Chrome Release Bot (LUCI) 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
..
BUILD.gn 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
DEPS 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
OWNERS 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
README.md 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
app_list_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
app_notification_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
app_setting_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
app_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
arc_package_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
autofill_offer_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
autofill_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
autofill_wallet_usage_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
bookmark_model_metadata.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
bookmark_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
client_commands.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
client_debug_info.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
contact_info_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
data_type_progress_marker.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
device_info_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
dictionary_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
encryption.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
entity_data.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
entity_data.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
entity_data_unittest.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
entity_metadata.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
entity_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
experiment_status.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
experiments_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
extension_setting_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
extension_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
favicon_image_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
favicon_tracking_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
gaia_password_reuse.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
get_updates_caller_info.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
history_delete_directive_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
history_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
history_status.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
local_trusted_vault.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
loopback_server.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
managed_user_setting_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
managed_user_shared_setting_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
managed_user_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
model_type_state.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
model_type_store_schema_descriptor.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
nigori_local_data.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
nigori_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
os_preference_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
os_priority_preference_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
password_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
persisted_entity_data.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
preference_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
printer_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
printers_authorization_server_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
priority_preference_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_enum_conversions.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_enum_conversions.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_enum_conversions_unittest.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_memory_estimations.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_memory_estimations.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_value_conversions.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_value_conversions.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_value_conversions_unittest.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
proto_visitors.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
protocol_sources.gni 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
reading_list_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
saved_tab_group_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
search_engine_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
security_event_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
send_tab_to_self_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
session_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sharing_message_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync_entity.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync_enums.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync_invalidations_payload.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync_protocol_error.cc 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
sync_protocol_error.h 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
synced_notification_app_info_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
synced_notification_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
test.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
theme_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
typed_url_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
unique_position.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
user_consent_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
user_consent_types.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
user_event_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
vault.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
web_app_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
webauthn_credential_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
wifi_configuration_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ
workspace_desk_specifics.proto 4762b62e7d Publish DEPS for 106.0.5249.13 1 gadu atpakaļ

README.md

Sync Protocol Style

General guidelines:

  • Follow the Protocol Buffers Style Guide
  • Follow the Proto Do’s and Don’ts (sorry, Googlers only).
  • Maintain local consistency.
  • Use proto2 syntax.
  • Always get a review from someone in the OWNERS file in this folder. Don’t use owners from higher-level folders, and never TBR changes!

Some specific guidelines on top of the general ones above, or just things that often come up:

  • Enum entries should be in ALL_CAPS (different from C++!), and for new code, the first entry should be a FOO_UNSPECIFIED = 0 one.
  • Timestamp fields must specify their epoch and unit in a suffix, in this format: _[unix|windows]_epoch_[seconds|millis|micros|nanos], e.g creation_time_unix_epoch_millis.
    • Many existing fields do not follow this format, and specify epoch/unit in a comment instead. Follow the format for all new fields, though!
  • Similarly, duration fields must specify their unit as _[minutes|seconds|millis|...].
  • Proto changes also require corresponding changes in proto_visitors.h and (where appropriate) in proto_enum_conversions.h/cc.
  • Backwards compatibility: In general, all changes must be fully backwards-compatible - consider that a single user might be running different versions of the browser simultaneously! Also note that Sync supports clients up to a few years old, so deprecating/removing an existing field is typically a multi-year process.
    • As one special case, renaming a field within a specifics message is generally safe (unless there are special server-side integrations that depend on the name). However, never rename fields anywhere outside of specifics.
  • Deprecating fields:
    • If the field is still accessed: Mark it as [deprecated = true]. This is the common case, since the browser typically needs to continue supporting the old field for backwards compatibility reasons.
    • If the field is not accessed anymore (i.e. no non-ancient clients depend on the field being populated anymore, all migration code has been retired, etc): Remove the field, and add reserved entries for both its name and its tag number.
  • Deprecating enum values: This is particularly tricky, especially if the default value is not a FOO_UNSPECIFIED one (see above). A common pattern is prepending DEPRECATED_ to the entry name.