app_test.go 100 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629
  1. // Copyright 2017 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package java
  15. import (
  16. "fmt"
  17. "path/filepath"
  18. "reflect"
  19. "sort"
  20. "strings"
  21. "testing"
  22. "github.com/google/blueprint/proptools"
  23. "android/soong/android"
  24. "android/soong/cc"
  25. "android/soong/dexpreopt"
  26. )
  27. // testApp runs tests using the prepareForJavaTest
  28. //
  29. // See testJava for an explanation as to how to stop using this deprecated method.
  30. //
  31. // deprecated
  32. func testApp(t *testing.T, bp string) *android.TestContext {
  33. t.Helper()
  34. result := prepareForJavaTest.RunTestWithBp(t, bp)
  35. return result.TestContext
  36. }
  37. func TestApp(t *testing.T) {
  38. resourceFiles := []string{
  39. "res/layout/layout.xml",
  40. "res/values/strings.xml",
  41. "res/values-en-rUS/strings.xml",
  42. }
  43. compiledResourceFiles := []string{
  44. "aapt2/res/layout_layout.xml.flat",
  45. "aapt2/res/values_strings.arsc.flat",
  46. "aapt2/res/values-en-rUS_strings.arsc.flat",
  47. }
  48. for _, moduleType := range []string{"android_app", "android_library"} {
  49. t.Run(moduleType, func(t *testing.T) {
  50. result := android.GroupFixturePreparers(
  51. prepareForJavaTest,
  52. android.FixtureModifyMockFS(func(fs android.MockFS) {
  53. for _, file := range resourceFiles {
  54. fs[file] = nil
  55. }
  56. }),
  57. ).RunTestWithBp(t, moduleType+` {
  58. name: "foo",
  59. srcs: ["a.java"],
  60. sdk_version: "current"
  61. }
  62. `)
  63. foo := result.ModuleForTests("foo", "android_common")
  64. var expectedLinkImplicits []string
  65. manifestFixer := foo.Output("manifest_fixer/AndroidManifest.xml")
  66. expectedLinkImplicits = append(expectedLinkImplicits, manifestFixer.Output.String())
  67. frameworkRes := result.ModuleForTests("framework-res", "android_common")
  68. expectedLinkImplicits = append(expectedLinkImplicits,
  69. frameworkRes.Output("package-res.apk").Output.String())
  70. // Test the mapping from input files to compiled output file names
  71. compile := foo.Output(compiledResourceFiles[0])
  72. android.AssertDeepEquals(t, "aapt2 compile inputs", resourceFiles, compile.Inputs.Strings())
  73. compiledResourceOutputs := compile.Outputs.Strings()
  74. sort.Strings(compiledResourceOutputs)
  75. expectedLinkImplicits = append(expectedLinkImplicits, compiledResourceOutputs...)
  76. list := foo.Output("aapt2/res.list")
  77. expectedLinkImplicits = append(expectedLinkImplicits, list.Output.String())
  78. // Check that the link rule uses
  79. res := result.ModuleForTests("foo", "android_common").Output("package-res.apk")
  80. android.AssertDeepEquals(t, "aapt2 link implicits", expectedLinkImplicits, res.Implicits.Strings())
  81. })
  82. }
  83. }
  84. func TestAppSplits(t *testing.T) {
  85. ctx := testApp(t, `
  86. android_app {
  87. name: "foo",
  88. srcs: ["a.java"],
  89. package_splits: ["v4", "v7,hdpi"],
  90. sdk_version: "current"
  91. }`)
  92. foo := ctx.ModuleForTests("foo", "android_common")
  93. expectedOutputs := []string{
  94. "out/soong/.intermediates/foo/android_common/foo.apk",
  95. "out/soong/.intermediates/foo/android_common/foo_v4.apk",
  96. "out/soong/.intermediates/foo/android_common/foo_v7_hdpi.apk",
  97. }
  98. for _, expectedOutput := range expectedOutputs {
  99. foo.Output(expectedOutput)
  100. }
  101. outputFiles, err := foo.Module().(*AndroidApp).OutputFiles("")
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. android.AssertPathsRelativeToTopEquals(t, `OutputFiles("")`, expectedOutputs, outputFiles)
  106. }
  107. func TestPlatformAPIs(t *testing.T) {
  108. testJava(t, `
  109. android_app {
  110. name: "foo",
  111. srcs: ["a.java"],
  112. platform_apis: true,
  113. }
  114. `)
  115. testJava(t, `
  116. android_app {
  117. name: "foo",
  118. srcs: ["a.java"],
  119. sdk_version: "current",
  120. }
  121. `)
  122. testJavaError(t, "This module has conflicting settings. sdk_version is empty, which means that this module is build against platform APIs. However platform_apis is not set to true", `
  123. android_app {
  124. name: "bar",
  125. srcs: ["b.java"],
  126. }
  127. `)
  128. testJavaError(t, "This module has conflicting settings. sdk_version is not empty, which means this module cannot use platform APIs. However platform_apis is set to true.", `
  129. android_app {
  130. name: "bar",
  131. srcs: ["b.java"],
  132. sdk_version: "system_current",
  133. platform_apis: true,
  134. }
  135. `)
  136. }
  137. func TestAndroidAppLinkType(t *testing.T) {
  138. testJava(t, `
  139. android_app {
  140. name: "foo",
  141. srcs: ["a.java"],
  142. libs: ["bar"],
  143. static_libs: ["baz"],
  144. platform_apis: true,
  145. }
  146. java_library {
  147. name: "bar",
  148. sdk_version: "current",
  149. srcs: ["b.java"],
  150. }
  151. android_library {
  152. name: "baz",
  153. sdk_version: "system_current",
  154. srcs: ["c.java"],
  155. }
  156. `)
  157. testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
  158. android_app {
  159. name: "foo",
  160. srcs: ["a.java"],
  161. libs: ["bar"],
  162. sdk_version: "current",
  163. static_libs: ["baz"],
  164. }
  165. java_library {
  166. name: "bar",
  167. sdk_version: "current",
  168. srcs: ["b.java"],
  169. }
  170. android_library {
  171. name: "baz",
  172. sdk_version: "system_current",
  173. srcs: ["c.java"],
  174. }
  175. `)
  176. testJava(t, `
  177. android_app {
  178. name: "foo",
  179. srcs: ["a.java"],
  180. libs: ["bar"],
  181. sdk_version: "system_current",
  182. static_libs: ["baz"],
  183. }
  184. java_library {
  185. name: "bar",
  186. sdk_version: "current",
  187. srcs: ["b.java"],
  188. }
  189. android_library {
  190. name: "baz",
  191. sdk_version: "system_current",
  192. srcs: ["c.java"],
  193. }
  194. `)
  195. testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
  196. android_app {
  197. name: "foo",
  198. srcs: ["a.java"],
  199. libs: ["bar"],
  200. sdk_version: "system_current",
  201. static_libs: ["baz"],
  202. }
  203. java_library {
  204. name: "bar",
  205. sdk_version: "current",
  206. srcs: ["b.java"],
  207. }
  208. android_library {
  209. name: "baz",
  210. srcs: ["c.java"],
  211. }
  212. `)
  213. }
  214. func TestUpdatableApps(t *testing.T) {
  215. testCases := []struct {
  216. name string
  217. bp string
  218. expectedError string
  219. }{
  220. {
  221. name: "Stable public SDK",
  222. bp: `android_app {
  223. name: "foo",
  224. srcs: ["a.java"],
  225. sdk_version: "29",
  226. min_sdk_version: "29",
  227. updatable: true,
  228. }`,
  229. },
  230. {
  231. name: "Stable system SDK",
  232. bp: `android_app {
  233. name: "foo",
  234. srcs: ["a.java"],
  235. sdk_version: "system_29",
  236. min_sdk_version: "29",
  237. updatable: true,
  238. }`,
  239. },
  240. {
  241. name: "Current public SDK",
  242. bp: `android_app {
  243. name: "foo",
  244. srcs: ["a.java"],
  245. sdk_version: "current",
  246. min_sdk_version: "29",
  247. updatable: true,
  248. }`,
  249. },
  250. {
  251. name: "Current system SDK",
  252. bp: `android_app {
  253. name: "foo",
  254. srcs: ["a.java"],
  255. sdk_version: "system_current",
  256. min_sdk_version: "29",
  257. updatable: true,
  258. }`,
  259. },
  260. {
  261. name: "Current module SDK",
  262. bp: `android_app {
  263. name: "foo",
  264. srcs: ["a.java"],
  265. sdk_version: "module_current",
  266. min_sdk_version: "29",
  267. updatable: true,
  268. }`,
  269. },
  270. {
  271. name: "Current core SDK",
  272. bp: `android_app {
  273. name: "foo",
  274. srcs: ["a.java"],
  275. sdk_version: "core_current",
  276. min_sdk_version: "29",
  277. updatable: true,
  278. }`,
  279. },
  280. {
  281. name: "No Platform APIs",
  282. bp: `android_app {
  283. name: "foo",
  284. srcs: ["a.java"],
  285. platform_apis: true,
  286. min_sdk_version: "29",
  287. updatable: true,
  288. }`,
  289. expectedError: "Updatable apps must use stable SDKs",
  290. },
  291. {
  292. name: "No Core Platform APIs",
  293. bp: `android_app {
  294. name: "foo",
  295. srcs: ["a.java"],
  296. sdk_version: "core_platform",
  297. min_sdk_version: "29",
  298. updatable: true,
  299. }`,
  300. expectedError: "Updatable apps must use stable SDKs",
  301. },
  302. {
  303. name: "No unspecified APIs",
  304. bp: `android_app {
  305. name: "foo",
  306. srcs: ["a.java"],
  307. updatable: true,
  308. min_sdk_version: "29",
  309. }`,
  310. expectedError: "Updatable apps must use stable SDK",
  311. },
  312. {
  313. name: "Must specify min_sdk_version",
  314. bp: `android_app {
  315. name: "app_without_min_sdk_version",
  316. srcs: ["a.java"],
  317. sdk_version: "29",
  318. updatable: true,
  319. }`,
  320. expectedError: "updatable apps must set min_sdk_version.",
  321. },
  322. }
  323. for _, test := range testCases {
  324. t.Run(test.name, func(t *testing.T) {
  325. errorHandler := android.FixtureExpectsNoErrors
  326. if test.expectedError != "" {
  327. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  328. }
  329. android.GroupFixturePreparers(
  330. prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{
  331. "29": {"foo"},
  332. })).
  333. ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, test.bp)
  334. })
  335. }
  336. }
  337. func TestUpdatableApps_TransitiveDepsShouldSetMinSdkVersion(t *testing.T) {
  338. testJavaError(t, `module "bar".*: should support min_sdk_version\(29\)`, cc.GatherRequiredDepsForTest(android.Android)+`
  339. android_app {
  340. name: "foo",
  341. srcs: ["a.java"],
  342. updatable: true,
  343. sdk_version: "current",
  344. min_sdk_version: "29",
  345. static_libs: ["bar"],
  346. }
  347. java_library {
  348. name: "bar",
  349. sdk_version: "current",
  350. }
  351. `)
  352. }
  353. func TestUpdatableApps_JniLibsShouldShouldSupportMinSdkVersion(t *testing.T) {
  354. testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  355. android_app {
  356. name: "foo",
  357. srcs: ["a.java"],
  358. updatable: true,
  359. sdk_version: "current",
  360. min_sdk_version: "current",
  361. jni_libs: ["libjni"],
  362. }
  363. cc_library {
  364. name: "libjni",
  365. stl: "none",
  366. system_shared_libs: [],
  367. sdk_version: "current",
  368. }
  369. `)
  370. }
  371. func TestUpdatableApps_JniLibShouldBeBuiltAgainstMinSdkVersion(t *testing.T) {
  372. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  373. android_app {
  374. name: "foo",
  375. srcs: ["a.java"],
  376. updatable: true,
  377. sdk_version: "current",
  378. min_sdk_version: "29",
  379. jni_libs: ["libjni"],
  380. }
  381. cc_library {
  382. name: "libjni",
  383. stl: "none",
  384. system_shared_libs: [],
  385. sdk_version: "current",
  386. min_sdk_version: "29",
  387. }
  388. `
  389. fs := map[string][]byte{
  390. "prebuilts/ndk/current/platforms/android-29/arch-arm64/usr/lib/crtbegin_so.o": nil,
  391. "prebuilts/ndk/current/platforms/android-29/arch-arm64/usr/lib/crtend_so.o": nil,
  392. "prebuilts/ndk/current/platforms/android-29/arch-arm/usr/lib/crtbegin_so.o": nil,
  393. "prebuilts/ndk/current/platforms/android-29/arch-arm/usr/lib/crtend_so.o": nil,
  394. }
  395. ctx, _ := testJavaWithFS(t, bp, fs)
  396. inputs := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_sdk_shared").Description("link").Implicits
  397. var crtbeginFound, crtendFound bool
  398. expectedCrtBegin := ctx.ModuleForTests("crtbegin_so",
  399. "android_arm64_armv8-a_sdk_29").Rule("noAddrSig").Output
  400. expectedCrtEnd := ctx.ModuleForTests("crtend_so",
  401. "android_arm64_armv8-a_sdk_29").Rule("noAddrSig").Output
  402. implicits := []string{}
  403. for _, input := range inputs {
  404. implicits = append(implicits, input.String())
  405. if strings.HasSuffix(input.String(), expectedCrtBegin.String()) {
  406. crtbeginFound = true
  407. } else if strings.HasSuffix(input.String(), expectedCrtEnd.String()) {
  408. crtendFound = true
  409. }
  410. }
  411. if !crtbeginFound {
  412. t.Error(fmt.Sprintf(
  413. "expected implicit with suffix %q, have the following implicits:\n%s",
  414. expectedCrtBegin, strings.Join(implicits, "\n")))
  415. }
  416. if !crtendFound {
  417. t.Error(fmt.Sprintf(
  418. "expected implicit with suffix %q, have the following implicits:\n%s",
  419. expectedCrtEnd, strings.Join(implicits, "\n")))
  420. }
  421. }
  422. func TestUpdatableApps_ErrorIfJniLibDoesntSupportMinSdkVersion(t *testing.T) {
  423. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  424. android_app {
  425. name: "foo",
  426. srcs: ["a.java"],
  427. updatable: true,
  428. sdk_version: "current",
  429. min_sdk_version: "29", // this APK should support 29
  430. jni_libs: ["libjni"],
  431. }
  432. cc_library {
  433. name: "libjni",
  434. stl: "none",
  435. sdk_version: "current",
  436. min_sdk_version: "current",
  437. }
  438. `
  439. testJavaError(t, `"libjni" .*: min_sdk_version\(current\) is higher than min_sdk_version\(29\)`, bp)
  440. }
  441. func TestUpdatableApps_ErrorIfDepMinSdkVersionIsHigher(t *testing.T) {
  442. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  443. android_app {
  444. name: "foo",
  445. srcs: ["a.java"],
  446. updatable: true,
  447. sdk_version: "current",
  448. min_sdk_version: "29", // this APK should support 29
  449. jni_libs: ["libjni"],
  450. }
  451. cc_library {
  452. name: "libjni",
  453. stl: "none",
  454. shared_libs: ["libbar"],
  455. system_shared_libs: [],
  456. sdk_version: "27",
  457. min_sdk_version: "27",
  458. }
  459. cc_library {
  460. name: "libbar",
  461. stl: "none",
  462. system_shared_libs: [],
  463. sdk_version: "current",
  464. min_sdk_version: "current",
  465. }
  466. `
  467. testJavaError(t, `"libjni" .*: links "libbar" built against newer API version "current"`, bp)
  468. }
  469. func TestResourceDirs(t *testing.T) {
  470. testCases := []struct {
  471. name string
  472. prop string
  473. resources []string
  474. }{
  475. {
  476. name: "no resource_dirs",
  477. prop: "",
  478. resources: []string{"res/res/values/strings.xml"},
  479. },
  480. {
  481. name: "resource_dirs",
  482. prop: `resource_dirs: ["res"]`,
  483. resources: []string{"res/res/values/strings.xml"},
  484. },
  485. {
  486. name: "empty resource_dirs",
  487. prop: `resource_dirs: []`,
  488. resources: nil,
  489. },
  490. }
  491. fs := android.MockFS{
  492. "res/res/values/strings.xml": nil,
  493. }
  494. bp := `
  495. android_app {
  496. name: "foo",
  497. sdk_version: "current",
  498. %s
  499. }
  500. `
  501. for _, testCase := range testCases {
  502. t.Run(testCase.name, func(t *testing.T) {
  503. result := android.GroupFixturePreparers(
  504. PrepareForTestWithJavaDefaultModules,
  505. PrepareForTestWithOverlayBuildComponents,
  506. fs.AddToFixture(),
  507. ).RunTestWithBp(t, fmt.Sprintf(bp, testCase.prop))
  508. module := result.ModuleForTests("foo", "android_common")
  509. resourceList := module.MaybeOutput("aapt2/res.list")
  510. var resources []string
  511. if resourceList.Rule != nil {
  512. for _, compiledResource := range resourceList.Inputs.Strings() {
  513. resources = append(resources, module.Output(compiledResource).Inputs.Strings()...)
  514. }
  515. }
  516. android.AssertDeepEquals(t, "resource files", testCase.resources, resources)
  517. })
  518. }
  519. }
  520. func TestLibraryAssets(t *testing.T) {
  521. bp := `
  522. android_app {
  523. name: "foo",
  524. sdk_version: "current",
  525. static_libs: ["lib1", "lib2", "lib3"],
  526. }
  527. android_library {
  528. name: "lib1",
  529. sdk_version: "current",
  530. asset_dirs: ["assets_a"],
  531. }
  532. android_library {
  533. name: "lib2",
  534. sdk_version: "current",
  535. }
  536. android_library {
  537. name: "lib3",
  538. sdk_version: "current",
  539. static_libs: ["lib4"],
  540. }
  541. android_library {
  542. name: "lib4",
  543. sdk_version: "current",
  544. asset_dirs: ["assets_b"],
  545. }
  546. `
  547. testCases := []struct {
  548. name string
  549. assetFlag string
  550. assetPackages []string
  551. }{
  552. {
  553. name: "foo",
  554. // lib1 has its own asset. lib3 doesn't have any, but provides lib4's transitively.
  555. assetPackages: []string{
  556. "out/soong/.intermediates/foo/android_common/aapt2/package-res.apk",
  557. "out/soong/.intermediates/lib1/android_common/assets.zip",
  558. "out/soong/.intermediates/lib3/android_common/assets.zip",
  559. },
  560. },
  561. {
  562. name: "lib1",
  563. assetFlag: "-A assets_a",
  564. },
  565. {
  566. name: "lib2",
  567. },
  568. {
  569. name: "lib3",
  570. assetPackages: []string{
  571. "out/soong/.intermediates/lib3/android_common/aapt2/package-res.apk",
  572. "out/soong/.intermediates/lib4/android_common/assets.zip",
  573. },
  574. },
  575. {
  576. name: "lib4",
  577. assetFlag: "-A assets_b",
  578. },
  579. }
  580. ctx := testApp(t, bp)
  581. for _, test := range testCases {
  582. t.Run(test.name, func(t *testing.T) {
  583. m := ctx.ModuleForTests(test.name, "android_common")
  584. // Check asset flag in aapt2 link flags
  585. var aapt2link android.TestingBuildParams
  586. if len(test.assetPackages) > 0 {
  587. aapt2link = m.Output("aapt2/package-res.apk")
  588. } else {
  589. aapt2link = m.Output("package-res.apk")
  590. }
  591. aapt2link = aapt2link
  592. aapt2Flags := aapt2link.Args["flags"]
  593. if test.assetFlag != "" {
  594. android.AssertStringDoesContain(t, "asset flag", aapt2Flags, test.assetFlag)
  595. } else {
  596. android.AssertStringDoesNotContain(t, "aapt2 link flags", aapt2Flags, " -A ")
  597. }
  598. // Check asset merge rule.
  599. if len(test.assetPackages) > 0 {
  600. mergeAssets := m.Output("package-res.apk")
  601. android.AssertPathsRelativeToTopEquals(t, "mergeAssets inputs", test.assetPackages, mergeAssets.Inputs)
  602. }
  603. })
  604. }
  605. }
  606. func TestAppJavaResources(t *testing.T) {
  607. bp := `
  608. android_app {
  609. name: "foo",
  610. sdk_version: "current",
  611. java_resources: ["resources/a"],
  612. srcs: ["a.java"],
  613. }
  614. android_app {
  615. name: "bar",
  616. sdk_version: "current",
  617. java_resources: ["resources/a"],
  618. }
  619. `
  620. ctx := testApp(t, bp)
  621. foo := ctx.ModuleForTests("foo", "android_common")
  622. fooResources := foo.Output("res/foo.jar")
  623. fooDexJar := foo.Output("dex-withres/foo.jar")
  624. fooDexJarAligned := foo.Output("dex-withres-aligned/foo.jar")
  625. fooApk := foo.Rule("combineApk")
  626. if g, w := fooDexJar.Inputs.Strings(), fooResources.Output.String(); !android.InList(w, g) {
  627. t.Errorf("expected resource jar %q in foo dex jar inputs %q", w, g)
  628. }
  629. if g, w := fooDexJarAligned.Input.String(), fooDexJar.Output.String(); g != w {
  630. t.Errorf("expected dex jar %q in foo aligned dex jar inputs %q", w, g)
  631. }
  632. if g, w := fooApk.Inputs.Strings(), fooDexJarAligned.Output.String(); !android.InList(w, g) {
  633. t.Errorf("expected aligned dex jar %q in foo apk inputs %q", w, g)
  634. }
  635. bar := ctx.ModuleForTests("bar", "android_common")
  636. barResources := bar.Output("res/bar.jar")
  637. barApk := bar.Rule("combineApk")
  638. if g, w := barApk.Inputs.Strings(), barResources.Output.String(); !android.InList(w, g) {
  639. t.Errorf("expected resources jar %q in bar apk inputs %q", w, g)
  640. }
  641. }
  642. func TestAndroidResources(t *testing.T) {
  643. testCases := []struct {
  644. name string
  645. enforceRROTargets []string
  646. enforceRROExcludedOverlays []string
  647. resourceFiles map[string][]string
  648. overlayFiles map[string][]string
  649. rroDirs map[string][]string
  650. }{
  651. {
  652. name: "no RRO",
  653. enforceRROTargets: nil,
  654. enforceRROExcludedOverlays: nil,
  655. resourceFiles: map[string][]string{
  656. "foo": nil,
  657. "bar": {"bar/res/res/values/strings.xml"},
  658. "lib": nil,
  659. "lib2": {"lib2/res/res/values/strings.xml"},
  660. },
  661. overlayFiles: map[string][]string{
  662. "foo": {
  663. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  664. "out/soong/.intermediates/lib/android_common/package-res.apk",
  665. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  666. "foo/res/res/values/strings.xml",
  667. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  668. "device/vendor/blah/overlay/foo/res/values/strings.xml",
  669. "product/vendor/blah/overlay/foo/res/values/strings.xml",
  670. },
  671. "bar": {
  672. "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
  673. "device/vendor/blah/overlay/bar/res/values/strings.xml",
  674. },
  675. "lib": {
  676. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  677. "lib/res/res/values/strings.xml",
  678. "device/vendor/blah/overlay/lib/res/values/strings.xml",
  679. },
  680. },
  681. rroDirs: map[string][]string{
  682. "foo": nil,
  683. "bar": nil,
  684. },
  685. },
  686. {
  687. name: "enforce RRO on foo",
  688. enforceRROTargets: []string{"foo"},
  689. enforceRROExcludedOverlays: []string{"device/vendor/blah/static_overlay"},
  690. resourceFiles: map[string][]string{
  691. "foo": nil,
  692. "bar": {"bar/res/res/values/strings.xml"},
  693. "lib": nil,
  694. "lib2": {"lib2/res/res/values/strings.xml"},
  695. },
  696. overlayFiles: map[string][]string{
  697. "foo": {
  698. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  699. "out/soong/.intermediates/lib/android_common/package-res.apk",
  700. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  701. "foo/res/res/values/strings.xml",
  702. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  703. },
  704. "bar": {
  705. "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
  706. "device/vendor/blah/overlay/bar/res/values/strings.xml",
  707. },
  708. "lib": {
  709. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  710. "lib/res/res/values/strings.xml",
  711. },
  712. },
  713. rroDirs: map[string][]string{
  714. "foo": {
  715. "device:device/vendor/blah/overlay/foo/res",
  716. "product:product/vendor/blah/overlay/foo/res",
  717. "device:device/vendor/blah/overlay/lib/res",
  718. },
  719. "bar": nil,
  720. "lib": {"device:device/vendor/blah/overlay/lib/res"},
  721. },
  722. },
  723. {
  724. name: "enforce RRO on all",
  725. enforceRROTargets: []string{"*"},
  726. enforceRROExcludedOverlays: []string{
  727. // Excluding specific apps/res directories also allowed.
  728. "device/vendor/blah/static_overlay/foo",
  729. "device/vendor/blah/static_overlay/bar/res",
  730. },
  731. resourceFiles: map[string][]string{
  732. "foo": nil,
  733. "bar": {"bar/res/res/values/strings.xml"},
  734. "lib": nil,
  735. "lib2": {"lib2/res/res/values/strings.xml"},
  736. },
  737. overlayFiles: map[string][]string{
  738. "foo": {
  739. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  740. "out/soong/.intermediates/lib/android_common/package-res.apk",
  741. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  742. "foo/res/res/values/strings.xml",
  743. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  744. },
  745. "bar": {"device/vendor/blah/static_overlay/bar/res/values/strings.xml"},
  746. "lib": {
  747. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  748. "lib/res/res/values/strings.xml",
  749. },
  750. },
  751. rroDirs: map[string][]string{
  752. "foo": {
  753. "device:device/vendor/blah/overlay/foo/res",
  754. "product:product/vendor/blah/overlay/foo/res",
  755. // Lib dep comes after the direct deps
  756. "device:device/vendor/blah/overlay/lib/res",
  757. },
  758. "bar": {"device:device/vendor/blah/overlay/bar/res"},
  759. "lib": {"device:device/vendor/blah/overlay/lib/res"},
  760. },
  761. },
  762. }
  763. deviceResourceOverlays := []string{
  764. "device/vendor/blah/overlay",
  765. "device/vendor/blah/overlay2",
  766. "device/vendor/blah/static_overlay",
  767. }
  768. productResourceOverlays := []string{
  769. "product/vendor/blah/overlay",
  770. }
  771. fs := android.MockFS{
  772. "foo/res/res/values/strings.xml": nil,
  773. "bar/res/res/values/strings.xml": nil,
  774. "lib/res/res/values/strings.xml": nil,
  775. "lib2/res/res/values/strings.xml": nil,
  776. "device/vendor/blah/overlay/foo/res/values/strings.xml": nil,
  777. "device/vendor/blah/overlay/bar/res/values/strings.xml": nil,
  778. "device/vendor/blah/overlay/lib/res/values/strings.xml": nil,
  779. "device/vendor/blah/static_overlay/foo/res/values/strings.xml": nil,
  780. "device/vendor/blah/static_overlay/bar/res/values/strings.xml": nil,
  781. "device/vendor/blah/overlay2/res/values/strings.xml": nil,
  782. "product/vendor/blah/overlay/foo/res/values/strings.xml": nil,
  783. }
  784. bp := `
  785. android_app {
  786. name: "foo",
  787. sdk_version: "current",
  788. resource_dirs: ["foo/res"],
  789. static_libs: ["lib", "lib3"],
  790. }
  791. android_app {
  792. name: "bar",
  793. sdk_version: "current",
  794. resource_dirs: ["bar/res"],
  795. }
  796. android_library {
  797. name: "lib",
  798. sdk_version: "current",
  799. resource_dirs: ["lib/res"],
  800. static_libs: ["lib2"],
  801. }
  802. android_library {
  803. name: "lib2",
  804. sdk_version: "current",
  805. resource_dirs: ["lib2/res"],
  806. }
  807. // This library has the same resources as lib (should not lead to dupe RROs)
  808. android_library {
  809. name: "lib3",
  810. sdk_version: "current",
  811. resource_dirs: ["lib/res"]
  812. }
  813. `
  814. for _, testCase := range testCases {
  815. t.Run(testCase.name, func(t *testing.T) {
  816. result := android.GroupFixturePreparers(
  817. PrepareForTestWithJavaDefaultModules,
  818. PrepareForTestWithOverlayBuildComponents,
  819. fs.AddToFixture(),
  820. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  821. variables.DeviceResourceOverlays = deviceResourceOverlays
  822. variables.ProductResourceOverlays = productResourceOverlays
  823. if testCase.enforceRROTargets != nil {
  824. variables.EnforceRROTargets = testCase.enforceRROTargets
  825. }
  826. if testCase.enforceRROExcludedOverlays != nil {
  827. variables.EnforceRROExcludedOverlays = testCase.enforceRROExcludedOverlays
  828. }
  829. }),
  830. ).RunTestWithBp(t, bp)
  831. resourceListToFiles := func(module android.TestingModule, list []string) (files []string) {
  832. for _, o := range list {
  833. res := module.MaybeOutput(o)
  834. if res.Rule != nil {
  835. // If the overlay is compiled as part of this module (i.e. a .arsc.flat file),
  836. // verify the inputs to the .arsc.flat rule.
  837. files = append(files, res.Inputs.Strings()...)
  838. } else {
  839. // Otherwise, verify the full path to the output of the other module
  840. files = append(files, o)
  841. }
  842. }
  843. return files
  844. }
  845. getResources := func(moduleName string) (resourceFiles, overlayFiles, rroDirs []string) {
  846. module := result.ModuleForTests(moduleName, "android_common")
  847. resourceList := module.MaybeOutput("aapt2/res.list")
  848. if resourceList.Rule != nil {
  849. resourceFiles = resourceListToFiles(module, android.PathsRelativeToTop(resourceList.Inputs))
  850. }
  851. overlayList := module.MaybeOutput("aapt2/overlay.list")
  852. if overlayList.Rule != nil {
  853. overlayFiles = resourceListToFiles(module, android.PathsRelativeToTop(overlayList.Inputs))
  854. }
  855. for _, d := range module.Module().(AndroidLibraryDependency).ExportedRRODirs() {
  856. var prefix string
  857. if d.overlayType == device {
  858. prefix = "device:"
  859. } else if d.overlayType == product {
  860. prefix = "product:"
  861. } else {
  862. t.Fatalf("Unexpected overlayType %d", d.overlayType)
  863. }
  864. rroDirs = append(rroDirs, prefix+android.PathRelativeToTop(d.path))
  865. }
  866. return resourceFiles, overlayFiles, rroDirs
  867. }
  868. modules := []string{"foo", "bar", "lib", "lib2"}
  869. for _, module := range modules {
  870. resourceFiles, overlayFiles, rroDirs := getResources(module)
  871. if !reflect.DeepEqual(resourceFiles, testCase.resourceFiles[module]) {
  872. t.Errorf("expected %s resource files:\n %#v\n got:\n %#v",
  873. module, testCase.resourceFiles[module], resourceFiles)
  874. }
  875. if !reflect.DeepEqual(overlayFiles, testCase.overlayFiles[module]) {
  876. t.Errorf("expected %s overlay files:\n %#v\n got:\n %#v",
  877. module, testCase.overlayFiles[module], overlayFiles)
  878. }
  879. if !reflect.DeepEqual(rroDirs, testCase.rroDirs[module]) {
  880. t.Errorf("expected %s rroDirs: %#v\n got:\n %#v",
  881. module, testCase.rroDirs[module], rroDirs)
  882. }
  883. }
  884. })
  885. }
  886. }
  887. func checkSdkVersion(t *testing.T, result *android.TestResult, expectedSdkVersion string) {
  888. foo := result.ModuleForTests("foo", "android_common")
  889. link := foo.Output("package-res.apk")
  890. linkFlags := strings.Split(link.Args["flags"], " ")
  891. min := android.IndexList("--min-sdk-version", linkFlags)
  892. target := android.IndexList("--target-sdk-version", linkFlags)
  893. if min == -1 || target == -1 || min == len(linkFlags)-1 || target == len(linkFlags)-1 {
  894. t.Fatalf("missing --min-sdk-version or --target-sdk-version in link flags: %q", linkFlags)
  895. }
  896. gotMinSdkVersion := linkFlags[min+1]
  897. gotTargetSdkVersion := linkFlags[target+1]
  898. android.AssertStringEquals(t, "incorrect --min-sdk-version", expectedSdkVersion, gotMinSdkVersion)
  899. android.AssertStringEquals(t, "incorrect --target-sdk-version", expectedSdkVersion, gotTargetSdkVersion)
  900. }
  901. func TestAppSdkVersion(t *testing.T) {
  902. testCases := []struct {
  903. name string
  904. sdkVersion string
  905. platformSdkInt int
  906. platformSdkCodename string
  907. platformSdkFinal bool
  908. minSdkVersionBp string
  909. expectedMinSdkVersion string
  910. platformApis bool
  911. activeCodenames []string
  912. }{
  913. {
  914. name: "current final SDK",
  915. sdkVersion: "current",
  916. platformSdkInt: 27,
  917. platformSdkCodename: "REL",
  918. platformSdkFinal: true,
  919. expectedMinSdkVersion: "27",
  920. },
  921. {
  922. name: "current non-final SDK",
  923. sdkVersion: "current",
  924. platformSdkInt: 27,
  925. platformSdkCodename: "OMR1",
  926. platformSdkFinal: false,
  927. expectedMinSdkVersion: "OMR1",
  928. activeCodenames: []string{"OMR1"},
  929. },
  930. {
  931. name: "default final SDK",
  932. sdkVersion: "",
  933. platformApis: true,
  934. platformSdkInt: 27,
  935. platformSdkCodename: "REL",
  936. platformSdkFinal: true,
  937. expectedMinSdkVersion: "27",
  938. },
  939. {
  940. name: "default non-final SDK",
  941. sdkVersion: "",
  942. platformApis: true,
  943. platformSdkInt: 27,
  944. platformSdkCodename: "OMR1",
  945. platformSdkFinal: false,
  946. expectedMinSdkVersion: "OMR1",
  947. activeCodenames: []string{"OMR1"},
  948. },
  949. {
  950. name: "14",
  951. sdkVersion: "14",
  952. expectedMinSdkVersion: "14",
  953. platformSdkCodename: "S",
  954. activeCodenames: []string{"S"},
  955. },
  956. {
  957. name: "two active SDKs",
  958. sdkVersion: "module_current",
  959. minSdkVersionBp: "UpsideDownCake",
  960. expectedMinSdkVersion: "UpsideDownCake", // And not VanillaIceCream
  961. platformSdkCodename: "VanillaIceCream",
  962. activeCodenames: []string{"UpsideDownCake", "VanillaIceCream"},
  963. },
  964. }
  965. for _, moduleType := range []string{"android_app", "android_library"} {
  966. for _, test := range testCases {
  967. t.Run(moduleType+" "+test.name, func(t *testing.T) {
  968. platformApiProp := ""
  969. if test.platformApis {
  970. platformApiProp = "platform_apis: true,"
  971. }
  972. minSdkVersionProp := ""
  973. if test.minSdkVersionBp != "" {
  974. minSdkVersionProp = fmt.Sprintf(` min_sdk_version: "%s",`, test.minSdkVersionBp)
  975. }
  976. bp := fmt.Sprintf(`%s {
  977. name: "foo",
  978. srcs: ["a.java"],
  979. sdk_version: "%s",
  980. %s
  981. %s
  982. }`, moduleType, test.sdkVersion, platformApiProp, minSdkVersionProp)
  983. result := android.GroupFixturePreparers(
  984. prepareForJavaTest,
  985. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  986. variables.Platform_sdk_version = &test.platformSdkInt
  987. variables.Platform_sdk_codename = &test.platformSdkCodename
  988. variables.Platform_version_active_codenames = test.activeCodenames
  989. variables.Platform_sdk_final = &test.platformSdkFinal
  990. }),
  991. FixtureWithPrebuiltApis(map[string][]string{
  992. "14": {"foo"},
  993. }),
  994. ).RunTestWithBp(t, bp)
  995. checkSdkVersion(t, result, test.expectedMinSdkVersion)
  996. })
  997. }
  998. }
  999. }
  1000. func TestVendorAppSdkVersion(t *testing.T) {
  1001. testCases := []struct {
  1002. name string
  1003. sdkVersion string
  1004. platformSdkInt int
  1005. platformSdkCodename string
  1006. platformSdkFinal bool
  1007. deviceCurrentApiLevelForVendorModules string
  1008. expectedMinSdkVersion string
  1009. }{
  1010. {
  1011. name: "current final SDK",
  1012. sdkVersion: "current",
  1013. platformSdkInt: 29,
  1014. platformSdkCodename: "REL",
  1015. platformSdkFinal: true,
  1016. deviceCurrentApiLevelForVendorModules: "29",
  1017. expectedMinSdkVersion: "29",
  1018. },
  1019. {
  1020. name: "current final SDK",
  1021. sdkVersion: "current",
  1022. platformSdkInt: 29,
  1023. platformSdkCodename: "REL",
  1024. platformSdkFinal: true,
  1025. deviceCurrentApiLevelForVendorModules: "28",
  1026. expectedMinSdkVersion: "28",
  1027. },
  1028. {
  1029. name: "current final SDK",
  1030. sdkVersion: "current",
  1031. platformSdkInt: 29,
  1032. platformSdkCodename: "Q",
  1033. platformSdkFinal: false,
  1034. deviceCurrentApiLevelForVendorModules: "28",
  1035. expectedMinSdkVersion: "28",
  1036. },
  1037. }
  1038. for _, moduleType := range []string{"android_app", "android_library"} {
  1039. for _, sdkKind := range []string{"", "system_"} {
  1040. for _, test := range testCases {
  1041. t.Run(moduleType+" "+test.name, func(t *testing.T) {
  1042. bp := fmt.Sprintf(`%s {
  1043. name: "foo",
  1044. srcs: ["a.java"],
  1045. sdk_version: "%s%s",
  1046. vendor: true,
  1047. }`, moduleType, sdkKind, test.sdkVersion)
  1048. result := android.GroupFixturePreparers(
  1049. prepareForJavaTest,
  1050. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1051. variables.Platform_sdk_version = &test.platformSdkInt
  1052. variables.Platform_sdk_codename = &test.platformSdkCodename
  1053. variables.Platform_sdk_final = &test.platformSdkFinal
  1054. variables.DeviceCurrentApiLevelForVendorModules = &test.deviceCurrentApiLevelForVendorModules
  1055. variables.DeviceSystemSdkVersions = []string{"28", "29"}
  1056. }),
  1057. FixtureWithPrebuiltApis(map[string][]string{
  1058. "28": {"foo"},
  1059. "29": {"foo"},
  1060. "current": {"foo"},
  1061. }),
  1062. ).RunTestWithBp(t, bp)
  1063. checkSdkVersion(t, result, test.expectedMinSdkVersion)
  1064. })
  1065. }
  1066. }
  1067. }
  1068. }
  1069. func TestJNIABI(t *testing.T) {
  1070. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1071. cc_library {
  1072. name: "libjni",
  1073. system_shared_libs: [],
  1074. sdk_version: "current",
  1075. stl: "none",
  1076. }
  1077. android_test {
  1078. name: "test",
  1079. sdk_version: "core_platform",
  1080. jni_libs: ["libjni"],
  1081. }
  1082. android_test {
  1083. name: "test_first",
  1084. sdk_version: "core_platform",
  1085. compile_multilib: "first",
  1086. jni_libs: ["libjni"],
  1087. }
  1088. android_test {
  1089. name: "test_both",
  1090. sdk_version: "core_platform",
  1091. compile_multilib: "both",
  1092. jni_libs: ["libjni"],
  1093. }
  1094. android_test {
  1095. name: "test_32",
  1096. sdk_version: "core_platform",
  1097. compile_multilib: "32",
  1098. jni_libs: ["libjni"],
  1099. }
  1100. android_test {
  1101. name: "test_64",
  1102. sdk_version: "core_platform",
  1103. compile_multilib: "64",
  1104. jni_libs: ["libjni"],
  1105. }
  1106. `)
  1107. testCases := []struct {
  1108. name string
  1109. abis []string
  1110. }{
  1111. {"test", []string{"arm64-v8a"}},
  1112. {"test_first", []string{"arm64-v8a"}},
  1113. {"test_both", []string{"arm64-v8a", "armeabi-v7a"}},
  1114. {"test_32", []string{"armeabi-v7a"}},
  1115. {"test_64", []string{"arm64-v8a"}},
  1116. }
  1117. for _, test := range testCases {
  1118. t.Run(test.name, func(t *testing.T) {
  1119. app := ctx.ModuleForTests(test.name, "android_common")
  1120. jniLibZip := app.Output(jniJarOutputPathString)
  1121. var abis []string
  1122. args := strings.Fields(jniLibZip.Args["jarArgs"])
  1123. for i := 0; i < len(args); i++ {
  1124. if args[i] == "-P" {
  1125. abis = append(abis, filepath.Base(args[i+1]))
  1126. i++
  1127. }
  1128. }
  1129. if !reflect.DeepEqual(abis, test.abis) {
  1130. t.Errorf("want abis %v, got %v", test.abis, abis)
  1131. }
  1132. })
  1133. }
  1134. }
  1135. func TestAppSdkVersionByPartition(t *testing.T) {
  1136. testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
  1137. android_app {
  1138. name: "foo",
  1139. srcs: ["a.java"],
  1140. vendor: true,
  1141. platform_apis: true,
  1142. }
  1143. `)
  1144. testJava(t, `
  1145. android_app {
  1146. name: "bar",
  1147. srcs: ["b.java"],
  1148. platform_apis: true,
  1149. }
  1150. `)
  1151. for _, enforce := range []bool{true, false} {
  1152. bp := `
  1153. android_app {
  1154. name: "foo",
  1155. srcs: ["a.java"],
  1156. product_specific: true,
  1157. platform_apis: true,
  1158. }
  1159. `
  1160. errorHandler := android.FixtureExpectsNoErrors
  1161. if enforce {
  1162. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
  1163. }
  1164. android.GroupFixturePreparers(
  1165. PrepareForTestWithJavaDefaultModules,
  1166. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1167. variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
  1168. }),
  1169. ).
  1170. ExtendWithErrorHandler(errorHandler).
  1171. RunTestWithBp(t, bp)
  1172. }
  1173. }
  1174. func TestJNIPackaging(t *testing.T) {
  1175. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1176. cc_library {
  1177. name: "libjni",
  1178. system_shared_libs: [],
  1179. stl: "none",
  1180. sdk_version: "current",
  1181. }
  1182. android_app {
  1183. name: "app",
  1184. jni_libs: ["libjni"],
  1185. sdk_version: "current",
  1186. }
  1187. android_app {
  1188. name: "app_noembed",
  1189. jni_libs: ["libjni"],
  1190. use_embedded_native_libs: false,
  1191. sdk_version: "current",
  1192. }
  1193. android_app {
  1194. name: "app_embed",
  1195. jni_libs: ["libjni"],
  1196. use_embedded_native_libs: true,
  1197. sdk_version: "current",
  1198. }
  1199. android_test {
  1200. name: "test",
  1201. sdk_version: "current",
  1202. jni_libs: ["libjni"],
  1203. }
  1204. android_test {
  1205. name: "test_noembed",
  1206. sdk_version: "current",
  1207. jni_libs: ["libjni"],
  1208. use_embedded_native_libs: false,
  1209. }
  1210. android_test_helper_app {
  1211. name: "test_helper",
  1212. sdk_version: "current",
  1213. jni_libs: ["libjni"],
  1214. }
  1215. android_test_helper_app {
  1216. name: "test_helper_noembed",
  1217. sdk_version: "current",
  1218. jni_libs: ["libjni"],
  1219. use_embedded_native_libs: false,
  1220. }
  1221. `)
  1222. testCases := []struct {
  1223. name string
  1224. packaged bool
  1225. compressed bool
  1226. }{
  1227. {"app", false, false},
  1228. {"app_noembed", false, false},
  1229. {"app_embed", true, false},
  1230. {"test", true, false},
  1231. {"test_noembed", true, true},
  1232. {"test_helper", true, false},
  1233. {"test_helper_noembed", true, true},
  1234. }
  1235. for _, test := range testCases {
  1236. t.Run(test.name, func(t *testing.T) {
  1237. app := ctx.ModuleForTests(test.name, "android_common")
  1238. jniLibZip := app.MaybeOutput(jniJarOutputPathString)
  1239. if g, w := (jniLibZip.Rule != nil), test.packaged; g != w {
  1240. t.Errorf("expected jni packaged %v, got %v", w, g)
  1241. }
  1242. if jniLibZip.Rule != nil {
  1243. if g, w := !strings.Contains(jniLibZip.Args["jarArgs"], "-L 0"), test.compressed; g != w {
  1244. t.Errorf("expected jni compressed %v, got %v", w, g)
  1245. }
  1246. if !strings.Contains(jniLibZip.Implicits[0].String(), "_sdk_") {
  1247. t.Errorf("expected input %q to use sdk variant", jniLibZip.Implicits[0].String())
  1248. }
  1249. }
  1250. })
  1251. }
  1252. }
  1253. func TestJNISDK(t *testing.T) {
  1254. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1255. cc_library {
  1256. name: "libjni",
  1257. system_shared_libs: [],
  1258. stl: "none",
  1259. sdk_version: "current",
  1260. }
  1261. android_test {
  1262. name: "app_platform",
  1263. jni_libs: ["libjni"],
  1264. platform_apis: true,
  1265. }
  1266. android_test {
  1267. name: "app_sdk",
  1268. jni_libs: ["libjni"],
  1269. sdk_version: "current",
  1270. }
  1271. android_test {
  1272. name: "app_force_platform",
  1273. jni_libs: ["libjni"],
  1274. sdk_version: "current",
  1275. jni_uses_platform_apis: true,
  1276. }
  1277. android_test {
  1278. name: "app_force_sdk",
  1279. jni_libs: ["libjni"],
  1280. platform_apis: true,
  1281. jni_uses_sdk_apis: true,
  1282. }
  1283. cc_library {
  1284. name: "libvendorjni",
  1285. system_shared_libs: [],
  1286. stl: "none",
  1287. vendor: true,
  1288. }
  1289. android_test {
  1290. name: "app_vendor",
  1291. jni_libs: ["libvendorjni"],
  1292. sdk_version: "current",
  1293. vendor: true,
  1294. }
  1295. `)
  1296. testCases := []struct {
  1297. name string
  1298. sdkJNI bool
  1299. vendorJNI bool
  1300. }{
  1301. {name: "app_platform"},
  1302. {name: "app_sdk", sdkJNI: true},
  1303. {name: "app_force_platform"},
  1304. {name: "app_force_sdk", sdkJNI: true},
  1305. {name: "app_vendor", vendorJNI: true},
  1306. }
  1307. platformJNI := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_shared").
  1308. Output("libjni.so").Output.String()
  1309. sdkJNI := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_sdk_shared").
  1310. Output("libjni.so").Output.String()
  1311. vendorJNI := ctx.ModuleForTests("libvendorjni", "android_arm64_armv8-a_shared").
  1312. Output("libvendorjni.so").Output.String()
  1313. for _, test := range testCases {
  1314. t.Run(test.name, func(t *testing.T) {
  1315. app := ctx.ModuleForTests(test.name, "android_common")
  1316. jniLibZip := app.MaybeOutput(jniJarOutputPathString)
  1317. if len(jniLibZip.Implicits) != 1 {
  1318. t.Fatalf("expected exactly one jni library, got %q", jniLibZip.Implicits.Strings())
  1319. }
  1320. gotJNI := jniLibZip.Implicits[0].String()
  1321. if test.sdkJNI {
  1322. if gotJNI != sdkJNI {
  1323. t.Errorf("expected SDK JNI library %q, got %q", sdkJNI, gotJNI)
  1324. }
  1325. } else if test.vendorJNI {
  1326. if gotJNI != vendorJNI {
  1327. t.Errorf("expected platform JNI library %q, got %q", vendorJNI, gotJNI)
  1328. }
  1329. } else {
  1330. if gotJNI != platformJNI {
  1331. t.Errorf("expected platform JNI library %q, got %q", platformJNI, gotJNI)
  1332. }
  1333. }
  1334. })
  1335. }
  1336. t.Run("jni_uses_platform_apis_error", func(t *testing.T) {
  1337. testJavaError(t, `jni_uses_platform_apis: can only be set for modules that set sdk_version`, `
  1338. android_test {
  1339. name: "app_platform",
  1340. platform_apis: true,
  1341. jni_uses_platform_apis: true,
  1342. }
  1343. `)
  1344. })
  1345. t.Run("jni_uses_sdk_apis_error", func(t *testing.T) {
  1346. testJavaError(t, `jni_uses_sdk_apis: can only be set for modules that do not set sdk_version`, `
  1347. android_test {
  1348. name: "app_sdk",
  1349. sdk_version: "current",
  1350. jni_uses_sdk_apis: true,
  1351. }
  1352. `)
  1353. })
  1354. }
  1355. func TestCertificates(t *testing.T) {
  1356. testCases := []struct {
  1357. name string
  1358. bp string
  1359. allowMissingDependencies bool
  1360. certificateOverride string
  1361. expectedCertSigningFlags string
  1362. expectedCertificate string
  1363. }{
  1364. {
  1365. name: "default",
  1366. bp: `
  1367. android_app {
  1368. name: "foo",
  1369. srcs: ["a.java"],
  1370. sdk_version: "current",
  1371. }
  1372. `,
  1373. certificateOverride: "",
  1374. expectedCertSigningFlags: "",
  1375. expectedCertificate: "build/make/target/product/security/testkey",
  1376. },
  1377. {
  1378. name: "module certificate property",
  1379. bp: `
  1380. android_app {
  1381. name: "foo",
  1382. srcs: ["a.java"],
  1383. certificate: ":new_certificate",
  1384. sdk_version: "current",
  1385. }
  1386. android_app_certificate {
  1387. name: "new_certificate",
  1388. certificate: "cert/new_cert",
  1389. }
  1390. `,
  1391. certificateOverride: "",
  1392. expectedCertSigningFlags: "",
  1393. expectedCertificate: "cert/new_cert",
  1394. },
  1395. {
  1396. name: "path certificate property",
  1397. bp: `
  1398. android_app {
  1399. name: "foo",
  1400. srcs: ["a.java"],
  1401. certificate: "expiredkey",
  1402. sdk_version: "current",
  1403. }
  1404. `,
  1405. certificateOverride: "",
  1406. expectedCertSigningFlags: "",
  1407. expectedCertificate: "build/make/target/product/security/expiredkey",
  1408. },
  1409. {
  1410. name: "certificate overrides",
  1411. bp: `
  1412. android_app {
  1413. name: "foo",
  1414. srcs: ["a.java"],
  1415. certificate: "expiredkey",
  1416. sdk_version: "current",
  1417. }
  1418. android_app_certificate {
  1419. name: "new_certificate",
  1420. certificate: "cert/new_cert",
  1421. }
  1422. `,
  1423. certificateOverride: "foo:new_certificate",
  1424. expectedCertSigningFlags: "",
  1425. expectedCertificate: "cert/new_cert",
  1426. },
  1427. {
  1428. name: "certificate signing flags",
  1429. bp: `
  1430. android_app {
  1431. name: "foo",
  1432. srcs: ["a.java"],
  1433. certificate: ":new_certificate",
  1434. lineage: "lineage.bin",
  1435. rotationMinSdkVersion: "32",
  1436. sdk_version: "current",
  1437. }
  1438. android_app_certificate {
  1439. name: "new_certificate",
  1440. certificate: "cert/new_cert",
  1441. }
  1442. `,
  1443. certificateOverride: "",
  1444. expectedCertSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1445. expectedCertificate: "cert/new_cert",
  1446. },
  1447. {
  1448. name: "cert signing flags from filegroup",
  1449. bp: `
  1450. android_app {
  1451. name: "foo",
  1452. srcs: ["a.java"],
  1453. certificate: ":new_certificate",
  1454. lineage: ":lineage_bin",
  1455. rotationMinSdkVersion: "32",
  1456. sdk_version: "current",
  1457. }
  1458. android_app_certificate {
  1459. name: "new_certificate",
  1460. certificate: "cert/new_cert",
  1461. }
  1462. filegroup {
  1463. name: "lineage_bin",
  1464. srcs: ["lineage.bin"],
  1465. }
  1466. `,
  1467. certificateOverride: "",
  1468. expectedCertSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1469. expectedCertificate: "cert/new_cert",
  1470. },
  1471. {
  1472. name: "missing with AllowMissingDependencies",
  1473. bp: `
  1474. android_app {
  1475. name: "foo",
  1476. srcs: ["a.java"],
  1477. certificate: ":new_certificate",
  1478. sdk_version: "current",
  1479. }
  1480. `,
  1481. expectedCertificate: "out/soong/.intermediates/foo/android_common/missing",
  1482. allowMissingDependencies: true,
  1483. },
  1484. }
  1485. for _, test := range testCases {
  1486. t.Run(test.name, func(t *testing.T) {
  1487. result := android.GroupFixturePreparers(
  1488. PrepareForTestWithJavaDefaultModules,
  1489. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1490. if test.certificateOverride != "" {
  1491. variables.CertificateOverrides = []string{test.certificateOverride}
  1492. }
  1493. if test.allowMissingDependencies {
  1494. variables.Allow_missing_dependencies = proptools.BoolPtr(true)
  1495. }
  1496. }),
  1497. android.FixtureModifyContext(func(ctx *android.TestContext) {
  1498. ctx.SetAllowMissingDependencies(test.allowMissingDependencies)
  1499. }),
  1500. ).RunTestWithBp(t, test.bp)
  1501. foo := result.ModuleForTests("foo", "android_common")
  1502. certificate := foo.Module().(*AndroidApp).certificate
  1503. android.AssertPathRelativeToTopEquals(t, "certificates key", test.expectedCertificate+".pk8", certificate.Key)
  1504. // The sign_target_files_apks and check_target_files_signatures
  1505. // tools require that certificates have a .x509.pem extension.
  1506. android.AssertPathRelativeToTopEquals(t, "certificates pem", test.expectedCertificate+".x509.pem", certificate.Pem)
  1507. signapk := foo.Output("foo.apk")
  1508. if signapk.Rule != android.ErrorRule {
  1509. signCertificateFlags := signapk.Args["certificates"]
  1510. expectedFlags := certificate.Pem.String() + " " + certificate.Key.String()
  1511. android.AssertStringEquals(t, "certificates flags", expectedFlags, signCertificateFlags)
  1512. certSigningFlags := signapk.Args["flags"]
  1513. android.AssertStringEquals(t, "cert signing flags", test.expectedCertSigningFlags, certSigningFlags)
  1514. }
  1515. })
  1516. }
  1517. }
  1518. func TestRequestV4SigningFlag(t *testing.T) {
  1519. testCases := []struct {
  1520. name string
  1521. bp string
  1522. expected string
  1523. }{
  1524. {
  1525. name: "default",
  1526. bp: `
  1527. android_app {
  1528. name: "foo",
  1529. srcs: ["a.java"],
  1530. sdk_version: "current",
  1531. }
  1532. `,
  1533. expected: "",
  1534. },
  1535. {
  1536. name: "default",
  1537. bp: `
  1538. android_app {
  1539. name: "foo",
  1540. srcs: ["a.java"],
  1541. sdk_version: "current",
  1542. v4_signature: false,
  1543. }
  1544. `,
  1545. expected: "",
  1546. },
  1547. {
  1548. name: "module certificate property",
  1549. bp: `
  1550. android_app {
  1551. name: "foo",
  1552. srcs: ["a.java"],
  1553. sdk_version: "current",
  1554. v4_signature: true,
  1555. }
  1556. `,
  1557. expected: "--enable-v4",
  1558. },
  1559. }
  1560. for _, test := range testCases {
  1561. t.Run(test.name, func(t *testing.T) {
  1562. result := android.GroupFixturePreparers(
  1563. PrepareForTestWithJavaDefaultModules,
  1564. ).RunTestWithBp(t, test.bp)
  1565. foo := result.ModuleForTests("foo", "android_common")
  1566. signapk := foo.Output("foo.apk")
  1567. signFlags := signapk.Args["flags"]
  1568. android.AssertStringEquals(t, "signing flags", test.expected, signFlags)
  1569. })
  1570. }
  1571. }
  1572. func TestPackageNameOverride(t *testing.T) {
  1573. testCases := []struct {
  1574. name string
  1575. bp string
  1576. packageNameOverride string
  1577. expected []string
  1578. }{
  1579. {
  1580. name: "default",
  1581. bp: `
  1582. android_app {
  1583. name: "foo",
  1584. srcs: ["a.java"],
  1585. sdk_version: "current",
  1586. }
  1587. `,
  1588. packageNameOverride: "",
  1589. expected: []string{
  1590. "out/soong/.intermediates/foo/android_common/foo.apk",
  1591. "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1592. },
  1593. },
  1594. {
  1595. name: "overridden via PRODUCT_PACKAGE_NAME_OVERRIDES",
  1596. bp: `
  1597. android_app {
  1598. name: "foo",
  1599. srcs: ["a.java"],
  1600. sdk_version: "current",
  1601. }
  1602. `,
  1603. packageNameOverride: "foo:bar",
  1604. expected: []string{
  1605. // The package apk should be still be the original name for test dependencies.
  1606. "out/soong/.intermediates/foo/android_common/bar.apk",
  1607. "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1608. },
  1609. },
  1610. {
  1611. name: "overridden via stem",
  1612. bp: `
  1613. android_app {
  1614. name: "foo",
  1615. srcs: ["a.java"],
  1616. sdk_version: "current",
  1617. stem: "bar",
  1618. }
  1619. `,
  1620. packageNameOverride: "",
  1621. expected: []string{
  1622. "out/soong/.intermediates/foo/android_common/bar.apk",
  1623. "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1624. },
  1625. },
  1626. }
  1627. for _, test := range testCases {
  1628. t.Run(test.name, func(t *testing.T) {
  1629. result := android.GroupFixturePreparers(
  1630. PrepareForTestWithJavaDefaultModules,
  1631. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1632. if test.packageNameOverride != "" {
  1633. variables.PackageNameOverrides = []string{test.packageNameOverride}
  1634. }
  1635. }),
  1636. ).RunTestWithBp(t, test.bp)
  1637. foo := result.ModuleForTests("foo", "android_common")
  1638. outSoongDir := result.Config.SoongOutDir()
  1639. outputs := foo.AllOutputs()
  1640. outputMap := make(map[string]bool)
  1641. for _, o := range outputs {
  1642. outputMap[android.StringPathRelativeToTop(outSoongDir, o)] = true
  1643. }
  1644. for _, e := range test.expected {
  1645. if _, exist := outputMap[e]; !exist {
  1646. t.Errorf("Can't find %q in output files.\nAll outputs:%v", e, outputs)
  1647. }
  1648. }
  1649. })
  1650. }
  1651. }
  1652. func TestInstrumentationTargetOverridden(t *testing.T) {
  1653. bp := `
  1654. android_app {
  1655. name: "foo",
  1656. srcs: ["a.java"],
  1657. sdk_version: "current",
  1658. }
  1659. android_test {
  1660. name: "bar",
  1661. instrumentation_for: "foo",
  1662. sdk_version: "current",
  1663. }
  1664. `
  1665. result := android.GroupFixturePreparers(
  1666. PrepareForTestWithJavaDefaultModules,
  1667. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1668. variables.ManifestPackageNameOverrides = []string{"foo:org.dandroid.bp"}
  1669. }),
  1670. ).RunTestWithBp(t, bp)
  1671. bar := result.ModuleForTests("bar", "android_common")
  1672. res := bar.Output("package-res.apk")
  1673. aapt2Flags := res.Args["flags"]
  1674. e := "--rename-instrumentation-target-package org.dandroid.bp"
  1675. if !strings.Contains(aapt2Flags, e) {
  1676. t.Errorf("target package renaming flag, %q is missing in aapt2 link flags, %q", e, aapt2Flags)
  1677. }
  1678. }
  1679. func TestOverrideAndroidApp(t *testing.T) {
  1680. result := PrepareForTestWithJavaDefaultModules.RunTestWithBp(
  1681. t, `
  1682. android_app {
  1683. name: "foo",
  1684. srcs: ["a.java"],
  1685. certificate: "expiredkey",
  1686. overrides: ["qux"],
  1687. sdk_version: "current",
  1688. }
  1689. override_android_app {
  1690. name: "bar",
  1691. base: "foo",
  1692. certificate: ":new_certificate",
  1693. lineage: "lineage.bin",
  1694. rotationMinSdkVersion: "32",
  1695. logging_parent: "bah",
  1696. }
  1697. android_app_certificate {
  1698. name: "new_certificate",
  1699. certificate: "cert/new_cert",
  1700. }
  1701. override_android_app {
  1702. name: "baz",
  1703. base: "foo",
  1704. package_name: "org.dandroid.bp",
  1705. }
  1706. override_android_app {
  1707. name: "baz_no_rename_resources",
  1708. base: "foo",
  1709. package_name: "org.dandroid.bp",
  1710. rename_resources_package: false,
  1711. }
  1712. android_app {
  1713. name: "foo_no_rename_resources",
  1714. srcs: ["a.java"],
  1715. certificate: "expiredkey",
  1716. overrides: ["qux"],
  1717. rename_resources_package: false,
  1718. sdk_version: "current",
  1719. }
  1720. override_android_app {
  1721. name: "baz_base_no_rename_resources",
  1722. base: "foo_no_rename_resources",
  1723. package_name: "org.dandroid.bp",
  1724. }
  1725. override_android_app {
  1726. name: "baz_override_base_rename_resources",
  1727. base: "foo_no_rename_resources",
  1728. package_name: "org.dandroid.bp",
  1729. rename_resources_package: true,
  1730. }
  1731. `)
  1732. expectedVariants := []struct {
  1733. name string
  1734. moduleName string
  1735. variantName string
  1736. apkName string
  1737. apkPath string
  1738. certFlag string
  1739. certSigningFlags string
  1740. overrides []string
  1741. packageFlag string
  1742. renameResources bool
  1743. logging_parent string
  1744. }{
  1745. {
  1746. name: "foo",
  1747. moduleName: "foo",
  1748. variantName: "android_common",
  1749. apkPath: "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1750. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1751. certSigningFlags: "",
  1752. overrides: []string{"qux"},
  1753. packageFlag: "",
  1754. renameResources: false,
  1755. logging_parent: "",
  1756. },
  1757. {
  1758. name: "foo",
  1759. moduleName: "bar",
  1760. variantName: "android_common_bar",
  1761. apkPath: "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1762. certFlag: "cert/new_cert.x509.pem cert/new_cert.pk8",
  1763. certSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1764. overrides: []string{"qux", "foo"},
  1765. packageFlag: "",
  1766. renameResources: false,
  1767. logging_parent: "bah",
  1768. },
  1769. {
  1770. name: "foo",
  1771. moduleName: "baz",
  1772. variantName: "android_common_baz",
  1773. apkPath: "out/soong/target/product/test_device/system/app/baz/baz.apk",
  1774. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1775. certSigningFlags: "",
  1776. overrides: []string{"qux", "foo"},
  1777. packageFlag: "org.dandroid.bp",
  1778. renameResources: true,
  1779. logging_parent: "",
  1780. },
  1781. {
  1782. name: "foo",
  1783. moduleName: "baz_no_rename_resources",
  1784. variantName: "android_common_baz_no_rename_resources",
  1785. apkPath: "out/soong/target/product/test_device/system/app/baz_no_rename_resources/baz_no_rename_resources.apk",
  1786. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1787. certSigningFlags: "",
  1788. overrides: []string{"qux", "foo"},
  1789. packageFlag: "org.dandroid.bp",
  1790. renameResources: false,
  1791. logging_parent: "",
  1792. },
  1793. {
  1794. name: "foo_no_rename_resources",
  1795. moduleName: "baz_base_no_rename_resources",
  1796. variantName: "android_common_baz_base_no_rename_resources",
  1797. apkPath: "out/soong/target/product/test_device/system/app/baz_base_no_rename_resources/baz_base_no_rename_resources.apk",
  1798. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1799. certSigningFlags: "",
  1800. overrides: []string{"qux", "foo_no_rename_resources"},
  1801. packageFlag: "org.dandroid.bp",
  1802. renameResources: false,
  1803. logging_parent: "",
  1804. },
  1805. {
  1806. name: "foo_no_rename_resources",
  1807. moduleName: "baz_override_base_rename_resources",
  1808. variantName: "android_common_baz_override_base_rename_resources",
  1809. apkPath: "out/soong/target/product/test_device/system/app/baz_override_base_rename_resources/baz_override_base_rename_resources.apk",
  1810. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1811. certSigningFlags: "",
  1812. overrides: []string{"qux", "foo_no_rename_resources"},
  1813. packageFlag: "org.dandroid.bp",
  1814. renameResources: true,
  1815. logging_parent: "",
  1816. },
  1817. }
  1818. for _, expected := range expectedVariants {
  1819. variant := result.ModuleForTests(expected.name, expected.variantName)
  1820. // Check the final apk name
  1821. variant.Output(expected.apkPath)
  1822. // Check the certificate paths
  1823. signapk := variant.Output(expected.moduleName + ".apk")
  1824. certFlag := signapk.Args["certificates"]
  1825. android.AssertStringEquals(t, "certificates flags", expected.certFlag, certFlag)
  1826. // Check the cert signing flags
  1827. certSigningFlags := signapk.Args["flags"]
  1828. android.AssertStringEquals(t, "cert signing flags", expected.certSigningFlags, certSigningFlags)
  1829. // Check if the overrides field values are correctly aggregated.
  1830. mod := variant.Module().(*AndroidApp)
  1831. android.AssertDeepEquals(t, "overrides property", expected.overrides, mod.overridableAppProperties.Overrides)
  1832. // Test Overridable property: Logging_parent
  1833. logging_parent := mod.aapt.LoggingParent
  1834. android.AssertStringEquals(t, "overrides property value for logging parent", expected.logging_parent, logging_parent)
  1835. // Check the package renaming flag, if exists.
  1836. res := variant.Output("package-res.apk")
  1837. aapt2Flags := res.Args["flags"]
  1838. checkAapt2LinkFlag(t, aapt2Flags, "rename-manifest-package", expected.packageFlag)
  1839. expectedPackage := expected.packageFlag
  1840. if !expected.renameResources {
  1841. expectedPackage = ""
  1842. }
  1843. checkAapt2LinkFlag(t, aapt2Flags, "rename-resources-package", expectedPackage)
  1844. }
  1845. }
  1846. func TestOverrideAndroidAppOverrides(t *testing.T) {
  1847. ctx, _ := testJava(
  1848. t, `
  1849. android_app {
  1850. name: "foo",
  1851. srcs: ["a.java"],
  1852. sdk_version: "current",
  1853. overrides: ["qux"]
  1854. }
  1855. android_app {
  1856. name: "bar",
  1857. srcs: ["b.java"],
  1858. sdk_version: "current",
  1859. overrides: ["foo"]
  1860. }
  1861. override_android_app {
  1862. name: "foo_override",
  1863. base: "foo",
  1864. overrides: ["bar"]
  1865. }
  1866. `)
  1867. expectedVariants := []struct {
  1868. name string
  1869. moduleName string
  1870. variantName string
  1871. overrides []string
  1872. }{
  1873. {
  1874. name: "foo",
  1875. moduleName: "foo",
  1876. variantName: "android_common",
  1877. overrides: []string{"qux"},
  1878. },
  1879. {
  1880. name: "bar",
  1881. moduleName: "bar",
  1882. variantName: "android_common",
  1883. overrides: []string{"foo"},
  1884. },
  1885. {
  1886. name: "foo",
  1887. moduleName: "foo_override",
  1888. variantName: "android_common_foo_override",
  1889. overrides: []string{"bar", "foo"},
  1890. },
  1891. }
  1892. for _, expected := range expectedVariants {
  1893. variant := ctx.ModuleForTests(expected.name, expected.variantName)
  1894. // Check if the overrides field values are correctly aggregated.
  1895. mod := variant.Module().(*AndroidApp)
  1896. android.AssertDeepEquals(t, "overrides property", expected.overrides, mod.overridableAppProperties.Overrides)
  1897. }
  1898. }
  1899. func TestOverrideAndroidAppWithPrebuilt(t *testing.T) {
  1900. result := PrepareForTestWithJavaDefaultModules.RunTestWithBp(
  1901. t, `
  1902. android_app {
  1903. name: "foo",
  1904. srcs: ["a.java"],
  1905. sdk_version: "current",
  1906. }
  1907. override_android_app {
  1908. name: "bar",
  1909. base: "foo",
  1910. }
  1911. android_app_import {
  1912. name: "bar",
  1913. prefer: true,
  1914. apk: "bar.apk",
  1915. presigned: true,
  1916. }
  1917. `)
  1918. // An app that has an override that also has a prebuilt should not be hidden.
  1919. foo := result.ModuleForTests("foo", "android_common")
  1920. if foo.Module().IsHideFromMake() {
  1921. t.Errorf("expected foo to have HideFromMake false")
  1922. }
  1923. // An override that also has a prebuilt should be hidden.
  1924. barOverride := result.ModuleForTests("foo", "android_common_bar")
  1925. if !barOverride.Module().IsHideFromMake() {
  1926. t.Errorf("expected bar override variant of foo to have HideFromMake true")
  1927. }
  1928. }
  1929. func TestOverrideAndroidAppStem(t *testing.T) {
  1930. ctx, _ := testJava(t, `
  1931. android_app {
  1932. name: "foo",
  1933. srcs: ["a.java"],
  1934. sdk_version: "current",
  1935. }
  1936. override_android_app {
  1937. name: "bar",
  1938. base: "foo",
  1939. }
  1940. override_android_app {
  1941. name: "baz",
  1942. base: "foo",
  1943. stem: "baz_stem",
  1944. }
  1945. android_app {
  1946. name: "foo2",
  1947. srcs: ["a.java"],
  1948. sdk_version: "current",
  1949. stem: "foo2_stem",
  1950. }
  1951. override_android_app {
  1952. name: "bar2",
  1953. base: "foo2",
  1954. }
  1955. override_android_app {
  1956. name: "baz2",
  1957. base: "foo2",
  1958. stem: "baz2_stem",
  1959. }
  1960. `)
  1961. for _, expected := range []struct {
  1962. moduleName string
  1963. variantName string
  1964. apkPath string
  1965. }{
  1966. {
  1967. moduleName: "foo",
  1968. variantName: "android_common",
  1969. apkPath: "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1970. },
  1971. {
  1972. moduleName: "foo",
  1973. variantName: "android_common_bar",
  1974. apkPath: "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1975. },
  1976. {
  1977. moduleName: "foo",
  1978. variantName: "android_common_baz",
  1979. apkPath: "out/soong/target/product/test_device/system/app/baz_stem/baz_stem.apk",
  1980. },
  1981. {
  1982. moduleName: "foo2",
  1983. variantName: "android_common",
  1984. apkPath: "out/soong/target/product/test_device/system/app/foo2_stem/foo2_stem.apk",
  1985. },
  1986. {
  1987. moduleName: "foo2",
  1988. variantName: "android_common_bar2",
  1989. // Note that this may cause the duplicate output error.
  1990. apkPath: "out/soong/target/product/test_device/system/app/foo2_stem/foo2_stem.apk",
  1991. },
  1992. {
  1993. moduleName: "foo2",
  1994. variantName: "android_common_baz2",
  1995. apkPath: "out/soong/target/product/test_device/system/app/baz2_stem/baz2_stem.apk",
  1996. },
  1997. } {
  1998. variant := ctx.ModuleForTests(expected.moduleName, expected.variantName)
  1999. variant.Output(expected.apkPath)
  2000. }
  2001. }
  2002. func TestOverrideAndroidAppDependency(t *testing.T) {
  2003. ctx, _ := testJava(t, `
  2004. android_app {
  2005. name: "foo",
  2006. srcs: ["a.java"],
  2007. sdk_version: "current",
  2008. }
  2009. override_android_app {
  2010. name: "bar",
  2011. base: "foo",
  2012. package_name: "org.dandroid.bp",
  2013. }
  2014. android_test {
  2015. name: "baz",
  2016. srcs: ["b.java"],
  2017. instrumentation_for: "foo",
  2018. }
  2019. android_test {
  2020. name: "qux",
  2021. srcs: ["b.java"],
  2022. instrumentation_for: "bar",
  2023. }
  2024. `)
  2025. // Verify baz, which depends on the overridden module foo, has the correct classpath javac arg.
  2026. javac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
  2027. fooTurbine := "out/soong/.intermediates/foo/android_common/turbine-combined/foo.jar"
  2028. if !strings.Contains(javac.Args["classpath"], fooTurbine) {
  2029. t.Errorf("baz classpath %v does not contain %q", javac.Args["classpath"], fooTurbine)
  2030. }
  2031. // Verify qux, which depends on the overriding module bar, has the correct classpath javac arg.
  2032. javac = ctx.ModuleForTests("qux", "android_common").Rule("javac")
  2033. barTurbine := "out/soong/.intermediates/foo/android_common_bar/turbine-combined/foo.jar"
  2034. if !strings.Contains(javac.Args["classpath"], barTurbine) {
  2035. t.Errorf("qux classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
  2036. }
  2037. }
  2038. func TestOverrideAndroidTest(t *testing.T) {
  2039. ctx, _ := testJava(t, `
  2040. android_app {
  2041. name: "foo",
  2042. srcs: ["a.java"],
  2043. package_name: "com.android.foo",
  2044. sdk_version: "current",
  2045. }
  2046. override_android_app {
  2047. name: "bar",
  2048. base: "foo",
  2049. package_name: "com.android.bar",
  2050. }
  2051. android_test {
  2052. name: "foo_test",
  2053. srcs: ["b.java"],
  2054. instrumentation_for: "foo",
  2055. }
  2056. override_android_test {
  2057. name: "bar_test",
  2058. base: "foo_test",
  2059. package_name: "com.android.bar.test",
  2060. instrumentation_for: "bar",
  2061. instrumentation_target_package: "com.android.bar",
  2062. }
  2063. `)
  2064. expectedVariants := []struct {
  2065. moduleName string
  2066. variantName string
  2067. apkPath string
  2068. overrides []string
  2069. targetVariant string
  2070. packageFlag string
  2071. targetPackageFlag string
  2072. }{
  2073. {
  2074. variantName: "android_common",
  2075. apkPath: "/target/product/test_device/testcases/foo_test/arm64/foo_test.apk",
  2076. overrides: nil,
  2077. targetVariant: "android_common",
  2078. packageFlag: "",
  2079. targetPackageFlag: "",
  2080. },
  2081. {
  2082. variantName: "android_common_bar_test",
  2083. apkPath: "/target/product/test_device/testcases/bar_test/arm64/bar_test.apk",
  2084. overrides: []string{"foo_test"},
  2085. targetVariant: "android_common_bar",
  2086. packageFlag: "com.android.bar.test",
  2087. targetPackageFlag: "com.android.bar",
  2088. },
  2089. }
  2090. for _, expected := range expectedVariants {
  2091. variant := ctx.ModuleForTests("foo_test", expected.variantName)
  2092. // Check the final apk name
  2093. variant.Output("out/soong" + expected.apkPath)
  2094. // Check if the overrides field values are correctly aggregated.
  2095. mod := variant.Module().(*AndroidTest)
  2096. if !reflect.DeepEqual(expected.overrides, mod.overridableAppProperties.Overrides) {
  2097. t.Errorf("Incorrect overrides property value, expected: %q, got: %q",
  2098. expected.overrides, mod.overridableAppProperties.Overrides)
  2099. }
  2100. // Check if javac classpath has the correct jar file path. This checks instrumentation_for overrides.
  2101. javac := variant.Rule("javac")
  2102. turbine := filepath.Join("out", "soong", ".intermediates", "foo", expected.targetVariant, "turbine-combined", "foo.jar")
  2103. if !strings.Contains(javac.Args["classpath"], turbine) {
  2104. t.Errorf("classpath %q does not contain %q", javac.Args["classpath"], turbine)
  2105. }
  2106. // Check aapt2 flags.
  2107. res := variant.Output("package-res.apk")
  2108. aapt2Flags := res.Args["flags"]
  2109. checkAapt2LinkFlag(t, aapt2Flags, "rename-manifest-package", expected.packageFlag)
  2110. checkAapt2LinkFlag(t, aapt2Flags, "rename-resources-package", expected.packageFlag)
  2111. checkAapt2LinkFlag(t, aapt2Flags, "rename-instrumentation-target-package", expected.targetPackageFlag)
  2112. }
  2113. }
  2114. func TestAndroidTest_FixTestConfig(t *testing.T) {
  2115. ctx, _ := testJava(t, `
  2116. android_app {
  2117. name: "foo",
  2118. srcs: ["a.java"],
  2119. package_name: "com.android.foo",
  2120. sdk_version: "current",
  2121. }
  2122. android_test {
  2123. name: "foo_test",
  2124. srcs: ["b.java"],
  2125. instrumentation_for: "foo",
  2126. }
  2127. android_test {
  2128. name: "bar_test",
  2129. srcs: ["b.java"],
  2130. package_name: "com.android.bar.test",
  2131. instrumentation_for: "foo",
  2132. mainline_package_name: "com.android.bar",
  2133. }
  2134. override_android_test {
  2135. name: "baz_test",
  2136. base: "foo_test",
  2137. package_name: "com.android.baz.test",
  2138. mainline_package_name: "com.android.baz",
  2139. }
  2140. `)
  2141. testCases := []struct {
  2142. moduleName string
  2143. variantName string
  2144. expectedFlags []string
  2145. }{
  2146. {
  2147. moduleName: "foo_test",
  2148. variantName: "android_common",
  2149. },
  2150. {
  2151. moduleName: "bar_test",
  2152. variantName: "android_common",
  2153. expectedFlags: []string{
  2154. "--manifest out/soong/.intermediates/bar_test/android_common/manifest_fixer/AndroidManifest.xml",
  2155. "--package-name com.android.bar.test",
  2156. "--mainline-package-name com.android.bar",
  2157. },
  2158. },
  2159. {
  2160. moduleName: "foo_test",
  2161. variantName: "android_common_baz_test",
  2162. expectedFlags: []string{
  2163. "--manifest out/soong/.intermediates/foo_test/android_common_baz_test/manifest_fixer/AndroidManifest.xml",
  2164. "--package-name com.android.baz.test",
  2165. "--test-file-name baz_test.apk",
  2166. "out/soong/.intermediates/foo_test/android_common_baz_test/test_config_fixer/AndroidTest.xml",
  2167. "--mainline-package-name com.android.baz",
  2168. },
  2169. },
  2170. }
  2171. for _, test := range testCases {
  2172. variant := ctx.ModuleForTests(test.moduleName, test.variantName)
  2173. params := variant.MaybeOutput("test_config_fixer/AndroidTest.xml")
  2174. if len(test.expectedFlags) > 0 {
  2175. if params.Rule == nil {
  2176. t.Errorf("test_config_fixer was expected to run, but didn't")
  2177. } else {
  2178. for _, flag := range test.expectedFlags {
  2179. if !strings.Contains(params.RuleParams.Command, flag) {
  2180. t.Errorf("Flag %q was not found in command: %q", flag, params.RuleParams.Command)
  2181. }
  2182. }
  2183. }
  2184. } else {
  2185. if params.Rule != nil {
  2186. t.Errorf("test_config_fixer was not expected to run, but did: %q", params.RuleParams.Command)
  2187. }
  2188. }
  2189. }
  2190. }
  2191. func TestInstrumentationTargetPrebuilt(t *testing.T) {
  2192. bp := `
  2193. android_app_import {
  2194. name: "foo",
  2195. apk: "foo.apk",
  2196. presigned: true,
  2197. }
  2198. android_test {
  2199. name: "bar",
  2200. srcs: ["a.java"],
  2201. instrumentation_for: "foo",
  2202. sdk_version: "current",
  2203. }
  2204. `
  2205. android.GroupFixturePreparers(
  2206. PrepareForTestWithJavaDefaultModules,
  2207. ).ExtendWithErrorHandler(
  2208. android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  2209. "instrumentation_for: dependency \"foo\" of type \"android_app_import\" does not provide JavaInfo so is unsuitable for use with this property")).
  2210. RunTestWithBp(t, bp)
  2211. }
  2212. func TestStl(t *testing.T) {
  2213. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  2214. cc_library {
  2215. name: "libjni",
  2216. sdk_version: "current",
  2217. stl: "c++_shared",
  2218. }
  2219. android_test {
  2220. name: "stl",
  2221. jni_libs: ["libjni"],
  2222. compile_multilib: "both",
  2223. sdk_version: "current",
  2224. stl: "c++_shared",
  2225. }
  2226. android_test {
  2227. name: "system",
  2228. jni_libs: ["libjni"],
  2229. compile_multilib: "both",
  2230. sdk_version: "current",
  2231. }
  2232. `)
  2233. testCases := []struct {
  2234. name string
  2235. jnis []string
  2236. }{
  2237. {"stl",
  2238. []string{
  2239. "libjni.so",
  2240. "libc++_shared.so",
  2241. },
  2242. },
  2243. {"system",
  2244. []string{
  2245. "libjni.so",
  2246. },
  2247. },
  2248. }
  2249. for _, test := range testCases {
  2250. t.Run(test.name, func(t *testing.T) {
  2251. app := ctx.ModuleForTests(test.name, "android_common")
  2252. jniLibZip := app.Output(jniJarOutputPathString)
  2253. var jnis []string
  2254. args := strings.Fields(jniLibZip.Args["jarArgs"])
  2255. for i := 0; i < len(args); i++ {
  2256. if args[i] == "-f" {
  2257. jnis = append(jnis, args[i+1])
  2258. i += 1
  2259. }
  2260. }
  2261. jnisJoined := strings.Join(jnis, " ")
  2262. for _, jni := range test.jnis {
  2263. if !strings.Contains(jnisJoined, jni) {
  2264. t.Errorf("missing jni %q in %q", jni, jnis)
  2265. }
  2266. }
  2267. })
  2268. }
  2269. }
  2270. func TestUsesLibraries(t *testing.T) {
  2271. bp := `
  2272. java_sdk_library {
  2273. name: "foo",
  2274. srcs: ["a.java"],
  2275. api_packages: ["foo"],
  2276. sdk_version: "current",
  2277. }
  2278. java_sdk_library {
  2279. name: "qux",
  2280. srcs: ["a.java"],
  2281. api_packages: ["qux"],
  2282. sdk_version: "current",
  2283. }
  2284. java_sdk_library {
  2285. name: "quuz",
  2286. srcs: ["a.java"],
  2287. api_packages: ["quuz"],
  2288. sdk_version: "current",
  2289. }
  2290. java_sdk_library {
  2291. name: "fred",
  2292. srcs: ["a.java"],
  2293. api_packages: ["fred"],
  2294. sdk_version: "current",
  2295. }
  2296. java_sdk_library {
  2297. name: "bar",
  2298. srcs: ["a.java"],
  2299. api_packages: ["bar"],
  2300. sdk_version: "current",
  2301. }
  2302. java_sdk_library {
  2303. name: "runtime-library",
  2304. srcs: ["a.java"],
  2305. sdk_version: "current",
  2306. }
  2307. java_library {
  2308. name: "static-runtime-helper",
  2309. srcs: ["a.java"],
  2310. libs: ["runtime-library"],
  2311. sdk_version: "current",
  2312. }
  2313. java_library {
  2314. name: "runtime-required-x",
  2315. srcs: ["a.java"],
  2316. installable: true,
  2317. sdk_version: "current",
  2318. }
  2319. java_library {
  2320. name: "runtime-optional-x",
  2321. srcs: ["a.java"],
  2322. installable: true,
  2323. sdk_version: "current",
  2324. }
  2325. android_library {
  2326. name: "static-x",
  2327. uses_libs: ["runtime-required-x"],
  2328. optional_uses_libs: ["runtime-optional-x"],
  2329. sdk_version: "current",
  2330. }
  2331. java_library {
  2332. name: "runtime-required-y",
  2333. srcs: ["a.java"],
  2334. installable: true,
  2335. sdk_version: "current",
  2336. }
  2337. java_library {
  2338. name: "runtime-optional-y",
  2339. srcs: ["a.java"],
  2340. installable: true,
  2341. sdk_version: "current",
  2342. }
  2343. java_library {
  2344. name: "static-y",
  2345. srcs: ["a.java"],
  2346. uses_libs: ["runtime-required-y"],
  2347. optional_uses_libs: ["runtime-optional-y"],
  2348. sdk_version: "current",
  2349. }
  2350. // A library that has to use "provides_uses_lib", because:
  2351. // - it is not an SDK library
  2352. // - its library name is different from its module name
  2353. java_library {
  2354. name: "non-sdk-lib",
  2355. provides_uses_lib: "com.non.sdk.lib",
  2356. installable: true,
  2357. srcs: ["a.java"],
  2358. }
  2359. android_app {
  2360. name: "app",
  2361. srcs: ["a.java"],
  2362. libs: [
  2363. "qux",
  2364. "quuz.stubs"
  2365. ],
  2366. static_libs: [
  2367. "static-runtime-helper",
  2368. // statically linked component libraries should not pull their SDK libraries,
  2369. // so "fred" should not be added to class loader context
  2370. "fred.stubs",
  2371. "static-x",
  2372. "static-y",
  2373. ],
  2374. uses_libs: [
  2375. "foo",
  2376. "non-sdk-lib"
  2377. ],
  2378. sdk_version: "current",
  2379. optional_uses_libs: [
  2380. "bar",
  2381. "baz",
  2382. ],
  2383. }
  2384. android_app_import {
  2385. name: "prebuilt",
  2386. apk: "prebuilts/apk/app.apk",
  2387. certificate: "platform",
  2388. uses_libs: [
  2389. "foo",
  2390. "non-sdk-lib",
  2391. "android.test.runner"
  2392. ],
  2393. optional_uses_libs: [
  2394. "bar",
  2395. "baz",
  2396. ],
  2397. }
  2398. `
  2399. result := android.GroupFixturePreparers(
  2400. prepareForJavaTest,
  2401. PrepareForTestWithJavaSdkLibraryFiles,
  2402. FixtureWithLastReleaseApis("runtime-library", "foo", "quuz", "qux", "bar", "fred"),
  2403. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2404. variables.BuildWarningBadOptionalUsesLibsAllowlist = []string{"app", "prebuilt"}
  2405. }),
  2406. ).RunTestWithBp(t, bp)
  2407. app := result.ModuleForTests("app", "android_common")
  2408. prebuilt := result.ModuleForTests("prebuilt", "android_common")
  2409. // Test that implicit dependencies on java_sdk_library instances are passed to the manifest.
  2410. // These also include explicit `uses_libs`/`optional_uses_libs` entries, as they may be
  2411. // propagated from dependencies.
  2412. actualManifestFixerArgs := app.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2413. expectManifestFixerArgs := `--extract-native-libs=true ` +
  2414. `--uses-library qux ` +
  2415. `--uses-library quuz ` +
  2416. `--uses-library foo ` +
  2417. `--uses-library com.non.sdk.lib ` +
  2418. `--uses-library runtime-library ` +
  2419. `--uses-library runtime-required-x ` +
  2420. `--uses-library runtime-required-y ` +
  2421. `--optional-uses-library bar ` +
  2422. `--optional-uses-library runtime-optional-x ` +
  2423. `--optional-uses-library runtime-optional-y`
  2424. android.AssertStringDoesContain(t, "manifest_fixer args", actualManifestFixerArgs, expectManifestFixerArgs)
  2425. // Test that all libraries are verified (library order matters).
  2426. verifyCmd := app.Rule("verify_uses_libraries").RuleParams.Command
  2427. verifyArgs := `--uses-library foo ` +
  2428. `--uses-library com.non.sdk.lib ` +
  2429. `--uses-library qux ` +
  2430. `--uses-library quuz ` +
  2431. `--uses-library runtime-library ` +
  2432. `--uses-library runtime-required-x ` +
  2433. `--uses-library runtime-required-y ` +
  2434. `--optional-uses-library bar ` +
  2435. `--optional-uses-library baz ` +
  2436. `--optional-uses-library runtime-optional-x ` +
  2437. `--optional-uses-library runtime-optional-y `
  2438. android.AssertStringDoesContain(t, "verify cmd args", verifyCmd, verifyArgs)
  2439. // Test that all libraries are verified for an APK (library order matters).
  2440. verifyApkCmd := prebuilt.Rule("verify_uses_libraries").RuleParams.Command
  2441. verifyApkArgs := `--uses-library foo ` +
  2442. `--uses-library com.non.sdk.lib ` +
  2443. `--uses-library android.test.runner ` +
  2444. `--optional-uses-library bar ` +
  2445. `--optional-uses-library baz `
  2446. android.AssertStringDoesContain(t, "verify apk cmd args", verifyApkCmd, verifyApkArgs)
  2447. // Test that necessary args are passed for constructing CLC in Ninja phase.
  2448. cmd := app.Rule("dexpreopt").RuleParams.Command
  2449. android.AssertStringDoesContain(t, "dexpreopt app cmd context", cmd, "--context-json=")
  2450. android.AssertStringDoesContain(t, "dexpreopt app cmd product_packages", cmd,
  2451. "--product-packages=out/soong/.intermediates/app/android_common/dexpreopt/product_packages.txt")
  2452. }
  2453. func TestDexpreoptBcp(t *testing.T) {
  2454. bp := `
  2455. java_sdk_library {
  2456. name: "foo",
  2457. srcs: ["a.java"],
  2458. api_packages: ["foo"],
  2459. sdk_version: "current",
  2460. }
  2461. java_sdk_library {
  2462. name: "bar",
  2463. srcs: ["a.java"],
  2464. api_packages: ["bar"],
  2465. permitted_packages: ["bar"],
  2466. sdk_version: "current",
  2467. }
  2468. android_app {
  2469. name: "app",
  2470. srcs: ["a.java"],
  2471. sdk_version: "current",
  2472. }
  2473. `
  2474. testCases := []struct {
  2475. name string
  2476. with bool
  2477. expect string
  2478. }{
  2479. {
  2480. name: "with updatable bcp",
  2481. with: true,
  2482. expect: "/system/framework/foo.jar:/system/framework/bar.jar",
  2483. },
  2484. {
  2485. name: "without updatable bcp",
  2486. with: false,
  2487. expect: "/system/framework/foo.jar",
  2488. },
  2489. }
  2490. for _, test := range testCases {
  2491. t.Run(test.name, func(t *testing.T) {
  2492. result := android.GroupFixturePreparers(
  2493. prepareForJavaTest,
  2494. PrepareForTestWithJavaSdkLibraryFiles,
  2495. FixtureWithLastReleaseApis("runtime-library", "foo", "bar"),
  2496. dexpreopt.FixtureSetBootJars("platform:foo"),
  2497. dexpreopt.FixtureSetApexBootJars("platform:bar"),
  2498. dexpreopt.FixtureSetPreoptWithUpdatableBcp(test.with),
  2499. ).RunTestWithBp(t, bp)
  2500. app := result.ModuleForTests("app", "android_common")
  2501. cmd := app.Rule("dexpreopt").RuleParams.Command
  2502. bcp := " -Xbootclasspath-locations:" + test.expect + " " // space at the end matters
  2503. android.AssertStringDoesContain(t, "dexpreopt app bcp", cmd, bcp)
  2504. })
  2505. }
  2506. }
  2507. func TestCodelessApp(t *testing.T) {
  2508. testCases := []struct {
  2509. name string
  2510. bp string
  2511. noCode bool
  2512. }{
  2513. {
  2514. name: "normal",
  2515. bp: `
  2516. android_app {
  2517. name: "foo",
  2518. srcs: ["a.java"],
  2519. sdk_version: "current",
  2520. }
  2521. `,
  2522. noCode: false,
  2523. },
  2524. {
  2525. name: "app without sources",
  2526. bp: `
  2527. android_app {
  2528. name: "foo",
  2529. sdk_version: "current",
  2530. }
  2531. `,
  2532. noCode: true,
  2533. },
  2534. {
  2535. name: "app with libraries",
  2536. bp: `
  2537. android_app {
  2538. name: "foo",
  2539. static_libs: ["lib"],
  2540. sdk_version: "current",
  2541. }
  2542. java_library {
  2543. name: "lib",
  2544. srcs: ["a.java"],
  2545. sdk_version: "current",
  2546. }
  2547. `,
  2548. noCode: false,
  2549. },
  2550. {
  2551. name: "app with sourceless libraries",
  2552. bp: `
  2553. android_app {
  2554. name: "foo",
  2555. static_libs: ["lib"],
  2556. sdk_version: "current",
  2557. }
  2558. java_library {
  2559. name: "lib",
  2560. sdk_version: "current",
  2561. }
  2562. `,
  2563. // TODO(jungjw): this should probably be true
  2564. noCode: false,
  2565. },
  2566. }
  2567. for _, test := range testCases {
  2568. t.Run(test.name, func(t *testing.T) {
  2569. ctx := testApp(t, test.bp)
  2570. foo := ctx.ModuleForTests("foo", "android_common")
  2571. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2572. if strings.Contains(manifestFixerArgs, "--has-no-code") != test.noCode {
  2573. t.Errorf("unexpected manifest_fixer args: %q", manifestFixerArgs)
  2574. }
  2575. })
  2576. }
  2577. }
  2578. func TestUncompressDex(t *testing.T) {
  2579. testCases := []struct {
  2580. name string
  2581. bp string
  2582. uncompressedPlatform bool
  2583. uncompressedUnbundled bool
  2584. }{
  2585. {
  2586. name: "normal",
  2587. bp: `
  2588. android_app {
  2589. name: "foo",
  2590. srcs: ["a.java"],
  2591. sdk_version: "current",
  2592. }
  2593. `,
  2594. uncompressedPlatform: true,
  2595. uncompressedUnbundled: false,
  2596. },
  2597. {
  2598. name: "use_embedded_dex",
  2599. bp: `
  2600. android_app {
  2601. name: "foo",
  2602. use_embedded_dex: true,
  2603. srcs: ["a.java"],
  2604. sdk_version: "current",
  2605. }
  2606. `,
  2607. uncompressedPlatform: true,
  2608. uncompressedUnbundled: true,
  2609. },
  2610. {
  2611. name: "privileged",
  2612. bp: `
  2613. android_app {
  2614. name: "foo",
  2615. privileged: true,
  2616. srcs: ["a.java"],
  2617. sdk_version: "current",
  2618. }
  2619. `,
  2620. uncompressedPlatform: true,
  2621. uncompressedUnbundled: true,
  2622. },
  2623. {
  2624. name: "normal_uncompress_dex_true",
  2625. bp: `
  2626. android_app {
  2627. name: "foo",
  2628. srcs: ["a.java"],
  2629. sdk_version: "current",
  2630. uncompress_dex: true,
  2631. }
  2632. `,
  2633. uncompressedPlatform: true,
  2634. uncompressedUnbundled: true,
  2635. },
  2636. {
  2637. name: "normal_uncompress_dex_false",
  2638. bp: `
  2639. android_app {
  2640. name: "foo",
  2641. srcs: ["a.java"],
  2642. sdk_version: "current",
  2643. uncompress_dex: false,
  2644. }
  2645. `,
  2646. uncompressedPlatform: false,
  2647. uncompressedUnbundled: false,
  2648. },
  2649. }
  2650. test := func(t *testing.T, bp string, want bool, unbundled bool) {
  2651. t.Helper()
  2652. result := android.GroupFixturePreparers(
  2653. prepareForJavaTest,
  2654. PrepareForTestWithPrebuiltsOfCurrentApi,
  2655. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2656. if unbundled {
  2657. variables.Unbundled_build = proptools.BoolPtr(true)
  2658. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(true)
  2659. }
  2660. }),
  2661. ).RunTestWithBp(t, bp)
  2662. foo := result.ModuleForTests("foo", "android_common")
  2663. dex := foo.Rule("r8")
  2664. uncompressedInDexJar := strings.Contains(dex.Args["zipFlags"], "-L 0")
  2665. aligned := foo.MaybeRule("zipalign").Rule != nil
  2666. android.AssertBoolEquals(t, "uncompressed in dex", want, uncompressedInDexJar)
  2667. android.AssertBoolEquals(t, "aligne", want, aligned)
  2668. }
  2669. for _, tt := range testCases {
  2670. t.Run(tt.name, func(t *testing.T) {
  2671. t.Run("platform", func(t *testing.T) {
  2672. test(t, tt.bp, tt.uncompressedPlatform, false)
  2673. })
  2674. t.Run("unbundled", func(t *testing.T) {
  2675. test(t, tt.bp, tt.uncompressedUnbundled, true)
  2676. })
  2677. })
  2678. }
  2679. }
  2680. func checkAapt2LinkFlag(t *testing.T, aapt2Flags, flagName, expectedValue string) {
  2681. if expectedValue != "" {
  2682. expectedFlag := "--" + flagName + " " + expectedValue
  2683. if !strings.Contains(aapt2Flags, expectedFlag) {
  2684. t.Errorf("%q is missing in aapt2 link flags, %q", expectedFlag, aapt2Flags)
  2685. }
  2686. } else {
  2687. unexpectedFlag := "--" + flagName
  2688. if strings.Contains(aapt2Flags, unexpectedFlag) {
  2689. t.Errorf("unexpected flag, %q is found in aapt2 link flags, %q", unexpectedFlag, aapt2Flags)
  2690. }
  2691. }
  2692. }
  2693. func TestExportedProguardFlagFiles(t *testing.T) {
  2694. ctx, _ := testJava(t, `
  2695. android_app {
  2696. name: "foo",
  2697. sdk_version: "current",
  2698. static_libs: ["lib1"],
  2699. }
  2700. android_library {
  2701. name: "lib1",
  2702. sdk_version: "current",
  2703. optimize: {
  2704. proguard_flags_files: ["lib1proguard.cfg"],
  2705. }
  2706. }
  2707. `)
  2708. m := ctx.ModuleForTests("foo", "android_common")
  2709. hasLib1Proguard := false
  2710. for _, s := range m.Rule("java.r8").Implicits.Strings() {
  2711. if s == "lib1proguard.cfg" {
  2712. hasLib1Proguard = true
  2713. break
  2714. }
  2715. }
  2716. if !hasLib1Proguard {
  2717. t.Errorf("App does not use library proguard config")
  2718. }
  2719. }
  2720. func TestTargetSdkVersionManifestFixer(t *testing.T) {
  2721. platform_sdk_codename := "Tiramisu"
  2722. platform_sdk_version := 33
  2723. testCases := []struct {
  2724. name string
  2725. targetSdkVersionInBp string
  2726. targetSdkVersionExpected string
  2727. unbundledBuild bool
  2728. platformSdkFinal bool
  2729. }{
  2730. {
  2731. name: "Non-Unbundled build: Android.bp has targetSdkVersion",
  2732. targetSdkVersionInBp: "30",
  2733. targetSdkVersionExpected: "30",
  2734. unbundledBuild: false,
  2735. },
  2736. {
  2737. name: "Unbundled build: Android.bp has targetSdkVersion",
  2738. targetSdkVersionInBp: "30",
  2739. targetSdkVersionExpected: "30",
  2740. unbundledBuild: true,
  2741. },
  2742. {
  2743. name: "Non-Unbundled build: Android.bp has targetSdkVersion equal to platform_sdk_codename",
  2744. targetSdkVersionInBp: platform_sdk_codename,
  2745. targetSdkVersionExpected: platform_sdk_codename,
  2746. unbundledBuild: false,
  2747. },
  2748. {
  2749. name: "Unbundled build: Android.bp has targetSdkVersion equal to platform_sdk_codename",
  2750. targetSdkVersionInBp: platform_sdk_codename,
  2751. targetSdkVersionExpected: "10000",
  2752. unbundledBuild: true,
  2753. },
  2754. {
  2755. name: "Non-Unbundled build: Android.bp has no targetSdkVersion",
  2756. targetSdkVersionExpected: platform_sdk_codename,
  2757. unbundledBuild: false,
  2758. },
  2759. {
  2760. name: "Unbundled build: Android.bp has no targetSdkVersion",
  2761. targetSdkVersionExpected: "10000",
  2762. unbundledBuild: true,
  2763. },
  2764. {
  2765. name: "Bundled build in REL branches",
  2766. targetSdkVersionExpected: "33",
  2767. unbundledBuild: false,
  2768. platformSdkFinal: true,
  2769. },
  2770. }
  2771. for _, testCase := range testCases {
  2772. targetSdkVersionTemplate := ""
  2773. if testCase.targetSdkVersionInBp != "" {
  2774. targetSdkVersionTemplate = fmt.Sprintf(`target_sdk_version: "%s",`, testCase.targetSdkVersionInBp)
  2775. }
  2776. bp := fmt.Sprintf(`
  2777. android_app {
  2778. name: "foo",
  2779. sdk_version: "current",
  2780. %s
  2781. }
  2782. `, targetSdkVersionTemplate)
  2783. fixture := android.GroupFixturePreparers(
  2784. prepareForJavaTest,
  2785. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2786. if testCase.platformSdkFinal {
  2787. variables.Platform_sdk_final = proptools.BoolPtr(true)
  2788. }
  2789. // explicitly set platform_sdk_codename to make the test deterministic
  2790. variables.Platform_sdk_codename = &platform_sdk_codename
  2791. variables.Platform_sdk_version = &platform_sdk_version
  2792. variables.Platform_version_active_codenames = []string{platform_sdk_codename}
  2793. // create a non-empty list if unbundledBuild==true
  2794. if testCase.unbundledBuild {
  2795. variables.Unbundled_build_apps = []string{"apex_a", "apex_b"}
  2796. }
  2797. }),
  2798. )
  2799. result := fixture.RunTestWithBp(t, bp)
  2800. foo := result.ModuleForTests("foo", "android_common")
  2801. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2802. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  2803. }
  2804. }
  2805. func TestDefaultAppTargetSdkVersionForUpdatableModules(t *testing.T) {
  2806. platform_sdk_codename := "Tiramisu"
  2807. platform_sdk_version := 33
  2808. testCases := []struct {
  2809. name string
  2810. platform_sdk_final bool
  2811. targetSdkVersionInBp *string
  2812. targetSdkVersionExpected *string
  2813. updatable bool
  2814. }{
  2815. {
  2816. name: "Non-Updatable Module: Android.bp has older targetSdkVersion",
  2817. targetSdkVersionInBp: proptools.StringPtr("29"),
  2818. targetSdkVersionExpected: proptools.StringPtr("29"),
  2819. updatable: false,
  2820. },
  2821. {
  2822. name: "Updatable Module: Android.bp has older targetSdkVersion",
  2823. targetSdkVersionInBp: proptools.StringPtr("30"),
  2824. targetSdkVersionExpected: proptools.StringPtr("30"),
  2825. updatable: true,
  2826. },
  2827. {
  2828. name: "Updatable Module: Android.bp has no targetSdkVersion",
  2829. targetSdkVersionExpected: proptools.StringPtr("10000"),
  2830. updatable: true,
  2831. },
  2832. {
  2833. name: "[SDK finalised] Non-Updatable Module: Android.bp has older targetSdkVersion",
  2834. platform_sdk_final: true,
  2835. targetSdkVersionInBp: proptools.StringPtr("30"),
  2836. targetSdkVersionExpected: proptools.StringPtr("30"),
  2837. updatable: false,
  2838. },
  2839. {
  2840. name: "[SDK finalised] Updatable Module: Android.bp has older targetSdkVersion",
  2841. platform_sdk_final: true,
  2842. targetSdkVersionInBp: proptools.StringPtr("30"),
  2843. targetSdkVersionExpected: proptools.StringPtr("30"),
  2844. updatable: true,
  2845. },
  2846. {
  2847. name: "[SDK finalised] Updatable Module: Android.bp has targetSdkVersion as platform sdk codename",
  2848. platform_sdk_final: true,
  2849. targetSdkVersionInBp: proptools.StringPtr(platform_sdk_codename),
  2850. targetSdkVersionExpected: proptools.StringPtr("33"),
  2851. updatable: true,
  2852. },
  2853. {
  2854. name: "[SDK finalised] Updatable Module: Android.bp has no targetSdkVersion",
  2855. platform_sdk_final: true,
  2856. targetSdkVersionExpected: proptools.StringPtr("33"),
  2857. updatable: true,
  2858. },
  2859. }
  2860. for _, testCase := range testCases {
  2861. targetSdkVersionTemplate := ""
  2862. if testCase.targetSdkVersionInBp != nil {
  2863. targetSdkVersionTemplate = fmt.Sprintf(`target_sdk_version: "%s",`, *testCase.targetSdkVersionInBp)
  2864. }
  2865. bp := fmt.Sprintf(`
  2866. android_app {
  2867. name: "foo",
  2868. sdk_version: "current",
  2869. min_sdk_version: "29",
  2870. %s
  2871. updatable: %t,
  2872. enforce_default_target_sdk_version: %t
  2873. }
  2874. `, targetSdkVersionTemplate, testCase.updatable, testCase.updatable) // enforce default target sdk version if app is updatable
  2875. fixture := android.GroupFixturePreparers(
  2876. PrepareForTestWithJavaDefaultModules,
  2877. android.PrepareForTestWithAllowMissingDependencies,
  2878. android.PrepareForTestWithAndroidMk,
  2879. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2880. // explicitly set following platform variables to make the test deterministic
  2881. variables.Platform_sdk_final = &testCase.platform_sdk_final
  2882. variables.Platform_sdk_version = &platform_sdk_version
  2883. variables.Platform_sdk_codename = &platform_sdk_codename
  2884. variables.Platform_version_active_codenames = []string{platform_sdk_codename}
  2885. variables.Unbundled_build = proptools.BoolPtr(true)
  2886. variables.Unbundled_build_apps = []string{"sampleModule"}
  2887. }),
  2888. )
  2889. result := fixture.RunTestWithBp(t, bp)
  2890. foo := result.ModuleForTests("foo", "android_common")
  2891. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2892. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+*testCase.targetSdkVersionExpected)
  2893. }
  2894. }
  2895. func TestEnforceDefaultAppTargetSdkVersionFlag(t *testing.T) {
  2896. platform_sdk_codename := "Tiramisu"
  2897. platform_sdk_version := 33
  2898. testCases := []struct {
  2899. name string
  2900. enforceDefaultTargetSdkVersion bool
  2901. expectedError string
  2902. platform_sdk_final bool
  2903. targetSdkVersionInBp string
  2904. targetSdkVersionExpected string
  2905. updatable bool
  2906. }{
  2907. {
  2908. name: "Not enforcing Target SDK Version: Android.bp has older targetSdkVersion",
  2909. enforceDefaultTargetSdkVersion: false,
  2910. targetSdkVersionInBp: "29",
  2911. targetSdkVersionExpected: "29",
  2912. updatable: false,
  2913. },
  2914. {
  2915. name: "[SDK finalised] Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2916. enforceDefaultTargetSdkVersion: true,
  2917. platform_sdk_final: true,
  2918. targetSdkVersionInBp: "current",
  2919. targetSdkVersionExpected: "33",
  2920. updatable: true,
  2921. },
  2922. {
  2923. name: "Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2924. enforceDefaultTargetSdkVersion: true,
  2925. platform_sdk_final: false,
  2926. targetSdkVersionInBp: "current",
  2927. targetSdkVersionExpected: "10000",
  2928. updatable: false,
  2929. },
  2930. {
  2931. name: "Not enforcing Target SDK Version for Updatable app",
  2932. enforceDefaultTargetSdkVersion: false,
  2933. expectedError: "Updatable apps must enforce default target sdk version",
  2934. targetSdkVersionInBp: "29",
  2935. targetSdkVersionExpected: "29",
  2936. updatable: true,
  2937. },
  2938. }
  2939. for _, testCase := range testCases {
  2940. errExpected := testCase.expectedError != ""
  2941. bp := fmt.Sprintf(`
  2942. android_app {
  2943. name: "foo",
  2944. enforce_default_target_sdk_version: %t,
  2945. sdk_version: "current",
  2946. min_sdk_version: "29",
  2947. target_sdk_version: "%v",
  2948. updatable: %t
  2949. }
  2950. `, testCase.enforceDefaultTargetSdkVersion, testCase.targetSdkVersionInBp, testCase.updatable)
  2951. fixture := android.GroupFixturePreparers(
  2952. PrepareForTestWithJavaDefaultModules,
  2953. android.PrepareForTestWithAllowMissingDependencies,
  2954. android.PrepareForTestWithAndroidMk,
  2955. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2956. // explicitly set following platform variables to make the test deterministic
  2957. variables.Platform_sdk_final = &testCase.platform_sdk_final
  2958. variables.Platform_sdk_version = &platform_sdk_version
  2959. variables.Platform_sdk_codename = &platform_sdk_codename
  2960. variables.Unbundled_build = proptools.BoolPtr(true)
  2961. variables.Unbundled_build_apps = []string{"sampleModule"}
  2962. }),
  2963. )
  2964. errorHandler := android.FixtureExpectsNoErrors
  2965. if errExpected {
  2966. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(testCase.expectedError)
  2967. }
  2968. result := fixture.ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, bp)
  2969. if !errExpected {
  2970. foo := result.ModuleForTests("foo", "android_common")
  2971. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2972. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  2973. }
  2974. }
  2975. }
  2976. func TestEnforceDefaultAppTargetSdkVersionFlagForTests(t *testing.T) {
  2977. platform_sdk_codename := "Tiramisu"
  2978. platform_sdk_version := 33
  2979. testCases := []struct {
  2980. name string
  2981. enforceDefaultTargetSdkVersion bool
  2982. expectedError string
  2983. platform_sdk_final bool
  2984. targetSdkVersionInBp string
  2985. targetSdkVersionExpected string
  2986. }{
  2987. {
  2988. name: "Not enforcing Target SDK Version: Android.bp has older targetSdkVersion",
  2989. enforceDefaultTargetSdkVersion: false,
  2990. targetSdkVersionInBp: "29",
  2991. targetSdkVersionExpected: "29",
  2992. },
  2993. {
  2994. name: "[SDK finalised] Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2995. enforceDefaultTargetSdkVersion: true,
  2996. platform_sdk_final: true,
  2997. targetSdkVersionInBp: "current",
  2998. targetSdkVersionExpected: "33",
  2999. },
  3000. {
  3001. name: "Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  3002. enforceDefaultTargetSdkVersion: true,
  3003. platform_sdk_final: false,
  3004. targetSdkVersionInBp: "current",
  3005. targetSdkVersionExpected: "10000",
  3006. },
  3007. }
  3008. for _, testCase := range testCases {
  3009. errExpected := testCase.expectedError != ""
  3010. bp := fmt.Sprintf(`
  3011. android_test {
  3012. name: "foo",
  3013. enforce_default_target_sdk_version: %t,
  3014. min_sdk_version: "29",
  3015. target_sdk_version: "%v",
  3016. }
  3017. `, testCase.enforceDefaultTargetSdkVersion, testCase.targetSdkVersionInBp)
  3018. fixture := android.GroupFixturePreparers(
  3019. PrepareForTestWithJavaDefaultModules,
  3020. android.PrepareForTestWithAllowMissingDependencies,
  3021. android.PrepareForTestWithAndroidMk,
  3022. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3023. // explicitly set following platform variables to make the test deterministic
  3024. variables.Platform_sdk_final = &testCase.platform_sdk_final
  3025. variables.Platform_sdk_version = &platform_sdk_version
  3026. variables.Platform_sdk_codename = &platform_sdk_codename
  3027. variables.Unbundled_build = proptools.BoolPtr(true)
  3028. variables.Unbundled_build_apps = []string{"sampleModule"}
  3029. }),
  3030. )
  3031. errorHandler := android.FixtureExpectsNoErrors
  3032. if errExpected {
  3033. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(testCase.expectedError)
  3034. }
  3035. result := fixture.ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, bp)
  3036. if !errExpected {
  3037. foo := result.ModuleForTests("foo", "android_common")
  3038. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  3039. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  3040. }
  3041. }
  3042. }
  3043. func TestAppMissingCertificateAllowMissingDependencies(t *testing.T) {
  3044. result := android.GroupFixturePreparers(
  3045. PrepareForTestWithJavaDefaultModules,
  3046. android.PrepareForTestWithAllowMissingDependencies,
  3047. android.PrepareForTestWithAndroidMk,
  3048. ).RunTestWithBp(t, `
  3049. android_app {
  3050. name: "foo",
  3051. srcs: ["a.java"],
  3052. certificate: ":missing_certificate",
  3053. sdk_version: "current",
  3054. }
  3055. android_app {
  3056. name: "bar",
  3057. srcs: ["a.java"],
  3058. certificate: ":missing_certificate",
  3059. product_specific: true,
  3060. sdk_version: "current",
  3061. }`)
  3062. foo := result.ModuleForTests("foo", "android_common")
  3063. fooApk := foo.Output("foo.apk")
  3064. if fooApk.Rule != android.ErrorRule {
  3065. t.Fatalf("expected ErrorRule for foo.apk, got %s", fooApk.Rule.String())
  3066. }
  3067. android.AssertStringDoesContain(t, "expected error rule message", fooApk.Args["error"], "missing dependencies: missing_certificate\n")
  3068. }
  3069. func TestAppIncludesJniPackages(t *testing.T) {
  3070. ctx := android.GroupFixturePreparers(
  3071. PrepareForTestWithJavaDefaultModules,
  3072. ).RunTestWithBp(t, `
  3073. android_library_import {
  3074. name: "aary-nodeps",
  3075. aars: ["aary.aar"],
  3076. extract_jni: true,
  3077. }
  3078. android_library {
  3079. name: "aary-lib",
  3080. sdk_version: "current",
  3081. min_sdk_version: "21",
  3082. static_libs: ["aary-nodeps"],
  3083. }
  3084. android_app {
  3085. name: "aary-lib-dep",
  3086. sdk_version: "current",
  3087. min_sdk_version: "21",
  3088. manifest: "AndroidManifest.xml",
  3089. static_libs: ["aary-lib"],
  3090. use_embedded_native_libs: true,
  3091. }
  3092. android_app {
  3093. name: "aary-import-dep",
  3094. sdk_version: "current",
  3095. min_sdk_version: "21",
  3096. manifest: "AndroidManifest.xml",
  3097. static_libs: ["aary-nodeps"],
  3098. use_embedded_native_libs: true,
  3099. }
  3100. android_app {
  3101. name: "aary-no-use-embedded",
  3102. sdk_version: "current",
  3103. min_sdk_version: "21",
  3104. manifest: "AndroidManifest.xml",
  3105. static_libs: ["aary-nodeps"],
  3106. }`)
  3107. testCases := []struct {
  3108. name string
  3109. hasPackage bool
  3110. }{
  3111. {
  3112. name: "aary-import-dep",
  3113. hasPackage: true,
  3114. },
  3115. {
  3116. name: "aary-lib-dep",
  3117. hasPackage: true,
  3118. },
  3119. {
  3120. name: "aary-no-use-embedded",
  3121. hasPackage: false,
  3122. },
  3123. }
  3124. for _, tc := range testCases {
  3125. t.Run(tc.name, func(t *testing.T) {
  3126. app := ctx.ModuleForTests(tc.name, "android_common")
  3127. outputFile := "jnilibs.zip"
  3128. jniOutputLibZip := app.MaybeOutput(outputFile)
  3129. if jniOutputLibZip.Rule == nil && !tc.hasPackage {
  3130. return
  3131. }
  3132. jniPackage := "arm64-v8a_jni.zip"
  3133. inputs := jniOutputLibZip.Inputs
  3134. foundPackage := false
  3135. for i := 0; i < len(inputs); i++ {
  3136. if strings.Contains(inputs[i].String(), jniPackage) {
  3137. foundPackage = true
  3138. }
  3139. }
  3140. if foundPackage != tc.hasPackage {
  3141. t.Errorf("expected to find %v in %v inputs; inputs = %v", jniPackage, outputFile, inputs)
  3142. }
  3143. })
  3144. }
  3145. }
  3146. func TestTargetSdkVersionMtsTests(t *testing.T) {
  3147. platformSdkCodename := "Tiramisu"
  3148. android_test := "android_test"
  3149. android_test_helper_app := "android_test_helper_app"
  3150. bpTemplate := `
  3151. %v {
  3152. name: "mytest",
  3153. target_sdk_version: "%v",
  3154. test_suites: ["othersuite", "%v"],
  3155. }
  3156. `
  3157. testCases := []struct {
  3158. desc string
  3159. moduleType string
  3160. targetSdkVersionInBp string
  3161. targetSdkVersionExpected string
  3162. testSuites string
  3163. }{
  3164. {
  3165. desc: "Non-MTS android_test_apps targeting current should not be upgraded to 10000",
  3166. moduleType: android_test,
  3167. targetSdkVersionInBp: "current",
  3168. targetSdkVersionExpected: platformSdkCodename,
  3169. testSuites: "non-mts-suite",
  3170. },
  3171. {
  3172. desc: "MTS android_test_apps targeting released sdks should not be upgraded to 10000",
  3173. moduleType: android_test,
  3174. targetSdkVersionInBp: "29",
  3175. targetSdkVersionExpected: "29",
  3176. testSuites: "mts-suite",
  3177. },
  3178. {
  3179. desc: "MTS android_test_apps targeting current should be upgraded to 10000",
  3180. moduleType: android_test,
  3181. targetSdkVersionInBp: "current",
  3182. targetSdkVersionExpected: "10000",
  3183. testSuites: "mts-suite",
  3184. },
  3185. {
  3186. desc: "MTS android_test_helper_apps targeting current should be upgraded to 10000",
  3187. moduleType: android_test_helper_app,
  3188. targetSdkVersionInBp: "current",
  3189. targetSdkVersionExpected: "10000",
  3190. testSuites: "mts-suite",
  3191. },
  3192. }
  3193. fixture := android.GroupFixturePreparers(
  3194. prepareForJavaTest,
  3195. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3196. variables.Platform_sdk_codename = &platformSdkCodename
  3197. variables.Platform_version_active_codenames = []string{platformSdkCodename}
  3198. }),
  3199. )
  3200. for _, testCase := range testCases {
  3201. result := fixture.RunTestWithBp(t, fmt.Sprintf(bpTemplate, testCase.moduleType, testCase.targetSdkVersionInBp, testCase.testSuites))
  3202. mytest := result.ModuleForTests("mytest", "android_common")
  3203. manifestFixerArgs := mytest.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  3204. android.AssertStringDoesContain(t, testCase.desc, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  3205. }
  3206. }
  3207. func TestPrivappAllowlist(t *testing.T) {
  3208. testJavaError(t, "privileged must be set in order to use privapp_allowlist", `
  3209. android_app {
  3210. name: "foo",
  3211. srcs: ["a.java"],
  3212. privapp_allowlist: "perms.xml",
  3213. }
  3214. `)
  3215. result := PrepareForTestWithJavaDefaultModules.RunTestWithBp(
  3216. t,
  3217. `
  3218. android_app {
  3219. name: "foo",
  3220. srcs: ["a.java"],
  3221. privapp_allowlist: "privapp_allowlist_com.android.foo.xml",
  3222. privileged: true,
  3223. sdk_version: "current",
  3224. }
  3225. override_android_app {
  3226. name: "bar",
  3227. base: "foo",
  3228. package_name: "com.google.android.foo",
  3229. }
  3230. `,
  3231. )
  3232. app := result.ModuleForTests("foo", "android_common")
  3233. overrideApp := result.ModuleForTests("foo", "android_common_bar")
  3234. // verify that privapp allowlist is created for override apps
  3235. overrideApp.Output("out/soong/.intermediates/foo/android_common_bar/privapp_allowlist_com.google.android.foo.xml")
  3236. expectedAllowlistInput := "privapp_allowlist_com.android.foo.xml"
  3237. overrideActualAllowlistInput := overrideApp.Rule("modifyAllowlist").Input.String()
  3238. if expectedAllowlistInput != overrideActualAllowlistInput {
  3239. t.Errorf("expected override allowlist to be %q; got %q", expectedAllowlistInput, overrideActualAllowlistInput)
  3240. }
  3241. // verify that permissions are copied to device
  3242. app.Output("out/soong/target/product/test_device/system/etc/permissions/foo.xml")
  3243. overrideApp.Output("out/soong/target/product/test_device/system/etc/permissions/bar.xml")
  3244. }
  3245. func TestPrivappAllowlistAndroidMk(t *testing.T) {
  3246. result := android.GroupFixturePreparers(
  3247. PrepareForTestWithJavaDefaultModules,
  3248. android.PrepareForTestWithAndroidMk,
  3249. ).RunTestWithBp(
  3250. t,
  3251. `
  3252. android_app {
  3253. name: "foo",
  3254. srcs: ["a.java"],
  3255. privapp_allowlist: "privapp_allowlist_com.android.foo.xml",
  3256. privileged: true,
  3257. sdk_version: "current",
  3258. }
  3259. override_android_app {
  3260. name: "bar",
  3261. base: "foo",
  3262. package_name: "com.google.android.foo",
  3263. }
  3264. `,
  3265. )
  3266. baseApp := result.ModuleForTests("foo", "android_common")
  3267. overrideApp := result.ModuleForTests("foo", "android_common_bar")
  3268. baseAndroidApp := baseApp.Module().(*AndroidApp)
  3269. baseEntries := android.AndroidMkEntriesForTest(t, result.TestContext, baseAndroidApp)[0]
  3270. android.AssertStringMatches(
  3271. t,
  3272. "androidmk has incorrect LOCAL_SOONG_INSTALLED_MODULE; expected to find foo.apk",
  3273. baseEntries.EntryMap["LOCAL_SOONG_INSTALLED_MODULE"][0],
  3274. "\\S+foo.apk",
  3275. )
  3276. android.AssertStringMatches(
  3277. t,
  3278. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include foo.apk",
  3279. baseEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3280. "\\S+foo.apk",
  3281. )
  3282. android.AssertStringMatches(
  3283. t,
  3284. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include app",
  3285. baseEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3286. "\\S+foo.apk:\\S+/target/product/test_device/system/priv-app/foo/foo.apk",
  3287. )
  3288. android.AssertStringMatches(
  3289. t,
  3290. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include privapp_allowlist",
  3291. baseEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3292. "privapp_allowlist_com.android.foo.xml:\\S+/target/product/test_device/system/etc/permissions/foo.xml",
  3293. )
  3294. overrideAndroidApp := overrideApp.Module().(*AndroidApp)
  3295. overrideEntries := android.AndroidMkEntriesForTest(t, result.TestContext, overrideAndroidApp)[0]
  3296. android.AssertStringMatches(
  3297. t,
  3298. "androidmk has incorrect LOCAL_SOONG_INSTALLED_MODULE; expected to find bar.apk",
  3299. overrideEntries.EntryMap["LOCAL_SOONG_INSTALLED_MODULE"][0],
  3300. "\\S+bar.apk",
  3301. )
  3302. android.AssertStringMatches(
  3303. t,
  3304. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include bar.apk",
  3305. overrideEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3306. "\\S+bar.apk",
  3307. )
  3308. android.AssertStringMatches(
  3309. t,
  3310. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include app",
  3311. overrideEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3312. "\\S+bar.apk:\\S+/target/product/test_device/system/priv-app/bar/bar.apk",
  3313. )
  3314. android.AssertStringMatches(
  3315. t,
  3316. "androidmk has incorrect LOCAL_SOONG_INSTALL_PAIRS; expected to it to include privapp_allowlist",
  3317. overrideEntries.EntryMap["LOCAL_SOONG_INSTALL_PAIRS"][0],
  3318. "\\S+soong/.intermediates/foo/android_common_bar/privapp_allowlist_com.google.android.foo.xml:\\S+/target/product/test_device/system/etc/permissions/bar.xml",
  3319. )
  3320. }