sanitize_test.go 46 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248
  1. // Copyright 2021 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package cc
  15. import (
  16. "fmt"
  17. "runtime"
  18. "strings"
  19. "testing"
  20. "android/soong/android"
  21. "github.com/google/blueprint"
  22. )
  23. var prepareForAsanTest = android.FixtureAddFile("asan/Android.bp", []byte(`
  24. cc_library_shared {
  25. name: "libclang_rt.asan",
  26. host_supported: true,
  27. }
  28. cc_library_static {
  29. name: "libclang_rt.asan.static",
  30. host_supported: true,
  31. }
  32. cc_library_static {
  33. name: "libclang_rt.asan_cxx.static",
  34. host_supported: true,
  35. }
  36. `))
  37. var prepareForTsanTest = android.FixtureAddFile("tsan/Android.bp", []byte(`
  38. cc_library_shared {
  39. name: "libclang_rt.tsan",
  40. host_supported: true,
  41. }
  42. `))
  43. type providerInterface interface {
  44. ModuleProvider(blueprint.Module, blueprint.ProviderKey) interface{}
  45. }
  46. // expectSharedLinkDep verifies that the from module links against the to module as a
  47. // shared library.
  48. func expectSharedLinkDep(t *testing.T, ctx providerInterface, from, to android.TestingModule) {
  49. t.Helper()
  50. fromLink := from.Description("link")
  51. toInfo := ctx.ModuleProvider(to.Module(), SharedLibraryInfoProvider).(SharedLibraryInfo)
  52. if g, w := fromLink.OrderOnly.Strings(), toInfo.SharedLibrary.RelativeToTop().String(); !android.InList(w, g) {
  53. t.Errorf("%s should link against %s, expected %q, got %q",
  54. from.Module(), to.Module(), w, g)
  55. }
  56. }
  57. // expectNoSharedLinkDep verifies that the from module links against the to module as a
  58. // shared library.
  59. func expectNoSharedLinkDep(t *testing.T, ctx providerInterface, from, to android.TestingModule) {
  60. t.Helper()
  61. fromLink := from.Description("link")
  62. toInfo := ctx.ModuleProvider(to.Module(), SharedLibraryInfoProvider).(SharedLibraryInfo)
  63. if g, w := fromLink.OrderOnly.Strings(), toInfo.SharedLibrary.RelativeToTop().String(); android.InList(w, g) {
  64. t.Errorf("%s should not link against %s, expected %q, got %q",
  65. from.Module(), to.Module(), w, g)
  66. }
  67. }
  68. // expectStaticLinkDep verifies that the from module links against the to module as a
  69. // static library.
  70. func expectStaticLinkDep(t *testing.T, ctx providerInterface, from, to android.TestingModule) {
  71. t.Helper()
  72. fromLink := from.Description("link")
  73. toInfo := ctx.ModuleProvider(to.Module(), StaticLibraryInfoProvider).(StaticLibraryInfo)
  74. if g, w := fromLink.Implicits.Strings(), toInfo.StaticLibrary.RelativeToTop().String(); !android.InList(w, g) {
  75. t.Errorf("%s should link against %s, expected %q, got %q",
  76. from.Module(), to.Module(), w, g)
  77. }
  78. }
  79. // expectNoStaticLinkDep verifies that the from module links against the to module as a
  80. // static library.
  81. func expectNoStaticLinkDep(t *testing.T, ctx providerInterface, from, to android.TestingModule) {
  82. t.Helper()
  83. fromLink := from.Description("link")
  84. toInfo := ctx.ModuleProvider(to.Module(), StaticLibraryInfoProvider).(StaticLibraryInfo)
  85. if g, w := fromLink.Implicits.Strings(), toInfo.StaticLibrary.RelativeToTop().String(); android.InList(w, g) {
  86. t.Errorf("%s should not link against %s, expected %q, got %q",
  87. from.Module(), to.Module(), w, g)
  88. }
  89. }
  90. // expectInstallDep verifies that the install rule of the from module depends on the
  91. // install rule of the to module.
  92. func expectInstallDep(t *testing.T, from, to android.TestingModule) {
  93. t.Helper()
  94. fromInstalled := from.Description("install")
  95. toInstalled := to.Description("install")
  96. // combine implicits and order-only dependencies, host uses implicit but device uses
  97. // order-only.
  98. got := append(fromInstalled.Implicits.Strings(), fromInstalled.OrderOnly.Strings()...)
  99. want := toInstalled.Output.String()
  100. if !android.InList(want, got) {
  101. t.Errorf("%s installation should depend on %s, expected %q, got %q",
  102. from.Module(), to.Module(), want, got)
  103. }
  104. }
  105. type expectedRuntimeLinkage int
  106. const (
  107. RUNTIME_LINKAGE_NONE = expectedRuntimeLinkage(0)
  108. RUNTIME_LINKAGE_SHARED = iota
  109. RUNTIME_LINKAGE_STATIC
  110. )
  111. func TestAsan(t *testing.T) {
  112. t.Parallel()
  113. bp := `
  114. cc_binary {
  115. name: "bin_with_asan",
  116. host_supported: true,
  117. shared_libs: [
  118. "libshared",
  119. "libasan",
  120. ],
  121. static_libs: [
  122. "libstatic",
  123. "libnoasan",
  124. "libstatic_asan",
  125. ],
  126. sanitize: {
  127. address: true,
  128. }
  129. }
  130. cc_binary {
  131. name: "bin_no_asan",
  132. host_supported: true,
  133. shared_libs: [
  134. "libshared",
  135. "libasan",
  136. ],
  137. static_libs: [
  138. "libstatic",
  139. "libnoasan",
  140. "libstatic_asan",
  141. ],
  142. }
  143. cc_library_shared {
  144. name: "libshared",
  145. host_supported: true,
  146. shared_libs: ["libtransitive"],
  147. }
  148. cc_library_shared {
  149. name: "libasan",
  150. host_supported: true,
  151. shared_libs: ["libtransitive"],
  152. sanitize: {
  153. address: true,
  154. }
  155. }
  156. cc_library_shared {
  157. name: "libtransitive",
  158. host_supported: true,
  159. }
  160. cc_library_static {
  161. name: "libstatic",
  162. host_supported: true,
  163. }
  164. cc_library_static {
  165. name: "libnoasan",
  166. host_supported: true,
  167. sanitize: {
  168. address: false,
  169. }
  170. }
  171. cc_library_static {
  172. name: "libstatic_asan",
  173. host_supported: true,
  174. sanitize: {
  175. address: true,
  176. }
  177. }
  178. `
  179. preparer := android.GroupFixturePreparers(
  180. prepareForCcTest,
  181. prepareForAsanTest,
  182. )
  183. buildOS := preparer.RunTestWithBp(t, bp).Config.BuildOSTarget.String()
  184. check := func(t *testing.T, variant string, runtimeLinkage expectedRuntimeLinkage, preparer android.FixturePreparer) {
  185. result := preparer.RunTestWithBp(t, bp)
  186. ctx := result.TestContext
  187. asanVariant := variant + "_asan"
  188. sharedVariant := variant + "_shared"
  189. sharedAsanVariant := sharedVariant + "_asan"
  190. staticVariant := variant + "_static"
  191. staticAsanVariant := staticVariant + "_asan"
  192. // The binaries, one with asan and one without
  193. binWithAsan := result.ModuleForTests("bin_with_asan", asanVariant)
  194. binNoAsan := result.ModuleForTests("bin_no_asan", variant)
  195. // Shared libraries that don't request asan
  196. libShared := result.ModuleForTests("libshared", sharedVariant)
  197. libTransitive := result.ModuleForTests("libtransitive", sharedVariant)
  198. // Shared library that requests asan
  199. libAsan := result.ModuleForTests("libasan", sharedAsanVariant)
  200. // Static library that uses an asan variant for bin_with_asan and a non-asan variant
  201. // for bin_no_asan.
  202. libStaticAsanVariant := result.ModuleForTests("libstatic", staticAsanVariant)
  203. libStaticNoAsanVariant := result.ModuleForTests("libstatic", staticVariant)
  204. // Static library that never uses asan.
  205. libNoAsan := result.ModuleForTests("libnoasan", staticVariant)
  206. // Static library that specifies asan
  207. libStaticAsan := result.ModuleForTests("libstatic_asan", staticAsanVariant)
  208. libStaticAsanNoAsanVariant := result.ModuleForTests("libstatic_asan", staticVariant)
  209. libAsanSharedRuntime := result.ModuleForTests("libclang_rt.asan", sharedVariant)
  210. libAsanStaticRuntime := result.ModuleForTests("libclang_rt.asan.static", staticVariant)
  211. libAsanStaticCxxRuntime := result.ModuleForTests("libclang_rt.asan_cxx.static", staticVariant)
  212. expectSharedLinkDep(t, ctx, binWithAsan, libShared)
  213. expectSharedLinkDep(t, ctx, binWithAsan, libAsan)
  214. expectSharedLinkDep(t, ctx, libShared, libTransitive)
  215. expectSharedLinkDep(t, ctx, libAsan, libTransitive)
  216. expectStaticLinkDep(t, ctx, binWithAsan, libStaticAsanVariant)
  217. expectStaticLinkDep(t, ctx, binWithAsan, libNoAsan)
  218. expectStaticLinkDep(t, ctx, binWithAsan, libStaticAsan)
  219. expectInstallDep(t, binWithAsan, libShared)
  220. expectInstallDep(t, binWithAsan, libAsan)
  221. expectInstallDep(t, binWithAsan, libTransitive)
  222. expectInstallDep(t, libShared, libTransitive)
  223. expectInstallDep(t, libAsan, libTransitive)
  224. expectSharedLinkDep(t, ctx, binNoAsan, libShared)
  225. expectSharedLinkDep(t, ctx, binNoAsan, libAsan)
  226. expectSharedLinkDep(t, ctx, libShared, libTransitive)
  227. expectSharedLinkDep(t, ctx, libAsan, libTransitive)
  228. expectStaticLinkDep(t, ctx, binNoAsan, libStaticNoAsanVariant)
  229. expectStaticLinkDep(t, ctx, binNoAsan, libNoAsan)
  230. expectStaticLinkDep(t, ctx, binNoAsan, libStaticAsanNoAsanVariant)
  231. expectInstallDep(t, binNoAsan, libShared)
  232. expectInstallDep(t, binNoAsan, libAsan)
  233. expectInstallDep(t, binNoAsan, libTransitive)
  234. expectInstallDep(t, libShared, libTransitive)
  235. expectInstallDep(t, libAsan, libTransitive)
  236. if runtimeLinkage == RUNTIME_LINKAGE_SHARED {
  237. expectSharedLinkDep(t, ctx, binWithAsan, libAsanSharedRuntime)
  238. expectNoSharedLinkDep(t, ctx, binNoAsan, libAsanSharedRuntime)
  239. expectSharedLinkDep(t, ctx, libAsan, libAsanSharedRuntime)
  240. expectNoSharedLinkDep(t, ctx, libShared, libAsanSharedRuntime)
  241. expectNoSharedLinkDep(t, ctx, libTransitive, libAsanSharedRuntime)
  242. } else {
  243. expectNoSharedLinkDep(t, ctx, binWithAsan, libAsanSharedRuntime)
  244. expectNoSharedLinkDep(t, ctx, binNoAsan, libAsanSharedRuntime)
  245. expectNoSharedLinkDep(t, ctx, libAsan, libAsanSharedRuntime)
  246. expectNoSharedLinkDep(t, ctx, libShared, libAsanSharedRuntime)
  247. expectNoSharedLinkDep(t, ctx, libTransitive, libAsanSharedRuntime)
  248. }
  249. if runtimeLinkage == RUNTIME_LINKAGE_STATIC {
  250. expectStaticLinkDep(t, ctx, binWithAsan, libAsanStaticRuntime)
  251. expectNoStaticLinkDep(t, ctx, binNoAsan, libAsanStaticRuntime)
  252. expectStaticLinkDep(t, ctx, libAsan, libAsanStaticRuntime)
  253. expectNoStaticLinkDep(t, ctx, libShared, libAsanStaticRuntime)
  254. expectNoStaticLinkDep(t, ctx, libTransitive, libAsanStaticRuntime)
  255. expectStaticLinkDep(t, ctx, binWithAsan, libAsanStaticCxxRuntime)
  256. expectNoStaticLinkDep(t, ctx, binNoAsan, libAsanStaticCxxRuntime)
  257. expectStaticLinkDep(t, ctx, libAsan, libAsanStaticCxxRuntime)
  258. expectNoStaticLinkDep(t, ctx, libShared, libAsanStaticCxxRuntime)
  259. expectNoStaticLinkDep(t, ctx, libTransitive, libAsanStaticCxxRuntime)
  260. } else {
  261. expectNoStaticLinkDep(t, ctx, binWithAsan, libAsanStaticRuntime)
  262. expectNoStaticLinkDep(t, ctx, binNoAsan, libAsanStaticRuntime)
  263. expectNoStaticLinkDep(t, ctx, libAsan, libAsanStaticRuntime)
  264. expectNoStaticLinkDep(t, ctx, libShared, libAsanStaticRuntime)
  265. expectNoStaticLinkDep(t, ctx, libTransitive, libAsanStaticRuntime)
  266. expectNoStaticLinkDep(t, ctx, binWithAsan, libAsanStaticCxxRuntime)
  267. expectNoStaticLinkDep(t, ctx, binNoAsan, libAsanStaticCxxRuntime)
  268. expectNoStaticLinkDep(t, ctx, libAsan, libAsanStaticCxxRuntime)
  269. expectNoStaticLinkDep(t, ctx, libShared, libAsanStaticCxxRuntime)
  270. expectNoStaticLinkDep(t, ctx, libTransitive, libAsanStaticCxxRuntime)
  271. }
  272. }
  273. t.Run("host", func(t *testing.T) { check(t, buildOS, RUNTIME_LINKAGE_NONE, preparer) })
  274. t.Run("device", func(t *testing.T) { check(t, "android_arm64_armv8-a", RUNTIME_LINKAGE_SHARED, preparer) })
  275. t.Run("host musl", func(t *testing.T) {
  276. check(t, "linux_musl_x86_64", RUNTIME_LINKAGE_STATIC,
  277. android.GroupFixturePreparers(preparer, PrepareForTestWithHostMusl))
  278. })
  279. }
  280. func TestTsan(t *testing.T) {
  281. t.Parallel()
  282. bp := `
  283. cc_binary {
  284. name: "bin_with_tsan",
  285. host_supported: true,
  286. shared_libs: [
  287. "libshared",
  288. "libtsan",
  289. ],
  290. sanitize: {
  291. thread: true,
  292. }
  293. }
  294. cc_binary {
  295. name: "bin_no_tsan",
  296. host_supported: true,
  297. shared_libs: [
  298. "libshared",
  299. "libtsan",
  300. ],
  301. }
  302. cc_library_shared {
  303. name: "libshared",
  304. host_supported: true,
  305. shared_libs: ["libtransitive"],
  306. }
  307. cc_library_shared {
  308. name: "libtsan",
  309. host_supported: true,
  310. shared_libs: ["libtransitive"],
  311. sanitize: {
  312. thread: true,
  313. }
  314. }
  315. cc_library_shared {
  316. name: "libtransitive",
  317. host_supported: true,
  318. }
  319. `
  320. preparer := android.GroupFixturePreparers(
  321. prepareForCcTest,
  322. prepareForTsanTest,
  323. )
  324. buildOS := preparer.RunTestWithBp(t, bp).Config.BuildOSTarget.String()
  325. check := func(t *testing.T, variant string, preparer android.FixturePreparer) {
  326. result := preparer.RunTestWithBp(t, bp)
  327. ctx := result.TestContext
  328. tsanVariant := variant + "_tsan"
  329. sharedVariant := variant + "_shared"
  330. sharedTsanVariant := sharedVariant + "_tsan"
  331. // The binaries, one with tsan and one without
  332. binWithTsan := result.ModuleForTests("bin_with_tsan", tsanVariant)
  333. binNoTsan := result.ModuleForTests("bin_no_tsan", variant)
  334. // Shared libraries that don't request tsan
  335. libShared := result.ModuleForTests("libshared", sharedVariant)
  336. libTransitive := result.ModuleForTests("libtransitive", sharedVariant)
  337. // Shared library that requests tsan
  338. libTsan := result.ModuleForTests("libtsan", sharedTsanVariant)
  339. expectSharedLinkDep(t, ctx, binWithTsan, libShared)
  340. expectSharedLinkDep(t, ctx, binWithTsan, libTsan)
  341. expectSharedLinkDep(t, ctx, libShared, libTransitive)
  342. expectSharedLinkDep(t, ctx, libTsan, libTransitive)
  343. expectSharedLinkDep(t, ctx, binNoTsan, libShared)
  344. expectSharedLinkDep(t, ctx, binNoTsan, libTsan)
  345. expectSharedLinkDep(t, ctx, libShared, libTransitive)
  346. expectSharedLinkDep(t, ctx, libTsan, libTransitive)
  347. }
  348. t.Run("host", func(t *testing.T) { check(t, buildOS, preparer) })
  349. t.Run("device", func(t *testing.T) { check(t, "android_arm64_armv8-a", preparer) })
  350. t.Run("host musl", func(t *testing.T) {
  351. check(t, "linux_musl_x86_64", android.GroupFixturePreparers(preparer, PrepareForTestWithHostMusl))
  352. })
  353. }
  354. func TestMiscUndefined(t *testing.T) {
  355. if runtime.GOOS != "linux" {
  356. t.Skip("requires linux")
  357. }
  358. t.Parallel()
  359. bp := `
  360. cc_binary {
  361. name: "bin_with_ubsan",
  362. srcs: ["src.cc"],
  363. host_supported: true,
  364. static_libs: [
  365. "libstatic",
  366. "libubsan",
  367. ],
  368. sanitize: {
  369. misc_undefined: ["integer"],
  370. }
  371. }
  372. cc_binary {
  373. name: "bin_no_ubsan",
  374. host_supported: true,
  375. srcs: ["src.cc"],
  376. static_libs: [
  377. "libstatic",
  378. "libubsan",
  379. ],
  380. }
  381. cc_library_static {
  382. name: "libstatic",
  383. host_supported: true,
  384. srcs: ["src.cc"],
  385. static_libs: ["libtransitive"],
  386. }
  387. cc_library_static {
  388. name: "libubsan",
  389. host_supported: true,
  390. srcs: ["src.cc"],
  391. whole_static_libs: ["libtransitive"],
  392. sanitize: {
  393. misc_undefined: ["integer"],
  394. }
  395. }
  396. cc_library_static {
  397. name: "libtransitive",
  398. host_supported: true,
  399. srcs: ["src.cc"],
  400. }
  401. `
  402. preparer := android.GroupFixturePreparers(
  403. prepareForCcTest,
  404. )
  405. buildOS := preparer.RunTestWithBp(t, bp).Config.BuildOSTarget.String()
  406. check := func(t *testing.T, variant string, preparer android.FixturePreparer) {
  407. result := preparer.RunTestWithBp(t, bp)
  408. ctx := result.TestContext
  409. staticVariant := variant + "_static"
  410. // The binaries, one with ubsan and one without
  411. binWithUbsan := result.ModuleForTests("bin_with_ubsan", variant)
  412. binNoUbsan := result.ModuleForTests("bin_no_ubsan", variant)
  413. // Static libraries that don't request ubsan
  414. libStatic := result.ModuleForTests("libstatic", staticVariant)
  415. libTransitive := result.ModuleForTests("libtransitive", staticVariant)
  416. libUbsan := result.ModuleForTests("libubsan", staticVariant)
  417. libUbsanMinimal := result.ModuleForTests("libclang_rt.ubsan_minimal", staticVariant)
  418. expectStaticLinkDep(t, ctx, binWithUbsan, libStatic)
  419. expectStaticLinkDep(t, ctx, binWithUbsan, libUbsan)
  420. expectStaticLinkDep(t, ctx, binWithUbsan, libUbsanMinimal)
  421. miscUndefinedSanFlag := "-fsanitize=integer"
  422. binWithUbsanCflags := binWithUbsan.Rule("cc").Args["cFlags"]
  423. if !strings.Contains(binWithUbsanCflags, miscUndefinedSanFlag) {
  424. t.Errorf("'bin_with_ubsan' Expected %q to be in flags %q, was not", miscUndefinedSanFlag, binWithUbsanCflags)
  425. }
  426. libStaticCflags := libStatic.Rule("cc").Args["cFlags"]
  427. if strings.Contains(libStaticCflags, miscUndefinedSanFlag) {
  428. t.Errorf("'libstatic' Expected %q to NOT be in flags %q, was", miscUndefinedSanFlag, binWithUbsanCflags)
  429. }
  430. libUbsanCflags := libUbsan.Rule("cc").Args["cFlags"]
  431. if !strings.Contains(libUbsanCflags, miscUndefinedSanFlag) {
  432. t.Errorf("'libubsan' Expected %q to be in flags %q, was not", miscUndefinedSanFlag, binWithUbsanCflags)
  433. }
  434. libTransitiveCflags := libTransitive.Rule("cc").Args["cFlags"]
  435. if strings.Contains(libTransitiveCflags, miscUndefinedSanFlag) {
  436. t.Errorf("'libtransitive': Expected %q to NOT be in flags %q, was", miscUndefinedSanFlag, binWithUbsanCflags)
  437. }
  438. expectStaticLinkDep(t, ctx, binNoUbsan, libStatic)
  439. expectStaticLinkDep(t, ctx, binNoUbsan, libUbsan)
  440. }
  441. t.Run("host", func(t *testing.T) { check(t, buildOS, preparer) })
  442. t.Run("device", func(t *testing.T) { check(t, "android_arm64_armv8-a", preparer) })
  443. t.Run("host musl", func(t *testing.T) {
  444. check(t, "linux_musl_x86_64", android.GroupFixturePreparers(preparer, PrepareForTestWithHostMusl))
  445. })
  446. }
  447. func TestFuzz(t *testing.T) {
  448. t.Parallel()
  449. bp := `
  450. cc_binary {
  451. name: "bin_with_fuzzer",
  452. host_supported: true,
  453. shared_libs: [
  454. "libshared",
  455. "libfuzzer",
  456. ],
  457. static_libs: [
  458. "libstatic",
  459. "libnofuzzer",
  460. "libstatic_fuzzer",
  461. ],
  462. sanitize: {
  463. fuzzer: true,
  464. }
  465. }
  466. cc_binary {
  467. name: "bin_no_fuzzer",
  468. host_supported: true,
  469. shared_libs: [
  470. "libshared",
  471. "libfuzzer",
  472. ],
  473. static_libs: [
  474. "libstatic",
  475. "libnofuzzer",
  476. "libstatic_fuzzer",
  477. ],
  478. }
  479. cc_library_shared {
  480. name: "libshared",
  481. host_supported: true,
  482. shared_libs: ["libtransitive"],
  483. }
  484. cc_library_shared {
  485. name: "libfuzzer",
  486. host_supported: true,
  487. shared_libs: ["libtransitive"],
  488. sanitize: {
  489. fuzzer: true,
  490. }
  491. }
  492. cc_library_shared {
  493. name: "libtransitive",
  494. host_supported: true,
  495. }
  496. cc_library_static {
  497. name: "libstatic",
  498. host_supported: true,
  499. }
  500. cc_library_static {
  501. name: "libnofuzzer",
  502. host_supported: true,
  503. sanitize: {
  504. fuzzer: false,
  505. }
  506. }
  507. cc_library_static {
  508. name: "libstatic_fuzzer",
  509. host_supported: true,
  510. }
  511. `
  512. result := android.GroupFixturePreparers(
  513. prepareForCcTest,
  514. ).RunTestWithBp(t, bp)
  515. check := func(t *testing.T, result *android.TestResult, variant string) {
  516. ctx := result.TestContext
  517. fuzzerVariant := variant + "_fuzzer"
  518. sharedVariant := variant + "_shared"
  519. sharedFuzzerVariant := sharedVariant + "_fuzzer"
  520. staticVariant := variant + "_static"
  521. staticFuzzerVariant := staticVariant + "_fuzzer"
  522. // The binaries, one with fuzzer and one without
  523. binWithFuzzer := result.ModuleForTests("bin_with_fuzzer", fuzzerVariant)
  524. binNoFuzzer := result.ModuleForTests("bin_no_fuzzer", variant)
  525. // Shared libraries that don't request fuzzer
  526. libShared := result.ModuleForTests("libshared", sharedVariant)
  527. libTransitive := result.ModuleForTests("libtransitive", sharedVariant)
  528. // Shared libraries that don't request fuzzer
  529. libSharedFuzzer := result.ModuleForTests("libshared", sharedFuzzerVariant)
  530. libTransitiveFuzzer := result.ModuleForTests("libtransitive", sharedFuzzerVariant)
  531. // Shared library that requests fuzzer
  532. libFuzzer := result.ModuleForTests("libfuzzer", sharedFuzzerVariant)
  533. // Static library that uses an fuzzer variant for bin_with_fuzzer and a non-fuzzer variant
  534. // for bin_no_fuzzer.
  535. libStaticFuzzerVariant := result.ModuleForTests("libstatic", staticFuzzerVariant)
  536. libStaticNoFuzzerVariant := result.ModuleForTests("libstatic", staticVariant)
  537. // Static library that never uses fuzzer.
  538. libNoFuzzer := result.ModuleForTests("libnofuzzer", staticVariant)
  539. // Static library that specifies fuzzer
  540. libStaticFuzzer := result.ModuleForTests("libstatic_fuzzer", staticFuzzerVariant)
  541. libStaticFuzzerNoFuzzerVariant := result.ModuleForTests("libstatic_fuzzer", staticVariant)
  542. expectSharedLinkDep(t, ctx, binWithFuzzer, libSharedFuzzer)
  543. expectSharedLinkDep(t, ctx, binWithFuzzer, libFuzzer)
  544. expectSharedLinkDep(t, ctx, libSharedFuzzer, libTransitiveFuzzer)
  545. expectSharedLinkDep(t, ctx, libFuzzer, libTransitiveFuzzer)
  546. expectStaticLinkDep(t, ctx, binWithFuzzer, libStaticFuzzerVariant)
  547. expectStaticLinkDep(t, ctx, binWithFuzzer, libNoFuzzer)
  548. expectStaticLinkDep(t, ctx, binWithFuzzer, libStaticFuzzer)
  549. expectSharedLinkDep(t, ctx, binNoFuzzer, libShared)
  550. expectSharedLinkDep(t, ctx, binNoFuzzer, libFuzzer)
  551. expectSharedLinkDep(t, ctx, libShared, libTransitive)
  552. expectSharedLinkDep(t, ctx, libFuzzer, libTransitiveFuzzer)
  553. expectStaticLinkDep(t, ctx, binNoFuzzer, libStaticNoFuzzerVariant)
  554. expectStaticLinkDep(t, ctx, binNoFuzzer, libNoFuzzer)
  555. expectStaticLinkDep(t, ctx, binNoFuzzer, libStaticFuzzerNoFuzzerVariant)
  556. }
  557. t.Run("device", func(t *testing.T) { check(t, result, "android_arm64_armv8-a") })
  558. }
  559. func TestUbsan(t *testing.T) {
  560. t.Parallel()
  561. if runtime.GOOS != "linux" {
  562. t.Skip("requires linux")
  563. }
  564. bp := `
  565. cc_binary {
  566. name: "bin_with_ubsan",
  567. host_supported: true,
  568. shared_libs: [
  569. "libshared",
  570. ],
  571. static_libs: [
  572. "libstatic",
  573. "libnoubsan",
  574. ],
  575. sanitize: {
  576. undefined: true,
  577. }
  578. }
  579. cc_binary {
  580. name: "bin_depends_ubsan_static",
  581. host_supported: true,
  582. shared_libs: [
  583. "libshared",
  584. ],
  585. static_libs: [
  586. "libstatic",
  587. "libubsan",
  588. "libnoubsan",
  589. ],
  590. }
  591. cc_binary {
  592. name: "bin_depends_ubsan_shared",
  593. host_supported: true,
  594. shared_libs: [
  595. "libsharedubsan",
  596. ],
  597. }
  598. cc_binary {
  599. name: "bin_no_ubsan",
  600. host_supported: true,
  601. shared_libs: [
  602. "libshared",
  603. ],
  604. static_libs: [
  605. "libstatic",
  606. "libnoubsan",
  607. ],
  608. }
  609. cc_library_shared {
  610. name: "libshared",
  611. host_supported: true,
  612. shared_libs: ["libtransitive"],
  613. }
  614. cc_library_shared {
  615. name: "libtransitive",
  616. host_supported: true,
  617. }
  618. cc_library_shared {
  619. name: "libsharedubsan",
  620. host_supported: true,
  621. sanitize: {
  622. undefined: true,
  623. }
  624. }
  625. cc_library_static {
  626. name: "libubsan",
  627. host_supported: true,
  628. sanitize: {
  629. undefined: true,
  630. }
  631. }
  632. cc_library_static {
  633. name: "libstatic",
  634. host_supported: true,
  635. }
  636. cc_library_static {
  637. name: "libnoubsan",
  638. host_supported: true,
  639. }
  640. `
  641. preparer := android.GroupFixturePreparers(
  642. prepareForCcTest,
  643. )
  644. buildOS := preparer.RunTestWithBp(t, bp).Config.BuildOSTarget.String()
  645. check := func(t *testing.T, variant string, preparer android.FixturePreparer) {
  646. result := preparer.RunTestWithBp(t, bp)
  647. staticVariant := variant + "_static"
  648. sharedVariant := variant + "_shared"
  649. minimalRuntime := result.ModuleForTests("libclang_rt.ubsan_minimal", staticVariant)
  650. // The binaries, one with ubsan and one without
  651. binWithUbsan := result.ModuleForTests("bin_with_ubsan", variant)
  652. binDependsUbsan := result.ModuleForTests("bin_depends_ubsan_static", variant)
  653. libSharedUbsan := result.ModuleForTests("libsharedubsan", sharedVariant)
  654. binDependsUbsanShared := result.ModuleForTests("bin_depends_ubsan_shared", variant)
  655. binNoUbsan := result.ModuleForTests("bin_no_ubsan", variant)
  656. android.AssertStringListContains(t, "missing libclang_rt.ubsan_minimal in bin_with_ubsan static libs",
  657. strings.Split(binWithUbsan.Rule("ld").Args["libFlags"], " "),
  658. minimalRuntime.OutputFiles(t, "")[0].String())
  659. android.AssertStringListContains(t, "missing libclang_rt.ubsan_minimal in bin_depends_ubsan_static static libs",
  660. strings.Split(binDependsUbsan.Rule("ld").Args["libFlags"], " "),
  661. minimalRuntime.OutputFiles(t, "")[0].String())
  662. android.AssertStringListContains(t, "missing libclang_rt.ubsan_minimal in libsharedubsan static libs",
  663. strings.Split(libSharedUbsan.Rule("ld").Args["libFlags"], " "),
  664. minimalRuntime.OutputFiles(t, "")[0].String())
  665. android.AssertStringListDoesNotContain(t, "unexpected libclang_rt.ubsan_minimal in bin_depends_ubsan_shared static libs",
  666. strings.Split(binDependsUbsanShared.Rule("ld").Args["libFlags"], " "),
  667. minimalRuntime.OutputFiles(t, "")[0].String())
  668. android.AssertStringListDoesNotContain(t, "unexpected libclang_rt.ubsan_minimal in bin_no_ubsan static libs",
  669. strings.Split(binNoUbsan.Rule("ld").Args["libFlags"], " "),
  670. minimalRuntime.OutputFiles(t, "")[0].String())
  671. android.AssertStringListContains(t, "missing -Wl,--exclude-libs for minimal runtime in bin_with_ubsan",
  672. strings.Split(binWithUbsan.Rule("ld").Args["ldFlags"], " "),
  673. "-Wl,--exclude-libs="+minimalRuntime.OutputFiles(t, "")[0].Base())
  674. android.AssertStringListContains(t, "missing -Wl,--exclude-libs for minimal runtime in bin_depends_ubsan_static static libs",
  675. strings.Split(binDependsUbsan.Rule("ld").Args["ldFlags"], " "),
  676. "-Wl,--exclude-libs="+minimalRuntime.OutputFiles(t, "")[0].Base())
  677. android.AssertStringListContains(t, "missing -Wl,--exclude-libs for minimal runtime in libsharedubsan static libs",
  678. strings.Split(libSharedUbsan.Rule("ld").Args["ldFlags"], " "),
  679. "-Wl,--exclude-libs="+minimalRuntime.OutputFiles(t, "")[0].Base())
  680. android.AssertStringListDoesNotContain(t, "unexpected -Wl,--exclude-libs for minimal runtime in bin_depends_ubsan_shared static libs",
  681. strings.Split(binDependsUbsanShared.Rule("ld").Args["ldFlags"], " "),
  682. "-Wl,--exclude-libs="+minimalRuntime.OutputFiles(t, "")[0].Base())
  683. android.AssertStringListDoesNotContain(t, "unexpected -Wl,--exclude-libs for minimal runtime in bin_no_ubsan static libs",
  684. strings.Split(binNoUbsan.Rule("ld").Args["ldFlags"], " "),
  685. "-Wl,--exclude-libs="+minimalRuntime.OutputFiles(t, "")[0].Base())
  686. }
  687. t.Run("host", func(t *testing.T) { check(t, buildOS, preparer) })
  688. t.Run("device", func(t *testing.T) { check(t, "android_arm64_armv8-a", preparer) })
  689. t.Run("host musl", func(t *testing.T) {
  690. check(t, "linux_musl_x86_64", android.GroupFixturePreparers(preparer, PrepareForTestWithHostMusl))
  691. })
  692. }
  693. type MemtagNoteType int
  694. const (
  695. None MemtagNoteType = iota + 1
  696. Sync
  697. Async
  698. )
  699. func (t MemtagNoteType) str() string {
  700. switch t {
  701. case None:
  702. return "none"
  703. case Sync:
  704. return "sync"
  705. case Async:
  706. return "async"
  707. default:
  708. panic("type_note_invalid")
  709. }
  710. }
  711. func checkHasMemtagNote(t *testing.T, m android.TestingModule, expected MemtagNoteType) {
  712. t.Helper()
  713. found := None
  714. ldFlags := m.Rule("ld").Args["ldFlags"]
  715. if strings.Contains(ldFlags, "-fsanitize-memtag-mode=async") {
  716. found = Async
  717. } else if strings.Contains(ldFlags, "-fsanitize-memtag-mode=sync") {
  718. found = Sync
  719. }
  720. if found != expected {
  721. t.Errorf("Wrong Memtag note in target %q: found %q, expected %q", m.Module().(*Module).Name(), found.str(), expected.str())
  722. }
  723. }
  724. var prepareForTestWithMemtagHeap = android.GroupFixturePreparers(
  725. android.FixtureModifyMockFS(func(fs android.MockFS) {
  726. templateBp := `
  727. cc_test {
  728. name: "unset_test_%[1]s",
  729. gtest: false,
  730. }
  731. cc_test {
  732. name: "no_memtag_test_%[1]s",
  733. gtest: false,
  734. sanitize: { memtag_heap: false },
  735. }
  736. cc_test {
  737. name: "set_memtag_test_%[1]s",
  738. gtest: false,
  739. sanitize: { memtag_heap: true },
  740. }
  741. cc_test {
  742. name: "set_memtag_set_async_test_%[1]s",
  743. gtest: false,
  744. sanitize: { memtag_heap: true, diag: { memtag_heap: false } },
  745. }
  746. cc_test {
  747. name: "set_memtag_set_sync_test_%[1]s",
  748. gtest: false,
  749. sanitize: { memtag_heap: true, diag: { memtag_heap: true } },
  750. }
  751. cc_test {
  752. name: "unset_memtag_set_sync_test_%[1]s",
  753. gtest: false,
  754. sanitize: { diag: { memtag_heap: true } },
  755. }
  756. cc_binary {
  757. name: "unset_binary_%[1]s",
  758. }
  759. cc_binary {
  760. name: "no_memtag_binary_%[1]s",
  761. sanitize: { memtag_heap: false },
  762. }
  763. cc_binary {
  764. name: "set_memtag_binary_%[1]s",
  765. sanitize: { memtag_heap: true },
  766. }
  767. cc_binary {
  768. name: "set_memtag_set_async_binary_%[1]s",
  769. sanitize: { memtag_heap: true, diag: { memtag_heap: false } },
  770. }
  771. cc_binary {
  772. name: "set_memtag_set_sync_binary_%[1]s",
  773. sanitize: { memtag_heap: true, diag: { memtag_heap: true } },
  774. }
  775. cc_binary {
  776. name: "unset_memtag_set_sync_binary_%[1]s",
  777. sanitize: { diag: { memtag_heap: true } },
  778. }
  779. `
  780. subdirNoOverrideBp := fmt.Sprintf(templateBp, "no_override")
  781. subdirOverrideDefaultDisableBp := fmt.Sprintf(templateBp, "override_default_disable")
  782. subdirSyncBp := fmt.Sprintf(templateBp, "override_default_sync")
  783. subdirAsyncBp := fmt.Sprintf(templateBp, "override_default_async")
  784. fs.Merge(android.MockFS{
  785. "subdir_no_override/Android.bp": []byte(subdirNoOverrideBp),
  786. "subdir_override_default_disable/Android.bp": []byte(subdirOverrideDefaultDisableBp),
  787. "subdir_sync/Android.bp": []byte(subdirSyncBp),
  788. "subdir_async/Android.bp": []byte(subdirAsyncBp),
  789. })
  790. }),
  791. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  792. variables.MemtagHeapExcludePaths = []string{"subdir_override_default_disable"}
  793. // "subdir_override_default_disable" is covered by both include and override_default_disable paths. override_default_disable wins.
  794. variables.MemtagHeapSyncIncludePaths = []string{"subdir_sync", "subdir_override_default_disable"}
  795. variables.MemtagHeapAsyncIncludePaths = []string{"subdir_async", "subdir_override_default_disable"}
  796. }),
  797. )
  798. func TestSanitizeMemtagHeap(t *testing.T) {
  799. t.Parallel()
  800. variant := "android_arm64_armv8-a"
  801. result := android.GroupFixturePreparers(
  802. prepareForCcTest,
  803. prepareForTestWithMemtagHeap,
  804. ).RunTest(t)
  805. ctx := result.TestContext
  806. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_no_override", variant), None)
  807. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_async", variant), None)
  808. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_disable", variant), None)
  809. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_sync", variant), None)
  810. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_no_override", variant), None)
  811. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_async", variant), None)
  812. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_disable", variant), None)
  813. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_sync", variant), None)
  814. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_no_override", variant), Async)
  815. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_async", variant), Async)
  816. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_disable", variant), Async)
  817. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_sync", variant), Sync)
  818. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_no_override", variant), Sync)
  819. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_async", variant), Sync)
  820. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_disable", variant), Sync)
  821. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_sync", variant), Sync)
  822. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_no_override", variant), Async)
  823. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_async", variant), Async)
  824. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_disable", variant), Async)
  825. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_sync", variant), Async)
  826. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_no_override", variant), Async)
  827. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_async", variant), Async)
  828. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_disable", variant), Async)
  829. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_sync", variant), Async)
  830. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_no_override", variant), Sync)
  831. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_async", variant), Sync)
  832. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_disable", variant), Sync)
  833. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_sync", variant), Sync)
  834. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_no_override", variant), Sync)
  835. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_async", variant), Sync)
  836. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_disable", variant), Sync)
  837. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_sync", variant), Sync)
  838. // should sanitize: { diag: { memtag: true } } result in Sync instead of None here?
  839. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_no_override", variant), None)
  840. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_async", variant), Sync)
  841. // should sanitize: { diag: { memtag: true } } result in Sync instead of None here?
  842. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_disable", variant), None)
  843. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_sync", variant), Sync)
  844. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_no_override", variant), Sync)
  845. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_async", variant), Sync)
  846. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_disable", variant), Sync)
  847. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_sync", variant), Sync)
  848. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_no_override", variant), None)
  849. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_async", variant), Async)
  850. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_disable", variant), None)
  851. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_sync", variant), Sync)
  852. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_no_override", variant), Sync)
  853. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_async", variant), Sync)
  854. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_disable", variant), Sync)
  855. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_sync", variant), Sync)
  856. }
  857. func TestSanitizeMemtagHeapWithSanitizeDevice(t *testing.T) {
  858. t.Parallel()
  859. variant := "android_arm64_armv8-a"
  860. result := android.GroupFixturePreparers(
  861. prepareForCcTest,
  862. prepareForTestWithMemtagHeap,
  863. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  864. variables.SanitizeDevice = []string{"memtag_heap"}
  865. }),
  866. ).RunTest(t)
  867. ctx := result.TestContext
  868. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_no_override", variant), None)
  869. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_async", variant), None)
  870. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_disable", variant), None)
  871. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_sync", variant), None)
  872. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_no_override", variant), None)
  873. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_async", variant), None)
  874. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_disable", variant), None)
  875. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_sync", variant), None)
  876. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_no_override", variant), Async)
  877. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_async", variant), Async)
  878. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_disable", variant), Async)
  879. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_sync", variant), Sync)
  880. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_no_override", variant), Sync)
  881. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_async", variant), Sync)
  882. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_disable", variant), Sync)
  883. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_sync", variant), Sync)
  884. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_no_override", variant), Async)
  885. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_async", variant), Async)
  886. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_disable", variant), Async)
  887. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_sync", variant), Async)
  888. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_no_override", variant), Async)
  889. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_async", variant), Async)
  890. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_disable", variant), Async)
  891. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_sync", variant), Async)
  892. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_no_override", variant), Sync)
  893. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_async", variant), Sync)
  894. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_disable", variant), Sync)
  895. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_sync", variant), Sync)
  896. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_no_override", variant), Sync)
  897. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_async", variant), Sync)
  898. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_disable", variant), Sync)
  899. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_sync", variant), Sync)
  900. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_no_override", variant), Sync)
  901. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_async", variant), Sync)
  902. // should sanitize: { diag: { memtag: true } } result in Sync instead of None here?
  903. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_disable", variant), None)
  904. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_sync", variant), Sync)
  905. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_no_override", variant), Sync)
  906. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_async", variant), Sync)
  907. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_disable", variant), Sync)
  908. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_sync", variant), Sync)
  909. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_no_override", variant), Async)
  910. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_async", variant), Async)
  911. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_disable", variant), None)
  912. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_sync", variant), Sync)
  913. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_no_override", variant), Sync)
  914. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_async", variant), Sync)
  915. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_disable", variant), Sync)
  916. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_sync", variant), Sync)
  917. }
  918. func TestSanitizeMemtagHeapWithSanitizeDeviceDiag(t *testing.T) {
  919. t.Parallel()
  920. variant := "android_arm64_armv8-a"
  921. result := android.GroupFixturePreparers(
  922. prepareForCcTest,
  923. prepareForTestWithMemtagHeap,
  924. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  925. variables.SanitizeDevice = []string{"memtag_heap"}
  926. variables.SanitizeDeviceDiag = []string{"memtag_heap"}
  927. }),
  928. ).RunTest(t)
  929. ctx := result.TestContext
  930. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_no_override", variant), None)
  931. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_async", variant), None)
  932. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_disable", variant), None)
  933. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_binary_override_default_sync", variant), None)
  934. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_no_override", variant), None)
  935. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_async", variant), None)
  936. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_disable", variant), None)
  937. checkHasMemtagNote(t, ctx.ModuleForTests("no_memtag_test_override_default_sync", variant), None)
  938. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_no_override", variant), Sync)
  939. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_async", variant), Sync)
  940. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_disable", variant), Sync)
  941. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_binary_override_default_sync", variant), Sync)
  942. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_no_override", variant), Sync)
  943. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_async", variant), Sync)
  944. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_disable", variant), Sync)
  945. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_test_override_default_sync", variant), Sync)
  946. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_no_override", variant), Async)
  947. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_async", variant), Async)
  948. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_disable", variant), Async)
  949. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_binary_override_default_sync", variant), Async)
  950. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_no_override", variant), Async)
  951. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_async", variant), Async)
  952. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_disable", variant), Async)
  953. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_async_test_override_default_sync", variant), Async)
  954. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_no_override", variant), Sync)
  955. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_async", variant), Sync)
  956. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_disable", variant), Sync)
  957. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_binary_override_default_sync", variant), Sync)
  958. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_no_override", variant), Sync)
  959. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_async", variant), Sync)
  960. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_disable", variant), Sync)
  961. checkHasMemtagNote(t, ctx.ModuleForTests("set_memtag_set_sync_test_override_default_sync", variant), Sync)
  962. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_no_override", variant), Sync)
  963. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_async", variant), Sync)
  964. // should sanitize: { diag: { memtag: true } } result in Sync instead of None here?
  965. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_disable", variant), None)
  966. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_binary_override_default_sync", variant), Sync)
  967. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_no_override", variant), Sync)
  968. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_async", variant), Sync)
  969. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_disable", variant), Sync)
  970. checkHasMemtagNote(t, ctx.ModuleForTests("unset_memtag_set_sync_test_override_default_sync", variant), Sync)
  971. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_no_override", variant), Sync)
  972. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_async", variant), Sync)
  973. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_disable", variant), None)
  974. checkHasMemtagNote(t, ctx.ModuleForTests("unset_binary_override_default_sync", variant), Sync)
  975. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_no_override", variant), Sync)
  976. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_async", variant), Sync)
  977. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_disable", variant), Sync)
  978. checkHasMemtagNote(t, ctx.ModuleForTests("unset_test_override_default_sync", variant), Sync)
  979. }
  980. func TestCfi(t *testing.T) {
  981. t.Parallel()
  982. bp := `
  983. cc_library_shared {
  984. name: "shared_with_cfi",
  985. static_libs: [
  986. "static_dep_with_cfi",
  987. "static_dep_no_cfi",
  988. ],
  989. sanitize: {
  990. cfi: true,
  991. },
  992. }
  993. cc_library_shared {
  994. name: "shared_no_cfi",
  995. static_libs: [
  996. "static_dep_with_cfi",
  997. "static_dep_no_cfi",
  998. ],
  999. }
  1000. cc_library_static {
  1001. name: "static_dep_with_cfi",
  1002. sanitize: {
  1003. cfi: true,
  1004. },
  1005. }
  1006. cc_library_static {
  1007. name: "static_dep_no_cfi",
  1008. }
  1009. cc_library_shared {
  1010. name: "shared_rdep_no_cfi",
  1011. static_libs: ["static_dep_with_cfi_2"],
  1012. }
  1013. cc_library_static {
  1014. name: "static_dep_with_cfi_2",
  1015. sanitize: {
  1016. cfi: true,
  1017. },
  1018. }
  1019. `
  1020. preparer := android.GroupFixturePreparers(
  1021. prepareForCcTest,
  1022. )
  1023. result := preparer.RunTestWithBp(t, bp)
  1024. ctx := result.TestContext
  1025. buildOs := "android_arm64_armv8-a"
  1026. shared_suffix := "_shared"
  1027. cfi_suffix := "_cfi"
  1028. static_suffix := "_static"
  1029. sharedWithCfiLib := result.ModuleForTests("shared_with_cfi", buildOs+shared_suffix+cfi_suffix)
  1030. sharedNoCfiLib := result.ModuleForTests("shared_no_cfi", buildOs+shared_suffix)
  1031. staticWithCfiLib := result.ModuleForTests("static_dep_with_cfi", buildOs+static_suffix)
  1032. staticWithCfiLibCfiVariant := result.ModuleForTests("static_dep_with_cfi", buildOs+static_suffix+cfi_suffix)
  1033. staticNoCfiLib := result.ModuleForTests("static_dep_no_cfi", buildOs+static_suffix)
  1034. staticNoCfiLibCfiVariant := result.ModuleForTests("static_dep_no_cfi", buildOs+static_suffix+cfi_suffix)
  1035. sharedRdepNoCfi := result.ModuleForTests("shared_rdep_no_cfi", buildOs+shared_suffix)
  1036. staticDepWithCfi2Lib := result.ModuleForTests("static_dep_with_cfi_2", buildOs+static_suffix)
  1037. // Confirm assumptions about propagation of CFI enablement
  1038. expectStaticLinkDep(t, ctx, sharedWithCfiLib, staticWithCfiLibCfiVariant)
  1039. expectStaticLinkDep(t, ctx, sharedNoCfiLib, staticWithCfiLib)
  1040. expectStaticLinkDep(t, ctx, sharedWithCfiLib, staticNoCfiLibCfiVariant)
  1041. expectStaticLinkDep(t, ctx, sharedNoCfiLib, staticNoCfiLib)
  1042. expectStaticLinkDep(t, ctx, sharedRdepNoCfi, staticDepWithCfi2Lib)
  1043. // Confirm that non-CFI variants do not add CFI flags
  1044. bazLibCflags := staticWithCfiLib.Rule("cc").Args["cFlags"]
  1045. if strings.Contains(bazLibCflags, "-fsanitize-cfi-cross-dso") {
  1046. t.Errorf("non-CFI variant of baz not expected to contain CFI flags ")
  1047. }
  1048. }