library_test.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590
  1. // Copyright 2017 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package cc
  15. import (
  16. "reflect"
  17. "testing"
  18. "android/soong/android"
  19. "android/soong/bazel/cquery"
  20. )
  21. func TestLibraryReuse(t *testing.T) {
  22. t.Parallel()
  23. t.Run("simple", func(t *testing.T) {
  24. ctx := testCc(t, `
  25. cc_library {
  26. name: "libfoo",
  27. srcs: ["foo.c", "baz.o"],
  28. }`)
  29. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  30. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  31. if len(libfooShared.Inputs) != 2 {
  32. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  33. }
  34. if len(libfooStatic.Inputs) != 2 {
  35. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  36. }
  37. if libfooShared.Inputs[0] != libfooStatic.Inputs[0] {
  38. t.Errorf("static object not reused for shared library")
  39. }
  40. if libfooShared.Inputs[1] != libfooStatic.Inputs[1] {
  41. t.Errorf("static object not reused for shared library")
  42. }
  43. })
  44. t.Run("extra static source", func(t *testing.T) {
  45. ctx := testCc(t, `
  46. cc_library {
  47. name: "libfoo",
  48. srcs: ["foo.c"],
  49. static: {
  50. srcs: ["bar.c"]
  51. },
  52. }`)
  53. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  54. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  55. if len(libfooShared.Inputs) != 1 {
  56. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  57. }
  58. if len(libfooStatic.Inputs) != 2 {
  59. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  60. }
  61. if libfooShared.Inputs[0] != libfooStatic.Inputs[0] {
  62. t.Errorf("static object not reused for shared library")
  63. }
  64. })
  65. t.Run("extra shared source", func(t *testing.T) {
  66. ctx := testCc(t, `
  67. cc_library {
  68. name: "libfoo",
  69. srcs: ["foo.c"],
  70. shared: {
  71. srcs: ["bar.c"]
  72. },
  73. }`)
  74. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  75. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  76. if len(libfooShared.Inputs) != 2 {
  77. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  78. }
  79. if len(libfooStatic.Inputs) != 1 {
  80. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  81. }
  82. if libfooShared.Inputs[0] != libfooStatic.Inputs[0] {
  83. t.Errorf("static object not reused for shared library")
  84. }
  85. })
  86. t.Run("extra static cflags", func(t *testing.T) {
  87. ctx := testCc(t, `
  88. cc_library {
  89. name: "libfoo",
  90. srcs: ["foo.c"],
  91. static: {
  92. cflags: ["-DFOO"],
  93. },
  94. }`)
  95. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  96. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  97. if len(libfooShared.Inputs) != 1 {
  98. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  99. }
  100. if len(libfooStatic.Inputs) != 1 {
  101. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  102. }
  103. if libfooShared.Inputs[0] == libfooStatic.Inputs[0] {
  104. t.Errorf("static object reused for shared library when it shouldn't be")
  105. }
  106. })
  107. t.Run("extra shared cflags", func(t *testing.T) {
  108. ctx := testCc(t, `
  109. cc_library {
  110. name: "libfoo",
  111. srcs: ["foo.c"],
  112. shared: {
  113. cflags: ["-DFOO"],
  114. },
  115. }`)
  116. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  117. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  118. if len(libfooShared.Inputs) != 1 {
  119. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  120. }
  121. if len(libfooStatic.Inputs) != 1 {
  122. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  123. }
  124. if libfooShared.Inputs[0] == libfooStatic.Inputs[0] {
  125. t.Errorf("static object reused for shared library when it shouldn't be")
  126. }
  127. })
  128. t.Run("global cflags for reused generated sources", func(t *testing.T) {
  129. ctx := testCc(t, `
  130. cc_library {
  131. name: "libfoo",
  132. srcs: [
  133. "foo.c",
  134. "a.proto",
  135. ],
  136. shared: {
  137. srcs: [
  138. "bar.c",
  139. ],
  140. },
  141. }`)
  142. libfooShared := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Rule("ld")
  143. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_static").Output("libfoo.a")
  144. if len(libfooShared.Inputs) != 3 {
  145. t.Fatalf("unexpected inputs to libfoo shared: %#v", libfooShared.Inputs.Strings())
  146. }
  147. if len(libfooStatic.Inputs) != 2 {
  148. t.Fatalf("unexpected inputs to libfoo static: %#v", libfooStatic.Inputs.Strings())
  149. }
  150. if !reflect.DeepEqual(libfooShared.Inputs[0:2].Strings(), libfooStatic.Inputs.Strings()) {
  151. t.Errorf("static objects not reused for shared library")
  152. }
  153. libfoo := ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_shared").Module().(*Module)
  154. if !inList("-DGOOGLE_PROTOBUF_NO_RTTI", libfoo.flags.Local.CFlags) {
  155. t.Errorf("missing protobuf cflags")
  156. }
  157. })
  158. }
  159. func TestStubsVersions(t *testing.T) {
  160. t.Parallel()
  161. bp := `
  162. cc_library {
  163. name: "libfoo",
  164. srcs: ["foo.c"],
  165. stubs: {
  166. versions: ["29", "R", "current"],
  167. },
  168. }
  169. `
  170. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  171. config.TestProductVariables.Platform_version_active_codenames = []string{"R"}
  172. ctx := testCcWithConfig(t, config)
  173. variants := ctx.ModuleVariantsForTests("libfoo")
  174. for _, expectedVer := range []string{"29", "R", "current"} {
  175. expectedVariant := "android_arm_armv7-a-neon_shared_" + expectedVer
  176. if !inList(expectedVariant, variants) {
  177. t.Errorf("missing expected variant: %q", expectedVariant)
  178. }
  179. }
  180. }
  181. func TestStubsVersions_NotSorted(t *testing.T) {
  182. t.Parallel()
  183. bp := `
  184. cc_library {
  185. name: "libfoo",
  186. srcs: ["foo.c"],
  187. stubs: {
  188. versions: ["29", "current", "R"],
  189. },
  190. }
  191. `
  192. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  193. config.TestProductVariables.Platform_version_active_codenames = []string{"R"}
  194. testCcErrorWithConfig(t, `"libfoo" .*: versions: not sorted`, config)
  195. }
  196. func TestStubsVersions_ParseError(t *testing.T) {
  197. t.Parallel()
  198. bp := `
  199. cc_library {
  200. name: "libfoo",
  201. srcs: ["foo.c"],
  202. stubs: {
  203. versions: ["29", "current", "X"],
  204. },
  205. }
  206. `
  207. testCcError(t, `"libfoo" .*: versions: "X" could not be parsed as an integer and is not a recognized codename`, bp)
  208. }
  209. func TestCcLibraryWithBazel(t *testing.T) {
  210. t.Parallel()
  211. bp := `
  212. cc_library {
  213. name: "foo",
  214. srcs: ["foo.cc"],
  215. bazel_module: { label: "//foo/bar:bar" },
  216. }`
  217. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  218. config.BazelContext = android.MockBazelContext{
  219. OutputBaseDir: "outputbase",
  220. LabelToCcInfo: map[string]cquery.CcInfo{
  221. "//foo/bar:bar": cquery.CcInfo{
  222. CcObjectFiles: []string{"foo.o"},
  223. Includes: []string{"include"},
  224. SystemIncludes: []string{"system_include"},
  225. Headers: []string{"foo.h"},
  226. RootDynamicLibraries: []string{"foo.so"},
  227. UnstrippedOutput: "foo_unstripped.so",
  228. },
  229. "//foo/bar:bar_bp2build_cc_library_static": cquery.CcInfo{
  230. CcObjectFiles: []string{"foo.o"},
  231. Includes: []string{"include"},
  232. SystemIncludes: []string{"system_include"},
  233. Headers: []string{"foo.h"},
  234. RootStaticArchives: []string{"foo.a"},
  235. },
  236. },
  237. }
  238. ctx := testCcWithConfig(t, config)
  239. staticFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_static").Module()
  240. outputFiles, err := staticFoo.(android.OutputFileProducer).OutputFiles("")
  241. if err != nil {
  242. t.Errorf("Unexpected error getting cc_object outputfiles %s", err)
  243. }
  244. expectedOutputFiles := []string{"outputbase/execroot/__main__/foo.a"}
  245. android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings())
  246. flagExporter := ctx.ModuleProvider(staticFoo, FlagExporterInfoProvider).(FlagExporterInfo)
  247. android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs)
  248. android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs)
  249. android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders)
  250. android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps)
  251. sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module()
  252. outputFiles, err = sharedFoo.(android.OutputFileProducer).OutputFiles("")
  253. if err != nil {
  254. t.Errorf("Unexpected error getting cc_library outputfiles %s", err)
  255. }
  256. expectedOutputFiles = []string{"outputbase/execroot/__main__/foo.so"}
  257. android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings())
  258. android.AssertStringEquals(t, "unstripped shared library", "outputbase/execroot/__main__/foo_unstripped.so", sharedFoo.(*Module).linker.unstrippedOutputFilePath().String())
  259. flagExporter = ctx.ModuleProvider(sharedFoo, FlagExporterInfoProvider).(FlagExporterInfo)
  260. android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs)
  261. android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs)
  262. android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders)
  263. android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps)
  264. }
  265. func TestCcLibraryWithBazelValidations(t *testing.T) {
  266. t.Parallel()
  267. bp := `
  268. cc_library {
  269. name: "foo",
  270. srcs: ["foo.cc"],
  271. bazel_module: { label: "//foo/bar:bar" },
  272. tidy: true,
  273. }`
  274. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  275. config.BazelContext = android.MockBazelContext{
  276. OutputBaseDir: "outputbase",
  277. LabelToCcInfo: map[string]cquery.CcInfo{
  278. "//foo/bar:bar": cquery.CcInfo{
  279. CcObjectFiles: []string{"foo.o"},
  280. Includes: []string{"include"},
  281. SystemIncludes: []string{"system_include"},
  282. Headers: []string{"foo.h"},
  283. RootDynamicLibraries: []string{"foo.so"},
  284. UnstrippedOutput: "foo_unstripped.so",
  285. },
  286. "//foo/bar:bar_bp2build_cc_library_static": cquery.CcInfo{
  287. CcObjectFiles: []string{"foo.o"},
  288. Includes: []string{"include"},
  289. SystemIncludes: []string{"system_include"},
  290. Headers: []string{"foo.h"},
  291. RootStaticArchives: []string{"foo.a"},
  292. TidyFiles: []string{"foo.c.tidy"},
  293. },
  294. },
  295. }
  296. ctx := android.GroupFixturePreparers(
  297. prepareForCcTest,
  298. android.FixtureMergeEnv(map[string]string{
  299. "ALLOW_LOCAL_TIDY_TRUE": "1",
  300. }),
  301. ).RunTestWithConfig(t, config).TestContext
  302. staticFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_static").Module()
  303. outputFiles, err := staticFoo.(android.OutputFileProducer).OutputFiles("")
  304. if err != nil {
  305. t.Errorf("Unexpected error getting cc_object outputfiles %s", err)
  306. }
  307. expectedOutputFiles := []string{"out/soong/.intermediates/foo/android_arm_armv7-a-neon_static/validated/foo.a"}
  308. android.AssertPathsRelativeToTopEquals(t, "output files", expectedOutputFiles, outputFiles)
  309. flagExporter := ctx.ModuleProvider(staticFoo, FlagExporterInfoProvider).(FlagExporterInfo)
  310. android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs)
  311. android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs)
  312. android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders)
  313. android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps)
  314. sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module()
  315. outputFiles, err = sharedFoo.(android.OutputFileProducer).OutputFiles("")
  316. if err != nil {
  317. t.Errorf("Unexpected error getting cc_library outputfiles %s", err)
  318. }
  319. expectedOutputFiles = []string{"outputbase/execroot/__main__/foo.so"}
  320. android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings())
  321. android.AssertStringEquals(t, "unstripped shared library", "outputbase/execroot/__main__/foo_unstripped.so", sharedFoo.(*Module).linker.unstrippedOutputFilePath().String())
  322. flagExporter = ctx.ModuleProvider(sharedFoo, FlagExporterInfoProvider).(FlagExporterInfo)
  323. android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs)
  324. android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs)
  325. android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders)
  326. android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps)
  327. }
  328. func TestLibraryVersionScript(t *testing.T) {
  329. t.Parallel()
  330. result := PrepareForIntegrationTestWithCc.RunTestWithBp(t, `
  331. cc_library {
  332. name: "libfoo",
  333. srcs: ["foo.c"],
  334. version_script: "foo.map.txt",
  335. }`)
  336. libfoo := result.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Rule("ld")
  337. android.AssertStringListContains(t, "missing dependency on version_script",
  338. libfoo.Implicits.Strings(), "foo.map.txt")
  339. android.AssertStringDoesContain(t, "missing flag for version_script",
  340. libfoo.Args["ldFlags"], "-Wl,--version-script,foo.map.txt")
  341. }
  342. func TestLibraryDynamicList(t *testing.T) {
  343. t.Parallel()
  344. result := PrepareForIntegrationTestWithCc.RunTestWithBp(t, `
  345. cc_library {
  346. name: "libfoo",
  347. srcs: ["foo.c"],
  348. dynamic_list: "foo.dynamic.txt",
  349. }`)
  350. libfoo := result.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Rule("ld")
  351. android.AssertStringListContains(t, "missing dependency on dynamic_list",
  352. libfoo.Implicits.Strings(), "foo.dynamic.txt")
  353. android.AssertStringDoesContain(t, "missing flag for dynamic_list",
  354. libfoo.Args["ldFlags"], "-Wl,--dynamic-list,foo.dynamic.txt")
  355. }
  356. func TestCcLibrarySharedWithBazelValidations(t *testing.T) {
  357. t.Parallel()
  358. bp := `
  359. cc_library_shared {
  360. name: "foo",
  361. srcs: ["foo.cc"],
  362. bazel_module: { label: "//foo/bar:bar" },
  363. tidy: true,
  364. }`
  365. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  366. config.BazelContext = android.MockBazelContext{
  367. OutputBaseDir: "outputbase",
  368. LabelToCcInfo: map[string]cquery.CcInfo{
  369. "//foo/bar:bar": cquery.CcInfo{
  370. CcObjectFiles: []string{"foo.o"},
  371. Includes: []string{"include"},
  372. SystemIncludes: []string{"system_include"},
  373. RootDynamicLibraries: []string{"foo.so"},
  374. TocFile: "foo.so.toc",
  375. TidyFiles: []string{"foo.c.tidy"},
  376. },
  377. },
  378. }
  379. ctx := android.GroupFixturePreparers(
  380. prepareForCcTest,
  381. android.FixtureMergeEnv(map[string]string{
  382. "ALLOW_LOCAL_TIDY_TRUE": "1",
  383. }),
  384. ).RunTestWithConfig(t, config).TestContext
  385. sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module()
  386. producer := sharedFoo.(android.OutputFileProducer)
  387. outputFiles, err := producer.OutputFiles("")
  388. if err != nil {
  389. t.Errorf("Unexpected error getting cc_object outputfiles %s", err)
  390. }
  391. expectedOutputFiles := []string{"out/soong/.intermediates/foo/android_arm_armv7-a-neon_shared/validated/foo.so"}
  392. android.AssertPathsRelativeToTopEquals(t, "output files", expectedOutputFiles, outputFiles)
  393. tocFilePath := sharedFoo.(*Module).Toc()
  394. if !tocFilePath.Valid() {
  395. t.Errorf("Invalid tocFilePath: %s", tocFilePath)
  396. }
  397. tocFile := tocFilePath.Path()
  398. expectedToc := "outputbase/execroot/__main__/foo.so.toc"
  399. android.AssertStringEquals(t, "toc file", expectedToc, tocFile.String())
  400. entries := android.AndroidMkEntriesForTest(t, ctx, sharedFoo)[0]
  401. expectedFlags := []string{"-Ioutputbase/execroot/__main__/include", "-isystem outputbase/execroot/__main__/system_include"}
  402. gotFlags := entries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  403. android.AssertDeepEquals(t, "androidmk exported cflags", expectedFlags, gotFlags)
  404. android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "cc_library_shared", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
  405. }
  406. func TestCcLibrarySharedWithBazel(t *testing.T) {
  407. t.Parallel()
  408. bp := `
  409. cc_library_shared {
  410. name: "foo",
  411. srcs: ["foo.cc"],
  412. bazel_module: { label: "//foo/bar:bar" },
  413. }`
  414. config := TestConfig(t.TempDir(), android.Android, nil, bp, nil)
  415. config.BazelContext = android.MockBazelContext{
  416. OutputBaseDir: "outputbase",
  417. LabelToCcInfo: map[string]cquery.CcInfo{
  418. "//foo/bar:bar": cquery.CcInfo{
  419. CcObjectFiles: []string{"foo.o"},
  420. Includes: []string{"include"},
  421. SystemIncludes: []string{"system_include"},
  422. RootDynamicLibraries: []string{"foo.so"},
  423. TocFile: "foo.so.toc",
  424. },
  425. },
  426. }
  427. ctx := testCcWithConfig(t, config)
  428. sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module()
  429. producer := sharedFoo.(android.OutputFileProducer)
  430. outputFiles, err := producer.OutputFiles("")
  431. if err != nil {
  432. t.Errorf("Unexpected error getting cc_object outputfiles %s", err)
  433. }
  434. expectedOutputFiles := []string{"outputbase/execroot/__main__/foo.so"}
  435. android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings())
  436. tocFilePath := sharedFoo.(*Module).Toc()
  437. if !tocFilePath.Valid() {
  438. t.Errorf("Invalid tocFilePath: %s", tocFilePath)
  439. }
  440. tocFile := tocFilePath.Path()
  441. expectedToc := "outputbase/execroot/__main__/foo.so.toc"
  442. android.AssertStringEquals(t, "toc file", expectedToc, tocFile.String())
  443. entries := android.AndroidMkEntriesForTest(t, ctx, sharedFoo)[0]
  444. expectedFlags := []string{"-Ioutputbase/execroot/__main__/include", "-isystem outputbase/execroot/__main__/system_include"}
  445. gotFlags := entries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  446. android.AssertDeepEquals(t, "androidmk exported cflags", expectedFlags, gotFlags)
  447. android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "cc_library_shared", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
  448. }
  449. func TestWholeStaticLibPrebuilts(t *testing.T) {
  450. t.Parallel()
  451. result := PrepareForIntegrationTestWithCc.RunTestWithBp(t, `
  452. cc_prebuilt_library_static {
  453. name: "libprebuilt",
  454. srcs: ["foo.a"],
  455. }
  456. cc_library_static {
  457. name: "libdirect",
  458. whole_static_libs: ["libprebuilt"],
  459. }
  460. cc_library_static {
  461. name: "libtransitive",
  462. whole_static_libs: ["libdirect"],
  463. }
  464. cc_library_static {
  465. name: "libdirect_with_srcs",
  466. srcs: ["bar.c"],
  467. whole_static_libs: ["libprebuilt"],
  468. }
  469. cc_library_static {
  470. name: "libtransitive_with_srcs",
  471. srcs: ["baz.c"],
  472. whole_static_libs: ["libdirect_with_srcs"],
  473. }
  474. `)
  475. libdirect := result.ModuleForTests("libdirect", "android_arm64_armv8-a_static").Rule("arWithLibs")
  476. libtransitive := result.ModuleForTests("libtransitive", "android_arm64_armv8-a_static").Rule("arWithLibs")
  477. libdirectWithSrcs := result.ModuleForTests("libdirect_with_srcs", "android_arm64_armv8-a_static").Rule("arWithLibs")
  478. libtransitiveWithSrcs := result.ModuleForTests("libtransitive_with_srcs", "android_arm64_armv8-a_static").Rule("arWithLibs")
  479. barObj := result.ModuleForTests("libdirect_with_srcs", "android_arm64_armv8-a_static").Rule("cc")
  480. bazObj := result.ModuleForTests("libtransitive_with_srcs", "android_arm64_armv8-a_static").Rule("cc")
  481. android.AssertStringListContains(t, "missing dependency on foo.a",
  482. libdirect.Inputs.Strings(), "foo.a")
  483. android.AssertStringDoesContain(t, "missing flag for foo.a",
  484. libdirect.Args["arLibs"], "foo.a")
  485. android.AssertStringListContains(t, "missing dependency on foo.a",
  486. libtransitive.Inputs.Strings(), "foo.a")
  487. android.AssertStringDoesContain(t, "missing flag for foo.a",
  488. libtransitive.Args["arLibs"], "foo.a")
  489. android.AssertStringListContains(t, "missing dependency on foo.a",
  490. libdirectWithSrcs.Inputs.Strings(), "foo.a")
  491. android.AssertStringDoesContain(t, "missing flag for foo.a",
  492. libdirectWithSrcs.Args["arLibs"], "foo.a")
  493. android.AssertStringListContains(t, "missing dependency on bar.o",
  494. libdirectWithSrcs.Inputs.Strings(), barObj.Output.String())
  495. android.AssertStringDoesContain(t, "missing flag for bar.o",
  496. libdirectWithSrcs.Args["arObjs"], barObj.Output.String())
  497. android.AssertStringListContains(t, "missing dependency on foo.a",
  498. libtransitiveWithSrcs.Inputs.Strings(), "foo.a")
  499. android.AssertStringDoesContain(t, "missing flag for foo.a",
  500. libtransitiveWithSrcs.Args["arLibs"], "foo.a")
  501. android.AssertStringListContains(t, "missing dependency on bar.o",
  502. libtransitiveWithSrcs.Inputs.Strings(), barObj.Output.String())
  503. android.AssertStringDoesContain(t, "missing flag for bar.o",
  504. libtransitiveWithSrcs.Args["arObjs"], barObj.Output.String())
  505. android.AssertStringListContains(t, "missing dependency on baz.o",
  506. libtransitiveWithSrcs.Inputs.Strings(), bazObj.Output.String())
  507. android.AssertStringDoesContain(t, "missing flag for baz.o",
  508. libtransitiveWithSrcs.Args["arObjs"], bazObj.Output.String())
  509. }