123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217 |
- // Copyright 2017 Google Inc. All rights reserved.
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- // This file implements the logic of bpfix and also provides a programmatic interface
- package bpfix
- import (
- "bytes"
- "fmt"
- "reflect"
- "strings"
- "testing"
- "github.com/google/blueprint/parser"
- "github.com/google/blueprint/pathtools"
- )
- // TODO(jeffrygaston) remove this when position is removed from ParseNode (in b/38325146) and we can directly do reflect.DeepEqual
- func printListOfStrings(items []string) (text string) {
- if len(items) == 0 {
- return "[]"
- }
- return fmt.Sprintf("[\"%s\"]", strings.Join(items, "\", \""))
- }
- func buildTree(local_include_dirs []string, export_include_dirs []string) (file *parser.File, errs []error) {
- // TODO(jeffrygaston) use the builder class when b/38325146 is done
- input := fmt.Sprintf(`cc_library_shared {
- name: "iAmAModule",
- local_include_dirs: %s,
- export_include_dirs: %s,
- }
- `,
- printListOfStrings(local_include_dirs), printListOfStrings(export_include_dirs))
- tree, errs := parser.Parse("", strings.NewReader(input), parser.NewScope(nil))
- if len(errs) > 0 {
- errs = append([]error{fmt.Errorf("failed to parse:\n%s", input)}, errs...)
- }
- return tree, errs
- }
- func implFilterListTest(t *testing.T, local_include_dirs []string, export_include_dirs []string, expectedResult []string) {
- // build tree
- tree, errs := buildTree(local_include_dirs, export_include_dirs)
- if len(errs) > 0 {
- t.Error("failed to build tree")
- for _, err := range errs {
- t.Error(err)
- }
- t.Fatalf("%d parse errors", len(errs))
- }
- fixer := NewFixer(tree)
- // apply simplifications
- err := runPatchListMod(simplifyKnownPropertiesDuplicatingEachOther)(fixer)
- if len(errs) > 0 {
- t.Fatal(err)
- }
- // lookup legacy property
- mod := fixer.tree.Defs[0].(*parser.Module)
- expectedResultString := fmt.Sprintf("%q", expectedResult)
- if expectedResult == nil {
- expectedResultString = "unset"
- }
- // check that the value for the legacy property was updated to the correct value
- errorHeader := fmt.Sprintf("\nFailed to correctly simplify key 'local_include_dirs' in the presence of 'export_include_dirs.'\n"+
- "original local_include_dirs: %q\n"+
- "original export_include_dirs: %q\n"+
- "expected result: %s\n"+
- "actual result: ",
- local_include_dirs, export_include_dirs, expectedResultString)
- result, found := mod.GetProperty("local_include_dirs")
- if !found {
- if expectedResult == nil {
- return
- }
- t.Fatal(errorHeader + "property not found")
- }
- listResult, ok := result.Value.(*parser.List)
- if !ok {
- t.Fatalf("%sproperty is not a list: %v", errorHeader, listResult)
- }
- if expectedResult == nil {
- t.Fatalf("%sproperty exists: %v", errorHeader, listResult)
- }
- actualExpressions := listResult.Values
- actualValues := make([]string, 0)
- for _, expr := range actualExpressions {
- str := expr.(*parser.String)
- actualValues = append(actualValues, str.Value)
- }
- if !reflect.DeepEqual(actualValues, expectedResult) {
- t.Fatalf("%s%q\nlists are different", errorHeader, actualValues)
- }
- }
- func TestSimplifyKnownVariablesDuplicatingEachOther(t *testing.T) {
- // TODO use []Expression{} once buildTree above can support it (which is after b/38325146 is done)
- implFilterListTest(t, []string{"include"}, []string{"include"}, nil)
- implFilterListTest(t, []string{"include1"}, []string{"include2"}, []string{"include1"})
- implFilterListTest(t, []string{"include1", "include2", "include3", "include4"}, []string{"include2"},
- []string{"include1", "include3", "include4"})
- implFilterListTest(t, []string{}, []string{"include"}, []string{})
- implFilterListTest(t, []string{}, []string{}, []string{})
- }
- func checkError(t *testing.T, in, expectedErr string, innerTest func(*Fixer) error) {
- expected := preProcessOutErr(expectedErr)
- runTestOnce(t, in, expected, innerTest)
- }
- func runTestOnce(t *testing.T, in, expected string, innerTest func(*Fixer) error) {
- fixer, err := preProcessIn(in)
- if err != nil {
- t.Fatal(err)
- }
- out, err := runFixerOnce(fixer, innerTest)
- if err != nil {
- out = err.Error()
- }
- compareResult := compareOutExpected(in, out, expected)
- if len(compareResult) > 0 {
- t.Errorf(compareResult)
- }
- }
- func preProcessOutErr(expectedErr string) string {
- expected := strings.TrimSpace(expectedErr)
- return expected
- }
- func preProcessOut(out string) (expected string, err error) {
- expected, err = Reformat(out)
- if err != nil {
- return expected, err
- }
- return expected, nil
- }
- func preProcessIn(in string) (fixer *Fixer, err error) {
- in, err = Reformat(in)
- if err != nil {
- return fixer, err
- }
- tree, errs := parser.Parse("<testcase>", bytes.NewBufferString(in), parser.NewScope(nil))
- if errs != nil {
- return fixer, err
- }
- fixer = NewFixer(tree)
- return fixer, nil
- }
- func runFixerOnce(fixer *Fixer, innerTest func(*Fixer) error) (string, error) {
- err := innerTest(fixer)
- if err != nil {
- return "", err
- }
- out, err := parser.Print(fixer.tree)
- if err != nil {
- return "", err
- }
- return string(out), nil
- }
- func compareOutExpected(in, out, expected string) string {
- if out != expected {
- return fmt.Sprintf("output didn't match:\ninput:\n%s\n\nexpected:\n%s\ngot:\n%s\n",
- in, expected, out)
- }
- return ""
- }
- func runPassOnce(t *testing.T, in, out string, innerTest func(*Fixer) error) {
- expected, err := preProcessOut(out)
- if err != nil {
- t.Fatal(err)
- }
- runTestOnce(t, in, expected, innerTest)
- }
- func runPass(t *testing.T, in, out string, innerTest func(*Fixer) error) {
- expected, err := preProcessOut(out)
- if err != nil {
- t.Fatal(err)
- }
- fixer, err := preProcessIn(in)
- if err != nil {
- t.Fatal(err)
- }
- got := ""
- prev := "foo"
- passes := 0
- for got != prev && passes < 10 {
- out, err = runFixerOnce(fixer, innerTest)
- if err != nil {
- t.Fatal(err)
- }
- prev = got
- got = string(out)
- passes++
- }
- compareResult := compareOutExpected(in, out, expected)
- if len(compareResult) > 0 {
- t.Errorf(compareResult)
- }
- }
- func TestMergeMatchingProperties(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "empty",
- in: `
- java_library {
- name: "foo",
- static_libs: [],
- static_libs: [],
- }
- `,
- out: `
- java_library {
- name: "foo",
- static_libs: [],
- }
- `,
- },
- {
- name: "single line into multiline",
- in: `
- java_library {
- name: "foo",
- static_libs: [
- "a",
- "b",
- ],
- //c1
- static_libs: ["c" /*c2*/],
- }
- `,
- out: `
- java_library {
- name: "foo",
- static_libs: [
- "a",
- "b",
- "c", /*c2*/
- ],
- //c1
- }
- `,
- },
- {
- name: "multiline into multiline",
- in: `
- java_library {
- name: "foo",
- static_libs: [
- "a",
- "b",
- ],
- //c1
- static_libs: [
- //c2
- "c", //c3
- "d",
- ],
- }
- `,
- out: `
- java_library {
- name: "foo",
- static_libs: [
- "a",
- "b",
- //c2
- "c", //c3
- "d",
- ],
- //c1
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return runPatchListMod(mergeMatchingModuleProperties)(fixer)
- })
- })
- }
- }
- func TestReorderCommonProperties(t *testing.T) {
- var tests = []struct {
- name string
- in string
- out string
- }{
- {
- name: "empty",
- in: `cc_library {}`,
- out: `cc_library {}`,
- },
- {
- name: "only priority",
- in: `
- cc_library {
- name: "foo",
- }
- `,
- out: `
- cc_library {
- name: "foo",
- }
- `,
- },
- {
- name: "already in order",
- in: `
- cc_library {
- name: "foo",
- defaults: ["bar"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- defaults: ["bar"],
- }
- `,
- },
- {
- name: "reorder only priority",
- in: `
- cc_library {
- defaults: ["bar"],
- name: "foo",
- }
- `,
- out: `
- cc_library {
- name: "foo",
- defaults: ["bar"],
- }
- `,
- },
- {
- name: "reorder",
- in: `
- cc_library {
- name: "foo",
- srcs: ["a.c"],
- host_supported: true,
- defaults: ["bar"],
- shared_libs: ["baz"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- defaults: ["bar"],
- host_supported: true,
- srcs: ["a.c"],
- shared_libs: ["baz"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return runPatchListMod(reorderCommonProperties)(fixer)
- })
- })
- }
- }
- func TestRemoveMatchingModuleListProperties(t *testing.T) {
- var tests = []struct {
- name string
- in string
- out string
- }{
- {
- name: "simple",
- in: `
- cc_library {
- name: "foo",
- foo: ["a"],
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- bar: ["a"],
- }
- `,
- },
- {
- name: "long",
- in: `
- cc_library {
- name: "foo",
- foo: [
- "a",
- "b",
- ],
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- foo: [
- "b",
- ],
- bar: ["a"],
- }
- `,
- },
- {
- name: "long fully removed",
- in: `
- cc_library {
- name: "foo",
- foo: [
- "a",
- ],
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- bar: ["a"],
- }
- `,
- },
- {
- name: "comment",
- in: `
- cc_library {
- name: "foo",
- // comment
- foo: ["a"],
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- // comment
- bar: ["a"],
- }
- `,
- },
- {
- name: "inner comment",
- in: `
- cc_library {
- name: "foo",
- foo: [
- // comment
- "a",
- ],
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- bar: ["a"],
- }
- `,
- },
- {
- name: "eol comment",
- in: `
- cc_library {
- name: "foo",
- foo: ["a"], // comment
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- // comment
- bar: ["a"],
- }
- `,
- },
- {
- name: "eol comment with blank lines",
- in: `
- cc_library {
- name: "foo",
- foo: ["a"], // comment
- // bar
- bar: ["a"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- // comment
- // bar
- bar: ["a"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return runPatchListMod(func(mod *parser.Module, buf []byte, patchList *parser.PatchList) error {
- return removeMatchingModuleListProperties(mod, patchList, "bar", "foo")
- })(fixer)
- })
- })
- }
- }
- func TestReplaceJavaStaticLibs(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "static lib",
- in: `
- java_library_static {
- name: "foo",
- }
- `,
- out: `
- java_library {
- name: "foo",
- }
- `,
- },
- {
- name: "java lib",
- in: `
- java_library {
- name: "foo",
- }
- `,
- out: `
- java_library {
- name: "foo",
- }
- `,
- },
- {
- name: "java installable lib",
- in: `
- java_library {
- name: "foo",
- installable: true,
- }
- `,
- out: `
- java_library {
- name: "foo",
- installable: true,
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteJavaStaticLibs(fixer)
- })
- })
- }
- }
- func TestRewritePrebuilts(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "jar srcs",
- in: `
- java_import {
- name: "foo",
- srcs: ["foo.jar"],
- }
- `,
- out: `
- java_import {
- name: "foo",
- jars: ["foo.jar"],
- }
- `,
- },
- {
- name: "aar srcs",
- in: `
- java_import {
- name: "foo",
- srcs: ["foo.aar"],
- installable: true,
- }
- `,
- out: `
- android_library_import {
- name: "foo",
- aars: ["foo.aar"],
- }
- `,
- },
- {
- name: "host prebuilt",
- in: `
- java_import {
- name: "foo",
- srcs: ["foo.jar"],
- host: true,
- }
- `,
- out: `
- java_import_host {
- name: "foo",
- jars: ["foo.jar"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteIncorrectAndroidmkPrebuilts(fixer)
- })
- })
- }
- }
- func TestRewriteCtsModuleTypes(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "cts_support_package",
- in: `
- cts_support_package {
- name: "foo",
- }
- `,
- out: `
- android_test_helper_app {
- name: "foo",
- defaults: ["cts_support_defaults"],
- }
- `,
- },
- {
- name: "cts_package",
- in: `
- cts_package {
- name: "foo",
- }
- `,
- out: `
- android_test {
- name: "foo",
- defaults: ["cts_defaults"],
- }
- `,
- },
- {
- name: "cts_target_java_library",
- in: `
- cts_target_java_library {
- name: "foo",
- }
- `,
- out: `
- java_library {
- name: "foo",
- defaults: ["cts_defaults"],
- }
- `,
- },
- {
- name: "cts_host_java_library",
- in: `
- cts_host_java_library {
- name: "foo",
- }
- `,
- out: `
- java_library_host {
- name: "foo",
- defaults: ["cts_defaults"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, rewriteCtsModuleTypes)
- })
- }
- }
- func TestRewritePrebuiltEtc(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "prebuilt_etc src",
- in: `
- prebuilt_etc {
- name: "foo",
- srcs: ["bar"],
- }
- `,
- out: `prebuilt_etc {
- name: "foo",
- src: "bar",
- }
- `,
- },
- {
- name: "prebuilt_etc src",
- in: `
- prebuilt_etc {
- name: "foo",
- srcs: FOO,
- }
- `,
- out: `prebuilt_etc {
- name: "foo",
- src: FOO,
- }
- `,
- },
- {
- name: "prebuilt_etc src",
- in: `
- prebuilt_etc {
- name: "foo",
- srcs: ["bar", "baz"],
- }
- `,
- out: `prebuilt_etc {
- name: "foo",
- src: "ERROR: LOCAL_SRC_FILES should contain at most one item",
- }
- `,
- },
- {
- name: "prebuilt_etc sub_dir",
- in: `
- prebuilt_etc {
- name: "foo",
- src: "bar",
- sub_dir: "baz",
- }
- `,
- out: `prebuilt_etc {
- name: "foo",
- src: "bar",
- relative_install_path: "baz",
- }
- `,
- },
- {
- name: "prebuilt_etc sub_dir",
- in: `
- prebuilt_etc_host {
- name: "foo",
- src: "bar",
- local_module_path: {
- var: "HOST_OUT",
- fixed: "/etc/baz",
- },
- }
- `,
- out: `prebuilt_etc_host {
- name: "foo",
- src: "bar",
- relative_install_path: "baz",
- }
- `,
- },
- {
- name: "prebuilt_etc sub_dir",
- in: `
- prebuilt_etc_host {
- name: "foo",
- src: "bar",
- local_module_path: {
- var: "HOST_OUT",
- fixed: "/baz/sub",
- },
- }
- `,
- out: `prebuilt_root_host {
- name: "foo",
- src: "bar",
- relative_install_path: "baz/sub",
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteAndroidmkPrebuiltEtc(fixer)
- })
- })
- }
- }
- func TestRewriteAndroidTest(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "android_test valid module path",
- in: `
- android_test {
- name: "foo",
- local_module_path: {
- var: "TARGET_OUT_DATA_APPS",
- },
- }
- `,
- out: `
- android_test {
- name: "foo",
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteAndroidTest(fixer)
- })
- })
- }
- }
- func TestRewriteAndroidAppImport(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "android_app_import apk",
- in: `
- android_app_import {
- name: "foo",
- srcs: ["package.apk"],
- }
- `,
- out: `
- android_app_import {
- name: "foo",
- apk: "package.apk",
- }
- `,
- },
- {
- name: "android_app_import presigned",
- in: `
- android_app_import {
- name: "foo",
- apk: "package.apk",
- certificate: "PRESIGNED",
- }
- `,
- out: `
- android_app_import {
- name: "foo",
- apk: "package.apk",
- presigned: true,
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteAndroidAppImport(fixer)
- })
- })
- }
- }
- func TestRemoveEmptyLibDependencies(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "remove sole shared lib",
- in: `
- cc_library {
- name: "foo",
- shared_libs: ["libhwbinder"],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- }
- `,
- },
- {
- name: "remove a shared lib",
- in: `
- cc_library {
- name: "foo",
- shared_libs: [
- "libhwbinder",
- "libfoo",
- "libhidltransport",
- ],
- }
- `,
- out: `
- cc_library {
- name: "foo",
- shared_libs: [
- "libfoo",
- ],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return removeEmptyLibDependencies(fixer)
- })
- })
- }
- }
- func TestRemoveHidlInterfaceTypes(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "remove types",
- in: `
- hidl_interface {
- name: "foo@1.0",
- types: ["ParcelFooBar"],
- }
- `,
- out: `
- hidl_interface {
- name: "foo@1.0",
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return removeHidlInterfaceTypes(fixer)
- })
- })
- }
- }
- func TestRemoveSoongConfigBoolVariable(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "remove bool",
- in: `
- soong_config_module_type {
- name: "foo",
- variables: ["bar", "baz"],
- }
- soong_config_bool_variable {
- name: "bar",
- }
- soong_config_string_variable {
- name: "baz",
- }
- `,
- out: `
- soong_config_module_type {
- name: "foo",
- variables: [
- "baz"
- ],
- bool_variables: ["bar"],
- }
- soong_config_string_variable {
- name: "baz",
- }
- `,
- },
- {
- name: "existing bool_variables",
- in: `
- soong_config_module_type {
- name: "foo",
- variables: ["baz"],
- bool_variables: ["bar"],
- }
- soong_config_bool_variable {
- name: "baz",
- }
- `,
- out: `
- soong_config_module_type {
- name: "foo",
- bool_variables: ["bar", "baz"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, removeSoongConfigBoolVariable)
- })
- }
- }
- func TestRemoveNestedProperty(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- propertyName string
- }{
- {
- name: "remove no nesting",
- in: `
- cc_library {
- name: "foo",
- foo: true,
- }`,
- out: `
- cc_library {
- name: "foo",
- }
- `,
- propertyName: "foo",
- },
- {
- name: "remove one nest",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: true,
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- }
- `,
- propertyName: "foo.bar",
- },
- {
- name: "remove one nest, multiple props",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: true,
- baz: false,
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- foo: {
- baz: false,
- },
- }
- `,
- propertyName: "foo.bar",
- },
- {
- name: "remove multiple nest",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- baz: {
- a: true,
- }
- },
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- }
- `,
- propertyName: "foo.bar.baz.a",
- },
- {
- name: "remove multiple nest, outer non-empty",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- baz: {
- a: true,
- }
- },
- other: true,
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- foo: {
- other: true,
- },
- }
- `,
- propertyName: "foo.bar.baz.a",
- },
- {
- name: "remove multiple nest, inner non-empty",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- baz: {
- a: true,
- },
- other: true,
- },
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- other: true,
- },
- },
- }
- `,
- propertyName: "foo.bar.baz.a",
- },
- {
- name: "remove multiple nest, inner-most non-empty",
- in: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- baz: {
- a: true,
- other: true,
- },
- },
- },
- }`,
- out: `
- cc_library {
- name: "foo",
- foo: {
- bar: {
- baz: {
- other: true,
- },
- },
- },
- }
- `,
- propertyName: "foo.bar.baz.a",
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, runPatchListMod(removeObsoleteProperty(test.propertyName)))
- })
- }
- }
- func TestRemoveObsoleteProperties(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "remove property",
- in: `
- cc_library_shared {
- name: "foo",
- product_variables: {
- other: {
- bar: true,
- },
- pdk: {
- enabled: false,
- },
- },
- }
- `,
- out: `
- cc_library_shared {
- name: "foo",
- product_variables: {
- other: {
- bar: true,
- },
- },
- }
- `,
- },
- {
- name: "remove property and empty product_variables",
- in: `
- cc_library_shared {
- name: "foo",
- product_variables: {
- pdk: {
- enabled: false,
- },
- },
- }
- `,
- out: `
- cc_library_shared {
- name: "foo",
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, runPatchListMod(removeObsoleteProperty("product_variables.pdk")))
- })
- }
- }
- func TestRewriteRuntimeResourceOverlay(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "product_specific runtime_resource_overlay",
- in: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- product_specific: true,
- }
- `,
- out: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- product_specific: true,
- }
- `,
- },
- {
- // It's probably wrong for runtime_resource_overlay not to be product specific, but let's not
- // debate it here.
- name: "non-product_specific runtime_resource_overlay",
- in: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- product_specific: false,
- }
- `,
- out: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- product_specific: false,
- }
- `,
- },
- {
- name: "runtime_resource_overlay without product_specific value",
- in: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- }
- `,
- out: `
- runtime_resource_overlay {
- name: "foo",
- resource_dirs: ["res"],
- product_specific: true,
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return RewriteRuntimeResourceOverlay(fixer)
- })
- })
- }
- }
- func TestRewriteTestModuleTypes(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "cc_binary with test_suites",
- in: `
- cc_binary {
- name: "foo",
- srcs: ["srcs"],
- test_suites: ["test_suite1"],
- }
- `,
- out: `
- cc_test {
- name: "foo",
- srcs: ["srcs"],
- test_suites: ["test_suite1"],
- }
- `,
- },
- {
- name: "cc_binary without test_suites",
- in: `
- cc_binary {
- name: "foo",
- srcs: ["srcs"],
- }
- `,
- out: `
- cc_binary {
- name: "foo",
- srcs: ["srcs"],
- }
- `,
- },
- {
- name: "android_app with android_test",
- in: `
- android_app {
- name: "foo",
- srcs: ["srcs"],
- test_suites: ["test_suite1"],
- }
- `,
- out: `
- android_test {
- name: "foo",
- srcs: ["srcs"],
- test_suites: ["test_suite1"],
- }
- `,
- },
- {
- name: "android_app without test_suites",
- in: `
- android_app {
- name: "foo",
- srcs: ["srcs"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- srcs: ["srcs"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, func(fixer *Fixer) error {
- return rewriteTestModuleTypes(fixer)
- })
- })
- }
- }
- func TestFormatFlagProperty(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "group options and values for apptflags, dxflags, javacflags, and kotlincflags",
- in: `
- android_test {
- name: "foo",
- aaptflags: [
- // comment1_1
- "--flag1",
- // comment1_2
- "1",
- // comment2_1
- // comment2_2
- "--flag2",
- // comment3_1
- // comment3_2
- // comment3_3
- "--flag3",
- // comment3_4
- // comment3_5
- // comment3_6
- "3",
- // other comment1_1
- // other comment1_2
- ],
- dxflags: [
- "--flag1",
- // comment1_1
- "1",
- // comment2_1
- "--flag2",
- // comment3_1
- "--flag3",
- // comment3_2
- "3",
- ],
- javacflags: [
- "--flag1",
- "1",
- "--flag2",
- "--flag3",
- "3",
- ],
- kotlincflags: [
- "--flag1",
- "1",
- "--flag2",
- "--flag3",
- "3",
- ],
- }
- `,
- out: `
- android_test {
- name: "foo",
- aaptflags: [
- // comment1_1
- // comment1_2
- "--flag1 1",
- // comment2_1
- // comment2_2
- "--flag2",
- // comment3_1
- // comment3_2
- // comment3_3
- // comment3_4
- // comment3_5
- // comment3_6
- "--flag3 3",
- // other comment1_1
- // other comment1_2
- ],
- dxflags: [
- // comment1_1
- "--flag1 1",
- // comment2_1
- "--flag2",
- // comment3_1
- // comment3_2
- "--flag3 3",
- ],
- javacflags: [
- "--flag1 1",
- "--flag2",
- "--flag3 3",
- ],
- kotlincflags: [
- "--flag1 1",
- "--flag2",
- "--flag3 3",
- ],
- }
- `,
- },
- {
- name: "group options and values for asflags, cflags, clang_asflags, clang_cflags, conlyflags, cppflags, ldflags, and tidy_flags",
- in: `
- cc_test {
- name: "foo",
- asflags: [
- // comment1_1
- "--flag1",
- "1",
- // comment2_1
- // comment2_2
- "--flag2",
- // comment2_3
- "2",
- // comment3_1
- // comment3_2
- "--flag3",
- // comment3_3
- // comment3_4
- // comment3_4
- "3",
- // comment4_1
- // comment4_2
- // comment4_3
- "--flag4",
- ],
- cflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- clang_asflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- clang_cflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- conlyflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- cppflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- ldflags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- tidy_flags: [
- "--flag1",
- "1",
- "--flag2",
- "2",
- "--flag3",
- "3",
- "--flag4",
- ],
- }
- `,
- out: `
- cc_test {
- name: "foo",
- asflags: [
- // comment1_1
- "--flag1 1",
- // comment2_1
- // comment2_2
- // comment2_3
- "--flag2 2",
- // comment3_1
- // comment3_2
- // comment3_3
- // comment3_4
- // comment3_4
- "--flag3 3",
- // comment4_1
- // comment4_2
- // comment4_3
- "--flag4",
- ],
- cflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- clang_asflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- clang_cflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- conlyflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- cppflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- ldflags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- tidy_flags: [
- "--flag1 1",
- "--flag2 2",
- "--flag3 3",
- "--flag4",
- ],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPass(t, test.in, test.out, runPatchListMod(formatFlagProperties))
- })
- }
- }
- func TestRewriteLicenseProperty(t *testing.T) {
- mockFs := pathtools.MockFs(map[string][]byte{
- "a/b/c/d/Android.mk": []byte("this is not important."),
- "a/b/LicenseFile1": []byte("LicenseFile1"),
- "a/b/LicenseFile2": []byte("LicenseFile2"),
- "a/b/Android.bp": []byte("license {\n\tname: \"reuse_a_b_license\",\n}\n"),
- })
- relativePath := "a/b/c/d"
- relativePathErr := "a/b/c"
- tests := []struct {
- name string
- in string
- fs pathtools.FileSystem
- path string
- out string
- }{
- {
- name: "license rewriting with one module",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- `,
- out: `
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "Android-Apache-2.0",
- ],
- }
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- `,
- },
- {
- name: "license rewriting with two modules",
- in: `
- android_test {
- name: "foo1",
- android_license_kinds: ["license_kind1"],
- android_license_conditions: ["license_notice1"],
- }
- android_test {
- name: "foo2",
- android_license_kinds: ["license_kind2"],
- android_license_conditions: ["license_notice2"],
- }
- `,
- out: `
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "Android-Apache-2.0",
- ],
- }
- android_test {
- name: "foo1",
- android_license_kinds: ["license_kind1"],
- android_license_conditions: ["license_notice1"],
- }
- android_test {
- name: "foo2",
- android_license_kinds: ["license_kind2"],
- android_license_conditions: ["license_notice2"],
- }
- `,
- },
- {
- name: "license rewriting with license files in the current directory",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: ["LicenseFile1", "LicenseFile2",],
- }
- `,
- fs: mockFs,
- path: relativePath,
- out: `
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "a_b_c_d_license",
- ],
- }
- license {
- name: "a_b_c_d_license",
- visibility: [":__subpackages__"],
- license_kinds: [
- "license_kind",
- ],
- license_text: [
- "LicenseFile1",
- "LicenseFile2",
- ],
- }
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: [
- "LicenseFile1",
- "LicenseFile2",
- ],
- }
- `,
- },
- {
- name: "license rewriting with license files outside the current directory",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: ["../../LicenseFile1", "../../LicenseFile2",],
- }
- `,
- fs: mockFs,
- path: relativePath,
- out: `
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "reuse_a_b_license",
- ],
- }
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: [
- "../../LicenseFile1",
- "../../LicenseFile2",
- ],
- }
- `,
- },
- {
- name: "license rewriting with no Android.bp file in the expected location",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: ["../../LicenseFile1", "../../LicenseFile2",],
- }
- `,
- fs: pathtools.MockFs(map[string][]byte{
- "a/b/c/d/Android.mk": []byte("this is not important."),
- "a/b/LicenseFile1": []byte("LicenseFile1"),
- "a/b/LicenseFile2": []byte("LicenseFile2"),
- "a/Android.bp": []byte("license {\n\tname: \"reuse_a_b_license\",\n}\n"),
- }),
- path: relativePath,
- out: `
- // Error: No Android.bp file is found at path
- // a/b
- // Please add one there with the needed license module first.
- // Then reset the default_applicable_licenses property below with the license module name.
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "",
- ],
- }
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: [
- "../../LicenseFile1",
- "../../LicenseFile2",
- ],
- }
- `,
- },
- {
- name: "license rewriting with an Android.bp file without a license module",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: ["../../LicenseFile1", "../../LicenseFile2",],
- }
- `,
- fs: pathtools.MockFs(map[string][]byte{
- "a/b/c/d/Android.mk": []byte("this is not important."),
- "a/b/LicenseFile1": []byte("LicenseFile1"),
- "a/b/LicenseFile2": []byte("LicenseFile2"),
- "a/b/Android.bp": []byte("non_license {\n\tname: \"reuse_a_b_license\",\n}\n"),
- }),
- path: relativePath,
- out: `
- // Error: Cannot get the name of the license module in the
- // a/b/Android.bp file.
- // If no such license module exists, please add one there first.
- // Then reset the default_applicable_licenses property below with the license module name.
- package {
- // See: http://go/android-license-faq
- default_applicable_licenses: [
- "",
- ],
- }
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: [
- "../../LicenseFile1",
- "../../LicenseFile2",
- ],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPassOnce(t, test.in, test.out, runPatchListMod(rewriteLicenseProperty(test.fs, test.path)))
- })
- }
- testErrs := []struct {
- name string
- in string
- fs pathtools.FileSystem
- path string
- expectedErr string
- }{
- {
- name: "license rewriting with a wrong path",
- in: `
- android_test {
- name: "foo",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- android_license_files: ["../../LicenseFile1", "../../LicenseFile2",],
- }
- `,
- fs: mockFs,
- path: relativePathErr,
- expectedErr: `
- Cannot find an Android.mk file at path "a/b/c"
- `,
- },
- }
- for _, test := range testErrs {
- t.Run(test.name, func(t *testing.T) {
- checkError(t, test.in, test.expectedErr, runPatchListMod(rewriteLicenseProperty(test.fs, test.path)))
- })
- }
- }
- func TestHaveSameLicense(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "two modules with the same license",
- in: `
- android_test {
- name: "foo1",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- android_test {
- name: "foo2",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- `,
- out: `
- android_test {
- name: "foo1",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- android_test {
- name: "foo2",
- android_license_kinds: ["license_kind"],
- android_license_conditions: ["license_notice"],
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPassOnce(t, test.in, test.out, func(fixer *Fixer) error {
- return haveSameLicense(fixer)
- })
- })
- }
- testErrs := []struct {
- name string
- in string
- expectedErr string
- }{
- {
- name: "two modules will different licenses",
- in: `
- android_test {
- name: "foo1",
- android_license_kinds: ["license_kind1"],
- android_license_conditions: ["license_notice1"],
- }
- android_test {
- name: "foo2",
- android_license_kinds: ["license_kind2"],
- android_license_conditions: ["license_notice2"],
- }
- `,
- expectedErr: `
- Modules foo1 and foo2 are expected to have the same android_license_kinds property.
- `,
- },
- }
- for _, test := range testErrs {
- t.Run(test.name, func(t *testing.T) {
- checkError(t, test.in, test.expectedErr, func(fixer *Fixer) error {
- return haveSameLicense(fixer)
- })
- })
- }
- }
- func TestRemoveResourceAndAssetsIfDefault(t *testing.T) {
- tests := []struct {
- name string
- in string
- out string
- }{
- {
- name: "resource_dirs default",
- in: `
- android_app {
- name: "foo",
- resource_dirs: ["res"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- }
- `,
- },
- {
- name: "resource_dirs not default",
- in: `
- android_app {
- name: "foo",
- resource_dirs: ["reso"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- resource_dirs: ["reso"],
- }
- `,
- },
- {
- name: "resource_dirs includes not default",
- in: `
- android_app {
- name: "foo",
- resource_dirs: ["res", "reso"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- resource_dirs: ["res", "reso"],
- }
- `,
- }, {
- name: "asset_dirs default",
- in: `
- android_app {
- name: "foo",
- asset_dirs: ["assets"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- }
- `,
- },
- {
- name: "asset_dirs not default",
- in: `
- android_app {
- name: "foo",
- asset_dirs: ["assety"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- asset_dirs: ["assety"],
- }
- `,
- },
- {
- name: "asset_dirs includes not default",
- in: `
- android_app {
- name: "foo",
- asset_dirs: ["assets", "assety"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- asset_dirs: ["assets", "assety"],
- }
- `,
- },
- {
- name: "resource_dirs and asset_dirs both default",
- in: `
- android_app {
- name: "foo",
- asset_dirs: ["assets"],
- resource_dirs: ["res"],
- }
- `,
- out: `
- android_app {
- name: "foo",
- }
- `,
- },
- }
- for _, test := range tests {
- t.Run(test.name, func(t *testing.T) {
- runPassOnce(t, test.in, test.out, func(fixer *Fixer) error {
- return removeResourceAndAssetsIfDefault(fixer)
- })
- })
- }
- }
|