12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075 |
- package android
- import (
- "reflect"
- "testing"
- "github.com/google/blueprint"
- )
- var visibilityTests = []struct {
- name string
- fs MockFS
- expectedErrors []string
- effectiveVisibility map[qualifiedModuleName][]string
- }{
- {
- name: "invalid visibility: empty list",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [],
- }`),
- },
- expectedErrors: []string{`visibility: must contain at least one visibility rule`},
- },
- {
- name: "invalid visibility: empty rule",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [""],
- }`),
- },
- expectedErrors: []string{`visibility: invalid visibility pattern ""`},
- },
- {
- name: "invalid visibility: unqualified",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["target"],
- }`),
- },
- expectedErrors: []string{`visibility: invalid visibility pattern "target"`},
- },
- {
- name: "invalid visibility: empty namespace",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//"],
- }`),
- },
- expectedErrors: []string{`visibility: invalid visibility pattern "//"`},
- },
- {
- name: "invalid visibility: empty module",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [":"],
- }`),
- },
- expectedErrors: []string{`visibility: invalid visibility pattern ":"`},
- },
- {
- name: "invalid visibility: empty namespace and module",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//:"],
- }`),
- },
- expectedErrors: []string{`visibility: invalid visibility pattern "//:"`},
- },
- {
- name: "//visibility:unknown",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:unknown"],
- }`),
- },
- expectedErrors: []string{`unrecognized visibility rule "//visibility:unknown"`},
- },
- {
- name: "//visibility:xxx mixed",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public", "//namespace"],
- }
- mock_library {
- name: "libother",
- visibility: ["//visibility:private", "//namespace"],
- }`),
- },
- expectedErrors: []string{
- `module "libother": visibility: cannot mix "//visibility:private"` +
- ` with any other visibility rules`,
- `module "libexample": visibility: cannot mix "//visibility:public"` +
- ` with any other visibility rules`,
- },
- },
- {
- name: "//visibility:legacy_public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:legacy_public"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: //visibility:legacy_public must` +
- ` not be used`,
- },
- },
- {
- // Verify that //visibility:public will allow the module to be referenced from anywhere, e.g.
- // the current directory, a nested directory and a directory in a separate tree.
- name: "//visibility:public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- // Verify that //visibility:private allows the module to be referenced from the current
- // directory only.
- name: "//visibility:private",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnested" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Verify that //visibility:private allows the module to be referenced from the current
- // directory only.
- name: "//visibility:private (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "nested-notice" references "//top:libexample" which is not visible to this` +
- ` module\nYou may need to add "//top/nested" to its visibility`,
- `module "other-notice" references "//top:libexample" which is not visible to this module\n` +
- `You may need to add "//other" to its visibility`,
- },
- },
- {
- // Verify that :__pkg__ allows the module to be referenced from the current directory only.
- name: ":__pkg__",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [":__pkg__"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnested" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Verify that :__pkg__ allows the module to be referenced from the current directory only.
- name: ":__pkg__ (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [":__pkg__"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "nested-notice" references "//top:libexample" which is not visible to this module`,
- `module "other-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- // Verify that //top/nested allows the module to be referenced from the current directory and
- // the top/nested directory only, not a subdirectory of top/nested and not peak directory.
- name: "//top/nested",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "top/nested/again/Android.bp": []byte(`
- mock_library {
- name: "libnestedagain",
- deps: ["libexample"],
- }`),
- "peak/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- `module "libnestedagain" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Verify that //top/nested allows the module to be referenced from the current directory and
- // the top/nested directory only, not a subdirectory of top/nested and not peak directory.
- name: "//top/nested (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "top/nested/again/Android.bp": []byte(`
- gen_notice {
- name: "nestedagain-notice",
- for: ["libexample"],
- }`),
- "peak/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "other-notice" references "//top:libexample" which is not visible to this module`,
- `module "nestedagain-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- // Verify that :__subpackages__ allows the module to be referenced from the current directory
- // and sub directories but nowhere else.
- name: ":__subpackages__",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [":__subpackages__"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "peak/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Verify that :__subpackages__ allows the module to be referenced from the current directory
- // and sub directories but nowhere else.
- name: ":__subpackages__ (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: [":__subpackages__"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "peak/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "other-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- // Verify that //top/nested:__subpackages__ allows the module to be referenced from the current
- // directory and sub directories but nowhere else.
- name: "//top/nested:__subpackages__",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested:__subpackages__", "//other"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "top/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Verify that //top/nested:__subpackages__ allows the module to be referenced from the current
- // directory and sub directories but nowhere else.
- name: "//top/nested:__subpackages__ (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested:__subpackages__", "//other"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "top/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "other-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- // Verify that ["//top/nested", "//peak:__subpackages"] allows the module to be referenced from
- // the current directory, top/nested and peak and all its subpackages.
- name: `["//top/nested", "//peak:__subpackages__"]`,
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested", "//peak:__subpackages__"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "peak/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- },
- {
- // Verify that ["//top/nested", "//peak:__subpackages"] allows the module to be referenced from
- // the current directory, top/nested and peak and all its subpackages.
- name: `["//top/nested", "//peak:__subpackages__ (notices)"]`,
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//top/nested", "//peak:__subpackages__"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "peak/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- // Verify that //vendor... cannot be used outside vendor apart from //vendor:__subpackages__
- name: `//vendor`,
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//vendor:__subpackages__"],
- }
- mock_library {
- name: "libsamepackage",
- visibility: ["//vendor/apps/AcmeSettings"],
- }`),
- "vendor/Android.bp": []byte(`
- mock_library {
- name: "libvendorexample",
- deps: ["libexample"],
- visibility: ["//vendor/nested"],
- }`),
- "vendor/nested/Android.bp": []byte(`
- mock_library {
- name: "libvendornested",
- deps: ["libexample", "libvendorexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libsamepackage": visibility: "//vendor/apps/AcmeSettings"` +
- ` is not allowed. Packages outside //vendor cannot make themselves visible to specific` +
- ` targets within //vendor, they can only use //vendor:__subpackages__.`,
- },
- },
- // Defaults propagation tests
- {
- // Check that visibility is the union of the defaults modules.
- name: "defaults union, basic",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//other"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//top/nested"],
- defaults: ["libexample_defaults"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // Check that visibility is the union of the defaults modules.
- name: "defaults union, basic (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//other"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//top/nested"],
- defaults: ["libexample_defaults"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "defaults union, multiple defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//other"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//top/nested"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "defaults union, multiple defaults (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//other"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//top/nested"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "//visibility:public mixed with other in defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public", "//namespace"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample_defaults": visibility: cannot mix "//visibility:public"` +
- ` with any other visibility rules`,
- },
- },
- {
- name: "//visibility:public overriding defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- defaults: ["libexample_defaults"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- effectiveVisibility: map[qualifiedModuleName][]string{
- qualifiedModuleName{pkg: "top", name: "libexample"}: {"//visibility:public"},
- },
- },
- {
- name: "//visibility:public overriding defaults (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- defaults: ["libexample_defaults"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- effectiveVisibility: map[qualifiedModuleName][]string{
- qualifiedModuleName{pkg: "top", name: "libexample"}: {"//visibility:public"},
- },
- },
- {
- name: "//visibility:public mixed with other from different defaults 1",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//namespace"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:public mixed with other from different defaults 1",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//namespace"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:public mixed with other from different defaults 2",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//visibility:public"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:public mixed with other from different defaults 2 (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//visibility:public"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:private in defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults"],
- }
- mock_library {
- name: "libsamepackage",
- deps: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnested" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- `module "libother" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "//visibility:private in defaults (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults"],
- }
- gen_notice {
- name: "libexample-notice",
- for: ["libexample"],
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "nested-notice" references "//top:libexample" which is not visible to this module`,
- `module "other-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "//visibility:private mixed with other in defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private", "//namespace"],
- }
- mock_library {
- name: "libexample",
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample_defaults": visibility: cannot mix "//visibility:private"` +
- ` with any other visibility rules`,
- },
- },
- {
- name: "//visibility:private overriding defaults",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: cannot mix "//visibility:private"` +
- ` with any other visibility rules`,
- },
- },
- {
- name: "//visibility:private in defaults overridden",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//namespace"],
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: cannot mix "//visibility:private"` +
- ` with any other visibility rules`,
- },
- },
- {
- name: "//visibility:private override //visibility:public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: cannot mix "//visibility:private" with any other visibility rules`,
- },
- },
- {
- name: "//visibility:public override //visibility:private",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- defaults: ["libexample_defaults"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: cannot mix "//visibility:private" with any other visibility rules`,
- },
- },
- {
- name: "//visibility:override must be first in the list",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_library {
- name: "libexample",
- visibility: ["//other", "//visibility:override", "//namespace"],
- }`),
- },
- expectedErrors: []string{
- `module "libexample": visibility: "//visibility:override" may only be used at the start of the visibility rules`,
- },
- },
- {
- name: "//visibility:override discards //visibility:private",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //visibility:private
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:override discards //visibility:private (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //visibility:private
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:override discards //visibility:public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //visibility:public
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- "namespace/Android.bp": []byte(`
- mock_library {
- name: "libnamespace",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
- },
- },
- {
- name: "//visibility:override discards //visibility:public (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //visibility:public
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- "namespace/Android.bp": []byte(`
- gen_notice {
- name: "namespace-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "namespace-notice" references "//top:libexample" which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
- },
- },
- {
- name: "//visibility:override discards defaults supplied rules",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //namespace
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libexample"],
- }`),
- "namespace/Android.bp": []byte(`
- mock_library {
- name: "libnamespace",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
- },
- },
- {
- name: "//visibility:override discards defaults supplied rules (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//namespace"],
- }
- mock_library {
- name: "libexample",
- // Make this visibility to //other but not //namespace
- visibility: ["//visibility:override", "//other"],
- defaults: ["libexample_defaults"],
- }`),
- "other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libexample"],
- }`),
- "namespace/Android.bp": []byte(`
- gen_notice {
- name: "namespace-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "namespace-notice" references "//top:libexample" which is not visible to this module\nYou may need to add "//namespace" to its visibility`,
- },
- },
- {
- name: "//visibility:override can override //visibility:public with //visibility:private",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:override", "//visibility:private"],
- defaults: ["libexample_defaults"],
- }`),
- "namespace/Android.bp": []byte(`
- mock_library {
- name: "libnamespace",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`,
- },
- },
- {
- name: "//visibility:override can override //visibility:public with //visibility:private (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:override", "//visibility:private"],
- defaults: ["libexample_defaults"],
- }`),
- "namespace/Android.bp": []byte(`
- gen_notice {
- name: "namespace-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "namespace-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "//visibility:override can override //visibility:private with //visibility:public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:override", "//visibility:public"],
- defaults: ["libexample_defaults"],
- }`),
- "namespace/Android.bp": []byte(`
- mock_library {
- name: "libnamespace",
- deps: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:override can override //visibility:private with //visibility:public (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:override", "//visibility:public"],
- defaults: ["libexample_defaults"],
- }`),
- "namespace/Android.bp": []byte(`
- gen_notice {
- name: "namespace-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- name: "//visibility:private mixed with itself",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//visibility:private"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "//visibility:private mixed with itself (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "libexample_defaults_1",
- visibility: ["//visibility:private"],
- }
- mock_defaults {
- name: "libexample_defaults_2",
- visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- defaults: ["libexample_defaults_1", "libexample_defaults_2"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- // Defaults module's defaults_visibility tests
- {
- name: "defaults_visibility invalid",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_defaults {
- name: "top_defaults",
- defaults_visibility: ["//visibility:invalid"],
- }`),
- },
- expectedErrors: []string{
- `defaults_visibility: unrecognized visibility rule "//visibility:invalid"`,
- },
- },
- {
- name: "defaults_visibility overrides package default",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }
- mock_defaults {
- name: "top_defaults",
- defaults_visibility: ["//visibility:public"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- defaults: ["top_defaults"],
- }`),
- },
- },
- // Package default_visibility tests
- {
- name: "package default_visibility property is checked",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:invalid"],
- }`),
- },
- expectedErrors: []string{`default_visibility: unrecognized visibility rule "//visibility:invalid"`},
- },
- {
- // This test relies on the default visibility being legacy_public.
- name: "package default_visibility property used when no visibility specified",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- // This test relies on the default visibility being legacy_public.
- name: "package default_visibility property used when no visibility specified (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "package default_visibility public does not override visibility private",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "package default_visibility public does not override visibility private (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:public"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:private"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "package default_visibility private does not override visibility public",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- },
- {
- name: "package default_visibility private does not override visibility public (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }
- mock_library {
- name: "libexample",
- visibility: ["//visibility:public"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- },
- {
- name: "package default_visibility :__subpackages__",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: [":__subpackages__"],
- }
- mock_library {
- name: "libexample",
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "package default_visibility :__subpackages__ (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: [":__subpackages__"],
- }
- mock_library {
- name: "libexample",
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "package default_visibility inherited to subpackages",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//outsider"],
- }
- mock_library {
- name: "libexample",
- visibility: [":__subpackages__"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libexample", "libnested"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top:libexample which is not` +
- ` visible to this module`,
- },
- },
- {
- name: "package default_visibility inherited to subpackages (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//outsider"],
- }
- mock_library {
- name: "libexample",
- visibility: [":__subpackages__"],
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libexample"],
- }
- gen_notice {
- name: "nested-notice",
- for: ["libexample"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libexample", "libnested"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top:libexample" which is not visible to this module`,
- },
- },
- {
- name: "package default_visibility inherited to subpackages",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }`),
- "top/nested/Android.bp": []byte(`
- package {
- default_visibility: ["//outsider"],
- }
- mock_library {
- name: "libnested",
- }`),
- "top/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- }`),
- "outsider/Android.bp": []byte(`
- mock_library {
- name: "liboutsider",
- deps: ["libother", "libnested"],
- }`),
- },
- expectedErrors: []string{
- `module "liboutsider" variant "android_common": depends on //top/other:libother which is` +
- ` not visible to this module`,
- },
- },
- {
- name: "package default_visibility inherited to subpackages (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- package {
- default_visibility: ["//visibility:private"],
- }`),
- "top/nested/Android.bp": []byte(`
- package {
- default_visibility: ["//outsider"],
- }
- mock_library {
- name: "libnested",
- }`),
- "top/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- }
- gen_notice {
- name: "other-notice",
- for: ["libother"],
- }`),
- "outsider/Android.bp": []byte(`
- gen_notice {
- name: "outsider-notice",
- for: ["libother", "libnested"],
- }`),
- },
- expectedErrors: []string{
- `module "outsider-notice" references "//top/other:libother" which is not visible to this` +
- ` module\nYou may need to add "//outsider" to its visibility`,
- },
- },
- {
- name: "verify that prebuilt dependencies are ignored for visibility reasons (not preferred)",
- fs: MockFS{
- "prebuilts/Android.bp": []byte(`
- prebuilt {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/sources/source_file": nil,
- "top/sources/Android.bp": []byte(`
- source {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/other/source_file": nil,
- "top/other/Android.bp": []byte(`
- source {
- name: "other",
- deps: [":module"],
- }`),
- },
- },
- {
- name: "verify that prebuilt dependencies are ignored for visibility reasons (not preferred) (notices)",
- fs: MockFS{
- "prebuilts/Android.bp": []byte(`
- prebuilt {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/sources/source_file": nil,
- "top/sources/Android.bp": []byte(`
- source {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/other/source_file": nil,
- "top/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["module"],
- }`),
- },
- },
- {
- name: "verify that prebuilt dependencies are ignored for visibility reasons (preferred)",
- fs: MockFS{
- "prebuilts/Android.bp": []byte(`
- prebuilt {
- name: "module",
- visibility: ["//top/other"],
- prefer: true,
- }`),
- "top/sources/source_file": nil,
- "top/sources/Android.bp": []byte(`
- source {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/other/source_file": nil,
- "top/other/Android.bp": []byte(`
- source {
- name: "other",
- deps: [":module"],
- }`),
- },
- },
- {
- name: "verify that prebuilt dependencies are ignored for visibility reasons (preferred) (notices)",
- fs: MockFS{
- "prebuilts/Android.bp": []byte(`
- prebuilt {
- name: "module",
- visibility: ["//top/other"],
- prefer: true,
- }`),
- "top/sources/source_file": nil,
- "top/sources/Android.bp": []byte(`
- source {
- name: "module",
- visibility: ["//top/other"],
- }`),
- "top/other/source_file": nil,
- "top/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["module"],
- }`),
- },
- },
- {
- name: "ensure visibility properties are checked for correctness",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_parent {
- name: "parent",
- visibility: ["//top/nested"],
- child: {
- name: "libchild",
- visibility: ["top/other"],
- },
- }`),
- },
- expectedErrors: []string{
- `module "parent": child.visibility: invalid visibility pattern "top/other"`,
- },
- },
- {
- name: "invalid visibility added to child detected during gather phase",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_parent {
- name: "parent",
- visibility: ["//top/nested"],
- child: {
- name: "libchild",
- invalid_visibility: ["top/other"],
- },
- }`),
- },
- expectedErrors: []string{
- // That this error is reported against the child not the parent shows it was
- // not being detected in the parent which is correct as invalid_visibility is
- // purposely not added to the list of visibility properties to check, and was
- // in fact detected in the child in the gather phase. Contrast this error message
- // with the preceding one.
- `module "libchild" \(created by module "parent"\): visibility: invalid visibility pattern "top/other"`,
- },
- },
- {
- name: "automatic visibility inheritance enabled",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_parent {
- name: "parent",
- visibility: ["//top/nested"],
- child: {
- name: "libchild",
- visibility: ["//top/other"],
- },
- }`),
- "top/nested/Android.bp": []byte(`
- mock_library {
- name: "libnested",
- deps: ["libchild"],
- }`),
- "top/other/Android.bp": []byte(`
- mock_library {
- name: "libother",
- deps: ["libchild"],
- }`),
- },
- },
- {
- name: "automatic visibility inheritance enabled (notices)",
- fs: MockFS{
- "top/Android.bp": []byte(`
- mock_parent {
- name: "parent",
- visibility: ["//top/nested"],
- child: {
- name: "libchild",
- visibility: ["//top/other"],
- },
- }`),
- "top/nested/Android.bp": []byte(`
- gen_notice {
- name: "nested-notice",
- for: ["libchild"],
- }`),
- "top/other/Android.bp": []byte(`
- gen_notice {
- name: "other-notice",
- for: ["libchild"],
- }`),
- },
- },
- }
- func TestVisibility(t *testing.T) {
- for _, test := range visibilityTests {
- t.Run(test.name, func(t *testing.T) {
- result := GroupFixturePreparers(
- // General preparers in alphabetical order as test infrastructure will enforce correct
- // registration order.
- PrepareForTestWithArchMutator,
- PrepareForTestWithDefaults,
- PrepareForTestWithGenNotice,
- PrepareForTestWithOverrides,
- PrepareForTestWithPackageModule,
- PrepareForTestWithPrebuilts,
- PrepareForTestWithVisibility,
- // Additional test specific preparers.
- FixtureRegisterWithContext(func(ctx RegistrationContext) {
- ctx.RegisterModuleType("mock_library", newMockLibraryModule)
- ctx.RegisterModuleType("mock_parent", newMockParentFactory)
- ctx.RegisterModuleType("mock_defaults", defaultsFactory)
- }),
- prepareForTestWithFakePrebuiltModules,
- // Add additional files to the mock filesystem
- test.fs.AddToFixture(),
- ).
- ExtendWithErrorHandler(FixtureExpectsAllErrorsToMatchAPattern(test.expectedErrors)).
- RunTest(t)
- if test.effectiveVisibility != nil {
- checkEffectiveVisibility(t, result, test.effectiveVisibility)
- }
- })
- }
- }
- func checkEffectiveVisibility(t *testing.T, result *TestResult, effectiveVisibility map[qualifiedModuleName][]string) {
- for moduleName, expectedRules := range effectiveVisibility {
- rule := effectiveVisibilityRules(result.Config, moduleName)
- stringRules := rule.Strings()
- AssertDeepEquals(t, "effective rules mismatch", expectedRules, stringRules)
- }
- }
- type mockLibraryProperties struct {
- Deps []string
- }
- type mockLibraryModule struct {
- ModuleBase
- DefaultableModuleBase
- properties mockLibraryProperties
- }
- func newMockLibraryModule() Module {
- m := &mockLibraryModule{}
- m.AddProperties(&m.properties)
- InitAndroidArchModule(m, HostAndDeviceSupported, MultilibCommon)
- InitDefaultableModule(m)
- return m
- }
- type dependencyTag struct {
- blueprint.BaseDependencyTag
- name string
- }
- func (j *mockLibraryModule) DepsMutator(ctx BottomUpMutatorContext) {
- ctx.AddVariationDependencies(nil, dependencyTag{name: "mockdeps"}, j.properties.Deps...)
- }
- func (p *mockLibraryModule) GenerateAndroidBuildActions(ModuleContext) {
- }
- type mockDefaults struct {
- ModuleBase
- DefaultsModuleBase
- }
- func defaultsFactory() Module {
- m := &mockDefaults{}
- InitDefaultsModule(m)
- return m
- }
- type mockParentProperties struct {
- Child struct {
- Name *string
- // Visibility to pass to the child module.
- Visibility []string
- // Purposely not validated visibility to pass to the child.
- Invalid_visibility []string
- }
- }
- type mockParent struct {
- ModuleBase
- DefaultableModuleBase
- properties mockParentProperties
- }
- func (p *mockParent) GenerateAndroidBuildActions(ModuleContext) {
- }
- func newMockParentFactory() Module {
- m := &mockParent{}
- m.AddProperties(&m.properties)
- InitAndroidArchModule(m, HostAndDeviceSupported, MultilibCommon)
- InitDefaultableModule(m)
- AddVisibilityProperty(m, "child.visibility", &m.properties.Child.Visibility)
- m.SetDefaultableHook(func(ctx DefaultableHookContext) {
- visibility := m.properties.Child.Visibility
- visibility = append(visibility, m.properties.Child.Invalid_visibility...)
- ctx.CreateModule(newMockLibraryModule, &struct {
- Name *string
- Visibility []string
- }{m.properties.Child.Name, visibility})
- })
- return m
- }
- func testVisibilityRuleSet(t *testing.T, rules, extra, expected []string) {
- t.Helper()
- set := &visibilityRuleSet{rules}
- err := set.Widen(extra)
- if err != nil {
- t.Error(err)
- return
- }
- actual := set.Strings()
- if !reflect.DeepEqual(actual, expected) {
- t.Errorf("mismatching rules after extend: expected %#v, actual %#v", expected, actual)
- }
- }
- func TestVisibilityRuleSet(t *testing.T) {
- t.Run("extend empty", func(t *testing.T) {
- testVisibilityRuleSet(t, nil, []string{"//foo"}, []string{"//foo"})
- })
- t.Run("extend", func(t *testing.T) {
- testVisibilityRuleSet(t, []string{"//foo"}, []string{"//bar"}, []string{"//bar", "//foo"})
- })
- t.Run("extend duplicate", func(t *testing.T) {
- testVisibilityRuleSet(t, []string{"//foo"}, []string{"//bar", "//foo"}, []string{"//bar", "//foo"})
- })
- t.Run("extend public", func(t *testing.T) {
- testVisibilityRuleSet(t, []string{"//visibility:public"}, []string{"//foo"}, []string{"//visibility:public"})
- })
- t.Run("extend private", func(t *testing.T) {
- testVisibilityRuleSet(t, []string{"//visibility:private"}, []string{"//foo"}, []string{"//foo"})
- })
- t.Run("extend with public", func(t *testing.T) {
- testVisibilityRuleSet(t, []string{"//foo"}, []string{"//visibility:public"}, []string{"//visibility:public"})
- })
- t.Run("extend with private", func(t *testing.T) {
- t.Helper()
- set := &visibilityRuleSet{[]string{"//foo"}}
- err := set.Widen([]string{"//visibility:private"})
- expectedError := `"//visibility:private" does not widen the visibility`
- if err == nil {
- t.Errorf("missing error")
- } else if err.Error() != expectedError {
- t.Errorf("expected error %q found error %q", expectedError, err)
- }
- })
- }
|