apex_test.go 294 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623562456255626562756285629563056315632563356345635563656375638563956405641564256435644564556465647564856495650565156525653565456555656565756585659566056615662566356645665566656675668566956705671567256735674567556765677567856795680568156825683568456855686568756885689569056915692569356945695569656975698569957005701570257035704570557065707570857095710571157125713571457155716571757185719572057215722572357245725572657275728572957305731573257335734573557365737573857395740574157425743574457455746574757485749575057515752575357545755575657575758575957605761576257635764576557665767576857695770577157725773577457755776577757785779578057815782578357845785578657875788578957905791579257935794579557965797579857995800580158025803580458055806580758085809581058115812581358145815581658175818581958205821582258235824582558265827582858295830583158325833583458355836583758385839584058415842584358445845584658475848584958505851585258535854585558565857585858595860586158625863586458655866586758685869587058715872587358745875587658775878587958805881588258835884588558865887588858895890589158925893589458955896589758985899590059015902590359045905590659075908590959105911591259135914591559165917591859195920592159225923592459255926592759285929593059315932593359345935593659375938593959405941594259435944594559465947594859495950595159525953595459555956595759585959596059615962596359645965596659675968596959705971597259735974597559765977597859795980598159825983598459855986598759885989599059915992599359945995599659975998599960006001600260036004600560066007600860096010601160126013601460156016601760186019602060216022602360246025602660276028602960306031603260336034603560366037603860396040604160426043604460456046604760486049605060516052605360546055605660576058605960606061606260636064606560666067606860696070607160726073607460756076607760786079608060816082608360846085608660876088608960906091609260936094609560966097609860996100610161026103610461056106610761086109611061116112611361146115611661176118611961206121612261236124612561266127612861296130613161326133613461356136613761386139614061416142614361446145614661476148614961506151615261536154615561566157615861596160616161626163616461656166616761686169617061716172617361746175617661776178617961806181618261836184618561866187618861896190619161926193619461956196619761986199620062016202620362046205620662076208620962106211621262136214621562166217621862196220622162226223622462256226622762286229623062316232623362346235623662376238623962406241624262436244624562466247624862496250625162526253625462556256625762586259626062616262626362646265626662676268626962706271627262736274627562766277627862796280628162826283628462856286628762886289629062916292629362946295629662976298629963006301630263036304630563066307630863096310631163126313631463156316631763186319632063216322632363246325632663276328632963306331633263336334633563366337633863396340634163426343634463456346634763486349635063516352635363546355635663576358635963606361636263636364636563666367636863696370637163726373637463756376637763786379638063816382638363846385638663876388638963906391639263936394639563966397639863996400640164026403640464056406640764086409641064116412641364146415641664176418641964206421642264236424642564266427642864296430643164326433643464356436643764386439644064416442644364446445644664476448644964506451645264536454645564566457645864596460646164626463646464656466646764686469647064716472647364746475647664776478647964806481648264836484648564866487648864896490649164926493649464956496649764986499650065016502650365046505650665076508650965106511651265136514651565166517651865196520652165226523652465256526652765286529653065316532653365346535653665376538653965406541654265436544654565466547654865496550655165526553655465556556655765586559656065616562656365646565656665676568656965706571657265736574657565766577657865796580658165826583658465856586658765886589659065916592659365946595659665976598659966006601660266036604660566066607660866096610661166126613661466156616661766186619662066216622662366246625662666276628662966306631663266336634663566366637663866396640664166426643664466456646664766486649665066516652665366546655665666576658665966606661666266636664666566666667666866696670667166726673667466756676667766786679668066816682668366846685668666876688668966906691669266936694669566966697669866996700670167026703670467056706670767086709671067116712671367146715671667176718671967206721672267236724672567266727672867296730673167326733673467356736673767386739674067416742674367446745674667476748674967506751675267536754675567566757675867596760676167626763676467656766676767686769677067716772677367746775677667776778677967806781678267836784678567866787678867896790679167926793679467956796679767986799680068016802680368046805680668076808680968106811681268136814681568166817681868196820682168226823682468256826682768286829683068316832683368346835683668376838683968406841684268436844684568466847684868496850685168526853685468556856685768586859686068616862686368646865686668676868686968706871687268736874687568766877687868796880688168826883688468856886688768886889689068916892689368946895689668976898689969006901690269036904690569066907690869096910691169126913691469156916691769186919692069216922692369246925692669276928692969306931693269336934693569366937693869396940694169426943694469456946694769486949695069516952695369546955695669576958695969606961696269636964696569666967696869696970697169726973697469756976697769786979698069816982698369846985698669876988698969906991699269936994699569966997699869997000700170027003700470057006700770087009701070117012701370147015701670177018701970207021702270237024702570267027702870297030703170327033703470357036703770387039704070417042704370447045704670477048704970507051705270537054705570567057705870597060706170627063706470657066706770687069707070717072707370747075707670777078707970807081708270837084708570867087708870897090709170927093709470957096709770987099710071017102710371047105710671077108710971107111711271137114711571167117711871197120712171227123712471257126712771287129713071317132713371347135713671377138713971407141714271437144714571467147714871497150715171527153715471557156715771587159716071617162716371647165716671677168716971707171717271737174717571767177717871797180718171827183718471857186718771887189719071917192719371947195719671977198719972007201720272037204720572067207720872097210721172127213721472157216721772187219722072217222722372247225722672277228722972307231723272337234723572367237723872397240724172427243724472457246724772487249725072517252725372547255725672577258725972607261726272637264726572667267726872697270727172727273727472757276727772787279728072817282728372847285728672877288728972907291729272937294729572967297729872997300730173027303730473057306730773087309731073117312731373147315731673177318731973207321732273237324732573267327732873297330733173327333733473357336733773387339734073417342734373447345734673477348734973507351735273537354735573567357735873597360736173627363736473657366736773687369737073717372737373747375737673777378737973807381738273837384738573867387738873897390739173927393739473957396739773987399740074017402740374047405740674077408740974107411741274137414741574167417741874197420742174227423742474257426742774287429743074317432743374347435743674377438743974407441744274437444744574467447744874497450745174527453745474557456745774587459746074617462746374647465746674677468746974707471747274737474747574767477747874797480748174827483748474857486748774887489749074917492749374947495749674977498749975007501750275037504750575067507750875097510751175127513751475157516751775187519752075217522752375247525752675277528752975307531753275337534753575367537753875397540754175427543754475457546754775487549755075517552755375547555755675577558755975607561756275637564756575667567756875697570757175727573757475757576757775787579758075817582758375847585758675877588758975907591759275937594759575967597759875997600760176027603760476057606760776087609761076117612761376147615761676177618761976207621762276237624762576267627762876297630763176327633763476357636763776387639764076417642764376447645764676477648764976507651765276537654765576567657765876597660766176627663766476657666766776687669767076717672767376747675767676777678767976807681768276837684768576867687768876897690769176927693769476957696769776987699770077017702770377047705770677077708770977107711771277137714771577167717771877197720772177227723772477257726772777287729773077317732773377347735773677377738773977407741774277437744774577467747774877497750775177527753775477557756775777587759776077617762776377647765776677677768776977707771777277737774777577767777777877797780778177827783778477857786778777887789779077917792779377947795779677977798779978007801780278037804780578067807780878097810781178127813781478157816781778187819782078217822782378247825782678277828782978307831783278337834783578367837783878397840784178427843784478457846784778487849785078517852785378547855785678577858785978607861786278637864786578667867786878697870787178727873787478757876787778787879788078817882788378847885788678877888788978907891789278937894789578967897789878997900790179027903790479057906790779087909791079117912791379147915791679177918791979207921792279237924792579267927792879297930793179327933793479357936793779387939794079417942794379447945794679477948794979507951795279537954795579567957795879597960796179627963796479657966796779687969797079717972797379747975797679777978797979807981798279837984798579867987798879897990799179927993799479957996799779987999800080018002800380048005800680078008800980108011801280138014801580168017801880198020802180228023802480258026802780288029803080318032803380348035803680378038803980408041804280438044804580468047804880498050805180528053805480558056805780588059806080618062806380648065806680678068806980708071807280738074807580768077807880798080808180828083808480858086808780888089809080918092809380948095809680978098809981008101810281038104810581068107810881098110811181128113811481158116811781188119812081218122812381248125812681278128812981308131813281338134813581368137813881398140814181428143814481458146814781488149815081518152815381548155815681578158815981608161816281638164816581668167816881698170817181728173817481758176817781788179818081818182818381848185818681878188818981908191819281938194819581968197819881998200820182028203820482058206820782088209821082118212821382148215821682178218821982208221822282238224822582268227822882298230823182328233823482358236823782388239824082418242824382448245824682478248824982508251825282538254825582568257825882598260826182628263826482658266826782688269827082718272827382748275827682778278827982808281828282838284828582868287828882898290829182928293829482958296829782988299830083018302830383048305830683078308830983108311831283138314831583168317831883198320832183228323832483258326832783288329833083318332833383348335833683378338833983408341834283438344834583468347834883498350835183528353835483558356835783588359836083618362836383648365836683678368836983708371837283738374837583768377837883798380838183828383838483858386838783888389839083918392839383948395839683978398839984008401840284038404840584068407840884098410841184128413841484158416841784188419842084218422842384248425842684278428842984308431843284338434843584368437843884398440844184428443844484458446844784488449845084518452845384548455845684578458845984608461846284638464846584668467846884698470847184728473847484758476847784788479848084818482848384848485848684878488848984908491849284938494849584968497849884998500850185028503850485058506850785088509851085118512851385148515851685178518851985208521852285238524852585268527852885298530853185328533853485358536853785388539854085418542854385448545854685478548854985508551855285538554855585568557855885598560856185628563856485658566856785688569857085718572857385748575857685778578857985808581858285838584858585868587858885898590859185928593859485958596859785988599860086018602860386048605860686078608860986108611861286138614861586168617861886198620862186228623862486258626862786288629863086318632863386348635863686378638863986408641864286438644864586468647864886498650865186528653865486558656865786588659866086618662866386648665866686678668866986708671867286738674867586768677867886798680868186828683868486858686868786888689869086918692869386948695869686978698869987008701870287038704870587068707870887098710871187128713871487158716871787188719872087218722872387248725872687278728872987308731873287338734873587368737873887398740874187428743874487458746874787488749875087518752875387548755875687578758875987608761876287638764876587668767876887698770877187728773877487758776877787788779878087818782878387848785878687878788878987908791879287938794879587968797879887998800880188028803880488058806880788088809881088118812881388148815881688178818881988208821882288238824882588268827882888298830883188328833883488358836883788388839884088418842884388448845884688478848884988508851885288538854885588568857885888598860886188628863886488658866886788688869887088718872887388748875887688778878887988808881888288838884888588868887888888898890889188928893889488958896889788988899890089018902890389048905890689078908890989108911891289138914891589168917891889198920892189228923892489258926892789288929893089318932893389348935893689378938893989408941894289438944894589468947894889498950895189528953895489558956895789588959896089618962896389648965896689678968896989708971897289738974897589768977897889798980898189828983898489858986898789888989899089918992899389948995899689978998899990009001900290039004900590069007900890099010901190129013901490159016901790189019902090219022902390249025902690279028902990309031903290339034903590369037903890399040904190429043904490459046904790489049905090519052905390549055905690579058905990609061906290639064906590669067906890699070907190729073907490759076907790789079908090819082908390849085908690879088908990909091909290939094909590969097909890999100910191029103910491059106910791089109911091119112911391149115911691179118911991209121912291239124912591269127912891299130913191329133913491359136913791389139914091419142914391449145914691479148914991509151915291539154915591569157915891599160916191629163916491659166916791689169917091719172917391749175917691779178917991809181918291839184918591869187918891899190919191929193919491959196919791989199920092019202920392049205920692079208920992109211921292139214921592169217921892199220922192229223922492259226922792289229923092319232923392349235923692379238923992409241924292439244924592469247924892499250925192529253925492559256925792589259926092619262926392649265926692679268926992709271927292739274927592769277927892799280928192829283928492859286928792889289929092919292929392949295929692979298929993009301930293039304930593069307930893099310931193129313931493159316931793189319932093219322932393249325932693279328932993309331933293339334933593369337933893399340934193429343934493459346934793489349935093519352935393549355935693579358935993609361936293639364936593669367936893699370937193729373937493759376937793789379938093819382938393849385938693879388938993909391939293939394939593969397939893999400940194029403940494059406940794089409941094119412941394149415941694179418941994209421942294239424942594269427942894299430943194329433943494359436943794389439944094419442944394449445944694479448944994509451945294539454945594569457945894599460946194629463946494659466946794689469947094719472947394749475947694779478947994809481948294839484948594869487948894899490949194929493949494959496949794989499950095019502950395049505950695079508950995109511951295139514951595169517951895199520952195229523952495259526952795289529953095319532953395349535953695379538953995409541954295439544954595469547954895499550955195529553955495559556955795589559956095619562956395649565956695679568956995709571957295739574957595769577957895799580958195829583958495859586958795889589959095919592959395949595959695979598959996009601960296039604960596069607960896099610961196129613961496159616961796189619962096219622962396249625962696279628962996309631963296339634963596369637963896399640964196429643964496459646964796489649965096519652965396549655965696579658965996609661966296639664966596669667966896699670967196729673967496759676967796789679968096819682968396849685968696879688968996909691969296939694969596969697969896999700970197029703970497059706970797089709971097119712971397149715971697179718971997209721972297239724972597269727972897299730973197329733973497359736973797389739974097419742974397449745974697479748974997509751975297539754975597569757975897599760976197629763976497659766976797689769977097719772977397749775977697779778977997809781978297839784978597869787978897899790979197929793979497959796979797989799980098019802980398049805980698079808980998109811981298139814981598169817981898199820982198229823982498259826982798289829983098319832983398349835983698379838983998409841984298439844984598469847984898499850985198529853985498559856985798589859986098619862986398649865986698679868986998709871987298739874987598769877987898799880988198829883988498859886988798889889989098919892989398949895989698979898989999009901990299039904990599069907990899099910991199129913991499159916991799189919992099219922992399249925992699279928992999309931993299339934993599369937993899399940994199429943994499459946994799489949995099519952995399549955995699579958995999609961996299639964996599669967996899699970997199729973997499759976997799789979998099819982998399849985998699879988998999909991999299939994999599969997999899991000010001100021000310004100051000610007100081000910010100111001210013100141001510016100171001810019100201002110022100231002410025100261002710028100291003010031100321003310034100351003610037100381003910040100411004210043100441004510046100471004810049100501005110052100531005410055100561005710058100591006010061100621006310064100651006610067100681006910070100711007210073100741007510076100771007810079100801008110082100831008410085100861008710088100891009010091100921009310094100951009610097100981009910100101011010210103101041010510106101071010810109101101011110112101131011410115101161011710118101191012010121101221012310124101251012610127101281012910130101311013210133101341013510136101371013810139101401014110142101431014410145101461014710148101491015010151101521015310154101551015610157101581015910160101611016210163101641016510166101671016810169101701017110172101731017410175101761017710178101791018010181101821018310184101851018610187101881018910190101911019210193101941019510196101971019810199102001020110202102031020410205102061020710208102091021010211102121021310214102151021610217102181021910220102211022210223102241022510226102271022810229102301023110232102331023410235102361023710238102391024010241102421024310244102451024610247102481024910250102511025210253102541025510256102571025810259102601026110262102631026410265102661026710268102691027010271102721027310274102751027610277102781027910280102811028210283102841028510286102871028810289102901029110292102931029410295102961029710298102991030010301103021030310304103051030610307103081030910310103111031210313103141031510316103171031810319103201032110322103231032410325103261032710328103291033010331103321033310334103351033610337103381033910340103411034210343103441034510346103471034810349103501035110352103531035410355103561035710358103591036010361103621036310364103651036610367103681036910370103711037210373103741037510376103771037810379103801038110382103831038410385103861038710388103891039010391103921039310394103951039610397103981039910400104011040210403104041040510406104071040810409104101041110412104131041410415104161041710418104191042010421104221042310424104251042610427104281042910430104311043210433104341043510436104371043810439104401044110442104431044410445104461044710448104491045010451104521045310454104551045610457104581045910460104611046210463104641046510466104671046810469104701047110472104731047410475104761047710478104791048010481104821048310484104851048610487104881048910490104911049210493104941049510496104971049810499105001050110502105031050410505105061050710508105091051010511105121051310514105151051610517105181051910520105211052210523105241052510526105271052810529105301053110532105331053410535105361053710538105391054010541105421054310544105451054610547105481054910550105511055210553105541055510556105571055810559105601056110562105631056410565105661056710568105691057010571105721057310574105751057610577105781057910580105811058210583105841058510586105871058810589105901059110592105931059410595105961059710598105991060010601106021060310604106051060610607106081060910610106111061210613106141061510616106171061810619106201062110622106231062410625106261062710628106291063010631106321063310634106351063610637106381063910640106411064210643106441064510646106471064810649106501065110652106531065410655106561065710658106591066010661106621066310664106651066610667106681066910670106711067210673106741067510676106771067810679106801068110682106831068410685106861068710688106891069010691106921069310694106951069610697106981069910700107011070210703107041070510706107071070810709107101071110712107131071410715107161071710718107191072010721107221072310724107251072610727107281072910730107311073210733107341073510736107371073810739107401074110742107431074410745107461074710748107491075010751107521075310754107551075610757107581075910760107611076210763107641076510766107671076810769107701077110772107731077410775107761077710778107791078010781107821078310784107851078610787107881078910790107911079210793107941079510796107971079810799108001080110802108031080410805108061080710808108091081010811108121081310814108151081610817108181081910820108211082210823108241082510826108271082810829108301083110832108331083410835108361083710838108391084010841108421084310844108451084610847108481084910850108511085210853108541085510856108571085810859108601086110862108631086410865108661086710868108691087010871108721087310874108751087610877108781087910880108811088210883108841088510886108871088810889108901089110892108931089410895108961089710898108991090010901109021090310904109051090610907109081090910910109111091210913109141091510916109171091810919109201092110922109231092410925109261092710928
  1. // Copyright 2018 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package apex
  15. import (
  16. "fmt"
  17. "path"
  18. "path/filepath"
  19. "reflect"
  20. "regexp"
  21. "sort"
  22. "strconv"
  23. "strings"
  24. "testing"
  25. "github.com/google/blueprint"
  26. "github.com/google/blueprint/proptools"
  27. "android/soong/android"
  28. "android/soong/bpf"
  29. "android/soong/cc"
  30. "android/soong/dexpreopt"
  31. prebuilt_etc "android/soong/etc"
  32. "android/soong/filesystem"
  33. "android/soong/java"
  34. "android/soong/rust"
  35. "android/soong/sh"
  36. )
  37. // names returns name list from white space separated string
  38. func names(s string) (ns []string) {
  39. for _, n := range strings.Split(s, " ") {
  40. if len(n) > 0 {
  41. ns = append(ns, n)
  42. }
  43. }
  44. return
  45. }
  46. func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
  47. t.Helper()
  48. android.GroupFixturePreparers(
  49. prepareForApexTest,
  50. android.GroupFixturePreparers(preparers...),
  51. ).
  52. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
  53. RunTestWithBp(t, bp)
  54. }
  55. func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
  56. t.Helper()
  57. optionalBpPreparer := android.NullFixturePreparer
  58. if bp != "" {
  59. optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
  60. }
  61. result := android.GroupFixturePreparers(
  62. prepareForApexTest,
  63. android.GroupFixturePreparers(preparers...),
  64. optionalBpPreparer,
  65. ).RunTest(t)
  66. return result.TestContext
  67. }
  68. func withFiles(files android.MockFS) android.FixturePreparer {
  69. return files.AddToFixture()
  70. }
  71. func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
  72. return android.FixtureModifyConfig(func(config android.Config) {
  73. for k, v := range targets {
  74. config.Targets[k] = v
  75. }
  76. })
  77. }
  78. // withNativeBridgeTargets sets configuration with targets including:
  79. // - X86_64 (primary)
  80. // - X86 (secondary)
  81. // - Arm64 on X86_64 (native bridge)
  82. // - Arm on X86 (native bridge)
  83. var withNativeBridgeEnabled = android.FixtureModifyConfig(
  84. func(config android.Config) {
  85. config.Targets[android.Android] = []android.Target{
  86. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
  87. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  88. {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
  89. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  90. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
  91. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
  92. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  93. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
  94. }
  95. },
  96. )
  97. func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
  98. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  99. variables.ManifestPackageNameOverrides = specs
  100. })
  101. }
  102. func withApexGlobalMinSdkVersionOverride(minSdkOverride *string) android.FixturePreparer {
  103. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  104. variables.ApexGlobalMinSdkVersionOverride = minSdkOverride
  105. })
  106. }
  107. var withBinder32bit = android.FixtureModifyProductVariables(
  108. func(variables android.FixtureProductVariables) {
  109. variables.Binder32bit = proptools.BoolPtr(true)
  110. },
  111. )
  112. var withUnbundledBuild = android.FixtureModifyProductVariables(
  113. func(variables android.FixtureProductVariables) {
  114. variables.Unbundled_build = proptools.BoolPtr(true)
  115. },
  116. )
  117. // Legacy preparer used for running tests within the apex package.
  118. //
  119. // This includes everything that was needed to run any test in the apex package prior to the
  120. // introduction of the test fixtures. Tests that are being converted to use fixtures directly
  121. // rather than through the testApex...() methods should avoid using this and instead use the
  122. // various preparers directly, using android.GroupFixturePreparers(...) to group them when
  123. // necessary.
  124. //
  125. // deprecated
  126. var prepareForApexTest = android.GroupFixturePreparers(
  127. // General preparers in alphabetical order as test infrastructure will enforce correct
  128. // registration order.
  129. android.PrepareForTestWithAndroidBuildComponents,
  130. bpf.PrepareForTestWithBpf,
  131. cc.PrepareForTestWithCcBuildComponents,
  132. java.PrepareForTestWithDexpreopt,
  133. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  134. rust.PrepareForTestWithRustDefaultModules,
  135. sh.PrepareForTestWithShBuildComponents,
  136. PrepareForTestWithApexBuildComponents,
  137. // Additional apex test specific preparers.
  138. android.FixtureAddTextFile("system/sepolicy/Android.bp", `
  139. filegroup {
  140. name: "myapex-file_contexts",
  141. srcs: [
  142. "apex/myapex-file_contexts",
  143. ],
  144. }
  145. `),
  146. prepareForTestWithMyapex,
  147. android.FixtureMergeMockFs(android.MockFS{
  148. "a.java": nil,
  149. "PrebuiltAppFoo.apk": nil,
  150. "PrebuiltAppFooPriv.apk": nil,
  151. "apex_manifest.json": nil,
  152. "AndroidManifest.xml": nil,
  153. "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
  154. "system/sepolicy/apex/myapex2-file_contexts": nil,
  155. "system/sepolicy/apex/otherapex-file_contexts": nil,
  156. "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
  157. "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
  158. "mylib.cpp": nil,
  159. "mytest.cpp": nil,
  160. "mytest1.cpp": nil,
  161. "mytest2.cpp": nil,
  162. "mytest3.cpp": nil,
  163. "myprebuilt": nil,
  164. "my_include": nil,
  165. "foo/bar/MyClass.java": nil,
  166. "prebuilt.jar": nil,
  167. "prebuilt.so": nil,
  168. "vendor/foo/devkeys/test.x509.pem": nil,
  169. "vendor/foo/devkeys/test.pk8": nil,
  170. "testkey.x509.pem": nil,
  171. "testkey.pk8": nil,
  172. "testkey.override.x509.pem": nil,
  173. "testkey.override.pk8": nil,
  174. "vendor/foo/devkeys/testkey.avbpubkey": nil,
  175. "vendor/foo/devkeys/testkey.pem": nil,
  176. "NOTICE": nil,
  177. "custom_notice": nil,
  178. "custom_notice_for_static_lib": nil,
  179. "testkey2.avbpubkey": nil,
  180. "testkey2.pem": nil,
  181. "myapex-arm64.apex": nil,
  182. "myapex-arm.apex": nil,
  183. "myapex.apks": nil,
  184. "frameworks/base/api/current.txt": nil,
  185. "framework/aidl/a.aidl": nil,
  186. "dummy.txt": nil,
  187. "baz": nil,
  188. "bar/baz": nil,
  189. "testdata/baz": nil,
  190. "AppSet.apks": nil,
  191. "foo.rs": nil,
  192. "libfoo.jar": nil,
  193. "libbar.jar": nil,
  194. },
  195. ),
  196. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  197. variables.DeviceVndkVersion = proptools.StringPtr("current")
  198. variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
  199. variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
  200. variables.Platform_sdk_codename = proptools.StringPtr("Q")
  201. variables.Platform_sdk_final = proptools.BoolPtr(false)
  202. // "Tiramisu" needs to be in the next line for compatibility with soong code,
  203. // not because of these tests specifically (it's not used by the tests)
  204. variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
  205. variables.Platform_vndk_version = proptools.StringPtr("29")
  206. variables.BuildId = proptools.StringPtr("TEST.BUILD_ID")
  207. }),
  208. )
  209. var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
  210. "system/sepolicy/apex/myapex-file_contexts": nil,
  211. })
  212. // ensure that 'result' equals 'expected'
  213. func ensureEquals(t *testing.T, result string, expected string) {
  214. t.Helper()
  215. if result != expected {
  216. t.Errorf("%q != %q", expected, result)
  217. }
  218. }
  219. // ensure that 'result' contains 'expected'
  220. func ensureContains(t *testing.T, result string, expected string) {
  221. t.Helper()
  222. if !strings.Contains(result, expected) {
  223. t.Errorf("%q is not found in %q", expected, result)
  224. }
  225. }
  226. // ensure that 'result' contains 'expected' exactly one time
  227. func ensureContainsOnce(t *testing.T, result string, expected string) {
  228. t.Helper()
  229. count := strings.Count(result, expected)
  230. if count != 1 {
  231. t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
  232. }
  233. }
  234. // ensures that 'result' does not contain 'notExpected'
  235. func ensureNotContains(t *testing.T, result string, notExpected string) {
  236. t.Helper()
  237. if strings.Contains(result, notExpected) {
  238. t.Errorf("%q is found in %q", notExpected, result)
  239. }
  240. }
  241. func ensureMatches(t *testing.T, result string, expectedRex string) {
  242. ok, err := regexp.MatchString(expectedRex, result)
  243. if err != nil {
  244. t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
  245. return
  246. }
  247. if !ok {
  248. t.Errorf("%s does not match regular expession %s", result, expectedRex)
  249. }
  250. }
  251. func ensureListContains(t *testing.T, result []string, expected string) {
  252. t.Helper()
  253. if !android.InList(expected, result) {
  254. t.Errorf("%q is not found in %v", expected, result)
  255. }
  256. }
  257. func ensureListNotContains(t *testing.T, result []string, notExpected string) {
  258. t.Helper()
  259. if android.InList(notExpected, result) {
  260. t.Errorf("%q is found in %v", notExpected, result)
  261. }
  262. }
  263. func ensureListEmpty(t *testing.T, result []string) {
  264. t.Helper()
  265. if len(result) > 0 {
  266. t.Errorf("%q is expected to be empty", result)
  267. }
  268. }
  269. func ensureListNotEmpty(t *testing.T, result []string) {
  270. t.Helper()
  271. if len(result) == 0 {
  272. t.Errorf("%q is expected to be not empty", result)
  273. }
  274. }
  275. // Minimal test
  276. func TestBasicApex(t *testing.T) {
  277. ctx := testApex(t, `
  278. apex_defaults {
  279. name: "myapex-defaults",
  280. manifest: ":myapex.manifest",
  281. androidManifest: ":myapex.androidmanifest",
  282. key: "myapex.key",
  283. binaries: ["foo.rust"],
  284. native_shared_libs: [
  285. "mylib",
  286. "libfoo.ffi",
  287. ],
  288. rust_dyn_libs: ["libfoo.dylib.rust"],
  289. multilib: {
  290. both: {
  291. binaries: ["foo"],
  292. }
  293. },
  294. java_libs: [
  295. "myjar",
  296. "myjar_dex",
  297. ],
  298. updatable: false,
  299. }
  300. apex {
  301. name: "myapex",
  302. defaults: ["myapex-defaults"],
  303. }
  304. apex_key {
  305. name: "myapex.key",
  306. public_key: "testkey.avbpubkey",
  307. private_key: "testkey.pem",
  308. }
  309. filegroup {
  310. name: "myapex.manifest",
  311. srcs: ["apex_manifest.json"],
  312. }
  313. filegroup {
  314. name: "myapex.androidmanifest",
  315. srcs: ["AndroidManifest.xml"],
  316. }
  317. cc_library {
  318. name: "mylib",
  319. srcs: ["mylib.cpp"],
  320. shared_libs: [
  321. "mylib2",
  322. "libbar.ffi",
  323. ],
  324. system_shared_libs: [],
  325. stl: "none",
  326. // TODO: remove //apex_available:platform
  327. apex_available: [
  328. "//apex_available:platform",
  329. "myapex",
  330. ],
  331. }
  332. cc_binary {
  333. name: "foo",
  334. srcs: ["mylib.cpp"],
  335. compile_multilib: "both",
  336. multilib: {
  337. lib32: {
  338. suffix: "32",
  339. },
  340. lib64: {
  341. suffix: "64",
  342. },
  343. },
  344. symlinks: ["foo_link_"],
  345. symlink_preferred_arch: true,
  346. system_shared_libs: [],
  347. stl: "none",
  348. apex_available: [ "myapex", "com.android.gki.*" ],
  349. }
  350. rust_binary {
  351. name: "foo.rust",
  352. srcs: ["foo.rs"],
  353. rlibs: ["libfoo.rlib.rust"],
  354. dylibs: ["libfoo.dylib.rust"],
  355. apex_available: ["myapex"],
  356. }
  357. rust_library_rlib {
  358. name: "libfoo.rlib.rust",
  359. srcs: ["foo.rs"],
  360. crate_name: "foo",
  361. apex_available: ["myapex"],
  362. shared_libs: ["libfoo.shared_from_rust"],
  363. }
  364. cc_library_shared {
  365. name: "libfoo.shared_from_rust",
  366. srcs: ["mylib.cpp"],
  367. system_shared_libs: [],
  368. stl: "none",
  369. apex_available: ["myapex"],
  370. }
  371. rust_library_dylib {
  372. name: "libfoo.dylib.rust",
  373. srcs: ["foo.rs"],
  374. crate_name: "foo",
  375. apex_available: ["myapex"],
  376. }
  377. rust_ffi_shared {
  378. name: "libfoo.ffi",
  379. srcs: ["foo.rs"],
  380. crate_name: "foo",
  381. apex_available: ["myapex"],
  382. }
  383. rust_ffi_shared {
  384. name: "libbar.ffi",
  385. srcs: ["foo.rs"],
  386. crate_name: "bar",
  387. apex_available: ["myapex"],
  388. }
  389. apex {
  390. name: "com.android.gki.fake",
  391. binaries: ["foo"],
  392. key: "myapex.key",
  393. file_contexts: ":myapex-file_contexts",
  394. updatable: false,
  395. }
  396. cc_library_shared {
  397. name: "mylib2",
  398. srcs: ["mylib.cpp"],
  399. system_shared_libs: [],
  400. stl: "none",
  401. static_libs: ["libstatic"],
  402. // TODO: remove //apex_available:platform
  403. apex_available: [
  404. "//apex_available:platform",
  405. "myapex",
  406. ],
  407. }
  408. cc_prebuilt_library_shared {
  409. name: "mylib2",
  410. srcs: ["prebuilt.so"],
  411. // TODO: remove //apex_available:platform
  412. apex_available: [
  413. "//apex_available:platform",
  414. "myapex",
  415. ],
  416. }
  417. cc_library_static {
  418. name: "libstatic",
  419. srcs: ["mylib.cpp"],
  420. system_shared_libs: [],
  421. stl: "none",
  422. // TODO: remove //apex_available:platform
  423. apex_available: [
  424. "//apex_available:platform",
  425. "myapex",
  426. ],
  427. }
  428. java_library {
  429. name: "myjar",
  430. srcs: ["foo/bar/MyClass.java"],
  431. stem: "myjar_stem",
  432. sdk_version: "none",
  433. system_modules: "none",
  434. static_libs: ["myotherjar"],
  435. libs: ["mysharedjar"],
  436. // TODO: remove //apex_available:platform
  437. apex_available: [
  438. "//apex_available:platform",
  439. "myapex",
  440. ],
  441. }
  442. dex_import {
  443. name: "myjar_dex",
  444. jars: ["prebuilt.jar"],
  445. apex_available: [
  446. "//apex_available:platform",
  447. "myapex",
  448. ],
  449. }
  450. java_library {
  451. name: "myotherjar",
  452. srcs: ["foo/bar/MyClass.java"],
  453. sdk_version: "none",
  454. system_modules: "none",
  455. // TODO: remove //apex_available:platform
  456. apex_available: [
  457. "//apex_available:platform",
  458. "myapex",
  459. ],
  460. }
  461. java_library {
  462. name: "mysharedjar",
  463. srcs: ["foo/bar/MyClass.java"],
  464. sdk_version: "none",
  465. system_modules: "none",
  466. }
  467. `)
  468. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  469. // Make sure that Android.mk is created
  470. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  471. data := android.AndroidMkDataForTest(t, ctx, ab)
  472. var builder strings.Builder
  473. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  474. androidMk := builder.String()
  475. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  476. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  477. optFlags := apexRule.Args["opt_flags"]
  478. ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
  479. // Ensure that the NOTICE output is being packaged as an asset.
  480. ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
  481. copyCmds := apexRule.Args["copy_commands"]
  482. // Ensure that main rule creates an output
  483. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  484. // Ensure that apex variant is created for the direct dep
  485. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  486. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
  487. ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
  488. ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
  489. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
  490. // Ensure that apex variant is created for the indirect dep
  491. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  492. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
  493. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
  494. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
  495. ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
  496. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
  497. // Ensure that both direct and indirect deps are copied into apex
  498. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  499. ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  500. ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
  501. ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
  502. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
  503. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
  504. ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
  505. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  506. // .. but not for java libs
  507. ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
  508. ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
  509. // Ensure that the platform variant ends with _shared or _common
  510. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  511. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  512. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
  513. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
  514. ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
  515. // Ensure that dynamic dependency to java libs are not included
  516. ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
  517. // Ensure that all symlinks are present.
  518. found_foo_link_64 := false
  519. found_foo := false
  520. for _, cmd := range strings.Split(copyCmds, " && ") {
  521. if strings.HasPrefix(cmd, "ln -sfn foo64") {
  522. if strings.HasSuffix(cmd, "bin/foo") {
  523. found_foo = true
  524. } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
  525. found_foo_link_64 = true
  526. }
  527. }
  528. }
  529. good := found_foo && found_foo_link_64
  530. if !good {
  531. t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
  532. }
  533. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  534. ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
  535. ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
  536. ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
  537. ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
  538. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  539. ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
  540. ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
  541. ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
  542. ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
  543. }
  544. func TestDefaults(t *testing.T) {
  545. ctx := testApex(t, `
  546. apex_defaults {
  547. name: "myapex-defaults",
  548. key: "myapex.key",
  549. prebuilts: ["myetc"],
  550. native_shared_libs: ["mylib"],
  551. java_libs: ["myjar"],
  552. apps: ["AppFoo"],
  553. rros: ["rro"],
  554. bpfs: ["bpf", "netdTest"],
  555. updatable: false,
  556. }
  557. prebuilt_etc {
  558. name: "myetc",
  559. src: "myprebuilt",
  560. }
  561. apex {
  562. name: "myapex",
  563. defaults: ["myapex-defaults"],
  564. }
  565. apex_key {
  566. name: "myapex.key",
  567. public_key: "testkey.avbpubkey",
  568. private_key: "testkey.pem",
  569. }
  570. cc_library {
  571. name: "mylib",
  572. system_shared_libs: [],
  573. stl: "none",
  574. apex_available: [ "myapex" ],
  575. }
  576. java_library {
  577. name: "myjar",
  578. srcs: ["foo/bar/MyClass.java"],
  579. sdk_version: "none",
  580. system_modules: "none",
  581. apex_available: [ "myapex" ],
  582. }
  583. android_app {
  584. name: "AppFoo",
  585. srcs: ["foo/bar/MyClass.java"],
  586. sdk_version: "none",
  587. system_modules: "none",
  588. apex_available: [ "myapex" ],
  589. }
  590. runtime_resource_overlay {
  591. name: "rro",
  592. theme: "blue",
  593. }
  594. bpf {
  595. name: "bpf",
  596. srcs: ["bpf.c", "bpf2.c"],
  597. }
  598. bpf {
  599. name: "netdTest",
  600. srcs: ["netdTest.c"],
  601. sub_dir: "netd",
  602. }
  603. `)
  604. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  605. "etc/myetc",
  606. "javalib/myjar.jar",
  607. "lib64/mylib.so",
  608. "app/AppFoo@TEST.BUILD_ID/AppFoo.apk",
  609. "overlay/blue/rro.apk",
  610. "etc/bpf/bpf.o",
  611. "etc/bpf/bpf2.o",
  612. "etc/bpf/netd/netdTest.o",
  613. })
  614. }
  615. func TestApexManifest(t *testing.T) {
  616. ctx := testApex(t, `
  617. apex {
  618. name: "myapex",
  619. key: "myapex.key",
  620. updatable: false,
  621. }
  622. apex_key {
  623. name: "myapex.key",
  624. public_key: "testkey.avbpubkey",
  625. private_key: "testkey.pem",
  626. }
  627. `)
  628. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  629. args := module.Rule("apexRule").Args
  630. if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
  631. t.Error("manifest should be apex_manifest.pb, but " + manifest)
  632. }
  633. }
  634. func TestApexManifestMinSdkVersion(t *testing.T) {
  635. ctx := testApex(t, `
  636. apex_defaults {
  637. name: "my_defaults",
  638. key: "myapex.key",
  639. product_specific: true,
  640. file_contexts: ":my-file-contexts",
  641. updatable: false,
  642. }
  643. apex {
  644. name: "myapex_30",
  645. min_sdk_version: "30",
  646. defaults: ["my_defaults"],
  647. }
  648. apex {
  649. name: "myapex_current",
  650. min_sdk_version: "current",
  651. defaults: ["my_defaults"],
  652. }
  653. apex {
  654. name: "myapex_none",
  655. defaults: ["my_defaults"],
  656. }
  657. apex_key {
  658. name: "myapex.key",
  659. public_key: "testkey.avbpubkey",
  660. private_key: "testkey.pem",
  661. }
  662. filegroup {
  663. name: "my-file-contexts",
  664. srcs: ["product_specific_file_contexts"],
  665. }
  666. `, withFiles(map[string][]byte{
  667. "product_specific_file_contexts": nil,
  668. }), android.FixtureModifyProductVariables(
  669. func(variables android.FixtureProductVariables) {
  670. variables.Unbundled_build = proptools.BoolPtr(true)
  671. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
  672. }), android.FixtureMergeEnv(map[string]string{
  673. "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
  674. }))
  675. testCases := []struct {
  676. module string
  677. minSdkVersion string
  678. }{
  679. {
  680. module: "myapex_30",
  681. minSdkVersion: "30",
  682. },
  683. {
  684. module: "myapex_current",
  685. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  686. },
  687. {
  688. module: "myapex_none",
  689. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  690. },
  691. }
  692. for _, tc := range testCases {
  693. module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
  694. args := module.Rule("apexRule").Args
  695. optFlags := args["opt_flags"]
  696. if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
  697. t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
  698. }
  699. }
  700. }
  701. func TestFileContexts(t *testing.T) {
  702. for _, vendor := range []bool{true, false} {
  703. prop := ""
  704. if vendor {
  705. prop = "vendor: true,\n"
  706. }
  707. ctx := testApex(t, `
  708. apex {
  709. name: "myapex",
  710. key: "myapex.key",
  711. updatable: false,
  712. `+prop+`
  713. }
  714. apex_key {
  715. name: "myapex.key",
  716. public_key: "testkey.avbpubkey",
  717. private_key: "testkey.pem",
  718. }
  719. `)
  720. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("file_contexts")
  721. if vendor {
  722. android.AssertStringDoesContain(t, "should force-label as vendor_apex_metadata_file",
  723. rule.RuleParams.Command,
  724. "apex_manifest\\\\.pb u:object_r:vendor_apex_metadata_file:s0")
  725. } else {
  726. android.AssertStringDoesContain(t, "should force-label as system_file",
  727. rule.RuleParams.Command,
  728. "apex_manifest\\\\.pb u:object_r:system_file:s0")
  729. }
  730. }
  731. }
  732. func TestBasicZipApex(t *testing.T) {
  733. ctx := testApex(t, `
  734. apex {
  735. name: "myapex",
  736. key: "myapex.key",
  737. payload_type: "zip",
  738. native_shared_libs: ["mylib"],
  739. updatable: false,
  740. }
  741. apex_key {
  742. name: "myapex.key",
  743. public_key: "testkey.avbpubkey",
  744. private_key: "testkey.pem",
  745. }
  746. cc_library {
  747. name: "mylib",
  748. srcs: ["mylib.cpp"],
  749. shared_libs: ["mylib2"],
  750. system_shared_libs: [],
  751. stl: "none",
  752. apex_available: [ "myapex" ],
  753. }
  754. cc_library {
  755. name: "mylib2",
  756. srcs: ["mylib.cpp"],
  757. system_shared_libs: [],
  758. stl: "none",
  759. apex_available: [ "myapex" ],
  760. }
  761. `)
  762. zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
  763. copyCmds := zipApexRule.Args["copy_commands"]
  764. // Ensure that main rule creates an output
  765. ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
  766. // Ensure that APEX variant is created for the direct dep
  767. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  768. // Ensure that APEX variant is created for the indirect dep
  769. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  770. // Ensure that both direct and indirect deps are copied into apex
  771. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
  772. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
  773. }
  774. func TestApexWithStubs(t *testing.T) {
  775. ctx := testApex(t, `
  776. apex {
  777. name: "myapex",
  778. key: "myapex.key",
  779. native_shared_libs: ["mylib", "mylib3"],
  780. binaries: ["foo.rust"],
  781. updatable: false,
  782. }
  783. apex_key {
  784. name: "myapex.key",
  785. public_key: "testkey.avbpubkey",
  786. private_key: "testkey.pem",
  787. }
  788. cc_library {
  789. name: "mylib",
  790. srcs: ["mylib.cpp"],
  791. shared_libs: ["mylib2", "mylib3"],
  792. system_shared_libs: [],
  793. stl: "none",
  794. apex_available: [ "myapex" ],
  795. }
  796. cc_library {
  797. name: "mylib2",
  798. srcs: ["mylib.cpp"],
  799. cflags: ["-include mylib.h"],
  800. system_shared_libs: [],
  801. stl: "none",
  802. stubs: {
  803. versions: ["1", "2", "3"],
  804. },
  805. }
  806. cc_library {
  807. name: "mylib3",
  808. srcs: ["mylib.cpp"],
  809. shared_libs: ["mylib4"],
  810. system_shared_libs: [],
  811. stl: "none",
  812. stubs: {
  813. versions: ["10", "11", "12"],
  814. },
  815. apex_available: [ "myapex" ],
  816. }
  817. cc_library {
  818. name: "mylib4",
  819. srcs: ["mylib.cpp"],
  820. system_shared_libs: [],
  821. stl: "none",
  822. apex_available: [ "myapex" ],
  823. }
  824. rust_binary {
  825. name: "foo.rust",
  826. srcs: ["foo.rs"],
  827. shared_libs: ["libfoo.shared_from_rust"],
  828. prefer_rlib: true,
  829. apex_available: ["myapex"],
  830. }
  831. cc_library_shared {
  832. name: "libfoo.shared_from_rust",
  833. srcs: ["mylib.cpp"],
  834. system_shared_libs: [],
  835. stl: "none",
  836. stubs: {
  837. versions: ["10", "11", "12"],
  838. },
  839. }
  840. `)
  841. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  842. copyCmds := apexRule.Args["copy_commands"]
  843. // Ensure that direct non-stubs dep is always included
  844. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  845. // Ensure that indirect stubs dep is not included
  846. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  847. // Ensure that direct stubs dep is included
  848. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  849. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  850. // Ensure that mylib is linking with the latest version of stubs for mylib2
  851. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  852. // ... and not linking to the non-stub (impl) variant of mylib2
  853. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  854. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  855. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
  856. // .. and not linking to the stubs variant of mylib3
  857. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
  858. // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
  859. // is replaced by sharing of "cFlags" in cc/builder.go.
  860. // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
  861. // module variable representing "cflags". So it was not detected by ensureNotContains.
  862. // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
  863. // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
  864. // including the original cflags's "-include mylib.h".
  865. //
  866. // Ensure that stubs libs are built without -include flags
  867. // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  868. // ensureNotContains(t, mylib2Cflags, "-include ")
  869. // Ensure that genstub for platform-provided lib is invoked with --systemapi
  870. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"], "--systemapi")
  871. // Ensure that genstub for apex-provided lib is invoked with --apex
  872. ensureContains(t, ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_shared_12").Rule("genStubSrc").Args["flags"], "--apex")
  873. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  874. "lib64/mylib.so",
  875. "lib64/mylib3.so",
  876. "lib64/mylib4.so",
  877. "bin/foo.rust",
  878. "lib64/libc++.so", // by the implicit dependency from foo.rust
  879. "lib64/liblog.so", // by the implicit dependency from foo.rust
  880. })
  881. // Ensure that stub dependency from a rust module is not included
  882. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  883. // The rust module is linked to the stub cc library
  884. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustLink").Args["linkFlags"]
  885. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  886. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  887. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  888. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  889. }
  890. func TestApexCanUsePrivateApis(t *testing.T) {
  891. ctx := testApex(t, `
  892. apex {
  893. name: "myapex",
  894. key: "myapex.key",
  895. native_shared_libs: ["mylib"],
  896. binaries: ["foo.rust"],
  897. updatable: false,
  898. platform_apis: true,
  899. }
  900. apex_key {
  901. name: "myapex.key",
  902. public_key: "testkey.avbpubkey",
  903. private_key: "testkey.pem",
  904. }
  905. cc_library {
  906. name: "mylib",
  907. srcs: ["mylib.cpp"],
  908. shared_libs: ["mylib2"],
  909. system_shared_libs: [],
  910. stl: "none",
  911. apex_available: [ "myapex" ],
  912. }
  913. cc_library {
  914. name: "mylib2",
  915. srcs: ["mylib.cpp"],
  916. cflags: ["-include mylib.h"],
  917. system_shared_libs: [],
  918. stl: "none",
  919. stubs: {
  920. versions: ["1", "2", "3"],
  921. },
  922. }
  923. rust_binary {
  924. name: "foo.rust",
  925. srcs: ["foo.rs"],
  926. shared_libs: ["libfoo.shared_from_rust"],
  927. prefer_rlib: true,
  928. apex_available: ["myapex"],
  929. }
  930. cc_library_shared {
  931. name: "libfoo.shared_from_rust",
  932. srcs: ["mylib.cpp"],
  933. system_shared_libs: [],
  934. stl: "none",
  935. stubs: {
  936. versions: ["10", "11", "12"],
  937. },
  938. }
  939. `)
  940. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  941. copyCmds := apexRule.Args["copy_commands"]
  942. // Ensure that indirect stubs dep is not included
  943. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  944. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  945. // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
  946. // of the platform_apis: true)
  947. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  948. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  949. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  950. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustLink").Args["linkFlags"]
  951. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  952. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  953. }
  954. func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
  955. t.Parallel()
  956. ctx := testApex(t, `
  957. apex {
  958. name: "myapex",
  959. key: "myapex.key",
  960. native_shared_libs: ["mylib", "mylib3"],
  961. min_sdk_version: "29",
  962. }
  963. apex_key {
  964. name: "myapex.key",
  965. public_key: "testkey.avbpubkey",
  966. private_key: "testkey.pem",
  967. }
  968. cc_library {
  969. name: "mylib",
  970. srcs: ["mylib.cpp"],
  971. shared_libs: ["mylib2", "mylib3"],
  972. system_shared_libs: [],
  973. stl: "none",
  974. apex_available: [ "myapex" ],
  975. min_sdk_version: "28",
  976. }
  977. cc_library {
  978. name: "mylib2",
  979. srcs: ["mylib.cpp"],
  980. cflags: ["-include mylib.h"],
  981. system_shared_libs: [],
  982. stl: "none",
  983. stubs: {
  984. versions: ["28", "29", "30", "current"],
  985. },
  986. min_sdk_version: "28",
  987. }
  988. cc_library {
  989. name: "mylib3",
  990. srcs: ["mylib.cpp"],
  991. shared_libs: ["mylib4"],
  992. system_shared_libs: [],
  993. stl: "none",
  994. stubs: {
  995. versions: ["28", "29", "30", "current"],
  996. },
  997. apex_available: [ "myapex" ],
  998. min_sdk_version: "28",
  999. }
  1000. cc_library {
  1001. name: "mylib4",
  1002. srcs: ["mylib.cpp"],
  1003. system_shared_libs: [],
  1004. stl: "none",
  1005. apex_available: [ "myapex" ],
  1006. min_sdk_version: "28",
  1007. }
  1008. `)
  1009. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1010. copyCmds := apexRule.Args["copy_commands"]
  1011. // Ensure that direct non-stubs dep is always included
  1012. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1013. // Ensure that indirect stubs dep is not included
  1014. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  1015. // Ensure that direct stubs dep is included
  1016. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  1017. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
  1018. // Ensure that mylib is linking with the latest version of stub for mylib2
  1019. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  1020. // ... and not linking to the non-stub (impl) variant of mylib2
  1021. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  1022. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  1023. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
  1024. // .. and not linking to the stubs variant of mylib3
  1025. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
  1026. // Ensure that stubs libs are built without -include flags
  1027. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
  1028. ensureNotContains(t, mylib2Cflags, "-include ")
  1029. // Ensure that genstub is invoked with --systemapi
  1030. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"], "--systemapi")
  1031. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1032. "lib64/mylib.so",
  1033. "lib64/mylib3.so",
  1034. "lib64/mylib4.so",
  1035. })
  1036. }
  1037. func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
  1038. t.Parallel()
  1039. // myapex (Z)
  1040. // mylib -----------------.
  1041. // |
  1042. // otherapex (29) |
  1043. // libstub's versions: 29 Z current
  1044. // |
  1045. // <platform> |
  1046. // libplatform ----------------'
  1047. ctx := testApex(t, `
  1048. apex {
  1049. name: "myapex",
  1050. key: "myapex.key",
  1051. native_shared_libs: ["mylib"],
  1052. min_sdk_version: "Z", // non-final
  1053. }
  1054. cc_library {
  1055. name: "mylib",
  1056. srcs: ["mylib.cpp"],
  1057. shared_libs: ["libstub"],
  1058. apex_available: ["myapex"],
  1059. min_sdk_version: "Z",
  1060. }
  1061. apex_key {
  1062. name: "myapex.key",
  1063. public_key: "testkey.avbpubkey",
  1064. private_key: "testkey.pem",
  1065. }
  1066. apex {
  1067. name: "otherapex",
  1068. key: "myapex.key",
  1069. native_shared_libs: ["libstub"],
  1070. min_sdk_version: "29",
  1071. }
  1072. cc_library {
  1073. name: "libstub",
  1074. srcs: ["mylib.cpp"],
  1075. stubs: {
  1076. versions: ["29", "Z", "current"],
  1077. },
  1078. apex_available: ["otherapex"],
  1079. min_sdk_version: "29",
  1080. }
  1081. // platform module depending on libstub from otherapex should use the latest stub("current")
  1082. cc_library {
  1083. name: "libplatform",
  1084. srcs: ["mylib.cpp"],
  1085. shared_libs: ["libstub"],
  1086. }
  1087. `,
  1088. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1089. variables.Platform_sdk_codename = proptools.StringPtr("Z")
  1090. variables.Platform_sdk_final = proptools.BoolPtr(false)
  1091. variables.Platform_version_active_codenames = []string{"Z"}
  1092. }),
  1093. )
  1094. // Ensure that mylib from myapex is built against the latest stub (current)
  1095. mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1096. ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
  1097. mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1098. ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1099. // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
  1100. libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  1101. ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
  1102. libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1103. ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1104. }
  1105. func TestApexWithExplicitStubsDependency(t *testing.T) {
  1106. ctx := testApex(t, `
  1107. apex {
  1108. name: "myapex2",
  1109. key: "myapex2.key",
  1110. native_shared_libs: ["mylib"],
  1111. updatable: false,
  1112. }
  1113. apex_key {
  1114. name: "myapex2.key",
  1115. public_key: "testkey.avbpubkey",
  1116. private_key: "testkey.pem",
  1117. }
  1118. cc_library {
  1119. name: "mylib",
  1120. srcs: ["mylib.cpp"],
  1121. shared_libs: ["libfoo#10"],
  1122. static_libs: ["libbaz"],
  1123. system_shared_libs: [],
  1124. stl: "none",
  1125. apex_available: [ "myapex2" ],
  1126. }
  1127. cc_library {
  1128. name: "libfoo",
  1129. srcs: ["mylib.cpp"],
  1130. shared_libs: ["libbar"],
  1131. system_shared_libs: [],
  1132. stl: "none",
  1133. stubs: {
  1134. versions: ["10", "20", "30"],
  1135. },
  1136. }
  1137. cc_library {
  1138. name: "libbar",
  1139. srcs: ["mylib.cpp"],
  1140. system_shared_libs: [],
  1141. stl: "none",
  1142. }
  1143. cc_library_static {
  1144. name: "libbaz",
  1145. srcs: ["mylib.cpp"],
  1146. system_shared_libs: [],
  1147. stl: "none",
  1148. apex_available: [ "myapex2" ],
  1149. }
  1150. `)
  1151. apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
  1152. copyCmds := apexRule.Args["copy_commands"]
  1153. // Ensure that direct non-stubs dep is always included
  1154. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1155. // Ensure that indirect stubs dep is not included
  1156. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1157. // Ensure that dependency of stubs is not included
  1158. ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1159. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1160. // Ensure that mylib is linking with version 10 of libfoo
  1161. ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
  1162. // ... and not linking to the non-stub (impl) variant of libfoo
  1163. ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
  1164. libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
  1165. // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
  1166. ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
  1167. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  1168. ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
  1169. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  1170. ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
  1171. }
  1172. func TestApexWithRuntimeLibsDependency(t *testing.T) {
  1173. /*
  1174. myapex
  1175. |
  1176. v (runtime_libs)
  1177. mylib ------+------> libfoo [provides stub]
  1178. |
  1179. `------> libbar
  1180. */
  1181. ctx := testApex(t, `
  1182. apex {
  1183. name: "myapex",
  1184. key: "myapex.key",
  1185. native_shared_libs: ["mylib"],
  1186. updatable: false,
  1187. }
  1188. apex_key {
  1189. name: "myapex.key",
  1190. public_key: "testkey.avbpubkey",
  1191. private_key: "testkey.pem",
  1192. }
  1193. cc_library {
  1194. name: "mylib",
  1195. srcs: ["mylib.cpp"],
  1196. static_libs: ["libstatic"],
  1197. shared_libs: ["libshared"],
  1198. runtime_libs: ["libfoo", "libbar"],
  1199. system_shared_libs: [],
  1200. stl: "none",
  1201. apex_available: [ "myapex" ],
  1202. }
  1203. cc_library {
  1204. name: "libfoo",
  1205. srcs: ["mylib.cpp"],
  1206. system_shared_libs: [],
  1207. stl: "none",
  1208. stubs: {
  1209. versions: ["10", "20", "30"],
  1210. },
  1211. }
  1212. cc_library {
  1213. name: "libbar",
  1214. srcs: ["mylib.cpp"],
  1215. system_shared_libs: [],
  1216. stl: "none",
  1217. apex_available: [ "myapex" ],
  1218. }
  1219. cc_library {
  1220. name: "libstatic",
  1221. srcs: ["mylib.cpp"],
  1222. system_shared_libs: [],
  1223. stl: "none",
  1224. apex_available: [ "myapex" ],
  1225. runtime_libs: ["libstatic_to_runtime"],
  1226. }
  1227. cc_library {
  1228. name: "libshared",
  1229. srcs: ["mylib.cpp"],
  1230. system_shared_libs: [],
  1231. stl: "none",
  1232. apex_available: [ "myapex" ],
  1233. runtime_libs: ["libshared_to_runtime"],
  1234. }
  1235. cc_library {
  1236. name: "libstatic_to_runtime",
  1237. srcs: ["mylib.cpp"],
  1238. system_shared_libs: [],
  1239. stl: "none",
  1240. apex_available: [ "myapex" ],
  1241. }
  1242. cc_library {
  1243. name: "libshared_to_runtime",
  1244. srcs: ["mylib.cpp"],
  1245. system_shared_libs: [],
  1246. stl: "none",
  1247. apex_available: [ "myapex" ],
  1248. }
  1249. `)
  1250. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1251. copyCmds := apexRule.Args["copy_commands"]
  1252. // Ensure that direct non-stubs dep is always included
  1253. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1254. // Ensure that indirect stubs dep is not included
  1255. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1256. // Ensure that runtime_libs dep in included
  1257. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1258. ensureContains(t, copyCmds, "image.apex/lib64/libshared.so")
  1259. ensureContains(t, copyCmds, "image.apex/lib64/libshared_to_runtime.so")
  1260. ensureNotContains(t, copyCmds, "image.apex/lib64/libstatic_to_runtime.so")
  1261. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1262. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1263. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
  1264. }
  1265. var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
  1266. cc.PrepareForTestWithCcBuildComponents,
  1267. PrepareForTestWithApexBuildComponents,
  1268. android.FixtureAddTextFile("bionic/apex/Android.bp", `
  1269. apex {
  1270. name: "com.android.runtime",
  1271. key: "com.android.runtime.key",
  1272. native_shared_libs: ["libc"],
  1273. updatable: false,
  1274. }
  1275. apex_key {
  1276. name: "com.android.runtime.key",
  1277. public_key: "testkey.avbpubkey",
  1278. private_key: "testkey.pem",
  1279. }
  1280. `),
  1281. android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
  1282. )
  1283. func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
  1284. result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
  1285. cc_library {
  1286. name: "libc",
  1287. no_libcrt: true,
  1288. nocrt: true,
  1289. stl: "none",
  1290. system_shared_libs: [],
  1291. stubs: { versions: ["1"] },
  1292. apex_available: ["com.android.runtime"],
  1293. sanitize: {
  1294. hwaddress: true,
  1295. }
  1296. }
  1297. cc_prebuilt_library_shared {
  1298. name: "libclang_rt.hwasan",
  1299. no_libcrt: true,
  1300. nocrt: true,
  1301. stl: "none",
  1302. system_shared_libs: [],
  1303. srcs: [""],
  1304. stubs: { versions: ["1"] },
  1305. stem: "libclang_rt.hwasan-aarch64-android",
  1306. sanitize: {
  1307. never: true,
  1308. },
  1309. apex_available: [
  1310. "//apex_available:anyapex",
  1311. "//apex_available:platform",
  1312. ],
  1313. } `)
  1314. ctx := result.TestContext
  1315. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1316. "lib64/bionic/libc.so",
  1317. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1318. })
  1319. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1320. installed := hwasan.Description("install libclang_rt.hwasan")
  1321. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1322. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1323. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1324. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1325. }
  1326. func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
  1327. result := android.GroupFixturePreparers(
  1328. prepareForTestOfRuntimeApexWithHwasan,
  1329. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1330. variables.SanitizeDevice = []string{"hwaddress"}
  1331. }),
  1332. ).RunTestWithBp(t, `
  1333. cc_library {
  1334. name: "libc",
  1335. no_libcrt: true,
  1336. nocrt: true,
  1337. stl: "none",
  1338. system_shared_libs: [],
  1339. stubs: { versions: ["1"] },
  1340. apex_available: ["com.android.runtime"],
  1341. }
  1342. cc_prebuilt_library_shared {
  1343. name: "libclang_rt.hwasan",
  1344. no_libcrt: true,
  1345. nocrt: true,
  1346. stl: "none",
  1347. system_shared_libs: [],
  1348. srcs: [""],
  1349. stubs: { versions: ["1"] },
  1350. stem: "libclang_rt.hwasan-aarch64-android",
  1351. sanitize: {
  1352. never: true,
  1353. },
  1354. apex_available: [
  1355. "//apex_available:anyapex",
  1356. "//apex_available:platform",
  1357. ],
  1358. }
  1359. `)
  1360. ctx := result.TestContext
  1361. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1362. "lib64/bionic/libc.so",
  1363. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1364. })
  1365. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1366. installed := hwasan.Description("install libclang_rt.hwasan")
  1367. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1368. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1369. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1370. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1371. }
  1372. func TestApexDependsOnLLNDKTransitively(t *testing.T) {
  1373. testcases := []struct {
  1374. name string
  1375. minSdkVersion string
  1376. apexVariant string
  1377. shouldLink string
  1378. shouldNotLink []string
  1379. }{
  1380. {
  1381. name: "unspecified version links to the latest",
  1382. minSdkVersion: "",
  1383. apexVariant: "apex10000",
  1384. shouldLink: "current",
  1385. shouldNotLink: []string{"29", "30"},
  1386. },
  1387. {
  1388. name: "always use the latest",
  1389. minSdkVersion: "min_sdk_version: \"29\",",
  1390. apexVariant: "apex29",
  1391. shouldLink: "current",
  1392. shouldNotLink: []string{"29", "30"},
  1393. },
  1394. }
  1395. for _, tc := range testcases {
  1396. t.Run(tc.name, func(t *testing.T) {
  1397. ctx := testApex(t, `
  1398. apex {
  1399. name: "myapex",
  1400. key: "myapex.key",
  1401. native_shared_libs: ["mylib"],
  1402. updatable: false,
  1403. `+tc.minSdkVersion+`
  1404. }
  1405. apex_key {
  1406. name: "myapex.key",
  1407. public_key: "testkey.avbpubkey",
  1408. private_key: "testkey.pem",
  1409. }
  1410. cc_library {
  1411. name: "mylib",
  1412. srcs: ["mylib.cpp"],
  1413. vendor_available: true,
  1414. shared_libs: ["libbar"],
  1415. system_shared_libs: [],
  1416. stl: "none",
  1417. apex_available: [ "myapex" ],
  1418. min_sdk_version: "29",
  1419. }
  1420. cc_library {
  1421. name: "libbar",
  1422. srcs: ["mylib.cpp"],
  1423. system_shared_libs: [],
  1424. stl: "none",
  1425. stubs: { versions: ["29","30"] },
  1426. llndk: {
  1427. symbol_file: "libbar.map.txt",
  1428. }
  1429. }
  1430. `,
  1431. withUnbundledBuild,
  1432. )
  1433. // Ensure that LLNDK dep is not included
  1434. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1435. "lib64/mylib.so",
  1436. })
  1437. // Ensure that LLNDK dep is required
  1438. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1439. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1440. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
  1441. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
  1442. ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
  1443. for _, ver := range tc.shouldNotLink {
  1444. ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
  1445. }
  1446. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
  1447. ver := tc.shouldLink
  1448. if tc.shouldLink == "current" {
  1449. ver = strconv.Itoa(android.FutureApiLevelInt)
  1450. }
  1451. ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
  1452. })
  1453. }
  1454. }
  1455. func TestApexWithSystemLibsStubs(t *testing.T) {
  1456. ctx := testApex(t, `
  1457. apex {
  1458. name: "myapex",
  1459. key: "myapex.key",
  1460. native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
  1461. updatable: false,
  1462. }
  1463. apex_key {
  1464. name: "myapex.key",
  1465. public_key: "testkey.avbpubkey",
  1466. private_key: "testkey.pem",
  1467. }
  1468. cc_library {
  1469. name: "mylib",
  1470. srcs: ["mylib.cpp"],
  1471. system_shared_libs: ["libc", "libm"],
  1472. shared_libs: ["libdl#27"],
  1473. stl: "none",
  1474. apex_available: [ "myapex" ],
  1475. }
  1476. cc_library_shared {
  1477. name: "mylib_shared",
  1478. srcs: ["mylib.cpp"],
  1479. shared_libs: ["libdl#27"],
  1480. stl: "none",
  1481. apex_available: [ "myapex" ],
  1482. }
  1483. cc_library {
  1484. name: "libBootstrap",
  1485. srcs: ["mylib.cpp"],
  1486. stl: "none",
  1487. bootstrap: true,
  1488. }
  1489. `)
  1490. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1491. copyCmds := apexRule.Args["copy_commands"]
  1492. // Ensure that mylib, libm, libdl are included.
  1493. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1494. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
  1495. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
  1496. // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
  1497. ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
  1498. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1499. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1500. mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
  1501. // For dependency to libc
  1502. // Ensure that mylib is linking with the latest version of stubs
  1503. ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
  1504. // ... and not linking to the non-stub (impl) variant
  1505. ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1506. // ... Cflags from stub is correctly exported to mylib
  1507. ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
  1508. ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
  1509. // For dependency to libm
  1510. // Ensure that mylib is linking with the non-stub (impl) variant
  1511. ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
  1512. // ... and not linking to the stub variant
  1513. ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
  1514. // ... and is not compiling with the stub
  1515. ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
  1516. ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
  1517. // For dependency to libdl
  1518. // Ensure that mylib is linking with the specified version of stubs
  1519. ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
  1520. // ... and not linking to the other versions of stubs
  1521. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
  1522. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
  1523. // ... and not linking to the non-stub (impl) variant
  1524. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
  1525. // ... Cflags from stub is correctly exported to mylib
  1526. ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
  1527. ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
  1528. // Ensure that libBootstrap is depending on the platform variant of bionic libs
  1529. libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1530. ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1531. ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
  1532. ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
  1533. }
  1534. func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
  1535. // there are three links between liba --> libz.
  1536. // 1) myapex -> libx -> liba -> libz : this should be #30 link
  1537. // 2) otherapex -> liby -> liba -> libz : this should be #30 link
  1538. // 3) (platform) -> liba -> libz : this should be non-stub link
  1539. ctx := testApex(t, `
  1540. apex {
  1541. name: "myapex",
  1542. key: "myapex.key",
  1543. native_shared_libs: ["libx"],
  1544. min_sdk_version: "29",
  1545. }
  1546. apex {
  1547. name: "otherapex",
  1548. key: "myapex.key",
  1549. native_shared_libs: ["liby"],
  1550. min_sdk_version: "30",
  1551. }
  1552. apex_key {
  1553. name: "myapex.key",
  1554. public_key: "testkey.avbpubkey",
  1555. private_key: "testkey.pem",
  1556. }
  1557. cc_library {
  1558. name: "libx",
  1559. shared_libs: ["liba"],
  1560. system_shared_libs: [],
  1561. stl: "none",
  1562. apex_available: [ "myapex" ],
  1563. min_sdk_version: "29",
  1564. }
  1565. cc_library {
  1566. name: "liby",
  1567. shared_libs: ["liba"],
  1568. system_shared_libs: [],
  1569. stl: "none",
  1570. apex_available: [ "otherapex" ],
  1571. min_sdk_version: "29",
  1572. }
  1573. cc_library {
  1574. name: "liba",
  1575. shared_libs: ["libz"],
  1576. system_shared_libs: [],
  1577. stl: "none",
  1578. apex_available: [
  1579. "//apex_available:anyapex",
  1580. "//apex_available:platform",
  1581. ],
  1582. min_sdk_version: "29",
  1583. }
  1584. cc_library {
  1585. name: "libz",
  1586. system_shared_libs: [],
  1587. stl: "none",
  1588. stubs: {
  1589. versions: ["28", "30"],
  1590. },
  1591. }
  1592. `)
  1593. expectLink := func(from, from_variant, to, to_variant string) {
  1594. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1595. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1596. }
  1597. expectNoLink := func(from, from_variant, to, to_variant string) {
  1598. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1599. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1600. }
  1601. // platform liba is linked to non-stub version
  1602. expectLink("liba", "shared", "libz", "shared")
  1603. // liba in myapex is linked to current
  1604. expectLink("liba", "shared_apex29", "libz", "shared_current")
  1605. expectNoLink("liba", "shared_apex29", "libz", "shared_30")
  1606. expectNoLink("liba", "shared_apex29", "libz", "shared_28")
  1607. expectNoLink("liba", "shared_apex29", "libz", "shared")
  1608. // liba in otherapex is linked to current
  1609. expectLink("liba", "shared_apex30", "libz", "shared_current")
  1610. expectNoLink("liba", "shared_apex30", "libz", "shared_30")
  1611. expectNoLink("liba", "shared_apex30", "libz", "shared_28")
  1612. expectNoLink("liba", "shared_apex30", "libz", "shared")
  1613. }
  1614. func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
  1615. ctx := testApex(t, `
  1616. apex {
  1617. name: "myapex",
  1618. key: "myapex.key",
  1619. native_shared_libs: ["libx"],
  1620. min_sdk_version: "R",
  1621. }
  1622. apex_key {
  1623. name: "myapex.key",
  1624. public_key: "testkey.avbpubkey",
  1625. private_key: "testkey.pem",
  1626. }
  1627. cc_library {
  1628. name: "libx",
  1629. shared_libs: ["libz"],
  1630. system_shared_libs: [],
  1631. stl: "none",
  1632. apex_available: [ "myapex" ],
  1633. min_sdk_version: "R",
  1634. }
  1635. cc_library {
  1636. name: "libz",
  1637. system_shared_libs: [],
  1638. stl: "none",
  1639. stubs: {
  1640. versions: ["29", "R"],
  1641. },
  1642. }
  1643. `,
  1644. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1645. variables.Platform_version_active_codenames = []string{"R"}
  1646. }),
  1647. )
  1648. expectLink := func(from, from_variant, to, to_variant string) {
  1649. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1650. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1651. }
  1652. expectNoLink := func(from, from_variant, to, to_variant string) {
  1653. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1654. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1655. }
  1656. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1657. expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
  1658. expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
  1659. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1660. }
  1661. func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
  1662. testApex(t, `
  1663. apex {
  1664. name: "myapex",
  1665. key: "myapex.key",
  1666. java_libs: ["libx"],
  1667. min_sdk_version: "S",
  1668. }
  1669. apex_key {
  1670. name: "myapex.key",
  1671. public_key: "testkey.avbpubkey",
  1672. private_key: "testkey.pem",
  1673. }
  1674. java_library {
  1675. name: "libx",
  1676. srcs: ["a.java"],
  1677. apex_available: [ "myapex" ],
  1678. sdk_version: "current",
  1679. min_sdk_version: "S", // should be okay
  1680. }
  1681. `,
  1682. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1683. variables.Platform_version_active_codenames = []string{"S"}
  1684. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1685. }),
  1686. )
  1687. }
  1688. func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
  1689. ctx := testApex(t, `
  1690. apex {
  1691. name: "myapex",
  1692. key: "myapex.key",
  1693. native_shared_libs: ["libx"],
  1694. updatable: false,
  1695. }
  1696. apex_key {
  1697. name: "myapex.key",
  1698. public_key: "testkey.avbpubkey",
  1699. private_key: "testkey.pem",
  1700. }
  1701. cc_library {
  1702. name: "libx",
  1703. shared_libs: ["libz"],
  1704. system_shared_libs: [],
  1705. stl: "none",
  1706. apex_available: [ "myapex" ],
  1707. }
  1708. cc_library {
  1709. name: "libz",
  1710. system_shared_libs: [],
  1711. stl: "none",
  1712. stubs: {
  1713. versions: ["1", "2"],
  1714. },
  1715. }
  1716. `)
  1717. expectLink := func(from, from_variant, to, to_variant string) {
  1718. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1719. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1720. }
  1721. expectNoLink := func(from, from_variant, to, to_variant string) {
  1722. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1723. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1724. }
  1725. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1726. expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
  1727. expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
  1728. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1729. }
  1730. func TestApexMinSdkVersion_InVendorApex(t *testing.T) {
  1731. ctx := testApex(t, `
  1732. apex {
  1733. name: "myapex",
  1734. key: "myapex.key",
  1735. native_shared_libs: ["mylib"],
  1736. updatable: true,
  1737. vendor: true,
  1738. min_sdk_version: "29",
  1739. }
  1740. apex_key {
  1741. name: "myapex.key",
  1742. public_key: "testkey.avbpubkey",
  1743. private_key: "testkey.pem",
  1744. }
  1745. cc_library {
  1746. name: "mylib",
  1747. srcs: ["mylib.cpp"],
  1748. vendor_available: true,
  1749. min_sdk_version: "29",
  1750. shared_libs: ["libbar"],
  1751. }
  1752. cc_library {
  1753. name: "libbar",
  1754. stubs: { versions: ["29", "30"] },
  1755. llndk: { symbol_file: "libbar.map.txt" },
  1756. }
  1757. `)
  1758. vendorVariant := "android_vendor.29_arm64_armv8-a"
  1759. mylib := ctx.ModuleForTests("mylib", vendorVariant+"_shared_myapex")
  1760. // Ensure that mylib links with "current" LLNDK
  1761. libFlags := names(mylib.Rule("ld").Args["libFlags"])
  1762. ensureListContains(t, libFlags, "out/soong/.intermediates/libbar/"+vendorVariant+"_shared_current/libbar.so")
  1763. // Ensure that mylib is targeting 29
  1764. ccRule := ctx.ModuleForTests("mylib", vendorVariant+"_static_apex29").Output("obj/mylib.o")
  1765. ensureContains(t, ccRule.Args["cFlags"], "-target aarch64-linux-android29")
  1766. // Ensure that the correct variant of crtbegin_so is used.
  1767. crtBegin := mylib.Rule("ld").Args["crtBegin"]
  1768. ensureContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
  1769. // Ensure that the crtbegin_so used by the APEX is targeting 29
  1770. cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
  1771. android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
  1772. }
  1773. func TestTrackAllowedDeps(t *testing.T) {
  1774. ctx := testApex(t, `
  1775. apex {
  1776. name: "myapex",
  1777. key: "myapex.key",
  1778. updatable: true,
  1779. native_shared_libs: [
  1780. "mylib",
  1781. "yourlib",
  1782. ],
  1783. min_sdk_version: "29",
  1784. }
  1785. apex {
  1786. name: "myapex2",
  1787. key: "myapex.key",
  1788. updatable: false,
  1789. native_shared_libs: ["yourlib"],
  1790. }
  1791. apex_key {
  1792. name: "myapex.key",
  1793. public_key: "testkey.avbpubkey",
  1794. private_key: "testkey.pem",
  1795. }
  1796. cc_library {
  1797. name: "mylib",
  1798. srcs: ["mylib.cpp"],
  1799. shared_libs: ["libbar"],
  1800. min_sdk_version: "29",
  1801. apex_available: ["myapex"],
  1802. }
  1803. cc_library {
  1804. name: "libbar",
  1805. stubs: { versions: ["29", "30"] },
  1806. }
  1807. cc_library {
  1808. name: "yourlib",
  1809. srcs: ["mylib.cpp"],
  1810. min_sdk_version: "29",
  1811. apex_available: ["myapex", "myapex2", "//apex_available:platform"],
  1812. }
  1813. `, withFiles(android.MockFS{
  1814. "packages/modules/common/build/allowed_deps.txt": nil,
  1815. }))
  1816. depsinfo := ctx.SingletonForTests("apex_depsinfo_singleton")
  1817. inputs := depsinfo.Rule("generateApexDepsInfoFilesRule").BuildParams.Inputs.Strings()
  1818. android.AssertStringListContains(t, "updatable myapex should generate depsinfo file", inputs,
  1819. "out/soong/.intermediates/myapex/android_common_myapex_image/depsinfo/flatlist.txt")
  1820. android.AssertStringListDoesNotContain(t, "non-updatable myapex2 should not generate depsinfo file", inputs,
  1821. "out/soong/.intermediates/myapex2/android_common_myapex2_image/depsinfo/flatlist.txt")
  1822. myapex := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  1823. flatlist := strings.Split(myapex.Output("depsinfo/flatlist.txt").BuildParams.Args["content"], "\\n")
  1824. android.AssertStringListContains(t, "deps with stubs should be tracked in depsinfo as external dep",
  1825. flatlist, "libbar(minSdkVersion:(no version)) (external)")
  1826. android.AssertStringListDoesNotContain(t, "do not track if not available for platform",
  1827. flatlist, "mylib:(minSdkVersion:29)")
  1828. android.AssertStringListContains(t, "track platform-available lib",
  1829. flatlist, "yourlib(minSdkVersion:29)")
  1830. }
  1831. func TestTrackAllowedDeps_SkipWithoutAllowedDepsTxt(t *testing.T) {
  1832. ctx := testApex(t, `
  1833. apex {
  1834. name: "myapex",
  1835. key: "myapex.key",
  1836. updatable: true,
  1837. min_sdk_version: "29",
  1838. }
  1839. apex_key {
  1840. name: "myapex.key",
  1841. public_key: "testkey.avbpubkey",
  1842. private_key: "testkey.pem",
  1843. }
  1844. `)
  1845. depsinfo := ctx.SingletonForTests("apex_depsinfo_singleton")
  1846. if nil != depsinfo.MaybeRule("generateApexDepsInfoFilesRule").Output {
  1847. t.Error("apex_depsinfo_singleton shouldn't run when allowed_deps.txt doesn't exist")
  1848. }
  1849. }
  1850. func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
  1851. ctx := testApex(t, `
  1852. apex {
  1853. name: "myapex",
  1854. key: "myapex.key",
  1855. native_shared_libs: ["libx"],
  1856. updatable: false,
  1857. }
  1858. apex_key {
  1859. name: "myapex.key",
  1860. public_key: "testkey.avbpubkey",
  1861. private_key: "testkey.pem",
  1862. }
  1863. cc_library {
  1864. name: "libx",
  1865. system_shared_libs: [],
  1866. stl: "none",
  1867. apex_available: [ "myapex" ],
  1868. stubs: {
  1869. versions: ["1", "2"],
  1870. },
  1871. }
  1872. cc_library {
  1873. name: "libz",
  1874. shared_libs: ["libx"],
  1875. system_shared_libs: [],
  1876. stl: "none",
  1877. }
  1878. `)
  1879. expectLink := func(from, from_variant, to, to_variant string) {
  1880. t.Helper()
  1881. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1882. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1883. }
  1884. expectNoLink := func(from, from_variant, to, to_variant string) {
  1885. t.Helper()
  1886. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1887. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1888. }
  1889. expectLink("libz", "shared", "libx", "shared_current")
  1890. expectNoLink("libz", "shared", "libx", "shared_2")
  1891. expectNoLink("libz", "shared", "libz", "shared_1")
  1892. expectNoLink("libz", "shared", "libz", "shared")
  1893. }
  1894. var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
  1895. func(variables android.FixtureProductVariables) {
  1896. variables.SanitizeDevice = []string{"hwaddress"}
  1897. },
  1898. )
  1899. func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
  1900. ctx := testApex(t, `
  1901. apex {
  1902. name: "myapex",
  1903. key: "myapex.key",
  1904. native_shared_libs: ["libx"],
  1905. min_sdk_version: "29",
  1906. }
  1907. apex_key {
  1908. name: "myapex.key",
  1909. public_key: "testkey.avbpubkey",
  1910. private_key: "testkey.pem",
  1911. }
  1912. cc_library {
  1913. name: "libx",
  1914. shared_libs: ["libbar"],
  1915. apex_available: [ "myapex" ],
  1916. min_sdk_version: "29",
  1917. }
  1918. cc_library {
  1919. name: "libbar",
  1920. stubs: {
  1921. versions: ["29", "30"],
  1922. },
  1923. }
  1924. `,
  1925. prepareForTestWithSantitizeHwaddress,
  1926. )
  1927. expectLink := func(from, from_variant, to, to_variant string) {
  1928. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1929. libFlags := ld.Args["libFlags"]
  1930. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1931. }
  1932. expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
  1933. }
  1934. func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
  1935. ctx := testApex(t, `
  1936. apex {
  1937. name: "myapex",
  1938. key: "myapex.key",
  1939. native_shared_libs: ["libx"],
  1940. min_sdk_version: "29",
  1941. }
  1942. apex_key {
  1943. name: "myapex.key",
  1944. public_key: "testkey.avbpubkey",
  1945. private_key: "testkey.pem",
  1946. }
  1947. cc_library {
  1948. name: "libx",
  1949. apex_available: [ "myapex" ],
  1950. min_sdk_version: "29",
  1951. }
  1952. `)
  1953. // ensure apex variant of c++ is linked with static unwinder
  1954. cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
  1955. ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1956. // note that platform variant is not.
  1957. cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  1958. ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1959. }
  1960. func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
  1961. testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
  1962. apex {
  1963. name: "myapex",
  1964. key: "myapex.key",
  1965. native_shared_libs: ["mylib"],
  1966. min_sdk_version: "29",
  1967. }
  1968. apex_key {
  1969. name: "myapex.key",
  1970. public_key: "testkey.avbpubkey",
  1971. private_key: "testkey.pem",
  1972. }
  1973. cc_library {
  1974. name: "mylib",
  1975. srcs: ["mylib.cpp"],
  1976. system_shared_libs: [],
  1977. stl: "none",
  1978. apex_available: [
  1979. "myapex",
  1980. ],
  1981. min_sdk_version: "30",
  1982. }
  1983. `)
  1984. testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
  1985. apex {
  1986. name: "myapex",
  1987. key: "myapex.key",
  1988. native_shared_libs: ["libfoo.ffi"],
  1989. min_sdk_version: "29",
  1990. }
  1991. apex_key {
  1992. name: "myapex.key",
  1993. public_key: "testkey.avbpubkey",
  1994. private_key: "testkey.pem",
  1995. }
  1996. rust_ffi_shared {
  1997. name: "libfoo.ffi",
  1998. srcs: ["foo.rs"],
  1999. crate_name: "foo",
  2000. apex_available: [
  2001. "myapex",
  2002. ],
  2003. min_sdk_version: "30",
  2004. }
  2005. `)
  2006. testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
  2007. apex {
  2008. name: "myapex",
  2009. key: "myapex.key",
  2010. java_libs: ["libfoo"],
  2011. min_sdk_version: "29",
  2012. }
  2013. apex_key {
  2014. name: "myapex.key",
  2015. public_key: "testkey.avbpubkey",
  2016. private_key: "testkey.pem",
  2017. }
  2018. java_import {
  2019. name: "libfoo",
  2020. jars: ["libfoo.jar"],
  2021. apex_available: [
  2022. "myapex",
  2023. ],
  2024. min_sdk_version: "30",
  2025. }
  2026. `)
  2027. // Skip check for modules compiling against core API surface
  2028. testApex(t, `
  2029. apex {
  2030. name: "myapex",
  2031. key: "myapex.key",
  2032. java_libs: ["libfoo"],
  2033. min_sdk_version: "29",
  2034. }
  2035. apex_key {
  2036. name: "myapex.key",
  2037. public_key: "testkey.avbpubkey",
  2038. private_key: "testkey.pem",
  2039. }
  2040. java_library {
  2041. name: "libfoo",
  2042. srcs: ["Foo.java"],
  2043. apex_available: [
  2044. "myapex",
  2045. ],
  2046. // Compile against core API surface
  2047. sdk_version: "core_current",
  2048. min_sdk_version: "30",
  2049. }
  2050. `)
  2051. }
  2052. func TestApexMinSdkVersion_Okay(t *testing.T) {
  2053. testApex(t, `
  2054. apex {
  2055. name: "myapex",
  2056. key: "myapex.key",
  2057. native_shared_libs: ["libfoo"],
  2058. java_libs: ["libbar"],
  2059. min_sdk_version: "29",
  2060. }
  2061. apex_key {
  2062. name: "myapex.key",
  2063. public_key: "testkey.avbpubkey",
  2064. private_key: "testkey.pem",
  2065. }
  2066. cc_library {
  2067. name: "libfoo",
  2068. srcs: ["mylib.cpp"],
  2069. shared_libs: ["libfoo_dep"],
  2070. apex_available: ["myapex"],
  2071. min_sdk_version: "29",
  2072. }
  2073. cc_library {
  2074. name: "libfoo_dep",
  2075. srcs: ["mylib.cpp"],
  2076. apex_available: ["myapex"],
  2077. min_sdk_version: "29",
  2078. }
  2079. java_library {
  2080. name: "libbar",
  2081. sdk_version: "current",
  2082. srcs: ["a.java"],
  2083. static_libs: [
  2084. "libbar_dep",
  2085. "libbar_import_dep",
  2086. ],
  2087. apex_available: ["myapex"],
  2088. min_sdk_version: "29",
  2089. }
  2090. java_library {
  2091. name: "libbar_dep",
  2092. sdk_version: "current",
  2093. srcs: ["a.java"],
  2094. apex_available: ["myapex"],
  2095. min_sdk_version: "29",
  2096. }
  2097. java_import {
  2098. name: "libbar_import_dep",
  2099. jars: ["libbar.jar"],
  2100. apex_available: ["myapex"],
  2101. min_sdk_version: "29",
  2102. }
  2103. `)
  2104. }
  2105. func TestApexMinSdkVersion_MinApiForArch(t *testing.T) {
  2106. // Tests that an apex dependency with min_sdk_version higher than the
  2107. // min_sdk_version of the apex is allowed as long as the dependency's
  2108. // min_sdk_version is less than or equal to the api level that the
  2109. // architecture was introduced in. In this case, arm64 didn't exist
  2110. // until api level 21, so the arm64 code will never need to run on
  2111. // an api level 20 device, even if other architectures of the apex
  2112. // will.
  2113. testApex(t, `
  2114. apex {
  2115. name: "myapex",
  2116. key: "myapex.key",
  2117. native_shared_libs: ["libfoo"],
  2118. min_sdk_version: "20",
  2119. }
  2120. apex_key {
  2121. name: "myapex.key",
  2122. public_key: "testkey.avbpubkey",
  2123. private_key: "testkey.pem",
  2124. }
  2125. cc_library {
  2126. name: "libfoo",
  2127. srcs: ["mylib.cpp"],
  2128. apex_available: ["myapex"],
  2129. min_sdk_version: "21",
  2130. stl: "none",
  2131. }
  2132. `)
  2133. }
  2134. func TestJavaStableSdkVersion(t *testing.T) {
  2135. testCases := []struct {
  2136. name string
  2137. expectedError string
  2138. bp string
  2139. preparer android.FixturePreparer
  2140. }{
  2141. {
  2142. name: "Non-updatable apex with non-stable dep",
  2143. bp: `
  2144. apex {
  2145. name: "myapex",
  2146. java_libs: ["myjar"],
  2147. key: "myapex.key",
  2148. updatable: false,
  2149. }
  2150. apex_key {
  2151. name: "myapex.key",
  2152. public_key: "testkey.avbpubkey",
  2153. private_key: "testkey.pem",
  2154. }
  2155. java_library {
  2156. name: "myjar",
  2157. srcs: ["foo/bar/MyClass.java"],
  2158. sdk_version: "test_current",
  2159. apex_available: ["myapex"],
  2160. }
  2161. `,
  2162. },
  2163. {
  2164. name: "Updatable apex with stable dep",
  2165. bp: `
  2166. apex {
  2167. name: "myapex",
  2168. java_libs: ["myjar"],
  2169. key: "myapex.key",
  2170. updatable: true,
  2171. min_sdk_version: "29",
  2172. }
  2173. apex_key {
  2174. name: "myapex.key",
  2175. public_key: "testkey.avbpubkey",
  2176. private_key: "testkey.pem",
  2177. }
  2178. java_library {
  2179. name: "myjar",
  2180. srcs: ["foo/bar/MyClass.java"],
  2181. sdk_version: "current",
  2182. apex_available: ["myapex"],
  2183. min_sdk_version: "29",
  2184. }
  2185. `,
  2186. },
  2187. {
  2188. name: "Updatable apex with non-stable dep",
  2189. expectedError: "cannot depend on \"myjar\"",
  2190. bp: `
  2191. apex {
  2192. name: "myapex",
  2193. java_libs: ["myjar"],
  2194. key: "myapex.key",
  2195. updatable: true,
  2196. }
  2197. apex_key {
  2198. name: "myapex.key",
  2199. public_key: "testkey.avbpubkey",
  2200. private_key: "testkey.pem",
  2201. }
  2202. java_library {
  2203. name: "myjar",
  2204. srcs: ["foo/bar/MyClass.java"],
  2205. sdk_version: "test_current",
  2206. apex_available: ["myapex"],
  2207. }
  2208. `,
  2209. },
  2210. {
  2211. name: "Updatable apex with non-stable legacy core platform dep",
  2212. expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
  2213. bp: `
  2214. apex {
  2215. name: "myapex",
  2216. java_libs: ["myjar-uses-legacy"],
  2217. key: "myapex.key",
  2218. updatable: true,
  2219. }
  2220. apex_key {
  2221. name: "myapex.key",
  2222. public_key: "testkey.avbpubkey",
  2223. private_key: "testkey.pem",
  2224. }
  2225. java_library {
  2226. name: "myjar-uses-legacy",
  2227. srcs: ["foo/bar/MyClass.java"],
  2228. sdk_version: "core_platform",
  2229. apex_available: ["myapex"],
  2230. }
  2231. `,
  2232. preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
  2233. },
  2234. {
  2235. name: "Updatable apex with non-stable transitive dep",
  2236. // This is not actually detecting that the transitive dependency is unstable, rather it is
  2237. // detecting that the transitive dependency is building against a wider API surface than the
  2238. // module that depends on it is using.
  2239. expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
  2240. bp: `
  2241. apex {
  2242. name: "myapex",
  2243. java_libs: ["myjar"],
  2244. key: "myapex.key",
  2245. updatable: true,
  2246. }
  2247. apex_key {
  2248. name: "myapex.key",
  2249. public_key: "testkey.avbpubkey",
  2250. private_key: "testkey.pem",
  2251. }
  2252. java_library {
  2253. name: "myjar",
  2254. srcs: ["foo/bar/MyClass.java"],
  2255. sdk_version: "current",
  2256. apex_available: ["myapex"],
  2257. static_libs: ["transitive-jar"],
  2258. }
  2259. java_library {
  2260. name: "transitive-jar",
  2261. srcs: ["foo/bar/MyClass.java"],
  2262. sdk_version: "core_platform",
  2263. apex_available: ["myapex"],
  2264. }
  2265. `,
  2266. },
  2267. }
  2268. for _, test := range testCases {
  2269. if test.name != "Updatable apex with non-stable legacy core platform dep" {
  2270. continue
  2271. }
  2272. t.Run(test.name, func(t *testing.T) {
  2273. errorHandler := android.FixtureExpectsNoErrors
  2274. if test.expectedError != "" {
  2275. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  2276. }
  2277. android.GroupFixturePreparers(
  2278. java.PrepareForTestWithJavaDefaultModules,
  2279. PrepareForTestWithApexBuildComponents,
  2280. prepareForTestWithMyapex,
  2281. android.OptionalFixturePreparer(test.preparer),
  2282. ).
  2283. ExtendWithErrorHandler(errorHandler).
  2284. RunTestWithBp(t, test.bp)
  2285. })
  2286. }
  2287. }
  2288. func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
  2289. testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
  2290. apex {
  2291. name: "myapex",
  2292. key: "myapex.key",
  2293. native_shared_libs: ["mylib"],
  2294. min_sdk_version: "29",
  2295. }
  2296. apex_key {
  2297. name: "myapex.key",
  2298. public_key: "testkey.avbpubkey",
  2299. private_key: "testkey.pem",
  2300. }
  2301. cc_library {
  2302. name: "mylib",
  2303. srcs: ["mylib.cpp"],
  2304. shared_libs: ["mylib2"],
  2305. system_shared_libs: [],
  2306. stl: "none",
  2307. apex_available: [
  2308. "myapex",
  2309. ],
  2310. min_sdk_version: "29",
  2311. }
  2312. // indirect part of the apex
  2313. cc_library {
  2314. name: "mylib2",
  2315. srcs: ["mylib.cpp"],
  2316. system_shared_libs: [],
  2317. stl: "none",
  2318. apex_available: [
  2319. "myapex",
  2320. ],
  2321. min_sdk_version: "30",
  2322. }
  2323. `)
  2324. }
  2325. func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
  2326. testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
  2327. apex {
  2328. name: "myapex",
  2329. key: "myapex.key",
  2330. apps: ["AppFoo"],
  2331. min_sdk_version: "29",
  2332. updatable: false,
  2333. }
  2334. apex_key {
  2335. name: "myapex.key",
  2336. public_key: "testkey.avbpubkey",
  2337. private_key: "testkey.pem",
  2338. }
  2339. android_app {
  2340. name: "AppFoo",
  2341. srcs: ["foo/bar/MyClass.java"],
  2342. sdk_version: "current",
  2343. min_sdk_version: "29",
  2344. system_modules: "none",
  2345. stl: "none",
  2346. static_libs: ["bar"],
  2347. apex_available: [ "myapex" ],
  2348. }
  2349. java_library {
  2350. name: "bar",
  2351. sdk_version: "current",
  2352. srcs: ["a.java"],
  2353. apex_available: [ "myapex" ],
  2354. }
  2355. `)
  2356. }
  2357. func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
  2358. ctx := testApex(t, `
  2359. apex {
  2360. name: "myapex",
  2361. key: "myapex.key",
  2362. native_shared_libs: ["mylib"],
  2363. min_sdk_version: "29",
  2364. }
  2365. apex_key {
  2366. name: "myapex.key",
  2367. public_key: "testkey.avbpubkey",
  2368. private_key: "testkey.pem",
  2369. }
  2370. // mylib in myapex will link to mylib2#current
  2371. // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
  2372. cc_library {
  2373. name: "mylib",
  2374. srcs: ["mylib.cpp"],
  2375. shared_libs: ["mylib2"],
  2376. system_shared_libs: [],
  2377. stl: "none",
  2378. apex_available: ["myapex", "otherapex"],
  2379. min_sdk_version: "29",
  2380. }
  2381. cc_library {
  2382. name: "mylib2",
  2383. srcs: ["mylib.cpp"],
  2384. system_shared_libs: [],
  2385. stl: "none",
  2386. apex_available: ["otherapex"],
  2387. stubs: { versions: ["29", "30"] },
  2388. min_sdk_version: "30",
  2389. }
  2390. apex {
  2391. name: "otherapex",
  2392. key: "myapex.key",
  2393. native_shared_libs: ["mylib", "mylib2"],
  2394. min_sdk_version: "30",
  2395. }
  2396. `)
  2397. expectLink := func(from, from_variant, to, to_variant string) {
  2398. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  2399. libFlags := ld.Args["libFlags"]
  2400. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  2401. }
  2402. expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
  2403. expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
  2404. }
  2405. func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
  2406. withSAsActiveCodeNames := android.FixtureModifyProductVariables(
  2407. func(variables android.FixtureProductVariables) {
  2408. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2409. variables.Platform_version_active_codenames = []string{"S"}
  2410. },
  2411. )
  2412. testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
  2413. apex {
  2414. name: "myapex",
  2415. key: "myapex.key",
  2416. native_shared_libs: ["libfoo"],
  2417. min_sdk_version: "S",
  2418. }
  2419. apex_key {
  2420. name: "myapex.key",
  2421. public_key: "testkey.avbpubkey",
  2422. private_key: "testkey.pem",
  2423. }
  2424. cc_library {
  2425. name: "libfoo",
  2426. shared_libs: ["libbar"],
  2427. apex_available: ["myapex"],
  2428. min_sdk_version: "29",
  2429. }
  2430. cc_library {
  2431. name: "libbar",
  2432. apex_available: ["myapex"],
  2433. }
  2434. `, withSAsActiveCodeNames)
  2435. }
  2436. func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
  2437. withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2438. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2439. variables.Platform_version_active_codenames = []string{"S", "T"}
  2440. })
  2441. ctx := testApex(t, `
  2442. apex {
  2443. name: "myapex",
  2444. key: "myapex.key",
  2445. native_shared_libs: ["libfoo"],
  2446. min_sdk_version: "S",
  2447. }
  2448. apex_key {
  2449. name: "myapex.key",
  2450. public_key: "testkey.avbpubkey",
  2451. private_key: "testkey.pem",
  2452. }
  2453. cc_library {
  2454. name: "libfoo",
  2455. shared_libs: ["libbar"],
  2456. apex_available: ["myapex"],
  2457. min_sdk_version: "S",
  2458. }
  2459. cc_library {
  2460. name: "libbar",
  2461. stubs: {
  2462. symbol_file: "libbar.map.txt",
  2463. versions: ["30", "S", "T"],
  2464. },
  2465. }
  2466. `, withSAsActiveCodeNames)
  2467. // ensure libfoo is linked with current version of libbar stub
  2468. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
  2469. libFlags := libfoo.Rule("ld").Args["libFlags"]
  2470. ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
  2471. }
  2472. func TestFilesInSubDir(t *testing.T) {
  2473. ctx := testApex(t, `
  2474. apex {
  2475. name: "myapex",
  2476. key: "myapex.key",
  2477. native_shared_libs: ["mylib"],
  2478. binaries: ["mybin"],
  2479. prebuilts: ["myetc"],
  2480. compile_multilib: "both",
  2481. updatable: false,
  2482. }
  2483. apex_key {
  2484. name: "myapex.key",
  2485. public_key: "testkey.avbpubkey",
  2486. private_key: "testkey.pem",
  2487. }
  2488. prebuilt_etc {
  2489. name: "myetc",
  2490. src: "myprebuilt",
  2491. sub_dir: "foo/bar",
  2492. }
  2493. cc_library {
  2494. name: "mylib",
  2495. srcs: ["mylib.cpp"],
  2496. relative_install_path: "foo/bar",
  2497. system_shared_libs: [],
  2498. stl: "none",
  2499. apex_available: [ "myapex" ],
  2500. }
  2501. cc_binary {
  2502. name: "mybin",
  2503. srcs: ["mylib.cpp"],
  2504. relative_install_path: "foo/bar",
  2505. system_shared_libs: [],
  2506. stl: "none",
  2507. apex_available: [ "myapex" ],
  2508. }
  2509. `)
  2510. generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
  2511. cmd := generateFsRule.RuleParams.Command
  2512. // Ensure that the subdirectories are all listed
  2513. ensureContains(t, cmd, "/etc ")
  2514. ensureContains(t, cmd, "/etc/foo ")
  2515. ensureContains(t, cmd, "/etc/foo/bar ")
  2516. ensureContains(t, cmd, "/lib64 ")
  2517. ensureContains(t, cmd, "/lib64/foo ")
  2518. ensureContains(t, cmd, "/lib64/foo/bar ")
  2519. ensureContains(t, cmd, "/lib ")
  2520. ensureContains(t, cmd, "/lib/foo ")
  2521. ensureContains(t, cmd, "/lib/foo/bar ")
  2522. ensureContains(t, cmd, "/bin ")
  2523. ensureContains(t, cmd, "/bin/foo ")
  2524. ensureContains(t, cmd, "/bin/foo/bar ")
  2525. }
  2526. func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
  2527. ctx := testApex(t, `
  2528. apex {
  2529. name: "myapex",
  2530. key: "myapex.key",
  2531. multilib: {
  2532. both: {
  2533. native_shared_libs: ["mylib"],
  2534. binaries: ["mybin"],
  2535. },
  2536. },
  2537. compile_multilib: "both",
  2538. native_bridge_supported: true,
  2539. updatable: false,
  2540. }
  2541. apex_key {
  2542. name: "myapex.key",
  2543. public_key: "testkey.avbpubkey",
  2544. private_key: "testkey.pem",
  2545. }
  2546. cc_library {
  2547. name: "mylib",
  2548. relative_install_path: "foo/bar",
  2549. system_shared_libs: [],
  2550. stl: "none",
  2551. apex_available: [ "myapex" ],
  2552. native_bridge_supported: true,
  2553. }
  2554. cc_binary {
  2555. name: "mybin",
  2556. relative_install_path: "foo/bar",
  2557. system_shared_libs: [],
  2558. stl: "none",
  2559. apex_available: [ "myapex" ],
  2560. native_bridge_supported: true,
  2561. compile_multilib: "both", // default is "first" for binary
  2562. multilib: {
  2563. lib64: {
  2564. suffix: "64",
  2565. },
  2566. },
  2567. }
  2568. `, withNativeBridgeEnabled)
  2569. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2570. "bin/foo/bar/mybin",
  2571. "bin/foo/bar/mybin64",
  2572. "bin/arm/foo/bar/mybin",
  2573. "bin/arm64/foo/bar/mybin64",
  2574. "lib/foo/bar/mylib.so",
  2575. "lib/arm/foo/bar/mylib.so",
  2576. "lib64/foo/bar/mylib.so",
  2577. "lib64/arm64/foo/bar/mylib.so",
  2578. })
  2579. }
  2580. func TestVendorApex(t *testing.T) {
  2581. result := android.GroupFixturePreparers(
  2582. prepareForApexTest,
  2583. android.FixtureModifyConfig(android.SetKatiEnabledForTests),
  2584. ).RunTestWithBp(t, `
  2585. apex {
  2586. name: "myapex",
  2587. key: "myapex.key",
  2588. binaries: ["mybin"],
  2589. vendor: true,
  2590. updatable: false,
  2591. }
  2592. apex_key {
  2593. name: "myapex.key",
  2594. public_key: "testkey.avbpubkey",
  2595. private_key: "testkey.pem",
  2596. }
  2597. cc_binary {
  2598. name: "mybin",
  2599. vendor: true,
  2600. shared_libs: ["libfoo"],
  2601. }
  2602. cc_library {
  2603. name: "libfoo",
  2604. proprietary: true,
  2605. }
  2606. `)
  2607. ensureExactContents(t, result.TestContext, "myapex", "android_common_myapex_image", []string{
  2608. "bin/mybin",
  2609. "lib64/libfoo.so",
  2610. // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
  2611. "lib64/libc++.so",
  2612. })
  2613. apexBundle := result.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2614. data := android.AndroidMkDataForTest(t, result.TestContext, apexBundle)
  2615. name := apexBundle.BaseModuleName()
  2616. prefix := "TARGET_"
  2617. var builder strings.Builder
  2618. data.Custom(&builder, name, prefix, "", data)
  2619. androidMk := android.StringRelativeToTop(result.Config, builder.String())
  2620. installPath := "out/target/product/test_device/vendor/apex"
  2621. ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
  2622. apexManifestRule := result.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2623. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2624. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2625. }
  2626. func TestVendorApex_use_vndk_as_stable_TryingToIncludeVNDKLib(t *testing.T) {
  2627. testApexError(t, `Trying to include a VNDK library`, `
  2628. apex {
  2629. name: "myapex",
  2630. key: "myapex.key",
  2631. native_shared_libs: ["libc++"], // libc++ is a VNDK lib
  2632. vendor: true,
  2633. use_vndk_as_stable: true,
  2634. updatable: false,
  2635. }
  2636. apex_key {
  2637. name: "myapex.key",
  2638. public_key: "testkey.avbpubkey",
  2639. private_key: "testkey.pem",
  2640. }`)
  2641. }
  2642. func TestVendorApex_use_vndk_as_stable(t *testing.T) {
  2643. // myapex myapex2
  2644. // | |
  2645. // mybin ------. mybin2
  2646. // \ \ / |
  2647. // (stable) .---\--------` |
  2648. // \ / \ |
  2649. // \ / \ /
  2650. // libvndk libvendor
  2651. // (vndk)
  2652. ctx := testApex(t, `
  2653. apex {
  2654. name: "myapex",
  2655. key: "myapex.key",
  2656. binaries: ["mybin"],
  2657. vendor: true,
  2658. use_vndk_as_stable: true,
  2659. updatable: false,
  2660. }
  2661. apex_key {
  2662. name: "myapex.key",
  2663. public_key: "testkey.avbpubkey",
  2664. private_key: "testkey.pem",
  2665. }
  2666. cc_binary {
  2667. name: "mybin",
  2668. vendor: true,
  2669. shared_libs: ["libvndk", "libvendor"],
  2670. }
  2671. cc_library {
  2672. name: "libvndk",
  2673. vndk: {
  2674. enabled: true,
  2675. },
  2676. vendor_available: true,
  2677. product_available: true,
  2678. }
  2679. cc_library {
  2680. name: "libvendor",
  2681. vendor: true,
  2682. stl: "none",
  2683. }
  2684. apex {
  2685. name: "myapex2",
  2686. key: "myapex.key",
  2687. binaries: ["mybin2"],
  2688. vendor: true,
  2689. use_vndk_as_stable: false,
  2690. updatable: false,
  2691. }
  2692. cc_binary {
  2693. name: "mybin2",
  2694. vendor: true,
  2695. shared_libs: ["libvndk", "libvendor"],
  2696. }
  2697. `)
  2698. vendorVariant := "android_vendor.29_arm64_armv8-a"
  2699. for _, tc := range []struct {
  2700. name string
  2701. apexName string
  2702. moduleName string
  2703. moduleVariant string
  2704. libs []string
  2705. contents []string
  2706. requireVndkNamespace bool
  2707. }{
  2708. {
  2709. name: "use_vndk_as_stable",
  2710. apexName: "myapex",
  2711. moduleName: "mybin",
  2712. moduleVariant: vendorVariant + "_apex10000",
  2713. libs: []string{
  2714. // should link with vendor variants of VNDK libs(libvndk/libc++)
  2715. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared/libvndk.so",
  2716. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared/libc++.so",
  2717. // unstable Vendor libs as APEX variant
  2718. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2719. },
  2720. contents: []string{
  2721. "bin/mybin",
  2722. "lib64/libvendor.so",
  2723. // VNDK libs (libvndk/libc++) are not included
  2724. },
  2725. requireVndkNamespace: true,
  2726. },
  2727. {
  2728. name: "!use_vndk_as_stable",
  2729. apexName: "myapex2",
  2730. moduleName: "mybin2",
  2731. moduleVariant: vendorVariant + "_myapex2",
  2732. libs: []string{
  2733. // should link with "unique" APEX(myapex2) variant of VNDK libs(libvndk/libc++)
  2734. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared_myapex2/libvndk.so",
  2735. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared_myapex2/libc++.so",
  2736. // unstable vendor libs have "merged" APEX variants
  2737. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2738. },
  2739. contents: []string{
  2740. "bin/mybin2",
  2741. "lib64/libvendor.so",
  2742. // VNDK libs are included as well
  2743. "lib64/libvndk.so",
  2744. "lib64/libc++.so",
  2745. },
  2746. requireVndkNamespace: false,
  2747. },
  2748. } {
  2749. t.Run(tc.name, func(t *testing.T) {
  2750. // Check linked libs
  2751. ldRule := ctx.ModuleForTests(tc.moduleName, tc.moduleVariant).Rule("ld")
  2752. libs := names(ldRule.Args["libFlags"])
  2753. for _, lib := range tc.libs {
  2754. ensureListContains(t, libs, lib)
  2755. }
  2756. // Check apex contents
  2757. ensureExactContents(t, ctx, tc.apexName, "android_common_"+tc.apexName+"_image", tc.contents)
  2758. // Check "requireNativeLibs"
  2759. apexManifestRule := ctx.ModuleForTests(tc.apexName, "android_common_"+tc.apexName+"_image").Rule("apexManifestRule")
  2760. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2761. if tc.requireVndkNamespace {
  2762. ensureListContains(t, requireNativeLibs, ":vndk")
  2763. } else {
  2764. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2765. }
  2766. })
  2767. }
  2768. }
  2769. func TestProductVariant(t *testing.T) {
  2770. ctx := testApex(t, `
  2771. apex {
  2772. name: "myapex",
  2773. key: "myapex.key",
  2774. updatable: false,
  2775. product_specific: true,
  2776. binaries: ["foo"],
  2777. }
  2778. apex_key {
  2779. name: "myapex.key",
  2780. public_key: "testkey.avbpubkey",
  2781. private_key: "testkey.pem",
  2782. }
  2783. cc_binary {
  2784. name: "foo",
  2785. product_available: true,
  2786. apex_available: ["myapex"],
  2787. srcs: ["foo.cpp"],
  2788. }
  2789. `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2790. variables.ProductVndkVersion = proptools.StringPtr("current")
  2791. }),
  2792. )
  2793. cflags := strings.Fields(
  2794. ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_myapex").Rule("cc").Args["cFlags"])
  2795. ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
  2796. ensureListContains(t, cflags, "-D__ANDROID_APEX__")
  2797. ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
  2798. ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
  2799. }
  2800. func TestApex_withPrebuiltFirmware(t *testing.T) {
  2801. testCases := []struct {
  2802. name string
  2803. additionalProp string
  2804. }{
  2805. {"system apex with prebuilt_firmware", ""},
  2806. {"vendor apex with prebuilt_firmware", "vendor: true,"},
  2807. }
  2808. for _, tc := range testCases {
  2809. t.Run(tc.name, func(t *testing.T) {
  2810. ctx := testApex(t, `
  2811. apex {
  2812. name: "myapex",
  2813. key: "myapex.key",
  2814. prebuilts: ["myfirmware"],
  2815. updatable: false,
  2816. `+tc.additionalProp+`
  2817. }
  2818. apex_key {
  2819. name: "myapex.key",
  2820. public_key: "testkey.avbpubkey",
  2821. private_key: "testkey.pem",
  2822. }
  2823. prebuilt_firmware {
  2824. name: "myfirmware",
  2825. src: "myfirmware.bin",
  2826. filename_from_src: true,
  2827. `+tc.additionalProp+`
  2828. }
  2829. `)
  2830. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2831. "etc/firmware/myfirmware.bin",
  2832. })
  2833. })
  2834. }
  2835. }
  2836. func TestAndroidMk_VendorApexRequired(t *testing.T) {
  2837. ctx := testApex(t, `
  2838. apex {
  2839. name: "myapex",
  2840. key: "myapex.key",
  2841. vendor: true,
  2842. native_shared_libs: ["mylib"],
  2843. updatable: false,
  2844. }
  2845. apex_key {
  2846. name: "myapex.key",
  2847. public_key: "testkey.avbpubkey",
  2848. private_key: "testkey.pem",
  2849. }
  2850. cc_library {
  2851. name: "mylib",
  2852. vendor_available: true,
  2853. }
  2854. `)
  2855. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2856. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2857. name := apexBundle.BaseModuleName()
  2858. prefix := "TARGET_"
  2859. var builder strings.Builder
  2860. data.Custom(&builder, name, prefix, "", data)
  2861. androidMk := builder.String()
  2862. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++.vendor.myapex:64 mylib.vendor.myapex:64 libc.vendor libm.vendor libdl.vendor\n")
  2863. }
  2864. func TestAndroidMkWritesCommonProperties(t *testing.T) {
  2865. ctx := testApex(t, `
  2866. apex {
  2867. name: "myapex",
  2868. key: "myapex.key",
  2869. vintf_fragments: ["fragment.xml"],
  2870. init_rc: ["init.rc"],
  2871. updatable: false,
  2872. }
  2873. apex_key {
  2874. name: "myapex.key",
  2875. public_key: "testkey.avbpubkey",
  2876. private_key: "testkey.pem",
  2877. }
  2878. cc_binary {
  2879. name: "mybin",
  2880. }
  2881. `)
  2882. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2883. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2884. name := apexBundle.BaseModuleName()
  2885. prefix := "TARGET_"
  2886. var builder strings.Builder
  2887. data.Custom(&builder, name, prefix, "", data)
  2888. androidMk := builder.String()
  2889. ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
  2890. ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
  2891. }
  2892. func TestStaticLinking(t *testing.T) {
  2893. ctx := testApex(t, `
  2894. apex {
  2895. name: "myapex",
  2896. key: "myapex.key",
  2897. native_shared_libs: ["mylib"],
  2898. updatable: false,
  2899. }
  2900. apex_key {
  2901. name: "myapex.key",
  2902. public_key: "testkey.avbpubkey",
  2903. private_key: "testkey.pem",
  2904. }
  2905. cc_library {
  2906. name: "mylib",
  2907. srcs: ["mylib.cpp"],
  2908. system_shared_libs: [],
  2909. stl: "none",
  2910. stubs: {
  2911. versions: ["1", "2", "3"],
  2912. },
  2913. apex_available: ["myapex"],
  2914. }
  2915. cc_binary {
  2916. name: "not_in_apex",
  2917. srcs: ["mylib.cpp"],
  2918. static_libs: ["mylib"],
  2919. static_executable: true,
  2920. system_shared_libs: [],
  2921. stl: "none",
  2922. }
  2923. `)
  2924. ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  2925. // Ensure that not_in_apex is linking with the static variant of mylib
  2926. ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
  2927. }
  2928. func TestKeys(t *testing.T) {
  2929. ctx := testApex(t, `
  2930. apex {
  2931. name: "myapex_keytest",
  2932. key: "myapex.key",
  2933. certificate: ":myapex.certificate",
  2934. native_shared_libs: ["mylib"],
  2935. file_contexts: ":myapex-file_contexts",
  2936. updatable: false,
  2937. }
  2938. cc_library {
  2939. name: "mylib",
  2940. srcs: ["mylib.cpp"],
  2941. system_shared_libs: [],
  2942. stl: "none",
  2943. apex_available: [ "myapex_keytest" ],
  2944. }
  2945. apex_key {
  2946. name: "myapex.key",
  2947. public_key: "testkey.avbpubkey",
  2948. private_key: "testkey.pem",
  2949. }
  2950. android_app_certificate {
  2951. name: "myapex.certificate",
  2952. certificate: "testkey",
  2953. }
  2954. android_app_certificate {
  2955. name: "myapex.certificate.override",
  2956. certificate: "testkey.override",
  2957. }
  2958. `)
  2959. // check the APEX keys
  2960. keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  2961. if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
  2962. t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
  2963. "vendor/foo/devkeys/testkey.avbpubkey")
  2964. }
  2965. if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
  2966. t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
  2967. "vendor/foo/devkeys/testkey.pem")
  2968. }
  2969. // check the APK certs. It should be overridden to myapex.certificate.override
  2970. certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
  2971. if certs != "testkey.override.x509.pem testkey.override.pk8" {
  2972. t.Errorf("cert and private key %q are not %q", certs,
  2973. "testkey.override.509.pem testkey.override.pk8")
  2974. }
  2975. }
  2976. func TestCertificate(t *testing.T) {
  2977. t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
  2978. ctx := testApex(t, `
  2979. apex {
  2980. name: "myapex",
  2981. key: "myapex.key",
  2982. updatable: false,
  2983. }
  2984. apex_key {
  2985. name: "myapex.key",
  2986. public_key: "testkey.avbpubkey",
  2987. private_key: "testkey.pem",
  2988. }`)
  2989. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2990. expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
  2991. if actual := rule.Args["certificates"]; actual != expected {
  2992. t.Errorf("certificates should be %q, not %q", expected, actual)
  2993. }
  2994. })
  2995. t.Run("override when unspecified", func(t *testing.T) {
  2996. ctx := testApex(t, `
  2997. apex {
  2998. name: "myapex_keytest",
  2999. key: "myapex.key",
  3000. file_contexts: ":myapex-file_contexts",
  3001. updatable: false,
  3002. }
  3003. apex_key {
  3004. name: "myapex.key",
  3005. public_key: "testkey.avbpubkey",
  3006. private_key: "testkey.pem",
  3007. }
  3008. android_app_certificate {
  3009. name: "myapex.certificate.override",
  3010. certificate: "testkey.override",
  3011. }`)
  3012. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  3013. expected := "testkey.override.x509.pem testkey.override.pk8"
  3014. if actual := rule.Args["certificates"]; actual != expected {
  3015. t.Errorf("certificates should be %q, not %q", expected, actual)
  3016. }
  3017. })
  3018. t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
  3019. ctx := testApex(t, `
  3020. apex {
  3021. name: "myapex",
  3022. key: "myapex.key",
  3023. certificate: ":myapex.certificate",
  3024. updatable: false,
  3025. }
  3026. apex_key {
  3027. name: "myapex.key",
  3028. public_key: "testkey.avbpubkey",
  3029. private_key: "testkey.pem",
  3030. }
  3031. android_app_certificate {
  3032. name: "myapex.certificate",
  3033. certificate: "testkey",
  3034. }`)
  3035. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  3036. expected := "testkey.x509.pem testkey.pk8"
  3037. if actual := rule.Args["certificates"]; actual != expected {
  3038. t.Errorf("certificates should be %q, not %q", expected, actual)
  3039. }
  3040. })
  3041. t.Run("override when specifiec as <:module>", func(t *testing.T) {
  3042. ctx := testApex(t, `
  3043. apex {
  3044. name: "myapex_keytest",
  3045. key: "myapex.key",
  3046. file_contexts: ":myapex-file_contexts",
  3047. certificate: ":myapex.certificate",
  3048. updatable: false,
  3049. }
  3050. apex_key {
  3051. name: "myapex.key",
  3052. public_key: "testkey.avbpubkey",
  3053. private_key: "testkey.pem",
  3054. }
  3055. android_app_certificate {
  3056. name: "myapex.certificate.override",
  3057. certificate: "testkey.override",
  3058. }`)
  3059. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  3060. expected := "testkey.override.x509.pem testkey.override.pk8"
  3061. if actual := rule.Args["certificates"]; actual != expected {
  3062. t.Errorf("certificates should be %q, not %q", expected, actual)
  3063. }
  3064. })
  3065. t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
  3066. ctx := testApex(t, `
  3067. apex {
  3068. name: "myapex",
  3069. key: "myapex.key",
  3070. certificate: "testkey",
  3071. updatable: false,
  3072. }
  3073. apex_key {
  3074. name: "myapex.key",
  3075. public_key: "testkey.avbpubkey",
  3076. private_key: "testkey.pem",
  3077. }`)
  3078. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  3079. expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
  3080. if actual := rule.Args["certificates"]; actual != expected {
  3081. t.Errorf("certificates should be %q, not %q", expected, actual)
  3082. }
  3083. })
  3084. t.Run("override when specified as <name>", func(t *testing.T) {
  3085. ctx := testApex(t, `
  3086. apex {
  3087. name: "myapex_keytest",
  3088. key: "myapex.key",
  3089. file_contexts: ":myapex-file_contexts",
  3090. certificate: "testkey",
  3091. updatable: false,
  3092. }
  3093. apex_key {
  3094. name: "myapex.key",
  3095. public_key: "testkey.avbpubkey",
  3096. private_key: "testkey.pem",
  3097. }
  3098. android_app_certificate {
  3099. name: "myapex.certificate.override",
  3100. certificate: "testkey.override",
  3101. }`)
  3102. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  3103. expected := "testkey.override.x509.pem testkey.override.pk8"
  3104. if actual := rule.Args["certificates"]; actual != expected {
  3105. t.Errorf("certificates should be %q, not %q", expected, actual)
  3106. }
  3107. })
  3108. }
  3109. func TestMacro(t *testing.T) {
  3110. ctx := testApex(t, `
  3111. apex {
  3112. name: "myapex",
  3113. key: "myapex.key",
  3114. native_shared_libs: ["mylib", "mylib2"],
  3115. updatable: false,
  3116. }
  3117. apex {
  3118. name: "otherapex",
  3119. key: "myapex.key",
  3120. native_shared_libs: ["mylib", "mylib2"],
  3121. min_sdk_version: "29",
  3122. }
  3123. apex_key {
  3124. name: "myapex.key",
  3125. public_key: "testkey.avbpubkey",
  3126. private_key: "testkey.pem",
  3127. }
  3128. cc_library {
  3129. name: "mylib",
  3130. srcs: ["mylib.cpp"],
  3131. system_shared_libs: [],
  3132. stl: "none",
  3133. apex_available: [
  3134. "myapex",
  3135. "otherapex",
  3136. ],
  3137. recovery_available: true,
  3138. min_sdk_version: "29",
  3139. }
  3140. cc_library {
  3141. name: "mylib2",
  3142. srcs: ["mylib.cpp"],
  3143. system_shared_libs: [],
  3144. stl: "none",
  3145. apex_available: [
  3146. "myapex",
  3147. "otherapex",
  3148. ],
  3149. static_libs: ["mylib3"],
  3150. recovery_available: true,
  3151. min_sdk_version: "29",
  3152. }
  3153. cc_library {
  3154. name: "mylib3",
  3155. srcs: ["mylib.cpp"],
  3156. system_shared_libs: [],
  3157. stl: "none",
  3158. apex_available: [
  3159. "myapex",
  3160. "otherapex",
  3161. ],
  3162. recovery_available: true,
  3163. min_sdk_version: "29",
  3164. }
  3165. `)
  3166. // non-APEX variant does not have __ANDROID_APEX__ defined
  3167. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3168. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3169. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX__ defined
  3170. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  3171. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3172. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX__ defined
  3173. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
  3174. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3175. // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
  3176. // each variant defines additional macros to distinguish which apex variant it is built for
  3177. // non-APEX variant does not have __ANDROID_APEX__ defined
  3178. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3179. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3180. // recovery variant does not set __ANDROID_APEX__
  3181. mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3182. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3183. // non-APEX variant does not have __ANDROID_APEX__ defined
  3184. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3185. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3186. // recovery variant does not set __ANDROID_APEX__
  3187. mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3188. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3189. }
  3190. func TestHeaderLibsDependency(t *testing.T) {
  3191. ctx := testApex(t, `
  3192. apex {
  3193. name: "myapex",
  3194. key: "myapex.key",
  3195. native_shared_libs: ["mylib"],
  3196. updatable: false,
  3197. }
  3198. apex_key {
  3199. name: "myapex.key",
  3200. public_key: "testkey.avbpubkey",
  3201. private_key: "testkey.pem",
  3202. }
  3203. cc_library_headers {
  3204. name: "mylib_headers",
  3205. export_include_dirs: ["my_include"],
  3206. system_shared_libs: [],
  3207. stl: "none",
  3208. apex_available: [ "myapex" ],
  3209. }
  3210. cc_library {
  3211. name: "mylib",
  3212. srcs: ["mylib.cpp"],
  3213. system_shared_libs: [],
  3214. stl: "none",
  3215. header_libs: ["mylib_headers"],
  3216. export_header_lib_headers: ["mylib_headers"],
  3217. stubs: {
  3218. versions: ["1", "2", "3"],
  3219. },
  3220. apex_available: [ "myapex" ],
  3221. }
  3222. cc_library {
  3223. name: "otherlib",
  3224. srcs: ["mylib.cpp"],
  3225. system_shared_libs: [],
  3226. stl: "none",
  3227. shared_libs: ["mylib"],
  3228. }
  3229. `)
  3230. cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3231. // Ensure that the include path of the header lib is exported to 'otherlib'
  3232. ensureContains(t, cFlags, "-Imy_include")
  3233. }
  3234. type fileInApex struct {
  3235. path string // path in apex
  3236. src string // src path
  3237. isLink bool
  3238. }
  3239. func (f fileInApex) String() string {
  3240. return f.src + ":" + f.path
  3241. }
  3242. func (f fileInApex) match(expectation string) bool {
  3243. parts := strings.Split(expectation, ":")
  3244. if len(parts) == 1 {
  3245. match, _ := path.Match(parts[0], f.path)
  3246. return match
  3247. }
  3248. if len(parts) == 2 {
  3249. matchSrc, _ := path.Match(parts[0], f.src)
  3250. matchDst, _ := path.Match(parts[1], f.path)
  3251. return matchSrc && matchDst
  3252. }
  3253. panic("invalid expected file specification: " + expectation)
  3254. }
  3255. func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
  3256. t.Helper()
  3257. module := ctx.ModuleForTests(moduleName, variant)
  3258. apexRule := module.MaybeRule("apexRule")
  3259. apexDir := "/image.apex/"
  3260. if apexRule.Rule == nil {
  3261. apexRule = module.Rule("zipApexRule")
  3262. apexDir = "/image.zipapex/"
  3263. }
  3264. copyCmds := apexRule.Args["copy_commands"]
  3265. var ret []fileInApex
  3266. for _, cmd := range strings.Split(copyCmds, "&&") {
  3267. cmd = strings.TrimSpace(cmd)
  3268. if cmd == "" {
  3269. continue
  3270. }
  3271. terms := strings.Split(cmd, " ")
  3272. var dst, src string
  3273. var isLink bool
  3274. switch terms[0] {
  3275. case "mkdir":
  3276. case "cp":
  3277. if len(terms) != 3 && len(terms) != 4 {
  3278. t.Fatal("copyCmds contains invalid cp command", cmd)
  3279. }
  3280. dst = terms[len(terms)-1]
  3281. src = terms[len(terms)-2]
  3282. isLink = false
  3283. case "ln":
  3284. if len(terms) != 3 && len(terms) != 4 {
  3285. // ln LINK TARGET or ln -s LINK TARGET
  3286. t.Fatal("copyCmds contains invalid ln command", cmd)
  3287. }
  3288. dst = terms[len(terms)-1]
  3289. src = terms[len(terms)-2]
  3290. isLink = true
  3291. default:
  3292. t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
  3293. }
  3294. if dst != "" {
  3295. index := strings.Index(dst, apexDir)
  3296. if index == -1 {
  3297. t.Fatal("copyCmds should copy a file to "+apexDir, cmd)
  3298. }
  3299. dstFile := dst[index+len(apexDir):]
  3300. ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
  3301. }
  3302. }
  3303. return ret
  3304. }
  3305. func assertFileListEquals(t *testing.T, expectedFiles []string, actualFiles []fileInApex) {
  3306. t.Helper()
  3307. var failed bool
  3308. var surplus []string
  3309. filesMatched := make(map[string]bool)
  3310. for _, file := range actualFiles {
  3311. matchFound := false
  3312. for _, expected := range expectedFiles {
  3313. if file.match(expected) {
  3314. matchFound = true
  3315. filesMatched[expected] = true
  3316. break
  3317. }
  3318. }
  3319. if !matchFound {
  3320. surplus = append(surplus, file.String())
  3321. }
  3322. }
  3323. if len(surplus) > 0 {
  3324. sort.Strings(surplus)
  3325. t.Log("surplus files", surplus)
  3326. failed = true
  3327. }
  3328. if len(expectedFiles) > len(filesMatched) {
  3329. var missing []string
  3330. for _, expected := range expectedFiles {
  3331. if !filesMatched[expected] {
  3332. missing = append(missing, expected)
  3333. }
  3334. }
  3335. sort.Strings(missing)
  3336. t.Log("missing files", missing)
  3337. failed = true
  3338. }
  3339. if failed {
  3340. t.Fail()
  3341. }
  3342. }
  3343. func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
  3344. assertFileListEquals(t, files, getFiles(t, ctx, moduleName, variant))
  3345. }
  3346. func ensureExactDeapexedContents(t *testing.T, ctx *android.TestContext, moduleName string, variant string, files []string) {
  3347. deapexer := ctx.ModuleForTests(moduleName+".deapexer", variant).Rule("deapexer")
  3348. outputs := make([]string, 0, len(deapexer.ImplicitOutputs)+1)
  3349. if deapexer.Output != nil {
  3350. outputs = append(outputs, deapexer.Output.String())
  3351. }
  3352. for _, output := range deapexer.ImplicitOutputs {
  3353. outputs = append(outputs, output.String())
  3354. }
  3355. actualFiles := make([]fileInApex, 0, len(outputs))
  3356. for _, output := range outputs {
  3357. dir := "/deapexer/"
  3358. pos := strings.LastIndex(output, dir)
  3359. if pos == -1 {
  3360. t.Fatal("Unknown deapexer output ", output)
  3361. }
  3362. path := output[pos+len(dir):]
  3363. actualFiles = append(actualFiles, fileInApex{path: path, src: "", isLink: false})
  3364. }
  3365. assertFileListEquals(t, files, actualFiles)
  3366. }
  3367. func TestVndkApexCurrent(t *testing.T) {
  3368. commonFiles := []string{
  3369. "lib/libc++.so",
  3370. "lib64/libc++.so",
  3371. "etc/llndk.libraries.29.txt",
  3372. "etc/vndkcore.libraries.29.txt",
  3373. "etc/vndksp.libraries.29.txt",
  3374. "etc/vndkprivate.libraries.29.txt",
  3375. "etc/vndkproduct.libraries.29.txt",
  3376. }
  3377. testCases := []struct {
  3378. vndkVersion string
  3379. expectedFiles []string
  3380. }{
  3381. {
  3382. vndkVersion: "current",
  3383. expectedFiles: append(commonFiles,
  3384. "lib/libvndk.so",
  3385. "lib/libvndksp.so",
  3386. "lib64/libvndk.so",
  3387. "lib64/libvndksp.so"),
  3388. },
  3389. {
  3390. vndkVersion: "",
  3391. expectedFiles: append(commonFiles,
  3392. // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
  3393. "lib/libvndksp.so",
  3394. "lib64/libvndksp.so"),
  3395. },
  3396. }
  3397. for _, tc := range testCases {
  3398. t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
  3399. ctx := testApex(t, `
  3400. apex_vndk {
  3401. name: "com.android.vndk.current",
  3402. key: "com.android.vndk.current.key",
  3403. updatable: false,
  3404. }
  3405. apex_key {
  3406. name: "com.android.vndk.current.key",
  3407. public_key: "testkey.avbpubkey",
  3408. private_key: "testkey.pem",
  3409. }
  3410. cc_library {
  3411. name: "libvndk",
  3412. srcs: ["mylib.cpp"],
  3413. vendor_available: true,
  3414. product_available: true,
  3415. vndk: {
  3416. enabled: true,
  3417. },
  3418. system_shared_libs: [],
  3419. stl: "none",
  3420. apex_available: [ "com.android.vndk.current" ],
  3421. }
  3422. cc_library {
  3423. name: "libvndksp",
  3424. srcs: ["mylib.cpp"],
  3425. vendor_available: true,
  3426. product_available: true,
  3427. vndk: {
  3428. enabled: true,
  3429. support_system_process: true,
  3430. },
  3431. system_shared_libs: [],
  3432. stl: "none",
  3433. apex_available: [ "com.android.vndk.current" ],
  3434. }
  3435. // VNDK-Ext should not cause any problems
  3436. cc_library {
  3437. name: "libvndk.ext",
  3438. srcs: ["mylib2.cpp"],
  3439. vendor: true,
  3440. vndk: {
  3441. enabled: true,
  3442. extends: "libvndk",
  3443. },
  3444. system_shared_libs: [],
  3445. stl: "none",
  3446. }
  3447. cc_library {
  3448. name: "libvndksp.ext",
  3449. srcs: ["mylib2.cpp"],
  3450. vendor: true,
  3451. vndk: {
  3452. enabled: true,
  3453. support_system_process: true,
  3454. extends: "libvndksp",
  3455. },
  3456. system_shared_libs: [],
  3457. stl: "none",
  3458. }
  3459. `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3460. variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
  3461. }))
  3462. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
  3463. })
  3464. }
  3465. }
  3466. func TestVndkApexWithPrebuilt(t *testing.T) {
  3467. ctx := testApex(t, `
  3468. apex_vndk {
  3469. name: "com.android.vndk.current",
  3470. key: "com.android.vndk.current.key",
  3471. updatable: false,
  3472. }
  3473. apex_key {
  3474. name: "com.android.vndk.current.key",
  3475. public_key: "testkey.avbpubkey",
  3476. private_key: "testkey.pem",
  3477. }
  3478. cc_prebuilt_library_shared {
  3479. name: "libvndk",
  3480. srcs: ["libvndk.so"],
  3481. vendor_available: true,
  3482. product_available: true,
  3483. vndk: {
  3484. enabled: true,
  3485. },
  3486. system_shared_libs: [],
  3487. stl: "none",
  3488. apex_available: [ "com.android.vndk.current" ],
  3489. }
  3490. cc_prebuilt_library_shared {
  3491. name: "libvndk.arm",
  3492. srcs: ["libvndk.arm.so"],
  3493. vendor_available: true,
  3494. product_available: true,
  3495. vndk: {
  3496. enabled: true,
  3497. },
  3498. enabled: false,
  3499. arch: {
  3500. arm: {
  3501. enabled: true,
  3502. },
  3503. },
  3504. system_shared_libs: [],
  3505. stl: "none",
  3506. apex_available: [ "com.android.vndk.current" ],
  3507. }
  3508. `+vndkLibrariesTxtFiles("current"),
  3509. withFiles(map[string][]byte{
  3510. "libvndk.so": nil,
  3511. "libvndk.arm.so": nil,
  3512. }))
  3513. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3514. "lib/libvndk.so",
  3515. "lib/libvndk.arm.so",
  3516. "lib64/libvndk.so",
  3517. "lib/libc++.so",
  3518. "lib64/libc++.so",
  3519. "etc/*",
  3520. })
  3521. }
  3522. func vndkLibrariesTxtFiles(vers ...string) (result string) {
  3523. for _, v := range vers {
  3524. if v == "current" {
  3525. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3526. result += `
  3527. ` + txt + `_libraries_txt {
  3528. name: "` + txt + `.libraries.txt",
  3529. }
  3530. `
  3531. }
  3532. } else {
  3533. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3534. result += `
  3535. prebuilt_etc {
  3536. name: "` + txt + `.libraries.` + v + `.txt",
  3537. src: "dummy.txt",
  3538. }
  3539. `
  3540. }
  3541. }
  3542. }
  3543. return
  3544. }
  3545. func TestVndkApexVersion(t *testing.T) {
  3546. ctx := testApex(t, `
  3547. apex_vndk {
  3548. name: "com.android.vndk.v27",
  3549. key: "myapex.key",
  3550. file_contexts: ":myapex-file_contexts",
  3551. vndk_version: "27",
  3552. updatable: false,
  3553. }
  3554. apex_key {
  3555. name: "myapex.key",
  3556. public_key: "testkey.avbpubkey",
  3557. private_key: "testkey.pem",
  3558. }
  3559. vndk_prebuilt_shared {
  3560. name: "libvndk27",
  3561. version: "27",
  3562. vendor_available: true,
  3563. product_available: true,
  3564. vndk: {
  3565. enabled: true,
  3566. },
  3567. target_arch: "arm64",
  3568. arch: {
  3569. arm: {
  3570. srcs: ["libvndk27_arm.so"],
  3571. },
  3572. arm64: {
  3573. srcs: ["libvndk27_arm64.so"],
  3574. },
  3575. },
  3576. apex_available: [ "com.android.vndk.v27" ],
  3577. }
  3578. vndk_prebuilt_shared {
  3579. name: "libvndk27",
  3580. version: "27",
  3581. vendor_available: true,
  3582. product_available: true,
  3583. vndk: {
  3584. enabled: true,
  3585. },
  3586. target_arch: "x86_64",
  3587. arch: {
  3588. x86: {
  3589. srcs: ["libvndk27_x86.so"],
  3590. },
  3591. x86_64: {
  3592. srcs: ["libvndk27_x86_64.so"],
  3593. },
  3594. },
  3595. }
  3596. `+vndkLibrariesTxtFiles("27"),
  3597. withFiles(map[string][]byte{
  3598. "libvndk27_arm.so": nil,
  3599. "libvndk27_arm64.so": nil,
  3600. "libvndk27_x86.so": nil,
  3601. "libvndk27_x86_64.so": nil,
  3602. }))
  3603. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3604. "lib/libvndk27_arm.so",
  3605. "lib64/libvndk27_arm64.so",
  3606. "etc/*",
  3607. })
  3608. }
  3609. func TestVndkApexNameRule(t *testing.T) {
  3610. ctx := testApex(t, `
  3611. apex_vndk {
  3612. name: "com.android.vndk.current",
  3613. key: "myapex.key",
  3614. file_contexts: ":myapex-file_contexts",
  3615. updatable: false,
  3616. }
  3617. apex_vndk {
  3618. name: "com.android.vndk.v28",
  3619. key: "myapex.key",
  3620. file_contexts: ":myapex-file_contexts",
  3621. vndk_version: "28",
  3622. updatable: false,
  3623. }
  3624. apex_key {
  3625. name: "myapex.key",
  3626. public_key: "testkey.avbpubkey",
  3627. private_key: "testkey.pem",
  3628. }`+vndkLibrariesTxtFiles("28", "current"))
  3629. assertApexName := func(expected, moduleName string) {
  3630. module := ctx.ModuleForTests(moduleName, "android_common_image")
  3631. apexManifestRule := module.Rule("apexManifestRule")
  3632. ensureContains(t, apexManifestRule.Args["opt"], "-v name "+expected)
  3633. }
  3634. assertApexName("com.android.vndk.v29", "com.android.vndk.current")
  3635. assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
  3636. }
  3637. func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
  3638. ctx := testApex(t, `
  3639. apex_vndk {
  3640. name: "com.android.vndk.current",
  3641. key: "com.android.vndk.current.key",
  3642. file_contexts: ":myapex-file_contexts",
  3643. updatable: false,
  3644. }
  3645. apex_key {
  3646. name: "com.android.vndk.current.key",
  3647. public_key: "testkey.avbpubkey",
  3648. private_key: "testkey.pem",
  3649. }
  3650. cc_library {
  3651. name: "libvndk",
  3652. srcs: ["mylib.cpp"],
  3653. vendor_available: true,
  3654. product_available: true,
  3655. native_bridge_supported: true,
  3656. host_supported: true,
  3657. vndk: {
  3658. enabled: true,
  3659. },
  3660. system_shared_libs: [],
  3661. stl: "none",
  3662. apex_available: [ "com.android.vndk.current" ],
  3663. }
  3664. `+vndkLibrariesTxtFiles("current"),
  3665. withNativeBridgeEnabled)
  3666. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3667. "lib/libvndk.so",
  3668. "lib64/libvndk.so",
  3669. "lib/libc++.so",
  3670. "lib64/libc++.so",
  3671. "etc/*",
  3672. })
  3673. }
  3674. func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
  3675. testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
  3676. apex_vndk {
  3677. name: "com.android.vndk.current",
  3678. key: "com.android.vndk.current.key",
  3679. file_contexts: ":myapex-file_contexts",
  3680. native_bridge_supported: true,
  3681. }
  3682. apex_key {
  3683. name: "com.android.vndk.current.key",
  3684. public_key: "testkey.avbpubkey",
  3685. private_key: "testkey.pem",
  3686. }
  3687. cc_library {
  3688. name: "libvndk",
  3689. srcs: ["mylib.cpp"],
  3690. vendor_available: true,
  3691. product_available: true,
  3692. native_bridge_supported: true,
  3693. host_supported: true,
  3694. vndk: {
  3695. enabled: true,
  3696. },
  3697. system_shared_libs: [],
  3698. stl: "none",
  3699. }
  3700. `)
  3701. }
  3702. func TestVndkApexWithBinder32(t *testing.T) {
  3703. ctx := testApex(t, `
  3704. apex_vndk {
  3705. name: "com.android.vndk.v27",
  3706. key: "myapex.key",
  3707. file_contexts: ":myapex-file_contexts",
  3708. vndk_version: "27",
  3709. updatable: false,
  3710. }
  3711. apex_key {
  3712. name: "myapex.key",
  3713. public_key: "testkey.avbpubkey",
  3714. private_key: "testkey.pem",
  3715. }
  3716. vndk_prebuilt_shared {
  3717. name: "libvndk27",
  3718. version: "27",
  3719. target_arch: "arm",
  3720. vendor_available: true,
  3721. product_available: true,
  3722. vndk: {
  3723. enabled: true,
  3724. },
  3725. arch: {
  3726. arm: {
  3727. srcs: ["libvndk27.so"],
  3728. }
  3729. },
  3730. }
  3731. vndk_prebuilt_shared {
  3732. name: "libvndk27",
  3733. version: "27",
  3734. target_arch: "arm",
  3735. binder32bit: true,
  3736. vendor_available: true,
  3737. product_available: true,
  3738. vndk: {
  3739. enabled: true,
  3740. },
  3741. arch: {
  3742. arm: {
  3743. srcs: ["libvndk27binder32.so"],
  3744. }
  3745. },
  3746. apex_available: [ "com.android.vndk.v27" ],
  3747. }
  3748. `+vndkLibrariesTxtFiles("27"),
  3749. withFiles(map[string][]byte{
  3750. "libvndk27.so": nil,
  3751. "libvndk27binder32.so": nil,
  3752. }),
  3753. withBinder32bit,
  3754. withTargets(map[android.OsType][]android.Target{
  3755. android.Android: {
  3756. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  3757. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  3758. },
  3759. }),
  3760. )
  3761. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3762. "lib/libvndk27binder32.so",
  3763. "etc/*",
  3764. })
  3765. }
  3766. func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
  3767. ctx := testApex(t, `
  3768. apex_vndk {
  3769. name: "com.android.vndk.current",
  3770. key: "com.android.vndk.current.key",
  3771. file_contexts: ":myapex-file_contexts",
  3772. updatable: false,
  3773. }
  3774. apex_key {
  3775. name: "com.android.vndk.current.key",
  3776. public_key: "testkey.avbpubkey",
  3777. private_key: "testkey.pem",
  3778. }
  3779. cc_library {
  3780. name: "libz",
  3781. vendor_available: true,
  3782. product_available: true,
  3783. vndk: {
  3784. enabled: true,
  3785. },
  3786. stubs: {
  3787. symbol_file: "libz.map.txt",
  3788. versions: ["30"],
  3789. }
  3790. }
  3791. `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
  3792. "libz.map.txt": nil,
  3793. }))
  3794. apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
  3795. provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
  3796. ensureListEmpty(t, provideNativeLibs)
  3797. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3798. "out/soong/.intermediates/libz/android_vendor.29_arm64_armv8-a_shared/libz.so:lib64/libz.so",
  3799. "out/soong/.intermediates/libz/android_vendor.29_arm_armv7-a-neon_shared/libz.so:lib/libz.so",
  3800. "*/*",
  3801. })
  3802. }
  3803. func TestVendorApexWithVndkPrebuilts(t *testing.T) {
  3804. ctx := testApex(t, "",
  3805. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3806. variables.DeviceVndkVersion = proptools.StringPtr("27")
  3807. }),
  3808. android.FixtureRegisterWithContext(func(ctx android.RegistrationContext) {
  3809. cc.RegisterVendorSnapshotModules(ctx)
  3810. }),
  3811. withFiles(map[string][]byte{
  3812. "vendor/foo/Android.bp": []byte(`
  3813. apex {
  3814. name: "myapex",
  3815. binaries: ["foo"],
  3816. key: "myapex.key",
  3817. min_sdk_version: "27",
  3818. vendor: true,
  3819. }
  3820. cc_binary {
  3821. name: "foo",
  3822. vendor: true,
  3823. srcs: ["abc.cpp"],
  3824. shared_libs: [
  3825. "libllndk",
  3826. "libvndk",
  3827. ],
  3828. nocrt: true,
  3829. system_shared_libs: [],
  3830. min_sdk_version: "27",
  3831. }
  3832. apex_key {
  3833. name: "myapex.key",
  3834. public_key: "testkey.avbpubkey",
  3835. private_key: "testkey.pem",
  3836. }
  3837. `),
  3838. // Simulate VNDK prebuilts with vendor_snapshot
  3839. "prebuilts/vndk/Android.bp": []byte(`
  3840. vndk_prebuilt_shared {
  3841. name: "libllndk",
  3842. version: "27",
  3843. vendor_available: true,
  3844. product_available: true,
  3845. target_arch: "arm64",
  3846. arch: {
  3847. arm64: {
  3848. srcs: ["libllndk.so"],
  3849. },
  3850. },
  3851. }
  3852. vndk_prebuilt_shared {
  3853. name: "libvndk",
  3854. version: "27",
  3855. vendor_available: true,
  3856. product_available: true,
  3857. target_arch: "arm64",
  3858. arch: {
  3859. arm64: {
  3860. srcs: ["libvndk.so"],
  3861. },
  3862. },
  3863. vndk: {
  3864. enabled: true,
  3865. },
  3866. min_sdk_version: "27",
  3867. }
  3868. vndk_prebuilt_shared {
  3869. name: "libc++",
  3870. version: "27",
  3871. target_arch: "arm64",
  3872. vendor_available: true,
  3873. product_available: true,
  3874. vndk: {
  3875. enabled: true,
  3876. support_system_process: true,
  3877. },
  3878. arch: {
  3879. arm64: {
  3880. srcs: ["libc++.so"],
  3881. },
  3882. },
  3883. min_sdk_version: "apex_inherit",
  3884. }
  3885. vendor_snapshot {
  3886. name: "vendor_snapshot",
  3887. version: "27",
  3888. arch: {
  3889. arm64: {
  3890. vndk_libs: [
  3891. "libc++",
  3892. "libllndk",
  3893. "libvndk",
  3894. ],
  3895. static_libs: [
  3896. "libc++demangle",
  3897. "libclang_rt.builtins",
  3898. "libunwind",
  3899. ],
  3900. },
  3901. }
  3902. }
  3903. vendor_snapshot_static {
  3904. name: "libclang_rt.builtins",
  3905. version: "27",
  3906. target_arch: "arm64",
  3907. vendor: true,
  3908. arch: {
  3909. arm64: {
  3910. src: "libclang_rt.builtins-aarch64-android.a",
  3911. },
  3912. },
  3913. }
  3914. vendor_snapshot_static {
  3915. name: "libc++demangle",
  3916. version: "27",
  3917. target_arch: "arm64",
  3918. compile_multilib: "64",
  3919. vendor: true,
  3920. arch: {
  3921. arm64: {
  3922. src: "libc++demangle.a",
  3923. },
  3924. },
  3925. min_sdk_version: "apex_inherit",
  3926. }
  3927. vendor_snapshot_static {
  3928. name: "libunwind",
  3929. version: "27",
  3930. target_arch: "arm64",
  3931. compile_multilib: "64",
  3932. vendor: true,
  3933. arch: {
  3934. arm64: {
  3935. src: "libunwind.a",
  3936. },
  3937. },
  3938. min_sdk_version: "apex_inherit",
  3939. }
  3940. `),
  3941. }))
  3942. // Should embed the prebuilt VNDK libraries in the apex
  3943. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  3944. "bin/foo",
  3945. "prebuilts/vndk/libc++.so:lib64/libc++.so",
  3946. "prebuilts/vndk/libvndk.so:lib64/libvndk.so",
  3947. })
  3948. // Should link foo with prebuilt libraries (shared/static)
  3949. ldRule := ctx.ModuleForTests("foo", "android_vendor.27_arm64_armv8-a_myapex").Rule("ld")
  3950. android.AssertStringDoesContain(t, "should link to prebuilt llndk", ldRule.Args["libFlags"], "prebuilts/vndk/libllndk.so")
  3951. android.AssertStringDoesContain(t, "should link to prebuilt vndk", ldRule.Args["libFlags"], "prebuilts/vndk/libvndk.so")
  3952. android.AssertStringDoesContain(t, "should link to prebuilt libc++demangle", ldRule.Args["libFlags"], "prebuilts/vndk/libc++demangle.a")
  3953. android.AssertStringDoesContain(t, "should link to prebuilt libunwind", ldRule.Args["libFlags"], "prebuilts/vndk/libunwind.a")
  3954. // Should declare the LLNDK library as a "required" external dependency
  3955. manifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  3956. requireNativeLibs := names(manifestRule.Args["requireNativeLibs"])
  3957. ensureListContains(t, requireNativeLibs, "libllndk.so")
  3958. }
  3959. func TestDependenciesInApexManifest(t *testing.T) {
  3960. ctx := testApex(t, `
  3961. apex {
  3962. name: "myapex_nodep",
  3963. key: "myapex.key",
  3964. native_shared_libs: ["lib_nodep"],
  3965. compile_multilib: "both",
  3966. file_contexts: ":myapex-file_contexts",
  3967. updatable: false,
  3968. }
  3969. apex {
  3970. name: "myapex_dep",
  3971. key: "myapex.key",
  3972. native_shared_libs: ["lib_dep"],
  3973. compile_multilib: "both",
  3974. file_contexts: ":myapex-file_contexts",
  3975. updatable: false,
  3976. }
  3977. apex {
  3978. name: "myapex_provider",
  3979. key: "myapex.key",
  3980. native_shared_libs: ["libfoo"],
  3981. compile_multilib: "both",
  3982. file_contexts: ":myapex-file_contexts",
  3983. updatable: false,
  3984. }
  3985. apex {
  3986. name: "myapex_selfcontained",
  3987. key: "myapex.key",
  3988. native_shared_libs: ["lib_dep_on_bar", "libbar"],
  3989. compile_multilib: "both",
  3990. file_contexts: ":myapex-file_contexts",
  3991. updatable: false,
  3992. }
  3993. apex_key {
  3994. name: "myapex.key",
  3995. public_key: "testkey.avbpubkey",
  3996. private_key: "testkey.pem",
  3997. }
  3998. cc_library {
  3999. name: "lib_nodep",
  4000. srcs: ["mylib.cpp"],
  4001. system_shared_libs: [],
  4002. stl: "none",
  4003. apex_available: [ "myapex_nodep" ],
  4004. }
  4005. cc_library {
  4006. name: "lib_dep",
  4007. srcs: ["mylib.cpp"],
  4008. shared_libs: ["libfoo"],
  4009. system_shared_libs: [],
  4010. stl: "none",
  4011. apex_available: [
  4012. "myapex_dep",
  4013. "myapex_provider",
  4014. "myapex_selfcontained",
  4015. ],
  4016. }
  4017. cc_library {
  4018. name: "lib_dep_on_bar",
  4019. srcs: ["mylib.cpp"],
  4020. shared_libs: ["libbar"],
  4021. system_shared_libs: [],
  4022. stl: "none",
  4023. apex_available: [
  4024. "myapex_selfcontained",
  4025. ],
  4026. }
  4027. cc_library {
  4028. name: "libfoo",
  4029. srcs: ["mytest.cpp"],
  4030. stubs: {
  4031. versions: ["1"],
  4032. },
  4033. system_shared_libs: [],
  4034. stl: "none",
  4035. apex_available: [
  4036. "myapex_provider",
  4037. ],
  4038. }
  4039. cc_library {
  4040. name: "libbar",
  4041. srcs: ["mytest.cpp"],
  4042. stubs: {
  4043. versions: ["1"],
  4044. },
  4045. system_shared_libs: [],
  4046. stl: "none",
  4047. apex_available: [
  4048. "myapex_selfcontained",
  4049. ],
  4050. }
  4051. `)
  4052. var apexManifestRule android.TestingBuildParams
  4053. var provideNativeLibs, requireNativeLibs []string
  4054. apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
  4055. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  4056. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  4057. ensureListEmpty(t, provideNativeLibs)
  4058. ensureListEmpty(t, requireNativeLibs)
  4059. apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
  4060. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  4061. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  4062. ensureListEmpty(t, provideNativeLibs)
  4063. ensureListContains(t, requireNativeLibs, "libfoo.so")
  4064. apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
  4065. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  4066. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  4067. ensureListContains(t, provideNativeLibs, "libfoo.so")
  4068. ensureListEmpty(t, requireNativeLibs)
  4069. apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
  4070. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  4071. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  4072. ensureListContains(t, provideNativeLibs, "libbar.so")
  4073. ensureListEmpty(t, requireNativeLibs)
  4074. }
  4075. func TestOverrideApexManifestDefaultVersion(t *testing.T) {
  4076. ctx := testApex(t, `
  4077. apex {
  4078. name: "myapex",
  4079. key: "myapex.key",
  4080. native_shared_libs: ["mylib"],
  4081. updatable: false,
  4082. }
  4083. apex_key {
  4084. name: "myapex.key",
  4085. public_key: "testkey.avbpubkey",
  4086. private_key: "testkey.pem",
  4087. }
  4088. cc_library {
  4089. name: "mylib",
  4090. srcs: ["mylib.cpp"],
  4091. system_shared_libs: [],
  4092. stl: "none",
  4093. apex_available: [
  4094. "//apex_available:platform",
  4095. "myapex",
  4096. ],
  4097. }
  4098. `, android.FixtureMergeEnv(map[string]string{
  4099. "OVERRIDE_APEX_MANIFEST_DEFAULT_VERSION": "1234",
  4100. }))
  4101. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4102. apexManifestRule := module.Rule("apexManifestRule")
  4103. ensureContains(t, apexManifestRule.Args["default_version"], "1234")
  4104. }
  4105. func TestCompileMultilibProp(t *testing.T) {
  4106. testCases := []struct {
  4107. compileMultiLibProp string
  4108. containedLibs []string
  4109. notContainedLibs []string
  4110. }{
  4111. {
  4112. containedLibs: []string{
  4113. "image.apex/lib64/mylib.so",
  4114. "image.apex/lib/mylib.so",
  4115. },
  4116. compileMultiLibProp: `compile_multilib: "both",`,
  4117. },
  4118. {
  4119. containedLibs: []string{"image.apex/lib64/mylib.so"},
  4120. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  4121. compileMultiLibProp: `compile_multilib: "first",`,
  4122. },
  4123. {
  4124. containedLibs: []string{"image.apex/lib64/mylib.so"},
  4125. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  4126. // compile_multilib, when unset, should result to the same output as when compile_multilib is "first"
  4127. },
  4128. {
  4129. containedLibs: []string{"image.apex/lib64/mylib.so"},
  4130. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  4131. compileMultiLibProp: `compile_multilib: "64",`,
  4132. },
  4133. {
  4134. containedLibs: []string{"image.apex/lib/mylib.so"},
  4135. notContainedLibs: []string{"image.apex/lib64/mylib.so"},
  4136. compileMultiLibProp: `compile_multilib: "32",`,
  4137. },
  4138. }
  4139. for _, testCase := range testCases {
  4140. ctx := testApex(t, fmt.Sprintf(`
  4141. apex {
  4142. name: "myapex",
  4143. key: "myapex.key",
  4144. %s
  4145. native_shared_libs: ["mylib"],
  4146. updatable: false,
  4147. }
  4148. apex_key {
  4149. name: "myapex.key",
  4150. public_key: "testkey.avbpubkey",
  4151. private_key: "testkey.pem",
  4152. }
  4153. cc_library {
  4154. name: "mylib",
  4155. srcs: ["mylib.cpp"],
  4156. apex_available: [
  4157. "//apex_available:platform",
  4158. "myapex",
  4159. ],
  4160. }
  4161. `, testCase.compileMultiLibProp),
  4162. )
  4163. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4164. apexRule := module.Rule("apexRule")
  4165. copyCmds := apexRule.Args["copy_commands"]
  4166. for _, containedLib := range testCase.containedLibs {
  4167. ensureContains(t, copyCmds, containedLib)
  4168. }
  4169. for _, notContainedLib := range testCase.notContainedLibs {
  4170. ensureNotContains(t, copyCmds, notContainedLib)
  4171. }
  4172. }
  4173. }
  4174. func TestNonTestApex(t *testing.T) {
  4175. ctx := testApex(t, `
  4176. apex {
  4177. name: "myapex",
  4178. key: "myapex.key",
  4179. native_shared_libs: ["mylib_common"],
  4180. updatable: false,
  4181. }
  4182. apex_key {
  4183. name: "myapex.key",
  4184. public_key: "testkey.avbpubkey",
  4185. private_key: "testkey.pem",
  4186. }
  4187. cc_library {
  4188. name: "mylib_common",
  4189. srcs: ["mylib.cpp"],
  4190. system_shared_libs: [],
  4191. stl: "none",
  4192. apex_available: [
  4193. "//apex_available:platform",
  4194. "myapex",
  4195. ],
  4196. }
  4197. `)
  4198. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4199. apexRule := module.Rule("apexRule")
  4200. copyCmds := apexRule.Args["copy_commands"]
  4201. if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
  4202. t.Log("Apex was a test apex!")
  4203. t.Fail()
  4204. }
  4205. // Ensure that main rule creates an output
  4206. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  4207. // Ensure that apex variant is created for the direct dep
  4208. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  4209. // Ensure that both direct and indirect deps are copied into apex
  4210. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  4211. // Ensure that the platform variant ends with _shared
  4212. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  4213. if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
  4214. t.Log("Found mylib_common not in any apex!")
  4215. t.Fail()
  4216. }
  4217. }
  4218. func TestTestApex(t *testing.T) {
  4219. ctx := testApex(t, `
  4220. apex_test {
  4221. name: "myapex",
  4222. key: "myapex.key",
  4223. native_shared_libs: ["mylib_common_test"],
  4224. updatable: false,
  4225. }
  4226. apex_key {
  4227. name: "myapex.key",
  4228. public_key: "testkey.avbpubkey",
  4229. private_key: "testkey.pem",
  4230. }
  4231. cc_library {
  4232. name: "mylib_common_test",
  4233. srcs: ["mylib.cpp"],
  4234. system_shared_libs: [],
  4235. stl: "none",
  4236. // TODO: remove //apex_available:platform
  4237. apex_available: [
  4238. "//apex_available:platform",
  4239. "myapex",
  4240. ],
  4241. }
  4242. `)
  4243. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4244. apexRule := module.Rule("apexRule")
  4245. copyCmds := apexRule.Args["copy_commands"]
  4246. if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
  4247. t.Log("Apex was not a test apex!")
  4248. t.Fail()
  4249. }
  4250. // Ensure that main rule creates an output
  4251. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  4252. // Ensure that apex variant is created for the direct dep
  4253. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
  4254. // Ensure that both direct and indirect deps are copied into apex
  4255. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
  4256. // Ensure that the platform variant ends with _shared
  4257. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
  4258. }
  4259. func TestApexWithTarget(t *testing.T) {
  4260. ctx := testApex(t, `
  4261. apex {
  4262. name: "myapex",
  4263. key: "myapex.key",
  4264. updatable: false,
  4265. multilib: {
  4266. first: {
  4267. native_shared_libs: ["mylib_common"],
  4268. }
  4269. },
  4270. target: {
  4271. android: {
  4272. multilib: {
  4273. first: {
  4274. native_shared_libs: ["mylib"],
  4275. }
  4276. }
  4277. },
  4278. host: {
  4279. multilib: {
  4280. first: {
  4281. native_shared_libs: ["mylib2"],
  4282. }
  4283. }
  4284. }
  4285. }
  4286. }
  4287. apex_key {
  4288. name: "myapex.key",
  4289. public_key: "testkey.avbpubkey",
  4290. private_key: "testkey.pem",
  4291. }
  4292. cc_library {
  4293. name: "mylib",
  4294. srcs: ["mylib.cpp"],
  4295. system_shared_libs: [],
  4296. stl: "none",
  4297. // TODO: remove //apex_available:platform
  4298. apex_available: [
  4299. "//apex_available:platform",
  4300. "myapex",
  4301. ],
  4302. }
  4303. cc_library {
  4304. name: "mylib_common",
  4305. srcs: ["mylib.cpp"],
  4306. system_shared_libs: [],
  4307. stl: "none",
  4308. compile_multilib: "first",
  4309. // TODO: remove //apex_available:platform
  4310. apex_available: [
  4311. "//apex_available:platform",
  4312. "myapex",
  4313. ],
  4314. }
  4315. cc_library {
  4316. name: "mylib2",
  4317. srcs: ["mylib.cpp"],
  4318. system_shared_libs: [],
  4319. stl: "none",
  4320. compile_multilib: "first",
  4321. }
  4322. `)
  4323. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4324. copyCmds := apexRule.Args["copy_commands"]
  4325. // Ensure that main rule creates an output
  4326. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  4327. // Ensure that apex variant is created for the direct dep
  4328. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  4329. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  4330. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  4331. // Ensure that both direct and indirect deps are copied into apex
  4332. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  4333. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  4334. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  4335. // Ensure that the platform variant ends with _shared
  4336. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  4337. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  4338. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  4339. }
  4340. func TestApexWithArch(t *testing.T) {
  4341. ctx := testApex(t, `
  4342. apex {
  4343. name: "myapex",
  4344. key: "myapex.key",
  4345. updatable: false,
  4346. native_shared_libs: ["mylib.generic"],
  4347. arch: {
  4348. arm64: {
  4349. native_shared_libs: ["mylib.arm64"],
  4350. exclude_native_shared_libs: ["mylib.generic"],
  4351. },
  4352. x86_64: {
  4353. native_shared_libs: ["mylib.x64"],
  4354. exclude_native_shared_libs: ["mylib.generic"],
  4355. },
  4356. }
  4357. }
  4358. apex_key {
  4359. name: "myapex.key",
  4360. public_key: "testkey.avbpubkey",
  4361. private_key: "testkey.pem",
  4362. }
  4363. cc_library {
  4364. name: "mylib.generic",
  4365. srcs: ["mylib.cpp"],
  4366. system_shared_libs: [],
  4367. stl: "none",
  4368. // TODO: remove //apex_available:platform
  4369. apex_available: [
  4370. "//apex_available:platform",
  4371. "myapex",
  4372. ],
  4373. }
  4374. cc_library {
  4375. name: "mylib.arm64",
  4376. srcs: ["mylib.cpp"],
  4377. system_shared_libs: [],
  4378. stl: "none",
  4379. // TODO: remove //apex_available:platform
  4380. apex_available: [
  4381. "//apex_available:platform",
  4382. "myapex",
  4383. ],
  4384. }
  4385. cc_library {
  4386. name: "mylib.x64",
  4387. srcs: ["mylib.cpp"],
  4388. system_shared_libs: [],
  4389. stl: "none",
  4390. // TODO: remove //apex_available:platform
  4391. apex_available: [
  4392. "//apex_available:platform",
  4393. "myapex",
  4394. ],
  4395. }
  4396. `)
  4397. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4398. copyCmds := apexRule.Args["copy_commands"]
  4399. // Ensure that apex variant is created for the direct dep
  4400. ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
  4401. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.generic"), "android_arm64_armv8-a_shared_apex10000")
  4402. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
  4403. // Ensure that both direct and indirect deps are copied into apex
  4404. ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
  4405. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
  4406. }
  4407. func TestApexWithShBinary(t *testing.T) {
  4408. ctx := testApex(t, `
  4409. apex {
  4410. name: "myapex",
  4411. key: "myapex.key",
  4412. sh_binaries: ["myscript"],
  4413. updatable: false,
  4414. }
  4415. apex_key {
  4416. name: "myapex.key",
  4417. public_key: "testkey.avbpubkey",
  4418. private_key: "testkey.pem",
  4419. }
  4420. sh_binary {
  4421. name: "myscript",
  4422. src: "mylib.cpp",
  4423. filename: "myscript.sh",
  4424. sub_dir: "script",
  4425. }
  4426. `)
  4427. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4428. copyCmds := apexRule.Args["copy_commands"]
  4429. ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
  4430. }
  4431. func TestApexInVariousPartition(t *testing.T) {
  4432. testcases := []struct {
  4433. propName, partition string
  4434. }{
  4435. {"", "system"},
  4436. {"product_specific: true", "product"},
  4437. {"soc_specific: true", "vendor"},
  4438. {"proprietary: true", "vendor"},
  4439. {"vendor: true", "vendor"},
  4440. {"system_ext_specific: true", "system_ext"},
  4441. }
  4442. for _, tc := range testcases {
  4443. t.Run(tc.propName+":"+tc.partition, func(t *testing.T) {
  4444. ctx := testApex(t, `
  4445. apex {
  4446. name: "myapex",
  4447. key: "myapex.key",
  4448. updatable: false,
  4449. `+tc.propName+`
  4450. }
  4451. apex_key {
  4452. name: "myapex.key",
  4453. public_key: "testkey.avbpubkey",
  4454. private_key: "testkey.pem",
  4455. }
  4456. `)
  4457. apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4458. expected := "out/soong/target/product/test_device/" + tc.partition + "/apex"
  4459. actual := apex.installDir.RelativeToTop().String()
  4460. if actual != expected {
  4461. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  4462. }
  4463. })
  4464. }
  4465. }
  4466. func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
  4467. ctx := testApex(t, `
  4468. apex {
  4469. name: "myapex",
  4470. key: "myapex.key",
  4471. updatable: false,
  4472. }
  4473. apex_key {
  4474. name: "myapex.key",
  4475. public_key: "testkey.avbpubkey",
  4476. private_key: "testkey.pem",
  4477. }
  4478. `)
  4479. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4480. rule := module.Output("file_contexts")
  4481. ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
  4482. }
  4483. func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
  4484. testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
  4485. apex {
  4486. name: "myapex",
  4487. key: "myapex.key",
  4488. file_contexts: "my_own_file_contexts",
  4489. updatable: false,
  4490. }
  4491. apex_key {
  4492. name: "myapex.key",
  4493. public_key: "testkey.avbpubkey",
  4494. private_key: "testkey.pem",
  4495. }
  4496. `, withFiles(map[string][]byte{
  4497. "my_own_file_contexts": nil,
  4498. }))
  4499. }
  4500. func TestFileContexts_ProductSpecificApexes(t *testing.T) {
  4501. testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
  4502. apex {
  4503. name: "myapex",
  4504. key: "myapex.key",
  4505. product_specific: true,
  4506. file_contexts: "product_specific_file_contexts",
  4507. updatable: false,
  4508. }
  4509. apex_key {
  4510. name: "myapex.key",
  4511. public_key: "testkey.avbpubkey",
  4512. private_key: "testkey.pem",
  4513. }
  4514. `)
  4515. ctx := testApex(t, `
  4516. apex {
  4517. name: "myapex",
  4518. key: "myapex.key",
  4519. product_specific: true,
  4520. file_contexts: "product_specific_file_contexts",
  4521. updatable: false,
  4522. }
  4523. apex_key {
  4524. name: "myapex.key",
  4525. public_key: "testkey.avbpubkey",
  4526. private_key: "testkey.pem",
  4527. }
  4528. `, withFiles(map[string][]byte{
  4529. "product_specific_file_contexts": nil,
  4530. }))
  4531. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4532. rule := module.Output("file_contexts")
  4533. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4534. }
  4535. func TestFileContexts_SetViaFileGroup(t *testing.T) {
  4536. ctx := testApex(t, `
  4537. apex {
  4538. name: "myapex",
  4539. key: "myapex.key",
  4540. product_specific: true,
  4541. file_contexts: ":my-file-contexts",
  4542. updatable: false,
  4543. }
  4544. apex_key {
  4545. name: "myapex.key",
  4546. public_key: "testkey.avbpubkey",
  4547. private_key: "testkey.pem",
  4548. }
  4549. filegroup {
  4550. name: "my-file-contexts",
  4551. srcs: ["product_specific_file_contexts"],
  4552. }
  4553. `, withFiles(map[string][]byte{
  4554. "product_specific_file_contexts": nil,
  4555. }))
  4556. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4557. rule := module.Output("file_contexts")
  4558. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4559. }
  4560. func TestApexKeyFromOtherModule(t *testing.T) {
  4561. ctx := testApex(t, `
  4562. apex_key {
  4563. name: "myapex.key",
  4564. public_key: ":my.avbpubkey",
  4565. private_key: ":my.pem",
  4566. product_specific: true,
  4567. }
  4568. filegroup {
  4569. name: "my.avbpubkey",
  4570. srcs: ["testkey2.avbpubkey"],
  4571. }
  4572. filegroup {
  4573. name: "my.pem",
  4574. srcs: ["testkey2.pem"],
  4575. }
  4576. `)
  4577. apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  4578. expected_pubkey := "testkey2.avbpubkey"
  4579. actual_pubkey := apex_key.publicKeyFile.String()
  4580. if actual_pubkey != expected_pubkey {
  4581. t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
  4582. }
  4583. expected_privkey := "testkey2.pem"
  4584. actual_privkey := apex_key.privateKeyFile.String()
  4585. if actual_privkey != expected_privkey {
  4586. t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
  4587. }
  4588. }
  4589. func TestPrebuilt(t *testing.T) {
  4590. ctx := testApex(t, `
  4591. prebuilt_apex {
  4592. name: "myapex",
  4593. arch: {
  4594. arm64: {
  4595. src: "myapex-arm64.apex",
  4596. },
  4597. arm: {
  4598. src: "myapex-arm.apex",
  4599. },
  4600. },
  4601. }
  4602. `)
  4603. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4604. prebuilt := testingModule.Module().(*Prebuilt)
  4605. expectedInput := "myapex-arm64.apex"
  4606. if prebuilt.inputApex.String() != expectedInput {
  4607. t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
  4608. }
  4609. android.AssertStringDoesContain(t, "Invalid provenance metadata file",
  4610. prebuilt.ProvenanceMetaDataFile().String(), "soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto")
  4611. rule := testingModule.Rule("genProvenanceMetaData")
  4612. android.AssertStringEquals(t, "Invalid input", "myapex-arm64.apex", rule.Inputs[0].String())
  4613. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4614. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4615. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.apex", rule.Args["install_path"])
  4616. entries := android.AndroidMkEntriesForTest(t, ctx, testingModule.Module())[0]
  4617. android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "prebuilt_apex", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
  4618. }
  4619. func TestPrebuiltMissingSrc(t *testing.T) {
  4620. testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
  4621. prebuilt_apex {
  4622. name: "myapex",
  4623. }
  4624. `)
  4625. }
  4626. func TestPrebuiltFilenameOverride(t *testing.T) {
  4627. ctx := testApex(t, `
  4628. prebuilt_apex {
  4629. name: "myapex",
  4630. src: "myapex-arm.apex",
  4631. filename: "notmyapex.apex",
  4632. }
  4633. `)
  4634. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4635. p := testingModule.Module().(*Prebuilt)
  4636. expected := "notmyapex.apex"
  4637. if p.installFilename != expected {
  4638. t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
  4639. }
  4640. rule := testingModule.Rule("genProvenanceMetaData")
  4641. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4642. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4643. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4644. android.AssertStringEquals(t, "Invalid args", "/system/apex/notmyapex.apex", rule.Args["install_path"])
  4645. }
  4646. func TestApexSetFilenameOverride(t *testing.T) {
  4647. testApex(t, `
  4648. apex_set {
  4649. name: "com.company.android.myapex",
  4650. apex_name: "com.android.myapex",
  4651. set: "company-myapex.apks",
  4652. filename: "com.company.android.myapex.apex"
  4653. }
  4654. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4655. testApex(t, `
  4656. apex_set {
  4657. name: "com.company.android.myapex",
  4658. apex_name: "com.android.myapex",
  4659. set: "company-myapex.apks",
  4660. filename: "com.company.android.myapex.capex"
  4661. }
  4662. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4663. testApexError(t, `filename should end in .apex or .capex for apex_set`, `
  4664. apex_set {
  4665. name: "com.company.android.myapex",
  4666. apex_name: "com.android.myapex",
  4667. set: "company-myapex.apks",
  4668. filename: "some-random-suffix"
  4669. }
  4670. `)
  4671. }
  4672. func TestPrebuiltOverrides(t *testing.T) {
  4673. ctx := testApex(t, `
  4674. prebuilt_apex {
  4675. name: "myapex.prebuilt",
  4676. src: "myapex-arm.apex",
  4677. overrides: [
  4678. "myapex",
  4679. ],
  4680. }
  4681. `)
  4682. testingModule := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt")
  4683. p := testingModule.Module().(*Prebuilt)
  4684. expected := []string{"myapex"}
  4685. actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  4686. if !reflect.DeepEqual(actual, expected) {
  4687. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
  4688. }
  4689. rule := testingModule.Rule("genProvenanceMetaData")
  4690. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4691. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex.prebuilt/provenance_metadata.textproto", rule.Output.String())
  4692. android.AssertStringEquals(t, "Invalid args", "myapex.prebuilt", rule.Args["module_name"])
  4693. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.prebuilt.apex", rule.Args["install_path"])
  4694. }
  4695. func TestPrebuiltApexName(t *testing.T) {
  4696. testApex(t, `
  4697. prebuilt_apex {
  4698. name: "com.company.android.myapex",
  4699. apex_name: "com.android.myapex",
  4700. src: "company-myapex-arm.apex",
  4701. }
  4702. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4703. testApex(t, `
  4704. apex_set {
  4705. name: "com.company.android.myapex",
  4706. apex_name: "com.android.myapex",
  4707. set: "company-myapex.apks",
  4708. }
  4709. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4710. }
  4711. func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
  4712. _ = android.GroupFixturePreparers(
  4713. java.PrepareForTestWithJavaDefaultModules,
  4714. PrepareForTestWithApexBuildComponents,
  4715. android.FixtureWithRootAndroidBp(`
  4716. platform_bootclasspath {
  4717. name: "platform-bootclasspath",
  4718. fragments: [
  4719. {
  4720. apex: "com.android.art",
  4721. module: "art-bootclasspath-fragment",
  4722. },
  4723. ],
  4724. }
  4725. prebuilt_apex {
  4726. name: "com.company.android.art",
  4727. apex_name: "com.android.art",
  4728. src: "com.company.android.art-arm.apex",
  4729. exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
  4730. }
  4731. prebuilt_bootclasspath_fragment {
  4732. name: "art-bootclasspath-fragment",
  4733. image_name: "art",
  4734. contents: ["core-oj"],
  4735. hidden_api: {
  4736. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4737. metadata: "my-bootclasspath-fragment/metadata.csv",
  4738. index: "my-bootclasspath-fragment/index.csv",
  4739. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4740. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4741. },
  4742. }
  4743. java_import {
  4744. name: "core-oj",
  4745. jars: ["prebuilt.jar"],
  4746. }
  4747. `),
  4748. ).RunTest(t)
  4749. }
  4750. // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
  4751. // propagation of paths to dex implementation jars from the former to the latter.
  4752. func TestPrebuiltExportDexImplementationJars(t *testing.T) {
  4753. transform := android.NullFixturePreparer
  4754. checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4755. t.Helper()
  4756. // Make sure the import has been given the correct path to the dex jar.
  4757. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4758. dexJarBuildPath := p.DexJarBuildPath().PathOrNil()
  4759. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4760. android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
  4761. ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
  4762. android.NormalizePathForTesting(dexJarBuildPath))
  4763. }
  4764. checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4765. t.Helper()
  4766. // Make sure the import has been given the correct path to the dex jar.
  4767. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4768. dexJarBuildPath := p.DexJarInstallPath()
  4769. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4770. android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
  4771. "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
  4772. android.NormalizePathForTesting(dexJarBuildPath))
  4773. }
  4774. ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
  4775. t.Helper()
  4776. // Make sure that an apex variant is not created for the source module.
  4777. android.AssertArrayString(t, "Check if there is no source variant",
  4778. []string{"android_common"},
  4779. ctx.ModuleVariantsForTests(name))
  4780. }
  4781. t.Run("prebuilt only", func(t *testing.T) {
  4782. bp := `
  4783. prebuilt_apex {
  4784. name: "myapex",
  4785. arch: {
  4786. arm64: {
  4787. src: "myapex-arm64.apex",
  4788. },
  4789. arm: {
  4790. src: "myapex-arm.apex",
  4791. },
  4792. },
  4793. exported_java_libs: ["libfoo", "libbar"],
  4794. }
  4795. java_import {
  4796. name: "libfoo",
  4797. jars: ["libfoo.jar"],
  4798. }
  4799. java_sdk_library_import {
  4800. name: "libbar",
  4801. public: {
  4802. jars: ["libbar.jar"],
  4803. },
  4804. }
  4805. `
  4806. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4807. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4808. deapexerName := deapexerModuleName("myapex")
  4809. android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName))
  4810. // Make sure that the deapexer has the correct input APEX.
  4811. deapexer := ctx.ModuleForTests(deapexerName, "android_common")
  4812. rule := deapexer.Rule("deapexer")
  4813. if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
  4814. t.Errorf("expected: %q, found: %q", expected, actual)
  4815. }
  4816. // Make sure that the prebuilt_apex has the correct input APEX.
  4817. prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
  4818. rule = prebuiltApex.Rule("android/soong/android.Cp")
  4819. if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
  4820. t.Errorf("expected: %q, found: %q", expected, actual)
  4821. }
  4822. checkDexJarBuildPath(t, ctx, "libfoo")
  4823. checkDexJarInstallPath(t, ctx, "libfoo")
  4824. checkDexJarBuildPath(t, ctx, "libbar")
  4825. checkDexJarInstallPath(t, ctx, "libbar")
  4826. })
  4827. t.Run("prebuilt with source preferred", func(t *testing.T) {
  4828. bp := `
  4829. prebuilt_apex {
  4830. name: "myapex",
  4831. arch: {
  4832. arm64: {
  4833. src: "myapex-arm64.apex",
  4834. },
  4835. arm: {
  4836. src: "myapex-arm.apex",
  4837. },
  4838. },
  4839. exported_java_libs: ["libfoo", "libbar"],
  4840. }
  4841. java_import {
  4842. name: "libfoo",
  4843. jars: ["libfoo.jar"],
  4844. }
  4845. java_library {
  4846. name: "libfoo",
  4847. }
  4848. java_sdk_library_import {
  4849. name: "libbar",
  4850. public: {
  4851. jars: ["libbar.jar"],
  4852. },
  4853. }
  4854. java_sdk_library {
  4855. name: "libbar",
  4856. srcs: ["foo/bar/MyClass.java"],
  4857. unsafe_ignore_missing_latest_api: true,
  4858. }
  4859. `
  4860. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4861. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4862. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4863. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4864. ensureNoSourceVariant(t, ctx, "libfoo")
  4865. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4866. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4867. ensureNoSourceVariant(t, ctx, "libbar")
  4868. })
  4869. t.Run("prebuilt preferred with source", func(t *testing.T) {
  4870. bp := `
  4871. prebuilt_apex {
  4872. name: "myapex",
  4873. arch: {
  4874. arm64: {
  4875. src: "myapex-arm64.apex",
  4876. },
  4877. arm: {
  4878. src: "myapex-arm.apex",
  4879. },
  4880. },
  4881. exported_java_libs: ["libfoo", "libbar"],
  4882. }
  4883. java_import {
  4884. name: "libfoo",
  4885. prefer: true,
  4886. jars: ["libfoo.jar"],
  4887. }
  4888. java_library {
  4889. name: "libfoo",
  4890. }
  4891. java_sdk_library_import {
  4892. name: "libbar",
  4893. prefer: true,
  4894. public: {
  4895. jars: ["libbar.jar"],
  4896. },
  4897. }
  4898. java_sdk_library {
  4899. name: "libbar",
  4900. srcs: ["foo/bar/MyClass.java"],
  4901. unsafe_ignore_missing_latest_api: true,
  4902. }
  4903. `
  4904. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4905. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4906. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4907. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4908. ensureNoSourceVariant(t, ctx, "libfoo")
  4909. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4910. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4911. ensureNoSourceVariant(t, ctx, "libbar")
  4912. })
  4913. }
  4914. func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
  4915. preparer := android.GroupFixturePreparers(
  4916. java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
  4917. // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
  4918. // is disabled.
  4919. android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
  4920. )
  4921. checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
  4922. t.Helper()
  4923. s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4924. foundLibfooJar := false
  4925. base := stem + ".jar"
  4926. for _, output := range s.AllOutputs() {
  4927. if filepath.Base(output) == base {
  4928. foundLibfooJar = true
  4929. buildRule := s.Output(output)
  4930. android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
  4931. }
  4932. }
  4933. if !foundLibfooJar {
  4934. t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
  4935. }
  4936. }
  4937. checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4938. t.Helper()
  4939. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4940. var rule android.TestingBuildParams
  4941. rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
  4942. java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
  4943. }
  4944. checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4945. t.Helper()
  4946. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4947. var rule android.TestingBuildParams
  4948. rule = platformBootclasspath.Output("hiddenapi-index.csv")
  4949. java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
  4950. }
  4951. fragment := java.ApexVariantReference{
  4952. Apex: proptools.StringPtr("myapex"),
  4953. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  4954. }
  4955. t.Run("prebuilt only", func(t *testing.T) {
  4956. bp := `
  4957. prebuilt_apex {
  4958. name: "myapex",
  4959. arch: {
  4960. arm64: {
  4961. src: "myapex-arm64.apex",
  4962. },
  4963. arm: {
  4964. src: "myapex-arm.apex",
  4965. },
  4966. },
  4967. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4968. }
  4969. prebuilt_bootclasspath_fragment {
  4970. name: "my-bootclasspath-fragment",
  4971. contents: ["libfoo", "libbar"],
  4972. apex_available: ["myapex"],
  4973. hidden_api: {
  4974. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4975. metadata: "my-bootclasspath-fragment/metadata.csv",
  4976. index: "my-bootclasspath-fragment/index.csv",
  4977. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4978. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4979. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4980. },
  4981. }
  4982. java_import {
  4983. name: "libfoo",
  4984. jars: ["libfoo.jar"],
  4985. apex_available: ["myapex"],
  4986. permitted_packages: ["foo"],
  4987. }
  4988. java_sdk_library_import {
  4989. name: "libbar",
  4990. public: {
  4991. jars: ["libbar.jar"],
  4992. },
  4993. apex_available: ["myapex"],
  4994. shared_library: false,
  4995. permitted_packages: ["bar"],
  4996. }
  4997. `
  4998. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4999. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  5000. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  5001. // Verify the correct module jars contribute to the hiddenapi index file.
  5002. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  5003. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  5004. my-bootclasspath-fragment/index.csv
  5005. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  5006. `)
  5007. })
  5008. t.Run("apex_set only", func(t *testing.T) {
  5009. bp := `
  5010. apex_set {
  5011. name: "myapex",
  5012. set: "myapex.apks",
  5013. exported_java_libs: ["myjavalib"],
  5014. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  5015. exported_systemserverclasspath_fragments: ["my-systemserverclasspath-fragment"],
  5016. }
  5017. java_import {
  5018. name: "myjavalib",
  5019. jars: ["myjavalib.jar"],
  5020. apex_available: ["myapex"],
  5021. permitted_packages: ["javalib"],
  5022. }
  5023. prebuilt_bootclasspath_fragment {
  5024. name: "my-bootclasspath-fragment",
  5025. contents: ["libfoo", "libbar"],
  5026. apex_available: ["myapex"],
  5027. hidden_api: {
  5028. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  5029. metadata: "my-bootclasspath-fragment/metadata.csv",
  5030. index: "my-bootclasspath-fragment/index.csv",
  5031. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  5032. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  5033. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  5034. },
  5035. }
  5036. prebuilt_systemserverclasspath_fragment {
  5037. name: "my-systemserverclasspath-fragment",
  5038. contents: ["libbaz"],
  5039. apex_available: ["myapex"],
  5040. }
  5041. java_import {
  5042. name: "libfoo",
  5043. jars: ["libfoo.jar"],
  5044. apex_available: ["myapex"],
  5045. permitted_packages: ["foo"],
  5046. }
  5047. java_sdk_library_import {
  5048. name: "libbar",
  5049. public: {
  5050. jars: ["libbar.jar"],
  5051. },
  5052. apex_available: ["myapex"],
  5053. shared_library: false,
  5054. permitted_packages: ["bar"],
  5055. }
  5056. java_sdk_library_import {
  5057. name: "libbaz",
  5058. public: {
  5059. jars: ["libbaz.jar"],
  5060. },
  5061. apex_available: ["myapex"],
  5062. shared_library: false,
  5063. permitted_packages: ["baz"],
  5064. }
  5065. `
  5066. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  5067. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  5068. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  5069. // Verify the correct module jars contribute to the hiddenapi index file.
  5070. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  5071. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  5072. my-bootclasspath-fragment/index.csv
  5073. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  5074. `)
  5075. myApex := ctx.ModuleForTests("myapex", "android_common_myapex").Module()
  5076. overrideNames := []string{
  5077. "",
  5078. "myjavalib.myapex",
  5079. "libfoo.myapex",
  5080. "libbar.myapex",
  5081. "libbaz.myapex",
  5082. }
  5083. mkEntries := android.AndroidMkEntriesForTest(t, ctx, myApex)
  5084. for i, e := range mkEntries {
  5085. g := e.OverrideName
  5086. if w := overrideNames[i]; w != g {
  5087. t.Errorf("Expected override name %q, got %q", w, g)
  5088. }
  5089. }
  5090. })
  5091. t.Run("prebuilt with source library preferred", func(t *testing.T) {
  5092. bp := `
  5093. prebuilt_apex {
  5094. name: "myapex",
  5095. arch: {
  5096. arm64: {
  5097. src: "myapex-arm64.apex",
  5098. },
  5099. arm: {
  5100. src: "myapex-arm.apex",
  5101. },
  5102. },
  5103. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  5104. }
  5105. prebuilt_bootclasspath_fragment {
  5106. name: "my-bootclasspath-fragment",
  5107. contents: ["libfoo", "libbar"],
  5108. apex_available: ["myapex"],
  5109. hidden_api: {
  5110. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  5111. metadata: "my-bootclasspath-fragment/metadata.csv",
  5112. index: "my-bootclasspath-fragment/index.csv",
  5113. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  5114. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  5115. },
  5116. }
  5117. java_import {
  5118. name: "libfoo",
  5119. jars: ["libfoo.jar"],
  5120. apex_available: ["myapex"],
  5121. }
  5122. java_library {
  5123. name: "libfoo",
  5124. srcs: ["foo/bar/MyClass.java"],
  5125. apex_available: ["myapex"],
  5126. }
  5127. java_sdk_library_import {
  5128. name: "libbar",
  5129. public: {
  5130. jars: ["libbar.jar"],
  5131. },
  5132. apex_available: ["myapex"],
  5133. shared_library: false,
  5134. }
  5135. java_sdk_library {
  5136. name: "libbar",
  5137. srcs: ["foo/bar/MyClass.java"],
  5138. unsafe_ignore_missing_latest_api: true,
  5139. apex_available: ["myapex"],
  5140. }
  5141. `
  5142. // In this test the source (java_library) libfoo is active since the
  5143. // prebuilt (java_import) defaults to prefer:false. However the
  5144. // prebuilt_apex module always depends on the prebuilt, and so it doesn't
  5145. // find the dex boot jar in it. We either need to disable the source libfoo
  5146. // or make the prebuilt libfoo preferred.
  5147. testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
  5148. // dexbootjar check is skipped if AllowMissingDependencies is true
  5149. preparerAllowMissingDeps := android.GroupFixturePreparers(
  5150. preparer,
  5151. android.PrepareForTestWithAllowMissingDependencies,
  5152. )
  5153. testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
  5154. })
  5155. t.Run("prebuilt library preferred with source", func(t *testing.T) {
  5156. bp := `
  5157. prebuilt_apex {
  5158. name: "myapex",
  5159. arch: {
  5160. arm64: {
  5161. src: "myapex-arm64.apex",
  5162. },
  5163. arm: {
  5164. src: "myapex-arm.apex",
  5165. },
  5166. },
  5167. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  5168. }
  5169. prebuilt_bootclasspath_fragment {
  5170. name: "my-bootclasspath-fragment",
  5171. contents: ["libfoo", "libbar"],
  5172. apex_available: ["myapex"],
  5173. hidden_api: {
  5174. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  5175. metadata: "my-bootclasspath-fragment/metadata.csv",
  5176. index: "my-bootclasspath-fragment/index.csv",
  5177. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  5178. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  5179. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  5180. },
  5181. }
  5182. java_import {
  5183. name: "libfoo",
  5184. prefer: true,
  5185. jars: ["libfoo.jar"],
  5186. apex_available: ["myapex"],
  5187. permitted_packages: ["foo"],
  5188. }
  5189. java_library {
  5190. name: "libfoo",
  5191. srcs: ["foo/bar/MyClass.java"],
  5192. apex_available: ["myapex"],
  5193. }
  5194. java_sdk_library_import {
  5195. name: "libbar",
  5196. prefer: true,
  5197. public: {
  5198. jars: ["libbar.jar"],
  5199. },
  5200. apex_available: ["myapex"],
  5201. shared_library: false,
  5202. permitted_packages: ["bar"],
  5203. }
  5204. java_sdk_library {
  5205. name: "libbar",
  5206. srcs: ["foo/bar/MyClass.java"],
  5207. unsafe_ignore_missing_latest_api: true,
  5208. apex_available: ["myapex"],
  5209. }
  5210. `
  5211. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  5212. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  5213. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  5214. // Verify the correct module jars contribute to the hiddenapi index file.
  5215. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  5216. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  5217. my-bootclasspath-fragment/index.csv
  5218. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  5219. `)
  5220. })
  5221. t.Run("prebuilt with source apex preferred", func(t *testing.T) {
  5222. bp := `
  5223. apex {
  5224. name: "myapex",
  5225. key: "myapex.key",
  5226. java_libs: ["libfoo", "libbar"],
  5227. updatable: false,
  5228. }
  5229. apex_key {
  5230. name: "myapex.key",
  5231. public_key: "testkey.avbpubkey",
  5232. private_key: "testkey.pem",
  5233. }
  5234. prebuilt_apex {
  5235. name: "myapex",
  5236. arch: {
  5237. arm64: {
  5238. src: "myapex-arm64.apex",
  5239. },
  5240. arm: {
  5241. src: "myapex-arm.apex",
  5242. },
  5243. },
  5244. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  5245. }
  5246. prebuilt_bootclasspath_fragment {
  5247. name: "my-bootclasspath-fragment",
  5248. contents: ["libfoo", "libbar"],
  5249. apex_available: ["myapex"],
  5250. hidden_api: {
  5251. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  5252. metadata: "my-bootclasspath-fragment/metadata.csv",
  5253. index: "my-bootclasspath-fragment/index.csv",
  5254. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  5255. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  5256. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  5257. },
  5258. }
  5259. java_import {
  5260. name: "libfoo",
  5261. jars: ["libfoo.jar"],
  5262. apex_available: ["myapex"],
  5263. }
  5264. java_library {
  5265. name: "libfoo",
  5266. srcs: ["foo/bar/MyClass.java"],
  5267. apex_available: ["myapex"],
  5268. permitted_packages: ["foo"],
  5269. }
  5270. java_sdk_library_import {
  5271. name: "libbar",
  5272. public: {
  5273. jars: ["libbar.jar"],
  5274. },
  5275. apex_available: ["myapex"],
  5276. shared_library: false,
  5277. }
  5278. java_sdk_library {
  5279. name: "libbar",
  5280. srcs: ["foo/bar/MyClass.java"],
  5281. unsafe_ignore_missing_latest_api: true,
  5282. apex_available: ["myapex"],
  5283. permitted_packages: ["bar"],
  5284. }
  5285. `
  5286. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  5287. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
  5288. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
  5289. // Verify the correct module jars contribute to the hiddenapi index file.
  5290. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  5291. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  5292. my-bootclasspath-fragment/index.csv
  5293. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  5294. `)
  5295. })
  5296. t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
  5297. bp := `
  5298. apex {
  5299. name: "myapex",
  5300. enabled: false,
  5301. key: "myapex.key",
  5302. java_libs: ["libfoo", "libbar"],
  5303. }
  5304. apex_key {
  5305. name: "myapex.key",
  5306. public_key: "testkey.avbpubkey",
  5307. private_key: "testkey.pem",
  5308. }
  5309. prebuilt_apex {
  5310. name: "myapex",
  5311. arch: {
  5312. arm64: {
  5313. src: "myapex-arm64.apex",
  5314. },
  5315. arm: {
  5316. src: "myapex-arm.apex",
  5317. },
  5318. },
  5319. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  5320. }
  5321. prebuilt_bootclasspath_fragment {
  5322. name: "my-bootclasspath-fragment",
  5323. contents: ["libfoo", "libbar"],
  5324. apex_available: ["myapex"],
  5325. hidden_api: {
  5326. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  5327. metadata: "my-bootclasspath-fragment/metadata.csv",
  5328. index: "my-bootclasspath-fragment/index.csv",
  5329. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  5330. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  5331. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  5332. },
  5333. }
  5334. java_import {
  5335. name: "libfoo",
  5336. prefer: true,
  5337. jars: ["libfoo.jar"],
  5338. apex_available: ["myapex"],
  5339. permitted_packages: ["foo"],
  5340. }
  5341. java_library {
  5342. name: "libfoo",
  5343. srcs: ["foo/bar/MyClass.java"],
  5344. apex_available: ["myapex"],
  5345. }
  5346. java_sdk_library_import {
  5347. name: "libbar",
  5348. prefer: true,
  5349. public: {
  5350. jars: ["libbar.jar"],
  5351. },
  5352. apex_available: ["myapex"],
  5353. shared_library: false,
  5354. permitted_packages: ["bar"],
  5355. }
  5356. java_sdk_library {
  5357. name: "libbar",
  5358. srcs: ["foo/bar/MyClass.java"],
  5359. unsafe_ignore_missing_latest_api: true,
  5360. apex_available: ["myapex"],
  5361. }
  5362. `
  5363. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  5364. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  5365. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  5366. // Verify the correct module jars contribute to the hiddenapi index file.
  5367. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  5368. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  5369. my-bootclasspath-fragment/index.csv
  5370. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  5371. `)
  5372. })
  5373. }
  5374. func TestApexWithTests(t *testing.T) {
  5375. ctx := testApex(t, `
  5376. apex_test {
  5377. name: "myapex",
  5378. key: "myapex.key",
  5379. updatable: false,
  5380. tests: [
  5381. "mytest",
  5382. "mytests",
  5383. ],
  5384. }
  5385. apex_key {
  5386. name: "myapex.key",
  5387. public_key: "testkey.avbpubkey",
  5388. private_key: "testkey.pem",
  5389. }
  5390. filegroup {
  5391. name: "fg",
  5392. srcs: [
  5393. "baz",
  5394. "bar/baz"
  5395. ],
  5396. }
  5397. cc_test {
  5398. name: "mytest",
  5399. gtest: false,
  5400. srcs: ["mytest.cpp"],
  5401. relative_install_path: "test",
  5402. shared_libs: ["mylib"],
  5403. system_shared_libs: [],
  5404. static_executable: true,
  5405. stl: "none",
  5406. data: [":fg"],
  5407. }
  5408. cc_library {
  5409. name: "mylib",
  5410. srcs: ["mylib.cpp"],
  5411. system_shared_libs: [],
  5412. stl: "none",
  5413. }
  5414. filegroup {
  5415. name: "fg2",
  5416. srcs: [
  5417. "testdata/baz"
  5418. ],
  5419. }
  5420. cc_test {
  5421. name: "mytests",
  5422. gtest: false,
  5423. srcs: [
  5424. "mytest1.cpp",
  5425. "mytest2.cpp",
  5426. "mytest3.cpp",
  5427. ],
  5428. test_per_src: true,
  5429. relative_install_path: "test",
  5430. system_shared_libs: [],
  5431. static_executable: true,
  5432. stl: "none",
  5433. data: [
  5434. ":fg",
  5435. ":fg2",
  5436. ],
  5437. }
  5438. `)
  5439. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5440. copyCmds := apexRule.Args["copy_commands"]
  5441. // Ensure that test dep (and their transitive dependencies) are copied into apex.
  5442. ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
  5443. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5444. //Ensure that test data are copied into apex.
  5445. ensureContains(t, copyCmds, "image.apex/bin/test/baz")
  5446. ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
  5447. // Ensure that test deps built with `test_per_src` are copied into apex.
  5448. ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
  5449. ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
  5450. ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
  5451. // Ensure the module is correctly translated.
  5452. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5453. data := android.AndroidMkDataForTest(t, ctx, bundle)
  5454. name := bundle.BaseModuleName()
  5455. prefix := "TARGET_"
  5456. var builder strings.Builder
  5457. data.Custom(&builder, name, prefix, "", data)
  5458. androidMk := builder.String()
  5459. ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
  5460. ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
  5461. ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
  5462. ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
  5463. ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
  5464. }
  5465. func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
  5466. testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
  5467. apex {
  5468. name: "myapex",
  5469. key: "myapex.key",
  5470. native_shared_libs: ["libfoo"],
  5471. }
  5472. apex_key {
  5473. name: "myapex.key",
  5474. public_key: "testkey.avbpubkey",
  5475. private_key: "testkey.pem",
  5476. }
  5477. cc_library {
  5478. name: "libfoo",
  5479. stl: "none",
  5480. system_shared_libs: [],
  5481. enabled: false,
  5482. apex_available: ["myapex"],
  5483. }
  5484. `)
  5485. testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
  5486. apex {
  5487. name: "myapex",
  5488. key: "myapex.key",
  5489. java_libs: ["myjar"],
  5490. }
  5491. apex_key {
  5492. name: "myapex.key",
  5493. public_key: "testkey.avbpubkey",
  5494. private_key: "testkey.pem",
  5495. }
  5496. java_library {
  5497. name: "myjar",
  5498. srcs: ["foo/bar/MyClass.java"],
  5499. sdk_version: "none",
  5500. system_modules: "none",
  5501. enabled: false,
  5502. apex_available: ["myapex"],
  5503. }
  5504. `)
  5505. }
  5506. func TestApexWithJavaImport(t *testing.T) {
  5507. ctx := testApex(t, `
  5508. apex {
  5509. name: "myapex",
  5510. key: "myapex.key",
  5511. java_libs: ["myjavaimport"],
  5512. updatable: false,
  5513. }
  5514. apex_key {
  5515. name: "myapex.key",
  5516. public_key: "testkey.avbpubkey",
  5517. private_key: "testkey.pem",
  5518. }
  5519. java_import {
  5520. name: "myjavaimport",
  5521. apex_available: ["myapex"],
  5522. jars: ["my.jar"],
  5523. compile_dex: true,
  5524. }
  5525. `)
  5526. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5527. apexRule := module.Rule("apexRule")
  5528. copyCmds := apexRule.Args["copy_commands"]
  5529. ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
  5530. }
  5531. func TestApexWithApps(t *testing.T) {
  5532. ctx := testApex(t, `
  5533. apex {
  5534. name: "myapex",
  5535. key: "myapex.key",
  5536. apps: [
  5537. "AppFoo",
  5538. "AppFooPriv",
  5539. ],
  5540. updatable: false,
  5541. }
  5542. apex_key {
  5543. name: "myapex.key",
  5544. public_key: "testkey.avbpubkey",
  5545. private_key: "testkey.pem",
  5546. }
  5547. android_app {
  5548. name: "AppFoo",
  5549. srcs: ["foo/bar/MyClass.java"],
  5550. sdk_version: "current",
  5551. system_modules: "none",
  5552. jni_libs: ["libjni"],
  5553. stl: "none",
  5554. apex_available: [ "myapex" ],
  5555. }
  5556. android_app {
  5557. name: "AppFooPriv",
  5558. srcs: ["foo/bar/MyClass.java"],
  5559. sdk_version: "current",
  5560. system_modules: "none",
  5561. privileged: true,
  5562. privapp_allowlist: "privapp_allowlist_com.android.AppFooPriv.xml",
  5563. stl: "none",
  5564. apex_available: [ "myapex" ],
  5565. }
  5566. cc_library_shared {
  5567. name: "libjni",
  5568. srcs: ["mylib.cpp"],
  5569. shared_libs: ["libfoo"],
  5570. stl: "none",
  5571. system_shared_libs: [],
  5572. apex_available: [ "myapex" ],
  5573. sdk_version: "current",
  5574. }
  5575. cc_library_shared {
  5576. name: "libfoo",
  5577. stl: "none",
  5578. system_shared_libs: [],
  5579. apex_available: [ "myapex" ],
  5580. sdk_version: "current",
  5581. }
  5582. `)
  5583. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5584. apexRule := module.Rule("apexRule")
  5585. copyCmds := apexRule.Args["copy_commands"]
  5586. ensureContains(t, copyCmds, "image.apex/app/AppFoo@TEST.BUILD_ID/AppFoo.apk")
  5587. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv@TEST.BUILD_ID/AppFooPriv.apk")
  5588. ensureContains(t, copyCmds, "image.apex/etc/permissions/privapp_allowlist_com.android.AppFooPriv.xml")
  5589. appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
  5590. // JNI libraries are uncompressed
  5591. if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
  5592. t.Errorf("jni libs are not uncompressed for AppFoo")
  5593. }
  5594. // JNI libraries including transitive deps are
  5595. for _, jni := range []string{"libjni", "libfoo"} {
  5596. jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
  5597. // ... embedded inside APK (jnilibs.zip)
  5598. ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
  5599. // ... and not directly inside the APEX
  5600. ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
  5601. }
  5602. apexBundle := module.Module().(*apexBundle)
  5603. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5604. var builder strings.Builder
  5605. data.Custom(&builder, apexBundle.Name(), "TARGET_", "", data)
  5606. androidMk := builder.String()
  5607. ensureContains(t, androidMk, "LOCAL_MODULE := AppFooPriv.myapex")
  5608. ensureContains(t, androidMk, "LOCAL_MODULE := AppFoo.myapex")
  5609. ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALLED_MODULE := \\S+AppFooPriv.apk")
  5610. ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALLED_MODULE := \\S+AppFoo.apk")
  5611. ensureMatches(t, androidMk, "LOCAL_SOONG_INSTALL_PAIRS := \\S+AppFooPriv.apk")
  5612. ensureContains(t, androidMk, "LOCAL_SOONG_INSTALL_PAIRS := privapp_allowlist_com.android.AppFooPriv.xml:$(PRODUCT_OUT)/apex/myapex/etc/permissions/privapp_allowlist_com.android.AppFooPriv.xml")
  5613. }
  5614. func TestApexWithAppImportBuildId(t *testing.T) {
  5615. invalidBuildIds := []string{"../", "a b", "a/b", "a/b/../c", "/a"}
  5616. for _, id := range invalidBuildIds {
  5617. message := fmt.Sprintf("Unable to use build id %s as filename suffix", id)
  5618. fixture := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  5619. variables.BuildId = proptools.StringPtr(id)
  5620. })
  5621. testApexError(t, message, `apex {
  5622. name: "myapex",
  5623. key: "myapex.key",
  5624. apps: ["AppFooPrebuilt"],
  5625. updatable: false,
  5626. }
  5627. apex_key {
  5628. name: "myapex.key",
  5629. public_key: "testkey.avbpubkey",
  5630. private_key: "testkey.pem",
  5631. }
  5632. android_app_import {
  5633. name: "AppFooPrebuilt",
  5634. apk: "PrebuiltAppFoo.apk",
  5635. presigned: true,
  5636. apex_available: ["myapex"],
  5637. }
  5638. `, fixture)
  5639. }
  5640. }
  5641. func TestApexWithAppImports(t *testing.T) {
  5642. ctx := testApex(t, `
  5643. apex {
  5644. name: "myapex",
  5645. key: "myapex.key",
  5646. apps: [
  5647. "AppFooPrebuilt",
  5648. "AppFooPrivPrebuilt",
  5649. ],
  5650. updatable: false,
  5651. }
  5652. apex_key {
  5653. name: "myapex.key",
  5654. public_key: "testkey.avbpubkey",
  5655. private_key: "testkey.pem",
  5656. }
  5657. android_app_import {
  5658. name: "AppFooPrebuilt",
  5659. apk: "PrebuiltAppFoo.apk",
  5660. presigned: true,
  5661. dex_preopt: {
  5662. enabled: false,
  5663. },
  5664. apex_available: ["myapex"],
  5665. }
  5666. android_app_import {
  5667. name: "AppFooPrivPrebuilt",
  5668. apk: "PrebuiltAppFooPriv.apk",
  5669. privileged: true,
  5670. presigned: true,
  5671. dex_preopt: {
  5672. enabled: false,
  5673. },
  5674. filename: "AwesomePrebuiltAppFooPriv.apk",
  5675. apex_available: ["myapex"],
  5676. }
  5677. `)
  5678. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5679. apexRule := module.Rule("apexRule")
  5680. copyCmds := apexRule.Args["copy_commands"]
  5681. ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt@TEST.BUILD_ID/AppFooPrebuilt.apk")
  5682. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt@TEST.BUILD_ID/AwesomePrebuiltAppFooPriv.apk")
  5683. }
  5684. func TestApexWithAppImportsPrefer(t *testing.T) {
  5685. ctx := testApex(t, `
  5686. apex {
  5687. name: "myapex",
  5688. key: "myapex.key",
  5689. apps: [
  5690. "AppFoo",
  5691. ],
  5692. updatable: false,
  5693. }
  5694. apex_key {
  5695. name: "myapex.key",
  5696. public_key: "testkey.avbpubkey",
  5697. private_key: "testkey.pem",
  5698. }
  5699. android_app {
  5700. name: "AppFoo",
  5701. srcs: ["foo/bar/MyClass.java"],
  5702. sdk_version: "none",
  5703. system_modules: "none",
  5704. apex_available: [ "myapex" ],
  5705. }
  5706. android_app_import {
  5707. name: "AppFoo",
  5708. apk: "AppFooPrebuilt.apk",
  5709. filename: "AppFooPrebuilt.apk",
  5710. presigned: true,
  5711. prefer: true,
  5712. apex_available: ["myapex"],
  5713. }
  5714. `, withFiles(map[string][]byte{
  5715. "AppFooPrebuilt.apk": nil,
  5716. }))
  5717. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5718. "app/AppFoo@TEST.BUILD_ID/AppFooPrebuilt.apk",
  5719. })
  5720. }
  5721. func TestApexWithTestHelperApp(t *testing.T) {
  5722. ctx := testApex(t, `
  5723. apex {
  5724. name: "myapex",
  5725. key: "myapex.key",
  5726. apps: [
  5727. "TesterHelpAppFoo",
  5728. ],
  5729. updatable: false,
  5730. }
  5731. apex_key {
  5732. name: "myapex.key",
  5733. public_key: "testkey.avbpubkey",
  5734. private_key: "testkey.pem",
  5735. }
  5736. android_test_helper_app {
  5737. name: "TesterHelpAppFoo",
  5738. srcs: ["foo/bar/MyClass.java"],
  5739. apex_available: [ "myapex" ],
  5740. }
  5741. `)
  5742. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5743. apexRule := module.Rule("apexRule")
  5744. copyCmds := apexRule.Args["copy_commands"]
  5745. ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo@TEST.BUILD_ID/TesterHelpAppFoo.apk")
  5746. }
  5747. func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
  5748. // libfoo's apex_available comes from cc_defaults
  5749. testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
  5750. apex {
  5751. name: "myapex",
  5752. key: "myapex.key",
  5753. native_shared_libs: ["libfoo"],
  5754. updatable: false,
  5755. }
  5756. apex_key {
  5757. name: "myapex.key",
  5758. public_key: "testkey.avbpubkey",
  5759. private_key: "testkey.pem",
  5760. }
  5761. apex {
  5762. name: "otherapex",
  5763. key: "myapex.key",
  5764. native_shared_libs: ["libfoo"],
  5765. updatable: false,
  5766. }
  5767. cc_defaults {
  5768. name: "libfoo-defaults",
  5769. apex_available: ["otherapex"],
  5770. }
  5771. cc_library {
  5772. name: "libfoo",
  5773. defaults: ["libfoo-defaults"],
  5774. stl: "none",
  5775. system_shared_libs: [],
  5776. }`)
  5777. }
  5778. func TestApexAvailable_DirectDep(t *testing.T) {
  5779. // libfoo is not available to myapex, but only to otherapex
  5780. testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
  5781. apex {
  5782. name: "myapex",
  5783. key: "myapex.key",
  5784. native_shared_libs: ["libfoo"],
  5785. updatable: false,
  5786. }
  5787. apex_key {
  5788. name: "myapex.key",
  5789. public_key: "testkey.avbpubkey",
  5790. private_key: "testkey.pem",
  5791. }
  5792. apex {
  5793. name: "otherapex",
  5794. key: "otherapex.key",
  5795. native_shared_libs: ["libfoo"],
  5796. updatable: false,
  5797. }
  5798. apex_key {
  5799. name: "otherapex.key",
  5800. public_key: "testkey.avbpubkey",
  5801. private_key: "testkey.pem",
  5802. }
  5803. cc_library {
  5804. name: "libfoo",
  5805. stl: "none",
  5806. system_shared_libs: [],
  5807. apex_available: ["otherapex"],
  5808. }`)
  5809. }
  5810. func TestApexAvailable_IndirectDep(t *testing.T) {
  5811. // libbbaz is an indirect dep
  5812. testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
  5813. .*via tag apex\.dependencyTag\{"sharedLib"\}
  5814. .*-> libfoo.*link:shared.*
  5815. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5816. .*-> libbar.*link:shared.*
  5817. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5818. .*-> libbaz.*link:shared.*`, `
  5819. apex {
  5820. name: "myapex",
  5821. key: "myapex.key",
  5822. native_shared_libs: ["libfoo"],
  5823. updatable: false,
  5824. }
  5825. apex_key {
  5826. name: "myapex.key",
  5827. public_key: "testkey.avbpubkey",
  5828. private_key: "testkey.pem",
  5829. }
  5830. cc_library {
  5831. name: "libfoo",
  5832. stl: "none",
  5833. shared_libs: ["libbar"],
  5834. system_shared_libs: [],
  5835. apex_available: ["myapex"],
  5836. }
  5837. cc_library {
  5838. name: "libbar",
  5839. stl: "none",
  5840. shared_libs: ["libbaz"],
  5841. system_shared_libs: [],
  5842. apex_available: ["myapex"],
  5843. }
  5844. cc_library {
  5845. name: "libbaz",
  5846. stl: "none",
  5847. system_shared_libs: [],
  5848. }`)
  5849. }
  5850. func TestApexAvailable_IndirectStaticDep(t *testing.T) {
  5851. testApex(t, `
  5852. apex {
  5853. name: "myapex",
  5854. key: "myapex.key",
  5855. native_shared_libs: ["libfoo"],
  5856. updatable: false,
  5857. }
  5858. apex_key {
  5859. name: "myapex.key",
  5860. public_key: "testkey.avbpubkey",
  5861. private_key: "testkey.pem",
  5862. }
  5863. cc_library {
  5864. name: "libfoo",
  5865. stl: "none",
  5866. static_libs: ["libbar"],
  5867. system_shared_libs: [],
  5868. apex_available: ["myapex"],
  5869. }
  5870. cc_library {
  5871. name: "libbar",
  5872. stl: "none",
  5873. shared_libs: ["libbaz"],
  5874. system_shared_libs: [],
  5875. apex_available: ["myapex"],
  5876. }
  5877. cc_library {
  5878. name: "libbaz",
  5879. stl: "none",
  5880. system_shared_libs: [],
  5881. }`)
  5882. testApexError(t, `requires "libbar" that doesn't list the APEX under 'apex_available'.`, `
  5883. apex {
  5884. name: "myapex",
  5885. key: "myapex.key",
  5886. native_shared_libs: ["libfoo"],
  5887. updatable: false,
  5888. }
  5889. apex_key {
  5890. name: "myapex.key",
  5891. public_key: "testkey.avbpubkey",
  5892. private_key: "testkey.pem",
  5893. }
  5894. cc_library {
  5895. name: "libfoo",
  5896. stl: "none",
  5897. static_libs: ["libbar"],
  5898. system_shared_libs: [],
  5899. apex_available: ["myapex"],
  5900. }
  5901. cc_library {
  5902. name: "libbar",
  5903. stl: "none",
  5904. system_shared_libs: [],
  5905. }`)
  5906. }
  5907. func TestApexAvailable_InvalidApexName(t *testing.T) {
  5908. testApexError(t, "\"otherapex\" is not a valid module name", `
  5909. apex {
  5910. name: "myapex",
  5911. key: "myapex.key",
  5912. native_shared_libs: ["libfoo"],
  5913. updatable: false,
  5914. }
  5915. apex_key {
  5916. name: "myapex.key",
  5917. public_key: "testkey.avbpubkey",
  5918. private_key: "testkey.pem",
  5919. }
  5920. cc_library {
  5921. name: "libfoo",
  5922. stl: "none",
  5923. system_shared_libs: [],
  5924. apex_available: ["otherapex"],
  5925. }`)
  5926. testApex(t, `
  5927. apex {
  5928. name: "myapex",
  5929. key: "myapex.key",
  5930. native_shared_libs: ["libfoo", "libbar"],
  5931. updatable: false,
  5932. }
  5933. apex_key {
  5934. name: "myapex.key",
  5935. public_key: "testkey.avbpubkey",
  5936. private_key: "testkey.pem",
  5937. }
  5938. cc_library {
  5939. name: "libfoo",
  5940. stl: "none",
  5941. system_shared_libs: [],
  5942. runtime_libs: ["libbaz"],
  5943. apex_available: ["myapex"],
  5944. }
  5945. cc_library {
  5946. name: "libbar",
  5947. stl: "none",
  5948. system_shared_libs: [],
  5949. apex_available: ["//apex_available:anyapex"],
  5950. }
  5951. cc_library {
  5952. name: "libbaz",
  5953. stl: "none",
  5954. system_shared_libs: [],
  5955. stubs: {
  5956. versions: ["10", "20", "30"],
  5957. },
  5958. }`)
  5959. }
  5960. func TestApexAvailable_ApexAvailableNameWithVersionCodeError(t *testing.T) {
  5961. t.Run("negative variant_version produces error", func(t *testing.T) {
  5962. testApexError(t, "expected an integer between 0-9; got -1", `
  5963. apex {
  5964. name: "myapex",
  5965. key: "myapex.key",
  5966. apex_available_name: "com.android.foo",
  5967. variant_version: "-1",
  5968. updatable: false,
  5969. }
  5970. apex_key {
  5971. name: "myapex.key",
  5972. public_key: "testkey.avbpubkey",
  5973. private_key: "testkey.pem",
  5974. }
  5975. `)
  5976. })
  5977. t.Run("variant_version greater than 9 produces error", func(t *testing.T) {
  5978. testApexError(t, "expected an integer between 0-9; got 10", `
  5979. apex {
  5980. name: "myapex",
  5981. key: "myapex.key",
  5982. apex_available_name: "com.android.foo",
  5983. variant_version: "10",
  5984. updatable: false,
  5985. }
  5986. apex_key {
  5987. name: "myapex.key",
  5988. public_key: "testkey.avbpubkey",
  5989. private_key: "testkey.pem",
  5990. }
  5991. `)
  5992. })
  5993. }
  5994. func TestApexAvailable_ApexAvailableNameWithVersionCode(t *testing.T) {
  5995. context := android.GroupFixturePreparers(
  5996. android.PrepareForIntegrationTestWithAndroid,
  5997. PrepareForTestWithApexBuildComponents,
  5998. android.FixtureMergeMockFs(android.MockFS{
  5999. "system/sepolicy/apex/foo-file_contexts": nil,
  6000. "system/sepolicy/apex/bar-file_contexts": nil,
  6001. }),
  6002. )
  6003. result := context.RunTestWithBp(t, `
  6004. apex {
  6005. name: "foo",
  6006. key: "myapex.key",
  6007. apex_available_name: "com.android.foo",
  6008. variant_version: "0",
  6009. updatable: false,
  6010. }
  6011. apex {
  6012. name: "bar",
  6013. key: "myapex.key",
  6014. apex_available_name: "com.android.foo",
  6015. variant_version: "3",
  6016. updatable: false,
  6017. }
  6018. apex_key {
  6019. name: "myapex.key",
  6020. public_key: "testkey.avbpubkey",
  6021. private_key: "testkey.pem",
  6022. }
  6023. `)
  6024. fooManifestRule := result.ModuleForTests("foo", "android_common_foo_image").Rule("apexManifestRule")
  6025. fooExpectedDefaultVersion := android.DefaultUpdatableModuleVersion
  6026. fooActualDefaultVersion := fooManifestRule.Args["default_version"]
  6027. if fooActualDefaultVersion != fooExpectedDefaultVersion {
  6028. t.Errorf("expected to find defaultVersion %q; got %q", fooExpectedDefaultVersion, fooActualDefaultVersion)
  6029. }
  6030. barManifestRule := result.ModuleForTests("bar", "android_common_bar_image").Rule("apexManifestRule")
  6031. defaultVersionInt, _ := strconv.Atoi(android.DefaultUpdatableModuleVersion)
  6032. barExpectedDefaultVersion := fmt.Sprint(defaultVersionInt + 3)
  6033. barActualDefaultVersion := barManifestRule.Args["default_version"]
  6034. if barActualDefaultVersion != barExpectedDefaultVersion {
  6035. t.Errorf("expected to find defaultVersion %q; got %q", barExpectedDefaultVersion, barActualDefaultVersion)
  6036. }
  6037. }
  6038. func TestApexAvailable_ApexAvailableName(t *testing.T) {
  6039. t.Run("using name of apex that sets apex_available_name is not allowed", func(t *testing.T) {
  6040. testApexError(t, "Consider adding \"myapex\" to 'apex_available' property of \"AppFoo\"", `
  6041. apex {
  6042. name: "myapex_sminus",
  6043. key: "myapex.key",
  6044. apps: ["AppFoo"],
  6045. apex_available_name: "myapex",
  6046. updatable: false,
  6047. }
  6048. apex {
  6049. name: "myapex",
  6050. key: "myapex.key",
  6051. apps: ["AppFoo"],
  6052. updatable: false,
  6053. }
  6054. apex_key {
  6055. name: "myapex.key",
  6056. public_key: "testkey.avbpubkey",
  6057. private_key: "testkey.pem",
  6058. }
  6059. android_app {
  6060. name: "AppFoo",
  6061. srcs: ["foo/bar/MyClass.java"],
  6062. sdk_version: "none",
  6063. system_modules: "none",
  6064. apex_available: [ "myapex_sminus" ],
  6065. }`,
  6066. android.FixtureMergeMockFs(android.MockFS{
  6067. "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
  6068. }),
  6069. )
  6070. })
  6071. t.Run("apex_available_name allows module to be used in two different apexes", func(t *testing.T) {
  6072. testApex(t, `
  6073. apex {
  6074. name: "myapex_sminus",
  6075. key: "myapex.key",
  6076. apps: ["AppFoo"],
  6077. apex_available_name: "myapex",
  6078. updatable: false,
  6079. }
  6080. apex {
  6081. name: "myapex",
  6082. key: "myapex.key",
  6083. apps: ["AppFoo"],
  6084. updatable: false,
  6085. }
  6086. apex_key {
  6087. name: "myapex.key",
  6088. public_key: "testkey.avbpubkey",
  6089. private_key: "testkey.pem",
  6090. }
  6091. android_app {
  6092. name: "AppFoo",
  6093. srcs: ["foo/bar/MyClass.java"],
  6094. sdk_version: "none",
  6095. system_modules: "none",
  6096. apex_available: [ "myapex" ],
  6097. }`,
  6098. android.FixtureMergeMockFs(android.MockFS{
  6099. "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
  6100. }),
  6101. )
  6102. })
  6103. t.Run("override_apexes work with apex_available_name", func(t *testing.T) {
  6104. testApex(t, `
  6105. override_apex {
  6106. name: "myoverrideapex_sminus",
  6107. base: "myapex_sminus",
  6108. key: "myapex.key",
  6109. apps: ["AppFooOverride"],
  6110. }
  6111. override_apex {
  6112. name: "myoverrideapex",
  6113. base: "myapex",
  6114. key: "myapex.key",
  6115. apps: ["AppFooOverride"],
  6116. }
  6117. apex {
  6118. name: "myapex_sminus",
  6119. key: "myapex.key",
  6120. apps: ["AppFoo"],
  6121. apex_available_name: "myapex",
  6122. updatable: false,
  6123. }
  6124. apex {
  6125. name: "myapex",
  6126. key: "myapex.key",
  6127. apps: ["AppFoo"],
  6128. updatable: false,
  6129. }
  6130. apex_key {
  6131. name: "myapex.key",
  6132. public_key: "testkey.avbpubkey",
  6133. private_key: "testkey.pem",
  6134. }
  6135. android_app {
  6136. name: "AppFooOverride",
  6137. srcs: ["foo/bar/MyClass.java"],
  6138. sdk_version: "none",
  6139. system_modules: "none",
  6140. apex_available: [ "myapex" ],
  6141. }
  6142. android_app {
  6143. name: "AppFoo",
  6144. srcs: ["foo/bar/MyClass.java"],
  6145. sdk_version: "none",
  6146. system_modules: "none",
  6147. apex_available: [ "myapex" ],
  6148. }`,
  6149. android.FixtureMergeMockFs(android.MockFS{
  6150. "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
  6151. }),
  6152. )
  6153. })
  6154. }
  6155. func TestApexAvailable_ApexAvailableNameWithOverrides(t *testing.T) {
  6156. context := android.GroupFixturePreparers(
  6157. android.PrepareForIntegrationTestWithAndroid,
  6158. PrepareForTestWithApexBuildComponents,
  6159. java.PrepareForTestWithDexpreopt,
  6160. android.FixtureMergeMockFs(android.MockFS{
  6161. "system/sepolicy/apex/myapex-file_contexts": nil,
  6162. "system/sepolicy/apex/myapex_sminus-file_contexts": nil,
  6163. }),
  6164. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6165. variables.BuildId = proptools.StringPtr("buildid")
  6166. }),
  6167. )
  6168. context.RunTestWithBp(t, `
  6169. override_apex {
  6170. name: "myoverrideapex_sminus",
  6171. base: "myapex_sminus",
  6172. }
  6173. override_apex {
  6174. name: "myoverrideapex",
  6175. base: "myapex",
  6176. }
  6177. apex {
  6178. name: "myapex",
  6179. key: "myapex.key",
  6180. apps: ["AppFoo"],
  6181. updatable: false,
  6182. }
  6183. apex {
  6184. name: "myapex_sminus",
  6185. apex_available_name: "myapex",
  6186. key: "myapex.key",
  6187. apps: ["AppFoo_sminus"],
  6188. updatable: false,
  6189. }
  6190. apex_key {
  6191. name: "myapex.key",
  6192. public_key: "testkey.avbpubkey",
  6193. private_key: "testkey.pem",
  6194. }
  6195. android_app {
  6196. name: "AppFoo",
  6197. srcs: ["foo/bar/MyClass.java"],
  6198. sdk_version: "none",
  6199. system_modules: "none",
  6200. apex_available: [ "myapex" ],
  6201. }
  6202. android_app {
  6203. name: "AppFoo_sminus",
  6204. srcs: ["foo/bar/MyClass.java"],
  6205. sdk_version: "none",
  6206. min_sdk_version: "29",
  6207. system_modules: "none",
  6208. apex_available: [ "myapex" ],
  6209. }`)
  6210. }
  6211. func TestApexAvailable_CheckForPlatform(t *testing.T) {
  6212. ctx := testApex(t, `
  6213. apex {
  6214. name: "myapex",
  6215. key: "myapex.key",
  6216. native_shared_libs: ["libbar", "libbaz"],
  6217. updatable: false,
  6218. }
  6219. apex_key {
  6220. name: "myapex.key",
  6221. public_key: "testkey.avbpubkey",
  6222. private_key: "testkey.pem",
  6223. }
  6224. cc_library {
  6225. name: "libfoo",
  6226. stl: "none",
  6227. system_shared_libs: [],
  6228. shared_libs: ["libbar"],
  6229. apex_available: ["//apex_available:platform"],
  6230. }
  6231. cc_library {
  6232. name: "libfoo2",
  6233. stl: "none",
  6234. system_shared_libs: [],
  6235. shared_libs: ["libbaz"],
  6236. apex_available: ["//apex_available:platform"],
  6237. }
  6238. cc_library {
  6239. name: "libbar",
  6240. stl: "none",
  6241. system_shared_libs: [],
  6242. apex_available: ["myapex"],
  6243. }
  6244. cc_library {
  6245. name: "libbaz",
  6246. stl: "none",
  6247. system_shared_libs: [],
  6248. apex_available: ["myapex"],
  6249. stubs: {
  6250. versions: ["1"],
  6251. },
  6252. }`)
  6253. // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
  6254. // because it depends on libbar which isn't available to platform
  6255. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  6256. if libfoo.NotAvailableForPlatform() != true {
  6257. t.Errorf("%q shouldn't be available to platform", libfoo.String())
  6258. }
  6259. // libfoo2 however can be available to platform because it depends on libbaz which provides
  6260. // stubs
  6261. libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  6262. if libfoo2.NotAvailableForPlatform() == true {
  6263. t.Errorf("%q should be available to platform", libfoo2.String())
  6264. }
  6265. }
  6266. func TestApexAvailable_CreatedForApex(t *testing.T) {
  6267. ctx := testApex(t, `
  6268. apex {
  6269. name: "myapex",
  6270. key: "myapex.key",
  6271. native_shared_libs: ["libfoo"],
  6272. updatable: false,
  6273. }
  6274. apex_key {
  6275. name: "myapex.key",
  6276. public_key: "testkey.avbpubkey",
  6277. private_key: "testkey.pem",
  6278. }
  6279. cc_library {
  6280. name: "libfoo",
  6281. stl: "none",
  6282. system_shared_libs: [],
  6283. apex_available: ["myapex"],
  6284. static: {
  6285. apex_available: ["//apex_available:platform"],
  6286. },
  6287. }`)
  6288. libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  6289. if libfooShared.NotAvailableForPlatform() != true {
  6290. t.Errorf("%q shouldn't be available to platform", libfooShared.String())
  6291. }
  6292. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
  6293. if libfooStatic.NotAvailableForPlatform() != false {
  6294. t.Errorf("%q should be available to platform", libfooStatic.String())
  6295. }
  6296. }
  6297. func TestOverrideApex(t *testing.T) {
  6298. ctx := testApex(t, `
  6299. apex {
  6300. name: "myapex",
  6301. key: "myapex.key",
  6302. apps: ["app"],
  6303. bpfs: ["bpf"],
  6304. prebuilts: ["myetc"],
  6305. overrides: ["oldapex"],
  6306. updatable: false,
  6307. }
  6308. override_apex {
  6309. name: "override_myapex",
  6310. base: "myapex",
  6311. apps: ["override_app"],
  6312. bpfs: ["overrideBpf"],
  6313. prebuilts: ["override_myetc"],
  6314. overrides: ["unknownapex"],
  6315. logging_parent: "com.foo.bar",
  6316. package_name: "test.overridden.package",
  6317. key: "mynewapex.key",
  6318. certificate: ":myapex.certificate",
  6319. }
  6320. apex_key {
  6321. name: "myapex.key",
  6322. public_key: "testkey.avbpubkey",
  6323. private_key: "testkey.pem",
  6324. }
  6325. apex_key {
  6326. name: "mynewapex.key",
  6327. public_key: "testkey2.avbpubkey",
  6328. private_key: "testkey2.pem",
  6329. }
  6330. android_app_certificate {
  6331. name: "myapex.certificate",
  6332. certificate: "testkey",
  6333. }
  6334. android_app {
  6335. name: "app",
  6336. srcs: ["foo/bar/MyClass.java"],
  6337. package_name: "foo",
  6338. sdk_version: "none",
  6339. system_modules: "none",
  6340. apex_available: [ "myapex" ],
  6341. }
  6342. override_android_app {
  6343. name: "override_app",
  6344. base: "app",
  6345. package_name: "bar",
  6346. }
  6347. bpf {
  6348. name: "bpf",
  6349. srcs: ["bpf.c"],
  6350. }
  6351. bpf {
  6352. name: "overrideBpf",
  6353. srcs: ["overrideBpf.c"],
  6354. }
  6355. prebuilt_etc {
  6356. name: "myetc",
  6357. src: "myprebuilt",
  6358. }
  6359. prebuilt_etc {
  6360. name: "override_myetc",
  6361. src: "override_myprebuilt",
  6362. }
  6363. `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
  6364. originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
  6365. overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
  6366. if originalVariant.GetOverriddenBy() != "" {
  6367. t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
  6368. }
  6369. if overriddenVariant.GetOverriddenBy() != "override_myapex" {
  6370. t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
  6371. }
  6372. module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
  6373. apexRule := module.Rule("apexRule")
  6374. copyCmds := apexRule.Args["copy_commands"]
  6375. ensureNotContains(t, copyCmds, "image.apex/app/app@TEST.BUILD_ID/app.apk")
  6376. ensureContains(t, copyCmds, "image.apex/app/override_app@TEST.BUILD_ID/override_app.apk")
  6377. ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
  6378. ensureContains(t, copyCmds, "image.apex/etc/bpf/overrideBpf.o")
  6379. ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
  6380. ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
  6381. apexBundle := module.Module().(*apexBundle)
  6382. name := apexBundle.Name()
  6383. if name != "override_myapex" {
  6384. t.Errorf("name should be \"override_myapex\", but was %q", name)
  6385. }
  6386. if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
  6387. t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
  6388. }
  6389. optFlags := apexRule.Args["opt_flags"]
  6390. ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
  6391. ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
  6392. signApkRule := module.Rule("signapk")
  6393. ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
  6394. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6395. var builder strings.Builder
  6396. data.Custom(&builder, name, "TARGET_", "", data)
  6397. androidMk := builder.String()
  6398. ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
  6399. ensureContains(t, androidMk, "LOCAL_MODULE := overrideBpf.o.override_myapex")
  6400. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
  6401. ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
  6402. ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
  6403. ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
  6404. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
  6405. ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
  6406. }
  6407. func TestMinSdkVersionOverride(t *testing.T) {
  6408. // Override from 29 to 31
  6409. minSdkOverride31 := "31"
  6410. ctx := testApex(t, `
  6411. apex {
  6412. name: "myapex",
  6413. key: "myapex.key",
  6414. native_shared_libs: ["mylib"],
  6415. updatable: true,
  6416. min_sdk_version: "29"
  6417. }
  6418. override_apex {
  6419. name: "override_myapex",
  6420. base: "myapex",
  6421. logging_parent: "com.foo.bar",
  6422. package_name: "test.overridden.package"
  6423. }
  6424. apex_key {
  6425. name: "myapex.key",
  6426. public_key: "testkey.avbpubkey",
  6427. private_key: "testkey.pem",
  6428. }
  6429. cc_library {
  6430. name: "mylib",
  6431. srcs: ["mylib.cpp"],
  6432. runtime_libs: ["libbar"],
  6433. system_shared_libs: [],
  6434. stl: "none",
  6435. apex_available: [ "myapex" ],
  6436. min_sdk_version: "apex_inherit"
  6437. }
  6438. cc_library {
  6439. name: "libbar",
  6440. srcs: ["mylib.cpp"],
  6441. system_shared_libs: [],
  6442. stl: "none",
  6443. apex_available: [ "myapex" ],
  6444. min_sdk_version: "apex_inherit"
  6445. }
  6446. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride31))
  6447. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  6448. copyCmds := apexRule.Args["copy_commands"]
  6449. // Ensure that direct non-stubs dep is always included
  6450. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  6451. // Ensure that runtime_libs dep in included
  6452. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  6453. // Ensure libraries target overridden min_sdk_version value
  6454. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  6455. }
  6456. func TestMinSdkVersionOverrideToLowerVersionNoOp(t *testing.T) {
  6457. // Attempt to override from 31 to 29, should be a NOOP
  6458. minSdkOverride29 := "29"
  6459. ctx := testApex(t, `
  6460. apex {
  6461. name: "myapex",
  6462. key: "myapex.key",
  6463. native_shared_libs: ["mylib"],
  6464. updatable: true,
  6465. min_sdk_version: "31"
  6466. }
  6467. override_apex {
  6468. name: "override_myapex",
  6469. base: "myapex",
  6470. logging_parent: "com.foo.bar",
  6471. package_name: "test.overridden.package"
  6472. }
  6473. apex_key {
  6474. name: "myapex.key",
  6475. public_key: "testkey.avbpubkey",
  6476. private_key: "testkey.pem",
  6477. }
  6478. cc_library {
  6479. name: "mylib",
  6480. srcs: ["mylib.cpp"],
  6481. runtime_libs: ["libbar"],
  6482. system_shared_libs: [],
  6483. stl: "none",
  6484. apex_available: [ "myapex" ],
  6485. min_sdk_version: "apex_inherit"
  6486. }
  6487. cc_library {
  6488. name: "libbar",
  6489. srcs: ["mylib.cpp"],
  6490. system_shared_libs: [],
  6491. stl: "none",
  6492. apex_available: [ "myapex" ],
  6493. min_sdk_version: "apex_inherit"
  6494. }
  6495. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride29))
  6496. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  6497. copyCmds := apexRule.Args["copy_commands"]
  6498. // Ensure that direct non-stubs dep is always included
  6499. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  6500. // Ensure that runtime_libs dep in included
  6501. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  6502. // Ensure libraries target the original min_sdk_version value rather than the overridden
  6503. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  6504. }
  6505. func TestLegacyAndroid10Support(t *testing.T) {
  6506. ctx := testApex(t, `
  6507. apex {
  6508. name: "myapex",
  6509. key: "myapex.key",
  6510. native_shared_libs: ["mylib"],
  6511. min_sdk_version: "29",
  6512. }
  6513. apex_key {
  6514. name: "myapex.key",
  6515. public_key: "testkey.avbpubkey",
  6516. private_key: "testkey.pem",
  6517. }
  6518. cc_library {
  6519. name: "mylib",
  6520. srcs: ["mylib.cpp"],
  6521. stl: "libc++",
  6522. system_shared_libs: [],
  6523. apex_available: [ "myapex" ],
  6524. min_sdk_version: "29",
  6525. }
  6526. `, withUnbundledBuild)
  6527. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  6528. args := module.Rule("apexRule").Args
  6529. ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
  6530. ensureNotContains(t, args["opt_flags"], "--no_hashtree")
  6531. // The copies of the libraries in the apex should have one more dependency than
  6532. // the ones outside the apex, namely the unwinder. Ideally we should check
  6533. // the dependency names directly here but for some reason the names are blank in
  6534. // this test.
  6535. for _, lib := range []string{"libc++", "mylib"} {
  6536. apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
  6537. nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
  6538. if len(apexImplicits) != len(nonApexImplicits)+1 {
  6539. t.Errorf("%q missing unwinder dep", lib)
  6540. }
  6541. }
  6542. }
  6543. var filesForSdkLibrary = android.MockFS{
  6544. "api/current.txt": nil,
  6545. "api/removed.txt": nil,
  6546. "api/system-current.txt": nil,
  6547. "api/system-removed.txt": nil,
  6548. "api/test-current.txt": nil,
  6549. "api/test-removed.txt": nil,
  6550. "100/public/api/foo.txt": nil,
  6551. "100/public/api/foo-removed.txt": nil,
  6552. "100/system/api/foo.txt": nil,
  6553. "100/system/api/foo-removed.txt": nil,
  6554. // For java_sdk_library_import
  6555. "a.jar": nil,
  6556. }
  6557. func TestJavaSDKLibrary(t *testing.T) {
  6558. ctx := testApex(t, `
  6559. apex {
  6560. name: "myapex",
  6561. key: "myapex.key",
  6562. java_libs: ["foo"],
  6563. updatable: false,
  6564. }
  6565. apex_key {
  6566. name: "myapex.key",
  6567. public_key: "testkey.avbpubkey",
  6568. private_key: "testkey.pem",
  6569. }
  6570. java_sdk_library {
  6571. name: "foo",
  6572. srcs: ["a.java"],
  6573. api_packages: ["foo"],
  6574. apex_available: [ "myapex" ],
  6575. }
  6576. prebuilt_apis {
  6577. name: "sdk",
  6578. api_dirs: ["100"],
  6579. }
  6580. `, withFiles(filesForSdkLibrary))
  6581. // java_sdk_library installs both impl jar and permission XML
  6582. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6583. "javalib/foo.jar",
  6584. "etc/permissions/foo.xml",
  6585. })
  6586. // Permission XML should point to the activated path of impl jar of java_sdk_library
  6587. sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
  6588. ensureMatches(t, sdkLibrary.RuleParams.Command, `<library\\n\s+name=\\\"foo\\\"\\n\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"`)
  6589. }
  6590. func TestJavaSDKLibrary_WithinApex(t *testing.T) {
  6591. ctx := testApex(t, `
  6592. apex {
  6593. name: "myapex",
  6594. key: "myapex.key",
  6595. java_libs: ["foo", "bar"],
  6596. updatable: false,
  6597. }
  6598. apex_key {
  6599. name: "myapex.key",
  6600. public_key: "testkey.avbpubkey",
  6601. private_key: "testkey.pem",
  6602. }
  6603. java_sdk_library {
  6604. name: "foo",
  6605. srcs: ["a.java"],
  6606. api_packages: ["foo"],
  6607. apex_available: ["myapex"],
  6608. sdk_version: "none",
  6609. system_modules: "none",
  6610. }
  6611. java_library {
  6612. name: "bar",
  6613. srcs: ["a.java"],
  6614. libs: ["foo"],
  6615. apex_available: ["myapex"],
  6616. sdk_version: "none",
  6617. system_modules: "none",
  6618. }
  6619. prebuilt_apis {
  6620. name: "sdk",
  6621. api_dirs: ["100"],
  6622. }
  6623. `, withFiles(filesForSdkLibrary))
  6624. // java_sdk_library installs both impl jar and permission XML
  6625. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6626. "javalib/bar.jar",
  6627. "javalib/foo.jar",
  6628. "etc/permissions/foo.xml",
  6629. })
  6630. // The bar library should depend on the implementation jar.
  6631. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  6632. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6633. t.Errorf("expected %q, found %#q", expected, actual)
  6634. }
  6635. }
  6636. func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
  6637. ctx := testApex(t, `
  6638. apex {
  6639. name: "myapex",
  6640. key: "myapex.key",
  6641. java_libs: ["foo"],
  6642. updatable: false,
  6643. }
  6644. apex_key {
  6645. name: "myapex.key",
  6646. public_key: "testkey.avbpubkey",
  6647. private_key: "testkey.pem",
  6648. }
  6649. java_sdk_library {
  6650. name: "foo",
  6651. srcs: ["a.java"],
  6652. api_packages: ["foo"],
  6653. apex_available: ["myapex"],
  6654. sdk_version: "none",
  6655. system_modules: "none",
  6656. }
  6657. java_library {
  6658. name: "bar",
  6659. srcs: ["a.java"],
  6660. libs: ["foo"],
  6661. sdk_version: "none",
  6662. system_modules: "none",
  6663. }
  6664. prebuilt_apis {
  6665. name: "sdk",
  6666. api_dirs: ["100"],
  6667. }
  6668. `, withFiles(filesForSdkLibrary))
  6669. // java_sdk_library installs both impl jar and permission XML
  6670. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6671. "javalib/foo.jar",
  6672. "etc/permissions/foo.xml",
  6673. })
  6674. // The bar library should depend on the stubs jar.
  6675. barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
  6676. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6677. t.Errorf("expected %q, found %#q", expected, actual)
  6678. }
  6679. }
  6680. func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
  6681. ctx := testApex(t, `
  6682. prebuilt_apis {
  6683. name: "sdk",
  6684. api_dirs: ["100"],
  6685. }`,
  6686. withFiles(map[string][]byte{
  6687. "apex/a.java": nil,
  6688. "apex/apex_manifest.json": nil,
  6689. "apex/Android.bp": []byte(`
  6690. package {
  6691. default_visibility: ["//visibility:private"],
  6692. }
  6693. apex {
  6694. name: "myapex",
  6695. key: "myapex.key",
  6696. java_libs: ["foo", "bar"],
  6697. updatable: false,
  6698. }
  6699. apex_key {
  6700. name: "myapex.key",
  6701. public_key: "testkey.avbpubkey",
  6702. private_key: "testkey.pem",
  6703. }
  6704. java_library {
  6705. name: "bar",
  6706. srcs: ["a.java"],
  6707. libs: ["foo"],
  6708. apex_available: ["myapex"],
  6709. sdk_version: "none",
  6710. system_modules: "none",
  6711. }
  6712. `),
  6713. "source/a.java": nil,
  6714. "source/api/current.txt": nil,
  6715. "source/api/removed.txt": nil,
  6716. "source/Android.bp": []byte(`
  6717. package {
  6718. default_visibility: ["//visibility:private"],
  6719. }
  6720. java_sdk_library {
  6721. name: "foo",
  6722. visibility: ["//apex"],
  6723. srcs: ["a.java"],
  6724. api_packages: ["foo"],
  6725. apex_available: ["myapex"],
  6726. sdk_version: "none",
  6727. system_modules: "none",
  6728. public: {
  6729. enabled: true,
  6730. },
  6731. }
  6732. `),
  6733. "prebuilt/a.jar": nil,
  6734. "prebuilt/Android.bp": []byte(`
  6735. package {
  6736. default_visibility: ["//visibility:private"],
  6737. }
  6738. java_sdk_library_import {
  6739. name: "foo",
  6740. visibility: ["//apex", "//source"],
  6741. apex_available: ["myapex"],
  6742. prefer: true,
  6743. public: {
  6744. jars: ["a.jar"],
  6745. },
  6746. }
  6747. `),
  6748. }), withFiles(filesForSdkLibrary),
  6749. )
  6750. // java_sdk_library installs both impl jar and permission XML
  6751. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6752. "javalib/bar.jar",
  6753. "javalib/foo.jar",
  6754. "etc/permissions/foo.xml",
  6755. })
  6756. // The bar library should depend on the implementation jar.
  6757. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  6758. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6759. t.Errorf("expected %q, found %#q", expected, actual)
  6760. }
  6761. }
  6762. func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
  6763. testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
  6764. apex {
  6765. name: "myapex",
  6766. key: "myapex.key",
  6767. java_libs: ["foo"],
  6768. updatable: false,
  6769. }
  6770. apex_key {
  6771. name: "myapex.key",
  6772. public_key: "testkey.avbpubkey",
  6773. private_key: "testkey.pem",
  6774. }
  6775. java_sdk_library_import {
  6776. name: "foo",
  6777. apex_available: ["myapex"],
  6778. prefer: true,
  6779. public: {
  6780. jars: ["a.jar"],
  6781. },
  6782. }
  6783. `, withFiles(filesForSdkLibrary))
  6784. }
  6785. func TestCompatConfig(t *testing.T) {
  6786. result := android.GroupFixturePreparers(
  6787. prepareForApexTest,
  6788. java.PrepareForTestWithPlatformCompatConfig,
  6789. ).RunTestWithBp(t, `
  6790. apex {
  6791. name: "myapex",
  6792. key: "myapex.key",
  6793. compat_configs: ["myjar-platform-compat-config"],
  6794. java_libs: ["myjar"],
  6795. updatable: false,
  6796. }
  6797. apex_key {
  6798. name: "myapex.key",
  6799. public_key: "testkey.avbpubkey",
  6800. private_key: "testkey.pem",
  6801. }
  6802. platform_compat_config {
  6803. name: "myjar-platform-compat-config",
  6804. src: ":myjar",
  6805. }
  6806. java_library {
  6807. name: "myjar",
  6808. srcs: ["foo/bar/MyClass.java"],
  6809. sdk_version: "none",
  6810. system_modules: "none",
  6811. apex_available: [ "myapex" ],
  6812. }
  6813. // Make sure that a preferred prebuilt does not affect the apex contents.
  6814. prebuilt_platform_compat_config {
  6815. name: "myjar-platform-compat-config",
  6816. metadata: "compat-config/metadata.xml",
  6817. prefer: true,
  6818. }
  6819. `)
  6820. ctx := result.TestContext
  6821. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6822. "etc/compatconfig/myjar-platform-compat-config.xml",
  6823. "javalib/myjar.jar",
  6824. })
  6825. }
  6826. func TestNoDupeApexFiles(t *testing.T) {
  6827. android.GroupFixturePreparers(
  6828. android.PrepareForTestWithAndroidBuildComponents,
  6829. PrepareForTestWithApexBuildComponents,
  6830. prepareForTestWithMyapex,
  6831. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  6832. ).
  6833. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern("is provided by two different files")).
  6834. RunTestWithBp(t, `
  6835. apex {
  6836. name: "myapex",
  6837. key: "myapex.key",
  6838. prebuilts: ["foo", "bar"],
  6839. updatable: false,
  6840. }
  6841. apex_key {
  6842. name: "myapex.key",
  6843. public_key: "testkey.avbpubkey",
  6844. private_key: "testkey.pem",
  6845. }
  6846. prebuilt_etc {
  6847. name: "foo",
  6848. src: "myprebuilt",
  6849. filename_from_src: true,
  6850. }
  6851. prebuilt_etc {
  6852. name: "bar",
  6853. src: "myprebuilt",
  6854. filename_from_src: true,
  6855. }
  6856. `)
  6857. }
  6858. func TestRejectNonInstallableJavaLibrary(t *testing.T) {
  6859. testApexError(t, `"myjar" is not configured to be compiled into dex`, `
  6860. apex {
  6861. name: "myapex",
  6862. key: "myapex.key",
  6863. java_libs: ["myjar"],
  6864. updatable: false,
  6865. }
  6866. apex_key {
  6867. name: "myapex.key",
  6868. public_key: "testkey.avbpubkey",
  6869. private_key: "testkey.pem",
  6870. }
  6871. java_library {
  6872. name: "myjar",
  6873. srcs: ["foo/bar/MyClass.java"],
  6874. sdk_version: "none",
  6875. system_modules: "none",
  6876. compile_dex: false,
  6877. apex_available: ["myapex"],
  6878. }
  6879. `)
  6880. }
  6881. func TestCarryRequiredModuleNames(t *testing.T) {
  6882. ctx := testApex(t, `
  6883. apex {
  6884. name: "myapex",
  6885. key: "myapex.key",
  6886. native_shared_libs: ["mylib"],
  6887. updatable: false,
  6888. }
  6889. apex_key {
  6890. name: "myapex.key",
  6891. public_key: "testkey.avbpubkey",
  6892. private_key: "testkey.pem",
  6893. }
  6894. cc_library {
  6895. name: "mylib",
  6896. srcs: ["mylib.cpp"],
  6897. system_shared_libs: [],
  6898. stl: "none",
  6899. required: ["a", "b"],
  6900. host_required: ["c", "d"],
  6901. target_required: ["e", "f"],
  6902. apex_available: [ "myapex" ],
  6903. }
  6904. `)
  6905. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6906. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6907. name := apexBundle.BaseModuleName()
  6908. prefix := "TARGET_"
  6909. var builder strings.Builder
  6910. data.Custom(&builder, name, prefix, "", data)
  6911. androidMk := builder.String()
  6912. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 a b\n")
  6913. ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES := c d\n")
  6914. ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES := e f\n")
  6915. }
  6916. func TestSymlinksFromApexToSystem(t *testing.T) {
  6917. bp := `
  6918. apex {
  6919. name: "myapex",
  6920. key: "myapex.key",
  6921. native_shared_libs: ["mylib"],
  6922. java_libs: ["myjar"],
  6923. updatable: false,
  6924. }
  6925. apex {
  6926. name: "myapex.updatable",
  6927. key: "myapex.key",
  6928. native_shared_libs: ["mylib"],
  6929. java_libs: ["myjar"],
  6930. updatable: true,
  6931. min_sdk_version: "33",
  6932. }
  6933. apex_key {
  6934. name: "myapex.key",
  6935. public_key: "testkey.avbpubkey",
  6936. private_key: "testkey.pem",
  6937. }
  6938. cc_library {
  6939. name: "mylib",
  6940. srcs: ["mylib.cpp"],
  6941. shared_libs: [
  6942. "myotherlib",
  6943. "myotherlib_ext",
  6944. ],
  6945. system_shared_libs: [],
  6946. stl: "none",
  6947. apex_available: [
  6948. "myapex",
  6949. "myapex.updatable",
  6950. "//apex_available:platform",
  6951. ],
  6952. min_sdk_version: "33",
  6953. }
  6954. cc_library {
  6955. name: "myotherlib",
  6956. srcs: ["mylib.cpp"],
  6957. system_shared_libs: [],
  6958. stl: "none",
  6959. apex_available: [
  6960. "myapex",
  6961. "myapex.updatable",
  6962. "//apex_available:platform",
  6963. ],
  6964. min_sdk_version: "33",
  6965. }
  6966. cc_library {
  6967. name: "myotherlib_ext",
  6968. srcs: ["mylib.cpp"],
  6969. system_shared_libs: [],
  6970. system_ext_specific: true,
  6971. stl: "none",
  6972. apex_available: [
  6973. "myapex",
  6974. "myapex.updatable",
  6975. "//apex_available:platform",
  6976. ],
  6977. min_sdk_version: "33",
  6978. }
  6979. java_library {
  6980. name: "myjar",
  6981. srcs: ["foo/bar/MyClass.java"],
  6982. sdk_version: "none",
  6983. system_modules: "none",
  6984. libs: ["myotherjar"],
  6985. apex_available: [
  6986. "myapex",
  6987. "myapex.updatable",
  6988. "//apex_available:platform",
  6989. ],
  6990. min_sdk_version: "33",
  6991. }
  6992. java_library {
  6993. name: "myotherjar",
  6994. srcs: ["foo/bar/MyClass.java"],
  6995. sdk_version: "none",
  6996. system_modules: "none",
  6997. apex_available: [
  6998. "myapex",
  6999. "myapex.updatable",
  7000. "//apex_available:platform",
  7001. ],
  7002. min_sdk_version: "33",
  7003. }
  7004. `
  7005. ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
  7006. for _, f := range files {
  7007. if f.path == file {
  7008. if f.isLink {
  7009. t.Errorf("%q is not a real file", file)
  7010. }
  7011. return
  7012. }
  7013. }
  7014. t.Errorf("%q is not found", file)
  7015. }
  7016. ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string, target string) {
  7017. for _, f := range files {
  7018. if f.path == file {
  7019. if !f.isLink {
  7020. t.Errorf("%q is not a symlink", file)
  7021. }
  7022. if f.src != target {
  7023. t.Errorf("expected symlink target to be %q, got %q", target, f.src)
  7024. }
  7025. return
  7026. }
  7027. }
  7028. t.Errorf("%q is not found", file)
  7029. }
  7030. // For unbundled build, symlink shouldn't exist regardless of whether an APEX
  7031. // is updatable or not
  7032. ctx := testApex(t, bp, withUnbundledBuild)
  7033. files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
  7034. ensureRealfileExists(t, files, "javalib/myjar.jar")
  7035. ensureRealfileExists(t, files, "lib64/mylib.so")
  7036. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  7037. ensureRealfileExists(t, files, "lib64/myotherlib_ext.so")
  7038. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  7039. ensureRealfileExists(t, files, "javalib/myjar.jar")
  7040. ensureRealfileExists(t, files, "lib64/mylib.so")
  7041. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  7042. ensureRealfileExists(t, files, "lib64/myotherlib_ext.so")
  7043. // For bundled build, symlink to the system for the non-updatable APEXes only
  7044. ctx = testApex(t, bp)
  7045. files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
  7046. ensureRealfileExists(t, files, "javalib/myjar.jar")
  7047. ensureRealfileExists(t, files, "lib64/mylib.so")
  7048. ensureSymlinkExists(t, files, "lib64/myotherlib.so", "/system/lib64/myotherlib.so") // this is symlink
  7049. ensureSymlinkExists(t, files, "lib64/myotherlib_ext.so", "/system_ext/lib64/myotherlib_ext.so") // this is symlink
  7050. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  7051. ensureRealfileExists(t, files, "javalib/myjar.jar")
  7052. ensureRealfileExists(t, files, "lib64/mylib.so")
  7053. ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
  7054. ensureRealfileExists(t, files, "lib64/myotherlib_ext.so") // this is a real file
  7055. }
  7056. func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
  7057. ctx := testApex(t, `
  7058. apex {
  7059. name: "myapex",
  7060. key: "myapex.key",
  7061. native_shared_libs: ["mylib"],
  7062. updatable: false,
  7063. }
  7064. apex_key {
  7065. name: "myapex.key",
  7066. public_key: "testkey.avbpubkey",
  7067. private_key: "testkey.pem",
  7068. }
  7069. cc_library_shared {
  7070. name: "mylib",
  7071. srcs: ["mylib.cpp"],
  7072. shared_libs: ["myotherlib"],
  7073. system_shared_libs: [],
  7074. stl: "none",
  7075. apex_available: [
  7076. "myapex",
  7077. "//apex_available:platform",
  7078. ],
  7079. }
  7080. cc_prebuilt_library_shared {
  7081. name: "myotherlib",
  7082. srcs: ["prebuilt.so"],
  7083. system_shared_libs: [],
  7084. stl: "none",
  7085. apex_available: [
  7086. "myapex",
  7087. "//apex_available:platform",
  7088. ],
  7089. }
  7090. `)
  7091. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7092. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  7093. var builder strings.Builder
  7094. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  7095. androidMk := builder.String()
  7096. // `myotherlib` is added to `myapex` as symlink
  7097. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  7098. ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
  7099. ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
  7100. // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
  7101. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 myotherlib:64\n")
  7102. }
  7103. func TestApexWithJniLibs(t *testing.T) {
  7104. ctx := testApex(t, `
  7105. apex {
  7106. name: "myapex",
  7107. key: "myapex.key",
  7108. jni_libs: ["mylib", "libfoo.rust"],
  7109. updatable: false,
  7110. }
  7111. apex_key {
  7112. name: "myapex.key",
  7113. public_key: "testkey.avbpubkey",
  7114. private_key: "testkey.pem",
  7115. }
  7116. cc_library {
  7117. name: "mylib",
  7118. srcs: ["mylib.cpp"],
  7119. shared_libs: ["mylib2"],
  7120. system_shared_libs: [],
  7121. stl: "none",
  7122. apex_available: [ "myapex" ],
  7123. }
  7124. cc_library {
  7125. name: "mylib2",
  7126. srcs: ["mylib.cpp"],
  7127. system_shared_libs: [],
  7128. stl: "none",
  7129. apex_available: [ "myapex" ],
  7130. }
  7131. rust_ffi_shared {
  7132. name: "libfoo.rust",
  7133. crate_name: "foo",
  7134. srcs: ["foo.rs"],
  7135. shared_libs: ["libfoo.shared_from_rust"],
  7136. prefer_rlib: true,
  7137. apex_available: ["myapex"],
  7138. }
  7139. cc_library_shared {
  7140. name: "libfoo.shared_from_rust",
  7141. srcs: ["mylib.cpp"],
  7142. system_shared_libs: [],
  7143. stl: "none",
  7144. stubs: {
  7145. versions: ["10", "11", "12"],
  7146. },
  7147. }
  7148. `)
  7149. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  7150. // Notice mylib2.so (transitive dep) is not added as a jni_lib
  7151. ensureEquals(t, rule.Args["opt"], "-a jniLibs libfoo.rust.so mylib.so")
  7152. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  7153. "lib64/mylib.so",
  7154. "lib64/mylib2.so",
  7155. "lib64/libfoo.rust.so",
  7156. "lib64/libc++.so", // auto-added to libfoo.rust by Soong
  7157. "lib64/liblog.so", // auto-added to libfoo.rust by Soong
  7158. })
  7159. // b/220397949
  7160. ensureListContains(t, names(rule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  7161. }
  7162. func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
  7163. ctx := testApex(t, `
  7164. apex {
  7165. name: "myapex",
  7166. key: "myapex.key",
  7167. updatable: false,
  7168. }
  7169. apex_key {
  7170. name: "myapex.key",
  7171. public_key: "testkey.avbpubkey",
  7172. private_key: "testkey.pem",
  7173. }
  7174. `,
  7175. android.FixtureModifyConfig(func(config android.Config) {
  7176. delete(config.Targets, android.Android)
  7177. config.AndroidCommonTarget = android.Target{}
  7178. }),
  7179. )
  7180. if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
  7181. t.Errorf("Expected variants: %v, but got: %v", expected, got)
  7182. }
  7183. }
  7184. func TestAppBundle(t *testing.T) {
  7185. ctx := testApex(t, `
  7186. apex {
  7187. name: "myapex",
  7188. key: "myapex.key",
  7189. apps: ["AppFoo"],
  7190. updatable: false,
  7191. }
  7192. apex_key {
  7193. name: "myapex.key",
  7194. public_key: "testkey.avbpubkey",
  7195. private_key: "testkey.pem",
  7196. }
  7197. android_app {
  7198. name: "AppFoo",
  7199. srcs: ["foo/bar/MyClass.java"],
  7200. sdk_version: "none",
  7201. system_modules: "none",
  7202. apex_available: [ "myapex" ],
  7203. }
  7204. `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
  7205. bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
  7206. content := bundleConfigRule.Args["content"]
  7207. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  7208. ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo@TEST.BUILD_ID/AppFoo.apk"}]}`)
  7209. }
  7210. func TestAppSetBundle(t *testing.T) {
  7211. ctx := testApex(t, `
  7212. apex {
  7213. name: "myapex",
  7214. key: "myapex.key",
  7215. apps: ["AppSet"],
  7216. updatable: false,
  7217. }
  7218. apex_key {
  7219. name: "myapex.key",
  7220. public_key: "testkey.avbpubkey",
  7221. private_key: "testkey.pem",
  7222. }
  7223. android_app_set {
  7224. name: "AppSet",
  7225. set: "AppSet.apks",
  7226. }`)
  7227. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  7228. bundleConfigRule := mod.Output("bundle_config.json")
  7229. content := bundleConfigRule.Args["content"]
  7230. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  7231. s := mod.Rule("apexRule").Args["copy_commands"]
  7232. copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
  7233. if len(copyCmds) != 4 {
  7234. t.Fatalf("Expected 4 commands, got %d in:\n%s", len(copyCmds), s)
  7235. }
  7236. ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet@TEST.BUILD_ID$")
  7237. ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet@TEST.BUILD_ID$")
  7238. ensureMatches(t, copyCmds[2], "^cp -f .*/app/AppSet@TEST.BUILD_ID/AppSet.apk$")
  7239. ensureMatches(t, copyCmds[3], "^unzip .*-d .*/app/AppSet@TEST.BUILD_ID .*/AppSet.zip$")
  7240. // Ensure that canned_fs_config has an entry for the app set zip file
  7241. generateFsRule := mod.Rule("generateFsConfig")
  7242. cmd := generateFsRule.RuleParams.Command
  7243. ensureContains(t, cmd, "AppSet.zip")
  7244. }
  7245. func TestAppSetBundlePrebuilt(t *testing.T) {
  7246. bp := `
  7247. apex_set {
  7248. name: "myapex",
  7249. filename: "foo_v2.apex",
  7250. sanitized: {
  7251. none: { set: "myapex.apks", },
  7252. hwaddress: { set: "myapex.hwasan.apks", },
  7253. },
  7254. }
  7255. `
  7256. ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
  7257. // Check that the extractor produces the correct output file from the correct input file.
  7258. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
  7259. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  7260. extractedApex := m.Output(extractorOutput)
  7261. android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
  7262. // Ditto for the apex.
  7263. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  7264. copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
  7265. android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
  7266. }
  7267. func TestApexSetApksModuleAssignment(t *testing.T) {
  7268. ctx := testApex(t, `
  7269. apex_set {
  7270. name: "myapex",
  7271. set: ":myapex_apks_file",
  7272. }
  7273. filegroup {
  7274. name: "myapex_apks_file",
  7275. srcs: ["myapex.apks"],
  7276. }
  7277. `)
  7278. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  7279. // Check that the extractor produces the correct apks file from the input module
  7280. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.apks"
  7281. extractedApex := m.Output(extractorOutput)
  7282. android.AssertArrayString(t, "extractor input", []string{"myapex.apks"}, extractedApex.Inputs.Strings())
  7283. }
  7284. func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
  7285. t.Helper()
  7286. bp := `
  7287. java_library {
  7288. name: "some-updatable-apex-lib",
  7289. srcs: ["a.java"],
  7290. sdk_version: "current",
  7291. apex_available: [
  7292. "some-updatable-apex",
  7293. ],
  7294. permitted_packages: ["some.updatable.apex.lib"],
  7295. min_sdk_version: "33",
  7296. }
  7297. java_library {
  7298. name: "some-non-updatable-apex-lib",
  7299. srcs: ["a.java"],
  7300. apex_available: [
  7301. "some-non-updatable-apex",
  7302. ],
  7303. compile_dex: true,
  7304. permitted_packages: ["some.non.updatable.apex.lib"],
  7305. }
  7306. bootclasspath_fragment {
  7307. name: "some-non-updatable-fragment",
  7308. contents: ["some-non-updatable-apex-lib"],
  7309. apex_available: [
  7310. "some-non-updatable-apex",
  7311. ],
  7312. hidden_api: {
  7313. split_packages: ["*"],
  7314. },
  7315. }
  7316. java_library {
  7317. name: "some-platform-lib",
  7318. srcs: ["a.java"],
  7319. sdk_version: "current",
  7320. installable: true,
  7321. }
  7322. java_library {
  7323. name: "some-art-lib",
  7324. srcs: ["a.java"],
  7325. sdk_version: "current",
  7326. apex_available: [
  7327. "com.android.art.debug",
  7328. ],
  7329. hostdex: true,
  7330. compile_dex: true,
  7331. min_sdk_version: "33",
  7332. }
  7333. apex {
  7334. name: "some-updatable-apex",
  7335. key: "some-updatable-apex.key",
  7336. java_libs: ["some-updatable-apex-lib"],
  7337. updatable: true,
  7338. min_sdk_version: "33",
  7339. }
  7340. apex {
  7341. name: "some-non-updatable-apex",
  7342. key: "some-non-updatable-apex.key",
  7343. bootclasspath_fragments: ["some-non-updatable-fragment"],
  7344. updatable: false,
  7345. }
  7346. apex_key {
  7347. name: "some-updatable-apex.key",
  7348. }
  7349. apex_key {
  7350. name: "some-non-updatable-apex.key",
  7351. }
  7352. apex {
  7353. name: "com.android.art.debug",
  7354. key: "com.android.art.debug.key",
  7355. bootclasspath_fragments: ["art-bootclasspath-fragment"],
  7356. updatable: true,
  7357. min_sdk_version: "33",
  7358. }
  7359. bootclasspath_fragment {
  7360. name: "art-bootclasspath-fragment",
  7361. image_name: "art",
  7362. contents: ["some-art-lib"],
  7363. apex_available: [
  7364. "com.android.art.debug",
  7365. ],
  7366. hidden_api: {
  7367. split_packages: ["*"],
  7368. },
  7369. }
  7370. apex_key {
  7371. name: "com.android.art.debug.key",
  7372. }
  7373. filegroup {
  7374. name: "some-updatable-apex-file_contexts",
  7375. srcs: [
  7376. "system/sepolicy/apex/some-updatable-apex-file_contexts",
  7377. ],
  7378. }
  7379. filegroup {
  7380. name: "some-non-updatable-apex-file_contexts",
  7381. srcs: [
  7382. "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
  7383. ],
  7384. }
  7385. `
  7386. testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
  7387. }
  7388. func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
  7389. t.Helper()
  7390. fs := android.MockFS{
  7391. "a.java": nil,
  7392. "a.jar": nil,
  7393. "apex_manifest.json": nil,
  7394. "AndroidManifest.xml": nil,
  7395. "system/sepolicy/apex/myapex-file_contexts": nil,
  7396. "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
  7397. "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
  7398. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  7399. "framework/aidl/a.aidl": nil,
  7400. }
  7401. errorHandler := android.FixtureExpectsNoErrors
  7402. if errmsg != "" {
  7403. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  7404. }
  7405. result := android.GroupFixturePreparers(
  7406. cc.PrepareForTestWithCcDefaultModules,
  7407. java.PrepareForTestWithHiddenApiBuildComponents,
  7408. java.PrepareForTestWithJavaDefaultModules,
  7409. java.PrepareForTestWithJavaSdkLibraryFiles,
  7410. PrepareForTestWithApexBuildComponents,
  7411. preparer,
  7412. fs.AddToFixture(),
  7413. android.FixtureModifyMockFS(func(fs android.MockFS) {
  7414. if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
  7415. insert := ""
  7416. for _, fragment := range fragments {
  7417. insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
  7418. }
  7419. fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
  7420. platform_bootclasspath {
  7421. name: "platform-bootclasspath",
  7422. fragments: [
  7423. %s
  7424. ],
  7425. }
  7426. `, insert))
  7427. }
  7428. }),
  7429. dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
  7430. ).
  7431. ExtendWithErrorHandler(errorHandler).
  7432. RunTestWithBp(t, bp)
  7433. return result.TestContext
  7434. }
  7435. func TestDuplicateDeapexersFromPrebuiltApexes(t *testing.T) {
  7436. preparers := android.GroupFixturePreparers(
  7437. java.PrepareForTestWithJavaDefaultModules,
  7438. PrepareForTestWithApexBuildComponents,
  7439. ).
  7440. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  7441. "Multiple installable prebuilt APEXes provide ambiguous deapexers: com.android.myapex and com.mycompany.android.myapex"))
  7442. bpBase := `
  7443. apex_set {
  7444. name: "com.android.myapex",
  7445. installable: true,
  7446. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7447. set: "myapex.apks",
  7448. }
  7449. apex_set {
  7450. name: "com.mycompany.android.myapex",
  7451. apex_name: "com.android.myapex",
  7452. installable: true,
  7453. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7454. set: "company-myapex.apks",
  7455. }
  7456. prebuilt_bootclasspath_fragment {
  7457. name: "my-bootclasspath-fragment",
  7458. apex_available: ["com.android.myapex"],
  7459. %s
  7460. }
  7461. `
  7462. t.Run("java_import", func(t *testing.T) {
  7463. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  7464. java_import {
  7465. name: "libfoo",
  7466. jars: ["libfoo.jar"],
  7467. apex_available: ["com.android.myapex"],
  7468. }
  7469. `)
  7470. })
  7471. t.Run("java_sdk_library_import", func(t *testing.T) {
  7472. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  7473. java_sdk_library_import {
  7474. name: "libfoo",
  7475. public: {
  7476. jars: ["libbar.jar"],
  7477. },
  7478. apex_available: ["com.android.myapex"],
  7479. }
  7480. `)
  7481. })
  7482. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  7483. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  7484. image_name: "art",
  7485. contents: ["libfoo"],
  7486. `)+`
  7487. java_sdk_library_import {
  7488. name: "libfoo",
  7489. public: {
  7490. jars: ["libbar.jar"],
  7491. },
  7492. apex_available: ["com.android.myapex"],
  7493. }
  7494. `)
  7495. })
  7496. }
  7497. func TestDuplicateButEquivalentDeapexersFromPrebuiltApexes(t *testing.T) {
  7498. preparers := android.GroupFixturePreparers(
  7499. java.PrepareForTestWithJavaDefaultModules,
  7500. PrepareForTestWithApexBuildComponents,
  7501. )
  7502. bpBase := `
  7503. apex_set {
  7504. name: "com.android.myapex",
  7505. installable: true,
  7506. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7507. set: "myapex.apks",
  7508. }
  7509. apex_set {
  7510. name: "com.android.myapex_compressed",
  7511. apex_name: "com.android.myapex",
  7512. installable: true,
  7513. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7514. set: "myapex_compressed.apks",
  7515. }
  7516. prebuilt_bootclasspath_fragment {
  7517. name: "my-bootclasspath-fragment",
  7518. apex_available: [
  7519. "com.android.myapex",
  7520. "com.android.myapex_compressed",
  7521. ],
  7522. hidden_api: {
  7523. annotation_flags: "annotation-flags.csv",
  7524. metadata: "metadata.csv",
  7525. index: "index.csv",
  7526. signature_patterns: "signature_patterns.csv",
  7527. },
  7528. %s
  7529. }
  7530. `
  7531. t.Run("java_import", func(t *testing.T) {
  7532. result := preparers.RunTestWithBp(t,
  7533. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  7534. java_import {
  7535. name: "libfoo",
  7536. jars: ["libfoo.jar"],
  7537. apex_available: [
  7538. "com.android.myapex",
  7539. "com.android.myapex_compressed",
  7540. ],
  7541. }
  7542. `)
  7543. module := result.Module("libfoo", "android_common_com.android.myapex")
  7544. usesLibraryDep := module.(java.UsesLibraryDependency)
  7545. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  7546. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  7547. usesLibraryDep.DexJarBuildPath().Path())
  7548. })
  7549. t.Run("java_sdk_library_import", func(t *testing.T) {
  7550. result := preparers.RunTestWithBp(t,
  7551. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  7552. java_sdk_library_import {
  7553. name: "libfoo",
  7554. public: {
  7555. jars: ["libbar.jar"],
  7556. },
  7557. apex_available: [
  7558. "com.android.myapex",
  7559. "com.android.myapex_compressed",
  7560. ],
  7561. compile_dex: true,
  7562. }
  7563. `)
  7564. module := result.Module("libfoo", "android_common_com.android.myapex")
  7565. usesLibraryDep := module.(java.UsesLibraryDependency)
  7566. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  7567. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  7568. usesLibraryDep.DexJarBuildPath().Path())
  7569. })
  7570. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  7571. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  7572. image_name: "art",
  7573. contents: ["libfoo"],
  7574. `)+`
  7575. java_sdk_library_import {
  7576. name: "libfoo",
  7577. public: {
  7578. jars: ["libbar.jar"],
  7579. },
  7580. apex_available: [
  7581. "com.android.myapex",
  7582. "com.android.myapex_compressed",
  7583. ],
  7584. compile_dex: true,
  7585. }
  7586. `)
  7587. })
  7588. }
  7589. func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
  7590. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  7591. apex {
  7592. name: "myapex",
  7593. key: "myapex.key",
  7594. updatable: true,
  7595. }
  7596. apex_key {
  7597. name: "myapex.key",
  7598. public_key: "testkey.avbpubkey",
  7599. private_key: "testkey.pem",
  7600. }
  7601. `)
  7602. }
  7603. func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
  7604. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  7605. apex {
  7606. name: "myapex",
  7607. key: "myapex.key",
  7608. }
  7609. apex_key {
  7610. name: "myapex.key",
  7611. public_key: "testkey.avbpubkey",
  7612. private_key: "testkey.pem",
  7613. }
  7614. `)
  7615. }
  7616. func Test_use_vndk_as_stable_shouldnt_be_used_for_updatable_vendor_apexes(t *testing.T) {
  7617. testApexError(t, `"myapex" .*: use_vndk_as_stable: updatable APEXes can't use external VNDK libs`, `
  7618. apex {
  7619. name: "myapex",
  7620. key: "myapex.key",
  7621. updatable: true,
  7622. use_vndk_as_stable: true,
  7623. soc_specific: true,
  7624. }
  7625. apex_key {
  7626. name: "myapex.key",
  7627. public_key: "testkey.avbpubkey",
  7628. private_key: "testkey.pem",
  7629. }
  7630. `)
  7631. }
  7632. func Test_use_vndk_as_stable_shouldnt_be_used_with_min_sdk_version(t *testing.T) {
  7633. testApexError(t, `"myapex" .*: use_vndk_as_stable: not supported when min_sdk_version is set`, `
  7634. apex {
  7635. name: "myapex",
  7636. key: "myapex.key",
  7637. updatable: false,
  7638. min_sdk_version: "29",
  7639. use_vndk_as_stable: true,
  7640. vendor: true,
  7641. }
  7642. apex_key {
  7643. name: "myapex.key",
  7644. public_key: "testkey.avbpubkey",
  7645. private_key: "testkey.pem",
  7646. }
  7647. `)
  7648. }
  7649. func Test_use_vndk_as_stable_shouldnt_be_used_for_non_vendor_apexes(t *testing.T) {
  7650. testApexError(t, `"myapex" .*: use_vndk_as_stable: not supported for system/system_ext APEXes`, `
  7651. apex {
  7652. name: "myapex",
  7653. key: "myapex.key",
  7654. updatable: false,
  7655. use_vndk_as_stable: true,
  7656. }
  7657. apex_key {
  7658. name: "myapex.key",
  7659. public_key: "testkey.avbpubkey",
  7660. private_key: "testkey.pem",
  7661. }
  7662. `)
  7663. }
  7664. func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
  7665. testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
  7666. apex {
  7667. name: "myapex",
  7668. key: "myapex.key",
  7669. systemserverclasspath_fragments: [
  7670. "mysystemserverclasspathfragment",
  7671. ],
  7672. min_sdk_version: "29",
  7673. updatable: true,
  7674. }
  7675. apex_key {
  7676. name: "myapex.key",
  7677. public_key: "testkey.avbpubkey",
  7678. private_key: "testkey.pem",
  7679. }
  7680. java_library {
  7681. name: "foo",
  7682. srcs: ["b.java"],
  7683. min_sdk_version: "29",
  7684. installable: true,
  7685. apex_available: [
  7686. "myapex",
  7687. ],
  7688. }
  7689. systemserverclasspath_fragment {
  7690. name: "mysystemserverclasspathfragment",
  7691. generate_classpaths_proto: false,
  7692. contents: [
  7693. "foo",
  7694. ],
  7695. apex_available: [
  7696. "myapex",
  7697. ],
  7698. }
  7699. `,
  7700. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7701. )
  7702. }
  7703. func TestNoUpdatableJarsInBootImage(t *testing.T) {
  7704. // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
  7705. // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
  7706. // modules to be included in the BootJars.
  7707. prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
  7708. return android.GroupFixturePreparers(
  7709. dexpreopt.FixtureSetBootJars(bootJars...),
  7710. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7711. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  7712. }),
  7713. )
  7714. }
  7715. // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
  7716. // same value. This can result in an invalid configuration as it allows non art apex jars to be
  7717. // specified in the ArtApexJars configuration.
  7718. prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
  7719. return android.GroupFixturePreparers(
  7720. dexpreopt.FixtureSetArtBootJars(bootJars...),
  7721. dexpreopt.FixtureSetBootJars(bootJars...),
  7722. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7723. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  7724. }),
  7725. )
  7726. }
  7727. t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
  7728. preparer := android.GroupFixturePreparers(
  7729. java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"),
  7730. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7731. )
  7732. fragments := []java.ApexVariantReference{
  7733. {
  7734. Apex: proptools.StringPtr("com.android.art.debug"),
  7735. Module: proptools.StringPtr("art-bootclasspath-fragment"),
  7736. },
  7737. {
  7738. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7739. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7740. },
  7741. }
  7742. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  7743. })
  7744. t.Run("updatable jar from ART apex in the platform bootclasspath => error", func(t *testing.T) {
  7745. err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the platform bootclasspath`
  7746. // Update the dexpreopt BootJars directly.
  7747. preparer := android.GroupFixturePreparers(
  7748. prepareSetBootJars("com.android.art.debug:some-art-lib"),
  7749. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7750. )
  7751. testNoUpdatableJarsInBootImage(t, err, preparer)
  7752. })
  7753. t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  7754. err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  7755. // Update the dexpreopt ArtApexJars directly.
  7756. preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
  7757. testNoUpdatableJarsInBootImage(t, err, preparer)
  7758. })
  7759. t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  7760. err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  7761. // Update the dexpreopt ArtApexJars directly.
  7762. preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  7763. testNoUpdatableJarsInBootImage(t, err, preparer)
  7764. })
  7765. t.Run("updatable jar from some other apex in the platform bootclasspath => error", func(t *testing.T) {
  7766. err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the platform bootclasspath`
  7767. preparer := android.GroupFixturePreparers(
  7768. java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"),
  7769. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7770. )
  7771. testNoUpdatableJarsInBootImage(t, err, preparer)
  7772. })
  7773. t.Run("non-updatable jar from some other apex in the platform bootclasspath => ok", func(t *testing.T) {
  7774. preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  7775. fragment := java.ApexVariantReference{
  7776. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7777. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7778. }
  7779. testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
  7780. })
  7781. t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
  7782. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  7783. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  7784. testNoUpdatableJarsInBootImage(t, err, preparer)
  7785. })
  7786. t.Run("nonexistent jar in the platform bootclasspath => error", func(t *testing.T) {
  7787. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  7788. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  7789. testNoUpdatableJarsInBootImage(t, err, preparer)
  7790. })
  7791. t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
  7792. err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
  7793. // Update the dexpreopt ArtApexJars directly.
  7794. preparer := prepareSetArtJars("platform:some-platform-lib")
  7795. testNoUpdatableJarsInBootImage(t, err, preparer)
  7796. })
  7797. t.Run("platform jar in the platform bootclasspath => ok", func(t *testing.T) {
  7798. preparer := android.GroupFixturePreparers(
  7799. java.FixtureConfigureBootJars("platform:some-platform-lib"),
  7800. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7801. )
  7802. fragments := []java.ApexVariantReference{
  7803. {
  7804. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7805. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7806. },
  7807. }
  7808. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  7809. })
  7810. }
  7811. func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
  7812. preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
  7813. t.Run("prebuilt no source", func(t *testing.T) {
  7814. fragment := java.ApexVariantReference{
  7815. Apex: proptools.StringPtr("myapex"),
  7816. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  7817. }
  7818. testDexpreoptWithApexes(t, `
  7819. prebuilt_apex {
  7820. name: "myapex" ,
  7821. arch: {
  7822. arm64: {
  7823. src: "myapex-arm64.apex",
  7824. },
  7825. arm: {
  7826. src: "myapex-arm.apex",
  7827. },
  7828. },
  7829. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7830. }
  7831. prebuilt_bootclasspath_fragment {
  7832. name: "my-bootclasspath-fragment",
  7833. contents: ["libfoo"],
  7834. apex_available: ["myapex"],
  7835. hidden_api: {
  7836. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  7837. metadata: "my-bootclasspath-fragment/metadata.csv",
  7838. index: "my-bootclasspath-fragment/index.csv",
  7839. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  7840. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  7841. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  7842. },
  7843. }
  7844. java_import {
  7845. name: "libfoo",
  7846. jars: ["libfoo.jar"],
  7847. apex_available: ["myapex"],
  7848. permitted_packages: ["libfoo"],
  7849. }
  7850. `, "", preparer, fragment)
  7851. })
  7852. }
  7853. func testBootJarPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
  7854. t.Helper()
  7855. bp += `
  7856. apex_key {
  7857. name: "myapex.key",
  7858. public_key: "testkey.avbpubkey",
  7859. private_key: "testkey.pem",
  7860. }`
  7861. fs := android.MockFS{
  7862. "lib1/src/A.java": nil,
  7863. "lib2/src/B.java": nil,
  7864. "system/sepolicy/apex/myapex-file_contexts": nil,
  7865. }
  7866. errorHandler := android.FixtureExpectsNoErrors
  7867. if errmsg != "" {
  7868. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  7869. }
  7870. android.GroupFixturePreparers(
  7871. android.PrepareForTestWithAndroidBuildComponents,
  7872. java.PrepareForTestWithJavaBuildComponents,
  7873. PrepareForTestWithApexBuildComponents,
  7874. android.PrepareForTestWithNeverallowRules(rules),
  7875. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7876. apexBootJars := make([]string, 0, len(bootJars))
  7877. for _, apexBootJar := range bootJars {
  7878. apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
  7879. }
  7880. variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
  7881. }),
  7882. fs.AddToFixture(),
  7883. ).
  7884. ExtendWithErrorHandler(errorHandler).
  7885. RunTestWithBp(t, bp)
  7886. }
  7887. func TestApexPermittedPackagesRules(t *testing.T) {
  7888. testcases := []struct {
  7889. name string
  7890. expectedError string
  7891. bp string
  7892. bootJars []string
  7893. bcpPermittedPackages map[string][]string
  7894. }{
  7895. {
  7896. name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
  7897. expectedError: "",
  7898. bp: `
  7899. java_library {
  7900. name: "bcp_lib1",
  7901. srcs: ["lib1/src/*.java"],
  7902. permitted_packages: ["foo.bar"],
  7903. apex_available: ["myapex"],
  7904. sdk_version: "none",
  7905. system_modules: "none",
  7906. }
  7907. java_library {
  7908. name: "nonbcp_lib2",
  7909. srcs: ["lib2/src/*.java"],
  7910. apex_available: ["myapex"],
  7911. permitted_packages: ["a.b"],
  7912. sdk_version: "none",
  7913. system_modules: "none",
  7914. }
  7915. apex {
  7916. name: "myapex",
  7917. key: "myapex.key",
  7918. java_libs: ["bcp_lib1", "nonbcp_lib2"],
  7919. updatable: false,
  7920. }`,
  7921. bootJars: []string{"bcp_lib1"},
  7922. bcpPermittedPackages: map[string][]string{
  7923. "bcp_lib1": []string{
  7924. "foo.bar",
  7925. },
  7926. },
  7927. },
  7928. {
  7929. name: "Bootclasspath apex jar not satisfying allowed module packages.",
  7930. expectedError: `(?s)module "bcp_lib2" .* which is restricted because bcp_lib2 bootjar may only use these package prefixes: foo.bar. Please consider the following alternatives:\n 1. If the offending code is from a statically linked library, consider removing that dependency and using an alternative already in the bootclasspath, or perhaps a shared library. 2. Move the offending code into an allowed package.\n 3. Jarjar the offending code. Please be mindful of the potential system health implications of bundling that code, particularly if the offending jar is part of the bootclasspath.`,
  7931. bp: `
  7932. java_library {
  7933. name: "bcp_lib1",
  7934. srcs: ["lib1/src/*.java"],
  7935. apex_available: ["myapex"],
  7936. permitted_packages: ["foo.bar"],
  7937. sdk_version: "none",
  7938. system_modules: "none",
  7939. }
  7940. java_library {
  7941. name: "bcp_lib2",
  7942. srcs: ["lib2/src/*.java"],
  7943. apex_available: ["myapex"],
  7944. permitted_packages: ["foo.bar", "bar.baz"],
  7945. sdk_version: "none",
  7946. system_modules: "none",
  7947. }
  7948. apex {
  7949. name: "myapex",
  7950. key: "myapex.key",
  7951. java_libs: ["bcp_lib1", "bcp_lib2"],
  7952. updatable: false,
  7953. }
  7954. `,
  7955. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7956. bcpPermittedPackages: map[string][]string{
  7957. "bcp_lib1": []string{
  7958. "foo.bar",
  7959. },
  7960. "bcp_lib2": []string{
  7961. "foo.bar",
  7962. },
  7963. },
  7964. },
  7965. {
  7966. name: "Updateable Bootclasspath apex jar not satisfying allowed module packages.",
  7967. expectedError: "",
  7968. bp: `
  7969. java_library {
  7970. name: "bcp_lib_restricted",
  7971. srcs: ["lib1/src/*.java"],
  7972. apex_available: ["myapex"],
  7973. permitted_packages: ["foo.bar"],
  7974. sdk_version: "none",
  7975. min_sdk_version: "29",
  7976. system_modules: "none",
  7977. }
  7978. java_library {
  7979. name: "bcp_lib_unrestricted",
  7980. srcs: ["lib2/src/*.java"],
  7981. apex_available: ["myapex"],
  7982. permitted_packages: ["foo.bar", "bar.baz"],
  7983. sdk_version: "none",
  7984. min_sdk_version: "29",
  7985. system_modules: "none",
  7986. }
  7987. apex {
  7988. name: "myapex",
  7989. key: "myapex.key",
  7990. java_libs: ["bcp_lib_restricted", "bcp_lib_unrestricted"],
  7991. updatable: true,
  7992. min_sdk_version: "29",
  7993. }
  7994. `,
  7995. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7996. bcpPermittedPackages: map[string][]string{
  7997. "bcp_lib1_non_updateable": []string{
  7998. "foo.bar",
  7999. },
  8000. // bcp_lib2_updateable has no entry here since updateable bcp can contain new packages - tracking via an allowlist is not necessary
  8001. },
  8002. },
  8003. }
  8004. for _, tc := range testcases {
  8005. t.Run(tc.name, func(t *testing.T) {
  8006. rules := createBcpPermittedPackagesRules(tc.bcpPermittedPackages)
  8007. testBootJarPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
  8008. })
  8009. }
  8010. }
  8011. func TestTestFor(t *testing.T) {
  8012. ctx := testApex(t, `
  8013. apex {
  8014. name: "myapex",
  8015. key: "myapex.key",
  8016. native_shared_libs: ["mylib", "myprivlib"],
  8017. updatable: false,
  8018. }
  8019. apex_key {
  8020. name: "myapex.key",
  8021. public_key: "testkey.avbpubkey",
  8022. private_key: "testkey.pem",
  8023. }
  8024. cc_library {
  8025. name: "mylib",
  8026. srcs: ["mylib.cpp"],
  8027. system_shared_libs: [],
  8028. stl: "none",
  8029. stubs: {
  8030. versions: ["1"],
  8031. },
  8032. apex_available: ["myapex"],
  8033. }
  8034. cc_library {
  8035. name: "myprivlib",
  8036. srcs: ["mylib.cpp"],
  8037. system_shared_libs: [],
  8038. stl: "none",
  8039. apex_available: ["myapex"],
  8040. }
  8041. cc_test {
  8042. name: "mytest",
  8043. gtest: false,
  8044. srcs: ["mylib.cpp"],
  8045. system_shared_libs: [],
  8046. stl: "none",
  8047. shared_libs: ["mylib", "myprivlib", "mytestlib"],
  8048. test_for: ["myapex"]
  8049. }
  8050. cc_library {
  8051. name: "mytestlib",
  8052. srcs: ["mylib.cpp"],
  8053. system_shared_libs: [],
  8054. shared_libs: ["mylib", "myprivlib"],
  8055. stl: "none",
  8056. test_for: ["myapex"],
  8057. }
  8058. cc_benchmark {
  8059. name: "mybench",
  8060. srcs: ["mylib.cpp"],
  8061. system_shared_libs: [],
  8062. shared_libs: ["mylib", "myprivlib"],
  8063. stl: "none",
  8064. test_for: ["myapex"],
  8065. }
  8066. `)
  8067. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  8068. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  8069. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  8070. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  8071. }
  8072. // These modules are tests for the apex, therefore are linked to the
  8073. // actual implementation of mylib instead of its stub.
  8074. ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  8075. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  8076. ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  8077. }
  8078. func TestIndirectTestFor(t *testing.T) {
  8079. ctx := testApex(t, `
  8080. apex {
  8081. name: "myapex",
  8082. key: "myapex.key",
  8083. native_shared_libs: ["mylib", "myprivlib"],
  8084. updatable: false,
  8085. }
  8086. apex_key {
  8087. name: "myapex.key",
  8088. public_key: "testkey.avbpubkey",
  8089. private_key: "testkey.pem",
  8090. }
  8091. cc_library {
  8092. name: "mylib",
  8093. srcs: ["mylib.cpp"],
  8094. system_shared_libs: [],
  8095. stl: "none",
  8096. stubs: {
  8097. versions: ["1"],
  8098. },
  8099. apex_available: ["myapex"],
  8100. }
  8101. cc_library {
  8102. name: "myprivlib",
  8103. srcs: ["mylib.cpp"],
  8104. system_shared_libs: [],
  8105. stl: "none",
  8106. shared_libs: ["mylib"],
  8107. apex_available: ["myapex"],
  8108. }
  8109. cc_library {
  8110. name: "mytestlib",
  8111. srcs: ["mylib.cpp"],
  8112. system_shared_libs: [],
  8113. shared_libs: ["myprivlib"],
  8114. stl: "none",
  8115. test_for: ["myapex"],
  8116. }
  8117. `)
  8118. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  8119. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  8120. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  8121. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  8122. }
  8123. // The platform variant of mytestlib links to the platform variant of the
  8124. // internal myprivlib.
  8125. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
  8126. // The platform variant of myprivlib links to the platform variant of mylib
  8127. // and bypasses its stubs.
  8128. ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  8129. }
  8130. func TestTestForForLibInOtherApex(t *testing.T) {
  8131. // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
  8132. _ = testApex(t, `
  8133. apex {
  8134. name: "com.android.art",
  8135. key: "myapex.key",
  8136. native_shared_libs: ["libnativebridge"],
  8137. updatable: false,
  8138. }
  8139. apex {
  8140. name: "com.android.art.debug",
  8141. key: "myapex.key",
  8142. native_shared_libs: ["libnativebridge", "libnativebrdige_test"],
  8143. updatable: false,
  8144. }
  8145. apex_key {
  8146. name: "myapex.key",
  8147. public_key: "testkey.avbpubkey",
  8148. private_key: "testkey.pem",
  8149. }
  8150. cc_library {
  8151. name: "libnativebridge",
  8152. srcs: ["libnativebridge.cpp"],
  8153. system_shared_libs: [],
  8154. stl: "none",
  8155. stubs: {
  8156. versions: ["1"],
  8157. },
  8158. apex_available: ["com.android.art", "com.android.art.debug"],
  8159. }
  8160. cc_library {
  8161. name: "libnativebrdige_test",
  8162. srcs: ["mylib.cpp"],
  8163. system_shared_libs: [],
  8164. shared_libs: ["libnativebridge"],
  8165. stl: "none",
  8166. apex_available: ["com.android.art.debug"],
  8167. test_for: ["com.android.art"],
  8168. }
  8169. `,
  8170. android.MockFS{
  8171. "system/sepolicy/apex/com.android.art-file_contexts": nil,
  8172. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  8173. }.AddToFixture())
  8174. }
  8175. // TODO(jungjw): Move this to proptools
  8176. func intPtr(i int) *int {
  8177. return &i
  8178. }
  8179. func TestApexSet(t *testing.T) {
  8180. ctx := testApex(t, `
  8181. apex_set {
  8182. name: "myapex",
  8183. set: "myapex.apks",
  8184. filename: "foo_v2.apex",
  8185. overrides: ["foo"],
  8186. }
  8187. `,
  8188. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  8189. variables.Platform_sdk_version = intPtr(30)
  8190. }),
  8191. android.FixtureModifyConfig(func(config android.Config) {
  8192. config.Targets[android.Android] = []android.Target{
  8193. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
  8194. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
  8195. }
  8196. }),
  8197. )
  8198. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  8199. // Check extract_apks tool parameters.
  8200. extractedApex := m.Output("extracted/myapex.apks")
  8201. actual := extractedApex.Args["abis"]
  8202. expected := "ARMEABI_V7A,ARM64_V8A"
  8203. if actual != expected {
  8204. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  8205. }
  8206. actual = extractedApex.Args["sdk-version"]
  8207. expected = "30"
  8208. if actual != expected {
  8209. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  8210. }
  8211. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  8212. a := m.Module().(*ApexSet)
  8213. expectedOverrides := []string{"foo"}
  8214. actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  8215. if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
  8216. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
  8217. }
  8218. }
  8219. func TestApexSet_NativeBridge(t *testing.T) {
  8220. ctx := testApex(t, `
  8221. apex_set {
  8222. name: "myapex",
  8223. set: "myapex.apks",
  8224. filename: "foo_v2.apex",
  8225. overrides: ["foo"],
  8226. }
  8227. `,
  8228. android.FixtureModifyConfig(func(config android.Config) {
  8229. config.Targets[android.Android] = []android.Target{
  8230. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "", Abi: []string{"x86_64"}}},
  8231. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled},
  8232. }
  8233. }),
  8234. )
  8235. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  8236. // Check extract_apks tool parameters. No native bridge arch expected
  8237. extractedApex := m.Output("extracted/myapex.apks")
  8238. android.AssertStringEquals(t, "abis", "X86_64", extractedApex.Args["abis"])
  8239. }
  8240. func TestNoStaticLinkingToStubsLib(t *testing.T) {
  8241. testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
  8242. apex {
  8243. name: "myapex",
  8244. key: "myapex.key",
  8245. native_shared_libs: ["mylib"],
  8246. updatable: false,
  8247. }
  8248. apex_key {
  8249. name: "myapex.key",
  8250. public_key: "testkey.avbpubkey",
  8251. private_key: "testkey.pem",
  8252. }
  8253. cc_library {
  8254. name: "mylib",
  8255. srcs: ["mylib.cpp"],
  8256. static_libs: ["otherlib"],
  8257. system_shared_libs: [],
  8258. stl: "none",
  8259. apex_available: [ "myapex" ],
  8260. }
  8261. cc_library {
  8262. name: "otherlib",
  8263. srcs: ["mylib.cpp"],
  8264. system_shared_libs: [],
  8265. stl: "none",
  8266. stubs: {
  8267. versions: ["1", "2", "3"],
  8268. },
  8269. apex_available: [ "myapex" ],
  8270. }
  8271. `)
  8272. }
  8273. func TestApexKeysTxt(t *testing.T) {
  8274. ctx := testApex(t, `
  8275. apex {
  8276. name: "myapex",
  8277. key: "myapex.key",
  8278. updatable: false,
  8279. custom_sign_tool: "sign_myapex",
  8280. }
  8281. apex_key {
  8282. name: "myapex.key",
  8283. public_key: "testkey.avbpubkey",
  8284. private_key: "testkey.pem",
  8285. }
  8286. `)
  8287. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  8288. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  8289. ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system" sign_tool="sign_myapex"`)
  8290. }
  8291. func TestApexKeysTxtOverrides(t *testing.T) {
  8292. ctx := testApex(t, `
  8293. apex {
  8294. name: "myapex",
  8295. key: "myapex.key",
  8296. updatable: false,
  8297. custom_sign_tool: "sign_myapex",
  8298. }
  8299. apex_key {
  8300. name: "myapex.key",
  8301. public_key: "testkey.avbpubkey",
  8302. private_key: "testkey.pem",
  8303. }
  8304. prebuilt_apex {
  8305. name: "myapex",
  8306. prefer: true,
  8307. arch: {
  8308. arm64: {
  8309. src: "myapex-arm64.apex",
  8310. },
  8311. arm: {
  8312. src: "myapex-arm.apex",
  8313. },
  8314. },
  8315. }
  8316. apex_set {
  8317. name: "myapex_set",
  8318. set: "myapex.apks",
  8319. filename: "myapex_set.apex",
  8320. overrides: ["myapex"],
  8321. }
  8322. `)
  8323. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  8324. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  8325. ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  8326. ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  8327. }
  8328. func TestAllowedFiles(t *testing.T) {
  8329. ctx := testApex(t, `
  8330. apex {
  8331. name: "myapex",
  8332. key: "myapex.key",
  8333. apps: ["app"],
  8334. allowed_files: "allowed.txt",
  8335. updatable: false,
  8336. }
  8337. apex_key {
  8338. name: "myapex.key",
  8339. public_key: "testkey.avbpubkey",
  8340. private_key: "testkey.pem",
  8341. }
  8342. android_app {
  8343. name: "app",
  8344. srcs: ["foo/bar/MyClass.java"],
  8345. package_name: "foo",
  8346. sdk_version: "none",
  8347. system_modules: "none",
  8348. apex_available: [ "myapex" ],
  8349. }
  8350. `, withFiles(map[string][]byte{
  8351. "sub/Android.bp": []byte(`
  8352. override_apex {
  8353. name: "override_myapex",
  8354. base: "myapex",
  8355. apps: ["override_app"],
  8356. allowed_files: ":allowed",
  8357. }
  8358. // Overridable "path" property should be referenced indirectly
  8359. filegroup {
  8360. name: "allowed",
  8361. srcs: ["allowed.txt"],
  8362. }
  8363. override_android_app {
  8364. name: "override_app",
  8365. base: "app",
  8366. package_name: "bar",
  8367. }
  8368. `),
  8369. }))
  8370. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
  8371. if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
  8372. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  8373. }
  8374. rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
  8375. if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
  8376. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  8377. }
  8378. }
  8379. func TestNonPreferredPrebuiltDependency(t *testing.T) {
  8380. testApex(t, `
  8381. apex {
  8382. name: "myapex",
  8383. key: "myapex.key",
  8384. native_shared_libs: ["mylib"],
  8385. updatable: false,
  8386. }
  8387. apex_key {
  8388. name: "myapex.key",
  8389. public_key: "testkey.avbpubkey",
  8390. private_key: "testkey.pem",
  8391. }
  8392. cc_library {
  8393. name: "mylib",
  8394. srcs: ["mylib.cpp"],
  8395. stubs: {
  8396. versions: ["current"],
  8397. },
  8398. apex_available: ["myapex"],
  8399. }
  8400. cc_prebuilt_library_shared {
  8401. name: "mylib",
  8402. prefer: false,
  8403. srcs: ["prebuilt.so"],
  8404. stubs: {
  8405. versions: ["current"],
  8406. },
  8407. apex_available: ["myapex"],
  8408. }
  8409. `)
  8410. }
  8411. func TestCompressedApex(t *testing.T) {
  8412. ctx := testApex(t, `
  8413. apex {
  8414. name: "myapex",
  8415. key: "myapex.key",
  8416. compressible: true,
  8417. updatable: false,
  8418. }
  8419. apex_key {
  8420. name: "myapex.key",
  8421. public_key: "testkey.avbpubkey",
  8422. private_key: "testkey.pem",
  8423. }
  8424. `,
  8425. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  8426. variables.CompressedApex = proptools.BoolPtr(true)
  8427. }),
  8428. )
  8429. compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
  8430. ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
  8431. signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
  8432. ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
  8433. // Make sure output of bundle is .capex
  8434. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8435. ensureContains(t, ab.outputFile.String(), "myapex.capex")
  8436. // Verify android.mk rules
  8437. data := android.AndroidMkDataForTest(t, ctx, ab)
  8438. var builder strings.Builder
  8439. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  8440. androidMk := builder.String()
  8441. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
  8442. }
  8443. func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
  8444. ctx := testApex(t, `
  8445. apex {
  8446. name: "myapex",
  8447. key: "myapex.key",
  8448. native_shared_libs: ["mylib"],
  8449. updatable: false,
  8450. }
  8451. apex_key {
  8452. name: "myapex.key",
  8453. public_key: "testkey.avbpubkey",
  8454. private_key: "testkey.pem",
  8455. }
  8456. cc_library {
  8457. name: "mylib",
  8458. srcs: ["mylib.cpp"],
  8459. apex_available: ["myapex"],
  8460. shared_libs: ["otherlib"],
  8461. system_shared_libs: [],
  8462. }
  8463. cc_library {
  8464. name: "otherlib",
  8465. srcs: ["mylib.cpp"],
  8466. stubs: {
  8467. versions: ["current"],
  8468. },
  8469. }
  8470. cc_prebuilt_library_shared {
  8471. name: "otherlib",
  8472. prefer: true,
  8473. srcs: ["prebuilt.so"],
  8474. stubs: {
  8475. versions: ["current"],
  8476. },
  8477. }
  8478. `)
  8479. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8480. data := android.AndroidMkDataForTest(t, ctx, ab)
  8481. var builder strings.Builder
  8482. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  8483. androidMk := builder.String()
  8484. // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
  8485. // a thing there.
  8486. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++:64 mylib.myapex:64 otherlib\n")
  8487. }
  8488. func TestExcludeDependency(t *testing.T) {
  8489. ctx := testApex(t, `
  8490. apex {
  8491. name: "myapex",
  8492. key: "myapex.key",
  8493. native_shared_libs: ["mylib"],
  8494. updatable: false,
  8495. }
  8496. apex_key {
  8497. name: "myapex.key",
  8498. public_key: "testkey.avbpubkey",
  8499. private_key: "testkey.pem",
  8500. }
  8501. cc_library {
  8502. name: "mylib",
  8503. srcs: ["mylib.cpp"],
  8504. system_shared_libs: [],
  8505. stl: "none",
  8506. apex_available: ["myapex"],
  8507. shared_libs: ["mylib2"],
  8508. target: {
  8509. apex: {
  8510. exclude_shared_libs: ["mylib2"],
  8511. },
  8512. },
  8513. }
  8514. cc_library {
  8515. name: "mylib2",
  8516. srcs: ["mylib.cpp"],
  8517. system_shared_libs: [],
  8518. stl: "none",
  8519. }
  8520. `)
  8521. // Check if mylib is linked to mylib2 for the non-apex target
  8522. ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  8523. ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  8524. // Make sure that the link doesn't occur for the apex target
  8525. ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  8526. ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
  8527. // It shouldn't appear in the copy cmd as well.
  8528. copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
  8529. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  8530. }
  8531. func TestPrebuiltStubLibDep(t *testing.T) {
  8532. bpBase := `
  8533. apex {
  8534. name: "myapex",
  8535. key: "myapex.key",
  8536. native_shared_libs: ["mylib"],
  8537. updatable: false,
  8538. }
  8539. apex_key {
  8540. name: "myapex.key",
  8541. public_key: "testkey.avbpubkey",
  8542. private_key: "testkey.pem",
  8543. }
  8544. cc_library {
  8545. name: "mylib",
  8546. srcs: ["mylib.cpp"],
  8547. apex_available: ["myapex"],
  8548. shared_libs: ["stublib"],
  8549. system_shared_libs: [],
  8550. }
  8551. apex {
  8552. name: "otherapex",
  8553. enabled: %s,
  8554. key: "myapex.key",
  8555. native_shared_libs: ["stublib"],
  8556. updatable: false,
  8557. }
  8558. `
  8559. stublibSourceBp := `
  8560. cc_library {
  8561. name: "stublib",
  8562. srcs: ["mylib.cpp"],
  8563. apex_available: ["otherapex"],
  8564. system_shared_libs: [],
  8565. stl: "none",
  8566. stubs: {
  8567. versions: ["1"],
  8568. },
  8569. }
  8570. `
  8571. stublibPrebuiltBp := `
  8572. cc_prebuilt_library_shared {
  8573. name: "stublib",
  8574. srcs: ["prebuilt.so"],
  8575. apex_available: ["otherapex"],
  8576. stubs: {
  8577. versions: ["1"],
  8578. },
  8579. %s
  8580. }
  8581. `
  8582. tests := []struct {
  8583. name string
  8584. stublibBp string
  8585. usePrebuilt bool
  8586. modNames []string // Modules to collect AndroidMkEntries for
  8587. otherApexEnabled []string
  8588. }{
  8589. {
  8590. name: "only_source",
  8591. stublibBp: stublibSourceBp,
  8592. usePrebuilt: false,
  8593. modNames: []string{"stublib"},
  8594. otherApexEnabled: []string{"true", "false"},
  8595. },
  8596. {
  8597. name: "source_preferred",
  8598. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
  8599. usePrebuilt: false,
  8600. modNames: []string{"stublib", "prebuilt_stublib"},
  8601. otherApexEnabled: []string{"true", "false"},
  8602. },
  8603. {
  8604. name: "prebuilt_preferred",
  8605. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
  8606. usePrebuilt: true,
  8607. modNames: []string{"stublib", "prebuilt_stublib"},
  8608. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  8609. },
  8610. {
  8611. name: "only_prebuilt",
  8612. stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
  8613. usePrebuilt: true,
  8614. modNames: []string{"stublib"},
  8615. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  8616. },
  8617. }
  8618. for _, test := range tests {
  8619. t.Run(test.name, func(t *testing.T) {
  8620. for _, otherApexEnabled := range test.otherApexEnabled {
  8621. t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
  8622. ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
  8623. type modAndMkEntries struct {
  8624. mod *cc.Module
  8625. mkEntries android.AndroidMkEntries
  8626. }
  8627. entries := []*modAndMkEntries{}
  8628. // Gather shared lib modules that are installable
  8629. for _, modName := range test.modNames {
  8630. for _, variant := range ctx.ModuleVariantsForTests(modName) {
  8631. if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
  8632. continue
  8633. }
  8634. mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
  8635. if !mod.Enabled() || mod.IsHideFromMake() {
  8636. continue
  8637. }
  8638. for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
  8639. if ent.Disabled {
  8640. continue
  8641. }
  8642. entries = append(entries, &modAndMkEntries{
  8643. mod: mod,
  8644. mkEntries: ent,
  8645. })
  8646. }
  8647. }
  8648. }
  8649. var entry *modAndMkEntries = nil
  8650. for _, ent := range entries {
  8651. if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
  8652. if entry != nil {
  8653. t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
  8654. } else {
  8655. entry = ent
  8656. }
  8657. }
  8658. }
  8659. if entry == nil {
  8660. t.Errorf("AndroidMk entry for \"stublib\" missing")
  8661. } else {
  8662. isPrebuilt := entry.mod.Prebuilt() != nil
  8663. if isPrebuilt != test.usePrebuilt {
  8664. t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
  8665. }
  8666. if !entry.mod.IsStubs() {
  8667. t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
  8668. }
  8669. if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
  8670. t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
  8671. }
  8672. cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  8673. expected := "-D__STUBLIB_API__=10000"
  8674. if !android.InList(expected, cflags) {
  8675. t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
  8676. }
  8677. }
  8678. })
  8679. }
  8680. })
  8681. }
  8682. }
  8683. func TestHostApexInHostOnlyBuild(t *testing.T) {
  8684. testApex(t, `
  8685. apex {
  8686. name: "myapex",
  8687. host_supported: true,
  8688. key: "myapex.key",
  8689. updatable: false,
  8690. payload_type: "zip",
  8691. }
  8692. apex_key {
  8693. name: "myapex.key",
  8694. public_key: "testkey.avbpubkey",
  8695. private_key: "testkey.pem",
  8696. }
  8697. `,
  8698. android.FixtureModifyConfig(func(config android.Config) {
  8699. // We may not have device targets in all builds, e.g. in
  8700. // prebuilts/build-tools/build-prebuilts.sh
  8701. config.Targets[android.Android] = []android.Target{}
  8702. }))
  8703. }
  8704. func TestApexJavaCoverage(t *testing.T) {
  8705. bp := `
  8706. apex {
  8707. name: "myapex",
  8708. key: "myapex.key",
  8709. java_libs: ["mylib"],
  8710. bootclasspath_fragments: ["mybootclasspathfragment"],
  8711. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8712. updatable: false,
  8713. }
  8714. apex_key {
  8715. name: "myapex.key",
  8716. public_key: "testkey.avbpubkey",
  8717. private_key: "testkey.pem",
  8718. }
  8719. java_library {
  8720. name: "mylib",
  8721. srcs: ["mylib.java"],
  8722. apex_available: ["myapex"],
  8723. compile_dex: true,
  8724. }
  8725. bootclasspath_fragment {
  8726. name: "mybootclasspathfragment",
  8727. contents: ["mybootclasspathlib"],
  8728. apex_available: ["myapex"],
  8729. hidden_api: {
  8730. split_packages: ["*"],
  8731. },
  8732. }
  8733. java_library {
  8734. name: "mybootclasspathlib",
  8735. srcs: ["mybootclasspathlib.java"],
  8736. apex_available: ["myapex"],
  8737. compile_dex: true,
  8738. }
  8739. systemserverclasspath_fragment {
  8740. name: "mysystemserverclasspathfragment",
  8741. contents: ["mysystemserverclasspathlib"],
  8742. apex_available: ["myapex"],
  8743. }
  8744. java_library {
  8745. name: "mysystemserverclasspathlib",
  8746. srcs: ["mysystemserverclasspathlib.java"],
  8747. apex_available: ["myapex"],
  8748. compile_dex: true,
  8749. }
  8750. `
  8751. result := android.GroupFixturePreparers(
  8752. PrepareForTestWithApexBuildComponents,
  8753. prepareForTestWithMyapex,
  8754. java.PrepareForTestWithJavaDefaultModules,
  8755. android.PrepareForTestWithAndroidBuildComponents,
  8756. android.FixtureWithRootAndroidBp(bp),
  8757. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  8758. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  8759. java.PrepareForTestWithJacocoInstrumentation,
  8760. ).RunTest(t)
  8761. // Make sure jacoco ran on both mylib and mybootclasspathlib
  8762. if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8763. t.Errorf("Failed to find jacoco rule for mylib")
  8764. }
  8765. if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8766. t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
  8767. }
  8768. if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8769. t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
  8770. }
  8771. }
  8772. func TestProhibitStaticExecutable(t *testing.T) {
  8773. testApexError(t, `executable mybin is static`, `
  8774. apex {
  8775. name: "myapex",
  8776. key: "myapex.key",
  8777. binaries: ["mybin"],
  8778. min_sdk_version: "29",
  8779. }
  8780. apex_key {
  8781. name: "myapex.key",
  8782. public_key: "testkey.avbpubkey",
  8783. private_key: "testkey.pem",
  8784. }
  8785. cc_binary {
  8786. name: "mybin",
  8787. srcs: ["mylib.cpp"],
  8788. relative_install_path: "foo/bar",
  8789. static_executable: true,
  8790. system_shared_libs: [],
  8791. stl: "none",
  8792. apex_available: [ "myapex" ],
  8793. min_sdk_version: "29",
  8794. }
  8795. `)
  8796. testApexError(t, `executable mybin.rust is static`, `
  8797. apex {
  8798. name: "myapex",
  8799. key: "myapex.key",
  8800. binaries: ["mybin.rust"],
  8801. min_sdk_version: "29",
  8802. }
  8803. apex_key {
  8804. name: "myapex.key",
  8805. public_key: "testkey.avbpubkey",
  8806. private_key: "testkey.pem",
  8807. }
  8808. rust_binary {
  8809. name: "mybin.rust",
  8810. srcs: ["foo.rs"],
  8811. static_executable: true,
  8812. apex_available: ["myapex"],
  8813. min_sdk_version: "29",
  8814. }
  8815. `)
  8816. }
  8817. func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
  8818. ctx := testApex(t, `
  8819. apex {
  8820. name: "myapex",
  8821. key: "myapex.key",
  8822. updatable: false,
  8823. java_libs: ["foo"],
  8824. }
  8825. apex_key {
  8826. name: "myapex.key",
  8827. public_key: "testkey.avbpubkey",
  8828. private_key: "testkey.pem",
  8829. }
  8830. java_library {
  8831. name: "foo",
  8832. srcs: ["foo.java"],
  8833. apex_available: ["myapex"],
  8834. installable: true,
  8835. }
  8836. `,
  8837. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  8838. )
  8839. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8840. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  8841. var builder strings.Builder
  8842. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  8843. androidMk := builder.String()
  8844. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex\n")
  8845. }
  8846. func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
  8847. ctx := testApex(t, `
  8848. prebuilt_apex {
  8849. name: "myapex",
  8850. arch: {
  8851. arm64: {
  8852. src: "myapex-arm64.apex",
  8853. },
  8854. arm: {
  8855. src: "myapex-arm.apex",
  8856. },
  8857. },
  8858. exported_java_libs: ["foo"],
  8859. }
  8860. java_import {
  8861. name: "foo",
  8862. jars: ["foo.jar"],
  8863. apex_available: ["myapex"],
  8864. }
  8865. `,
  8866. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  8867. )
  8868. prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  8869. entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
  8870. mainModuleEntries := entriesList[0]
  8871. android.AssertArrayString(t,
  8872. "LOCAL_REQUIRED_MODULES",
  8873. mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
  8874. []string{
  8875. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
  8876. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
  8877. })
  8878. }
  8879. func TestAndroidMk_RequiredModules(t *testing.T) {
  8880. ctx := testApex(t, `
  8881. apex {
  8882. name: "myapex",
  8883. key: "myapex.key",
  8884. updatable: false,
  8885. java_libs: ["foo"],
  8886. required: ["otherapex"],
  8887. }
  8888. apex {
  8889. name: "otherapex",
  8890. key: "myapex.key",
  8891. updatable: false,
  8892. java_libs: ["foo"],
  8893. required: ["otherapex"],
  8894. }
  8895. apex_key {
  8896. name: "myapex.key",
  8897. public_key: "testkey.avbpubkey",
  8898. private_key: "testkey.pem",
  8899. }
  8900. java_library {
  8901. name: "foo",
  8902. srcs: ["foo.java"],
  8903. apex_available: ["myapex", "otherapex"],
  8904. installable: true,
  8905. }
  8906. `)
  8907. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8908. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  8909. var builder strings.Builder
  8910. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  8911. androidMk := builder.String()
  8912. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex otherapex")
  8913. }
  8914. func TestAndroidMk_RequiredDeps(t *testing.T) {
  8915. ctx := testApex(t, `
  8916. apex {
  8917. name: "myapex",
  8918. key: "myapex.key",
  8919. updatable: false,
  8920. }
  8921. apex_key {
  8922. name: "myapex.key",
  8923. public_key: "testkey.avbpubkey",
  8924. private_key: "testkey.pem",
  8925. }
  8926. `)
  8927. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8928. bundle.makeModulesToInstall = append(bundle.makeModulesToInstall, "foo")
  8929. data := android.AndroidMkDataForTest(t, ctx, bundle)
  8930. var builder strings.Builder
  8931. data.Custom(&builder, bundle.BaseModuleName(), "TARGET_", "", data)
  8932. androidMk := builder.String()
  8933. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo\n")
  8934. }
  8935. func TestApexOutputFileProducer(t *testing.T) {
  8936. for _, tc := range []struct {
  8937. name string
  8938. ref string
  8939. expected_data []string
  8940. }{
  8941. {
  8942. name: "test_using_output",
  8943. ref: ":myapex",
  8944. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.capex:myapex.capex"},
  8945. },
  8946. {
  8947. name: "test_using_apex",
  8948. ref: ":myapex{.apex}",
  8949. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.apex:myapex.apex"},
  8950. },
  8951. } {
  8952. t.Run(tc.name, func(t *testing.T) {
  8953. ctx := testApex(t, `
  8954. apex {
  8955. name: "myapex",
  8956. key: "myapex.key",
  8957. compressible: true,
  8958. updatable: false,
  8959. }
  8960. apex_key {
  8961. name: "myapex.key",
  8962. public_key: "testkey.avbpubkey",
  8963. private_key: "testkey.pem",
  8964. }
  8965. java_test {
  8966. name: "`+tc.name+`",
  8967. srcs: ["a.java"],
  8968. data: ["`+tc.ref+`"],
  8969. }
  8970. `,
  8971. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  8972. variables.CompressedApex = proptools.BoolPtr(true)
  8973. }))
  8974. javaTest := ctx.ModuleForTests(tc.name, "android_common").Module().(*java.Test)
  8975. data := android.AndroidMkEntriesForTest(t, ctx, javaTest)[0].EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
  8976. android.AssertStringPathsRelativeToTopEquals(t, "data", ctx.Config(), tc.expected_data, data)
  8977. })
  8978. }
  8979. }
  8980. func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
  8981. preparer := android.GroupFixturePreparers(
  8982. PrepareForTestWithApexBuildComponents,
  8983. prepareForTestWithMyapex,
  8984. java.PrepareForTestWithJavaSdkLibraryFiles,
  8985. java.PrepareForTestWithJavaDefaultModules,
  8986. android.PrepareForTestWithAndroidBuildComponents,
  8987. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  8988. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  8989. )
  8990. // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
  8991. t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  8992. preparer.RunTestWithBp(t, `
  8993. apex {
  8994. name: "myapex",
  8995. key: "myapex.key",
  8996. bootclasspath_fragments: ["mybootclasspathfragment"],
  8997. min_sdk_version: "30",
  8998. updatable: false,
  8999. }
  9000. apex_key {
  9001. name: "myapex.key",
  9002. public_key: "testkey.avbpubkey",
  9003. private_key: "testkey.pem",
  9004. }
  9005. bootclasspath_fragment {
  9006. name: "mybootclasspathfragment",
  9007. contents: ["mybootclasspathlib"],
  9008. apex_available: ["myapex"],
  9009. hidden_api: {
  9010. split_packages: ["*"],
  9011. },
  9012. }
  9013. java_sdk_library {
  9014. name: "mybootclasspathlib",
  9015. srcs: ["mybootclasspathlib.java"],
  9016. apex_available: ["myapex"],
  9017. compile_dex: true,
  9018. unsafe_ignore_missing_latest_api: true,
  9019. min_sdk_version: "31",
  9020. static_libs: ["util"],
  9021. }
  9022. java_library {
  9023. name: "util",
  9024. srcs: ["a.java"],
  9025. apex_available: ["myapex"],
  9026. min_sdk_version: "31",
  9027. static_libs: ["another_util"],
  9028. }
  9029. java_library {
  9030. name: "another_util",
  9031. srcs: ["a.java"],
  9032. min_sdk_version: "31",
  9033. apex_available: ["myapex"],
  9034. }
  9035. `)
  9036. })
  9037. // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
  9038. t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  9039. preparer.RunTestWithBp(t, `
  9040. apex {
  9041. name: "myapex",
  9042. key: "myapex.key",
  9043. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  9044. min_sdk_version: "30",
  9045. updatable: false,
  9046. }
  9047. apex_key {
  9048. name: "myapex.key",
  9049. public_key: "testkey.avbpubkey",
  9050. private_key: "testkey.pem",
  9051. }
  9052. systemserverclasspath_fragment {
  9053. name: "mysystemserverclasspathfragment",
  9054. contents: ["mysystemserverclasspathlib"],
  9055. apex_available: ["myapex"],
  9056. }
  9057. java_sdk_library {
  9058. name: "mysystemserverclasspathlib",
  9059. srcs: ["mysystemserverclasspathlib.java"],
  9060. apex_available: ["myapex"],
  9061. compile_dex: true,
  9062. min_sdk_version: "32",
  9063. unsafe_ignore_missing_latest_api: true,
  9064. static_libs: ["util"],
  9065. }
  9066. java_library {
  9067. name: "util",
  9068. srcs: ["a.java"],
  9069. apex_available: ["myapex"],
  9070. min_sdk_version: "31",
  9071. static_libs: ["another_util"],
  9072. }
  9073. java_library {
  9074. name: "another_util",
  9075. srcs: ["a.java"],
  9076. min_sdk_version: "31",
  9077. apex_available: ["myapex"],
  9078. }
  9079. `)
  9080. })
  9081. t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  9082. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
  9083. RunTestWithBp(t, `
  9084. apex {
  9085. name: "myapex",
  9086. key: "myapex.key",
  9087. bootclasspath_fragments: ["mybootclasspathfragment"],
  9088. min_sdk_version: "30",
  9089. updatable: false,
  9090. }
  9091. apex_key {
  9092. name: "myapex.key",
  9093. public_key: "testkey.avbpubkey",
  9094. private_key: "testkey.pem",
  9095. }
  9096. bootclasspath_fragment {
  9097. name: "mybootclasspathfragment",
  9098. contents: ["mybootclasspathlib"],
  9099. apex_available: ["myapex"],
  9100. hidden_api: {
  9101. split_packages: ["*"],
  9102. },
  9103. }
  9104. java_sdk_library {
  9105. name: "mybootclasspathlib",
  9106. srcs: ["mybootclasspathlib.java"],
  9107. apex_available: ["myapex"],
  9108. compile_dex: true,
  9109. unsafe_ignore_missing_latest_api: true,
  9110. }
  9111. `)
  9112. })
  9113. t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  9114. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
  9115. RunTestWithBp(t, `
  9116. apex {
  9117. name: "myapex",
  9118. key: "myapex.key",
  9119. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  9120. min_sdk_version: "30",
  9121. updatable: false,
  9122. }
  9123. apex_key {
  9124. name: "myapex.key",
  9125. public_key: "testkey.avbpubkey",
  9126. private_key: "testkey.pem",
  9127. }
  9128. systemserverclasspath_fragment {
  9129. name: "mysystemserverclasspathfragment",
  9130. contents: ["mysystemserverclasspathlib"],
  9131. apex_available: ["myapex"],
  9132. }
  9133. java_sdk_library {
  9134. name: "mysystemserverclasspathlib",
  9135. srcs: ["mysystemserverclasspathlib.java"],
  9136. apex_available: ["myapex"],
  9137. compile_dex: true,
  9138. unsafe_ignore_missing_latest_api: true,
  9139. }
  9140. `)
  9141. })
  9142. }
  9143. // Verifies that the APEX depends on all the Make modules in the list.
  9144. func ensureContainsRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  9145. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  9146. for _, dep := range deps {
  9147. android.AssertStringListContains(t, "", a.makeModulesToInstall, dep)
  9148. }
  9149. }
  9150. // Verifies that the APEX does not depend on any of the Make modules in the list.
  9151. func ensureDoesNotContainRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  9152. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  9153. for _, dep := range deps {
  9154. android.AssertStringListDoesNotContain(t, "", a.makeModulesToInstall, dep)
  9155. }
  9156. }
  9157. // TODO(b/193460475): Re-enable this test
  9158. //func TestApexStrictUpdtabilityLint(t *testing.T) {
  9159. // bpTemplate := `
  9160. // apex {
  9161. // name: "myapex",
  9162. // key: "myapex.key",
  9163. // java_libs: ["myjavalib"],
  9164. // updatable: %v,
  9165. // min_sdk_version: "29",
  9166. // }
  9167. // apex_key {
  9168. // name: "myapex.key",
  9169. // }
  9170. // java_library {
  9171. // name: "myjavalib",
  9172. // srcs: ["MyClass.java"],
  9173. // apex_available: [ "myapex" ],
  9174. // lint: {
  9175. // strict_updatability_linting: %v,
  9176. // },
  9177. // sdk_version: "current",
  9178. // min_sdk_version: "29",
  9179. // }
  9180. // `
  9181. // fs := android.MockFS{
  9182. // "lint-baseline.xml": nil,
  9183. // }
  9184. //
  9185. // testCases := []struct {
  9186. // testCaseName string
  9187. // apexUpdatable bool
  9188. // javaStrictUpdtabilityLint bool
  9189. // lintFileExists bool
  9190. // disallowedFlagExpected bool
  9191. // }{
  9192. // {
  9193. // testCaseName: "lint-baseline.xml does not exist, no disallowed flag necessary in lint cmd",
  9194. // apexUpdatable: true,
  9195. // javaStrictUpdtabilityLint: true,
  9196. // lintFileExists: false,
  9197. // disallowedFlagExpected: false,
  9198. // },
  9199. // {
  9200. // testCaseName: "non-updatable apex respects strict_updatability of javalib",
  9201. // apexUpdatable: false,
  9202. // javaStrictUpdtabilityLint: false,
  9203. // lintFileExists: true,
  9204. // disallowedFlagExpected: false,
  9205. // },
  9206. // {
  9207. // testCaseName: "non-updatable apex respects strict updatability of javalib",
  9208. // apexUpdatable: false,
  9209. // javaStrictUpdtabilityLint: true,
  9210. // lintFileExists: true,
  9211. // disallowedFlagExpected: true,
  9212. // },
  9213. // {
  9214. // testCaseName: "updatable apex sets strict updatability of javalib to true",
  9215. // apexUpdatable: true,
  9216. // javaStrictUpdtabilityLint: false, // will be set to true by mutator
  9217. // lintFileExists: true,
  9218. // disallowedFlagExpected: true,
  9219. // },
  9220. // }
  9221. //
  9222. // for _, testCase := range testCases {
  9223. // bp := fmt.Sprintf(bpTemplate, testCase.apexUpdatable, testCase.javaStrictUpdtabilityLint)
  9224. // fixtures := []android.FixturePreparer{}
  9225. // if testCase.lintFileExists {
  9226. // fixtures = append(fixtures, fs.AddToFixture())
  9227. // }
  9228. //
  9229. // result := testApex(t, bp, fixtures...)
  9230. // myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  9231. // sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  9232. // disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi")
  9233. //
  9234. // if disallowedFlagActual != testCase.disallowedFlagExpected {
  9235. // t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  9236. // }
  9237. // }
  9238. //}
  9239. //
  9240. //func TestUpdatabilityLintSkipLibcore(t *testing.T) {
  9241. // bp := `
  9242. // apex {
  9243. // name: "myapex",
  9244. // key: "myapex.key",
  9245. // java_libs: ["myjavalib"],
  9246. // updatable: true,
  9247. // min_sdk_version: "29",
  9248. // }
  9249. // apex_key {
  9250. // name: "myapex.key",
  9251. // }
  9252. // java_library {
  9253. // name: "myjavalib",
  9254. // srcs: ["MyClass.java"],
  9255. // apex_available: [ "myapex" ],
  9256. // sdk_version: "current",
  9257. // min_sdk_version: "29",
  9258. // }
  9259. // `
  9260. //
  9261. // testCases := []struct {
  9262. // testCaseName string
  9263. // moduleDirectory string
  9264. // disallowedFlagExpected bool
  9265. // }{
  9266. // {
  9267. // testCaseName: "lintable module defined outside libcore",
  9268. // moduleDirectory: "",
  9269. // disallowedFlagExpected: true,
  9270. // },
  9271. // {
  9272. // testCaseName: "lintable module defined in libcore root directory",
  9273. // moduleDirectory: "libcore/",
  9274. // disallowedFlagExpected: false,
  9275. // },
  9276. // {
  9277. // testCaseName: "lintable module defined in libcore child directory",
  9278. // moduleDirectory: "libcore/childdir/",
  9279. // disallowedFlagExpected: true,
  9280. // },
  9281. // }
  9282. //
  9283. // for _, testCase := range testCases {
  9284. // lintFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"lint-baseline.xml", "")
  9285. // bpFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"Android.bp", bp)
  9286. // result := testApex(t, "", lintFileCreator, bpFileCreator)
  9287. // myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  9288. // sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  9289. // cmdFlags := fmt.Sprintf("--baseline %vlint-baseline.xml --disallowed_issues NewApi", testCase.moduleDirectory)
  9290. // disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, cmdFlags)
  9291. //
  9292. // if disallowedFlagActual != testCase.disallowedFlagExpected {
  9293. // t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  9294. // }
  9295. // }
  9296. //}
  9297. //
  9298. //// checks transtive deps of an apex coming from bootclasspath_fragment
  9299. //func TestApexStrictUpdtabilityLintBcpFragmentDeps(t *testing.T) {
  9300. // bp := `
  9301. // apex {
  9302. // name: "myapex",
  9303. // key: "myapex.key",
  9304. // bootclasspath_fragments: ["mybootclasspathfragment"],
  9305. // updatable: true,
  9306. // min_sdk_version: "29",
  9307. // }
  9308. // apex_key {
  9309. // name: "myapex.key",
  9310. // }
  9311. // bootclasspath_fragment {
  9312. // name: "mybootclasspathfragment",
  9313. // contents: ["myjavalib"],
  9314. // apex_available: ["myapex"],
  9315. // hidden_api: {
  9316. // split_packages: ["*"],
  9317. // },
  9318. // }
  9319. // java_library {
  9320. // name: "myjavalib",
  9321. // srcs: ["MyClass.java"],
  9322. // apex_available: [ "myapex" ],
  9323. // sdk_version: "current",
  9324. // min_sdk_version: "29",
  9325. // compile_dex: true,
  9326. // }
  9327. // `
  9328. // fs := android.MockFS{
  9329. // "lint-baseline.xml": nil,
  9330. // }
  9331. //
  9332. // result := testApex(t, bp, dexpreopt.FixtureSetApexBootJars("myapex:myjavalib"), fs.AddToFixture())
  9333. // myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  9334. // sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  9335. // if !strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi") {
  9336. // t.Errorf("Strict updabality lint missing in myjavalib coming from bootclasspath_fragment mybootclasspath-fragment\nActual lint cmd: %v", *sboxProto.Commands[0].Command)
  9337. // }
  9338. //}
  9339. // updatable apexes should propagate updatable=true to its apps
  9340. func TestUpdatableApexEnforcesAppUpdatability(t *testing.T) {
  9341. bp := `
  9342. apex {
  9343. name: "myapex",
  9344. key: "myapex.key",
  9345. updatable: %v,
  9346. apps: [
  9347. "myapp",
  9348. ],
  9349. min_sdk_version: "30",
  9350. }
  9351. apex_key {
  9352. name: "myapex.key",
  9353. }
  9354. android_app {
  9355. name: "myapp",
  9356. updatable: %v,
  9357. apex_available: [
  9358. "myapex",
  9359. ],
  9360. sdk_version: "current",
  9361. min_sdk_version: "30",
  9362. }
  9363. `
  9364. testCases := []struct {
  9365. name string
  9366. apex_is_updatable_bp bool
  9367. app_is_updatable_bp bool
  9368. app_is_updatable_expected bool
  9369. }{
  9370. {
  9371. name: "Non-updatable apex respects updatable property of non-updatable app",
  9372. apex_is_updatable_bp: false,
  9373. app_is_updatable_bp: false,
  9374. app_is_updatable_expected: false,
  9375. },
  9376. {
  9377. name: "Non-updatable apex respects updatable property of updatable app",
  9378. apex_is_updatable_bp: false,
  9379. app_is_updatable_bp: true,
  9380. app_is_updatable_expected: true,
  9381. },
  9382. {
  9383. name: "Updatable apex respects updatable property of updatable app",
  9384. apex_is_updatable_bp: true,
  9385. app_is_updatable_bp: true,
  9386. app_is_updatable_expected: true,
  9387. },
  9388. {
  9389. name: "Updatable apex sets updatable=true on non-updatable app",
  9390. apex_is_updatable_bp: true,
  9391. app_is_updatable_bp: false,
  9392. app_is_updatable_expected: true,
  9393. },
  9394. }
  9395. for _, testCase := range testCases {
  9396. result := testApex(t, fmt.Sprintf(bp, testCase.apex_is_updatable_bp, testCase.app_is_updatable_bp))
  9397. myapp := result.ModuleForTests("myapp", "android_common").Module().(*java.AndroidApp)
  9398. android.AssertBoolEquals(t, testCase.name, testCase.app_is_updatable_expected, myapp.Updatable())
  9399. }
  9400. }
  9401. func TestApexBuildsAgainstApiSurfaceStubLibraries(t *testing.T) {
  9402. bp := `
  9403. apex {
  9404. name: "myapex",
  9405. key: "myapex.key",
  9406. native_shared_libs: ["libbaz"],
  9407. binaries: ["binfoo"],
  9408. min_sdk_version: "29",
  9409. }
  9410. apex_key {
  9411. name: "myapex.key",
  9412. }
  9413. cc_binary {
  9414. name: "binfoo",
  9415. shared_libs: ["libbar", "libbaz", "libqux",],
  9416. apex_available: ["myapex"],
  9417. min_sdk_version: "29",
  9418. recovery_available: false,
  9419. }
  9420. cc_library {
  9421. name: "libbar",
  9422. srcs: ["libbar.cc"],
  9423. stubs: {
  9424. symbol_file: "libbar.map.txt",
  9425. versions: [
  9426. "29",
  9427. ],
  9428. },
  9429. }
  9430. cc_library {
  9431. name: "libbaz",
  9432. srcs: ["libbaz.cc"],
  9433. apex_available: ["myapex"],
  9434. min_sdk_version: "29",
  9435. stubs: {
  9436. symbol_file: "libbaz.map.txt",
  9437. versions: [
  9438. "29",
  9439. ],
  9440. },
  9441. }
  9442. cc_api_library {
  9443. name: "libbar",
  9444. src: "libbar_stub.so",
  9445. min_sdk_version: "29",
  9446. variants: ["apex.29"],
  9447. }
  9448. cc_api_variant {
  9449. name: "libbar",
  9450. variant: "apex",
  9451. version: "29",
  9452. src: "libbar_apex_29.so",
  9453. }
  9454. cc_api_library {
  9455. name: "libbaz",
  9456. src: "libbaz_stub.so",
  9457. min_sdk_version: "29",
  9458. variants: ["apex.29"],
  9459. }
  9460. cc_api_variant {
  9461. name: "libbaz",
  9462. variant: "apex",
  9463. version: "29",
  9464. src: "libbaz_apex_29.so",
  9465. }
  9466. cc_api_library {
  9467. name: "libqux",
  9468. src: "libqux_stub.so",
  9469. min_sdk_version: "29",
  9470. variants: ["apex.29"],
  9471. }
  9472. cc_api_variant {
  9473. name: "libqux",
  9474. variant: "apex",
  9475. version: "29",
  9476. src: "libqux_apex_29.so",
  9477. }
  9478. api_imports {
  9479. name: "api_imports",
  9480. apex_shared_libs: [
  9481. "libbar",
  9482. "libbaz",
  9483. "libqux",
  9484. ],
  9485. }
  9486. `
  9487. result := testApex(t, bp)
  9488. hasDep := func(m android.Module, wantDep android.Module) bool {
  9489. t.Helper()
  9490. var found bool
  9491. result.VisitDirectDeps(m, func(dep blueprint.Module) {
  9492. if dep == wantDep {
  9493. found = true
  9494. }
  9495. })
  9496. return found
  9497. }
  9498. // Library defines stubs and cc_api_library should be used with cc_api_library
  9499. binfooApexVariant := result.ModuleForTests("binfoo", "android_arm64_armv8-a_apex29").Module()
  9500. libbarCoreVariant := result.ModuleForTests("libbar", "android_arm64_armv8-a_shared").Module()
  9501. libbarApiImportCoreVariant := result.ModuleForTests("libbar.apiimport", "android_arm64_armv8-a_shared").Module()
  9502. android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries", true, hasDep(binfooApexVariant, libbarApiImportCoreVariant))
  9503. android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbarCoreVariant))
  9504. binFooCFlags := result.ModuleForTests("binfoo", "android_arm64_armv8-a_apex29").Rule("ld").Args["libFlags"]
  9505. android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbar.apex.29.apiimport.so")
  9506. android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbar.apiimport.so")
  9507. android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbar.so")
  9508. // Library defined in the same APEX should be linked with original definition instead of cc_api_library
  9509. libbazApexVariant := result.ModuleForTests("libbaz", "android_arm64_armv8-a_shared_apex29").Module()
  9510. libbazApiImportCoreVariant := result.ModuleForTests("libbaz.apiimport", "android_arm64_armv8-a_shared").Module()
  9511. android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries even from same APEX", true, hasDep(binfooApexVariant, libbazApiImportCoreVariant))
  9512. android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbazApexVariant))
  9513. android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbaz.so")
  9514. android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbaz.apiimport.so")
  9515. android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbaz.apex.29.apiimport.so")
  9516. // cc_api_library defined without original library should be linked with cc_api_library
  9517. libquxApiImportApexVariant := result.ModuleForTests("libqux.apiimport", "android_arm64_armv8-a_shared").Module()
  9518. android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries even original library definition does not exist", true, hasDep(binfooApexVariant, libquxApiImportApexVariant))
  9519. android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libqux.apex.29.apiimport.so")
  9520. }
  9521. func TestPlatformBinaryBuildsAgainstApiSurfaceStubLibraries(t *testing.T) {
  9522. bp := `
  9523. apex {
  9524. name: "myapex",
  9525. key: "myapex.key",
  9526. native_shared_libs: ["libbar"],
  9527. min_sdk_version: "29",
  9528. }
  9529. apex_key {
  9530. name: "myapex.key",
  9531. }
  9532. cc_binary {
  9533. name: "binfoo",
  9534. shared_libs: ["libbar"],
  9535. recovery_available: false,
  9536. }
  9537. cc_library {
  9538. name: "libbar",
  9539. srcs: ["libbar.cc"],
  9540. apex_available: ["myapex"],
  9541. min_sdk_version: "29",
  9542. stubs: {
  9543. symbol_file: "libbar.map.txt",
  9544. versions: [
  9545. "29",
  9546. ],
  9547. },
  9548. }
  9549. cc_api_library {
  9550. name: "libbar",
  9551. src: "libbar_stub.so",
  9552. variants: ["apex.29"],
  9553. }
  9554. cc_api_variant {
  9555. name: "libbar",
  9556. variant: "apex",
  9557. version: "29",
  9558. src: "libbar_apex_29.so",
  9559. }
  9560. api_imports {
  9561. name: "api_imports",
  9562. apex_shared_libs: [
  9563. "libbar",
  9564. ],
  9565. }
  9566. `
  9567. result := testApex(t, bp)
  9568. hasDep := func(m android.Module, wantDep android.Module) bool {
  9569. t.Helper()
  9570. var found bool
  9571. result.VisitDirectDeps(m, func(dep blueprint.Module) {
  9572. if dep == wantDep {
  9573. found = true
  9574. }
  9575. })
  9576. return found
  9577. }
  9578. // Library defines stubs and cc_api_library should be used with cc_api_library
  9579. binfooApexVariant := result.ModuleForTests("binfoo", "android_arm64_armv8-a").Module()
  9580. libbarCoreVariant := result.ModuleForTests("libbar", "android_arm64_armv8-a_shared").Module()
  9581. libbarApiImportCoreVariant := result.ModuleForTests("libbar.apiimport", "android_arm64_armv8-a_shared").Module()
  9582. android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries", true, hasDep(binfooApexVariant, libbarApiImportCoreVariant))
  9583. android.AssertBoolEquals(t, "apex variant should link against original library if exists", true, hasDep(binfooApexVariant, libbarCoreVariant))
  9584. binFooCFlags := result.ModuleForTests("binfoo", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  9585. android.AssertStringDoesContain(t, "binfoo should link against APEX variant", binFooCFlags, "libbar.apex.29.apiimport.so")
  9586. android.AssertStringDoesNotContain(t, "binfoo should not link against cc_api_library itself", binFooCFlags, "libbar.apiimport.so")
  9587. android.AssertStringDoesNotContain(t, "binfoo should not link against original definition", binFooCFlags, "libbar.so")
  9588. }
  9589. func TestTrimmedApex(t *testing.T) {
  9590. bp := `
  9591. apex {
  9592. name: "myapex",
  9593. key: "myapex.key",
  9594. native_shared_libs: ["libfoo","libbaz"],
  9595. min_sdk_version: "29",
  9596. trim_against: "mydcla",
  9597. }
  9598. apex {
  9599. name: "mydcla",
  9600. key: "myapex.key",
  9601. native_shared_libs: ["libfoo","libbar"],
  9602. min_sdk_version: "29",
  9603. file_contexts: ":myapex-file_contexts",
  9604. dynamic_common_lib_apex: true,
  9605. }
  9606. apex_key {
  9607. name: "myapex.key",
  9608. }
  9609. cc_library {
  9610. name: "libfoo",
  9611. shared_libs: ["libc"],
  9612. apex_available: ["myapex","mydcla"],
  9613. min_sdk_version: "29",
  9614. }
  9615. cc_library {
  9616. name: "libbar",
  9617. shared_libs: ["libc"],
  9618. apex_available: ["myapex","mydcla"],
  9619. min_sdk_version: "29",
  9620. }
  9621. cc_library {
  9622. name: "libbaz",
  9623. shared_libs: ["libc"],
  9624. apex_available: ["myapex","mydcla"],
  9625. min_sdk_version: "29",
  9626. }
  9627. cc_api_library {
  9628. name: "libc",
  9629. src: "libc.so",
  9630. min_sdk_version: "29",
  9631. recovery_available: true,
  9632. }
  9633. api_imports {
  9634. name: "api_imports",
  9635. shared_libs: [
  9636. "libc",
  9637. ],
  9638. header_libs: [],
  9639. }
  9640. `
  9641. ctx := testApex(t, bp)
  9642. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  9643. apexRule := module.MaybeRule("apexRule")
  9644. if apexRule.Rule == nil {
  9645. t.Errorf("Expecting regular apex rule but a non regular apex rule found")
  9646. }
  9647. ctx = testApex(t, bp, android.FixtureModifyConfig(android.SetTrimmedApexEnabledForTests))
  9648. trimmedApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("TrimmedApexRule")
  9649. libs_to_trim := trimmedApexRule.Args["libs_to_trim"]
  9650. android.AssertStringDoesContain(t, "missing lib to trim", libs_to_trim, "libfoo")
  9651. android.AssertStringDoesContain(t, "missing lib to trim", libs_to_trim, "libbar")
  9652. android.AssertStringDoesNotContain(t, "unexpected libs in the libs to trim", libs_to_trim, "libbaz")
  9653. }
  9654. func TestCannedFsConfig(t *testing.T) {
  9655. ctx := testApex(t, `
  9656. apex {
  9657. name: "myapex",
  9658. key: "myapex.key",
  9659. updatable: false,
  9660. }
  9661. apex_key {
  9662. name: "myapex.key",
  9663. public_key: "testkey.avbpubkey",
  9664. private_key: "testkey.pem",
  9665. }`)
  9666. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  9667. generateFsRule := mod.Rule("generateFsConfig")
  9668. cmd := generateFsRule.RuleParams.Command
  9669. ensureContains(t, cmd, `( echo '/ 1000 1000 0755'; echo '/apex_manifest.json 1000 1000 0644'; echo '/apex_manifest.pb 1000 1000 0644'; ) >`)
  9670. }
  9671. func TestCannedFsConfig_HasCustomConfig(t *testing.T) {
  9672. ctx := testApex(t, `
  9673. apex {
  9674. name: "myapex",
  9675. key: "myapex.key",
  9676. canned_fs_config: "my_config",
  9677. updatable: false,
  9678. }
  9679. apex_key {
  9680. name: "myapex.key",
  9681. public_key: "testkey.avbpubkey",
  9682. private_key: "testkey.pem",
  9683. }`)
  9684. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  9685. generateFsRule := mod.Rule("generateFsConfig")
  9686. cmd := generateFsRule.RuleParams.Command
  9687. // Ensure that canned_fs_config has "cat my_config" at the end
  9688. ensureContains(t, cmd, `( echo '/ 1000 1000 0755'; echo '/apex_manifest.json 1000 1000 0644'; echo '/apex_manifest.pb 1000 1000 0644'; cat my_config ) >`)
  9689. }
  9690. func TestStubLibrariesMultipleApexViolation(t *testing.T) {
  9691. testCases := []struct {
  9692. desc string
  9693. hasStubs bool
  9694. apexAvailable string
  9695. expectedError string
  9696. }{
  9697. {
  9698. desc: "non-stub library can have multiple apex_available",
  9699. hasStubs: false,
  9700. apexAvailable: `["myapex", "otherapex"]`,
  9701. },
  9702. {
  9703. desc: "stub library should not be available to anyapex",
  9704. hasStubs: true,
  9705. apexAvailable: `["//apex_available:anyapex"]`,
  9706. expectedError: "Stub libraries should have a single apex_available.*anyapex",
  9707. },
  9708. {
  9709. desc: "stub library should not be available to multiple apexes",
  9710. hasStubs: true,
  9711. apexAvailable: `["myapex", "otherapex"]`,
  9712. expectedError: "Stub libraries should have a single apex_available.*myapex.*otherapex",
  9713. },
  9714. {
  9715. desc: "stub library can be available to a core apex and a test apex",
  9716. hasStubs: true,
  9717. apexAvailable: `["myapex", "test_myapex"]`,
  9718. },
  9719. }
  9720. bpTemplate := `
  9721. cc_library {
  9722. name: "libfoo",
  9723. %v
  9724. apex_available: %v,
  9725. }
  9726. apex {
  9727. name: "myapex",
  9728. key: "apex.key",
  9729. updatable: false,
  9730. native_shared_libs: ["libfoo"],
  9731. }
  9732. apex {
  9733. name: "otherapex",
  9734. key: "apex.key",
  9735. updatable: false,
  9736. }
  9737. apex_test {
  9738. name: "test_myapex",
  9739. key: "apex.key",
  9740. updatable: false,
  9741. native_shared_libs: ["libfoo"],
  9742. }
  9743. apex_key {
  9744. name: "apex.key",
  9745. }
  9746. `
  9747. for _, tc := range testCases {
  9748. stubs := ""
  9749. if tc.hasStubs {
  9750. stubs = `stubs: {symbol_file: "libfoo.map.txt"},`
  9751. }
  9752. bp := fmt.Sprintf(bpTemplate, stubs, tc.apexAvailable)
  9753. mockFsFixturePreparer := android.FixtureModifyMockFS(func(fs android.MockFS) {
  9754. fs["system/sepolicy/apex/test_myapex-file_contexts"] = nil
  9755. })
  9756. if tc.expectedError == "" {
  9757. testApex(t, bp, mockFsFixturePreparer)
  9758. } else {
  9759. testApexError(t, tc.expectedError, bp, mockFsFixturePreparer)
  9760. }
  9761. }
  9762. }
  9763. func TestFileSystemShouldSkipApexLibraries(t *testing.T) {
  9764. context := android.GroupFixturePreparers(
  9765. android.PrepareForIntegrationTestWithAndroid,
  9766. cc.PrepareForIntegrationTestWithCc,
  9767. PrepareForTestWithApexBuildComponents,
  9768. prepareForTestWithMyapex,
  9769. filesystem.PrepareForTestWithFilesystemBuildComponents,
  9770. )
  9771. result := context.RunTestWithBp(t, `
  9772. android_system_image {
  9773. name: "myfilesystem",
  9774. deps: [
  9775. "libfoo",
  9776. ],
  9777. linker_config_src: "linker.config.json",
  9778. }
  9779. cc_library {
  9780. name: "libfoo",
  9781. shared_libs: [
  9782. "libbar",
  9783. ],
  9784. stl: "none",
  9785. }
  9786. cc_library {
  9787. name: "libbar",
  9788. stl: "none",
  9789. apex_available: ["myapex"],
  9790. }
  9791. apex {
  9792. name: "myapex",
  9793. native_shared_libs: ["libbar"],
  9794. key: "myapex.key",
  9795. updatable: false,
  9796. }
  9797. apex_key {
  9798. name: "myapex.key",
  9799. public_key: "testkey.avbpubkey",
  9800. private_key: "testkey.pem",
  9801. }
  9802. `)
  9803. inputs := result.ModuleForTests("myfilesystem", "android_common").Output("deps.zip").Implicits
  9804. android.AssertStringListDoesNotContain(t, "filesystem should not have libbar",
  9805. inputs.Strings(),
  9806. "out/soong/.intermediates/libbar/android_arm64_armv8-a_shared/libbar.so")
  9807. }