apex_test.go 270 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623562456255626562756285629563056315632563356345635563656375638563956405641564256435644564556465647564856495650565156525653565456555656565756585659566056615662566356645665566656675668566956705671567256735674567556765677567856795680568156825683568456855686568756885689569056915692569356945695569656975698569957005701570257035704570557065707570857095710571157125713571457155716571757185719572057215722572357245725572657275728572957305731573257335734573557365737573857395740574157425743574457455746574757485749575057515752575357545755575657575758575957605761576257635764576557665767576857695770577157725773577457755776577757785779578057815782578357845785578657875788578957905791579257935794579557965797579857995800580158025803580458055806580758085809581058115812581358145815581658175818581958205821582258235824582558265827582858295830583158325833583458355836583758385839584058415842584358445845584658475848584958505851585258535854585558565857585858595860586158625863586458655866586758685869587058715872587358745875587658775878587958805881588258835884588558865887588858895890589158925893589458955896589758985899590059015902590359045905590659075908590959105911591259135914591559165917591859195920592159225923592459255926592759285929593059315932593359345935593659375938593959405941594259435944594559465947594859495950595159525953595459555956595759585959596059615962596359645965596659675968596959705971597259735974597559765977597859795980598159825983598459855986598759885989599059915992599359945995599659975998599960006001600260036004600560066007600860096010601160126013601460156016601760186019602060216022602360246025602660276028602960306031603260336034603560366037603860396040604160426043604460456046604760486049605060516052605360546055605660576058605960606061606260636064606560666067606860696070607160726073607460756076607760786079608060816082608360846085608660876088608960906091609260936094609560966097609860996100610161026103610461056106610761086109611061116112611361146115611661176118611961206121612261236124612561266127612861296130613161326133613461356136613761386139614061416142614361446145614661476148614961506151615261536154615561566157615861596160616161626163616461656166616761686169617061716172617361746175617661776178617961806181618261836184618561866187618861896190619161926193619461956196619761986199620062016202620362046205620662076208620962106211621262136214621562166217621862196220622162226223622462256226622762286229623062316232623362346235623662376238623962406241624262436244624562466247624862496250625162526253625462556256625762586259626062616262626362646265626662676268626962706271627262736274627562766277627862796280628162826283628462856286628762886289629062916292629362946295629662976298629963006301630263036304630563066307630863096310631163126313631463156316631763186319632063216322632363246325632663276328632963306331633263336334633563366337633863396340634163426343634463456346634763486349635063516352635363546355635663576358635963606361636263636364636563666367636863696370637163726373637463756376637763786379638063816382638363846385638663876388638963906391639263936394639563966397639863996400640164026403640464056406640764086409641064116412641364146415641664176418641964206421642264236424642564266427642864296430643164326433643464356436643764386439644064416442644364446445644664476448644964506451645264536454645564566457645864596460646164626463646464656466646764686469647064716472647364746475647664776478647964806481648264836484648564866487648864896490649164926493649464956496649764986499650065016502650365046505650665076508650965106511651265136514651565166517651865196520652165226523652465256526652765286529653065316532653365346535653665376538653965406541654265436544654565466547654865496550655165526553655465556556655765586559656065616562656365646565656665676568656965706571657265736574657565766577657865796580658165826583658465856586658765886589659065916592659365946595659665976598659966006601660266036604660566066607660866096610661166126613661466156616661766186619662066216622662366246625662666276628662966306631663266336634663566366637663866396640664166426643664466456646664766486649665066516652665366546655665666576658665966606661666266636664666566666667666866696670667166726673667466756676667766786679668066816682668366846685668666876688668966906691669266936694669566966697669866996700670167026703670467056706670767086709671067116712671367146715671667176718671967206721672267236724672567266727672867296730673167326733673467356736673767386739674067416742674367446745674667476748674967506751675267536754675567566757675867596760676167626763676467656766676767686769677067716772677367746775677667776778677967806781678267836784678567866787678867896790679167926793679467956796679767986799680068016802680368046805680668076808680968106811681268136814681568166817681868196820682168226823682468256826682768286829683068316832683368346835683668376838683968406841684268436844684568466847684868496850685168526853685468556856685768586859686068616862686368646865686668676868686968706871687268736874687568766877687868796880688168826883688468856886688768886889689068916892689368946895689668976898689969006901690269036904690569066907690869096910691169126913691469156916691769186919692069216922692369246925692669276928692969306931693269336934693569366937693869396940694169426943694469456946694769486949695069516952695369546955695669576958695969606961696269636964696569666967696869696970697169726973697469756976697769786979698069816982698369846985698669876988698969906991699269936994699569966997699869997000700170027003700470057006700770087009701070117012701370147015701670177018701970207021702270237024702570267027702870297030703170327033703470357036703770387039704070417042704370447045704670477048704970507051705270537054705570567057705870597060706170627063706470657066706770687069707070717072707370747075707670777078707970807081708270837084708570867087708870897090709170927093709470957096709770987099710071017102710371047105710671077108710971107111711271137114711571167117711871197120712171227123712471257126712771287129713071317132713371347135713671377138713971407141714271437144714571467147714871497150715171527153715471557156715771587159716071617162716371647165716671677168716971707171717271737174717571767177717871797180718171827183718471857186718771887189719071917192719371947195719671977198719972007201720272037204720572067207720872097210721172127213721472157216721772187219722072217222722372247225722672277228722972307231723272337234723572367237723872397240724172427243724472457246724772487249725072517252725372547255725672577258725972607261726272637264726572667267726872697270727172727273727472757276727772787279728072817282728372847285728672877288728972907291729272937294729572967297729872997300730173027303730473057306730773087309731073117312731373147315731673177318731973207321732273237324732573267327732873297330733173327333733473357336733773387339734073417342734373447345734673477348734973507351735273537354735573567357735873597360736173627363736473657366736773687369737073717372737373747375737673777378737973807381738273837384738573867387738873897390739173927393739473957396739773987399740074017402740374047405740674077408740974107411741274137414741574167417741874197420742174227423742474257426742774287429743074317432743374347435743674377438743974407441744274437444744574467447744874497450745174527453745474557456745774587459746074617462746374647465746674677468746974707471747274737474747574767477747874797480748174827483748474857486748774887489749074917492749374947495749674977498749975007501750275037504750575067507750875097510751175127513751475157516751775187519752075217522752375247525752675277528752975307531753275337534753575367537753875397540754175427543754475457546754775487549755075517552755375547555755675577558755975607561756275637564756575667567756875697570757175727573757475757576757775787579758075817582758375847585758675877588758975907591759275937594759575967597759875997600760176027603760476057606760776087609761076117612761376147615761676177618761976207621762276237624762576267627762876297630763176327633763476357636763776387639764076417642764376447645764676477648764976507651765276537654765576567657765876597660766176627663766476657666766776687669767076717672767376747675767676777678767976807681768276837684768576867687768876897690769176927693769476957696769776987699770077017702770377047705770677077708770977107711771277137714771577167717771877197720772177227723772477257726772777287729773077317732773377347735773677377738773977407741774277437744774577467747774877497750775177527753775477557756775777587759776077617762776377647765776677677768776977707771777277737774777577767777777877797780778177827783778477857786778777887789779077917792779377947795779677977798779978007801780278037804780578067807780878097810781178127813781478157816781778187819782078217822782378247825782678277828782978307831783278337834783578367837783878397840784178427843784478457846784778487849785078517852785378547855785678577858785978607861786278637864786578667867786878697870787178727873787478757876787778787879788078817882788378847885788678877888788978907891789278937894789578967897789878997900790179027903790479057906790779087909791079117912791379147915791679177918791979207921792279237924792579267927792879297930793179327933793479357936793779387939794079417942794379447945794679477948794979507951795279537954795579567957795879597960796179627963796479657966796779687969797079717972797379747975797679777978797979807981798279837984798579867987798879897990799179927993799479957996799779987999800080018002800380048005800680078008800980108011801280138014801580168017801880198020802180228023802480258026802780288029803080318032803380348035803680378038803980408041804280438044804580468047804880498050805180528053805480558056805780588059806080618062806380648065806680678068806980708071807280738074807580768077807880798080808180828083808480858086808780888089809080918092809380948095809680978098809981008101810281038104810581068107810881098110811181128113811481158116811781188119812081218122812381248125812681278128812981308131813281338134813581368137813881398140814181428143814481458146814781488149815081518152815381548155815681578158815981608161816281638164816581668167816881698170817181728173817481758176817781788179818081818182818381848185818681878188818981908191819281938194819581968197819881998200820182028203820482058206820782088209821082118212821382148215821682178218821982208221822282238224822582268227822882298230823182328233823482358236823782388239824082418242824382448245824682478248824982508251825282538254825582568257825882598260826182628263826482658266826782688269827082718272827382748275827682778278827982808281828282838284828582868287828882898290829182928293829482958296829782988299830083018302830383048305830683078308830983108311831283138314831583168317831883198320832183228323832483258326832783288329833083318332833383348335833683378338833983408341834283438344834583468347834883498350835183528353835483558356835783588359836083618362836383648365836683678368836983708371837283738374837583768377837883798380838183828383838483858386838783888389839083918392839383948395839683978398839984008401840284038404840584068407840884098410841184128413841484158416841784188419842084218422842384248425842684278428842984308431843284338434843584368437843884398440844184428443844484458446844784488449845084518452845384548455845684578458845984608461846284638464846584668467846884698470847184728473847484758476847784788479848084818482848384848485848684878488848984908491849284938494849584968497849884998500850185028503850485058506850785088509851085118512851385148515851685178518851985208521852285238524852585268527852885298530853185328533853485358536853785388539854085418542854385448545854685478548854985508551855285538554855585568557855885598560856185628563856485658566856785688569857085718572857385748575857685778578857985808581858285838584858585868587858885898590859185928593859485958596859785988599860086018602860386048605860686078608860986108611861286138614861586168617861886198620862186228623862486258626862786288629863086318632863386348635863686378638863986408641864286438644864586468647864886498650865186528653865486558656865786588659866086618662866386648665866686678668866986708671867286738674867586768677867886798680868186828683868486858686868786888689869086918692869386948695869686978698869987008701870287038704870587068707870887098710871187128713871487158716871787188719872087218722872387248725872687278728872987308731873287338734873587368737873887398740874187428743874487458746874787488749875087518752875387548755875687578758875987608761876287638764876587668767876887698770877187728773877487758776877787788779878087818782878387848785878687878788878987908791879287938794879587968797879887998800880188028803880488058806880788088809881088118812881388148815881688178818881988208821882288238824882588268827882888298830883188328833883488358836883788388839884088418842884388448845884688478848884988508851885288538854885588568857885888598860886188628863886488658866886788688869887088718872887388748875887688778878887988808881888288838884888588868887888888898890889188928893889488958896889788988899890089018902890389048905890689078908890989108911891289138914891589168917891889198920892189228923892489258926892789288929893089318932893389348935893689378938893989408941894289438944894589468947894889498950895189528953895489558956895789588959896089618962896389648965896689678968896989708971897289738974897589768977897889798980898189828983898489858986898789888989899089918992899389948995899689978998899990009001900290039004900590069007900890099010901190129013901490159016901790189019902090219022902390249025902690279028902990309031903290339034903590369037903890399040904190429043904490459046904790489049905090519052905390549055905690579058905990609061906290639064906590669067906890699070907190729073907490759076907790789079908090819082908390849085908690879088908990909091909290939094909590969097909890999100910191029103910491059106910791089109911091119112911391149115911691179118911991209121912291239124912591269127912891299130913191329133913491359136913791389139914091419142914391449145914691479148914991509151915291539154915591569157915891599160916191629163916491659166916791689169917091719172917391749175917691779178917991809181918291839184918591869187918891899190919191929193919491959196919791989199920092019202920392049205920692079208920992109211921292139214921592169217921892199220922192229223922492259226922792289229923092319232923392349235923692379238923992409241924292439244924592469247924892499250925192529253925492559256925792589259926092619262926392649265926692679268926992709271927292739274927592769277927892799280928192829283928492859286928792889289929092919292929392949295929692979298929993009301930293039304930593069307930893099310931193129313931493159316931793189319932093219322932393249325932693279328932993309331933293339334933593369337933893399340934193429343934493459346934793489349935093519352935393549355935693579358935993609361936293639364936593669367936893699370937193729373937493759376937793789379938093819382938393849385938693879388938993909391939293939394939593969397939893999400940194029403940494059406940794089409941094119412941394149415941694179418941994209421942294239424942594269427942894299430943194329433943494359436943794389439944094419442944394449445944694479448944994509451945294539454945594569457945894599460946194629463946494659466946794689469947094719472947394749475947694779478947994809481948294839484948594869487948894899490949194929493949494959496949794989499950095019502950395049505950695079508950995109511951295139514951595169517951895199520952195229523952495259526952795289529953095319532953395349535953695379538953995409541954295439544954595469547954895499550955195529553955495559556955795589559956095619562956395649565956695679568956995709571957295739574957595769577957895799580958195829583958495859586958795889589959095919592959395949595959695979598959996009601960296039604960596069607960896099610961196129613961496159616961796189619962096219622962396249625962696279628962996309631963296339634963596369637963896399640964196429643964496459646964796489649965096519652965396549655965696579658965996609661966296639664966596669667966896699670967196729673967496759676967796789679968096819682968396849685968696879688968996909691969296939694969596969697969896999700970197029703970497059706970797089709971097119712971397149715971697179718971997209721972297239724972597269727972897299730973197329733973497359736973797389739974097419742974397449745974697479748974997509751975297539754975597569757975897599760976197629763976497659766976797689769977097719772977397749775977697779778977997809781978297839784978597869787978897899790979197929793979497959796979797989799980098019802980398049805980698079808980998109811981298139814981598169817981898199820982198229823982498259826982798289829983098319832983398349835983698379838983998409841984298439844984598469847984898499850985198529853985498559856985798589859986098619862986398649865986698679868986998709871987298739874987598769877987898799880988198829883988498859886988798889889989098919892989398949895989698979898
  1. // Copyright 2018 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package apex
  15. import (
  16. "fmt"
  17. "path"
  18. "path/filepath"
  19. "reflect"
  20. "regexp"
  21. "sort"
  22. "strconv"
  23. "strings"
  24. "testing"
  25. "github.com/google/blueprint"
  26. "github.com/google/blueprint/proptools"
  27. "android/soong/android"
  28. "android/soong/bazel/cquery"
  29. "android/soong/bpf"
  30. "android/soong/cc"
  31. "android/soong/dexpreopt"
  32. prebuilt_etc "android/soong/etc"
  33. "android/soong/java"
  34. "android/soong/rust"
  35. "android/soong/sh"
  36. )
  37. // names returns name list from white space separated string
  38. func names(s string) (ns []string) {
  39. for _, n := range strings.Split(s, " ") {
  40. if len(n) > 0 {
  41. ns = append(ns, n)
  42. }
  43. }
  44. return
  45. }
  46. func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
  47. t.Helper()
  48. android.GroupFixturePreparers(
  49. prepareForApexTest,
  50. android.GroupFixturePreparers(preparers...),
  51. ).
  52. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
  53. RunTestWithBp(t, bp)
  54. }
  55. func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
  56. t.Helper()
  57. optionalBpPreparer := android.NullFixturePreparer
  58. if bp != "" {
  59. optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
  60. }
  61. result := android.GroupFixturePreparers(
  62. prepareForApexTest,
  63. android.GroupFixturePreparers(preparers...),
  64. optionalBpPreparer,
  65. ).RunTest(t)
  66. return result.TestContext
  67. }
  68. func withFiles(files android.MockFS) android.FixturePreparer {
  69. return files.AddToFixture()
  70. }
  71. func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
  72. return android.FixtureModifyConfig(func(config android.Config) {
  73. for k, v := range targets {
  74. config.Targets[k] = v
  75. }
  76. })
  77. }
  78. // withNativeBridgeTargets sets configuration with targets including:
  79. // - X86_64 (primary)
  80. // - X86 (secondary)
  81. // - Arm64 on X86_64 (native bridge)
  82. // - Arm on X86 (native bridge)
  83. var withNativeBridgeEnabled = android.FixtureModifyConfig(
  84. func(config android.Config) {
  85. config.Targets[android.Android] = []android.Target{
  86. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
  87. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  88. {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
  89. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  90. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
  91. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
  92. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  93. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
  94. }
  95. },
  96. )
  97. func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
  98. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  99. variables.ManifestPackageNameOverrides = specs
  100. })
  101. }
  102. func withApexGlobalMinSdkVersionOverride(minSdkOverride *string) android.FixturePreparer {
  103. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  104. variables.ApexGlobalMinSdkVersionOverride = minSdkOverride
  105. })
  106. }
  107. var withBinder32bit = android.FixtureModifyProductVariables(
  108. func(variables android.FixtureProductVariables) {
  109. variables.Binder32bit = proptools.BoolPtr(true)
  110. },
  111. )
  112. var withUnbundledBuild = android.FixtureModifyProductVariables(
  113. func(variables android.FixtureProductVariables) {
  114. variables.Unbundled_build = proptools.BoolPtr(true)
  115. },
  116. )
  117. // Legacy preparer used for running tests within the apex package.
  118. //
  119. // This includes everything that was needed to run any test in the apex package prior to the
  120. // introduction of the test fixtures. Tests that are being converted to use fixtures directly
  121. // rather than through the testApex...() methods should avoid using this and instead use the
  122. // various preparers directly, using android.GroupFixturePreparers(...) to group them when
  123. // necessary.
  124. //
  125. // deprecated
  126. var prepareForApexTest = android.GroupFixturePreparers(
  127. // General preparers in alphabetical order as test infrastructure will enforce correct
  128. // registration order.
  129. android.PrepareForTestWithAndroidBuildComponents,
  130. bpf.PrepareForTestWithBpf,
  131. cc.PrepareForTestWithCcBuildComponents,
  132. java.PrepareForTestWithJavaDefaultModules,
  133. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  134. rust.PrepareForTestWithRustDefaultModules,
  135. sh.PrepareForTestWithShBuildComponents,
  136. PrepareForTestWithApexBuildComponents,
  137. // Additional apex test specific preparers.
  138. android.FixtureAddTextFile("system/sepolicy/Android.bp", `
  139. filegroup {
  140. name: "myapex-file_contexts",
  141. srcs: [
  142. "apex/myapex-file_contexts",
  143. ],
  144. }
  145. `),
  146. prepareForTestWithMyapex,
  147. android.FixtureMergeMockFs(android.MockFS{
  148. "a.java": nil,
  149. "PrebuiltAppFoo.apk": nil,
  150. "PrebuiltAppFooPriv.apk": nil,
  151. "apex_manifest.json": nil,
  152. "AndroidManifest.xml": nil,
  153. "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
  154. "system/sepolicy/apex/myapex2-file_contexts": nil,
  155. "system/sepolicy/apex/otherapex-file_contexts": nil,
  156. "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
  157. "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
  158. "mylib.cpp": nil,
  159. "mytest.cpp": nil,
  160. "mytest1.cpp": nil,
  161. "mytest2.cpp": nil,
  162. "mytest3.cpp": nil,
  163. "myprebuilt": nil,
  164. "my_include": nil,
  165. "foo/bar/MyClass.java": nil,
  166. "prebuilt.jar": nil,
  167. "prebuilt.so": nil,
  168. "vendor/foo/devkeys/test.x509.pem": nil,
  169. "vendor/foo/devkeys/test.pk8": nil,
  170. "testkey.x509.pem": nil,
  171. "testkey.pk8": nil,
  172. "testkey.override.x509.pem": nil,
  173. "testkey.override.pk8": nil,
  174. "vendor/foo/devkeys/testkey.avbpubkey": nil,
  175. "vendor/foo/devkeys/testkey.pem": nil,
  176. "NOTICE": nil,
  177. "custom_notice": nil,
  178. "custom_notice_for_static_lib": nil,
  179. "testkey2.avbpubkey": nil,
  180. "testkey2.pem": nil,
  181. "myapex-arm64.apex": nil,
  182. "myapex-arm.apex": nil,
  183. "myapex.apks": nil,
  184. "frameworks/base/api/current.txt": nil,
  185. "framework/aidl/a.aidl": nil,
  186. "dummy.txt": nil,
  187. "baz": nil,
  188. "bar/baz": nil,
  189. "testdata/baz": nil,
  190. "AppSet.apks": nil,
  191. "foo.rs": nil,
  192. "libfoo.jar": nil,
  193. "libbar.jar": nil,
  194. },
  195. ),
  196. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  197. variables.DeviceVndkVersion = proptools.StringPtr("current")
  198. variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
  199. variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
  200. variables.Platform_sdk_codename = proptools.StringPtr("Q")
  201. variables.Platform_sdk_final = proptools.BoolPtr(false)
  202. // "Tiramisu" needs to be in the next line for compatibility with soong code,
  203. // not because of these tests specifically (it's not used by the tests)
  204. variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
  205. variables.Platform_vndk_version = proptools.StringPtr("29")
  206. variables.BuildId = proptools.StringPtr("TEST.BUILD_ID")
  207. }),
  208. )
  209. var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
  210. "system/sepolicy/apex/myapex-file_contexts": nil,
  211. })
  212. // ensure that 'result' equals 'expected'
  213. func ensureEquals(t *testing.T, result string, expected string) {
  214. t.Helper()
  215. if result != expected {
  216. t.Errorf("%q != %q", expected, result)
  217. }
  218. }
  219. // ensure that 'result' contains 'expected'
  220. func ensureContains(t *testing.T, result string, expected string) {
  221. t.Helper()
  222. if !strings.Contains(result, expected) {
  223. t.Errorf("%q is not found in %q", expected, result)
  224. }
  225. }
  226. // ensure that 'result' contains 'expected' exactly one time
  227. func ensureContainsOnce(t *testing.T, result string, expected string) {
  228. t.Helper()
  229. count := strings.Count(result, expected)
  230. if count != 1 {
  231. t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
  232. }
  233. }
  234. // ensures that 'result' does not contain 'notExpected'
  235. func ensureNotContains(t *testing.T, result string, notExpected string) {
  236. t.Helper()
  237. if strings.Contains(result, notExpected) {
  238. t.Errorf("%q is found in %q", notExpected, result)
  239. }
  240. }
  241. func ensureMatches(t *testing.T, result string, expectedRex string) {
  242. ok, err := regexp.MatchString(expectedRex, result)
  243. if err != nil {
  244. t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
  245. return
  246. }
  247. if !ok {
  248. t.Errorf("%s does not match regular expession %s", result, expectedRex)
  249. }
  250. }
  251. func ensureListContains(t *testing.T, result []string, expected string) {
  252. t.Helper()
  253. if !android.InList(expected, result) {
  254. t.Errorf("%q is not found in %v", expected, result)
  255. }
  256. }
  257. func ensureListNotContains(t *testing.T, result []string, notExpected string) {
  258. t.Helper()
  259. if android.InList(notExpected, result) {
  260. t.Errorf("%q is found in %v", notExpected, result)
  261. }
  262. }
  263. func ensureListEmpty(t *testing.T, result []string) {
  264. t.Helper()
  265. if len(result) > 0 {
  266. t.Errorf("%q is expected to be empty", result)
  267. }
  268. }
  269. func ensureListNotEmpty(t *testing.T, result []string) {
  270. t.Helper()
  271. if len(result) == 0 {
  272. t.Errorf("%q is expected to be not empty", result)
  273. }
  274. }
  275. // Minimal test
  276. func TestBasicApex(t *testing.T) {
  277. ctx := testApex(t, `
  278. apex_defaults {
  279. name: "myapex-defaults",
  280. manifest: ":myapex.manifest",
  281. androidManifest: ":myapex.androidmanifest",
  282. key: "myapex.key",
  283. binaries: ["foo.rust"],
  284. native_shared_libs: [
  285. "mylib",
  286. "libfoo.ffi",
  287. ],
  288. rust_dyn_libs: ["libfoo.dylib.rust"],
  289. multilib: {
  290. both: {
  291. binaries: ["foo"],
  292. }
  293. },
  294. java_libs: [
  295. "myjar",
  296. "myjar_dex",
  297. ],
  298. updatable: false,
  299. }
  300. apex {
  301. name: "myapex",
  302. defaults: ["myapex-defaults"],
  303. }
  304. apex_key {
  305. name: "myapex.key",
  306. public_key: "testkey.avbpubkey",
  307. private_key: "testkey.pem",
  308. }
  309. filegroup {
  310. name: "myapex.manifest",
  311. srcs: ["apex_manifest.json"],
  312. }
  313. filegroup {
  314. name: "myapex.androidmanifest",
  315. srcs: ["AndroidManifest.xml"],
  316. }
  317. cc_library {
  318. name: "mylib",
  319. srcs: ["mylib.cpp"],
  320. shared_libs: [
  321. "mylib2",
  322. "libbar.ffi",
  323. ],
  324. system_shared_libs: [],
  325. stl: "none",
  326. // TODO: remove //apex_available:platform
  327. apex_available: [
  328. "//apex_available:platform",
  329. "myapex",
  330. ],
  331. }
  332. cc_binary {
  333. name: "foo",
  334. srcs: ["mylib.cpp"],
  335. compile_multilib: "both",
  336. multilib: {
  337. lib32: {
  338. suffix: "32",
  339. },
  340. lib64: {
  341. suffix: "64",
  342. },
  343. },
  344. symlinks: ["foo_link_"],
  345. symlink_preferred_arch: true,
  346. system_shared_libs: [],
  347. stl: "none",
  348. apex_available: [ "myapex", "com.android.gki.*" ],
  349. }
  350. rust_binary {
  351. name: "foo.rust",
  352. srcs: ["foo.rs"],
  353. rlibs: ["libfoo.rlib.rust"],
  354. dylibs: ["libfoo.dylib.rust"],
  355. apex_available: ["myapex"],
  356. }
  357. rust_library_rlib {
  358. name: "libfoo.rlib.rust",
  359. srcs: ["foo.rs"],
  360. crate_name: "foo",
  361. apex_available: ["myapex"],
  362. shared_libs: ["libfoo.shared_from_rust"],
  363. }
  364. cc_library_shared {
  365. name: "libfoo.shared_from_rust",
  366. srcs: ["mylib.cpp"],
  367. system_shared_libs: [],
  368. stl: "none",
  369. apex_available: ["myapex"],
  370. }
  371. rust_library_dylib {
  372. name: "libfoo.dylib.rust",
  373. srcs: ["foo.rs"],
  374. crate_name: "foo",
  375. apex_available: ["myapex"],
  376. }
  377. rust_ffi_shared {
  378. name: "libfoo.ffi",
  379. srcs: ["foo.rs"],
  380. crate_name: "foo",
  381. apex_available: ["myapex"],
  382. }
  383. rust_ffi_shared {
  384. name: "libbar.ffi",
  385. srcs: ["foo.rs"],
  386. crate_name: "bar",
  387. apex_available: ["myapex"],
  388. }
  389. apex {
  390. name: "com.android.gki.fake",
  391. binaries: ["foo"],
  392. key: "myapex.key",
  393. file_contexts: ":myapex-file_contexts",
  394. updatable: false,
  395. }
  396. cc_library_shared {
  397. name: "mylib2",
  398. srcs: ["mylib.cpp"],
  399. system_shared_libs: [],
  400. stl: "none",
  401. static_libs: ["libstatic"],
  402. // TODO: remove //apex_available:platform
  403. apex_available: [
  404. "//apex_available:platform",
  405. "myapex",
  406. ],
  407. }
  408. cc_prebuilt_library_shared {
  409. name: "mylib2",
  410. srcs: ["prebuilt.so"],
  411. // TODO: remove //apex_available:platform
  412. apex_available: [
  413. "//apex_available:platform",
  414. "myapex",
  415. ],
  416. }
  417. cc_library_static {
  418. name: "libstatic",
  419. srcs: ["mylib.cpp"],
  420. system_shared_libs: [],
  421. stl: "none",
  422. // TODO: remove //apex_available:platform
  423. apex_available: [
  424. "//apex_available:platform",
  425. "myapex",
  426. ],
  427. }
  428. java_library {
  429. name: "myjar",
  430. srcs: ["foo/bar/MyClass.java"],
  431. stem: "myjar_stem",
  432. sdk_version: "none",
  433. system_modules: "none",
  434. static_libs: ["myotherjar"],
  435. libs: ["mysharedjar"],
  436. // TODO: remove //apex_available:platform
  437. apex_available: [
  438. "//apex_available:platform",
  439. "myapex",
  440. ],
  441. }
  442. dex_import {
  443. name: "myjar_dex",
  444. jars: ["prebuilt.jar"],
  445. apex_available: [
  446. "//apex_available:platform",
  447. "myapex",
  448. ],
  449. }
  450. java_library {
  451. name: "myotherjar",
  452. srcs: ["foo/bar/MyClass.java"],
  453. sdk_version: "none",
  454. system_modules: "none",
  455. // TODO: remove //apex_available:platform
  456. apex_available: [
  457. "//apex_available:platform",
  458. "myapex",
  459. ],
  460. }
  461. java_library {
  462. name: "mysharedjar",
  463. srcs: ["foo/bar/MyClass.java"],
  464. sdk_version: "none",
  465. system_modules: "none",
  466. }
  467. `)
  468. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  469. // Make sure that Android.mk is created
  470. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  471. data := android.AndroidMkDataForTest(t, ctx, ab)
  472. var builder strings.Builder
  473. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  474. androidMk := builder.String()
  475. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  476. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  477. optFlags := apexRule.Args["opt_flags"]
  478. ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
  479. // Ensure that the NOTICE output is being packaged as an asset.
  480. ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
  481. copyCmds := apexRule.Args["copy_commands"]
  482. // Ensure that main rule creates an output
  483. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  484. // Ensure that apex variant is created for the direct dep
  485. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  486. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
  487. ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
  488. ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
  489. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
  490. // Ensure that apex variant is created for the indirect dep
  491. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  492. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
  493. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
  494. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
  495. ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
  496. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
  497. // Ensure that both direct and indirect deps are copied into apex
  498. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  499. ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  500. ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
  501. ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
  502. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
  503. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
  504. ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
  505. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  506. // .. but not for java libs
  507. ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
  508. ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
  509. // Ensure that the platform variant ends with _shared or _common
  510. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  511. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  512. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
  513. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
  514. ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
  515. // Ensure that dynamic dependency to java libs are not included
  516. ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
  517. // Ensure that all symlinks are present.
  518. found_foo_link_64 := false
  519. found_foo := false
  520. for _, cmd := range strings.Split(copyCmds, " && ") {
  521. if strings.HasPrefix(cmd, "ln -sfn foo64") {
  522. if strings.HasSuffix(cmd, "bin/foo") {
  523. found_foo = true
  524. } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
  525. found_foo_link_64 = true
  526. }
  527. }
  528. }
  529. good := found_foo && found_foo_link_64
  530. if !good {
  531. t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
  532. }
  533. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  534. ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
  535. ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
  536. ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
  537. ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
  538. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  539. ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
  540. ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
  541. ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
  542. ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
  543. }
  544. func TestDefaults(t *testing.T) {
  545. ctx := testApex(t, `
  546. apex_defaults {
  547. name: "myapex-defaults",
  548. key: "myapex.key",
  549. prebuilts: ["myetc"],
  550. native_shared_libs: ["mylib"],
  551. java_libs: ["myjar"],
  552. apps: ["AppFoo"],
  553. rros: ["rro"],
  554. bpfs: ["bpf", "netdTest"],
  555. updatable: false,
  556. }
  557. prebuilt_etc {
  558. name: "myetc",
  559. src: "myprebuilt",
  560. }
  561. apex {
  562. name: "myapex",
  563. defaults: ["myapex-defaults"],
  564. }
  565. apex_key {
  566. name: "myapex.key",
  567. public_key: "testkey.avbpubkey",
  568. private_key: "testkey.pem",
  569. }
  570. cc_library {
  571. name: "mylib",
  572. system_shared_libs: [],
  573. stl: "none",
  574. apex_available: [ "myapex" ],
  575. }
  576. java_library {
  577. name: "myjar",
  578. srcs: ["foo/bar/MyClass.java"],
  579. sdk_version: "none",
  580. system_modules: "none",
  581. apex_available: [ "myapex" ],
  582. }
  583. android_app {
  584. name: "AppFoo",
  585. srcs: ["foo/bar/MyClass.java"],
  586. sdk_version: "none",
  587. system_modules: "none",
  588. apex_available: [ "myapex" ],
  589. }
  590. runtime_resource_overlay {
  591. name: "rro",
  592. theme: "blue",
  593. }
  594. bpf {
  595. name: "bpf",
  596. srcs: ["bpf.c", "bpf2.c"],
  597. }
  598. bpf {
  599. name: "netdTest",
  600. srcs: ["netdTest.c"],
  601. sub_dir: "netd",
  602. }
  603. `)
  604. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  605. "etc/myetc",
  606. "javalib/myjar.jar",
  607. "lib64/mylib.so",
  608. "app/AppFoo@TEST.BUILD_ID/AppFoo.apk",
  609. "overlay/blue/rro.apk",
  610. "etc/bpf/bpf.o",
  611. "etc/bpf/bpf2.o",
  612. "etc/bpf/netd/netdTest.o",
  613. })
  614. }
  615. func TestApexManifest(t *testing.T) {
  616. ctx := testApex(t, `
  617. apex {
  618. name: "myapex",
  619. key: "myapex.key",
  620. updatable: false,
  621. }
  622. apex_key {
  623. name: "myapex.key",
  624. public_key: "testkey.avbpubkey",
  625. private_key: "testkey.pem",
  626. }
  627. `)
  628. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  629. args := module.Rule("apexRule").Args
  630. if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
  631. t.Error("manifest should be apex_manifest.pb, but " + manifest)
  632. }
  633. }
  634. func TestApexManifestMinSdkVersion(t *testing.T) {
  635. ctx := testApex(t, `
  636. apex_defaults {
  637. name: "my_defaults",
  638. key: "myapex.key",
  639. product_specific: true,
  640. file_contexts: ":my-file-contexts",
  641. updatable: false,
  642. }
  643. apex {
  644. name: "myapex_30",
  645. min_sdk_version: "30",
  646. defaults: ["my_defaults"],
  647. }
  648. apex {
  649. name: "myapex_current",
  650. min_sdk_version: "current",
  651. defaults: ["my_defaults"],
  652. }
  653. apex {
  654. name: "myapex_none",
  655. defaults: ["my_defaults"],
  656. }
  657. apex_key {
  658. name: "myapex.key",
  659. public_key: "testkey.avbpubkey",
  660. private_key: "testkey.pem",
  661. }
  662. filegroup {
  663. name: "my-file-contexts",
  664. srcs: ["product_specific_file_contexts"],
  665. }
  666. `, withFiles(map[string][]byte{
  667. "product_specific_file_contexts": nil,
  668. }), android.FixtureModifyProductVariables(
  669. func(variables android.FixtureProductVariables) {
  670. variables.Unbundled_build = proptools.BoolPtr(true)
  671. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
  672. }), android.FixtureMergeEnv(map[string]string{
  673. "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
  674. }))
  675. testCases := []struct {
  676. module string
  677. minSdkVersion string
  678. }{
  679. {
  680. module: "myapex_30",
  681. minSdkVersion: "30",
  682. },
  683. {
  684. module: "myapex_current",
  685. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  686. },
  687. {
  688. module: "myapex_none",
  689. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  690. },
  691. }
  692. for _, tc := range testCases {
  693. module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
  694. args := module.Rule("apexRule").Args
  695. optFlags := args["opt_flags"]
  696. if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
  697. t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
  698. }
  699. }
  700. }
  701. func TestBasicZipApex(t *testing.T) {
  702. ctx := testApex(t, `
  703. apex {
  704. name: "myapex",
  705. key: "myapex.key",
  706. payload_type: "zip",
  707. native_shared_libs: ["mylib"],
  708. updatable: false,
  709. }
  710. apex_key {
  711. name: "myapex.key",
  712. public_key: "testkey.avbpubkey",
  713. private_key: "testkey.pem",
  714. }
  715. cc_library {
  716. name: "mylib",
  717. srcs: ["mylib.cpp"],
  718. shared_libs: ["mylib2"],
  719. system_shared_libs: [],
  720. stl: "none",
  721. apex_available: [ "myapex" ],
  722. }
  723. cc_library {
  724. name: "mylib2",
  725. srcs: ["mylib.cpp"],
  726. system_shared_libs: [],
  727. stl: "none",
  728. apex_available: [ "myapex" ],
  729. }
  730. `)
  731. zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
  732. copyCmds := zipApexRule.Args["copy_commands"]
  733. // Ensure that main rule creates an output
  734. ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
  735. // Ensure that APEX variant is created for the direct dep
  736. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  737. // Ensure that APEX variant is created for the indirect dep
  738. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  739. // Ensure that both direct and indirect deps are copied into apex
  740. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
  741. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
  742. }
  743. func TestApexWithStubs(t *testing.T) {
  744. ctx := testApex(t, `
  745. apex {
  746. name: "myapex",
  747. key: "myapex.key",
  748. native_shared_libs: ["mylib", "mylib3"],
  749. binaries: ["foo.rust"],
  750. updatable: false,
  751. }
  752. apex_key {
  753. name: "myapex.key",
  754. public_key: "testkey.avbpubkey",
  755. private_key: "testkey.pem",
  756. }
  757. cc_library {
  758. name: "mylib",
  759. srcs: ["mylib.cpp"],
  760. shared_libs: ["mylib2", "mylib3"],
  761. system_shared_libs: [],
  762. stl: "none",
  763. apex_available: [ "myapex" ],
  764. }
  765. cc_library {
  766. name: "mylib2",
  767. srcs: ["mylib.cpp"],
  768. cflags: ["-include mylib.h"],
  769. system_shared_libs: [],
  770. stl: "none",
  771. stubs: {
  772. versions: ["1", "2", "3"],
  773. },
  774. }
  775. cc_library {
  776. name: "mylib3",
  777. srcs: ["mylib.cpp"],
  778. shared_libs: ["mylib4"],
  779. system_shared_libs: [],
  780. stl: "none",
  781. stubs: {
  782. versions: ["10", "11", "12"],
  783. },
  784. apex_available: [ "myapex" ],
  785. }
  786. cc_library {
  787. name: "mylib4",
  788. srcs: ["mylib.cpp"],
  789. system_shared_libs: [],
  790. stl: "none",
  791. apex_available: [ "myapex" ],
  792. }
  793. rust_binary {
  794. name: "foo.rust",
  795. srcs: ["foo.rs"],
  796. shared_libs: ["libfoo.shared_from_rust"],
  797. prefer_rlib: true,
  798. apex_available: ["myapex"],
  799. }
  800. cc_library_shared {
  801. name: "libfoo.shared_from_rust",
  802. srcs: ["mylib.cpp"],
  803. system_shared_libs: [],
  804. stl: "none",
  805. stubs: {
  806. versions: ["10", "11", "12"],
  807. },
  808. }
  809. `)
  810. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  811. copyCmds := apexRule.Args["copy_commands"]
  812. // Ensure that direct non-stubs dep is always included
  813. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  814. // Ensure that indirect stubs dep is not included
  815. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  816. // Ensure that direct stubs dep is included
  817. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  818. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  819. // Ensure that mylib is linking with the latest version of stubs for mylib2
  820. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  821. // ... and not linking to the non-stub (impl) variant of mylib2
  822. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  823. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  824. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
  825. // .. and not linking to the stubs variant of mylib3
  826. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
  827. // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
  828. // is replaced by sharing of "cFlags" in cc/builder.go.
  829. // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
  830. // module variable representing "cflags". So it was not detected by ensureNotContains.
  831. // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
  832. // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
  833. // including the original cflags's "-include mylib.h".
  834. //
  835. // Ensure that stubs libs are built without -include flags
  836. // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  837. // ensureNotContains(t, mylib2Cflags, "-include ")
  838. // Ensure that genstub for platform-provided lib is invoked with --systemapi
  839. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"], "--systemapi")
  840. // Ensure that genstub for apex-provided lib is invoked with --apex
  841. ensureContains(t, ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_shared_12").Rule("genStubSrc").Args["flags"], "--apex")
  842. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  843. "lib64/mylib.so",
  844. "lib64/mylib3.so",
  845. "lib64/mylib4.so",
  846. "bin/foo.rust",
  847. "lib64/libc++.so", // by the implicit dependency from foo.rust
  848. "lib64/liblog.so", // by the implicit dependency from foo.rust
  849. })
  850. // Ensure that stub dependency from a rust module is not included
  851. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  852. // The rust module is linked to the stub cc library
  853. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
  854. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  855. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  856. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  857. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  858. }
  859. func TestApexCanUsePrivateApis(t *testing.T) {
  860. ctx := testApex(t, `
  861. apex {
  862. name: "myapex",
  863. key: "myapex.key",
  864. native_shared_libs: ["mylib"],
  865. binaries: ["foo.rust"],
  866. updatable: false,
  867. platform_apis: true,
  868. }
  869. apex_key {
  870. name: "myapex.key",
  871. public_key: "testkey.avbpubkey",
  872. private_key: "testkey.pem",
  873. }
  874. cc_library {
  875. name: "mylib",
  876. srcs: ["mylib.cpp"],
  877. shared_libs: ["mylib2"],
  878. system_shared_libs: [],
  879. stl: "none",
  880. apex_available: [ "myapex" ],
  881. }
  882. cc_library {
  883. name: "mylib2",
  884. srcs: ["mylib.cpp"],
  885. cflags: ["-include mylib.h"],
  886. system_shared_libs: [],
  887. stl: "none",
  888. stubs: {
  889. versions: ["1", "2", "3"],
  890. },
  891. }
  892. rust_binary {
  893. name: "foo.rust",
  894. srcs: ["foo.rs"],
  895. shared_libs: ["libfoo.shared_from_rust"],
  896. prefer_rlib: true,
  897. apex_available: ["myapex"],
  898. }
  899. cc_library_shared {
  900. name: "libfoo.shared_from_rust",
  901. srcs: ["mylib.cpp"],
  902. system_shared_libs: [],
  903. stl: "none",
  904. stubs: {
  905. versions: ["10", "11", "12"],
  906. },
  907. }
  908. `)
  909. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  910. copyCmds := apexRule.Args["copy_commands"]
  911. // Ensure that indirect stubs dep is not included
  912. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  913. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  914. // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
  915. // of the platform_apis: true)
  916. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  917. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  918. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  919. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
  920. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  921. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  922. }
  923. func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
  924. t.Parallel()
  925. ctx := testApex(t, `
  926. apex {
  927. name: "myapex",
  928. key: "myapex.key",
  929. native_shared_libs: ["mylib", "mylib3"],
  930. min_sdk_version: "29",
  931. }
  932. apex_key {
  933. name: "myapex.key",
  934. public_key: "testkey.avbpubkey",
  935. private_key: "testkey.pem",
  936. }
  937. cc_library {
  938. name: "mylib",
  939. srcs: ["mylib.cpp"],
  940. shared_libs: ["mylib2", "mylib3"],
  941. system_shared_libs: [],
  942. stl: "none",
  943. apex_available: [ "myapex" ],
  944. min_sdk_version: "28",
  945. }
  946. cc_library {
  947. name: "mylib2",
  948. srcs: ["mylib.cpp"],
  949. cflags: ["-include mylib.h"],
  950. system_shared_libs: [],
  951. stl: "none",
  952. stubs: {
  953. versions: ["28", "29", "30", "current"],
  954. },
  955. min_sdk_version: "28",
  956. }
  957. cc_library {
  958. name: "mylib3",
  959. srcs: ["mylib.cpp"],
  960. shared_libs: ["mylib4"],
  961. system_shared_libs: [],
  962. stl: "none",
  963. stubs: {
  964. versions: ["28", "29", "30", "current"],
  965. },
  966. apex_available: [ "myapex" ],
  967. min_sdk_version: "28",
  968. }
  969. cc_library {
  970. name: "mylib4",
  971. srcs: ["mylib.cpp"],
  972. system_shared_libs: [],
  973. stl: "none",
  974. apex_available: [ "myapex" ],
  975. min_sdk_version: "28",
  976. }
  977. `)
  978. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  979. copyCmds := apexRule.Args["copy_commands"]
  980. // Ensure that direct non-stubs dep is always included
  981. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  982. // Ensure that indirect stubs dep is not included
  983. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  984. // Ensure that direct stubs dep is included
  985. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  986. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
  987. // Ensure that mylib is linking with the latest version of stub for mylib2
  988. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  989. // ... and not linking to the non-stub (impl) variant of mylib2
  990. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  991. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  992. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
  993. // .. and not linking to the stubs variant of mylib3
  994. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
  995. // Ensure that stubs libs are built without -include flags
  996. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
  997. ensureNotContains(t, mylib2Cflags, "-include ")
  998. // Ensure that genstub is invoked with --systemapi
  999. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"], "--systemapi")
  1000. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1001. "lib64/mylib.so",
  1002. "lib64/mylib3.so",
  1003. "lib64/mylib4.so",
  1004. })
  1005. }
  1006. func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
  1007. t.Parallel()
  1008. // myapex (Z)
  1009. // mylib -----------------.
  1010. // |
  1011. // otherapex (29) |
  1012. // libstub's versions: 29 Z current
  1013. // |
  1014. // <platform> |
  1015. // libplatform ----------------'
  1016. ctx := testApex(t, `
  1017. apex {
  1018. name: "myapex",
  1019. key: "myapex.key",
  1020. native_shared_libs: ["mylib"],
  1021. min_sdk_version: "Z", // non-final
  1022. }
  1023. cc_library {
  1024. name: "mylib",
  1025. srcs: ["mylib.cpp"],
  1026. shared_libs: ["libstub"],
  1027. apex_available: ["myapex"],
  1028. min_sdk_version: "Z",
  1029. }
  1030. apex_key {
  1031. name: "myapex.key",
  1032. public_key: "testkey.avbpubkey",
  1033. private_key: "testkey.pem",
  1034. }
  1035. apex {
  1036. name: "otherapex",
  1037. key: "myapex.key",
  1038. native_shared_libs: ["libstub"],
  1039. min_sdk_version: "29",
  1040. }
  1041. cc_library {
  1042. name: "libstub",
  1043. srcs: ["mylib.cpp"],
  1044. stubs: {
  1045. versions: ["29", "Z", "current"],
  1046. },
  1047. apex_available: ["otherapex"],
  1048. min_sdk_version: "29",
  1049. }
  1050. // platform module depending on libstub from otherapex should use the latest stub("current")
  1051. cc_library {
  1052. name: "libplatform",
  1053. srcs: ["mylib.cpp"],
  1054. shared_libs: ["libstub"],
  1055. }
  1056. `,
  1057. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1058. variables.Platform_sdk_codename = proptools.StringPtr("Z")
  1059. variables.Platform_sdk_final = proptools.BoolPtr(false)
  1060. variables.Platform_version_active_codenames = []string{"Z"}
  1061. }),
  1062. )
  1063. // Ensure that mylib from myapex is built against the latest stub (current)
  1064. mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1065. ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
  1066. mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1067. ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1068. // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
  1069. libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  1070. ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
  1071. libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1072. ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1073. }
  1074. func TestApexWithExplicitStubsDependency(t *testing.T) {
  1075. ctx := testApex(t, `
  1076. apex {
  1077. name: "myapex2",
  1078. key: "myapex2.key",
  1079. native_shared_libs: ["mylib"],
  1080. updatable: false,
  1081. }
  1082. apex_key {
  1083. name: "myapex2.key",
  1084. public_key: "testkey.avbpubkey",
  1085. private_key: "testkey.pem",
  1086. }
  1087. cc_library {
  1088. name: "mylib",
  1089. srcs: ["mylib.cpp"],
  1090. shared_libs: ["libfoo#10"],
  1091. static_libs: ["libbaz"],
  1092. system_shared_libs: [],
  1093. stl: "none",
  1094. apex_available: [ "myapex2" ],
  1095. }
  1096. cc_library {
  1097. name: "libfoo",
  1098. srcs: ["mylib.cpp"],
  1099. shared_libs: ["libbar"],
  1100. system_shared_libs: [],
  1101. stl: "none",
  1102. stubs: {
  1103. versions: ["10", "20", "30"],
  1104. },
  1105. }
  1106. cc_library {
  1107. name: "libbar",
  1108. srcs: ["mylib.cpp"],
  1109. system_shared_libs: [],
  1110. stl: "none",
  1111. }
  1112. cc_library_static {
  1113. name: "libbaz",
  1114. srcs: ["mylib.cpp"],
  1115. system_shared_libs: [],
  1116. stl: "none",
  1117. apex_available: [ "myapex2" ],
  1118. }
  1119. `)
  1120. apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
  1121. copyCmds := apexRule.Args["copy_commands"]
  1122. // Ensure that direct non-stubs dep is always included
  1123. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1124. // Ensure that indirect stubs dep is not included
  1125. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1126. // Ensure that dependency of stubs is not included
  1127. ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1128. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1129. // Ensure that mylib is linking with version 10 of libfoo
  1130. ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
  1131. // ... and not linking to the non-stub (impl) variant of libfoo
  1132. ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
  1133. libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
  1134. // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
  1135. ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
  1136. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  1137. ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
  1138. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  1139. ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
  1140. }
  1141. func TestApexWithRuntimeLibsDependency(t *testing.T) {
  1142. /*
  1143. myapex
  1144. |
  1145. v (runtime_libs)
  1146. mylib ------+------> libfoo [provides stub]
  1147. |
  1148. `------> libbar
  1149. */
  1150. ctx := testApex(t, `
  1151. apex {
  1152. name: "myapex",
  1153. key: "myapex.key",
  1154. native_shared_libs: ["mylib"],
  1155. updatable: false,
  1156. }
  1157. apex_key {
  1158. name: "myapex.key",
  1159. public_key: "testkey.avbpubkey",
  1160. private_key: "testkey.pem",
  1161. }
  1162. cc_library {
  1163. name: "mylib",
  1164. srcs: ["mylib.cpp"],
  1165. runtime_libs: ["libfoo", "libbar"],
  1166. system_shared_libs: [],
  1167. stl: "none",
  1168. apex_available: [ "myapex" ],
  1169. }
  1170. cc_library {
  1171. name: "libfoo",
  1172. srcs: ["mylib.cpp"],
  1173. system_shared_libs: [],
  1174. stl: "none",
  1175. stubs: {
  1176. versions: ["10", "20", "30"],
  1177. },
  1178. }
  1179. cc_library {
  1180. name: "libbar",
  1181. srcs: ["mylib.cpp"],
  1182. system_shared_libs: [],
  1183. stl: "none",
  1184. apex_available: [ "myapex" ],
  1185. }
  1186. `)
  1187. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1188. copyCmds := apexRule.Args["copy_commands"]
  1189. // Ensure that direct non-stubs dep is always included
  1190. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1191. // Ensure that indirect stubs dep is not included
  1192. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1193. // Ensure that runtime_libs dep in included
  1194. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1195. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1196. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1197. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
  1198. }
  1199. var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
  1200. cc.PrepareForTestWithCcBuildComponents,
  1201. PrepareForTestWithApexBuildComponents,
  1202. android.FixtureAddTextFile("bionic/apex/Android.bp", `
  1203. apex {
  1204. name: "com.android.runtime",
  1205. key: "com.android.runtime.key",
  1206. native_shared_libs: ["libc"],
  1207. updatable: false,
  1208. }
  1209. apex_key {
  1210. name: "com.android.runtime.key",
  1211. public_key: "testkey.avbpubkey",
  1212. private_key: "testkey.pem",
  1213. }
  1214. `),
  1215. android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
  1216. )
  1217. func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
  1218. result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
  1219. cc_library {
  1220. name: "libc",
  1221. no_libcrt: true,
  1222. nocrt: true,
  1223. stl: "none",
  1224. system_shared_libs: [],
  1225. stubs: { versions: ["1"] },
  1226. apex_available: ["com.android.runtime"],
  1227. sanitize: {
  1228. hwaddress: true,
  1229. }
  1230. }
  1231. cc_prebuilt_library_shared {
  1232. name: "libclang_rt.hwasan",
  1233. no_libcrt: true,
  1234. nocrt: true,
  1235. stl: "none",
  1236. system_shared_libs: [],
  1237. srcs: [""],
  1238. stubs: { versions: ["1"] },
  1239. stem: "libclang_rt.hwasan-aarch64-android",
  1240. sanitize: {
  1241. never: true,
  1242. },
  1243. } `)
  1244. ctx := result.TestContext
  1245. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1246. "lib64/bionic/libc.so",
  1247. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1248. })
  1249. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1250. installed := hwasan.Description("install libclang_rt.hwasan")
  1251. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1252. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1253. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1254. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1255. }
  1256. func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
  1257. result := android.GroupFixturePreparers(
  1258. prepareForTestOfRuntimeApexWithHwasan,
  1259. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1260. variables.SanitizeDevice = []string{"hwaddress"}
  1261. }),
  1262. ).RunTestWithBp(t, `
  1263. cc_library {
  1264. name: "libc",
  1265. no_libcrt: true,
  1266. nocrt: true,
  1267. stl: "none",
  1268. system_shared_libs: [],
  1269. stubs: { versions: ["1"] },
  1270. apex_available: ["com.android.runtime"],
  1271. }
  1272. cc_prebuilt_library_shared {
  1273. name: "libclang_rt.hwasan",
  1274. no_libcrt: true,
  1275. nocrt: true,
  1276. stl: "none",
  1277. system_shared_libs: [],
  1278. srcs: [""],
  1279. stubs: { versions: ["1"] },
  1280. stem: "libclang_rt.hwasan-aarch64-android",
  1281. sanitize: {
  1282. never: true,
  1283. },
  1284. }
  1285. `)
  1286. ctx := result.TestContext
  1287. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1288. "lib64/bionic/libc.so",
  1289. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1290. })
  1291. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1292. installed := hwasan.Description("install libclang_rt.hwasan")
  1293. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1294. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1295. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1296. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1297. }
  1298. func TestApexDependsOnLLNDKTransitively(t *testing.T) {
  1299. testcases := []struct {
  1300. name string
  1301. minSdkVersion string
  1302. apexVariant string
  1303. shouldLink string
  1304. shouldNotLink []string
  1305. }{
  1306. {
  1307. name: "unspecified version links to the latest",
  1308. minSdkVersion: "",
  1309. apexVariant: "apex10000",
  1310. shouldLink: "current",
  1311. shouldNotLink: []string{"29", "30"},
  1312. },
  1313. {
  1314. name: "always use the latest",
  1315. minSdkVersion: "min_sdk_version: \"29\",",
  1316. apexVariant: "apex29",
  1317. shouldLink: "current",
  1318. shouldNotLink: []string{"29", "30"},
  1319. },
  1320. }
  1321. for _, tc := range testcases {
  1322. t.Run(tc.name, func(t *testing.T) {
  1323. ctx := testApex(t, `
  1324. apex {
  1325. name: "myapex",
  1326. key: "myapex.key",
  1327. native_shared_libs: ["mylib"],
  1328. updatable: false,
  1329. `+tc.minSdkVersion+`
  1330. }
  1331. apex_key {
  1332. name: "myapex.key",
  1333. public_key: "testkey.avbpubkey",
  1334. private_key: "testkey.pem",
  1335. }
  1336. cc_library {
  1337. name: "mylib",
  1338. srcs: ["mylib.cpp"],
  1339. vendor_available: true,
  1340. shared_libs: ["libbar"],
  1341. system_shared_libs: [],
  1342. stl: "none",
  1343. apex_available: [ "myapex" ],
  1344. min_sdk_version: "29",
  1345. }
  1346. cc_library {
  1347. name: "libbar",
  1348. srcs: ["mylib.cpp"],
  1349. system_shared_libs: [],
  1350. stl: "none",
  1351. stubs: { versions: ["29","30"] },
  1352. llndk: {
  1353. symbol_file: "libbar.map.txt",
  1354. }
  1355. }
  1356. `,
  1357. withUnbundledBuild,
  1358. )
  1359. // Ensure that LLNDK dep is not included
  1360. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1361. "lib64/mylib.so",
  1362. })
  1363. // Ensure that LLNDK dep is required
  1364. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1365. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1366. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
  1367. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
  1368. ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
  1369. for _, ver := range tc.shouldNotLink {
  1370. ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
  1371. }
  1372. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
  1373. ver := tc.shouldLink
  1374. if tc.shouldLink == "current" {
  1375. ver = strconv.Itoa(android.FutureApiLevelInt)
  1376. }
  1377. ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
  1378. })
  1379. }
  1380. }
  1381. func TestApexWithSystemLibsStubs(t *testing.T) {
  1382. ctx := testApex(t, `
  1383. apex {
  1384. name: "myapex",
  1385. key: "myapex.key",
  1386. native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
  1387. updatable: false,
  1388. }
  1389. apex_key {
  1390. name: "myapex.key",
  1391. public_key: "testkey.avbpubkey",
  1392. private_key: "testkey.pem",
  1393. }
  1394. cc_library {
  1395. name: "mylib",
  1396. srcs: ["mylib.cpp"],
  1397. system_shared_libs: ["libc", "libm"],
  1398. shared_libs: ["libdl#27"],
  1399. stl: "none",
  1400. apex_available: [ "myapex" ],
  1401. }
  1402. cc_library_shared {
  1403. name: "mylib_shared",
  1404. srcs: ["mylib.cpp"],
  1405. shared_libs: ["libdl#27"],
  1406. stl: "none",
  1407. apex_available: [ "myapex" ],
  1408. }
  1409. cc_library {
  1410. name: "libBootstrap",
  1411. srcs: ["mylib.cpp"],
  1412. stl: "none",
  1413. bootstrap: true,
  1414. }
  1415. `)
  1416. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1417. copyCmds := apexRule.Args["copy_commands"]
  1418. // Ensure that mylib, libm, libdl are included.
  1419. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1420. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
  1421. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
  1422. // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
  1423. ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
  1424. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1425. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1426. mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
  1427. // For dependency to libc
  1428. // Ensure that mylib is linking with the latest version of stubs
  1429. ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
  1430. // ... and not linking to the non-stub (impl) variant
  1431. ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1432. // ... Cflags from stub is correctly exported to mylib
  1433. ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
  1434. ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
  1435. // For dependency to libm
  1436. // Ensure that mylib is linking with the non-stub (impl) variant
  1437. ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
  1438. // ... and not linking to the stub variant
  1439. ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
  1440. // ... and is not compiling with the stub
  1441. ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
  1442. ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
  1443. // For dependency to libdl
  1444. // Ensure that mylib is linking with the specified version of stubs
  1445. ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
  1446. // ... and not linking to the other versions of stubs
  1447. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
  1448. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
  1449. // ... and not linking to the non-stub (impl) variant
  1450. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
  1451. // ... Cflags from stub is correctly exported to mylib
  1452. ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
  1453. ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
  1454. // Ensure that libBootstrap is depending on the platform variant of bionic libs
  1455. libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1456. ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1457. ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
  1458. ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
  1459. }
  1460. func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
  1461. // there are three links between liba --> libz.
  1462. // 1) myapex -> libx -> liba -> libz : this should be #30 link
  1463. // 2) otherapex -> liby -> liba -> libz : this should be #30 link
  1464. // 3) (platform) -> liba -> libz : this should be non-stub link
  1465. ctx := testApex(t, `
  1466. apex {
  1467. name: "myapex",
  1468. key: "myapex.key",
  1469. native_shared_libs: ["libx"],
  1470. min_sdk_version: "29",
  1471. }
  1472. apex {
  1473. name: "otherapex",
  1474. key: "myapex.key",
  1475. native_shared_libs: ["liby"],
  1476. min_sdk_version: "30",
  1477. }
  1478. apex_key {
  1479. name: "myapex.key",
  1480. public_key: "testkey.avbpubkey",
  1481. private_key: "testkey.pem",
  1482. }
  1483. cc_library {
  1484. name: "libx",
  1485. shared_libs: ["liba"],
  1486. system_shared_libs: [],
  1487. stl: "none",
  1488. apex_available: [ "myapex" ],
  1489. min_sdk_version: "29",
  1490. }
  1491. cc_library {
  1492. name: "liby",
  1493. shared_libs: ["liba"],
  1494. system_shared_libs: [],
  1495. stl: "none",
  1496. apex_available: [ "otherapex" ],
  1497. min_sdk_version: "29",
  1498. }
  1499. cc_library {
  1500. name: "liba",
  1501. shared_libs: ["libz"],
  1502. system_shared_libs: [],
  1503. stl: "none",
  1504. apex_available: [
  1505. "//apex_available:anyapex",
  1506. "//apex_available:platform",
  1507. ],
  1508. min_sdk_version: "29",
  1509. }
  1510. cc_library {
  1511. name: "libz",
  1512. system_shared_libs: [],
  1513. stl: "none",
  1514. stubs: {
  1515. versions: ["28", "30"],
  1516. },
  1517. }
  1518. `)
  1519. expectLink := func(from, from_variant, to, to_variant string) {
  1520. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1521. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1522. }
  1523. expectNoLink := func(from, from_variant, to, to_variant string) {
  1524. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1525. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1526. }
  1527. // platform liba is linked to non-stub version
  1528. expectLink("liba", "shared", "libz", "shared")
  1529. // liba in myapex is linked to current
  1530. expectLink("liba", "shared_apex29", "libz", "shared_current")
  1531. expectNoLink("liba", "shared_apex29", "libz", "shared_30")
  1532. expectNoLink("liba", "shared_apex29", "libz", "shared_28")
  1533. expectNoLink("liba", "shared_apex29", "libz", "shared")
  1534. // liba in otherapex is linked to current
  1535. expectLink("liba", "shared_apex30", "libz", "shared_current")
  1536. expectNoLink("liba", "shared_apex30", "libz", "shared_30")
  1537. expectNoLink("liba", "shared_apex30", "libz", "shared_28")
  1538. expectNoLink("liba", "shared_apex30", "libz", "shared")
  1539. }
  1540. func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
  1541. ctx := testApex(t, `
  1542. apex {
  1543. name: "myapex",
  1544. key: "myapex.key",
  1545. native_shared_libs: ["libx"],
  1546. min_sdk_version: "R",
  1547. }
  1548. apex_key {
  1549. name: "myapex.key",
  1550. public_key: "testkey.avbpubkey",
  1551. private_key: "testkey.pem",
  1552. }
  1553. cc_library {
  1554. name: "libx",
  1555. shared_libs: ["libz"],
  1556. system_shared_libs: [],
  1557. stl: "none",
  1558. apex_available: [ "myapex" ],
  1559. min_sdk_version: "R",
  1560. }
  1561. cc_library {
  1562. name: "libz",
  1563. system_shared_libs: [],
  1564. stl: "none",
  1565. stubs: {
  1566. versions: ["29", "R"],
  1567. },
  1568. }
  1569. `,
  1570. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1571. variables.Platform_version_active_codenames = []string{"R"}
  1572. }),
  1573. )
  1574. expectLink := func(from, from_variant, to, to_variant string) {
  1575. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1576. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1577. }
  1578. expectNoLink := func(from, from_variant, to, to_variant string) {
  1579. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1580. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1581. }
  1582. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1583. expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
  1584. expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
  1585. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1586. }
  1587. func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
  1588. testApex(t, `
  1589. apex {
  1590. name: "myapex",
  1591. key: "myapex.key",
  1592. java_libs: ["libx"],
  1593. min_sdk_version: "S",
  1594. }
  1595. apex_key {
  1596. name: "myapex.key",
  1597. public_key: "testkey.avbpubkey",
  1598. private_key: "testkey.pem",
  1599. }
  1600. java_library {
  1601. name: "libx",
  1602. srcs: ["a.java"],
  1603. apex_available: [ "myapex" ],
  1604. sdk_version: "current",
  1605. min_sdk_version: "S", // should be okay
  1606. }
  1607. `,
  1608. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1609. variables.Platform_version_active_codenames = []string{"S"}
  1610. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1611. }),
  1612. )
  1613. }
  1614. func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
  1615. ctx := testApex(t, `
  1616. apex {
  1617. name: "myapex",
  1618. key: "myapex.key",
  1619. native_shared_libs: ["libx"],
  1620. updatable: false,
  1621. }
  1622. apex_key {
  1623. name: "myapex.key",
  1624. public_key: "testkey.avbpubkey",
  1625. private_key: "testkey.pem",
  1626. }
  1627. cc_library {
  1628. name: "libx",
  1629. shared_libs: ["libz"],
  1630. system_shared_libs: [],
  1631. stl: "none",
  1632. apex_available: [ "myapex" ],
  1633. }
  1634. cc_library {
  1635. name: "libz",
  1636. system_shared_libs: [],
  1637. stl: "none",
  1638. stubs: {
  1639. versions: ["1", "2"],
  1640. },
  1641. }
  1642. `)
  1643. expectLink := func(from, from_variant, to, to_variant string) {
  1644. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1645. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1646. }
  1647. expectNoLink := func(from, from_variant, to, to_variant string) {
  1648. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1649. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1650. }
  1651. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1652. expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
  1653. expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
  1654. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1655. }
  1656. func TestApexMinSdkVersion_crtobjectInVendorApex(t *testing.T) {
  1657. ctx := testApex(t, `
  1658. apex {
  1659. name: "myapex",
  1660. key: "myapex.key",
  1661. native_shared_libs: ["mylib"],
  1662. updatable: false,
  1663. vendor: true,
  1664. min_sdk_version: "29",
  1665. }
  1666. apex_key {
  1667. name: "myapex.key",
  1668. public_key: "testkey.avbpubkey",
  1669. private_key: "testkey.pem",
  1670. }
  1671. cc_library {
  1672. name: "mylib",
  1673. vendor_available: true,
  1674. system_shared_libs: [],
  1675. stl: "none",
  1676. apex_available: [ "myapex" ],
  1677. min_sdk_version: "29",
  1678. }
  1679. `)
  1680. vendorVariant := "android_vendor.29_arm64_armv8-a"
  1681. // First check that the correct variant of crtbegin_so is used.
  1682. ldRule := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29").Rule("ld")
  1683. crtBegin := names(ldRule.Args["crtBegin"])
  1684. ensureListContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
  1685. // Ensure that the crtbegin_so used by the APEX is targeting 29
  1686. cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
  1687. android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
  1688. }
  1689. func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
  1690. ctx := testApex(t, `
  1691. apex {
  1692. name: "myapex",
  1693. key: "myapex.key",
  1694. native_shared_libs: ["libx"],
  1695. updatable: false,
  1696. }
  1697. apex_key {
  1698. name: "myapex.key",
  1699. public_key: "testkey.avbpubkey",
  1700. private_key: "testkey.pem",
  1701. }
  1702. cc_library {
  1703. name: "libx",
  1704. system_shared_libs: [],
  1705. stl: "none",
  1706. apex_available: [ "myapex" ],
  1707. stubs: {
  1708. versions: ["1", "2"],
  1709. },
  1710. }
  1711. cc_library {
  1712. name: "libz",
  1713. shared_libs: ["libx"],
  1714. system_shared_libs: [],
  1715. stl: "none",
  1716. }
  1717. `)
  1718. expectLink := func(from, from_variant, to, to_variant string) {
  1719. t.Helper()
  1720. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1721. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1722. }
  1723. expectNoLink := func(from, from_variant, to, to_variant string) {
  1724. t.Helper()
  1725. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1726. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1727. }
  1728. expectLink("libz", "shared", "libx", "shared_current")
  1729. expectNoLink("libz", "shared", "libx", "shared_2")
  1730. expectNoLink("libz", "shared", "libz", "shared_1")
  1731. expectNoLink("libz", "shared", "libz", "shared")
  1732. }
  1733. var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
  1734. func(variables android.FixtureProductVariables) {
  1735. variables.SanitizeDevice = []string{"hwaddress"}
  1736. },
  1737. )
  1738. func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
  1739. ctx := testApex(t, `
  1740. apex {
  1741. name: "myapex",
  1742. key: "myapex.key",
  1743. native_shared_libs: ["libx"],
  1744. min_sdk_version: "29",
  1745. }
  1746. apex_key {
  1747. name: "myapex.key",
  1748. public_key: "testkey.avbpubkey",
  1749. private_key: "testkey.pem",
  1750. }
  1751. cc_library {
  1752. name: "libx",
  1753. shared_libs: ["libbar"],
  1754. apex_available: [ "myapex" ],
  1755. min_sdk_version: "29",
  1756. }
  1757. cc_library {
  1758. name: "libbar",
  1759. stubs: {
  1760. versions: ["29", "30"],
  1761. },
  1762. }
  1763. `,
  1764. prepareForTestWithSantitizeHwaddress,
  1765. )
  1766. expectLink := func(from, from_variant, to, to_variant string) {
  1767. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1768. libFlags := ld.Args["libFlags"]
  1769. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1770. }
  1771. expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
  1772. }
  1773. func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
  1774. ctx := testApex(t, `
  1775. apex {
  1776. name: "myapex",
  1777. key: "myapex.key",
  1778. native_shared_libs: ["libx"],
  1779. min_sdk_version: "29",
  1780. }
  1781. apex_key {
  1782. name: "myapex.key",
  1783. public_key: "testkey.avbpubkey",
  1784. private_key: "testkey.pem",
  1785. }
  1786. cc_library {
  1787. name: "libx",
  1788. apex_available: [ "myapex" ],
  1789. min_sdk_version: "29",
  1790. }
  1791. `)
  1792. // ensure apex variant of c++ is linked with static unwinder
  1793. cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
  1794. ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1795. // note that platform variant is not.
  1796. cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  1797. ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1798. }
  1799. func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
  1800. testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
  1801. apex {
  1802. name: "myapex",
  1803. key: "myapex.key",
  1804. native_shared_libs: ["mylib"],
  1805. min_sdk_version: "29",
  1806. }
  1807. apex_key {
  1808. name: "myapex.key",
  1809. public_key: "testkey.avbpubkey",
  1810. private_key: "testkey.pem",
  1811. }
  1812. cc_library {
  1813. name: "mylib",
  1814. srcs: ["mylib.cpp"],
  1815. system_shared_libs: [],
  1816. stl: "none",
  1817. apex_available: [
  1818. "myapex",
  1819. ],
  1820. min_sdk_version: "30",
  1821. }
  1822. `)
  1823. testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
  1824. apex {
  1825. name: "myapex",
  1826. key: "myapex.key",
  1827. native_shared_libs: ["libfoo.ffi"],
  1828. min_sdk_version: "29",
  1829. }
  1830. apex_key {
  1831. name: "myapex.key",
  1832. public_key: "testkey.avbpubkey",
  1833. private_key: "testkey.pem",
  1834. }
  1835. rust_ffi_shared {
  1836. name: "libfoo.ffi",
  1837. srcs: ["foo.rs"],
  1838. crate_name: "foo",
  1839. apex_available: [
  1840. "myapex",
  1841. ],
  1842. min_sdk_version: "30",
  1843. }
  1844. `)
  1845. testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
  1846. apex {
  1847. name: "myapex",
  1848. key: "myapex.key",
  1849. java_libs: ["libfoo"],
  1850. min_sdk_version: "29",
  1851. }
  1852. apex_key {
  1853. name: "myapex.key",
  1854. public_key: "testkey.avbpubkey",
  1855. private_key: "testkey.pem",
  1856. }
  1857. java_import {
  1858. name: "libfoo",
  1859. jars: ["libfoo.jar"],
  1860. apex_available: [
  1861. "myapex",
  1862. ],
  1863. min_sdk_version: "30",
  1864. }
  1865. `)
  1866. }
  1867. func TestApexMinSdkVersion_Okay(t *testing.T) {
  1868. testApex(t, `
  1869. apex {
  1870. name: "myapex",
  1871. key: "myapex.key",
  1872. native_shared_libs: ["libfoo"],
  1873. java_libs: ["libbar"],
  1874. min_sdk_version: "29",
  1875. }
  1876. apex_key {
  1877. name: "myapex.key",
  1878. public_key: "testkey.avbpubkey",
  1879. private_key: "testkey.pem",
  1880. }
  1881. cc_library {
  1882. name: "libfoo",
  1883. srcs: ["mylib.cpp"],
  1884. shared_libs: ["libfoo_dep"],
  1885. apex_available: ["myapex"],
  1886. min_sdk_version: "29",
  1887. }
  1888. cc_library {
  1889. name: "libfoo_dep",
  1890. srcs: ["mylib.cpp"],
  1891. apex_available: ["myapex"],
  1892. min_sdk_version: "29",
  1893. }
  1894. java_library {
  1895. name: "libbar",
  1896. sdk_version: "current",
  1897. srcs: ["a.java"],
  1898. static_libs: [
  1899. "libbar_dep",
  1900. "libbar_import_dep",
  1901. ],
  1902. apex_available: ["myapex"],
  1903. min_sdk_version: "29",
  1904. }
  1905. java_library {
  1906. name: "libbar_dep",
  1907. sdk_version: "current",
  1908. srcs: ["a.java"],
  1909. apex_available: ["myapex"],
  1910. min_sdk_version: "29",
  1911. }
  1912. java_import {
  1913. name: "libbar_import_dep",
  1914. jars: ["libbar.jar"],
  1915. apex_available: ["myapex"],
  1916. min_sdk_version: "29",
  1917. }
  1918. `)
  1919. }
  1920. func TestApexMinSdkVersion_MinApiForArch(t *testing.T) {
  1921. // Tests that an apex dependency with min_sdk_version higher than the
  1922. // min_sdk_version of the apex is allowed as long as the dependency's
  1923. // min_sdk_version is less than or equal to the api level that the
  1924. // architecture was introduced in. In this case, arm64 didn't exist
  1925. // until api level 21, so the arm64 code will never need to run on
  1926. // an api level 20 device, even if other architectures of the apex
  1927. // will.
  1928. testApex(t, `
  1929. apex {
  1930. name: "myapex",
  1931. key: "myapex.key",
  1932. native_shared_libs: ["libfoo"],
  1933. min_sdk_version: "20",
  1934. }
  1935. apex_key {
  1936. name: "myapex.key",
  1937. public_key: "testkey.avbpubkey",
  1938. private_key: "testkey.pem",
  1939. }
  1940. cc_library {
  1941. name: "libfoo",
  1942. srcs: ["mylib.cpp"],
  1943. apex_available: ["myapex"],
  1944. min_sdk_version: "21",
  1945. stl: "none",
  1946. }
  1947. `)
  1948. }
  1949. func TestJavaStableSdkVersion(t *testing.T) {
  1950. testCases := []struct {
  1951. name string
  1952. expectedError string
  1953. bp string
  1954. preparer android.FixturePreparer
  1955. }{
  1956. {
  1957. name: "Non-updatable apex with non-stable dep",
  1958. bp: `
  1959. apex {
  1960. name: "myapex",
  1961. java_libs: ["myjar"],
  1962. key: "myapex.key",
  1963. updatable: false,
  1964. }
  1965. apex_key {
  1966. name: "myapex.key",
  1967. public_key: "testkey.avbpubkey",
  1968. private_key: "testkey.pem",
  1969. }
  1970. java_library {
  1971. name: "myjar",
  1972. srcs: ["foo/bar/MyClass.java"],
  1973. sdk_version: "test_current",
  1974. apex_available: ["myapex"],
  1975. }
  1976. `,
  1977. },
  1978. {
  1979. name: "Updatable apex with stable dep",
  1980. bp: `
  1981. apex {
  1982. name: "myapex",
  1983. java_libs: ["myjar"],
  1984. key: "myapex.key",
  1985. updatable: true,
  1986. min_sdk_version: "29",
  1987. }
  1988. apex_key {
  1989. name: "myapex.key",
  1990. public_key: "testkey.avbpubkey",
  1991. private_key: "testkey.pem",
  1992. }
  1993. java_library {
  1994. name: "myjar",
  1995. srcs: ["foo/bar/MyClass.java"],
  1996. sdk_version: "current",
  1997. apex_available: ["myapex"],
  1998. min_sdk_version: "29",
  1999. }
  2000. `,
  2001. },
  2002. {
  2003. name: "Updatable apex with non-stable dep",
  2004. expectedError: "cannot depend on \"myjar\"",
  2005. bp: `
  2006. apex {
  2007. name: "myapex",
  2008. java_libs: ["myjar"],
  2009. key: "myapex.key",
  2010. updatable: true,
  2011. }
  2012. apex_key {
  2013. name: "myapex.key",
  2014. public_key: "testkey.avbpubkey",
  2015. private_key: "testkey.pem",
  2016. }
  2017. java_library {
  2018. name: "myjar",
  2019. srcs: ["foo/bar/MyClass.java"],
  2020. sdk_version: "test_current",
  2021. apex_available: ["myapex"],
  2022. }
  2023. `,
  2024. },
  2025. {
  2026. name: "Updatable apex with non-stable legacy core platform dep",
  2027. expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
  2028. bp: `
  2029. apex {
  2030. name: "myapex",
  2031. java_libs: ["myjar-uses-legacy"],
  2032. key: "myapex.key",
  2033. updatable: true,
  2034. }
  2035. apex_key {
  2036. name: "myapex.key",
  2037. public_key: "testkey.avbpubkey",
  2038. private_key: "testkey.pem",
  2039. }
  2040. java_library {
  2041. name: "myjar-uses-legacy",
  2042. srcs: ["foo/bar/MyClass.java"],
  2043. sdk_version: "core_platform",
  2044. apex_available: ["myapex"],
  2045. }
  2046. `,
  2047. preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
  2048. },
  2049. {
  2050. name: "Updatable apex with non-stable transitive dep",
  2051. // This is not actually detecting that the transitive dependency is unstable, rather it is
  2052. // detecting that the transitive dependency is building against a wider API surface than the
  2053. // module that depends on it is using.
  2054. expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
  2055. bp: `
  2056. apex {
  2057. name: "myapex",
  2058. java_libs: ["myjar"],
  2059. key: "myapex.key",
  2060. updatable: true,
  2061. }
  2062. apex_key {
  2063. name: "myapex.key",
  2064. public_key: "testkey.avbpubkey",
  2065. private_key: "testkey.pem",
  2066. }
  2067. java_library {
  2068. name: "myjar",
  2069. srcs: ["foo/bar/MyClass.java"],
  2070. sdk_version: "current",
  2071. apex_available: ["myapex"],
  2072. static_libs: ["transitive-jar"],
  2073. }
  2074. java_library {
  2075. name: "transitive-jar",
  2076. srcs: ["foo/bar/MyClass.java"],
  2077. sdk_version: "core_platform",
  2078. apex_available: ["myapex"],
  2079. }
  2080. `,
  2081. },
  2082. }
  2083. for _, test := range testCases {
  2084. if test.name != "Updatable apex with non-stable legacy core platform dep" {
  2085. continue
  2086. }
  2087. t.Run(test.name, func(t *testing.T) {
  2088. errorHandler := android.FixtureExpectsNoErrors
  2089. if test.expectedError != "" {
  2090. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  2091. }
  2092. android.GroupFixturePreparers(
  2093. java.PrepareForTestWithJavaDefaultModules,
  2094. PrepareForTestWithApexBuildComponents,
  2095. prepareForTestWithMyapex,
  2096. android.OptionalFixturePreparer(test.preparer),
  2097. ).
  2098. ExtendWithErrorHandler(errorHandler).
  2099. RunTestWithBp(t, test.bp)
  2100. })
  2101. }
  2102. }
  2103. func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
  2104. testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
  2105. apex {
  2106. name: "myapex",
  2107. key: "myapex.key",
  2108. native_shared_libs: ["mylib"],
  2109. min_sdk_version: "29",
  2110. }
  2111. apex_key {
  2112. name: "myapex.key",
  2113. public_key: "testkey.avbpubkey",
  2114. private_key: "testkey.pem",
  2115. }
  2116. cc_library {
  2117. name: "mylib",
  2118. srcs: ["mylib.cpp"],
  2119. shared_libs: ["mylib2"],
  2120. system_shared_libs: [],
  2121. stl: "none",
  2122. apex_available: [
  2123. "myapex",
  2124. ],
  2125. min_sdk_version: "29",
  2126. }
  2127. // indirect part of the apex
  2128. cc_library {
  2129. name: "mylib2",
  2130. srcs: ["mylib.cpp"],
  2131. system_shared_libs: [],
  2132. stl: "none",
  2133. apex_available: [
  2134. "myapex",
  2135. ],
  2136. min_sdk_version: "30",
  2137. }
  2138. `)
  2139. }
  2140. func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
  2141. testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
  2142. apex {
  2143. name: "myapex",
  2144. key: "myapex.key",
  2145. apps: ["AppFoo"],
  2146. min_sdk_version: "29",
  2147. updatable: false,
  2148. }
  2149. apex_key {
  2150. name: "myapex.key",
  2151. public_key: "testkey.avbpubkey",
  2152. private_key: "testkey.pem",
  2153. }
  2154. android_app {
  2155. name: "AppFoo",
  2156. srcs: ["foo/bar/MyClass.java"],
  2157. sdk_version: "current",
  2158. min_sdk_version: "29",
  2159. system_modules: "none",
  2160. stl: "none",
  2161. static_libs: ["bar"],
  2162. apex_available: [ "myapex" ],
  2163. }
  2164. java_library {
  2165. name: "bar",
  2166. sdk_version: "current",
  2167. srcs: ["a.java"],
  2168. apex_available: [ "myapex" ],
  2169. }
  2170. `)
  2171. }
  2172. func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
  2173. ctx := testApex(t, `
  2174. apex {
  2175. name: "myapex",
  2176. key: "myapex.key",
  2177. native_shared_libs: ["mylib"],
  2178. min_sdk_version: "29",
  2179. }
  2180. apex_key {
  2181. name: "myapex.key",
  2182. public_key: "testkey.avbpubkey",
  2183. private_key: "testkey.pem",
  2184. }
  2185. // mylib in myapex will link to mylib2#current
  2186. // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
  2187. cc_library {
  2188. name: "mylib",
  2189. srcs: ["mylib.cpp"],
  2190. shared_libs: ["mylib2"],
  2191. system_shared_libs: [],
  2192. stl: "none",
  2193. apex_available: ["myapex", "otherapex"],
  2194. min_sdk_version: "29",
  2195. }
  2196. cc_library {
  2197. name: "mylib2",
  2198. srcs: ["mylib.cpp"],
  2199. system_shared_libs: [],
  2200. stl: "none",
  2201. apex_available: ["otherapex"],
  2202. stubs: { versions: ["29", "30"] },
  2203. min_sdk_version: "30",
  2204. }
  2205. apex {
  2206. name: "otherapex",
  2207. key: "myapex.key",
  2208. native_shared_libs: ["mylib", "mylib2"],
  2209. min_sdk_version: "30",
  2210. }
  2211. `)
  2212. expectLink := func(from, from_variant, to, to_variant string) {
  2213. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  2214. libFlags := ld.Args["libFlags"]
  2215. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  2216. }
  2217. expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
  2218. expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
  2219. }
  2220. func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
  2221. withSAsActiveCodeNames := android.FixtureModifyProductVariables(
  2222. func(variables android.FixtureProductVariables) {
  2223. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2224. variables.Platform_version_active_codenames = []string{"S"}
  2225. },
  2226. )
  2227. testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
  2228. apex {
  2229. name: "myapex",
  2230. key: "myapex.key",
  2231. native_shared_libs: ["libfoo"],
  2232. min_sdk_version: "S",
  2233. }
  2234. apex_key {
  2235. name: "myapex.key",
  2236. public_key: "testkey.avbpubkey",
  2237. private_key: "testkey.pem",
  2238. }
  2239. cc_library {
  2240. name: "libfoo",
  2241. shared_libs: ["libbar"],
  2242. apex_available: ["myapex"],
  2243. min_sdk_version: "29",
  2244. }
  2245. cc_library {
  2246. name: "libbar",
  2247. apex_available: ["myapex"],
  2248. }
  2249. `, withSAsActiveCodeNames)
  2250. }
  2251. func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
  2252. withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2253. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2254. variables.Platform_version_active_codenames = []string{"S", "T"}
  2255. })
  2256. ctx := testApex(t, `
  2257. apex {
  2258. name: "myapex",
  2259. key: "myapex.key",
  2260. native_shared_libs: ["libfoo"],
  2261. min_sdk_version: "S",
  2262. }
  2263. apex_key {
  2264. name: "myapex.key",
  2265. public_key: "testkey.avbpubkey",
  2266. private_key: "testkey.pem",
  2267. }
  2268. cc_library {
  2269. name: "libfoo",
  2270. shared_libs: ["libbar"],
  2271. apex_available: ["myapex"],
  2272. min_sdk_version: "S",
  2273. }
  2274. cc_library {
  2275. name: "libbar",
  2276. stubs: {
  2277. symbol_file: "libbar.map.txt",
  2278. versions: ["30", "S", "T"],
  2279. },
  2280. }
  2281. `, withSAsActiveCodeNames)
  2282. // ensure libfoo is linked with current version of libbar stub
  2283. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
  2284. libFlags := libfoo.Rule("ld").Args["libFlags"]
  2285. ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
  2286. }
  2287. func TestFilesInSubDir(t *testing.T) {
  2288. ctx := testApex(t, `
  2289. apex {
  2290. name: "myapex",
  2291. key: "myapex.key",
  2292. native_shared_libs: ["mylib"],
  2293. binaries: ["mybin"],
  2294. prebuilts: ["myetc"],
  2295. compile_multilib: "both",
  2296. updatable: false,
  2297. }
  2298. apex_key {
  2299. name: "myapex.key",
  2300. public_key: "testkey.avbpubkey",
  2301. private_key: "testkey.pem",
  2302. }
  2303. prebuilt_etc {
  2304. name: "myetc",
  2305. src: "myprebuilt",
  2306. sub_dir: "foo/bar",
  2307. }
  2308. cc_library {
  2309. name: "mylib",
  2310. srcs: ["mylib.cpp"],
  2311. relative_install_path: "foo/bar",
  2312. system_shared_libs: [],
  2313. stl: "none",
  2314. apex_available: [ "myapex" ],
  2315. }
  2316. cc_binary {
  2317. name: "mybin",
  2318. srcs: ["mylib.cpp"],
  2319. relative_install_path: "foo/bar",
  2320. system_shared_libs: [],
  2321. stl: "none",
  2322. apex_available: [ "myapex" ],
  2323. }
  2324. `)
  2325. generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
  2326. cmd := generateFsRule.RuleParams.Command
  2327. // Ensure that the subdirectories are all listed
  2328. ensureContains(t, cmd, "/etc ")
  2329. ensureContains(t, cmd, "/etc/foo ")
  2330. ensureContains(t, cmd, "/etc/foo/bar ")
  2331. ensureContains(t, cmd, "/lib64 ")
  2332. ensureContains(t, cmd, "/lib64/foo ")
  2333. ensureContains(t, cmd, "/lib64/foo/bar ")
  2334. ensureContains(t, cmd, "/lib ")
  2335. ensureContains(t, cmd, "/lib/foo ")
  2336. ensureContains(t, cmd, "/lib/foo/bar ")
  2337. ensureContains(t, cmd, "/bin ")
  2338. ensureContains(t, cmd, "/bin/foo ")
  2339. ensureContains(t, cmd, "/bin/foo/bar ")
  2340. }
  2341. func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
  2342. ctx := testApex(t, `
  2343. apex {
  2344. name: "myapex",
  2345. key: "myapex.key",
  2346. multilib: {
  2347. both: {
  2348. native_shared_libs: ["mylib"],
  2349. binaries: ["mybin"],
  2350. },
  2351. },
  2352. compile_multilib: "both",
  2353. native_bridge_supported: true,
  2354. updatable: false,
  2355. }
  2356. apex_key {
  2357. name: "myapex.key",
  2358. public_key: "testkey.avbpubkey",
  2359. private_key: "testkey.pem",
  2360. }
  2361. cc_library {
  2362. name: "mylib",
  2363. relative_install_path: "foo/bar",
  2364. system_shared_libs: [],
  2365. stl: "none",
  2366. apex_available: [ "myapex" ],
  2367. native_bridge_supported: true,
  2368. }
  2369. cc_binary {
  2370. name: "mybin",
  2371. relative_install_path: "foo/bar",
  2372. system_shared_libs: [],
  2373. stl: "none",
  2374. apex_available: [ "myapex" ],
  2375. native_bridge_supported: true,
  2376. compile_multilib: "both", // default is "first" for binary
  2377. multilib: {
  2378. lib64: {
  2379. suffix: "64",
  2380. },
  2381. },
  2382. }
  2383. `, withNativeBridgeEnabled)
  2384. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2385. "bin/foo/bar/mybin",
  2386. "bin/foo/bar/mybin64",
  2387. "bin/arm/foo/bar/mybin",
  2388. "bin/arm64/foo/bar/mybin64",
  2389. "lib/foo/bar/mylib.so",
  2390. "lib/arm/foo/bar/mylib.so",
  2391. "lib64/foo/bar/mylib.so",
  2392. "lib64/arm64/foo/bar/mylib.so",
  2393. })
  2394. }
  2395. func TestVendorApex(t *testing.T) {
  2396. result := android.GroupFixturePreparers(
  2397. prepareForApexTest,
  2398. android.FixtureModifyConfig(android.SetKatiEnabledForTests),
  2399. ).RunTestWithBp(t, `
  2400. apex {
  2401. name: "myapex",
  2402. key: "myapex.key",
  2403. binaries: ["mybin"],
  2404. vendor: true,
  2405. updatable: false,
  2406. }
  2407. apex_key {
  2408. name: "myapex.key",
  2409. public_key: "testkey.avbpubkey",
  2410. private_key: "testkey.pem",
  2411. }
  2412. cc_binary {
  2413. name: "mybin",
  2414. vendor: true,
  2415. shared_libs: ["libfoo"],
  2416. }
  2417. cc_library {
  2418. name: "libfoo",
  2419. proprietary: true,
  2420. }
  2421. `)
  2422. ensureExactContents(t, result.TestContext, "myapex", "android_common_myapex_image", []string{
  2423. "bin/mybin",
  2424. "lib64/libfoo.so",
  2425. // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
  2426. "lib64/libc++.so",
  2427. })
  2428. apexBundle := result.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2429. data := android.AndroidMkDataForTest(t, result.TestContext, apexBundle)
  2430. name := apexBundle.BaseModuleName()
  2431. prefix := "TARGET_"
  2432. var builder strings.Builder
  2433. data.Custom(&builder, name, prefix, "", data)
  2434. androidMk := android.StringRelativeToTop(result.Config, builder.String())
  2435. installPath := "out/target/product/test_device/vendor/apex"
  2436. ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
  2437. apexManifestRule := result.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2438. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2439. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2440. }
  2441. func TestVendorApex_use_vndk_as_stable_TryingToIncludeVNDKLib(t *testing.T) {
  2442. testApexError(t, `Trying to include a VNDK library`, `
  2443. apex {
  2444. name: "myapex",
  2445. key: "myapex.key",
  2446. native_shared_libs: ["libc++"], // libc++ is a VNDK lib
  2447. vendor: true,
  2448. use_vndk_as_stable: true,
  2449. updatable: false,
  2450. }
  2451. apex_key {
  2452. name: "myapex.key",
  2453. public_key: "testkey.avbpubkey",
  2454. private_key: "testkey.pem",
  2455. }`)
  2456. }
  2457. func TestVendorApex_use_vndk_as_stable(t *testing.T) {
  2458. // myapex myapex2
  2459. // | |
  2460. // mybin ------. mybin2
  2461. // \ \ / |
  2462. // (stable) .---\--------` |
  2463. // \ / \ |
  2464. // \ / \ /
  2465. // libvndk libvendor
  2466. // (vndk)
  2467. ctx := testApex(t, `
  2468. apex {
  2469. name: "myapex",
  2470. key: "myapex.key",
  2471. binaries: ["mybin"],
  2472. vendor: true,
  2473. use_vndk_as_stable: true,
  2474. updatable: false,
  2475. }
  2476. apex_key {
  2477. name: "myapex.key",
  2478. public_key: "testkey.avbpubkey",
  2479. private_key: "testkey.pem",
  2480. }
  2481. cc_binary {
  2482. name: "mybin",
  2483. vendor: true,
  2484. shared_libs: ["libvndk", "libvendor"],
  2485. }
  2486. cc_library {
  2487. name: "libvndk",
  2488. vndk: {
  2489. enabled: true,
  2490. },
  2491. vendor_available: true,
  2492. product_available: true,
  2493. }
  2494. cc_library {
  2495. name: "libvendor",
  2496. vendor: true,
  2497. stl: "none",
  2498. }
  2499. apex {
  2500. name: "myapex2",
  2501. key: "myapex.key",
  2502. binaries: ["mybin2"],
  2503. vendor: true,
  2504. use_vndk_as_stable: false,
  2505. updatable: false,
  2506. }
  2507. cc_binary {
  2508. name: "mybin2",
  2509. vendor: true,
  2510. shared_libs: ["libvndk", "libvendor"],
  2511. }
  2512. `)
  2513. vendorVariant := "android_vendor.29_arm64_armv8-a"
  2514. for _, tc := range []struct {
  2515. name string
  2516. apexName string
  2517. moduleName string
  2518. moduleVariant string
  2519. libs []string
  2520. contents []string
  2521. requireVndkNamespace bool
  2522. }{
  2523. {
  2524. name: "use_vndk_as_stable",
  2525. apexName: "myapex",
  2526. moduleName: "mybin",
  2527. moduleVariant: vendorVariant + "_apex10000",
  2528. libs: []string{
  2529. // should link with vendor variants of VNDK libs(libvndk/libc++)
  2530. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared/libvndk.so",
  2531. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared/libc++.so",
  2532. // unstable Vendor libs as APEX variant
  2533. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2534. },
  2535. contents: []string{
  2536. "bin/mybin",
  2537. "lib64/libvendor.so",
  2538. // VNDK libs (libvndk/libc++) are not included
  2539. },
  2540. requireVndkNamespace: true,
  2541. },
  2542. {
  2543. name: "!use_vndk_as_stable",
  2544. apexName: "myapex2",
  2545. moduleName: "mybin2",
  2546. moduleVariant: vendorVariant + "_myapex2",
  2547. libs: []string{
  2548. // should link with "unique" APEX(myapex2) variant of VNDK libs(libvndk/libc++)
  2549. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared_myapex2/libvndk.so",
  2550. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared_myapex2/libc++.so",
  2551. // unstable vendor libs have "merged" APEX variants
  2552. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2553. },
  2554. contents: []string{
  2555. "bin/mybin2",
  2556. "lib64/libvendor.so",
  2557. // VNDK libs are included as well
  2558. "lib64/libvndk.so",
  2559. "lib64/libc++.so",
  2560. },
  2561. requireVndkNamespace: false,
  2562. },
  2563. } {
  2564. t.Run(tc.name, func(t *testing.T) {
  2565. // Check linked libs
  2566. ldRule := ctx.ModuleForTests(tc.moduleName, tc.moduleVariant).Rule("ld")
  2567. libs := names(ldRule.Args["libFlags"])
  2568. for _, lib := range tc.libs {
  2569. ensureListContains(t, libs, lib)
  2570. }
  2571. // Check apex contents
  2572. ensureExactContents(t, ctx, tc.apexName, "android_common_"+tc.apexName+"_image", tc.contents)
  2573. // Check "requireNativeLibs"
  2574. apexManifestRule := ctx.ModuleForTests(tc.apexName, "android_common_"+tc.apexName+"_image").Rule("apexManifestRule")
  2575. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2576. if tc.requireVndkNamespace {
  2577. ensureListContains(t, requireNativeLibs, ":vndk")
  2578. } else {
  2579. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2580. }
  2581. })
  2582. }
  2583. }
  2584. func TestProductVariant(t *testing.T) {
  2585. ctx := testApex(t, `
  2586. apex {
  2587. name: "myapex",
  2588. key: "myapex.key",
  2589. updatable: false,
  2590. product_specific: true,
  2591. binaries: ["foo"],
  2592. }
  2593. apex_key {
  2594. name: "myapex.key",
  2595. public_key: "testkey.avbpubkey",
  2596. private_key: "testkey.pem",
  2597. }
  2598. cc_binary {
  2599. name: "foo",
  2600. product_available: true,
  2601. apex_available: ["myapex"],
  2602. srcs: ["foo.cpp"],
  2603. }
  2604. `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2605. variables.ProductVndkVersion = proptools.StringPtr("current")
  2606. }),
  2607. )
  2608. cflags := strings.Fields(
  2609. ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_myapex").Rule("cc").Args["cFlags"])
  2610. ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
  2611. ensureListContains(t, cflags, "-D__ANDROID_APEX__")
  2612. ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
  2613. ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
  2614. }
  2615. func TestApex_withPrebuiltFirmware(t *testing.T) {
  2616. testCases := []struct {
  2617. name string
  2618. additionalProp string
  2619. }{
  2620. {"system apex with prebuilt_firmware", ""},
  2621. {"vendor apex with prebuilt_firmware", "vendor: true,"},
  2622. }
  2623. for _, tc := range testCases {
  2624. t.Run(tc.name, func(t *testing.T) {
  2625. ctx := testApex(t, `
  2626. apex {
  2627. name: "myapex",
  2628. key: "myapex.key",
  2629. prebuilts: ["myfirmware"],
  2630. updatable: false,
  2631. `+tc.additionalProp+`
  2632. }
  2633. apex_key {
  2634. name: "myapex.key",
  2635. public_key: "testkey.avbpubkey",
  2636. private_key: "testkey.pem",
  2637. }
  2638. prebuilt_firmware {
  2639. name: "myfirmware",
  2640. src: "myfirmware.bin",
  2641. filename_from_src: true,
  2642. `+tc.additionalProp+`
  2643. }
  2644. `)
  2645. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2646. "etc/firmware/myfirmware.bin",
  2647. })
  2648. })
  2649. }
  2650. }
  2651. func TestAndroidMk_VendorApexRequired(t *testing.T) {
  2652. ctx := testApex(t, `
  2653. apex {
  2654. name: "myapex",
  2655. key: "myapex.key",
  2656. vendor: true,
  2657. native_shared_libs: ["mylib"],
  2658. updatable: false,
  2659. }
  2660. apex_key {
  2661. name: "myapex.key",
  2662. public_key: "testkey.avbpubkey",
  2663. private_key: "testkey.pem",
  2664. }
  2665. cc_library {
  2666. name: "mylib",
  2667. vendor_available: true,
  2668. }
  2669. `)
  2670. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2671. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2672. name := apexBundle.BaseModuleName()
  2673. prefix := "TARGET_"
  2674. var builder strings.Builder
  2675. data.Custom(&builder, name, prefix, "", data)
  2676. androidMk := builder.String()
  2677. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++.vendor.myapex:64 mylib.vendor.myapex:64 apex_manifest.pb.myapex apex_pubkey.myapex libc.vendor libm.vendor libdl.vendor\n")
  2678. }
  2679. func TestAndroidMkWritesCommonProperties(t *testing.T) {
  2680. ctx := testApex(t, `
  2681. apex {
  2682. name: "myapex",
  2683. key: "myapex.key",
  2684. vintf_fragments: ["fragment.xml"],
  2685. init_rc: ["init.rc"],
  2686. updatable: false,
  2687. }
  2688. apex_key {
  2689. name: "myapex.key",
  2690. public_key: "testkey.avbpubkey",
  2691. private_key: "testkey.pem",
  2692. }
  2693. cc_binary {
  2694. name: "mybin",
  2695. }
  2696. `)
  2697. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2698. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2699. name := apexBundle.BaseModuleName()
  2700. prefix := "TARGET_"
  2701. var builder strings.Builder
  2702. data.Custom(&builder, name, prefix, "", data)
  2703. androidMk := builder.String()
  2704. ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
  2705. ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
  2706. }
  2707. func TestStaticLinking(t *testing.T) {
  2708. ctx := testApex(t, `
  2709. apex {
  2710. name: "myapex",
  2711. key: "myapex.key",
  2712. native_shared_libs: ["mylib"],
  2713. updatable: false,
  2714. }
  2715. apex_key {
  2716. name: "myapex.key",
  2717. public_key: "testkey.avbpubkey",
  2718. private_key: "testkey.pem",
  2719. }
  2720. cc_library {
  2721. name: "mylib",
  2722. srcs: ["mylib.cpp"],
  2723. system_shared_libs: [],
  2724. stl: "none",
  2725. stubs: {
  2726. versions: ["1", "2", "3"],
  2727. },
  2728. apex_available: [
  2729. "//apex_available:platform",
  2730. "myapex",
  2731. ],
  2732. }
  2733. cc_binary {
  2734. name: "not_in_apex",
  2735. srcs: ["mylib.cpp"],
  2736. static_libs: ["mylib"],
  2737. static_executable: true,
  2738. system_shared_libs: [],
  2739. stl: "none",
  2740. }
  2741. `)
  2742. ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  2743. // Ensure that not_in_apex is linking with the static variant of mylib
  2744. ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
  2745. }
  2746. func TestKeys(t *testing.T) {
  2747. ctx := testApex(t, `
  2748. apex {
  2749. name: "myapex_keytest",
  2750. key: "myapex.key",
  2751. certificate: ":myapex.certificate",
  2752. native_shared_libs: ["mylib"],
  2753. file_contexts: ":myapex-file_contexts",
  2754. updatable: false,
  2755. }
  2756. cc_library {
  2757. name: "mylib",
  2758. srcs: ["mylib.cpp"],
  2759. system_shared_libs: [],
  2760. stl: "none",
  2761. apex_available: [ "myapex_keytest" ],
  2762. }
  2763. apex_key {
  2764. name: "myapex.key",
  2765. public_key: "testkey.avbpubkey",
  2766. private_key: "testkey.pem",
  2767. }
  2768. android_app_certificate {
  2769. name: "myapex.certificate",
  2770. certificate: "testkey",
  2771. }
  2772. android_app_certificate {
  2773. name: "myapex.certificate.override",
  2774. certificate: "testkey.override",
  2775. }
  2776. `)
  2777. // check the APEX keys
  2778. keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  2779. if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
  2780. t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
  2781. "vendor/foo/devkeys/testkey.avbpubkey")
  2782. }
  2783. if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
  2784. t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
  2785. "vendor/foo/devkeys/testkey.pem")
  2786. }
  2787. // check the APK certs. It should be overridden to myapex.certificate.override
  2788. certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
  2789. if certs != "testkey.override.x509.pem testkey.override.pk8" {
  2790. t.Errorf("cert and private key %q are not %q", certs,
  2791. "testkey.override.509.pem testkey.override.pk8")
  2792. }
  2793. }
  2794. func TestCertificate(t *testing.T) {
  2795. t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
  2796. ctx := testApex(t, `
  2797. apex {
  2798. name: "myapex",
  2799. key: "myapex.key",
  2800. updatable: false,
  2801. }
  2802. apex_key {
  2803. name: "myapex.key",
  2804. public_key: "testkey.avbpubkey",
  2805. private_key: "testkey.pem",
  2806. }`)
  2807. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2808. expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
  2809. if actual := rule.Args["certificates"]; actual != expected {
  2810. t.Errorf("certificates should be %q, not %q", expected, actual)
  2811. }
  2812. })
  2813. t.Run("override when unspecified", func(t *testing.T) {
  2814. ctx := testApex(t, `
  2815. apex {
  2816. name: "myapex_keytest",
  2817. key: "myapex.key",
  2818. file_contexts: ":myapex-file_contexts",
  2819. updatable: false,
  2820. }
  2821. apex_key {
  2822. name: "myapex.key",
  2823. public_key: "testkey.avbpubkey",
  2824. private_key: "testkey.pem",
  2825. }
  2826. android_app_certificate {
  2827. name: "myapex.certificate.override",
  2828. certificate: "testkey.override",
  2829. }`)
  2830. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2831. expected := "testkey.override.x509.pem testkey.override.pk8"
  2832. if actual := rule.Args["certificates"]; actual != expected {
  2833. t.Errorf("certificates should be %q, not %q", expected, actual)
  2834. }
  2835. })
  2836. t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
  2837. ctx := testApex(t, `
  2838. apex {
  2839. name: "myapex",
  2840. key: "myapex.key",
  2841. certificate: ":myapex.certificate",
  2842. updatable: false,
  2843. }
  2844. apex_key {
  2845. name: "myapex.key",
  2846. public_key: "testkey.avbpubkey",
  2847. private_key: "testkey.pem",
  2848. }
  2849. android_app_certificate {
  2850. name: "myapex.certificate",
  2851. certificate: "testkey",
  2852. }`)
  2853. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2854. expected := "testkey.x509.pem testkey.pk8"
  2855. if actual := rule.Args["certificates"]; actual != expected {
  2856. t.Errorf("certificates should be %q, not %q", expected, actual)
  2857. }
  2858. })
  2859. t.Run("override when specifiec as <:module>", func(t *testing.T) {
  2860. ctx := testApex(t, `
  2861. apex {
  2862. name: "myapex_keytest",
  2863. key: "myapex.key",
  2864. file_contexts: ":myapex-file_contexts",
  2865. certificate: ":myapex.certificate",
  2866. updatable: false,
  2867. }
  2868. apex_key {
  2869. name: "myapex.key",
  2870. public_key: "testkey.avbpubkey",
  2871. private_key: "testkey.pem",
  2872. }
  2873. android_app_certificate {
  2874. name: "myapex.certificate.override",
  2875. certificate: "testkey.override",
  2876. }`)
  2877. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2878. expected := "testkey.override.x509.pem testkey.override.pk8"
  2879. if actual := rule.Args["certificates"]; actual != expected {
  2880. t.Errorf("certificates should be %q, not %q", expected, actual)
  2881. }
  2882. })
  2883. t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
  2884. ctx := testApex(t, `
  2885. apex {
  2886. name: "myapex",
  2887. key: "myapex.key",
  2888. certificate: "testkey",
  2889. updatable: false,
  2890. }
  2891. apex_key {
  2892. name: "myapex.key",
  2893. public_key: "testkey.avbpubkey",
  2894. private_key: "testkey.pem",
  2895. }`)
  2896. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2897. expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
  2898. if actual := rule.Args["certificates"]; actual != expected {
  2899. t.Errorf("certificates should be %q, not %q", expected, actual)
  2900. }
  2901. })
  2902. t.Run("override when specified as <name>", func(t *testing.T) {
  2903. ctx := testApex(t, `
  2904. apex {
  2905. name: "myapex_keytest",
  2906. key: "myapex.key",
  2907. file_contexts: ":myapex-file_contexts",
  2908. certificate: "testkey",
  2909. updatable: false,
  2910. }
  2911. apex_key {
  2912. name: "myapex.key",
  2913. public_key: "testkey.avbpubkey",
  2914. private_key: "testkey.pem",
  2915. }
  2916. android_app_certificate {
  2917. name: "myapex.certificate.override",
  2918. certificate: "testkey.override",
  2919. }`)
  2920. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2921. expected := "testkey.override.x509.pem testkey.override.pk8"
  2922. if actual := rule.Args["certificates"]; actual != expected {
  2923. t.Errorf("certificates should be %q, not %q", expected, actual)
  2924. }
  2925. })
  2926. }
  2927. func TestMacro(t *testing.T) {
  2928. ctx := testApex(t, `
  2929. apex {
  2930. name: "myapex",
  2931. key: "myapex.key",
  2932. native_shared_libs: ["mylib", "mylib2"],
  2933. updatable: false,
  2934. }
  2935. apex {
  2936. name: "otherapex",
  2937. key: "myapex.key",
  2938. native_shared_libs: ["mylib", "mylib2"],
  2939. min_sdk_version: "29",
  2940. }
  2941. apex_key {
  2942. name: "myapex.key",
  2943. public_key: "testkey.avbpubkey",
  2944. private_key: "testkey.pem",
  2945. }
  2946. cc_library {
  2947. name: "mylib",
  2948. srcs: ["mylib.cpp"],
  2949. system_shared_libs: [],
  2950. stl: "none",
  2951. apex_available: [
  2952. "myapex",
  2953. "otherapex",
  2954. ],
  2955. recovery_available: true,
  2956. min_sdk_version: "29",
  2957. }
  2958. cc_library {
  2959. name: "mylib2",
  2960. srcs: ["mylib.cpp"],
  2961. system_shared_libs: [],
  2962. stl: "none",
  2963. apex_available: [
  2964. "myapex",
  2965. "otherapex",
  2966. ],
  2967. static_libs: ["mylib3"],
  2968. recovery_available: true,
  2969. min_sdk_version: "29",
  2970. }
  2971. cc_library {
  2972. name: "mylib3",
  2973. srcs: ["mylib.cpp"],
  2974. system_shared_libs: [],
  2975. stl: "none",
  2976. apex_available: [
  2977. "myapex",
  2978. "otherapex",
  2979. ],
  2980. recovery_available: true,
  2981. min_sdk_version: "29",
  2982. }
  2983. `)
  2984. // non-APEX variant does not have __ANDROID_APEX__ defined
  2985. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2986. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2987. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2988. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2989. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  2990. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2991. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
  2992. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2993. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
  2994. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2995. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
  2996. // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
  2997. // each variant defines additional macros to distinguish which apex variant it is built for
  2998. // non-APEX variant does not have __ANDROID_APEX__ defined
  2999. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3000. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3001. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  3002. mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3003. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3004. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  3005. // non-APEX variant does not have __ANDROID_APEX__ defined
  3006. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3007. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3008. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  3009. mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3010. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  3011. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  3012. }
  3013. func TestHeaderLibsDependency(t *testing.T) {
  3014. ctx := testApex(t, `
  3015. apex {
  3016. name: "myapex",
  3017. key: "myapex.key",
  3018. native_shared_libs: ["mylib"],
  3019. updatable: false,
  3020. }
  3021. apex_key {
  3022. name: "myapex.key",
  3023. public_key: "testkey.avbpubkey",
  3024. private_key: "testkey.pem",
  3025. }
  3026. cc_library_headers {
  3027. name: "mylib_headers",
  3028. export_include_dirs: ["my_include"],
  3029. system_shared_libs: [],
  3030. stl: "none",
  3031. apex_available: [ "myapex" ],
  3032. }
  3033. cc_library {
  3034. name: "mylib",
  3035. srcs: ["mylib.cpp"],
  3036. system_shared_libs: [],
  3037. stl: "none",
  3038. header_libs: ["mylib_headers"],
  3039. export_header_lib_headers: ["mylib_headers"],
  3040. stubs: {
  3041. versions: ["1", "2", "3"],
  3042. },
  3043. apex_available: [ "myapex" ],
  3044. }
  3045. cc_library {
  3046. name: "otherlib",
  3047. srcs: ["mylib.cpp"],
  3048. system_shared_libs: [],
  3049. stl: "none",
  3050. shared_libs: ["mylib"],
  3051. }
  3052. `)
  3053. cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3054. // Ensure that the include path of the header lib is exported to 'otherlib'
  3055. ensureContains(t, cFlags, "-Imy_include")
  3056. }
  3057. type fileInApex struct {
  3058. path string // path in apex
  3059. src string // src path
  3060. isLink bool
  3061. }
  3062. func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
  3063. t.Helper()
  3064. apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
  3065. copyCmds := apexRule.Args["copy_commands"]
  3066. imageApexDir := "/image.apex/"
  3067. var ret []fileInApex
  3068. for _, cmd := range strings.Split(copyCmds, "&&") {
  3069. cmd = strings.TrimSpace(cmd)
  3070. if cmd == "" {
  3071. continue
  3072. }
  3073. terms := strings.Split(cmd, " ")
  3074. var dst, src string
  3075. var isLink bool
  3076. switch terms[0] {
  3077. case "mkdir":
  3078. case "cp":
  3079. if len(terms) != 3 && len(terms) != 4 {
  3080. t.Fatal("copyCmds contains invalid cp command", cmd)
  3081. }
  3082. dst = terms[len(terms)-1]
  3083. src = terms[len(terms)-2]
  3084. isLink = false
  3085. case "ln":
  3086. if len(terms) != 3 && len(terms) != 4 {
  3087. // ln LINK TARGET or ln -s LINK TARGET
  3088. t.Fatal("copyCmds contains invalid ln command", cmd)
  3089. }
  3090. dst = terms[len(terms)-1]
  3091. src = terms[len(terms)-2]
  3092. isLink = true
  3093. default:
  3094. t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
  3095. }
  3096. if dst != "" {
  3097. index := strings.Index(dst, imageApexDir)
  3098. if index == -1 {
  3099. t.Fatal("copyCmds should copy a file to image.apex/", cmd)
  3100. }
  3101. dstFile := dst[index+len(imageApexDir):]
  3102. ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
  3103. }
  3104. }
  3105. return ret
  3106. }
  3107. func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
  3108. t.Helper()
  3109. var failed bool
  3110. var surplus []string
  3111. filesMatched := make(map[string]bool)
  3112. for _, file := range getFiles(t, ctx, moduleName, variant) {
  3113. mactchFound := false
  3114. for _, expected := range files {
  3115. if matched, _ := path.Match(expected, file.path); matched {
  3116. filesMatched[expected] = true
  3117. mactchFound = true
  3118. break
  3119. }
  3120. }
  3121. if !mactchFound {
  3122. surplus = append(surplus, file.path)
  3123. }
  3124. }
  3125. if len(surplus) > 0 {
  3126. sort.Strings(surplus)
  3127. t.Log("surplus files", surplus)
  3128. failed = true
  3129. }
  3130. if len(files) > len(filesMatched) {
  3131. var missing []string
  3132. for _, expected := range files {
  3133. if !filesMatched[expected] {
  3134. missing = append(missing, expected)
  3135. }
  3136. }
  3137. sort.Strings(missing)
  3138. t.Log("missing files", missing)
  3139. failed = true
  3140. }
  3141. if failed {
  3142. t.Fail()
  3143. }
  3144. }
  3145. func TestVndkApexCurrent(t *testing.T) {
  3146. commonFiles := []string{
  3147. "lib/libc++.so",
  3148. "lib64/libc++.so",
  3149. "etc/llndk.libraries.29.txt",
  3150. "etc/vndkcore.libraries.29.txt",
  3151. "etc/vndksp.libraries.29.txt",
  3152. "etc/vndkprivate.libraries.29.txt",
  3153. "etc/vndkproduct.libraries.29.txt",
  3154. }
  3155. testCases := []struct {
  3156. vndkVersion string
  3157. expectedFiles []string
  3158. }{
  3159. {
  3160. vndkVersion: "current",
  3161. expectedFiles: append(commonFiles,
  3162. "lib/libvndk.so",
  3163. "lib/libvndksp.so",
  3164. "lib64/libvndk.so",
  3165. "lib64/libvndksp.so"),
  3166. },
  3167. {
  3168. vndkVersion: "",
  3169. expectedFiles: append(commonFiles,
  3170. // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
  3171. "lib/libvndksp.so",
  3172. "lib64/libvndksp.so"),
  3173. },
  3174. }
  3175. for _, tc := range testCases {
  3176. t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
  3177. ctx := testApex(t, `
  3178. apex_vndk {
  3179. name: "com.android.vndk.current",
  3180. key: "com.android.vndk.current.key",
  3181. updatable: false,
  3182. }
  3183. apex_key {
  3184. name: "com.android.vndk.current.key",
  3185. public_key: "testkey.avbpubkey",
  3186. private_key: "testkey.pem",
  3187. }
  3188. cc_library {
  3189. name: "libvndk",
  3190. srcs: ["mylib.cpp"],
  3191. vendor_available: true,
  3192. product_available: true,
  3193. vndk: {
  3194. enabled: true,
  3195. },
  3196. system_shared_libs: [],
  3197. stl: "none",
  3198. apex_available: [ "com.android.vndk.current" ],
  3199. }
  3200. cc_library {
  3201. name: "libvndksp",
  3202. srcs: ["mylib.cpp"],
  3203. vendor_available: true,
  3204. product_available: true,
  3205. vndk: {
  3206. enabled: true,
  3207. support_system_process: true,
  3208. },
  3209. system_shared_libs: [],
  3210. stl: "none",
  3211. apex_available: [ "com.android.vndk.current" ],
  3212. }
  3213. // VNDK-Ext should not cause any problems
  3214. cc_library {
  3215. name: "libvndk.ext",
  3216. srcs: ["mylib2.cpp"],
  3217. vendor: true,
  3218. vndk: {
  3219. enabled: true,
  3220. extends: "libvndk",
  3221. },
  3222. system_shared_libs: [],
  3223. stl: "none",
  3224. }
  3225. cc_library {
  3226. name: "libvndksp.ext",
  3227. srcs: ["mylib2.cpp"],
  3228. vendor: true,
  3229. vndk: {
  3230. enabled: true,
  3231. support_system_process: true,
  3232. extends: "libvndksp",
  3233. },
  3234. system_shared_libs: [],
  3235. stl: "none",
  3236. }
  3237. `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3238. variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
  3239. }))
  3240. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
  3241. })
  3242. }
  3243. }
  3244. func TestVndkApexWithPrebuilt(t *testing.T) {
  3245. ctx := testApex(t, `
  3246. apex_vndk {
  3247. name: "com.android.vndk.current",
  3248. key: "com.android.vndk.current.key",
  3249. updatable: false,
  3250. }
  3251. apex_key {
  3252. name: "com.android.vndk.current.key",
  3253. public_key: "testkey.avbpubkey",
  3254. private_key: "testkey.pem",
  3255. }
  3256. cc_prebuilt_library_shared {
  3257. name: "libvndk",
  3258. srcs: ["libvndk.so"],
  3259. vendor_available: true,
  3260. product_available: true,
  3261. vndk: {
  3262. enabled: true,
  3263. },
  3264. system_shared_libs: [],
  3265. stl: "none",
  3266. apex_available: [ "com.android.vndk.current" ],
  3267. }
  3268. cc_prebuilt_library_shared {
  3269. name: "libvndk.arm",
  3270. srcs: ["libvndk.arm.so"],
  3271. vendor_available: true,
  3272. product_available: true,
  3273. vndk: {
  3274. enabled: true,
  3275. },
  3276. enabled: false,
  3277. arch: {
  3278. arm: {
  3279. enabled: true,
  3280. },
  3281. },
  3282. system_shared_libs: [],
  3283. stl: "none",
  3284. apex_available: [ "com.android.vndk.current" ],
  3285. }
  3286. `+vndkLibrariesTxtFiles("current"),
  3287. withFiles(map[string][]byte{
  3288. "libvndk.so": nil,
  3289. "libvndk.arm.so": nil,
  3290. }))
  3291. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3292. "lib/libvndk.so",
  3293. "lib/libvndk.arm.so",
  3294. "lib64/libvndk.so",
  3295. "lib/libc++.so",
  3296. "lib64/libc++.so",
  3297. "etc/*",
  3298. })
  3299. }
  3300. func vndkLibrariesTxtFiles(vers ...string) (result string) {
  3301. for _, v := range vers {
  3302. if v == "current" {
  3303. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3304. result += `
  3305. ` + txt + `_libraries_txt {
  3306. name: "` + txt + `.libraries.txt",
  3307. }
  3308. `
  3309. }
  3310. } else {
  3311. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3312. result += `
  3313. prebuilt_etc {
  3314. name: "` + txt + `.libraries.` + v + `.txt",
  3315. src: "dummy.txt",
  3316. }
  3317. `
  3318. }
  3319. }
  3320. }
  3321. return
  3322. }
  3323. func TestVndkApexVersion(t *testing.T) {
  3324. ctx := testApex(t, `
  3325. apex_vndk {
  3326. name: "com.android.vndk.v27",
  3327. key: "myapex.key",
  3328. file_contexts: ":myapex-file_contexts",
  3329. vndk_version: "27",
  3330. updatable: false,
  3331. }
  3332. apex_key {
  3333. name: "myapex.key",
  3334. public_key: "testkey.avbpubkey",
  3335. private_key: "testkey.pem",
  3336. }
  3337. vndk_prebuilt_shared {
  3338. name: "libvndk27",
  3339. version: "27",
  3340. vendor_available: true,
  3341. product_available: true,
  3342. vndk: {
  3343. enabled: true,
  3344. },
  3345. target_arch: "arm64",
  3346. arch: {
  3347. arm: {
  3348. srcs: ["libvndk27_arm.so"],
  3349. },
  3350. arm64: {
  3351. srcs: ["libvndk27_arm64.so"],
  3352. },
  3353. },
  3354. apex_available: [ "com.android.vndk.v27" ],
  3355. }
  3356. vndk_prebuilt_shared {
  3357. name: "libvndk27",
  3358. version: "27",
  3359. vendor_available: true,
  3360. product_available: true,
  3361. vndk: {
  3362. enabled: true,
  3363. },
  3364. target_arch: "x86_64",
  3365. arch: {
  3366. x86: {
  3367. srcs: ["libvndk27_x86.so"],
  3368. },
  3369. x86_64: {
  3370. srcs: ["libvndk27_x86_64.so"],
  3371. },
  3372. },
  3373. }
  3374. `+vndkLibrariesTxtFiles("27"),
  3375. withFiles(map[string][]byte{
  3376. "libvndk27_arm.so": nil,
  3377. "libvndk27_arm64.so": nil,
  3378. "libvndk27_x86.so": nil,
  3379. "libvndk27_x86_64.so": nil,
  3380. }))
  3381. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3382. "lib/libvndk27_arm.so",
  3383. "lib64/libvndk27_arm64.so",
  3384. "etc/*",
  3385. })
  3386. }
  3387. func TestVndkApexNameRule(t *testing.T) {
  3388. ctx := testApex(t, `
  3389. apex_vndk {
  3390. name: "com.android.vndk.current",
  3391. key: "myapex.key",
  3392. file_contexts: ":myapex-file_contexts",
  3393. updatable: false,
  3394. }
  3395. apex_vndk {
  3396. name: "com.android.vndk.v28",
  3397. key: "myapex.key",
  3398. file_contexts: ":myapex-file_contexts",
  3399. vndk_version: "28",
  3400. updatable: false,
  3401. }
  3402. apex_key {
  3403. name: "myapex.key",
  3404. public_key: "testkey.avbpubkey",
  3405. private_key: "testkey.pem",
  3406. }`+vndkLibrariesTxtFiles("28", "current"))
  3407. assertApexName := func(expected, moduleName string) {
  3408. bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
  3409. actual := proptools.String(bundle.properties.Apex_name)
  3410. if !reflect.DeepEqual(actual, expected) {
  3411. t.Errorf("Got '%v', expected '%v'", actual, expected)
  3412. }
  3413. }
  3414. assertApexName("com.android.vndk.v29", "com.android.vndk.current")
  3415. assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
  3416. }
  3417. func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
  3418. ctx := testApex(t, `
  3419. apex_vndk {
  3420. name: "com.android.vndk.current",
  3421. key: "com.android.vndk.current.key",
  3422. file_contexts: ":myapex-file_contexts",
  3423. updatable: false,
  3424. }
  3425. apex_key {
  3426. name: "com.android.vndk.current.key",
  3427. public_key: "testkey.avbpubkey",
  3428. private_key: "testkey.pem",
  3429. }
  3430. cc_library {
  3431. name: "libvndk",
  3432. srcs: ["mylib.cpp"],
  3433. vendor_available: true,
  3434. product_available: true,
  3435. native_bridge_supported: true,
  3436. host_supported: true,
  3437. vndk: {
  3438. enabled: true,
  3439. },
  3440. system_shared_libs: [],
  3441. stl: "none",
  3442. apex_available: [ "com.android.vndk.current" ],
  3443. }
  3444. `+vndkLibrariesTxtFiles("current"),
  3445. withNativeBridgeEnabled)
  3446. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3447. "lib/libvndk.so",
  3448. "lib64/libvndk.so",
  3449. "lib/libc++.so",
  3450. "lib64/libc++.so",
  3451. "etc/*",
  3452. })
  3453. }
  3454. func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
  3455. testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
  3456. apex_vndk {
  3457. name: "com.android.vndk.current",
  3458. key: "com.android.vndk.current.key",
  3459. file_contexts: ":myapex-file_contexts",
  3460. native_bridge_supported: true,
  3461. }
  3462. apex_key {
  3463. name: "com.android.vndk.current.key",
  3464. public_key: "testkey.avbpubkey",
  3465. private_key: "testkey.pem",
  3466. }
  3467. cc_library {
  3468. name: "libvndk",
  3469. srcs: ["mylib.cpp"],
  3470. vendor_available: true,
  3471. product_available: true,
  3472. native_bridge_supported: true,
  3473. host_supported: true,
  3474. vndk: {
  3475. enabled: true,
  3476. },
  3477. system_shared_libs: [],
  3478. stl: "none",
  3479. }
  3480. `)
  3481. }
  3482. func TestVndkApexWithBinder32(t *testing.T) {
  3483. ctx := testApex(t, `
  3484. apex_vndk {
  3485. name: "com.android.vndk.v27",
  3486. key: "myapex.key",
  3487. file_contexts: ":myapex-file_contexts",
  3488. vndk_version: "27",
  3489. updatable: false,
  3490. }
  3491. apex_key {
  3492. name: "myapex.key",
  3493. public_key: "testkey.avbpubkey",
  3494. private_key: "testkey.pem",
  3495. }
  3496. vndk_prebuilt_shared {
  3497. name: "libvndk27",
  3498. version: "27",
  3499. target_arch: "arm",
  3500. vendor_available: true,
  3501. product_available: true,
  3502. vndk: {
  3503. enabled: true,
  3504. },
  3505. arch: {
  3506. arm: {
  3507. srcs: ["libvndk27.so"],
  3508. }
  3509. },
  3510. }
  3511. vndk_prebuilt_shared {
  3512. name: "libvndk27",
  3513. version: "27",
  3514. target_arch: "arm",
  3515. binder32bit: true,
  3516. vendor_available: true,
  3517. product_available: true,
  3518. vndk: {
  3519. enabled: true,
  3520. },
  3521. arch: {
  3522. arm: {
  3523. srcs: ["libvndk27binder32.so"],
  3524. }
  3525. },
  3526. apex_available: [ "com.android.vndk.v27" ],
  3527. }
  3528. `+vndkLibrariesTxtFiles("27"),
  3529. withFiles(map[string][]byte{
  3530. "libvndk27.so": nil,
  3531. "libvndk27binder32.so": nil,
  3532. }),
  3533. withBinder32bit,
  3534. withTargets(map[android.OsType][]android.Target{
  3535. android.Android: {
  3536. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  3537. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  3538. },
  3539. }),
  3540. )
  3541. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3542. "lib/libvndk27binder32.so",
  3543. "etc/*",
  3544. })
  3545. }
  3546. func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
  3547. ctx := testApex(t, `
  3548. apex_vndk {
  3549. name: "com.android.vndk.current",
  3550. key: "com.android.vndk.current.key",
  3551. file_contexts: ":myapex-file_contexts",
  3552. updatable: false,
  3553. }
  3554. apex_key {
  3555. name: "com.android.vndk.current.key",
  3556. public_key: "testkey.avbpubkey",
  3557. private_key: "testkey.pem",
  3558. }
  3559. cc_library {
  3560. name: "libz",
  3561. vendor_available: true,
  3562. product_available: true,
  3563. vndk: {
  3564. enabled: true,
  3565. },
  3566. stubs: {
  3567. symbol_file: "libz.map.txt",
  3568. versions: ["30"],
  3569. }
  3570. }
  3571. `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
  3572. "libz.map.txt": nil,
  3573. }))
  3574. apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
  3575. provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
  3576. ensureListEmpty(t, provideNativeLibs)
  3577. }
  3578. func TestDependenciesInApexManifest(t *testing.T) {
  3579. ctx := testApex(t, `
  3580. apex {
  3581. name: "myapex_nodep",
  3582. key: "myapex.key",
  3583. native_shared_libs: ["lib_nodep"],
  3584. compile_multilib: "both",
  3585. file_contexts: ":myapex-file_contexts",
  3586. updatable: false,
  3587. }
  3588. apex {
  3589. name: "myapex_dep",
  3590. key: "myapex.key",
  3591. native_shared_libs: ["lib_dep"],
  3592. compile_multilib: "both",
  3593. file_contexts: ":myapex-file_contexts",
  3594. updatable: false,
  3595. }
  3596. apex {
  3597. name: "myapex_provider",
  3598. key: "myapex.key",
  3599. native_shared_libs: ["libfoo"],
  3600. compile_multilib: "both",
  3601. file_contexts: ":myapex-file_contexts",
  3602. updatable: false,
  3603. }
  3604. apex {
  3605. name: "myapex_selfcontained",
  3606. key: "myapex.key",
  3607. native_shared_libs: ["lib_dep", "libfoo"],
  3608. compile_multilib: "both",
  3609. file_contexts: ":myapex-file_contexts",
  3610. updatable: false,
  3611. }
  3612. apex_key {
  3613. name: "myapex.key",
  3614. public_key: "testkey.avbpubkey",
  3615. private_key: "testkey.pem",
  3616. }
  3617. cc_library {
  3618. name: "lib_nodep",
  3619. srcs: ["mylib.cpp"],
  3620. system_shared_libs: [],
  3621. stl: "none",
  3622. apex_available: [ "myapex_nodep" ],
  3623. }
  3624. cc_library {
  3625. name: "lib_dep",
  3626. srcs: ["mylib.cpp"],
  3627. shared_libs: ["libfoo"],
  3628. system_shared_libs: [],
  3629. stl: "none",
  3630. apex_available: [
  3631. "myapex_dep",
  3632. "myapex_provider",
  3633. "myapex_selfcontained",
  3634. ],
  3635. }
  3636. cc_library {
  3637. name: "libfoo",
  3638. srcs: ["mytest.cpp"],
  3639. stubs: {
  3640. versions: ["1"],
  3641. },
  3642. system_shared_libs: [],
  3643. stl: "none",
  3644. apex_available: [
  3645. "myapex_provider",
  3646. "myapex_selfcontained",
  3647. ],
  3648. }
  3649. `)
  3650. var apexManifestRule android.TestingBuildParams
  3651. var provideNativeLibs, requireNativeLibs []string
  3652. apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
  3653. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3654. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3655. ensureListEmpty(t, provideNativeLibs)
  3656. ensureListEmpty(t, requireNativeLibs)
  3657. apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
  3658. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3659. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3660. ensureListEmpty(t, provideNativeLibs)
  3661. ensureListContains(t, requireNativeLibs, "libfoo.so")
  3662. apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
  3663. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3664. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3665. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3666. ensureListEmpty(t, requireNativeLibs)
  3667. apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
  3668. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3669. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3670. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3671. ensureListEmpty(t, requireNativeLibs)
  3672. }
  3673. func TestApexName(t *testing.T) {
  3674. ctx := testApex(t, `
  3675. apex {
  3676. name: "myapex",
  3677. key: "myapex.key",
  3678. apex_name: "com.android.myapex",
  3679. native_shared_libs: ["mylib"],
  3680. updatable: false,
  3681. }
  3682. apex_key {
  3683. name: "myapex.key",
  3684. public_key: "testkey.avbpubkey",
  3685. private_key: "testkey.pem",
  3686. }
  3687. cc_library {
  3688. name: "mylib",
  3689. srcs: ["mylib.cpp"],
  3690. system_shared_libs: [],
  3691. stl: "none",
  3692. apex_available: [
  3693. "//apex_available:platform",
  3694. "myapex",
  3695. ],
  3696. }
  3697. `)
  3698. module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image")
  3699. apexManifestRule := module.Rule("apexManifestRule")
  3700. ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
  3701. apexRule := module.Rule("apexRule")
  3702. ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
  3703. apexBundle := module.Module().(*apexBundle)
  3704. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  3705. name := apexBundle.BaseModuleName()
  3706. prefix := "TARGET_"
  3707. var builder strings.Builder
  3708. data.Custom(&builder, name, prefix, "", data)
  3709. androidMk := builder.String()
  3710. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  3711. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  3712. }
  3713. func TestOverrideApexManifestDefaultVersion(t *testing.T) {
  3714. ctx := testApex(t, `
  3715. apex {
  3716. name: "myapex",
  3717. key: "myapex.key",
  3718. apex_name: "com.android.myapex",
  3719. native_shared_libs: ["mylib"],
  3720. updatable: false,
  3721. }
  3722. apex_key {
  3723. name: "myapex.key",
  3724. public_key: "testkey.avbpubkey",
  3725. private_key: "testkey.pem",
  3726. }
  3727. cc_library {
  3728. name: "mylib",
  3729. srcs: ["mylib.cpp"],
  3730. system_shared_libs: [],
  3731. stl: "none",
  3732. apex_available: [
  3733. "//apex_available:platform",
  3734. "myapex",
  3735. ],
  3736. }
  3737. `, android.FixtureMergeEnv(map[string]string{
  3738. "OVERRIDE_APEX_MANIFEST_DEFAULT_VERSION": "1234",
  3739. }))
  3740. module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image")
  3741. apexManifestRule := module.Rule("apexManifestRule")
  3742. ensureContains(t, apexManifestRule.Args["default_version"], "1234")
  3743. }
  3744. func TestCompileMultilibProp(t *testing.T) {
  3745. testCases := []struct {
  3746. compileMultiLibProp string
  3747. containedLibs []string
  3748. notContainedLibs []string
  3749. }{
  3750. {
  3751. containedLibs: []string{
  3752. "image.apex/lib64/mylib.so",
  3753. "image.apex/lib/mylib.so",
  3754. },
  3755. compileMultiLibProp: `compile_multilib: "both",`,
  3756. },
  3757. {
  3758. containedLibs: []string{"image.apex/lib64/mylib.so"},
  3759. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  3760. compileMultiLibProp: `compile_multilib: "first",`,
  3761. },
  3762. {
  3763. containedLibs: []string{"image.apex/lib64/mylib.so"},
  3764. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  3765. // compile_multilib, when unset, should result to the same output as when compile_multilib is "first"
  3766. },
  3767. {
  3768. containedLibs: []string{"image.apex/lib64/mylib.so"},
  3769. notContainedLibs: []string{"image.apex/lib/mylib.so"},
  3770. compileMultiLibProp: `compile_multilib: "64",`,
  3771. },
  3772. {
  3773. containedLibs: []string{"image.apex/lib/mylib.so"},
  3774. notContainedLibs: []string{"image.apex/lib64/mylib.so"},
  3775. compileMultiLibProp: `compile_multilib: "32",`,
  3776. },
  3777. }
  3778. for _, testCase := range testCases {
  3779. ctx := testApex(t, fmt.Sprintf(`
  3780. apex {
  3781. name: "myapex",
  3782. key: "myapex.key",
  3783. %s
  3784. native_shared_libs: ["mylib"],
  3785. updatable: false,
  3786. }
  3787. apex_key {
  3788. name: "myapex.key",
  3789. public_key: "testkey.avbpubkey",
  3790. private_key: "testkey.pem",
  3791. }
  3792. cc_library {
  3793. name: "mylib",
  3794. srcs: ["mylib.cpp"],
  3795. apex_available: [
  3796. "//apex_available:platform",
  3797. "myapex",
  3798. ],
  3799. }
  3800. `, testCase.compileMultiLibProp),
  3801. )
  3802. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3803. apexRule := module.Rule("apexRule")
  3804. copyCmds := apexRule.Args["copy_commands"]
  3805. for _, containedLib := range testCase.containedLibs {
  3806. ensureContains(t, copyCmds, containedLib)
  3807. }
  3808. for _, notContainedLib := range testCase.notContainedLibs {
  3809. ensureNotContains(t, copyCmds, notContainedLib)
  3810. }
  3811. }
  3812. }
  3813. func TestNonTestApex(t *testing.T) {
  3814. ctx := testApex(t, `
  3815. apex {
  3816. name: "myapex",
  3817. key: "myapex.key",
  3818. native_shared_libs: ["mylib_common"],
  3819. updatable: false,
  3820. }
  3821. apex_key {
  3822. name: "myapex.key",
  3823. public_key: "testkey.avbpubkey",
  3824. private_key: "testkey.pem",
  3825. }
  3826. cc_library {
  3827. name: "mylib_common",
  3828. srcs: ["mylib.cpp"],
  3829. system_shared_libs: [],
  3830. stl: "none",
  3831. apex_available: [
  3832. "//apex_available:platform",
  3833. "myapex",
  3834. ],
  3835. }
  3836. `)
  3837. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3838. apexRule := module.Rule("apexRule")
  3839. copyCmds := apexRule.Args["copy_commands"]
  3840. if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
  3841. t.Log("Apex was a test apex!")
  3842. t.Fail()
  3843. }
  3844. // Ensure that main rule creates an output
  3845. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3846. // Ensure that apex variant is created for the direct dep
  3847. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3848. // Ensure that both direct and indirect deps are copied into apex
  3849. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3850. // Ensure that the platform variant ends with _shared
  3851. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3852. if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
  3853. t.Log("Found mylib_common not in any apex!")
  3854. t.Fail()
  3855. }
  3856. }
  3857. func TestTestApex(t *testing.T) {
  3858. ctx := testApex(t, `
  3859. apex_test {
  3860. name: "myapex",
  3861. key: "myapex.key",
  3862. native_shared_libs: ["mylib_common_test"],
  3863. updatable: false,
  3864. }
  3865. apex_key {
  3866. name: "myapex.key",
  3867. public_key: "testkey.avbpubkey",
  3868. private_key: "testkey.pem",
  3869. }
  3870. cc_library {
  3871. name: "mylib_common_test",
  3872. srcs: ["mylib.cpp"],
  3873. system_shared_libs: [],
  3874. stl: "none",
  3875. // TODO: remove //apex_available:platform
  3876. apex_available: [
  3877. "//apex_available:platform",
  3878. "myapex",
  3879. ],
  3880. }
  3881. `)
  3882. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3883. apexRule := module.Rule("apexRule")
  3884. copyCmds := apexRule.Args["copy_commands"]
  3885. if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
  3886. t.Log("Apex was not a test apex!")
  3887. t.Fail()
  3888. }
  3889. // Ensure that main rule creates an output
  3890. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3891. // Ensure that apex variant is created for the direct dep
  3892. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
  3893. // Ensure that both direct and indirect deps are copied into apex
  3894. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
  3895. // Ensure that the platform variant ends with _shared
  3896. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
  3897. }
  3898. func TestApexWithTarget(t *testing.T) {
  3899. ctx := testApex(t, `
  3900. apex {
  3901. name: "myapex",
  3902. key: "myapex.key",
  3903. updatable: false,
  3904. multilib: {
  3905. first: {
  3906. native_shared_libs: ["mylib_common"],
  3907. }
  3908. },
  3909. target: {
  3910. android: {
  3911. multilib: {
  3912. first: {
  3913. native_shared_libs: ["mylib"],
  3914. }
  3915. }
  3916. },
  3917. host: {
  3918. multilib: {
  3919. first: {
  3920. native_shared_libs: ["mylib2"],
  3921. }
  3922. }
  3923. }
  3924. }
  3925. }
  3926. apex_key {
  3927. name: "myapex.key",
  3928. public_key: "testkey.avbpubkey",
  3929. private_key: "testkey.pem",
  3930. }
  3931. cc_library {
  3932. name: "mylib",
  3933. srcs: ["mylib.cpp"],
  3934. system_shared_libs: [],
  3935. stl: "none",
  3936. // TODO: remove //apex_available:platform
  3937. apex_available: [
  3938. "//apex_available:platform",
  3939. "myapex",
  3940. ],
  3941. }
  3942. cc_library {
  3943. name: "mylib_common",
  3944. srcs: ["mylib.cpp"],
  3945. system_shared_libs: [],
  3946. stl: "none",
  3947. compile_multilib: "first",
  3948. // TODO: remove //apex_available:platform
  3949. apex_available: [
  3950. "//apex_available:platform",
  3951. "myapex",
  3952. ],
  3953. }
  3954. cc_library {
  3955. name: "mylib2",
  3956. srcs: ["mylib.cpp"],
  3957. system_shared_libs: [],
  3958. stl: "none",
  3959. compile_multilib: "first",
  3960. }
  3961. `)
  3962. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3963. copyCmds := apexRule.Args["copy_commands"]
  3964. // Ensure that main rule creates an output
  3965. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3966. // Ensure that apex variant is created for the direct dep
  3967. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  3968. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3969. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  3970. // Ensure that both direct and indirect deps are copied into apex
  3971. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  3972. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3973. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  3974. // Ensure that the platform variant ends with _shared
  3975. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  3976. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3977. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  3978. }
  3979. func TestApexWithArch(t *testing.T) {
  3980. ctx := testApex(t, `
  3981. apex {
  3982. name: "myapex",
  3983. key: "myapex.key",
  3984. updatable: false,
  3985. native_shared_libs: ["mylib.generic"],
  3986. arch: {
  3987. arm64: {
  3988. native_shared_libs: ["mylib.arm64"],
  3989. exclude_native_shared_libs: ["mylib.generic"],
  3990. },
  3991. x86_64: {
  3992. native_shared_libs: ["mylib.x64"],
  3993. exclude_native_shared_libs: ["mylib.generic"],
  3994. },
  3995. }
  3996. }
  3997. apex_key {
  3998. name: "myapex.key",
  3999. public_key: "testkey.avbpubkey",
  4000. private_key: "testkey.pem",
  4001. }
  4002. cc_library {
  4003. name: "mylib.generic",
  4004. srcs: ["mylib.cpp"],
  4005. system_shared_libs: [],
  4006. stl: "none",
  4007. // TODO: remove //apex_available:platform
  4008. apex_available: [
  4009. "//apex_available:platform",
  4010. "myapex",
  4011. ],
  4012. }
  4013. cc_library {
  4014. name: "mylib.arm64",
  4015. srcs: ["mylib.cpp"],
  4016. system_shared_libs: [],
  4017. stl: "none",
  4018. // TODO: remove //apex_available:platform
  4019. apex_available: [
  4020. "//apex_available:platform",
  4021. "myapex",
  4022. ],
  4023. }
  4024. cc_library {
  4025. name: "mylib.x64",
  4026. srcs: ["mylib.cpp"],
  4027. system_shared_libs: [],
  4028. stl: "none",
  4029. // TODO: remove //apex_available:platform
  4030. apex_available: [
  4031. "//apex_available:platform",
  4032. "myapex",
  4033. ],
  4034. }
  4035. `)
  4036. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4037. copyCmds := apexRule.Args["copy_commands"]
  4038. // Ensure that apex variant is created for the direct dep
  4039. ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
  4040. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.generic"), "android_arm64_armv8-a_shared_apex10000")
  4041. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
  4042. // Ensure that both direct and indirect deps are copied into apex
  4043. ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
  4044. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
  4045. }
  4046. func TestApexWithShBinary(t *testing.T) {
  4047. ctx := testApex(t, `
  4048. apex {
  4049. name: "myapex",
  4050. key: "myapex.key",
  4051. sh_binaries: ["myscript"],
  4052. updatable: false,
  4053. }
  4054. apex_key {
  4055. name: "myapex.key",
  4056. public_key: "testkey.avbpubkey",
  4057. private_key: "testkey.pem",
  4058. }
  4059. sh_binary {
  4060. name: "myscript",
  4061. src: "mylib.cpp",
  4062. filename: "myscript.sh",
  4063. sub_dir: "script",
  4064. }
  4065. `)
  4066. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4067. copyCmds := apexRule.Args["copy_commands"]
  4068. ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
  4069. }
  4070. func TestApexInVariousPartition(t *testing.T) {
  4071. testcases := []struct {
  4072. propName, parition, flattenedPartition string
  4073. }{
  4074. {"", "system", "system_ext"},
  4075. {"product_specific: true", "product", "product"},
  4076. {"soc_specific: true", "vendor", "vendor"},
  4077. {"proprietary: true", "vendor", "vendor"},
  4078. {"vendor: true", "vendor", "vendor"},
  4079. {"system_ext_specific: true", "system_ext", "system_ext"},
  4080. }
  4081. for _, tc := range testcases {
  4082. t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
  4083. ctx := testApex(t, `
  4084. apex {
  4085. name: "myapex",
  4086. key: "myapex.key",
  4087. updatable: false,
  4088. `+tc.propName+`
  4089. }
  4090. apex_key {
  4091. name: "myapex.key",
  4092. public_key: "testkey.avbpubkey",
  4093. private_key: "testkey.pem",
  4094. }
  4095. `)
  4096. apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4097. expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
  4098. actual := apex.installDir.RelativeToTop().String()
  4099. if actual != expected {
  4100. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  4101. }
  4102. flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  4103. expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
  4104. actual = flattened.installDir.RelativeToTop().String()
  4105. if actual != expected {
  4106. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  4107. }
  4108. })
  4109. }
  4110. }
  4111. func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
  4112. ctx := testApex(t, `
  4113. apex {
  4114. name: "myapex",
  4115. key: "myapex.key",
  4116. updatable: false,
  4117. }
  4118. apex_key {
  4119. name: "myapex.key",
  4120. public_key: "testkey.avbpubkey",
  4121. private_key: "testkey.pem",
  4122. }
  4123. `)
  4124. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4125. rule := module.Output("file_contexts")
  4126. ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
  4127. }
  4128. func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
  4129. testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
  4130. apex {
  4131. name: "myapex",
  4132. key: "myapex.key",
  4133. file_contexts: "my_own_file_contexts",
  4134. updatable: false,
  4135. }
  4136. apex_key {
  4137. name: "myapex.key",
  4138. public_key: "testkey.avbpubkey",
  4139. private_key: "testkey.pem",
  4140. }
  4141. `, withFiles(map[string][]byte{
  4142. "my_own_file_contexts": nil,
  4143. }))
  4144. }
  4145. func TestFileContexts_ProductSpecificApexes(t *testing.T) {
  4146. testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
  4147. apex {
  4148. name: "myapex",
  4149. key: "myapex.key",
  4150. product_specific: true,
  4151. file_contexts: "product_specific_file_contexts",
  4152. updatable: false,
  4153. }
  4154. apex_key {
  4155. name: "myapex.key",
  4156. public_key: "testkey.avbpubkey",
  4157. private_key: "testkey.pem",
  4158. }
  4159. `)
  4160. ctx := testApex(t, `
  4161. apex {
  4162. name: "myapex",
  4163. key: "myapex.key",
  4164. product_specific: true,
  4165. file_contexts: "product_specific_file_contexts",
  4166. updatable: false,
  4167. }
  4168. apex_key {
  4169. name: "myapex.key",
  4170. public_key: "testkey.avbpubkey",
  4171. private_key: "testkey.pem",
  4172. }
  4173. `, withFiles(map[string][]byte{
  4174. "product_specific_file_contexts": nil,
  4175. }))
  4176. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4177. rule := module.Output("file_contexts")
  4178. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4179. }
  4180. func TestFileContexts_SetViaFileGroup(t *testing.T) {
  4181. ctx := testApex(t, `
  4182. apex {
  4183. name: "myapex",
  4184. key: "myapex.key",
  4185. product_specific: true,
  4186. file_contexts: ":my-file-contexts",
  4187. updatable: false,
  4188. }
  4189. apex_key {
  4190. name: "myapex.key",
  4191. public_key: "testkey.avbpubkey",
  4192. private_key: "testkey.pem",
  4193. }
  4194. filegroup {
  4195. name: "my-file-contexts",
  4196. srcs: ["product_specific_file_contexts"],
  4197. }
  4198. `, withFiles(map[string][]byte{
  4199. "product_specific_file_contexts": nil,
  4200. }))
  4201. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4202. rule := module.Output("file_contexts")
  4203. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4204. }
  4205. func TestApexKeyFromOtherModule(t *testing.T) {
  4206. ctx := testApex(t, `
  4207. apex_key {
  4208. name: "myapex.key",
  4209. public_key: ":my.avbpubkey",
  4210. private_key: ":my.pem",
  4211. product_specific: true,
  4212. }
  4213. filegroup {
  4214. name: "my.avbpubkey",
  4215. srcs: ["testkey2.avbpubkey"],
  4216. }
  4217. filegroup {
  4218. name: "my.pem",
  4219. srcs: ["testkey2.pem"],
  4220. }
  4221. `)
  4222. apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  4223. expected_pubkey := "testkey2.avbpubkey"
  4224. actual_pubkey := apex_key.publicKeyFile.String()
  4225. if actual_pubkey != expected_pubkey {
  4226. t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
  4227. }
  4228. expected_privkey := "testkey2.pem"
  4229. actual_privkey := apex_key.privateKeyFile.String()
  4230. if actual_privkey != expected_privkey {
  4231. t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
  4232. }
  4233. }
  4234. func TestPrebuilt(t *testing.T) {
  4235. ctx := testApex(t, `
  4236. prebuilt_apex {
  4237. name: "myapex",
  4238. arch: {
  4239. arm64: {
  4240. src: "myapex-arm64.apex",
  4241. },
  4242. arm: {
  4243. src: "myapex-arm.apex",
  4244. },
  4245. },
  4246. }
  4247. `)
  4248. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4249. prebuilt := testingModule.Module().(*Prebuilt)
  4250. expectedInput := "myapex-arm64.apex"
  4251. if prebuilt.inputApex.String() != expectedInput {
  4252. t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
  4253. }
  4254. android.AssertStringDoesContain(t, "Invalid provenance metadata file",
  4255. prebuilt.ProvenanceMetaDataFile().String(), "soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto")
  4256. rule := testingModule.Rule("genProvenanceMetaData")
  4257. android.AssertStringEquals(t, "Invalid input", "myapex-arm64.apex", rule.Inputs[0].String())
  4258. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4259. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4260. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.apex", rule.Args["install_path"])
  4261. }
  4262. func TestPrebuiltMissingSrc(t *testing.T) {
  4263. testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
  4264. prebuilt_apex {
  4265. name: "myapex",
  4266. }
  4267. `)
  4268. }
  4269. func TestPrebuiltFilenameOverride(t *testing.T) {
  4270. ctx := testApex(t, `
  4271. prebuilt_apex {
  4272. name: "myapex",
  4273. src: "myapex-arm.apex",
  4274. filename: "notmyapex.apex",
  4275. }
  4276. `)
  4277. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4278. p := testingModule.Module().(*Prebuilt)
  4279. expected := "notmyapex.apex"
  4280. if p.installFilename != expected {
  4281. t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
  4282. }
  4283. rule := testingModule.Rule("genProvenanceMetaData")
  4284. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4285. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4286. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4287. android.AssertStringEquals(t, "Invalid args", "/system/apex/notmyapex.apex", rule.Args["install_path"])
  4288. }
  4289. func TestApexSetFilenameOverride(t *testing.T) {
  4290. testApex(t, `
  4291. apex_set {
  4292. name: "com.company.android.myapex",
  4293. apex_name: "com.android.myapex",
  4294. set: "company-myapex.apks",
  4295. filename: "com.company.android.myapex.apex"
  4296. }
  4297. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4298. testApex(t, `
  4299. apex_set {
  4300. name: "com.company.android.myapex",
  4301. apex_name: "com.android.myapex",
  4302. set: "company-myapex.apks",
  4303. filename: "com.company.android.myapex.capex"
  4304. }
  4305. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4306. testApexError(t, `filename should end in .apex or .capex for apex_set`, `
  4307. apex_set {
  4308. name: "com.company.android.myapex",
  4309. apex_name: "com.android.myapex",
  4310. set: "company-myapex.apks",
  4311. filename: "some-random-suffix"
  4312. }
  4313. `)
  4314. }
  4315. func TestPrebuiltOverrides(t *testing.T) {
  4316. ctx := testApex(t, `
  4317. prebuilt_apex {
  4318. name: "myapex.prebuilt",
  4319. src: "myapex-arm.apex",
  4320. overrides: [
  4321. "myapex",
  4322. ],
  4323. }
  4324. `)
  4325. testingModule := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt")
  4326. p := testingModule.Module().(*Prebuilt)
  4327. expected := []string{"myapex"}
  4328. actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  4329. if !reflect.DeepEqual(actual, expected) {
  4330. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
  4331. }
  4332. rule := testingModule.Rule("genProvenanceMetaData")
  4333. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4334. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex.prebuilt/provenance_metadata.textproto", rule.Output.String())
  4335. android.AssertStringEquals(t, "Invalid args", "myapex.prebuilt", rule.Args["module_name"])
  4336. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.prebuilt.apex", rule.Args["install_path"])
  4337. }
  4338. func TestPrebuiltApexName(t *testing.T) {
  4339. testApex(t, `
  4340. prebuilt_apex {
  4341. name: "com.company.android.myapex",
  4342. apex_name: "com.android.myapex",
  4343. src: "company-myapex-arm.apex",
  4344. }
  4345. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4346. testApex(t, `
  4347. apex_set {
  4348. name: "com.company.android.myapex",
  4349. apex_name: "com.android.myapex",
  4350. set: "company-myapex.apks",
  4351. }
  4352. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4353. }
  4354. func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
  4355. _ = android.GroupFixturePreparers(
  4356. java.PrepareForTestWithJavaDefaultModules,
  4357. PrepareForTestWithApexBuildComponents,
  4358. android.FixtureWithRootAndroidBp(`
  4359. platform_bootclasspath {
  4360. name: "platform-bootclasspath",
  4361. fragments: [
  4362. {
  4363. apex: "com.android.art",
  4364. module: "art-bootclasspath-fragment",
  4365. },
  4366. ],
  4367. }
  4368. prebuilt_apex {
  4369. name: "com.company.android.art",
  4370. apex_name: "com.android.art",
  4371. src: "com.company.android.art-arm.apex",
  4372. exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
  4373. }
  4374. prebuilt_bootclasspath_fragment {
  4375. name: "art-bootclasspath-fragment",
  4376. image_name: "art",
  4377. contents: ["core-oj"],
  4378. hidden_api: {
  4379. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4380. metadata: "my-bootclasspath-fragment/metadata.csv",
  4381. index: "my-bootclasspath-fragment/index.csv",
  4382. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4383. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4384. },
  4385. }
  4386. java_import {
  4387. name: "core-oj",
  4388. jars: ["prebuilt.jar"],
  4389. }
  4390. `),
  4391. ).RunTest(t)
  4392. }
  4393. // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
  4394. // propagation of paths to dex implementation jars from the former to the latter.
  4395. func TestPrebuiltExportDexImplementationJars(t *testing.T) {
  4396. transform := android.NullFixturePreparer
  4397. checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4398. t.Helper()
  4399. // Make sure the import has been given the correct path to the dex jar.
  4400. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4401. dexJarBuildPath := p.DexJarBuildPath().PathOrNil()
  4402. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4403. android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
  4404. ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
  4405. android.NormalizePathForTesting(dexJarBuildPath))
  4406. }
  4407. checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4408. t.Helper()
  4409. // Make sure the import has been given the correct path to the dex jar.
  4410. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4411. dexJarBuildPath := p.DexJarInstallPath()
  4412. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4413. android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
  4414. "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
  4415. android.NormalizePathForTesting(dexJarBuildPath))
  4416. }
  4417. ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
  4418. t.Helper()
  4419. // Make sure that an apex variant is not created for the source module.
  4420. android.AssertArrayString(t, "Check if there is no source variant",
  4421. []string{"android_common"},
  4422. ctx.ModuleVariantsForTests(name))
  4423. }
  4424. t.Run("prebuilt only", func(t *testing.T) {
  4425. bp := `
  4426. prebuilt_apex {
  4427. name: "myapex",
  4428. arch: {
  4429. arm64: {
  4430. src: "myapex-arm64.apex",
  4431. },
  4432. arm: {
  4433. src: "myapex-arm.apex",
  4434. },
  4435. },
  4436. exported_java_libs: ["libfoo", "libbar"],
  4437. }
  4438. java_import {
  4439. name: "libfoo",
  4440. jars: ["libfoo.jar"],
  4441. }
  4442. java_sdk_library_import {
  4443. name: "libbar",
  4444. public: {
  4445. jars: ["libbar.jar"],
  4446. },
  4447. }
  4448. `
  4449. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4450. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4451. deapexerName := deapexerModuleName("myapex")
  4452. android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName))
  4453. // Make sure that the deapexer has the correct input APEX.
  4454. deapexer := ctx.ModuleForTests(deapexerName, "android_common")
  4455. rule := deapexer.Rule("deapexer")
  4456. if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
  4457. t.Errorf("expected: %q, found: %q", expected, actual)
  4458. }
  4459. // Make sure that the prebuilt_apex has the correct input APEX.
  4460. prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
  4461. rule = prebuiltApex.Rule("android/soong/android.Cp")
  4462. if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
  4463. t.Errorf("expected: %q, found: %q", expected, actual)
  4464. }
  4465. checkDexJarBuildPath(t, ctx, "libfoo")
  4466. checkDexJarInstallPath(t, ctx, "libfoo")
  4467. checkDexJarBuildPath(t, ctx, "libbar")
  4468. checkDexJarInstallPath(t, ctx, "libbar")
  4469. })
  4470. t.Run("prebuilt with source preferred", func(t *testing.T) {
  4471. bp := `
  4472. prebuilt_apex {
  4473. name: "myapex",
  4474. arch: {
  4475. arm64: {
  4476. src: "myapex-arm64.apex",
  4477. },
  4478. arm: {
  4479. src: "myapex-arm.apex",
  4480. },
  4481. },
  4482. exported_java_libs: ["libfoo", "libbar"],
  4483. }
  4484. java_import {
  4485. name: "libfoo",
  4486. jars: ["libfoo.jar"],
  4487. }
  4488. java_library {
  4489. name: "libfoo",
  4490. }
  4491. java_sdk_library_import {
  4492. name: "libbar",
  4493. public: {
  4494. jars: ["libbar.jar"],
  4495. },
  4496. }
  4497. java_sdk_library {
  4498. name: "libbar",
  4499. srcs: ["foo/bar/MyClass.java"],
  4500. unsafe_ignore_missing_latest_api: true,
  4501. }
  4502. `
  4503. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4504. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4505. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4506. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4507. ensureNoSourceVariant(t, ctx, "libfoo")
  4508. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4509. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4510. ensureNoSourceVariant(t, ctx, "libbar")
  4511. })
  4512. t.Run("prebuilt preferred with source", func(t *testing.T) {
  4513. bp := `
  4514. prebuilt_apex {
  4515. name: "myapex",
  4516. arch: {
  4517. arm64: {
  4518. src: "myapex-arm64.apex",
  4519. },
  4520. arm: {
  4521. src: "myapex-arm.apex",
  4522. },
  4523. },
  4524. exported_java_libs: ["libfoo", "libbar"],
  4525. }
  4526. java_import {
  4527. name: "libfoo",
  4528. prefer: true,
  4529. jars: ["libfoo.jar"],
  4530. }
  4531. java_library {
  4532. name: "libfoo",
  4533. }
  4534. java_sdk_library_import {
  4535. name: "libbar",
  4536. prefer: true,
  4537. public: {
  4538. jars: ["libbar.jar"],
  4539. },
  4540. }
  4541. java_sdk_library {
  4542. name: "libbar",
  4543. srcs: ["foo/bar/MyClass.java"],
  4544. unsafe_ignore_missing_latest_api: true,
  4545. }
  4546. `
  4547. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4548. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4549. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4550. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4551. ensureNoSourceVariant(t, ctx, "libfoo")
  4552. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4553. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4554. ensureNoSourceVariant(t, ctx, "libbar")
  4555. })
  4556. }
  4557. func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
  4558. preparer := android.GroupFixturePreparers(
  4559. java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
  4560. // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
  4561. // is disabled.
  4562. android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
  4563. )
  4564. checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
  4565. t.Helper()
  4566. s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4567. foundLibfooJar := false
  4568. base := stem + ".jar"
  4569. for _, output := range s.AllOutputs() {
  4570. if filepath.Base(output) == base {
  4571. foundLibfooJar = true
  4572. buildRule := s.Output(output)
  4573. android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
  4574. }
  4575. }
  4576. if !foundLibfooJar {
  4577. t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
  4578. }
  4579. }
  4580. checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4581. t.Helper()
  4582. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4583. var rule android.TestingBuildParams
  4584. rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
  4585. java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
  4586. }
  4587. checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4588. t.Helper()
  4589. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4590. var rule android.TestingBuildParams
  4591. rule = platformBootclasspath.Output("hiddenapi-index.csv")
  4592. java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
  4593. }
  4594. fragment := java.ApexVariantReference{
  4595. Apex: proptools.StringPtr("myapex"),
  4596. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  4597. }
  4598. t.Run("prebuilt only", func(t *testing.T) {
  4599. bp := `
  4600. prebuilt_apex {
  4601. name: "myapex",
  4602. arch: {
  4603. arm64: {
  4604. src: "myapex-arm64.apex",
  4605. },
  4606. arm: {
  4607. src: "myapex-arm.apex",
  4608. },
  4609. },
  4610. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4611. }
  4612. prebuilt_bootclasspath_fragment {
  4613. name: "my-bootclasspath-fragment",
  4614. contents: ["libfoo", "libbar"],
  4615. apex_available: ["myapex"],
  4616. hidden_api: {
  4617. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4618. metadata: "my-bootclasspath-fragment/metadata.csv",
  4619. index: "my-bootclasspath-fragment/index.csv",
  4620. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4621. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4622. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4623. },
  4624. }
  4625. java_import {
  4626. name: "libfoo",
  4627. jars: ["libfoo.jar"],
  4628. apex_available: ["myapex"],
  4629. permitted_packages: ["foo"],
  4630. }
  4631. java_sdk_library_import {
  4632. name: "libbar",
  4633. public: {
  4634. jars: ["libbar.jar"],
  4635. },
  4636. apex_available: ["myapex"],
  4637. shared_library: false,
  4638. permitted_packages: ["bar"],
  4639. }
  4640. `
  4641. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4642. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4643. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4644. // Verify the correct module jars contribute to the hiddenapi index file.
  4645. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4646. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4647. my-bootclasspath-fragment/index.csv
  4648. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4649. `)
  4650. })
  4651. t.Run("apex_set only", func(t *testing.T) {
  4652. bp := `
  4653. apex_set {
  4654. name: "myapex",
  4655. set: "myapex.apks",
  4656. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4657. }
  4658. prebuilt_bootclasspath_fragment {
  4659. name: "my-bootclasspath-fragment",
  4660. contents: ["libfoo", "libbar"],
  4661. apex_available: ["myapex"],
  4662. hidden_api: {
  4663. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4664. metadata: "my-bootclasspath-fragment/metadata.csv",
  4665. index: "my-bootclasspath-fragment/index.csv",
  4666. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4667. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4668. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4669. },
  4670. }
  4671. java_import {
  4672. name: "libfoo",
  4673. jars: ["libfoo.jar"],
  4674. apex_available: ["myapex"],
  4675. permitted_packages: ["foo"],
  4676. }
  4677. java_sdk_library_import {
  4678. name: "libbar",
  4679. public: {
  4680. jars: ["libbar.jar"],
  4681. },
  4682. apex_available: ["myapex"],
  4683. shared_library: false,
  4684. permitted_packages: ["bar"],
  4685. }
  4686. `
  4687. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4688. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4689. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4690. // Verify the correct module jars contribute to the hiddenapi index file.
  4691. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4692. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4693. my-bootclasspath-fragment/index.csv
  4694. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4695. `)
  4696. })
  4697. t.Run("prebuilt with source library preferred", func(t *testing.T) {
  4698. bp := `
  4699. prebuilt_apex {
  4700. name: "myapex",
  4701. arch: {
  4702. arm64: {
  4703. src: "myapex-arm64.apex",
  4704. },
  4705. arm: {
  4706. src: "myapex-arm.apex",
  4707. },
  4708. },
  4709. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4710. }
  4711. prebuilt_bootclasspath_fragment {
  4712. name: "my-bootclasspath-fragment",
  4713. contents: ["libfoo", "libbar"],
  4714. apex_available: ["myapex"],
  4715. hidden_api: {
  4716. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4717. metadata: "my-bootclasspath-fragment/metadata.csv",
  4718. index: "my-bootclasspath-fragment/index.csv",
  4719. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4720. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4721. },
  4722. }
  4723. java_import {
  4724. name: "libfoo",
  4725. jars: ["libfoo.jar"],
  4726. apex_available: ["myapex"],
  4727. }
  4728. java_library {
  4729. name: "libfoo",
  4730. srcs: ["foo/bar/MyClass.java"],
  4731. apex_available: ["myapex"],
  4732. }
  4733. java_sdk_library_import {
  4734. name: "libbar",
  4735. public: {
  4736. jars: ["libbar.jar"],
  4737. },
  4738. apex_available: ["myapex"],
  4739. shared_library: false,
  4740. }
  4741. java_sdk_library {
  4742. name: "libbar",
  4743. srcs: ["foo/bar/MyClass.java"],
  4744. unsafe_ignore_missing_latest_api: true,
  4745. apex_available: ["myapex"],
  4746. }
  4747. `
  4748. // In this test the source (java_library) libfoo is active since the
  4749. // prebuilt (java_import) defaults to prefer:false. However the
  4750. // prebuilt_apex module always depends on the prebuilt, and so it doesn't
  4751. // find the dex boot jar in it. We either need to disable the source libfoo
  4752. // or make the prebuilt libfoo preferred.
  4753. testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
  4754. // dexbootjar check is skipped if AllowMissingDependencies is true
  4755. preparerAllowMissingDeps := android.GroupFixturePreparers(
  4756. preparer,
  4757. android.PrepareForTestWithAllowMissingDependencies,
  4758. )
  4759. testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
  4760. })
  4761. t.Run("prebuilt library preferred with source", func(t *testing.T) {
  4762. bp := `
  4763. prebuilt_apex {
  4764. name: "myapex",
  4765. arch: {
  4766. arm64: {
  4767. src: "myapex-arm64.apex",
  4768. },
  4769. arm: {
  4770. src: "myapex-arm.apex",
  4771. },
  4772. },
  4773. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4774. }
  4775. prebuilt_bootclasspath_fragment {
  4776. name: "my-bootclasspath-fragment",
  4777. contents: ["libfoo", "libbar"],
  4778. apex_available: ["myapex"],
  4779. hidden_api: {
  4780. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4781. metadata: "my-bootclasspath-fragment/metadata.csv",
  4782. index: "my-bootclasspath-fragment/index.csv",
  4783. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4784. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4785. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4786. },
  4787. }
  4788. java_import {
  4789. name: "libfoo",
  4790. prefer: true,
  4791. jars: ["libfoo.jar"],
  4792. apex_available: ["myapex"],
  4793. permitted_packages: ["foo"],
  4794. }
  4795. java_library {
  4796. name: "libfoo",
  4797. srcs: ["foo/bar/MyClass.java"],
  4798. apex_available: ["myapex"],
  4799. }
  4800. java_sdk_library_import {
  4801. name: "libbar",
  4802. prefer: true,
  4803. public: {
  4804. jars: ["libbar.jar"],
  4805. },
  4806. apex_available: ["myapex"],
  4807. shared_library: false,
  4808. permitted_packages: ["bar"],
  4809. }
  4810. java_sdk_library {
  4811. name: "libbar",
  4812. srcs: ["foo/bar/MyClass.java"],
  4813. unsafe_ignore_missing_latest_api: true,
  4814. apex_available: ["myapex"],
  4815. }
  4816. `
  4817. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4818. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4819. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4820. // Verify the correct module jars contribute to the hiddenapi index file.
  4821. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4822. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4823. my-bootclasspath-fragment/index.csv
  4824. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4825. `)
  4826. })
  4827. t.Run("prebuilt with source apex preferred", func(t *testing.T) {
  4828. bp := `
  4829. apex {
  4830. name: "myapex",
  4831. key: "myapex.key",
  4832. java_libs: ["libfoo", "libbar"],
  4833. updatable: false,
  4834. }
  4835. apex_key {
  4836. name: "myapex.key",
  4837. public_key: "testkey.avbpubkey",
  4838. private_key: "testkey.pem",
  4839. }
  4840. prebuilt_apex {
  4841. name: "myapex",
  4842. arch: {
  4843. arm64: {
  4844. src: "myapex-arm64.apex",
  4845. },
  4846. arm: {
  4847. src: "myapex-arm.apex",
  4848. },
  4849. },
  4850. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4851. }
  4852. prebuilt_bootclasspath_fragment {
  4853. name: "my-bootclasspath-fragment",
  4854. contents: ["libfoo", "libbar"],
  4855. apex_available: ["myapex"],
  4856. hidden_api: {
  4857. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4858. metadata: "my-bootclasspath-fragment/metadata.csv",
  4859. index: "my-bootclasspath-fragment/index.csv",
  4860. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4861. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4862. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4863. },
  4864. }
  4865. java_import {
  4866. name: "libfoo",
  4867. jars: ["libfoo.jar"],
  4868. apex_available: ["myapex"],
  4869. }
  4870. java_library {
  4871. name: "libfoo",
  4872. srcs: ["foo/bar/MyClass.java"],
  4873. apex_available: ["myapex"],
  4874. permitted_packages: ["foo"],
  4875. }
  4876. java_sdk_library_import {
  4877. name: "libbar",
  4878. public: {
  4879. jars: ["libbar.jar"],
  4880. },
  4881. apex_available: ["myapex"],
  4882. shared_library: false,
  4883. }
  4884. java_sdk_library {
  4885. name: "libbar",
  4886. srcs: ["foo/bar/MyClass.java"],
  4887. unsafe_ignore_missing_latest_api: true,
  4888. apex_available: ["myapex"],
  4889. permitted_packages: ["bar"],
  4890. }
  4891. `
  4892. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4893. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
  4894. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
  4895. // Verify the correct module jars contribute to the hiddenapi index file.
  4896. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4897. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4898. my-bootclasspath-fragment/index.csv
  4899. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4900. `)
  4901. })
  4902. t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
  4903. bp := `
  4904. apex {
  4905. name: "myapex",
  4906. enabled: false,
  4907. key: "myapex.key",
  4908. java_libs: ["libfoo", "libbar"],
  4909. }
  4910. apex_key {
  4911. name: "myapex.key",
  4912. public_key: "testkey.avbpubkey",
  4913. private_key: "testkey.pem",
  4914. }
  4915. prebuilt_apex {
  4916. name: "myapex",
  4917. arch: {
  4918. arm64: {
  4919. src: "myapex-arm64.apex",
  4920. },
  4921. arm: {
  4922. src: "myapex-arm.apex",
  4923. },
  4924. },
  4925. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4926. }
  4927. prebuilt_bootclasspath_fragment {
  4928. name: "my-bootclasspath-fragment",
  4929. contents: ["libfoo", "libbar"],
  4930. apex_available: ["myapex"],
  4931. hidden_api: {
  4932. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4933. metadata: "my-bootclasspath-fragment/metadata.csv",
  4934. index: "my-bootclasspath-fragment/index.csv",
  4935. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4936. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4937. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4938. },
  4939. }
  4940. java_import {
  4941. name: "libfoo",
  4942. prefer: true,
  4943. jars: ["libfoo.jar"],
  4944. apex_available: ["myapex"],
  4945. permitted_packages: ["foo"],
  4946. }
  4947. java_library {
  4948. name: "libfoo",
  4949. srcs: ["foo/bar/MyClass.java"],
  4950. apex_available: ["myapex"],
  4951. }
  4952. java_sdk_library_import {
  4953. name: "libbar",
  4954. prefer: true,
  4955. public: {
  4956. jars: ["libbar.jar"],
  4957. },
  4958. apex_available: ["myapex"],
  4959. shared_library: false,
  4960. permitted_packages: ["bar"],
  4961. }
  4962. java_sdk_library {
  4963. name: "libbar",
  4964. srcs: ["foo/bar/MyClass.java"],
  4965. unsafe_ignore_missing_latest_api: true,
  4966. apex_available: ["myapex"],
  4967. }
  4968. `
  4969. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4970. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4971. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4972. // Verify the correct module jars contribute to the hiddenapi index file.
  4973. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4974. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4975. my-bootclasspath-fragment/index.csv
  4976. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4977. `)
  4978. })
  4979. }
  4980. func TestApexWithTests(t *testing.T) {
  4981. ctx := testApex(t, `
  4982. apex_test {
  4983. name: "myapex",
  4984. key: "myapex.key",
  4985. updatable: false,
  4986. tests: [
  4987. "mytest",
  4988. "mytests",
  4989. ],
  4990. }
  4991. apex_key {
  4992. name: "myapex.key",
  4993. public_key: "testkey.avbpubkey",
  4994. private_key: "testkey.pem",
  4995. }
  4996. filegroup {
  4997. name: "fg",
  4998. srcs: [
  4999. "baz",
  5000. "bar/baz"
  5001. ],
  5002. }
  5003. cc_test {
  5004. name: "mytest",
  5005. gtest: false,
  5006. srcs: ["mytest.cpp"],
  5007. relative_install_path: "test",
  5008. shared_libs: ["mylib"],
  5009. system_shared_libs: [],
  5010. static_executable: true,
  5011. stl: "none",
  5012. data: [":fg"],
  5013. }
  5014. cc_library {
  5015. name: "mylib",
  5016. srcs: ["mylib.cpp"],
  5017. system_shared_libs: [],
  5018. stl: "none",
  5019. }
  5020. filegroup {
  5021. name: "fg2",
  5022. srcs: [
  5023. "testdata/baz"
  5024. ],
  5025. }
  5026. cc_test {
  5027. name: "mytests",
  5028. gtest: false,
  5029. srcs: [
  5030. "mytest1.cpp",
  5031. "mytest2.cpp",
  5032. "mytest3.cpp",
  5033. ],
  5034. test_per_src: true,
  5035. relative_install_path: "test",
  5036. system_shared_libs: [],
  5037. static_executable: true,
  5038. stl: "none",
  5039. data: [
  5040. ":fg",
  5041. ":fg2",
  5042. ],
  5043. }
  5044. `)
  5045. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5046. copyCmds := apexRule.Args["copy_commands"]
  5047. // Ensure that test dep (and their transitive dependencies) are copied into apex.
  5048. ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
  5049. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5050. //Ensure that test data are copied into apex.
  5051. ensureContains(t, copyCmds, "image.apex/bin/test/baz")
  5052. ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
  5053. // Ensure that test deps built with `test_per_src` are copied into apex.
  5054. ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
  5055. ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
  5056. ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
  5057. // Ensure the module is correctly translated.
  5058. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5059. data := android.AndroidMkDataForTest(t, ctx, bundle)
  5060. name := bundle.BaseModuleName()
  5061. prefix := "TARGET_"
  5062. var builder strings.Builder
  5063. data.Custom(&builder, name, prefix, "", data)
  5064. androidMk := builder.String()
  5065. ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
  5066. ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
  5067. ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
  5068. ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
  5069. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
  5070. ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
  5071. ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
  5072. flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  5073. data = android.AndroidMkDataForTest(t, ctx, flatBundle)
  5074. data.Custom(&builder, name, prefix, "", data)
  5075. flatAndroidMk := builder.String()
  5076. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
  5077. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
  5078. }
  5079. func TestInstallExtraFlattenedApexes(t *testing.T) {
  5080. ctx := testApex(t, `
  5081. apex {
  5082. name: "myapex",
  5083. key: "myapex.key",
  5084. updatable: false,
  5085. }
  5086. apex_key {
  5087. name: "myapex.key",
  5088. public_key: "testkey.avbpubkey",
  5089. private_key: "testkey.pem",
  5090. }
  5091. `,
  5092. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  5093. variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
  5094. }),
  5095. )
  5096. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5097. ensureListContains(t, ab.requiredDeps, "myapex.flattened")
  5098. mk := android.AndroidMkDataForTest(t, ctx, ab)
  5099. var builder strings.Builder
  5100. mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
  5101. androidMk := builder.String()
  5102. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := apex_manifest.pb.myapex apex_pubkey.myapex myapex.flattened\n")
  5103. }
  5104. func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
  5105. testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
  5106. apex {
  5107. name: "myapex",
  5108. key: "myapex.key",
  5109. native_shared_libs: ["libfoo"],
  5110. }
  5111. apex_key {
  5112. name: "myapex.key",
  5113. public_key: "testkey.avbpubkey",
  5114. private_key: "testkey.pem",
  5115. }
  5116. cc_library {
  5117. name: "libfoo",
  5118. stl: "none",
  5119. system_shared_libs: [],
  5120. enabled: false,
  5121. apex_available: ["myapex"],
  5122. }
  5123. `)
  5124. testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
  5125. apex {
  5126. name: "myapex",
  5127. key: "myapex.key",
  5128. java_libs: ["myjar"],
  5129. }
  5130. apex_key {
  5131. name: "myapex.key",
  5132. public_key: "testkey.avbpubkey",
  5133. private_key: "testkey.pem",
  5134. }
  5135. java_library {
  5136. name: "myjar",
  5137. srcs: ["foo/bar/MyClass.java"],
  5138. sdk_version: "none",
  5139. system_modules: "none",
  5140. enabled: false,
  5141. apex_available: ["myapex"],
  5142. }
  5143. `)
  5144. }
  5145. func TestApexWithJavaImport(t *testing.T) {
  5146. ctx := testApex(t, `
  5147. apex {
  5148. name: "myapex",
  5149. key: "myapex.key",
  5150. java_libs: ["myjavaimport"],
  5151. updatable: false,
  5152. }
  5153. apex_key {
  5154. name: "myapex.key",
  5155. public_key: "testkey.avbpubkey",
  5156. private_key: "testkey.pem",
  5157. }
  5158. java_import {
  5159. name: "myjavaimport",
  5160. apex_available: ["myapex"],
  5161. jars: ["my.jar"],
  5162. compile_dex: true,
  5163. }
  5164. `)
  5165. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5166. apexRule := module.Rule("apexRule")
  5167. copyCmds := apexRule.Args["copy_commands"]
  5168. ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
  5169. }
  5170. func TestApexWithApps(t *testing.T) {
  5171. ctx := testApex(t, `
  5172. apex {
  5173. name: "myapex",
  5174. key: "myapex.key",
  5175. apps: [
  5176. "AppFoo",
  5177. "AppFooPriv",
  5178. ],
  5179. updatable: false,
  5180. }
  5181. apex_key {
  5182. name: "myapex.key",
  5183. public_key: "testkey.avbpubkey",
  5184. private_key: "testkey.pem",
  5185. }
  5186. android_app {
  5187. name: "AppFoo",
  5188. srcs: ["foo/bar/MyClass.java"],
  5189. sdk_version: "current",
  5190. system_modules: "none",
  5191. jni_libs: ["libjni"],
  5192. stl: "none",
  5193. apex_available: [ "myapex" ],
  5194. }
  5195. android_app {
  5196. name: "AppFooPriv",
  5197. srcs: ["foo/bar/MyClass.java"],
  5198. sdk_version: "current",
  5199. system_modules: "none",
  5200. privileged: true,
  5201. stl: "none",
  5202. apex_available: [ "myapex" ],
  5203. }
  5204. cc_library_shared {
  5205. name: "libjni",
  5206. srcs: ["mylib.cpp"],
  5207. shared_libs: ["libfoo"],
  5208. stl: "none",
  5209. system_shared_libs: [],
  5210. apex_available: [ "myapex" ],
  5211. sdk_version: "current",
  5212. }
  5213. cc_library_shared {
  5214. name: "libfoo",
  5215. stl: "none",
  5216. system_shared_libs: [],
  5217. apex_available: [ "myapex" ],
  5218. sdk_version: "current",
  5219. }
  5220. `)
  5221. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5222. apexRule := module.Rule("apexRule")
  5223. copyCmds := apexRule.Args["copy_commands"]
  5224. ensureContains(t, copyCmds, "image.apex/app/AppFoo@TEST.BUILD_ID/AppFoo.apk")
  5225. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv@TEST.BUILD_ID/AppFooPriv.apk")
  5226. appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
  5227. // JNI libraries are uncompressed
  5228. if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
  5229. t.Errorf("jni libs are not uncompressed for AppFoo")
  5230. }
  5231. // JNI libraries including transitive deps are
  5232. for _, jni := range []string{"libjni", "libfoo"} {
  5233. jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
  5234. // ... embedded inside APK (jnilibs.zip)
  5235. ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
  5236. // ... and not directly inside the APEX
  5237. ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
  5238. }
  5239. }
  5240. func TestApexWithAppImportBuildId(t *testing.T) {
  5241. invalidBuildIds := []string{"../", "a b", "a/b", "a/b/../c", "/a"}
  5242. for _, id := range invalidBuildIds {
  5243. message := fmt.Sprintf("Unable to use build id %s as filename suffix", id)
  5244. fixture := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  5245. variables.BuildId = proptools.StringPtr(id)
  5246. })
  5247. testApexError(t, message, `apex {
  5248. name: "myapex",
  5249. key: "myapex.key",
  5250. apps: ["AppFooPrebuilt"],
  5251. updatable: false,
  5252. }
  5253. apex_key {
  5254. name: "myapex.key",
  5255. public_key: "testkey.avbpubkey",
  5256. private_key: "testkey.pem",
  5257. }
  5258. android_app_import {
  5259. name: "AppFooPrebuilt",
  5260. apk: "PrebuiltAppFoo.apk",
  5261. presigned: true,
  5262. apex_available: ["myapex"],
  5263. }
  5264. `, fixture)
  5265. }
  5266. }
  5267. func TestApexWithAppImports(t *testing.T) {
  5268. ctx := testApex(t, `
  5269. apex {
  5270. name: "myapex",
  5271. key: "myapex.key",
  5272. apps: [
  5273. "AppFooPrebuilt",
  5274. "AppFooPrivPrebuilt",
  5275. ],
  5276. updatable: false,
  5277. }
  5278. apex_key {
  5279. name: "myapex.key",
  5280. public_key: "testkey.avbpubkey",
  5281. private_key: "testkey.pem",
  5282. }
  5283. android_app_import {
  5284. name: "AppFooPrebuilt",
  5285. apk: "PrebuiltAppFoo.apk",
  5286. presigned: true,
  5287. dex_preopt: {
  5288. enabled: false,
  5289. },
  5290. apex_available: ["myapex"],
  5291. }
  5292. android_app_import {
  5293. name: "AppFooPrivPrebuilt",
  5294. apk: "PrebuiltAppFooPriv.apk",
  5295. privileged: true,
  5296. presigned: true,
  5297. dex_preopt: {
  5298. enabled: false,
  5299. },
  5300. filename: "AwesomePrebuiltAppFooPriv.apk",
  5301. apex_available: ["myapex"],
  5302. }
  5303. `)
  5304. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5305. apexRule := module.Rule("apexRule")
  5306. copyCmds := apexRule.Args["copy_commands"]
  5307. ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt@TEST.BUILD_ID/AppFooPrebuilt.apk")
  5308. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt@TEST.BUILD_ID/AwesomePrebuiltAppFooPriv.apk")
  5309. }
  5310. func TestApexWithAppImportsPrefer(t *testing.T) {
  5311. ctx := testApex(t, `
  5312. apex {
  5313. name: "myapex",
  5314. key: "myapex.key",
  5315. apps: [
  5316. "AppFoo",
  5317. ],
  5318. updatable: false,
  5319. }
  5320. apex_key {
  5321. name: "myapex.key",
  5322. public_key: "testkey.avbpubkey",
  5323. private_key: "testkey.pem",
  5324. }
  5325. android_app {
  5326. name: "AppFoo",
  5327. srcs: ["foo/bar/MyClass.java"],
  5328. sdk_version: "none",
  5329. system_modules: "none",
  5330. apex_available: [ "myapex" ],
  5331. }
  5332. android_app_import {
  5333. name: "AppFoo",
  5334. apk: "AppFooPrebuilt.apk",
  5335. filename: "AppFooPrebuilt.apk",
  5336. presigned: true,
  5337. prefer: true,
  5338. apex_available: ["myapex"],
  5339. }
  5340. `, withFiles(map[string][]byte{
  5341. "AppFooPrebuilt.apk": nil,
  5342. }))
  5343. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5344. "app/AppFoo@TEST.BUILD_ID/AppFooPrebuilt.apk",
  5345. })
  5346. }
  5347. func TestApexWithTestHelperApp(t *testing.T) {
  5348. ctx := testApex(t, `
  5349. apex {
  5350. name: "myapex",
  5351. key: "myapex.key",
  5352. apps: [
  5353. "TesterHelpAppFoo",
  5354. ],
  5355. updatable: false,
  5356. }
  5357. apex_key {
  5358. name: "myapex.key",
  5359. public_key: "testkey.avbpubkey",
  5360. private_key: "testkey.pem",
  5361. }
  5362. android_test_helper_app {
  5363. name: "TesterHelpAppFoo",
  5364. srcs: ["foo/bar/MyClass.java"],
  5365. apex_available: [ "myapex" ],
  5366. }
  5367. `)
  5368. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5369. apexRule := module.Rule("apexRule")
  5370. copyCmds := apexRule.Args["copy_commands"]
  5371. ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo@TEST.BUILD_ID/TesterHelpAppFoo.apk")
  5372. }
  5373. func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
  5374. // libfoo's apex_available comes from cc_defaults
  5375. testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
  5376. apex {
  5377. name: "myapex",
  5378. key: "myapex.key",
  5379. native_shared_libs: ["libfoo"],
  5380. updatable: false,
  5381. }
  5382. apex_key {
  5383. name: "myapex.key",
  5384. public_key: "testkey.avbpubkey",
  5385. private_key: "testkey.pem",
  5386. }
  5387. apex {
  5388. name: "otherapex",
  5389. key: "myapex.key",
  5390. native_shared_libs: ["libfoo"],
  5391. updatable: false,
  5392. }
  5393. cc_defaults {
  5394. name: "libfoo-defaults",
  5395. apex_available: ["otherapex"],
  5396. }
  5397. cc_library {
  5398. name: "libfoo",
  5399. defaults: ["libfoo-defaults"],
  5400. stl: "none",
  5401. system_shared_libs: [],
  5402. }`)
  5403. }
  5404. func TestApexAvailable_DirectDep(t *testing.T) {
  5405. // libfoo is not available to myapex, but only to otherapex
  5406. testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
  5407. apex {
  5408. name: "myapex",
  5409. key: "myapex.key",
  5410. native_shared_libs: ["libfoo"],
  5411. updatable: false,
  5412. }
  5413. apex_key {
  5414. name: "myapex.key",
  5415. public_key: "testkey.avbpubkey",
  5416. private_key: "testkey.pem",
  5417. }
  5418. apex {
  5419. name: "otherapex",
  5420. key: "otherapex.key",
  5421. native_shared_libs: ["libfoo"],
  5422. updatable: false,
  5423. }
  5424. apex_key {
  5425. name: "otherapex.key",
  5426. public_key: "testkey.avbpubkey",
  5427. private_key: "testkey.pem",
  5428. }
  5429. cc_library {
  5430. name: "libfoo",
  5431. stl: "none",
  5432. system_shared_libs: [],
  5433. apex_available: ["otherapex"],
  5434. }`)
  5435. }
  5436. func TestApexAvailable_IndirectDep(t *testing.T) {
  5437. // libbbaz is an indirect dep
  5438. testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
  5439. .*via tag apex\.dependencyTag\{"sharedLib"\}
  5440. .*-> libfoo.*link:shared.*
  5441. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5442. .*-> libbar.*link:shared.*
  5443. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5444. .*-> libbaz.*link:shared.*`, `
  5445. apex {
  5446. name: "myapex",
  5447. key: "myapex.key",
  5448. native_shared_libs: ["libfoo"],
  5449. updatable: false,
  5450. }
  5451. apex_key {
  5452. name: "myapex.key",
  5453. public_key: "testkey.avbpubkey",
  5454. private_key: "testkey.pem",
  5455. }
  5456. cc_library {
  5457. name: "libfoo",
  5458. stl: "none",
  5459. shared_libs: ["libbar"],
  5460. system_shared_libs: [],
  5461. apex_available: ["myapex"],
  5462. }
  5463. cc_library {
  5464. name: "libbar",
  5465. stl: "none",
  5466. shared_libs: ["libbaz"],
  5467. system_shared_libs: [],
  5468. apex_available: ["myapex"],
  5469. }
  5470. cc_library {
  5471. name: "libbaz",
  5472. stl: "none",
  5473. system_shared_libs: [],
  5474. }`)
  5475. }
  5476. func TestApexAvailable_InvalidApexName(t *testing.T) {
  5477. testApexError(t, "\"otherapex\" is not a valid module name", `
  5478. apex {
  5479. name: "myapex",
  5480. key: "myapex.key",
  5481. native_shared_libs: ["libfoo"],
  5482. updatable: false,
  5483. }
  5484. apex_key {
  5485. name: "myapex.key",
  5486. public_key: "testkey.avbpubkey",
  5487. private_key: "testkey.pem",
  5488. }
  5489. cc_library {
  5490. name: "libfoo",
  5491. stl: "none",
  5492. system_shared_libs: [],
  5493. apex_available: ["otherapex"],
  5494. }`)
  5495. testApex(t, `
  5496. apex {
  5497. name: "myapex",
  5498. key: "myapex.key",
  5499. native_shared_libs: ["libfoo", "libbar"],
  5500. updatable: false,
  5501. }
  5502. apex_key {
  5503. name: "myapex.key",
  5504. public_key: "testkey.avbpubkey",
  5505. private_key: "testkey.pem",
  5506. }
  5507. cc_library {
  5508. name: "libfoo",
  5509. stl: "none",
  5510. system_shared_libs: [],
  5511. runtime_libs: ["libbaz"],
  5512. apex_available: ["myapex"],
  5513. }
  5514. cc_library {
  5515. name: "libbar",
  5516. stl: "none",
  5517. system_shared_libs: [],
  5518. apex_available: ["//apex_available:anyapex"],
  5519. }
  5520. cc_library {
  5521. name: "libbaz",
  5522. stl: "none",
  5523. system_shared_libs: [],
  5524. stubs: {
  5525. versions: ["10", "20", "30"],
  5526. },
  5527. }`)
  5528. }
  5529. func TestApexAvailable_CheckForPlatform(t *testing.T) {
  5530. ctx := testApex(t, `
  5531. apex {
  5532. name: "myapex",
  5533. key: "myapex.key",
  5534. native_shared_libs: ["libbar", "libbaz"],
  5535. updatable: false,
  5536. }
  5537. apex_key {
  5538. name: "myapex.key",
  5539. public_key: "testkey.avbpubkey",
  5540. private_key: "testkey.pem",
  5541. }
  5542. cc_library {
  5543. name: "libfoo",
  5544. stl: "none",
  5545. system_shared_libs: [],
  5546. shared_libs: ["libbar"],
  5547. apex_available: ["//apex_available:platform"],
  5548. }
  5549. cc_library {
  5550. name: "libfoo2",
  5551. stl: "none",
  5552. system_shared_libs: [],
  5553. shared_libs: ["libbaz"],
  5554. apex_available: ["//apex_available:platform"],
  5555. }
  5556. cc_library {
  5557. name: "libbar",
  5558. stl: "none",
  5559. system_shared_libs: [],
  5560. apex_available: ["myapex"],
  5561. }
  5562. cc_library {
  5563. name: "libbaz",
  5564. stl: "none",
  5565. system_shared_libs: [],
  5566. apex_available: ["myapex"],
  5567. stubs: {
  5568. versions: ["1"],
  5569. },
  5570. }`)
  5571. // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
  5572. // because it depends on libbar which isn't available to platform
  5573. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5574. if libfoo.NotAvailableForPlatform() != true {
  5575. t.Errorf("%q shouldn't be available to platform", libfoo.String())
  5576. }
  5577. // libfoo2 however can be available to platform because it depends on libbaz which provides
  5578. // stubs
  5579. libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5580. if libfoo2.NotAvailableForPlatform() == true {
  5581. t.Errorf("%q should be available to platform", libfoo2.String())
  5582. }
  5583. }
  5584. func TestApexAvailable_CreatedForApex(t *testing.T) {
  5585. ctx := testApex(t, `
  5586. apex {
  5587. name: "myapex",
  5588. key: "myapex.key",
  5589. native_shared_libs: ["libfoo"],
  5590. updatable: false,
  5591. }
  5592. apex_key {
  5593. name: "myapex.key",
  5594. public_key: "testkey.avbpubkey",
  5595. private_key: "testkey.pem",
  5596. }
  5597. cc_library {
  5598. name: "libfoo",
  5599. stl: "none",
  5600. system_shared_libs: [],
  5601. apex_available: ["myapex"],
  5602. static: {
  5603. apex_available: ["//apex_available:platform"],
  5604. },
  5605. }`)
  5606. libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5607. if libfooShared.NotAvailableForPlatform() != true {
  5608. t.Errorf("%q shouldn't be available to platform", libfooShared.String())
  5609. }
  5610. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
  5611. if libfooStatic.NotAvailableForPlatform() != false {
  5612. t.Errorf("%q should be available to platform", libfooStatic.String())
  5613. }
  5614. }
  5615. func TestOverrideApex(t *testing.T) {
  5616. ctx := testApex(t, `
  5617. apex {
  5618. name: "myapex",
  5619. key: "myapex.key",
  5620. apps: ["app"],
  5621. bpfs: ["bpf"],
  5622. prebuilts: ["myetc"],
  5623. bootclasspath_fragments: ["mybootclasspath_fragment"],
  5624. systemserverclasspath_fragments: ["mysystemserverclasspath_fragment"],
  5625. java_libs: ["myjava_library"],
  5626. overrides: ["oldapex"],
  5627. updatable: false,
  5628. }
  5629. override_apex {
  5630. name: "override_myapex",
  5631. base: "myapex",
  5632. apps: ["override_app"],
  5633. bpfs: ["overrideBpf"],
  5634. prebuilts: ["override_myetc"],
  5635. bootclasspath_fragments: ["override_bootclasspath_fragment"],
  5636. systemserverclasspath_fragments: ["override_systemserverclasspath_fragment"],
  5637. java_libs: ["override_java_library"],
  5638. overrides: ["unknownapex"],
  5639. logging_parent: "com.foo.bar",
  5640. package_name: "test.overridden.package",
  5641. key: "mynewapex.key",
  5642. certificate: ":myapex.certificate",
  5643. }
  5644. apex_key {
  5645. name: "myapex.key",
  5646. public_key: "testkey.avbpubkey",
  5647. private_key: "testkey.pem",
  5648. }
  5649. apex_key {
  5650. name: "mynewapex.key",
  5651. public_key: "testkey2.avbpubkey",
  5652. private_key: "testkey2.pem",
  5653. }
  5654. android_app_certificate {
  5655. name: "myapex.certificate",
  5656. certificate: "testkey",
  5657. }
  5658. android_app {
  5659. name: "app",
  5660. srcs: ["foo/bar/MyClass.java"],
  5661. package_name: "foo",
  5662. sdk_version: "none",
  5663. system_modules: "none",
  5664. apex_available: [ "myapex" ],
  5665. }
  5666. override_android_app {
  5667. name: "override_app",
  5668. base: "app",
  5669. package_name: "bar",
  5670. }
  5671. bpf {
  5672. name: "bpf",
  5673. srcs: ["bpf.c"],
  5674. }
  5675. bpf {
  5676. name: "overrideBpf",
  5677. srcs: ["overrideBpf.c"],
  5678. }
  5679. prebuilt_etc {
  5680. name: "myetc",
  5681. src: "myprebuilt",
  5682. }
  5683. prebuilt_etc {
  5684. name: "override_myetc",
  5685. src: "override_myprebuilt",
  5686. }
  5687. java_library {
  5688. name: "bcplib",
  5689. srcs: ["a.java"],
  5690. compile_dex: true,
  5691. apex_available: ["myapex"],
  5692. permitted_packages: ["bcp.lib"],
  5693. }
  5694. bootclasspath_fragment {
  5695. name: "mybootclasspath_fragment",
  5696. contents: ["bcplib"],
  5697. apex_available: ["myapex"],
  5698. hidden_api: {
  5699. split_packages: ["*"],
  5700. },
  5701. }
  5702. java_library {
  5703. name: "override_bcplib",
  5704. srcs: ["a.java"],
  5705. compile_dex: true,
  5706. apex_available: ["myapex"],
  5707. permitted_packages: ["override.bcp.lib"],
  5708. }
  5709. bootclasspath_fragment {
  5710. name: "override_bootclasspath_fragment",
  5711. contents: ["override_bcplib"],
  5712. apex_available: ["myapex"],
  5713. hidden_api: {
  5714. split_packages: ["*"],
  5715. },
  5716. }
  5717. java_library {
  5718. name: "systemserverlib",
  5719. srcs: ["a.java"],
  5720. apex_available: ["myapex"],
  5721. }
  5722. systemserverclasspath_fragment {
  5723. name: "mysystemserverclasspath_fragment",
  5724. standalone_contents: ["systemserverlib"],
  5725. apex_available: ["myapex"],
  5726. }
  5727. java_library {
  5728. name: "override_systemserverlib",
  5729. srcs: ["a.java"],
  5730. apex_available: ["myapex"],
  5731. }
  5732. systemserverclasspath_fragment {
  5733. name: "override_systemserverclasspath_fragment",
  5734. standalone_contents: ["override_systemserverlib"],
  5735. apex_available: ["myapex"],
  5736. }
  5737. java_library {
  5738. name: "myjava_library",
  5739. srcs: ["a.java"],
  5740. compile_dex: true,
  5741. apex_available: ["myapex"],
  5742. }
  5743. java_library {
  5744. name: "override_java_library",
  5745. srcs: ["a.java"],
  5746. compile_dex: true,
  5747. apex_available: ["myapex"],
  5748. }
  5749. `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
  5750. originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
  5751. overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
  5752. if originalVariant.GetOverriddenBy() != "" {
  5753. t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
  5754. }
  5755. if overriddenVariant.GetOverriddenBy() != "override_myapex" {
  5756. t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
  5757. }
  5758. module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
  5759. apexRule := module.Rule("apexRule")
  5760. copyCmds := apexRule.Args["copy_commands"]
  5761. ensureNotContains(t, copyCmds, "image.apex/app/app@TEST.BUILD_ID/app.apk")
  5762. ensureContains(t, copyCmds, "image.apex/app/override_app@TEST.BUILD_ID/override_app.apk")
  5763. ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
  5764. ensureContains(t, copyCmds, "image.apex/etc/bpf/overrideBpf.o")
  5765. ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
  5766. ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
  5767. apexBundle := module.Module().(*apexBundle)
  5768. name := apexBundle.Name()
  5769. if name != "override_myapex" {
  5770. t.Errorf("name should be \"override_myapex\", but was %q", name)
  5771. }
  5772. if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
  5773. t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
  5774. }
  5775. android.AssertArrayString(t, "Bootclasspath_fragments does not match",
  5776. []string{"override_bootclasspath_fragment"}, apexBundle.overridableProperties.Bootclasspath_fragments)
  5777. android.AssertArrayString(t, "Systemserverclasspath_fragments does not match",
  5778. []string{"override_systemserverclasspath_fragment"}, apexBundle.overridableProperties.Systemserverclasspath_fragments)
  5779. android.AssertArrayString(t, "Java_libs does not match",
  5780. []string{"override_java_library"}, apexBundle.overridableProperties.Java_libs)
  5781. optFlags := apexRule.Args["opt_flags"]
  5782. ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
  5783. ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
  5784. signApkRule := module.Rule("signapk")
  5785. ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
  5786. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5787. var builder strings.Builder
  5788. data.Custom(&builder, name, "TARGET_", "", data)
  5789. androidMk := builder.String()
  5790. ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
  5791. ensureContains(t, androidMk, "LOCAL_MODULE := overrideBpf.o.override_myapex")
  5792. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
  5793. ensureContains(t, androidMk, "LOCAL_MODULE := override_bcplib.override_myapex")
  5794. ensureContains(t, androidMk, "LOCAL_MODULE := override_systemserverlib.override_myapex")
  5795. ensureContains(t, androidMk, "LOCAL_MODULE := override_java_library.override_myapex")
  5796. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
  5797. ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
  5798. ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
  5799. ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
  5800. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
  5801. ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
  5802. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_bcplib.myapex")
  5803. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_systemserverlib.myapex")
  5804. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_java_library.pb.myapex")
  5805. ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
  5806. }
  5807. func TestMinSdkVersionOverride(t *testing.T) {
  5808. // Override from 29 to 31
  5809. minSdkOverride31 := "31"
  5810. ctx := testApex(t, `
  5811. apex {
  5812. name: "myapex",
  5813. key: "myapex.key",
  5814. native_shared_libs: ["mylib"],
  5815. updatable: true,
  5816. min_sdk_version: "29"
  5817. }
  5818. override_apex {
  5819. name: "override_myapex",
  5820. base: "myapex",
  5821. logging_parent: "com.foo.bar",
  5822. package_name: "test.overridden.package"
  5823. }
  5824. apex_key {
  5825. name: "myapex.key",
  5826. public_key: "testkey.avbpubkey",
  5827. private_key: "testkey.pem",
  5828. }
  5829. cc_library {
  5830. name: "mylib",
  5831. srcs: ["mylib.cpp"],
  5832. runtime_libs: ["libbar"],
  5833. system_shared_libs: [],
  5834. stl: "none",
  5835. apex_available: [ "myapex" ],
  5836. min_sdk_version: "apex_inherit"
  5837. }
  5838. cc_library {
  5839. name: "libbar",
  5840. srcs: ["mylib.cpp"],
  5841. system_shared_libs: [],
  5842. stl: "none",
  5843. apex_available: [ "myapex" ],
  5844. min_sdk_version: "apex_inherit"
  5845. }
  5846. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride31))
  5847. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5848. copyCmds := apexRule.Args["copy_commands"]
  5849. // Ensure that direct non-stubs dep is always included
  5850. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5851. // Ensure that runtime_libs dep in included
  5852. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  5853. // Ensure libraries target overridden min_sdk_version value
  5854. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  5855. }
  5856. func TestMinSdkVersionOverrideToLowerVersionNoOp(t *testing.T) {
  5857. // Attempt to override from 31 to 29, should be a NOOP
  5858. minSdkOverride29 := "29"
  5859. ctx := testApex(t, `
  5860. apex {
  5861. name: "myapex",
  5862. key: "myapex.key",
  5863. native_shared_libs: ["mylib"],
  5864. updatable: true,
  5865. min_sdk_version: "31"
  5866. }
  5867. override_apex {
  5868. name: "override_myapex",
  5869. base: "myapex",
  5870. logging_parent: "com.foo.bar",
  5871. package_name: "test.overridden.package"
  5872. }
  5873. apex_key {
  5874. name: "myapex.key",
  5875. public_key: "testkey.avbpubkey",
  5876. private_key: "testkey.pem",
  5877. }
  5878. cc_library {
  5879. name: "mylib",
  5880. srcs: ["mylib.cpp"],
  5881. runtime_libs: ["libbar"],
  5882. system_shared_libs: [],
  5883. stl: "none",
  5884. apex_available: [ "myapex" ],
  5885. min_sdk_version: "apex_inherit"
  5886. }
  5887. cc_library {
  5888. name: "libbar",
  5889. srcs: ["mylib.cpp"],
  5890. system_shared_libs: [],
  5891. stl: "none",
  5892. apex_available: [ "myapex" ],
  5893. min_sdk_version: "apex_inherit"
  5894. }
  5895. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride29))
  5896. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5897. copyCmds := apexRule.Args["copy_commands"]
  5898. // Ensure that direct non-stubs dep is always included
  5899. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5900. // Ensure that runtime_libs dep in included
  5901. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  5902. // Ensure libraries target the original min_sdk_version value rather than the overridden
  5903. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  5904. }
  5905. func TestLegacyAndroid10Support(t *testing.T) {
  5906. ctx := testApex(t, `
  5907. apex {
  5908. name: "myapex",
  5909. key: "myapex.key",
  5910. native_shared_libs: ["mylib"],
  5911. min_sdk_version: "29",
  5912. }
  5913. apex_key {
  5914. name: "myapex.key",
  5915. public_key: "testkey.avbpubkey",
  5916. private_key: "testkey.pem",
  5917. }
  5918. cc_library {
  5919. name: "mylib",
  5920. srcs: ["mylib.cpp"],
  5921. stl: "libc++",
  5922. system_shared_libs: [],
  5923. apex_available: [ "myapex" ],
  5924. min_sdk_version: "29",
  5925. }
  5926. `, withUnbundledBuild)
  5927. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5928. args := module.Rule("apexRule").Args
  5929. ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
  5930. ensureNotContains(t, args["opt_flags"], "--no_hashtree")
  5931. // The copies of the libraries in the apex should have one more dependency than
  5932. // the ones outside the apex, namely the unwinder. Ideally we should check
  5933. // the dependency names directly here but for some reason the names are blank in
  5934. // this test.
  5935. for _, lib := range []string{"libc++", "mylib"} {
  5936. apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
  5937. nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
  5938. if len(apexImplicits) != len(nonApexImplicits)+1 {
  5939. t.Errorf("%q missing unwinder dep", lib)
  5940. }
  5941. }
  5942. }
  5943. var filesForSdkLibrary = android.MockFS{
  5944. "api/current.txt": nil,
  5945. "api/removed.txt": nil,
  5946. "api/system-current.txt": nil,
  5947. "api/system-removed.txt": nil,
  5948. "api/test-current.txt": nil,
  5949. "api/test-removed.txt": nil,
  5950. "100/public/api/foo.txt": nil,
  5951. "100/public/api/foo-removed.txt": nil,
  5952. "100/system/api/foo.txt": nil,
  5953. "100/system/api/foo-removed.txt": nil,
  5954. // For java_sdk_library_import
  5955. "a.jar": nil,
  5956. }
  5957. func TestJavaSDKLibrary(t *testing.T) {
  5958. ctx := testApex(t, `
  5959. apex {
  5960. name: "myapex",
  5961. key: "myapex.key",
  5962. java_libs: ["foo"],
  5963. updatable: false,
  5964. }
  5965. apex_key {
  5966. name: "myapex.key",
  5967. public_key: "testkey.avbpubkey",
  5968. private_key: "testkey.pem",
  5969. }
  5970. java_sdk_library {
  5971. name: "foo",
  5972. srcs: ["a.java"],
  5973. api_packages: ["foo"],
  5974. apex_available: [ "myapex" ],
  5975. }
  5976. prebuilt_apis {
  5977. name: "sdk",
  5978. api_dirs: ["100"],
  5979. }
  5980. `, withFiles(filesForSdkLibrary))
  5981. // java_sdk_library installs both impl jar and permission XML
  5982. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5983. "javalib/foo.jar",
  5984. "etc/permissions/foo.xml",
  5985. })
  5986. // Permission XML should point to the activated path of impl jar of java_sdk_library
  5987. sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
  5988. ensureMatches(t, sdkLibrary.RuleParams.Command, `<library\\n\s+name=\\\"foo\\\"\\n\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"`)
  5989. }
  5990. func TestJavaSDKLibrary_WithinApex(t *testing.T) {
  5991. ctx := testApex(t, `
  5992. apex {
  5993. name: "myapex",
  5994. key: "myapex.key",
  5995. java_libs: ["foo", "bar"],
  5996. updatable: false,
  5997. }
  5998. apex_key {
  5999. name: "myapex.key",
  6000. public_key: "testkey.avbpubkey",
  6001. private_key: "testkey.pem",
  6002. }
  6003. java_sdk_library {
  6004. name: "foo",
  6005. srcs: ["a.java"],
  6006. api_packages: ["foo"],
  6007. apex_available: ["myapex"],
  6008. sdk_version: "none",
  6009. system_modules: "none",
  6010. }
  6011. java_library {
  6012. name: "bar",
  6013. srcs: ["a.java"],
  6014. libs: ["foo"],
  6015. apex_available: ["myapex"],
  6016. sdk_version: "none",
  6017. system_modules: "none",
  6018. }
  6019. prebuilt_apis {
  6020. name: "sdk",
  6021. api_dirs: ["100"],
  6022. }
  6023. `, withFiles(filesForSdkLibrary))
  6024. // java_sdk_library installs both impl jar and permission XML
  6025. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6026. "javalib/bar.jar",
  6027. "javalib/foo.jar",
  6028. "etc/permissions/foo.xml",
  6029. })
  6030. // The bar library should depend on the implementation jar.
  6031. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  6032. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6033. t.Errorf("expected %q, found %#q", expected, actual)
  6034. }
  6035. }
  6036. func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
  6037. ctx := testApex(t, `
  6038. apex {
  6039. name: "myapex",
  6040. key: "myapex.key",
  6041. java_libs: ["foo"],
  6042. updatable: false,
  6043. }
  6044. apex_key {
  6045. name: "myapex.key",
  6046. public_key: "testkey.avbpubkey",
  6047. private_key: "testkey.pem",
  6048. }
  6049. java_sdk_library {
  6050. name: "foo",
  6051. srcs: ["a.java"],
  6052. api_packages: ["foo"],
  6053. apex_available: ["myapex"],
  6054. sdk_version: "none",
  6055. system_modules: "none",
  6056. }
  6057. java_library {
  6058. name: "bar",
  6059. srcs: ["a.java"],
  6060. libs: ["foo"],
  6061. sdk_version: "none",
  6062. system_modules: "none",
  6063. }
  6064. prebuilt_apis {
  6065. name: "sdk",
  6066. api_dirs: ["100"],
  6067. }
  6068. `, withFiles(filesForSdkLibrary))
  6069. // java_sdk_library installs both impl jar and permission XML
  6070. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6071. "javalib/foo.jar",
  6072. "etc/permissions/foo.xml",
  6073. })
  6074. // The bar library should depend on the stubs jar.
  6075. barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
  6076. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6077. t.Errorf("expected %q, found %#q", expected, actual)
  6078. }
  6079. }
  6080. func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
  6081. ctx := testApex(t, `
  6082. prebuilt_apis {
  6083. name: "sdk",
  6084. api_dirs: ["100"],
  6085. }`,
  6086. withFiles(map[string][]byte{
  6087. "apex/a.java": nil,
  6088. "apex/apex_manifest.json": nil,
  6089. "apex/Android.bp": []byte(`
  6090. package {
  6091. default_visibility: ["//visibility:private"],
  6092. }
  6093. apex {
  6094. name: "myapex",
  6095. key: "myapex.key",
  6096. java_libs: ["foo", "bar"],
  6097. updatable: false,
  6098. }
  6099. apex_key {
  6100. name: "myapex.key",
  6101. public_key: "testkey.avbpubkey",
  6102. private_key: "testkey.pem",
  6103. }
  6104. java_library {
  6105. name: "bar",
  6106. srcs: ["a.java"],
  6107. libs: ["foo"],
  6108. apex_available: ["myapex"],
  6109. sdk_version: "none",
  6110. system_modules: "none",
  6111. }
  6112. `),
  6113. "source/a.java": nil,
  6114. "source/api/current.txt": nil,
  6115. "source/api/removed.txt": nil,
  6116. "source/Android.bp": []byte(`
  6117. package {
  6118. default_visibility: ["//visibility:private"],
  6119. }
  6120. java_sdk_library {
  6121. name: "foo",
  6122. visibility: ["//apex"],
  6123. srcs: ["a.java"],
  6124. api_packages: ["foo"],
  6125. apex_available: ["myapex"],
  6126. sdk_version: "none",
  6127. system_modules: "none",
  6128. public: {
  6129. enabled: true,
  6130. },
  6131. }
  6132. `),
  6133. "prebuilt/a.jar": nil,
  6134. "prebuilt/Android.bp": []byte(`
  6135. package {
  6136. default_visibility: ["//visibility:private"],
  6137. }
  6138. java_sdk_library_import {
  6139. name: "foo",
  6140. visibility: ["//apex", "//source"],
  6141. apex_available: ["myapex"],
  6142. prefer: true,
  6143. public: {
  6144. jars: ["a.jar"],
  6145. },
  6146. }
  6147. `),
  6148. }), withFiles(filesForSdkLibrary),
  6149. )
  6150. // java_sdk_library installs both impl jar and permission XML
  6151. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6152. "javalib/bar.jar",
  6153. "javalib/foo.jar",
  6154. "etc/permissions/foo.xml",
  6155. })
  6156. // The bar library should depend on the implementation jar.
  6157. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  6158. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6159. t.Errorf("expected %q, found %#q", expected, actual)
  6160. }
  6161. }
  6162. func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
  6163. testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
  6164. apex {
  6165. name: "myapex",
  6166. key: "myapex.key",
  6167. java_libs: ["foo"],
  6168. updatable: false,
  6169. }
  6170. apex_key {
  6171. name: "myapex.key",
  6172. public_key: "testkey.avbpubkey",
  6173. private_key: "testkey.pem",
  6174. }
  6175. java_sdk_library_import {
  6176. name: "foo",
  6177. apex_available: ["myapex"],
  6178. prefer: true,
  6179. public: {
  6180. jars: ["a.jar"],
  6181. },
  6182. }
  6183. `, withFiles(filesForSdkLibrary))
  6184. }
  6185. func TestCompatConfig(t *testing.T) {
  6186. result := android.GroupFixturePreparers(
  6187. prepareForApexTest,
  6188. java.PrepareForTestWithPlatformCompatConfig,
  6189. ).RunTestWithBp(t, `
  6190. apex {
  6191. name: "myapex",
  6192. key: "myapex.key",
  6193. compat_configs: ["myjar-platform-compat-config"],
  6194. java_libs: ["myjar"],
  6195. updatable: false,
  6196. }
  6197. apex_key {
  6198. name: "myapex.key",
  6199. public_key: "testkey.avbpubkey",
  6200. private_key: "testkey.pem",
  6201. }
  6202. platform_compat_config {
  6203. name: "myjar-platform-compat-config",
  6204. src: ":myjar",
  6205. }
  6206. java_library {
  6207. name: "myjar",
  6208. srcs: ["foo/bar/MyClass.java"],
  6209. sdk_version: "none",
  6210. system_modules: "none",
  6211. apex_available: [ "myapex" ],
  6212. }
  6213. // Make sure that a preferred prebuilt does not affect the apex contents.
  6214. prebuilt_platform_compat_config {
  6215. name: "myjar-platform-compat-config",
  6216. metadata: "compat-config/metadata.xml",
  6217. prefer: true,
  6218. }
  6219. `)
  6220. ctx := result.TestContext
  6221. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6222. "etc/compatconfig/myjar-platform-compat-config.xml",
  6223. "javalib/myjar.jar",
  6224. })
  6225. }
  6226. func TestRejectNonInstallableJavaLibrary(t *testing.T) {
  6227. testApexError(t, `"myjar" is not configured to be compiled into dex`, `
  6228. apex {
  6229. name: "myapex",
  6230. key: "myapex.key",
  6231. java_libs: ["myjar"],
  6232. updatable: false,
  6233. }
  6234. apex_key {
  6235. name: "myapex.key",
  6236. public_key: "testkey.avbpubkey",
  6237. private_key: "testkey.pem",
  6238. }
  6239. java_library {
  6240. name: "myjar",
  6241. srcs: ["foo/bar/MyClass.java"],
  6242. sdk_version: "none",
  6243. system_modules: "none",
  6244. compile_dex: false,
  6245. apex_available: ["myapex"],
  6246. }
  6247. `)
  6248. }
  6249. func TestCarryRequiredModuleNames(t *testing.T) {
  6250. ctx := testApex(t, `
  6251. apex {
  6252. name: "myapex",
  6253. key: "myapex.key",
  6254. native_shared_libs: ["mylib"],
  6255. updatable: false,
  6256. }
  6257. apex_key {
  6258. name: "myapex.key",
  6259. public_key: "testkey.avbpubkey",
  6260. private_key: "testkey.pem",
  6261. }
  6262. cc_library {
  6263. name: "mylib",
  6264. srcs: ["mylib.cpp"],
  6265. system_shared_libs: [],
  6266. stl: "none",
  6267. required: ["a", "b"],
  6268. host_required: ["c", "d"],
  6269. target_required: ["e", "f"],
  6270. apex_available: [ "myapex" ],
  6271. }
  6272. `)
  6273. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6274. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6275. name := apexBundle.BaseModuleName()
  6276. prefix := "TARGET_"
  6277. var builder strings.Builder
  6278. data.Custom(&builder, name, prefix, "", data)
  6279. androidMk := builder.String()
  6280. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 apex_manifest.pb.myapex apex_pubkey.myapex a b\n")
  6281. ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES := c d\n")
  6282. ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES := e f\n")
  6283. }
  6284. func TestSymlinksFromApexToSystem(t *testing.T) {
  6285. bp := `
  6286. apex {
  6287. name: "myapex",
  6288. key: "myapex.key",
  6289. native_shared_libs: ["mylib"],
  6290. java_libs: ["myjar"],
  6291. updatable: false,
  6292. }
  6293. apex {
  6294. name: "myapex.updatable",
  6295. key: "myapex.key",
  6296. native_shared_libs: ["mylib"],
  6297. java_libs: ["myjar"],
  6298. updatable: true,
  6299. min_sdk_version: "current",
  6300. }
  6301. apex_key {
  6302. name: "myapex.key",
  6303. public_key: "testkey.avbpubkey",
  6304. private_key: "testkey.pem",
  6305. }
  6306. cc_library {
  6307. name: "mylib",
  6308. srcs: ["mylib.cpp"],
  6309. shared_libs: ["myotherlib"],
  6310. system_shared_libs: [],
  6311. stl: "none",
  6312. apex_available: [
  6313. "myapex",
  6314. "myapex.updatable",
  6315. "//apex_available:platform",
  6316. ],
  6317. min_sdk_version: "current",
  6318. }
  6319. cc_library {
  6320. name: "myotherlib",
  6321. srcs: ["mylib.cpp"],
  6322. system_shared_libs: [],
  6323. stl: "none",
  6324. apex_available: [
  6325. "myapex",
  6326. "myapex.updatable",
  6327. "//apex_available:platform",
  6328. ],
  6329. min_sdk_version: "current",
  6330. }
  6331. java_library {
  6332. name: "myjar",
  6333. srcs: ["foo/bar/MyClass.java"],
  6334. sdk_version: "none",
  6335. system_modules: "none",
  6336. libs: ["myotherjar"],
  6337. apex_available: [
  6338. "myapex",
  6339. "myapex.updatable",
  6340. "//apex_available:platform",
  6341. ],
  6342. min_sdk_version: "current",
  6343. }
  6344. java_library {
  6345. name: "myotherjar",
  6346. srcs: ["foo/bar/MyClass.java"],
  6347. sdk_version: "none",
  6348. system_modules: "none",
  6349. apex_available: [
  6350. "myapex",
  6351. "myapex.updatable",
  6352. "//apex_available:platform",
  6353. ],
  6354. min_sdk_version: "current",
  6355. }
  6356. `
  6357. ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
  6358. for _, f := range files {
  6359. if f.path == file {
  6360. if f.isLink {
  6361. t.Errorf("%q is not a real file", file)
  6362. }
  6363. return
  6364. }
  6365. }
  6366. t.Errorf("%q is not found", file)
  6367. }
  6368. ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
  6369. for _, f := range files {
  6370. if f.path == file {
  6371. if !f.isLink {
  6372. t.Errorf("%q is not a symlink", file)
  6373. }
  6374. return
  6375. }
  6376. }
  6377. t.Errorf("%q is not found", file)
  6378. }
  6379. // For unbundled build, symlink shouldn't exist regardless of whether an APEX
  6380. // is updatable or not
  6381. ctx := testApex(t, bp, withUnbundledBuild)
  6382. files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
  6383. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6384. ensureRealfileExists(t, files, "lib64/mylib.so")
  6385. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  6386. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  6387. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6388. ensureRealfileExists(t, files, "lib64/mylib.so")
  6389. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  6390. // For bundled build, symlink to the system for the non-updatable APEXes only
  6391. ctx = testApex(t, bp)
  6392. files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
  6393. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6394. ensureRealfileExists(t, files, "lib64/mylib.so")
  6395. ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
  6396. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  6397. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6398. ensureRealfileExists(t, files, "lib64/mylib.so")
  6399. ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
  6400. }
  6401. func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
  6402. ctx := testApex(t, `
  6403. apex {
  6404. name: "myapex",
  6405. key: "myapex.key",
  6406. native_shared_libs: ["mylib"],
  6407. updatable: false,
  6408. }
  6409. apex_key {
  6410. name: "myapex.key",
  6411. public_key: "testkey.avbpubkey",
  6412. private_key: "testkey.pem",
  6413. }
  6414. cc_library_shared {
  6415. name: "mylib",
  6416. srcs: ["mylib.cpp"],
  6417. shared_libs: ["myotherlib"],
  6418. system_shared_libs: [],
  6419. stl: "none",
  6420. apex_available: [
  6421. "myapex",
  6422. "//apex_available:platform",
  6423. ],
  6424. }
  6425. cc_prebuilt_library_shared {
  6426. name: "myotherlib",
  6427. srcs: ["prebuilt.so"],
  6428. system_shared_libs: [],
  6429. stl: "none",
  6430. apex_available: [
  6431. "myapex",
  6432. "//apex_available:platform",
  6433. ],
  6434. }
  6435. `)
  6436. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6437. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6438. var builder strings.Builder
  6439. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  6440. androidMk := builder.String()
  6441. // `myotherlib` is added to `myapex` as symlink
  6442. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  6443. ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
  6444. ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
  6445. // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
  6446. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
  6447. }
  6448. func TestApexWithJniLibs(t *testing.T) {
  6449. ctx := testApex(t, `
  6450. apex {
  6451. name: "myapex",
  6452. key: "myapex.key",
  6453. jni_libs: ["mylib", "libfoo.rust"],
  6454. updatable: false,
  6455. }
  6456. apex_key {
  6457. name: "myapex.key",
  6458. public_key: "testkey.avbpubkey",
  6459. private_key: "testkey.pem",
  6460. }
  6461. cc_library {
  6462. name: "mylib",
  6463. srcs: ["mylib.cpp"],
  6464. shared_libs: ["mylib2"],
  6465. system_shared_libs: [],
  6466. stl: "none",
  6467. apex_available: [ "myapex" ],
  6468. }
  6469. cc_library {
  6470. name: "mylib2",
  6471. srcs: ["mylib.cpp"],
  6472. system_shared_libs: [],
  6473. stl: "none",
  6474. apex_available: [ "myapex" ],
  6475. }
  6476. rust_ffi_shared {
  6477. name: "libfoo.rust",
  6478. crate_name: "foo",
  6479. srcs: ["foo.rs"],
  6480. shared_libs: ["libfoo.shared_from_rust"],
  6481. prefer_rlib: true,
  6482. apex_available: ["myapex"],
  6483. }
  6484. cc_library_shared {
  6485. name: "libfoo.shared_from_rust",
  6486. srcs: ["mylib.cpp"],
  6487. system_shared_libs: [],
  6488. stl: "none",
  6489. stubs: {
  6490. versions: ["10", "11", "12"],
  6491. },
  6492. }
  6493. `)
  6494. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  6495. // Notice mylib2.so (transitive dep) is not added as a jni_lib
  6496. ensureEquals(t, rule.Args["opt"], "-a jniLibs libfoo.rust.so mylib.so")
  6497. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6498. "lib64/mylib.so",
  6499. "lib64/mylib2.so",
  6500. "lib64/libfoo.rust.so",
  6501. "lib64/libc++.so", // auto-added to libfoo.rust by Soong
  6502. "lib64/liblog.so", // auto-added to libfoo.rust by Soong
  6503. })
  6504. // b/220397949
  6505. ensureListContains(t, names(rule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  6506. }
  6507. func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
  6508. ctx := testApex(t, `
  6509. apex {
  6510. name: "myapex",
  6511. key: "myapex.key",
  6512. updatable: false,
  6513. }
  6514. apex_key {
  6515. name: "myapex.key",
  6516. public_key: "testkey.avbpubkey",
  6517. private_key: "testkey.pem",
  6518. }
  6519. `,
  6520. android.FixtureModifyConfig(func(config android.Config) {
  6521. delete(config.Targets, android.Android)
  6522. config.AndroidCommonTarget = android.Target{}
  6523. }),
  6524. )
  6525. if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
  6526. t.Errorf("Expected variants: %v, but got: %v", expected, got)
  6527. }
  6528. }
  6529. func TestAppBundle(t *testing.T) {
  6530. ctx := testApex(t, `
  6531. apex {
  6532. name: "myapex",
  6533. key: "myapex.key",
  6534. apps: ["AppFoo"],
  6535. updatable: false,
  6536. }
  6537. apex_key {
  6538. name: "myapex.key",
  6539. public_key: "testkey.avbpubkey",
  6540. private_key: "testkey.pem",
  6541. }
  6542. android_app {
  6543. name: "AppFoo",
  6544. srcs: ["foo/bar/MyClass.java"],
  6545. sdk_version: "none",
  6546. system_modules: "none",
  6547. apex_available: [ "myapex" ],
  6548. }
  6549. `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
  6550. bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
  6551. content := bundleConfigRule.Args["content"]
  6552. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6553. ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo@TEST.BUILD_ID/AppFoo.apk"}]}`)
  6554. }
  6555. func TestAppSetBundle(t *testing.T) {
  6556. ctx := testApex(t, `
  6557. apex {
  6558. name: "myapex",
  6559. key: "myapex.key",
  6560. apps: ["AppSet"],
  6561. updatable: false,
  6562. }
  6563. apex_key {
  6564. name: "myapex.key",
  6565. public_key: "testkey.avbpubkey",
  6566. private_key: "testkey.pem",
  6567. }
  6568. android_app_set {
  6569. name: "AppSet",
  6570. set: "AppSet.apks",
  6571. }`)
  6572. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  6573. bundleConfigRule := mod.Output("bundle_config.json")
  6574. content := bundleConfigRule.Args["content"]
  6575. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6576. s := mod.Rule("apexRule").Args["copy_commands"]
  6577. copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
  6578. if len(copyCmds) != 4 {
  6579. t.Fatalf("Expected 4 commands, got %d in:\n%s", len(copyCmds), s)
  6580. }
  6581. ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet@TEST.BUILD_ID$")
  6582. ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet@TEST.BUILD_ID$")
  6583. ensureMatches(t, copyCmds[2], "^cp -f .*/app/AppSet@TEST.BUILD_ID/AppSet.apk$")
  6584. ensureMatches(t, copyCmds[3], "^unzip .*-d .*/app/AppSet@TEST.BUILD_ID .*/AppSet.zip$")
  6585. // Ensure that canned_fs_config has an entry for the app set zip file
  6586. generateFsRule := mod.Rule("generateFsConfig")
  6587. cmd := generateFsRule.RuleParams.Command
  6588. ensureContains(t, cmd, "AppSet.zip")
  6589. }
  6590. func TestAppSetBundlePrebuilt(t *testing.T) {
  6591. bp := `
  6592. apex_set {
  6593. name: "myapex",
  6594. filename: "foo_v2.apex",
  6595. sanitized: {
  6596. none: { set: "myapex.apks", },
  6597. hwaddress: { set: "myapex.hwasan.apks", },
  6598. },
  6599. }
  6600. `
  6601. ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
  6602. // Check that the extractor produces the correct output file from the correct input file.
  6603. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
  6604. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  6605. extractedApex := m.Output(extractorOutput)
  6606. android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
  6607. // Ditto for the apex.
  6608. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  6609. copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
  6610. android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
  6611. }
  6612. func TestApexSetApksModuleAssignment(t *testing.T) {
  6613. ctx := testApex(t, `
  6614. apex_set {
  6615. name: "myapex",
  6616. set: ":myapex_apks_file",
  6617. }
  6618. filegroup {
  6619. name: "myapex_apks_file",
  6620. srcs: ["myapex.apks"],
  6621. }
  6622. `)
  6623. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  6624. // Check that the extractor produces the correct apks file from the input module
  6625. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.apks"
  6626. extractedApex := m.Output(extractorOutput)
  6627. android.AssertArrayString(t, "extractor input", []string{"myapex.apks"}, extractedApex.Inputs.Strings())
  6628. }
  6629. func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
  6630. t.Helper()
  6631. bp := `
  6632. java_library {
  6633. name: "some-updatable-apex-lib",
  6634. srcs: ["a.java"],
  6635. sdk_version: "current",
  6636. apex_available: [
  6637. "some-updatable-apex",
  6638. ],
  6639. permitted_packages: ["some.updatable.apex.lib"],
  6640. }
  6641. java_library {
  6642. name: "some-non-updatable-apex-lib",
  6643. srcs: ["a.java"],
  6644. apex_available: [
  6645. "some-non-updatable-apex",
  6646. ],
  6647. compile_dex: true,
  6648. permitted_packages: ["some.non.updatable.apex.lib"],
  6649. }
  6650. bootclasspath_fragment {
  6651. name: "some-non-updatable-fragment",
  6652. contents: ["some-non-updatable-apex-lib"],
  6653. apex_available: [
  6654. "some-non-updatable-apex",
  6655. ],
  6656. hidden_api: {
  6657. split_packages: ["*"],
  6658. },
  6659. }
  6660. java_library {
  6661. name: "some-platform-lib",
  6662. srcs: ["a.java"],
  6663. sdk_version: "current",
  6664. installable: true,
  6665. }
  6666. java_library {
  6667. name: "some-art-lib",
  6668. srcs: ["a.java"],
  6669. sdk_version: "current",
  6670. apex_available: [
  6671. "com.android.art.debug",
  6672. ],
  6673. hostdex: true,
  6674. compile_dex: true,
  6675. }
  6676. apex {
  6677. name: "some-updatable-apex",
  6678. key: "some-updatable-apex.key",
  6679. java_libs: ["some-updatable-apex-lib"],
  6680. updatable: true,
  6681. min_sdk_version: "current",
  6682. }
  6683. apex {
  6684. name: "some-non-updatable-apex",
  6685. key: "some-non-updatable-apex.key",
  6686. bootclasspath_fragments: ["some-non-updatable-fragment"],
  6687. updatable: false,
  6688. }
  6689. apex_key {
  6690. name: "some-updatable-apex.key",
  6691. }
  6692. apex_key {
  6693. name: "some-non-updatable-apex.key",
  6694. }
  6695. apex {
  6696. name: "com.android.art.debug",
  6697. key: "com.android.art.debug.key",
  6698. bootclasspath_fragments: ["art-bootclasspath-fragment"],
  6699. updatable: true,
  6700. min_sdk_version: "current",
  6701. }
  6702. bootclasspath_fragment {
  6703. name: "art-bootclasspath-fragment",
  6704. image_name: "art",
  6705. contents: ["some-art-lib"],
  6706. apex_available: [
  6707. "com.android.art.debug",
  6708. ],
  6709. hidden_api: {
  6710. split_packages: ["*"],
  6711. },
  6712. }
  6713. apex_key {
  6714. name: "com.android.art.debug.key",
  6715. }
  6716. filegroup {
  6717. name: "some-updatable-apex-file_contexts",
  6718. srcs: [
  6719. "system/sepolicy/apex/some-updatable-apex-file_contexts",
  6720. ],
  6721. }
  6722. filegroup {
  6723. name: "some-non-updatable-apex-file_contexts",
  6724. srcs: [
  6725. "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
  6726. ],
  6727. }
  6728. `
  6729. testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
  6730. }
  6731. func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
  6732. t.Helper()
  6733. fs := android.MockFS{
  6734. "a.java": nil,
  6735. "a.jar": nil,
  6736. "apex_manifest.json": nil,
  6737. "AndroidManifest.xml": nil,
  6738. "system/sepolicy/apex/myapex-file_contexts": nil,
  6739. "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
  6740. "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
  6741. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  6742. "framework/aidl/a.aidl": nil,
  6743. }
  6744. errorHandler := android.FixtureExpectsNoErrors
  6745. if errmsg != "" {
  6746. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  6747. }
  6748. result := android.GroupFixturePreparers(
  6749. cc.PrepareForTestWithCcDefaultModules,
  6750. java.PrepareForTestWithHiddenApiBuildComponents,
  6751. java.PrepareForTestWithJavaDefaultModules,
  6752. java.PrepareForTestWithJavaSdkLibraryFiles,
  6753. PrepareForTestWithApexBuildComponents,
  6754. preparer,
  6755. fs.AddToFixture(),
  6756. android.FixtureModifyMockFS(func(fs android.MockFS) {
  6757. if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
  6758. insert := ""
  6759. for _, fragment := range fragments {
  6760. insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
  6761. }
  6762. fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
  6763. platform_bootclasspath {
  6764. name: "platform-bootclasspath",
  6765. fragments: [
  6766. %s
  6767. ],
  6768. }
  6769. `, insert))
  6770. }
  6771. }),
  6772. dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
  6773. ).
  6774. ExtendWithErrorHandler(errorHandler).
  6775. RunTestWithBp(t, bp)
  6776. return result.TestContext
  6777. }
  6778. func TestDuplicateDeapexersFromPrebuiltApexes(t *testing.T) {
  6779. preparers := android.GroupFixturePreparers(
  6780. java.PrepareForTestWithJavaDefaultModules,
  6781. PrepareForTestWithApexBuildComponents,
  6782. ).
  6783. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  6784. "Multiple installable prebuilt APEXes provide ambiguous deapexers: com.android.myapex and com.mycompany.android.myapex"))
  6785. bpBase := `
  6786. apex_set {
  6787. name: "com.android.myapex",
  6788. installable: true,
  6789. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6790. set: "myapex.apks",
  6791. }
  6792. apex_set {
  6793. name: "com.mycompany.android.myapex",
  6794. apex_name: "com.android.myapex",
  6795. installable: true,
  6796. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6797. set: "company-myapex.apks",
  6798. }
  6799. prebuilt_bootclasspath_fragment {
  6800. name: "my-bootclasspath-fragment",
  6801. apex_available: ["com.android.myapex"],
  6802. %s
  6803. }
  6804. `
  6805. t.Run("java_import", func(t *testing.T) {
  6806. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6807. java_import {
  6808. name: "libfoo",
  6809. jars: ["libfoo.jar"],
  6810. apex_available: ["com.android.myapex"],
  6811. }
  6812. `)
  6813. })
  6814. t.Run("java_sdk_library_import", func(t *testing.T) {
  6815. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6816. java_sdk_library_import {
  6817. name: "libfoo",
  6818. public: {
  6819. jars: ["libbar.jar"],
  6820. },
  6821. apex_available: ["com.android.myapex"],
  6822. }
  6823. `)
  6824. })
  6825. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  6826. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  6827. image_name: "art",
  6828. contents: ["libfoo"],
  6829. `)+`
  6830. java_sdk_library_import {
  6831. name: "libfoo",
  6832. public: {
  6833. jars: ["libbar.jar"],
  6834. },
  6835. apex_available: ["com.android.myapex"],
  6836. }
  6837. `)
  6838. })
  6839. }
  6840. func TestDuplicateButEquivalentDeapexersFromPrebuiltApexes(t *testing.T) {
  6841. preparers := android.GroupFixturePreparers(
  6842. java.PrepareForTestWithJavaDefaultModules,
  6843. PrepareForTestWithApexBuildComponents,
  6844. )
  6845. bpBase := `
  6846. apex_set {
  6847. name: "com.android.myapex",
  6848. installable: true,
  6849. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6850. set: "myapex.apks",
  6851. }
  6852. apex_set {
  6853. name: "com.android.myapex_compressed",
  6854. apex_name: "com.android.myapex",
  6855. installable: true,
  6856. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6857. set: "myapex_compressed.apks",
  6858. }
  6859. prebuilt_bootclasspath_fragment {
  6860. name: "my-bootclasspath-fragment",
  6861. apex_available: [
  6862. "com.android.myapex",
  6863. "com.android.myapex_compressed",
  6864. ],
  6865. hidden_api: {
  6866. annotation_flags: "annotation-flags.csv",
  6867. metadata: "metadata.csv",
  6868. index: "index.csv",
  6869. signature_patterns: "signature_patterns.csv",
  6870. },
  6871. %s
  6872. }
  6873. `
  6874. t.Run("java_import", func(t *testing.T) {
  6875. result := preparers.RunTestWithBp(t,
  6876. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6877. java_import {
  6878. name: "libfoo",
  6879. jars: ["libfoo.jar"],
  6880. apex_available: [
  6881. "com.android.myapex",
  6882. "com.android.myapex_compressed",
  6883. ],
  6884. }
  6885. `)
  6886. module := result.Module("libfoo", "android_common_com.android.myapex")
  6887. usesLibraryDep := module.(java.UsesLibraryDependency)
  6888. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  6889. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  6890. usesLibraryDep.DexJarBuildPath().Path())
  6891. })
  6892. t.Run("java_sdk_library_import", func(t *testing.T) {
  6893. result := preparers.RunTestWithBp(t,
  6894. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6895. java_sdk_library_import {
  6896. name: "libfoo",
  6897. public: {
  6898. jars: ["libbar.jar"],
  6899. },
  6900. apex_available: [
  6901. "com.android.myapex",
  6902. "com.android.myapex_compressed",
  6903. ],
  6904. compile_dex: true,
  6905. }
  6906. `)
  6907. module := result.Module("libfoo", "android_common_com.android.myapex")
  6908. usesLibraryDep := module.(java.UsesLibraryDependency)
  6909. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  6910. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  6911. usesLibraryDep.DexJarBuildPath().Path())
  6912. })
  6913. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  6914. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  6915. image_name: "art",
  6916. contents: ["libfoo"],
  6917. `)+`
  6918. java_sdk_library_import {
  6919. name: "libfoo",
  6920. public: {
  6921. jars: ["libbar.jar"],
  6922. },
  6923. apex_available: [
  6924. "com.android.myapex",
  6925. "com.android.myapex_compressed",
  6926. ],
  6927. compile_dex: true,
  6928. }
  6929. `)
  6930. })
  6931. }
  6932. func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
  6933. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6934. apex {
  6935. name: "myapex",
  6936. key: "myapex.key",
  6937. updatable: true,
  6938. }
  6939. apex_key {
  6940. name: "myapex.key",
  6941. public_key: "testkey.avbpubkey",
  6942. private_key: "testkey.pem",
  6943. }
  6944. `)
  6945. }
  6946. func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
  6947. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6948. apex {
  6949. name: "myapex",
  6950. key: "myapex.key",
  6951. }
  6952. apex_key {
  6953. name: "myapex.key",
  6954. public_key: "testkey.avbpubkey",
  6955. private_key: "testkey.pem",
  6956. }
  6957. `)
  6958. }
  6959. func TestUpdatable_cannot_be_vendor_apex(t *testing.T) {
  6960. testApexError(t, `"myapex" .*: updatable: vendor APEXes are not updatable`, `
  6961. apex {
  6962. name: "myapex",
  6963. key: "myapex.key",
  6964. updatable: true,
  6965. soc_specific: true,
  6966. }
  6967. apex_key {
  6968. name: "myapex.key",
  6969. public_key: "testkey.avbpubkey",
  6970. private_key: "testkey.pem",
  6971. }
  6972. `)
  6973. }
  6974. func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
  6975. testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
  6976. apex {
  6977. name: "myapex",
  6978. key: "myapex.key",
  6979. systemserverclasspath_fragments: [
  6980. "mysystemserverclasspathfragment",
  6981. ],
  6982. min_sdk_version: "29",
  6983. updatable: true,
  6984. }
  6985. apex_key {
  6986. name: "myapex.key",
  6987. public_key: "testkey.avbpubkey",
  6988. private_key: "testkey.pem",
  6989. }
  6990. java_library {
  6991. name: "foo",
  6992. srcs: ["b.java"],
  6993. min_sdk_version: "29",
  6994. installable: true,
  6995. apex_available: [
  6996. "myapex",
  6997. ],
  6998. }
  6999. systemserverclasspath_fragment {
  7000. name: "mysystemserverclasspathfragment",
  7001. generate_classpaths_proto: false,
  7002. contents: [
  7003. "foo",
  7004. ],
  7005. apex_available: [
  7006. "myapex",
  7007. ],
  7008. }
  7009. `,
  7010. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7011. )
  7012. }
  7013. func TestNoUpdatableJarsInBootImage(t *testing.T) {
  7014. // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
  7015. // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
  7016. // modules to be included in the BootJars.
  7017. prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
  7018. return android.GroupFixturePreparers(
  7019. dexpreopt.FixtureSetBootJars(bootJars...),
  7020. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7021. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  7022. }),
  7023. )
  7024. }
  7025. // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
  7026. // same value. This can result in an invalid configuration as it allows non art apex jars to be
  7027. // specified in the ArtApexJars configuration.
  7028. prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
  7029. return android.GroupFixturePreparers(
  7030. dexpreopt.FixtureSetArtBootJars(bootJars...),
  7031. dexpreopt.FixtureSetBootJars(bootJars...),
  7032. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7033. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  7034. }),
  7035. )
  7036. }
  7037. t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
  7038. preparer := android.GroupFixturePreparers(
  7039. java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"),
  7040. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7041. )
  7042. fragments := []java.ApexVariantReference{
  7043. {
  7044. Apex: proptools.StringPtr("com.android.art.debug"),
  7045. Module: proptools.StringPtr("art-bootclasspath-fragment"),
  7046. },
  7047. {
  7048. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7049. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7050. },
  7051. }
  7052. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  7053. })
  7054. t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
  7055. err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
  7056. // Update the dexpreopt BootJars directly.
  7057. preparer := android.GroupFixturePreparers(
  7058. prepareSetBootJars("com.android.art.debug:some-art-lib"),
  7059. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7060. )
  7061. testNoUpdatableJarsInBootImage(t, err, preparer)
  7062. })
  7063. t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  7064. err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  7065. // Update the dexpreopt ArtApexJars directly.
  7066. preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
  7067. testNoUpdatableJarsInBootImage(t, err, preparer)
  7068. })
  7069. t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  7070. err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  7071. // Update the dexpreopt ArtApexJars directly.
  7072. preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  7073. testNoUpdatableJarsInBootImage(t, err, preparer)
  7074. })
  7075. t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
  7076. err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
  7077. preparer := android.GroupFixturePreparers(
  7078. java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"),
  7079. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7080. )
  7081. testNoUpdatableJarsInBootImage(t, err, preparer)
  7082. })
  7083. t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
  7084. preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  7085. fragment := java.ApexVariantReference{
  7086. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7087. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7088. }
  7089. testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
  7090. })
  7091. t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
  7092. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  7093. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  7094. testNoUpdatableJarsInBootImage(t, err, preparer)
  7095. })
  7096. t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
  7097. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  7098. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  7099. testNoUpdatableJarsInBootImage(t, err, preparer)
  7100. })
  7101. t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
  7102. err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
  7103. // Update the dexpreopt ArtApexJars directly.
  7104. preparer := prepareSetArtJars("platform:some-platform-lib")
  7105. testNoUpdatableJarsInBootImage(t, err, preparer)
  7106. })
  7107. t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
  7108. preparer := android.GroupFixturePreparers(
  7109. java.FixtureConfigureBootJars("platform:some-platform-lib"),
  7110. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  7111. )
  7112. fragments := []java.ApexVariantReference{
  7113. {
  7114. Apex: proptools.StringPtr("some-non-updatable-apex"),
  7115. Module: proptools.StringPtr("some-non-updatable-fragment"),
  7116. },
  7117. }
  7118. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  7119. })
  7120. }
  7121. func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
  7122. preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
  7123. t.Run("prebuilt no source", func(t *testing.T) {
  7124. fragment := java.ApexVariantReference{
  7125. Apex: proptools.StringPtr("myapex"),
  7126. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  7127. }
  7128. testDexpreoptWithApexes(t, `
  7129. prebuilt_apex {
  7130. name: "myapex" ,
  7131. arch: {
  7132. arm64: {
  7133. src: "myapex-arm64.apex",
  7134. },
  7135. arm: {
  7136. src: "myapex-arm.apex",
  7137. },
  7138. },
  7139. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  7140. }
  7141. prebuilt_bootclasspath_fragment {
  7142. name: "my-bootclasspath-fragment",
  7143. contents: ["libfoo"],
  7144. apex_available: ["myapex"],
  7145. hidden_api: {
  7146. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  7147. metadata: "my-bootclasspath-fragment/metadata.csv",
  7148. index: "my-bootclasspath-fragment/index.csv",
  7149. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  7150. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  7151. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  7152. },
  7153. }
  7154. java_import {
  7155. name: "libfoo",
  7156. jars: ["libfoo.jar"],
  7157. apex_available: ["myapex"],
  7158. permitted_packages: ["libfoo"],
  7159. }
  7160. `, "", preparer, fragment)
  7161. })
  7162. }
  7163. func testBootJarPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
  7164. t.Helper()
  7165. bp += `
  7166. apex_key {
  7167. name: "myapex.key",
  7168. public_key: "testkey.avbpubkey",
  7169. private_key: "testkey.pem",
  7170. }`
  7171. fs := android.MockFS{
  7172. "lib1/src/A.java": nil,
  7173. "lib2/src/B.java": nil,
  7174. "system/sepolicy/apex/myapex-file_contexts": nil,
  7175. }
  7176. errorHandler := android.FixtureExpectsNoErrors
  7177. if errmsg != "" {
  7178. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  7179. }
  7180. android.GroupFixturePreparers(
  7181. android.PrepareForTestWithAndroidBuildComponents,
  7182. java.PrepareForTestWithJavaBuildComponents,
  7183. PrepareForTestWithApexBuildComponents,
  7184. android.PrepareForTestWithNeverallowRules(rules),
  7185. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7186. apexBootJars := make([]string, 0, len(bootJars))
  7187. for _, apexBootJar := range bootJars {
  7188. apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
  7189. }
  7190. variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
  7191. }),
  7192. fs.AddToFixture(),
  7193. ).
  7194. ExtendWithErrorHandler(errorHandler).
  7195. RunTestWithBp(t, bp)
  7196. }
  7197. func TestApexPermittedPackagesRules(t *testing.T) {
  7198. testcases := []struct {
  7199. name string
  7200. expectedError string
  7201. bp string
  7202. bootJars []string
  7203. bcpPermittedPackages map[string][]string
  7204. }{
  7205. {
  7206. name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
  7207. expectedError: "",
  7208. bp: `
  7209. java_library {
  7210. name: "bcp_lib1",
  7211. srcs: ["lib1/src/*.java"],
  7212. permitted_packages: ["foo.bar"],
  7213. apex_available: ["myapex"],
  7214. sdk_version: "none",
  7215. system_modules: "none",
  7216. }
  7217. java_library {
  7218. name: "nonbcp_lib2",
  7219. srcs: ["lib2/src/*.java"],
  7220. apex_available: ["myapex"],
  7221. permitted_packages: ["a.b"],
  7222. sdk_version: "none",
  7223. system_modules: "none",
  7224. }
  7225. apex {
  7226. name: "myapex",
  7227. key: "myapex.key",
  7228. java_libs: ["bcp_lib1", "nonbcp_lib2"],
  7229. updatable: false,
  7230. }`,
  7231. bootJars: []string{"bcp_lib1"},
  7232. bcpPermittedPackages: map[string][]string{
  7233. "bcp_lib1": []string{
  7234. "foo.bar",
  7235. },
  7236. },
  7237. },
  7238. {
  7239. name: "Bootclasspath apex jar not satisfying allowed module packages.",
  7240. expectedError: `(?s)module "bcp_lib2" .* which is restricted because bcp_lib2 bootjar may only use these package prefixes: foo.bar. Please consider the following alternatives:\n 1. If the offending code is from a statically linked library, consider removing that dependency and using an alternative already in the bootclasspath, or perhaps a shared library. 2. Move the offending code into an allowed package.\n 3. Jarjar the offending code. Please be mindful of the potential system health implications of bundling that code, particularly if the offending jar is part of the bootclasspath.`,
  7241. bp: `
  7242. java_library {
  7243. name: "bcp_lib1",
  7244. srcs: ["lib1/src/*.java"],
  7245. apex_available: ["myapex"],
  7246. permitted_packages: ["foo.bar"],
  7247. sdk_version: "none",
  7248. system_modules: "none",
  7249. }
  7250. java_library {
  7251. name: "bcp_lib2",
  7252. srcs: ["lib2/src/*.java"],
  7253. apex_available: ["myapex"],
  7254. permitted_packages: ["foo.bar", "bar.baz"],
  7255. sdk_version: "none",
  7256. system_modules: "none",
  7257. }
  7258. apex {
  7259. name: "myapex",
  7260. key: "myapex.key",
  7261. java_libs: ["bcp_lib1", "bcp_lib2"],
  7262. updatable: false,
  7263. }
  7264. `,
  7265. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7266. bcpPermittedPackages: map[string][]string{
  7267. "bcp_lib1": []string{
  7268. "foo.bar",
  7269. },
  7270. "bcp_lib2": []string{
  7271. "foo.bar",
  7272. },
  7273. },
  7274. },
  7275. {
  7276. name: "Updateable Bootclasspath apex jar not satisfying allowed module packages.",
  7277. expectedError: "",
  7278. bp: `
  7279. java_library {
  7280. name: "bcp_lib_restricted",
  7281. srcs: ["lib1/src/*.java"],
  7282. apex_available: ["myapex"],
  7283. permitted_packages: ["foo.bar"],
  7284. sdk_version: "none",
  7285. min_sdk_version: "29",
  7286. system_modules: "none",
  7287. }
  7288. java_library {
  7289. name: "bcp_lib_unrestricted",
  7290. srcs: ["lib2/src/*.java"],
  7291. apex_available: ["myapex"],
  7292. permitted_packages: ["foo.bar", "bar.baz"],
  7293. sdk_version: "none",
  7294. min_sdk_version: "29",
  7295. system_modules: "none",
  7296. }
  7297. apex {
  7298. name: "myapex",
  7299. key: "myapex.key",
  7300. java_libs: ["bcp_lib_restricted", "bcp_lib_unrestricted"],
  7301. updatable: true,
  7302. min_sdk_version: "29",
  7303. }
  7304. `,
  7305. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7306. bcpPermittedPackages: map[string][]string{
  7307. "bcp_lib1_non_updateable": []string{
  7308. "foo.bar",
  7309. },
  7310. // bcp_lib2_updateable has no entry here since updateable bcp can contain new packages - tracking via an allowlist is not necessary
  7311. },
  7312. },
  7313. }
  7314. for _, tc := range testcases {
  7315. t.Run(tc.name, func(t *testing.T) {
  7316. rules := createBcpPermittedPackagesRules(tc.bcpPermittedPackages)
  7317. testBootJarPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
  7318. })
  7319. }
  7320. }
  7321. func TestTestFor(t *testing.T) {
  7322. ctx := testApex(t, `
  7323. apex {
  7324. name: "myapex",
  7325. key: "myapex.key",
  7326. native_shared_libs: ["mylib", "myprivlib"],
  7327. updatable: false,
  7328. }
  7329. apex_key {
  7330. name: "myapex.key",
  7331. public_key: "testkey.avbpubkey",
  7332. private_key: "testkey.pem",
  7333. }
  7334. cc_library {
  7335. name: "mylib",
  7336. srcs: ["mylib.cpp"],
  7337. system_shared_libs: [],
  7338. stl: "none",
  7339. stubs: {
  7340. versions: ["1"],
  7341. },
  7342. apex_available: ["myapex"],
  7343. }
  7344. cc_library {
  7345. name: "myprivlib",
  7346. srcs: ["mylib.cpp"],
  7347. system_shared_libs: [],
  7348. stl: "none",
  7349. apex_available: ["myapex"],
  7350. }
  7351. cc_test {
  7352. name: "mytest",
  7353. gtest: false,
  7354. srcs: ["mylib.cpp"],
  7355. system_shared_libs: [],
  7356. stl: "none",
  7357. shared_libs: ["mylib", "myprivlib", "mytestlib"],
  7358. test_for: ["myapex"]
  7359. }
  7360. cc_library {
  7361. name: "mytestlib",
  7362. srcs: ["mylib.cpp"],
  7363. system_shared_libs: [],
  7364. shared_libs: ["mylib", "myprivlib"],
  7365. stl: "none",
  7366. test_for: ["myapex"],
  7367. }
  7368. cc_benchmark {
  7369. name: "mybench",
  7370. srcs: ["mylib.cpp"],
  7371. system_shared_libs: [],
  7372. shared_libs: ["mylib", "myprivlib"],
  7373. stl: "none",
  7374. test_for: ["myapex"],
  7375. }
  7376. `)
  7377. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  7378. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  7379. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  7380. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  7381. }
  7382. // These modules are tests for the apex, therefore are linked to the
  7383. // actual implementation of mylib instead of its stub.
  7384. ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7385. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7386. ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7387. }
  7388. func TestIndirectTestFor(t *testing.T) {
  7389. ctx := testApex(t, `
  7390. apex {
  7391. name: "myapex",
  7392. key: "myapex.key",
  7393. native_shared_libs: ["mylib", "myprivlib"],
  7394. updatable: false,
  7395. }
  7396. apex_key {
  7397. name: "myapex.key",
  7398. public_key: "testkey.avbpubkey",
  7399. private_key: "testkey.pem",
  7400. }
  7401. cc_library {
  7402. name: "mylib",
  7403. srcs: ["mylib.cpp"],
  7404. system_shared_libs: [],
  7405. stl: "none",
  7406. stubs: {
  7407. versions: ["1"],
  7408. },
  7409. apex_available: ["myapex"],
  7410. }
  7411. cc_library {
  7412. name: "myprivlib",
  7413. srcs: ["mylib.cpp"],
  7414. system_shared_libs: [],
  7415. stl: "none",
  7416. shared_libs: ["mylib"],
  7417. apex_available: ["myapex"],
  7418. }
  7419. cc_library {
  7420. name: "mytestlib",
  7421. srcs: ["mylib.cpp"],
  7422. system_shared_libs: [],
  7423. shared_libs: ["myprivlib"],
  7424. stl: "none",
  7425. test_for: ["myapex"],
  7426. }
  7427. `)
  7428. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  7429. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  7430. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  7431. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  7432. }
  7433. // The platform variant of mytestlib links to the platform variant of the
  7434. // internal myprivlib.
  7435. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
  7436. // The platform variant of myprivlib links to the platform variant of mylib
  7437. // and bypasses its stubs.
  7438. ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7439. }
  7440. func TestTestForForLibInOtherApex(t *testing.T) {
  7441. // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
  7442. _ = testApex(t, `
  7443. apex {
  7444. name: "com.android.art",
  7445. key: "myapex.key",
  7446. native_shared_libs: ["mylib"],
  7447. updatable: false,
  7448. }
  7449. apex {
  7450. name: "com.android.art.debug",
  7451. key: "myapex.key",
  7452. native_shared_libs: ["mylib", "mytestlib"],
  7453. updatable: false,
  7454. }
  7455. apex_key {
  7456. name: "myapex.key",
  7457. public_key: "testkey.avbpubkey",
  7458. private_key: "testkey.pem",
  7459. }
  7460. cc_library {
  7461. name: "mylib",
  7462. srcs: ["mylib.cpp"],
  7463. system_shared_libs: [],
  7464. stl: "none",
  7465. stubs: {
  7466. versions: ["1"],
  7467. },
  7468. apex_available: ["com.android.art", "com.android.art.debug"],
  7469. }
  7470. cc_library {
  7471. name: "mytestlib",
  7472. srcs: ["mylib.cpp"],
  7473. system_shared_libs: [],
  7474. shared_libs: ["mylib"],
  7475. stl: "none",
  7476. apex_available: ["com.android.art.debug"],
  7477. test_for: ["com.android.art"],
  7478. }
  7479. `,
  7480. android.MockFS{
  7481. "system/sepolicy/apex/com.android.art-file_contexts": nil,
  7482. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  7483. }.AddToFixture())
  7484. }
  7485. // TODO(jungjw): Move this to proptools
  7486. func intPtr(i int) *int {
  7487. return &i
  7488. }
  7489. func TestApexSet(t *testing.T) {
  7490. ctx := testApex(t, `
  7491. apex_set {
  7492. name: "myapex",
  7493. set: "myapex.apks",
  7494. filename: "foo_v2.apex",
  7495. overrides: ["foo"],
  7496. }
  7497. `,
  7498. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7499. variables.Platform_sdk_version = intPtr(30)
  7500. }),
  7501. android.FixtureModifyConfig(func(config android.Config) {
  7502. config.Targets[android.Android] = []android.Target{
  7503. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
  7504. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
  7505. }
  7506. }),
  7507. )
  7508. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  7509. // Check extract_apks tool parameters.
  7510. extractedApex := m.Output("extracted/myapex.apks")
  7511. actual := extractedApex.Args["abis"]
  7512. expected := "ARMEABI_V7A,ARM64_V8A"
  7513. if actual != expected {
  7514. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  7515. }
  7516. actual = extractedApex.Args["sdk-version"]
  7517. expected = "30"
  7518. if actual != expected {
  7519. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  7520. }
  7521. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  7522. a := m.Module().(*ApexSet)
  7523. expectedOverrides := []string{"foo"}
  7524. actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  7525. if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
  7526. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
  7527. }
  7528. }
  7529. func TestApexSet_NativeBridge(t *testing.T) {
  7530. ctx := testApex(t, `
  7531. apex_set {
  7532. name: "myapex",
  7533. set: "myapex.apks",
  7534. filename: "foo_v2.apex",
  7535. overrides: ["foo"],
  7536. }
  7537. `,
  7538. android.FixtureModifyConfig(func(config android.Config) {
  7539. config.Targets[android.Android] = []android.Target{
  7540. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "", Abi: []string{"x86_64"}}},
  7541. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}, NativeBridge: android.NativeBridgeEnabled},
  7542. }
  7543. }),
  7544. )
  7545. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  7546. // Check extract_apks tool parameters. No native bridge arch expected
  7547. extractedApex := m.Output("extracted/myapex.apks")
  7548. android.AssertStringEquals(t, "abis", "X86_64", extractedApex.Args["abis"])
  7549. }
  7550. func TestNoStaticLinkingToStubsLib(t *testing.T) {
  7551. testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
  7552. apex {
  7553. name: "myapex",
  7554. key: "myapex.key",
  7555. native_shared_libs: ["mylib"],
  7556. updatable: false,
  7557. }
  7558. apex_key {
  7559. name: "myapex.key",
  7560. public_key: "testkey.avbpubkey",
  7561. private_key: "testkey.pem",
  7562. }
  7563. cc_library {
  7564. name: "mylib",
  7565. srcs: ["mylib.cpp"],
  7566. static_libs: ["otherlib"],
  7567. system_shared_libs: [],
  7568. stl: "none",
  7569. apex_available: [ "myapex" ],
  7570. }
  7571. cc_library {
  7572. name: "otherlib",
  7573. srcs: ["mylib.cpp"],
  7574. system_shared_libs: [],
  7575. stl: "none",
  7576. stubs: {
  7577. versions: ["1", "2", "3"],
  7578. },
  7579. apex_available: [ "myapex" ],
  7580. }
  7581. `)
  7582. }
  7583. func TestApexKeysTxt(t *testing.T) {
  7584. ctx := testApex(t, `
  7585. apex {
  7586. name: "myapex",
  7587. key: "myapex.key",
  7588. updatable: false,
  7589. custom_sign_tool: "sign_myapex",
  7590. }
  7591. apex_key {
  7592. name: "myapex.key",
  7593. public_key: "testkey.avbpubkey",
  7594. private_key: "testkey.pem",
  7595. }
  7596. `)
  7597. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7598. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7599. ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system_ext" sign_tool="sign_myapex"`)
  7600. }
  7601. func TestApexKeysTxtOverrides(t *testing.T) {
  7602. ctx := testApex(t, `
  7603. apex {
  7604. name: "myapex",
  7605. key: "myapex.key",
  7606. updatable: false,
  7607. custom_sign_tool: "sign_myapex",
  7608. }
  7609. apex_key {
  7610. name: "myapex.key",
  7611. public_key: "testkey.avbpubkey",
  7612. private_key: "testkey.pem",
  7613. }
  7614. prebuilt_apex {
  7615. name: "myapex",
  7616. prefer: true,
  7617. arch: {
  7618. arm64: {
  7619. src: "myapex-arm64.apex",
  7620. },
  7621. arm: {
  7622. src: "myapex-arm.apex",
  7623. },
  7624. },
  7625. }
  7626. apex_set {
  7627. name: "myapex_set",
  7628. set: "myapex.apks",
  7629. filename: "myapex_set.apex",
  7630. overrides: ["myapex"],
  7631. }
  7632. `)
  7633. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7634. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7635. ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7636. ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7637. }
  7638. func TestAllowedFiles(t *testing.T) {
  7639. ctx := testApex(t, `
  7640. apex {
  7641. name: "myapex",
  7642. key: "myapex.key",
  7643. apps: ["app"],
  7644. allowed_files: "allowed.txt",
  7645. updatable: false,
  7646. }
  7647. apex_key {
  7648. name: "myapex.key",
  7649. public_key: "testkey.avbpubkey",
  7650. private_key: "testkey.pem",
  7651. }
  7652. android_app {
  7653. name: "app",
  7654. srcs: ["foo/bar/MyClass.java"],
  7655. package_name: "foo",
  7656. sdk_version: "none",
  7657. system_modules: "none",
  7658. apex_available: [ "myapex" ],
  7659. }
  7660. `, withFiles(map[string][]byte{
  7661. "sub/Android.bp": []byte(`
  7662. override_apex {
  7663. name: "override_myapex",
  7664. base: "myapex",
  7665. apps: ["override_app"],
  7666. allowed_files: ":allowed",
  7667. }
  7668. // Overridable "path" property should be referenced indirectly
  7669. filegroup {
  7670. name: "allowed",
  7671. srcs: ["allowed.txt"],
  7672. }
  7673. override_android_app {
  7674. name: "override_app",
  7675. base: "app",
  7676. package_name: "bar",
  7677. }
  7678. `),
  7679. }))
  7680. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
  7681. if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
  7682. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7683. }
  7684. rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
  7685. if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
  7686. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7687. }
  7688. }
  7689. func TestNonPreferredPrebuiltDependency(t *testing.T) {
  7690. testApex(t, `
  7691. apex {
  7692. name: "myapex",
  7693. key: "myapex.key",
  7694. native_shared_libs: ["mylib"],
  7695. updatable: false,
  7696. }
  7697. apex_key {
  7698. name: "myapex.key",
  7699. public_key: "testkey.avbpubkey",
  7700. private_key: "testkey.pem",
  7701. }
  7702. cc_library {
  7703. name: "mylib",
  7704. srcs: ["mylib.cpp"],
  7705. stubs: {
  7706. versions: ["current"],
  7707. },
  7708. apex_available: ["myapex"],
  7709. }
  7710. cc_prebuilt_library_shared {
  7711. name: "mylib",
  7712. prefer: false,
  7713. srcs: ["prebuilt.so"],
  7714. stubs: {
  7715. versions: ["current"],
  7716. },
  7717. apex_available: ["myapex"],
  7718. }
  7719. `)
  7720. }
  7721. func TestCompressedApex(t *testing.T) {
  7722. ctx := testApex(t, `
  7723. apex {
  7724. name: "myapex",
  7725. key: "myapex.key",
  7726. compressible: true,
  7727. updatable: false,
  7728. }
  7729. apex_key {
  7730. name: "myapex.key",
  7731. public_key: "testkey.avbpubkey",
  7732. private_key: "testkey.pem",
  7733. }
  7734. `,
  7735. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7736. variables.CompressedApex = proptools.BoolPtr(true)
  7737. }),
  7738. )
  7739. compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
  7740. ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
  7741. signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
  7742. ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
  7743. // Make sure output of bundle is .capex
  7744. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7745. ensureContains(t, ab.outputFile.String(), "myapex.capex")
  7746. // Verify android.mk rules
  7747. data := android.AndroidMkDataForTest(t, ctx, ab)
  7748. var builder strings.Builder
  7749. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7750. androidMk := builder.String()
  7751. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
  7752. }
  7753. func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
  7754. ctx := testApex(t, `
  7755. apex {
  7756. name: "myapex",
  7757. key: "myapex.key",
  7758. native_shared_libs: ["mylib"],
  7759. updatable: false,
  7760. }
  7761. apex_key {
  7762. name: "myapex.key",
  7763. public_key: "testkey.avbpubkey",
  7764. private_key: "testkey.pem",
  7765. }
  7766. cc_library {
  7767. name: "mylib",
  7768. srcs: ["mylib.cpp"],
  7769. apex_available: ["myapex"],
  7770. shared_libs: ["otherlib"],
  7771. system_shared_libs: [],
  7772. }
  7773. cc_library {
  7774. name: "otherlib",
  7775. srcs: ["mylib.cpp"],
  7776. stubs: {
  7777. versions: ["current"],
  7778. },
  7779. }
  7780. cc_prebuilt_library_shared {
  7781. name: "otherlib",
  7782. prefer: true,
  7783. srcs: ["prebuilt.so"],
  7784. stubs: {
  7785. versions: ["current"],
  7786. },
  7787. }
  7788. `)
  7789. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7790. data := android.AndroidMkDataForTest(t, ctx, ab)
  7791. var builder strings.Builder
  7792. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7793. androidMk := builder.String()
  7794. // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
  7795. // a thing there.
  7796. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := libc++:64 mylib.myapex:64 apex_manifest.pb.myapex apex_pubkey.myapex otherlib\n")
  7797. }
  7798. func TestExcludeDependency(t *testing.T) {
  7799. ctx := testApex(t, `
  7800. apex {
  7801. name: "myapex",
  7802. key: "myapex.key",
  7803. native_shared_libs: ["mylib"],
  7804. updatable: false,
  7805. }
  7806. apex_key {
  7807. name: "myapex.key",
  7808. public_key: "testkey.avbpubkey",
  7809. private_key: "testkey.pem",
  7810. }
  7811. cc_library {
  7812. name: "mylib",
  7813. srcs: ["mylib.cpp"],
  7814. system_shared_libs: [],
  7815. stl: "none",
  7816. apex_available: ["myapex"],
  7817. shared_libs: ["mylib2"],
  7818. target: {
  7819. apex: {
  7820. exclude_shared_libs: ["mylib2"],
  7821. },
  7822. },
  7823. }
  7824. cc_library {
  7825. name: "mylib2",
  7826. srcs: ["mylib.cpp"],
  7827. system_shared_libs: [],
  7828. stl: "none",
  7829. }
  7830. `)
  7831. // Check if mylib is linked to mylib2 for the non-apex target
  7832. ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  7833. ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  7834. // Make sure that the link doesn't occur for the apex target
  7835. ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  7836. ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
  7837. // It shouldn't appear in the copy cmd as well.
  7838. copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
  7839. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  7840. }
  7841. func TestPrebuiltStubLibDep(t *testing.T) {
  7842. bpBase := `
  7843. apex {
  7844. name: "myapex",
  7845. key: "myapex.key",
  7846. native_shared_libs: ["mylib"],
  7847. updatable: false,
  7848. }
  7849. apex_key {
  7850. name: "myapex.key",
  7851. public_key: "testkey.avbpubkey",
  7852. private_key: "testkey.pem",
  7853. }
  7854. cc_library {
  7855. name: "mylib",
  7856. srcs: ["mylib.cpp"],
  7857. apex_available: ["myapex"],
  7858. shared_libs: ["stublib"],
  7859. system_shared_libs: [],
  7860. }
  7861. apex {
  7862. name: "otherapex",
  7863. enabled: %s,
  7864. key: "myapex.key",
  7865. native_shared_libs: ["stublib"],
  7866. updatable: false,
  7867. }
  7868. `
  7869. stublibSourceBp := `
  7870. cc_library {
  7871. name: "stublib",
  7872. srcs: ["mylib.cpp"],
  7873. apex_available: ["otherapex"],
  7874. system_shared_libs: [],
  7875. stl: "none",
  7876. stubs: {
  7877. versions: ["1"],
  7878. },
  7879. }
  7880. `
  7881. stublibPrebuiltBp := `
  7882. cc_prebuilt_library_shared {
  7883. name: "stublib",
  7884. srcs: ["prebuilt.so"],
  7885. apex_available: ["otherapex"],
  7886. stubs: {
  7887. versions: ["1"],
  7888. },
  7889. %s
  7890. }
  7891. `
  7892. tests := []struct {
  7893. name string
  7894. stublibBp string
  7895. usePrebuilt bool
  7896. modNames []string // Modules to collect AndroidMkEntries for
  7897. otherApexEnabled []string
  7898. }{
  7899. {
  7900. name: "only_source",
  7901. stublibBp: stublibSourceBp,
  7902. usePrebuilt: false,
  7903. modNames: []string{"stublib"},
  7904. otherApexEnabled: []string{"true", "false"},
  7905. },
  7906. {
  7907. name: "source_preferred",
  7908. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
  7909. usePrebuilt: false,
  7910. modNames: []string{"stublib", "prebuilt_stublib"},
  7911. otherApexEnabled: []string{"true", "false"},
  7912. },
  7913. {
  7914. name: "prebuilt_preferred",
  7915. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
  7916. usePrebuilt: true,
  7917. modNames: []string{"stublib", "prebuilt_stublib"},
  7918. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7919. },
  7920. {
  7921. name: "only_prebuilt",
  7922. stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
  7923. usePrebuilt: true,
  7924. modNames: []string{"stublib"},
  7925. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7926. },
  7927. }
  7928. for _, test := range tests {
  7929. t.Run(test.name, func(t *testing.T) {
  7930. for _, otherApexEnabled := range test.otherApexEnabled {
  7931. t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
  7932. ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
  7933. type modAndMkEntries struct {
  7934. mod *cc.Module
  7935. mkEntries android.AndroidMkEntries
  7936. }
  7937. entries := []*modAndMkEntries{}
  7938. // Gather shared lib modules that are installable
  7939. for _, modName := range test.modNames {
  7940. for _, variant := range ctx.ModuleVariantsForTests(modName) {
  7941. if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
  7942. continue
  7943. }
  7944. mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
  7945. if !mod.Enabled() || mod.IsHideFromMake() {
  7946. continue
  7947. }
  7948. for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
  7949. if ent.Disabled {
  7950. continue
  7951. }
  7952. entries = append(entries, &modAndMkEntries{
  7953. mod: mod,
  7954. mkEntries: ent,
  7955. })
  7956. }
  7957. }
  7958. }
  7959. var entry *modAndMkEntries = nil
  7960. for _, ent := range entries {
  7961. if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
  7962. if entry != nil {
  7963. t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
  7964. } else {
  7965. entry = ent
  7966. }
  7967. }
  7968. }
  7969. if entry == nil {
  7970. t.Errorf("AndroidMk entry for \"stublib\" missing")
  7971. } else {
  7972. isPrebuilt := entry.mod.Prebuilt() != nil
  7973. if isPrebuilt != test.usePrebuilt {
  7974. t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
  7975. }
  7976. if !entry.mod.IsStubs() {
  7977. t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
  7978. }
  7979. if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
  7980. t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
  7981. }
  7982. cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  7983. expected := "-D__STUBLIB_API__=10000"
  7984. if !android.InList(expected, cflags) {
  7985. t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
  7986. }
  7987. }
  7988. })
  7989. }
  7990. })
  7991. }
  7992. }
  7993. func TestHostApexInHostOnlyBuild(t *testing.T) {
  7994. testApex(t, `
  7995. apex {
  7996. name: "myapex",
  7997. host_supported: true,
  7998. key: "myapex.key",
  7999. updatable: false,
  8000. payload_type: "zip",
  8001. }
  8002. apex_key {
  8003. name: "myapex.key",
  8004. public_key: "testkey.avbpubkey",
  8005. private_key: "testkey.pem",
  8006. }
  8007. `,
  8008. android.FixtureModifyConfig(func(config android.Config) {
  8009. // We may not have device targets in all builds, e.g. in
  8010. // prebuilts/build-tools/build-prebuilts.sh
  8011. config.Targets[android.Android] = []android.Target{}
  8012. }))
  8013. }
  8014. func TestApexJavaCoverage(t *testing.T) {
  8015. bp := `
  8016. apex {
  8017. name: "myapex",
  8018. key: "myapex.key",
  8019. java_libs: ["mylib"],
  8020. bootclasspath_fragments: ["mybootclasspathfragment"],
  8021. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8022. updatable: false,
  8023. }
  8024. apex_key {
  8025. name: "myapex.key",
  8026. public_key: "testkey.avbpubkey",
  8027. private_key: "testkey.pem",
  8028. }
  8029. java_library {
  8030. name: "mylib",
  8031. srcs: ["mylib.java"],
  8032. apex_available: ["myapex"],
  8033. compile_dex: true,
  8034. }
  8035. bootclasspath_fragment {
  8036. name: "mybootclasspathfragment",
  8037. contents: ["mybootclasspathlib"],
  8038. apex_available: ["myapex"],
  8039. hidden_api: {
  8040. split_packages: ["*"],
  8041. },
  8042. }
  8043. java_library {
  8044. name: "mybootclasspathlib",
  8045. srcs: ["mybootclasspathlib.java"],
  8046. apex_available: ["myapex"],
  8047. compile_dex: true,
  8048. }
  8049. systemserverclasspath_fragment {
  8050. name: "mysystemserverclasspathfragment",
  8051. contents: ["mysystemserverclasspathlib"],
  8052. apex_available: ["myapex"],
  8053. }
  8054. java_library {
  8055. name: "mysystemserverclasspathlib",
  8056. srcs: ["mysystemserverclasspathlib.java"],
  8057. apex_available: ["myapex"],
  8058. compile_dex: true,
  8059. }
  8060. `
  8061. result := android.GroupFixturePreparers(
  8062. PrepareForTestWithApexBuildComponents,
  8063. prepareForTestWithMyapex,
  8064. java.PrepareForTestWithJavaDefaultModules,
  8065. android.PrepareForTestWithAndroidBuildComponents,
  8066. android.FixtureWithRootAndroidBp(bp),
  8067. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  8068. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  8069. java.PrepareForTestWithJacocoInstrumentation,
  8070. ).RunTest(t)
  8071. // Make sure jacoco ran on both mylib and mybootclasspathlib
  8072. if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8073. t.Errorf("Failed to find jacoco rule for mylib")
  8074. }
  8075. if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8076. t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
  8077. }
  8078. if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  8079. t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
  8080. }
  8081. }
  8082. func TestProhibitStaticExecutable(t *testing.T) {
  8083. testApexError(t, `executable mybin is static`, `
  8084. apex {
  8085. name: "myapex",
  8086. key: "myapex.key",
  8087. binaries: ["mybin"],
  8088. min_sdk_version: "29",
  8089. }
  8090. apex_key {
  8091. name: "myapex.key",
  8092. public_key: "testkey.avbpubkey",
  8093. private_key: "testkey.pem",
  8094. }
  8095. cc_binary {
  8096. name: "mybin",
  8097. srcs: ["mylib.cpp"],
  8098. relative_install_path: "foo/bar",
  8099. static_executable: true,
  8100. system_shared_libs: [],
  8101. stl: "none",
  8102. apex_available: [ "myapex" ],
  8103. min_sdk_version: "29",
  8104. }
  8105. `)
  8106. testApexError(t, `executable mybin.rust is static`, `
  8107. apex {
  8108. name: "myapex",
  8109. key: "myapex.key",
  8110. binaries: ["mybin.rust"],
  8111. min_sdk_version: "29",
  8112. }
  8113. apex_key {
  8114. name: "myapex.key",
  8115. public_key: "testkey.avbpubkey",
  8116. private_key: "testkey.pem",
  8117. }
  8118. rust_binary {
  8119. name: "mybin.rust",
  8120. srcs: ["foo.rs"],
  8121. static_executable: true,
  8122. apex_available: ["myapex"],
  8123. min_sdk_version: "29",
  8124. }
  8125. `)
  8126. }
  8127. func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
  8128. ctx := testApex(t, `
  8129. apex {
  8130. name: "myapex",
  8131. key: "myapex.key",
  8132. updatable: false,
  8133. java_libs: ["foo"],
  8134. }
  8135. apex_key {
  8136. name: "myapex.key",
  8137. public_key: "testkey.avbpubkey",
  8138. private_key: "testkey.pem",
  8139. }
  8140. java_library {
  8141. name: "foo",
  8142. srcs: ["foo.java"],
  8143. apex_available: ["myapex"],
  8144. installable: true,
  8145. }
  8146. `,
  8147. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  8148. )
  8149. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8150. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  8151. var builder strings.Builder
  8152. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  8153. androidMk := builder.String()
  8154. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex apex_manifest.pb.myapex apex_pubkey.myapex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex\n")
  8155. }
  8156. func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
  8157. ctx := testApex(t, `
  8158. prebuilt_apex {
  8159. name: "myapex",
  8160. arch: {
  8161. arm64: {
  8162. src: "myapex-arm64.apex",
  8163. },
  8164. arm: {
  8165. src: "myapex-arm.apex",
  8166. },
  8167. },
  8168. exported_java_libs: ["foo"],
  8169. }
  8170. java_import {
  8171. name: "foo",
  8172. jars: ["foo.jar"],
  8173. apex_available: ["myapex"],
  8174. }
  8175. `,
  8176. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  8177. )
  8178. prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  8179. entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
  8180. mainModuleEntries := entriesList[0]
  8181. android.AssertArrayString(t,
  8182. "LOCAL_REQUIRED_MODULES",
  8183. mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
  8184. []string{
  8185. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
  8186. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
  8187. })
  8188. }
  8189. func TestAndroidMk_RequiredModules(t *testing.T) {
  8190. ctx := testApex(t, `
  8191. apex {
  8192. name: "myapex",
  8193. key: "myapex.key",
  8194. updatable: false,
  8195. java_libs: ["foo"],
  8196. required: ["otherapex"],
  8197. }
  8198. apex {
  8199. name: "otherapex",
  8200. key: "myapex.key",
  8201. updatable: false,
  8202. java_libs: ["foo"],
  8203. required: ["otherapex"],
  8204. }
  8205. apex_key {
  8206. name: "myapex.key",
  8207. public_key: "testkey.avbpubkey",
  8208. private_key: "testkey.pem",
  8209. }
  8210. java_library {
  8211. name: "foo",
  8212. srcs: ["foo.java"],
  8213. apex_available: ["myapex", "otherapex"],
  8214. installable: true,
  8215. }
  8216. `)
  8217. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8218. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  8219. var builder strings.Builder
  8220. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  8221. androidMk := builder.String()
  8222. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := foo.myapex apex_manifest.pb.myapex apex_pubkey.myapex otherapex")
  8223. }
  8224. func TestAndroidMk_RequiredDeps(t *testing.T) {
  8225. ctx := testApex(t, `
  8226. apex {
  8227. name: "myapex",
  8228. key: "myapex.key",
  8229. updatable: false,
  8230. }
  8231. apex_key {
  8232. name: "myapex.key",
  8233. public_key: "testkey.avbpubkey",
  8234. private_key: "testkey.pem",
  8235. }
  8236. `)
  8237. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8238. bundle.requiredDeps = append(bundle.requiredDeps, "foo")
  8239. data := android.AndroidMkDataForTest(t, ctx, bundle)
  8240. var builder strings.Builder
  8241. data.Custom(&builder, bundle.BaseModuleName(), "TARGET_", "", data)
  8242. androidMk := builder.String()
  8243. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES := apex_manifest.pb.myapex apex_pubkey.myapex foo\n")
  8244. flattenedBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  8245. flattenedBundle.requiredDeps = append(flattenedBundle.requiredDeps, "foo")
  8246. flattenedData := android.AndroidMkDataForTest(t, ctx, flattenedBundle)
  8247. var flattenedBuilder strings.Builder
  8248. flattenedData.Custom(&flattenedBuilder, flattenedBundle.BaseModuleName(), "TARGET_", "", flattenedData)
  8249. flattenedAndroidMk := flattenedBuilder.String()
  8250. ensureContains(t, flattenedAndroidMk, "LOCAL_REQUIRED_MODULES := apex_manifest.pb.myapex.flattened apex_pubkey.myapex.flattened foo\n")
  8251. }
  8252. func TestApexOutputFileProducer(t *testing.T) {
  8253. for _, tc := range []struct {
  8254. name string
  8255. ref string
  8256. expected_data []string
  8257. }{
  8258. {
  8259. name: "test_using_output",
  8260. ref: ":myapex",
  8261. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.capex:myapex.capex"},
  8262. },
  8263. {
  8264. name: "test_using_apex",
  8265. ref: ":myapex{.apex}",
  8266. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.apex:myapex.apex"},
  8267. },
  8268. } {
  8269. t.Run(tc.name, func(t *testing.T) {
  8270. ctx := testApex(t, `
  8271. apex {
  8272. name: "myapex",
  8273. key: "myapex.key",
  8274. compressible: true,
  8275. updatable: false,
  8276. }
  8277. apex_key {
  8278. name: "myapex.key",
  8279. public_key: "testkey.avbpubkey",
  8280. private_key: "testkey.pem",
  8281. }
  8282. java_test {
  8283. name: "`+tc.name+`",
  8284. srcs: ["a.java"],
  8285. data: ["`+tc.ref+`"],
  8286. }
  8287. `,
  8288. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  8289. variables.CompressedApex = proptools.BoolPtr(true)
  8290. }))
  8291. javaTest := ctx.ModuleForTests(tc.name, "android_common").Module().(*java.Test)
  8292. data := android.AndroidMkEntriesForTest(t, ctx, javaTest)[0].EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
  8293. android.AssertStringPathsRelativeToTopEquals(t, "data", ctx.Config(), tc.expected_data, data)
  8294. })
  8295. }
  8296. }
  8297. func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
  8298. preparer := android.GroupFixturePreparers(
  8299. PrepareForTestWithApexBuildComponents,
  8300. prepareForTestWithMyapex,
  8301. java.PrepareForTestWithJavaSdkLibraryFiles,
  8302. java.PrepareForTestWithJavaDefaultModules,
  8303. android.PrepareForTestWithAndroidBuildComponents,
  8304. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  8305. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  8306. )
  8307. // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
  8308. t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  8309. preparer.RunTestWithBp(t, `
  8310. apex {
  8311. name: "myapex",
  8312. key: "myapex.key",
  8313. bootclasspath_fragments: ["mybootclasspathfragment"],
  8314. min_sdk_version: "30",
  8315. updatable: false,
  8316. }
  8317. apex_key {
  8318. name: "myapex.key",
  8319. public_key: "testkey.avbpubkey",
  8320. private_key: "testkey.pem",
  8321. }
  8322. bootclasspath_fragment {
  8323. name: "mybootclasspathfragment",
  8324. contents: ["mybootclasspathlib"],
  8325. apex_available: ["myapex"],
  8326. hidden_api: {
  8327. split_packages: ["*"],
  8328. },
  8329. }
  8330. java_sdk_library {
  8331. name: "mybootclasspathlib",
  8332. srcs: ["mybootclasspathlib.java"],
  8333. apex_available: ["myapex"],
  8334. compile_dex: true,
  8335. unsafe_ignore_missing_latest_api: true,
  8336. min_sdk_version: "31",
  8337. static_libs: ["util"],
  8338. }
  8339. java_library {
  8340. name: "util",
  8341. srcs: ["a.java"],
  8342. apex_available: ["myapex"],
  8343. min_sdk_version: "31",
  8344. static_libs: ["another_util"],
  8345. }
  8346. java_library {
  8347. name: "another_util",
  8348. srcs: ["a.java"],
  8349. min_sdk_version: "31",
  8350. apex_available: ["myapex"],
  8351. }
  8352. `)
  8353. })
  8354. // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
  8355. t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  8356. preparer.RunTestWithBp(t, `
  8357. apex {
  8358. name: "myapex",
  8359. key: "myapex.key",
  8360. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8361. min_sdk_version: "30",
  8362. updatable: false,
  8363. }
  8364. apex_key {
  8365. name: "myapex.key",
  8366. public_key: "testkey.avbpubkey",
  8367. private_key: "testkey.pem",
  8368. }
  8369. systemserverclasspath_fragment {
  8370. name: "mysystemserverclasspathfragment",
  8371. contents: ["mysystemserverclasspathlib"],
  8372. apex_available: ["myapex"],
  8373. }
  8374. java_sdk_library {
  8375. name: "mysystemserverclasspathlib",
  8376. srcs: ["mysystemserverclasspathlib.java"],
  8377. apex_available: ["myapex"],
  8378. compile_dex: true,
  8379. min_sdk_version: "32",
  8380. unsafe_ignore_missing_latest_api: true,
  8381. static_libs: ["util"],
  8382. }
  8383. java_library {
  8384. name: "util",
  8385. srcs: ["a.java"],
  8386. apex_available: ["myapex"],
  8387. min_sdk_version: "31",
  8388. static_libs: ["another_util"],
  8389. }
  8390. java_library {
  8391. name: "another_util",
  8392. srcs: ["a.java"],
  8393. min_sdk_version: "31",
  8394. apex_available: ["myapex"],
  8395. }
  8396. `)
  8397. })
  8398. t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  8399. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
  8400. RunTestWithBp(t, `
  8401. apex {
  8402. name: "myapex",
  8403. key: "myapex.key",
  8404. bootclasspath_fragments: ["mybootclasspathfragment"],
  8405. min_sdk_version: "30",
  8406. updatable: false,
  8407. }
  8408. apex_key {
  8409. name: "myapex.key",
  8410. public_key: "testkey.avbpubkey",
  8411. private_key: "testkey.pem",
  8412. }
  8413. bootclasspath_fragment {
  8414. name: "mybootclasspathfragment",
  8415. contents: ["mybootclasspathlib"],
  8416. apex_available: ["myapex"],
  8417. hidden_api: {
  8418. split_packages: ["*"],
  8419. },
  8420. }
  8421. java_sdk_library {
  8422. name: "mybootclasspathlib",
  8423. srcs: ["mybootclasspathlib.java"],
  8424. apex_available: ["myapex"],
  8425. compile_dex: true,
  8426. unsafe_ignore_missing_latest_api: true,
  8427. }
  8428. `)
  8429. })
  8430. t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  8431. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
  8432. RunTestWithBp(t, `
  8433. apex {
  8434. name: "myapex",
  8435. key: "myapex.key",
  8436. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8437. min_sdk_version: "30",
  8438. updatable: false,
  8439. }
  8440. apex_key {
  8441. name: "myapex.key",
  8442. public_key: "testkey.avbpubkey",
  8443. private_key: "testkey.pem",
  8444. }
  8445. systemserverclasspath_fragment {
  8446. name: "mysystemserverclasspathfragment",
  8447. contents: ["mysystemserverclasspathlib"],
  8448. apex_available: ["myapex"],
  8449. }
  8450. java_sdk_library {
  8451. name: "mysystemserverclasspathlib",
  8452. srcs: ["mysystemserverclasspathlib.java"],
  8453. apex_available: ["myapex"],
  8454. compile_dex: true,
  8455. unsafe_ignore_missing_latest_api: true,
  8456. }
  8457. `)
  8458. })
  8459. }
  8460. // Verifies that the APEX depends on all the Make modules in the list.
  8461. func ensureContainsRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  8462. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  8463. for _, dep := range deps {
  8464. android.AssertStringListContains(t, "", a.requiredDeps, dep)
  8465. }
  8466. }
  8467. // Verifies that the APEX does not depend on any of the Make modules in the list.
  8468. func ensureDoesNotContainRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  8469. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  8470. for _, dep := range deps {
  8471. android.AssertStringListDoesNotContain(t, "", a.requiredDeps, dep)
  8472. }
  8473. }
  8474. func TestApexStrictUpdtabilityLint(t *testing.T) {
  8475. bpTemplate := `
  8476. apex {
  8477. name: "myapex",
  8478. key: "myapex.key",
  8479. java_libs: ["myjavalib"],
  8480. updatable: %v,
  8481. min_sdk_version: "29",
  8482. }
  8483. apex_key {
  8484. name: "myapex.key",
  8485. }
  8486. java_library {
  8487. name: "myjavalib",
  8488. srcs: ["MyClass.java"],
  8489. apex_available: [ "myapex" ],
  8490. lint: {
  8491. strict_updatability_linting: %v,
  8492. },
  8493. sdk_version: "current",
  8494. min_sdk_version: "29",
  8495. }
  8496. `
  8497. fs := android.MockFS{
  8498. "lint-baseline.xml": nil,
  8499. }
  8500. testCases := []struct {
  8501. testCaseName string
  8502. apexUpdatable bool
  8503. javaStrictUpdtabilityLint bool
  8504. lintFileExists bool
  8505. disallowedFlagExpected bool
  8506. }{
  8507. {
  8508. testCaseName: "lint-baseline.xml does not exist, no disallowed flag necessary in lint cmd",
  8509. apexUpdatable: true,
  8510. javaStrictUpdtabilityLint: true,
  8511. lintFileExists: false,
  8512. disallowedFlagExpected: false,
  8513. },
  8514. {
  8515. testCaseName: "non-updatable apex respects strict_updatability of javalib",
  8516. apexUpdatable: false,
  8517. javaStrictUpdtabilityLint: false,
  8518. lintFileExists: true,
  8519. disallowedFlagExpected: false,
  8520. },
  8521. {
  8522. testCaseName: "non-updatable apex respects strict updatability of javalib",
  8523. apexUpdatable: false,
  8524. javaStrictUpdtabilityLint: true,
  8525. lintFileExists: true,
  8526. disallowedFlagExpected: true,
  8527. },
  8528. {
  8529. testCaseName: "updatable apex sets strict updatability of javalib to true",
  8530. apexUpdatable: true,
  8531. javaStrictUpdtabilityLint: false, // will be set to true by mutator
  8532. lintFileExists: true,
  8533. disallowedFlagExpected: true,
  8534. },
  8535. }
  8536. for _, testCase := range testCases {
  8537. bp := fmt.Sprintf(bpTemplate, testCase.apexUpdatable, testCase.javaStrictUpdtabilityLint)
  8538. fixtures := []android.FixturePreparer{}
  8539. if testCase.lintFileExists {
  8540. fixtures = append(fixtures, fs.AddToFixture())
  8541. }
  8542. result := testApex(t, bp, fixtures...)
  8543. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8544. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8545. disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi")
  8546. if disallowedFlagActual != testCase.disallowedFlagExpected {
  8547. t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  8548. }
  8549. }
  8550. }
  8551. func TestUpdatabilityLintSkipLibcore(t *testing.T) {
  8552. bp := `
  8553. apex {
  8554. name: "myapex",
  8555. key: "myapex.key",
  8556. java_libs: ["myjavalib"],
  8557. updatable: true,
  8558. min_sdk_version: "29",
  8559. }
  8560. apex_key {
  8561. name: "myapex.key",
  8562. }
  8563. java_library {
  8564. name: "myjavalib",
  8565. srcs: ["MyClass.java"],
  8566. apex_available: [ "myapex" ],
  8567. sdk_version: "current",
  8568. min_sdk_version: "29",
  8569. }
  8570. `
  8571. testCases := []struct {
  8572. testCaseName string
  8573. moduleDirectory string
  8574. disallowedFlagExpected bool
  8575. }{
  8576. {
  8577. testCaseName: "lintable module defined outside libcore",
  8578. moduleDirectory: "",
  8579. disallowedFlagExpected: true,
  8580. },
  8581. {
  8582. testCaseName: "lintable module defined in libcore root directory",
  8583. moduleDirectory: "libcore/",
  8584. disallowedFlagExpected: false,
  8585. },
  8586. {
  8587. testCaseName: "lintable module defined in libcore child directory",
  8588. moduleDirectory: "libcore/childdir/",
  8589. disallowedFlagExpected: true,
  8590. },
  8591. }
  8592. for _, testCase := range testCases {
  8593. lintFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"lint-baseline.xml", "")
  8594. bpFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"Android.bp", bp)
  8595. result := testApex(t, "", lintFileCreator, bpFileCreator)
  8596. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8597. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8598. cmdFlags := fmt.Sprintf("--baseline %vlint-baseline.xml --disallowed_issues NewApi", testCase.moduleDirectory)
  8599. disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, cmdFlags)
  8600. if disallowedFlagActual != testCase.disallowedFlagExpected {
  8601. t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  8602. }
  8603. }
  8604. }
  8605. // checks transtive deps of an apex coming from bootclasspath_fragment
  8606. func TestApexStrictUpdtabilityLintBcpFragmentDeps(t *testing.T) {
  8607. bp := `
  8608. apex {
  8609. name: "myapex",
  8610. key: "myapex.key",
  8611. bootclasspath_fragments: ["mybootclasspathfragment"],
  8612. updatable: true,
  8613. min_sdk_version: "29",
  8614. }
  8615. apex_key {
  8616. name: "myapex.key",
  8617. }
  8618. bootclasspath_fragment {
  8619. name: "mybootclasspathfragment",
  8620. contents: ["myjavalib"],
  8621. apex_available: ["myapex"],
  8622. hidden_api: {
  8623. split_packages: ["*"],
  8624. },
  8625. }
  8626. java_library {
  8627. name: "myjavalib",
  8628. srcs: ["MyClass.java"],
  8629. apex_available: [ "myapex" ],
  8630. sdk_version: "current",
  8631. min_sdk_version: "29",
  8632. compile_dex: true,
  8633. }
  8634. `
  8635. fs := android.MockFS{
  8636. "lint-baseline.xml": nil,
  8637. }
  8638. result := testApex(t, bp, dexpreopt.FixtureSetApexBootJars("myapex:myjavalib"), fs.AddToFixture())
  8639. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8640. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8641. if !strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi") {
  8642. t.Errorf("Strict updabality lint missing in myjavalib coming from bootclasspath_fragment mybootclasspath-fragment\nActual lint cmd: %v", *sboxProto.Commands[0].Command)
  8643. }
  8644. }
  8645. // updatable apexes should propagate updatable=true to its apps
  8646. func TestUpdatableApexEnforcesAppUpdatability(t *testing.T) {
  8647. bp := `
  8648. apex {
  8649. name: "myapex",
  8650. key: "myapex.key",
  8651. updatable: %v,
  8652. apps: [
  8653. "myapp",
  8654. ],
  8655. min_sdk_version: "30",
  8656. }
  8657. apex_key {
  8658. name: "myapex.key",
  8659. }
  8660. android_app {
  8661. name: "myapp",
  8662. updatable: %v,
  8663. apex_available: [
  8664. "myapex",
  8665. ],
  8666. sdk_version: "current",
  8667. min_sdk_version: "30",
  8668. }
  8669. `
  8670. testCases := []struct {
  8671. name string
  8672. apex_is_updatable_bp bool
  8673. app_is_updatable_bp bool
  8674. app_is_updatable_expected bool
  8675. }{
  8676. {
  8677. name: "Non-updatable apex respects updatable property of non-updatable app",
  8678. apex_is_updatable_bp: false,
  8679. app_is_updatable_bp: false,
  8680. app_is_updatable_expected: false,
  8681. },
  8682. {
  8683. name: "Non-updatable apex respects updatable property of updatable app",
  8684. apex_is_updatable_bp: false,
  8685. app_is_updatable_bp: true,
  8686. app_is_updatable_expected: true,
  8687. },
  8688. {
  8689. name: "Updatable apex respects updatable property of updatable app",
  8690. apex_is_updatable_bp: true,
  8691. app_is_updatable_bp: true,
  8692. app_is_updatable_expected: true,
  8693. },
  8694. {
  8695. name: "Updatable apex sets updatable=true on non-updatable app",
  8696. apex_is_updatable_bp: true,
  8697. app_is_updatable_bp: false,
  8698. app_is_updatable_expected: true,
  8699. },
  8700. }
  8701. for _, testCase := range testCases {
  8702. result := testApex(t, fmt.Sprintf(bp, testCase.apex_is_updatable_bp, testCase.app_is_updatable_bp))
  8703. myapp := result.ModuleForTests("myapp", "android_common").Module().(*java.AndroidApp)
  8704. android.AssertBoolEquals(t, testCase.name, testCase.app_is_updatable_expected, myapp.Updatable())
  8705. }
  8706. }
  8707. func TestApexBuildsAgainstApiSurfaceStubLibraries(t *testing.T) {
  8708. bp := `
  8709. apex {
  8710. name: "myapex",
  8711. key: "myapex.key",
  8712. native_shared_libs: ["libfoo"],
  8713. min_sdk_version: "29",
  8714. }
  8715. apex_key {
  8716. name: "myapex.key",
  8717. }
  8718. cc_library {
  8719. name: "libfoo",
  8720. shared_libs: ["libc"],
  8721. apex_available: ["myapex"],
  8722. min_sdk_version: "29",
  8723. }
  8724. cc_api_library {
  8725. name: "libc",
  8726. src: "libc.so",
  8727. min_sdk_version: "29",
  8728. recovery_available: true,
  8729. }
  8730. api_imports {
  8731. name: "api_imports",
  8732. shared_libs: [
  8733. "libc",
  8734. ],
  8735. header_libs: [],
  8736. }
  8737. `
  8738. result := testApex(t, bp)
  8739. hasDep := func(m android.Module, wantDep android.Module) bool {
  8740. t.Helper()
  8741. var found bool
  8742. result.VisitDirectDeps(m, func(dep blueprint.Module) {
  8743. if dep == wantDep {
  8744. found = true
  8745. }
  8746. })
  8747. return found
  8748. }
  8749. libfooApexVariant := result.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex29").Module()
  8750. libcApexVariant := result.ModuleForTests("libc.apiimport", "android_arm64_armv8-a_shared_apex29").Module()
  8751. android.AssertBoolEquals(t, "apex variant should link against API surface stub libraries", true, hasDep(libfooApexVariant, libcApexVariant))
  8752. // libfoo core variant should be buildable in the same inner tree since
  8753. // certain mcombo files might build system and apexes in the same inner tree
  8754. // libfoo core variant should link against source libc
  8755. libfooCoreVariant := result.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module()
  8756. libcCoreVariant := result.ModuleForTests("libc.apiimport", "android_arm64_armv8-a_shared").Module()
  8757. android.AssertBoolEquals(t, "core variant should link against source libc", true, hasDep(libfooCoreVariant, libcCoreVariant))
  8758. }
  8759. func TestApexImageInMixedBuilds(t *testing.T) {
  8760. bp := `
  8761. apex_key{
  8762. name: "foo_key",
  8763. }
  8764. apex {
  8765. name: "foo",
  8766. key: "foo_key",
  8767. updatable: true,
  8768. min_sdk_version: "31",
  8769. file_contexts: ":myapex-file_contexts",
  8770. bazel_module: { label: "//:foo" },
  8771. }`
  8772. outputBaseDir := "out/bazel"
  8773. result := android.GroupFixturePreparers(
  8774. prepareForApexTest,
  8775. android.FixtureModifyConfig(func(config android.Config) {
  8776. config.BazelContext = android.MockBazelContext{
  8777. OutputBaseDir: outputBaseDir,
  8778. LabelToApexInfo: map[string]cquery.ApexInfo{
  8779. "//:foo": cquery.ApexInfo{
  8780. SignedOutput: "signed_out.apex",
  8781. UnsignedOutput: "unsigned_out.apex",
  8782. BundleKeyInfo: []string{"public_key", "private_key"},
  8783. ContainerKeyInfo: []string{"container_cert", "container_private"},
  8784. SymbolsUsedByApex: "foo_using.txt",
  8785. JavaSymbolsUsedByApex: "foo_using.xml",
  8786. BundleFile: "apex_bundle.zip",
  8787. InstalledFiles: "installed-files.txt",
  8788. // unused
  8789. PackageName: "pkg_name",
  8790. ProvidesLibs: []string{"a", "b"},
  8791. RequiresLibs: []string{"c", "d"},
  8792. },
  8793. },
  8794. }
  8795. }),
  8796. ).RunTestWithBp(t, bp)
  8797. m := result.ModuleForTests("foo", "android_common_foo_image").Module()
  8798. ab, ok := m.(*apexBundle)
  8799. if !ok {
  8800. t.Fatalf("Expected module to be an apexBundle, was not")
  8801. }
  8802. if w, g := "out/bazel/execroot/__main__/public_key", ab.publicKeyFile.String(); w != g {
  8803. t.Errorf("Expected public key %q, got %q", w, g)
  8804. }
  8805. if w, g := "out/bazel/execroot/__main__/private_key", ab.privateKeyFile.String(); w != g {
  8806. t.Errorf("Expected private key %q, got %q", w, g)
  8807. }
  8808. if w, g := "out/bazel/execroot/__main__/container_cert", ab.containerCertificateFile.String(); w != g {
  8809. t.Errorf("Expected public container key %q, got %q", w, g)
  8810. }
  8811. if w, g := "out/bazel/execroot/__main__/container_private", ab.containerPrivateKeyFile.String(); w != g {
  8812. t.Errorf("Expected private container key %q, got %q", w, g)
  8813. }
  8814. if w, g := "out/bazel/execroot/__main__/signed_out.apex", ab.outputFile.String(); w != g {
  8815. t.Errorf("Expected output file %q, got %q", w, g)
  8816. }
  8817. if w, g := "out/bazel/execroot/__main__/foo_using.txt", ab.nativeApisUsedByModuleFile.String(); w != g {
  8818. t.Errorf("Expected output file %q, got %q", w, g)
  8819. }
  8820. if w, g := "out/bazel/execroot/__main__/foo_using.xml", ab.javaApisUsedByModuleFile.String(); w != g {
  8821. t.Errorf("Expected output file %q, got %q", w, g)
  8822. }
  8823. if w, g := "out/bazel/execroot/__main__/installed-files.txt", ab.installedFilesFile.String(); w != g {
  8824. t.Errorf("Expected installed-files.txt %q, got %q", w, g)
  8825. }
  8826. mkData := android.AndroidMkDataForTest(t, result.TestContext, m)
  8827. var builder strings.Builder
  8828. mkData.Custom(&builder, "foo", "BAZEL_TARGET_", "", mkData)
  8829. data := builder.String()
  8830. if w := "ALL_MODULES.$(my_register_name).BUNDLE := out/bazel/execroot/__main__/apex_bundle.zip"; !strings.Contains(data, w) {
  8831. t.Errorf("Expected %q in androidmk data, but did not find %q", w, data)
  8832. }
  8833. if w := "$(call dist-for-goals,checkbuild,out/bazel/execroot/__main__/installed-files.txt:foo-installed-files.txt)"; !strings.Contains(data, w) {
  8834. t.Errorf("Expected %q in androidmk data, but did not find %q", w, data)
  8835. }
  8836. }