app_test.go 96 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507
  1. // Copyright 2017 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package java
  15. import (
  16. "fmt"
  17. "path/filepath"
  18. "reflect"
  19. "sort"
  20. "strings"
  21. "testing"
  22. "github.com/google/blueprint/proptools"
  23. "android/soong/android"
  24. "android/soong/cc"
  25. "android/soong/dexpreopt"
  26. )
  27. // testApp runs tests using the prepareForJavaTest
  28. //
  29. // See testJava for an explanation as to how to stop using this deprecated method.
  30. //
  31. // deprecated
  32. func testApp(t *testing.T, bp string) *android.TestContext {
  33. t.Helper()
  34. result := prepareForJavaTest.RunTestWithBp(t, bp)
  35. return result.TestContext
  36. }
  37. func TestApp(t *testing.T) {
  38. resourceFiles := []string{
  39. "res/layout/layout.xml",
  40. "res/values/strings.xml",
  41. "res/values-en-rUS/strings.xml",
  42. }
  43. compiledResourceFiles := []string{
  44. "aapt2/res/layout_layout.xml.flat",
  45. "aapt2/res/values_strings.arsc.flat",
  46. "aapt2/res/values-en-rUS_strings.arsc.flat",
  47. }
  48. for _, moduleType := range []string{"android_app", "android_library"} {
  49. t.Run(moduleType, func(t *testing.T) {
  50. result := android.GroupFixturePreparers(
  51. prepareForJavaTest,
  52. android.FixtureModifyMockFS(func(fs android.MockFS) {
  53. for _, file := range resourceFiles {
  54. fs[file] = nil
  55. }
  56. }),
  57. ).RunTestWithBp(t, moduleType+` {
  58. name: "foo",
  59. srcs: ["a.java"],
  60. sdk_version: "current"
  61. }
  62. `)
  63. foo := result.ModuleForTests("foo", "android_common")
  64. var expectedLinkImplicits []string
  65. manifestFixer := foo.Output("manifest_fixer/AndroidManifest.xml")
  66. expectedLinkImplicits = append(expectedLinkImplicits, manifestFixer.Output.String())
  67. frameworkRes := result.ModuleForTests("framework-res", "android_common")
  68. expectedLinkImplicits = append(expectedLinkImplicits,
  69. frameworkRes.Output("package-res.apk").Output.String())
  70. // Test the mapping from input files to compiled output file names
  71. compile := foo.Output(compiledResourceFiles[0])
  72. android.AssertDeepEquals(t, "aapt2 compile inputs", resourceFiles, compile.Inputs.Strings())
  73. compiledResourceOutputs := compile.Outputs.Strings()
  74. sort.Strings(compiledResourceOutputs)
  75. expectedLinkImplicits = append(expectedLinkImplicits, compiledResourceOutputs...)
  76. list := foo.Output("aapt2/res.list")
  77. expectedLinkImplicits = append(expectedLinkImplicits, list.Output.String())
  78. // Check that the link rule uses
  79. res := result.ModuleForTests("foo", "android_common").Output("package-res.apk")
  80. android.AssertDeepEquals(t, "aapt2 link implicits", expectedLinkImplicits, res.Implicits.Strings())
  81. })
  82. }
  83. }
  84. func TestAppSplits(t *testing.T) {
  85. ctx := testApp(t, `
  86. android_app {
  87. name: "foo",
  88. srcs: ["a.java"],
  89. package_splits: ["v4", "v7,hdpi"],
  90. sdk_version: "current"
  91. }`)
  92. foo := ctx.ModuleForTests("foo", "android_common")
  93. expectedOutputs := []string{
  94. "out/soong/.intermediates/foo/android_common/foo.apk",
  95. "out/soong/.intermediates/foo/android_common/foo_v4.apk",
  96. "out/soong/.intermediates/foo/android_common/foo_v7_hdpi.apk",
  97. }
  98. for _, expectedOutput := range expectedOutputs {
  99. foo.Output(expectedOutput)
  100. }
  101. outputFiles, err := foo.Module().(*AndroidApp).OutputFiles("")
  102. if err != nil {
  103. t.Fatal(err)
  104. }
  105. android.AssertPathsRelativeToTopEquals(t, `OutputFiles("")`, expectedOutputs, outputFiles)
  106. }
  107. func TestPlatformAPIs(t *testing.T) {
  108. testJava(t, `
  109. android_app {
  110. name: "foo",
  111. srcs: ["a.java"],
  112. platform_apis: true,
  113. }
  114. `)
  115. testJava(t, `
  116. android_app {
  117. name: "foo",
  118. srcs: ["a.java"],
  119. sdk_version: "current",
  120. }
  121. `)
  122. testJavaError(t, "This module has conflicting settings. sdk_version is empty, which means that this module is build against platform APIs. However platform_apis is not set to true", `
  123. android_app {
  124. name: "bar",
  125. srcs: ["b.java"],
  126. }
  127. `)
  128. testJavaError(t, "This module has conflicting settings. sdk_version is not empty, which means this module cannot use platform APIs. However platform_apis is set to true.", `
  129. android_app {
  130. name: "bar",
  131. srcs: ["b.java"],
  132. sdk_version: "system_current",
  133. platform_apis: true,
  134. }
  135. `)
  136. }
  137. func TestAndroidAppLinkType(t *testing.T) {
  138. testJava(t, `
  139. android_app {
  140. name: "foo",
  141. srcs: ["a.java"],
  142. libs: ["bar"],
  143. static_libs: ["baz"],
  144. platform_apis: true,
  145. }
  146. java_library {
  147. name: "bar",
  148. sdk_version: "current",
  149. srcs: ["b.java"],
  150. }
  151. android_library {
  152. name: "baz",
  153. sdk_version: "system_current",
  154. srcs: ["c.java"],
  155. }
  156. `)
  157. testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
  158. android_app {
  159. name: "foo",
  160. srcs: ["a.java"],
  161. libs: ["bar"],
  162. sdk_version: "current",
  163. static_libs: ["baz"],
  164. }
  165. java_library {
  166. name: "bar",
  167. sdk_version: "current",
  168. srcs: ["b.java"],
  169. }
  170. android_library {
  171. name: "baz",
  172. sdk_version: "system_current",
  173. srcs: ["c.java"],
  174. }
  175. `)
  176. testJava(t, `
  177. android_app {
  178. name: "foo",
  179. srcs: ["a.java"],
  180. libs: ["bar"],
  181. sdk_version: "system_current",
  182. static_libs: ["baz"],
  183. }
  184. java_library {
  185. name: "bar",
  186. sdk_version: "current",
  187. srcs: ["b.java"],
  188. }
  189. android_library {
  190. name: "baz",
  191. sdk_version: "system_current",
  192. srcs: ["c.java"],
  193. }
  194. `)
  195. testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
  196. android_app {
  197. name: "foo",
  198. srcs: ["a.java"],
  199. libs: ["bar"],
  200. sdk_version: "system_current",
  201. static_libs: ["baz"],
  202. }
  203. java_library {
  204. name: "bar",
  205. sdk_version: "current",
  206. srcs: ["b.java"],
  207. }
  208. android_library {
  209. name: "baz",
  210. srcs: ["c.java"],
  211. }
  212. `)
  213. }
  214. func TestUpdatableApps(t *testing.T) {
  215. testCases := []struct {
  216. name string
  217. bp string
  218. expectedError string
  219. }{
  220. {
  221. name: "Stable public SDK",
  222. bp: `android_app {
  223. name: "foo",
  224. srcs: ["a.java"],
  225. sdk_version: "29",
  226. min_sdk_version: "29",
  227. updatable: true,
  228. }`,
  229. },
  230. {
  231. name: "Stable system SDK",
  232. bp: `android_app {
  233. name: "foo",
  234. srcs: ["a.java"],
  235. sdk_version: "system_29",
  236. min_sdk_version: "29",
  237. updatable: true,
  238. }`,
  239. },
  240. {
  241. name: "Current public SDK",
  242. bp: `android_app {
  243. name: "foo",
  244. srcs: ["a.java"],
  245. sdk_version: "current",
  246. min_sdk_version: "29",
  247. updatable: true,
  248. }`,
  249. },
  250. {
  251. name: "Current system SDK",
  252. bp: `android_app {
  253. name: "foo",
  254. srcs: ["a.java"],
  255. sdk_version: "system_current",
  256. min_sdk_version: "29",
  257. updatable: true,
  258. }`,
  259. },
  260. {
  261. name: "Current module SDK",
  262. bp: `android_app {
  263. name: "foo",
  264. srcs: ["a.java"],
  265. sdk_version: "module_current",
  266. min_sdk_version: "29",
  267. updatable: true,
  268. }`,
  269. },
  270. {
  271. name: "Current core SDK",
  272. bp: `android_app {
  273. name: "foo",
  274. srcs: ["a.java"],
  275. sdk_version: "core_current",
  276. min_sdk_version: "29",
  277. updatable: true,
  278. }`,
  279. },
  280. {
  281. name: "No Platform APIs",
  282. bp: `android_app {
  283. name: "foo",
  284. srcs: ["a.java"],
  285. platform_apis: true,
  286. min_sdk_version: "29",
  287. updatable: true,
  288. }`,
  289. expectedError: "Updatable apps must use stable SDKs",
  290. },
  291. {
  292. name: "No Core Platform APIs",
  293. bp: `android_app {
  294. name: "foo",
  295. srcs: ["a.java"],
  296. sdk_version: "core_platform",
  297. min_sdk_version: "29",
  298. updatable: true,
  299. }`,
  300. expectedError: "Updatable apps must use stable SDKs",
  301. },
  302. {
  303. name: "No unspecified APIs",
  304. bp: `android_app {
  305. name: "foo",
  306. srcs: ["a.java"],
  307. updatable: true,
  308. min_sdk_version: "29",
  309. }`,
  310. expectedError: "Updatable apps must use stable SDK",
  311. },
  312. {
  313. name: "Must specify min_sdk_version",
  314. bp: `android_app {
  315. name: "app_without_min_sdk_version",
  316. srcs: ["a.java"],
  317. sdk_version: "29",
  318. updatable: true,
  319. }`,
  320. expectedError: "updatable apps must set min_sdk_version.",
  321. },
  322. }
  323. for _, test := range testCases {
  324. t.Run(test.name, func(t *testing.T) {
  325. errorHandler := android.FixtureExpectsNoErrors
  326. if test.expectedError != "" {
  327. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  328. }
  329. android.GroupFixturePreparers(
  330. prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{
  331. "29": {"foo"},
  332. })).
  333. ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, test.bp)
  334. })
  335. }
  336. }
  337. func TestUpdatableApps_TransitiveDepsShouldSetMinSdkVersion(t *testing.T) {
  338. testJavaError(t, `module "bar".*: should support min_sdk_version\(29\)`, cc.GatherRequiredDepsForTest(android.Android)+`
  339. android_app {
  340. name: "foo",
  341. srcs: ["a.java"],
  342. updatable: true,
  343. sdk_version: "current",
  344. min_sdk_version: "29",
  345. static_libs: ["bar"],
  346. }
  347. java_library {
  348. name: "bar",
  349. sdk_version: "current",
  350. }
  351. `)
  352. }
  353. func TestUpdatableApps_JniLibsShouldShouldSupportMinSdkVersion(t *testing.T) {
  354. testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  355. android_app {
  356. name: "foo",
  357. srcs: ["a.java"],
  358. updatable: true,
  359. sdk_version: "current",
  360. min_sdk_version: "current",
  361. jni_libs: ["libjni"],
  362. }
  363. cc_library {
  364. name: "libjni",
  365. stl: "none",
  366. system_shared_libs: [],
  367. sdk_version: "current",
  368. }
  369. `)
  370. }
  371. func TestUpdatableApps_JniLibShouldBeBuiltAgainstMinSdkVersion(t *testing.T) {
  372. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  373. android_app {
  374. name: "foo",
  375. srcs: ["a.java"],
  376. updatable: true,
  377. sdk_version: "current",
  378. min_sdk_version: "29",
  379. jni_libs: ["libjni"],
  380. }
  381. cc_library {
  382. name: "libjni",
  383. stl: "none",
  384. system_shared_libs: [],
  385. sdk_version: "current",
  386. min_sdk_version: "29",
  387. }
  388. `
  389. fs := map[string][]byte{
  390. "prebuilts/ndk/current/platforms/android-29/arch-arm64/usr/lib/crtbegin_so.o": nil,
  391. "prebuilts/ndk/current/platforms/android-29/arch-arm64/usr/lib/crtend_so.o": nil,
  392. "prebuilts/ndk/current/platforms/android-29/arch-arm/usr/lib/crtbegin_so.o": nil,
  393. "prebuilts/ndk/current/platforms/android-29/arch-arm/usr/lib/crtend_so.o": nil,
  394. }
  395. ctx, _ := testJavaWithFS(t, bp, fs)
  396. inputs := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_sdk_shared").Description("link").Implicits
  397. var crtbeginFound, crtendFound bool
  398. expectedCrtBegin := ctx.ModuleForTests("crtbegin_so",
  399. "android_arm64_armv8-a_sdk_29").Rule("partialLd").Output
  400. expectedCrtEnd := ctx.ModuleForTests("crtend_so",
  401. "android_arm64_armv8-a_sdk_29").Rule("partialLd").Output
  402. implicits := []string{}
  403. for _, input := range inputs {
  404. implicits = append(implicits, input.String())
  405. if strings.HasSuffix(input.String(), expectedCrtBegin.String()) {
  406. crtbeginFound = true
  407. } else if strings.HasSuffix(input.String(), expectedCrtEnd.String()) {
  408. crtendFound = true
  409. }
  410. }
  411. if !crtbeginFound {
  412. t.Error(fmt.Sprintf(
  413. "expected implicit with suffix %q, have the following implicits:\n%s",
  414. expectedCrtBegin, strings.Join(implicits, "\n")))
  415. }
  416. if !crtendFound {
  417. t.Error(fmt.Sprintf(
  418. "expected implicit with suffix %q, have the following implicits:\n%s",
  419. expectedCrtEnd, strings.Join(implicits, "\n")))
  420. }
  421. }
  422. func TestUpdatableApps_ErrorIfJniLibDoesntSupportMinSdkVersion(t *testing.T) {
  423. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  424. android_app {
  425. name: "foo",
  426. srcs: ["a.java"],
  427. updatable: true,
  428. sdk_version: "current",
  429. min_sdk_version: "29", // this APK should support 29
  430. jni_libs: ["libjni"],
  431. }
  432. cc_library {
  433. name: "libjni",
  434. stl: "none",
  435. sdk_version: "current",
  436. min_sdk_version: "current",
  437. }
  438. `
  439. testJavaError(t, `"libjni" .*: min_sdk_version\(current\) is higher than min_sdk_version\(29\)`, bp)
  440. }
  441. func TestUpdatableApps_ErrorIfDepMinSdkVersionIsHigher(t *testing.T) {
  442. bp := cc.GatherRequiredDepsForTest(android.Android) + `
  443. android_app {
  444. name: "foo",
  445. srcs: ["a.java"],
  446. updatable: true,
  447. sdk_version: "current",
  448. min_sdk_version: "29", // this APK should support 29
  449. jni_libs: ["libjni"],
  450. }
  451. cc_library {
  452. name: "libjni",
  453. stl: "none",
  454. shared_libs: ["libbar"],
  455. system_shared_libs: [],
  456. sdk_version: "27",
  457. min_sdk_version: "27",
  458. }
  459. cc_library {
  460. name: "libbar",
  461. stl: "none",
  462. system_shared_libs: [],
  463. sdk_version: "current",
  464. min_sdk_version: "current",
  465. }
  466. `
  467. testJavaError(t, `"libjni" .*: links "libbar" built against newer API version "current"`, bp)
  468. }
  469. func TestResourceDirs(t *testing.T) {
  470. testCases := []struct {
  471. name string
  472. prop string
  473. resources []string
  474. }{
  475. {
  476. name: "no resource_dirs",
  477. prop: "",
  478. resources: []string{"res/res/values/strings.xml"},
  479. },
  480. {
  481. name: "resource_dirs",
  482. prop: `resource_dirs: ["res"]`,
  483. resources: []string{"res/res/values/strings.xml"},
  484. },
  485. {
  486. name: "empty resource_dirs",
  487. prop: `resource_dirs: []`,
  488. resources: nil,
  489. },
  490. }
  491. fs := android.MockFS{
  492. "res/res/values/strings.xml": nil,
  493. }
  494. bp := `
  495. android_app {
  496. name: "foo",
  497. sdk_version: "current",
  498. %s
  499. }
  500. `
  501. for _, testCase := range testCases {
  502. t.Run(testCase.name, func(t *testing.T) {
  503. result := android.GroupFixturePreparers(
  504. PrepareForTestWithJavaDefaultModules,
  505. PrepareForTestWithOverlayBuildComponents,
  506. fs.AddToFixture(),
  507. ).RunTestWithBp(t, fmt.Sprintf(bp, testCase.prop))
  508. module := result.ModuleForTests("foo", "android_common")
  509. resourceList := module.MaybeOutput("aapt2/res.list")
  510. var resources []string
  511. if resourceList.Rule != nil {
  512. for _, compiledResource := range resourceList.Inputs.Strings() {
  513. resources = append(resources, module.Output(compiledResource).Inputs.Strings()...)
  514. }
  515. }
  516. android.AssertDeepEquals(t, "resource files", testCase.resources, resources)
  517. })
  518. }
  519. }
  520. func TestLibraryAssets(t *testing.T) {
  521. bp := `
  522. android_app {
  523. name: "foo",
  524. sdk_version: "current",
  525. static_libs: ["lib1", "lib2", "lib3"],
  526. }
  527. android_library {
  528. name: "lib1",
  529. sdk_version: "current",
  530. asset_dirs: ["assets_a"],
  531. }
  532. android_library {
  533. name: "lib2",
  534. sdk_version: "current",
  535. }
  536. android_library {
  537. name: "lib3",
  538. sdk_version: "current",
  539. static_libs: ["lib4"],
  540. }
  541. android_library {
  542. name: "lib4",
  543. sdk_version: "current",
  544. asset_dirs: ["assets_b"],
  545. }
  546. `
  547. testCases := []struct {
  548. name string
  549. assetFlag string
  550. assetPackages []string
  551. }{
  552. {
  553. name: "foo",
  554. // lib1 has its own asset. lib3 doesn't have any, but provides lib4's transitively.
  555. assetPackages: []string{
  556. "out/soong/.intermediates/foo/android_common/aapt2/package-res.apk",
  557. "out/soong/.intermediates/lib1/android_common/assets.zip",
  558. "out/soong/.intermediates/lib3/android_common/assets.zip",
  559. },
  560. },
  561. {
  562. name: "lib1",
  563. assetFlag: "-A assets_a",
  564. },
  565. {
  566. name: "lib2",
  567. },
  568. {
  569. name: "lib3",
  570. assetPackages: []string{
  571. "out/soong/.intermediates/lib3/android_common/aapt2/package-res.apk",
  572. "out/soong/.intermediates/lib4/android_common/assets.zip",
  573. },
  574. },
  575. {
  576. name: "lib4",
  577. assetFlag: "-A assets_b",
  578. },
  579. }
  580. ctx := testApp(t, bp)
  581. for _, test := range testCases {
  582. t.Run(test.name, func(t *testing.T) {
  583. m := ctx.ModuleForTests(test.name, "android_common")
  584. // Check asset flag in aapt2 link flags
  585. var aapt2link android.TestingBuildParams
  586. if len(test.assetPackages) > 0 {
  587. aapt2link = m.Output("aapt2/package-res.apk")
  588. } else {
  589. aapt2link = m.Output("package-res.apk")
  590. }
  591. aapt2link = aapt2link
  592. aapt2Flags := aapt2link.Args["flags"]
  593. if test.assetFlag != "" {
  594. android.AssertStringDoesContain(t, "asset flag", aapt2Flags, test.assetFlag)
  595. } else {
  596. android.AssertStringDoesNotContain(t, "aapt2 link flags", aapt2Flags, " -A ")
  597. }
  598. // Check asset merge rule.
  599. if len(test.assetPackages) > 0 {
  600. mergeAssets := m.Output("package-res.apk")
  601. android.AssertPathsRelativeToTopEquals(t, "mergeAssets inputs", test.assetPackages, mergeAssets.Inputs)
  602. }
  603. })
  604. }
  605. }
  606. func TestAppJavaResources(t *testing.T) {
  607. bp := `
  608. android_app {
  609. name: "foo",
  610. sdk_version: "current",
  611. java_resources: ["resources/a"],
  612. srcs: ["a.java"],
  613. }
  614. android_app {
  615. name: "bar",
  616. sdk_version: "current",
  617. java_resources: ["resources/a"],
  618. }
  619. `
  620. ctx := testApp(t, bp)
  621. foo := ctx.ModuleForTests("foo", "android_common")
  622. fooResources := foo.Output("res/foo.jar")
  623. fooDexJar := foo.Output("dex-withres/foo.jar")
  624. fooDexJarAligned := foo.Output("dex-withres-aligned/foo.jar")
  625. fooApk := foo.Rule("combineApk")
  626. if g, w := fooDexJar.Inputs.Strings(), fooResources.Output.String(); !android.InList(w, g) {
  627. t.Errorf("expected resource jar %q in foo dex jar inputs %q", w, g)
  628. }
  629. if g, w := fooDexJarAligned.Input.String(), fooDexJar.Output.String(); g != w {
  630. t.Errorf("expected dex jar %q in foo aligned dex jar inputs %q", w, g)
  631. }
  632. if g, w := fooApk.Inputs.Strings(), fooDexJarAligned.Output.String(); !android.InList(w, g) {
  633. t.Errorf("expected aligned dex jar %q in foo apk inputs %q", w, g)
  634. }
  635. bar := ctx.ModuleForTests("bar", "android_common")
  636. barResources := bar.Output("res/bar.jar")
  637. barApk := bar.Rule("combineApk")
  638. if g, w := barApk.Inputs.Strings(), barResources.Output.String(); !android.InList(w, g) {
  639. t.Errorf("expected resources jar %q in bar apk inputs %q", w, g)
  640. }
  641. }
  642. func TestAndroidResources(t *testing.T) {
  643. testCases := []struct {
  644. name string
  645. enforceRROTargets []string
  646. enforceRROExcludedOverlays []string
  647. resourceFiles map[string][]string
  648. overlayFiles map[string][]string
  649. rroDirs map[string][]string
  650. }{
  651. {
  652. name: "no RRO",
  653. enforceRROTargets: nil,
  654. enforceRROExcludedOverlays: nil,
  655. resourceFiles: map[string][]string{
  656. "foo": nil,
  657. "bar": {"bar/res/res/values/strings.xml"},
  658. "lib": nil,
  659. "lib2": {"lib2/res/res/values/strings.xml"},
  660. },
  661. overlayFiles: map[string][]string{
  662. "foo": {
  663. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  664. "out/soong/.intermediates/lib/android_common/package-res.apk",
  665. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  666. "foo/res/res/values/strings.xml",
  667. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  668. "device/vendor/blah/overlay/foo/res/values/strings.xml",
  669. "product/vendor/blah/overlay/foo/res/values/strings.xml",
  670. },
  671. "bar": {
  672. "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
  673. "device/vendor/blah/overlay/bar/res/values/strings.xml",
  674. },
  675. "lib": {
  676. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  677. "lib/res/res/values/strings.xml",
  678. "device/vendor/blah/overlay/lib/res/values/strings.xml",
  679. },
  680. },
  681. rroDirs: map[string][]string{
  682. "foo": nil,
  683. "bar": nil,
  684. },
  685. },
  686. {
  687. name: "enforce RRO on foo",
  688. enforceRROTargets: []string{"foo"},
  689. enforceRROExcludedOverlays: []string{"device/vendor/blah/static_overlay"},
  690. resourceFiles: map[string][]string{
  691. "foo": nil,
  692. "bar": {"bar/res/res/values/strings.xml"},
  693. "lib": nil,
  694. "lib2": {"lib2/res/res/values/strings.xml"},
  695. },
  696. overlayFiles: map[string][]string{
  697. "foo": {
  698. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  699. "out/soong/.intermediates/lib/android_common/package-res.apk",
  700. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  701. "foo/res/res/values/strings.xml",
  702. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  703. },
  704. "bar": {
  705. "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
  706. "device/vendor/blah/overlay/bar/res/values/strings.xml",
  707. },
  708. "lib": {
  709. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  710. "lib/res/res/values/strings.xml",
  711. },
  712. },
  713. rroDirs: map[string][]string{
  714. "foo": {
  715. "device:device/vendor/blah/overlay/foo/res",
  716. "product:product/vendor/blah/overlay/foo/res",
  717. "device:device/vendor/blah/overlay/lib/res",
  718. },
  719. "bar": nil,
  720. "lib": {"device:device/vendor/blah/overlay/lib/res"},
  721. },
  722. },
  723. {
  724. name: "enforce RRO on all",
  725. enforceRROTargets: []string{"*"},
  726. enforceRROExcludedOverlays: []string{
  727. // Excluding specific apps/res directories also allowed.
  728. "device/vendor/blah/static_overlay/foo",
  729. "device/vendor/blah/static_overlay/bar/res",
  730. },
  731. resourceFiles: map[string][]string{
  732. "foo": nil,
  733. "bar": {"bar/res/res/values/strings.xml"},
  734. "lib": nil,
  735. "lib2": {"lib2/res/res/values/strings.xml"},
  736. },
  737. overlayFiles: map[string][]string{
  738. "foo": {
  739. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  740. "out/soong/.intermediates/lib/android_common/package-res.apk",
  741. "out/soong/.intermediates/lib3/android_common/package-res.apk",
  742. "foo/res/res/values/strings.xml",
  743. "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
  744. },
  745. "bar": {"device/vendor/blah/static_overlay/bar/res/values/strings.xml"},
  746. "lib": {
  747. "out/soong/.intermediates/lib2/android_common/package-res.apk",
  748. "lib/res/res/values/strings.xml",
  749. },
  750. },
  751. rroDirs: map[string][]string{
  752. "foo": {
  753. "device:device/vendor/blah/overlay/foo/res",
  754. "product:product/vendor/blah/overlay/foo/res",
  755. // Lib dep comes after the direct deps
  756. "device:device/vendor/blah/overlay/lib/res",
  757. },
  758. "bar": {"device:device/vendor/blah/overlay/bar/res"},
  759. "lib": {"device:device/vendor/blah/overlay/lib/res"},
  760. },
  761. },
  762. }
  763. deviceResourceOverlays := []string{
  764. "device/vendor/blah/overlay",
  765. "device/vendor/blah/overlay2",
  766. "device/vendor/blah/static_overlay",
  767. }
  768. productResourceOverlays := []string{
  769. "product/vendor/blah/overlay",
  770. }
  771. fs := android.MockFS{
  772. "foo/res/res/values/strings.xml": nil,
  773. "bar/res/res/values/strings.xml": nil,
  774. "lib/res/res/values/strings.xml": nil,
  775. "lib2/res/res/values/strings.xml": nil,
  776. "device/vendor/blah/overlay/foo/res/values/strings.xml": nil,
  777. "device/vendor/blah/overlay/bar/res/values/strings.xml": nil,
  778. "device/vendor/blah/overlay/lib/res/values/strings.xml": nil,
  779. "device/vendor/blah/static_overlay/foo/res/values/strings.xml": nil,
  780. "device/vendor/blah/static_overlay/bar/res/values/strings.xml": nil,
  781. "device/vendor/blah/overlay2/res/values/strings.xml": nil,
  782. "product/vendor/blah/overlay/foo/res/values/strings.xml": nil,
  783. }
  784. bp := `
  785. android_app {
  786. name: "foo",
  787. sdk_version: "current",
  788. resource_dirs: ["foo/res"],
  789. static_libs: ["lib", "lib3"],
  790. }
  791. android_app {
  792. name: "bar",
  793. sdk_version: "current",
  794. resource_dirs: ["bar/res"],
  795. }
  796. android_library {
  797. name: "lib",
  798. sdk_version: "current",
  799. resource_dirs: ["lib/res"],
  800. static_libs: ["lib2"],
  801. }
  802. android_library {
  803. name: "lib2",
  804. sdk_version: "current",
  805. resource_dirs: ["lib2/res"],
  806. }
  807. // This library has the same resources as lib (should not lead to dupe RROs)
  808. android_library {
  809. name: "lib3",
  810. sdk_version: "current",
  811. resource_dirs: ["lib/res"]
  812. }
  813. `
  814. for _, testCase := range testCases {
  815. t.Run(testCase.name, func(t *testing.T) {
  816. result := android.GroupFixturePreparers(
  817. PrepareForTestWithJavaDefaultModules,
  818. PrepareForTestWithOverlayBuildComponents,
  819. fs.AddToFixture(),
  820. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  821. variables.DeviceResourceOverlays = deviceResourceOverlays
  822. variables.ProductResourceOverlays = productResourceOverlays
  823. if testCase.enforceRROTargets != nil {
  824. variables.EnforceRROTargets = testCase.enforceRROTargets
  825. }
  826. if testCase.enforceRROExcludedOverlays != nil {
  827. variables.EnforceRROExcludedOverlays = testCase.enforceRROExcludedOverlays
  828. }
  829. }),
  830. ).RunTestWithBp(t, bp)
  831. resourceListToFiles := func(module android.TestingModule, list []string) (files []string) {
  832. for _, o := range list {
  833. res := module.MaybeOutput(o)
  834. if res.Rule != nil {
  835. // If the overlay is compiled as part of this module (i.e. a .arsc.flat file),
  836. // verify the inputs to the .arsc.flat rule.
  837. files = append(files, res.Inputs.Strings()...)
  838. } else {
  839. // Otherwise, verify the full path to the output of the other module
  840. files = append(files, o)
  841. }
  842. }
  843. return files
  844. }
  845. getResources := func(moduleName string) (resourceFiles, overlayFiles, rroDirs []string) {
  846. module := result.ModuleForTests(moduleName, "android_common")
  847. resourceList := module.MaybeOutput("aapt2/res.list")
  848. if resourceList.Rule != nil {
  849. resourceFiles = resourceListToFiles(module, android.PathsRelativeToTop(resourceList.Inputs))
  850. }
  851. overlayList := module.MaybeOutput("aapt2/overlay.list")
  852. if overlayList.Rule != nil {
  853. overlayFiles = resourceListToFiles(module, android.PathsRelativeToTop(overlayList.Inputs))
  854. }
  855. for _, d := range module.Module().(AndroidLibraryDependency).ExportedRRODirs() {
  856. var prefix string
  857. if d.overlayType == device {
  858. prefix = "device:"
  859. } else if d.overlayType == product {
  860. prefix = "product:"
  861. } else {
  862. t.Fatalf("Unexpected overlayType %d", d.overlayType)
  863. }
  864. rroDirs = append(rroDirs, prefix+android.PathRelativeToTop(d.path))
  865. }
  866. return resourceFiles, overlayFiles, rroDirs
  867. }
  868. modules := []string{"foo", "bar", "lib", "lib2"}
  869. for _, module := range modules {
  870. resourceFiles, overlayFiles, rroDirs := getResources(module)
  871. if !reflect.DeepEqual(resourceFiles, testCase.resourceFiles[module]) {
  872. t.Errorf("expected %s resource files:\n %#v\n got:\n %#v",
  873. module, testCase.resourceFiles[module], resourceFiles)
  874. }
  875. if !reflect.DeepEqual(overlayFiles, testCase.overlayFiles[module]) {
  876. t.Errorf("expected %s overlay files:\n %#v\n got:\n %#v",
  877. module, testCase.overlayFiles[module], overlayFiles)
  878. }
  879. if !reflect.DeepEqual(rroDirs, testCase.rroDirs[module]) {
  880. t.Errorf("expected %s rroDirs: %#v\n got:\n %#v",
  881. module, testCase.rroDirs[module], rroDirs)
  882. }
  883. }
  884. })
  885. }
  886. }
  887. func checkSdkVersion(t *testing.T, result *android.TestResult, expectedSdkVersion string) {
  888. foo := result.ModuleForTests("foo", "android_common")
  889. link := foo.Output("package-res.apk")
  890. linkFlags := strings.Split(link.Args["flags"], " ")
  891. min := android.IndexList("--min-sdk-version", linkFlags)
  892. target := android.IndexList("--target-sdk-version", linkFlags)
  893. if min == -1 || target == -1 || min == len(linkFlags)-1 || target == len(linkFlags)-1 {
  894. t.Fatalf("missing --min-sdk-version or --target-sdk-version in link flags: %q", linkFlags)
  895. }
  896. gotMinSdkVersion := linkFlags[min+1]
  897. gotTargetSdkVersion := linkFlags[target+1]
  898. android.AssertStringEquals(t, "incorrect --min-sdk-version", expectedSdkVersion, gotMinSdkVersion)
  899. android.AssertStringEquals(t, "incorrect --target-sdk-version", expectedSdkVersion, gotTargetSdkVersion)
  900. }
  901. func TestAppSdkVersion(t *testing.T) {
  902. testCases := []struct {
  903. name string
  904. sdkVersion string
  905. platformSdkInt int
  906. platformSdkCodename string
  907. platformSdkFinal bool
  908. expectedMinSdkVersion string
  909. platformApis bool
  910. activeCodenames []string
  911. }{
  912. {
  913. name: "current final SDK",
  914. sdkVersion: "current",
  915. platformSdkInt: 27,
  916. platformSdkCodename: "REL",
  917. platformSdkFinal: true,
  918. expectedMinSdkVersion: "27",
  919. },
  920. {
  921. name: "current non-final SDK",
  922. sdkVersion: "current",
  923. platformSdkInt: 27,
  924. platformSdkCodename: "OMR1",
  925. platformSdkFinal: false,
  926. expectedMinSdkVersion: "OMR1",
  927. activeCodenames: []string{"OMR1"},
  928. },
  929. {
  930. name: "default final SDK",
  931. sdkVersion: "",
  932. platformApis: true,
  933. platformSdkInt: 27,
  934. platformSdkCodename: "REL",
  935. platformSdkFinal: true,
  936. expectedMinSdkVersion: "27",
  937. },
  938. {
  939. name: "default non-final SDK",
  940. sdkVersion: "",
  941. platformApis: true,
  942. platformSdkInt: 27,
  943. platformSdkCodename: "OMR1",
  944. platformSdkFinal: false,
  945. expectedMinSdkVersion: "OMR1",
  946. activeCodenames: []string{"OMR1"},
  947. },
  948. {
  949. name: "14",
  950. sdkVersion: "14",
  951. expectedMinSdkVersion: "14",
  952. platformSdkCodename: "S",
  953. activeCodenames: []string{"S"},
  954. },
  955. }
  956. for _, moduleType := range []string{"android_app", "android_library"} {
  957. for _, test := range testCases {
  958. t.Run(moduleType+" "+test.name, func(t *testing.T) {
  959. platformApiProp := ""
  960. if test.platformApis {
  961. platformApiProp = "platform_apis: true,"
  962. }
  963. bp := fmt.Sprintf(`%s {
  964. name: "foo",
  965. srcs: ["a.java"],
  966. sdk_version: "%s",
  967. %s
  968. }`, moduleType, test.sdkVersion, platformApiProp)
  969. result := android.GroupFixturePreparers(
  970. prepareForJavaTest,
  971. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  972. variables.Platform_sdk_version = &test.platformSdkInt
  973. variables.Platform_sdk_codename = &test.platformSdkCodename
  974. variables.Platform_version_active_codenames = test.activeCodenames
  975. variables.Platform_sdk_final = &test.platformSdkFinal
  976. }),
  977. FixtureWithPrebuiltApis(map[string][]string{
  978. "14": {"foo"},
  979. }),
  980. ).RunTestWithBp(t, bp)
  981. checkSdkVersion(t, result, test.expectedMinSdkVersion)
  982. })
  983. }
  984. }
  985. }
  986. func TestVendorAppSdkVersion(t *testing.T) {
  987. testCases := []struct {
  988. name string
  989. sdkVersion string
  990. platformSdkInt int
  991. platformSdkCodename string
  992. platformSdkFinal bool
  993. deviceCurrentApiLevelForVendorModules string
  994. expectedMinSdkVersion string
  995. }{
  996. {
  997. name: "current final SDK",
  998. sdkVersion: "current",
  999. platformSdkInt: 29,
  1000. platformSdkCodename: "REL",
  1001. platformSdkFinal: true,
  1002. deviceCurrentApiLevelForVendorModules: "29",
  1003. expectedMinSdkVersion: "29",
  1004. },
  1005. {
  1006. name: "current final SDK",
  1007. sdkVersion: "current",
  1008. platformSdkInt: 29,
  1009. platformSdkCodename: "REL",
  1010. platformSdkFinal: true,
  1011. deviceCurrentApiLevelForVendorModules: "28",
  1012. expectedMinSdkVersion: "28",
  1013. },
  1014. {
  1015. name: "current final SDK",
  1016. sdkVersion: "current",
  1017. platformSdkInt: 29,
  1018. platformSdkCodename: "Q",
  1019. platformSdkFinal: false,
  1020. deviceCurrentApiLevelForVendorModules: "28",
  1021. expectedMinSdkVersion: "28",
  1022. },
  1023. }
  1024. for _, moduleType := range []string{"android_app", "android_library"} {
  1025. for _, sdkKind := range []string{"", "system_"} {
  1026. for _, test := range testCases {
  1027. t.Run(moduleType+" "+test.name, func(t *testing.T) {
  1028. bp := fmt.Sprintf(`%s {
  1029. name: "foo",
  1030. srcs: ["a.java"],
  1031. sdk_version: "%s%s",
  1032. vendor: true,
  1033. }`, moduleType, sdkKind, test.sdkVersion)
  1034. result := android.GroupFixturePreparers(
  1035. prepareForJavaTest,
  1036. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1037. variables.Platform_sdk_version = &test.platformSdkInt
  1038. variables.Platform_sdk_codename = &test.platformSdkCodename
  1039. variables.Platform_sdk_final = &test.platformSdkFinal
  1040. variables.DeviceCurrentApiLevelForVendorModules = &test.deviceCurrentApiLevelForVendorModules
  1041. variables.DeviceSystemSdkVersions = []string{"28", "29"}
  1042. }),
  1043. FixtureWithPrebuiltApis(map[string][]string{
  1044. "28": {"foo"},
  1045. "29": {"foo"},
  1046. "current": {"foo"},
  1047. }),
  1048. ).RunTestWithBp(t, bp)
  1049. checkSdkVersion(t, result, test.expectedMinSdkVersion)
  1050. })
  1051. }
  1052. }
  1053. }
  1054. }
  1055. func TestJNIABI(t *testing.T) {
  1056. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1057. cc_library {
  1058. name: "libjni",
  1059. system_shared_libs: [],
  1060. sdk_version: "current",
  1061. stl: "none",
  1062. }
  1063. android_test {
  1064. name: "test",
  1065. sdk_version: "core_platform",
  1066. jni_libs: ["libjni"],
  1067. }
  1068. android_test {
  1069. name: "test_first",
  1070. sdk_version: "core_platform",
  1071. compile_multilib: "first",
  1072. jni_libs: ["libjni"],
  1073. }
  1074. android_test {
  1075. name: "test_both",
  1076. sdk_version: "core_platform",
  1077. compile_multilib: "both",
  1078. jni_libs: ["libjni"],
  1079. }
  1080. android_test {
  1081. name: "test_32",
  1082. sdk_version: "core_platform",
  1083. compile_multilib: "32",
  1084. jni_libs: ["libjni"],
  1085. }
  1086. android_test {
  1087. name: "test_64",
  1088. sdk_version: "core_platform",
  1089. compile_multilib: "64",
  1090. jni_libs: ["libjni"],
  1091. }
  1092. `)
  1093. testCases := []struct {
  1094. name string
  1095. abis []string
  1096. }{
  1097. {"test", []string{"arm64-v8a"}},
  1098. {"test_first", []string{"arm64-v8a"}},
  1099. {"test_both", []string{"arm64-v8a", "armeabi-v7a"}},
  1100. {"test_32", []string{"armeabi-v7a"}},
  1101. {"test_64", []string{"arm64-v8a"}},
  1102. }
  1103. for _, test := range testCases {
  1104. t.Run(test.name, func(t *testing.T) {
  1105. app := ctx.ModuleForTests(test.name, "android_common")
  1106. jniLibZip := app.Output(jniJarOutputPathString)
  1107. var abis []string
  1108. args := strings.Fields(jniLibZip.Args["jarArgs"])
  1109. for i := 0; i < len(args); i++ {
  1110. if args[i] == "-P" {
  1111. abis = append(abis, filepath.Base(args[i+1]))
  1112. i++
  1113. }
  1114. }
  1115. if !reflect.DeepEqual(abis, test.abis) {
  1116. t.Errorf("want abis %v, got %v", test.abis, abis)
  1117. }
  1118. })
  1119. }
  1120. }
  1121. func TestAppSdkVersionByPartition(t *testing.T) {
  1122. testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
  1123. android_app {
  1124. name: "foo",
  1125. srcs: ["a.java"],
  1126. vendor: true,
  1127. platform_apis: true,
  1128. }
  1129. `)
  1130. testJava(t, `
  1131. android_app {
  1132. name: "bar",
  1133. srcs: ["b.java"],
  1134. platform_apis: true,
  1135. }
  1136. `)
  1137. for _, enforce := range []bool{true, false} {
  1138. bp := `
  1139. android_app {
  1140. name: "foo",
  1141. srcs: ["a.java"],
  1142. product_specific: true,
  1143. platform_apis: true,
  1144. }
  1145. `
  1146. errorHandler := android.FixtureExpectsNoErrors
  1147. if enforce {
  1148. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
  1149. }
  1150. android.GroupFixturePreparers(
  1151. PrepareForTestWithJavaDefaultModules,
  1152. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1153. variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
  1154. }),
  1155. ).
  1156. ExtendWithErrorHandler(errorHandler).
  1157. RunTestWithBp(t, bp)
  1158. }
  1159. }
  1160. func TestJNIPackaging(t *testing.T) {
  1161. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1162. cc_library {
  1163. name: "libjni",
  1164. system_shared_libs: [],
  1165. stl: "none",
  1166. sdk_version: "current",
  1167. }
  1168. android_app {
  1169. name: "app",
  1170. jni_libs: ["libjni"],
  1171. sdk_version: "current",
  1172. }
  1173. android_app {
  1174. name: "app_noembed",
  1175. jni_libs: ["libjni"],
  1176. use_embedded_native_libs: false,
  1177. sdk_version: "current",
  1178. }
  1179. android_app {
  1180. name: "app_embed",
  1181. jni_libs: ["libjni"],
  1182. use_embedded_native_libs: true,
  1183. sdk_version: "current",
  1184. }
  1185. android_test {
  1186. name: "test",
  1187. sdk_version: "current",
  1188. jni_libs: ["libjni"],
  1189. }
  1190. android_test {
  1191. name: "test_noembed",
  1192. sdk_version: "current",
  1193. jni_libs: ["libjni"],
  1194. use_embedded_native_libs: false,
  1195. }
  1196. android_test_helper_app {
  1197. name: "test_helper",
  1198. sdk_version: "current",
  1199. jni_libs: ["libjni"],
  1200. }
  1201. android_test_helper_app {
  1202. name: "test_helper_noembed",
  1203. sdk_version: "current",
  1204. jni_libs: ["libjni"],
  1205. use_embedded_native_libs: false,
  1206. }
  1207. `)
  1208. testCases := []struct {
  1209. name string
  1210. packaged bool
  1211. compressed bool
  1212. }{
  1213. {"app", false, false},
  1214. {"app_noembed", false, false},
  1215. {"app_embed", true, false},
  1216. {"test", true, false},
  1217. {"test_noembed", true, true},
  1218. {"test_helper", true, false},
  1219. {"test_helper_noembed", true, true},
  1220. }
  1221. for _, test := range testCases {
  1222. t.Run(test.name, func(t *testing.T) {
  1223. app := ctx.ModuleForTests(test.name, "android_common")
  1224. jniLibZip := app.MaybeOutput(jniJarOutputPathString)
  1225. if g, w := (jniLibZip.Rule != nil), test.packaged; g != w {
  1226. t.Errorf("expected jni packaged %v, got %v", w, g)
  1227. }
  1228. if jniLibZip.Rule != nil {
  1229. if g, w := !strings.Contains(jniLibZip.Args["jarArgs"], "-L 0"), test.compressed; g != w {
  1230. t.Errorf("expected jni compressed %v, got %v", w, g)
  1231. }
  1232. if !strings.Contains(jniLibZip.Implicits[0].String(), "_sdk_") {
  1233. t.Errorf("expected input %q to use sdk variant", jniLibZip.Implicits[0].String())
  1234. }
  1235. }
  1236. })
  1237. }
  1238. }
  1239. func TestJNISDK(t *testing.T) {
  1240. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  1241. cc_library {
  1242. name: "libjni",
  1243. system_shared_libs: [],
  1244. stl: "none",
  1245. sdk_version: "current",
  1246. }
  1247. android_test {
  1248. name: "app_platform",
  1249. jni_libs: ["libjni"],
  1250. platform_apis: true,
  1251. }
  1252. android_test {
  1253. name: "app_sdk",
  1254. jni_libs: ["libjni"],
  1255. sdk_version: "current",
  1256. }
  1257. android_test {
  1258. name: "app_force_platform",
  1259. jni_libs: ["libjni"],
  1260. sdk_version: "current",
  1261. jni_uses_platform_apis: true,
  1262. }
  1263. android_test {
  1264. name: "app_force_sdk",
  1265. jni_libs: ["libjni"],
  1266. platform_apis: true,
  1267. jni_uses_sdk_apis: true,
  1268. }
  1269. cc_library {
  1270. name: "libvendorjni",
  1271. system_shared_libs: [],
  1272. stl: "none",
  1273. vendor: true,
  1274. }
  1275. android_test {
  1276. name: "app_vendor",
  1277. jni_libs: ["libvendorjni"],
  1278. sdk_version: "current",
  1279. vendor: true,
  1280. }
  1281. `)
  1282. testCases := []struct {
  1283. name string
  1284. sdkJNI bool
  1285. vendorJNI bool
  1286. }{
  1287. {name: "app_platform"},
  1288. {name: "app_sdk", sdkJNI: true},
  1289. {name: "app_force_platform"},
  1290. {name: "app_force_sdk", sdkJNI: true},
  1291. {name: "app_vendor", vendorJNI: true},
  1292. }
  1293. platformJNI := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_shared").
  1294. Output("libjni.so").Output.String()
  1295. sdkJNI := ctx.ModuleForTests("libjni", "android_arm64_armv8-a_sdk_shared").
  1296. Output("libjni.so").Output.String()
  1297. vendorJNI := ctx.ModuleForTests("libvendorjni", "android_arm64_armv8-a_shared").
  1298. Output("libvendorjni.so").Output.String()
  1299. for _, test := range testCases {
  1300. t.Run(test.name, func(t *testing.T) {
  1301. app := ctx.ModuleForTests(test.name, "android_common")
  1302. jniLibZip := app.MaybeOutput(jniJarOutputPathString)
  1303. if len(jniLibZip.Implicits) != 1 {
  1304. t.Fatalf("expected exactly one jni library, got %q", jniLibZip.Implicits.Strings())
  1305. }
  1306. gotJNI := jniLibZip.Implicits[0].String()
  1307. if test.sdkJNI {
  1308. if gotJNI != sdkJNI {
  1309. t.Errorf("expected SDK JNI library %q, got %q", sdkJNI, gotJNI)
  1310. }
  1311. } else if test.vendorJNI {
  1312. if gotJNI != vendorJNI {
  1313. t.Errorf("expected platform JNI library %q, got %q", vendorJNI, gotJNI)
  1314. }
  1315. } else {
  1316. if gotJNI != platformJNI {
  1317. t.Errorf("expected platform JNI library %q, got %q", platformJNI, gotJNI)
  1318. }
  1319. }
  1320. })
  1321. }
  1322. t.Run("jni_uses_platform_apis_error", func(t *testing.T) {
  1323. testJavaError(t, `jni_uses_platform_apis: can only be set for modules that set sdk_version`, `
  1324. android_test {
  1325. name: "app_platform",
  1326. platform_apis: true,
  1327. jni_uses_platform_apis: true,
  1328. }
  1329. `)
  1330. })
  1331. t.Run("jni_uses_sdk_apis_error", func(t *testing.T) {
  1332. testJavaError(t, `jni_uses_sdk_apis: can only be set for modules that do not set sdk_version`, `
  1333. android_test {
  1334. name: "app_sdk",
  1335. sdk_version: "current",
  1336. jni_uses_sdk_apis: true,
  1337. }
  1338. `)
  1339. })
  1340. }
  1341. func TestCertificates(t *testing.T) {
  1342. testCases := []struct {
  1343. name string
  1344. bp string
  1345. allowMissingDependencies bool
  1346. certificateOverride string
  1347. expectedCertSigningFlags string
  1348. expectedCertificate string
  1349. }{
  1350. {
  1351. name: "default",
  1352. bp: `
  1353. android_app {
  1354. name: "foo",
  1355. srcs: ["a.java"],
  1356. sdk_version: "current",
  1357. }
  1358. `,
  1359. certificateOverride: "",
  1360. expectedCertSigningFlags: "",
  1361. expectedCertificate: "build/make/target/product/security/testkey",
  1362. },
  1363. {
  1364. name: "module certificate property",
  1365. bp: `
  1366. android_app {
  1367. name: "foo",
  1368. srcs: ["a.java"],
  1369. certificate: ":new_certificate",
  1370. sdk_version: "current",
  1371. }
  1372. android_app_certificate {
  1373. name: "new_certificate",
  1374. certificate: "cert/new_cert",
  1375. }
  1376. `,
  1377. certificateOverride: "",
  1378. expectedCertSigningFlags: "",
  1379. expectedCertificate: "cert/new_cert",
  1380. },
  1381. {
  1382. name: "path certificate property",
  1383. bp: `
  1384. android_app {
  1385. name: "foo",
  1386. srcs: ["a.java"],
  1387. certificate: "expiredkey",
  1388. sdk_version: "current",
  1389. }
  1390. `,
  1391. certificateOverride: "",
  1392. expectedCertSigningFlags: "",
  1393. expectedCertificate: "build/make/target/product/security/expiredkey",
  1394. },
  1395. {
  1396. name: "certificate overrides",
  1397. bp: `
  1398. android_app {
  1399. name: "foo",
  1400. srcs: ["a.java"],
  1401. certificate: "expiredkey",
  1402. sdk_version: "current",
  1403. }
  1404. android_app_certificate {
  1405. name: "new_certificate",
  1406. certificate: "cert/new_cert",
  1407. }
  1408. `,
  1409. certificateOverride: "foo:new_certificate",
  1410. expectedCertSigningFlags: "",
  1411. expectedCertificate: "cert/new_cert",
  1412. },
  1413. {
  1414. name: "certificate signing flags",
  1415. bp: `
  1416. android_app {
  1417. name: "foo",
  1418. srcs: ["a.java"],
  1419. certificate: ":new_certificate",
  1420. lineage: "lineage.bin",
  1421. rotationMinSdkVersion: "32",
  1422. sdk_version: "current",
  1423. }
  1424. android_app_certificate {
  1425. name: "new_certificate",
  1426. certificate: "cert/new_cert",
  1427. }
  1428. `,
  1429. certificateOverride: "",
  1430. expectedCertSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1431. expectedCertificate: "cert/new_cert",
  1432. },
  1433. {
  1434. name: "cert signing flags from filegroup",
  1435. bp: `
  1436. android_app {
  1437. name: "foo",
  1438. srcs: ["a.java"],
  1439. certificate: ":new_certificate",
  1440. lineage: ":lineage_bin",
  1441. rotationMinSdkVersion: "32",
  1442. sdk_version: "current",
  1443. }
  1444. android_app_certificate {
  1445. name: "new_certificate",
  1446. certificate: "cert/new_cert",
  1447. }
  1448. filegroup {
  1449. name: "lineage_bin",
  1450. srcs: ["lineage.bin"],
  1451. }
  1452. `,
  1453. certificateOverride: "",
  1454. expectedCertSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1455. expectedCertificate: "cert/new_cert",
  1456. },
  1457. {
  1458. name: "missing with AllowMissingDependencies",
  1459. bp: `
  1460. android_app {
  1461. name: "foo",
  1462. srcs: ["a.java"],
  1463. certificate: ":new_certificate",
  1464. sdk_version: "current",
  1465. }
  1466. `,
  1467. expectedCertificate: "out/soong/.intermediates/foo/android_common/missing",
  1468. allowMissingDependencies: true,
  1469. },
  1470. }
  1471. for _, test := range testCases {
  1472. t.Run(test.name, func(t *testing.T) {
  1473. result := android.GroupFixturePreparers(
  1474. PrepareForTestWithJavaDefaultModules,
  1475. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1476. if test.certificateOverride != "" {
  1477. variables.CertificateOverrides = []string{test.certificateOverride}
  1478. }
  1479. if test.allowMissingDependencies {
  1480. variables.Allow_missing_dependencies = proptools.BoolPtr(true)
  1481. }
  1482. }),
  1483. android.FixtureModifyContext(func(ctx *android.TestContext) {
  1484. ctx.SetAllowMissingDependencies(test.allowMissingDependencies)
  1485. }),
  1486. ).RunTestWithBp(t, test.bp)
  1487. foo := result.ModuleForTests("foo", "android_common")
  1488. certificate := foo.Module().(*AndroidApp).certificate
  1489. android.AssertPathRelativeToTopEquals(t, "certificates key", test.expectedCertificate+".pk8", certificate.Key)
  1490. // The sign_target_files_apks and check_target_files_signatures
  1491. // tools require that certificates have a .x509.pem extension.
  1492. android.AssertPathRelativeToTopEquals(t, "certificates pem", test.expectedCertificate+".x509.pem", certificate.Pem)
  1493. signapk := foo.Output("foo.apk")
  1494. if signapk.Rule != android.ErrorRule {
  1495. signCertificateFlags := signapk.Args["certificates"]
  1496. expectedFlags := certificate.Pem.String() + " " + certificate.Key.String()
  1497. android.AssertStringEquals(t, "certificates flags", expectedFlags, signCertificateFlags)
  1498. certSigningFlags := signapk.Args["flags"]
  1499. android.AssertStringEquals(t, "cert signing flags", test.expectedCertSigningFlags, certSigningFlags)
  1500. }
  1501. })
  1502. }
  1503. }
  1504. func TestRequestV4SigningFlag(t *testing.T) {
  1505. testCases := []struct {
  1506. name string
  1507. bp string
  1508. expected string
  1509. }{
  1510. {
  1511. name: "default",
  1512. bp: `
  1513. android_app {
  1514. name: "foo",
  1515. srcs: ["a.java"],
  1516. sdk_version: "current",
  1517. }
  1518. `,
  1519. expected: "",
  1520. },
  1521. {
  1522. name: "default",
  1523. bp: `
  1524. android_app {
  1525. name: "foo",
  1526. srcs: ["a.java"],
  1527. sdk_version: "current",
  1528. v4_signature: false,
  1529. }
  1530. `,
  1531. expected: "",
  1532. },
  1533. {
  1534. name: "module certificate property",
  1535. bp: `
  1536. android_app {
  1537. name: "foo",
  1538. srcs: ["a.java"],
  1539. sdk_version: "current",
  1540. v4_signature: true,
  1541. }
  1542. `,
  1543. expected: "--enable-v4",
  1544. },
  1545. }
  1546. for _, test := range testCases {
  1547. t.Run(test.name, func(t *testing.T) {
  1548. result := android.GroupFixturePreparers(
  1549. PrepareForTestWithJavaDefaultModules,
  1550. ).RunTestWithBp(t, test.bp)
  1551. foo := result.ModuleForTests("foo", "android_common")
  1552. signapk := foo.Output("foo.apk")
  1553. signFlags := signapk.Args["flags"]
  1554. android.AssertStringEquals(t, "signing flags", test.expected, signFlags)
  1555. })
  1556. }
  1557. }
  1558. func TestPackageNameOverride(t *testing.T) {
  1559. testCases := []struct {
  1560. name string
  1561. bp string
  1562. packageNameOverride string
  1563. expected []string
  1564. }{
  1565. {
  1566. name: "default",
  1567. bp: `
  1568. android_app {
  1569. name: "foo",
  1570. srcs: ["a.java"],
  1571. sdk_version: "current",
  1572. }
  1573. `,
  1574. packageNameOverride: "",
  1575. expected: []string{
  1576. "out/soong/.intermediates/foo/android_common/foo.apk",
  1577. "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1578. },
  1579. },
  1580. {
  1581. name: "overridden via PRODUCT_PACKAGE_NAME_OVERRIDES",
  1582. bp: `
  1583. android_app {
  1584. name: "foo",
  1585. srcs: ["a.java"],
  1586. sdk_version: "current",
  1587. }
  1588. `,
  1589. packageNameOverride: "foo:bar",
  1590. expected: []string{
  1591. // The package apk should be still be the original name for test dependencies.
  1592. "out/soong/.intermediates/foo/android_common/bar.apk",
  1593. "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1594. },
  1595. },
  1596. {
  1597. name: "overridden via stem",
  1598. bp: `
  1599. android_app {
  1600. name: "foo",
  1601. srcs: ["a.java"],
  1602. sdk_version: "current",
  1603. stem: "bar",
  1604. }
  1605. `,
  1606. packageNameOverride: "",
  1607. expected: []string{
  1608. "out/soong/.intermediates/foo/android_common/bar.apk",
  1609. "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1610. },
  1611. },
  1612. }
  1613. for _, test := range testCases {
  1614. t.Run(test.name, func(t *testing.T) {
  1615. result := android.GroupFixturePreparers(
  1616. PrepareForTestWithJavaDefaultModules,
  1617. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1618. if test.packageNameOverride != "" {
  1619. variables.PackageNameOverrides = []string{test.packageNameOverride}
  1620. }
  1621. }),
  1622. ).RunTestWithBp(t, test.bp)
  1623. foo := result.ModuleForTests("foo", "android_common")
  1624. outSoongDir := result.Config.SoongOutDir()
  1625. outputs := foo.AllOutputs()
  1626. outputMap := make(map[string]bool)
  1627. for _, o := range outputs {
  1628. outputMap[android.StringPathRelativeToTop(outSoongDir, o)] = true
  1629. }
  1630. for _, e := range test.expected {
  1631. if _, exist := outputMap[e]; !exist {
  1632. t.Errorf("Can't find %q in output files.\nAll outputs:%v", e, outputs)
  1633. }
  1634. }
  1635. })
  1636. }
  1637. }
  1638. func TestInstrumentationTargetOverridden(t *testing.T) {
  1639. bp := `
  1640. android_app {
  1641. name: "foo",
  1642. srcs: ["a.java"],
  1643. sdk_version: "current",
  1644. }
  1645. android_test {
  1646. name: "bar",
  1647. instrumentation_for: "foo",
  1648. sdk_version: "current",
  1649. }
  1650. `
  1651. result := android.GroupFixturePreparers(
  1652. PrepareForTestWithJavaDefaultModules,
  1653. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1654. variables.ManifestPackageNameOverrides = []string{"foo:org.dandroid.bp"}
  1655. }),
  1656. ).RunTestWithBp(t, bp)
  1657. bar := result.ModuleForTests("bar", "android_common")
  1658. res := bar.Output("package-res.apk")
  1659. aapt2Flags := res.Args["flags"]
  1660. e := "--rename-instrumentation-target-package org.dandroid.bp"
  1661. if !strings.Contains(aapt2Flags, e) {
  1662. t.Errorf("target package renaming flag, %q is missing in aapt2 link flags, %q", e, aapt2Flags)
  1663. }
  1664. }
  1665. func TestOverrideAndroidApp(t *testing.T) {
  1666. result := PrepareForTestWithJavaDefaultModules.RunTestWithBp(
  1667. t, `
  1668. android_app {
  1669. name: "foo",
  1670. srcs: ["a.java"],
  1671. certificate: "expiredkey",
  1672. overrides: ["qux"],
  1673. sdk_version: "current",
  1674. }
  1675. override_android_app {
  1676. name: "bar",
  1677. base: "foo",
  1678. certificate: ":new_certificate",
  1679. lineage: "lineage.bin",
  1680. rotationMinSdkVersion: "32",
  1681. logging_parent: "bah",
  1682. }
  1683. android_app_certificate {
  1684. name: "new_certificate",
  1685. certificate: "cert/new_cert",
  1686. }
  1687. override_android_app {
  1688. name: "baz",
  1689. base: "foo",
  1690. package_name: "org.dandroid.bp",
  1691. }
  1692. override_android_app {
  1693. name: "baz_no_rename_resources",
  1694. base: "foo",
  1695. package_name: "org.dandroid.bp",
  1696. rename_resources_package: false,
  1697. }
  1698. android_app {
  1699. name: "foo_no_rename_resources",
  1700. srcs: ["a.java"],
  1701. certificate: "expiredkey",
  1702. overrides: ["qux"],
  1703. rename_resources_package: false,
  1704. sdk_version: "current",
  1705. }
  1706. override_android_app {
  1707. name: "baz_base_no_rename_resources",
  1708. base: "foo_no_rename_resources",
  1709. package_name: "org.dandroid.bp",
  1710. }
  1711. override_android_app {
  1712. name: "baz_override_base_rename_resources",
  1713. base: "foo_no_rename_resources",
  1714. package_name: "org.dandroid.bp",
  1715. rename_resources_package: true,
  1716. }
  1717. `)
  1718. expectedVariants := []struct {
  1719. name string
  1720. moduleName string
  1721. variantName string
  1722. apkName string
  1723. apkPath string
  1724. certFlag string
  1725. certSigningFlags string
  1726. overrides []string
  1727. packageFlag string
  1728. renameResources bool
  1729. logging_parent string
  1730. }{
  1731. {
  1732. name: "foo",
  1733. moduleName: "foo",
  1734. variantName: "android_common",
  1735. apkPath: "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1736. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1737. certSigningFlags: "",
  1738. overrides: []string{"qux"},
  1739. packageFlag: "",
  1740. renameResources: false,
  1741. logging_parent: "",
  1742. },
  1743. {
  1744. name: "foo",
  1745. moduleName: "bar",
  1746. variantName: "android_common_bar",
  1747. apkPath: "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1748. certFlag: "cert/new_cert.x509.pem cert/new_cert.pk8",
  1749. certSigningFlags: "--lineage lineage.bin --rotation-min-sdk-version 32",
  1750. overrides: []string{"qux", "foo"},
  1751. packageFlag: "",
  1752. renameResources: false,
  1753. logging_parent: "bah",
  1754. },
  1755. {
  1756. name: "foo",
  1757. moduleName: "baz",
  1758. variantName: "android_common_baz",
  1759. apkPath: "out/soong/target/product/test_device/system/app/baz/baz.apk",
  1760. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1761. certSigningFlags: "",
  1762. overrides: []string{"qux", "foo"},
  1763. packageFlag: "org.dandroid.bp",
  1764. renameResources: true,
  1765. logging_parent: "",
  1766. },
  1767. {
  1768. name: "foo",
  1769. moduleName: "baz_no_rename_resources",
  1770. variantName: "android_common_baz_no_rename_resources",
  1771. apkPath: "out/soong/target/product/test_device/system/app/baz_no_rename_resources/baz_no_rename_resources.apk",
  1772. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1773. certSigningFlags: "",
  1774. overrides: []string{"qux", "foo"},
  1775. packageFlag: "org.dandroid.bp",
  1776. renameResources: false,
  1777. logging_parent: "",
  1778. },
  1779. {
  1780. name: "foo_no_rename_resources",
  1781. moduleName: "baz_base_no_rename_resources",
  1782. variantName: "android_common_baz_base_no_rename_resources",
  1783. apkPath: "out/soong/target/product/test_device/system/app/baz_base_no_rename_resources/baz_base_no_rename_resources.apk",
  1784. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1785. certSigningFlags: "",
  1786. overrides: []string{"qux", "foo_no_rename_resources"},
  1787. packageFlag: "org.dandroid.bp",
  1788. renameResources: false,
  1789. logging_parent: "",
  1790. },
  1791. {
  1792. name: "foo_no_rename_resources",
  1793. moduleName: "baz_override_base_rename_resources",
  1794. variantName: "android_common_baz_override_base_rename_resources",
  1795. apkPath: "out/soong/target/product/test_device/system/app/baz_override_base_rename_resources/baz_override_base_rename_resources.apk",
  1796. certFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
  1797. certSigningFlags: "",
  1798. overrides: []string{"qux", "foo_no_rename_resources"},
  1799. packageFlag: "org.dandroid.bp",
  1800. renameResources: true,
  1801. logging_parent: "",
  1802. },
  1803. }
  1804. for _, expected := range expectedVariants {
  1805. variant := result.ModuleForTests(expected.name, expected.variantName)
  1806. // Check the final apk name
  1807. variant.Output(expected.apkPath)
  1808. // Check the certificate paths
  1809. signapk := variant.Output(expected.moduleName + ".apk")
  1810. certFlag := signapk.Args["certificates"]
  1811. android.AssertStringEquals(t, "certificates flags", expected.certFlag, certFlag)
  1812. // Check the cert signing flags
  1813. certSigningFlags := signapk.Args["flags"]
  1814. android.AssertStringEquals(t, "cert signing flags", expected.certSigningFlags, certSigningFlags)
  1815. // Check if the overrides field values are correctly aggregated.
  1816. mod := variant.Module().(*AndroidApp)
  1817. android.AssertDeepEquals(t, "overrides property", expected.overrides, mod.overridableAppProperties.Overrides)
  1818. // Test Overridable property: Logging_parent
  1819. logging_parent := mod.aapt.LoggingParent
  1820. android.AssertStringEquals(t, "overrides property value for logging parent", expected.logging_parent, logging_parent)
  1821. // Check the package renaming flag, if exists.
  1822. res := variant.Output("package-res.apk")
  1823. aapt2Flags := res.Args["flags"]
  1824. checkAapt2LinkFlag(t, aapt2Flags, "rename-manifest-package", expected.packageFlag)
  1825. expectedPackage := expected.packageFlag
  1826. if !expected.renameResources {
  1827. expectedPackage = ""
  1828. }
  1829. checkAapt2LinkFlag(t, aapt2Flags, "rename-resources-package", expectedPackage)
  1830. }
  1831. }
  1832. func TestOverrideAndroidAppOverrides(t *testing.T) {
  1833. ctx, _ := testJava(
  1834. t, `
  1835. android_app {
  1836. name: "foo",
  1837. srcs: ["a.java"],
  1838. sdk_version: "current",
  1839. overrides: ["qux"]
  1840. }
  1841. android_app {
  1842. name: "bar",
  1843. srcs: ["b.java"],
  1844. sdk_version: "current",
  1845. overrides: ["foo"]
  1846. }
  1847. override_android_app {
  1848. name: "foo_override",
  1849. base: "foo",
  1850. overrides: ["bar"]
  1851. }
  1852. `)
  1853. expectedVariants := []struct {
  1854. name string
  1855. moduleName string
  1856. variantName string
  1857. overrides []string
  1858. }{
  1859. {
  1860. name: "foo",
  1861. moduleName: "foo",
  1862. variantName: "android_common",
  1863. overrides: []string{"qux"},
  1864. },
  1865. {
  1866. name: "bar",
  1867. moduleName: "bar",
  1868. variantName: "android_common",
  1869. overrides: []string{"foo"},
  1870. },
  1871. {
  1872. name: "foo",
  1873. moduleName: "foo_override",
  1874. variantName: "android_common_foo_override",
  1875. overrides: []string{"bar", "foo"},
  1876. },
  1877. }
  1878. for _, expected := range expectedVariants {
  1879. variant := ctx.ModuleForTests(expected.name, expected.variantName)
  1880. // Check if the overrides field values are correctly aggregated.
  1881. mod := variant.Module().(*AndroidApp)
  1882. android.AssertDeepEquals(t, "overrides property", expected.overrides, mod.overridableAppProperties.Overrides)
  1883. }
  1884. }
  1885. func TestOverrideAndroidAppWithPrebuilt(t *testing.T) {
  1886. result := PrepareForTestWithJavaDefaultModules.RunTestWithBp(
  1887. t, `
  1888. android_app {
  1889. name: "foo",
  1890. srcs: ["a.java"],
  1891. sdk_version: "current",
  1892. }
  1893. override_android_app {
  1894. name: "bar",
  1895. base: "foo",
  1896. }
  1897. android_app_import {
  1898. name: "bar",
  1899. prefer: true,
  1900. apk: "bar.apk",
  1901. presigned: true,
  1902. }
  1903. `)
  1904. // An app that has an override that also has a prebuilt should not be hidden.
  1905. foo := result.ModuleForTests("foo", "android_common")
  1906. if foo.Module().IsHideFromMake() {
  1907. t.Errorf("expected foo to have HideFromMake false")
  1908. }
  1909. // An override that also has a prebuilt should be hidden.
  1910. barOverride := result.ModuleForTests("foo", "android_common_bar")
  1911. if !barOverride.Module().IsHideFromMake() {
  1912. t.Errorf("expected bar override variant of foo to have HideFromMake true")
  1913. }
  1914. }
  1915. func TestOverrideAndroidAppStem(t *testing.T) {
  1916. ctx, _ := testJava(t, `
  1917. android_app {
  1918. name: "foo",
  1919. srcs: ["a.java"],
  1920. sdk_version: "current",
  1921. }
  1922. override_android_app {
  1923. name: "bar",
  1924. base: "foo",
  1925. }
  1926. override_android_app {
  1927. name: "baz",
  1928. base: "foo",
  1929. stem: "baz_stem",
  1930. }
  1931. android_app {
  1932. name: "foo2",
  1933. srcs: ["a.java"],
  1934. sdk_version: "current",
  1935. stem: "foo2_stem",
  1936. }
  1937. override_android_app {
  1938. name: "bar2",
  1939. base: "foo2",
  1940. }
  1941. override_android_app {
  1942. name: "baz2",
  1943. base: "foo2",
  1944. stem: "baz2_stem",
  1945. }
  1946. `)
  1947. for _, expected := range []struct {
  1948. moduleName string
  1949. variantName string
  1950. apkPath string
  1951. }{
  1952. {
  1953. moduleName: "foo",
  1954. variantName: "android_common",
  1955. apkPath: "out/soong/target/product/test_device/system/app/foo/foo.apk",
  1956. },
  1957. {
  1958. moduleName: "foo",
  1959. variantName: "android_common_bar",
  1960. apkPath: "out/soong/target/product/test_device/system/app/bar/bar.apk",
  1961. },
  1962. {
  1963. moduleName: "foo",
  1964. variantName: "android_common_baz",
  1965. apkPath: "out/soong/target/product/test_device/system/app/baz_stem/baz_stem.apk",
  1966. },
  1967. {
  1968. moduleName: "foo2",
  1969. variantName: "android_common",
  1970. apkPath: "out/soong/target/product/test_device/system/app/foo2_stem/foo2_stem.apk",
  1971. },
  1972. {
  1973. moduleName: "foo2",
  1974. variantName: "android_common_bar2",
  1975. // Note that this may cause the duplicate output error.
  1976. apkPath: "out/soong/target/product/test_device/system/app/foo2_stem/foo2_stem.apk",
  1977. },
  1978. {
  1979. moduleName: "foo2",
  1980. variantName: "android_common_baz2",
  1981. apkPath: "out/soong/target/product/test_device/system/app/baz2_stem/baz2_stem.apk",
  1982. },
  1983. } {
  1984. variant := ctx.ModuleForTests(expected.moduleName, expected.variantName)
  1985. variant.Output(expected.apkPath)
  1986. }
  1987. }
  1988. func TestOverrideAndroidAppDependency(t *testing.T) {
  1989. ctx, _ := testJava(t, `
  1990. android_app {
  1991. name: "foo",
  1992. srcs: ["a.java"],
  1993. sdk_version: "current",
  1994. }
  1995. override_android_app {
  1996. name: "bar",
  1997. base: "foo",
  1998. package_name: "org.dandroid.bp",
  1999. }
  2000. android_test {
  2001. name: "baz",
  2002. srcs: ["b.java"],
  2003. instrumentation_for: "foo",
  2004. }
  2005. android_test {
  2006. name: "qux",
  2007. srcs: ["b.java"],
  2008. instrumentation_for: "bar",
  2009. }
  2010. `)
  2011. // Verify baz, which depends on the overridden module foo, has the correct classpath javac arg.
  2012. javac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
  2013. fooTurbine := "out/soong/.intermediates/foo/android_common/turbine-combined/foo.jar"
  2014. if !strings.Contains(javac.Args["classpath"], fooTurbine) {
  2015. t.Errorf("baz classpath %v does not contain %q", javac.Args["classpath"], fooTurbine)
  2016. }
  2017. // Verify qux, which depends on the overriding module bar, has the correct classpath javac arg.
  2018. javac = ctx.ModuleForTests("qux", "android_common").Rule("javac")
  2019. barTurbine := "out/soong/.intermediates/foo/android_common_bar/turbine-combined/foo.jar"
  2020. if !strings.Contains(javac.Args["classpath"], barTurbine) {
  2021. t.Errorf("qux classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
  2022. }
  2023. }
  2024. func TestOverrideAndroidTest(t *testing.T) {
  2025. ctx, _ := testJava(t, `
  2026. android_app {
  2027. name: "foo",
  2028. srcs: ["a.java"],
  2029. package_name: "com.android.foo",
  2030. sdk_version: "current",
  2031. }
  2032. override_android_app {
  2033. name: "bar",
  2034. base: "foo",
  2035. package_name: "com.android.bar",
  2036. }
  2037. android_test {
  2038. name: "foo_test",
  2039. srcs: ["b.java"],
  2040. instrumentation_for: "foo",
  2041. }
  2042. override_android_test {
  2043. name: "bar_test",
  2044. base: "foo_test",
  2045. package_name: "com.android.bar.test",
  2046. instrumentation_for: "bar",
  2047. instrumentation_target_package: "com.android.bar",
  2048. }
  2049. `)
  2050. expectedVariants := []struct {
  2051. moduleName string
  2052. variantName string
  2053. apkPath string
  2054. overrides []string
  2055. targetVariant string
  2056. packageFlag string
  2057. targetPackageFlag string
  2058. }{
  2059. {
  2060. variantName: "android_common",
  2061. apkPath: "/target/product/test_device/testcases/foo_test/arm64/foo_test.apk",
  2062. overrides: nil,
  2063. targetVariant: "android_common",
  2064. packageFlag: "",
  2065. targetPackageFlag: "",
  2066. },
  2067. {
  2068. variantName: "android_common_bar_test",
  2069. apkPath: "/target/product/test_device/testcases/bar_test/arm64/bar_test.apk",
  2070. overrides: []string{"foo_test"},
  2071. targetVariant: "android_common_bar",
  2072. packageFlag: "com.android.bar.test",
  2073. targetPackageFlag: "com.android.bar",
  2074. },
  2075. }
  2076. for _, expected := range expectedVariants {
  2077. variant := ctx.ModuleForTests("foo_test", expected.variantName)
  2078. // Check the final apk name
  2079. variant.Output("out/soong" + expected.apkPath)
  2080. // Check if the overrides field values are correctly aggregated.
  2081. mod := variant.Module().(*AndroidTest)
  2082. if !reflect.DeepEqual(expected.overrides, mod.overridableAppProperties.Overrides) {
  2083. t.Errorf("Incorrect overrides property value, expected: %q, got: %q",
  2084. expected.overrides, mod.overridableAppProperties.Overrides)
  2085. }
  2086. // Check if javac classpath has the correct jar file path. This checks instrumentation_for overrides.
  2087. javac := variant.Rule("javac")
  2088. turbine := filepath.Join("out", "soong", ".intermediates", "foo", expected.targetVariant, "turbine-combined", "foo.jar")
  2089. if !strings.Contains(javac.Args["classpath"], turbine) {
  2090. t.Errorf("classpath %q does not contain %q", javac.Args["classpath"], turbine)
  2091. }
  2092. // Check aapt2 flags.
  2093. res := variant.Output("package-res.apk")
  2094. aapt2Flags := res.Args["flags"]
  2095. checkAapt2LinkFlag(t, aapt2Flags, "rename-manifest-package", expected.packageFlag)
  2096. checkAapt2LinkFlag(t, aapt2Flags, "rename-resources-package", expected.packageFlag)
  2097. checkAapt2LinkFlag(t, aapt2Flags, "rename-instrumentation-target-package", expected.targetPackageFlag)
  2098. }
  2099. }
  2100. func TestAndroidTest_FixTestConfig(t *testing.T) {
  2101. ctx, _ := testJava(t, `
  2102. android_app {
  2103. name: "foo",
  2104. srcs: ["a.java"],
  2105. package_name: "com.android.foo",
  2106. sdk_version: "current",
  2107. }
  2108. android_test {
  2109. name: "foo_test",
  2110. srcs: ["b.java"],
  2111. instrumentation_for: "foo",
  2112. }
  2113. android_test {
  2114. name: "bar_test",
  2115. srcs: ["b.java"],
  2116. package_name: "com.android.bar.test",
  2117. instrumentation_for: "foo",
  2118. mainline_package_name: "com.android.bar",
  2119. }
  2120. override_android_test {
  2121. name: "baz_test",
  2122. base: "foo_test",
  2123. package_name: "com.android.baz.test",
  2124. mainline_package_name: "com.android.baz",
  2125. }
  2126. `)
  2127. testCases := []struct {
  2128. moduleName string
  2129. variantName string
  2130. expectedFlags []string
  2131. }{
  2132. {
  2133. moduleName: "foo_test",
  2134. variantName: "android_common",
  2135. },
  2136. {
  2137. moduleName: "bar_test",
  2138. variantName: "android_common",
  2139. expectedFlags: []string{
  2140. "--manifest out/soong/.intermediates/bar_test/android_common/manifest_fixer/AndroidManifest.xml",
  2141. "--package-name com.android.bar.test",
  2142. "--mainline-package-name com.android.bar",
  2143. },
  2144. },
  2145. {
  2146. moduleName: "foo_test",
  2147. variantName: "android_common_baz_test",
  2148. expectedFlags: []string{
  2149. "--manifest out/soong/.intermediates/foo_test/android_common_baz_test/manifest_fixer/AndroidManifest.xml",
  2150. "--package-name com.android.baz.test",
  2151. "--test-file-name baz_test.apk",
  2152. "out/soong/.intermediates/foo_test/android_common_baz_test/test_config_fixer/AndroidTest.xml",
  2153. "--mainline-package-name com.android.baz",
  2154. },
  2155. },
  2156. }
  2157. for _, test := range testCases {
  2158. variant := ctx.ModuleForTests(test.moduleName, test.variantName)
  2159. params := variant.MaybeOutput("test_config_fixer/AndroidTest.xml")
  2160. if len(test.expectedFlags) > 0 {
  2161. if params.Rule == nil {
  2162. t.Errorf("test_config_fixer was expected to run, but didn't")
  2163. } else {
  2164. for _, flag := range test.expectedFlags {
  2165. if !strings.Contains(params.RuleParams.Command, flag) {
  2166. t.Errorf("Flag %q was not found in command: %q", flag, params.RuleParams.Command)
  2167. }
  2168. }
  2169. }
  2170. } else {
  2171. if params.Rule != nil {
  2172. t.Errorf("test_config_fixer was not expected to run, but did: %q", params.RuleParams.Command)
  2173. }
  2174. }
  2175. }
  2176. }
  2177. func TestInstrumentationTargetPrebuilt(t *testing.T) {
  2178. bp := `
  2179. android_app_import {
  2180. name: "foo",
  2181. apk: "foo.apk",
  2182. presigned: true,
  2183. }
  2184. android_test {
  2185. name: "bar",
  2186. srcs: ["a.java"],
  2187. instrumentation_for: "foo",
  2188. sdk_version: "current",
  2189. }
  2190. `
  2191. android.GroupFixturePreparers(
  2192. PrepareForTestWithJavaDefaultModules,
  2193. ).ExtendWithErrorHandler(
  2194. android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  2195. "instrumentation_for: dependency \"foo\" of type \"android_app_import\" does not provide JavaInfo so is unsuitable for use with this property")).
  2196. RunTestWithBp(t, bp)
  2197. }
  2198. func TestStl(t *testing.T) {
  2199. ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
  2200. cc_library {
  2201. name: "libjni",
  2202. sdk_version: "current",
  2203. stl: "c++_shared",
  2204. }
  2205. android_test {
  2206. name: "stl",
  2207. jni_libs: ["libjni"],
  2208. compile_multilib: "both",
  2209. sdk_version: "current",
  2210. stl: "c++_shared",
  2211. }
  2212. android_test {
  2213. name: "system",
  2214. jni_libs: ["libjni"],
  2215. compile_multilib: "both",
  2216. sdk_version: "current",
  2217. }
  2218. `)
  2219. testCases := []struct {
  2220. name string
  2221. jnis []string
  2222. }{
  2223. {"stl",
  2224. []string{
  2225. "libjni.so",
  2226. "libc++_shared.so",
  2227. },
  2228. },
  2229. {"system",
  2230. []string{
  2231. "libjni.so",
  2232. },
  2233. },
  2234. }
  2235. for _, test := range testCases {
  2236. t.Run(test.name, func(t *testing.T) {
  2237. app := ctx.ModuleForTests(test.name, "android_common")
  2238. jniLibZip := app.Output(jniJarOutputPathString)
  2239. var jnis []string
  2240. args := strings.Fields(jniLibZip.Args["jarArgs"])
  2241. for i := 0; i < len(args); i++ {
  2242. if args[i] == "-f" {
  2243. jnis = append(jnis, args[i+1])
  2244. i += 1
  2245. }
  2246. }
  2247. jnisJoined := strings.Join(jnis, " ")
  2248. for _, jni := range test.jnis {
  2249. if !strings.Contains(jnisJoined, jni) {
  2250. t.Errorf("missing jni %q in %q", jni, jnis)
  2251. }
  2252. }
  2253. })
  2254. }
  2255. }
  2256. func TestUsesLibraries(t *testing.T) {
  2257. bp := `
  2258. java_sdk_library {
  2259. name: "foo",
  2260. srcs: ["a.java"],
  2261. api_packages: ["foo"],
  2262. sdk_version: "current",
  2263. }
  2264. java_sdk_library {
  2265. name: "qux",
  2266. srcs: ["a.java"],
  2267. api_packages: ["qux"],
  2268. sdk_version: "current",
  2269. }
  2270. java_sdk_library {
  2271. name: "quuz",
  2272. srcs: ["a.java"],
  2273. api_packages: ["quuz"],
  2274. sdk_version: "current",
  2275. }
  2276. java_sdk_library {
  2277. name: "fred",
  2278. srcs: ["a.java"],
  2279. api_packages: ["fred"],
  2280. sdk_version: "current",
  2281. }
  2282. java_sdk_library {
  2283. name: "bar",
  2284. srcs: ["a.java"],
  2285. api_packages: ["bar"],
  2286. sdk_version: "current",
  2287. }
  2288. java_sdk_library {
  2289. name: "runtime-library",
  2290. srcs: ["a.java"],
  2291. sdk_version: "current",
  2292. }
  2293. java_library {
  2294. name: "static-runtime-helper",
  2295. srcs: ["a.java"],
  2296. libs: ["runtime-library"],
  2297. sdk_version: "current",
  2298. }
  2299. java_library {
  2300. name: "runtime-required-x",
  2301. srcs: ["a.java"],
  2302. installable: true,
  2303. sdk_version: "current",
  2304. }
  2305. java_library {
  2306. name: "runtime-optional-x",
  2307. srcs: ["a.java"],
  2308. installable: true,
  2309. sdk_version: "current",
  2310. }
  2311. android_library {
  2312. name: "static-x",
  2313. uses_libs: ["runtime-required-x"],
  2314. optional_uses_libs: ["runtime-optional-x"],
  2315. sdk_version: "current",
  2316. }
  2317. java_library {
  2318. name: "runtime-required-y",
  2319. srcs: ["a.java"],
  2320. installable: true,
  2321. sdk_version: "current",
  2322. }
  2323. java_library {
  2324. name: "runtime-optional-y",
  2325. srcs: ["a.java"],
  2326. installable: true,
  2327. sdk_version: "current",
  2328. }
  2329. java_library {
  2330. name: "static-y",
  2331. srcs: ["a.java"],
  2332. uses_libs: ["runtime-required-y"],
  2333. optional_uses_libs: ["runtime-optional-y"],
  2334. sdk_version: "current",
  2335. }
  2336. // A library that has to use "provides_uses_lib", because:
  2337. // - it is not an SDK library
  2338. // - its library name is different from its module name
  2339. java_library {
  2340. name: "non-sdk-lib",
  2341. provides_uses_lib: "com.non.sdk.lib",
  2342. installable: true,
  2343. srcs: ["a.java"],
  2344. }
  2345. android_app {
  2346. name: "app",
  2347. srcs: ["a.java"],
  2348. libs: [
  2349. "qux",
  2350. "quuz.stubs"
  2351. ],
  2352. static_libs: [
  2353. "static-runtime-helper",
  2354. // statically linked component libraries should not pull their SDK libraries,
  2355. // so "fred" should not be added to class loader context
  2356. "fred.stubs",
  2357. "static-x",
  2358. "static-y",
  2359. ],
  2360. uses_libs: [
  2361. "foo",
  2362. "non-sdk-lib"
  2363. ],
  2364. sdk_version: "current",
  2365. optional_uses_libs: [
  2366. "bar",
  2367. "baz",
  2368. ],
  2369. }
  2370. android_app_import {
  2371. name: "prebuilt",
  2372. apk: "prebuilts/apk/app.apk",
  2373. certificate: "platform",
  2374. uses_libs: [
  2375. "foo",
  2376. "non-sdk-lib",
  2377. "android.test.runner"
  2378. ],
  2379. optional_uses_libs: [
  2380. "bar",
  2381. "baz",
  2382. ],
  2383. }
  2384. `
  2385. result := android.GroupFixturePreparers(
  2386. prepareForJavaTest,
  2387. PrepareForTestWithJavaSdkLibraryFiles,
  2388. FixtureWithLastReleaseApis("runtime-library", "foo", "quuz", "qux", "bar", "fred"),
  2389. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2390. variables.MissingUsesLibraries = []string{"baz"}
  2391. }),
  2392. ).RunTestWithBp(t, bp)
  2393. app := result.ModuleForTests("app", "android_common")
  2394. prebuilt := result.ModuleForTests("prebuilt", "android_common")
  2395. // Test that implicit dependencies on java_sdk_library instances are passed to the manifest.
  2396. // These also include explicit `uses_libs`/`optional_uses_libs` entries, as they may be
  2397. // propagated from dependencies.
  2398. actualManifestFixerArgs := app.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2399. expectManifestFixerArgs := `--extract-native-libs=true ` +
  2400. `--uses-library qux ` +
  2401. `--uses-library quuz ` +
  2402. `--uses-library foo ` +
  2403. `--uses-library com.non.sdk.lib ` +
  2404. `--uses-library runtime-library ` +
  2405. `--uses-library runtime-required-x ` +
  2406. `--uses-library runtime-required-y ` +
  2407. `--optional-uses-library bar ` +
  2408. `--optional-uses-library runtime-optional-x ` +
  2409. `--optional-uses-library runtime-optional-y`
  2410. android.AssertStringDoesContain(t, "manifest_fixer args", actualManifestFixerArgs, expectManifestFixerArgs)
  2411. // Test that all libraries are verified (library order matters).
  2412. verifyCmd := app.Rule("verify_uses_libraries").RuleParams.Command
  2413. verifyArgs := `--uses-library foo ` +
  2414. `--uses-library com.non.sdk.lib ` +
  2415. `--uses-library qux ` +
  2416. `--uses-library quuz ` +
  2417. `--uses-library runtime-library ` +
  2418. `--uses-library runtime-required-x ` +
  2419. `--uses-library runtime-required-y ` +
  2420. `--optional-uses-library bar ` +
  2421. `--optional-uses-library baz ` +
  2422. `--optional-uses-library runtime-optional-x ` +
  2423. `--optional-uses-library runtime-optional-y `
  2424. android.AssertStringDoesContain(t, "verify cmd args", verifyCmd, verifyArgs)
  2425. // Test that all libraries are verified for an APK (library order matters).
  2426. verifyApkCmd := prebuilt.Rule("verify_uses_libraries").RuleParams.Command
  2427. verifyApkArgs := `--uses-library foo ` +
  2428. `--uses-library com.non.sdk.lib ` +
  2429. `--uses-library android.test.runner ` +
  2430. `--optional-uses-library bar ` +
  2431. `--optional-uses-library baz `
  2432. android.AssertStringDoesContain(t, "verify apk cmd args", verifyApkCmd, verifyApkArgs)
  2433. // Test that all present libraries are preopted, including implicit SDK dependencies, possibly stubs
  2434. cmd := app.Rule("dexpreopt").RuleParams.Command
  2435. w := `--target-context-for-sdk any ` +
  2436. `PCL[/system/framework/qux.jar]#` +
  2437. `PCL[/system/framework/quuz.jar]#` +
  2438. `PCL[/system/framework/foo.jar]#` +
  2439. `PCL[/system/framework/non-sdk-lib.jar]#` +
  2440. `PCL[/system/framework/bar.jar]#` +
  2441. `PCL[/system/framework/runtime-library.jar]#` +
  2442. `PCL[/system/framework/runtime-required-x.jar]#` +
  2443. `PCL[/system/framework/runtime-optional-x.jar]#` +
  2444. `PCL[/system/framework/runtime-required-y.jar]#` +
  2445. `PCL[/system/framework/runtime-optional-y.jar] `
  2446. android.AssertStringDoesContain(t, "dexpreopt app cmd args", cmd, w)
  2447. // Test conditional context for target SDK version 28.
  2448. android.AssertStringDoesContain(t, "dexpreopt app cmd 28", cmd,
  2449. `--target-context-for-sdk 28`+
  2450. ` PCL[/system/framework/org.apache.http.legacy.jar] `)
  2451. // Test conditional context for target SDK version 29.
  2452. android.AssertStringDoesContain(t, "dexpreopt app cmd 29", cmd,
  2453. `--target-context-for-sdk 29`+
  2454. ` PCL[/system/framework/android.hidl.manager-V1.0-java.jar]`+
  2455. `#PCL[/system/framework/android.hidl.base-V1.0-java.jar] `)
  2456. // Test conditional context for target SDK version 30.
  2457. // "android.test.mock" is absent because "android.test.runner" is not used.
  2458. android.AssertStringDoesContain(t, "dexpreopt app cmd 30", cmd,
  2459. `--target-context-for-sdk 30`+
  2460. ` PCL[/system/framework/android.test.base.jar] `)
  2461. cmd = prebuilt.Rule("dexpreopt").RuleParams.Command
  2462. android.AssertStringDoesContain(t, "dexpreopt prebuilt cmd", cmd,
  2463. `--target-context-for-sdk any`+
  2464. ` PCL[/system/framework/foo.jar]`+
  2465. `#PCL[/system/framework/non-sdk-lib.jar]`+
  2466. `#PCL[/system/framework/android.test.runner.jar]`+
  2467. `#PCL[/system/framework/bar.jar] `)
  2468. // Test conditional context for target SDK version 30.
  2469. // "android.test.mock" is present because "android.test.runner" is used.
  2470. android.AssertStringDoesContain(t, "dexpreopt prebuilt cmd 30", cmd,
  2471. `--target-context-for-sdk 30`+
  2472. ` PCL[/system/framework/android.test.base.jar]`+
  2473. `#PCL[/system/framework/android.test.mock.jar] `)
  2474. }
  2475. func TestDexpreoptBcp(t *testing.T) {
  2476. bp := `
  2477. java_sdk_library {
  2478. name: "foo",
  2479. srcs: ["a.java"],
  2480. api_packages: ["foo"],
  2481. sdk_version: "current",
  2482. }
  2483. java_sdk_library {
  2484. name: "bar",
  2485. srcs: ["a.java"],
  2486. api_packages: ["bar"],
  2487. permitted_packages: ["bar"],
  2488. sdk_version: "current",
  2489. }
  2490. android_app {
  2491. name: "app",
  2492. srcs: ["a.java"],
  2493. sdk_version: "current",
  2494. }
  2495. `
  2496. testCases := []struct {
  2497. name string
  2498. with bool
  2499. expect string
  2500. }{
  2501. {
  2502. name: "with updatable bcp",
  2503. with: true,
  2504. expect: "/system/framework/foo.jar:/system/framework/bar.jar",
  2505. },
  2506. {
  2507. name: "without updatable bcp",
  2508. with: false,
  2509. expect: "/system/framework/foo.jar",
  2510. },
  2511. }
  2512. for _, test := range testCases {
  2513. t.Run(test.name, func(t *testing.T) {
  2514. result := android.GroupFixturePreparers(
  2515. prepareForJavaTest,
  2516. PrepareForTestWithJavaSdkLibraryFiles,
  2517. FixtureWithLastReleaseApis("runtime-library", "foo", "bar"),
  2518. dexpreopt.FixtureSetBootJars("platform:foo"),
  2519. dexpreopt.FixtureSetApexBootJars("platform:bar"),
  2520. dexpreopt.FixtureSetPreoptWithUpdatableBcp(test.with),
  2521. ).RunTestWithBp(t, bp)
  2522. app := result.ModuleForTests("app", "android_common")
  2523. cmd := app.Rule("dexpreopt").RuleParams.Command
  2524. bcp := " -Xbootclasspath-locations:" + test.expect + " " // space at the end matters
  2525. android.AssertStringDoesContain(t, "dexpreopt app bcp", cmd, bcp)
  2526. })
  2527. }
  2528. }
  2529. func TestCodelessApp(t *testing.T) {
  2530. testCases := []struct {
  2531. name string
  2532. bp string
  2533. noCode bool
  2534. }{
  2535. {
  2536. name: "normal",
  2537. bp: `
  2538. android_app {
  2539. name: "foo",
  2540. srcs: ["a.java"],
  2541. sdk_version: "current",
  2542. }
  2543. `,
  2544. noCode: false,
  2545. },
  2546. {
  2547. name: "app without sources",
  2548. bp: `
  2549. android_app {
  2550. name: "foo",
  2551. sdk_version: "current",
  2552. }
  2553. `,
  2554. noCode: true,
  2555. },
  2556. {
  2557. name: "app with libraries",
  2558. bp: `
  2559. android_app {
  2560. name: "foo",
  2561. static_libs: ["lib"],
  2562. sdk_version: "current",
  2563. }
  2564. java_library {
  2565. name: "lib",
  2566. srcs: ["a.java"],
  2567. sdk_version: "current",
  2568. }
  2569. `,
  2570. noCode: false,
  2571. },
  2572. {
  2573. name: "app with sourceless libraries",
  2574. bp: `
  2575. android_app {
  2576. name: "foo",
  2577. static_libs: ["lib"],
  2578. sdk_version: "current",
  2579. }
  2580. java_library {
  2581. name: "lib",
  2582. sdk_version: "current",
  2583. }
  2584. `,
  2585. // TODO(jungjw): this should probably be true
  2586. noCode: false,
  2587. },
  2588. }
  2589. for _, test := range testCases {
  2590. t.Run(test.name, func(t *testing.T) {
  2591. ctx := testApp(t, test.bp)
  2592. foo := ctx.ModuleForTests("foo", "android_common")
  2593. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2594. if strings.Contains(manifestFixerArgs, "--has-no-code") != test.noCode {
  2595. t.Errorf("unexpected manifest_fixer args: %q", manifestFixerArgs)
  2596. }
  2597. })
  2598. }
  2599. }
  2600. func TestUncompressDex(t *testing.T) {
  2601. testCases := []struct {
  2602. name string
  2603. bp string
  2604. uncompressedPlatform bool
  2605. uncompressedUnbundled bool
  2606. }{
  2607. {
  2608. name: "normal",
  2609. bp: `
  2610. android_app {
  2611. name: "foo",
  2612. srcs: ["a.java"],
  2613. sdk_version: "current",
  2614. }
  2615. `,
  2616. uncompressedPlatform: true,
  2617. uncompressedUnbundled: false,
  2618. },
  2619. {
  2620. name: "use_embedded_dex",
  2621. bp: `
  2622. android_app {
  2623. name: "foo",
  2624. use_embedded_dex: true,
  2625. srcs: ["a.java"],
  2626. sdk_version: "current",
  2627. }
  2628. `,
  2629. uncompressedPlatform: true,
  2630. uncompressedUnbundled: true,
  2631. },
  2632. {
  2633. name: "privileged",
  2634. bp: `
  2635. android_app {
  2636. name: "foo",
  2637. privileged: true,
  2638. srcs: ["a.java"],
  2639. sdk_version: "current",
  2640. }
  2641. `,
  2642. uncompressedPlatform: true,
  2643. uncompressedUnbundled: true,
  2644. },
  2645. {
  2646. name: "normal_uncompress_dex_true",
  2647. bp: `
  2648. android_app {
  2649. name: "foo",
  2650. srcs: ["a.java"],
  2651. sdk_version: "current",
  2652. uncompress_dex: true,
  2653. }
  2654. `,
  2655. uncompressedPlatform: true,
  2656. uncompressedUnbundled: true,
  2657. },
  2658. {
  2659. name: "normal_uncompress_dex_false",
  2660. bp: `
  2661. android_app {
  2662. name: "foo",
  2663. srcs: ["a.java"],
  2664. sdk_version: "current",
  2665. uncompress_dex: false,
  2666. }
  2667. `,
  2668. uncompressedPlatform: false,
  2669. uncompressedUnbundled: false,
  2670. },
  2671. }
  2672. test := func(t *testing.T, bp string, want bool, unbundled bool) {
  2673. t.Helper()
  2674. result := android.GroupFixturePreparers(
  2675. prepareForJavaTest,
  2676. PrepareForTestWithPrebuiltsOfCurrentApi,
  2677. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2678. if unbundled {
  2679. variables.Unbundled_build = proptools.BoolPtr(true)
  2680. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(true)
  2681. }
  2682. }),
  2683. ).RunTestWithBp(t, bp)
  2684. foo := result.ModuleForTests("foo", "android_common")
  2685. dex := foo.Rule("r8")
  2686. uncompressedInDexJar := strings.Contains(dex.Args["zipFlags"], "-L 0")
  2687. aligned := foo.MaybeRule("zipalign").Rule != nil
  2688. android.AssertBoolEquals(t, "uncompressed in dex", want, uncompressedInDexJar)
  2689. android.AssertBoolEquals(t, "aligne", want, aligned)
  2690. }
  2691. for _, tt := range testCases {
  2692. t.Run(tt.name, func(t *testing.T) {
  2693. t.Run("platform", func(t *testing.T) {
  2694. test(t, tt.bp, tt.uncompressedPlatform, false)
  2695. })
  2696. t.Run("unbundled", func(t *testing.T) {
  2697. test(t, tt.bp, tt.uncompressedUnbundled, true)
  2698. })
  2699. })
  2700. }
  2701. }
  2702. func checkAapt2LinkFlag(t *testing.T, aapt2Flags, flagName, expectedValue string) {
  2703. if expectedValue != "" {
  2704. expectedFlag := "--" + flagName + " " + expectedValue
  2705. if !strings.Contains(aapt2Flags, expectedFlag) {
  2706. t.Errorf("%q is missing in aapt2 link flags, %q", expectedFlag, aapt2Flags)
  2707. }
  2708. } else {
  2709. unexpectedFlag := "--" + flagName
  2710. if strings.Contains(aapt2Flags, unexpectedFlag) {
  2711. t.Errorf("unexpected flag, %q is found in aapt2 link flags, %q", unexpectedFlag, aapt2Flags)
  2712. }
  2713. }
  2714. }
  2715. func TestExportedProguardFlagFiles(t *testing.T) {
  2716. ctx, _ := testJava(t, `
  2717. android_app {
  2718. name: "foo",
  2719. sdk_version: "current",
  2720. static_libs: ["lib1"],
  2721. }
  2722. android_library {
  2723. name: "lib1",
  2724. sdk_version: "current",
  2725. optimize: {
  2726. proguard_flags_files: ["lib1proguard.cfg"],
  2727. }
  2728. }
  2729. `)
  2730. m := ctx.ModuleForTests("foo", "android_common")
  2731. hasLib1Proguard := false
  2732. for _, s := range m.Rule("java.r8").Implicits.Strings() {
  2733. if s == "lib1proguard.cfg" {
  2734. hasLib1Proguard = true
  2735. break
  2736. }
  2737. }
  2738. if !hasLib1Proguard {
  2739. t.Errorf("App does not use library proguard config")
  2740. }
  2741. }
  2742. func TestTargetSdkVersionManifestFixer(t *testing.T) {
  2743. platform_sdk_codename := "Tiramisu"
  2744. testCases := []struct {
  2745. name string
  2746. targetSdkVersionInBp string
  2747. targetSdkVersionExpected string
  2748. unbundledBuild bool
  2749. }{
  2750. {
  2751. name: "Non-Unbundled build: Android.bp has targetSdkVersion",
  2752. targetSdkVersionInBp: "30",
  2753. targetSdkVersionExpected: "30",
  2754. unbundledBuild: false,
  2755. },
  2756. {
  2757. name: "Unbundled build: Android.bp has targetSdkVersion",
  2758. targetSdkVersionInBp: "30",
  2759. targetSdkVersionExpected: "30",
  2760. unbundledBuild: true,
  2761. },
  2762. {
  2763. name: "Non-Unbundled build: Android.bp has targetSdkVersion equal to platform_sdk_codename",
  2764. targetSdkVersionInBp: platform_sdk_codename,
  2765. targetSdkVersionExpected: platform_sdk_codename,
  2766. unbundledBuild: false,
  2767. },
  2768. {
  2769. name: "Unbundled build: Android.bp has targetSdkVersion equal to platform_sdk_codename",
  2770. targetSdkVersionInBp: platform_sdk_codename,
  2771. targetSdkVersionExpected: "10000",
  2772. unbundledBuild: true,
  2773. },
  2774. {
  2775. name: "Non-Unbundled build: Android.bp has no targetSdkVersion",
  2776. targetSdkVersionExpected: platform_sdk_codename,
  2777. unbundledBuild: false,
  2778. },
  2779. {
  2780. name: "Unbundled build: Android.bp has no targetSdkVersion",
  2781. targetSdkVersionExpected: "10000",
  2782. unbundledBuild: true,
  2783. },
  2784. }
  2785. for _, testCase := range testCases {
  2786. bp := fmt.Sprintf(`
  2787. android_app {
  2788. name: "foo",
  2789. sdk_version: "current",
  2790. target_sdk_version: "%v",
  2791. }
  2792. `, testCase.targetSdkVersionInBp)
  2793. fixture := android.GroupFixturePreparers(
  2794. prepareForJavaTest,
  2795. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2796. // explicitly set platform_sdk_codename to make the test deterministic
  2797. variables.Platform_sdk_codename = &platform_sdk_codename
  2798. variables.Platform_version_active_codenames = []string{platform_sdk_codename}
  2799. // create a non-empty list if unbundledBuild==true
  2800. if testCase.unbundledBuild {
  2801. variables.Unbundled_build_apps = []string{"apex_a", "apex_b"}
  2802. }
  2803. }),
  2804. )
  2805. result := fixture.RunTestWithBp(t, bp)
  2806. foo := result.ModuleForTests("foo", "android_common")
  2807. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2808. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  2809. }
  2810. }
  2811. func TestDefaultAppTargetSdkVersionForUpdatableModules(t *testing.T) {
  2812. platform_sdk_codename := "Tiramisu"
  2813. platform_sdk_version := 33
  2814. testCases := []struct {
  2815. name string
  2816. platform_sdk_final bool
  2817. targetSdkVersionInBp *string
  2818. targetSdkVersionExpected *string
  2819. updatable bool
  2820. }{
  2821. {
  2822. name: "Non-Updatable Module: Android.bp has older targetSdkVersion",
  2823. targetSdkVersionInBp: proptools.StringPtr("29"),
  2824. targetSdkVersionExpected: proptools.StringPtr("29"),
  2825. updatable: false,
  2826. },
  2827. {
  2828. name: "Updatable Module: Android.bp has older targetSdkVersion",
  2829. targetSdkVersionInBp: proptools.StringPtr("30"),
  2830. targetSdkVersionExpected: proptools.StringPtr("30"),
  2831. updatable: true,
  2832. },
  2833. {
  2834. name: "Updatable Module: Android.bp has no targetSdkVersion",
  2835. targetSdkVersionExpected: proptools.StringPtr("10000"),
  2836. updatable: true,
  2837. },
  2838. {
  2839. name: "[SDK finalised] Non-Updatable Module: Android.bp has older targetSdkVersion",
  2840. platform_sdk_final: true,
  2841. targetSdkVersionInBp: proptools.StringPtr("30"),
  2842. targetSdkVersionExpected: proptools.StringPtr("30"),
  2843. updatable: false,
  2844. },
  2845. {
  2846. name: "[SDK finalised] Updatable Module: Android.bp has older targetSdkVersion",
  2847. platform_sdk_final: true,
  2848. targetSdkVersionInBp: proptools.StringPtr("30"),
  2849. targetSdkVersionExpected: proptools.StringPtr("30"),
  2850. updatable: true,
  2851. },
  2852. {
  2853. name: "[SDK finalised] Updatable Module: Android.bp has targetSdkVersion as platform sdk codename",
  2854. platform_sdk_final: true,
  2855. targetSdkVersionInBp: proptools.StringPtr(platform_sdk_codename),
  2856. targetSdkVersionExpected: proptools.StringPtr("33"),
  2857. updatable: true,
  2858. },
  2859. {
  2860. name: "[SDK finalised] Updatable Module: Android.bp has no targetSdkVersion",
  2861. platform_sdk_final: true,
  2862. targetSdkVersionExpected: proptools.StringPtr("33"),
  2863. updatable: true,
  2864. },
  2865. }
  2866. for _, testCase := range testCases {
  2867. bp := fmt.Sprintf(`
  2868. android_app {
  2869. name: "foo",
  2870. sdk_version: "current",
  2871. min_sdk_version: "29",
  2872. target_sdk_version: "%v",
  2873. updatable: %t,
  2874. enforce_default_target_sdk_version: %t
  2875. }
  2876. `, proptools.String(testCase.targetSdkVersionInBp), testCase.updatable, testCase.updatable) // enforce default target sdk version if app is updatable
  2877. fixture := android.GroupFixturePreparers(
  2878. PrepareForTestWithJavaDefaultModules,
  2879. android.PrepareForTestWithAllowMissingDependencies,
  2880. android.PrepareForTestWithAndroidMk,
  2881. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2882. // explicitly set following platform variables to make the test deterministic
  2883. variables.Platform_sdk_final = &testCase.platform_sdk_final
  2884. variables.Platform_sdk_version = &platform_sdk_version
  2885. variables.Platform_sdk_codename = &platform_sdk_codename
  2886. variables.Platform_version_active_codenames = []string{platform_sdk_codename}
  2887. variables.Unbundled_build = proptools.BoolPtr(true)
  2888. variables.Unbundled_build_apps = []string{"sampleModule"}
  2889. }),
  2890. )
  2891. result := fixture.RunTestWithBp(t, bp)
  2892. foo := result.ModuleForTests("foo", "android_common")
  2893. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2894. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+*testCase.targetSdkVersionExpected)
  2895. }
  2896. }
  2897. func TestEnforceDefaultAppTargetSdkVersionFlag(t *testing.T) {
  2898. platform_sdk_codename := "Tiramisu"
  2899. platform_sdk_version := 33
  2900. testCases := []struct {
  2901. name string
  2902. enforceDefaultTargetSdkVersion bool
  2903. expectedError string
  2904. platform_sdk_final bool
  2905. targetSdkVersionInBp string
  2906. targetSdkVersionExpected string
  2907. updatable bool
  2908. }{
  2909. {
  2910. name: "Not enforcing Target SDK Version: Android.bp has older targetSdkVersion",
  2911. enforceDefaultTargetSdkVersion: false,
  2912. targetSdkVersionInBp: "29",
  2913. targetSdkVersionExpected: "29",
  2914. updatable: false,
  2915. },
  2916. {
  2917. name: "[SDK finalised] Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2918. enforceDefaultTargetSdkVersion: true,
  2919. platform_sdk_final: true,
  2920. targetSdkVersionInBp: "current",
  2921. targetSdkVersionExpected: "33",
  2922. updatable: true,
  2923. },
  2924. {
  2925. name: "Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2926. enforceDefaultTargetSdkVersion: true,
  2927. platform_sdk_final: false,
  2928. targetSdkVersionInBp: "current",
  2929. targetSdkVersionExpected: "10000",
  2930. updatable: false,
  2931. },
  2932. {
  2933. name: "Not enforcing Target SDK Version for Updatable app",
  2934. enforceDefaultTargetSdkVersion: false,
  2935. expectedError: "Updatable apps must enforce default target sdk version",
  2936. targetSdkVersionInBp: "29",
  2937. targetSdkVersionExpected: "29",
  2938. updatable: true,
  2939. },
  2940. }
  2941. for _, testCase := range testCases {
  2942. errExpected := testCase.expectedError != ""
  2943. bp := fmt.Sprintf(`
  2944. android_app {
  2945. name: "foo",
  2946. enforce_default_target_sdk_version: %t,
  2947. sdk_version: "current",
  2948. min_sdk_version: "29",
  2949. target_sdk_version: "%v",
  2950. updatable: %t
  2951. }
  2952. `, testCase.enforceDefaultTargetSdkVersion, testCase.targetSdkVersionInBp, testCase.updatable)
  2953. fixture := android.GroupFixturePreparers(
  2954. PrepareForTestWithJavaDefaultModules,
  2955. android.PrepareForTestWithAllowMissingDependencies,
  2956. android.PrepareForTestWithAndroidMk,
  2957. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2958. // explicitly set following platform variables to make the test deterministic
  2959. variables.Platform_sdk_final = &testCase.platform_sdk_final
  2960. variables.Platform_sdk_version = &platform_sdk_version
  2961. variables.Platform_sdk_codename = &platform_sdk_codename
  2962. variables.Unbundled_build = proptools.BoolPtr(true)
  2963. variables.Unbundled_build_apps = []string{"sampleModule"}
  2964. }),
  2965. )
  2966. errorHandler := android.FixtureExpectsNoErrors
  2967. if errExpected {
  2968. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(testCase.expectedError)
  2969. }
  2970. result := fixture.ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, bp)
  2971. if !errExpected {
  2972. foo := result.ModuleForTests("foo", "android_common")
  2973. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  2974. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  2975. }
  2976. }
  2977. }
  2978. func TestEnforceDefaultAppTargetSdkVersionFlagForTests(t *testing.T) {
  2979. platform_sdk_codename := "Tiramisu"
  2980. platform_sdk_version := 33
  2981. testCases := []struct {
  2982. name string
  2983. enforceDefaultTargetSdkVersion bool
  2984. expectedError string
  2985. platform_sdk_final bool
  2986. targetSdkVersionInBp string
  2987. targetSdkVersionExpected string
  2988. }{
  2989. {
  2990. name: "Not enforcing Target SDK Version: Android.bp has older targetSdkVersion",
  2991. enforceDefaultTargetSdkVersion: false,
  2992. targetSdkVersionInBp: "29",
  2993. targetSdkVersionExpected: "29",
  2994. },
  2995. {
  2996. name: "[SDK finalised] Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  2997. enforceDefaultTargetSdkVersion: true,
  2998. platform_sdk_final: true,
  2999. targetSdkVersionInBp: "current",
  3000. targetSdkVersionExpected: "33",
  3001. },
  3002. {
  3003. name: "Enforce Target SDK Version: Android.bp has current targetSdkVersion",
  3004. enforceDefaultTargetSdkVersion: true,
  3005. platform_sdk_final: false,
  3006. targetSdkVersionInBp: "current",
  3007. targetSdkVersionExpected: "10000",
  3008. },
  3009. }
  3010. for _, testCase := range testCases {
  3011. errExpected := testCase.expectedError != ""
  3012. bp := fmt.Sprintf(`
  3013. android_test {
  3014. name: "foo",
  3015. enforce_default_target_sdk_version: %t,
  3016. min_sdk_version: "29",
  3017. target_sdk_version: "%v",
  3018. }
  3019. `, testCase.enforceDefaultTargetSdkVersion, testCase.targetSdkVersionInBp)
  3020. fixture := android.GroupFixturePreparers(
  3021. PrepareForTestWithJavaDefaultModules,
  3022. android.PrepareForTestWithAllowMissingDependencies,
  3023. android.PrepareForTestWithAndroidMk,
  3024. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3025. // explicitly set following platform variables to make the test deterministic
  3026. variables.Platform_sdk_final = &testCase.platform_sdk_final
  3027. variables.Platform_sdk_version = &platform_sdk_version
  3028. variables.Platform_sdk_codename = &platform_sdk_codename
  3029. variables.Unbundled_build = proptools.BoolPtr(true)
  3030. variables.Unbundled_build_apps = []string{"sampleModule"}
  3031. }),
  3032. )
  3033. errorHandler := android.FixtureExpectsNoErrors
  3034. if errExpected {
  3035. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(testCase.expectedError)
  3036. }
  3037. result := fixture.ExtendWithErrorHandler(errorHandler).RunTestWithBp(t, bp)
  3038. if !errExpected {
  3039. foo := result.ModuleForTests("foo", "android_common")
  3040. manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  3041. android.AssertStringDoesContain(t, testCase.name, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  3042. }
  3043. }
  3044. }
  3045. func TestAppMissingCertificateAllowMissingDependencies(t *testing.T) {
  3046. result := android.GroupFixturePreparers(
  3047. PrepareForTestWithJavaDefaultModules,
  3048. android.PrepareForTestWithAllowMissingDependencies,
  3049. android.PrepareForTestWithAndroidMk,
  3050. ).RunTestWithBp(t, `
  3051. android_app {
  3052. name: "foo",
  3053. srcs: ["a.java"],
  3054. certificate: ":missing_certificate",
  3055. sdk_version: "current",
  3056. }`)
  3057. foo := result.ModuleForTests("foo", "android_common")
  3058. fooApk := foo.Output("foo.apk")
  3059. if fooApk.Rule != android.ErrorRule {
  3060. t.Fatalf("expected ErrorRule for foo.apk, got %s", fooApk.Rule.String())
  3061. }
  3062. android.AssertStringDoesContain(t, "expected error rule message", fooApk.Args["error"], "missing dependencies: missing_certificate\n")
  3063. }
  3064. func TestAppIncludesJniPackages(t *testing.T) {
  3065. ctx := android.GroupFixturePreparers(
  3066. PrepareForTestWithJavaDefaultModules,
  3067. ).RunTestWithBp(t, `
  3068. android_library_import {
  3069. name: "aary-nodeps",
  3070. aars: ["aary.aar"],
  3071. extract_jni: true,
  3072. }
  3073. android_library {
  3074. name: "aary-lib",
  3075. sdk_version: "current",
  3076. min_sdk_version: "21",
  3077. static_libs: ["aary-nodeps"],
  3078. }
  3079. android_app {
  3080. name: "aary-lib-dep",
  3081. sdk_version: "current",
  3082. min_sdk_version: "21",
  3083. manifest: "AndroidManifest.xml",
  3084. static_libs: ["aary-lib"],
  3085. use_embedded_native_libs: true,
  3086. }
  3087. android_app {
  3088. name: "aary-import-dep",
  3089. sdk_version: "current",
  3090. min_sdk_version: "21",
  3091. manifest: "AndroidManifest.xml",
  3092. static_libs: ["aary-nodeps"],
  3093. use_embedded_native_libs: true,
  3094. }
  3095. android_app {
  3096. name: "aary-no-use-embedded",
  3097. sdk_version: "current",
  3098. min_sdk_version: "21",
  3099. manifest: "AndroidManifest.xml",
  3100. static_libs: ["aary-nodeps"],
  3101. }`)
  3102. testCases := []struct {
  3103. name string
  3104. hasPackage bool
  3105. }{
  3106. {
  3107. name: "aary-import-dep",
  3108. hasPackage: true,
  3109. },
  3110. {
  3111. name: "aary-lib-dep",
  3112. hasPackage: true,
  3113. },
  3114. {
  3115. name: "aary-no-use-embedded",
  3116. hasPackage: false,
  3117. },
  3118. }
  3119. for _, tc := range testCases {
  3120. t.Run(tc.name, func(t *testing.T) {
  3121. app := ctx.ModuleForTests(tc.name, "android_common")
  3122. outputFile := "jnilibs.zip"
  3123. jniOutputLibZip := app.MaybeOutput(outputFile)
  3124. if jniOutputLibZip.Rule == nil && !tc.hasPackage {
  3125. return
  3126. }
  3127. jniPackage := "arm64-v8a_jni.zip"
  3128. inputs := jniOutputLibZip.Inputs
  3129. foundPackage := false
  3130. for i := 0; i < len(inputs); i++ {
  3131. if strings.Contains(inputs[i].String(), jniPackage) {
  3132. foundPackage = true
  3133. }
  3134. }
  3135. if foundPackage != tc.hasPackage {
  3136. t.Errorf("expected to find %v in %v inputs; inputs = %v", jniPackage, outputFile, inputs)
  3137. }
  3138. })
  3139. }
  3140. }
  3141. func TestTargetSdkVersionMtsTests(t *testing.T) {
  3142. platformSdkCodename := "Tiramisu"
  3143. android_test := "android_test"
  3144. android_test_helper_app := "android_test_helper_app"
  3145. bpTemplate := `
  3146. %v {
  3147. name: "mytest",
  3148. target_sdk_version: "%v",
  3149. test_suites: ["othersuite", "%v"],
  3150. }
  3151. `
  3152. testCases := []struct {
  3153. desc string
  3154. moduleType string
  3155. targetSdkVersionInBp string
  3156. targetSdkVersionExpected string
  3157. testSuites string
  3158. }{
  3159. {
  3160. desc: "Non-MTS android_test_apps targeting current should not be upgraded to 10000",
  3161. moduleType: android_test,
  3162. targetSdkVersionInBp: "current",
  3163. targetSdkVersionExpected: platformSdkCodename,
  3164. testSuites: "non-mts-suite",
  3165. },
  3166. {
  3167. desc: "MTS android_test_apps targeting released sdks should not be upgraded to 10000",
  3168. moduleType: android_test,
  3169. targetSdkVersionInBp: "29",
  3170. targetSdkVersionExpected: "29",
  3171. testSuites: "mts-suite",
  3172. },
  3173. {
  3174. desc: "MTS android_test_apps targeting current should be upgraded to 10000",
  3175. moduleType: android_test,
  3176. targetSdkVersionInBp: "current",
  3177. targetSdkVersionExpected: "10000",
  3178. testSuites: "mts-suite",
  3179. },
  3180. {
  3181. desc: "MTS android_test_helper_apps targeting current should be upgraded to 10000",
  3182. moduleType: android_test_helper_app,
  3183. targetSdkVersionInBp: "current",
  3184. targetSdkVersionExpected: "10000",
  3185. testSuites: "mts-suite",
  3186. },
  3187. }
  3188. fixture := android.GroupFixturePreparers(
  3189. prepareForJavaTest,
  3190. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3191. variables.Platform_sdk_codename = &platformSdkCodename
  3192. variables.Platform_version_active_codenames = []string{platformSdkCodename}
  3193. }),
  3194. )
  3195. for _, testCase := range testCases {
  3196. result := fixture.RunTestWithBp(t, fmt.Sprintf(bpTemplate, testCase.moduleType, testCase.targetSdkVersionInBp, testCase.testSuites))
  3197. mytest := result.ModuleForTests("mytest", "android_common")
  3198. manifestFixerArgs := mytest.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
  3199. android.AssertStringDoesContain(t, testCase.desc, manifestFixerArgs, "--targetSdkVersion "+testCase.targetSdkVersionExpected)
  3200. }
  3201. }