apex_test.go 234 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011601260136014601560166017601860196020602160226023602460256026602760286029603060316032603360346035603660376038603960406041604260436044604560466047604860496050605160526053605460556056605760586059606060616062606360646065606660676068606960706071607260736074607560766077607860796080608160826083608460856086608760886089609060916092609360946095609660976098609961006101610261036104610561066107610861096110611161126113611461156116611761186119612061216122612361246125612661276128612961306131613261336134613561366137613861396140614161426143614461456146614761486149615061516152615361546155615661576158615961606161616261636164616561666167616861696170617161726173617461756176617761786179618061816182618361846185618661876188618961906191619261936194619561966197619861996200620162026203620462056206620762086209621062116212621362146215621662176218621962206221622262236224622562266227622862296230623162326233623462356236623762386239624062416242624362446245624662476248624962506251625262536254625562566257625862596260626162626263626462656266626762686269627062716272627362746275627662776278627962806281628262836284628562866287628862896290629162926293629462956296629762986299630063016302630363046305630663076308630963106311631263136314631563166317631863196320632163226323632463256326632763286329633063316332633363346335633663376338633963406341634263436344634563466347634863496350635163526353635463556356635763586359636063616362636363646365636663676368636963706371637263736374637563766377637863796380638163826383638463856386638763886389639063916392639363946395639663976398639964006401640264036404640564066407640864096410641164126413641464156416641764186419642064216422642364246425642664276428642964306431643264336434643564366437643864396440644164426443644464456446644764486449645064516452645364546455645664576458645964606461646264636464646564666467646864696470647164726473647464756476647764786479648064816482648364846485648664876488648964906491649264936494649564966497649864996500650165026503650465056506650765086509651065116512651365146515651665176518651965206521652265236524652565266527652865296530653165326533653465356536653765386539654065416542654365446545654665476548654965506551655265536554655565566557655865596560656165626563656465656566656765686569657065716572657365746575657665776578657965806581658265836584658565866587658865896590659165926593659465956596659765986599660066016602660366046605660666076608660966106611661266136614661566166617661866196620662166226623662466256626662766286629663066316632663366346635663666376638663966406641664266436644664566466647664866496650665166526653665466556656665766586659666066616662666366646665666666676668666966706671667266736674667566766677667866796680668166826683668466856686668766886689669066916692669366946695669666976698669967006701670267036704670567066707670867096710671167126713671467156716671767186719672067216722672367246725672667276728672967306731673267336734673567366737673867396740674167426743674467456746674767486749675067516752675367546755675667576758675967606761676267636764676567666767676867696770677167726773677467756776677767786779678067816782678367846785678667876788678967906791679267936794679567966797679867996800680168026803680468056806680768086809681068116812681368146815681668176818681968206821682268236824682568266827682868296830683168326833683468356836683768386839684068416842684368446845684668476848684968506851685268536854685568566857685868596860686168626863686468656866686768686869687068716872687368746875687668776878687968806881688268836884688568866887688868896890689168926893689468956896689768986899690069016902690369046905690669076908690969106911691269136914691569166917691869196920692169226923692469256926692769286929693069316932693369346935693669376938693969406941694269436944694569466947694869496950695169526953695469556956695769586959696069616962696369646965696669676968696969706971697269736974697569766977697869796980698169826983698469856986698769886989699069916992699369946995699669976998699970007001700270037004700570067007700870097010701170127013701470157016701770187019702070217022702370247025702670277028702970307031703270337034703570367037703870397040704170427043704470457046704770487049705070517052705370547055705670577058705970607061706270637064706570667067706870697070707170727073707470757076707770787079708070817082708370847085708670877088708970907091709270937094709570967097709870997100710171027103710471057106710771087109711071117112711371147115711671177118711971207121712271237124712571267127712871297130713171327133713471357136713771387139714071417142714371447145714671477148714971507151715271537154715571567157715871597160716171627163716471657166716771687169717071717172717371747175717671777178717971807181718271837184718571867187718871897190719171927193719471957196719771987199720072017202720372047205720672077208720972107211721272137214721572167217721872197220722172227223722472257226722772287229723072317232723372347235723672377238723972407241724272437244724572467247724872497250725172527253725472557256725772587259726072617262726372647265726672677268726972707271727272737274727572767277727872797280728172827283728472857286728772887289729072917292729372947295729672977298729973007301730273037304730573067307730873097310731173127313731473157316731773187319732073217322732373247325732673277328732973307331733273337334733573367337733873397340734173427343734473457346734773487349735073517352735373547355735673577358735973607361736273637364736573667367736873697370737173727373737473757376737773787379738073817382738373847385738673877388738973907391739273937394739573967397739873997400740174027403740474057406740774087409741074117412741374147415741674177418741974207421742274237424742574267427742874297430743174327433743474357436743774387439744074417442744374447445744674477448744974507451745274537454745574567457745874597460746174627463746474657466746774687469747074717472747374747475747674777478747974807481748274837484748574867487748874897490749174927493749474957496749774987499750075017502750375047505750675077508750975107511751275137514751575167517751875197520752175227523752475257526752775287529753075317532753375347535753675377538753975407541754275437544754575467547754875497550755175527553755475557556755775587559756075617562756375647565756675677568756975707571757275737574757575767577757875797580758175827583758475857586758775887589759075917592759375947595759675977598759976007601760276037604760576067607760876097610761176127613761476157616761776187619762076217622762376247625762676277628762976307631763276337634763576367637763876397640764176427643764476457646764776487649765076517652765376547655765676577658765976607661766276637664766576667667766876697670767176727673767476757676767776787679768076817682768376847685768676877688768976907691769276937694769576967697769876997700770177027703770477057706770777087709771077117712771377147715771677177718771977207721772277237724772577267727772877297730773177327733773477357736773777387739774077417742774377447745774677477748774977507751775277537754775577567757775877597760776177627763776477657766776777687769777077717772777377747775777677777778777977807781778277837784778577867787778877897790779177927793779477957796779777987799780078017802780378047805780678077808780978107811781278137814781578167817781878197820782178227823782478257826782778287829783078317832783378347835783678377838783978407841784278437844784578467847784878497850785178527853785478557856785778587859786078617862786378647865786678677868786978707871787278737874787578767877787878797880788178827883788478857886788778887889789078917892789378947895789678977898789979007901790279037904790579067907790879097910791179127913791479157916791779187919792079217922792379247925792679277928792979307931793279337934793579367937793879397940794179427943794479457946794779487949795079517952795379547955795679577958795979607961796279637964796579667967796879697970797179727973797479757976797779787979798079817982798379847985798679877988798979907991799279937994799579967997799879998000800180028003800480058006800780088009801080118012801380148015801680178018801980208021802280238024802580268027802880298030803180328033803480358036803780388039804080418042804380448045804680478048804980508051805280538054805580568057805880598060806180628063806480658066806780688069807080718072807380748075807680778078807980808081808280838084808580868087808880898090809180928093809480958096809780988099810081018102810381048105810681078108810981108111811281138114811581168117811881198120812181228123812481258126812781288129813081318132813381348135813681378138813981408141814281438144814581468147814881498150815181528153815481558156815781588159816081618162816381648165816681678168816981708171817281738174817581768177817881798180818181828183818481858186818781888189819081918192819381948195819681978198819982008201820282038204820582068207820882098210821182128213821482158216821782188219822082218222822382248225822682278228822982308231823282338234823582368237823882398240824182428243824482458246824782488249825082518252825382548255825682578258825982608261826282638264826582668267826882698270827182728273827482758276827782788279828082818282828382848285828682878288828982908291829282938294829582968297829882998300830183028303830483058306830783088309831083118312831383148315831683178318831983208321832283238324832583268327832883298330833183328333833483358336833783388339834083418342834383448345834683478348834983508351835283538354835583568357835883598360836183628363836483658366836783688369837083718372837383748375837683778378837983808381838283838384838583868387838883898390839183928393839483958396839783988399840084018402840384048405840684078408840984108411841284138414841584168417841884198420842184228423842484258426842784288429843084318432843384348435843684378438843984408441844284438444844584468447844884498450845184528453845484558456845784588459846084618462846384648465846684678468846984708471847284738474847584768477847884798480848184828483848484858486848784888489849084918492849384948495849684978498849985008501850285038504850585068507850885098510851185128513851485158516851785188519852085218522852385248525852685278528852985308531853285338534853585368537853885398540854185428543854485458546854785488549855085518552855385548555855685578558855985608561856285638564856585668567856885698570857185728573857485758576857785788579858085818582858385848585858685878588858985908591859285938594859585968597859885998600860186028603860486058606860786088609861086118612861386148615861686178618861986208621862286238624862586268627862886298630863186328633863486358636863786388639864086418642864386448645864686478648864986508651865286538654865586568657865886598660866186628663866486658666866786688669867086718672867386748675867686778678867986808681868286838684868586868687868886898690869186928693869486958696869786988699870087018702870387048705870687078708870987108711871287138714871587168717871887198720872187228723872487258726872787288729873087318732873387348735873687378738873987408741874287438744
  1. // Copyright 2018 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package apex
  15. import (
  16. "fmt"
  17. "os"
  18. "path"
  19. "path/filepath"
  20. "reflect"
  21. "regexp"
  22. "sort"
  23. "strconv"
  24. "strings"
  25. "testing"
  26. "github.com/google/blueprint/proptools"
  27. "android/soong/android"
  28. "android/soong/bpf"
  29. "android/soong/cc"
  30. "android/soong/dexpreopt"
  31. prebuilt_etc "android/soong/etc"
  32. "android/soong/java"
  33. "android/soong/rust"
  34. "android/soong/sh"
  35. )
  36. // names returns name list from white space separated string
  37. func names(s string) (ns []string) {
  38. for _, n := range strings.Split(s, " ") {
  39. if len(n) > 0 {
  40. ns = append(ns, n)
  41. }
  42. }
  43. return
  44. }
  45. func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
  46. t.Helper()
  47. android.GroupFixturePreparers(
  48. prepareForApexTest,
  49. android.GroupFixturePreparers(preparers...),
  50. ).
  51. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
  52. RunTestWithBp(t, bp)
  53. }
  54. func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
  55. t.Helper()
  56. optionalBpPreparer := android.NullFixturePreparer
  57. if bp != "" {
  58. optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
  59. }
  60. result := android.GroupFixturePreparers(
  61. prepareForApexTest,
  62. android.GroupFixturePreparers(preparers...),
  63. optionalBpPreparer,
  64. ).RunTest(t)
  65. return result.TestContext
  66. }
  67. func withFiles(files android.MockFS) android.FixturePreparer {
  68. return files.AddToFixture()
  69. }
  70. func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
  71. return android.FixtureModifyConfig(func(config android.Config) {
  72. for k, v := range targets {
  73. config.Targets[k] = v
  74. }
  75. })
  76. }
  77. // withNativeBridgeTargets sets configuration with targets including:
  78. // - X86_64 (primary)
  79. // - X86 (secondary)
  80. // - Arm64 on X86_64 (native bridge)
  81. // - Arm on X86 (native bridge)
  82. var withNativeBridgeEnabled = android.FixtureModifyConfig(
  83. func(config android.Config) {
  84. config.Targets[android.Android] = []android.Target{
  85. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
  86. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  87. {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
  88. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  89. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
  90. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
  91. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  92. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
  93. }
  94. },
  95. )
  96. func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
  97. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  98. variables.ManifestPackageNameOverrides = specs
  99. })
  100. }
  101. var withBinder32bit = android.FixtureModifyProductVariables(
  102. func(variables android.FixtureProductVariables) {
  103. variables.Binder32bit = proptools.BoolPtr(true)
  104. },
  105. )
  106. var withUnbundledBuild = android.FixtureModifyProductVariables(
  107. func(variables android.FixtureProductVariables) {
  108. variables.Unbundled_build = proptools.BoolPtr(true)
  109. },
  110. )
  111. // Legacy preparer used for running tests within the apex package.
  112. //
  113. // This includes everything that was needed to run any test in the apex package prior to the
  114. // introduction of the test fixtures. Tests that are being converted to use fixtures directly
  115. // rather than through the testApex...() methods should avoid using this and instead use the
  116. // various preparers directly, using android.GroupFixturePreparers(...) to group them when
  117. // necessary.
  118. //
  119. // deprecated
  120. var prepareForApexTest = android.GroupFixturePreparers(
  121. // General preparers in alphabetical order as test infrastructure will enforce correct
  122. // registration order.
  123. android.PrepareForTestWithAndroidBuildComponents,
  124. bpf.PrepareForTestWithBpf,
  125. cc.PrepareForTestWithCcBuildComponents,
  126. java.PrepareForTestWithJavaDefaultModules,
  127. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  128. rust.PrepareForTestWithRustDefaultModules,
  129. sh.PrepareForTestWithShBuildComponents,
  130. PrepareForTestWithApexBuildComponents,
  131. // Additional apex test specific preparers.
  132. android.FixtureAddTextFile("system/sepolicy/Android.bp", `
  133. filegroup {
  134. name: "myapex-file_contexts",
  135. srcs: [
  136. "apex/myapex-file_contexts",
  137. ],
  138. }
  139. `),
  140. prepareForTestWithMyapex,
  141. android.FixtureMergeMockFs(android.MockFS{
  142. "a.java": nil,
  143. "PrebuiltAppFoo.apk": nil,
  144. "PrebuiltAppFooPriv.apk": nil,
  145. "apex_manifest.json": nil,
  146. "AndroidManifest.xml": nil,
  147. "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
  148. "system/sepolicy/apex/myapex2-file_contexts": nil,
  149. "system/sepolicy/apex/otherapex-file_contexts": nil,
  150. "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
  151. "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
  152. "mylib.cpp": nil,
  153. "mytest.cpp": nil,
  154. "mytest1.cpp": nil,
  155. "mytest2.cpp": nil,
  156. "mytest3.cpp": nil,
  157. "myprebuilt": nil,
  158. "my_include": nil,
  159. "foo/bar/MyClass.java": nil,
  160. "prebuilt.jar": nil,
  161. "prebuilt.so": nil,
  162. "vendor/foo/devkeys/test.x509.pem": nil,
  163. "vendor/foo/devkeys/test.pk8": nil,
  164. "testkey.x509.pem": nil,
  165. "testkey.pk8": nil,
  166. "testkey.override.x509.pem": nil,
  167. "testkey.override.pk8": nil,
  168. "vendor/foo/devkeys/testkey.avbpubkey": nil,
  169. "vendor/foo/devkeys/testkey.pem": nil,
  170. "NOTICE": nil,
  171. "custom_notice": nil,
  172. "custom_notice_for_static_lib": nil,
  173. "testkey2.avbpubkey": nil,
  174. "testkey2.pem": nil,
  175. "myapex-arm64.apex": nil,
  176. "myapex-arm.apex": nil,
  177. "myapex.apks": nil,
  178. "frameworks/base/api/current.txt": nil,
  179. "framework/aidl/a.aidl": nil,
  180. "build/make/core/proguard.flags": nil,
  181. "build/make/core/proguard_basic_keeps.flags": nil,
  182. "dummy.txt": nil,
  183. "baz": nil,
  184. "bar/baz": nil,
  185. "testdata/baz": nil,
  186. "AppSet.apks": nil,
  187. "foo.rs": nil,
  188. "libfoo.jar": nil,
  189. "libbar.jar": nil,
  190. },
  191. ),
  192. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  193. variables.DeviceVndkVersion = proptools.StringPtr("current")
  194. variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
  195. variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
  196. variables.Platform_sdk_codename = proptools.StringPtr("Q")
  197. variables.Platform_sdk_final = proptools.BoolPtr(false)
  198. // "Tiramisu" needs to be in the next line for compatibility with soong code,
  199. // not because of these tests specifically (it's not used by the tests)
  200. variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
  201. variables.Platform_vndk_version = proptools.StringPtr("29")
  202. }),
  203. )
  204. var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
  205. "system/sepolicy/apex/myapex-file_contexts": nil,
  206. })
  207. // ensure that 'result' equals 'expected'
  208. func ensureEquals(t *testing.T, result string, expected string) {
  209. t.Helper()
  210. if result != expected {
  211. t.Errorf("%q != %q", expected, result)
  212. }
  213. }
  214. // ensure that 'result' contains 'expected'
  215. func ensureContains(t *testing.T, result string, expected string) {
  216. t.Helper()
  217. if !strings.Contains(result, expected) {
  218. t.Errorf("%q is not found in %q", expected, result)
  219. }
  220. }
  221. // ensure that 'result' contains 'expected' exactly one time
  222. func ensureContainsOnce(t *testing.T, result string, expected string) {
  223. t.Helper()
  224. count := strings.Count(result, expected)
  225. if count != 1 {
  226. t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
  227. }
  228. }
  229. // ensures that 'result' does not contain 'notExpected'
  230. func ensureNotContains(t *testing.T, result string, notExpected string) {
  231. t.Helper()
  232. if strings.Contains(result, notExpected) {
  233. t.Errorf("%q is found in %q", notExpected, result)
  234. }
  235. }
  236. func ensureMatches(t *testing.T, result string, expectedRex string) {
  237. ok, err := regexp.MatchString(expectedRex, result)
  238. if err != nil {
  239. t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
  240. return
  241. }
  242. if !ok {
  243. t.Errorf("%s does not match regular expession %s", result, expectedRex)
  244. }
  245. }
  246. func ensureListContains(t *testing.T, result []string, expected string) {
  247. t.Helper()
  248. if !android.InList(expected, result) {
  249. t.Errorf("%q is not found in %v", expected, result)
  250. }
  251. }
  252. func ensureListNotContains(t *testing.T, result []string, notExpected string) {
  253. t.Helper()
  254. if android.InList(notExpected, result) {
  255. t.Errorf("%q is found in %v", notExpected, result)
  256. }
  257. }
  258. func ensureListEmpty(t *testing.T, result []string) {
  259. t.Helper()
  260. if len(result) > 0 {
  261. t.Errorf("%q is expected to be empty", result)
  262. }
  263. }
  264. func ensureListNotEmpty(t *testing.T, result []string) {
  265. t.Helper()
  266. if len(result) == 0 {
  267. t.Errorf("%q is expected to be not empty", result)
  268. }
  269. }
  270. // Minimal test
  271. func TestBasicApex(t *testing.T) {
  272. ctx := testApex(t, `
  273. apex_defaults {
  274. name: "myapex-defaults",
  275. manifest: ":myapex.manifest",
  276. androidManifest: ":myapex.androidmanifest",
  277. key: "myapex.key",
  278. binaries: ["foo.rust"],
  279. native_shared_libs: [
  280. "mylib",
  281. "libfoo.ffi",
  282. ],
  283. rust_dyn_libs: ["libfoo.dylib.rust"],
  284. multilib: {
  285. both: {
  286. binaries: ["foo"],
  287. }
  288. },
  289. java_libs: [
  290. "myjar",
  291. "myjar_dex",
  292. ],
  293. updatable: false,
  294. }
  295. apex {
  296. name: "myapex",
  297. defaults: ["myapex-defaults"],
  298. }
  299. apex_key {
  300. name: "myapex.key",
  301. public_key: "testkey.avbpubkey",
  302. private_key: "testkey.pem",
  303. }
  304. filegroup {
  305. name: "myapex.manifest",
  306. srcs: ["apex_manifest.json"],
  307. }
  308. filegroup {
  309. name: "myapex.androidmanifest",
  310. srcs: ["AndroidManifest.xml"],
  311. }
  312. cc_library {
  313. name: "mylib",
  314. srcs: ["mylib.cpp"],
  315. shared_libs: [
  316. "mylib2",
  317. "libbar.ffi",
  318. ],
  319. system_shared_libs: [],
  320. stl: "none",
  321. // TODO: remove //apex_available:platform
  322. apex_available: [
  323. "//apex_available:platform",
  324. "myapex",
  325. ],
  326. }
  327. cc_binary {
  328. name: "foo",
  329. srcs: ["mylib.cpp"],
  330. compile_multilib: "both",
  331. multilib: {
  332. lib32: {
  333. suffix: "32",
  334. },
  335. lib64: {
  336. suffix: "64",
  337. },
  338. },
  339. symlinks: ["foo_link_"],
  340. symlink_preferred_arch: true,
  341. system_shared_libs: [],
  342. stl: "none",
  343. apex_available: [ "myapex", "com.android.gki.*" ],
  344. }
  345. rust_binary {
  346. name: "foo.rust",
  347. srcs: ["foo.rs"],
  348. rlibs: ["libfoo.rlib.rust"],
  349. dylibs: ["libfoo.dylib.rust"],
  350. apex_available: ["myapex"],
  351. }
  352. rust_library_rlib {
  353. name: "libfoo.rlib.rust",
  354. srcs: ["foo.rs"],
  355. crate_name: "foo",
  356. apex_available: ["myapex"],
  357. shared_libs: ["libfoo.shared_from_rust"],
  358. }
  359. cc_library_shared {
  360. name: "libfoo.shared_from_rust",
  361. srcs: ["mylib.cpp"],
  362. system_shared_libs: [],
  363. stl: "none",
  364. apex_available: ["myapex"],
  365. }
  366. rust_library_dylib {
  367. name: "libfoo.dylib.rust",
  368. srcs: ["foo.rs"],
  369. crate_name: "foo",
  370. apex_available: ["myapex"],
  371. }
  372. rust_ffi_shared {
  373. name: "libfoo.ffi",
  374. srcs: ["foo.rs"],
  375. crate_name: "foo",
  376. apex_available: ["myapex"],
  377. }
  378. rust_ffi_shared {
  379. name: "libbar.ffi",
  380. srcs: ["foo.rs"],
  381. crate_name: "bar",
  382. apex_available: ["myapex"],
  383. }
  384. apex {
  385. name: "com.android.gki.fake",
  386. binaries: ["foo"],
  387. key: "myapex.key",
  388. file_contexts: ":myapex-file_contexts",
  389. updatable: false,
  390. }
  391. cc_library_shared {
  392. name: "mylib2",
  393. srcs: ["mylib.cpp"],
  394. system_shared_libs: [],
  395. stl: "none",
  396. notice: "custom_notice",
  397. static_libs: ["libstatic"],
  398. // TODO: remove //apex_available:platform
  399. apex_available: [
  400. "//apex_available:platform",
  401. "myapex",
  402. ],
  403. }
  404. cc_prebuilt_library_shared {
  405. name: "mylib2",
  406. srcs: ["prebuilt.so"],
  407. // TODO: remove //apex_available:platform
  408. apex_available: [
  409. "//apex_available:platform",
  410. "myapex",
  411. ],
  412. }
  413. cc_library_static {
  414. name: "libstatic",
  415. srcs: ["mylib.cpp"],
  416. system_shared_libs: [],
  417. stl: "none",
  418. notice: "custom_notice_for_static_lib",
  419. // TODO: remove //apex_available:platform
  420. apex_available: [
  421. "//apex_available:platform",
  422. "myapex",
  423. ],
  424. }
  425. java_library {
  426. name: "myjar",
  427. srcs: ["foo/bar/MyClass.java"],
  428. stem: "myjar_stem",
  429. sdk_version: "none",
  430. system_modules: "none",
  431. static_libs: ["myotherjar"],
  432. libs: ["mysharedjar"],
  433. // TODO: remove //apex_available:platform
  434. apex_available: [
  435. "//apex_available:platform",
  436. "myapex",
  437. ],
  438. }
  439. dex_import {
  440. name: "myjar_dex",
  441. jars: ["prebuilt.jar"],
  442. apex_available: [
  443. "//apex_available:platform",
  444. "myapex",
  445. ],
  446. }
  447. java_library {
  448. name: "myotherjar",
  449. srcs: ["foo/bar/MyClass.java"],
  450. sdk_version: "none",
  451. system_modules: "none",
  452. // TODO: remove //apex_available:platform
  453. apex_available: [
  454. "//apex_available:platform",
  455. "myapex",
  456. ],
  457. }
  458. java_library {
  459. name: "mysharedjar",
  460. srcs: ["foo/bar/MyClass.java"],
  461. sdk_version: "none",
  462. system_modules: "none",
  463. }
  464. `)
  465. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  466. // Make sure that Android.mk is created
  467. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  468. data := android.AndroidMkDataForTest(t, ctx, ab)
  469. var builder strings.Builder
  470. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  471. androidMk := builder.String()
  472. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  473. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  474. optFlags := apexRule.Args["opt_flags"]
  475. ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
  476. // Ensure that the NOTICE output is being packaged as an asset.
  477. ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
  478. copyCmds := apexRule.Args["copy_commands"]
  479. // Ensure that main rule creates an output
  480. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  481. // Ensure that apex variant is created for the direct dep
  482. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  483. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
  484. ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
  485. ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
  486. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
  487. // Ensure that apex variant is created for the indirect dep
  488. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  489. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
  490. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
  491. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
  492. ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
  493. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
  494. // Ensure that both direct and indirect deps are copied into apex
  495. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  496. ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  497. ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
  498. ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
  499. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
  500. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
  501. ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
  502. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  503. // .. but not for java libs
  504. ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
  505. ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
  506. // Ensure that the platform variant ends with _shared or _common
  507. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  508. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  509. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
  510. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
  511. ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
  512. // Ensure that dynamic dependency to java libs are not included
  513. ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
  514. // Ensure that all symlinks are present.
  515. found_foo_link_64 := false
  516. found_foo := false
  517. for _, cmd := range strings.Split(copyCmds, " && ") {
  518. if strings.HasPrefix(cmd, "ln -sfn foo64") {
  519. if strings.HasSuffix(cmd, "bin/foo") {
  520. found_foo = true
  521. } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
  522. found_foo_link_64 = true
  523. }
  524. }
  525. }
  526. good := found_foo && found_foo_link_64
  527. if !good {
  528. t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
  529. }
  530. mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
  531. noticeInputs := mergeNoticesRule.Inputs.Strings()
  532. if len(noticeInputs) != 3 {
  533. t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
  534. }
  535. ensureListContains(t, noticeInputs, "NOTICE")
  536. ensureListContains(t, noticeInputs, "custom_notice")
  537. ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
  538. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  539. ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
  540. ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
  541. ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
  542. ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
  543. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  544. ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
  545. ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
  546. ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
  547. ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
  548. }
  549. func TestDefaults(t *testing.T) {
  550. ctx := testApex(t, `
  551. apex_defaults {
  552. name: "myapex-defaults",
  553. key: "myapex.key",
  554. prebuilts: ["myetc"],
  555. native_shared_libs: ["mylib"],
  556. java_libs: ["myjar"],
  557. apps: ["AppFoo"],
  558. rros: ["rro"],
  559. bpfs: ["bpf"],
  560. updatable: false,
  561. }
  562. prebuilt_etc {
  563. name: "myetc",
  564. src: "myprebuilt",
  565. }
  566. apex {
  567. name: "myapex",
  568. defaults: ["myapex-defaults"],
  569. }
  570. apex_key {
  571. name: "myapex.key",
  572. public_key: "testkey.avbpubkey",
  573. private_key: "testkey.pem",
  574. }
  575. cc_library {
  576. name: "mylib",
  577. system_shared_libs: [],
  578. stl: "none",
  579. apex_available: [ "myapex" ],
  580. }
  581. java_library {
  582. name: "myjar",
  583. srcs: ["foo/bar/MyClass.java"],
  584. sdk_version: "none",
  585. system_modules: "none",
  586. apex_available: [ "myapex" ],
  587. }
  588. android_app {
  589. name: "AppFoo",
  590. srcs: ["foo/bar/MyClass.java"],
  591. sdk_version: "none",
  592. system_modules: "none",
  593. apex_available: [ "myapex" ],
  594. }
  595. runtime_resource_overlay {
  596. name: "rro",
  597. theme: "blue",
  598. }
  599. bpf {
  600. name: "bpf",
  601. srcs: ["bpf.c", "bpf2.c"],
  602. }
  603. `)
  604. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  605. "etc/myetc",
  606. "javalib/myjar.jar",
  607. "lib64/mylib.so",
  608. "app/AppFoo/AppFoo.apk",
  609. "overlay/blue/rro.apk",
  610. "etc/bpf/bpf.o",
  611. "etc/bpf/bpf2.o",
  612. })
  613. }
  614. func TestApexManifest(t *testing.T) {
  615. ctx := testApex(t, `
  616. apex {
  617. name: "myapex",
  618. key: "myapex.key",
  619. updatable: false,
  620. }
  621. apex_key {
  622. name: "myapex.key",
  623. public_key: "testkey.avbpubkey",
  624. private_key: "testkey.pem",
  625. }
  626. `)
  627. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  628. args := module.Rule("apexRule").Args
  629. if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
  630. t.Error("manifest should be apex_manifest.pb, but " + manifest)
  631. }
  632. }
  633. func TestApexManifestMinSdkVersion(t *testing.T) {
  634. ctx := testApex(t, `
  635. apex_defaults {
  636. name: "my_defaults",
  637. key: "myapex.key",
  638. product_specific: true,
  639. file_contexts: ":my-file-contexts",
  640. updatable: false,
  641. }
  642. apex {
  643. name: "myapex_30",
  644. min_sdk_version: "30",
  645. defaults: ["my_defaults"],
  646. }
  647. apex {
  648. name: "myapex_current",
  649. min_sdk_version: "current",
  650. defaults: ["my_defaults"],
  651. }
  652. apex {
  653. name: "myapex_none",
  654. defaults: ["my_defaults"],
  655. }
  656. apex_key {
  657. name: "myapex.key",
  658. public_key: "testkey.avbpubkey",
  659. private_key: "testkey.pem",
  660. }
  661. filegroup {
  662. name: "my-file-contexts",
  663. srcs: ["product_specific_file_contexts"],
  664. }
  665. `, withFiles(map[string][]byte{
  666. "product_specific_file_contexts": nil,
  667. }), android.FixtureModifyProductVariables(
  668. func(variables android.FixtureProductVariables) {
  669. variables.Unbundled_build = proptools.BoolPtr(true)
  670. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
  671. }), android.FixtureMergeEnv(map[string]string{
  672. "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
  673. }))
  674. testCases := []struct {
  675. module string
  676. minSdkVersion string
  677. }{
  678. {
  679. module: "myapex_30",
  680. minSdkVersion: "30",
  681. },
  682. {
  683. module: "myapex_current",
  684. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  685. },
  686. {
  687. module: "myapex_none",
  688. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  689. },
  690. }
  691. for _, tc := range testCases {
  692. module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
  693. args := module.Rule("apexRule").Args
  694. optFlags := args["opt_flags"]
  695. if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
  696. t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
  697. }
  698. }
  699. }
  700. func TestBasicZipApex(t *testing.T) {
  701. ctx := testApex(t, `
  702. apex {
  703. name: "myapex",
  704. key: "myapex.key",
  705. payload_type: "zip",
  706. native_shared_libs: ["mylib"],
  707. updatable: false,
  708. }
  709. apex_key {
  710. name: "myapex.key",
  711. public_key: "testkey.avbpubkey",
  712. private_key: "testkey.pem",
  713. }
  714. cc_library {
  715. name: "mylib",
  716. srcs: ["mylib.cpp"],
  717. shared_libs: ["mylib2"],
  718. system_shared_libs: [],
  719. stl: "none",
  720. apex_available: [ "myapex" ],
  721. }
  722. cc_library {
  723. name: "mylib2",
  724. srcs: ["mylib.cpp"],
  725. system_shared_libs: [],
  726. stl: "none",
  727. apex_available: [ "myapex" ],
  728. }
  729. `)
  730. zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
  731. copyCmds := zipApexRule.Args["copy_commands"]
  732. // Ensure that main rule creates an output
  733. ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
  734. // Ensure that APEX variant is created for the direct dep
  735. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  736. // Ensure that APEX variant is created for the indirect dep
  737. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  738. // Ensure that both direct and indirect deps are copied into apex
  739. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
  740. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
  741. }
  742. func TestApexWithStubs(t *testing.T) {
  743. ctx := testApex(t, `
  744. apex {
  745. name: "myapex",
  746. key: "myapex.key",
  747. native_shared_libs: ["mylib", "mylib3"],
  748. binaries: ["foo.rust"],
  749. updatable: false,
  750. }
  751. apex_key {
  752. name: "myapex.key",
  753. public_key: "testkey.avbpubkey",
  754. private_key: "testkey.pem",
  755. }
  756. cc_library {
  757. name: "mylib",
  758. srcs: ["mylib.cpp"],
  759. shared_libs: ["mylib2", "mylib3"],
  760. system_shared_libs: [],
  761. stl: "none",
  762. apex_available: [ "myapex" ],
  763. }
  764. cc_library {
  765. name: "mylib2",
  766. srcs: ["mylib.cpp"],
  767. cflags: ["-include mylib.h"],
  768. system_shared_libs: [],
  769. stl: "none",
  770. stubs: {
  771. versions: ["1", "2", "3"],
  772. },
  773. }
  774. cc_library {
  775. name: "mylib3",
  776. srcs: ["mylib.cpp"],
  777. shared_libs: ["mylib4"],
  778. system_shared_libs: [],
  779. stl: "none",
  780. stubs: {
  781. versions: ["10", "11", "12"],
  782. },
  783. apex_available: [ "myapex" ],
  784. }
  785. cc_library {
  786. name: "mylib4",
  787. srcs: ["mylib.cpp"],
  788. system_shared_libs: [],
  789. stl: "none",
  790. apex_available: [ "myapex" ],
  791. }
  792. rust_binary {
  793. name: "foo.rust",
  794. srcs: ["foo.rs"],
  795. shared_libs: ["libfoo.shared_from_rust"],
  796. prefer_rlib: true,
  797. apex_available: ["myapex"],
  798. }
  799. cc_library_shared {
  800. name: "libfoo.shared_from_rust",
  801. srcs: ["mylib.cpp"],
  802. system_shared_libs: [],
  803. stl: "none",
  804. stubs: {
  805. versions: ["10", "11", "12"],
  806. },
  807. }
  808. `)
  809. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  810. copyCmds := apexRule.Args["copy_commands"]
  811. // Ensure that direct non-stubs dep is always included
  812. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  813. // Ensure that indirect stubs dep is not included
  814. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  815. // Ensure that direct stubs dep is included
  816. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  817. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  818. // Ensure that mylib is linking with the latest version of stubs for mylib2
  819. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  820. // ... and not linking to the non-stub (impl) variant of mylib2
  821. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  822. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  823. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
  824. // .. and not linking to the stubs variant of mylib3
  825. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
  826. // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
  827. // is replaced by sharing of "cFlags" in cc/builder.go.
  828. // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
  829. // module variable representing "cflags". So it was not detected by ensureNotContains.
  830. // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
  831. // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
  832. // including the original cflags's "-include mylib.h".
  833. //
  834. // Ensure that stubs libs are built without -include flags
  835. // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  836. // ensureNotContains(t, mylib2Cflags, "-include ")
  837. // Ensure that genstub is invoked with --apex
  838. ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
  839. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  840. "lib64/mylib.so",
  841. "lib64/mylib3.so",
  842. "lib64/mylib4.so",
  843. "bin/foo.rust",
  844. "lib64/libc++.so", // by the implicit dependency from foo.rust
  845. "lib64/liblog.so", // by the implicit dependency from foo.rust
  846. })
  847. // Ensure that stub dependency from a rust module is not included
  848. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  849. // The rust module is linked to the stub cc library
  850. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
  851. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  852. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  853. }
  854. func TestApexCanUsePrivateApis(t *testing.T) {
  855. ctx := testApex(t, `
  856. apex {
  857. name: "myapex",
  858. key: "myapex.key",
  859. native_shared_libs: ["mylib"],
  860. binaries: ["foo.rust"],
  861. updatable: false,
  862. platform_apis: true,
  863. }
  864. apex_key {
  865. name: "myapex.key",
  866. public_key: "testkey.avbpubkey",
  867. private_key: "testkey.pem",
  868. }
  869. cc_library {
  870. name: "mylib",
  871. srcs: ["mylib.cpp"],
  872. shared_libs: ["mylib2"],
  873. system_shared_libs: [],
  874. stl: "none",
  875. apex_available: [ "myapex" ],
  876. }
  877. cc_library {
  878. name: "mylib2",
  879. srcs: ["mylib.cpp"],
  880. cflags: ["-include mylib.h"],
  881. system_shared_libs: [],
  882. stl: "none",
  883. stubs: {
  884. versions: ["1", "2", "3"],
  885. },
  886. }
  887. rust_binary {
  888. name: "foo.rust",
  889. srcs: ["foo.rs"],
  890. shared_libs: ["libfoo.shared_from_rust"],
  891. prefer_rlib: true,
  892. apex_available: ["myapex"],
  893. }
  894. cc_library_shared {
  895. name: "libfoo.shared_from_rust",
  896. srcs: ["mylib.cpp"],
  897. system_shared_libs: [],
  898. stl: "none",
  899. stubs: {
  900. versions: ["10", "11", "12"],
  901. },
  902. }
  903. `)
  904. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  905. copyCmds := apexRule.Args["copy_commands"]
  906. // Ensure that indirect stubs dep is not included
  907. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  908. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  909. // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
  910. // of the platform_apis: true)
  911. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000_private").Rule("ld").Args["libFlags"]
  912. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  913. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  914. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000_private").Rule("rustc").Args["linkFlags"]
  915. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  916. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  917. }
  918. func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
  919. t.Parallel()
  920. ctx := testApex(t, `
  921. apex {
  922. name: "myapex",
  923. key: "myapex.key",
  924. native_shared_libs: ["mylib", "mylib3"],
  925. min_sdk_version: "29",
  926. }
  927. apex_key {
  928. name: "myapex.key",
  929. public_key: "testkey.avbpubkey",
  930. private_key: "testkey.pem",
  931. }
  932. cc_library {
  933. name: "mylib",
  934. srcs: ["mylib.cpp"],
  935. shared_libs: ["mylib2", "mylib3"],
  936. system_shared_libs: [],
  937. stl: "none",
  938. apex_available: [ "myapex" ],
  939. min_sdk_version: "28",
  940. }
  941. cc_library {
  942. name: "mylib2",
  943. srcs: ["mylib.cpp"],
  944. cflags: ["-include mylib.h"],
  945. system_shared_libs: [],
  946. stl: "none",
  947. stubs: {
  948. versions: ["28", "29", "30", "current"],
  949. },
  950. min_sdk_version: "28",
  951. }
  952. cc_library {
  953. name: "mylib3",
  954. srcs: ["mylib.cpp"],
  955. shared_libs: ["mylib4"],
  956. system_shared_libs: [],
  957. stl: "none",
  958. stubs: {
  959. versions: ["28", "29", "30", "current"],
  960. },
  961. apex_available: [ "myapex" ],
  962. min_sdk_version: "28",
  963. }
  964. cc_library {
  965. name: "mylib4",
  966. srcs: ["mylib.cpp"],
  967. system_shared_libs: [],
  968. stl: "none",
  969. apex_available: [ "myapex" ],
  970. min_sdk_version: "28",
  971. }
  972. `)
  973. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  974. copyCmds := apexRule.Args["copy_commands"]
  975. // Ensure that direct non-stubs dep is always included
  976. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  977. // Ensure that indirect stubs dep is not included
  978. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  979. // Ensure that direct stubs dep is included
  980. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  981. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
  982. // Ensure that mylib is linking with the latest version of stub for mylib2
  983. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  984. // ... and not linking to the non-stub (impl) variant of mylib2
  985. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  986. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  987. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
  988. // .. and not linking to the stubs variant of mylib3
  989. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
  990. // Ensure that stubs libs are built without -include flags
  991. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
  992. ensureNotContains(t, mylib2Cflags, "-include ")
  993. // Ensure that genstub is invoked with --apex
  994. ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
  995. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  996. "lib64/mylib.so",
  997. "lib64/mylib3.so",
  998. "lib64/mylib4.so",
  999. })
  1000. }
  1001. func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
  1002. t.Parallel()
  1003. // myapex (Z)
  1004. // mylib -----------------.
  1005. // |
  1006. // otherapex (29) |
  1007. // libstub's versions: 29 Z current
  1008. // |
  1009. // <platform> |
  1010. // libplatform ----------------'
  1011. ctx := testApex(t, `
  1012. apex {
  1013. name: "myapex",
  1014. key: "myapex.key",
  1015. native_shared_libs: ["mylib"],
  1016. min_sdk_version: "Z", // non-final
  1017. }
  1018. cc_library {
  1019. name: "mylib",
  1020. srcs: ["mylib.cpp"],
  1021. shared_libs: ["libstub"],
  1022. apex_available: ["myapex"],
  1023. min_sdk_version: "Z",
  1024. }
  1025. apex_key {
  1026. name: "myapex.key",
  1027. public_key: "testkey.avbpubkey",
  1028. private_key: "testkey.pem",
  1029. }
  1030. apex {
  1031. name: "otherapex",
  1032. key: "myapex.key",
  1033. native_shared_libs: ["libstub"],
  1034. min_sdk_version: "29",
  1035. }
  1036. cc_library {
  1037. name: "libstub",
  1038. srcs: ["mylib.cpp"],
  1039. stubs: {
  1040. versions: ["29", "Z", "current"],
  1041. },
  1042. apex_available: ["otherapex"],
  1043. min_sdk_version: "29",
  1044. }
  1045. // platform module depending on libstub from otherapex should use the latest stub("current")
  1046. cc_library {
  1047. name: "libplatform",
  1048. srcs: ["mylib.cpp"],
  1049. shared_libs: ["libstub"],
  1050. }
  1051. `,
  1052. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1053. variables.Platform_sdk_codename = proptools.StringPtr("Z")
  1054. variables.Platform_sdk_final = proptools.BoolPtr(false)
  1055. variables.Platform_version_active_codenames = []string{"Z"}
  1056. }),
  1057. )
  1058. // Ensure that mylib from myapex is built against the latest stub (current)
  1059. mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1060. ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
  1061. mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1062. ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1063. // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
  1064. libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  1065. ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
  1066. libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1067. ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1068. }
  1069. func TestApexWithExplicitStubsDependency(t *testing.T) {
  1070. ctx := testApex(t, `
  1071. apex {
  1072. name: "myapex2",
  1073. key: "myapex2.key",
  1074. native_shared_libs: ["mylib"],
  1075. updatable: false,
  1076. }
  1077. apex_key {
  1078. name: "myapex2.key",
  1079. public_key: "testkey.avbpubkey",
  1080. private_key: "testkey.pem",
  1081. }
  1082. cc_library {
  1083. name: "mylib",
  1084. srcs: ["mylib.cpp"],
  1085. shared_libs: ["libfoo#10"],
  1086. static_libs: ["libbaz"],
  1087. system_shared_libs: [],
  1088. stl: "none",
  1089. apex_available: [ "myapex2" ],
  1090. }
  1091. cc_library {
  1092. name: "libfoo",
  1093. srcs: ["mylib.cpp"],
  1094. shared_libs: ["libbar"],
  1095. system_shared_libs: [],
  1096. stl: "none",
  1097. stubs: {
  1098. versions: ["10", "20", "30"],
  1099. },
  1100. }
  1101. cc_library {
  1102. name: "libbar",
  1103. srcs: ["mylib.cpp"],
  1104. system_shared_libs: [],
  1105. stl: "none",
  1106. }
  1107. cc_library_static {
  1108. name: "libbaz",
  1109. srcs: ["mylib.cpp"],
  1110. system_shared_libs: [],
  1111. stl: "none",
  1112. apex_available: [ "myapex2" ],
  1113. }
  1114. `)
  1115. apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
  1116. copyCmds := apexRule.Args["copy_commands"]
  1117. // Ensure that direct non-stubs dep is always included
  1118. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1119. // Ensure that indirect stubs dep is not included
  1120. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1121. // Ensure that dependency of stubs is not included
  1122. ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1123. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1124. // Ensure that mylib is linking with version 10 of libfoo
  1125. ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
  1126. // ... and not linking to the non-stub (impl) variant of libfoo
  1127. ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
  1128. libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
  1129. // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
  1130. ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
  1131. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  1132. ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
  1133. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  1134. ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
  1135. }
  1136. func TestApexWithRuntimeLibsDependency(t *testing.T) {
  1137. /*
  1138. myapex
  1139. |
  1140. v (runtime_libs)
  1141. mylib ------+------> libfoo [provides stub]
  1142. |
  1143. `------> libbar
  1144. */
  1145. ctx := testApex(t, `
  1146. apex {
  1147. name: "myapex",
  1148. key: "myapex.key",
  1149. native_shared_libs: ["mylib"],
  1150. updatable: false,
  1151. }
  1152. apex_key {
  1153. name: "myapex.key",
  1154. public_key: "testkey.avbpubkey",
  1155. private_key: "testkey.pem",
  1156. }
  1157. cc_library {
  1158. name: "mylib",
  1159. srcs: ["mylib.cpp"],
  1160. runtime_libs: ["libfoo", "libbar"],
  1161. system_shared_libs: [],
  1162. stl: "none",
  1163. apex_available: [ "myapex" ],
  1164. }
  1165. cc_library {
  1166. name: "libfoo",
  1167. srcs: ["mylib.cpp"],
  1168. system_shared_libs: [],
  1169. stl: "none",
  1170. stubs: {
  1171. versions: ["10", "20", "30"],
  1172. },
  1173. }
  1174. cc_library {
  1175. name: "libbar",
  1176. srcs: ["mylib.cpp"],
  1177. system_shared_libs: [],
  1178. stl: "none",
  1179. apex_available: [ "myapex" ],
  1180. }
  1181. `)
  1182. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1183. copyCmds := apexRule.Args["copy_commands"]
  1184. // Ensure that direct non-stubs dep is always included
  1185. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1186. // Ensure that indirect stubs dep is not included
  1187. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1188. // Ensure that runtime_libs dep in included
  1189. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1190. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1191. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1192. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
  1193. }
  1194. var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
  1195. cc.PrepareForTestWithCcBuildComponents,
  1196. PrepareForTestWithApexBuildComponents,
  1197. android.FixtureAddTextFile("bionic/apex/Android.bp", `
  1198. apex {
  1199. name: "com.android.runtime",
  1200. key: "com.android.runtime.key",
  1201. native_shared_libs: ["libc"],
  1202. updatable: false,
  1203. }
  1204. apex_key {
  1205. name: "com.android.runtime.key",
  1206. public_key: "testkey.avbpubkey",
  1207. private_key: "testkey.pem",
  1208. }
  1209. `),
  1210. android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
  1211. )
  1212. func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
  1213. result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
  1214. cc_library {
  1215. name: "libc",
  1216. no_libcrt: true,
  1217. nocrt: true,
  1218. stl: "none",
  1219. system_shared_libs: [],
  1220. stubs: { versions: ["1"] },
  1221. apex_available: ["com.android.runtime"],
  1222. sanitize: {
  1223. hwaddress: true,
  1224. }
  1225. }
  1226. cc_prebuilt_library_shared {
  1227. name: "libclang_rt.hwasan-aarch64-android",
  1228. no_libcrt: true,
  1229. nocrt: true,
  1230. stl: "none",
  1231. system_shared_libs: [],
  1232. srcs: [""],
  1233. stubs: { versions: ["1"] },
  1234. sanitize: {
  1235. never: true,
  1236. },
  1237. } `)
  1238. ctx := result.TestContext
  1239. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1240. "lib64/bionic/libc.so",
  1241. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1242. })
  1243. hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
  1244. installed := hwasan.Description("install libclang_rt.hwasan")
  1245. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1246. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1247. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1248. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1249. }
  1250. func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
  1251. result := android.GroupFixturePreparers(
  1252. prepareForTestOfRuntimeApexWithHwasan,
  1253. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1254. variables.SanitizeDevice = []string{"hwaddress"}
  1255. }),
  1256. ).RunTestWithBp(t, `
  1257. cc_library {
  1258. name: "libc",
  1259. no_libcrt: true,
  1260. nocrt: true,
  1261. stl: "none",
  1262. system_shared_libs: [],
  1263. stubs: { versions: ["1"] },
  1264. apex_available: ["com.android.runtime"],
  1265. }
  1266. cc_prebuilt_library_shared {
  1267. name: "libclang_rt.hwasan-aarch64-android",
  1268. no_libcrt: true,
  1269. nocrt: true,
  1270. stl: "none",
  1271. system_shared_libs: [],
  1272. srcs: [""],
  1273. stubs: { versions: ["1"] },
  1274. sanitize: {
  1275. never: true,
  1276. },
  1277. }
  1278. `)
  1279. ctx := result.TestContext
  1280. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1281. "lib64/bionic/libc.so",
  1282. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1283. })
  1284. hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
  1285. installed := hwasan.Description("install libclang_rt.hwasan")
  1286. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1287. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1288. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1289. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1290. }
  1291. func TestApexDependsOnLLNDKTransitively(t *testing.T) {
  1292. testcases := []struct {
  1293. name string
  1294. minSdkVersion string
  1295. apexVariant string
  1296. shouldLink string
  1297. shouldNotLink []string
  1298. }{
  1299. {
  1300. name: "unspecified version links to the latest",
  1301. minSdkVersion: "",
  1302. apexVariant: "apex10000",
  1303. shouldLink: "current",
  1304. shouldNotLink: []string{"29", "30"},
  1305. },
  1306. {
  1307. name: "always use the latest",
  1308. minSdkVersion: "min_sdk_version: \"29\",",
  1309. apexVariant: "apex29",
  1310. shouldLink: "current",
  1311. shouldNotLink: []string{"29", "30"},
  1312. },
  1313. }
  1314. for _, tc := range testcases {
  1315. t.Run(tc.name, func(t *testing.T) {
  1316. ctx := testApex(t, `
  1317. apex {
  1318. name: "myapex",
  1319. key: "myapex.key",
  1320. native_shared_libs: ["mylib"],
  1321. updatable: false,
  1322. `+tc.minSdkVersion+`
  1323. }
  1324. apex_key {
  1325. name: "myapex.key",
  1326. public_key: "testkey.avbpubkey",
  1327. private_key: "testkey.pem",
  1328. }
  1329. cc_library {
  1330. name: "mylib",
  1331. srcs: ["mylib.cpp"],
  1332. vendor_available: true,
  1333. shared_libs: ["libbar"],
  1334. system_shared_libs: [],
  1335. stl: "none",
  1336. apex_available: [ "myapex" ],
  1337. min_sdk_version: "29",
  1338. }
  1339. cc_library {
  1340. name: "libbar",
  1341. srcs: ["mylib.cpp"],
  1342. system_shared_libs: [],
  1343. stl: "none",
  1344. stubs: { versions: ["29","30"] },
  1345. llndk: {
  1346. symbol_file: "libbar.map.txt",
  1347. }
  1348. }
  1349. `,
  1350. withUnbundledBuild,
  1351. )
  1352. // Ensure that LLNDK dep is not included
  1353. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1354. "lib64/mylib.so",
  1355. })
  1356. // Ensure that LLNDK dep is required
  1357. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1358. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1359. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
  1360. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
  1361. ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
  1362. for _, ver := range tc.shouldNotLink {
  1363. ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
  1364. }
  1365. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
  1366. ver := tc.shouldLink
  1367. if tc.shouldLink == "current" {
  1368. ver = strconv.Itoa(android.FutureApiLevelInt)
  1369. }
  1370. ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
  1371. })
  1372. }
  1373. }
  1374. func TestApexWithSystemLibsStubs(t *testing.T) {
  1375. ctx := testApex(t, `
  1376. apex {
  1377. name: "myapex",
  1378. key: "myapex.key",
  1379. native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
  1380. updatable: false,
  1381. }
  1382. apex_key {
  1383. name: "myapex.key",
  1384. public_key: "testkey.avbpubkey",
  1385. private_key: "testkey.pem",
  1386. }
  1387. cc_library {
  1388. name: "mylib",
  1389. srcs: ["mylib.cpp"],
  1390. system_shared_libs: ["libc", "libm"],
  1391. shared_libs: ["libdl#27"],
  1392. stl: "none",
  1393. apex_available: [ "myapex" ],
  1394. }
  1395. cc_library_shared {
  1396. name: "mylib_shared",
  1397. srcs: ["mylib.cpp"],
  1398. shared_libs: ["libdl#27"],
  1399. stl: "none",
  1400. apex_available: [ "myapex" ],
  1401. }
  1402. cc_library {
  1403. name: "libBootstrap",
  1404. srcs: ["mylib.cpp"],
  1405. stl: "none",
  1406. bootstrap: true,
  1407. }
  1408. `)
  1409. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1410. copyCmds := apexRule.Args["copy_commands"]
  1411. // Ensure that mylib, libm, libdl are included.
  1412. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1413. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
  1414. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
  1415. // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
  1416. ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
  1417. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1418. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1419. mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
  1420. // For dependency to libc
  1421. // Ensure that mylib is linking with the latest version of stubs
  1422. ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
  1423. // ... and not linking to the non-stub (impl) variant
  1424. ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1425. // ... Cflags from stub is correctly exported to mylib
  1426. ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
  1427. ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
  1428. // For dependency to libm
  1429. // Ensure that mylib is linking with the non-stub (impl) variant
  1430. ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
  1431. // ... and not linking to the stub variant
  1432. ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
  1433. // ... and is not compiling with the stub
  1434. ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
  1435. ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
  1436. // For dependency to libdl
  1437. // Ensure that mylib is linking with the specified version of stubs
  1438. ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
  1439. // ... and not linking to the other versions of stubs
  1440. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
  1441. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
  1442. // ... and not linking to the non-stub (impl) variant
  1443. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
  1444. // ... Cflags from stub is correctly exported to mylib
  1445. ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
  1446. ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
  1447. // Ensure that libBootstrap is depending on the platform variant of bionic libs
  1448. libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1449. ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1450. ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
  1451. ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
  1452. }
  1453. func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
  1454. // there are three links between liba --> libz.
  1455. // 1) myapex -> libx -> liba -> libz : this should be #30 link
  1456. // 2) otherapex -> liby -> liba -> libz : this should be #30 link
  1457. // 3) (platform) -> liba -> libz : this should be non-stub link
  1458. ctx := testApex(t, `
  1459. apex {
  1460. name: "myapex",
  1461. key: "myapex.key",
  1462. native_shared_libs: ["libx"],
  1463. min_sdk_version: "29",
  1464. }
  1465. apex {
  1466. name: "otherapex",
  1467. key: "myapex.key",
  1468. native_shared_libs: ["liby"],
  1469. min_sdk_version: "30",
  1470. }
  1471. apex_key {
  1472. name: "myapex.key",
  1473. public_key: "testkey.avbpubkey",
  1474. private_key: "testkey.pem",
  1475. }
  1476. cc_library {
  1477. name: "libx",
  1478. shared_libs: ["liba"],
  1479. system_shared_libs: [],
  1480. stl: "none",
  1481. apex_available: [ "myapex" ],
  1482. min_sdk_version: "29",
  1483. }
  1484. cc_library {
  1485. name: "liby",
  1486. shared_libs: ["liba"],
  1487. system_shared_libs: [],
  1488. stl: "none",
  1489. apex_available: [ "otherapex" ],
  1490. min_sdk_version: "29",
  1491. }
  1492. cc_library {
  1493. name: "liba",
  1494. shared_libs: ["libz"],
  1495. system_shared_libs: [],
  1496. stl: "none",
  1497. apex_available: [
  1498. "//apex_available:anyapex",
  1499. "//apex_available:platform",
  1500. ],
  1501. min_sdk_version: "29",
  1502. }
  1503. cc_library {
  1504. name: "libz",
  1505. system_shared_libs: [],
  1506. stl: "none",
  1507. stubs: {
  1508. versions: ["28", "30"],
  1509. },
  1510. }
  1511. `)
  1512. expectLink := func(from, from_variant, to, to_variant string) {
  1513. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1514. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1515. }
  1516. expectNoLink := func(from, from_variant, to, to_variant string) {
  1517. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1518. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1519. }
  1520. // platform liba is linked to non-stub version
  1521. expectLink("liba", "shared", "libz", "shared")
  1522. // liba in myapex is linked to current
  1523. expectLink("liba", "shared_apex29", "libz", "shared_current")
  1524. expectNoLink("liba", "shared_apex29", "libz", "shared_30")
  1525. expectNoLink("liba", "shared_apex29", "libz", "shared_28")
  1526. expectNoLink("liba", "shared_apex29", "libz", "shared")
  1527. // liba in otherapex is linked to current
  1528. expectLink("liba", "shared_apex30", "libz", "shared_current")
  1529. expectNoLink("liba", "shared_apex30", "libz", "shared_30")
  1530. expectNoLink("liba", "shared_apex30", "libz", "shared_28")
  1531. expectNoLink("liba", "shared_apex30", "libz", "shared")
  1532. }
  1533. func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
  1534. ctx := testApex(t, `
  1535. apex {
  1536. name: "myapex",
  1537. key: "myapex.key",
  1538. native_shared_libs: ["libx"],
  1539. min_sdk_version: "R",
  1540. }
  1541. apex_key {
  1542. name: "myapex.key",
  1543. public_key: "testkey.avbpubkey",
  1544. private_key: "testkey.pem",
  1545. }
  1546. cc_library {
  1547. name: "libx",
  1548. shared_libs: ["libz"],
  1549. system_shared_libs: [],
  1550. stl: "none",
  1551. apex_available: [ "myapex" ],
  1552. min_sdk_version: "R",
  1553. }
  1554. cc_library {
  1555. name: "libz",
  1556. system_shared_libs: [],
  1557. stl: "none",
  1558. stubs: {
  1559. versions: ["29", "R"],
  1560. },
  1561. }
  1562. `,
  1563. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1564. variables.Platform_version_active_codenames = []string{"R"}
  1565. }),
  1566. )
  1567. expectLink := func(from, from_variant, to, to_variant string) {
  1568. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1569. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1570. }
  1571. expectNoLink := func(from, from_variant, to, to_variant string) {
  1572. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1573. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1574. }
  1575. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1576. expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
  1577. expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
  1578. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1579. }
  1580. func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
  1581. testApex(t, `
  1582. apex {
  1583. name: "myapex",
  1584. key: "myapex.key",
  1585. java_libs: ["libx"],
  1586. min_sdk_version: "S",
  1587. }
  1588. apex_key {
  1589. name: "myapex.key",
  1590. public_key: "testkey.avbpubkey",
  1591. private_key: "testkey.pem",
  1592. }
  1593. java_library {
  1594. name: "libx",
  1595. srcs: ["a.java"],
  1596. apex_available: [ "myapex" ],
  1597. sdk_version: "current",
  1598. min_sdk_version: "S", // should be okay
  1599. }
  1600. `,
  1601. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1602. variables.Platform_version_active_codenames = []string{"S"}
  1603. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1604. }),
  1605. )
  1606. }
  1607. func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
  1608. ctx := testApex(t, `
  1609. apex {
  1610. name: "myapex",
  1611. key: "myapex.key",
  1612. native_shared_libs: ["libx"],
  1613. updatable: false,
  1614. }
  1615. apex_key {
  1616. name: "myapex.key",
  1617. public_key: "testkey.avbpubkey",
  1618. private_key: "testkey.pem",
  1619. }
  1620. cc_library {
  1621. name: "libx",
  1622. shared_libs: ["libz"],
  1623. system_shared_libs: [],
  1624. stl: "none",
  1625. apex_available: [ "myapex" ],
  1626. }
  1627. cc_library {
  1628. name: "libz",
  1629. system_shared_libs: [],
  1630. stl: "none",
  1631. stubs: {
  1632. versions: ["1", "2"],
  1633. },
  1634. }
  1635. `)
  1636. expectLink := func(from, from_variant, to, to_variant string) {
  1637. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1638. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1639. }
  1640. expectNoLink := func(from, from_variant, to, to_variant string) {
  1641. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1642. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1643. }
  1644. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1645. expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
  1646. expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
  1647. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1648. }
  1649. func TestApexMinSdkVersion_crtobjectInVendorApex(t *testing.T) {
  1650. ctx := testApex(t, `
  1651. apex {
  1652. name: "myapex",
  1653. key: "myapex.key",
  1654. native_shared_libs: ["mylib"],
  1655. updatable: false,
  1656. vendor: true,
  1657. min_sdk_version: "29",
  1658. }
  1659. apex_key {
  1660. name: "myapex.key",
  1661. public_key: "testkey.avbpubkey",
  1662. private_key: "testkey.pem",
  1663. }
  1664. cc_library {
  1665. name: "mylib",
  1666. vendor_available: true,
  1667. system_shared_libs: [],
  1668. stl: "none",
  1669. apex_available: [ "myapex" ],
  1670. min_sdk_version: "29",
  1671. }
  1672. `)
  1673. vendorVariant := "android_vendor.29_arm64_armv8-a"
  1674. // First check that the correct variant of crtbegin_so is used.
  1675. ldRule := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29").Rule("ld")
  1676. crtBegin := names(ldRule.Args["crtBegin"])
  1677. ensureListContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
  1678. // Ensure that the crtbegin_so used by the APEX is targeting 29
  1679. cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
  1680. android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
  1681. }
  1682. func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
  1683. ctx := testApex(t, `
  1684. apex {
  1685. name: "myapex",
  1686. key: "myapex.key",
  1687. native_shared_libs: ["libx"],
  1688. updatable: false,
  1689. }
  1690. apex_key {
  1691. name: "myapex.key",
  1692. public_key: "testkey.avbpubkey",
  1693. private_key: "testkey.pem",
  1694. }
  1695. cc_library {
  1696. name: "libx",
  1697. system_shared_libs: [],
  1698. stl: "none",
  1699. apex_available: [ "myapex" ],
  1700. stubs: {
  1701. versions: ["1", "2"],
  1702. },
  1703. }
  1704. cc_library {
  1705. name: "libz",
  1706. shared_libs: ["libx"],
  1707. system_shared_libs: [],
  1708. stl: "none",
  1709. }
  1710. `)
  1711. expectLink := func(from, from_variant, to, to_variant string) {
  1712. t.Helper()
  1713. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1714. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1715. }
  1716. expectNoLink := func(from, from_variant, to, to_variant string) {
  1717. t.Helper()
  1718. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1719. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1720. }
  1721. expectLink("libz", "shared", "libx", "shared_current")
  1722. expectNoLink("libz", "shared", "libx", "shared_2")
  1723. expectNoLink("libz", "shared", "libz", "shared_1")
  1724. expectNoLink("libz", "shared", "libz", "shared")
  1725. }
  1726. var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
  1727. func(variables android.FixtureProductVariables) {
  1728. variables.SanitizeDevice = []string{"hwaddress"}
  1729. },
  1730. )
  1731. func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
  1732. ctx := testApex(t, `
  1733. apex {
  1734. name: "myapex",
  1735. key: "myapex.key",
  1736. native_shared_libs: ["libx"],
  1737. min_sdk_version: "29",
  1738. }
  1739. apex_key {
  1740. name: "myapex.key",
  1741. public_key: "testkey.avbpubkey",
  1742. private_key: "testkey.pem",
  1743. }
  1744. cc_library {
  1745. name: "libx",
  1746. shared_libs: ["libbar"],
  1747. apex_available: [ "myapex" ],
  1748. min_sdk_version: "29",
  1749. }
  1750. cc_library {
  1751. name: "libbar",
  1752. stubs: {
  1753. versions: ["29", "30"],
  1754. },
  1755. }
  1756. `,
  1757. prepareForTestWithSantitizeHwaddress,
  1758. )
  1759. expectLink := func(from, from_variant, to, to_variant string) {
  1760. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1761. libFlags := ld.Args["libFlags"]
  1762. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1763. }
  1764. expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
  1765. }
  1766. func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
  1767. ctx := testApex(t, `
  1768. apex {
  1769. name: "myapex",
  1770. key: "myapex.key",
  1771. native_shared_libs: ["libx"],
  1772. min_sdk_version: "29",
  1773. }
  1774. apex_key {
  1775. name: "myapex.key",
  1776. public_key: "testkey.avbpubkey",
  1777. private_key: "testkey.pem",
  1778. }
  1779. cc_library {
  1780. name: "libx",
  1781. apex_available: [ "myapex" ],
  1782. min_sdk_version: "29",
  1783. }
  1784. `)
  1785. // ensure apex variant of c++ is linked with static unwinder
  1786. cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
  1787. ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1788. // note that platform variant is not.
  1789. cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  1790. ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1791. }
  1792. func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
  1793. testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
  1794. apex {
  1795. name: "myapex",
  1796. key: "myapex.key",
  1797. native_shared_libs: ["mylib"],
  1798. min_sdk_version: "29",
  1799. }
  1800. apex_key {
  1801. name: "myapex.key",
  1802. public_key: "testkey.avbpubkey",
  1803. private_key: "testkey.pem",
  1804. }
  1805. cc_library {
  1806. name: "mylib",
  1807. srcs: ["mylib.cpp"],
  1808. system_shared_libs: [],
  1809. stl: "none",
  1810. apex_available: [
  1811. "myapex",
  1812. ],
  1813. min_sdk_version: "30",
  1814. }
  1815. `)
  1816. testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
  1817. apex {
  1818. name: "myapex",
  1819. key: "myapex.key",
  1820. native_shared_libs: ["libfoo.ffi"],
  1821. min_sdk_version: "29",
  1822. }
  1823. apex_key {
  1824. name: "myapex.key",
  1825. public_key: "testkey.avbpubkey",
  1826. private_key: "testkey.pem",
  1827. }
  1828. rust_ffi_shared {
  1829. name: "libfoo.ffi",
  1830. srcs: ["foo.rs"],
  1831. crate_name: "foo",
  1832. apex_available: [
  1833. "myapex",
  1834. ],
  1835. min_sdk_version: "30",
  1836. }
  1837. `)
  1838. testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
  1839. apex {
  1840. name: "myapex",
  1841. key: "myapex.key",
  1842. java_libs: ["libfoo"],
  1843. min_sdk_version: "29",
  1844. }
  1845. apex_key {
  1846. name: "myapex.key",
  1847. public_key: "testkey.avbpubkey",
  1848. private_key: "testkey.pem",
  1849. }
  1850. java_import {
  1851. name: "libfoo",
  1852. jars: ["libfoo.jar"],
  1853. apex_available: [
  1854. "myapex",
  1855. ],
  1856. min_sdk_version: "30",
  1857. }
  1858. `)
  1859. }
  1860. func TestApexMinSdkVersion_Okay(t *testing.T) {
  1861. testApex(t, `
  1862. apex {
  1863. name: "myapex",
  1864. key: "myapex.key",
  1865. native_shared_libs: ["libfoo"],
  1866. java_libs: ["libbar"],
  1867. min_sdk_version: "29",
  1868. }
  1869. apex_key {
  1870. name: "myapex.key",
  1871. public_key: "testkey.avbpubkey",
  1872. private_key: "testkey.pem",
  1873. }
  1874. cc_library {
  1875. name: "libfoo",
  1876. srcs: ["mylib.cpp"],
  1877. shared_libs: ["libfoo_dep"],
  1878. apex_available: ["myapex"],
  1879. min_sdk_version: "29",
  1880. }
  1881. cc_library {
  1882. name: "libfoo_dep",
  1883. srcs: ["mylib.cpp"],
  1884. apex_available: ["myapex"],
  1885. min_sdk_version: "29",
  1886. }
  1887. java_library {
  1888. name: "libbar",
  1889. sdk_version: "current",
  1890. srcs: ["a.java"],
  1891. static_libs: [
  1892. "libbar_dep",
  1893. "libbar_import_dep",
  1894. ],
  1895. apex_available: ["myapex"],
  1896. min_sdk_version: "29",
  1897. }
  1898. java_library {
  1899. name: "libbar_dep",
  1900. sdk_version: "current",
  1901. srcs: ["a.java"],
  1902. apex_available: ["myapex"],
  1903. min_sdk_version: "29",
  1904. }
  1905. java_import {
  1906. name: "libbar_import_dep",
  1907. jars: ["libbar.jar"],
  1908. apex_available: ["myapex"],
  1909. min_sdk_version: "29",
  1910. }
  1911. `)
  1912. }
  1913. func TestJavaStableSdkVersion(t *testing.T) {
  1914. testCases := []struct {
  1915. name string
  1916. expectedError string
  1917. bp string
  1918. preparer android.FixturePreparer
  1919. }{
  1920. {
  1921. name: "Non-updatable apex with non-stable dep",
  1922. bp: `
  1923. apex {
  1924. name: "myapex",
  1925. java_libs: ["myjar"],
  1926. key: "myapex.key",
  1927. updatable: false,
  1928. }
  1929. apex_key {
  1930. name: "myapex.key",
  1931. public_key: "testkey.avbpubkey",
  1932. private_key: "testkey.pem",
  1933. }
  1934. java_library {
  1935. name: "myjar",
  1936. srcs: ["foo/bar/MyClass.java"],
  1937. sdk_version: "test_current",
  1938. apex_available: ["myapex"],
  1939. }
  1940. `,
  1941. },
  1942. {
  1943. name: "Updatable apex with stable dep",
  1944. bp: `
  1945. apex {
  1946. name: "myapex",
  1947. java_libs: ["myjar"],
  1948. key: "myapex.key",
  1949. updatable: true,
  1950. min_sdk_version: "29",
  1951. }
  1952. apex_key {
  1953. name: "myapex.key",
  1954. public_key: "testkey.avbpubkey",
  1955. private_key: "testkey.pem",
  1956. }
  1957. java_library {
  1958. name: "myjar",
  1959. srcs: ["foo/bar/MyClass.java"],
  1960. sdk_version: "current",
  1961. apex_available: ["myapex"],
  1962. min_sdk_version: "29",
  1963. }
  1964. `,
  1965. },
  1966. {
  1967. name: "Updatable apex with non-stable dep",
  1968. expectedError: "cannot depend on \"myjar\"",
  1969. bp: `
  1970. apex {
  1971. name: "myapex",
  1972. java_libs: ["myjar"],
  1973. key: "myapex.key",
  1974. updatable: true,
  1975. }
  1976. apex_key {
  1977. name: "myapex.key",
  1978. public_key: "testkey.avbpubkey",
  1979. private_key: "testkey.pem",
  1980. }
  1981. java_library {
  1982. name: "myjar",
  1983. srcs: ["foo/bar/MyClass.java"],
  1984. sdk_version: "test_current",
  1985. apex_available: ["myapex"],
  1986. }
  1987. `,
  1988. },
  1989. {
  1990. name: "Updatable apex with non-stable legacy core platform dep",
  1991. expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
  1992. bp: `
  1993. apex {
  1994. name: "myapex",
  1995. java_libs: ["myjar-uses-legacy"],
  1996. key: "myapex.key",
  1997. updatable: true,
  1998. }
  1999. apex_key {
  2000. name: "myapex.key",
  2001. public_key: "testkey.avbpubkey",
  2002. private_key: "testkey.pem",
  2003. }
  2004. java_library {
  2005. name: "myjar-uses-legacy",
  2006. srcs: ["foo/bar/MyClass.java"],
  2007. sdk_version: "core_platform",
  2008. apex_available: ["myapex"],
  2009. }
  2010. `,
  2011. preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
  2012. },
  2013. {
  2014. name: "Updatable apex with non-stable transitive dep",
  2015. // This is not actually detecting that the transitive dependency is unstable, rather it is
  2016. // detecting that the transitive dependency is building against a wider API surface than the
  2017. // module that depends on it is using.
  2018. expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
  2019. bp: `
  2020. apex {
  2021. name: "myapex",
  2022. java_libs: ["myjar"],
  2023. key: "myapex.key",
  2024. updatable: true,
  2025. }
  2026. apex_key {
  2027. name: "myapex.key",
  2028. public_key: "testkey.avbpubkey",
  2029. private_key: "testkey.pem",
  2030. }
  2031. java_library {
  2032. name: "myjar",
  2033. srcs: ["foo/bar/MyClass.java"],
  2034. sdk_version: "current",
  2035. apex_available: ["myapex"],
  2036. static_libs: ["transitive-jar"],
  2037. }
  2038. java_library {
  2039. name: "transitive-jar",
  2040. srcs: ["foo/bar/MyClass.java"],
  2041. sdk_version: "core_platform",
  2042. apex_available: ["myapex"],
  2043. }
  2044. `,
  2045. },
  2046. }
  2047. for _, test := range testCases {
  2048. if test.name != "Updatable apex with non-stable legacy core platform dep" {
  2049. continue
  2050. }
  2051. t.Run(test.name, func(t *testing.T) {
  2052. errorHandler := android.FixtureExpectsNoErrors
  2053. if test.expectedError != "" {
  2054. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  2055. }
  2056. android.GroupFixturePreparers(
  2057. java.PrepareForTestWithJavaDefaultModules,
  2058. PrepareForTestWithApexBuildComponents,
  2059. prepareForTestWithMyapex,
  2060. android.OptionalFixturePreparer(test.preparer),
  2061. ).
  2062. ExtendWithErrorHandler(errorHandler).
  2063. RunTestWithBp(t, test.bp)
  2064. })
  2065. }
  2066. }
  2067. func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
  2068. testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
  2069. apex {
  2070. name: "myapex",
  2071. key: "myapex.key",
  2072. native_shared_libs: ["mylib"],
  2073. min_sdk_version: "29",
  2074. }
  2075. apex_key {
  2076. name: "myapex.key",
  2077. public_key: "testkey.avbpubkey",
  2078. private_key: "testkey.pem",
  2079. }
  2080. cc_library {
  2081. name: "mylib",
  2082. srcs: ["mylib.cpp"],
  2083. shared_libs: ["mylib2"],
  2084. system_shared_libs: [],
  2085. stl: "none",
  2086. apex_available: [
  2087. "myapex",
  2088. ],
  2089. min_sdk_version: "29",
  2090. }
  2091. // indirect part of the apex
  2092. cc_library {
  2093. name: "mylib2",
  2094. srcs: ["mylib.cpp"],
  2095. system_shared_libs: [],
  2096. stl: "none",
  2097. apex_available: [
  2098. "myapex",
  2099. ],
  2100. min_sdk_version: "30",
  2101. }
  2102. `)
  2103. }
  2104. func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
  2105. testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
  2106. apex {
  2107. name: "myapex",
  2108. key: "myapex.key",
  2109. apps: ["AppFoo"],
  2110. min_sdk_version: "29",
  2111. }
  2112. apex_key {
  2113. name: "myapex.key",
  2114. public_key: "testkey.avbpubkey",
  2115. private_key: "testkey.pem",
  2116. }
  2117. android_app {
  2118. name: "AppFoo",
  2119. srcs: ["foo/bar/MyClass.java"],
  2120. sdk_version: "current",
  2121. min_sdk_version: "29",
  2122. system_modules: "none",
  2123. stl: "none",
  2124. static_libs: ["bar"],
  2125. apex_available: [ "myapex" ],
  2126. }
  2127. java_library {
  2128. name: "bar",
  2129. sdk_version: "current",
  2130. srcs: ["a.java"],
  2131. apex_available: [ "myapex" ],
  2132. }
  2133. `)
  2134. }
  2135. func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
  2136. ctx := testApex(t, `
  2137. apex {
  2138. name: "myapex",
  2139. key: "myapex.key",
  2140. native_shared_libs: ["mylib"],
  2141. min_sdk_version: "29",
  2142. }
  2143. apex_key {
  2144. name: "myapex.key",
  2145. public_key: "testkey.avbpubkey",
  2146. private_key: "testkey.pem",
  2147. }
  2148. // mylib in myapex will link to mylib2#current
  2149. // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
  2150. cc_library {
  2151. name: "mylib",
  2152. srcs: ["mylib.cpp"],
  2153. shared_libs: ["mylib2"],
  2154. system_shared_libs: [],
  2155. stl: "none",
  2156. apex_available: ["myapex", "otherapex"],
  2157. min_sdk_version: "29",
  2158. }
  2159. cc_library {
  2160. name: "mylib2",
  2161. srcs: ["mylib.cpp"],
  2162. system_shared_libs: [],
  2163. stl: "none",
  2164. apex_available: ["otherapex"],
  2165. stubs: { versions: ["29", "30"] },
  2166. min_sdk_version: "30",
  2167. }
  2168. apex {
  2169. name: "otherapex",
  2170. key: "myapex.key",
  2171. native_shared_libs: ["mylib", "mylib2"],
  2172. min_sdk_version: "30",
  2173. }
  2174. `)
  2175. expectLink := func(from, from_variant, to, to_variant string) {
  2176. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  2177. libFlags := ld.Args["libFlags"]
  2178. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  2179. }
  2180. expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
  2181. expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
  2182. }
  2183. func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
  2184. withSAsActiveCodeNames := android.FixtureModifyProductVariables(
  2185. func(variables android.FixtureProductVariables) {
  2186. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2187. variables.Platform_version_active_codenames = []string{"S"}
  2188. },
  2189. )
  2190. testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
  2191. apex {
  2192. name: "myapex",
  2193. key: "myapex.key",
  2194. native_shared_libs: ["libfoo"],
  2195. min_sdk_version: "S",
  2196. }
  2197. apex_key {
  2198. name: "myapex.key",
  2199. public_key: "testkey.avbpubkey",
  2200. private_key: "testkey.pem",
  2201. }
  2202. cc_library {
  2203. name: "libfoo",
  2204. shared_libs: ["libbar"],
  2205. apex_available: ["myapex"],
  2206. min_sdk_version: "29",
  2207. }
  2208. cc_library {
  2209. name: "libbar",
  2210. apex_available: ["myapex"],
  2211. }
  2212. `, withSAsActiveCodeNames)
  2213. }
  2214. func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
  2215. withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2216. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2217. variables.Platform_version_active_codenames = []string{"S", "T"}
  2218. })
  2219. ctx := testApex(t, `
  2220. apex {
  2221. name: "myapex",
  2222. key: "myapex.key",
  2223. native_shared_libs: ["libfoo"],
  2224. min_sdk_version: "S",
  2225. }
  2226. apex_key {
  2227. name: "myapex.key",
  2228. public_key: "testkey.avbpubkey",
  2229. private_key: "testkey.pem",
  2230. }
  2231. cc_library {
  2232. name: "libfoo",
  2233. shared_libs: ["libbar"],
  2234. apex_available: ["myapex"],
  2235. min_sdk_version: "S",
  2236. }
  2237. cc_library {
  2238. name: "libbar",
  2239. stubs: {
  2240. symbol_file: "libbar.map.txt",
  2241. versions: ["30", "S", "T"],
  2242. },
  2243. }
  2244. `, withSAsActiveCodeNames)
  2245. // ensure libfoo is linked with current version of libbar stub
  2246. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
  2247. libFlags := libfoo.Rule("ld").Args["libFlags"]
  2248. ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
  2249. }
  2250. func TestFilesInSubDir(t *testing.T) {
  2251. ctx := testApex(t, `
  2252. apex {
  2253. name: "myapex",
  2254. key: "myapex.key",
  2255. native_shared_libs: ["mylib"],
  2256. binaries: ["mybin"],
  2257. prebuilts: ["myetc"],
  2258. compile_multilib: "both",
  2259. updatable: false,
  2260. }
  2261. apex_key {
  2262. name: "myapex.key",
  2263. public_key: "testkey.avbpubkey",
  2264. private_key: "testkey.pem",
  2265. }
  2266. prebuilt_etc {
  2267. name: "myetc",
  2268. src: "myprebuilt",
  2269. sub_dir: "foo/bar",
  2270. }
  2271. cc_library {
  2272. name: "mylib",
  2273. srcs: ["mylib.cpp"],
  2274. relative_install_path: "foo/bar",
  2275. system_shared_libs: [],
  2276. stl: "none",
  2277. apex_available: [ "myapex" ],
  2278. }
  2279. cc_binary {
  2280. name: "mybin",
  2281. srcs: ["mylib.cpp"],
  2282. relative_install_path: "foo/bar",
  2283. system_shared_libs: [],
  2284. stl: "none",
  2285. apex_available: [ "myapex" ],
  2286. }
  2287. `)
  2288. generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
  2289. cmd := generateFsRule.RuleParams.Command
  2290. // Ensure that the subdirectories are all listed
  2291. ensureContains(t, cmd, "/etc ")
  2292. ensureContains(t, cmd, "/etc/foo ")
  2293. ensureContains(t, cmd, "/etc/foo/bar ")
  2294. ensureContains(t, cmd, "/lib64 ")
  2295. ensureContains(t, cmd, "/lib64/foo ")
  2296. ensureContains(t, cmd, "/lib64/foo/bar ")
  2297. ensureContains(t, cmd, "/lib ")
  2298. ensureContains(t, cmd, "/lib/foo ")
  2299. ensureContains(t, cmd, "/lib/foo/bar ")
  2300. ensureContains(t, cmd, "/bin ")
  2301. ensureContains(t, cmd, "/bin/foo ")
  2302. ensureContains(t, cmd, "/bin/foo/bar ")
  2303. }
  2304. func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
  2305. ctx := testApex(t, `
  2306. apex {
  2307. name: "myapex",
  2308. key: "myapex.key",
  2309. multilib: {
  2310. both: {
  2311. native_shared_libs: ["mylib"],
  2312. binaries: ["mybin"],
  2313. },
  2314. },
  2315. compile_multilib: "both",
  2316. native_bridge_supported: true,
  2317. updatable: false,
  2318. }
  2319. apex_key {
  2320. name: "myapex.key",
  2321. public_key: "testkey.avbpubkey",
  2322. private_key: "testkey.pem",
  2323. }
  2324. cc_library {
  2325. name: "mylib",
  2326. relative_install_path: "foo/bar",
  2327. system_shared_libs: [],
  2328. stl: "none",
  2329. apex_available: [ "myapex" ],
  2330. native_bridge_supported: true,
  2331. }
  2332. cc_binary {
  2333. name: "mybin",
  2334. relative_install_path: "foo/bar",
  2335. system_shared_libs: [],
  2336. stl: "none",
  2337. apex_available: [ "myapex" ],
  2338. native_bridge_supported: true,
  2339. compile_multilib: "both", // default is "first" for binary
  2340. multilib: {
  2341. lib64: {
  2342. suffix: "64",
  2343. },
  2344. },
  2345. }
  2346. `, withNativeBridgeEnabled)
  2347. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2348. "bin/foo/bar/mybin",
  2349. "bin/foo/bar/mybin64",
  2350. "bin/arm/foo/bar/mybin",
  2351. "bin/arm64/foo/bar/mybin64",
  2352. "lib/foo/bar/mylib.so",
  2353. "lib/arm/foo/bar/mylib.so",
  2354. "lib64/foo/bar/mylib.so",
  2355. "lib64/arm64/foo/bar/mylib.so",
  2356. })
  2357. }
  2358. func TestVendorApex(t *testing.T) {
  2359. result := android.GroupFixturePreparers(
  2360. prepareForApexTest,
  2361. android.FixtureModifyConfig(android.SetKatiEnabledForTests),
  2362. ).RunTestWithBp(t, `
  2363. apex {
  2364. name: "myapex",
  2365. key: "myapex.key",
  2366. binaries: ["mybin"],
  2367. vendor: true,
  2368. updatable: false,
  2369. }
  2370. apex_key {
  2371. name: "myapex.key",
  2372. public_key: "testkey.avbpubkey",
  2373. private_key: "testkey.pem",
  2374. }
  2375. cc_binary {
  2376. name: "mybin",
  2377. vendor: true,
  2378. shared_libs: ["libfoo"],
  2379. }
  2380. cc_library {
  2381. name: "libfoo",
  2382. proprietary: true,
  2383. }
  2384. `)
  2385. ensureExactContents(t, result.TestContext, "myapex", "android_common_myapex_image", []string{
  2386. "bin/mybin",
  2387. "lib64/libfoo.so",
  2388. // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
  2389. "lib64/libc++.so",
  2390. })
  2391. apexBundle := result.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2392. data := android.AndroidMkDataForTest(t, result.TestContext, apexBundle)
  2393. name := apexBundle.BaseModuleName()
  2394. prefix := "TARGET_"
  2395. var builder strings.Builder
  2396. data.Custom(&builder, name, prefix, "", data)
  2397. androidMk := android.StringRelativeToTop(result.Config, builder.String())
  2398. installPath := "out/target/product/test_device/vendor/apex"
  2399. ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
  2400. apexManifestRule := result.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2401. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2402. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2403. }
  2404. func TestVendorApex_use_vndk_as_stable(t *testing.T) {
  2405. ctx := testApex(t, `
  2406. apex {
  2407. name: "myapex",
  2408. key: "myapex.key",
  2409. binaries: ["mybin"],
  2410. vendor: true,
  2411. use_vndk_as_stable: true,
  2412. updatable: false,
  2413. }
  2414. apex_key {
  2415. name: "myapex.key",
  2416. public_key: "testkey.avbpubkey",
  2417. private_key: "testkey.pem",
  2418. }
  2419. cc_binary {
  2420. name: "mybin",
  2421. vendor: true,
  2422. shared_libs: ["libvndk", "libvendor"],
  2423. }
  2424. cc_library {
  2425. name: "libvndk",
  2426. vndk: {
  2427. enabled: true,
  2428. },
  2429. vendor_available: true,
  2430. product_available: true,
  2431. }
  2432. cc_library {
  2433. name: "libvendor",
  2434. vendor: true,
  2435. }
  2436. `)
  2437. vendorVariant := "android_vendor.29_arm64_armv8-a"
  2438. ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
  2439. libs := names(ldRule.Args["libFlags"])
  2440. // VNDK libs(libvndk/libc++) as they are
  2441. ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
  2442. ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
  2443. // non-stable Vendor libs as APEX variants
  2444. ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
  2445. // VNDK libs are not included when use_vndk_as_stable: true
  2446. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2447. "bin/mybin",
  2448. "lib64/libvendor.so",
  2449. })
  2450. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2451. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2452. ensureListContains(t, requireNativeLibs, ":vndk")
  2453. }
  2454. func TestProductVariant(t *testing.T) {
  2455. ctx := testApex(t, `
  2456. apex {
  2457. name: "myapex",
  2458. key: "myapex.key",
  2459. updatable: false,
  2460. product_specific: true,
  2461. binaries: ["foo"],
  2462. }
  2463. apex_key {
  2464. name: "myapex.key",
  2465. public_key: "testkey.avbpubkey",
  2466. private_key: "testkey.pem",
  2467. }
  2468. cc_binary {
  2469. name: "foo",
  2470. product_available: true,
  2471. apex_available: ["myapex"],
  2472. srcs: ["foo.cpp"],
  2473. }
  2474. `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2475. variables.ProductVndkVersion = proptools.StringPtr("current")
  2476. }),
  2477. )
  2478. cflags := strings.Fields(
  2479. ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
  2480. ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
  2481. ensureListContains(t, cflags, "-D__ANDROID_APEX__")
  2482. ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
  2483. ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
  2484. }
  2485. func TestApex_withPrebuiltFirmware(t *testing.T) {
  2486. testCases := []struct {
  2487. name string
  2488. additionalProp string
  2489. }{
  2490. {"system apex with prebuilt_firmware", ""},
  2491. {"vendor apex with prebuilt_firmware", "vendor: true,"},
  2492. }
  2493. for _, tc := range testCases {
  2494. t.Run(tc.name, func(t *testing.T) {
  2495. ctx := testApex(t, `
  2496. apex {
  2497. name: "myapex",
  2498. key: "myapex.key",
  2499. prebuilts: ["myfirmware"],
  2500. updatable: false,
  2501. `+tc.additionalProp+`
  2502. }
  2503. apex_key {
  2504. name: "myapex.key",
  2505. public_key: "testkey.avbpubkey",
  2506. private_key: "testkey.pem",
  2507. }
  2508. prebuilt_firmware {
  2509. name: "myfirmware",
  2510. src: "myfirmware.bin",
  2511. filename_from_src: true,
  2512. `+tc.additionalProp+`
  2513. }
  2514. `)
  2515. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2516. "etc/firmware/myfirmware.bin",
  2517. })
  2518. })
  2519. }
  2520. }
  2521. func TestAndroidMk_VendorApexRequired(t *testing.T) {
  2522. ctx := testApex(t, `
  2523. apex {
  2524. name: "myapex",
  2525. key: "myapex.key",
  2526. vendor: true,
  2527. native_shared_libs: ["mylib"],
  2528. updatable: false,
  2529. }
  2530. apex_key {
  2531. name: "myapex.key",
  2532. public_key: "testkey.avbpubkey",
  2533. private_key: "testkey.pem",
  2534. }
  2535. cc_library {
  2536. name: "mylib",
  2537. vendor_available: true,
  2538. }
  2539. `)
  2540. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2541. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2542. name := apexBundle.BaseModuleName()
  2543. prefix := "TARGET_"
  2544. var builder strings.Builder
  2545. data.Custom(&builder, name, prefix, "", data)
  2546. androidMk := builder.String()
  2547. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
  2548. }
  2549. func TestAndroidMkWritesCommonProperties(t *testing.T) {
  2550. ctx := testApex(t, `
  2551. apex {
  2552. name: "myapex",
  2553. key: "myapex.key",
  2554. vintf_fragments: ["fragment.xml"],
  2555. init_rc: ["init.rc"],
  2556. updatable: false,
  2557. }
  2558. apex_key {
  2559. name: "myapex.key",
  2560. public_key: "testkey.avbpubkey",
  2561. private_key: "testkey.pem",
  2562. }
  2563. cc_binary {
  2564. name: "mybin",
  2565. }
  2566. `)
  2567. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2568. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2569. name := apexBundle.BaseModuleName()
  2570. prefix := "TARGET_"
  2571. var builder strings.Builder
  2572. data.Custom(&builder, name, prefix, "", data)
  2573. androidMk := builder.String()
  2574. ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
  2575. ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
  2576. }
  2577. func TestStaticLinking(t *testing.T) {
  2578. ctx := testApex(t, `
  2579. apex {
  2580. name: "myapex",
  2581. key: "myapex.key",
  2582. native_shared_libs: ["mylib"],
  2583. updatable: false,
  2584. }
  2585. apex_key {
  2586. name: "myapex.key",
  2587. public_key: "testkey.avbpubkey",
  2588. private_key: "testkey.pem",
  2589. }
  2590. cc_library {
  2591. name: "mylib",
  2592. srcs: ["mylib.cpp"],
  2593. system_shared_libs: [],
  2594. stl: "none",
  2595. stubs: {
  2596. versions: ["1", "2", "3"],
  2597. },
  2598. apex_available: [
  2599. "//apex_available:platform",
  2600. "myapex",
  2601. ],
  2602. }
  2603. cc_binary {
  2604. name: "not_in_apex",
  2605. srcs: ["mylib.cpp"],
  2606. static_libs: ["mylib"],
  2607. static_executable: true,
  2608. system_shared_libs: [],
  2609. stl: "none",
  2610. }
  2611. `)
  2612. ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  2613. // Ensure that not_in_apex is linking with the static variant of mylib
  2614. ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
  2615. }
  2616. func TestKeys(t *testing.T) {
  2617. ctx := testApex(t, `
  2618. apex {
  2619. name: "myapex_keytest",
  2620. key: "myapex.key",
  2621. certificate: ":myapex.certificate",
  2622. native_shared_libs: ["mylib"],
  2623. file_contexts: ":myapex-file_contexts",
  2624. updatable: false,
  2625. }
  2626. cc_library {
  2627. name: "mylib",
  2628. srcs: ["mylib.cpp"],
  2629. system_shared_libs: [],
  2630. stl: "none",
  2631. apex_available: [ "myapex_keytest" ],
  2632. }
  2633. apex_key {
  2634. name: "myapex.key",
  2635. public_key: "testkey.avbpubkey",
  2636. private_key: "testkey.pem",
  2637. }
  2638. android_app_certificate {
  2639. name: "myapex.certificate",
  2640. certificate: "testkey",
  2641. }
  2642. android_app_certificate {
  2643. name: "myapex.certificate.override",
  2644. certificate: "testkey.override",
  2645. }
  2646. `)
  2647. // check the APEX keys
  2648. keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  2649. if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
  2650. t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
  2651. "vendor/foo/devkeys/testkey.avbpubkey")
  2652. }
  2653. if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
  2654. t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
  2655. "vendor/foo/devkeys/testkey.pem")
  2656. }
  2657. // check the APK certs. It should be overridden to myapex.certificate.override
  2658. certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
  2659. if certs != "testkey.override.x509.pem testkey.override.pk8" {
  2660. t.Errorf("cert and private key %q are not %q", certs,
  2661. "testkey.override.509.pem testkey.override.pk8")
  2662. }
  2663. }
  2664. func TestCertificate(t *testing.T) {
  2665. t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
  2666. ctx := testApex(t, `
  2667. apex {
  2668. name: "myapex",
  2669. key: "myapex.key",
  2670. updatable: false,
  2671. }
  2672. apex_key {
  2673. name: "myapex.key",
  2674. public_key: "testkey.avbpubkey",
  2675. private_key: "testkey.pem",
  2676. }`)
  2677. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2678. expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
  2679. if actual := rule.Args["certificates"]; actual != expected {
  2680. t.Errorf("certificates should be %q, not %q", expected, actual)
  2681. }
  2682. })
  2683. t.Run("override when unspecified", func(t *testing.T) {
  2684. ctx := testApex(t, `
  2685. apex {
  2686. name: "myapex_keytest",
  2687. key: "myapex.key",
  2688. file_contexts: ":myapex-file_contexts",
  2689. updatable: false,
  2690. }
  2691. apex_key {
  2692. name: "myapex.key",
  2693. public_key: "testkey.avbpubkey",
  2694. private_key: "testkey.pem",
  2695. }
  2696. android_app_certificate {
  2697. name: "myapex.certificate.override",
  2698. certificate: "testkey.override",
  2699. }`)
  2700. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2701. expected := "testkey.override.x509.pem testkey.override.pk8"
  2702. if actual := rule.Args["certificates"]; actual != expected {
  2703. t.Errorf("certificates should be %q, not %q", expected, actual)
  2704. }
  2705. })
  2706. t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
  2707. ctx := testApex(t, `
  2708. apex {
  2709. name: "myapex",
  2710. key: "myapex.key",
  2711. certificate: ":myapex.certificate",
  2712. updatable: false,
  2713. }
  2714. apex_key {
  2715. name: "myapex.key",
  2716. public_key: "testkey.avbpubkey",
  2717. private_key: "testkey.pem",
  2718. }
  2719. android_app_certificate {
  2720. name: "myapex.certificate",
  2721. certificate: "testkey",
  2722. }`)
  2723. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2724. expected := "testkey.x509.pem testkey.pk8"
  2725. if actual := rule.Args["certificates"]; actual != expected {
  2726. t.Errorf("certificates should be %q, not %q", expected, actual)
  2727. }
  2728. })
  2729. t.Run("override when specifiec as <:module>", func(t *testing.T) {
  2730. ctx := testApex(t, `
  2731. apex {
  2732. name: "myapex_keytest",
  2733. key: "myapex.key",
  2734. file_contexts: ":myapex-file_contexts",
  2735. certificate: ":myapex.certificate",
  2736. updatable: false,
  2737. }
  2738. apex_key {
  2739. name: "myapex.key",
  2740. public_key: "testkey.avbpubkey",
  2741. private_key: "testkey.pem",
  2742. }
  2743. android_app_certificate {
  2744. name: "myapex.certificate.override",
  2745. certificate: "testkey.override",
  2746. }`)
  2747. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2748. expected := "testkey.override.x509.pem testkey.override.pk8"
  2749. if actual := rule.Args["certificates"]; actual != expected {
  2750. t.Errorf("certificates should be %q, not %q", expected, actual)
  2751. }
  2752. })
  2753. t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
  2754. ctx := testApex(t, `
  2755. apex {
  2756. name: "myapex",
  2757. key: "myapex.key",
  2758. certificate: "testkey",
  2759. updatable: false,
  2760. }
  2761. apex_key {
  2762. name: "myapex.key",
  2763. public_key: "testkey.avbpubkey",
  2764. private_key: "testkey.pem",
  2765. }`)
  2766. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2767. expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
  2768. if actual := rule.Args["certificates"]; actual != expected {
  2769. t.Errorf("certificates should be %q, not %q", expected, actual)
  2770. }
  2771. })
  2772. t.Run("override when specified as <name>", func(t *testing.T) {
  2773. ctx := testApex(t, `
  2774. apex {
  2775. name: "myapex_keytest",
  2776. key: "myapex.key",
  2777. file_contexts: ":myapex-file_contexts",
  2778. certificate: "testkey",
  2779. updatable: false,
  2780. }
  2781. apex_key {
  2782. name: "myapex.key",
  2783. public_key: "testkey.avbpubkey",
  2784. private_key: "testkey.pem",
  2785. }
  2786. android_app_certificate {
  2787. name: "myapex.certificate.override",
  2788. certificate: "testkey.override",
  2789. }`)
  2790. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2791. expected := "testkey.override.x509.pem testkey.override.pk8"
  2792. if actual := rule.Args["certificates"]; actual != expected {
  2793. t.Errorf("certificates should be %q, not %q", expected, actual)
  2794. }
  2795. })
  2796. }
  2797. func TestMacro(t *testing.T) {
  2798. ctx := testApex(t, `
  2799. apex {
  2800. name: "myapex",
  2801. key: "myapex.key",
  2802. native_shared_libs: ["mylib", "mylib2"],
  2803. updatable: false,
  2804. }
  2805. apex {
  2806. name: "otherapex",
  2807. key: "myapex.key",
  2808. native_shared_libs: ["mylib", "mylib2"],
  2809. min_sdk_version: "29",
  2810. }
  2811. apex_key {
  2812. name: "myapex.key",
  2813. public_key: "testkey.avbpubkey",
  2814. private_key: "testkey.pem",
  2815. }
  2816. cc_library {
  2817. name: "mylib",
  2818. srcs: ["mylib.cpp"],
  2819. system_shared_libs: [],
  2820. stl: "none",
  2821. apex_available: [
  2822. "myapex",
  2823. "otherapex",
  2824. ],
  2825. recovery_available: true,
  2826. min_sdk_version: "29",
  2827. }
  2828. cc_library {
  2829. name: "mylib2",
  2830. srcs: ["mylib.cpp"],
  2831. system_shared_libs: [],
  2832. stl: "none",
  2833. apex_available: [
  2834. "myapex",
  2835. "otherapex",
  2836. ],
  2837. static_libs: ["mylib3"],
  2838. recovery_available: true,
  2839. min_sdk_version: "29",
  2840. }
  2841. cc_library {
  2842. name: "mylib3",
  2843. srcs: ["mylib.cpp"],
  2844. system_shared_libs: [],
  2845. stl: "none",
  2846. apex_available: [
  2847. "myapex",
  2848. "otherapex",
  2849. ],
  2850. recovery_available: true,
  2851. min_sdk_version: "29",
  2852. }
  2853. `)
  2854. // non-APEX variant does not have __ANDROID_APEX__ defined
  2855. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2856. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2857. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2858. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2859. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  2860. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2861. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
  2862. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2863. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
  2864. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2865. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
  2866. // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
  2867. // each variant defines additional macros to distinguish which apex variant it is built for
  2868. // non-APEX variant does not have __ANDROID_APEX__ defined
  2869. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2870. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2871. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2872. mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2873. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2874. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2875. // non-APEX variant does not have __ANDROID_APEX__ defined
  2876. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2877. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2878. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2879. mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2880. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2881. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2882. }
  2883. func TestHeaderLibsDependency(t *testing.T) {
  2884. ctx := testApex(t, `
  2885. apex {
  2886. name: "myapex",
  2887. key: "myapex.key",
  2888. native_shared_libs: ["mylib"],
  2889. updatable: false,
  2890. }
  2891. apex_key {
  2892. name: "myapex.key",
  2893. public_key: "testkey.avbpubkey",
  2894. private_key: "testkey.pem",
  2895. }
  2896. cc_library_headers {
  2897. name: "mylib_headers",
  2898. export_include_dirs: ["my_include"],
  2899. system_shared_libs: [],
  2900. stl: "none",
  2901. apex_available: [ "myapex" ],
  2902. }
  2903. cc_library {
  2904. name: "mylib",
  2905. srcs: ["mylib.cpp"],
  2906. system_shared_libs: [],
  2907. stl: "none",
  2908. header_libs: ["mylib_headers"],
  2909. export_header_lib_headers: ["mylib_headers"],
  2910. stubs: {
  2911. versions: ["1", "2", "3"],
  2912. },
  2913. apex_available: [ "myapex" ],
  2914. }
  2915. cc_library {
  2916. name: "otherlib",
  2917. srcs: ["mylib.cpp"],
  2918. system_shared_libs: [],
  2919. stl: "none",
  2920. shared_libs: ["mylib"],
  2921. }
  2922. `)
  2923. cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2924. // Ensure that the include path of the header lib is exported to 'otherlib'
  2925. ensureContains(t, cFlags, "-Imy_include")
  2926. }
  2927. type fileInApex struct {
  2928. path string // path in apex
  2929. src string // src path
  2930. isLink bool
  2931. }
  2932. func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
  2933. t.Helper()
  2934. apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
  2935. copyCmds := apexRule.Args["copy_commands"]
  2936. imageApexDir := "/image.apex/"
  2937. var ret []fileInApex
  2938. for _, cmd := range strings.Split(copyCmds, "&&") {
  2939. cmd = strings.TrimSpace(cmd)
  2940. if cmd == "" {
  2941. continue
  2942. }
  2943. terms := strings.Split(cmd, " ")
  2944. var dst, src string
  2945. var isLink bool
  2946. switch terms[0] {
  2947. case "mkdir":
  2948. case "cp":
  2949. if len(terms) != 3 && len(terms) != 4 {
  2950. t.Fatal("copyCmds contains invalid cp command", cmd)
  2951. }
  2952. dst = terms[len(terms)-1]
  2953. src = terms[len(terms)-2]
  2954. isLink = false
  2955. case "ln":
  2956. if len(terms) != 3 && len(terms) != 4 {
  2957. // ln LINK TARGET or ln -s LINK TARGET
  2958. t.Fatal("copyCmds contains invalid ln command", cmd)
  2959. }
  2960. dst = terms[len(terms)-1]
  2961. src = terms[len(terms)-2]
  2962. isLink = true
  2963. default:
  2964. t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
  2965. }
  2966. if dst != "" {
  2967. index := strings.Index(dst, imageApexDir)
  2968. if index == -1 {
  2969. t.Fatal("copyCmds should copy a file to image.apex/", cmd)
  2970. }
  2971. dstFile := dst[index+len(imageApexDir):]
  2972. ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
  2973. }
  2974. }
  2975. return ret
  2976. }
  2977. func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
  2978. t.Helper()
  2979. var failed bool
  2980. var surplus []string
  2981. filesMatched := make(map[string]bool)
  2982. for _, file := range getFiles(t, ctx, moduleName, variant) {
  2983. mactchFound := false
  2984. for _, expected := range files {
  2985. if matched, _ := path.Match(expected, file.path); matched {
  2986. filesMatched[expected] = true
  2987. mactchFound = true
  2988. break
  2989. }
  2990. }
  2991. if !mactchFound {
  2992. surplus = append(surplus, file.path)
  2993. }
  2994. }
  2995. if len(surplus) > 0 {
  2996. sort.Strings(surplus)
  2997. t.Log("surplus files", surplus)
  2998. failed = true
  2999. }
  3000. if len(files) > len(filesMatched) {
  3001. var missing []string
  3002. for _, expected := range files {
  3003. if !filesMatched[expected] {
  3004. missing = append(missing, expected)
  3005. }
  3006. }
  3007. sort.Strings(missing)
  3008. t.Log("missing files", missing)
  3009. failed = true
  3010. }
  3011. if failed {
  3012. t.Fail()
  3013. }
  3014. }
  3015. func TestVndkApexCurrent(t *testing.T) {
  3016. commonFiles := []string{
  3017. "lib/libc++.so",
  3018. "lib64/libc++.so",
  3019. "etc/llndk.libraries.29.txt",
  3020. "etc/vndkcore.libraries.29.txt",
  3021. "etc/vndksp.libraries.29.txt",
  3022. "etc/vndkprivate.libraries.29.txt",
  3023. "etc/vndkproduct.libraries.29.txt",
  3024. }
  3025. testCases := []struct {
  3026. vndkVersion string
  3027. expectedFiles []string
  3028. }{
  3029. {
  3030. vndkVersion: "current",
  3031. expectedFiles: append(commonFiles,
  3032. "lib/libvndk.so",
  3033. "lib/libvndksp.so",
  3034. "lib64/libvndk.so",
  3035. "lib64/libvndksp.so"),
  3036. },
  3037. {
  3038. vndkVersion: "",
  3039. expectedFiles: append(commonFiles,
  3040. // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
  3041. "lib/libvndksp.so",
  3042. "lib64/libvndksp.so"),
  3043. },
  3044. }
  3045. for _, tc := range testCases {
  3046. t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
  3047. ctx := testApex(t, `
  3048. apex_vndk {
  3049. name: "com.android.vndk.current",
  3050. key: "com.android.vndk.current.key",
  3051. updatable: false,
  3052. }
  3053. apex_key {
  3054. name: "com.android.vndk.current.key",
  3055. public_key: "testkey.avbpubkey",
  3056. private_key: "testkey.pem",
  3057. }
  3058. cc_library {
  3059. name: "libvndk",
  3060. srcs: ["mylib.cpp"],
  3061. vendor_available: true,
  3062. product_available: true,
  3063. vndk: {
  3064. enabled: true,
  3065. },
  3066. system_shared_libs: [],
  3067. stl: "none",
  3068. apex_available: [ "com.android.vndk.current" ],
  3069. }
  3070. cc_library {
  3071. name: "libvndksp",
  3072. srcs: ["mylib.cpp"],
  3073. vendor_available: true,
  3074. product_available: true,
  3075. vndk: {
  3076. enabled: true,
  3077. support_system_process: true,
  3078. },
  3079. system_shared_libs: [],
  3080. stl: "none",
  3081. apex_available: [ "com.android.vndk.current" ],
  3082. }
  3083. // VNDK-Ext should not cause any problems
  3084. cc_library {
  3085. name: "libvndk.ext",
  3086. srcs: ["mylib2.cpp"],
  3087. vendor: true,
  3088. vndk: {
  3089. enabled: true,
  3090. extends: "libvndk",
  3091. },
  3092. system_shared_libs: [],
  3093. stl: "none",
  3094. }
  3095. cc_library {
  3096. name: "libvndksp.ext",
  3097. srcs: ["mylib2.cpp"],
  3098. vendor: true,
  3099. vndk: {
  3100. enabled: true,
  3101. support_system_process: true,
  3102. extends: "libvndksp",
  3103. },
  3104. system_shared_libs: [],
  3105. stl: "none",
  3106. }
  3107. `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3108. variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
  3109. }))
  3110. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
  3111. })
  3112. }
  3113. }
  3114. func TestVndkApexWithPrebuilt(t *testing.T) {
  3115. ctx := testApex(t, `
  3116. apex_vndk {
  3117. name: "com.android.vndk.current",
  3118. key: "com.android.vndk.current.key",
  3119. updatable: false,
  3120. }
  3121. apex_key {
  3122. name: "com.android.vndk.current.key",
  3123. public_key: "testkey.avbpubkey",
  3124. private_key: "testkey.pem",
  3125. }
  3126. cc_prebuilt_library_shared {
  3127. name: "libvndk",
  3128. srcs: ["libvndk.so"],
  3129. vendor_available: true,
  3130. product_available: true,
  3131. vndk: {
  3132. enabled: true,
  3133. },
  3134. system_shared_libs: [],
  3135. stl: "none",
  3136. apex_available: [ "com.android.vndk.current" ],
  3137. }
  3138. cc_prebuilt_library_shared {
  3139. name: "libvndk.arm",
  3140. srcs: ["libvndk.arm.so"],
  3141. vendor_available: true,
  3142. product_available: true,
  3143. vndk: {
  3144. enabled: true,
  3145. },
  3146. enabled: false,
  3147. arch: {
  3148. arm: {
  3149. enabled: true,
  3150. },
  3151. },
  3152. system_shared_libs: [],
  3153. stl: "none",
  3154. apex_available: [ "com.android.vndk.current" ],
  3155. }
  3156. `+vndkLibrariesTxtFiles("current"),
  3157. withFiles(map[string][]byte{
  3158. "libvndk.so": nil,
  3159. "libvndk.arm.so": nil,
  3160. }))
  3161. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3162. "lib/libvndk.so",
  3163. "lib/libvndk.arm.so",
  3164. "lib64/libvndk.so",
  3165. "lib/libc++.so",
  3166. "lib64/libc++.so",
  3167. "etc/*",
  3168. })
  3169. }
  3170. func vndkLibrariesTxtFiles(vers ...string) (result string) {
  3171. for _, v := range vers {
  3172. if v == "current" {
  3173. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3174. result += `
  3175. ` + txt + `_libraries_txt {
  3176. name: "` + txt + `.libraries.txt",
  3177. }
  3178. `
  3179. }
  3180. } else {
  3181. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3182. result += `
  3183. prebuilt_etc {
  3184. name: "` + txt + `.libraries.` + v + `.txt",
  3185. src: "dummy.txt",
  3186. }
  3187. `
  3188. }
  3189. }
  3190. }
  3191. return
  3192. }
  3193. func TestVndkApexVersion(t *testing.T) {
  3194. ctx := testApex(t, `
  3195. apex_vndk {
  3196. name: "com.android.vndk.v27",
  3197. key: "myapex.key",
  3198. file_contexts: ":myapex-file_contexts",
  3199. vndk_version: "27",
  3200. updatable: false,
  3201. }
  3202. apex_key {
  3203. name: "myapex.key",
  3204. public_key: "testkey.avbpubkey",
  3205. private_key: "testkey.pem",
  3206. }
  3207. vndk_prebuilt_shared {
  3208. name: "libvndk27",
  3209. version: "27",
  3210. vendor_available: true,
  3211. product_available: true,
  3212. vndk: {
  3213. enabled: true,
  3214. },
  3215. target_arch: "arm64",
  3216. arch: {
  3217. arm: {
  3218. srcs: ["libvndk27_arm.so"],
  3219. },
  3220. arm64: {
  3221. srcs: ["libvndk27_arm64.so"],
  3222. },
  3223. },
  3224. apex_available: [ "com.android.vndk.v27" ],
  3225. }
  3226. vndk_prebuilt_shared {
  3227. name: "libvndk27",
  3228. version: "27",
  3229. vendor_available: true,
  3230. product_available: true,
  3231. vndk: {
  3232. enabled: true,
  3233. },
  3234. target_arch: "x86_64",
  3235. arch: {
  3236. x86: {
  3237. srcs: ["libvndk27_x86.so"],
  3238. },
  3239. x86_64: {
  3240. srcs: ["libvndk27_x86_64.so"],
  3241. },
  3242. },
  3243. }
  3244. `+vndkLibrariesTxtFiles("27"),
  3245. withFiles(map[string][]byte{
  3246. "libvndk27_arm.so": nil,
  3247. "libvndk27_arm64.so": nil,
  3248. "libvndk27_x86.so": nil,
  3249. "libvndk27_x86_64.so": nil,
  3250. }))
  3251. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3252. "lib/libvndk27_arm.so",
  3253. "lib64/libvndk27_arm64.so",
  3254. "etc/*",
  3255. })
  3256. }
  3257. func TestVndkApexNameRule(t *testing.T) {
  3258. ctx := testApex(t, `
  3259. apex_vndk {
  3260. name: "com.android.vndk.current",
  3261. key: "myapex.key",
  3262. file_contexts: ":myapex-file_contexts",
  3263. updatable: false,
  3264. }
  3265. apex_vndk {
  3266. name: "com.android.vndk.v28",
  3267. key: "myapex.key",
  3268. file_contexts: ":myapex-file_contexts",
  3269. vndk_version: "28",
  3270. updatable: false,
  3271. }
  3272. apex_key {
  3273. name: "myapex.key",
  3274. public_key: "testkey.avbpubkey",
  3275. private_key: "testkey.pem",
  3276. }`+vndkLibrariesTxtFiles("28", "current"))
  3277. assertApexName := func(expected, moduleName string) {
  3278. bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
  3279. actual := proptools.String(bundle.properties.Apex_name)
  3280. if !reflect.DeepEqual(actual, expected) {
  3281. t.Errorf("Got '%v', expected '%v'", actual, expected)
  3282. }
  3283. }
  3284. assertApexName("com.android.vndk.v29", "com.android.vndk.current")
  3285. assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
  3286. }
  3287. func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
  3288. ctx := testApex(t, `
  3289. apex_vndk {
  3290. name: "com.android.vndk.current",
  3291. key: "com.android.vndk.current.key",
  3292. file_contexts: ":myapex-file_contexts",
  3293. updatable: false,
  3294. }
  3295. apex_key {
  3296. name: "com.android.vndk.current.key",
  3297. public_key: "testkey.avbpubkey",
  3298. private_key: "testkey.pem",
  3299. }
  3300. cc_library {
  3301. name: "libvndk",
  3302. srcs: ["mylib.cpp"],
  3303. vendor_available: true,
  3304. product_available: true,
  3305. native_bridge_supported: true,
  3306. host_supported: true,
  3307. vndk: {
  3308. enabled: true,
  3309. },
  3310. system_shared_libs: [],
  3311. stl: "none",
  3312. apex_available: [ "com.android.vndk.current" ],
  3313. }
  3314. `+vndkLibrariesTxtFiles("current"),
  3315. withNativeBridgeEnabled)
  3316. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3317. "lib/libvndk.so",
  3318. "lib64/libvndk.so",
  3319. "lib/libc++.so",
  3320. "lib64/libc++.so",
  3321. "etc/*",
  3322. })
  3323. }
  3324. func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
  3325. testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
  3326. apex_vndk {
  3327. name: "com.android.vndk.current",
  3328. key: "com.android.vndk.current.key",
  3329. file_contexts: ":myapex-file_contexts",
  3330. native_bridge_supported: true,
  3331. }
  3332. apex_key {
  3333. name: "com.android.vndk.current.key",
  3334. public_key: "testkey.avbpubkey",
  3335. private_key: "testkey.pem",
  3336. }
  3337. cc_library {
  3338. name: "libvndk",
  3339. srcs: ["mylib.cpp"],
  3340. vendor_available: true,
  3341. product_available: true,
  3342. native_bridge_supported: true,
  3343. host_supported: true,
  3344. vndk: {
  3345. enabled: true,
  3346. },
  3347. system_shared_libs: [],
  3348. stl: "none",
  3349. }
  3350. `)
  3351. }
  3352. func TestVndkApexWithBinder32(t *testing.T) {
  3353. ctx := testApex(t, `
  3354. apex_vndk {
  3355. name: "com.android.vndk.v27",
  3356. key: "myapex.key",
  3357. file_contexts: ":myapex-file_contexts",
  3358. vndk_version: "27",
  3359. updatable: false,
  3360. }
  3361. apex_key {
  3362. name: "myapex.key",
  3363. public_key: "testkey.avbpubkey",
  3364. private_key: "testkey.pem",
  3365. }
  3366. vndk_prebuilt_shared {
  3367. name: "libvndk27",
  3368. version: "27",
  3369. target_arch: "arm",
  3370. vendor_available: true,
  3371. product_available: true,
  3372. vndk: {
  3373. enabled: true,
  3374. },
  3375. arch: {
  3376. arm: {
  3377. srcs: ["libvndk27.so"],
  3378. }
  3379. },
  3380. }
  3381. vndk_prebuilt_shared {
  3382. name: "libvndk27",
  3383. version: "27",
  3384. target_arch: "arm",
  3385. binder32bit: true,
  3386. vendor_available: true,
  3387. product_available: true,
  3388. vndk: {
  3389. enabled: true,
  3390. },
  3391. arch: {
  3392. arm: {
  3393. srcs: ["libvndk27binder32.so"],
  3394. }
  3395. },
  3396. apex_available: [ "com.android.vndk.v27" ],
  3397. }
  3398. `+vndkLibrariesTxtFiles("27"),
  3399. withFiles(map[string][]byte{
  3400. "libvndk27.so": nil,
  3401. "libvndk27binder32.so": nil,
  3402. }),
  3403. withBinder32bit,
  3404. withTargets(map[android.OsType][]android.Target{
  3405. android.Android: []android.Target{
  3406. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  3407. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  3408. },
  3409. }),
  3410. )
  3411. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3412. "lib/libvndk27binder32.so",
  3413. "etc/*",
  3414. })
  3415. }
  3416. func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
  3417. ctx := testApex(t, `
  3418. apex_vndk {
  3419. name: "com.android.vndk.current",
  3420. key: "com.android.vndk.current.key",
  3421. file_contexts: ":myapex-file_contexts",
  3422. updatable: false,
  3423. }
  3424. apex_key {
  3425. name: "com.android.vndk.current.key",
  3426. public_key: "testkey.avbpubkey",
  3427. private_key: "testkey.pem",
  3428. }
  3429. cc_library {
  3430. name: "libz",
  3431. vendor_available: true,
  3432. product_available: true,
  3433. vndk: {
  3434. enabled: true,
  3435. },
  3436. stubs: {
  3437. symbol_file: "libz.map.txt",
  3438. versions: ["30"],
  3439. }
  3440. }
  3441. `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
  3442. "libz.map.txt": nil,
  3443. }))
  3444. apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
  3445. provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
  3446. ensureListEmpty(t, provideNativeLibs)
  3447. }
  3448. func TestDependenciesInApexManifest(t *testing.T) {
  3449. ctx := testApex(t, `
  3450. apex {
  3451. name: "myapex_nodep",
  3452. key: "myapex.key",
  3453. native_shared_libs: ["lib_nodep"],
  3454. compile_multilib: "both",
  3455. file_contexts: ":myapex-file_contexts",
  3456. updatable: false,
  3457. }
  3458. apex {
  3459. name: "myapex_dep",
  3460. key: "myapex.key",
  3461. native_shared_libs: ["lib_dep"],
  3462. compile_multilib: "both",
  3463. file_contexts: ":myapex-file_contexts",
  3464. updatable: false,
  3465. }
  3466. apex {
  3467. name: "myapex_provider",
  3468. key: "myapex.key",
  3469. native_shared_libs: ["libfoo"],
  3470. compile_multilib: "both",
  3471. file_contexts: ":myapex-file_contexts",
  3472. updatable: false,
  3473. }
  3474. apex {
  3475. name: "myapex_selfcontained",
  3476. key: "myapex.key",
  3477. native_shared_libs: ["lib_dep", "libfoo"],
  3478. compile_multilib: "both",
  3479. file_contexts: ":myapex-file_contexts",
  3480. updatable: false,
  3481. }
  3482. apex_key {
  3483. name: "myapex.key",
  3484. public_key: "testkey.avbpubkey",
  3485. private_key: "testkey.pem",
  3486. }
  3487. cc_library {
  3488. name: "lib_nodep",
  3489. srcs: ["mylib.cpp"],
  3490. system_shared_libs: [],
  3491. stl: "none",
  3492. apex_available: [ "myapex_nodep" ],
  3493. }
  3494. cc_library {
  3495. name: "lib_dep",
  3496. srcs: ["mylib.cpp"],
  3497. shared_libs: ["libfoo"],
  3498. system_shared_libs: [],
  3499. stl: "none",
  3500. apex_available: [
  3501. "myapex_dep",
  3502. "myapex_provider",
  3503. "myapex_selfcontained",
  3504. ],
  3505. }
  3506. cc_library {
  3507. name: "libfoo",
  3508. srcs: ["mytest.cpp"],
  3509. stubs: {
  3510. versions: ["1"],
  3511. },
  3512. system_shared_libs: [],
  3513. stl: "none",
  3514. apex_available: [
  3515. "myapex_provider",
  3516. "myapex_selfcontained",
  3517. ],
  3518. }
  3519. `)
  3520. var apexManifestRule android.TestingBuildParams
  3521. var provideNativeLibs, requireNativeLibs []string
  3522. apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
  3523. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3524. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3525. ensureListEmpty(t, provideNativeLibs)
  3526. ensureListEmpty(t, requireNativeLibs)
  3527. apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
  3528. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3529. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3530. ensureListEmpty(t, provideNativeLibs)
  3531. ensureListContains(t, requireNativeLibs, "libfoo.so")
  3532. apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
  3533. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3534. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3535. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3536. ensureListEmpty(t, requireNativeLibs)
  3537. apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
  3538. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3539. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3540. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3541. ensureListEmpty(t, requireNativeLibs)
  3542. }
  3543. func TestApexName(t *testing.T) {
  3544. ctx := testApex(t, `
  3545. apex {
  3546. name: "myapex",
  3547. key: "myapex.key",
  3548. apex_name: "com.android.myapex",
  3549. native_shared_libs: ["mylib"],
  3550. updatable: false,
  3551. }
  3552. apex_key {
  3553. name: "myapex.key",
  3554. public_key: "testkey.avbpubkey",
  3555. private_key: "testkey.pem",
  3556. }
  3557. cc_library {
  3558. name: "mylib",
  3559. srcs: ["mylib.cpp"],
  3560. system_shared_libs: [],
  3561. stl: "none",
  3562. apex_available: [
  3563. "//apex_available:platform",
  3564. "myapex",
  3565. ],
  3566. }
  3567. `)
  3568. module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image")
  3569. apexManifestRule := module.Rule("apexManifestRule")
  3570. ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
  3571. apexRule := module.Rule("apexRule")
  3572. ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
  3573. apexBundle := module.Module().(*apexBundle)
  3574. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  3575. name := apexBundle.BaseModuleName()
  3576. prefix := "TARGET_"
  3577. var builder strings.Builder
  3578. data.Custom(&builder, name, prefix, "", data)
  3579. androidMk := builder.String()
  3580. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  3581. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  3582. }
  3583. func TestNonTestApex(t *testing.T) {
  3584. ctx := testApex(t, `
  3585. apex {
  3586. name: "myapex",
  3587. key: "myapex.key",
  3588. native_shared_libs: ["mylib_common"],
  3589. updatable: false,
  3590. }
  3591. apex_key {
  3592. name: "myapex.key",
  3593. public_key: "testkey.avbpubkey",
  3594. private_key: "testkey.pem",
  3595. }
  3596. cc_library {
  3597. name: "mylib_common",
  3598. srcs: ["mylib.cpp"],
  3599. system_shared_libs: [],
  3600. stl: "none",
  3601. apex_available: [
  3602. "//apex_available:platform",
  3603. "myapex",
  3604. ],
  3605. }
  3606. `)
  3607. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3608. apexRule := module.Rule("apexRule")
  3609. copyCmds := apexRule.Args["copy_commands"]
  3610. if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
  3611. t.Log("Apex was a test apex!")
  3612. t.Fail()
  3613. }
  3614. // Ensure that main rule creates an output
  3615. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3616. // Ensure that apex variant is created for the direct dep
  3617. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3618. // Ensure that both direct and indirect deps are copied into apex
  3619. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3620. // Ensure that the platform variant ends with _shared
  3621. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3622. if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
  3623. t.Log("Found mylib_common not in any apex!")
  3624. t.Fail()
  3625. }
  3626. }
  3627. func TestTestApex(t *testing.T) {
  3628. ctx := testApex(t, `
  3629. apex_test {
  3630. name: "myapex",
  3631. key: "myapex.key",
  3632. native_shared_libs: ["mylib_common_test"],
  3633. updatable: false,
  3634. }
  3635. apex_key {
  3636. name: "myapex.key",
  3637. public_key: "testkey.avbpubkey",
  3638. private_key: "testkey.pem",
  3639. }
  3640. cc_library {
  3641. name: "mylib_common_test",
  3642. srcs: ["mylib.cpp"],
  3643. system_shared_libs: [],
  3644. stl: "none",
  3645. // TODO: remove //apex_available:platform
  3646. apex_available: [
  3647. "//apex_available:platform",
  3648. "myapex",
  3649. ],
  3650. }
  3651. `)
  3652. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3653. apexRule := module.Rule("apexRule")
  3654. copyCmds := apexRule.Args["copy_commands"]
  3655. if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
  3656. t.Log("Apex was not a test apex!")
  3657. t.Fail()
  3658. }
  3659. // Ensure that main rule creates an output
  3660. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3661. // Ensure that apex variant is created for the direct dep
  3662. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
  3663. // Ensure that both direct and indirect deps are copied into apex
  3664. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
  3665. // Ensure that the platform variant ends with _shared
  3666. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
  3667. }
  3668. func TestApexWithTarget(t *testing.T) {
  3669. ctx := testApex(t, `
  3670. apex {
  3671. name: "myapex",
  3672. key: "myapex.key",
  3673. updatable: false,
  3674. multilib: {
  3675. first: {
  3676. native_shared_libs: ["mylib_common"],
  3677. }
  3678. },
  3679. target: {
  3680. android: {
  3681. multilib: {
  3682. first: {
  3683. native_shared_libs: ["mylib"],
  3684. }
  3685. }
  3686. },
  3687. host: {
  3688. multilib: {
  3689. first: {
  3690. native_shared_libs: ["mylib2"],
  3691. }
  3692. }
  3693. }
  3694. }
  3695. }
  3696. apex_key {
  3697. name: "myapex.key",
  3698. public_key: "testkey.avbpubkey",
  3699. private_key: "testkey.pem",
  3700. }
  3701. cc_library {
  3702. name: "mylib",
  3703. srcs: ["mylib.cpp"],
  3704. system_shared_libs: [],
  3705. stl: "none",
  3706. // TODO: remove //apex_available:platform
  3707. apex_available: [
  3708. "//apex_available:platform",
  3709. "myapex",
  3710. ],
  3711. }
  3712. cc_library {
  3713. name: "mylib_common",
  3714. srcs: ["mylib.cpp"],
  3715. system_shared_libs: [],
  3716. stl: "none",
  3717. compile_multilib: "first",
  3718. // TODO: remove //apex_available:platform
  3719. apex_available: [
  3720. "//apex_available:platform",
  3721. "myapex",
  3722. ],
  3723. }
  3724. cc_library {
  3725. name: "mylib2",
  3726. srcs: ["mylib.cpp"],
  3727. system_shared_libs: [],
  3728. stl: "none",
  3729. compile_multilib: "first",
  3730. }
  3731. `)
  3732. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3733. copyCmds := apexRule.Args["copy_commands"]
  3734. // Ensure that main rule creates an output
  3735. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3736. // Ensure that apex variant is created for the direct dep
  3737. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  3738. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3739. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  3740. // Ensure that both direct and indirect deps are copied into apex
  3741. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  3742. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3743. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  3744. // Ensure that the platform variant ends with _shared
  3745. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  3746. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3747. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  3748. }
  3749. func TestApexWithArch(t *testing.T) {
  3750. ctx := testApex(t, `
  3751. apex {
  3752. name: "myapex",
  3753. key: "myapex.key",
  3754. updatable: false,
  3755. arch: {
  3756. arm64: {
  3757. native_shared_libs: ["mylib.arm64"],
  3758. },
  3759. x86_64: {
  3760. native_shared_libs: ["mylib.x64"],
  3761. },
  3762. }
  3763. }
  3764. apex_key {
  3765. name: "myapex.key",
  3766. public_key: "testkey.avbpubkey",
  3767. private_key: "testkey.pem",
  3768. }
  3769. cc_library {
  3770. name: "mylib.arm64",
  3771. srcs: ["mylib.cpp"],
  3772. system_shared_libs: [],
  3773. stl: "none",
  3774. // TODO: remove //apex_available:platform
  3775. apex_available: [
  3776. "//apex_available:platform",
  3777. "myapex",
  3778. ],
  3779. }
  3780. cc_library {
  3781. name: "mylib.x64",
  3782. srcs: ["mylib.cpp"],
  3783. system_shared_libs: [],
  3784. stl: "none",
  3785. // TODO: remove //apex_available:platform
  3786. apex_available: [
  3787. "//apex_available:platform",
  3788. "myapex",
  3789. ],
  3790. }
  3791. `)
  3792. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3793. copyCmds := apexRule.Args["copy_commands"]
  3794. // Ensure that apex variant is created for the direct dep
  3795. ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
  3796. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
  3797. // Ensure that both direct and indirect deps are copied into apex
  3798. ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
  3799. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
  3800. }
  3801. func TestApexWithShBinary(t *testing.T) {
  3802. ctx := testApex(t, `
  3803. apex {
  3804. name: "myapex",
  3805. key: "myapex.key",
  3806. sh_binaries: ["myscript"],
  3807. updatable: false,
  3808. }
  3809. apex_key {
  3810. name: "myapex.key",
  3811. public_key: "testkey.avbpubkey",
  3812. private_key: "testkey.pem",
  3813. }
  3814. sh_binary {
  3815. name: "myscript",
  3816. src: "mylib.cpp",
  3817. filename: "myscript.sh",
  3818. sub_dir: "script",
  3819. }
  3820. `)
  3821. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3822. copyCmds := apexRule.Args["copy_commands"]
  3823. ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
  3824. }
  3825. func TestApexInVariousPartition(t *testing.T) {
  3826. testcases := []struct {
  3827. propName, parition, flattenedPartition string
  3828. }{
  3829. {"", "system", "system_ext"},
  3830. {"product_specific: true", "product", "product"},
  3831. {"soc_specific: true", "vendor", "vendor"},
  3832. {"proprietary: true", "vendor", "vendor"},
  3833. {"vendor: true", "vendor", "vendor"},
  3834. {"system_ext_specific: true", "system_ext", "system_ext"},
  3835. }
  3836. for _, tc := range testcases {
  3837. t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
  3838. ctx := testApex(t, `
  3839. apex {
  3840. name: "myapex",
  3841. key: "myapex.key",
  3842. updatable: false,
  3843. `+tc.propName+`
  3844. }
  3845. apex_key {
  3846. name: "myapex.key",
  3847. public_key: "testkey.avbpubkey",
  3848. private_key: "testkey.pem",
  3849. }
  3850. `)
  3851. apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  3852. expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
  3853. actual := apex.installDir.RelativeToTop().String()
  3854. if actual != expected {
  3855. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3856. }
  3857. flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  3858. expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
  3859. actual = flattened.installDir.RelativeToTop().String()
  3860. if actual != expected {
  3861. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3862. }
  3863. })
  3864. }
  3865. }
  3866. func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
  3867. ctx := testApex(t, `
  3868. apex {
  3869. name: "myapex",
  3870. key: "myapex.key",
  3871. updatable: false,
  3872. }
  3873. apex_key {
  3874. name: "myapex.key",
  3875. public_key: "testkey.avbpubkey",
  3876. private_key: "testkey.pem",
  3877. }
  3878. `)
  3879. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3880. rule := module.Output("file_contexts")
  3881. ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
  3882. }
  3883. func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
  3884. testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
  3885. apex {
  3886. name: "myapex",
  3887. key: "myapex.key",
  3888. file_contexts: "my_own_file_contexts",
  3889. updatable: false,
  3890. }
  3891. apex_key {
  3892. name: "myapex.key",
  3893. public_key: "testkey.avbpubkey",
  3894. private_key: "testkey.pem",
  3895. }
  3896. `, withFiles(map[string][]byte{
  3897. "my_own_file_contexts": nil,
  3898. }))
  3899. }
  3900. func TestFileContexts_ProductSpecificApexes(t *testing.T) {
  3901. testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
  3902. apex {
  3903. name: "myapex",
  3904. key: "myapex.key",
  3905. product_specific: true,
  3906. file_contexts: "product_specific_file_contexts",
  3907. updatable: false,
  3908. }
  3909. apex_key {
  3910. name: "myapex.key",
  3911. public_key: "testkey.avbpubkey",
  3912. private_key: "testkey.pem",
  3913. }
  3914. `)
  3915. ctx := testApex(t, `
  3916. apex {
  3917. name: "myapex",
  3918. key: "myapex.key",
  3919. product_specific: true,
  3920. file_contexts: "product_specific_file_contexts",
  3921. updatable: false,
  3922. }
  3923. apex_key {
  3924. name: "myapex.key",
  3925. public_key: "testkey.avbpubkey",
  3926. private_key: "testkey.pem",
  3927. }
  3928. `, withFiles(map[string][]byte{
  3929. "product_specific_file_contexts": nil,
  3930. }))
  3931. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3932. rule := module.Output("file_contexts")
  3933. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  3934. }
  3935. func TestFileContexts_SetViaFileGroup(t *testing.T) {
  3936. ctx := testApex(t, `
  3937. apex {
  3938. name: "myapex",
  3939. key: "myapex.key",
  3940. product_specific: true,
  3941. file_contexts: ":my-file-contexts",
  3942. updatable: false,
  3943. }
  3944. apex_key {
  3945. name: "myapex.key",
  3946. public_key: "testkey.avbpubkey",
  3947. private_key: "testkey.pem",
  3948. }
  3949. filegroup {
  3950. name: "my-file-contexts",
  3951. srcs: ["product_specific_file_contexts"],
  3952. }
  3953. `, withFiles(map[string][]byte{
  3954. "product_specific_file_contexts": nil,
  3955. }))
  3956. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3957. rule := module.Output("file_contexts")
  3958. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  3959. }
  3960. func TestApexKeyFromOtherModule(t *testing.T) {
  3961. ctx := testApex(t, `
  3962. apex_key {
  3963. name: "myapex.key",
  3964. public_key: ":my.avbpubkey",
  3965. private_key: ":my.pem",
  3966. product_specific: true,
  3967. }
  3968. filegroup {
  3969. name: "my.avbpubkey",
  3970. srcs: ["testkey2.avbpubkey"],
  3971. }
  3972. filegroup {
  3973. name: "my.pem",
  3974. srcs: ["testkey2.pem"],
  3975. }
  3976. `)
  3977. apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  3978. expected_pubkey := "testkey2.avbpubkey"
  3979. actual_pubkey := apex_key.publicKeyFile.String()
  3980. if actual_pubkey != expected_pubkey {
  3981. t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
  3982. }
  3983. expected_privkey := "testkey2.pem"
  3984. actual_privkey := apex_key.privateKeyFile.String()
  3985. if actual_privkey != expected_privkey {
  3986. t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
  3987. }
  3988. }
  3989. func TestPrebuilt(t *testing.T) {
  3990. ctx := testApex(t, `
  3991. prebuilt_apex {
  3992. name: "myapex",
  3993. arch: {
  3994. arm64: {
  3995. src: "myapex-arm64.apex",
  3996. },
  3997. arm: {
  3998. src: "myapex-arm.apex",
  3999. },
  4000. },
  4001. }
  4002. `)
  4003. prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  4004. expectedInput := "myapex-arm64.apex"
  4005. if prebuilt.inputApex.String() != expectedInput {
  4006. t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
  4007. }
  4008. }
  4009. func TestPrebuiltMissingSrc(t *testing.T) {
  4010. testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
  4011. prebuilt_apex {
  4012. name: "myapex",
  4013. }
  4014. `)
  4015. }
  4016. func TestPrebuiltFilenameOverride(t *testing.T) {
  4017. ctx := testApex(t, `
  4018. prebuilt_apex {
  4019. name: "myapex",
  4020. src: "myapex-arm.apex",
  4021. filename: "notmyapex.apex",
  4022. }
  4023. `)
  4024. p := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  4025. expected := "notmyapex.apex"
  4026. if p.installFilename != expected {
  4027. t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
  4028. }
  4029. }
  4030. func TestApexSetFilenameOverride(t *testing.T) {
  4031. testApex(t, `
  4032. apex_set {
  4033. name: "com.company.android.myapex",
  4034. apex_name: "com.android.myapex",
  4035. set: "company-myapex.apks",
  4036. filename: "com.company.android.myapex.apex"
  4037. }
  4038. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4039. testApex(t, `
  4040. apex_set {
  4041. name: "com.company.android.myapex",
  4042. apex_name: "com.android.myapex",
  4043. set: "company-myapex.apks",
  4044. filename: "com.company.android.myapex.capex"
  4045. }
  4046. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4047. testApexError(t, `filename should end in .apex or .capex for apex_set`, `
  4048. apex_set {
  4049. name: "com.company.android.myapex",
  4050. apex_name: "com.android.myapex",
  4051. set: "company-myapex.apks",
  4052. filename: "some-random-suffix"
  4053. }
  4054. `)
  4055. }
  4056. func TestPrebuiltOverrides(t *testing.T) {
  4057. ctx := testApex(t, `
  4058. prebuilt_apex {
  4059. name: "myapex.prebuilt",
  4060. src: "myapex-arm.apex",
  4061. overrides: [
  4062. "myapex",
  4063. ],
  4064. }
  4065. `)
  4066. p := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt").Module().(*Prebuilt)
  4067. expected := []string{"myapex"}
  4068. actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  4069. if !reflect.DeepEqual(actual, expected) {
  4070. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
  4071. }
  4072. }
  4073. func TestPrebuiltApexName(t *testing.T) {
  4074. testApex(t, `
  4075. prebuilt_apex {
  4076. name: "com.company.android.myapex",
  4077. apex_name: "com.android.myapex",
  4078. src: "company-myapex-arm.apex",
  4079. }
  4080. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4081. testApex(t, `
  4082. apex_set {
  4083. name: "com.company.android.myapex",
  4084. apex_name: "com.android.myapex",
  4085. set: "company-myapex.apks",
  4086. }
  4087. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4088. }
  4089. func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
  4090. _ = android.GroupFixturePreparers(
  4091. java.PrepareForTestWithJavaDefaultModules,
  4092. PrepareForTestWithApexBuildComponents,
  4093. android.FixtureWithRootAndroidBp(`
  4094. platform_bootclasspath {
  4095. name: "platform-bootclasspath",
  4096. fragments: [
  4097. {
  4098. apex: "com.android.art",
  4099. module: "art-bootclasspath-fragment",
  4100. },
  4101. ],
  4102. }
  4103. prebuilt_apex {
  4104. name: "com.company.android.art",
  4105. apex_name: "com.android.art",
  4106. src: "com.company.android.art-arm.apex",
  4107. exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
  4108. }
  4109. prebuilt_bootclasspath_fragment {
  4110. name: "art-bootclasspath-fragment",
  4111. image_name: "art",
  4112. contents: ["core-oj"],
  4113. hidden_api: {
  4114. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4115. metadata: "my-bootclasspath-fragment/metadata.csv",
  4116. index: "my-bootclasspath-fragment/index.csv",
  4117. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4118. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4119. },
  4120. }
  4121. java_import {
  4122. name: "core-oj",
  4123. jars: ["prebuilt.jar"],
  4124. }
  4125. `),
  4126. ).RunTest(t)
  4127. }
  4128. // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
  4129. // propagation of paths to dex implementation jars from the former to the latter.
  4130. func TestPrebuiltExportDexImplementationJars(t *testing.T) {
  4131. transform := android.NullFixturePreparer
  4132. checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4133. t.Helper()
  4134. // Make sure the import has been given the correct path to the dex jar.
  4135. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4136. dexJarBuildPath := p.DexJarBuildPath().PathOrNil()
  4137. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4138. android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
  4139. ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
  4140. android.NormalizePathForTesting(dexJarBuildPath))
  4141. }
  4142. checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4143. t.Helper()
  4144. // Make sure the import has been given the correct path to the dex jar.
  4145. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4146. dexJarBuildPath := p.DexJarInstallPath()
  4147. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4148. android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
  4149. "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
  4150. android.NormalizePathForTesting(dexJarBuildPath))
  4151. }
  4152. ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
  4153. t.Helper()
  4154. // Make sure that an apex variant is not created for the source module.
  4155. android.AssertArrayString(t, "Check if there is no source variant",
  4156. []string{"android_common"},
  4157. ctx.ModuleVariantsForTests(name))
  4158. }
  4159. t.Run("prebuilt only", func(t *testing.T) {
  4160. bp := `
  4161. prebuilt_apex {
  4162. name: "myapex",
  4163. arch: {
  4164. arm64: {
  4165. src: "myapex-arm64.apex",
  4166. },
  4167. arm: {
  4168. src: "myapex-arm.apex",
  4169. },
  4170. },
  4171. exported_java_libs: ["libfoo", "libbar"],
  4172. }
  4173. java_import {
  4174. name: "libfoo",
  4175. jars: ["libfoo.jar"],
  4176. }
  4177. java_sdk_library_import {
  4178. name: "libbar",
  4179. public: {
  4180. jars: ["libbar.jar"],
  4181. },
  4182. }
  4183. `
  4184. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4185. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4186. deapexerName := deapexerModuleName("myapex")
  4187. android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName))
  4188. // Make sure that the deapexer has the correct input APEX.
  4189. deapexer := ctx.ModuleForTests(deapexerName, "android_common")
  4190. rule := deapexer.Rule("deapexer")
  4191. if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
  4192. t.Errorf("expected: %q, found: %q", expected, actual)
  4193. }
  4194. // Make sure that the prebuilt_apex has the correct input APEX.
  4195. prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
  4196. rule = prebuiltApex.Rule("android/soong/android.Cp")
  4197. if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
  4198. t.Errorf("expected: %q, found: %q", expected, actual)
  4199. }
  4200. checkDexJarBuildPath(t, ctx, "libfoo")
  4201. checkDexJarInstallPath(t, ctx, "libfoo")
  4202. checkDexJarBuildPath(t, ctx, "libbar")
  4203. checkDexJarInstallPath(t, ctx, "libbar")
  4204. })
  4205. t.Run("prebuilt with source preferred", func(t *testing.T) {
  4206. bp := `
  4207. prebuilt_apex {
  4208. name: "myapex",
  4209. arch: {
  4210. arm64: {
  4211. src: "myapex-arm64.apex",
  4212. },
  4213. arm: {
  4214. src: "myapex-arm.apex",
  4215. },
  4216. },
  4217. exported_java_libs: ["libfoo", "libbar"],
  4218. }
  4219. java_import {
  4220. name: "libfoo",
  4221. jars: ["libfoo.jar"],
  4222. }
  4223. java_library {
  4224. name: "libfoo",
  4225. }
  4226. java_sdk_library_import {
  4227. name: "libbar",
  4228. public: {
  4229. jars: ["libbar.jar"],
  4230. },
  4231. }
  4232. java_sdk_library {
  4233. name: "libbar",
  4234. srcs: ["foo/bar/MyClass.java"],
  4235. unsafe_ignore_missing_latest_api: true,
  4236. }
  4237. `
  4238. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4239. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4240. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4241. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4242. ensureNoSourceVariant(t, ctx, "libfoo")
  4243. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4244. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4245. ensureNoSourceVariant(t, ctx, "libbar")
  4246. })
  4247. t.Run("prebuilt preferred with source", func(t *testing.T) {
  4248. bp := `
  4249. prebuilt_apex {
  4250. name: "myapex",
  4251. arch: {
  4252. arm64: {
  4253. src: "myapex-arm64.apex",
  4254. },
  4255. arm: {
  4256. src: "myapex-arm.apex",
  4257. },
  4258. },
  4259. exported_java_libs: ["libfoo", "libbar"],
  4260. }
  4261. java_import {
  4262. name: "libfoo",
  4263. prefer: true,
  4264. jars: ["libfoo.jar"],
  4265. }
  4266. java_library {
  4267. name: "libfoo",
  4268. }
  4269. java_sdk_library_import {
  4270. name: "libbar",
  4271. prefer: true,
  4272. public: {
  4273. jars: ["libbar.jar"],
  4274. },
  4275. }
  4276. java_sdk_library {
  4277. name: "libbar",
  4278. srcs: ["foo/bar/MyClass.java"],
  4279. unsafe_ignore_missing_latest_api: true,
  4280. }
  4281. `
  4282. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4283. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4284. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4285. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4286. ensureNoSourceVariant(t, ctx, "libfoo")
  4287. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4288. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4289. ensureNoSourceVariant(t, ctx, "libbar")
  4290. })
  4291. }
  4292. func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
  4293. preparer := android.GroupFixturePreparers(
  4294. java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
  4295. // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
  4296. // is disabled.
  4297. android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
  4298. )
  4299. checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
  4300. t.Helper()
  4301. s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4302. foundLibfooJar := false
  4303. base := stem + ".jar"
  4304. for _, output := range s.AllOutputs() {
  4305. if filepath.Base(output) == base {
  4306. foundLibfooJar = true
  4307. buildRule := s.Output(output)
  4308. android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
  4309. }
  4310. }
  4311. if !foundLibfooJar {
  4312. t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
  4313. }
  4314. }
  4315. checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4316. t.Helper()
  4317. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4318. var rule android.TestingBuildParams
  4319. rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
  4320. java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
  4321. }
  4322. checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4323. t.Helper()
  4324. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4325. var rule android.TestingBuildParams
  4326. rule = platformBootclasspath.Output("hiddenapi-index.csv")
  4327. java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
  4328. }
  4329. fragment := java.ApexVariantReference{
  4330. Apex: proptools.StringPtr("myapex"),
  4331. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  4332. }
  4333. t.Run("prebuilt only", func(t *testing.T) {
  4334. bp := `
  4335. prebuilt_apex {
  4336. name: "myapex",
  4337. arch: {
  4338. arm64: {
  4339. src: "myapex-arm64.apex",
  4340. },
  4341. arm: {
  4342. src: "myapex-arm.apex",
  4343. },
  4344. },
  4345. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4346. }
  4347. prebuilt_bootclasspath_fragment {
  4348. name: "my-bootclasspath-fragment",
  4349. contents: ["libfoo", "libbar"],
  4350. apex_available: ["myapex"],
  4351. hidden_api: {
  4352. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4353. metadata: "my-bootclasspath-fragment/metadata.csv",
  4354. index: "my-bootclasspath-fragment/index.csv",
  4355. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4356. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4357. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4358. },
  4359. }
  4360. java_import {
  4361. name: "libfoo",
  4362. jars: ["libfoo.jar"],
  4363. apex_available: ["myapex"],
  4364. permitted_packages: ["foo"],
  4365. }
  4366. java_sdk_library_import {
  4367. name: "libbar",
  4368. public: {
  4369. jars: ["libbar.jar"],
  4370. },
  4371. apex_available: ["myapex"],
  4372. shared_library: false,
  4373. permitted_packages: ["bar"],
  4374. }
  4375. `
  4376. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4377. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4378. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4379. // Verify the correct module jars contribute to the hiddenapi index file.
  4380. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4381. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4382. my-bootclasspath-fragment/index.csv
  4383. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4384. `)
  4385. })
  4386. t.Run("apex_set only", func(t *testing.T) {
  4387. bp := `
  4388. apex_set {
  4389. name: "myapex",
  4390. set: "myapex.apks",
  4391. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4392. }
  4393. prebuilt_bootclasspath_fragment {
  4394. name: "my-bootclasspath-fragment",
  4395. contents: ["libfoo", "libbar"],
  4396. apex_available: ["myapex"],
  4397. hidden_api: {
  4398. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4399. metadata: "my-bootclasspath-fragment/metadata.csv",
  4400. index: "my-bootclasspath-fragment/index.csv",
  4401. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4402. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4403. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4404. },
  4405. }
  4406. java_import {
  4407. name: "libfoo",
  4408. jars: ["libfoo.jar"],
  4409. apex_available: ["myapex"],
  4410. permitted_packages: ["foo"],
  4411. }
  4412. java_sdk_library_import {
  4413. name: "libbar",
  4414. public: {
  4415. jars: ["libbar.jar"],
  4416. },
  4417. apex_available: ["myapex"],
  4418. shared_library: false,
  4419. permitted_packages: ["bar"],
  4420. }
  4421. `
  4422. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4423. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4424. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4425. // Verify the correct module jars contribute to the hiddenapi index file.
  4426. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4427. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4428. my-bootclasspath-fragment/index.csv
  4429. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4430. `)
  4431. })
  4432. t.Run("prebuilt with source library preferred", func(t *testing.T) {
  4433. bp := `
  4434. prebuilt_apex {
  4435. name: "myapex",
  4436. arch: {
  4437. arm64: {
  4438. src: "myapex-arm64.apex",
  4439. },
  4440. arm: {
  4441. src: "myapex-arm.apex",
  4442. },
  4443. },
  4444. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4445. }
  4446. prebuilt_bootclasspath_fragment {
  4447. name: "my-bootclasspath-fragment",
  4448. contents: ["libfoo", "libbar"],
  4449. apex_available: ["myapex"],
  4450. hidden_api: {
  4451. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4452. metadata: "my-bootclasspath-fragment/metadata.csv",
  4453. index: "my-bootclasspath-fragment/index.csv",
  4454. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4455. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4456. },
  4457. }
  4458. java_import {
  4459. name: "libfoo",
  4460. jars: ["libfoo.jar"],
  4461. apex_available: ["myapex"],
  4462. }
  4463. java_library {
  4464. name: "libfoo",
  4465. srcs: ["foo/bar/MyClass.java"],
  4466. apex_available: ["myapex"],
  4467. }
  4468. java_sdk_library_import {
  4469. name: "libbar",
  4470. public: {
  4471. jars: ["libbar.jar"],
  4472. },
  4473. apex_available: ["myapex"],
  4474. shared_library: false,
  4475. }
  4476. java_sdk_library {
  4477. name: "libbar",
  4478. srcs: ["foo/bar/MyClass.java"],
  4479. unsafe_ignore_missing_latest_api: true,
  4480. apex_available: ["myapex"],
  4481. }
  4482. `
  4483. // In this test the source (java_library) libfoo is active since the
  4484. // prebuilt (java_import) defaults to prefer:false. However the
  4485. // prebuilt_apex module always depends on the prebuilt, and so it doesn't
  4486. // find the dex boot jar in it. We either need to disable the source libfoo
  4487. // or make the prebuilt libfoo preferred.
  4488. testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
  4489. // dexbootjar check is skipped if AllowMissingDependencies is true
  4490. preparerAllowMissingDeps := android.GroupFixturePreparers(
  4491. preparer,
  4492. android.PrepareForTestWithAllowMissingDependencies,
  4493. )
  4494. testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
  4495. })
  4496. t.Run("prebuilt library preferred with source", func(t *testing.T) {
  4497. bp := `
  4498. prebuilt_apex {
  4499. name: "myapex",
  4500. arch: {
  4501. arm64: {
  4502. src: "myapex-arm64.apex",
  4503. },
  4504. arm: {
  4505. src: "myapex-arm.apex",
  4506. },
  4507. },
  4508. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4509. }
  4510. prebuilt_bootclasspath_fragment {
  4511. name: "my-bootclasspath-fragment",
  4512. contents: ["libfoo", "libbar"],
  4513. apex_available: ["myapex"],
  4514. hidden_api: {
  4515. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4516. metadata: "my-bootclasspath-fragment/metadata.csv",
  4517. index: "my-bootclasspath-fragment/index.csv",
  4518. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4519. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4520. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4521. },
  4522. }
  4523. java_import {
  4524. name: "libfoo",
  4525. prefer: true,
  4526. jars: ["libfoo.jar"],
  4527. apex_available: ["myapex"],
  4528. permitted_packages: ["foo"],
  4529. }
  4530. java_library {
  4531. name: "libfoo",
  4532. srcs: ["foo/bar/MyClass.java"],
  4533. apex_available: ["myapex"],
  4534. }
  4535. java_sdk_library_import {
  4536. name: "libbar",
  4537. prefer: true,
  4538. public: {
  4539. jars: ["libbar.jar"],
  4540. },
  4541. apex_available: ["myapex"],
  4542. shared_library: false,
  4543. permitted_packages: ["bar"],
  4544. }
  4545. java_sdk_library {
  4546. name: "libbar",
  4547. srcs: ["foo/bar/MyClass.java"],
  4548. unsafe_ignore_missing_latest_api: true,
  4549. apex_available: ["myapex"],
  4550. }
  4551. `
  4552. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4553. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4554. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4555. // Verify the correct module jars contribute to the hiddenapi index file.
  4556. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4557. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4558. my-bootclasspath-fragment/index.csv
  4559. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4560. `)
  4561. })
  4562. t.Run("prebuilt with source apex preferred", func(t *testing.T) {
  4563. bp := `
  4564. apex {
  4565. name: "myapex",
  4566. key: "myapex.key",
  4567. java_libs: ["libfoo", "libbar"],
  4568. updatable: false,
  4569. }
  4570. apex_key {
  4571. name: "myapex.key",
  4572. public_key: "testkey.avbpubkey",
  4573. private_key: "testkey.pem",
  4574. }
  4575. prebuilt_apex {
  4576. name: "myapex",
  4577. arch: {
  4578. arm64: {
  4579. src: "myapex-arm64.apex",
  4580. },
  4581. arm: {
  4582. src: "myapex-arm.apex",
  4583. },
  4584. },
  4585. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4586. }
  4587. prebuilt_bootclasspath_fragment {
  4588. name: "my-bootclasspath-fragment",
  4589. contents: ["libfoo", "libbar"],
  4590. apex_available: ["myapex"],
  4591. hidden_api: {
  4592. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4593. metadata: "my-bootclasspath-fragment/metadata.csv",
  4594. index: "my-bootclasspath-fragment/index.csv",
  4595. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4596. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4597. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4598. },
  4599. }
  4600. java_import {
  4601. name: "libfoo",
  4602. jars: ["libfoo.jar"],
  4603. apex_available: ["myapex"],
  4604. }
  4605. java_library {
  4606. name: "libfoo",
  4607. srcs: ["foo/bar/MyClass.java"],
  4608. apex_available: ["myapex"],
  4609. permitted_packages: ["foo"],
  4610. }
  4611. java_sdk_library_import {
  4612. name: "libbar",
  4613. public: {
  4614. jars: ["libbar.jar"],
  4615. },
  4616. apex_available: ["myapex"],
  4617. shared_library: false,
  4618. }
  4619. java_sdk_library {
  4620. name: "libbar",
  4621. srcs: ["foo/bar/MyClass.java"],
  4622. unsafe_ignore_missing_latest_api: true,
  4623. apex_available: ["myapex"],
  4624. permitted_packages: ["bar"],
  4625. }
  4626. `
  4627. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4628. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
  4629. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
  4630. // Verify the correct module jars contribute to the hiddenapi index file.
  4631. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4632. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4633. my-bootclasspath-fragment/index.csv
  4634. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4635. `)
  4636. })
  4637. t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
  4638. bp := `
  4639. apex {
  4640. name: "myapex",
  4641. enabled: false,
  4642. key: "myapex.key",
  4643. java_libs: ["libfoo", "libbar"],
  4644. }
  4645. apex_key {
  4646. name: "myapex.key",
  4647. public_key: "testkey.avbpubkey",
  4648. private_key: "testkey.pem",
  4649. }
  4650. prebuilt_apex {
  4651. name: "myapex",
  4652. arch: {
  4653. arm64: {
  4654. src: "myapex-arm64.apex",
  4655. },
  4656. arm: {
  4657. src: "myapex-arm.apex",
  4658. },
  4659. },
  4660. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4661. }
  4662. prebuilt_bootclasspath_fragment {
  4663. name: "my-bootclasspath-fragment",
  4664. contents: ["libfoo", "libbar"],
  4665. apex_available: ["myapex"],
  4666. hidden_api: {
  4667. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4668. metadata: "my-bootclasspath-fragment/metadata.csv",
  4669. index: "my-bootclasspath-fragment/index.csv",
  4670. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4671. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4672. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4673. },
  4674. }
  4675. java_import {
  4676. name: "libfoo",
  4677. prefer: true,
  4678. jars: ["libfoo.jar"],
  4679. apex_available: ["myapex"],
  4680. permitted_packages: ["foo"],
  4681. }
  4682. java_library {
  4683. name: "libfoo",
  4684. srcs: ["foo/bar/MyClass.java"],
  4685. apex_available: ["myapex"],
  4686. }
  4687. java_sdk_library_import {
  4688. name: "libbar",
  4689. prefer: true,
  4690. public: {
  4691. jars: ["libbar.jar"],
  4692. },
  4693. apex_available: ["myapex"],
  4694. shared_library: false,
  4695. permitted_packages: ["bar"],
  4696. }
  4697. java_sdk_library {
  4698. name: "libbar",
  4699. srcs: ["foo/bar/MyClass.java"],
  4700. unsafe_ignore_missing_latest_api: true,
  4701. apex_available: ["myapex"],
  4702. }
  4703. `
  4704. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4705. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4706. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4707. // Verify the correct module jars contribute to the hiddenapi index file.
  4708. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4709. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4710. my-bootclasspath-fragment/index.csv
  4711. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4712. `)
  4713. })
  4714. }
  4715. func TestApexWithTests(t *testing.T) {
  4716. ctx := testApex(t, `
  4717. apex_test {
  4718. name: "myapex",
  4719. key: "myapex.key",
  4720. updatable: false,
  4721. tests: [
  4722. "mytest",
  4723. "mytests",
  4724. ],
  4725. }
  4726. apex_key {
  4727. name: "myapex.key",
  4728. public_key: "testkey.avbpubkey",
  4729. private_key: "testkey.pem",
  4730. }
  4731. filegroup {
  4732. name: "fg",
  4733. srcs: [
  4734. "baz",
  4735. "bar/baz"
  4736. ],
  4737. }
  4738. cc_test {
  4739. name: "mytest",
  4740. gtest: false,
  4741. srcs: ["mytest.cpp"],
  4742. relative_install_path: "test",
  4743. shared_libs: ["mylib"],
  4744. system_shared_libs: [],
  4745. static_executable: true,
  4746. stl: "none",
  4747. data: [":fg"],
  4748. }
  4749. cc_library {
  4750. name: "mylib",
  4751. srcs: ["mylib.cpp"],
  4752. system_shared_libs: [],
  4753. stl: "none",
  4754. }
  4755. filegroup {
  4756. name: "fg2",
  4757. srcs: [
  4758. "testdata/baz"
  4759. ],
  4760. }
  4761. cc_test {
  4762. name: "mytests",
  4763. gtest: false,
  4764. srcs: [
  4765. "mytest1.cpp",
  4766. "mytest2.cpp",
  4767. "mytest3.cpp",
  4768. ],
  4769. test_per_src: true,
  4770. relative_install_path: "test",
  4771. system_shared_libs: [],
  4772. static_executable: true,
  4773. stl: "none",
  4774. data: [
  4775. ":fg",
  4776. ":fg2",
  4777. ],
  4778. }
  4779. `)
  4780. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4781. copyCmds := apexRule.Args["copy_commands"]
  4782. // Ensure that test dep (and their transitive dependencies) are copied into apex.
  4783. ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
  4784. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  4785. //Ensure that test data are copied into apex.
  4786. ensureContains(t, copyCmds, "image.apex/bin/test/baz")
  4787. ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
  4788. // Ensure that test deps built with `test_per_src` are copied into apex.
  4789. ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
  4790. ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
  4791. ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
  4792. // Ensure the module is correctly translated.
  4793. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4794. data := android.AndroidMkDataForTest(t, ctx, bundle)
  4795. name := bundle.BaseModuleName()
  4796. prefix := "TARGET_"
  4797. var builder strings.Builder
  4798. data.Custom(&builder, name, prefix, "", data)
  4799. androidMk := builder.String()
  4800. ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
  4801. ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
  4802. ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
  4803. ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
  4804. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
  4805. ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
  4806. ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
  4807. flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  4808. data = android.AndroidMkDataForTest(t, ctx, flatBundle)
  4809. data.Custom(&builder, name, prefix, "", data)
  4810. flatAndroidMk := builder.String()
  4811. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
  4812. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
  4813. }
  4814. func TestInstallExtraFlattenedApexes(t *testing.T) {
  4815. ctx := testApex(t, `
  4816. apex {
  4817. name: "myapex",
  4818. key: "myapex.key",
  4819. updatable: false,
  4820. }
  4821. apex_key {
  4822. name: "myapex.key",
  4823. public_key: "testkey.avbpubkey",
  4824. private_key: "testkey.pem",
  4825. }
  4826. `,
  4827. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  4828. variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
  4829. }),
  4830. )
  4831. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4832. ensureListContains(t, ab.requiredDeps, "myapex.flattened")
  4833. mk := android.AndroidMkDataForTest(t, ctx, ab)
  4834. var builder strings.Builder
  4835. mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
  4836. androidMk := builder.String()
  4837. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
  4838. }
  4839. func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
  4840. testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
  4841. apex {
  4842. name: "myapex",
  4843. key: "myapex.key",
  4844. native_shared_libs: ["libfoo"],
  4845. }
  4846. apex_key {
  4847. name: "myapex.key",
  4848. public_key: "testkey.avbpubkey",
  4849. private_key: "testkey.pem",
  4850. }
  4851. cc_library {
  4852. name: "libfoo",
  4853. stl: "none",
  4854. system_shared_libs: [],
  4855. enabled: false,
  4856. apex_available: ["myapex"],
  4857. }
  4858. `)
  4859. testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
  4860. apex {
  4861. name: "myapex",
  4862. key: "myapex.key",
  4863. java_libs: ["myjar"],
  4864. }
  4865. apex_key {
  4866. name: "myapex.key",
  4867. public_key: "testkey.avbpubkey",
  4868. private_key: "testkey.pem",
  4869. }
  4870. java_library {
  4871. name: "myjar",
  4872. srcs: ["foo/bar/MyClass.java"],
  4873. sdk_version: "none",
  4874. system_modules: "none",
  4875. enabled: false,
  4876. apex_available: ["myapex"],
  4877. }
  4878. `)
  4879. }
  4880. func TestApexWithJavaImport(t *testing.T) {
  4881. ctx := testApex(t, `
  4882. apex {
  4883. name: "myapex",
  4884. key: "myapex.key",
  4885. java_libs: ["myjavaimport"],
  4886. updatable: false,
  4887. }
  4888. apex_key {
  4889. name: "myapex.key",
  4890. public_key: "testkey.avbpubkey",
  4891. private_key: "testkey.pem",
  4892. }
  4893. java_import {
  4894. name: "myjavaimport",
  4895. apex_available: ["myapex"],
  4896. jars: ["my.jar"],
  4897. compile_dex: true,
  4898. }
  4899. `)
  4900. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4901. apexRule := module.Rule("apexRule")
  4902. copyCmds := apexRule.Args["copy_commands"]
  4903. ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
  4904. }
  4905. func TestApexWithApps(t *testing.T) {
  4906. ctx := testApex(t, `
  4907. apex {
  4908. name: "myapex",
  4909. key: "myapex.key",
  4910. apps: [
  4911. "AppFoo",
  4912. "AppFooPriv",
  4913. ],
  4914. updatable: false,
  4915. }
  4916. apex_key {
  4917. name: "myapex.key",
  4918. public_key: "testkey.avbpubkey",
  4919. private_key: "testkey.pem",
  4920. }
  4921. android_app {
  4922. name: "AppFoo",
  4923. srcs: ["foo/bar/MyClass.java"],
  4924. sdk_version: "current",
  4925. system_modules: "none",
  4926. jni_libs: ["libjni"],
  4927. stl: "none",
  4928. apex_available: [ "myapex" ],
  4929. }
  4930. android_app {
  4931. name: "AppFooPriv",
  4932. srcs: ["foo/bar/MyClass.java"],
  4933. sdk_version: "current",
  4934. system_modules: "none",
  4935. privileged: true,
  4936. stl: "none",
  4937. apex_available: [ "myapex" ],
  4938. }
  4939. cc_library_shared {
  4940. name: "libjni",
  4941. srcs: ["mylib.cpp"],
  4942. shared_libs: ["libfoo"],
  4943. stl: "none",
  4944. system_shared_libs: [],
  4945. apex_available: [ "myapex" ],
  4946. sdk_version: "current",
  4947. }
  4948. cc_library_shared {
  4949. name: "libfoo",
  4950. stl: "none",
  4951. system_shared_libs: [],
  4952. apex_available: [ "myapex" ],
  4953. sdk_version: "current",
  4954. }
  4955. `)
  4956. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4957. apexRule := module.Rule("apexRule")
  4958. copyCmds := apexRule.Args["copy_commands"]
  4959. ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
  4960. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
  4961. appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
  4962. // JNI libraries are uncompressed
  4963. if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
  4964. t.Errorf("jni libs are not uncompressed for AppFoo")
  4965. }
  4966. // JNI libraries including transitive deps are
  4967. for _, jni := range []string{"libjni", "libfoo"} {
  4968. jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
  4969. // ... embedded inside APK (jnilibs.zip)
  4970. ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
  4971. // ... and not directly inside the APEX
  4972. ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
  4973. }
  4974. }
  4975. func TestApexWithAppImports(t *testing.T) {
  4976. ctx := testApex(t, `
  4977. apex {
  4978. name: "myapex",
  4979. key: "myapex.key",
  4980. apps: [
  4981. "AppFooPrebuilt",
  4982. "AppFooPrivPrebuilt",
  4983. ],
  4984. updatable: false,
  4985. }
  4986. apex_key {
  4987. name: "myapex.key",
  4988. public_key: "testkey.avbpubkey",
  4989. private_key: "testkey.pem",
  4990. }
  4991. android_app_import {
  4992. name: "AppFooPrebuilt",
  4993. apk: "PrebuiltAppFoo.apk",
  4994. presigned: true,
  4995. dex_preopt: {
  4996. enabled: false,
  4997. },
  4998. apex_available: ["myapex"],
  4999. }
  5000. android_app_import {
  5001. name: "AppFooPrivPrebuilt",
  5002. apk: "PrebuiltAppFooPriv.apk",
  5003. privileged: true,
  5004. presigned: true,
  5005. dex_preopt: {
  5006. enabled: false,
  5007. },
  5008. filename: "AwesomePrebuiltAppFooPriv.apk",
  5009. apex_available: ["myapex"],
  5010. }
  5011. `)
  5012. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5013. apexRule := module.Rule("apexRule")
  5014. copyCmds := apexRule.Args["copy_commands"]
  5015. ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
  5016. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
  5017. }
  5018. func TestApexWithAppImportsPrefer(t *testing.T) {
  5019. ctx := testApex(t, `
  5020. apex {
  5021. name: "myapex",
  5022. key: "myapex.key",
  5023. apps: [
  5024. "AppFoo",
  5025. ],
  5026. updatable: false,
  5027. }
  5028. apex_key {
  5029. name: "myapex.key",
  5030. public_key: "testkey.avbpubkey",
  5031. private_key: "testkey.pem",
  5032. }
  5033. android_app {
  5034. name: "AppFoo",
  5035. srcs: ["foo/bar/MyClass.java"],
  5036. sdk_version: "none",
  5037. system_modules: "none",
  5038. apex_available: [ "myapex" ],
  5039. }
  5040. android_app_import {
  5041. name: "AppFoo",
  5042. apk: "AppFooPrebuilt.apk",
  5043. filename: "AppFooPrebuilt.apk",
  5044. presigned: true,
  5045. prefer: true,
  5046. apex_available: ["myapex"],
  5047. }
  5048. `, withFiles(map[string][]byte{
  5049. "AppFooPrebuilt.apk": nil,
  5050. }))
  5051. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5052. "app/AppFoo/AppFooPrebuilt.apk",
  5053. })
  5054. }
  5055. func TestApexWithTestHelperApp(t *testing.T) {
  5056. ctx := testApex(t, `
  5057. apex {
  5058. name: "myapex",
  5059. key: "myapex.key",
  5060. apps: [
  5061. "TesterHelpAppFoo",
  5062. ],
  5063. updatable: false,
  5064. }
  5065. apex_key {
  5066. name: "myapex.key",
  5067. public_key: "testkey.avbpubkey",
  5068. private_key: "testkey.pem",
  5069. }
  5070. android_test_helper_app {
  5071. name: "TesterHelpAppFoo",
  5072. srcs: ["foo/bar/MyClass.java"],
  5073. apex_available: [ "myapex" ],
  5074. }
  5075. `)
  5076. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5077. apexRule := module.Rule("apexRule")
  5078. copyCmds := apexRule.Args["copy_commands"]
  5079. ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
  5080. }
  5081. func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
  5082. // libfoo's apex_available comes from cc_defaults
  5083. testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
  5084. apex {
  5085. name: "myapex",
  5086. key: "myapex.key",
  5087. native_shared_libs: ["libfoo"],
  5088. updatable: false,
  5089. }
  5090. apex_key {
  5091. name: "myapex.key",
  5092. public_key: "testkey.avbpubkey",
  5093. private_key: "testkey.pem",
  5094. }
  5095. apex {
  5096. name: "otherapex",
  5097. key: "myapex.key",
  5098. native_shared_libs: ["libfoo"],
  5099. updatable: false,
  5100. }
  5101. cc_defaults {
  5102. name: "libfoo-defaults",
  5103. apex_available: ["otherapex"],
  5104. }
  5105. cc_library {
  5106. name: "libfoo",
  5107. defaults: ["libfoo-defaults"],
  5108. stl: "none",
  5109. system_shared_libs: [],
  5110. }`)
  5111. }
  5112. func TestApexAvailable_DirectDep(t *testing.T) {
  5113. // libfoo is not available to myapex, but only to otherapex
  5114. testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
  5115. apex {
  5116. name: "myapex",
  5117. key: "myapex.key",
  5118. native_shared_libs: ["libfoo"],
  5119. updatable: false,
  5120. }
  5121. apex_key {
  5122. name: "myapex.key",
  5123. public_key: "testkey.avbpubkey",
  5124. private_key: "testkey.pem",
  5125. }
  5126. apex {
  5127. name: "otherapex",
  5128. key: "otherapex.key",
  5129. native_shared_libs: ["libfoo"],
  5130. updatable: false,
  5131. }
  5132. apex_key {
  5133. name: "otherapex.key",
  5134. public_key: "testkey.avbpubkey",
  5135. private_key: "testkey.pem",
  5136. }
  5137. cc_library {
  5138. name: "libfoo",
  5139. stl: "none",
  5140. system_shared_libs: [],
  5141. apex_available: ["otherapex"],
  5142. }`)
  5143. }
  5144. func TestApexAvailable_IndirectDep(t *testing.T) {
  5145. // libbbaz is an indirect dep
  5146. testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
  5147. .*via tag apex\.dependencyTag.*name:sharedLib.*
  5148. .*-> libfoo.*link:shared.*
  5149. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5150. .*-> libbar.*link:shared.*
  5151. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5152. .*-> libbaz.*link:shared.*`, `
  5153. apex {
  5154. name: "myapex",
  5155. key: "myapex.key",
  5156. native_shared_libs: ["libfoo"],
  5157. updatable: false,
  5158. }
  5159. apex_key {
  5160. name: "myapex.key",
  5161. public_key: "testkey.avbpubkey",
  5162. private_key: "testkey.pem",
  5163. }
  5164. cc_library {
  5165. name: "libfoo",
  5166. stl: "none",
  5167. shared_libs: ["libbar"],
  5168. system_shared_libs: [],
  5169. apex_available: ["myapex"],
  5170. }
  5171. cc_library {
  5172. name: "libbar",
  5173. stl: "none",
  5174. shared_libs: ["libbaz"],
  5175. system_shared_libs: [],
  5176. apex_available: ["myapex"],
  5177. }
  5178. cc_library {
  5179. name: "libbaz",
  5180. stl: "none",
  5181. system_shared_libs: [],
  5182. }`)
  5183. }
  5184. func TestApexAvailable_InvalidApexName(t *testing.T) {
  5185. testApexError(t, "\"otherapex\" is not a valid module name", `
  5186. apex {
  5187. name: "myapex",
  5188. key: "myapex.key",
  5189. native_shared_libs: ["libfoo"],
  5190. updatable: false,
  5191. }
  5192. apex_key {
  5193. name: "myapex.key",
  5194. public_key: "testkey.avbpubkey",
  5195. private_key: "testkey.pem",
  5196. }
  5197. cc_library {
  5198. name: "libfoo",
  5199. stl: "none",
  5200. system_shared_libs: [],
  5201. apex_available: ["otherapex"],
  5202. }`)
  5203. testApex(t, `
  5204. apex {
  5205. name: "myapex",
  5206. key: "myapex.key",
  5207. native_shared_libs: ["libfoo", "libbar"],
  5208. updatable: false,
  5209. }
  5210. apex_key {
  5211. name: "myapex.key",
  5212. public_key: "testkey.avbpubkey",
  5213. private_key: "testkey.pem",
  5214. }
  5215. cc_library {
  5216. name: "libfoo",
  5217. stl: "none",
  5218. system_shared_libs: [],
  5219. runtime_libs: ["libbaz"],
  5220. apex_available: ["myapex"],
  5221. }
  5222. cc_library {
  5223. name: "libbar",
  5224. stl: "none",
  5225. system_shared_libs: [],
  5226. apex_available: ["//apex_available:anyapex"],
  5227. }
  5228. cc_library {
  5229. name: "libbaz",
  5230. stl: "none",
  5231. system_shared_libs: [],
  5232. stubs: {
  5233. versions: ["10", "20", "30"],
  5234. },
  5235. }`)
  5236. }
  5237. func TestApexAvailable_CheckForPlatform(t *testing.T) {
  5238. ctx := testApex(t, `
  5239. apex {
  5240. name: "myapex",
  5241. key: "myapex.key",
  5242. native_shared_libs: ["libbar", "libbaz"],
  5243. updatable: false,
  5244. }
  5245. apex_key {
  5246. name: "myapex.key",
  5247. public_key: "testkey.avbpubkey",
  5248. private_key: "testkey.pem",
  5249. }
  5250. cc_library {
  5251. name: "libfoo",
  5252. stl: "none",
  5253. system_shared_libs: [],
  5254. shared_libs: ["libbar"],
  5255. apex_available: ["//apex_available:platform"],
  5256. }
  5257. cc_library {
  5258. name: "libfoo2",
  5259. stl: "none",
  5260. system_shared_libs: [],
  5261. shared_libs: ["libbaz"],
  5262. apex_available: ["//apex_available:platform"],
  5263. }
  5264. cc_library {
  5265. name: "libbar",
  5266. stl: "none",
  5267. system_shared_libs: [],
  5268. apex_available: ["myapex"],
  5269. }
  5270. cc_library {
  5271. name: "libbaz",
  5272. stl: "none",
  5273. system_shared_libs: [],
  5274. apex_available: ["myapex"],
  5275. stubs: {
  5276. versions: ["1"],
  5277. },
  5278. }`)
  5279. // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
  5280. // because it depends on libbar which isn't available to platform
  5281. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5282. if libfoo.NotAvailableForPlatform() != true {
  5283. t.Errorf("%q shouldn't be available to platform", libfoo.String())
  5284. }
  5285. // libfoo2 however can be available to platform because it depends on libbaz which provides
  5286. // stubs
  5287. libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5288. if libfoo2.NotAvailableForPlatform() == true {
  5289. t.Errorf("%q should be available to platform", libfoo2.String())
  5290. }
  5291. }
  5292. func TestApexAvailable_CreatedForApex(t *testing.T) {
  5293. ctx := testApex(t, `
  5294. apex {
  5295. name: "myapex",
  5296. key: "myapex.key",
  5297. native_shared_libs: ["libfoo"],
  5298. updatable: false,
  5299. }
  5300. apex_key {
  5301. name: "myapex.key",
  5302. public_key: "testkey.avbpubkey",
  5303. private_key: "testkey.pem",
  5304. }
  5305. cc_library {
  5306. name: "libfoo",
  5307. stl: "none",
  5308. system_shared_libs: [],
  5309. apex_available: ["myapex"],
  5310. static: {
  5311. apex_available: ["//apex_available:platform"],
  5312. },
  5313. }`)
  5314. libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5315. if libfooShared.NotAvailableForPlatform() != true {
  5316. t.Errorf("%q shouldn't be available to platform", libfooShared.String())
  5317. }
  5318. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
  5319. if libfooStatic.NotAvailableForPlatform() != false {
  5320. t.Errorf("%q should be available to platform", libfooStatic.String())
  5321. }
  5322. }
  5323. func TestOverrideApex(t *testing.T) {
  5324. ctx := testApex(t, `
  5325. apex {
  5326. name: "myapex",
  5327. key: "myapex.key",
  5328. apps: ["app"],
  5329. bpfs: ["bpf"],
  5330. prebuilts: ["myetc"],
  5331. overrides: ["oldapex"],
  5332. updatable: false,
  5333. }
  5334. override_apex {
  5335. name: "override_myapex",
  5336. base: "myapex",
  5337. apps: ["override_app"],
  5338. bpfs: ["override_bpf"],
  5339. prebuilts: ["override_myetc"],
  5340. overrides: ["unknownapex"],
  5341. logging_parent: "com.foo.bar",
  5342. package_name: "test.overridden.package",
  5343. key: "mynewapex.key",
  5344. certificate: ":myapex.certificate",
  5345. }
  5346. apex_key {
  5347. name: "myapex.key",
  5348. public_key: "testkey.avbpubkey",
  5349. private_key: "testkey.pem",
  5350. }
  5351. apex_key {
  5352. name: "mynewapex.key",
  5353. public_key: "testkey2.avbpubkey",
  5354. private_key: "testkey2.pem",
  5355. }
  5356. android_app_certificate {
  5357. name: "myapex.certificate",
  5358. certificate: "testkey",
  5359. }
  5360. android_app {
  5361. name: "app",
  5362. srcs: ["foo/bar/MyClass.java"],
  5363. package_name: "foo",
  5364. sdk_version: "none",
  5365. system_modules: "none",
  5366. apex_available: [ "myapex" ],
  5367. }
  5368. override_android_app {
  5369. name: "override_app",
  5370. base: "app",
  5371. package_name: "bar",
  5372. }
  5373. bpf {
  5374. name: "bpf",
  5375. srcs: ["bpf.c"],
  5376. }
  5377. bpf {
  5378. name: "override_bpf",
  5379. srcs: ["override_bpf.c"],
  5380. }
  5381. prebuilt_etc {
  5382. name: "myetc",
  5383. src: "myprebuilt",
  5384. }
  5385. prebuilt_etc {
  5386. name: "override_myetc",
  5387. src: "override_myprebuilt",
  5388. }
  5389. `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
  5390. originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
  5391. overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
  5392. if originalVariant.GetOverriddenBy() != "" {
  5393. t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
  5394. }
  5395. if overriddenVariant.GetOverriddenBy() != "override_myapex" {
  5396. t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
  5397. }
  5398. module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
  5399. apexRule := module.Rule("apexRule")
  5400. copyCmds := apexRule.Args["copy_commands"]
  5401. ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
  5402. ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
  5403. ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
  5404. ensureContains(t, copyCmds, "image.apex/etc/bpf/override_bpf.o")
  5405. ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
  5406. ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
  5407. apexBundle := module.Module().(*apexBundle)
  5408. name := apexBundle.Name()
  5409. if name != "override_myapex" {
  5410. t.Errorf("name should be \"override_myapex\", but was %q", name)
  5411. }
  5412. if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
  5413. t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
  5414. }
  5415. optFlags := apexRule.Args["opt_flags"]
  5416. ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
  5417. ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
  5418. signApkRule := module.Rule("signapk")
  5419. ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
  5420. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5421. var builder strings.Builder
  5422. data.Custom(&builder, name, "TARGET_", "", data)
  5423. androidMk := builder.String()
  5424. ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
  5425. ensureContains(t, androidMk, "LOCAL_MODULE := override_bpf.o.override_myapex")
  5426. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
  5427. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
  5428. ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
  5429. ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
  5430. ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
  5431. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
  5432. ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
  5433. ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
  5434. }
  5435. func TestLegacyAndroid10Support(t *testing.T) {
  5436. ctx := testApex(t, `
  5437. apex {
  5438. name: "myapex",
  5439. key: "myapex.key",
  5440. native_shared_libs: ["mylib"],
  5441. min_sdk_version: "29",
  5442. }
  5443. apex_key {
  5444. name: "myapex.key",
  5445. public_key: "testkey.avbpubkey",
  5446. private_key: "testkey.pem",
  5447. }
  5448. cc_library {
  5449. name: "mylib",
  5450. srcs: ["mylib.cpp"],
  5451. stl: "libc++",
  5452. system_shared_libs: [],
  5453. apex_available: [ "myapex" ],
  5454. min_sdk_version: "29",
  5455. }
  5456. `, withUnbundledBuild)
  5457. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5458. args := module.Rule("apexRule").Args
  5459. ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
  5460. ensureNotContains(t, args["opt_flags"], "--no_hashtree")
  5461. // The copies of the libraries in the apex should have one more dependency than
  5462. // the ones outside the apex, namely the unwinder. Ideally we should check
  5463. // the dependency names directly here but for some reason the names are blank in
  5464. // this test.
  5465. for _, lib := range []string{"libc++", "mylib"} {
  5466. apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
  5467. nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
  5468. if len(apexImplicits) != len(nonApexImplicits)+1 {
  5469. t.Errorf("%q missing unwinder dep", lib)
  5470. }
  5471. }
  5472. }
  5473. var filesForSdkLibrary = android.MockFS{
  5474. "api/current.txt": nil,
  5475. "api/removed.txt": nil,
  5476. "api/system-current.txt": nil,
  5477. "api/system-removed.txt": nil,
  5478. "api/test-current.txt": nil,
  5479. "api/test-removed.txt": nil,
  5480. "100/public/api/foo.txt": nil,
  5481. "100/public/api/foo-removed.txt": nil,
  5482. "100/system/api/foo.txt": nil,
  5483. "100/system/api/foo-removed.txt": nil,
  5484. // For java_sdk_library_import
  5485. "a.jar": nil,
  5486. }
  5487. func TestJavaSDKLibrary(t *testing.T) {
  5488. ctx := testApex(t, `
  5489. apex {
  5490. name: "myapex",
  5491. key: "myapex.key",
  5492. java_libs: ["foo"],
  5493. updatable: false,
  5494. }
  5495. apex_key {
  5496. name: "myapex.key",
  5497. public_key: "testkey.avbpubkey",
  5498. private_key: "testkey.pem",
  5499. }
  5500. java_sdk_library {
  5501. name: "foo",
  5502. srcs: ["a.java"],
  5503. api_packages: ["foo"],
  5504. apex_available: [ "myapex" ],
  5505. }
  5506. prebuilt_apis {
  5507. name: "sdk",
  5508. api_dirs: ["100"],
  5509. }
  5510. `, withFiles(filesForSdkLibrary))
  5511. // java_sdk_library installs both impl jar and permission XML
  5512. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5513. "javalib/foo.jar",
  5514. "etc/permissions/foo.xml",
  5515. })
  5516. // Permission XML should point to the activated path of impl jar of java_sdk_library
  5517. sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
  5518. ensureMatches(t, sdkLibrary.RuleParams.Command, `<library\\n\s+name=\\\"foo\\\"\\n\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"`)
  5519. }
  5520. func TestJavaSDKLibrary_WithinApex(t *testing.T) {
  5521. ctx := testApex(t, `
  5522. apex {
  5523. name: "myapex",
  5524. key: "myapex.key",
  5525. java_libs: ["foo", "bar"],
  5526. updatable: false,
  5527. }
  5528. apex_key {
  5529. name: "myapex.key",
  5530. public_key: "testkey.avbpubkey",
  5531. private_key: "testkey.pem",
  5532. }
  5533. java_sdk_library {
  5534. name: "foo",
  5535. srcs: ["a.java"],
  5536. api_packages: ["foo"],
  5537. apex_available: ["myapex"],
  5538. sdk_version: "none",
  5539. system_modules: "none",
  5540. }
  5541. java_library {
  5542. name: "bar",
  5543. srcs: ["a.java"],
  5544. libs: ["foo"],
  5545. apex_available: ["myapex"],
  5546. sdk_version: "none",
  5547. system_modules: "none",
  5548. }
  5549. prebuilt_apis {
  5550. name: "sdk",
  5551. api_dirs: ["100"],
  5552. }
  5553. `, withFiles(filesForSdkLibrary))
  5554. // java_sdk_library installs both impl jar and permission XML
  5555. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5556. "javalib/bar.jar",
  5557. "javalib/foo.jar",
  5558. "etc/permissions/foo.xml",
  5559. })
  5560. // The bar library should depend on the implementation jar.
  5561. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  5562. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5563. t.Errorf("expected %q, found %#q", expected, actual)
  5564. }
  5565. }
  5566. func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
  5567. ctx := testApex(t, `
  5568. apex {
  5569. name: "myapex",
  5570. key: "myapex.key",
  5571. java_libs: ["foo"],
  5572. updatable: false,
  5573. }
  5574. apex_key {
  5575. name: "myapex.key",
  5576. public_key: "testkey.avbpubkey",
  5577. private_key: "testkey.pem",
  5578. }
  5579. java_sdk_library {
  5580. name: "foo",
  5581. srcs: ["a.java"],
  5582. api_packages: ["foo"],
  5583. apex_available: ["myapex"],
  5584. sdk_version: "none",
  5585. system_modules: "none",
  5586. }
  5587. java_library {
  5588. name: "bar",
  5589. srcs: ["a.java"],
  5590. libs: ["foo"],
  5591. sdk_version: "none",
  5592. system_modules: "none",
  5593. }
  5594. prebuilt_apis {
  5595. name: "sdk",
  5596. api_dirs: ["100"],
  5597. }
  5598. `, withFiles(filesForSdkLibrary))
  5599. // java_sdk_library installs both impl jar and permission XML
  5600. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5601. "javalib/foo.jar",
  5602. "etc/permissions/foo.xml",
  5603. })
  5604. // The bar library should depend on the stubs jar.
  5605. barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
  5606. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5607. t.Errorf("expected %q, found %#q", expected, actual)
  5608. }
  5609. }
  5610. func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
  5611. ctx := testApex(t, `
  5612. prebuilt_apis {
  5613. name: "sdk",
  5614. api_dirs: ["100"],
  5615. }`,
  5616. withFiles(map[string][]byte{
  5617. "apex/a.java": nil,
  5618. "apex/apex_manifest.json": nil,
  5619. "apex/Android.bp": []byte(`
  5620. package {
  5621. default_visibility: ["//visibility:private"],
  5622. }
  5623. apex {
  5624. name: "myapex",
  5625. key: "myapex.key",
  5626. java_libs: ["foo", "bar"],
  5627. updatable: false,
  5628. }
  5629. apex_key {
  5630. name: "myapex.key",
  5631. public_key: "testkey.avbpubkey",
  5632. private_key: "testkey.pem",
  5633. }
  5634. java_library {
  5635. name: "bar",
  5636. srcs: ["a.java"],
  5637. libs: ["foo"],
  5638. apex_available: ["myapex"],
  5639. sdk_version: "none",
  5640. system_modules: "none",
  5641. }
  5642. `),
  5643. "source/a.java": nil,
  5644. "source/api/current.txt": nil,
  5645. "source/api/removed.txt": nil,
  5646. "source/Android.bp": []byte(`
  5647. package {
  5648. default_visibility: ["//visibility:private"],
  5649. }
  5650. java_sdk_library {
  5651. name: "foo",
  5652. visibility: ["//apex"],
  5653. srcs: ["a.java"],
  5654. api_packages: ["foo"],
  5655. apex_available: ["myapex"],
  5656. sdk_version: "none",
  5657. system_modules: "none",
  5658. public: {
  5659. enabled: true,
  5660. },
  5661. }
  5662. `),
  5663. "prebuilt/a.jar": nil,
  5664. "prebuilt/Android.bp": []byte(`
  5665. package {
  5666. default_visibility: ["//visibility:private"],
  5667. }
  5668. java_sdk_library_import {
  5669. name: "foo",
  5670. visibility: ["//apex", "//source"],
  5671. apex_available: ["myapex"],
  5672. prefer: true,
  5673. public: {
  5674. jars: ["a.jar"],
  5675. },
  5676. }
  5677. `),
  5678. }), withFiles(filesForSdkLibrary),
  5679. )
  5680. // java_sdk_library installs both impl jar and permission XML
  5681. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5682. "javalib/bar.jar",
  5683. "javalib/foo.jar",
  5684. "etc/permissions/foo.xml",
  5685. })
  5686. // The bar library should depend on the implementation jar.
  5687. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  5688. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5689. t.Errorf("expected %q, found %#q", expected, actual)
  5690. }
  5691. }
  5692. func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
  5693. testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
  5694. apex {
  5695. name: "myapex",
  5696. key: "myapex.key",
  5697. java_libs: ["foo"],
  5698. updatable: false,
  5699. }
  5700. apex_key {
  5701. name: "myapex.key",
  5702. public_key: "testkey.avbpubkey",
  5703. private_key: "testkey.pem",
  5704. }
  5705. java_sdk_library_import {
  5706. name: "foo",
  5707. apex_available: ["myapex"],
  5708. prefer: true,
  5709. public: {
  5710. jars: ["a.jar"],
  5711. },
  5712. }
  5713. `, withFiles(filesForSdkLibrary))
  5714. }
  5715. func TestCompatConfig(t *testing.T) {
  5716. result := android.GroupFixturePreparers(
  5717. prepareForApexTest,
  5718. java.PrepareForTestWithPlatformCompatConfig,
  5719. ).RunTestWithBp(t, `
  5720. apex {
  5721. name: "myapex",
  5722. key: "myapex.key",
  5723. compat_configs: ["myjar-platform-compat-config"],
  5724. java_libs: ["myjar"],
  5725. updatable: false,
  5726. }
  5727. apex_key {
  5728. name: "myapex.key",
  5729. public_key: "testkey.avbpubkey",
  5730. private_key: "testkey.pem",
  5731. }
  5732. platform_compat_config {
  5733. name: "myjar-platform-compat-config",
  5734. src: ":myjar",
  5735. }
  5736. java_library {
  5737. name: "myjar",
  5738. srcs: ["foo/bar/MyClass.java"],
  5739. sdk_version: "none",
  5740. system_modules: "none",
  5741. apex_available: [ "myapex" ],
  5742. }
  5743. // Make sure that a preferred prebuilt does not affect the apex contents.
  5744. prebuilt_platform_compat_config {
  5745. name: "myjar-platform-compat-config",
  5746. metadata: "compat-config/metadata.xml",
  5747. prefer: true,
  5748. }
  5749. `)
  5750. ctx := result.TestContext
  5751. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5752. "etc/compatconfig/myjar-platform-compat-config.xml",
  5753. "javalib/myjar.jar",
  5754. })
  5755. }
  5756. func TestRejectNonInstallableJavaLibrary(t *testing.T) {
  5757. testApexError(t, `"myjar" is not configured to be compiled into dex`, `
  5758. apex {
  5759. name: "myapex",
  5760. key: "myapex.key",
  5761. java_libs: ["myjar"],
  5762. updatable: false,
  5763. }
  5764. apex_key {
  5765. name: "myapex.key",
  5766. public_key: "testkey.avbpubkey",
  5767. private_key: "testkey.pem",
  5768. }
  5769. java_library {
  5770. name: "myjar",
  5771. srcs: ["foo/bar/MyClass.java"],
  5772. sdk_version: "none",
  5773. system_modules: "none",
  5774. compile_dex: false,
  5775. apex_available: ["myapex"],
  5776. }
  5777. `)
  5778. }
  5779. func TestCarryRequiredModuleNames(t *testing.T) {
  5780. ctx := testApex(t, `
  5781. apex {
  5782. name: "myapex",
  5783. key: "myapex.key",
  5784. native_shared_libs: ["mylib"],
  5785. updatable: false,
  5786. }
  5787. apex_key {
  5788. name: "myapex.key",
  5789. public_key: "testkey.avbpubkey",
  5790. private_key: "testkey.pem",
  5791. }
  5792. cc_library {
  5793. name: "mylib",
  5794. srcs: ["mylib.cpp"],
  5795. system_shared_libs: [],
  5796. stl: "none",
  5797. required: ["a", "b"],
  5798. host_required: ["c", "d"],
  5799. target_required: ["e", "f"],
  5800. apex_available: [ "myapex" ],
  5801. }
  5802. `)
  5803. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5804. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5805. name := apexBundle.BaseModuleName()
  5806. prefix := "TARGET_"
  5807. var builder strings.Builder
  5808. data.Custom(&builder, name, prefix, "", data)
  5809. androidMk := builder.String()
  5810. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
  5811. ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
  5812. ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
  5813. }
  5814. func TestSymlinksFromApexToSystem(t *testing.T) {
  5815. bp := `
  5816. apex {
  5817. name: "myapex",
  5818. key: "myapex.key",
  5819. native_shared_libs: ["mylib"],
  5820. java_libs: ["myjar"],
  5821. updatable: false,
  5822. }
  5823. apex {
  5824. name: "myapex.updatable",
  5825. key: "myapex.key",
  5826. native_shared_libs: ["mylib"],
  5827. java_libs: ["myjar"],
  5828. updatable: true,
  5829. min_sdk_version: "current",
  5830. }
  5831. apex_key {
  5832. name: "myapex.key",
  5833. public_key: "testkey.avbpubkey",
  5834. private_key: "testkey.pem",
  5835. }
  5836. cc_library {
  5837. name: "mylib",
  5838. srcs: ["mylib.cpp"],
  5839. shared_libs: ["myotherlib"],
  5840. system_shared_libs: [],
  5841. stl: "none",
  5842. apex_available: [
  5843. "myapex",
  5844. "myapex.updatable",
  5845. "//apex_available:platform",
  5846. ],
  5847. min_sdk_version: "current",
  5848. }
  5849. cc_library {
  5850. name: "myotherlib",
  5851. srcs: ["mylib.cpp"],
  5852. system_shared_libs: [],
  5853. stl: "none",
  5854. apex_available: [
  5855. "myapex",
  5856. "myapex.updatable",
  5857. "//apex_available:platform",
  5858. ],
  5859. min_sdk_version: "current",
  5860. }
  5861. java_library {
  5862. name: "myjar",
  5863. srcs: ["foo/bar/MyClass.java"],
  5864. sdk_version: "none",
  5865. system_modules: "none",
  5866. libs: ["myotherjar"],
  5867. apex_available: [
  5868. "myapex",
  5869. "myapex.updatable",
  5870. "//apex_available:platform",
  5871. ],
  5872. min_sdk_version: "current",
  5873. }
  5874. java_library {
  5875. name: "myotherjar",
  5876. srcs: ["foo/bar/MyClass.java"],
  5877. sdk_version: "none",
  5878. system_modules: "none",
  5879. apex_available: [
  5880. "myapex",
  5881. "myapex.updatable",
  5882. "//apex_available:platform",
  5883. ],
  5884. min_sdk_version: "current",
  5885. }
  5886. `
  5887. ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
  5888. for _, f := range files {
  5889. if f.path == file {
  5890. if f.isLink {
  5891. t.Errorf("%q is not a real file", file)
  5892. }
  5893. return
  5894. }
  5895. }
  5896. t.Errorf("%q is not found", file)
  5897. }
  5898. ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
  5899. for _, f := range files {
  5900. if f.path == file {
  5901. if !f.isLink {
  5902. t.Errorf("%q is not a symlink", file)
  5903. }
  5904. return
  5905. }
  5906. }
  5907. t.Errorf("%q is not found", file)
  5908. }
  5909. // For unbundled build, symlink shouldn't exist regardless of whether an APEX
  5910. // is updatable or not
  5911. ctx := testApex(t, bp, withUnbundledBuild)
  5912. files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
  5913. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5914. ensureRealfileExists(t, files, "lib64/mylib.so")
  5915. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  5916. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  5917. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5918. ensureRealfileExists(t, files, "lib64/mylib.so")
  5919. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  5920. // For bundled build, symlink to the system for the non-updatable APEXes only
  5921. ctx = testApex(t, bp)
  5922. files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
  5923. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5924. ensureRealfileExists(t, files, "lib64/mylib.so")
  5925. ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
  5926. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  5927. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5928. ensureRealfileExists(t, files, "lib64/mylib.so")
  5929. ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
  5930. }
  5931. func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
  5932. ctx := testApex(t, `
  5933. apex {
  5934. name: "myapex",
  5935. key: "myapex.key",
  5936. native_shared_libs: ["mylib"],
  5937. updatable: false,
  5938. }
  5939. apex_key {
  5940. name: "myapex.key",
  5941. public_key: "testkey.avbpubkey",
  5942. private_key: "testkey.pem",
  5943. }
  5944. cc_library_shared {
  5945. name: "mylib",
  5946. srcs: ["mylib.cpp"],
  5947. shared_libs: ["myotherlib"],
  5948. system_shared_libs: [],
  5949. stl: "none",
  5950. apex_available: [
  5951. "myapex",
  5952. "//apex_available:platform",
  5953. ],
  5954. }
  5955. cc_prebuilt_library_shared {
  5956. name: "myotherlib",
  5957. srcs: ["prebuilt.so"],
  5958. system_shared_libs: [],
  5959. stl: "none",
  5960. apex_available: [
  5961. "myapex",
  5962. "//apex_available:platform",
  5963. ],
  5964. }
  5965. `)
  5966. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5967. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5968. var builder strings.Builder
  5969. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  5970. androidMk := builder.String()
  5971. // `myotherlib` is added to `myapex` as symlink
  5972. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  5973. ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
  5974. ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
  5975. // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
  5976. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
  5977. }
  5978. func TestApexWithJniLibs(t *testing.T) {
  5979. ctx := testApex(t, `
  5980. apex {
  5981. name: "myapex",
  5982. key: "myapex.key",
  5983. jni_libs: ["mylib"],
  5984. updatable: false,
  5985. }
  5986. apex_key {
  5987. name: "myapex.key",
  5988. public_key: "testkey.avbpubkey",
  5989. private_key: "testkey.pem",
  5990. }
  5991. cc_library {
  5992. name: "mylib",
  5993. srcs: ["mylib.cpp"],
  5994. shared_libs: ["mylib2"],
  5995. system_shared_libs: [],
  5996. stl: "none",
  5997. apex_available: [ "myapex" ],
  5998. }
  5999. cc_library {
  6000. name: "mylib2",
  6001. srcs: ["mylib.cpp"],
  6002. system_shared_libs: [],
  6003. stl: "none",
  6004. apex_available: [ "myapex" ],
  6005. }
  6006. `)
  6007. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  6008. // Notice mylib2.so (transitive dep) is not added as a jni_lib
  6009. ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
  6010. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6011. "lib64/mylib.so",
  6012. "lib64/mylib2.so",
  6013. })
  6014. }
  6015. func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
  6016. ctx := testApex(t, `
  6017. apex {
  6018. name: "myapex",
  6019. key: "myapex.key",
  6020. updatable: false,
  6021. }
  6022. apex_key {
  6023. name: "myapex.key",
  6024. public_key: "testkey.avbpubkey",
  6025. private_key: "testkey.pem",
  6026. }
  6027. `,
  6028. android.FixtureModifyConfig(func(config android.Config) {
  6029. delete(config.Targets, android.Android)
  6030. config.AndroidCommonTarget = android.Target{}
  6031. }),
  6032. )
  6033. if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
  6034. t.Errorf("Expected variants: %v, but got: %v", expected, got)
  6035. }
  6036. }
  6037. func TestAppBundle(t *testing.T) {
  6038. ctx := testApex(t, `
  6039. apex {
  6040. name: "myapex",
  6041. key: "myapex.key",
  6042. apps: ["AppFoo"],
  6043. updatable: false,
  6044. }
  6045. apex_key {
  6046. name: "myapex.key",
  6047. public_key: "testkey.avbpubkey",
  6048. private_key: "testkey.pem",
  6049. }
  6050. android_app {
  6051. name: "AppFoo",
  6052. srcs: ["foo/bar/MyClass.java"],
  6053. sdk_version: "none",
  6054. system_modules: "none",
  6055. apex_available: [ "myapex" ],
  6056. }
  6057. `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
  6058. bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
  6059. content := bundleConfigRule.Args["content"]
  6060. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6061. ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
  6062. }
  6063. func TestAppSetBundle(t *testing.T) {
  6064. ctx := testApex(t, `
  6065. apex {
  6066. name: "myapex",
  6067. key: "myapex.key",
  6068. apps: ["AppSet"],
  6069. updatable: false,
  6070. }
  6071. apex_key {
  6072. name: "myapex.key",
  6073. public_key: "testkey.avbpubkey",
  6074. private_key: "testkey.pem",
  6075. }
  6076. android_app_set {
  6077. name: "AppSet",
  6078. set: "AppSet.apks",
  6079. }`)
  6080. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  6081. bundleConfigRule := mod.Output("bundle_config.json")
  6082. content := bundleConfigRule.Args["content"]
  6083. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6084. s := mod.Rule("apexRule").Args["copy_commands"]
  6085. copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
  6086. if len(copyCmds) != 3 {
  6087. t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
  6088. }
  6089. ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
  6090. ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
  6091. ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
  6092. }
  6093. func TestAppSetBundlePrebuilt(t *testing.T) {
  6094. bp := `
  6095. apex_set {
  6096. name: "myapex",
  6097. filename: "foo_v2.apex",
  6098. sanitized: {
  6099. none: { set: "myapex.apks", },
  6100. hwaddress: { set: "myapex.hwasan.apks", },
  6101. },
  6102. }
  6103. `
  6104. ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
  6105. // Check that the extractor produces the correct output file from the correct input file.
  6106. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
  6107. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  6108. extractedApex := m.Output(extractorOutput)
  6109. android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
  6110. // Ditto for the apex.
  6111. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  6112. copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
  6113. android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
  6114. }
  6115. func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
  6116. t.Helper()
  6117. bp := `
  6118. java_library {
  6119. name: "some-updatable-apex-lib",
  6120. srcs: ["a.java"],
  6121. sdk_version: "current",
  6122. apex_available: [
  6123. "some-updatable-apex",
  6124. ],
  6125. permitted_packages: ["some.updatable.apex.lib"],
  6126. }
  6127. java_library {
  6128. name: "some-non-updatable-apex-lib",
  6129. srcs: ["a.java"],
  6130. apex_available: [
  6131. "some-non-updatable-apex",
  6132. ],
  6133. compile_dex: true,
  6134. permitted_packages: ["some.non.updatable.apex.lib"],
  6135. }
  6136. bootclasspath_fragment {
  6137. name: "some-non-updatable-fragment",
  6138. contents: ["some-non-updatable-apex-lib"],
  6139. apex_available: [
  6140. "some-non-updatable-apex",
  6141. ],
  6142. }
  6143. java_library {
  6144. name: "some-platform-lib",
  6145. srcs: ["a.java"],
  6146. sdk_version: "current",
  6147. installable: true,
  6148. }
  6149. java_library {
  6150. name: "some-art-lib",
  6151. srcs: ["a.java"],
  6152. sdk_version: "current",
  6153. apex_available: [
  6154. "com.android.art.debug",
  6155. ],
  6156. hostdex: true,
  6157. compile_dex: true,
  6158. }
  6159. apex {
  6160. name: "some-updatable-apex",
  6161. key: "some-updatable-apex.key",
  6162. java_libs: ["some-updatable-apex-lib"],
  6163. updatable: true,
  6164. min_sdk_version: "current",
  6165. }
  6166. apex {
  6167. name: "some-non-updatable-apex",
  6168. key: "some-non-updatable-apex.key",
  6169. bootclasspath_fragments: ["some-non-updatable-fragment"],
  6170. updatable: false,
  6171. }
  6172. apex_key {
  6173. name: "some-updatable-apex.key",
  6174. }
  6175. apex_key {
  6176. name: "some-non-updatable-apex.key",
  6177. }
  6178. apex {
  6179. name: "com.android.art.debug",
  6180. key: "com.android.art.debug.key",
  6181. bootclasspath_fragments: ["art-bootclasspath-fragment"],
  6182. updatable: true,
  6183. min_sdk_version: "current",
  6184. }
  6185. bootclasspath_fragment {
  6186. name: "art-bootclasspath-fragment",
  6187. image_name: "art",
  6188. contents: ["some-art-lib"],
  6189. apex_available: [
  6190. "com.android.art.debug",
  6191. ],
  6192. }
  6193. apex_key {
  6194. name: "com.android.art.debug.key",
  6195. }
  6196. filegroup {
  6197. name: "some-updatable-apex-file_contexts",
  6198. srcs: [
  6199. "system/sepolicy/apex/some-updatable-apex-file_contexts",
  6200. ],
  6201. }
  6202. filegroup {
  6203. name: "some-non-updatable-apex-file_contexts",
  6204. srcs: [
  6205. "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
  6206. ],
  6207. }
  6208. `
  6209. testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
  6210. }
  6211. func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
  6212. t.Helper()
  6213. fs := android.MockFS{
  6214. "a.java": nil,
  6215. "a.jar": nil,
  6216. "apex_manifest.json": nil,
  6217. "AndroidManifest.xml": nil,
  6218. "system/sepolicy/apex/myapex-file_contexts": nil,
  6219. "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
  6220. "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
  6221. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  6222. "framework/aidl/a.aidl": nil,
  6223. }
  6224. errorHandler := android.FixtureExpectsNoErrors
  6225. if errmsg != "" {
  6226. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  6227. }
  6228. result := android.GroupFixturePreparers(
  6229. cc.PrepareForTestWithCcDefaultModules,
  6230. java.PrepareForTestWithHiddenApiBuildComponents,
  6231. java.PrepareForTestWithJavaDefaultModules,
  6232. java.PrepareForTestWithJavaSdkLibraryFiles,
  6233. PrepareForTestWithApexBuildComponents,
  6234. preparer,
  6235. fs.AddToFixture(),
  6236. android.FixtureModifyMockFS(func(fs android.MockFS) {
  6237. if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
  6238. insert := ""
  6239. for _, fragment := range fragments {
  6240. insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
  6241. }
  6242. fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
  6243. platform_bootclasspath {
  6244. name: "platform-bootclasspath",
  6245. fragments: [
  6246. %s
  6247. ],
  6248. }
  6249. `, insert))
  6250. }
  6251. }),
  6252. dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
  6253. ).
  6254. ExtendWithErrorHandler(errorHandler).
  6255. RunTestWithBp(t, bp)
  6256. return result.TestContext
  6257. }
  6258. func TestDuplicateDeapexeresFromPrebuiltApexes(t *testing.T) {
  6259. preparers := android.GroupFixturePreparers(
  6260. java.PrepareForTestWithJavaDefaultModules,
  6261. PrepareForTestWithApexBuildComponents,
  6262. ).
  6263. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  6264. "Multiple installable prebuilt APEXes provide ambiguous deapexers: com.android.myapex and com.mycompany.android.myapex"))
  6265. bpBase := `
  6266. apex_set {
  6267. name: "com.android.myapex",
  6268. installable: true,
  6269. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6270. set: "myapex.apks",
  6271. }
  6272. apex_set {
  6273. name: "com.mycompany.android.myapex",
  6274. apex_name: "com.android.myapex",
  6275. installable: true,
  6276. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6277. set: "company-myapex.apks",
  6278. }
  6279. prebuilt_bootclasspath_fragment {
  6280. name: "my-bootclasspath-fragment",
  6281. apex_available: ["com.android.myapex"],
  6282. %s
  6283. }
  6284. `
  6285. t.Run("java_import", func(t *testing.T) {
  6286. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6287. java_import {
  6288. name: "libfoo",
  6289. jars: ["libfoo.jar"],
  6290. apex_available: ["com.android.myapex"],
  6291. }
  6292. `)
  6293. })
  6294. t.Run("java_sdk_library_import", func(t *testing.T) {
  6295. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6296. java_sdk_library_import {
  6297. name: "libfoo",
  6298. public: {
  6299. jars: ["libbar.jar"],
  6300. },
  6301. apex_available: ["com.android.myapex"],
  6302. }
  6303. `)
  6304. })
  6305. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  6306. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  6307. image_name: "art",
  6308. contents: ["libfoo"],
  6309. `)+`
  6310. java_sdk_library_import {
  6311. name: "libfoo",
  6312. public: {
  6313. jars: ["libbar.jar"],
  6314. },
  6315. apex_available: ["com.android.myapex"],
  6316. }
  6317. `)
  6318. })
  6319. }
  6320. func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
  6321. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6322. apex {
  6323. name: "myapex",
  6324. key: "myapex.key",
  6325. updatable: true,
  6326. }
  6327. apex_key {
  6328. name: "myapex.key",
  6329. public_key: "testkey.avbpubkey",
  6330. private_key: "testkey.pem",
  6331. }
  6332. `)
  6333. }
  6334. func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
  6335. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6336. apex {
  6337. name: "myapex",
  6338. key: "myapex.key",
  6339. }
  6340. apex_key {
  6341. name: "myapex.key",
  6342. public_key: "testkey.avbpubkey",
  6343. private_key: "testkey.pem",
  6344. }
  6345. `)
  6346. }
  6347. func TestUpdatable_cannot_be_vendor_apex(t *testing.T) {
  6348. testApexError(t, `"myapex" .*: updatable: vendor APEXes are not updatable`, `
  6349. apex {
  6350. name: "myapex",
  6351. key: "myapex.key",
  6352. updatable: true,
  6353. soc_specific: true,
  6354. }
  6355. apex_key {
  6356. name: "myapex.key",
  6357. public_key: "testkey.avbpubkey",
  6358. private_key: "testkey.pem",
  6359. }
  6360. `)
  6361. }
  6362. func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
  6363. testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
  6364. apex {
  6365. name: "myapex",
  6366. key: "myapex.key",
  6367. systemserverclasspath_fragments: [
  6368. "mysystemserverclasspathfragment",
  6369. ],
  6370. min_sdk_version: "29",
  6371. updatable: true,
  6372. }
  6373. apex_key {
  6374. name: "myapex.key",
  6375. public_key: "testkey.avbpubkey",
  6376. private_key: "testkey.pem",
  6377. }
  6378. java_library {
  6379. name: "foo",
  6380. srcs: ["b.java"],
  6381. min_sdk_version: "29",
  6382. installable: true,
  6383. apex_available: [
  6384. "myapex",
  6385. ],
  6386. }
  6387. systemserverclasspath_fragment {
  6388. name: "mysystemserverclasspathfragment",
  6389. generate_classpaths_proto: false,
  6390. contents: [
  6391. "foo",
  6392. ],
  6393. apex_available: [
  6394. "myapex",
  6395. ],
  6396. }
  6397. `,
  6398. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  6399. )
  6400. }
  6401. func TestNoUpdatableJarsInBootImage(t *testing.T) {
  6402. // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
  6403. // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
  6404. // modules to be included in the BootJars.
  6405. prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
  6406. return android.GroupFixturePreparers(
  6407. dexpreopt.FixtureSetBootJars(bootJars...),
  6408. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6409. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  6410. }),
  6411. )
  6412. }
  6413. // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
  6414. // same value. This can result in an invalid configuration as it allows non art apex jars to be
  6415. // specified in the ArtApexJars configuration.
  6416. prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
  6417. return android.GroupFixturePreparers(
  6418. dexpreopt.FixtureSetArtBootJars(bootJars...),
  6419. dexpreopt.FixtureSetBootJars(bootJars...),
  6420. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6421. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  6422. }),
  6423. )
  6424. }
  6425. t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
  6426. preparer := android.GroupFixturePreparers(
  6427. java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"),
  6428. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6429. )
  6430. fragments := []java.ApexVariantReference{
  6431. {
  6432. Apex: proptools.StringPtr("com.android.art.debug"),
  6433. Module: proptools.StringPtr("art-bootclasspath-fragment"),
  6434. },
  6435. {
  6436. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6437. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6438. },
  6439. }
  6440. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  6441. })
  6442. t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
  6443. err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
  6444. // Update the dexpreopt BootJars directly.
  6445. preparer := android.GroupFixturePreparers(
  6446. prepareSetBootJars("com.android.art.debug:some-art-lib"),
  6447. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6448. )
  6449. testNoUpdatableJarsInBootImage(t, err, preparer)
  6450. })
  6451. t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  6452. err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  6453. // Update the dexpreopt ArtApexJars directly.
  6454. preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
  6455. testNoUpdatableJarsInBootImage(t, err, preparer)
  6456. })
  6457. t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  6458. err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  6459. // Update the dexpreopt ArtApexJars directly.
  6460. preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  6461. testNoUpdatableJarsInBootImage(t, err, preparer)
  6462. })
  6463. t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
  6464. err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
  6465. preparer := android.GroupFixturePreparers(
  6466. java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"),
  6467. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6468. )
  6469. testNoUpdatableJarsInBootImage(t, err, preparer)
  6470. })
  6471. t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
  6472. preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  6473. fragment := java.ApexVariantReference{
  6474. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6475. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6476. }
  6477. testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
  6478. })
  6479. t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
  6480. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  6481. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  6482. testNoUpdatableJarsInBootImage(t, err, preparer)
  6483. })
  6484. t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
  6485. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  6486. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  6487. testNoUpdatableJarsInBootImage(t, err, preparer)
  6488. })
  6489. t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
  6490. err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
  6491. // Update the dexpreopt ArtApexJars directly.
  6492. preparer := prepareSetArtJars("platform:some-platform-lib")
  6493. testNoUpdatableJarsInBootImage(t, err, preparer)
  6494. })
  6495. t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
  6496. preparer := android.GroupFixturePreparers(
  6497. java.FixtureConfigureBootJars("platform:some-platform-lib"),
  6498. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6499. )
  6500. fragments := []java.ApexVariantReference{
  6501. {
  6502. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6503. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6504. },
  6505. }
  6506. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  6507. })
  6508. }
  6509. func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
  6510. preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
  6511. t.Run("prebuilt no source", func(t *testing.T) {
  6512. fragment := java.ApexVariantReference{
  6513. Apex: proptools.StringPtr("myapex"),
  6514. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  6515. }
  6516. testDexpreoptWithApexes(t, `
  6517. prebuilt_apex {
  6518. name: "myapex" ,
  6519. arch: {
  6520. arm64: {
  6521. src: "myapex-arm64.apex",
  6522. },
  6523. arm: {
  6524. src: "myapex-arm.apex",
  6525. },
  6526. },
  6527. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6528. }
  6529. prebuilt_bootclasspath_fragment {
  6530. name: "my-bootclasspath-fragment",
  6531. contents: ["libfoo"],
  6532. apex_available: ["myapex"],
  6533. hidden_api: {
  6534. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  6535. metadata: "my-bootclasspath-fragment/metadata.csv",
  6536. index: "my-bootclasspath-fragment/index.csv",
  6537. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  6538. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  6539. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  6540. },
  6541. }
  6542. java_import {
  6543. name: "libfoo",
  6544. jars: ["libfoo.jar"],
  6545. apex_available: ["myapex"],
  6546. permitted_packages: ["libfoo"],
  6547. }
  6548. `, "", preparer, fragment)
  6549. })
  6550. }
  6551. func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
  6552. t.Helper()
  6553. bp += `
  6554. apex_key {
  6555. name: "myapex.key",
  6556. public_key: "testkey.avbpubkey",
  6557. private_key: "testkey.pem",
  6558. }`
  6559. fs := android.MockFS{
  6560. "lib1/src/A.java": nil,
  6561. "lib2/src/B.java": nil,
  6562. "system/sepolicy/apex/myapex-file_contexts": nil,
  6563. }
  6564. errorHandler := android.FixtureExpectsNoErrors
  6565. if errmsg != "" {
  6566. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  6567. }
  6568. android.GroupFixturePreparers(
  6569. android.PrepareForTestWithAndroidBuildComponents,
  6570. java.PrepareForTestWithJavaBuildComponents,
  6571. PrepareForTestWithApexBuildComponents,
  6572. android.PrepareForTestWithNeverallowRules(rules),
  6573. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6574. apexBootJars := make([]string, 0, len(bootJars))
  6575. for _, apexBootJar := range bootJars {
  6576. apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
  6577. }
  6578. variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
  6579. }),
  6580. fs.AddToFixture(),
  6581. ).
  6582. ExtendWithErrorHandler(errorHandler).
  6583. RunTestWithBp(t, bp)
  6584. }
  6585. func TestApexPermittedPackagesRules(t *testing.T) {
  6586. testcases := []struct {
  6587. name string
  6588. expectedError string
  6589. bp string
  6590. bootJars []string
  6591. modulesPackages map[string][]string
  6592. }{
  6593. {
  6594. name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
  6595. expectedError: "",
  6596. bp: `
  6597. java_library {
  6598. name: "bcp_lib1",
  6599. srcs: ["lib1/src/*.java"],
  6600. permitted_packages: ["foo.bar"],
  6601. apex_available: ["myapex"],
  6602. sdk_version: "none",
  6603. system_modules: "none",
  6604. min_sdk_version: "30",
  6605. }
  6606. java_library {
  6607. name: "nonbcp_lib2",
  6608. srcs: ["lib2/src/*.java"],
  6609. apex_available: ["myapex"],
  6610. permitted_packages: ["a.b"],
  6611. sdk_version: "none",
  6612. system_modules: "none",
  6613. min_sdk_version: "30",
  6614. }
  6615. apex {
  6616. name: "myapex",
  6617. min_sdk_version: "30",
  6618. key: "myapex.key",
  6619. java_libs: ["bcp_lib1", "nonbcp_lib2"],
  6620. updatable: false,
  6621. }`,
  6622. bootJars: []string{"bcp_lib1"},
  6623. modulesPackages: map[string][]string{
  6624. "myapex": []string{
  6625. "foo.bar",
  6626. },
  6627. },
  6628. },
  6629. {
  6630. name: "Bootclasspath apex jar not satisfying allowed module packages on Q.",
  6631. expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar with min_sdk < T. Please jarjar or move code around.`,
  6632. bp: `
  6633. java_library {
  6634. name: "bcp_lib1",
  6635. srcs: ["lib1/src/*.java"],
  6636. apex_available: ["myapex"],
  6637. permitted_packages: ["foo.bar"],
  6638. sdk_version: "none",
  6639. system_modules: "none",
  6640. min_sdk_version: "29",
  6641. }
  6642. java_library {
  6643. name: "bcp_lib2",
  6644. srcs: ["lib2/src/*.java"],
  6645. apex_available: ["myapex"],
  6646. permitted_packages: ["foo.bar", "bar.baz"],
  6647. sdk_version: "none",
  6648. system_modules: "none",
  6649. min_sdk_version: "29",
  6650. }
  6651. apex {
  6652. name: "myapex",
  6653. min_sdk_version: "29",
  6654. key: "myapex.key",
  6655. java_libs: ["bcp_lib1", "bcp_lib2"],
  6656. updatable: false,
  6657. }
  6658. `,
  6659. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  6660. modulesPackages: map[string][]string{
  6661. "myapex": []string{
  6662. "foo.bar",
  6663. },
  6664. },
  6665. },
  6666. {
  6667. name: "Bootclasspath apex jar not satisfying allowed module packages on R.",
  6668. expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar with min_sdk < T. Please jarjar or move code around.`,
  6669. bp: `
  6670. java_library {
  6671. name: "bcp_lib1",
  6672. srcs: ["lib1/src/*.java"],
  6673. apex_available: ["myapex"],
  6674. permitted_packages: ["foo.bar"],
  6675. sdk_version: "none",
  6676. system_modules: "none",
  6677. min_sdk_version: "30",
  6678. }
  6679. java_library {
  6680. name: "bcp_lib2",
  6681. srcs: ["lib2/src/*.java"],
  6682. apex_available: ["myapex"],
  6683. permitted_packages: ["foo.bar", "bar.baz"],
  6684. sdk_version: "none",
  6685. system_modules: "none",
  6686. min_sdk_version: "30",
  6687. }
  6688. apex {
  6689. name: "myapex",
  6690. min_sdk_version: "30",
  6691. key: "myapex.key",
  6692. java_libs: ["bcp_lib1", "bcp_lib2"],
  6693. updatable: false,
  6694. }
  6695. `,
  6696. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  6697. modulesPackages: map[string][]string{
  6698. "myapex": []string{
  6699. "foo.bar",
  6700. },
  6701. },
  6702. },
  6703. {
  6704. name: "Bootclasspath apex jar >= T not satisfying Q/R/S allowed module packages.",
  6705. expectedError: "",
  6706. bp: `
  6707. java_library {
  6708. name: "bcp_lib1",
  6709. srcs: ["lib1/src/*.java"],
  6710. apex_available: ["myapex"],
  6711. permitted_packages: ["foo.bar"],
  6712. sdk_version: "none",
  6713. system_modules: "none",
  6714. min_sdk_version: "current",
  6715. }
  6716. java_library {
  6717. name: "bcp_lib2",
  6718. srcs: ["lib2/src/*.java"],
  6719. apex_available: ["myapex"],
  6720. permitted_packages: ["foo.bar", "bar.baz"],
  6721. sdk_version: "none",
  6722. system_modules: "none",
  6723. min_sdk_version: "current",
  6724. }
  6725. apex {
  6726. name: "myapex",
  6727. min_sdk_version: "current",
  6728. key: "myapex.key",
  6729. java_libs: ["bcp_lib1", "bcp_lib2"],
  6730. updatable: false,
  6731. }
  6732. `,
  6733. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  6734. modulesPackages: map[string][]string{
  6735. "myapex": []string{
  6736. "foo.bar",
  6737. },
  6738. },
  6739. },
  6740. }
  6741. for _, tc := range testcases {
  6742. t.Run(tc.name, func(t *testing.T) {
  6743. rules := createApexPermittedPackagesRules(tc.modulesPackages)
  6744. testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
  6745. })
  6746. }
  6747. }
  6748. func TestTestFor(t *testing.T) {
  6749. ctx := testApex(t, `
  6750. apex {
  6751. name: "myapex",
  6752. key: "myapex.key",
  6753. native_shared_libs: ["mylib", "myprivlib"],
  6754. updatable: false,
  6755. }
  6756. apex_key {
  6757. name: "myapex.key",
  6758. public_key: "testkey.avbpubkey",
  6759. private_key: "testkey.pem",
  6760. }
  6761. cc_library {
  6762. name: "mylib",
  6763. srcs: ["mylib.cpp"],
  6764. system_shared_libs: [],
  6765. stl: "none",
  6766. stubs: {
  6767. versions: ["1"],
  6768. },
  6769. apex_available: ["myapex"],
  6770. }
  6771. cc_library {
  6772. name: "myprivlib",
  6773. srcs: ["mylib.cpp"],
  6774. system_shared_libs: [],
  6775. stl: "none",
  6776. apex_available: ["myapex"],
  6777. }
  6778. cc_test {
  6779. name: "mytest",
  6780. gtest: false,
  6781. srcs: ["mylib.cpp"],
  6782. system_shared_libs: [],
  6783. stl: "none",
  6784. shared_libs: ["mylib", "myprivlib", "mytestlib"],
  6785. test_for: ["myapex"]
  6786. }
  6787. cc_library {
  6788. name: "mytestlib",
  6789. srcs: ["mylib.cpp"],
  6790. system_shared_libs: [],
  6791. shared_libs: ["mylib", "myprivlib"],
  6792. stl: "none",
  6793. test_for: ["myapex"],
  6794. }
  6795. cc_benchmark {
  6796. name: "mybench",
  6797. srcs: ["mylib.cpp"],
  6798. system_shared_libs: [],
  6799. shared_libs: ["mylib", "myprivlib"],
  6800. stl: "none",
  6801. test_for: ["myapex"],
  6802. }
  6803. `)
  6804. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  6805. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  6806. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  6807. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  6808. }
  6809. // These modules are tests for the apex, therefore are linked to the
  6810. // actual implementation of mylib instead of its stub.
  6811. ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6812. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6813. ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6814. }
  6815. func TestIndirectTestFor(t *testing.T) {
  6816. ctx := testApex(t, `
  6817. apex {
  6818. name: "myapex",
  6819. key: "myapex.key",
  6820. native_shared_libs: ["mylib", "myprivlib"],
  6821. updatable: false,
  6822. }
  6823. apex_key {
  6824. name: "myapex.key",
  6825. public_key: "testkey.avbpubkey",
  6826. private_key: "testkey.pem",
  6827. }
  6828. cc_library {
  6829. name: "mylib",
  6830. srcs: ["mylib.cpp"],
  6831. system_shared_libs: [],
  6832. stl: "none",
  6833. stubs: {
  6834. versions: ["1"],
  6835. },
  6836. apex_available: ["myapex"],
  6837. }
  6838. cc_library {
  6839. name: "myprivlib",
  6840. srcs: ["mylib.cpp"],
  6841. system_shared_libs: [],
  6842. stl: "none",
  6843. shared_libs: ["mylib"],
  6844. apex_available: ["myapex"],
  6845. }
  6846. cc_library {
  6847. name: "mytestlib",
  6848. srcs: ["mylib.cpp"],
  6849. system_shared_libs: [],
  6850. shared_libs: ["myprivlib"],
  6851. stl: "none",
  6852. test_for: ["myapex"],
  6853. }
  6854. `)
  6855. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  6856. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  6857. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  6858. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  6859. }
  6860. // The platform variant of mytestlib links to the platform variant of the
  6861. // internal myprivlib.
  6862. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
  6863. // The platform variant of myprivlib links to the platform variant of mylib
  6864. // and bypasses its stubs.
  6865. ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6866. }
  6867. func TestTestForForLibInOtherApex(t *testing.T) {
  6868. // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
  6869. _ = testApex(t, `
  6870. apex {
  6871. name: "com.android.art",
  6872. key: "myapex.key",
  6873. native_shared_libs: ["mylib"],
  6874. updatable: false,
  6875. }
  6876. apex {
  6877. name: "com.android.art.debug",
  6878. key: "myapex.key",
  6879. native_shared_libs: ["mylib", "mytestlib"],
  6880. updatable: false,
  6881. }
  6882. apex_key {
  6883. name: "myapex.key",
  6884. public_key: "testkey.avbpubkey",
  6885. private_key: "testkey.pem",
  6886. }
  6887. cc_library {
  6888. name: "mylib",
  6889. srcs: ["mylib.cpp"],
  6890. system_shared_libs: [],
  6891. stl: "none",
  6892. stubs: {
  6893. versions: ["1"],
  6894. },
  6895. apex_available: ["com.android.art", "com.android.art.debug"],
  6896. }
  6897. cc_library {
  6898. name: "mytestlib",
  6899. srcs: ["mylib.cpp"],
  6900. system_shared_libs: [],
  6901. shared_libs: ["mylib"],
  6902. stl: "none",
  6903. apex_available: ["com.android.art.debug"],
  6904. test_for: ["com.android.art"],
  6905. }
  6906. `,
  6907. android.MockFS{
  6908. "system/sepolicy/apex/com.android.art-file_contexts": nil,
  6909. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  6910. }.AddToFixture())
  6911. }
  6912. // TODO(jungjw): Move this to proptools
  6913. func intPtr(i int) *int {
  6914. return &i
  6915. }
  6916. func TestApexSet(t *testing.T) {
  6917. ctx := testApex(t, `
  6918. apex_set {
  6919. name: "myapex",
  6920. set: "myapex.apks",
  6921. filename: "foo_v2.apex",
  6922. overrides: ["foo"],
  6923. }
  6924. `,
  6925. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6926. variables.Platform_sdk_version = intPtr(30)
  6927. }),
  6928. android.FixtureModifyConfig(func(config android.Config) {
  6929. config.Targets[android.Android] = []android.Target{
  6930. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
  6931. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
  6932. }
  6933. }),
  6934. )
  6935. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  6936. // Check extract_apks tool parameters.
  6937. extractedApex := m.Output("extracted/myapex.apks")
  6938. actual := extractedApex.Args["abis"]
  6939. expected := "ARMEABI_V7A,ARM64_V8A"
  6940. if actual != expected {
  6941. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  6942. }
  6943. actual = extractedApex.Args["sdk-version"]
  6944. expected = "30"
  6945. if actual != expected {
  6946. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  6947. }
  6948. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  6949. a := m.Module().(*ApexSet)
  6950. expectedOverrides := []string{"foo"}
  6951. actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  6952. if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
  6953. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
  6954. }
  6955. }
  6956. func TestNoStaticLinkingToStubsLib(t *testing.T) {
  6957. testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
  6958. apex {
  6959. name: "myapex",
  6960. key: "myapex.key",
  6961. native_shared_libs: ["mylib"],
  6962. updatable: false,
  6963. }
  6964. apex_key {
  6965. name: "myapex.key",
  6966. public_key: "testkey.avbpubkey",
  6967. private_key: "testkey.pem",
  6968. }
  6969. cc_library {
  6970. name: "mylib",
  6971. srcs: ["mylib.cpp"],
  6972. static_libs: ["otherlib"],
  6973. system_shared_libs: [],
  6974. stl: "none",
  6975. apex_available: [ "myapex" ],
  6976. }
  6977. cc_library {
  6978. name: "otherlib",
  6979. srcs: ["mylib.cpp"],
  6980. system_shared_libs: [],
  6981. stl: "none",
  6982. stubs: {
  6983. versions: ["1", "2", "3"],
  6984. },
  6985. apex_available: [ "myapex" ],
  6986. }
  6987. `)
  6988. }
  6989. func TestApexKeysTxt(t *testing.T) {
  6990. ctx := testApex(t, `
  6991. apex {
  6992. name: "myapex",
  6993. key: "myapex.key",
  6994. updatable: false,
  6995. custom_sign_tool: "sign_myapex",
  6996. }
  6997. apex_key {
  6998. name: "myapex.key",
  6999. public_key: "testkey.avbpubkey",
  7000. private_key: "testkey.pem",
  7001. }
  7002. `)
  7003. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7004. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7005. ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system_ext" sign_tool="sign_myapex"`)
  7006. }
  7007. func TestApexKeysTxtOverrides(t *testing.T) {
  7008. ctx := testApex(t, `
  7009. apex {
  7010. name: "myapex",
  7011. key: "myapex.key",
  7012. updatable: false,
  7013. custom_sign_tool: "sign_myapex",
  7014. }
  7015. apex_key {
  7016. name: "myapex.key",
  7017. public_key: "testkey.avbpubkey",
  7018. private_key: "testkey.pem",
  7019. }
  7020. prebuilt_apex {
  7021. name: "myapex",
  7022. prefer: true,
  7023. arch: {
  7024. arm64: {
  7025. src: "myapex-arm64.apex",
  7026. },
  7027. arm: {
  7028. src: "myapex-arm.apex",
  7029. },
  7030. },
  7031. }
  7032. apex_set {
  7033. name: "myapex_set",
  7034. set: "myapex.apks",
  7035. filename: "myapex_set.apex",
  7036. overrides: ["myapex"],
  7037. }
  7038. `)
  7039. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7040. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7041. ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7042. ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7043. }
  7044. func TestAllowedFiles(t *testing.T) {
  7045. ctx := testApex(t, `
  7046. apex {
  7047. name: "myapex",
  7048. key: "myapex.key",
  7049. apps: ["app"],
  7050. allowed_files: "allowed.txt",
  7051. updatable: false,
  7052. }
  7053. apex_key {
  7054. name: "myapex.key",
  7055. public_key: "testkey.avbpubkey",
  7056. private_key: "testkey.pem",
  7057. }
  7058. android_app {
  7059. name: "app",
  7060. srcs: ["foo/bar/MyClass.java"],
  7061. package_name: "foo",
  7062. sdk_version: "none",
  7063. system_modules: "none",
  7064. apex_available: [ "myapex" ],
  7065. }
  7066. `, withFiles(map[string][]byte{
  7067. "sub/Android.bp": []byte(`
  7068. override_apex {
  7069. name: "override_myapex",
  7070. base: "myapex",
  7071. apps: ["override_app"],
  7072. allowed_files: ":allowed",
  7073. }
  7074. // Overridable "path" property should be referenced indirectly
  7075. filegroup {
  7076. name: "allowed",
  7077. srcs: ["allowed.txt"],
  7078. }
  7079. override_android_app {
  7080. name: "override_app",
  7081. base: "app",
  7082. package_name: "bar",
  7083. }
  7084. `),
  7085. }))
  7086. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
  7087. if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
  7088. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7089. }
  7090. rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
  7091. if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
  7092. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7093. }
  7094. }
  7095. func TestNonPreferredPrebuiltDependency(t *testing.T) {
  7096. testApex(t, `
  7097. apex {
  7098. name: "myapex",
  7099. key: "myapex.key",
  7100. native_shared_libs: ["mylib"],
  7101. updatable: false,
  7102. }
  7103. apex_key {
  7104. name: "myapex.key",
  7105. public_key: "testkey.avbpubkey",
  7106. private_key: "testkey.pem",
  7107. }
  7108. cc_library {
  7109. name: "mylib",
  7110. srcs: ["mylib.cpp"],
  7111. stubs: {
  7112. versions: ["current"],
  7113. },
  7114. apex_available: ["myapex"],
  7115. }
  7116. cc_prebuilt_library_shared {
  7117. name: "mylib",
  7118. prefer: false,
  7119. srcs: ["prebuilt.so"],
  7120. stubs: {
  7121. versions: ["current"],
  7122. },
  7123. apex_available: ["myapex"],
  7124. }
  7125. `)
  7126. }
  7127. func TestCompressedApex(t *testing.T) {
  7128. ctx := testApex(t, `
  7129. apex {
  7130. name: "myapex",
  7131. key: "myapex.key",
  7132. compressible: true,
  7133. updatable: false,
  7134. }
  7135. apex_key {
  7136. name: "myapex.key",
  7137. public_key: "testkey.avbpubkey",
  7138. private_key: "testkey.pem",
  7139. }
  7140. `,
  7141. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7142. variables.CompressedApex = proptools.BoolPtr(true)
  7143. }),
  7144. )
  7145. compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
  7146. ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
  7147. signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
  7148. ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
  7149. // Make sure output of bundle is .capex
  7150. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7151. ensureContains(t, ab.outputFile.String(), "myapex.capex")
  7152. // Verify android.mk rules
  7153. data := android.AndroidMkDataForTest(t, ctx, ab)
  7154. var builder strings.Builder
  7155. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7156. androidMk := builder.String()
  7157. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
  7158. }
  7159. func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
  7160. ctx := testApex(t, `
  7161. apex {
  7162. name: "myapex",
  7163. key: "myapex.key",
  7164. native_shared_libs: ["mylib"],
  7165. updatable: false,
  7166. }
  7167. apex_key {
  7168. name: "myapex.key",
  7169. public_key: "testkey.avbpubkey",
  7170. private_key: "testkey.pem",
  7171. }
  7172. cc_library {
  7173. name: "mylib",
  7174. srcs: ["mylib.cpp"],
  7175. apex_available: ["myapex"],
  7176. shared_libs: ["otherlib"],
  7177. system_shared_libs: [],
  7178. }
  7179. cc_library {
  7180. name: "otherlib",
  7181. srcs: ["mylib.cpp"],
  7182. stubs: {
  7183. versions: ["current"],
  7184. },
  7185. }
  7186. cc_prebuilt_library_shared {
  7187. name: "otherlib",
  7188. prefer: true,
  7189. srcs: ["prebuilt.so"],
  7190. stubs: {
  7191. versions: ["current"],
  7192. },
  7193. }
  7194. `)
  7195. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7196. data := android.AndroidMkDataForTest(t, ctx, ab)
  7197. var builder strings.Builder
  7198. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7199. androidMk := builder.String()
  7200. // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
  7201. // a thing there.
  7202. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
  7203. }
  7204. func TestExcludeDependency(t *testing.T) {
  7205. ctx := testApex(t, `
  7206. apex {
  7207. name: "myapex",
  7208. key: "myapex.key",
  7209. native_shared_libs: ["mylib"],
  7210. updatable: false,
  7211. }
  7212. apex_key {
  7213. name: "myapex.key",
  7214. public_key: "testkey.avbpubkey",
  7215. private_key: "testkey.pem",
  7216. }
  7217. cc_library {
  7218. name: "mylib",
  7219. srcs: ["mylib.cpp"],
  7220. system_shared_libs: [],
  7221. stl: "none",
  7222. apex_available: ["myapex"],
  7223. shared_libs: ["mylib2"],
  7224. target: {
  7225. apex: {
  7226. exclude_shared_libs: ["mylib2"],
  7227. },
  7228. },
  7229. }
  7230. cc_library {
  7231. name: "mylib2",
  7232. srcs: ["mylib.cpp"],
  7233. system_shared_libs: [],
  7234. stl: "none",
  7235. }
  7236. `)
  7237. // Check if mylib is linked to mylib2 for the non-apex target
  7238. ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  7239. ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  7240. // Make sure that the link doesn't occur for the apex target
  7241. ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  7242. ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
  7243. // It shouldn't appear in the copy cmd as well.
  7244. copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
  7245. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  7246. }
  7247. func TestPrebuiltStubLibDep(t *testing.T) {
  7248. bpBase := `
  7249. apex {
  7250. name: "myapex",
  7251. key: "myapex.key",
  7252. native_shared_libs: ["mylib"],
  7253. updatable: false,
  7254. }
  7255. apex_key {
  7256. name: "myapex.key",
  7257. public_key: "testkey.avbpubkey",
  7258. private_key: "testkey.pem",
  7259. }
  7260. cc_library {
  7261. name: "mylib",
  7262. srcs: ["mylib.cpp"],
  7263. apex_available: ["myapex"],
  7264. shared_libs: ["stublib"],
  7265. system_shared_libs: [],
  7266. }
  7267. apex {
  7268. name: "otherapex",
  7269. enabled: %s,
  7270. key: "myapex.key",
  7271. native_shared_libs: ["stublib"],
  7272. updatable: false,
  7273. }
  7274. `
  7275. stublibSourceBp := `
  7276. cc_library {
  7277. name: "stublib",
  7278. srcs: ["mylib.cpp"],
  7279. apex_available: ["otherapex"],
  7280. system_shared_libs: [],
  7281. stl: "none",
  7282. stubs: {
  7283. versions: ["1"],
  7284. },
  7285. }
  7286. `
  7287. stublibPrebuiltBp := `
  7288. cc_prebuilt_library_shared {
  7289. name: "stublib",
  7290. srcs: ["prebuilt.so"],
  7291. apex_available: ["otherapex"],
  7292. stubs: {
  7293. versions: ["1"],
  7294. },
  7295. %s
  7296. }
  7297. `
  7298. tests := []struct {
  7299. name string
  7300. stublibBp string
  7301. usePrebuilt bool
  7302. modNames []string // Modules to collect AndroidMkEntries for
  7303. otherApexEnabled []string
  7304. }{
  7305. {
  7306. name: "only_source",
  7307. stublibBp: stublibSourceBp,
  7308. usePrebuilt: false,
  7309. modNames: []string{"stublib"},
  7310. otherApexEnabled: []string{"true", "false"},
  7311. },
  7312. {
  7313. name: "source_preferred",
  7314. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
  7315. usePrebuilt: false,
  7316. modNames: []string{"stublib", "prebuilt_stublib"},
  7317. otherApexEnabled: []string{"true", "false"},
  7318. },
  7319. {
  7320. name: "prebuilt_preferred",
  7321. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
  7322. usePrebuilt: true,
  7323. modNames: []string{"stublib", "prebuilt_stublib"},
  7324. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7325. },
  7326. {
  7327. name: "only_prebuilt",
  7328. stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
  7329. usePrebuilt: true,
  7330. modNames: []string{"stublib"},
  7331. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7332. },
  7333. }
  7334. for _, test := range tests {
  7335. t.Run(test.name, func(t *testing.T) {
  7336. for _, otherApexEnabled := range test.otherApexEnabled {
  7337. t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
  7338. ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
  7339. type modAndMkEntries struct {
  7340. mod *cc.Module
  7341. mkEntries android.AndroidMkEntries
  7342. }
  7343. entries := []*modAndMkEntries{}
  7344. // Gather shared lib modules that are installable
  7345. for _, modName := range test.modNames {
  7346. for _, variant := range ctx.ModuleVariantsForTests(modName) {
  7347. if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
  7348. continue
  7349. }
  7350. mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
  7351. if !mod.Enabled() || mod.IsHideFromMake() {
  7352. continue
  7353. }
  7354. for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
  7355. if ent.Disabled {
  7356. continue
  7357. }
  7358. entries = append(entries, &modAndMkEntries{
  7359. mod: mod,
  7360. mkEntries: ent,
  7361. })
  7362. }
  7363. }
  7364. }
  7365. var entry *modAndMkEntries = nil
  7366. for _, ent := range entries {
  7367. if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
  7368. if entry != nil {
  7369. t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
  7370. } else {
  7371. entry = ent
  7372. }
  7373. }
  7374. }
  7375. if entry == nil {
  7376. t.Errorf("AndroidMk entry for \"stublib\" missing")
  7377. } else {
  7378. isPrebuilt := entry.mod.Prebuilt() != nil
  7379. if isPrebuilt != test.usePrebuilt {
  7380. t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
  7381. }
  7382. if !entry.mod.IsStubs() {
  7383. t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
  7384. }
  7385. if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
  7386. t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
  7387. }
  7388. cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  7389. expected := "-D__STUBLIB_API__=10000"
  7390. if !android.InList(expected, cflags) {
  7391. t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
  7392. }
  7393. }
  7394. })
  7395. }
  7396. })
  7397. }
  7398. }
  7399. func TestHostApexInHostOnlyBuild(t *testing.T) {
  7400. testApex(t, `
  7401. apex {
  7402. name: "myapex",
  7403. host_supported: true,
  7404. key: "myapex.key",
  7405. updatable: false,
  7406. payload_type: "zip",
  7407. }
  7408. apex_key {
  7409. name: "myapex.key",
  7410. public_key: "testkey.avbpubkey",
  7411. private_key: "testkey.pem",
  7412. }
  7413. `,
  7414. android.FixtureModifyConfig(func(config android.Config) {
  7415. // We may not have device targets in all builds, e.g. in
  7416. // prebuilts/build-tools/build-prebuilts.sh
  7417. config.Targets[android.Android] = []android.Target{}
  7418. }))
  7419. }
  7420. func TestApexJavaCoverage(t *testing.T) {
  7421. bp := `
  7422. apex {
  7423. name: "myapex",
  7424. key: "myapex.key",
  7425. java_libs: ["mylib"],
  7426. bootclasspath_fragments: ["mybootclasspathfragment"],
  7427. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  7428. updatable: false,
  7429. }
  7430. apex_key {
  7431. name: "myapex.key",
  7432. public_key: "testkey.avbpubkey",
  7433. private_key: "testkey.pem",
  7434. }
  7435. java_library {
  7436. name: "mylib",
  7437. srcs: ["mylib.java"],
  7438. apex_available: ["myapex"],
  7439. compile_dex: true,
  7440. }
  7441. bootclasspath_fragment {
  7442. name: "mybootclasspathfragment",
  7443. contents: ["mybootclasspathlib"],
  7444. apex_available: ["myapex"],
  7445. }
  7446. java_library {
  7447. name: "mybootclasspathlib",
  7448. srcs: ["mybootclasspathlib.java"],
  7449. apex_available: ["myapex"],
  7450. compile_dex: true,
  7451. }
  7452. systemserverclasspath_fragment {
  7453. name: "mysystemserverclasspathfragment",
  7454. contents: ["mysystemserverclasspathlib"],
  7455. apex_available: ["myapex"],
  7456. }
  7457. java_library {
  7458. name: "mysystemserverclasspathlib",
  7459. srcs: ["mysystemserverclasspathlib.java"],
  7460. apex_available: ["myapex"],
  7461. compile_dex: true,
  7462. }
  7463. `
  7464. result := android.GroupFixturePreparers(
  7465. PrepareForTestWithApexBuildComponents,
  7466. prepareForTestWithMyapex,
  7467. java.PrepareForTestWithJavaDefaultModules,
  7468. android.PrepareForTestWithAndroidBuildComponents,
  7469. android.FixtureWithRootAndroidBp(bp),
  7470. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  7471. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  7472. android.FixtureMergeEnv(map[string]string{
  7473. "EMMA_INSTRUMENT": "true",
  7474. }),
  7475. ).RunTest(t)
  7476. // Make sure jacoco ran on both mylib and mybootclasspathlib
  7477. if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7478. t.Errorf("Failed to find jacoco rule for mylib")
  7479. }
  7480. if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7481. t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
  7482. }
  7483. if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7484. t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
  7485. }
  7486. }
  7487. func TestProhibitStaticExecutable(t *testing.T) {
  7488. testApexError(t, `executable mybin is static`, `
  7489. apex {
  7490. name: "myapex",
  7491. key: "myapex.key",
  7492. binaries: ["mybin"],
  7493. min_sdk_version: "29",
  7494. }
  7495. apex_key {
  7496. name: "myapex.key",
  7497. public_key: "testkey.avbpubkey",
  7498. private_key: "testkey.pem",
  7499. }
  7500. cc_binary {
  7501. name: "mybin",
  7502. srcs: ["mylib.cpp"],
  7503. relative_install_path: "foo/bar",
  7504. static_executable: true,
  7505. system_shared_libs: [],
  7506. stl: "none",
  7507. apex_available: [ "myapex" ],
  7508. min_sdk_version: "29",
  7509. }
  7510. `)
  7511. testApexError(t, `executable mybin.rust is static`, `
  7512. apex {
  7513. name: "myapex",
  7514. key: "myapex.key",
  7515. binaries: ["mybin.rust"],
  7516. min_sdk_version: "29",
  7517. }
  7518. apex_key {
  7519. name: "myapex.key",
  7520. public_key: "testkey.avbpubkey",
  7521. private_key: "testkey.pem",
  7522. }
  7523. rust_binary {
  7524. name: "mybin.rust",
  7525. srcs: ["foo.rs"],
  7526. static_executable: true,
  7527. apex_available: ["myapex"],
  7528. min_sdk_version: "29",
  7529. }
  7530. `)
  7531. }
  7532. func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
  7533. ctx := testApex(t, `
  7534. apex {
  7535. name: "myapex",
  7536. key: "myapex.key",
  7537. updatable: false,
  7538. java_libs: ["foo"],
  7539. }
  7540. apex_key {
  7541. name: "myapex.key",
  7542. public_key: "testkey.avbpubkey",
  7543. private_key: "testkey.pem",
  7544. }
  7545. java_library {
  7546. name: "foo",
  7547. srcs: ["foo.java"],
  7548. apex_available: ["myapex"],
  7549. installable: true,
  7550. }
  7551. `,
  7552. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7553. )
  7554. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7555. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  7556. var builder strings.Builder
  7557. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  7558. androidMk := builder.String()
  7559. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex")
  7560. }
  7561. func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
  7562. ctx := testApex(t, `
  7563. prebuilt_apex {
  7564. name: "myapex",
  7565. arch: {
  7566. arm64: {
  7567. src: "myapex-arm64.apex",
  7568. },
  7569. arm: {
  7570. src: "myapex-arm.apex",
  7571. },
  7572. },
  7573. exported_java_libs: ["foo"],
  7574. }
  7575. java_import {
  7576. name: "foo",
  7577. jars: ["foo.jar"],
  7578. installable: true,
  7579. }
  7580. `,
  7581. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7582. )
  7583. prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  7584. entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
  7585. mainModuleEntries := entriesList[0]
  7586. android.AssertArrayString(t,
  7587. "LOCAL_REQUIRED_MODULES",
  7588. mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
  7589. []string{
  7590. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
  7591. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
  7592. })
  7593. }
  7594. func TestAndroidMk_RequiredModules(t *testing.T) {
  7595. ctx := testApex(t, `
  7596. apex {
  7597. name: "myapex",
  7598. key: "myapex.key",
  7599. updatable: false,
  7600. java_libs: ["foo"],
  7601. required: ["otherapex"],
  7602. }
  7603. apex {
  7604. name: "otherapex",
  7605. key: "myapex.key",
  7606. updatable: false,
  7607. java_libs: ["foo"],
  7608. required: ["otherapex"],
  7609. }
  7610. apex_key {
  7611. name: "myapex.key",
  7612. public_key: "testkey.avbpubkey",
  7613. private_key: "testkey.pem",
  7614. }
  7615. java_library {
  7616. name: "foo",
  7617. srcs: ["foo.java"],
  7618. apex_available: ["myapex", "otherapex"],
  7619. installable: true,
  7620. }
  7621. `)
  7622. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7623. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  7624. var builder strings.Builder
  7625. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  7626. androidMk := builder.String()
  7627. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherapex")
  7628. }
  7629. func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
  7630. preparer := android.GroupFixturePreparers(
  7631. PrepareForTestWithApexBuildComponents,
  7632. prepareForTestWithMyapex,
  7633. java.PrepareForTestWithJavaSdkLibraryFiles,
  7634. java.PrepareForTestWithJavaDefaultModules,
  7635. android.PrepareForTestWithAndroidBuildComponents,
  7636. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  7637. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  7638. )
  7639. // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
  7640. t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  7641. preparer.RunTestWithBp(t, `
  7642. apex {
  7643. name: "myapex",
  7644. key: "myapex.key",
  7645. bootclasspath_fragments: ["mybootclasspathfragment"],
  7646. min_sdk_version: "30",
  7647. updatable: false,
  7648. }
  7649. apex_key {
  7650. name: "myapex.key",
  7651. public_key: "testkey.avbpubkey",
  7652. private_key: "testkey.pem",
  7653. }
  7654. bootclasspath_fragment {
  7655. name: "mybootclasspathfragment",
  7656. contents: ["mybootclasspathlib"],
  7657. apex_available: ["myapex"],
  7658. }
  7659. java_sdk_library {
  7660. name: "mybootclasspathlib",
  7661. srcs: ["mybootclasspathlib.java"],
  7662. apex_available: ["myapex"],
  7663. compile_dex: true,
  7664. unsafe_ignore_missing_latest_api: true,
  7665. min_sdk_version: "31",
  7666. static_libs: ["util"],
  7667. }
  7668. java_library {
  7669. name: "util",
  7670. srcs: ["a.java"],
  7671. apex_available: ["myapex"],
  7672. min_sdk_version: "31",
  7673. static_libs: ["another_util"],
  7674. }
  7675. java_library {
  7676. name: "another_util",
  7677. srcs: ["a.java"],
  7678. min_sdk_version: "31",
  7679. apex_available: ["myapex"],
  7680. }
  7681. `)
  7682. })
  7683. // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
  7684. t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  7685. preparer.RunTestWithBp(t, `
  7686. apex {
  7687. name: "myapex",
  7688. key: "myapex.key",
  7689. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  7690. min_sdk_version: "30",
  7691. updatable: false,
  7692. }
  7693. apex_key {
  7694. name: "myapex.key",
  7695. public_key: "testkey.avbpubkey",
  7696. private_key: "testkey.pem",
  7697. }
  7698. systemserverclasspath_fragment {
  7699. name: "mysystemserverclasspathfragment",
  7700. contents: ["mysystemserverclasspathlib"],
  7701. apex_available: ["myapex"],
  7702. }
  7703. java_sdk_library {
  7704. name: "mysystemserverclasspathlib",
  7705. srcs: ["mysystemserverclasspathlib.java"],
  7706. apex_available: ["myapex"],
  7707. compile_dex: true,
  7708. min_sdk_version: "32",
  7709. unsafe_ignore_missing_latest_api: true,
  7710. static_libs: ["util"],
  7711. }
  7712. java_library {
  7713. name: "util",
  7714. srcs: ["a.java"],
  7715. apex_available: ["myapex"],
  7716. min_sdk_version: "31",
  7717. static_libs: ["another_util"],
  7718. }
  7719. java_library {
  7720. name: "another_util",
  7721. srcs: ["a.java"],
  7722. min_sdk_version: "31",
  7723. apex_available: ["myapex"],
  7724. }
  7725. `)
  7726. })
  7727. t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  7728. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
  7729. RunTestWithBp(t, `
  7730. apex {
  7731. name: "myapex",
  7732. key: "myapex.key",
  7733. bootclasspath_fragments: ["mybootclasspathfragment"],
  7734. min_sdk_version: "30",
  7735. updatable: false,
  7736. }
  7737. apex_key {
  7738. name: "myapex.key",
  7739. public_key: "testkey.avbpubkey",
  7740. private_key: "testkey.pem",
  7741. }
  7742. bootclasspath_fragment {
  7743. name: "mybootclasspathfragment",
  7744. contents: ["mybootclasspathlib"],
  7745. apex_available: ["myapex"],
  7746. }
  7747. java_sdk_library {
  7748. name: "mybootclasspathlib",
  7749. srcs: ["mybootclasspathlib.java"],
  7750. apex_available: ["myapex"],
  7751. compile_dex: true,
  7752. unsafe_ignore_missing_latest_api: true,
  7753. }
  7754. `)
  7755. })
  7756. t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  7757. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
  7758. RunTestWithBp(t, `
  7759. apex {
  7760. name: "myapex",
  7761. key: "myapex.key",
  7762. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  7763. min_sdk_version: "30",
  7764. updatable: false,
  7765. }
  7766. apex_key {
  7767. name: "myapex.key",
  7768. public_key: "testkey.avbpubkey",
  7769. private_key: "testkey.pem",
  7770. }
  7771. systemserverclasspath_fragment {
  7772. name: "mysystemserverclasspathfragment",
  7773. contents: ["mysystemserverclasspathlib"],
  7774. apex_available: ["myapex"],
  7775. }
  7776. java_sdk_library {
  7777. name: "mysystemserverclasspathlib",
  7778. srcs: ["mysystemserverclasspathlib.java"],
  7779. apex_available: ["myapex"],
  7780. compile_dex: true,
  7781. unsafe_ignore_missing_latest_api: true,
  7782. }
  7783. `)
  7784. })
  7785. }
  7786. func TestMain(m *testing.M) {
  7787. os.Exit(m.Run())
  7788. }