apex_test.go 196 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623562456255626562756285629563056315632563356345635563656375638563956405641564256435644564556465647564856495650565156525653565456555656565756585659566056615662566356645665566656675668566956705671567256735674567556765677567856795680568156825683568456855686568756885689569056915692569356945695569656975698569957005701570257035704570557065707570857095710571157125713571457155716571757185719572057215722572357245725572657275728572957305731573257335734573557365737573857395740574157425743574457455746574757485749575057515752575357545755575657575758575957605761576257635764576557665767576857695770577157725773577457755776577757785779578057815782578357845785578657875788578957905791579257935794579557965797579857995800580158025803580458055806580758085809581058115812581358145815581658175818581958205821582258235824582558265827582858295830583158325833583458355836583758385839584058415842584358445845584658475848584958505851585258535854585558565857585858595860586158625863586458655866586758685869587058715872587358745875587658775878587958805881588258835884588558865887588858895890589158925893589458955896589758985899590059015902590359045905590659075908590959105911591259135914591559165917591859195920592159225923592459255926592759285929593059315932593359345935593659375938593959405941594259435944594559465947594859495950595159525953595459555956595759585959596059615962596359645965596659675968596959705971597259735974597559765977597859795980598159825983598459855986598759885989599059915992599359945995599659975998599960006001600260036004600560066007600860096010601160126013601460156016601760186019602060216022602360246025602660276028602960306031603260336034603560366037603860396040604160426043604460456046604760486049605060516052605360546055605660576058605960606061606260636064606560666067606860696070607160726073607460756076607760786079608060816082608360846085608660876088608960906091609260936094609560966097609860996100610161026103610461056106610761086109611061116112611361146115611661176118611961206121612261236124612561266127612861296130613161326133613461356136613761386139614061416142614361446145614661476148614961506151615261536154615561566157615861596160616161626163616461656166616761686169617061716172617361746175617661776178617961806181618261836184618561866187618861896190619161926193619461956196619761986199620062016202620362046205620662076208620962106211621262136214621562166217621862196220622162226223622462256226622762286229623062316232623362346235623662376238623962406241624262436244624562466247624862496250625162526253625462556256625762586259626062616262626362646265626662676268626962706271627262736274627562766277627862796280628162826283628462856286628762886289629062916292629362946295629662976298629963006301630263036304630563066307630863096310631163126313631463156316631763186319632063216322632363246325632663276328632963306331633263336334633563366337633863396340634163426343634463456346634763486349635063516352635363546355635663576358635963606361636263636364636563666367636863696370637163726373637463756376637763786379638063816382638363846385638663876388638963906391639263936394639563966397639863996400640164026403640464056406640764086409641064116412641364146415641664176418641964206421642264236424642564266427642864296430643164326433643464356436643764386439644064416442644364446445644664476448644964506451645264536454645564566457645864596460646164626463646464656466646764686469647064716472647364746475647664776478647964806481648264836484648564866487648864896490649164926493649464956496649764986499650065016502650365046505650665076508650965106511651265136514651565166517651865196520652165226523652465256526652765286529653065316532653365346535653665376538653965406541654265436544654565466547654865496550655165526553655465556556655765586559656065616562656365646565656665676568656965706571657265736574657565766577657865796580658165826583658465856586658765886589659065916592659365946595659665976598659966006601660266036604660566066607660866096610661166126613661466156616661766186619662066216622662366246625662666276628662966306631663266336634663566366637663866396640664166426643664466456646664766486649665066516652665366546655665666576658665966606661666266636664666566666667666866696670667166726673667466756676667766786679668066816682668366846685668666876688668966906691669266936694669566966697669866996700670167026703670467056706670767086709671067116712671367146715671667176718671967206721672267236724672567266727672867296730673167326733673467356736673767386739674067416742674367446745674667476748674967506751675267536754675567566757675867596760676167626763676467656766676767686769677067716772677367746775677667776778677967806781678267836784678567866787678867896790679167926793679467956796679767986799680068016802680368046805680668076808680968106811681268136814681568166817681868196820682168226823682468256826682768286829683068316832683368346835683668376838683968406841684268436844684568466847684868496850685168526853685468556856685768586859686068616862686368646865686668676868686968706871687268736874687568766877687868796880688168826883688468856886688768886889689068916892689368946895689668976898689969006901690269036904690569066907690869096910691169126913691469156916691769186919692069216922692369246925692669276928692969306931693269336934693569366937693869396940694169426943694469456946694769486949695069516952695369546955695669576958695969606961696269636964696569666967696869696970697169726973697469756976697769786979698069816982698369846985698669876988698969906991699269936994699569966997699869997000700170027003700470057006700770087009701070117012701370147015701670177018701970207021702270237024702570267027702870297030703170327033703470357036703770387039704070417042704370447045704670477048704970507051705270537054705570567057705870597060706170627063706470657066706770687069707070717072707370747075707670777078707970807081708270837084708570867087708870897090709170927093709470957096709770987099710071017102710371047105710671077108710971107111711271137114711571167117711871197120712171227123712471257126712771287129713071317132713371347135713671377138713971407141714271437144714571467147714871497150715171527153715471557156715771587159716071617162716371647165716671677168716971707171717271737174717571767177717871797180718171827183718471857186718771887189719071917192719371947195719671977198719972007201720272037204720572067207720872097210721172127213721472157216721772187219722072217222722372247225722672277228722972307231723272337234723572367237723872397240724172427243724472457246724772487249725072517252725372547255725672577258725972607261726272637264726572667267726872697270727172727273727472757276727772787279728072817282728372847285728672877288728972907291729272937294729572967297729872997300730173027303730473057306730773087309731073117312731373147315731673177318731973207321732273237324732573267327732873297330733173327333733473357336733773387339734073417342734373447345734673477348734973507351735273537354735573567357735873597360736173627363736473657366736773687369737073717372737373747375737673777378737973807381738273837384738573867387738873897390739173927393739473957396739773987399740074017402740374047405740674077408740974107411741274137414741574167417741874197420742174227423742474257426742774287429743074317432743374347435743674377438743974407441744274437444
  1. // Copyright 2018 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package apex
  15. import (
  16. "fmt"
  17. "os"
  18. "path"
  19. "path/filepath"
  20. "reflect"
  21. "regexp"
  22. "sort"
  23. "strings"
  24. "testing"
  25. "github.com/google/blueprint/proptools"
  26. "android/soong/android"
  27. "android/soong/bpf"
  28. "android/soong/cc"
  29. "android/soong/dexpreopt"
  30. prebuilt_etc "android/soong/etc"
  31. "android/soong/java"
  32. "android/soong/rust"
  33. "android/soong/sh"
  34. )
  35. // names returns name list from white space separated string
  36. func names(s string) (ns []string) {
  37. for _, n := range strings.Split(s, " ") {
  38. if len(n) > 0 {
  39. ns = append(ns, n)
  40. }
  41. }
  42. return
  43. }
  44. func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
  45. t.Helper()
  46. apexFixtureFactory.Extend(preparers...).
  47. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
  48. RunTestWithBp(t, bp)
  49. }
  50. func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
  51. t.Helper()
  52. factory := apexFixtureFactory.Extend(preparers...)
  53. if bp != "" {
  54. factory = factory.Extend(android.FixtureWithRootAndroidBp(bp))
  55. }
  56. result := factory.RunTest(t)
  57. return result.TestContext
  58. }
  59. func withFiles(files android.MockFS) android.FixturePreparer {
  60. return files.AddToFixture()
  61. }
  62. func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
  63. return android.FixtureModifyConfig(func(config android.Config) {
  64. for k, v := range targets {
  65. config.Targets[k] = v
  66. }
  67. })
  68. }
  69. // withNativeBridgeTargets sets configuration with targets including:
  70. // - X86_64 (primary)
  71. // - X86 (secondary)
  72. // - Arm64 on X86_64 (native bridge)
  73. // - Arm on X86 (native bridge)
  74. var withNativeBridgeEnabled = android.FixtureModifyConfig(
  75. func(config android.Config) {
  76. config.Targets[android.Android] = []android.Target{
  77. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
  78. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  79. {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
  80. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  81. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
  82. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
  83. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  84. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
  85. }
  86. },
  87. )
  88. func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
  89. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  90. variables.ManifestPackageNameOverrides = specs
  91. })
  92. }
  93. var withBinder32bit = android.FixtureModifyProductVariables(
  94. func(variables android.FixtureProductVariables) {
  95. variables.Binder32bit = proptools.BoolPtr(true)
  96. },
  97. )
  98. var withUnbundledBuild = android.FixtureModifyProductVariables(
  99. func(variables android.FixtureProductVariables) {
  100. variables.Unbundled_build = proptools.BoolPtr(true)
  101. },
  102. )
  103. var apexFixtureFactory = android.NewFixtureFactory(
  104. nil,
  105. // General preparers in alphabetical order as test infrastructure will enforce correct
  106. // registration order.
  107. android.PrepareForTestWithAndroidBuildComponents,
  108. bpf.PrepareForTestWithBpf,
  109. cc.PrepareForTestWithCcBuildComponents,
  110. java.PrepareForTestWithJavaDefaultModules,
  111. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  112. rust.PrepareForTestWithRustDefaultModules,
  113. sh.PrepareForTestWithShBuildComponents,
  114. PrepareForTestWithApexBuildComponents,
  115. // Additional apex test specific preparers.
  116. android.FixtureAddTextFile("system/sepolicy/Android.bp", `
  117. filegroup {
  118. name: "myapex-file_contexts",
  119. srcs: [
  120. "apex/myapex-file_contexts",
  121. ],
  122. }
  123. `),
  124. prepareForTestWithMyapex,
  125. android.FixtureMergeMockFs(android.MockFS{
  126. "a.java": nil,
  127. "PrebuiltAppFoo.apk": nil,
  128. "PrebuiltAppFooPriv.apk": nil,
  129. "apex_manifest.json": nil,
  130. "AndroidManifest.xml": nil,
  131. "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
  132. "system/sepolicy/apex/myapex2-file_contexts": nil,
  133. "system/sepolicy/apex/otherapex-file_contexts": nil,
  134. "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
  135. "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
  136. "mylib.cpp": nil,
  137. "mytest.cpp": nil,
  138. "mytest1.cpp": nil,
  139. "mytest2.cpp": nil,
  140. "mytest3.cpp": nil,
  141. "myprebuilt": nil,
  142. "my_include": nil,
  143. "foo/bar/MyClass.java": nil,
  144. "prebuilt.jar": nil,
  145. "prebuilt.so": nil,
  146. "vendor/foo/devkeys/test.x509.pem": nil,
  147. "vendor/foo/devkeys/test.pk8": nil,
  148. "testkey.x509.pem": nil,
  149. "testkey.pk8": nil,
  150. "testkey.override.x509.pem": nil,
  151. "testkey.override.pk8": nil,
  152. "vendor/foo/devkeys/testkey.avbpubkey": nil,
  153. "vendor/foo/devkeys/testkey.pem": nil,
  154. "NOTICE": nil,
  155. "custom_notice": nil,
  156. "custom_notice_for_static_lib": nil,
  157. "testkey2.avbpubkey": nil,
  158. "testkey2.pem": nil,
  159. "myapex-arm64.apex": nil,
  160. "myapex-arm.apex": nil,
  161. "myapex.apks": nil,
  162. "frameworks/base/api/current.txt": nil,
  163. "framework/aidl/a.aidl": nil,
  164. "build/make/core/proguard.flags": nil,
  165. "build/make/core/proguard_basic_keeps.flags": nil,
  166. "dummy.txt": nil,
  167. "baz": nil,
  168. "bar/baz": nil,
  169. "testdata/baz": nil,
  170. "AppSet.apks": nil,
  171. "foo.rs": nil,
  172. "libfoo.jar": nil,
  173. "libbar.jar": nil,
  174. },
  175. ),
  176. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  177. variables.DeviceVndkVersion = proptools.StringPtr("current")
  178. variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
  179. variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
  180. variables.Platform_sdk_codename = proptools.StringPtr("Q")
  181. variables.Platform_sdk_final = proptools.BoolPtr(false)
  182. variables.Platform_version_active_codenames = []string{"Q"}
  183. variables.Platform_vndk_version = proptools.StringPtr("VER")
  184. }),
  185. )
  186. var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
  187. "system/sepolicy/apex/myapex-file_contexts": nil,
  188. })
  189. // ensure that 'result' equals 'expected'
  190. func ensureEquals(t *testing.T, result string, expected string) {
  191. t.Helper()
  192. if result != expected {
  193. t.Errorf("%q != %q", expected, result)
  194. }
  195. }
  196. // ensure that 'result' contains 'expected'
  197. func ensureContains(t *testing.T, result string, expected string) {
  198. t.Helper()
  199. if !strings.Contains(result, expected) {
  200. t.Errorf("%q is not found in %q", expected, result)
  201. }
  202. }
  203. // ensure that 'result' contains 'expected' exactly one time
  204. func ensureContainsOnce(t *testing.T, result string, expected string) {
  205. t.Helper()
  206. count := strings.Count(result, expected)
  207. if count != 1 {
  208. t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
  209. }
  210. }
  211. // ensures that 'result' does not contain 'notExpected'
  212. func ensureNotContains(t *testing.T, result string, notExpected string) {
  213. t.Helper()
  214. if strings.Contains(result, notExpected) {
  215. t.Errorf("%q is found in %q", notExpected, result)
  216. }
  217. }
  218. func ensureMatches(t *testing.T, result string, expectedRex string) {
  219. ok, err := regexp.MatchString(expectedRex, result)
  220. if err != nil {
  221. t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
  222. return
  223. }
  224. if !ok {
  225. t.Errorf("%s does not match regular expession %s", result, expectedRex)
  226. }
  227. }
  228. func ensureListContains(t *testing.T, result []string, expected string) {
  229. t.Helper()
  230. if !android.InList(expected, result) {
  231. t.Errorf("%q is not found in %v", expected, result)
  232. }
  233. }
  234. func ensureListNotContains(t *testing.T, result []string, notExpected string) {
  235. t.Helper()
  236. if android.InList(notExpected, result) {
  237. t.Errorf("%q is found in %v", notExpected, result)
  238. }
  239. }
  240. func ensureListEmpty(t *testing.T, result []string) {
  241. t.Helper()
  242. if len(result) > 0 {
  243. t.Errorf("%q is expected to be empty", result)
  244. }
  245. }
  246. func ensureListNotEmpty(t *testing.T, result []string) {
  247. t.Helper()
  248. if len(result) == 0 {
  249. t.Errorf("%q is expected to be not empty", result)
  250. }
  251. }
  252. // Minimal test
  253. func TestBasicApex(t *testing.T) {
  254. ctx := testApex(t, `
  255. apex_defaults {
  256. name: "myapex-defaults",
  257. manifest: ":myapex.manifest",
  258. androidManifest: ":myapex.androidmanifest",
  259. key: "myapex.key",
  260. binaries: ["foo.rust"],
  261. native_shared_libs: [
  262. "mylib",
  263. "libfoo.ffi",
  264. ],
  265. rust_dyn_libs: ["libfoo.dylib.rust"],
  266. multilib: {
  267. both: {
  268. binaries: ["foo"],
  269. }
  270. },
  271. java_libs: [
  272. "myjar",
  273. "myjar_dex",
  274. ],
  275. updatable: false,
  276. }
  277. apex {
  278. name: "myapex",
  279. defaults: ["myapex-defaults"],
  280. }
  281. apex_key {
  282. name: "myapex.key",
  283. public_key: "testkey.avbpubkey",
  284. private_key: "testkey.pem",
  285. }
  286. filegroup {
  287. name: "myapex.manifest",
  288. srcs: ["apex_manifest.json"],
  289. }
  290. filegroup {
  291. name: "myapex.androidmanifest",
  292. srcs: ["AndroidManifest.xml"],
  293. }
  294. cc_library {
  295. name: "mylib",
  296. srcs: ["mylib.cpp"],
  297. shared_libs: [
  298. "mylib2",
  299. "libbar.ffi",
  300. ],
  301. system_shared_libs: [],
  302. stl: "none",
  303. // TODO: remove //apex_available:platform
  304. apex_available: [
  305. "//apex_available:platform",
  306. "myapex",
  307. ],
  308. }
  309. cc_binary {
  310. name: "foo",
  311. srcs: ["mylib.cpp"],
  312. compile_multilib: "both",
  313. multilib: {
  314. lib32: {
  315. suffix: "32",
  316. },
  317. lib64: {
  318. suffix: "64",
  319. },
  320. },
  321. symlinks: ["foo_link_"],
  322. symlink_preferred_arch: true,
  323. system_shared_libs: [],
  324. static_executable: true,
  325. stl: "none",
  326. apex_available: [ "myapex", "com.android.gki.*" ],
  327. }
  328. rust_binary {
  329. name: "foo.rust",
  330. srcs: ["foo.rs"],
  331. rlibs: ["libfoo.rlib.rust"],
  332. dylibs: ["libfoo.dylib.rust"],
  333. apex_available: ["myapex"],
  334. }
  335. rust_library_rlib {
  336. name: "libfoo.rlib.rust",
  337. srcs: ["foo.rs"],
  338. crate_name: "foo",
  339. apex_available: ["myapex"],
  340. }
  341. rust_library_dylib {
  342. name: "libfoo.dylib.rust",
  343. srcs: ["foo.rs"],
  344. crate_name: "foo",
  345. apex_available: ["myapex"],
  346. }
  347. rust_ffi_shared {
  348. name: "libfoo.ffi",
  349. srcs: ["foo.rs"],
  350. crate_name: "foo",
  351. apex_available: ["myapex"],
  352. }
  353. rust_ffi_shared {
  354. name: "libbar.ffi",
  355. srcs: ["foo.rs"],
  356. crate_name: "bar",
  357. apex_available: ["myapex"],
  358. }
  359. apex {
  360. name: "com.android.gki.fake",
  361. binaries: ["foo"],
  362. key: "myapex.key",
  363. file_contexts: ":myapex-file_contexts",
  364. updatable: false,
  365. }
  366. cc_library_shared {
  367. name: "mylib2",
  368. srcs: ["mylib.cpp"],
  369. system_shared_libs: [],
  370. stl: "none",
  371. notice: "custom_notice",
  372. static_libs: ["libstatic"],
  373. // TODO: remove //apex_available:platform
  374. apex_available: [
  375. "//apex_available:platform",
  376. "myapex",
  377. ],
  378. }
  379. cc_prebuilt_library_shared {
  380. name: "mylib2",
  381. srcs: ["prebuilt.so"],
  382. // TODO: remove //apex_available:platform
  383. apex_available: [
  384. "//apex_available:platform",
  385. "myapex",
  386. ],
  387. }
  388. cc_library_static {
  389. name: "libstatic",
  390. srcs: ["mylib.cpp"],
  391. system_shared_libs: [],
  392. stl: "none",
  393. notice: "custom_notice_for_static_lib",
  394. // TODO: remove //apex_available:platform
  395. apex_available: [
  396. "//apex_available:platform",
  397. "myapex",
  398. ],
  399. }
  400. java_library {
  401. name: "myjar",
  402. srcs: ["foo/bar/MyClass.java"],
  403. stem: "myjar_stem",
  404. sdk_version: "none",
  405. system_modules: "none",
  406. static_libs: ["myotherjar"],
  407. libs: ["mysharedjar"],
  408. // TODO: remove //apex_available:platform
  409. apex_available: [
  410. "//apex_available:platform",
  411. "myapex",
  412. ],
  413. }
  414. dex_import {
  415. name: "myjar_dex",
  416. jars: ["prebuilt.jar"],
  417. apex_available: [
  418. "//apex_available:platform",
  419. "myapex",
  420. ],
  421. }
  422. java_library {
  423. name: "myotherjar",
  424. srcs: ["foo/bar/MyClass.java"],
  425. sdk_version: "none",
  426. system_modules: "none",
  427. // TODO: remove //apex_available:platform
  428. apex_available: [
  429. "//apex_available:platform",
  430. "myapex",
  431. ],
  432. }
  433. java_library {
  434. name: "mysharedjar",
  435. srcs: ["foo/bar/MyClass.java"],
  436. sdk_version: "none",
  437. system_modules: "none",
  438. }
  439. `)
  440. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  441. // Make sure that Android.mk is created
  442. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  443. data := android.AndroidMkDataForTest(t, ctx, ab)
  444. var builder strings.Builder
  445. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  446. androidMk := builder.String()
  447. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  448. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  449. optFlags := apexRule.Args["opt_flags"]
  450. ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
  451. // Ensure that the NOTICE output is being packaged as an asset.
  452. ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
  453. copyCmds := apexRule.Args["copy_commands"]
  454. // Ensure that main rule creates an output
  455. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  456. // Ensure that apex variant is created for the direct dep
  457. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  458. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
  459. ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
  460. ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
  461. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
  462. // Ensure that apex variant is created for the indirect dep
  463. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  464. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
  465. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
  466. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
  467. ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
  468. // Ensure that both direct and indirect deps are copied into apex
  469. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  470. ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  471. ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
  472. ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
  473. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
  474. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
  475. ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
  476. // .. but not for java libs
  477. ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
  478. ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
  479. // Ensure that the platform variant ends with _shared or _common
  480. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  481. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  482. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
  483. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
  484. ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
  485. // Ensure that dynamic dependency to java libs are not included
  486. ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
  487. // Ensure that all symlinks are present.
  488. found_foo_link_64 := false
  489. found_foo := false
  490. for _, cmd := range strings.Split(copyCmds, " && ") {
  491. if strings.HasPrefix(cmd, "ln -sfn foo64") {
  492. if strings.HasSuffix(cmd, "bin/foo") {
  493. found_foo = true
  494. } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
  495. found_foo_link_64 = true
  496. }
  497. }
  498. }
  499. good := found_foo && found_foo_link_64
  500. if !good {
  501. t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
  502. }
  503. mergeNoticesRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("mergeNoticesRule")
  504. noticeInputs := mergeNoticesRule.Inputs.Strings()
  505. if len(noticeInputs) != 3 {
  506. t.Errorf("number of input notice files: expected = 3, actual = %q", len(noticeInputs))
  507. }
  508. ensureListContains(t, noticeInputs, "NOTICE")
  509. ensureListContains(t, noticeInputs, "custom_notice")
  510. ensureListContains(t, noticeInputs, "custom_notice_for_static_lib")
  511. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  512. ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
  513. ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
  514. ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
  515. ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
  516. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  517. ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
  518. ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
  519. ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
  520. ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
  521. }
  522. func TestDefaults(t *testing.T) {
  523. ctx := testApex(t, `
  524. apex_defaults {
  525. name: "myapex-defaults",
  526. key: "myapex.key",
  527. prebuilts: ["myetc"],
  528. native_shared_libs: ["mylib"],
  529. java_libs: ["myjar"],
  530. apps: ["AppFoo"],
  531. rros: ["rro"],
  532. bpfs: ["bpf"],
  533. updatable: false,
  534. }
  535. prebuilt_etc {
  536. name: "myetc",
  537. src: "myprebuilt",
  538. }
  539. apex {
  540. name: "myapex",
  541. defaults: ["myapex-defaults"],
  542. }
  543. apex_key {
  544. name: "myapex.key",
  545. public_key: "testkey.avbpubkey",
  546. private_key: "testkey.pem",
  547. }
  548. cc_library {
  549. name: "mylib",
  550. system_shared_libs: [],
  551. stl: "none",
  552. apex_available: [ "myapex" ],
  553. }
  554. java_library {
  555. name: "myjar",
  556. srcs: ["foo/bar/MyClass.java"],
  557. sdk_version: "none",
  558. system_modules: "none",
  559. apex_available: [ "myapex" ],
  560. }
  561. android_app {
  562. name: "AppFoo",
  563. srcs: ["foo/bar/MyClass.java"],
  564. sdk_version: "none",
  565. system_modules: "none",
  566. apex_available: [ "myapex" ],
  567. }
  568. runtime_resource_overlay {
  569. name: "rro",
  570. theme: "blue",
  571. }
  572. bpf {
  573. name: "bpf",
  574. srcs: ["bpf.c", "bpf2.c"],
  575. }
  576. `)
  577. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  578. "etc/myetc",
  579. "javalib/myjar.jar",
  580. "lib64/mylib.so",
  581. "app/AppFoo/AppFoo.apk",
  582. "overlay/blue/rro.apk",
  583. "etc/bpf/bpf.o",
  584. "etc/bpf/bpf2.o",
  585. })
  586. }
  587. func TestApexManifest(t *testing.T) {
  588. ctx := testApex(t, `
  589. apex {
  590. name: "myapex",
  591. key: "myapex.key",
  592. updatable: false,
  593. }
  594. apex_key {
  595. name: "myapex.key",
  596. public_key: "testkey.avbpubkey",
  597. private_key: "testkey.pem",
  598. }
  599. `)
  600. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  601. args := module.Rule("apexRule").Args
  602. if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
  603. t.Error("manifest should be apex_manifest.pb, but " + manifest)
  604. }
  605. }
  606. func TestBasicZipApex(t *testing.T) {
  607. ctx := testApex(t, `
  608. apex {
  609. name: "myapex",
  610. key: "myapex.key",
  611. payload_type: "zip",
  612. native_shared_libs: ["mylib"],
  613. updatable: false,
  614. }
  615. apex_key {
  616. name: "myapex.key",
  617. public_key: "testkey.avbpubkey",
  618. private_key: "testkey.pem",
  619. }
  620. cc_library {
  621. name: "mylib",
  622. srcs: ["mylib.cpp"],
  623. shared_libs: ["mylib2"],
  624. system_shared_libs: [],
  625. stl: "none",
  626. apex_available: [ "myapex" ],
  627. }
  628. cc_library {
  629. name: "mylib2",
  630. srcs: ["mylib.cpp"],
  631. system_shared_libs: [],
  632. stl: "none",
  633. apex_available: [ "myapex" ],
  634. }
  635. `)
  636. zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
  637. copyCmds := zipApexRule.Args["copy_commands"]
  638. // Ensure that main rule creates an output
  639. ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
  640. // Ensure that APEX variant is created for the direct dep
  641. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  642. // Ensure that APEX variant is created for the indirect dep
  643. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  644. // Ensure that both direct and indirect deps are copied into apex
  645. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
  646. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
  647. }
  648. func TestApexWithStubs(t *testing.T) {
  649. ctx := testApex(t, `
  650. apex {
  651. name: "myapex",
  652. key: "myapex.key",
  653. native_shared_libs: ["mylib", "mylib3"],
  654. updatable: false,
  655. }
  656. apex_key {
  657. name: "myapex.key",
  658. public_key: "testkey.avbpubkey",
  659. private_key: "testkey.pem",
  660. }
  661. cc_library {
  662. name: "mylib",
  663. srcs: ["mylib.cpp"],
  664. shared_libs: ["mylib2", "mylib3"],
  665. system_shared_libs: [],
  666. stl: "none",
  667. apex_available: [ "myapex" ],
  668. }
  669. cc_library {
  670. name: "mylib2",
  671. srcs: ["mylib.cpp"],
  672. cflags: ["-include mylib.h"],
  673. system_shared_libs: [],
  674. stl: "none",
  675. stubs: {
  676. versions: ["1", "2", "3"],
  677. },
  678. }
  679. cc_library {
  680. name: "mylib3",
  681. srcs: ["mylib.cpp"],
  682. shared_libs: ["mylib4"],
  683. system_shared_libs: [],
  684. stl: "none",
  685. stubs: {
  686. versions: ["10", "11", "12"],
  687. },
  688. apex_available: [ "myapex" ],
  689. }
  690. cc_library {
  691. name: "mylib4",
  692. srcs: ["mylib.cpp"],
  693. system_shared_libs: [],
  694. stl: "none",
  695. apex_available: [ "myapex" ],
  696. }
  697. `)
  698. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  699. copyCmds := apexRule.Args["copy_commands"]
  700. // Ensure that direct non-stubs dep is always included
  701. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  702. // Ensure that indirect stubs dep is not included
  703. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  704. // Ensure that direct stubs dep is included
  705. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  706. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  707. // Ensure that mylib is linking with the latest version of stubs for mylib2
  708. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_3/mylib2.so")
  709. // ... and not linking to the non-stub (impl) variant of mylib2
  710. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  711. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  712. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
  713. // .. and not linking to the stubs variant of mylib3
  714. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
  715. // Ensure that stubs libs are built without -include flags
  716. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  717. ensureNotContains(t, mylib2Cflags, "-include ")
  718. // Ensure that genstub is invoked with --apex
  719. ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"])
  720. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  721. "lib64/mylib.so",
  722. "lib64/mylib3.so",
  723. "lib64/mylib4.so",
  724. })
  725. }
  726. func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
  727. t.Parallel()
  728. ctx := testApex(t, `
  729. apex {
  730. name: "myapex",
  731. key: "myapex.key",
  732. native_shared_libs: ["mylib", "mylib3"],
  733. min_sdk_version: "29",
  734. }
  735. apex_key {
  736. name: "myapex.key",
  737. public_key: "testkey.avbpubkey",
  738. private_key: "testkey.pem",
  739. }
  740. cc_library {
  741. name: "mylib",
  742. srcs: ["mylib.cpp"],
  743. shared_libs: ["mylib2", "mylib3"],
  744. system_shared_libs: [],
  745. stl: "none",
  746. apex_available: [ "myapex" ],
  747. min_sdk_version: "28",
  748. }
  749. cc_library {
  750. name: "mylib2",
  751. srcs: ["mylib.cpp"],
  752. cflags: ["-include mylib.h"],
  753. system_shared_libs: [],
  754. stl: "none",
  755. stubs: {
  756. versions: ["28", "29", "30", "current"],
  757. },
  758. min_sdk_version: "28",
  759. }
  760. cc_library {
  761. name: "mylib3",
  762. srcs: ["mylib.cpp"],
  763. shared_libs: ["mylib4"],
  764. system_shared_libs: [],
  765. stl: "none",
  766. stubs: {
  767. versions: ["28", "29", "30", "current"],
  768. },
  769. apex_available: [ "myapex" ],
  770. min_sdk_version: "28",
  771. }
  772. cc_library {
  773. name: "mylib4",
  774. srcs: ["mylib.cpp"],
  775. system_shared_libs: [],
  776. stl: "none",
  777. apex_available: [ "myapex" ],
  778. min_sdk_version: "28",
  779. }
  780. `)
  781. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  782. copyCmds := apexRule.Args["copy_commands"]
  783. // Ensure that direct non-stubs dep is always included
  784. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  785. // Ensure that indirect stubs dep is not included
  786. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  787. // Ensure that direct stubs dep is included
  788. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  789. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
  790. // Ensure that mylib is linking with the latest version of stub for mylib2
  791. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  792. // ... and not linking to the non-stub (impl) variant of mylib2
  793. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  794. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  795. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
  796. // .. and not linking to the stubs variant of mylib3
  797. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
  798. // Ensure that stubs libs are built without -include flags
  799. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
  800. ensureNotContains(t, mylib2Cflags, "-include ")
  801. // Ensure that genstub is invoked with --apex
  802. ensureContains(t, "--apex", ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"])
  803. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  804. "lib64/mylib.so",
  805. "lib64/mylib3.so",
  806. "lib64/mylib4.so",
  807. })
  808. }
  809. func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
  810. t.Parallel()
  811. // myapex (Z)
  812. // mylib -----------------.
  813. // |
  814. // otherapex (29) |
  815. // libstub's versions: 29 Z current
  816. // |
  817. // <platform> |
  818. // libplatform ----------------'
  819. ctx := testApex(t, `
  820. apex {
  821. name: "myapex",
  822. key: "myapex.key",
  823. native_shared_libs: ["mylib"],
  824. min_sdk_version: "Z", // non-final
  825. }
  826. cc_library {
  827. name: "mylib",
  828. srcs: ["mylib.cpp"],
  829. shared_libs: ["libstub"],
  830. apex_available: ["myapex"],
  831. min_sdk_version: "Z",
  832. }
  833. apex_key {
  834. name: "myapex.key",
  835. public_key: "testkey.avbpubkey",
  836. private_key: "testkey.pem",
  837. }
  838. apex {
  839. name: "otherapex",
  840. key: "myapex.key",
  841. native_shared_libs: ["libstub"],
  842. min_sdk_version: "29",
  843. }
  844. cc_library {
  845. name: "libstub",
  846. srcs: ["mylib.cpp"],
  847. stubs: {
  848. versions: ["29", "Z", "current"],
  849. },
  850. apex_available: ["otherapex"],
  851. min_sdk_version: "29",
  852. }
  853. // platform module depending on libstub from otherapex should use the latest stub("current")
  854. cc_library {
  855. name: "libplatform",
  856. srcs: ["mylib.cpp"],
  857. shared_libs: ["libstub"],
  858. }
  859. `,
  860. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  861. variables.Platform_sdk_codename = proptools.StringPtr("Z")
  862. variables.Platform_sdk_final = proptools.BoolPtr(false)
  863. variables.Platform_version_active_codenames = []string{"Z"}
  864. }),
  865. )
  866. // Ensure that mylib from myapex is built against the latest stub (current)
  867. mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  868. ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
  869. mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  870. ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  871. // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
  872. libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  873. ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
  874. libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  875. ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  876. }
  877. func TestApexWithExplicitStubsDependency(t *testing.T) {
  878. ctx := testApex(t, `
  879. apex {
  880. name: "myapex2",
  881. key: "myapex2.key",
  882. native_shared_libs: ["mylib"],
  883. updatable: false,
  884. }
  885. apex_key {
  886. name: "myapex2.key",
  887. public_key: "testkey.avbpubkey",
  888. private_key: "testkey.pem",
  889. }
  890. cc_library {
  891. name: "mylib",
  892. srcs: ["mylib.cpp"],
  893. shared_libs: ["libfoo#10"],
  894. static_libs: ["libbaz"],
  895. system_shared_libs: [],
  896. stl: "none",
  897. apex_available: [ "myapex2" ],
  898. }
  899. cc_library {
  900. name: "libfoo",
  901. srcs: ["mylib.cpp"],
  902. shared_libs: ["libbar"],
  903. system_shared_libs: [],
  904. stl: "none",
  905. stubs: {
  906. versions: ["10", "20", "30"],
  907. },
  908. }
  909. cc_library {
  910. name: "libbar",
  911. srcs: ["mylib.cpp"],
  912. system_shared_libs: [],
  913. stl: "none",
  914. }
  915. cc_library_static {
  916. name: "libbaz",
  917. srcs: ["mylib.cpp"],
  918. system_shared_libs: [],
  919. stl: "none",
  920. apex_available: [ "myapex2" ],
  921. }
  922. `)
  923. apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
  924. copyCmds := apexRule.Args["copy_commands"]
  925. // Ensure that direct non-stubs dep is always included
  926. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  927. // Ensure that indirect stubs dep is not included
  928. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  929. // Ensure that dependency of stubs is not included
  930. ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
  931. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  932. // Ensure that mylib is linking with version 10 of libfoo
  933. ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
  934. // ... and not linking to the non-stub (impl) variant of libfoo
  935. ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
  936. libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
  937. // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
  938. ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
  939. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  940. ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
  941. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  942. ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
  943. }
  944. func TestApexWithRuntimeLibsDependency(t *testing.T) {
  945. /*
  946. myapex
  947. |
  948. v (runtime_libs)
  949. mylib ------+------> libfoo [provides stub]
  950. |
  951. `------> libbar
  952. */
  953. ctx := testApex(t, `
  954. apex {
  955. name: "myapex",
  956. key: "myapex.key",
  957. native_shared_libs: ["mylib"],
  958. updatable: false,
  959. }
  960. apex_key {
  961. name: "myapex.key",
  962. public_key: "testkey.avbpubkey",
  963. private_key: "testkey.pem",
  964. }
  965. cc_library {
  966. name: "mylib",
  967. srcs: ["mylib.cpp"],
  968. runtime_libs: ["libfoo", "libbar"],
  969. system_shared_libs: [],
  970. stl: "none",
  971. apex_available: [ "myapex" ],
  972. }
  973. cc_library {
  974. name: "libfoo",
  975. srcs: ["mylib.cpp"],
  976. system_shared_libs: [],
  977. stl: "none",
  978. stubs: {
  979. versions: ["10", "20", "30"],
  980. },
  981. }
  982. cc_library {
  983. name: "libbar",
  984. srcs: ["mylib.cpp"],
  985. system_shared_libs: [],
  986. stl: "none",
  987. apex_available: [ "myapex" ],
  988. }
  989. `)
  990. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  991. copyCmds := apexRule.Args["copy_commands"]
  992. // Ensure that direct non-stubs dep is always included
  993. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  994. // Ensure that indirect stubs dep is not included
  995. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  996. // Ensure that runtime_libs dep in included
  997. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  998. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  999. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1000. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
  1001. }
  1002. var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
  1003. cc.PrepareForTestWithCcBuildComponents,
  1004. PrepareForTestWithApexBuildComponents,
  1005. android.FixtureAddTextFile("bionic/apex/Android.bp", `
  1006. apex {
  1007. name: "com.android.runtime",
  1008. key: "com.android.runtime.key",
  1009. native_shared_libs: ["libc"],
  1010. updatable: false,
  1011. }
  1012. apex_key {
  1013. name: "com.android.runtime.key",
  1014. public_key: "testkey.avbpubkey",
  1015. private_key: "testkey.pem",
  1016. }
  1017. `),
  1018. android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
  1019. )
  1020. func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
  1021. result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
  1022. cc_library {
  1023. name: "libc",
  1024. no_libcrt: true,
  1025. nocrt: true,
  1026. stl: "none",
  1027. system_shared_libs: [],
  1028. stubs: { versions: ["1"] },
  1029. apex_available: ["com.android.runtime"],
  1030. sanitize: {
  1031. hwaddress: true,
  1032. }
  1033. }
  1034. cc_prebuilt_library_shared {
  1035. name: "libclang_rt.hwasan-aarch64-android",
  1036. no_libcrt: true,
  1037. nocrt: true,
  1038. stl: "none",
  1039. system_shared_libs: [],
  1040. srcs: [""],
  1041. stubs: { versions: ["1"] },
  1042. sanitize: {
  1043. never: true,
  1044. },
  1045. } `)
  1046. ctx := result.TestContext
  1047. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1048. "lib64/bionic/libc.so",
  1049. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1050. })
  1051. hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
  1052. installed := hwasan.Description("install libclang_rt.hwasan")
  1053. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1054. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1055. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1056. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1057. }
  1058. func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
  1059. result := android.GroupFixturePreparers(
  1060. prepareForTestOfRuntimeApexWithHwasan,
  1061. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1062. variables.SanitizeDevice = []string{"hwaddress"}
  1063. }),
  1064. ).RunTestWithBp(t, `
  1065. cc_library {
  1066. name: "libc",
  1067. no_libcrt: true,
  1068. nocrt: true,
  1069. stl: "none",
  1070. system_shared_libs: [],
  1071. stubs: { versions: ["1"] },
  1072. apex_available: ["com.android.runtime"],
  1073. }
  1074. cc_prebuilt_library_shared {
  1075. name: "libclang_rt.hwasan-aarch64-android",
  1076. no_libcrt: true,
  1077. nocrt: true,
  1078. stl: "none",
  1079. system_shared_libs: [],
  1080. srcs: [""],
  1081. stubs: { versions: ["1"] },
  1082. sanitize: {
  1083. never: true,
  1084. },
  1085. }
  1086. `)
  1087. ctx := result.TestContext
  1088. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1089. "lib64/bionic/libc.so",
  1090. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1091. })
  1092. hwasan := ctx.ModuleForTests("libclang_rt.hwasan-aarch64-android", "android_arm64_armv8-a_shared")
  1093. installed := hwasan.Description("install libclang_rt.hwasan")
  1094. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1095. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1096. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1097. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1098. }
  1099. func TestApexDependsOnLLNDKTransitively(t *testing.T) {
  1100. testcases := []struct {
  1101. name string
  1102. minSdkVersion string
  1103. apexVariant string
  1104. shouldLink string
  1105. shouldNotLink []string
  1106. }{
  1107. {
  1108. name: "unspecified version links to the latest",
  1109. minSdkVersion: "",
  1110. apexVariant: "apex10000",
  1111. shouldLink: "30",
  1112. shouldNotLink: []string{"29"},
  1113. },
  1114. {
  1115. name: "always use the latest",
  1116. minSdkVersion: "min_sdk_version: \"29\",",
  1117. apexVariant: "apex29",
  1118. shouldLink: "30",
  1119. shouldNotLink: []string{"29"},
  1120. },
  1121. }
  1122. for _, tc := range testcases {
  1123. t.Run(tc.name, func(t *testing.T) {
  1124. ctx := testApex(t, `
  1125. apex {
  1126. name: "myapex",
  1127. key: "myapex.key",
  1128. use_vendor: true,
  1129. native_shared_libs: ["mylib"],
  1130. updatable: false,
  1131. `+tc.minSdkVersion+`
  1132. }
  1133. apex_key {
  1134. name: "myapex.key",
  1135. public_key: "testkey.avbpubkey",
  1136. private_key: "testkey.pem",
  1137. }
  1138. cc_library {
  1139. name: "mylib",
  1140. srcs: ["mylib.cpp"],
  1141. vendor_available: true,
  1142. shared_libs: ["libbar"],
  1143. system_shared_libs: [],
  1144. stl: "none",
  1145. apex_available: [ "myapex" ],
  1146. min_sdk_version: "29",
  1147. }
  1148. cc_library {
  1149. name: "libbar",
  1150. srcs: ["mylib.cpp"],
  1151. system_shared_libs: [],
  1152. stl: "none",
  1153. stubs: { versions: ["29","30"] },
  1154. llndk_stubs: "libbar.llndk",
  1155. }
  1156. llndk_library {
  1157. name: "libbar.llndk",
  1158. symbol_file: "",
  1159. }
  1160. `,
  1161. setUseVendorAllowListForTest([]string{"myapex"}),
  1162. withUnbundledBuild,
  1163. )
  1164. // Ensure that LLNDK dep is not included
  1165. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1166. "lib64/mylib.so",
  1167. })
  1168. // Ensure that LLNDK dep is required
  1169. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1170. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1171. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
  1172. mylibLdFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
  1173. ensureContains(t, mylibLdFlags, "libbar/android_vendor.VER_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
  1174. for _, ver := range tc.shouldNotLink {
  1175. ensureNotContains(t, mylibLdFlags, "libbar/android_vendor.VER_arm64_armv8-a_shared_"+ver+"/libbar.so")
  1176. }
  1177. mylibCFlags := ctx.ModuleForTests("mylib", "android_vendor.VER_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
  1178. ensureContains(t, mylibCFlags, "__LIBBAR_API__="+tc.shouldLink)
  1179. })
  1180. }
  1181. }
  1182. func TestApexWithSystemLibsStubs(t *testing.T) {
  1183. ctx := testApex(t, `
  1184. apex {
  1185. name: "myapex",
  1186. key: "myapex.key",
  1187. native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
  1188. updatable: false,
  1189. }
  1190. apex_key {
  1191. name: "myapex.key",
  1192. public_key: "testkey.avbpubkey",
  1193. private_key: "testkey.pem",
  1194. }
  1195. cc_library {
  1196. name: "mylib",
  1197. srcs: ["mylib.cpp"],
  1198. system_shared_libs: ["libc", "libm"],
  1199. shared_libs: ["libdl#27"],
  1200. stl: "none",
  1201. apex_available: [ "myapex" ],
  1202. }
  1203. cc_library_shared {
  1204. name: "mylib_shared",
  1205. srcs: ["mylib.cpp"],
  1206. shared_libs: ["libdl#27"],
  1207. stl: "none",
  1208. apex_available: [ "myapex" ],
  1209. }
  1210. cc_library {
  1211. name: "libBootstrap",
  1212. srcs: ["mylib.cpp"],
  1213. stl: "none",
  1214. bootstrap: true,
  1215. }
  1216. `)
  1217. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1218. copyCmds := apexRule.Args["copy_commands"]
  1219. // Ensure that mylib, libm, libdl are included.
  1220. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1221. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
  1222. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
  1223. // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
  1224. ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
  1225. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1226. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1227. mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
  1228. // For dependency to libc
  1229. // Ensure that mylib is linking with the latest version of stubs
  1230. ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_29/libc.so")
  1231. // ... and not linking to the non-stub (impl) variant
  1232. ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1233. // ... Cflags from stub is correctly exported to mylib
  1234. ensureContains(t, mylibCFlags, "__LIBC_API__=29")
  1235. ensureContains(t, mylibSharedCFlags, "__LIBC_API__=29")
  1236. // For dependency to libm
  1237. // Ensure that mylib is linking with the non-stub (impl) variant
  1238. ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
  1239. // ... and not linking to the stub variant
  1240. ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
  1241. // ... and is not compiling with the stub
  1242. ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
  1243. ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
  1244. // For dependency to libdl
  1245. // Ensure that mylib is linking with the specified version of stubs
  1246. ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
  1247. // ... and not linking to the other versions of stubs
  1248. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
  1249. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
  1250. // ... and not linking to the non-stub (impl) variant
  1251. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
  1252. // ... Cflags from stub is correctly exported to mylib
  1253. ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
  1254. ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
  1255. // Ensure that libBootstrap is depending on the platform variant of bionic libs
  1256. libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1257. ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1258. ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
  1259. ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
  1260. }
  1261. func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
  1262. // there are three links between liba --> libz.
  1263. // 1) myapex -> libx -> liba -> libz : this should be #30 link
  1264. // 2) otherapex -> liby -> liba -> libz : this should be #30 link
  1265. // 3) (platform) -> liba -> libz : this should be non-stub link
  1266. ctx := testApex(t, `
  1267. apex {
  1268. name: "myapex",
  1269. key: "myapex.key",
  1270. native_shared_libs: ["libx"],
  1271. min_sdk_version: "29",
  1272. }
  1273. apex {
  1274. name: "otherapex",
  1275. key: "myapex.key",
  1276. native_shared_libs: ["liby"],
  1277. min_sdk_version: "30",
  1278. }
  1279. apex_key {
  1280. name: "myapex.key",
  1281. public_key: "testkey.avbpubkey",
  1282. private_key: "testkey.pem",
  1283. }
  1284. cc_library {
  1285. name: "libx",
  1286. shared_libs: ["liba"],
  1287. system_shared_libs: [],
  1288. stl: "none",
  1289. apex_available: [ "myapex" ],
  1290. min_sdk_version: "29",
  1291. }
  1292. cc_library {
  1293. name: "liby",
  1294. shared_libs: ["liba"],
  1295. system_shared_libs: [],
  1296. stl: "none",
  1297. apex_available: [ "otherapex" ],
  1298. min_sdk_version: "29",
  1299. }
  1300. cc_library {
  1301. name: "liba",
  1302. shared_libs: ["libz"],
  1303. system_shared_libs: [],
  1304. stl: "none",
  1305. apex_available: [
  1306. "//apex_available:anyapex",
  1307. "//apex_available:platform",
  1308. ],
  1309. min_sdk_version: "29",
  1310. }
  1311. cc_library {
  1312. name: "libz",
  1313. system_shared_libs: [],
  1314. stl: "none",
  1315. stubs: {
  1316. versions: ["28", "30"],
  1317. },
  1318. }
  1319. `)
  1320. expectLink := func(from, from_variant, to, to_variant string) {
  1321. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1322. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1323. }
  1324. expectNoLink := func(from, from_variant, to, to_variant string) {
  1325. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1326. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1327. }
  1328. // platform liba is linked to non-stub version
  1329. expectLink("liba", "shared", "libz", "shared")
  1330. // liba in myapex is linked to #30
  1331. expectLink("liba", "shared_apex29", "libz", "shared_30")
  1332. expectNoLink("liba", "shared_apex29", "libz", "shared_28")
  1333. expectNoLink("liba", "shared_apex29", "libz", "shared")
  1334. // liba in otherapex is linked to #30
  1335. expectLink("liba", "shared_apex30", "libz", "shared_30")
  1336. expectNoLink("liba", "shared_apex30", "libz", "shared_28")
  1337. expectNoLink("liba", "shared_apex30", "libz", "shared")
  1338. }
  1339. func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
  1340. ctx := testApex(t, `
  1341. apex {
  1342. name: "myapex",
  1343. key: "myapex.key",
  1344. native_shared_libs: ["libx"],
  1345. min_sdk_version: "R",
  1346. }
  1347. apex_key {
  1348. name: "myapex.key",
  1349. public_key: "testkey.avbpubkey",
  1350. private_key: "testkey.pem",
  1351. }
  1352. cc_library {
  1353. name: "libx",
  1354. shared_libs: ["libz"],
  1355. system_shared_libs: [],
  1356. stl: "none",
  1357. apex_available: [ "myapex" ],
  1358. min_sdk_version: "R",
  1359. }
  1360. cc_library {
  1361. name: "libz",
  1362. system_shared_libs: [],
  1363. stl: "none",
  1364. stubs: {
  1365. versions: ["29", "R"],
  1366. },
  1367. }
  1368. `,
  1369. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1370. variables.Platform_version_active_codenames = []string{"R"}
  1371. }),
  1372. )
  1373. expectLink := func(from, from_variant, to, to_variant string) {
  1374. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1375. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1376. }
  1377. expectNoLink := func(from, from_variant, to, to_variant string) {
  1378. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1379. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1380. }
  1381. expectLink("libx", "shared_apex10000", "libz", "shared_R")
  1382. expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
  1383. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1384. }
  1385. func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
  1386. ctx := testApex(t, `
  1387. apex {
  1388. name: "myapex",
  1389. key: "myapex.key",
  1390. native_shared_libs: ["libx"],
  1391. updatable: false,
  1392. }
  1393. apex_key {
  1394. name: "myapex.key",
  1395. public_key: "testkey.avbpubkey",
  1396. private_key: "testkey.pem",
  1397. }
  1398. cc_library {
  1399. name: "libx",
  1400. shared_libs: ["libz"],
  1401. system_shared_libs: [],
  1402. stl: "none",
  1403. apex_available: [ "myapex" ],
  1404. }
  1405. cc_library {
  1406. name: "libz",
  1407. system_shared_libs: [],
  1408. stl: "none",
  1409. stubs: {
  1410. versions: ["1", "2"],
  1411. },
  1412. }
  1413. `)
  1414. expectLink := func(from, from_variant, to, to_variant string) {
  1415. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1416. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1417. }
  1418. expectNoLink := func(from, from_variant, to, to_variant string) {
  1419. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1420. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1421. }
  1422. expectLink("libx", "shared_apex10000", "libz", "shared_2")
  1423. expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
  1424. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1425. }
  1426. func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
  1427. ctx := testApex(t, `
  1428. apex {
  1429. name: "myapex",
  1430. key: "myapex.key",
  1431. native_shared_libs: ["libx"],
  1432. updatable: false,
  1433. }
  1434. apex_key {
  1435. name: "myapex.key",
  1436. public_key: "testkey.avbpubkey",
  1437. private_key: "testkey.pem",
  1438. }
  1439. cc_library {
  1440. name: "libx",
  1441. system_shared_libs: [],
  1442. stl: "none",
  1443. apex_available: [ "myapex" ],
  1444. stubs: {
  1445. versions: ["1", "2"],
  1446. },
  1447. }
  1448. cc_library {
  1449. name: "libz",
  1450. shared_libs: ["libx"],
  1451. system_shared_libs: [],
  1452. stl: "none",
  1453. }
  1454. `)
  1455. expectLink := func(from, from_variant, to, to_variant string) {
  1456. t.Helper()
  1457. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1458. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1459. }
  1460. expectNoLink := func(from, from_variant, to, to_variant string) {
  1461. t.Helper()
  1462. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1463. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1464. }
  1465. expectLink("libz", "shared", "libx", "shared_2")
  1466. expectNoLink("libz", "shared", "libz", "shared_1")
  1467. expectNoLink("libz", "shared", "libz", "shared")
  1468. }
  1469. var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
  1470. func(variables android.FixtureProductVariables) {
  1471. variables.SanitizeDevice = []string{"hwaddress"}
  1472. },
  1473. )
  1474. func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
  1475. ctx := testApex(t, `
  1476. apex {
  1477. name: "myapex",
  1478. key: "myapex.key",
  1479. native_shared_libs: ["libx"],
  1480. min_sdk_version: "29",
  1481. }
  1482. apex_key {
  1483. name: "myapex.key",
  1484. public_key: "testkey.avbpubkey",
  1485. private_key: "testkey.pem",
  1486. }
  1487. cc_library {
  1488. name: "libx",
  1489. shared_libs: ["libbar"],
  1490. apex_available: [ "myapex" ],
  1491. min_sdk_version: "29",
  1492. }
  1493. cc_library {
  1494. name: "libbar",
  1495. stubs: {
  1496. versions: ["29", "30"],
  1497. },
  1498. }
  1499. `,
  1500. prepareForTestWithSantitizeHwaddress,
  1501. )
  1502. expectLink := func(from, from_variant, to, to_variant string) {
  1503. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1504. libFlags := ld.Args["libFlags"]
  1505. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1506. }
  1507. expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_30")
  1508. }
  1509. func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
  1510. ctx := testApex(t, `
  1511. apex {
  1512. name: "myapex",
  1513. key: "myapex.key",
  1514. native_shared_libs: ["libx"],
  1515. min_sdk_version: "29",
  1516. }
  1517. apex_key {
  1518. name: "myapex.key",
  1519. public_key: "testkey.avbpubkey",
  1520. private_key: "testkey.pem",
  1521. }
  1522. cc_library {
  1523. name: "libx",
  1524. apex_available: [ "myapex" ],
  1525. min_sdk_version: "29",
  1526. }
  1527. `)
  1528. // ensure apex variant of c++ is linked with static unwinder
  1529. cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
  1530. ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1531. // note that platform variant is not.
  1532. cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  1533. ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1534. }
  1535. func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
  1536. testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
  1537. apex {
  1538. name: "myapex",
  1539. key: "myapex.key",
  1540. native_shared_libs: ["mylib"],
  1541. min_sdk_version: "29",
  1542. }
  1543. apex_key {
  1544. name: "myapex.key",
  1545. public_key: "testkey.avbpubkey",
  1546. private_key: "testkey.pem",
  1547. }
  1548. cc_library {
  1549. name: "mylib",
  1550. srcs: ["mylib.cpp"],
  1551. system_shared_libs: [],
  1552. stl: "none",
  1553. apex_available: [
  1554. "myapex",
  1555. ],
  1556. min_sdk_version: "30",
  1557. }
  1558. `)
  1559. testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
  1560. apex {
  1561. name: "myapex",
  1562. key: "myapex.key",
  1563. native_shared_libs: ["libfoo.ffi"],
  1564. min_sdk_version: "29",
  1565. }
  1566. apex_key {
  1567. name: "myapex.key",
  1568. public_key: "testkey.avbpubkey",
  1569. private_key: "testkey.pem",
  1570. }
  1571. rust_ffi_shared {
  1572. name: "libfoo.ffi",
  1573. srcs: ["foo.rs"],
  1574. crate_name: "foo",
  1575. apex_available: [
  1576. "myapex",
  1577. ],
  1578. min_sdk_version: "30",
  1579. }
  1580. `)
  1581. }
  1582. func TestApexMinSdkVersion_Okay(t *testing.T) {
  1583. testApex(t, `
  1584. apex {
  1585. name: "myapex",
  1586. key: "myapex.key",
  1587. native_shared_libs: ["libfoo"],
  1588. java_libs: ["libbar"],
  1589. min_sdk_version: "29",
  1590. }
  1591. apex_key {
  1592. name: "myapex.key",
  1593. public_key: "testkey.avbpubkey",
  1594. private_key: "testkey.pem",
  1595. }
  1596. cc_library {
  1597. name: "libfoo",
  1598. srcs: ["mylib.cpp"],
  1599. shared_libs: ["libfoo_dep"],
  1600. apex_available: ["myapex"],
  1601. min_sdk_version: "29",
  1602. }
  1603. cc_library {
  1604. name: "libfoo_dep",
  1605. srcs: ["mylib.cpp"],
  1606. apex_available: ["myapex"],
  1607. min_sdk_version: "29",
  1608. }
  1609. java_library {
  1610. name: "libbar",
  1611. sdk_version: "current",
  1612. srcs: ["a.java"],
  1613. static_libs: ["libbar_dep"],
  1614. apex_available: ["myapex"],
  1615. min_sdk_version: "29",
  1616. }
  1617. java_library {
  1618. name: "libbar_dep",
  1619. sdk_version: "current",
  1620. srcs: ["a.java"],
  1621. apex_available: ["myapex"],
  1622. min_sdk_version: "29",
  1623. }
  1624. `)
  1625. }
  1626. func TestJavaStableSdkVersion(t *testing.T) {
  1627. testCases := []struct {
  1628. name string
  1629. expectedError string
  1630. bp string
  1631. }{
  1632. {
  1633. name: "Non-updatable apex with non-stable dep",
  1634. bp: `
  1635. apex {
  1636. name: "myapex",
  1637. java_libs: ["myjar"],
  1638. key: "myapex.key",
  1639. updatable: false,
  1640. }
  1641. apex_key {
  1642. name: "myapex.key",
  1643. public_key: "testkey.avbpubkey",
  1644. private_key: "testkey.pem",
  1645. }
  1646. java_library {
  1647. name: "myjar",
  1648. srcs: ["foo/bar/MyClass.java"],
  1649. sdk_version: "test_current",
  1650. apex_available: ["myapex"],
  1651. }
  1652. `,
  1653. },
  1654. {
  1655. name: "Updatable apex with stable dep",
  1656. bp: `
  1657. apex {
  1658. name: "myapex",
  1659. java_libs: ["myjar"],
  1660. key: "myapex.key",
  1661. updatable: true,
  1662. min_sdk_version: "29",
  1663. }
  1664. apex_key {
  1665. name: "myapex.key",
  1666. public_key: "testkey.avbpubkey",
  1667. private_key: "testkey.pem",
  1668. }
  1669. java_library {
  1670. name: "myjar",
  1671. srcs: ["foo/bar/MyClass.java"],
  1672. sdk_version: "current",
  1673. apex_available: ["myapex"],
  1674. min_sdk_version: "29",
  1675. }
  1676. `,
  1677. },
  1678. {
  1679. name: "Updatable apex with non-stable dep",
  1680. expectedError: "cannot depend on \"myjar\"",
  1681. bp: `
  1682. apex {
  1683. name: "myapex",
  1684. java_libs: ["myjar"],
  1685. key: "myapex.key",
  1686. updatable: true,
  1687. }
  1688. apex_key {
  1689. name: "myapex.key",
  1690. public_key: "testkey.avbpubkey",
  1691. private_key: "testkey.pem",
  1692. }
  1693. java_library {
  1694. name: "myjar",
  1695. srcs: ["foo/bar/MyClass.java"],
  1696. sdk_version: "test_current",
  1697. apex_available: ["myapex"],
  1698. }
  1699. `,
  1700. },
  1701. {
  1702. name: "Updatable apex with non-stable transitive dep",
  1703. // This is not actually detecting that the transitive dependency is unstable, rather it is
  1704. // detecting that the transitive dependency is building against a wider API surface than the
  1705. // module that depends on it is using.
  1706. expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
  1707. bp: `
  1708. apex {
  1709. name: "myapex",
  1710. java_libs: ["myjar"],
  1711. key: "myapex.key",
  1712. updatable: true,
  1713. }
  1714. apex_key {
  1715. name: "myapex.key",
  1716. public_key: "testkey.avbpubkey",
  1717. private_key: "testkey.pem",
  1718. }
  1719. java_library {
  1720. name: "myjar",
  1721. srcs: ["foo/bar/MyClass.java"],
  1722. sdk_version: "current",
  1723. apex_available: ["myapex"],
  1724. static_libs: ["transitive-jar"],
  1725. }
  1726. java_library {
  1727. name: "transitive-jar",
  1728. srcs: ["foo/bar/MyClass.java"],
  1729. sdk_version: "core_platform",
  1730. apex_available: ["myapex"],
  1731. }
  1732. `,
  1733. },
  1734. }
  1735. for _, test := range testCases {
  1736. t.Run(test.name, func(t *testing.T) {
  1737. if test.expectedError == "" {
  1738. testApex(t, test.bp)
  1739. } else {
  1740. testApexError(t, test.expectedError, test.bp)
  1741. }
  1742. })
  1743. }
  1744. }
  1745. func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
  1746. testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
  1747. apex {
  1748. name: "myapex",
  1749. key: "myapex.key",
  1750. native_shared_libs: ["mylib"],
  1751. min_sdk_version: "29",
  1752. }
  1753. apex_key {
  1754. name: "myapex.key",
  1755. public_key: "testkey.avbpubkey",
  1756. private_key: "testkey.pem",
  1757. }
  1758. cc_library {
  1759. name: "mylib",
  1760. srcs: ["mylib.cpp"],
  1761. shared_libs: ["mylib2"],
  1762. system_shared_libs: [],
  1763. stl: "none",
  1764. apex_available: [
  1765. "myapex",
  1766. ],
  1767. min_sdk_version: "29",
  1768. }
  1769. // indirect part of the apex
  1770. cc_library {
  1771. name: "mylib2",
  1772. srcs: ["mylib.cpp"],
  1773. system_shared_libs: [],
  1774. stl: "none",
  1775. apex_available: [
  1776. "myapex",
  1777. ],
  1778. min_sdk_version: "30",
  1779. }
  1780. `)
  1781. }
  1782. func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
  1783. testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
  1784. apex {
  1785. name: "myapex",
  1786. key: "myapex.key",
  1787. apps: ["AppFoo"],
  1788. min_sdk_version: "29",
  1789. }
  1790. apex_key {
  1791. name: "myapex.key",
  1792. public_key: "testkey.avbpubkey",
  1793. private_key: "testkey.pem",
  1794. }
  1795. android_app {
  1796. name: "AppFoo",
  1797. srcs: ["foo/bar/MyClass.java"],
  1798. sdk_version: "current",
  1799. min_sdk_version: "29",
  1800. system_modules: "none",
  1801. stl: "none",
  1802. static_libs: ["bar"],
  1803. apex_available: [ "myapex" ],
  1804. }
  1805. java_library {
  1806. name: "bar",
  1807. sdk_version: "current",
  1808. srcs: ["a.java"],
  1809. apex_available: [ "myapex" ],
  1810. }
  1811. `)
  1812. }
  1813. func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
  1814. ctx := testApex(t, `
  1815. apex {
  1816. name: "myapex",
  1817. key: "myapex.key",
  1818. native_shared_libs: ["mylib"],
  1819. min_sdk_version: "29",
  1820. }
  1821. apex_key {
  1822. name: "myapex.key",
  1823. public_key: "testkey.avbpubkey",
  1824. private_key: "testkey.pem",
  1825. }
  1826. // mylib in myapex will link to mylib2#30
  1827. // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
  1828. cc_library {
  1829. name: "mylib",
  1830. srcs: ["mylib.cpp"],
  1831. shared_libs: ["mylib2"],
  1832. system_shared_libs: [],
  1833. stl: "none",
  1834. apex_available: ["myapex", "otherapex"],
  1835. min_sdk_version: "29",
  1836. }
  1837. cc_library {
  1838. name: "mylib2",
  1839. srcs: ["mylib.cpp"],
  1840. system_shared_libs: [],
  1841. stl: "none",
  1842. apex_available: ["otherapex"],
  1843. stubs: { versions: ["29", "30"] },
  1844. min_sdk_version: "30",
  1845. }
  1846. apex {
  1847. name: "otherapex",
  1848. key: "myapex.key",
  1849. native_shared_libs: ["mylib", "mylib2"],
  1850. min_sdk_version: "30",
  1851. }
  1852. `)
  1853. expectLink := func(from, from_variant, to, to_variant string) {
  1854. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1855. libFlags := ld.Args["libFlags"]
  1856. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1857. }
  1858. expectLink("mylib", "shared_apex29", "mylib2", "shared_30")
  1859. expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
  1860. }
  1861. func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
  1862. withSAsActiveCodeNames := android.FixtureModifyProductVariables(
  1863. func(variables android.FixtureProductVariables) {
  1864. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1865. variables.Platform_version_active_codenames = []string{"S"}
  1866. },
  1867. )
  1868. testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
  1869. apex {
  1870. name: "myapex",
  1871. key: "myapex.key",
  1872. native_shared_libs: ["libfoo"],
  1873. min_sdk_version: "S",
  1874. }
  1875. apex_key {
  1876. name: "myapex.key",
  1877. public_key: "testkey.avbpubkey",
  1878. private_key: "testkey.pem",
  1879. }
  1880. cc_library {
  1881. name: "libfoo",
  1882. shared_libs: ["libbar"],
  1883. apex_available: ["myapex"],
  1884. min_sdk_version: "29",
  1885. }
  1886. cc_library {
  1887. name: "libbar",
  1888. apex_available: ["myapex"],
  1889. }
  1890. `, withSAsActiveCodeNames)
  1891. }
  1892. func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
  1893. withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1894. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1895. variables.Platform_version_active_codenames = []string{"S", "T"}
  1896. })
  1897. ctx := testApex(t, `
  1898. apex {
  1899. name: "myapex",
  1900. key: "myapex.key",
  1901. native_shared_libs: ["libfoo"],
  1902. min_sdk_version: "S",
  1903. }
  1904. apex_key {
  1905. name: "myapex.key",
  1906. public_key: "testkey.avbpubkey",
  1907. private_key: "testkey.pem",
  1908. }
  1909. cc_library {
  1910. name: "libfoo",
  1911. shared_libs: ["libbar"],
  1912. apex_available: ["myapex"],
  1913. min_sdk_version: "S",
  1914. }
  1915. cc_library {
  1916. name: "libbar",
  1917. stubs: {
  1918. symbol_file: "libbar.map.txt",
  1919. versions: ["30", "S", "T"],
  1920. },
  1921. }
  1922. `, withSAsActiveCodeNames)
  1923. // ensure libfoo is linked with "S" version of libbar stub
  1924. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
  1925. libFlags := libfoo.Rule("ld").Args["libFlags"]
  1926. ensureContains(t, libFlags, "android_arm64_armv8-a_shared_T/libbar.so")
  1927. }
  1928. func TestFilesInSubDir(t *testing.T) {
  1929. ctx := testApex(t, `
  1930. apex {
  1931. name: "myapex",
  1932. key: "myapex.key",
  1933. native_shared_libs: ["mylib"],
  1934. binaries: ["mybin"],
  1935. prebuilts: ["myetc"],
  1936. compile_multilib: "both",
  1937. updatable: false,
  1938. }
  1939. apex_key {
  1940. name: "myapex.key",
  1941. public_key: "testkey.avbpubkey",
  1942. private_key: "testkey.pem",
  1943. }
  1944. prebuilt_etc {
  1945. name: "myetc",
  1946. src: "myprebuilt",
  1947. sub_dir: "foo/bar",
  1948. }
  1949. cc_library {
  1950. name: "mylib",
  1951. srcs: ["mylib.cpp"],
  1952. relative_install_path: "foo/bar",
  1953. system_shared_libs: [],
  1954. stl: "none",
  1955. apex_available: [ "myapex" ],
  1956. }
  1957. cc_binary {
  1958. name: "mybin",
  1959. srcs: ["mylib.cpp"],
  1960. relative_install_path: "foo/bar",
  1961. system_shared_libs: [],
  1962. static_executable: true,
  1963. stl: "none",
  1964. apex_available: [ "myapex" ],
  1965. }
  1966. `)
  1967. generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
  1968. dirs := strings.Split(generateFsRule.Args["exec_paths"], " ")
  1969. // Ensure that the subdirectories are all listed
  1970. ensureListContains(t, dirs, "etc")
  1971. ensureListContains(t, dirs, "etc/foo")
  1972. ensureListContains(t, dirs, "etc/foo/bar")
  1973. ensureListContains(t, dirs, "lib64")
  1974. ensureListContains(t, dirs, "lib64/foo")
  1975. ensureListContains(t, dirs, "lib64/foo/bar")
  1976. ensureListContains(t, dirs, "lib")
  1977. ensureListContains(t, dirs, "lib/foo")
  1978. ensureListContains(t, dirs, "lib/foo/bar")
  1979. ensureListContains(t, dirs, "bin")
  1980. ensureListContains(t, dirs, "bin/foo")
  1981. ensureListContains(t, dirs, "bin/foo/bar")
  1982. }
  1983. func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
  1984. ctx := testApex(t, `
  1985. apex {
  1986. name: "myapex",
  1987. key: "myapex.key",
  1988. multilib: {
  1989. both: {
  1990. native_shared_libs: ["mylib"],
  1991. binaries: ["mybin"],
  1992. },
  1993. },
  1994. compile_multilib: "both",
  1995. native_bridge_supported: true,
  1996. updatable: false,
  1997. }
  1998. apex_key {
  1999. name: "myapex.key",
  2000. public_key: "testkey.avbpubkey",
  2001. private_key: "testkey.pem",
  2002. }
  2003. cc_library {
  2004. name: "mylib",
  2005. relative_install_path: "foo/bar",
  2006. system_shared_libs: [],
  2007. stl: "none",
  2008. apex_available: [ "myapex" ],
  2009. native_bridge_supported: true,
  2010. }
  2011. cc_binary {
  2012. name: "mybin",
  2013. relative_install_path: "foo/bar",
  2014. system_shared_libs: [],
  2015. static_executable: true,
  2016. stl: "none",
  2017. apex_available: [ "myapex" ],
  2018. native_bridge_supported: true,
  2019. compile_multilib: "both", // default is "first" for binary
  2020. multilib: {
  2021. lib64: {
  2022. suffix: "64",
  2023. },
  2024. },
  2025. }
  2026. `, withNativeBridgeEnabled)
  2027. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2028. "bin/foo/bar/mybin",
  2029. "bin/foo/bar/mybin64",
  2030. "bin/arm/foo/bar/mybin",
  2031. "bin/arm64/foo/bar/mybin64",
  2032. "lib/foo/bar/mylib.so",
  2033. "lib/arm/foo/bar/mylib.so",
  2034. "lib64/foo/bar/mylib.so",
  2035. "lib64/arm64/foo/bar/mylib.so",
  2036. })
  2037. }
  2038. func TestUseVendor(t *testing.T) {
  2039. ctx := testApex(t, `
  2040. apex {
  2041. name: "myapex",
  2042. key: "myapex.key",
  2043. native_shared_libs: ["mylib"],
  2044. use_vendor: true,
  2045. updatable: false,
  2046. }
  2047. apex_key {
  2048. name: "myapex.key",
  2049. public_key: "testkey.avbpubkey",
  2050. private_key: "testkey.pem",
  2051. }
  2052. cc_library {
  2053. name: "mylib",
  2054. srcs: ["mylib.cpp"],
  2055. shared_libs: ["mylib2"],
  2056. system_shared_libs: [],
  2057. vendor_available: true,
  2058. stl: "none",
  2059. apex_available: [ "myapex" ],
  2060. }
  2061. cc_library {
  2062. name: "mylib2",
  2063. srcs: ["mylib.cpp"],
  2064. system_shared_libs: [],
  2065. vendor_available: true,
  2066. stl: "none",
  2067. apex_available: [ "myapex" ],
  2068. }
  2069. `,
  2070. setUseVendorAllowListForTest([]string{"myapex"}),
  2071. )
  2072. inputsList := []string{}
  2073. for _, i := range ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().BuildParamsForTests() {
  2074. for _, implicit := range i.Implicits {
  2075. inputsList = append(inputsList, implicit.String())
  2076. }
  2077. }
  2078. inputsString := strings.Join(inputsList, " ")
  2079. // ensure that the apex includes vendor variants of the direct and indirect deps
  2080. ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_apex10000/mylib.so")
  2081. ensureContains(t, inputsString, "android_vendor.VER_arm64_armv8-a_shared_apex10000/mylib2.so")
  2082. // ensure that the apex does not include core variants
  2083. ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib.so")
  2084. ensureNotContains(t, inputsString, "android_arm64_armv8-a_shared_apex10000/mylib2.so")
  2085. }
  2086. func TestUseVendorNotAllowedForSystemApexes(t *testing.T) {
  2087. testApexError(t, `module "myapex" .*: use_vendor: not allowed`, `
  2088. apex {
  2089. name: "myapex",
  2090. key: "myapex.key",
  2091. use_vendor: true,
  2092. }
  2093. apex_key {
  2094. name: "myapex.key",
  2095. public_key: "testkey.avbpubkey",
  2096. private_key: "testkey.pem",
  2097. }
  2098. `,
  2099. setUseVendorAllowListForTest([]string{""}),
  2100. )
  2101. // no error with allow list
  2102. testApex(t, `
  2103. apex {
  2104. name: "myapex",
  2105. key: "myapex.key",
  2106. use_vendor: true,
  2107. updatable: false,
  2108. }
  2109. apex_key {
  2110. name: "myapex.key",
  2111. public_key: "testkey.avbpubkey",
  2112. private_key: "testkey.pem",
  2113. }
  2114. `,
  2115. setUseVendorAllowListForTest([]string{"myapex"}),
  2116. )
  2117. }
  2118. func TestUseVendorFailsIfNotVendorAvailable(t *testing.T) {
  2119. testApexError(t, `dependency "mylib" of "myapex" missing variant:\n.*image:vendor`, `
  2120. apex {
  2121. name: "myapex",
  2122. key: "myapex.key",
  2123. native_shared_libs: ["mylib"],
  2124. use_vendor: true,
  2125. updatable: false,
  2126. }
  2127. apex_key {
  2128. name: "myapex.key",
  2129. public_key: "testkey.avbpubkey",
  2130. private_key: "testkey.pem",
  2131. }
  2132. cc_library {
  2133. name: "mylib",
  2134. srcs: ["mylib.cpp"],
  2135. system_shared_libs: [],
  2136. stl: "none",
  2137. }
  2138. `)
  2139. }
  2140. func TestVendorApex(t *testing.T) {
  2141. ctx := testApex(t, `
  2142. apex {
  2143. name: "myapex",
  2144. key: "myapex.key",
  2145. binaries: ["mybin"],
  2146. vendor: true,
  2147. updatable: false,
  2148. }
  2149. apex_key {
  2150. name: "myapex.key",
  2151. public_key: "testkey.avbpubkey",
  2152. private_key: "testkey.pem",
  2153. }
  2154. cc_binary {
  2155. name: "mybin",
  2156. vendor: true,
  2157. shared_libs: ["libfoo"],
  2158. }
  2159. cc_library {
  2160. name: "libfoo",
  2161. proprietary: true,
  2162. }
  2163. `)
  2164. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2165. "bin/mybin",
  2166. "lib64/libfoo.so",
  2167. // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
  2168. "lib64/libc++.so",
  2169. })
  2170. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2171. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2172. name := apexBundle.BaseModuleName()
  2173. prefix := "TARGET_"
  2174. var builder strings.Builder
  2175. data.Custom(&builder, name, prefix, "", data)
  2176. androidMk := android.StringRelativeToTop(ctx.Config(), builder.String())
  2177. installPath := "out/target/product/test_device/vendor/apex"
  2178. ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
  2179. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2180. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2181. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2182. }
  2183. func TestVendorApex_use_vndk_as_stable(t *testing.T) {
  2184. ctx := testApex(t, `
  2185. apex {
  2186. name: "myapex",
  2187. key: "myapex.key",
  2188. binaries: ["mybin"],
  2189. vendor: true,
  2190. use_vndk_as_stable: true,
  2191. updatable: false,
  2192. }
  2193. apex_key {
  2194. name: "myapex.key",
  2195. public_key: "testkey.avbpubkey",
  2196. private_key: "testkey.pem",
  2197. }
  2198. cc_binary {
  2199. name: "mybin",
  2200. vendor: true,
  2201. shared_libs: ["libvndk", "libvendor"],
  2202. }
  2203. cc_library {
  2204. name: "libvndk",
  2205. vndk: {
  2206. enabled: true,
  2207. },
  2208. vendor_available: true,
  2209. product_available: true,
  2210. }
  2211. cc_library {
  2212. name: "libvendor",
  2213. vendor: true,
  2214. }
  2215. `)
  2216. vendorVariant := "android_vendor.VER_arm64_armv8-a"
  2217. ldRule := ctx.ModuleForTests("mybin", vendorVariant+"_apex10000").Rule("ld")
  2218. libs := names(ldRule.Args["libFlags"])
  2219. // VNDK libs(libvndk/libc++) as they are
  2220. ensureListContains(t, libs, "out/soong/.intermediates/libvndk/"+vendorVariant+"_shared/libvndk.so")
  2221. ensureListContains(t, libs, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"libc++/"+vendorVariant+"_shared/libc++.so")
  2222. // non-stable Vendor libs as APEX variants
  2223. ensureListContains(t, libs, "out/soong/.intermediates/libvendor/"+vendorVariant+"_shared_apex10000/libvendor.so")
  2224. // VNDK libs are not included when use_vndk_as_stable: true
  2225. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2226. "bin/mybin",
  2227. "lib64/libvendor.so",
  2228. })
  2229. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2230. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2231. ensureListContains(t, requireNativeLibs, ":vndk")
  2232. }
  2233. func TestProductVariant(t *testing.T) {
  2234. ctx := testApex(t, `
  2235. apex {
  2236. name: "myapex",
  2237. key: "myapex.key",
  2238. updatable: false,
  2239. product_specific: true,
  2240. binaries: ["foo"],
  2241. }
  2242. apex_key {
  2243. name: "myapex.key",
  2244. public_key: "testkey.avbpubkey",
  2245. private_key: "testkey.pem",
  2246. }
  2247. cc_binary {
  2248. name: "foo",
  2249. product_available: true,
  2250. apex_available: ["myapex"],
  2251. srcs: ["foo.cpp"],
  2252. }
  2253. `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2254. variables.ProductVndkVersion = proptools.StringPtr("current")
  2255. }),
  2256. )
  2257. cflags := strings.Fields(
  2258. ctx.ModuleForTests("foo", "android_product.VER_arm64_armv8-a_apex10000").Rule("cc").Args["cFlags"])
  2259. ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
  2260. ensureListContains(t, cflags, "-D__ANDROID_APEX__")
  2261. ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
  2262. ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
  2263. }
  2264. func TestApex_withPrebuiltFirmware(t *testing.T) {
  2265. testCases := []struct {
  2266. name string
  2267. additionalProp string
  2268. }{
  2269. {"system apex with prebuilt_firmware", ""},
  2270. {"vendor apex with prebuilt_firmware", "vendor: true,"},
  2271. }
  2272. for _, tc := range testCases {
  2273. t.Run(tc.name, func(t *testing.T) {
  2274. ctx := testApex(t, `
  2275. apex {
  2276. name: "myapex",
  2277. key: "myapex.key",
  2278. prebuilts: ["myfirmware"],
  2279. updatable: false,
  2280. `+tc.additionalProp+`
  2281. }
  2282. apex_key {
  2283. name: "myapex.key",
  2284. public_key: "testkey.avbpubkey",
  2285. private_key: "testkey.pem",
  2286. }
  2287. prebuilt_firmware {
  2288. name: "myfirmware",
  2289. src: "myfirmware.bin",
  2290. filename_from_src: true,
  2291. `+tc.additionalProp+`
  2292. }
  2293. `)
  2294. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2295. "etc/firmware/myfirmware.bin",
  2296. })
  2297. })
  2298. }
  2299. }
  2300. func TestAndroidMk_UseVendorRequired(t *testing.T) {
  2301. ctx := testApex(t, `
  2302. apex {
  2303. name: "myapex",
  2304. key: "myapex.key",
  2305. use_vendor: true,
  2306. native_shared_libs: ["mylib"],
  2307. updatable: false,
  2308. }
  2309. apex_key {
  2310. name: "myapex.key",
  2311. public_key: "testkey.avbpubkey",
  2312. private_key: "testkey.pem",
  2313. }
  2314. cc_library {
  2315. name: "mylib",
  2316. vendor_available: true,
  2317. apex_available: ["myapex"],
  2318. }
  2319. `,
  2320. setUseVendorAllowListForTest([]string{"myapex"}),
  2321. )
  2322. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2323. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2324. name := apexBundle.BaseModuleName()
  2325. prefix := "TARGET_"
  2326. var builder strings.Builder
  2327. data.Custom(&builder, name, prefix, "", data)
  2328. androidMk := builder.String()
  2329. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc libm libdl\n")
  2330. }
  2331. func TestAndroidMk_VendorApexRequired(t *testing.T) {
  2332. ctx := testApex(t, `
  2333. apex {
  2334. name: "myapex",
  2335. key: "myapex.key",
  2336. vendor: true,
  2337. native_shared_libs: ["mylib"],
  2338. updatable: false,
  2339. }
  2340. apex_key {
  2341. name: "myapex.key",
  2342. public_key: "testkey.avbpubkey",
  2343. private_key: "testkey.pem",
  2344. }
  2345. cc_library {
  2346. name: "mylib",
  2347. vendor_available: true,
  2348. }
  2349. `)
  2350. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2351. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2352. name := apexBundle.BaseModuleName()
  2353. prefix := "TARGET_"
  2354. var builder strings.Builder
  2355. data.Custom(&builder, name, prefix, "", data)
  2356. androidMk := builder.String()
  2357. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
  2358. }
  2359. func TestAndroidMkWritesCommonProperties(t *testing.T) {
  2360. ctx := testApex(t, `
  2361. apex {
  2362. name: "myapex",
  2363. key: "myapex.key",
  2364. vintf_fragments: ["fragment.xml"],
  2365. init_rc: ["init.rc"],
  2366. updatable: false,
  2367. }
  2368. apex_key {
  2369. name: "myapex.key",
  2370. public_key: "testkey.avbpubkey",
  2371. private_key: "testkey.pem",
  2372. }
  2373. cc_binary {
  2374. name: "mybin",
  2375. }
  2376. `)
  2377. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2378. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2379. name := apexBundle.BaseModuleName()
  2380. prefix := "TARGET_"
  2381. var builder strings.Builder
  2382. data.Custom(&builder, name, prefix, "", data)
  2383. androidMk := builder.String()
  2384. ensureContains(t, androidMk, "LOCAL_VINTF_FRAGMENTS := fragment.xml\n")
  2385. ensureContains(t, androidMk, "LOCAL_INIT_RC := init.rc\n")
  2386. }
  2387. func TestStaticLinking(t *testing.T) {
  2388. ctx := testApex(t, `
  2389. apex {
  2390. name: "myapex",
  2391. key: "myapex.key",
  2392. native_shared_libs: ["mylib"],
  2393. updatable: false,
  2394. }
  2395. apex_key {
  2396. name: "myapex.key",
  2397. public_key: "testkey.avbpubkey",
  2398. private_key: "testkey.pem",
  2399. }
  2400. cc_library {
  2401. name: "mylib",
  2402. srcs: ["mylib.cpp"],
  2403. system_shared_libs: [],
  2404. stl: "none",
  2405. stubs: {
  2406. versions: ["1", "2", "3"],
  2407. },
  2408. apex_available: [
  2409. "//apex_available:platform",
  2410. "myapex",
  2411. ],
  2412. }
  2413. cc_binary {
  2414. name: "not_in_apex",
  2415. srcs: ["mylib.cpp"],
  2416. static_libs: ["mylib"],
  2417. static_executable: true,
  2418. system_shared_libs: [],
  2419. stl: "none",
  2420. }
  2421. `)
  2422. ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  2423. // Ensure that not_in_apex is linking with the static variant of mylib
  2424. ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
  2425. }
  2426. func TestKeys(t *testing.T) {
  2427. ctx := testApex(t, `
  2428. apex {
  2429. name: "myapex_keytest",
  2430. key: "myapex.key",
  2431. certificate: ":myapex.certificate",
  2432. native_shared_libs: ["mylib"],
  2433. file_contexts: ":myapex-file_contexts",
  2434. updatable: false,
  2435. }
  2436. cc_library {
  2437. name: "mylib",
  2438. srcs: ["mylib.cpp"],
  2439. system_shared_libs: [],
  2440. stl: "none",
  2441. apex_available: [ "myapex_keytest" ],
  2442. }
  2443. apex_key {
  2444. name: "myapex.key",
  2445. public_key: "testkey.avbpubkey",
  2446. private_key: "testkey.pem",
  2447. }
  2448. android_app_certificate {
  2449. name: "myapex.certificate",
  2450. certificate: "testkey",
  2451. }
  2452. android_app_certificate {
  2453. name: "myapex.certificate.override",
  2454. certificate: "testkey.override",
  2455. }
  2456. `)
  2457. // check the APEX keys
  2458. keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  2459. if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
  2460. t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
  2461. "vendor/foo/devkeys/testkey.avbpubkey")
  2462. }
  2463. if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
  2464. t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
  2465. "vendor/foo/devkeys/testkey.pem")
  2466. }
  2467. // check the APK certs. It should be overridden to myapex.certificate.override
  2468. certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
  2469. if certs != "testkey.override.x509.pem testkey.override.pk8" {
  2470. t.Errorf("cert and private key %q are not %q", certs,
  2471. "testkey.override.509.pem testkey.override.pk8")
  2472. }
  2473. }
  2474. func TestCertificate(t *testing.T) {
  2475. t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
  2476. ctx := testApex(t, `
  2477. apex {
  2478. name: "myapex",
  2479. key: "myapex.key",
  2480. updatable: false,
  2481. }
  2482. apex_key {
  2483. name: "myapex.key",
  2484. public_key: "testkey.avbpubkey",
  2485. private_key: "testkey.pem",
  2486. }`)
  2487. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2488. expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
  2489. if actual := rule.Args["certificates"]; actual != expected {
  2490. t.Errorf("certificates should be %q, not %q", expected, actual)
  2491. }
  2492. })
  2493. t.Run("override when unspecified", func(t *testing.T) {
  2494. ctx := testApex(t, `
  2495. apex {
  2496. name: "myapex_keytest",
  2497. key: "myapex.key",
  2498. file_contexts: ":myapex-file_contexts",
  2499. updatable: false,
  2500. }
  2501. apex_key {
  2502. name: "myapex.key",
  2503. public_key: "testkey.avbpubkey",
  2504. private_key: "testkey.pem",
  2505. }
  2506. android_app_certificate {
  2507. name: "myapex.certificate.override",
  2508. certificate: "testkey.override",
  2509. }`)
  2510. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2511. expected := "testkey.override.x509.pem testkey.override.pk8"
  2512. if actual := rule.Args["certificates"]; actual != expected {
  2513. t.Errorf("certificates should be %q, not %q", expected, actual)
  2514. }
  2515. })
  2516. t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
  2517. ctx := testApex(t, `
  2518. apex {
  2519. name: "myapex",
  2520. key: "myapex.key",
  2521. certificate: ":myapex.certificate",
  2522. updatable: false,
  2523. }
  2524. apex_key {
  2525. name: "myapex.key",
  2526. public_key: "testkey.avbpubkey",
  2527. private_key: "testkey.pem",
  2528. }
  2529. android_app_certificate {
  2530. name: "myapex.certificate",
  2531. certificate: "testkey",
  2532. }`)
  2533. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2534. expected := "testkey.x509.pem testkey.pk8"
  2535. if actual := rule.Args["certificates"]; actual != expected {
  2536. t.Errorf("certificates should be %q, not %q", expected, actual)
  2537. }
  2538. })
  2539. t.Run("override when specifiec as <:module>", func(t *testing.T) {
  2540. ctx := testApex(t, `
  2541. apex {
  2542. name: "myapex_keytest",
  2543. key: "myapex.key",
  2544. file_contexts: ":myapex-file_contexts",
  2545. certificate: ":myapex.certificate",
  2546. updatable: false,
  2547. }
  2548. apex_key {
  2549. name: "myapex.key",
  2550. public_key: "testkey.avbpubkey",
  2551. private_key: "testkey.pem",
  2552. }
  2553. android_app_certificate {
  2554. name: "myapex.certificate.override",
  2555. certificate: "testkey.override",
  2556. }`)
  2557. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2558. expected := "testkey.override.x509.pem testkey.override.pk8"
  2559. if actual := rule.Args["certificates"]; actual != expected {
  2560. t.Errorf("certificates should be %q, not %q", expected, actual)
  2561. }
  2562. })
  2563. t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
  2564. ctx := testApex(t, `
  2565. apex {
  2566. name: "myapex",
  2567. key: "myapex.key",
  2568. certificate: "testkey",
  2569. updatable: false,
  2570. }
  2571. apex_key {
  2572. name: "myapex.key",
  2573. public_key: "testkey.avbpubkey",
  2574. private_key: "testkey.pem",
  2575. }`)
  2576. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2577. expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
  2578. if actual := rule.Args["certificates"]; actual != expected {
  2579. t.Errorf("certificates should be %q, not %q", expected, actual)
  2580. }
  2581. })
  2582. t.Run("override when specified as <name>", func(t *testing.T) {
  2583. ctx := testApex(t, `
  2584. apex {
  2585. name: "myapex_keytest",
  2586. key: "myapex.key",
  2587. file_contexts: ":myapex-file_contexts",
  2588. certificate: "testkey",
  2589. updatable: false,
  2590. }
  2591. apex_key {
  2592. name: "myapex.key",
  2593. public_key: "testkey.avbpubkey",
  2594. private_key: "testkey.pem",
  2595. }
  2596. android_app_certificate {
  2597. name: "myapex.certificate.override",
  2598. certificate: "testkey.override",
  2599. }`)
  2600. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2601. expected := "testkey.override.x509.pem testkey.override.pk8"
  2602. if actual := rule.Args["certificates"]; actual != expected {
  2603. t.Errorf("certificates should be %q, not %q", expected, actual)
  2604. }
  2605. })
  2606. }
  2607. func TestMacro(t *testing.T) {
  2608. ctx := testApex(t, `
  2609. apex {
  2610. name: "myapex",
  2611. key: "myapex.key",
  2612. native_shared_libs: ["mylib", "mylib2"],
  2613. updatable: false,
  2614. }
  2615. apex {
  2616. name: "otherapex",
  2617. key: "myapex.key",
  2618. native_shared_libs: ["mylib", "mylib2"],
  2619. min_sdk_version: "29",
  2620. }
  2621. apex_key {
  2622. name: "myapex.key",
  2623. public_key: "testkey.avbpubkey",
  2624. private_key: "testkey.pem",
  2625. }
  2626. cc_library {
  2627. name: "mylib",
  2628. srcs: ["mylib.cpp"],
  2629. system_shared_libs: [],
  2630. stl: "none",
  2631. apex_available: [
  2632. "myapex",
  2633. "otherapex",
  2634. ],
  2635. recovery_available: true,
  2636. min_sdk_version: "29",
  2637. }
  2638. cc_library {
  2639. name: "mylib2",
  2640. srcs: ["mylib.cpp"],
  2641. system_shared_libs: [],
  2642. stl: "none",
  2643. apex_available: [
  2644. "myapex",
  2645. "otherapex",
  2646. ],
  2647. static_libs: ["mylib3"],
  2648. recovery_available: true,
  2649. min_sdk_version: "29",
  2650. }
  2651. cc_library {
  2652. name: "mylib3",
  2653. srcs: ["mylib.cpp"],
  2654. system_shared_libs: [],
  2655. stl: "none",
  2656. apex_available: [
  2657. "myapex",
  2658. "otherapex",
  2659. ],
  2660. use_apex_name_macro: true,
  2661. recovery_available: true,
  2662. min_sdk_version: "29",
  2663. }
  2664. `)
  2665. // non-APEX variant does not have __ANDROID_APEX__ defined
  2666. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2667. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2668. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2669. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2670. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  2671. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2672. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
  2673. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
  2674. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2675. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
  2676. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2677. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
  2678. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
  2679. // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
  2680. // each variant defines additional macros to distinguish which apex variant it is built for
  2681. // non-APEX variant does not have __ANDROID_APEX__ defined
  2682. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2683. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2684. // APEX variant has __ANDROID_APEX__ defined
  2685. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
  2686. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2687. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
  2688. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
  2689. // APEX variant has __ANDROID_APEX__ defined
  2690. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
  2691. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2692. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
  2693. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
  2694. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2695. mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2696. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2697. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2698. // When a dependency of a cc_library sets use_apex_name_macro: true each apex gets a unique
  2699. // variant.
  2700. // non-APEX variant does not have __ANDROID_APEX__ defined
  2701. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2702. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2703. // APEX variant has __ANDROID_APEX__ defined
  2704. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_myapex").Rule("cc").Args["cFlags"]
  2705. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2706. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
  2707. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
  2708. // APEX variant has __ANDROID_APEX__ defined
  2709. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static_otherapex").Rule("cc").Args["cFlags"]
  2710. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2711. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MYAPEX__")
  2712. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_OTHERAPEX__")
  2713. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2714. mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2715. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2716. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2717. }
  2718. func TestHeaderLibsDependency(t *testing.T) {
  2719. ctx := testApex(t, `
  2720. apex {
  2721. name: "myapex",
  2722. key: "myapex.key",
  2723. native_shared_libs: ["mylib"],
  2724. updatable: false,
  2725. }
  2726. apex_key {
  2727. name: "myapex.key",
  2728. public_key: "testkey.avbpubkey",
  2729. private_key: "testkey.pem",
  2730. }
  2731. cc_library_headers {
  2732. name: "mylib_headers",
  2733. export_include_dirs: ["my_include"],
  2734. system_shared_libs: [],
  2735. stl: "none",
  2736. apex_available: [ "myapex" ],
  2737. }
  2738. cc_library {
  2739. name: "mylib",
  2740. srcs: ["mylib.cpp"],
  2741. system_shared_libs: [],
  2742. stl: "none",
  2743. header_libs: ["mylib_headers"],
  2744. export_header_lib_headers: ["mylib_headers"],
  2745. stubs: {
  2746. versions: ["1", "2", "3"],
  2747. },
  2748. apex_available: [ "myapex" ],
  2749. }
  2750. cc_library {
  2751. name: "otherlib",
  2752. srcs: ["mylib.cpp"],
  2753. system_shared_libs: [],
  2754. stl: "none",
  2755. shared_libs: ["mylib"],
  2756. }
  2757. `)
  2758. cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2759. // Ensure that the include path of the header lib is exported to 'otherlib'
  2760. ensureContains(t, cFlags, "-Imy_include")
  2761. }
  2762. type fileInApex struct {
  2763. path string // path in apex
  2764. src string // src path
  2765. isLink bool
  2766. }
  2767. func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
  2768. t.Helper()
  2769. apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
  2770. copyCmds := apexRule.Args["copy_commands"]
  2771. imageApexDir := "/image.apex/"
  2772. var ret []fileInApex
  2773. for _, cmd := range strings.Split(copyCmds, "&&") {
  2774. cmd = strings.TrimSpace(cmd)
  2775. if cmd == "" {
  2776. continue
  2777. }
  2778. terms := strings.Split(cmd, " ")
  2779. var dst, src string
  2780. var isLink bool
  2781. switch terms[0] {
  2782. case "mkdir":
  2783. case "cp":
  2784. if len(terms) != 3 && len(terms) != 4 {
  2785. t.Fatal("copyCmds contains invalid cp command", cmd)
  2786. }
  2787. dst = terms[len(terms)-1]
  2788. src = terms[len(terms)-2]
  2789. isLink = false
  2790. case "ln":
  2791. if len(terms) != 3 && len(terms) != 4 {
  2792. // ln LINK TARGET or ln -s LINK TARGET
  2793. t.Fatal("copyCmds contains invalid ln command", cmd)
  2794. }
  2795. dst = terms[len(terms)-1]
  2796. src = terms[len(terms)-2]
  2797. isLink = true
  2798. default:
  2799. t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
  2800. }
  2801. if dst != "" {
  2802. index := strings.Index(dst, imageApexDir)
  2803. if index == -1 {
  2804. t.Fatal("copyCmds should copy a file to image.apex/", cmd)
  2805. }
  2806. dstFile := dst[index+len(imageApexDir):]
  2807. ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
  2808. }
  2809. }
  2810. return ret
  2811. }
  2812. func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
  2813. t.Helper()
  2814. var failed bool
  2815. var surplus []string
  2816. filesMatched := make(map[string]bool)
  2817. for _, file := range getFiles(t, ctx, moduleName, variant) {
  2818. mactchFound := false
  2819. for _, expected := range files {
  2820. if matched, _ := path.Match(expected, file.path); matched {
  2821. filesMatched[expected] = true
  2822. mactchFound = true
  2823. break
  2824. }
  2825. }
  2826. if !mactchFound {
  2827. surplus = append(surplus, file.path)
  2828. }
  2829. }
  2830. if len(surplus) > 0 {
  2831. sort.Strings(surplus)
  2832. t.Log("surplus files", surplus)
  2833. failed = true
  2834. }
  2835. if len(files) > len(filesMatched) {
  2836. var missing []string
  2837. for _, expected := range files {
  2838. if !filesMatched[expected] {
  2839. missing = append(missing, expected)
  2840. }
  2841. }
  2842. sort.Strings(missing)
  2843. t.Log("missing files", missing)
  2844. failed = true
  2845. }
  2846. if failed {
  2847. t.Fail()
  2848. }
  2849. }
  2850. func TestVndkApexCurrent(t *testing.T) {
  2851. ctx := testApex(t, `
  2852. apex_vndk {
  2853. name: "com.android.vndk.current",
  2854. key: "com.android.vndk.current.key",
  2855. updatable: false,
  2856. }
  2857. apex_key {
  2858. name: "com.android.vndk.current.key",
  2859. public_key: "testkey.avbpubkey",
  2860. private_key: "testkey.pem",
  2861. }
  2862. cc_library {
  2863. name: "libvndk",
  2864. srcs: ["mylib.cpp"],
  2865. vendor_available: true,
  2866. product_available: true,
  2867. vndk: {
  2868. enabled: true,
  2869. },
  2870. system_shared_libs: [],
  2871. stl: "none",
  2872. apex_available: [ "com.android.vndk.current" ],
  2873. }
  2874. cc_library {
  2875. name: "libvndksp",
  2876. srcs: ["mylib.cpp"],
  2877. vendor_available: true,
  2878. product_available: true,
  2879. vndk: {
  2880. enabled: true,
  2881. support_system_process: true,
  2882. },
  2883. system_shared_libs: [],
  2884. stl: "none",
  2885. apex_available: [ "com.android.vndk.current" ],
  2886. }
  2887. `+vndkLibrariesTxtFiles("current"))
  2888. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  2889. "lib/libvndk.so",
  2890. "lib/libvndksp.so",
  2891. "lib/libc++.so",
  2892. "lib64/libvndk.so",
  2893. "lib64/libvndksp.so",
  2894. "lib64/libc++.so",
  2895. "etc/llndk.libraries.VER.txt",
  2896. "etc/vndkcore.libraries.VER.txt",
  2897. "etc/vndksp.libraries.VER.txt",
  2898. "etc/vndkprivate.libraries.VER.txt",
  2899. "etc/vndkproduct.libraries.VER.txt",
  2900. })
  2901. }
  2902. func TestVndkApexWithPrebuilt(t *testing.T) {
  2903. ctx := testApex(t, `
  2904. apex_vndk {
  2905. name: "com.android.vndk.current",
  2906. key: "com.android.vndk.current.key",
  2907. updatable: false,
  2908. }
  2909. apex_key {
  2910. name: "com.android.vndk.current.key",
  2911. public_key: "testkey.avbpubkey",
  2912. private_key: "testkey.pem",
  2913. }
  2914. cc_prebuilt_library_shared {
  2915. name: "libvndk",
  2916. srcs: ["libvndk.so"],
  2917. vendor_available: true,
  2918. product_available: true,
  2919. vndk: {
  2920. enabled: true,
  2921. },
  2922. system_shared_libs: [],
  2923. stl: "none",
  2924. apex_available: [ "com.android.vndk.current" ],
  2925. }
  2926. cc_prebuilt_library_shared {
  2927. name: "libvndk.arm",
  2928. srcs: ["libvndk.arm.so"],
  2929. vendor_available: true,
  2930. product_available: true,
  2931. vndk: {
  2932. enabled: true,
  2933. },
  2934. enabled: false,
  2935. arch: {
  2936. arm: {
  2937. enabled: true,
  2938. },
  2939. },
  2940. system_shared_libs: [],
  2941. stl: "none",
  2942. apex_available: [ "com.android.vndk.current" ],
  2943. }
  2944. `+vndkLibrariesTxtFiles("current"),
  2945. withFiles(map[string][]byte{
  2946. "libvndk.so": nil,
  2947. "libvndk.arm.so": nil,
  2948. }))
  2949. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  2950. "lib/libvndk.so",
  2951. "lib/libvndk.arm.so",
  2952. "lib64/libvndk.so",
  2953. "lib/libc++.so",
  2954. "lib64/libc++.so",
  2955. "etc/*",
  2956. })
  2957. }
  2958. func vndkLibrariesTxtFiles(vers ...string) (result string) {
  2959. for _, v := range vers {
  2960. if v == "current" {
  2961. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  2962. result += `
  2963. ` + txt + `_libraries_txt {
  2964. name: "` + txt + `.libraries.txt",
  2965. }
  2966. `
  2967. }
  2968. } else {
  2969. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  2970. result += `
  2971. prebuilt_etc {
  2972. name: "` + txt + `.libraries.` + v + `.txt",
  2973. src: "dummy.txt",
  2974. }
  2975. `
  2976. }
  2977. }
  2978. }
  2979. return
  2980. }
  2981. func TestVndkApexVersion(t *testing.T) {
  2982. ctx := testApex(t, `
  2983. apex_vndk {
  2984. name: "com.android.vndk.v27",
  2985. key: "myapex.key",
  2986. file_contexts: ":myapex-file_contexts",
  2987. vndk_version: "27",
  2988. updatable: false,
  2989. }
  2990. apex_key {
  2991. name: "myapex.key",
  2992. public_key: "testkey.avbpubkey",
  2993. private_key: "testkey.pem",
  2994. }
  2995. vndk_prebuilt_shared {
  2996. name: "libvndk27",
  2997. version: "27",
  2998. vendor_available: true,
  2999. product_available: true,
  3000. vndk: {
  3001. enabled: true,
  3002. },
  3003. target_arch: "arm64",
  3004. arch: {
  3005. arm: {
  3006. srcs: ["libvndk27_arm.so"],
  3007. },
  3008. arm64: {
  3009. srcs: ["libvndk27_arm64.so"],
  3010. },
  3011. },
  3012. apex_available: [ "com.android.vndk.v27" ],
  3013. }
  3014. vndk_prebuilt_shared {
  3015. name: "libvndk27",
  3016. version: "27",
  3017. vendor_available: true,
  3018. product_available: true,
  3019. vndk: {
  3020. enabled: true,
  3021. },
  3022. target_arch: "x86_64",
  3023. arch: {
  3024. x86: {
  3025. srcs: ["libvndk27_x86.so"],
  3026. },
  3027. x86_64: {
  3028. srcs: ["libvndk27_x86_64.so"],
  3029. },
  3030. },
  3031. }
  3032. `+vndkLibrariesTxtFiles("27"),
  3033. withFiles(map[string][]byte{
  3034. "libvndk27_arm.so": nil,
  3035. "libvndk27_arm64.so": nil,
  3036. "libvndk27_x86.so": nil,
  3037. "libvndk27_x86_64.so": nil,
  3038. }))
  3039. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3040. "lib/libvndk27_arm.so",
  3041. "lib64/libvndk27_arm64.so",
  3042. "etc/*",
  3043. })
  3044. }
  3045. func TestVndkApexNameRule(t *testing.T) {
  3046. ctx := testApex(t, `
  3047. apex_vndk {
  3048. name: "com.android.vndk.current",
  3049. key: "myapex.key",
  3050. file_contexts: ":myapex-file_contexts",
  3051. updatable: false,
  3052. }
  3053. apex_vndk {
  3054. name: "com.android.vndk.v28",
  3055. key: "myapex.key",
  3056. file_contexts: ":myapex-file_contexts",
  3057. vndk_version: "28",
  3058. updatable: false,
  3059. }
  3060. apex_key {
  3061. name: "myapex.key",
  3062. public_key: "testkey.avbpubkey",
  3063. private_key: "testkey.pem",
  3064. }`+vndkLibrariesTxtFiles("28", "current"))
  3065. assertApexName := func(expected, moduleName string) {
  3066. bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
  3067. actual := proptools.String(bundle.properties.Apex_name)
  3068. if !reflect.DeepEqual(actual, expected) {
  3069. t.Errorf("Got '%v', expected '%v'", actual, expected)
  3070. }
  3071. }
  3072. assertApexName("com.android.vndk.vVER", "com.android.vndk.current")
  3073. assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
  3074. }
  3075. func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
  3076. ctx := testApex(t, `
  3077. apex_vndk {
  3078. name: "com.android.vndk.current",
  3079. key: "com.android.vndk.current.key",
  3080. file_contexts: ":myapex-file_contexts",
  3081. updatable: false,
  3082. }
  3083. apex_key {
  3084. name: "com.android.vndk.current.key",
  3085. public_key: "testkey.avbpubkey",
  3086. private_key: "testkey.pem",
  3087. }
  3088. cc_library {
  3089. name: "libvndk",
  3090. srcs: ["mylib.cpp"],
  3091. vendor_available: true,
  3092. product_available: true,
  3093. native_bridge_supported: true,
  3094. host_supported: true,
  3095. vndk: {
  3096. enabled: true,
  3097. },
  3098. system_shared_libs: [],
  3099. stl: "none",
  3100. apex_available: [ "com.android.vndk.current" ],
  3101. }
  3102. `+vndkLibrariesTxtFiles("current"),
  3103. withNativeBridgeEnabled)
  3104. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3105. "lib/libvndk.so",
  3106. "lib64/libvndk.so",
  3107. "lib/libc++.so",
  3108. "lib64/libc++.so",
  3109. "etc/*",
  3110. })
  3111. }
  3112. func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
  3113. testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
  3114. apex_vndk {
  3115. name: "com.android.vndk.current",
  3116. key: "com.android.vndk.current.key",
  3117. file_contexts: ":myapex-file_contexts",
  3118. native_bridge_supported: true,
  3119. }
  3120. apex_key {
  3121. name: "com.android.vndk.current.key",
  3122. public_key: "testkey.avbpubkey",
  3123. private_key: "testkey.pem",
  3124. }
  3125. cc_library {
  3126. name: "libvndk",
  3127. srcs: ["mylib.cpp"],
  3128. vendor_available: true,
  3129. product_available: true,
  3130. native_bridge_supported: true,
  3131. host_supported: true,
  3132. vndk: {
  3133. enabled: true,
  3134. },
  3135. system_shared_libs: [],
  3136. stl: "none",
  3137. }
  3138. `)
  3139. }
  3140. func TestVndkApexWithBinder32(t *testing.T) {
  3141. ctx := testApex(t, `
  3142. apex_vndk {
  3143. name: "com.android.vndk.v27",
  3144. key: "myapex.key",
  3145. file_contexts: ":myapex-file_contexts",
  3146. vndk_version: "27",
  3147. updatable: false,
  3148. }
  3149. apex_key {
  3150. name: "myapex.key",
  3151. public_key: "testkey.avbpubkey",
  3152. private_key: "testkey.pem",
  3153. }
  3154. vndk_prebuilt_shared {
  3155. name: "libvndk27",
  3156. version: "27",
  3157. target_arch: "arm",
  3158. vendor_available: true,
  3159. product_available: true,
  3160. vndk: {
  3161. enabled: true,
  3162. },
  3163. arch: {
  3164. arm: {
  3165. srcs: ["libvndk27.so"],
  3166. }
  3167. },
  3168. }
  3169. vndk_prebuilt_shared {
  3170. name: "libvndk27",
  3171. version: "27",
  3172. target_arch: "arm",
  3173. binder32bit: true,
  3174. vendor_available: true,
  3175. product_available: true,
  3176. vndk: {
  3177. enabled: true,
  3178. },
  3179. arch: {
  3180. arm: {
  3181. srcs: ["libvndk27binder32.so"],
  3182. }
  3183. },
  3184. apex_available: [ "com.android.vndk.v27" ],
  3185. }
  3186. `+vndkLibrariesTxtFiles("27"),
  3187. withFiles(map[string][]byte{
  3188. "libvndk27.so": nil,
  3189. "libvndk27binder32.so": nil,
  3190. }),
  3191. withBinder32bit,
  3192. withTargets(map[android.OsType][]android.Target{
  3193. android.Android: []android.Target{
  3194. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  3195. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  3196. },
  3197. }),
  3198. )
  3199. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3200. "lib/libvndk27binder32.so",
  3201. "etc/*",
  3202. })
  3203. }
  3204. func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
  3205. ctx := testApex(t, `
  3206. apex_vndk {
  3207. name: "com.android.vndk.current",
  3208. key: "com.android.vndk.current.key",
  3209. file_contexts: ":myapex-file_contexts",
  3210. updatable: false,
  3211. }
  3212. apex_key {
  3213. name: "com.android.vndk.current.key",
  3214. public_key: "testkey.avbpubkey",
  3215. private_key: "testkey.pem",
  3216. }
  3217. cc_library {
  3218. name: "libz",
  3219. vendor_available: true,
  3220. product_available: true,
  3221. vndk: {
  3222. enabled: true,
  3223. },
  3224. stubs: {
  3225. symbol_file: "libz.map.txt",
  3226. versions: ["30"],
  3227. }
  3228. }
  3229. `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
  3230. "libz.map.txt": nil,
  3231. }))
  3232. apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
  3233. provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
  3234. ensureListEmpty(t, provideNativeLibs)
  3235. }
  3236. func TestDependenciesInApexManifest(t *testing.T) {
  3237. ctx := testApex(t, `
  3238. apex {
  3239. name: "myapex_nodep",
  3240. key: "myapex.key",
  3241. native_shared_libs: ["lib_nodep"],
  3242. compile_multilib: "both",
  3243. file_contexts: ":myapex-file_contexts",
  3244. updatable: false,
  3245. }
  3246. apex {
  3247. name: "myapex_dep",
  3248. key: "myapex.key",
  3249. native_shared_libs: ["lib_dep"],
  3250. compile_multilib: "both",
  3251. file_contexts: ":myapex-file_contexts",
  3252. updatable: false,
  3253. }
  3254. apex {
  3255. name: "myapex_provider",
  3256. key: "myapex.key",
  3257. native_shared_libs: ["libfoo"],
  3258. compile_multilib: "both",
  3259. file_contexts: ":myapex-file_contexts",
  3260. updatable: false,
  3261. }
  3262. apex {
  3263. name: "myapex_selfcontained",
  3264. key: "myapex.key",
  3265. native_shared_libs: ["lib_dep", "libfoo"],
  3266. compile_multilib: "both",
  3267. file_contexts: ":myapex-file_contexts",
  3268. updatable: false,
  3269. }
  3270. apex_key {
  3271. name: "myapex.key",
  3272. public_key: "testkey.avbpubkey",
  3273. private_key: "testkey.pem",
  3274. }
  3275. cc_library {
  3276. name: "lib_nodep",
  3277. srcs: ["mylib.cpp"],
  3278. system_shared_libs: [],
  3279. stl: "none",
  3280. apex_available: [ "myapex_nodep" ],
  3281. }
  3282. cc_library {
  3283. name: "lib_dep",
  3284. srcs: ["mylib.cpp"],
  3285. shared_libs: ["libfoo"],
  3286. system_shared_libs: [],
  3287. stl: "none",
  3288. apex_available: [
  3289. "myapex_dep",
  3290. "myapex_provider",
  3291. "myapex_selfcontained",
  3292. ],
  3293. }
  3294. cc_library {
  3295. name: "libfoo",
  3296. srcs: ["mytest.cpp"],
  3297. stubs: {
  3298. versions: ["1"],
  3299. },
  3300. system_shared_libs: [],
  3301. stl: "none",
  3302. apex_available: [
  3303. "myapex_provider",
  3304. "myapex_selfcontained",
  3305. ],
  3306. }
  3307. `)
  3308. var apexManifestRule android.TestingBuildParams
  3309. var provideNativeLibs, requireNativeLibs []string
  3310. apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
  3311. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3312. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3313. ensureListEmpty(t, provideNativeLibs)
  3314. ensureListEmpty(t, requireNativeLibs)
  3315. apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
  3316. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3317. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3318. ensureListEmpty(t, provideNativeLibs)
  3319. ensureListContains(t, requireNativeLibs, "libfoo.so")
  3320. apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
  3321. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3322. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3323. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3324. ensureListEmpty(t, requireNativeLibs)
  3325. apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
  3326. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3327. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3328. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3329. ensureListEmpty(t, requireNativeLibs)
  3330. }
  3331. func TestApexName(t *testing.T) {
  3332. ctx := testApex(t, `
  3333. apex {
  3334. name: "myapex",
  3335. key: "myapex.key",
  3336. apex_name: "com.android.myapex",
  3337. native_shared_libs: ["mylib"],
  3338. updatable: false,
  3339. }
  3340. apex_key {
  3341. name: "myapex.key",
  3342. public_key: "testkey.avbpubkey",
  3343. private_key: "testkey.pem",
  3344. }
  3345. cc_library {
  3346. name: "mylib",
  3347. srcs: ["mylib.cpp"],
  3348. system_shared_libs: [],
  3349. stl: "none",
  3350. apex_available: [
  3351. "//apex_available:platform",
  3352. "myapex",
  3353. ],
  3354. }
  3355. `)
  3356. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3357. apexManifestRule := module.Rule("apexManifestRule")
  3358. ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
  3359. apexRule := module.Rule("apexRule")
  3360. ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
  3361. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  3362. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  3363. name := apexBundle.BaseModuleName()
  3364. prefix := "TARGET_"
  3365. var builder strings.Builder
  3366. data.Custom(&builder, name, prefix, "", data)
  3367. androidMk := builder.String()
  3368. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  3369. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  3370. }
  3371. func TestNonTestApex(t *testing.T) {
  3372. ctx := testApex(t, `
  3373. apex {
  3374. name: "myapex",
  3375. key: "myapex.key",
  3376. native_shared_libs: ["mylib_common"],
  3377. updatable: false,
  3378. }
  3379. apex_key {
  3380. name: "myapex.key",
  3381. public_key: "testkey.avbpubkey",
  3382. private_key: "testkey.pem",
  3383. }
  3384. cc_library {
  3385. name: "mylib_common",
  3386. srcs: ["mylib.cpp"],
  3387. system_shared_libs: [],
  3388. stl: "none",
  3389. apex_available: [
  3390. "//apex_available:platform",
  3391. "myapex",
  3392. ],
  3393. }
  3394. `)
  3395. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3396. apexRule := module.Rule("apexRule")
  3397. copyCmds := apexRule.Args["copy_commands"]
  3398. if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
  3399. t.Log("Apex was a test apex!")
  3400. t.Fail()
  3401. }
  3402. // Ensure that main rule creates an output
  3403. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3404. // Ensure that apex variant is created for the direct dep
  3405. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3406. // Ensure that both direct and indirect deps are copied into apex
  3407. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3408. // Ensure that the platform variant ends with _shared
  3409. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3410. if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
  3411. t.Log("Found mylib_common not in any apex!")
  3412. t.Fail()
  3413. }
  3414. }
  3415. func TestTestApex(t *testing.T) {
  3416. ctx := testApex(t, `
  3417. apex_test {
  3418. name: "myapex",
  3419. key: "myapex.key",
  3420. native_shared_libs: ["mylib_common_test"],
  3421. updatable: false,
  3422. }
  3423. apex_key {
  3424. name: "myapex.key",
  3425. public_key: "testkey.avbpubkey",
  3426. private_key: "testkey.pem",
  3427. }
  3428. cc_library {
  3429. name: "mylib_common_test",
  3430. srcs: ["mylib.cpp"],
  3431. system_shared_libs: [],
  3432. stl: "none",
  3433. // TODO: remove //apex_available:platform
  3434. apex_available: [
  3435. "//apex_available:platform",
  3436. "myapex",
  3437. ],
  3438. }
  3439. `)
  3440. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3441. apexRule := module.Rule("apexRule")
  3442. copyCmds := apexRule.Args["copy_commands"]
  3443. if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
  3444. t.Log("Apex was not a test apex!")
  3445. t.Fail()
  3446. }
  3447. // Ensure that main rule creates an output
  3448. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3449. // Ensure that apex variant is created for the direct dep
  3450. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
  3451. // Ensure that both direct and indirect deps are copied into apex
  3452. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
  3453. // Ensure that the platform variant ends with _shared
  3454. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
  3455. }
  3456. func TestApexWithTarget(t *testing.T) {
  3457. ctx := testApex(t, `
  3458. apex {
  3459. name: "myapex",
  3460. key: "myapex.key",
  3461. updatable: false,
  3462. multilib: {
  3463. first: {
  3464. native_shared_libs: ["mylib_common"],
  3465. }
  3466. },
  3467. target: {
  3468. android: {
  3469. multilib: {
  3470. first: {
  3471. native_shared_libs: ["mylib"],
  3472. }
  3473. }
  3474. },
  3475. host: {
  3476. multilib: {
  3477. first: {
  3478. native_shared_libs: ["mylib2"],
  3479. }
  3480. }
  3481. }
  3482. }
  3483. }
  3484. apex_key {
  3485. name: "myapex.key",
  3486. public_key: "testkey.avbpubkey",
  3487. private_key: "testkey.pem",
  3488. }
  3489. cc_library {
  3490. name: "mylib",
  3491. srcs: ["mylib.cpp"],
  3492. system_shared_libs: [],
  3493. stl: "none",
  3494. // TODO: remove //apex_available:platform
  3495. apex_available: [
  3496. "//apex_available:platform",
  3497. "myapex",
  3498. ],
  3499. }
  3500. cc_library {
  3501. name: "mylib_common",
  3502. srcs: ["mylib.cpp"],
  3503. system_shared_libs: [],
  3504. stl: "none",
  3505. compile_multilib: "first",
  3506. // TODO: remove //apex_available:platform
  3507. apex_available: [
  3508. "//apex_available:platform",
  3509. "myapex",
  3510. ],
  3511. }
  3512. cc_library {
  3513. name: "mylib2",
  3514. srcs: ["mylib.cpp"],
  3515. system_shared_libs: [],
  3516. stl: "none",
  3517. compile_multilib: "first",
  3518. }
  3519. `)
  3520. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3521. copyCmds := apexRule.Args["copy_commands"]
  3522. // Ensure that main rule creates an output
  3523. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3524. // Ensure that apex variant is created for the direct dep
  3525. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  3526. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3527. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  3528. // Ensure that both direct and indirect deps are copied into apex
  3529. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  3530. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3531. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  3532. // Ensure that the platform variant ends with _shared
  3533. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  3534. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3535. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  3536. }
  3537. func TestApexWithArch(t *testing.T) {
  3538. ctx := testApex(t, `
  3539. apex {
  3540. name: "myapex",
  3541. key: "myapex.key",
  3542. updatable: false,
  3543. arch: {
  3544. arm64: {
  3545. native_shared_libs: ["mylib.arm64"],
  3546. },
  3547. x86_64: {
  3548. native_shared_libs: ["mylib.x64"],
  3549. },
  3550. }
  3551. }
  3552. apex_key {
  3553. name: "myapex.key",
  3554. public_key: "testkey.avbpubkey",
  3555. private_key: "testkey.pem",
  3556. }
  3557. cc_library {
  3558. name: "mylib.arm64",
  3559. srcs: ["mylib.cpp"],
  3560. system_shared_libs: [],
  3561. stl: "none",
  3562. // TODO: remove //apex_available:platform
  3563. apex_available: [
  3564. "//apex_available:platform",
  3565. "myapex",
  3566. ],
  3567. }
  3568. cc_library {
  3569. name: "mylib.x64",
  3570. srcs: ["mylib.cpp"],
  3571. system_shared_libs: [],
  3572. stl: "none",
  3573. // TODO: remove //apex_available:platform
  3574. apex_available: [
  3575. "//apex_available:platform",
  3576. "myapex",
  3577. ],
  3578. }
  3579. `)
  3580. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3581. copyCmds := apexRule.Args["copy_commands"]
  3582. // Ensure that apex variant is created for the direct dep
  3583. ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
  3584. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
  3585. // Ensure that both direct and indirect deps are copied into apex
  3586. ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
  3587. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
  3588. }
  3589. func TestApexWithShBinary(t *testing.T) {
  3590. ctx := testApex(t, `
  3591. apex {
  3592. name: "myapex",
  3593. key: "myapex.key",
  3594. binaries: ["myscript"],
  3595. updatable: false,
  3596. }
  3597. apex_key {
  3598. name: "myapex.key",
  3599. public_key: "testkey.avbpubkey",
  3600. private_key: "testkey.pem",
  3601. }
  3602. sh_binary {
  3603. name: "myscript",
  3604. src: "mylib.cpp",
  3605. filename: "myscript.sh",
  3606. sub_dir: "script",
  3607. }
  3608. `)
  3609. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3610. copyCmds := apexRule.Args["copy_commands"]
  3611. ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
  3612. }
  3613. func TestApexInVariousPartition(t *testing.T) {
  3614. testcases := []struct {
  3615. propName, parition, flattenedPartition string
  3616. }{
  3617. {"", "system", "system_ext"},
  3618. {"product_specific: true", "product", "product"},
  3619. {"soc_specific: true", "vendor", "vendor"},
  3620. {"proprietary: true", "vendor", "vendor"},
  3621. {"vendor: true", "vendor", "vendor"},
  3622. {"system_ext_specific: true", "system_ext", "system_ext"},
  3623. }
  3624. for _, tc := range testcases {
  3625. t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
  3626. ctx := testApex(t, `
  3627. apex {
  3628. name: "myapex",
  3629. key: "myapex.key",
  3630. updatable: false,
  3631. `+tc.propName+`
  3632. }
  3633. apex_key {
  3634. name: "myapex.key",
  3635. public_key: "testkey.avbpubkey",
  3636. private_key: "testkey.pem",
  3637. }
  3638. `)
  3639. apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  3640. expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
  3641. actual := apex.installDir.RelativeToTop().String()
  3642. if actual != expected {
  3643. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3644. }
  3645. flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  3646. expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
  3647. actual = flattened.installDir.RelativeToTop().String()
  3648. if actual != expected {
  3649. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3650. }
  3651. })
  3652. }
  3653. }
  3654. func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
  3655. ctx := testApex(t, `
  3656. apex {
  3657. name: "myapex",
  3658. key: "myapex.key",
  3659. updatable: false,
  3660. }
  3661. apex_key {
  3662. name: "myapex.key",
  3663. public_key: "testkey.avbpubkey",
  3664. private_key: "testkey.pem",
  3665. }
  3666. `)
  3667. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3668. rule := module.Output("file_contexts")
  3669. ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
  3670. }
  3671. func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
  3672. testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
  3673. apex {
  3674. name: "myapex",
  3675. key: "myapex.key",
  3676. file_contexts: "my_own_file_contexts",
  3677. updatable: false,
  3678. }
  3679. apex_key {
  3680. name: "myapex.key",
  3681. public_key: "testkey.avbpubkey",
  3682. private_key: "testkey.pem",
  3683. }
  3684. `, withFiles(map[string][]byte{
  3685. "my_own_file_contexts": nil,
  3686. }))
  3687. }
  3688. func TestFileContexts_ProductSpecificApexes(t *testing.T) {
  3689. testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
  3690. apex {
  3691. name: "myapex",
  3692. key: "myapex.key",
  3693. product_specific: true,
  3694. file_contexts: "product_specific_file_contexts",
  3695. updatable: false,
  3696. }
  3697. apex_key {
  3698. name: "myapex.key",
  3699. public_key: "testkey.avbpubkey",
  3700. private_key: "testkey.pem",
  3701. }
  3702. `)
  3703. ctx := testApex(t, `
  3704. apex {
  3705. name: "myapex",
  3706. key: "myapex.key",
  3707. product_specific: true,
  3708. file_contexts: "product_specific_file_contexts",
  3709. updatable: false,
  3710. }
  3711. apex_key {
  3712. name: "myapex.key",
  3713. public_key: "testkey.avbpubkey",
  3714. private_key: "testkey.pem",
  3715. }
  3716. `, withFiles(map[string][]byte{
  3717. "product_specific_file_contexts": nil,
  3718. }))
  3719. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3720. rule := module.Output("file_contexts")
  3721. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  3722. }
  3723. func TestFileContexts_SetViaFileGroup(t *testing.T) {
  3724. ctx := testApex(t, `
  3725. apex {
  3726. name: "myapex",
  3727. key: "myapex.key",
  3728. product_specific: true,
  3729. file_contexts: ":my-file-contexts",
  3730. updatable: false,
  3731. }
  3732. apex_key {
  3733. name: "myapex.key",
  3734. public_key: "testkey.avbpubkey",
  3735. private_key: "testkey.pem",
  3736. }
  3737. filegroup {
  3738. name: "my-file-contexts",
  3739. srcs: ["product_specific_file_contexts"],
  3740. }
  3741. `, withFiles(map[string][]byte{
  3742. "product_specific_file_contexts": nil,
  3743. }))
  3744. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3745. rule := module.Output("file_contexts")
  3746. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  3747. }
  3748. func TestApexKeyFromOtherModule(t *testing.T) {
  3749. ctx := testApex(t, `
  3750. apex_key {
  3751. name: "myapex.key",
  3752. public_key: ":my.avbpubkey",
  3753. private_key: ":my.pem",
  3754. product_specific: true,
  3755. }
  3756. filegroup {
  3757. name: "my.avbpubkey",
  3758. srcs: ["testkey2.avbpubkey"],
  3759. }
  3760. filegroup {
  3761. name: "my.pem",
  3762. srcs: ["testkey2.pem"],
  3763. }
  3764. `)
  3765. apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  3766. expected_pubkey := "testkey2.avbpubkey"
  3767. actual_pubkey := apex_key.publicKeyFile.String()
  3768. if actual_pubkey != expected_pubkey {
  3769. t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
  3770. }
  3771. expected_privkey := "testkey2.pem"
  3772. actual_privkey := apex_key.privateKeyFile.String()
  3773. if actual_privkey != expected_privkey {
  3774. t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
  3775. }
  3776. }
  3777. func TestPrebuilt(t *testing.T) {
  3778. ctx := testApex(t, `
  3779. prebuilt_apex {
  3780. name: "myapex",
  3781. arch: {
  3782. arm64: {
  3783. src: "myapex-arm64.apex",
  3784. },
  3785. arm: {
  3786. src: "myapex-arm.apex",
  3787. },
  3788. },
  3789. }
  3790. `)
  3791. prebuilt := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
  3792. expectedInput := "myapex-arm64.apex"
  3793. if prebuilt.inputApex.String() != expectedInput {
  3794. t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
  3795. }
  3796. }
  3797. func TestPrebuiltFilenameOverride(t *testing.T) {
  3798. ctx := testApex(t, `
  3799. prebuilt_apex {
  3800. name: "myapex",
  3801. src: "myapex-arm.apex",
  3802. filename: "notmyapex.apex",
  3803. }
  3804. `)
  3805. p := ctx.ModuleForTests("myapex", "android_common").Module().(*Prebuilt)
  3806. expected := "notmyapex.apex"
  3807. if p.installFilename != expected {
  3808. t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
  3809. }
  3810. }
  3811. func TestPrebuiltOverrides(t *testing.T) {
  3812. ctx := testApex(t, `
  3813. prebuilt_apex {
  3814. name: "myapex.prebuilt",
  3815. src: "myapex-arm.apex",
  3816. overrides: [
  3817. "myapex",
  3818. ],
  3819. }
  3820. `)
  3821. p := ctx.ModuleForTests("myapex.prebuilt", "android_common").Module().(*Prebuilt)
  3822. expected := []string{"myapex"}
  3823. actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  3824. if !reflect.DeepEqual(actual, expected) {
  3825. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
  3826. }
  3827. }
  3828. // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
  3829. // propagation of paths to dex implementation jars from the former to the latter.
  3830. func TestPrebuiltExportDexImplementationJars(t *testing.T) {
  3831. transform := func(config *dexpreopt.GlobalConfig) {
  3832. // Empty transformation.
  3833. }
  3834. checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
  3835. // Make sure the import has been given the correct path to the dex jar.
  3836. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  3837. dexJarBuildPath := p.DexJarBuildPath()
  3838. stem := android.RemoveOptionalPrebuiltPrefix(name)
  3839. if expected, actual := ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar", android.NormalizePathForTesting(dexJarBuildPath); actual != expected {
  3840. t.Errorf("Incorrect DexJarBuildPath value '%s', expected '%s'", actual, expected)
  3841. }
  3842. }
  3843. ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
  3844. // Make sure that an apex variant is not created for the source module.
  3845. if expected, actual := []string{"android_common"}, ctx.ModuleVariantsForTests(name); !reflect.DeepEqual(expected, actual) {
  3846. t.Errorf("invalid set of variants for %q: expected %q, found %q", "libfoo", expected, actual)
  3847. }
  3848. }
  3849. t.Run("prebuilt only", func(t *testing.T) {
  3850. bp := `
  3851. prebuilt_apex {
  3852. name: "myapex",
  3853. arch: {
  3854. arm64: {
  3855. src: "myapex-arm64.apex",
  3856. },
  3857. arm: {
  3858. src: "myapex-arm.apex",
  3859. },
  3860. },
  3861. exported_java_libs: ["libfoo", "libbar"],
  3862. }
  3863. java_import {
  3864. name: "libfoo",
  3865. jars: ["libfoo.jar"],
  3866. }
  3867. java_sdk_library_import {
  3868. name: "libbar",
  3869. public: {
  3870. jars: ["libbar.jar"],
  3871. },
  3872. }
  3873. `
  3874. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  3875. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  3876. // Make sure that the deapexer has the correct input APEX.
  3877. deapexer := ctx.ModuleForTests("myapex.deapexer", "android_common")
  3878. rule := deapexer.Rule("deapexer")
  3879. if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
  3880. t.Errorf("expected: %q, found: %q", expected, actual)
  3881. }
  3882. // Make sure that the prebuilt_apex has the correct input APEX.
  3883. prebuiltApex := ctx.ModuleForTests("myapex", "android_common")
  3884. rule = prebuiltApex.Rule("android/soong/android.Cp")
  3885. if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
  3886. t.Errorf("expected: %q, found: %q", expected, actual)
  3887. }
  3888. checkDexJarBuildPath(t, ctx, "libfoo")
  3889. checkDexJarBuildPath(t, ctx, "libbar")
  3890. })
  3891. t.Run("prebuilt with source preferred", func(t *testing.T) {
  3892. bp := `
  3893. prebuilt_apex {
  3894. name: "myapex",
  3895. arch: {
  3896. arm64: {
  3897. src: "myapex-arm64.apex",
  3898. },
  3899. arm: {
  3900. src: "myapex-arm.apex",
  3901. },
  3902. },
  3903. exported_java_libs: ["libfoo", "libbar"],
  3904. }
  3905. java_import {
  3906. name: "libfoo",
  3907. jars: ["libfoo.jar"],
  3908. }
  3909. java_library {
  3910. name: "libfoo",
  3911. }
  3912. java_sdk_library_import {
  3913. name: "libbar",
  3914. public: {
  3915. jars: ["libbar.jar"],
  3916. },
  3917. }
  3918. java_sdk_library {
  3919. name: "libbar",
  3920. srcs: ["foo/bar/MyClass.java"],
  3921. unsafe_ignore_missing_latest_api: true,
  3922. }
  3923. `
  3924. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  3925. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  3926. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  3927. ensureNoSourceVariant(t, ctx, "libfoo")
  3928. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  3929. ensureNoSourceVariant(t, ctx, "libbar")
  3930. })
  3931. t.Run("prebuilt preferred with source", func(t *testing.T) {
  3932. bp := `
  3933. prebuilt_apex {
  3934. name: "myapex",
  3935. arch: {
  3936. arm64: {
  3937. src: "myapex-arm64.apex",
  3938. },
  3939. arm: {
  3940. src: "myapex-arm.apex",
  3941. },
  3942. },
  3943. exported_java_libs: ["libfoo", "libbar"],
  3944. }
  3945. java_import {
  3946. name: "libfoo",
  3947. prefer: true,
  3948. jars: ["libfoo.jar"],
  3949. }
  3950. java_library {
  3951. name: "libfoo",
  3952. }
  3953. java_sdk_library_import {
  3954. name: "libbar",
  3955. prefer: true,
  3956. public: {
  3957. jars: ["libbar.jar"],
  3958. },
  3959. }
  3960. java_sdk_library {
  3961. name: "libbar",
  3962. srcs: ["foo/bar/MyClass.java"],
  3963. unsafe_ignore_missing_latest_api: true,
  3964. }
  3965. `
  3966. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  3967. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  3968. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  3969. ensureNoSourceVariant(t, ctx, "libfoo")
  3970. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  3971. ensureNoSourceVariant(t, ctx, "libbar")
  3972. })
  3973. }
  3974. func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
  3975. transform := func(config *dexpreopt.GlobalConfig) {
  3976. config.BootJars = android.CreateTestConfiguredJarList([]string{"myapex:libfoo", "myapex:libbar"})
  3977. }
  3978. checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
  3979. t.Helper()
  3980. s := ctx.SingletonForTests("dex_bootjars")
  3981. foundLibfooJar := false
  3982. base := stem + ".jar"
  3983. for _, output := range s.AllOutputs() {
  3984. if filepath.Base(output) == base {
  3985. foundLibfooJar = true
  3986. buildRule := s.Output(output)
  3987. actual := android.NormalizePathForTesting(buildRule.Input)
  3988. if actual != bootDexJarPath {
  3989. t.Errorf("Incorrect boot dex jar path '%s', expected '%s'", actual, bootDexJarPath)
  3990. }
  3991. }
  3992. }
  3993. if !foundLibfooJar {
  3994. t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs")
  3995. }
  3996. }
  3997. checkHiddenAPIIndexInputs := func(t *testing.T, ctx *android.TestContext, expectedInputs string) {
  3998. t.Helper()
  3999. hiddenAPIIndex := ctx.SingletonForTests("hiddenapi_index")
  4000. indexRule := hiddenAPIIndex.Rule("singleton-merged-hiddenapi-index")
  4001. java.CheckHiddenAPIRuleInputs(t, expectedInputs, indexRule)
  4002. }
  4003. t.Run("prebuilt only", func(t *testing.T) {
  4004. bp := `
  4005. prebuilt_apex {
  4006. name: "myapex",
  4007. arch: {
  4008. arm64: {
  4009. src: "myapex-arm64.apex",
  4010. },
  4011. arm: {
  4012. src: "myapex-arm.apex",
  4013. },
  4014. },
  4015. exported_java_libs: ["libfoo", "libbar"],
  4016. }
  4017. java_import {
  4018. name: "libfoo",
  4019. jars: ["libfoo.jar"],
  4020. apex_available: ["myapex"],
  4021. }
  4022. java_sdk_library_import {
  4023. name: "libbar",
  4024. public: {
  4025. jars: ["libbar.jar"],
  4026. },
  4027. apex_available: ["myapex"],
  4028. }
  4029. `
  4030. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4031. checkBootDexJarPath(t, ctx, "libfoo", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4032. checkBootDexJarPath(t, ctx, "libbar", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4033. // Make sure that the dex file from the prebuilt_apex contributes to the hiddenapi index file.
  4034. checkHiddenAPIIndexInputs(t, ctx, `
  4035. .intermediates/libbar/android_common_myapex/hiddenapi/index.csv
  4036. .intermediates/libfoo/android_common_myapex/hiddenapi/index.csv
  4037. `)
  4038. })
  4039. t.Run("prebuilt with source library preferred", func(t *testing.T) {
  4040. bp := `
  4041. prebuilt_apex {
  4042. name: "myapex",
  4043. arch: {
  4044. arm64: {
  4045. src: "myapex-arm64.apex",
  4046. },
  4047. arm: {
  4048. src: "myapex-arm.apex",
  4049. },
  4050. },
  4051. exported_java_libs: ["libfoo", "libbar"],
  4052. }
  4053. java_import {
  4054. name: "libfoo",
  4055. jars: ["libfoo.jar"],
  4056. apex_available: ["myapex"],
  4057. }
  4058. java_library {
  4059. name: "libfoo",
  4060. srcs: ["foo/bar/MyClass.java"],
  4061. apex_available: ["myapex"],
  4062. }
  4063. java_sdk_library_import {
  4064. name: "libbar",
  4065. public: {
  4066. jars: ["libbar.jar"],
  4067. },
  4068. apex_available: ["myapex"],
  4069. }
  4070. java_sdk_library {
  4071. name: "libbar",
  4072. srcs: ["foo/bar/MyClass.java"],
  4073. unsafe_ignore_missing_latest_api: true,
  4074. apex_available: ["myapex"],
  4075. }
  4076. `
  4077. // In this test the source (java_library) libfoo is active since the
  4078. // prebuilt (java_import) defaults to prefer:false. However the
  4079. // prebuilt_apex module always depends on the prebuilt, and so it doesn't
  4080. // find the dex boot jar in it. We either need to disable the source libfoo
  4081. // or make the prebuilt libfoo preferred.
  4082. testDexpreoptWithApexes(t, bp, "failed to find a dex jar path for module 'libfoo'", transform)
  4083. })
  4084. t.Run("prebuilt library preferred with source", func(t *testing.T) {
  4085. bp := `
  4086. prebuilt_apex {
  4087. name: "myapex",
  4088. arch: {
  4089. arm64: {
  4090. src: "myapex-arm64.apex",
  4091. },
  4092. arm: {
  4093. src: "myapex-arm.apex",
  4094. },
  4095. },
  4096. exported_java_libs: ["libfoo", "libbar"],
  4097. }
  4098. java_import {
  4099. name: "libfoo",
  4100. prefer: true,
  4101. jars: ["libfoo.jar"],
  4102. apex_available: ["myapex"],
  4103. }
  4104. java_library {
  4105. name: "libfoo",
  4106. srcs: ["foo/bar/MyClass.java"],
  4107. apex_available: ["myapex"],
  4108. }
  4109. java_sdk_library_import {
  4110. name: "libbar",
  4111. prefer: true,
  4112. public: {
  4113. jars: ["libbar.jar"],
  4114. },
  4115. apex_available: ["myapex"],
  4116. }
  4117. java_sdk_library {
  4118. name: "libbar",
  4119. srcs: ["foo/bar/MyClass.java"],
  4120. unsafe_ignore_missing_latest_api: true,
  4121. apex_available: ["myapex"],
  4122. }
  4123. `
  4124. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4125. checkBootDexJarPath(t, ctx, "libfoo", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4126. checkBootDexJarPath(t, ctx, "libbar", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4127. // Make sure that the dex file from the prebuilt_apex contributes to the hiddenapi index file.
  4128. checkHiddenAPIIndexInputs(t, ctx, `
  4129. .intermediates/prebuilt_libbar/android_common_myapex/hiddenapi/index.csv
  4130. .intermediates/prebuilt_libfoo/android_common_myapex/hiddenapi/index.csv
  4131. `)
  4132. })
  4133. t.Run("prebuilt with source apex preferred", func(t *testing.T) {
  4134. bp := `
  4135. apex {
  4136. name: "myapex",
  4137. key: "myapex.key",
  4138. java_libs: ["libfoo", "libbar"],
  4139. updatable: false,
  4140. }
  4141. apex_key {
  4142. name: "myapex.key",
  4143. public_key: "testkey.avbpubkey",
  4144. private_key: "testkey.pem",
  4145. }
  4146. prebuilt_apex {
  4147. name: "myapex",
  4148. arch: {
  4149. arm64: {
  4150. src: "myapex-arm64.apex",
  4151. },
  4152. arm: {
  4153. src: "myapex-arm.apex",
  4154. },
  4155. },
  4156. exported_java_libs: ["libfoo", "libbar"],
  4157. }
  4158. java_import {
  4159. name: "libfoo",
  4160. jars: ["libfoo.jar"],
  4161. apex_available: ["myapex"],
  4162. }
  4163. java_library {
  4164. name: "libfoo",
  4165. srcs: ["foo/bar/MyClass.java"],
  4166. apex_available: ["myapex"],
  4167. }
  4168. java_sdk_library_import {
  4169. name: "libbar",
  4170. public: {
  4171. jars: ["libbar.jar"],
  4172. },
  4173. apex_available: ["myapex"],
  4174. }
  4175. java_sdk_library {
  4176. name: "libbar",
  4177. srcs: ["foo/bar/MyClass.java"],
  4178. unsafe_ignore_missing_latest_api: true,
  4179. apex_available: ["myapex"],
  4180. }
  4181. `
  4182. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4183. checkBootDexJarPath(t, ctx, "libfoo", ".intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
  4184. checkBootDexJarPath(t, ctx, "libbar", ".intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
  4185. // Make sure that the dex file from the prebuilt_apex contributes to the hiddenapi index file.
  4186. checkHiddenAPIIndexInputs(t, ctx, `
  4187. .intermediates/libbar/android_common_myapex/hiddenapi/index.csv
  4188. .intermediates/libfoo/android_common_apex10000/hiddenapi/index.csv
  4189. `)
  4190. })
  4191. t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
  4192. bp := `
  4193. apex {
  4194. name: "myapex",
  4195. enabled: false,
  4196. key: "myapex.key",
  4197. java_libs: ["libfoo"],
  4198. }
  4199. apex_key {
  4200. name: "myapex.key",
  4201. public_key: "testkey.avbpubkey",
  4202. private_key: "testkey.pem",
  4203. }
  4204. prebuilt_apex {
  4205. name: "myapex",
  4206. arch: {
  4207. arm64: {
  4208. src: "myapex-arm64.apex",
  4209. },
  4210. arm: {
  4211. src: "myapex-arm.apex",
  4212. },
  4213. },
  4214. exported_java_libs: ["libfoo", "libbar"],
  4215. }
  4216. java_import {
  4217. name: "libfoo",
  4218. prefer: true,
  4219. jars: ["libfoo.jar"],
  4220. apex_available: ["myapex"],
  4221. }
  4222. java_library {
  4223. name: "libfoo",
  4224. srcs: ["foo/bar/MyClass.java"],
  4225. apex_available: ["myapex"],
  4226. }
  4227. java_sdk_library_import {
  4228. name: "libbar",
  4229. prefer: true,
  4230. public: {
  4231. jars: ["libbar.jar"],
  4232. },
  4233. apex_available: ["myapex"],
  4234. }
  4235. java_sdk_library {
  4236. name: "libbar",
  4237. srcs: ["foo/bar/MyClass.java"],
  4238. unsafe_ignore_missing_latest_api: true,
  4239. apex_available: ["myapex"],
  4240. }
  4241. `
  4242. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4243. checkBootDexJarPath(t, ctx, "libfoo", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4244. checkBootDexJarPath(t, ctx, "libbar", ".intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4245. // Make sure that the dex file from the prebuilt_apex contributes to the hiddenapi index file.
  4246. checkHiddenAPIIndexInputs(t, ctx, `
  4247. .intermediates/prebuilt_libbar/android_common_prebuilt_myapex/hiddenapi/index.csv
  4248. .intermediates/prebuilt_libfoo/android_common_prebuilt_myapex/hiddenapi/index.csv
  4249. `)
  4250. })
  4251. }
  4252. func TestApexWithTests(t *testing.T) {
  4253. ctx := testApex(t, `
  4254. apex_test {
  4255. name: "myapex",
  4256. key: "myapex.key",
  4257. updatable: false,
  4258. tests: [
  4259. "mytest",
  4260. "mytests",
  4261. ],
  4262. }
  4263. apex_key {
  4264. name: "myapex.key",
  4265. public_key: "testkey.avbpubkey",
  4266. private_key: "testkey.pem",
  4267. }
  4268. filegroup {
  4269. name: "fg",
  4270. srcs: [
  4271. "baz",
  4272. "bar/baz"
  4273. ],
  4274. }
  4275. cc_test {
  4276. name: "mytest",
  4277. gtest: false,
  4278. srcs: ["mytest.cpp"],
  4279. relative_install_path: "test",
  4280. shared_libs: ["mylib"],
  4281. system_shared_libs: [],
  4282. static_executable: true,
  4283. stl: "none",
  4284. data: [":fg"],
  4285. }
  4286. cc_library {
  4287. name: "mylib",
  4288. srcs: ["mylib.cpp"],
  4289. system_shared_libs: [],
  4290. stl: "none",
  4291. }
  4292. filegroup {
  4293. name: "fg2",
  4294. srcs: [
  4295. "testdata/baz"
  4296. ],
  4297. }
  4298. cc_test {
  4299. name: "mytests",
  4300. gtest: false,
  4301. srcs: [
  4302. "mytest1.cpp",
  4303. "mytest2.cpp",
  4304. "mytest3.cpp",
  4305. ],
  4306. test_per_src: true,
  4307. relative_install_path: "test",
  4308. system_shared_libs: [],
  4309. static_executable: true,
  4310. stl: "none",
  4311. data: [
  4312. ":fg",
  4313. ":fg2",
  4314. ],
  4315. }
  4316. `)
  4317. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4318. copyCmds := apexRule.Args["copy_commands"]
  4319. // Ensure that test dep (and their transitive dependencies) are copied into apex.
  4320. ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
  4321. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  4322. //Ensure that test data are copied into apex.
  4323. ensureContains(t, copyCmds, "image.apex/bin/test/baz")
  4324. ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
  4325. // Ensure that test deps built with `test_per_src` are copied into apex.
  4326. ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
  4327. ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
  4328. ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
  4329. // Ensure the module is correctly translated.
  4330. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4331. data := android.AndroidMkDataForTest(t, ctx, bundle)
  4332. name := bundle.BaseModuleName()
  4333. prefix := "TARGET_"
  4334. var builder strings.Builder
  4335. data.Custom(&builder, name, prefix, "", data)
  4336. androidMk := builder.String()
  4337. ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
  4338. ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
  4339. ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
  4340. ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
  4341. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
  4342. ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
  4343. ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
  4344. flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  4345. data = android.AndroidMkDataForTest(t, ctx, flatBundle)
  4346. data.Custom(&builder, name, prefix, "", data)
  4347. flatAndroidMk := builder.String()
  4348. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
  4349. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
  4350. }
  4351. func TestInstallExtraFlattenedApexes(t *testing.T) {
  4352. ctx := testApex(t, `
  4353. apex {
  4354. name: "myapex",
  4355. key: "myapex.key",
  4356. updatable: false,
  4357. }
  4358. apex_key {
  4359. name: "myapex.key",
  4360. public_key: "testkey.avbpubkey",
  4361. private_key: "testkey.pem",
  4362. }
  4363. `,
  4364. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  4365. variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
  4366. }),
  4367. )
  4368. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4369. ensureListContains(t, ab.requiredDeps, "myapex.flattened")
  4370. mk := android.AndroidMkDataForTest(t, ctx, ab)
  4371. var builder strings.Builder
  4372. mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
  4373. androidMk := builder.String()
  4374. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
  4375. }
  4376. func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
  4377. testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
  4378. apex {
  4379. name: "myapex",
  4380. key: "myapex.key",
  4381. native_shared_libs: ["libfoo"],
  4382. }
  4383. apex_key {
  4384. name: "myapex.key",
  4385. public_key: "testkey.avbpubkey",
  4386. private_key: "testkey.pem",
  4387. }
  4388. cc_library {
  4389. name: "libfoo",
  4390. stl: "none",
  4391. system_shared_libs: [],
  4392. enabled: false,
  4393. apex_available: ["myapex"],
  4394. }
  4395. `)
  4396. testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
  4397. apex {
  4398. name: "myapex",
  4399. key: "myapex.key",
  4400. java_libs: ["myjar"],
  4401. }
  4402. apex_key {
  4403. name: "myapex.key",
  4404. public_key: "testkey.avbpubkey",
  4405. private_key: "testkey.pem",
  4406. }
  4407. java_library {
  4408. name: "myjar",
  4409. srcs: ["foo/bar/MyClass.java"],
  4410. sdk_version: "none",
  4411. system_modules: "none",
  4412. enabled: false,
  4413. apex_available: ["myapex"],
  4414. }
  4415. `)
  4416. }
  4417. func TestApexWithJavaImport(t *testing.T) {
  4418. ctx := testApex(t, `
  4419. apex {
  4420. name: "myapex",
  4421. key: "myapex.key",
  4422. java_libs: ["myjavaimport"],
  4423. updatable: false,
  4424. }
  4425. apex_key {
  4426. name: "myapex.key",
  4427. public_key: "testkey.avbpubkey",
  4428. private_key: "testkey.pem",
  4429. }
  4430. java_import {
  4431. name: "myjavaimport",
  4432. apex_available: ["myapex"],
  4433. jars: ["my.jar"],
  4434. compile_dex: true,
  4435. }
  4436. `)
  4437. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4438. apexRule := module.Rule("apexRule")
  4439. copyCmds := apexRule.Args["copy_commands"]
  4440. ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
  4441. }
  4442. func TestApexWithApps(t *testing.T) {
  4443. ctx := testApex(t, `
  4444. apex {
  4445. name: "myapex",
  4446. key: "myapex.key",
  4447. apps: [
  4448. "AppFoo",
  4449. "AppFooPriv",
  4450. ],
  4451. updatable: false,
  4452. }
  4453. apex_key {
  4454. name: "myapex.key",
  4455. public_key: "testkey.avbpubkey",
  4456. private_key: "testkey.pem",
  4457. }
  4458. android_app {
  4459. name: "AppFoo",
  4460. srcs: ["foo/bar/MyClass.java"],
  4461. sdk_version: "current",
  4462. system_modules: "none",
  4463. jni_libs: ["libjni"],
  4464. stl: "none",
  4465. apex_available: [ "myapex" ],
  4466. }
  4467. android_app {
  4468. name: "AppFooPriv",
  4469. srcs: ["foo/bar/MyClass.java"],
  4470. sdk_version: "current",
  4471. system_modules: "none",
  4472. privileged: true,
  4473. stl: "none",
  4474. apex_available: [ "myapex" ],
  4475. }
  4476. cc_library_shared {
  4477. name: "libjni",
  4478. srcs: ["mylib.cpp"],
  4479. shared_libs: ["libfoo"],
  4480. stl: "none",
  4481. system_shared_libs: [],
  4482. apex_available: [ "myapex" ],
  4483. sdk_version: "current",
  4484. }
  4485. cc_library_shared {
  4486. name: "libfoo",
  4487. stl: "none",
  4488. system_shared_libs: [],
  4489. apex_available: [ "myapex" ],
  4490. sdk_version: "current",
  4491. }
  4492. `)
  4493. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4494. apexRule := module.Rule("apexRule")
  4495. copyCmds := apexRule.Args["copy_commands"]
  4496. ensureContains(t, copyCmds, "image.apex/app/AppFoo/AppFoo.apk")
  4497. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv/AppFooPriv.apk")
  4498. appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
  4499. // JNI libraries are uncompressed
  4500. if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
  4501. t.Errorf("jni libs are not uncompressed for AppFoo")
  4502. }
  4503. // JNI libraries including transitive deps are
  4504. for _, jni := range []string{"libjni", "libfoo"} {
  4505. jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToPath()
  4506. // ... embedded inside APK (jnilibs.zip)
  4507. ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
  4508. // ... and not directly inside the APEX
  4509. ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
  4510. }
  4511. }
  4512. func TestApexWithAppImports(t *testing.T) {
  4513. ctx := testApex(t, `
  4514. apex {
  4515. name: "myapex",
  4516. key: "myapex.key",
  4517. apps: [
  4518. "AppFooPrebuilt",
  4519. "AppFooPrivPrebuilt",
  4520. ],
  4521. updatable: false,
  4522. }
  4523. apex_key {
  4524. name: "myapex.key",
  4525. public_key: "testkey.avbpubkey",
  4526. private_key: "testkey.pem",
  4527. }
  4528. android_app_import {
  4529. name: "AppFooPrebuilt",
  4530. apk: "PrebuiltAppFoo.apk",
  4531. presigned: true,
  4532. dex_preopt: {
  4533. enabled: false,
  4534. },
  4535. apex_available: ["myapex"],
  4536. }
  4537. android_app_import {
  4538. name: "AppFooPrivPrebuilt",
  4539. apk: "PrebuiltAppFooPriv.apk",
  4540. privileged: true,
  4541. presigned: true,
  4542. dex_preopt: {
  4543. enabled: false,
  4544. },
  4545. filename: "AwesomePrebuiltAppFooPriv.apk",
  4546. apex_available: ["myapex"],
  4547. }
  4548. `)
  4549. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4550. apexRule := module.Rule("apexRule")
  4551. copyCmds := apexRule.Args["copy_commands"]
  4552. ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt/AppFooPrebuilt.apk")
  4553. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt/AwesomePrebuiltAppFooPriv.apk")
  4554. }
  4555. func TestApexWithAppImportsPrefer(t *testing.T) {
  4556. ctx := testApex(t, `
  4557. apex {
  4558. name: "myapex",
  4559. key: "myapex.key",
  4560. apps: [
  4561. "AppFoo",
  4562. ],
  4563. updatable: false,
  4564. }
  4565. apex_key {
  4566. name: "myapex.key",
  4567. public_key: "testkey.avbpubkey",
  4568. private_key: "testkey.pem",
  4569. }
  4570. android_app {
  4571. name: "AppFoo",
  4572. srcs: ["foo/bar/MyClass.java"],
  4573. sdk_version: "none",
  4574. system_modules: "none",
  4575. apex_available: [ "myapex" ],
  4576. }
  4577. android_app_import {
  4578. name: "AppFoo",
  4579. apk: "AppFooPrebuilt.apk",
  4580. filename: "AppFooPrebuilt.apk",
  4581. presigned: true,
  4582. prefer: true,
  4583. apex_available: ["myapex"],
  4584. }
  4585. `, withFiles(map[string][]byte{
  4586. "AppFooPrebuilt.apk": nil,
  4587. }))
  4588. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  4589. "app/AppFoo/AppFooPrebuilt.apk",
  4590. })
  4591. }
  4592. func TestApexWithTestHelperApp(t *testing.T) {
  4593. ctx := testApex(t, `
  4594. apex {
  4595. name: "myapex",
  4596. key: "myapex.key",
  4597. apps: [
  4598. "TesterHelpAppFoo",
  4599. ],
  4600. updatable: false,
  4601. }
  4602. apex_key {
  4603. name: "myapex.key",
  4604. public_key: "testkey.avbpubkey",
  4605. private_key: "testkey.pem",
  4606. }
  4607. android_test_helper_app {
  4608. name: "TesterHelpAppFoo",
  4609. srcs: ["foo/bar/MyClass.java"],
  4610. apex_available: [ "myapex" ],
  4611. }
  4612. `)
  4613. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4614. apexRule := module.Rule("apexRule")
  4615. copyCmds := apexRule.Args["copy_commands"]
  4616. ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo/TesterHelpAppFoo.apk")
  4617. }
  4618. func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
  4619. // libfoo's apex_available comes from cc_defaults
  4620. testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
  4621. apex {
  4622. name: "myapex",
  4623. key: "myapex.key",
  4624. native_shared_libs: ["libfoo"],
  4625. updatable: false,
  4626. }
  4627. apex_key {
  4628. name: "myapex.key",
  4629. public_key: "testkey.avbpubkey",
  4630. private_key: "testkey.pem",
  4631. }
  4632. apex {
  4633. name: "otherapex",
  4634. key: "myapex.key",
  4635. native_shared_libs: ["libfoo"],
  4636. updatable: false,
  4637. }
  4638. cc_defaults {
  4639. name: "libfoo-defaults",
  4640. apex_available: ["otherapex"],
  4641. }
  4642. cc_library {
  4643. name: "libfoo",
  4644. defaults: ["libfoo-defaults"],
  4645. stl: "none",
  4646. system_shared_libs: [],
  4647. }`)
  4648. }
  4649. func TestApexAvailable_DirectDep(t *testing.T) {
  4650. // libfoo is not available to myapex, but only to otherapex
  4651. testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
  4652. apex {
  4653. name: "myapex",
  4654. key: "myapex.key",
  4655. native_shared_libs: ["libfoo"],
  4656. updatable: false,
  4657. }
  4658. apex_key {
  4659. name: "myapex.key",
  4660. public_key: "testkey.avbpubkey",
  4661. private_key: "testkey.pem",
  4662. }
  4663. apex {
  4664. name: "otherapex",
  4665. key: "otherapex.key",
  4666. native_shared_libs: ["libfoo"],
  4667. updatable: false,
  4668. }
  4669. apex_key {
  4670. name: "otherapex.key",
  4671. public_key: "testkey.avbpubkey",
  4672. private_key: "testkey.pem",
  4673. }
  4674. cc_library {
  4675. name: "libfoo",
  4676. stl: "none",
  4677. system_shared_libs: [],
  4678. apex_available: ["otherapex"],
  4679. }`)
  4680. }
  4681. func TestApexAvailable_IndirectDep(t *testing.T) {
  4682. // libbbaz is an indirect dep
  4683. testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
  4684. .*via tag apex\.dependencyTag.*name:sharedLib.*
  4685. .*-> libfoo.*link:shared.*
  4686. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  4687. .*-> libbar.*link:shared.*
  4688. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  4689. .*-> libbaz.*link:shared.*`, `
  4690. apex {
  4691. name: "myapex",
  4692. key: "myapex.key",
  4693. native_shared_libs: ["libfoo"],
  4694. updatable: false,
  4695. }
  4696. apex_key {
  4697. name: "myapex.key",
  4698. public_key: "testkey.avbpubkey",
  4699. private_key: "testkey.pem",
  4700. }
  4701. cc_library {
  4702. name: "libfoo",
  4703. stl: "none",
  4704. shared_libs: ["libbar"],
  4705. system_shared_libs: [],
  4706. apex_available: ["myapex"],
  4707. }
  4708. cc_library {
  4709. name: "libbar",
  4710. stl: "none",
  4711. shared_libs: ["libbaz"],
  4712. system_shared_libs: [],
  4713. apex_available: ["myapex"],
  4714. }
  4715. cc_library {
  4716. name: "libbaz",
  4717. stl: "none",
  4718. system_shared_libs: [],
  4719. }`)
  4720. }
  4721. func TestApexAvailable_InvalidApexName(t *testing.T) {
  4722. testApexError(t, "\"otherapex\" is not a valid module name", `
  4723. apex {
  4724. name: "myapex",
  4725. key: "myapex.key",
  4726. native_shared_libs: ["libfoo"],
  4727. updatable: false,
  4728. }
  4729. apex_key {
  4730. name: "myapex.key",
  4731. public_key: "testkey.avbpubkey",
  4732. private_key: "testkey.pem",
  4733. }
  4734. cc_library {
  4735. name: "libfoo",
  4736. stl: "none",
  4737. system_shared_libs: [],
  4738. apex_available: ["otherapex"],
  4739. }`)
  4740. testApex(t, `
  4741. apex {
  4742. name: "myapex",
  4743. key: "myapex.key",
  4744. native_shared_libs: ["libfoo", "libbar"],
  4745. updatable: false,
  4746. }
  4747. apex_key {
  4748. name: "myapex.key",
  4749. public_key: "testkey.avbpubkey",
  4750. private_key: "testkey.pem",
  4751. }
  4752. cc_library {
  4753. name: "libfoo",
  4754. stl: "none",
  4755. system_shared_libs: [],
  4756. runtime_libs: ["libbaz"],
  4757. apex_available: ["myapex"],
  4758. }
  4759. cc_library {
  4760. name: "libbar",
  4761. stl: "none",
  4762. system_shared_libs: [],
  4763. apex_available: ["//apex_available:anyapex"],
  4764. }
  4765. cc_library {
  4766. name: "libbaz",
  4767. stl: "none",
  4768. system_shared_libs: [],
  4769. stubs: {
  4770. versions: ["10", "20", "30"],
  4771. },
  4772. }`)
  4773. }
  4774. func TestApexAvailable_CheckForPlatform(t *testing.T) {
  4775. ctx := testApex(t, `
  4776. apex {
  4777. name: "myapex",
  4778. key: "myapex.key",
  4779. native_shared_libs: ["libbar", "libbaz"],
  4780. updatable: false,
  4781. }
  4782. apex_key {
  4783. name: "myapex.key",
  4784. public_key: "testkey.avbpubkey",
  4785. private_key: "testkey.pem",
  4786. }
  4787. cc_library {
  4788. name: "libfoo",
  4789. stl: "none",
  4790. system_shared_libs: [],
  4791. shared_libs: ["libbar"],
  4792. apex_available: ["//apex_available:platform"],
  4793. }
  4794. cc_library {
  4795. name: "libfoo2",
  4796. stl: "none",
  4797. system_shared_libs: [],
  4798. shared_libs: ["libbaz"],
  4799. apex_available: ["//apex_available:platform"],
  4800. }
  4801. cc_library {
  4802. name: "libbar",
  4803. stl: "none",
  4804. system_shared_libs: [],
  4805. apex_available: ["myapex"],
  4806. }
  4807. cc_library {
  4808. name: "libbaz",
  4809. stl: "none",
  4810. system_shared_libs: [],
  4811. apex_available: ["myapex"],
  4812. stubs: {
  4813. versions: ["1"],
  4814. },
  4815. }`)
  4816. // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
  4817. // because it depends on libbar which isn't available to platform
  4818. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  4819. if libfoo.NotAvailableForPlatform() != true {
  4820. t.Errorf("%q shouldn't be available to platform", libfoo.String())
  4821. }
  4822. // libfoo2 however can be available to platform because it depends on libbaz which provides
  4823. // stubs
  4824. libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  4825. if libfoo2.NotAvailableForPlatform() == true {
  4826. t.Errorf("%q should be available to platform", libfoo2.String())
  4827. }
  4828. }
  4829. func TestApexAvailable_CreatedForApex(t *testing.T) {
  4830. ctx := testApex(t, `
  4831. apex {
  4832. name: "myapex",
  4833. key: "myapex.key",
  4834. native_shared_libs: ["libfoo"],
  4835. updatable: false,
  4836. }
  4837. apex_key {
  4838. name: "myapex.key",
  4839. public_key: "testkey.avbpubkey",
  4840. private_key: "testkey.pem",
  4841. }
  4842. cc_library {
  4843. name: "libfoo",
  4844. stl: "none",
  4845. system_shared_libs: [],
  4846. apex_available: ["myapex"],
  4847. static: {
  4848. apex_available: ["//apex_available:platform"],
  4849. },
  4850. }`)
  4851. libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  4852. if libfooShared.NotAvailableForPlatform() != true {
  4853. t.Errorf("%q shouldn't be available to platform", libfooShared.String())
  4854. }
  4855. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
  4856. if libfooStatic.NotAvailableForPlatform() != false {
  4857. t.Errorf("%q should be available to platform", libfooStatic.String())
  4858. }
  4859. }
  4860. func TestOverrideApex(t *testing.T) {
  4861. ctx := testApex(t, `
  4862. apex {
  4863. name: "myapex",
  4864. key: "myapex.key",
  4865. apps: ["app"],
  4866. overrides: ["oldapex"],
  4867. updatable: false,
  4868. }
  4869. override_apex {
  4870. name: "override_myapex",
  4871. base: "myapex",
  4872. apps: ["override_app"],
  4873. overrides: ["unknownapex"],
  4874. logging_parent: "com.foo.bar",
  4875. package_name: "test.overridden.package",
  4876. }
  4877. apex_key {
  4878. name: "myapex.key",
  4879. public_key: "testkey.avbpubkey",
  4880. private_key: "testkey.pem",
  4881. }
  4882. android_app {
  4883. name: "app",
  4884. srcs: ["foo/bar/MyClass.java"],
  4885. package_name: "foo",
  4886. sdk_version: "none",
  4887. system_modules: "none",
  4888. apex_available: [ "myapex" ],
  4889. }
  4890. override_android_app {
  4891. name: "override_app",
  4892. base: "app",
  4893. package_name: "bar",
  4894. }
  4895. `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
  4896. originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
  4897. overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
  4898. if originalVariant.GetOverriddenBy() != "" {
  4899. t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
  4900. }
  4901. if overriddenVariant.GetOverriddenBy() != "override_myapex" {
  4902. t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
  4903. }
  4904. module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
  4905. apexRule := module.Rule("apexRule")
  4906. copyCmds := apexRule.Args["copy_commands"]
  4907. ensureNotContains(t, copyCmds, "image.apex/app/app/app.apk")
  4908. ensureContains(t, copyCmds, "image.apex/app/override_app/override_app.apk")
  4909. apexBundle := module.Module().(*apexBundle)
  4910. name := apexBundle.Name()
  4911. if name != "override_myapex" {
  4912. t.Errorf("name should be \"override_myapex\", but was %q", name)
  4913. }
  4914. if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
  4915. t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
  4916. }
  4917. optFlags := apexRule.Args["opt_flags"]
  4918. ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
  4919. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  4920. var builder strings.Builder
  4921. data.Custom(&builder, name, "TARGET_", "", data)
  4922. androidMk := builder.String()
  4923. ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
  4924. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
  4925. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
  4926. ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
  4927. ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
  4928. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
  4929. ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
  4930. ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
  4931. }
  4932. func TestLegacyAndroid10Support(t *testing.T) {
  4933. ctx := testApex(t, `
  4934. apex {
  4935. name: "myapex",
  4936. key: "myapex.key",
  4937. native_shared_libs: ["mylib"],
  4938. min_sdk_version: "29",
  4939. }
  4940. apex_key {
  4941. name: "myapex.key",
  4942. public_key: "testkey.avbpubkey",
  4943. private_key: "testkey.pem",
  4944. }
  4945. cc_library {
  4946. name: "mylib",
  4947. srcs: ["mylib.cpp"],
  4948. stl: "libc++",
  4949. system_shared_libs: [],
  4950. apex_available: [ "myapex" ],
  4951. min_sdk_version: "29",
  4952. }
  4953. `, withUnbundledBuild)
  4954. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4955. args := module.Rule("apexRule").Args
  4956. ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
  4957. ensureNotContains(t, args["opt_flags"], "--no_hashtree")
  4958. // The copies of the libraries in the apex should have one more dependency than
  4959. // the ones outside the apex, namely the unwinder. Ideally we should check
  4960. // the dependency names directly here but for some reason the names are blank in
  4961. // this test.
  4962. for _, lib := range []string{"libc++", "mylib"} {
  4963. apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
  4964. nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
  4965. if len(apexImplicits) != len(nonApexImplicits)+1 {
  4966. t.Errorf("%q missing unwinder dep", lib)
  4967. }
  4968. }
  4969. }
  4970. var filesForSdkLibrary = android.MockFS{
  4971. "api/current.txt": nil,
  4972. "api/removed.txt": nil,
  4973. "api/system-current.txt": nil,
  4974. "api/system-removed.txt": nil,
  4975. "api/test-current.txt": nil,
  4976. "api/test-removed.txt": nil,
  4977. "100/public/api/foo.txt": nil,
  4978. "100/public/api/foo-removed.txt": nil,
  4979. "100/system/api/foo.txt": nil,
  4980. "100/system/api/foo-removed.txt": nil,
  4981. // For java_sdk_library_import
  4982. "a.jar": nil,
  4983. }
  4984. func TestJavaSDKLibrary(t *testing.T) {
  4985. ctx := testApex(t, `
  4986. apex {
  4987. name: "myapex",
  4988. key: "myapex.key",
  4989. java_libs: ["foo"],
  4990. updatable: false,
  4991. }
  4992. apex_key {
  4993. name: "myapex.key",
  4994. public_key: "testkey.avbpubkey",
  4995. private_key: "testkey.pem",
  4996. }
  4997. java_sdk_library {
  4998. name: "foo",
  4999. srcs: ["a.java"],
  5000. api_packages: ["foo"],
  5001. apex_available: [ "myapex" ],
  5002. }
  5003. prebuilt_apis {
  5004. name: "sdk",
  5005. api_dirs: ["100"],
  5006. }
  5007. `, withFiles(filesForSdkLibrary))
  5008. // java_sdk_library installs both impl jar and permission XML
  5009. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5010. "javalib/foo.jar",
  5011. "etc/permissions/foo.xml",
  5012. })
  5013. // Permission XML should point to the activated path of impl jar of java_sdk_library
  5014. sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
  5015. ensureContains(t, sdkLibrary.RuleParams.Command, `<library name=\"foo\" file=\"/apex/myapex/javalib/foo.jar\"`)
  5016. }
  5017. func TestJavaSDKLibrary_WithinApex(t *testing.T) {
  5018. ctx := testApex(t, `
  5019. apex {
  5020. name: "myapex",
  5021. key: "myapex.key",
  5022. java_libs: ["foo", "bar"],
  5023. updatable: false,
  5024. }
  5025. apex_key {
  5026. name: "myapex.key",
  5027. public_key: "testkey.avbpubkey",
  5028. private_key: "testkey.pem",
  5029. }
  5030. java_sdk_library {
  5031. name: "foo",
  5032. srcs: ["a.java"],
  5033. api_packages: ["foo"],
  5034. apex_available: ["myapex"],
  5035. sdk_version: "none",
  5036. system_modules: "none",
  5037. }
  5038. java_library {
  5039. name: "bar",
  5040. srcs: ["a.java"],
  5041. libs: ["foo"],
  5042. apex_available: ["myapex"],
  5043. sdk_version: "none",
  5044. system_modules: "none",
  5045. }
  5046. prebuilt_apis {
  5047. name: "sdk",
  5048. api_dirs: ["100"],
  5049. }
  5050. `, withFiles(filesForSdkLibrary))
  5051. // java_sdk_library installs both impl jar and permission XML
  5052. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5053. "javalib/bar.jar",
  5054. "javalib/foo.jar",
  5055. "etc/permissions/foo.xml",
  5056. })
  5057. // The bar library should depend on the implementation jar.
  5058. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  5059. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5060. t.Errorf("expected %q, found %#q", expected, actual)
  5061. }
  5062. }
  5063. func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
  5064. ctx := testApex(t, `
  5065. apex {
  5066. name: "myapex",
  5067. key: "myapex.key",
  5068. java_libs: ["foo"],
  5069. updatable: false,
  5070. }
  5071. apex_key {
  5072. name: "myapex.key",
  5073. public_key: "testkey.avbpubkey",
  5074. private_key: "testkey.pem",
  5075. }
  5076. java_sdk_library {
  5077. name: "foo",
  5078. srcs: ["a.java"],
  5079. api_packages: ["foo"],
  5080. apex_available: ["myapex"],
  5081. sdk_version: "none",
  5082. system_modules: "none",
  5083. }
  5084. java_library {
  5085. name: "bar",
  5086. srcs: ["a.java"],
  5087. libs: ["foo"],
  5088. sdk_version: "none",
  5089. system_modules: "none",
  5090. }
  5091. prebuilt_apis {
  5092. name: "sdk",
  5093. api_dirs: ["100"],
  5094. }
  5095. `, withFiles(filesForSdkLibrary))
  5096. // java_sdk_library installs both impl jar and permission XML
  5097. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5098. "javalib/foo.jar",
  5099. "etc/permissions/foo.xml",
  5100. })
  5101. // The bar library should depend on the stubs jar.
  5102. barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
  5103. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5104. t.Errorf("expected %q, found %#q", expected, actual)
  5105. }
  5106. }
  5107. func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
  5108. ctx := testApex(t, `
  5109. prebuilt_apis {
  5110. name: "sdk",
  5111. api_dirs: ["100"],
  5112. }`,
  5113. withFiles(map[string][]byte{
  5114. "apex/a.java": nil,
  5115. "apex/apex_manifest.json": nil,
  5116. "apex/Android.bp": []byte(`
  5117. package {
  5118. default_visibility: ["//visibility:private"],
  5119. }
  5120. apex {
  5121. name: "myapex",
  5122. key: "myapex.key",
  5123. java_libs: ["foo", "bar"],
  5124. updatable: false,
  5125. }
  5126. apex_key {
  5127. name: "myapex.key",
  5128. public_key: "testkey.avbpubkey",
  5129. private_key: "testkey.pem",
  5130. }
  5131. java_library {
  5132. name: "bar",
  5133. srcs: ["a.java"],
  5134. libs: ["foo"],
  5135. apex_available: ["myapex"],
  5136. sdk_version: "none",
  5137. system_modules: "none",
  5138. }
  5139. `),
  5140. "source/a.java": nil,
  5141. "source/api/current.txt": nil,
  5142. "source/api/removed.txt": nil,
  5143. "source/Android.bp": []byte(`
  5144. package {
  5145. default_visibility: ["//visibility:private"],
  5146. }
  5147. java_sdk_library {
  5148. name: "foo",
  5149. visibility: ["//apex"],
  5150. srcs: ["a.java"],
  5151. api_packages: ["foo"],
  5152. apex_available: ["myapex"],
  5153. sdk_version: "none",
  5154. system_modules: "none",
  5155. public: {
  5156. enabled: true,
  5157. },
  5158. }
  5159. `),
  5160. "prebuilt/a.jar": nil,
  5161. "prebuilt/Android.bp": []byte(`
  5162. package {
  5163. default_visibility: ["//visibility:private"],
  5164. }
  5165. java_sdk_library_import {
  5166. name: "foo",
  5167. visibility: ["//apex", "//source"],
  5168. apex_available: ["myapex"],
  5169. prefer: true,
  5170. public: {
  5171. jars: ["a.jar"],
  5172. },
  5173. }
  5174. `),
  5175. }), withFiles(filesForSdkLibrary),
  5176. )
  5177. // java_sdk_library installs both impl jar and permission XML
  5178. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5179. "javalib/bar.jar",
  5180. "javalib/foo.jar",
  5181. "etc/permissions/foo.xml",
  5182. })
  5183. // The bar library should depend on the implementation jar.
  5184. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  5185. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5186. t.Errorf("expected %q, found %#q", expected, actual)
  5187. }
  5188. }
  5189. func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
  5190. testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
  5191. apex {
  5192. name: "myapex",
  5193. key: "myapex.key",
  5194. java_libs: ["foo"],
  5195. updatable: false,
  5196. }
  5197. apex_key {
  5198. name: "myapex.key",
  5199. public_key: "testkey.avbpubkey",
  5200. private_key: "testkey.pem",
  5201. }
  5202. java_sdk_library_import {
  5203. name: "foo",
  5204. apex_available: ["myapex"],
  5205. prefer: true,
  5206. public: {
  5207. jars: ["a.jar"],
  5208. },
  5209. }
  5210. `, withFiles(filesForSdkLibrary))
  5211. }
  5212. func TestCompatConfig(t *testing.T) {
  5213. result := apexFixtureFactory.
  5214. Extend(java.PrepareForTestWithPlatformCompatConfig).
  5215. RunTestWithBp(t, `
  5216. apex {
  5217. name: "myapex",
  5218. key: "myapex.key",
  5219. compat_configs: ["myjar-platform-compat-config"],
  5220. java_libs: ["myjar"],
  5221. updatable: false,
  5222. }
  5223. apex_key {
  5224. name: "myapex.key",
  5225. public_key: "testkey.avbpubkey",
  5226. private_key: "testkey.pem",
  5227. }
  5228. platform_compat_config {
  5229. name: "myjar-platform-compat-config",
  5230. src: ":myjar",
  5231. }
  5232. java_library {
  5233. name: "myjar",
  5234. srcs: ["foo/bar/MyClass.java"],
  5235. sdk_version: "none",
  5236. system_modules: "none",
  5237. apex_available: [ "myapex" ],
  5238. }
  5239. // Make sure that a preferred prebuilt does not affect the apex contents.
  5240. prebuilt_platform_compat_config {
  5241. name: "myjar-platform-compat-config",
  5242. metadata: "compat-config/metadata.xml",
  5243. prefer: true,
  5244. }
  5245. `)
  5246. ctx := result.TestContext
  5247. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5248. "etc/compatconfig/myjar-platform-compat-config.xml",
  5249. "javalib/myjar.jar",
  5250. })
  5251. }
  5252. func TestRejectNonInstallableJavaLibrary(t *testing.T) {
  5253. testApexError(t, `"myjar" is not configured to be compiled into dex`, `
  5254. apex {
  5255. name: "myapex",
  5256. key: "myapex.key",
  5257. java_libs: ["myjar"],
  5258. updatable: false,
  5259. }
  5260. apex_key {
  5261. name: "myapex.key",
  5262. public_key: "testkey.avbpubkey",
  5263. private_key: "testkey.pem",
  5264. }
  5265. java_library {
  5266. name: "myjar",
  5267. srcs: ["foo/bar/MyClass.java"],
  5268. sdk_version: "none",
  5269. system_modules: "none",
  5270. compile_dex: false,
  5271. apex_available: ["myapex"],
  5272. }
  5273. `)
  5274. }
  5275. func TestCarryRequiredModuleNames(t *testing.T) {
  5276. ctx := testApex(t, `
  5277. apex {
  5278. name: "myapex",
  5279. key: "myapex.key",
  5280. native_shared_libs: ["mylib"],
  5281. updatable: false,
  5282. }
  5283. apex_key {
  5284. name: "myapex.key",
  5285. public_key: "testkey.avbpubkey",
  5286. private_key: "testkey.pem",
  5287. }
  5288. cc_library {
  5289. name: "mylib",
  5290. srcs: ["mylib.cpp"],
  5291. system_shared_libs: [],
  5292. stl: "none",
  5293. required: ["a", "b"],
  5294. host_required: ["c", "d"],
  5295. target_required: ["e", "f"],
  5296. apex_available: [ "myapex" ],
  5297. }
  5298. `)
  5299. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5300. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5301. name := apexBundle.BaseModuleName()
  5302. prefix := "TARGET_"
  5303. var builder strings.Builder
  5304. data.Custom(&builder, name, prefix, "", data)
  5305. androidMk := builder.String()
  5306. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
  5307. ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
  5308. ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
  5309. }
  5310. func TestSymlinksFromApexToSystem(t *testing.T) {
  5311. bp := `
  5312. apex {
  5313. name: "myapex",
  5314. key: "myapex.key",
  5315. native_shared_libs: ["mylib"],
  5316. java_libs: ["myjar"],
  5317. updatable: false,
  5318. }
  5319. apex {
  5320. name: "myapex.updatable",
  5321. key: "myapex.key",
  5322. native_shared_libs: ["mylib"],
  5323. java_libs: ["myjar"],
  5324. updatable: true,
  5325. min_sdk_version: "current",
  5326. }
  5327. apex_key {
  5328. name: "myapex.key",
  5329. public_key: "testkey.avbpubkey",
  5330. private_key: "testkey.pem",
  5331. }
  5332. cc_library {
  5333. name: "mylib",
  5334. srcs: ["mylib.cpp"],
  5335. shared_libs: ["myotherlib"],
  5336. system_shared_libs: [],
  5337. stl: "none",
  5338. apex_available: [
  5339. "myapex",
  5340. "myapex.updatable",
  5341. "//apex_available:platform",
  5342. ],
  5343. min_sdk_version: "current",
  5344. }
  5345. cc_library {
  5346. name: "myotherlib",
  5347. srcs: ["mylib.cpp"],
  5348. system_shared_libs: [],
  5349. stl: "none",
  5350. apex_available: [
  5351. "myapex",
  5352. "myapex.updatable",
  5353. "//apex_available:platform",
  5354. ],
  5355. min_sdk_version: "current",
  5356. }
  5357. java_library {
  5358. name: "myjar",
  5359. srcs: ["foo/bar/MyClass.java"],
  5360. sdk_version: "none",
  5361. system_modules: "none",
  5362. libs: ["myotherjar"],
  5363. apex_available: [
  5364. "myapex",
  5365. "myapex.updatable",
  5366. "//apex_available:platform",
  5367. ],
  5368. min_sdk_version: "current",
  5369. }
  5370. java_library {
  5371. name: "myotherjar",
  5372. srcs: ["foo/bar/MyClass.java"],
  5373. sdk_version: "none",
  5374. system_modules: "none",
  5375. apex_available: [
  5376. "myapex",
  5377. "myapex.updatable",
  5378. "//apex_available:platform",
  5379. ],
  5380. min_sdk_version: "current",
  5381. }
  5382. `
  5383. ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
  5384. for _, f := range files {
  5385. if f.path == file {
  5386. if f.isLink {
  5387. t.Errorf("%q is not a real file", file)
  5388. }
  5389. return
  5390. }
  5391. }
  5392. t.Errorf("%q is not found", file)
  5393. }
  5394. ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
  5395. for _, f := range files {
  5396. if f.path == file {
  5397. if !f.isLink {
  5398. t.Errorf("%q is not a symlink", file)
  5399. }
  5400. return
  5401. }
  5402. }
  5403. t.Errorf("%q is not found", file)
  5404. }
  5405. // For unbundled build, symlink shouldn't exist regardless of whether an APEX
  5406. // is updatable or not
  5407. ctx := testApex(t, bp, withUnbundledBuild)
  5408. files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
  5409. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5410. ensureRealfileExists(t, files, "lib64/mylib.so")
  5411. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  5412. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  5413. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5414. ensureRealfileExists(t, files, "lib64/mylib.so")
  5415. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  5416. // For bundled build, symlink to the system for the non-updatable APEXes only
  5417. ctx = testApex(t, bp)
  5418. files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
  5419. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5420. ensureRealfileExists(t, files, "lib64/mylib.so")
  5421. ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
  5422. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  5423. ensureRealfileExists(t, files, "javalib/myjar.jar")
  5424. ensureRealfileExists(t, files, "lib64/mylib.so")
  5425. ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
  5426. }
  5427. func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
  5428. ctx := testApex(t, `
  5429. apex {
  5430. name: "myapex",
  5431. key: "myapex.key",
  5432. native_shared_libs: ["mylib"],
  5433. updatable: false,
  5434. }
  5435. apex_key {
  5436. name: "myapex.key",
  5437. public_key: "testkey.avbpubkey",
  5438. private_key: "testkey.pem",
  5439. }
  5440. cc_library_shared {
  5441. name: "mylib",
  5442. srcs: ["mylib.cpp"],
  5443. shared_libs: ["myotherlib"],
  5444. system_shared_libs: [],
  5445. stl: "none",
  5446. apex_available: [
  5447. "myapex",
  5448. "//apex_available:platform",
  5449. ],
  5450. }
  5451. cc_prebuilt_library_shared {
  5452. name: "myotherlib",
  5453. srcs: ["prebuilt.so"],
  5454. system_shared_libs: [],
  5455. stl: "none",
  5456. apex_available: [
  5457. "myapex",
  5458. "//apex_available:platform",
  5459. ],
  5460. }
  5461. `)
  5462. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  5463. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5464. var builder strings.Builder
  5465. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  5466. androidMk := builder.String()
  5467. // `myotherlib` is added to `myapex` as symlink
  5468. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  5469. ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
  5470. ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
  5471. // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
  5472. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
  5473. }
  5474. func TestApexWithJniLibs(t *testing.T) {
  5475. ctx := testApex(t, `
  5476. apex {
  5477. name: "myapex",
  5478. key: "myapex.key",
  5479. jni_libs: ["mylib"],
  5480. updatable: false,
  5481. }
  5482. apex_key {
  5483. name: "myapex.key",
  5484. public_key: "testkey.avbpubkey",
  5485. private_key: "testkey.pem",
  5486. }
  5487. cc_library {
  5488. name: "mylib",
  5489. srcs: ["mylib.cpp"],
  5490. shared_libs: ["mylib2"],
  5491. system_shared_libs: [],
  5492. stl: "none",
  5493. apex_available: [ "myapex" ],
  5494. }
  5495. cc_library {
  5496. name: "mylib2",
  5497. srcs: ["mylib.cpp"],
  5498. system_shared_libs: [],
  5499. stl: "none",
  5500. apex_available: [ "myapex" ],
  5501. }
  5502. `)
  5503. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  5504. // Notice mylib2.so (transitive dep) is not added as a jni_lib
  5505. ensureEquals(t, rule.Args["opt"], "-a jniLibs mylib.so")
  5506. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5507. "lib64/mylib.so",
  5508. "lib64/mylib2.so",
  5509. })
  5510. }
  5511. func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
  5512. ctx := testApex(t, `
  5513. apex {
  5514. name: "myapex",
  5515. key: "myapex.key",
  5516. updatable: false,
  5517. }
  5518. apex_key {
  5519. name: "myapex.key",
  5520. public_key: "testkey.avbpubkey",
  5521. private_key: "testkey.pem",
  5522. }
  5523. `,
  5524. android.FixtureModifyConfig(func(config android.Config) {
  5525. delete(config.Targets, android.Android)
  5526. config.AndroidCommonTarget = android.Target{}
  5527. }),
  5528. )
  5529. if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
  5530. t.Errorf("Expected variants: %v, but got: %v", expected, got)
  5531. }
  5532. }
  5533. func TestAppBundle(t *testing.T) {
  5534. ctx := testApex(t, `
  5535. apex {
  5536. name: "myapex",
  5537. key: "myapex.key",
  5538. apps: ["AppFoo"],
  5539. updatable: false,
  5540. }
  5541. apex_key {
  5542. name: "myapex.key",
  5543. public_key: "testkey.avbpubkey",
  5544. private_key: "testkey.pem",
  5545. }
  5546. android_app {
  5547. name: "AppFoo",
  5548. srcs: ["foo/bar/MyClass.java"],
  5549. sdk_version: "none",
  5550. system_modules: "none",
  5551. apex_available: [ "myapex" ],
  5552. }
  5553. `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
  5554. bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
  5555. content := bundleConfigRule.Args["content"]
  5556. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  5557. ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo/AppFoo.apk"}]}`)
  5558. }
  5559. func TestAppSetBundle(t *testing.T) {
  5560. ctx := testApex(t, `
  5561. apex {
  5562. name: "myapex",
  5563. key: "myapex.key",
  5564. apps: ["AppSet"],
  5565. updatable: false,
  5566. }
  5567. apex_key {
  5568. name: "myapex.key",
  5569. public_key: "testkey.avbpubkey",
  5570. private_key: "testkey.pem",
  5571. }
  5572. android_app_set {
  5573. name: "AppSet",
  5574. set: "AppSet.apks",
  5575. }`)
  5576. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5577. bundleConfigRule := mod.Output("bundle_config.json")
  5578. content := bundleConfigRule.Args["content"]
  5579. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  5580. s := mod.Rule("apexRule").Args["copy_commands"]
  5581. copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
  5582. if len(copyCmds) != 3 {
  5583. t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
  5584. }
  5585. ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet$")
  5586. ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet$")
  5587. ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet .*/AppSet.zip$")
  5588. }
  5589. func TestAppSetBundlePrebuilt(t *testing.T) {
  5590. ctx := testApex(t, "", android.FixtureModifyMockFS(func(fs android.MockFS) {
  5591. bp := `
  5592. apex_set {
  5593. name: "myapex",
  5594. filename: "foo_v2.apex",
  5595. sanitized: {
  5596. none: { set: "myapex.apks", },
  5597. hwaddress: { set: "myapex.hwasan.apks", },
  5598. },
  5599. }`
  5600. fs["Android.bp"] = []byte(bp)
  5601. }),
  5602. prepareForTestWithSantitizeHwaddress,
  5603. )
  5604. m := ctx.ModuleForTests("myapex", "android_common")
  5605. extractedApex := m.Output("out/soong/.intermediates/myapex/android_common/foo_v2.apex")
  5606. actual := extractedApex.Inputs
  5607. if len(actual) != 1 {
  5608. t.Errorf("expected a single input")
  5609. }
  5610. expected := "myapex.hwasan.apks"
  5611. if actual[0].String() != expected {
  5612. t.Errorf("expected %s, got %s", expected, actual[0].String())
  5613. }
  5614. }
  5615. func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, transformDexpreoptConfig func(*dexpreopt.GlobalConfig)) {
  5616. t.Helper()
  5617. bp := `
  5618. java_library {
  5619. name: "some-updatable-apex-lib",
  5620. srcs: ["a.java"],
  5621. sdk_version: "current",
  5622. apex_available: [
  5623. "some-updatable-apex",
  5624. ],
  5625. }
  5626. java_library {
  5627. name: "some-non-updatable-apex-lib",
  5628. srcs: ["a.java"],
  5629. apex_available: [
  5630. "some-non-updatable-apex",
  5631. ],
  5632. }
  5633. java_library {
  5634. name: "some-platform-lib",
  5635. srcs: ["a.java"],
  5636. sdk_version: "current",
  5637. installable: true,
  5638. }
  5639. java_library {
  5640. name: "some-art-lib",
  5641. srcs: ["a.java"],
  5642. sdk_version: "current",
  5643. apex_available: [
  5644. "com.android.art.debug",
  5645. ],
  5646. hostdex: true,
  5647. }
  5648. apex {
  5649. name: "some-updatable-apex",
  5650. key: "some-updatable-apex.key",
  5651. java_libs: ["some-updatable-apex-lib"],
  5652. updatable: true,
  5653. min_sdk_version: "current",
  5654. }
  5655. apex {
  5656. name: "some-non-updatable-apex",
  5657. key: "some-non-updatable-apex.key",
  5658. java_libs: ["some-non-updatable-apex-lib"],
  5659. updatable: false,
  5660. }
  5661. apex_key {
  5662. name: "some-updatable-apex.key",
  5663. }
  5664. apex_key {
  5665. name: "some-non-updatable-apex.key",
  5666. }
  5667. apex {
  5668. name: "com.android.art.debug",
  5669. key: "com.android.art.debug.key",
  5670. java_libs: ["some-art-lib"],
  5671. updatable: true,
  5672. min_sdk_version: "current",
  5673. }
  5674. apex_key {
  5675. name: "com.android.art.debug.key",
  5676. }
  5677. filegroup {
  5678. name: "some-updatable-apex-file_contexts",
  5679. srcs: [
  5680. "system/sepolicy/apex/some-updatable-apex-file_contexts",
  5681. ],
  5682. }
  5683. filegroup {
  5684. name: "some-non-updatable-apex-file_contexts",
  5685. srcs: [
  5686. "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
  5687. ],
  5688. }
  5689. `
  5690. testDexpreoptWithApexes(t, bp, errmsg, transformDexpreoptConfig)
  5691. }
  5692. func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, transformDexpreoptConfig func(*dexpreopt.GlobalConfig)) *android.TestContext {
  5693. t.Helper()
  5694. bp += cc.GatherRequiredDepsForTest(android.Android)
  5695. bp += java.GatherRequiredDepsForTest()
  5696. fs := map[string][]byte{
  5697. "a.java": nil,
  5698. "a.jar": nil,
  5699. "build/make/target/product/security": nil,
  5700. "apex_manifest.json": nil,
  5701. "AndroidManifest.xml": nil,
  5702. "system/sepolicy/apex/myapex-file_contexts": nil,
  5703. "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
  5704. "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
  5705. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  5706. "framework/aidl/a.aidl": nil,
  5707. }
  5708. cc.GatherRequiredFilesForTest(fs)
  5709. for k, v := range filesForSdkLibrary {
  5710. fs[k] = v
  5711. }
  5712. config := android.TestArchConfig(t.TempDir(), nil, bp, fs)
  5713. ctx := android.NewTestArchContext(config)
  5714. ctx.RegisterModuleType("apex", BundleFactory)
  5715. ctx.RegisterModuleType("apex_key", ApexKeyFactory)
  5716. ctx.RegisterModuleType("prebuilt_apex", PrebuiltFactory)
  5717. ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
  5718. ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
  5719. ctx.PreArchMutators(android.RegisterComponentsMutator)
  5720. android.RegisterPrebuiltMutators(ctx)
  5721. cc.RegisterRequiredBuildComponentsForTest(ctx)
  5722. java.RegisterRequiredBuildComponentsForTest(ctx)
  5723. java.RegisterHiddenApiSingletonComponents(ctx)
  5724. ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
  5725. ctx.PreDepsMutators(RegisterPreDepsMutators)
  5726. ctx.PostDepsMutators(RegisterPostDepsMutators)
  5727. ctx.Register()
  5728. pathCtx := android.PathContextForTesting(config)
  5729. dexpreoptConfig := dexpreopt.GlobalConfigForTests(pathCtx)
  5730. transformDexpreoptConfig(dexpreoptConfig)
  5731. dexpreopt.SetTestGlobalConfig(config, dexpreoptConfig)
  5732. // Make sure that any changes to these dexpreopt properties are mirrored in the corresponding
  5733. // product variables.
  5734. config.TestProductVariables.BootJars = dexpreoptConfig.BootJars
  5735. config.TestProductVariables.UpdatableBootJars = dexpreoptConfig.UpdatableBootJars
  5736. _, errs := ctx.ParseBlueprintsFiles("Android.bp")
  5737. android.FailIfErrored(t, errs)
  5738. _, errs = ctx.PrepareBuildActions(config)
  5739. if errmsg == "" {
  5740. android.FailIfErrored(t, errs)
  5741. } else if len(errs) > 0 {
  5742. android.FailIfNoMatchingErrors(t, errmsg, errs)
  5743. } else {
  5744. t.Fatalf("missing expected error %q (0 errors are returned)", errmsg)
  5745. }
  5746. return ctx
  5747. }
  5748. func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
  5749. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  5750. apex {
  5751. name: "myapex",
  5752. key: "myapex.key",
  5753. updatable: true,
  5754. }
  5755. apex_key {
  5756. name: "myapex.key",
  5757. public_key: "testkey.avbpubkey",
  5758. private_key: "testkey.pem",
  5759. }
  5760. `)
  5761. }
  5762. func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
  5763. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  5764. apex {
  5765. name: "myapex",
  5766. key: "myapex.key",
  5767. }
  5768. apex_key {
  5769. name: "myapex.key",
  5770. public_key: "testkey.avbpubkey",
  5771. private_key: "testkey.pem",
  5772. }
  5773. `)
  5774. }
  5775. func TestNoUpdatableJarsInBootImage(t *testing.T) {
  5776. var err string
  5777. var transform func(*dexpreopt.GlobalConfig)
  5778. t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
  5779. transform = func(config *dexpreopt.GlobalConfig) {
  5780. config.ArtApexJars = android.CreateTestConfiguredJarList([]string{"com.android.art.debug:some-art-lib"})
  5781. }
  5782. testNoUpdatableJarsInBootImage(t, "", transform)
  5783. })
  5784. t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
  5785. err = `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
  5786. transform = func(config *dexpreopt.GlobalConfig) {
  5787. config.BootJars = android.CreateTestConfiguredJarList([]string{"com.android.art.debug:some-art-lib"})
  5788. }
  5789. testNoUpdatableJarsInBootImage(t, err, transform)
  5790. })
  5791. t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  5792. err = `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the ART boot image`
  5793. transform = func(config *dexpreopt.GlobalConfig) {
  5794. config.ArtApexJars = android.CreateTestConfiguredJarList([]string{"some-updatable-apex:some-updatable-apex-lib"})
  5795. }
  5796. testNoUpdatableJarsInBootImage(t, err, transform)
  5797. })
  5798. t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  5799. err = `module "some-non-updatable-apex-lib" is not allowed in the ART boot image`
  5800. transform = func(config *dexpreopt.GlobalConfig) {
  5801. config.ArtApexJars = android.CreateTestConfiguredJarList([]string{"some-non-updatable-apex:some-non-updatable-apex-lib"})
  5802. }
  5803. testNoUpdatableJarsInBootImage(t, err, transform)
  5804. })
  5805. t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
  5806. err = `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
  5807. transform = func(config *dexpreopt.GlobalConfig) {
  5808. config.BootJars = android.CreateTestConfiguredJarList([]string{"some-updatable-apex:some-updatable-apex-lib"})
  5809. }
  5810. testNoUpdatableJarsInBootImage(t, err, transform)
  5811. })
  5812. t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
  5813. transform = func(config *dexpreopt.GlobalConfig) {
  5814. config.BootJars = android.CreateTestConfiguredJarList([]string{"some-non-updatable-apex:some-non-updatable-apex-lib"})
  5815. }
  5816. testNoUpdatableJarsInBootImage(t, "", transform)
  5817. })
  5818. t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
  5819. err = "failed to find a dex jar path for module 'nonexistent'"
  5820. transform = func(config *dexpreopt.GlobalConfig) {
  5821. config.ArtApexJars = android.CreateTestConfiguredJarList([]string{"platform:nonexistent"})
  5822. }
  5823. testNoUpdatableJarsInBootImage(t, err, transform)
  5824. })
  5825. t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
  5826. err = "failed to find a dex jar path for module 'nonexistent'"
  5827. transform = func(config *dexpreopt.GlobalConfig) {
  5828. config.BootJars = android.CreateTestConfiguredJarList([]string{"platform:nonexistent"})
  5829. }
  5830. testNoUpdatableJarsInBootImage(t, err, transform)
  5831. })
  5832. t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
  5833. err = `module "some-platform-lib" is not allowed in the ART boot image`
  5834. transform = func(config *dexpreopt.GlobalConfig) {
  5835. config.ArtApexJars = android.CreateTestConfiguredJarList([]string{"platform:some-platform-lib"})
  5836. }
  5837. testNoUpdatableJarsInBootImage(t, err, transform)
  5838. })
  5839. t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
  5840. transform = func(config *dexpreopt.GlobalConfig) {
  5841. config.BootJars = android.CreateTestConfiguredJarList([]string{"platform:some-platform-lib"})
  5842. }
  5843. testNoUpdatableJarsInBootImage(t, "", transform)
  5844. })
  5845. }
  5846. func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
  5847. transform := func(config *dexpreopt.GlobalConfig) {
  5848. config.BootJars = android.CreateTestConfiguredJarList([]string{"myapex:libfoo"})
  5849. }
  5850. t.Run("prebuilt no source", func(t *testing.T) {
  5851. testDexpreoptWithApexes(t, `
  5852. prebuilt_apex {
  5853. name: "myapex" ,
  5854. arch: {
  5855. arm64: {
  5856. src: "myapex-arm64.apex",
  5857. },
  5858. arm: {
  5859. src: "myapex-arm.apex",
  5860. },
  5861. },
  5862. exported_java_libs: ["libfoo"],
  5863. }
  5864. java_import {
  5865. name: "libfoo",
  5866. jars: ["libfoo.jar"],
  5867. }
  5868. `, "", transform)
  5869. })
  5870. t.Run("prebuilt no source", func(t *testing.T) {
  5871. testDexpreoptWithApexes(t, `
  5872. prebuilt_apex {
  5873. name: "myapex" ,
  5874. arch: {
  5875. arm64: {
  5876. src: "myapex-arm64.apex",
  5877. },
  5878. arm: {
  5879. src: "myapex-arm.apex",
  5880. },
  5881. },
  5882. exported_java_libs: ["libfoo"],
  5883. }
  5884. java_import {
  5885. name: "libfoo",
  5886. jars: ["libfoo.jar"],
  5887. }
  5888. `, "", transform)
  5889. })
  5890. }
  5891. func testApexPermittedPackagesRules(t *testing.T, errmsg, bp string, apexBootJars []string, rules []android.Rule) {
  5892. t.Helper()
  5893. bp += `
  5894. apex_key {
  5895. name: "myapex.key",
  5896. public_key: "testkey.avbpubkey",
  5897. private_key: "testkey.pem",
  5898. }`
  5899. fs := map[string][]byte{
  5900. "lib1/src/A.java": nil,
  5901. "lib2/src/B.java": nil,
  5902. "system/sepolicy/apex/myapex-file_contexts": nil,
  5903. }
  5904. config := android.TestArchConfig(t.TempDir(), nil, bp, fs)
  5905. android.SetTestNeverallowRules(config, rules)
  5906. updatableBootJars := make([]string, 0, len(apexBootJars))
  5907. for _, apexBootJar := range apexBootJars {
  5908. updatableBootJars = append(updatableBootJars, "myapex:"+apexBootJar)
  5909. }
  5910. config.TestProductVariables.UpdatableBootJars = android.CreateTestConfiguredJarList(updatableBootJars)
  5911. ctx := android.NewTestArchContext(config)
  5912. ctx.RegisterModuleType("apex", BundleFactory)
  5913. ctx.RegisterModuleType("apex_key", ApexKeyFactory)
  5914. ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
  5915. cc.RegisterRequiredBuildComponentsForTest(ctx)
  5916. java.RegisterRequiredBuildComponentsForTest(ctx)
  5917. ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
  5918. ctx.PreDepsMutators(RegisterPreDepsMutators)
  5919. ctx.PostDepsMutators(RegisterPostDepsMutators)
  5920. ctx.PostDepsMutators(android.RegisterNeverallowMutator)
  5921. ctx.Register()
  5922. _, errs := ctx.ParseBlueprintsFiles("Android.bp")
  5923. android.FailIfErrored(t, errs)
  5924. _, errs = ctx.PrepareBuildActions(config)
  5925. if errmsg == "" {
  5926. android.FailIfErrored(t, errs)
  5927. } else if len(errs) > 0 {
  5928. android.FailIfNoMatchingErrors(t, errmsg, errs)
  5929. return
  5930. } else {
  5931. t.Fatalf("missing expected error %q (0 errors are returned)", errmsg)
  5932. }
  5933. }
  5934. func TestApexPermittedPackagesRules(t *testing.T) {
  5935. testcases := []struct {
  5936. name string
  5937. expectedError string
  5938. bp string
  5939. bootJars []string
  5940. modulesPackages map[string][]string
  5941. }{
  5942. {
  5943. name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
  5944. expectedError: "",
  5945. bp: `
  5946. java_library {
  5947. name: "bcp_lib1",
  5948. srcs: ["lib1/src/*.java"],
  5949. permitted_packages: ["foo.bar"],
  5950. apex_available: ["myapex"],
  5951. sdk_version: "none",
  5952. system_modules: "none",
  5953. }
  5954. java_library {
  5955. name: "nonbcp_lib2",
  5956. srcs: ["lib2/src/*.java"],
  5957. apex_available: ["myapex"],
  5958. permitted_packages: ["a.b"],
  5959. sdk_version: "none",
  5960. system_modules: "none",
  5961. }
  5962. apex {
  5963. name: "myapex",
  5964. key: "myapex.key",
  5965. java_libs: ["bcp_lib1", "nonbcp_lib2"],
  5966. updatable: false,
  5967. }`,
  5968. bootJars: []string{"bcp_lib1"},
  5969. modulesPackages: map[string][]string{
  5970. "myapex": []string{
  5971. "foo.bar",
  5972. },
  5973. },
  5974. },
  5975. {
  5976. name: "Bootclasspath apex jar not satisfying allowed module packages.",
  5977. expectedError: `module "bcp_lib2" .* which is restricted because jars that are part of the myapex module may only allow these packages: foo.bar. Please jarjar or move code around.`,
  5978. bp: `
  5979. java_library {
  5980. name: "bcp_lib1",
  5981. srcs: ["lib1/src/*.java"],
  5982. apex_available: ["myapex"],
  5983. permitted_packages: ["foo.bar"],
  5984. sdk_version: "none",
  5985. system_modules: "none",
  5986. }
  5987. java_library {
  5988. name: "bcp_lib2",
  5989. srcs: ["lib2/src/*.java"],
  5990. apex_available: ["myapex"],
  5991. permitted_packages: ["foo.bar", "bar.baz"],
  5992. sdk_version: "none",
  5993. system_modules: "none",
  5994. }
  5995. apex {
  5996. name: "myapex",
  5997. key: "myapex.key",
  5998. java_libs: ["bcp_lib1", "bcp_lib2"],
  5999. updatable: false,
  6000. }
  6001. `,
  6002. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  6003. modulesPackages: map[string][]string{
  6004. "myapex": []string{
  6005. "foo.bar",
  6006. },
  6007. },
  6008. },
  6009. }
  6010. for _, tc := range testcases {
  6011. t.Run(tc.name, func(t *testing.T) {
  6012. rules := createApexPermittedPackagesRules(tc.modulesPackages)
  6013. testApexPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
  6014. })
  6015. }
  6016. }
  6017. func TestTestFor(t *testing.T) {
  6018. ctx := testApex(t, `
  6019. apex {
  6020. name: "myapex",
  6021. key: "myapex.key",
  6022. native_shared_libs: ["mylib", "myprivlib"],
  6023. updatable: false,
  6024. }
  6025. apex_key {
  6026. name: "myapex.key",
  6027. public_key: "testkey.avbpubkey",
  6028. private_key: "testkey.pem",
  6029. }
  6030. cc_library {
  6031. name: "mylib",
  6032. srcs: ["mylib.cpp"],
  6033. system_shared_libs: [],
  6034. stl: "none",
  6035. stubs: {
  6036. versions: ["1"],
  6037. },
  6038. apex_available: ["myapex"],
  6039. }
  6040. cc_library {
  6041. name: "myprivlib",
  6042. srcs: ["mylib.cpp"],
  6043. system_shared_libs: [],
  6044. stl: "none",
  6045. apex_available: ["myapex"],
  6046. }
  6047. cc_test {
  6048. name: "mytest",
  6049. gtest: false,
  6050. srcs: ["mylib.cpp"],
  6051. system_shared_libs: [],
  6052. stl: "none",
  6053. shared_libs: ["mylib", "myprivlib", "mytestlib"],
  6054. test_for: ["myapex"]
  6055. }
  6056. cc_library {
  6057. name: "mytestlib",
  6058. srcs: ["mylib.cpp"],
  6059. system_shared_libs: [],
  6060. shared_libs: ["mylib", "myprivlib"],
  6061. stl: "none",
  6062. test_for: ["myapex"],
  6063. }
  6064. cc_benchmark {
  6065. name: "mybench",
  6066. srcs: ["mylib.cpp"],
  6067. system_shared_libs: [],
  6068. shared_libs: ["mylib", "myprivlib"],
  6069. stl: "none",
  6070. test_for: ["myapex"],
  6071. }
  6072. `)
  6073. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  6074. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  6075. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  6076. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  6077. }
  6078. // These modules are tests for the apex, therefore are linked to the
  6079. // actual implementation of mylib instead of its stub.
  6080. ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6081. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6082. ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6083. }
  6084. func TestIndirectTestFor(t *testing.T) {
  6085. ctx := testApex(t, `
  6086. apex {
  6087. name: "myapex",
  6088. key: "myapex.key",
  6089. native_shared_libs: ["mylib", "myprivlib"],
  6090. updatable: false,
  6091. }
  6092. apex_key {
  6093. name: "myapex.key",
  6094. public_key: "testkey.avbpubkey",
  6095. private_key: "testkey.pem",
  6096. }
  6097. cc_library {
  6098. name: "mylib",
  6099. srcs: ["mylib.cpp"],
  6100. system_shared_libs: [],
  6101. stl: "none",
  6102. stubs: {
  6103. versions: ["1"],
  6104. },
  6105. apex_available: ["myapex"],
  6106. }
  6107. cc_library {
  6108. name: "myprivlib",
  6109. srcs: ["mylib.cpp"],
  6110. system_shared_libs: [],
  6111. stl: "none",
  6112. shared_libs: ["mylib"],
  6113. apex_available: ["myapex"],
  6114. }
  6115. cc_library {
  6116. name: "mytestlib",
  6117. srcs: ["mylib.cpp"],
  6118. system_shared_libs: [],
  6119. shared_libs: ["myprivlib"],
  6120. stl: "none",
  6121. test_for: ["myapex"],
  6122. }
  6123. `)
  6124. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  6125. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  6126. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  6127. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  6128. }
  6129. // The platform variant of mytestlib links to the platform variant of the
  6130. // internal myprivlib.
  6131. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
  6132. // The platform variant of myprivlib links to the platform variant of mylib
  6133. // and bypasses its stubs.
  6134. ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  6135. }
  6136. // TODO(jungjw): Move this to proptools
  6137. func intPtr(i int) *int {
  6138. return &i
  6139. }
  6140. func TestApexSet(t *testing.T) {
  6141. ctx := testApex(t, `
  6142. apex_set {
  6143. name: "myapex",
  6144. set: "myapex.apks",
  6145. filename: "foo_v2.apex",
  6146. overrides: ["foo"],
  6147. }
  6148. `,
  6149. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6150. variables.Platform_sdk_version = intPtr(30)
  6151. }),
  6152. android.FixtureModifyConfig(func(config android.Config) {
  6153. config.Targets[android.Android] = []android.Target{
  6154. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
  6155. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
  6156. }
  6157. }),
  6158. )
  6159. m := ctx.ModuleForTests("myapex", "android_common")
  6160. // Check extract_apks tool parameters.
  6161. extractedApex := m.Output("out/soong/.intermediates/myapex/android_common/foo_v2.apex")
  6162. actual := extractedApex.Args["abis"]
  6163. expected := "ARMEABI_V7A,ARM64_V8A"
  6164. if actual != expected {
  6165. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  6166. }
  6167. actual = extractedApex.Args["sdk-version"]
  6168. expected = "30"
  6169. if actual != expected {
  6170. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  6171. }
  6172. a := m.Module().(*ApexSet)
  6173. expectedOverrides := []string{"foo"}
  6174. actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  6175. if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
  6176. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
  6177. }
  6178. }
  6179. func TestNoStaticLinkingToStubsLib(t *testing.T) {
  6180. testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
  6181. apex {
  6182. name: "myapex",
  6183. key: "myapex.key",
  6184. native_shared_libs: ["mylib"],
  6185. updatable: false,
  6186. }
  6187. apex_key {
  6188. name: "myapex.key",
  6189. public_key: "testkey.avbpubkey",
  6190. private_key: "testkey.pem",
  6191. }
  6192. cc_library {
  6193. name: "mylib",
  6194. srcs: ["mylib.cpp"],
  6195. static_libs: ["otherlib"],
  6196. system_shared_libs: [],
  6197. stl: "none",
  6198. apex_available: [ "myapex" ],
  6199. }
  6200. cc_library {
  6201. name: "otherlib",
  6202. srcs: ["mylib.cpp"],
  6203. system_shared_libs: [],
  6204. stl: "none",
  6205. stubs: {
  6206. versions: ["1", "2", "3"],
  6207. },
  6208. apex_available: [ "myapex" ],
  6209. }
  6210. `)
  6211. }
  6212. func TestApexKeysTxt(t *testing.T) {
  6213. ctx := testApex(t, `
  6214. apex {
  6215. name: "myapex",
  6216. key: "myapex.key",
  6217. updatable: false,
  6218. }
  6219. apex_key {
  6220. name: "myapex.key",
  6221. public_key: "testkey.avbpubkey",
  6222. private_key: "testkey.pem",
  6223. }
  6224. prebuilt_apex {
  6225. name: "myapex",
  6226. prefer: true,
  6227. arch: {
  6228. arm64: {
  6229. src: "myapex-arm64.apex",
  6230. },
  6231. arm: {
  6232. src: "myapex-arm.apex",
  6233. },
  6234. },
  6235. }
  6236. apex_set {
  6237. name: "myapex_set",
  6238. set: "myapex.apks",
  6239. filename: "myapex_set.apex",
  6240. overrides: ["myapex"],
  6241. }
  6242. `)
  6243. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  6244. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  6245. ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  6246. ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  6247. }
  6248. func TestAllowedFiles(t *testing.T) {
  6249. ctx := testApex(t, `
  6250. apex {
  6251. name: "myapex",
  6252. key: "myapex.key",
  6253. apps: ["app"],
  6254. allowed_files: "allowed.txt",
  6255. updatable: false,
  6256. }
  6257. apex_key {
  6258. name: "myapex.key",
  6259. public_key: "testkey.avbpubkey",
  6260. private_key: "testkey.pem",
  6261. }
  6262. android_app {
  6263. name: "app",
  6264. srcs: ["foo/bar/MyClass.java"],
  6265. package_name: "foo",
  6266. sdk_version: "none",
  6267. system_modules: "none",
  6268. apex_available: [ "myapex" ],
  6269. }
  6270. `, withFiles(map[string][]byte{
  6271. "sub/Android.bp": []byte(`
  6272. override_apex {
  6273. name: "override_myapex",
  6274. base: "myapex",
  6275. apps: ["override_app"],
  6276. allowed_files: ":allowed",
  6277. }
  6278. // Overridable "path" property should be referenced indirectly
  6279. filegroup {
  6280. name: "allowed",
  6281. srcs: ["allowed.txt"],
  6282. }
  6283. override_android_app {
  6284. name: "override_app",
  6285. base: "app",
  6286. package_name: "bar",
  6287. }
  6288. `),
  6289. }))
  6290. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
  6291. if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
  6292. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  6293. }
  6294. rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
  6295. if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
  6296. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  6297. }
  6298. }
  6299. func TestNonPreferredPrebuiltDependency(t *testing.T) {
  6300. testApex(t, `
  6301. apex {
  6302. name: "myapex",
  6303. key: "myapex.key",
  6304. native_shared_libs: ["mylib"],
  6305. updatable: false,
  6306. }
  6307. apex_key {
  6308. name: "myapex.key",
  6309. public_key: "testkey.avbpubkey",
  6310. private_key: "testkey.pem",
  6311. }
  6312. cc_library {
  6313. name: "mylib",
  6314. srcs: ["mylib.cpp"],
  6315. stubs: {
  6316. versions: ["current"],
  6317. },
  6318. apex_available: ["myapex"],
  6319. }
  6320. cc_prebuilt_library_shared {
  6321. name: "mylib",
  6322. prefer: false,
  6323. srcs: ["prebuilt.so"],
  6324. stubs: {
  6325. versions: ["current"],
  6326. },
  6327. apex_available: ["myapex"],
  6328. }
  6329. `)
  6330. }
  6331. func TestCompressedApex(t *testing.T) {
  6332. ctx := testApex(t, `
  6333. apex {
  6334. name: "myapex",
  6335. key: "myapex.key",
  6336. compressible: true,
  6337. updatable: false,
  6338. }
  6339. apex_key {
  6340. name: "myapex.key",
  6341. public_key: "testkey.avbpubkey",
  6342. private_key: "testkey.pem",
  6343. }
  6344. `,
  6345. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6346. variables.CompressedApex = proptools.BoolPtr(true)
  6347. }),
  6348. )
  6349. compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
  6350. ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
  6351. signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
  6352. ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
  6353. // Make sure output of bundle is .capex
  6354. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6355. ensureContains(t, ab.outputFile.String(), "myapex.capex")
  6356. // Verify android.mk rules
  6357. data := android.AndroidMkDataForTest(t, ctx, ab)
  6358. var builder strings.Builder
  6359. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  6360. androidMk := builder.String()
  6361. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
  6362. }
  6363. func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
  6364. ctx := testApex(t, `
  6365. apex {
  6366. name: "myapex",
  6367. key: "myapex.key",
  6368. native_shared_libs: ["mylib"],
  6369. updatable: false,
  6370. }
  6371. apex_key {
  6372. name: "myapex.key",
  6373. public_key: "testkey.avbpubkey",
  6374. private_key: "testkey.pem",
  6375. }
  6376. cc_library {
  6377. name: "mylib",
  6378. srcs: ["mylib.cpp"],
  6379. apex_available: ["myapex"],
  6380. shared_libs: ["otherlib"],
  6381. system_shared_libs: [],
  6382. }
  6383. cc_library {
  6384. name: "otherlib",
  6385. srcs: ["mylib.cpp"],
  6386. stubs: {
  6387. versions: ["current"],
  6388. },
  6389. }
  6390. cc_prebuilt_library_shared {
  6391. name: "otherlib",
  6392. prefer: true,
  6393. srcs: ["prebuilt.so"],
  6394. stubs: {
  6395. versions: ["current"],
  6396. },
  6397. }
  6398. `)
  6399. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6400. data := android.AndroidMkDataForTest(t, ctx, ab)
  6401. var builder strings.Builder
  6402. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  6403. androidMk := builder.String()
  6404. // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
  6405. // a thing there.
  6406. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
  6407. }
  6408. func TestExcludeDependency(t *testing.T) {
  6409. ctx := testApex(t, `
  6410. apex {
  6411. name: "myapex",
  6412. key: "myapex.key",
  6413. native_shared_libs: ["mylib"],
  6414. updatable: false,
  6415. }
  6416. apex_key {
  6417. name: "myapex.key",
  6418. public_key: "testkey.avbpubkey",
  6419. private_key: "testkey.pem",
  6420. }
  6421. cc_library {
  6422. name: "mylib",
  6423. srcs: ["mylib.cpp"],
  6424. system_shared_libs: [],
  6425. stl: "none",
  6426. apex_available: ["myapex"],
  6427. shared_libs: ["mylib2"],
  6428. target: {
  6429. apex: {
  6430. exclude_shared_libs: ["mylib2"],
  6431. },
  6432. },
  6433. }
  6434. cc_library {
  6435. name: "mylib2",
  6436. srcs: ["mylib.cpp"],
  6437. system_shared_libs: [],
  6438. stl: "none",
  6439. }
  6440. `)
  6441. // Check if mylib is linked to mylib2 for the non-apex target
  6442. ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  6443. ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  6444. // Make sure that the link doesn't occur for the apex target
  6445. ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  6446. ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
  6447. // It shouldn't appear in the copy cmd as well.
  6448. copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
  6449. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  6450. }
  6451. func TestPrebuiltStubLibDep(t *testing.T) {
  6452. bpBase := `
  6453. apex {
  6454. name: "myapex",
  6455. key: "myapex.key",
  6456. native_shared_libs: ["mylib"],
  6457. updatable: false,
  6458. }
  6459. apex_key {
  6460. name: "myapex.key",
  6461. public_key: "testkey.avbpubkey",
  6462. private_key: "testkey.pem",
  6463. }
  6464. cc_library {
  6465. name: "mylib",
  6466. srcs: ["mylib.cpp"],
  6467. apex_available: ["myapex"],
  6468. shared_libs: ["stublib"],
  6469. system_shared_libs: [],
  6470. }
  6471. apex {
  6472. name: "otherapex",
  6473. enabled: %s,
  6474. key: "myapex.key",
  6475. native_shared_libs: ["stublib"],
  6476. updatable: false,
  6477. }
  6478. `
  6479. stublibSourceBp := `
  6480. cc_library {
  6481. name: "stublib",
  6482. srcs: ["mylib.cpp"],
  6483. apex_available: ["otherapex"],
  6484. system_shared_libs: [],
  6485. stl: "none",
  6486. stubs: {
  6487. versions: ["1"],
  6488. },
  6489. }
  6490. `
  6491. stublibPrebuiltBp := `
  6492. cc_prebuilt_library_shared {
  6493. name: "stublib",
  6494. srcs: ["prebuilt.so"],
  6495. apex_available: ["otherapex"],
  6496. stubs: {
  6497. versions: ["1"],
  6498. },
  6499. %s
  6500. }
  6501. `
  6502. tests := []struct {
  6503. name string
  6504. stublibBp string
  6505. usePrebuilt bool
  6506. modNames []string // Modules to collect AndroidMkEntries for
  6507. otherApexEnabled []string
  6508. }{
  6509. {
  6510. name: "only_source",
  6511. stublibBp: stublibSourceBp,
  6512. usePrebuilt: false,
  6513. modNames: []string{"stublib"},
  6514. otherApexEnabled: []string{"true", "false"},
  6515. },
  6516. {
  6517. name: "source_preferred",
  6518. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
  6519. usePrebuilt: false,
  6520. modNames: []string{"stublib", "prebuilt_stublib"},
  6521. otherApexEnabled: []string{"true", "false"},
  6522. },
  6523. {
  6524. name: "prebuilt_preferred",
  6525. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
  6526. usePrebuilt: true,
  6527. modNames: []string{"stublib", "prebuilt_stublib"},
  6528. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  6529. },
  6530. {
  6531. name: "only_prebuilt",
  6532. stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
  6533. usePrebuilt: true,
  6534. modNames: []string{"stublib"},
  6535. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  6536. },
  6537. }
  6538. for _, test := range tests {
  6539. t.Run(test.name, func(t *testing.T) {
  6540. for _, otherApexEnabled := range test.otherApexEnabled {
  6541. t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
  6542. ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
  6543. type modAndMkEntries struct {
  6544. mod *cc.Module
  6545. mkEntries android.AndroidMkEntries
  6546. }
  6547. entries := []*modAndMkEntries{}
  6548. // Gather shared lib modules that are installable
  6549. for _, modName := range test.modNames {
  6550. for _, variant := range ctx.ModuleVariantsForTests(modName) {
  6551. if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
  6552. continue
  6553. }
  6554. mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
  6555. if !mod.Enabled() || mod.IsHideFromMake() {
  6556. continue
  6557. }
  6558. for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
  6559. if ent.Disabled {
  6560. continue
  6561. }
  6562. entries = append(entries, &modAndMkEntries{
  6563. mod: mod,
  6564. mkEntries: ent,
  6565. })
  6566. }
  6567. }
  6568. }
  6569. var entry *modAndMkEntries = nil
  6570. for _, ent := range entries {
  6571. if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
  6572. if entry != nil {
  6573. t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
  6574. } else {
  6575. entry = ent
  6576. }
  6577. }
  6578. }
  6579. if entry == nil {
  6580. t.Errorf("AndroidMk entry for \"stublib\" missing")
  6581. } else {
  6582. isPrebuilt := entry.mod.Prebuilt() != nil
  6583. if isPrebuilt != test.usePrebuilt {
  6584. t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
  6585. }
  6586. if !entry.mod.IsStubs() {
  6587. t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
  6588. }
  6589. if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
  6590. t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
  6591. }
  6592. cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  6593. expected := "-D__STUBLIB_API__=1"
  6594. if !android.InList(expected, cflags) {
  6595. t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
  6596. }
  6597. }
  6598. })
  6599. }
  6600. })
  6601. }
  6602. }
  6603. func TestMain(m *testing.M) {
  6604. os.Exit(m.Run())
  6605. }