apex_test.go 258 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787578857895790579157925793579457955796579757985799580058015802580358045805580658075808580958105811581258135814581558165817581858195820582158225823582458255826582758285829583058315832583358345835583658375838583958405841584258435844584558465847584858495850585158525853585458555856585758585859586058615862586358645865586658675868586958705871587258735874587558765877587858795880588158825883588458855886588758885889589058915892589358945895589658975898589959005901590259035904590559065907590859095910591159125913591459155916591759185919592059215922592359245925592659275928592959305931593259335934593559365937593859395940594159425943594459455946594759485949595059515952595359545955595659575958595959605961596259635964596559665967596859695970597159725973597459755976597759785979598059815982598359845985598659875988598959905991599259935994599559965997599859996000600160026003600460056006600760086009601060116012601360146015601660176018601960206021602260236024602560266027602860296030603160326033603460356036603760386039604060416042604360446045604660476048604960506051605260536054605560566057605860596060606160626063606460656066606760686069607060716072607360746075607660776078607960806081608260836084608560866087608860896090609160926093609460956096609760986099610061016102610361046105610661076108610961106111611261136114611561166117611861196120612161226123612461256126612761286129613061316132613361346135613661376138613961406141614261436144614561466147614861496150615161526153615461556156615761586159616061616162616361646165616661676168616961706171617261736174617561766177617861796180618161826183618461856186618761886189619061916192619361946195619661976198619962006201620262036204620562066207620862096210621162126213621462156216621762186219622062216222622362246225622662276228622962306231623262336234623562366237623862396240624162426243624462456246624762486249625062516252625362546255625662576258625962606261626262636264626562666267626862696270627162726273627462756276627762786279628062816282628362846285628662876288628962906291629262936294629562966297629862996300630163026303630463056306630763086309631063116312631363146315631663176318631963206321632263236324632563266327632863296330633163326333633463356336633763386339634063416342634363446345634663476348634963506351635263536354635563566357635863596360636163626363636463656366636763686369637063716372637363746375637663776378637963806381638263836384638563866387638863896390639163926393639463956396639763986399640064016402640364046405640664076408640964106411641264136414641564166417641864196420642164226423642464256426642764286429643064316432643364346435643664376438643964406441644264436444644564466447644864496450645164526453645464556456645764586459646064616462646364646465646664676468646964706471647264736474647564766477647864796480648164826483648464856486648764886489649064916492649364946495649664976498649965006501650265036504650565066507650865096510651165126513651465156516651765186519652065216522652365246525652665276528652965306531653265336534653565366537653865396540654165426543654465456546654765486549655065516552655365546555655665576558655965606561656265636564656565666567656865696570657165726573657465756576657765786579658065816582658365846585658665876588658965906591659265936594659565966597659865996600660166026603660466056606660766086609661066116612661366146615661666176618661966206621662266236624662566266627662866296630663166326633663466356636663766386639664066416642664366446645664666476648664966506651665266536654665566566657665866596660666166626663666466656666666766686669667066716672667366746675667666776678667966806681668266836684668566866687668866896690669166926693669466956696669766986699670067016702670367046705670667076708670967106711671267136714671567166717671867196720672167226723672467256726672767286729673067316732673367346735673667376738673967406741674267436744674567466747674867496750675167526753675467556756675767586759676067616762676367646765676667676768676967706771677267736774677567766777677867796780678167826783678467856786678767886789679067916792679367946795679667976798679968006801680268036804680568066807680868096810681168126813681468156816681768186819682068216822682368246825682668276828682968306831683268336834683568366837683868396840684168426843684468456846684768486849685068516852685368546855685668576858685968606861686268636864686568666867686868696870687168726873687468756876687768786879688068816882688368846885688668876888688968906891689268936894689568966897689868996900690169026903690469056906690769086909691069116912691369146915691669176918691969206921692269236924692569266927692869296930693169326933693469356936693769386939694069416942694369446945694669476948694969506951695269536954695569566957695869596960696169626963696469656966696769686969697069716972697369746975697669776978697969806981698269836984698569866987698869896990699169926993699469956996699769986999700070017002700370047005700670077008700970107011701270137014701570167017701870197020702170227023702470257026702770287029703070317032703370347035703670377038703970407041704270437044704570467047704870497050705170527053705470557056705770587059706070617062706370647065706670677068706970707071707270737074707570767077707870797080708170827083708470857086708770887089709070917092709370947095709670977098709971007101710271037104710571067107710871097110711171127113711471157116711771187119712071217122712371247125712671277128712971307131713271337134713571367137713871397140714171427143714471457146714771487149715071517152715371547155715671577158715971607161716271637164716571667167716871697170717171727173717471757176717771787179718071817182718371847185718671877188718971907191719271937194719571967197719871997200720172027203720472057206720772087209721072117212721372147215721672177218721972207221722272237224722572267227722872297230723172327233723472357236723772387239724072417242724372447245724672477248724972507251725272537254725572567257725872597260726172627263726472657266726772687269727072717272727372747275727672777278727972807281728272837284728572867287728872897290729172927293729472957296729772987299730073017302730373047305730673077308730973107311731273137314731573167317731873197320732173227323732473257326732773287329733073317332733373347335733673377338733973407341734273437344734573467347734873497350735173527353735473557356735773587359736073617362736373647365736673677368736973707371737273737374737573767377737873797380738173827383738473857386738773887389739073917392739373947395739673977398739974007401740274037404740574067407740874097410741174127413741474157416741774187419742074217422742374247425742674277428742974307431743274337434743574367437743874397440744174427443744474457446744774487449745074517452745374547455745674577458745974607461746274637464746574667467746874697470747174727473747474757476747774787479748074817482748374847485748674877488748974907491749274937494749574967497749874997500750175027503750475057506750775087509751075117512751375147515751675177518751975207521752275237524752575267527752875297530753175327533753475357536753775387539754075417542754375447545754675477548754975507551755275537554755575567557755875597560756175627563756475657566756775687569757075717572757375747575757675777578757975807581758275837584758575867587758875897590759175927593759475957596759775987599760076017602760376047605760676077608760976107611761276137614761576167617761876197620762176227623762476257626762776287629763076317632763376347635763676377638763976407641764276437644764576467647764876497650765176527653765476557656765776587659766076617662766376647665766676677668766976707671767276737674767576767677767876797680768176827683768476857686768776887689769076917692769376947695769676977698769977007701770277037704770577067707770877097710771177127713771477157716771777187719772077217722772377247725772677277728772977307731773277337734773577367737773877397740774177427743774477457746774777487749775077517752775377547755775677577758775977607761776277637764776577667767776877697770777177727773777477757776777777787779778077817782778377847785778677877788778977907791779277937794779577967797779877997800780178027803780478057806780778087809781078117812781378147815781678177818781978207821782278237824782578267827782878297830783178327833783478357836783778387839784078417842784378447845784678477848784978507851785278537854785578567857785878597860786178627863786478657866786778687869787078717872787378747875787678777878787978807881788278837884788578867887788878897890789178927893789478957896789778987899790079017902790379047905790679077908790979107911791279137914791579167917791879197920792179227923792479257926792779287929793079317932793379347935793679377938793979407941794279437944794579467947794879497950795179527953795479557956795779587959796079617962796379647965796679677968796979707971797279737974797579767977797879797980798179827983798479857986798779887989799079917992799379947995799679977998799980008001800280038004800580068007800880098010801180128013801480158016801780188019802080218022802380248025802680278028802980308031803280338034803580368037803880398040804180428043804480458046804780488049805080518052805380548055805680578058805980608061806280638064806580668067806880698070807180728073807480758076807780788079808080818082808380848085808680878088808980908091809280938094809580968097809880998100810181028103810481058106810781088109811081118112811381148115811681178118811981208121812281238124812581268127812881298130813181328133813481358136813781388139814081418142814381448145814681478148814981508151815281538154815581568157815881598160816181628163816481658166816781688169817081718172817381748175817681778178817981808181818281838184818581868187818881898190819181928193819481958196819781988199820082018202820382048205820682078208820982108211821282138214821582168217821882198220822182228223822482258226822782288229823082318232823382348235823682378238823982408241824282438244824582468247824882498250825182528253825482558256825782588259826082618262826382648265826682678268826982708271827282738274827582768277827882798280828182828283828482858286828782888289829082918292829382948295829682978298829983008301830283038304830583068307830883098310831183128313831483158316831783188319832083218322832383248325832683278328832983308331833283338334833583368337833883398340834183428343834483458346834783488349835083518352835383548355835683578358835983608361836283638364836583668367836883698370837183728373837483758376837783788379838083818382838383848385838683878388838983908391839283938394839583968397839883998400840184028403840484058406840784088409841084118412841384148415841684178418841984208421842284238424842584268427842884298430843184328433843484358436843784388439844084418442844384448445844684478448844984508451845284538454845584568457845884598460846184628463846484658466846784688469847084718472847384748475847684778478847984808481848284838484848584868487848884898490849184928493849484958496849784988499850085018502850385048505850685078508850985108511851285138514851585168517851885198520852185228523852485258526852785288529853085318532853385348535853685378538853985408541854285438544854585468547854885498550855185528553855485558556855785588559856085618562856385648565856685678568856985708571857285738574857585768577857885798580858185828583858485858586858785888589859085918592859385948595859685978598859986008601860286038604860586068607860886098610861186128613861486158616861786188619862086218622862386248625862686278628862986308631863286338634863586368637863886398640864186428643864486458646864786488649865086518652865386548655865686578658865986608661866286638664866586668667866886698670867186728673867486758676867786788679868086818682868386848685868686878688868986908691869286938694869586968697869886998700870187028703870487058706870787088709871087118712871387148715871687178718871987208721872287238724872587268727872887298730873187328733873487358736873787388739874087418742874387448745874687478748874987508751875287538754875587568757875887598760876187628763876487658766876787688769877087718772877387748775877687778778877987808781878287838784878587868787878887898790879187928793879487958796879787988799880088018802880388048805880688078808880988108811881288138814881588168817881888198820882188228823882488258826882788288829883088318832883388348835883688378838883988408841884288438844884588468847884888498850885188528853885488558856885788588859886088618862886388648865886688678868886988708871887288738874887588768877887888798880888188828883888488858886888788888889889088918892889388948895889688978898889989008901890289038904890589068907890889098910891189128913891489158916891789188919892089218922892389248925892689278928892989308931893289338934893589368937893889398940894189428943894489458946894789488949895089518952895389548955895689578958895989608961896289638964896589668967896889698970897189728973897489758976897789788979898089818982898389848985898689878988898989908991899289938994899589968997899889999000900190029003900490059006900790089009901090119012901390149015901690179018901990209021902290239024902590269027902890299030903190329033903490359036903790389039904090419042904390449045904690479048904990509051905290539054905590569057905890599060906190629063906490659066906790689069907090719072907390749075907690779078907990809081908290839084908590869087908890899090909190929093909490959096909790989099910091019102910391049105910691079108910991109111911291139114911591169117911891199120912191229123912491259126912791289129913091319132913391349135913691379138913991409141914291439144914591469147914891499150915191529153915491559156915791589159916091619162916391649165916691679168916991709171917291739174917591769177917891799180918191829183918491859186918791889189919091919192919391949195919691979198919992009201920292039204920592069207920892099210921192129213921492159216921792189219922092219222922392249225922692279228922992309231923292339234923592369237923892399240924192429243924492459246924792489249925092519252925392549255925692579258925992609261926292639264926592669267926892699270927192729273927492759276927792789279928092819282928392849285928692879288928992909291929292939294929592969297929892999300930193029303930493059306930793089309931093119312931393149315931693179318931993209321932293239324932593269327932893299330933193329333933493359336933793389339934093419342934393449345934693479348934993509351935293539354935593569357935893599360936193629363936493659366936793689369937093719372937393749375937693779378937993809381938293839384938593869387938893899390939193929393939493959396939793989399940094019402940394049405940694079408940994109411941294139414941594169417941894199420942194229423942494259426942794289429943094319432943394349435943694379438943994409441944294439444944594469447944894499450945194529453945494559456945794589459946094619462946394649465946694679468946994709471947294739474947594769477947894799480948194829483948494859486948794889489949094919492949394949495949694979498949995009501950295039504950595069507950895099510951195129513951495159516951795189519952095219522952395249525952695279528952995309531953295339534953595369537953895399540954195429543954495459546954795489549
  1. // Copyright 2018 Google Inc. All rights reserved.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. package apex
  15. import (
  16. "fmt"
  17. "os"
  18. "path"
  19. "path/filepath"
  20. "reflect"
  21. "regexp"
  22. "sort"
  23. "strconv"
  24. "strings"
  25. "testing"
  26. "github.com/google/blueprint/proptools"
  27. "android/soong/android"
  28. "android/soong/bpf"
  29. "android/soong/cc"
  30. "android/soong/dexpreopt"
  31. prebuilt_etc "android/soong/etc"
  32. "android/soong/java"
  33. "android/soong/rust"
  34. "android/soong/sh"
  35. )
  36. // names returns name list from white space separated string
  37. func names(s string) (ns []string) {
  38. for _, n := range strings.Split(s, " ") {
  39. if len(n) > 0 {
  40. ns = append(ns, n)
  41. }
  42. }
  43. return
  44. }
  45. func testApexError(t *testing.T, pattern, bp string, preparers ...android.FixturePreparer) {
  46. t.Helper()
  47. android.GroupFixturePreparers(
  48. prepareForApexTest,
  49. android.GroupFixturePreparers(preparers...),
  50. ).
  51. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
  52. RunTestWithBp(t, bp)
  53. }
  54. func testApex(t *testing.T, bp string, preparers ...android.FixturePreparer) *android.TestContext {
  55. t.Helper()
  56. optionalBpPreparer := android.NullFixturePreparer
  57. if bp != "" {
  58. optionalBpPreparer = android.FixtureWithRootAndroidBp(bp)
  59. }
  60. result := android.GroupFixturePreparers(
  61. prepareForApexTest,
  62. android.GroupFixturePreparers(preparers...),
  63. optionalBpPreparer,
  64. ).RunTest(t)
  65. return result.TestContext
  66. }
  67. func withFiles(files android.MockFS) android.FixturePreparer {
  68. return files.AddToFixture()
  69. }
  70. func withTargets(targets map[android.OsType][]android.Target) android.FixturePreparer {
  71. return android.FixtureModifyConfig(func(config android.Config) {
  72. for k, v := range targets {
  73. config.Targets[k] = v
  74. }
  75. })
  76. }
  77. // withNativeBridgeTargets sets configuration with targets including:
  78. // - X86_64 (primary)
  79. // - X86 (secondary)
  80. // - Arm64 on X86_64 (native bridge)
  81. // - Arm on X86 (native bridge)
  82. var withNativeBridgeEnabled = android.FixtureModifyConfig(
  83. func(config android.Config) {
  84. config.Targets[android.Android] = []android.Target{
  85. {Os: android.Android, Arch: android.Arch{ArchType: android.X86_64, ArchVariant: "silvermont", Abi: []string{"arm64-v8a"}},
  86. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  87. {Os: android.Android, Arch: android.Arch{ArchType: android.X86, ArchVariant: "silvermont", Abi: []string{"armeabi-v7a"}},
  88. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  89. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}},
  90. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86_64", NativeBridgeRelativePath: "arm64"},
  91. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  92. NativeBridge: android.NativeBridgeEnabled, NativeBridgeHostArchName: "x86", NativeBridgeRelativePath: "arm"},
  93. }
  94. },
  95. )
  96. func withManifestPackageNameOverrides(specs []string) android.FixturePreparer {
  97. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  98. variables.ManifestPackageNameOverrides = specs
  99. })
  100. }
  101. func withApexGlobalMinSdkVersionOverride(minSdkOverride *string) android.FixturePreparer {
  102. return android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  103. variables.ApexGlobalMinSdkVersionOverride = minSdkOverride
  104. })
  105. }
  106. var withBinder32bit = android.FixtureModifyProductVariables(
  107. func(variables android.FixtureProductVariables) {
  108. variables.Binder32bit = proptools.BoolPtr(true)
  109. },
  110. )
  111. var withUnbundledBuild = android.FixtureModifyProductVariables(
  112. func(variables android.FixtureProductVariables) {
  113. variables.Unbundled_build = proptools.BoolPtr(true)
  114. },
  115. )
  116. // Legacy preparer used for running tests within the apex package.
  117. //
  118. // This includes everything that was needed to run any test in the apex package prior to the
  119. // introduction of the test fixtures. Tests that are being converted to use fixtures directly
  120. // rather than through the testApex...() methods should avoid using this and instead use the
  121. // various preparers directly, using android.GroupFixturePreparers(...) to group them when
  122. // necessary.
  123. //
  124. // deprecated
  125. var prepareForApexTest = android.GroupFixturePreparers(
  126. // General preparers in alphabetical order as test infrastructure will enforce correct
  127. // registration order.
  128. android.PrepareForTestWithAndroidBuildComponents,
  129. bpf.PrepareForTestWithBpf,
  130. cc.PrepareForTestWithCcBuildComponents,
  131. java.PrepareForTestWithJavaDefaultModules,
  132. prebuilt_etc.PrepareForTestWithPrebuiltEtc,
  133. rust.PrepareForTestWithRustDefaultModules,
  134. sh.PrepareForTestWithShBuildComponents,
  135. PrepareForTestWithApexBuildComponents,
  136. // Additional apex test specific preparers.
  137. android.FixtureAddTextFile("system/sepolicy/Android.bp", `
  138. filegroup {
  139. name: "myapex-file_contexts",
  140. srcs: [
  141. "apex/myapex-file_contexts",
  142. ],
  143. }
  144. `),
  145. prepareForTestWithMyapex,
  146. android.FixtureMergeMockFs(android.MockFS{
  147. "a.java": nil,
  148. "PrebuiltAppFoo.apk": nil,
  149. "PrebuiltAppFooPriv.apk": nil,
  150. "apex_manifest.json": nil,
  151. "AndroidManifest.xml": nil,
  152. "system/sepolicy/apex/myapex.updatable-file_contexts": nil,
  153. "system/sepolicy/apex/myapex2-file_contexts": nil,
  154. "system/sepolicy/apex/otherapex-file_contexts": nil,
  155. "system/sepolicy/apex/com.android.vndk-file_contexts": nil,
  156. "system/sepolicy/apex/com.android.vndk.current-file_contexts": nil,
  157. "mylib.cpp": nil,
  158. "mytest.cpp": nil,
  159. "mytest1.cpp": nil,
  160. "mytest2.cpp": nil,
  161. "mytest3.cpp": nil,
  162. "myprebuilt": nil,
  163. "my_include": nil,
  164. "foo/bar/MyClass.java": nil,
  165. "prebuilt.jar": nil,
  166. "prebuilt.so": nil,
  167. "vendor/foo/devkeys/test.x509.pem": nil,
  168. "vendor/foo/devkeys/test.pk8": nil,
  169. "testkey.x509.pem": nil,
  170. "testkey.pk8": nil,
  171. "testkey.override.x509.pem": nil,
  172. "testkey.override.pk8": nil,
  173. "vendor/foo/devkeys/testkey.avbpubkey": nil,
  174. "vendor/foo/devkeys/testkey.pem": nil,
  175. "NOTICE": nil,
  176. "custom_notice": nil,
  177. "custom_notice_for_static_lib": nil,
  178. "testkey2.avbpubkey": nil,
  179. "testkey2.pem": nil,
  180. "myapex-arm64.apex": nil,
  181. "myapex-arm.apex": nil,
  182. "myapex.apks": nil,
  183. "frameworks/base/api/current.txt": nil,
  184. "framework/aidl/a.aidl": nil,
  185. "dummy.txt": nil,
  186. "baz": nil,
  187. "bar/baz": nil,
  188. "testdata/baz": nil,
  189. "AppSet.apks": nil,
  190. "foo.rs": nil,
  191. "libfoo.jar": nil,
  192. "libbar.jar": nil,
  193. },
  194. ),
  195. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  196. variables.DeviceVndkVersion = proptools.StringPtr("current")
  197. variables.DefaultAppCertificate = proptools.StringPtr("vendor/foo/devkeys/test")
  198. variables.CertificateOverrides = []string{"myapex_keytest:myapex.certificate.override"}
  199. variables.Platform_sdk_codename = proptools.StringPtr("Q")
  200. variables.Platform_sdk_final = proptools.BoolPtr(false)
  201. // "Tiramisu" needs to be in the next line for compatibility with soong code,
  202. // not because of these tests specifically (it's not used by the tests)
  203. variables.Platform_version_active_codenames = []string{"Q", "Tiramisu"}
  204. variables.Platform_vndk_version = proptools.StringPtr("29")
  205. variables.BuildId = proptools.StringPtr("TEST.BUILD_ID")
  206. }),
  207. )
  208. var prepareForTestWithMyapex = android.FixtureMergeMockFs(android.MockFS{
  209. "system/sepolicy/apex/myapex-file_contexts": nil,
  210. })
  211. // ensure that 'result' equals 'expected'
  212. func ensureEquals(t *testing.T, result string, expected string) {
  213. t.Helper()
  214. if result != expected {
  215. t.Errorf("%q != %q", expected, result)
  216. }
  217. }
  218. // ensure that 'result' contains 'expected'
  219. func ensureContains(t *testing.T, result string, expected string) {
  220. t.Helper()
  221. if !strings.Contains(result, expected) {
  222. t.Errorf("%q is not found in %q", expected, result)
  223. }
  224. }
  225. // ensure that 'result' contains 'expected' exactly one time
  226. func ensureContainsOnce(t *testing.T, result string, expected string) {
  227. t.Helper()
  228. count := strings.Count(result, expected)
  229. if count != 1 {
  230. t.Errorf("%q is found %d times (expected 1 time) in %q", expected, count, result)
  231. }
  232. }
  233. // ensures that 'result' does not contain 'notExpected'
  234. func ensureNotContains(t *testing.T, result string, notExpected string) {
  235. t.Helper()
  236. if strings.Contains(result, notExpected) {
  237. t.Errorf("%q is found in %q", notExpected, result)
  238. }
  239. }
  240. func ensureMatches(t *testing.T, result string, expectedRex string) {
  241. ok, err := regexp.MatchString(expectedRex, result)
  242. if err != nil {
  243. t.Fatalf("regexp failure trying to match %s against `%s` expression: %s", result, expectedRex, err)
  244. return
  245. }
  246. if !ok {
  247. t.Errorf("%s does not match regular expession %s", result, expectedRex)
  248. }
  249. }
  250. func ensureListContains(t *testing.T, result []string, expected string) {
  251. t.Helper()
  252. if !android.InList(expected, result) {
  253. t.Errorf("%q is not found in %v", expected, result)
  254. }
  255. }
  256. func ensureListNotContains(t *testing.T, result []string, notExpected string) {
  257. t.Helper()
  258. if android.InList(notExpected, result) {
  259. t.Errorf("%q is found in %v", notExpected, result)
  260. }
  261. }
  262. func ensureListEmpty(t *testing.T, result []string) {
  263. t.Helper()
  264. if len(result) > 0 {
  265. t.Errorf("%q is expected to be empty", result)
  266. }
  267. }
  268. func ensureListNotEmpty(t *testing.T, result []string) {
  269. t.Helper()
  270. if len(result) == 0 {
  271. t.Errorf("%q is expected to be not empty", result)
  272. }
  273. }
  274. // Minimal test
  275. func TestBasicApex(t *testing.T) {
  276. ctx := testApex(t, `
  277. apex_defaults {
  278. name: "myapex-defaults",
  279. manifest: ":myapex.manifest",
  280. androidManifest: ":myapex.androidmanifest",
  281. key: "myapex.key",
  282. binaries: ["foo.rust"],
  283. native_shared_libs: [
  284. "mylib",
  285. "libfoo.ffi",
  286. ],
  287. rust_dyn_libs: ["libfoo.dylib.rust"],
  288. multilib: {
  289. both: {
  290. binaries: ["foo"],
  291. }
  292. },
  293. java_libs: [
  294. "myjar",
  295. "myjar_dex",
  296. ],
  297. updatable: false,
  298. }
  299. apex {
  300. name: "myapex",
  301. defaults: ["myapex-defaults"],
  302. }
  303. apex_key {
  304. name: "myapex.key",
  305. public_key: "testkey.avbpubkey",
  306. private_key: "testkey.pem",
  307. }
  308. filegroup {
  309. name: "myapex.manifest",
  310. srcs: ["apex_manifest.json"],
  311. }
  312. filegroup {
  313. name: "myapex.androidmanifest",
  314. srcs: ["AndroidManifest.xml"],
  315. }
  316. cc_library {
  317. name: "mylib",
  318. srcs: ["mylib.cpp"],
  319. shared_libs: [
  320. "mylib2",
  321. "libbar.ffi",
  322. ],
  323. system_shared_libs: [],
  324. stl: "none",
  325. // TODO: remove //apex_available:platform
  326. apex_available: [
  327. "//apex_available:platform",
  328. "myapex",
  329. ],
  330. }
  331. cc_binary {
  332. name: "foo",
  333. srcs: ["mylib.cpp"],
  334. compile_multilib: "both",
  335. multilib: {
  336. lib32: {
  337. suffix: "32",
  338. },
  339. lib64: {
  340. suffix: "64",
  341. },
  342. },
  343. symlinks: ["foo_link_"],
  344. symlink_preferred_arch: true,
  345. system_shared_libs: [],
  346. stl: "none",
  347. apex_available: [ "myapex", "com.android.gki.*" ],
  348. }
  349. rust_binary {
  350. name: "foo.rust",
  351. srcs: ["foo.rs"],
  352. rlibs: ["libfoo.rlib.rust"],
  353. dylibs: ["libfoo.dylib.rust"],
  354. apex_available: ["myapex"],
  355. }
  356. rust_library_rlib {
  357. name: "libfoo.rlib.rust",
  358. srcs: ["foo.rs"],
  359. crate_name: "foo",
  360. apex_available: ["myapex"],
  361. shared_libs: ["libfoo.shared_from_rust"],
  362. }
  363. cc_library_shared {
  364. name: "libfoo.shared_from_rust",
  365. srcs: ["mylib.cpp"],
  366. system_shared_libs: [],
  367. stl: "none",
  368. apex_available: ["myapex"],
  369. }
  370. rust_library_dylib {
  371. name: "libfoo.dylib.rust",
  372. srcs: ["foo.rs"],
  373. crate_name: "foo",
  374. apex_available: ["myapex"],
  375. }
  376. rust_ffi_shared {
  377. name: "libfoo.ffi",
  378. srcs: ["foo.rs"],
  379. crate_name: "foo",
  380. apex_available: ["myapex"],
  381. }
  382. rust_ffi_shared {
  383. name: "libbar.ffi",
  384. srcs: ["foo.rs"],
  385. crate_name: "bar",
  386. apex_available: ["myapex"],
  387. }
  388. apex {
  389. name: "com.android.gki.fake",
  390. binaries: ["foo"],
  391. key: "myapex.key",
  392. file_contexts: ":myapex-file_contexts",
  393. updatable: false,
  394. }
  395. cc_library_shared {
  396. name: "mylib2",
  397. srcs: ["mylib.cpp"],
  398. system_shared_libs: [],
  399. stl: "none",
  400. static_libs: ["libstatic"],
  401. // TODO: remove //apex_available:platform
  402. apex_available: [
  403. "//apex_available:platform",
  404. "myapex",
  405. ],
  406. }
  407. cc_prebuilt_library_shared {
  408. name: "mylib2",
  409. srcs: ["prebuilt.so"],
  410. // TODO: remove //apex_available:platform
  411. apex_available: [
  412. "//apex_available:platform",
  413. "myapex",
  414. ],
  415. }
  416. cc_library_static {
  417. name: "libstatic",
  418. srcs: ["mylib.cpp"],
  419. system_shared_libs: [],
  420. stl: "none",
  421. // TODO: remove //apex_available:platform
  422. apex_available: [
  423. "//apex_available:platform",
  424. "myapex",
  425. ],
  426. }
  427. java_library {
  428. name: "myjar",
  429. srcs: ["foo/bar/MyClass.java"],
  430. stem: "myjar_stem",
  431. sdk_version: "none",
  432. system_modules: "none",
  433. static_libs: ["myotherjar"],
  434. libs: ["mysharedjar"],
  435. // TODO: remove //apex_available:platform
  436. apex_available: [
  437. "//apex_available:platform",
  438. "myapex",
  439. ],
  440. }
  441. dex_import {
  442. name: "myjar_dex",
  443. jars: ["prebuilt.jar"],
  444. apex_available: [
  445. "//apex_available:platform",
  446. "myapex",
  447. ],
  448. }
  449. java_library {
  450. name: "myotherjar",
  451. srcs: ["foo/bar/MyClass.java"],
  452. sdk_version: "none",
  453. system_modules: "none",
  454. // TODO: remove //apex_available:platform
  455. apex_available: [
  456. "//apex_available:platform",
  457. "myapex",
  458. ],
  459. }
  460. java_library {
  461. name: "mysharedjar",
  462. srcs: ["foo/bar/MyClass.java"],
  463. sdk_version: "none",
  464. system_modules: "none",
  465. }
  466. `)
  467. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  468. // Make sure that Android.mk is created
  469. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  470. data := android.AndroidMkDataForTest(t, ctx, ab)
  471. var builder strings.Builder
  472. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  473. androidMk := builder.String()
  474. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  475. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  476. optFlags := apexRule.Args["opt_flags"]
  477. ensureContains(t, optFlags, "--pubkey vendor/foo/devkeys/testkey.avbpubkey")
  478. // Ensure that the NOTICE output is being packaged as an asset.
  479. ensureContains(t, optFlags, "--assets_dir out/soong/.intermediates/myapex/android_common_myapex_image/NOTICE")
  480. copyCmds := apexRule.Args["copy_commands"]
  481. // Ensure that main rule creates an output
  482. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  483. // Ensure that apex variant is created for the direct dep
  484. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  485. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common_apex10000")
  486. ensureListContains(t, ctx.ModuleVariantsForTests("myjar_dex"), "android_common_apex10000")
  487. ensureListContains(t, ctx.ModuleVariantsForTests("foo.rust"), "android_arm64_armv8-a_apex10000")
  488. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.ffi"), "android_arm64_armv8-a_shared_apex10000")
  489. // Ensure that apex variant is created for the indirect dep
  490. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  491. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common_apex10000")
  492. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.rlib.rust"), "android_arm64_armv8-a_rlib_dylib-std_apex10000")
  493. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.dylib.rust"), "android_arm64_armv8-a_dylib_apex10000")
  494. ensureListContains(t, ctx.ModuleVariantsForTests("libbar.ffi"), "android_arm64_armv8-a_shared_apex10000")
  495. ensureListContains(t, ctx.ModuleVariantsForTests("libfoo.shared_from_rust"), "android_arm64_armv8-a_shared_apex10000")
  496. // Ensure that both direct and indirect deps are copied into apex
  497. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  498. ensureContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  499. ensureContains(t, copyCmds, "image.apex/javalib/myjar_stem.jar")
  500. ensureContains(t, copyCmds, "image.apex/javalib/myjar_dex.jar")
  501. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.dylib.rust.dylib.so")
  502. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.ffi.so")
  503. ensureContains(t, copyCmds, "image.apex/lib64/libbar.ffi.so")
  504. ensureContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  505. // .. but not for java libs
  506. ensureNotContains(t, copyCmds, "image.apex/javalib/myotherjar.jar")
  507. ensureNotContains(t, copyCmds, "image.apex/javalib/msharedjar.jar")
  508. // Ensure that the platform variant ends with _shared or _common
  509. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  510. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  511. ensureListContains(t, ctx.ModuleVariantsForTests("myjar"), "android_common")
  512. ensureListContains(t, ctx.ModuleVariantsForTests("myotherjar"), "android_common")
  513. ensureListContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common")
  514. // Ensure that dynamic dependency to java libs are not included
  515. ensureListNotContains(t, ctx.ModuleVariantsForTests("mysharedjar"), "android_common_myapex")
  516. // Ensure that all symlinks are present.
  517. found_foo_link_64 := false
  518. found_foo := false
  519. for _, cmd := range strings.Split(copyCmds, " && ") {
  520. if strings.HasPrefix(cmd, "ln -sfn foo64") {
  521. if strings.HasSuffix(cmd, "bin/foo") {
  522. found_foo = true
  523. } else if strings.HasSuffix(cmd, "bin/foo_link_64") {
  524. found_foo_link_64 = true
  525. }
  526. }
  527. }
  528. good := found_foo && found_foo_link_64
  529. if !good {
  530. t.Errorf("Could not find all expected symlinks! foo: %t, foo_link_64: %t. Command was %s", found_foo, found_foo_link_64, copyCmds)
  531. }
  532. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  533. ensureListContains(t, fullDepsInfo, " myjar(minSdkVersion:(no version)) <- myapex")
  534. ensureListContains(t, fullDepsInfo, " mylib2(minSdkVersion:(no version)) <- mylib")
  535. ensureListContains(t, fullDepsInfo, " myotherjar(minSdkVersion:(no version)) <- myjar")
  536. ensureListContains(t, fullDepsInfo, " mysharedjar(minSdkVersion:(no version)) (external) <- myjar")
  537. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  538. ensureListContains(t, flatDepsInfo, "myjar(minSdkVersion:(no version))")
  539. ensureListContains(t, flatDepsInfo, "mylib2(minSdkVersion:(no version))")
  540. ensureListContains(t, flatDepsInfo, "myotherjar(minSdkVersion:(no version))")
  541. ensureListContains(t, flatDepsInfo, "mysharedjar(minSdkVersion:(no version)) (external)")
  542. }
  543. func TestDefaults(t *testing.T) {
  544. ctx := testApex(t, `
  545. apex_defaults {
  546. name: "myapex-defaults",
  547. key: "myapex.key",
  548. prebuilts: ["myetc"],
  549. native_shared_libs: ["mylib"],
  550. java_libs: ["myjar"],
  551. apps: ["AppFoo"],
  552. rros: ["rro"],
  553. bpfs: ["bpf", "netdTest"],
  554. updatable: false,
  555. }
  556. prebuilt_etc {
  557. name: "myetc",
  558. src: "myprebuilt",
  559. }
  560. apex {
  561. name: "myapex",
  562. defaults: ["myapex-defaults"],
  563. }
  564. apex_key {
  565. name: "myapex.key",
  566. public_key: "testkey.avbpubkey",
  567. private_key: "testkey.pem",
  568. }
  569. cc_library {
  570. name: "mylib",
  571. system_shared_libs: [],
  572. stl: "none",
  573. apex_available: [ "myapex" ],
  574. }
  575. java_library {
  576. name: "myjar",
  577. srcs: ["foo/bar/MyClass.java"],
  578. sdk_version: "none",
  579. system_modules: "none",
  580. apex_available: [ "myapex" ],
  581. }
  582. android_app {
  583. name: "AppFoo",
  584. srcs: ["foo/bar/MyClass.java"],
  585. sdk_version: "none",
  586. system_modules: "none",
  587. apex_available: [ "myapex" ],
  588. }
  589. runtime_resource_overlay {
  590. name: "rro",
  591. theme: "blue",
  592. }
  593. bpf {
  594. name: "bpf",
  595. srcs: ["bpf.c", "bpf2.c"],
  596. }
  597. bpf {
  598. name: "netdTest",
  599. srcs: ["netdTest.c"],
  600. sub_dir: "netd",
  601. }
  602. `)
  603. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  604. "etc/myetc",
  605. "javalib/myjar.jar",
  606. "lib64/mylib.so",
  607. "app/AppFoo@TEST.BUILD_ID/AppFoo.apk",
  608. "overlay/blue/rro.apk",
  609. "etc/bpf/bpf.o",
  610. "etc/bpf/bpf2.o",
  611. "etc/bpf/netd/netdTest.o",
  612. })
  613. }
  614. func TestApexManifest(t *testing.T) {
  615. ctx := testApex(t, `
  616. apex {
  617. name: "myapex",
  618. key: "myapex.key",
  619. updatable: false,
  620. }
  621. apex_key {
  622. name: "myapex.key",
  623. public_key: "testkey.avbpubkey",
  624. private_key: "testkey.pem",
  625. }
  626. `)
  627. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  628. args := module.Rule("apexRule").Args
  629. if manifest := args["manifest"]; manifest != module.Output("apex_manifest.pb").Output.String() {
  630. t.Error("manifest should be apex_manifest.pb, but " + manifest)
  631. }
  632. }
  633. func TestApexManifestMinSdkVersion(t *testing.T) {
  634. ctx := testApex(t, `
  635. apex_defaults {
  636. name: "my_defaults",
  637. key: "myapex.key",
  638. product_specific: true,
  639. file_contexts: ":my-file-contexts",
  640. updatable: false,
  641. }
  642. apex {
  643. name: "myapex_30",
  644. min_sdk_version: "30",
  645. defaults: ["my_defaults"],
  646. }
  647. apex {
  648. name: "myapex_current",
  649. min_sdk_version: "current",
  650. defaults: ["my_defaults"],
  651. }
  652. apex {
  653. name: "myapex_none",
  654. defaults: ["my_defaults"],
  655. }
  656. apex_key {
  657. name: "myapex.key",
  658. public_key: "testkey.avbpubkey",
  659. private_key: "testkey.pem",
  660. }
  661. filegroup {
  662. name: "my-file-contexts",
  663. srcs: ["product_specific_file_contexts"],
  664. }
  665. `, withFiles(map[string][]byte{
  666. "product_specific_file_contexts": nil,
  667. }), android.FixtureModifyProductVariables(
  668. func(variables android.FixtureProductVariables) {
  669. variables.Unbundled_build = proptools.BoolPtr(true)
  670. variables.Always_use_prebuilt_sdks = proptools.BoolPtr(false)
  671. }), android.FixtureMergeEnv(map[string]string{
  672. "UNBUNDLED_BUILD_TARGET_SDK_WITH_API_FINGERPRINT": "true",
  673. }))
  674. testCases := []struct {
  675. module string
  676. minSdkVersion string
  677. }{
  678. {
  679. module: "myapex_30",
  680. minSdkVersion: "30",
  681. },
  682. {
  683. module: "myapex_current",
  684. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  685. },
  686. {
  687. module: "myapex_none",
  688. minSdkVersion: "Q.$$(cat out/soong/api_fingerprint.txt)",
  689. },
  690. }
  691. for _, tc := range testCases {
  692. module := ctx.ModuleForTests(tc.module, "android_common_"+tc.module+"_image")
  693. args := module.Rule("apexRule").Args
  694. optFlags := args["opt_flags"]
  695. if !strings.Contains(optFlags, "--min_sdk_version "+tc.minSdkVersion) {
  696. t.Errorf("%s: Expected min_sdk_version=%s, got: %s", tc.module, tc.minSdkVersion, optFlags)
  697. }
  698. }
  699. }
  700. func TestBasicZipApex(t *testing.T) {
  701. ctx := testApex(t, `
  702. apex {
  703. name: "myapex",
  704. key: "myapex.key",
  705. payload_type: "zip",
  706. native_shared_libs: ["mylib"],
  707. updatable: false,
  708. }
  709. apex_key {
  710. name: "myapex.key",
  711. public_key: "testkey.avbpubkey",
  712. private_key: "testkey.pem",
  713. }
  714. cc_library {
  715. name: "mylib",
  716. srcs: ["mylib.cpp"],
  717. shared_libs: ["mylib2"],
  718. system_shared_libs: [],
  719. stl: "none",
  720. apex_available: [ "myapex" ],
  721. }
  722. cc_library {
  723. name: "mylib2",
  724. srcs: ["mylib.cpp"],
  725. system_shared_libs: [],
  726. stl: "none",
  727. apex_available: [ "myapex" ],
  728. }
  729. `)
  730. zipApexRule := ctx.ModuleForTests("myapex", "android_common_myapex_zip").Rule("zipApexRule")
  731. copyCmds := zipApexRule.Args["copy_commands"]
  732. // Ensure that main rule creates an output
  733. ensureContains(t, zipApexRule.Output.String(), "myapex.zipapex.unsigned")
  734. // Ensure that APEX variant is created for the direct dep
  735. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  736. // Ensure that APEX variant is created for the indirect dep
  737. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  738. // Ensure that both direct and indirect deps are copied into apex
  739. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib.so")
  740. ensureContains(t, copyCmds, "image.zipapex/lib64/mylib2.so")
  741. }
  742. func TestApexWithStubs(t *testing.T) {
  743. ctx := testApex(t, `
  744. apex {
  745. name: "myapex",
  746. key: "myapex.key",
  747. native_shared_libs: ["mylib", "mylib3"],
  748. binaries: ["foo.rust"],
  749. updatable: false,
  750. }
  751. apex_key {
  752. name: "myapex.key",
  753. public_key: "testkey.avbpubkey",
  754. private_key: "testkey.pem",
  755. }
  756. cc_library {
  757. name: "mylib",
  758. srcs: ["mylib.cpp"],
  759. shared_libs: ["mylib2", "mylib3"],
  760. system_shared_libs: [],
  761. stl: "none",
  762. apex_available: [ "myapex" ],
  763. }
  764. cc_library {
  765. name: "mylib2",
  766. srcs: ["mylib.cpp"],
  767. cflags: ["-include mylib.h"],
  768. system_shared_libs: [],
  769. stl: "none",
  770. stubs: {
  771. versions: ["1", "2", "3"],
  772. },
  773. }
  774. cc_library {
  775. name: "mylib3",
  776. srcs: ["mylib.cpp"],
  777. shared_libs: ["mylib4"],
  778. system_shared_libs: [],
  779. stl: "none",
  780. stubs: {
  781. versions: ["10", "11", "12"],
  782. },
  783. apex_available: [ "myapex" ],
  784. }
  785. cc_library {
  786. name: "mylib4",
  787. srcs: ["mylib.cpp"],
  788. system_shared_libs: [],
  789. stl: "none",
  790. apex_available: [ "myapex" ],
  791. }
  792. rust_binary {
  793. name: "foo.rust",
  794. srcs: ["foo.rs"],
  795. shared_libs: ["libfoo.shared_from_rust"],
  796. prefer_rlib: true,
  797. apex_available: ["myapex"],
  798. }
  799. cc_library_shared {
  800. name: "libfoo.shared_from_rust",
  801. srcs: ["mylib.cpp"],
  802. system_shared_libs: [],
  803. stl: "none",
  804. stubs: {
  805. versions: ["10", "11", "12"],
  806. },
  807. }
  808. `)
  809. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  810. copyCmds := apexRule.Args["copy_commands"]
  811. // Ensure that direct non-stubs dep is always included
  812. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  813. // Ensure that indirect stubs dep is not included
  814. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  815. // Ensure that direct stubs dep is included
  816. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  817. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  818. // Ensure that mylib is linking with the latest version of stubs for mylib2
  819. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  820. // ... and not linking to the non-stub (impl) variant of mylib2
  821. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  822. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  823. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex10000/mylib3.so")
  824. // .. and not linking to the stubs variant of mylib3
  825. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_12/mylib3.so")
  826. // Comment out this test. Now it fails after the optimization of sharing "cflags" in cc/cc.go
  827. // is replaced by sharing of "cFlags" in cc/builder.go.
  828. // The "cflags" contains "-include mylib.h", but cFlags contained only a reference to the
  829. // module variable representing "cflags". So it was not detected by ensureNotContains.
  830. // Now "cFlags" is a reference to a module variable like $flags1, which includes all previous
  831. // content of "cflags". ModuleForTests...Args["cFlags"] returns the full string of $flags1,
  832. // including the original cflags's "-include mylib.h".
  833. //
  834. // Ensure that stubs libs are built without -include flags
  835. // mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  836. // ensureNotContains(t, mylib2Cflags, "-include ")
  837. // Ensure that genstub for platform-provided lib is invoked with --systemapi
  838. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_3").Rule("genStubSrc").Args["flags"], "--systemapi")
  839. // Ensure that genstub for apex-provided lib is invoked with --apex
  840. ensureContains(t, ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_shared_12").Rule("genStubSrc").Args["flags"], "--apex")
  841. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  842. "lib64/mylib.so",
  843. "lib64/mylib3.so",
  844. "lib64/mylib4.so",
  845. "bin/foo.rust",
  846. "lib64/libc++.so", // by the implicit dependency from foo.rust
  847. "lib64/liblog.so", // by the implicit dependency from foo.rust
  848. })
  849. // Ensure that stub dependency from a rust module is not included
  850. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  851. // The rust module is linked to the stub cc library
  852. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
  853. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  854. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  855. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  856. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  857. }
  858. func TestApexCanUsePrivateApis(t *testing.T) {
  859. ctx := testApex(t, `
  860. apex {
  861. name: "myapex",
  862. key: "myapex.key",
  863. native_shared_libs: ["mylib"],
  864. binaries: ["foo.rust"],
  865. updatable: false,
  866. platform_apis: true,
  867. }
  868. apex_key {
  869. name: "myapex.key",
  870. public_key: "testkey.avbpubkey",
  871. private_key: "testkey.pem",
  872. }
  873. cc_library {
  874. name: "mylib",
  875. srcs: ["mylib.cpp"],
  876. shared_libs: ["mylib2"],
  877. system_shared_libs: [],
  878. stl: "none",
  879. apex_available: [ "myapex" ],
  880. }
  881. cc_library {
  882. name: "mylib2",
  883. srcs: ["mylib.cpp"],
  884. cflags: ["-include mylib.h"],
  885. system_shared_libs: [],
  886. stl: "none",
  887. stubs: {
  888. versions: ["1", "2", "3"],
  889. },
  890. }
  891. rust_binary {
  892. name: "foo.rust",
  893. srcs: ["foo.rs"],
  894. shared_libs: ["libfoo.shared_from_rust"],
  895. prefer_rlib: true,
  896. apex_available: ["myapex"],
  897. }
  898. cc_library_shared {
  899. name: "libfoo.shared_from_rust",
  900. srcs: ["mylib.cpp"],
  901. system_shared_libs: [],
  902. stl: "none",
  903. stubs: {
  904. versions: ["10", "11", "12"],
  905. },
  906. }
  907. `)
  908. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  909. copyCmds := apexRule.Args["copy_commands"]
  910. // Ensure that indirect stubs dep is not included
  911. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  912. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.shared_from_rust.so")
  913. // Ensure that we are using non-stub variants of mylib2 and libfoo.shared_from_rust (because
  914. // of the platform_apis: true)
  915. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  916. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  917. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  918. rustDeps := ctx.ModuleForTests("foo.rust", "android_arm64_armv8-a_apex10000").Rule("rustc").Args["linkFlags"]
  919. ensureNotContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared_current/libfoo.shared_from_rust.so")
  920. ensureContains(t, rustDeps, "libfoo.shared_from_rust/android_arm64_armv8-a_shared/libfoo.shared_from_rust.so")
  921. }
  922. func TestApexWithStubsWithMinSdkVersion(t *testing.T) {
  923. t.Parallel()
  924. ctx := testApex(t, `
  925. apex {
  926. name: "myapex",
  927. key: "myapex.key",
  928. native_shared_libs: ["mylib", "mylib3"],
  929. min_sdk_version: "29",
  930. }
  931. apex_key {
  932. name: "myapex.key",
  933. public_key: "testkey.avbpubkey",
  934. private_key: "testkey.pem",
  935. }
  936. cc_library {
  937. name: "mylib",
  938. srcs: ["mylib.cpp"],
  939. shared_libs: ["mylib2", "mylib3"],
  940. system_shared_libs: [],
  941. stl: "none",
  942. apex_available: [ "myapex" ],
  943. min_sdk_version: "28",
  944. }
  945. cc_library {
  946. name: "mylib2",
  947. srcs: ["mylib.cpp"],
  948. cflags: ["-include mylib.h"],
  949. system_shared_libs: [],
  950. stl: "none",
  951. stubs: {
  952. versions: ["28", "29", "30", "current"],
  953. },
  954. min_sdk_version: "28",
  955. }
  956. cc_library {
  957. name: "mylib3",
  958. srcs: ["mylib.cpp"],
  959. shared_libs: ["mylib4"],
  960. system_shared_libs: [],
  961. stl: "none",
  962. stubs: {
  963. versions: ["28", "29", "30", "current"],
  964. },
  965. apex_available: [ "myapex" ],
  966. min_sdk_version: "28",
  967. }
  968. cc_library {
  969. name: "mylib4",
  970. srcs: ["mylib.cpp"],
  971. system_shared_libs: [],
  972. stl: "none",
  973. apex_available: [ "myapex" ],
  974. min_sdk_version: "28",
  975. }
  976. `)
  977. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  978. copyCmds := apexRule.Args["copy_commands"]
  979. // Ensure that direct non-stubs dep is always included
  980. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  981. // Ensure that indirect stubs dep is not included
  982. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  983. // Ensure that direct stubs dep is included
  984. ensureContains(t, copyCmds, "image.apex/lib64/mylib3.so")
  985. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex29").Rule("ld").Args["libFlags"]
  986. // Ensure that mylib is linking with the latest version of stub for mylib2
  987. ensureContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared_current/mylib2.so")
  988. // ... and not linking to the non-stub (impl) variant of mylib2
  989. ensureNotContains(t, mylibLdFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  990. // Ensure that mylib is linking with the non-stub (impl) of mylib3 (because mylib3 is in the same apex)
  991. ensureContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_apex29/mylib3.so")
  992. // .. and not linking to the stubs variant of mylib3
  993. ensureNotContains(t, mylibLdFlags, "mylib3/android_arm64_armv8-a_shared_29/mylib3.so")
  994. // Ensure that stubs libs are built without -include flags
  995. mylib2Cflags := ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("cc").Args["cFlags"]
  996. ensureNotContains(t, mylib2Cflags, "-include ")
  997. // Ensure that genstub is invoked with --systemapi
  998. ensureContains(t, ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_shared_29").Rule("genStubSrc").Args["flags"], "--systemapi")
  999. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1000. "lib64/mylib.so",
  1001. "lib64/mylib3.so",
  1002. "lib64/mylib4.so",
  1003. })
  1004. }
  1005. func TestApex_PlatformUsesLatestStubFromApex(t *testing.T) {
  1006. t.Parallel()
  1007. // myapex (Z)
  1008. // mylib -----------------.
  1009. // |
  1010. // otherapex (29) |
  1011. // libstub's versions: 29 Z current
  1012. // |
  1013. // <platform> |
  1014. // libplatform ----------------'
  1015. ctx := testApex(t, `
  1016. apex {
  1017. name: "myapex",
  1018. key: "myapex.key",
  1019. native_shared_libs: ["mylib"],
  1020. min_sdk_version: "Z", // non-final
  1021. }
  1022. cc_library {
  1023. name: "mylib",
  1024. srcs: ["mylib.cpp"],
  1025. shared_libs: ["libstub"],
  1026. apex_available: ["myapex"],
  1027. min_sdk_version: "Z",
  1028. }
  1029. apex_key {
  1030. name: "myapex.key",
  1031. public_key: "testkey.avbpubkey",
  1032. private_key: "testkey.pem",
  1033. }
  1034. apex {
  1035. name: "otherapex",
  1036. key: "myapex.key",
  1037. native_shared_libs: ["libstub"],
  1038. min_sdk_version: "29",
  1039. }
  1040. cc_library {
  1041. name: "libstub",
  1042. srcs: ["mylib.cpp"],
  1043. stubs: {
  1044. versions: ["29", "Z", "current"],
  1045. },
  1046. apex_available: ["otherapex"],
  1047. min_sdk_version: "29",
  1048. }
  1049. // platform module depending on libstub from otherapex should use the latest stub("current")
  1050. cc_library {
  1051. name: "libplatform",
  1052. srcs: ["mylib.cpp"],
  1053. shared_libs: ["libstub"],
  1054. }
  1055. `,
  1056. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1057. variables.Platform_sdk_codename = proptools.StringPtr("Z")
  1058. variables.Platform_sdk_final = proptools.BoolPtr(false)
  1059. variables.Platform_version_active_codenames = []string{"Z"}
  1060. }),
  1061. )
  1062. // Ensure that mylib from myapex is built against the latest stub (current)
  1063. mylibCflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1064. ensureContains(t, mylibCflags, "-D__LIBSTUB_API__=10000 ")
  1065. mylibLdflags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1066. ensureContains(t, mylibLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1067. // Ensure that libplatform is built against latest stub ("current") of mylib3 from the apex
  1068. libplatformCflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  1069. ensureContains(t, libplatformCflags, "-D__LIBSTUB_API__=10000 ") // "current" maps to 10000
  1070. libplatformLdflags := ctx.ModuleForTests("libplatform", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1071. ensureContains(t, libplatformLdflags, "libstub/android_arm64_armv8-a_shared_current/libstub.so ")
  1072. }
  1073. func TestApexWithExplicitStubsDependency(t *testing.T) {
  1074. ctx := testApex(t, `
  1075. apex {
  1076. name: "myapex2",
  1077. key: "myapex2.key",
  1078. native_shared_libs: ["mylib"],
  1079. updatable: false,
  1080. }
  1081. apex_key {
  1082. name: "myapex2.key",
  1083. public_key: "testkey.avbpubkey",
  1084. private_key: "testkey.pem",
  1085. }
  1086. cc_library {
  1087. name: "mylib",
  1088. srcs: ["mylib.cpp"],
  1089. shared_libs: ["libfoo#10"],
  1090. static_libs: ["libbaz"],
  1091. system_shared_libs: [],
  1092. stl: "none",
  1093. apex_available: [ "myapex2" ],
  1094. }
  1095. cc_library {
  1096. name: "libfoo",
  1097. srcs: ["mylib.cpp"],
  1098. shared_libs: ["libbar"],
  1099. system_shared_libs: [],
  1100. stl: "none",
  1101. stubs: {
  1102. versions: ["10", "20", "30"],
  1103. },
  1104. }
  1105. cc_library {
  1106. name: "libbar",
  1107. srcs: ["mylib.cpp"],
  1108. system_shared_libs: [],
  1109. stl: "none",
  1110. }
  1111. cc_library_static {
  1112. name: "libbaz",
  1113. srcs: ["mylib.cpp"],
  1114. system_shared_libs: [],
  1115. stl: "none",
  1116. apex_available: [ "myapex2" ],
  1117. }
  1118. `)
  1119. apexRule := ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Rule("apexRule")
  1120. copyCmds := apexRule.Args["copy_commands"]
  1121. // Ensure that direct non-stubs dep is always included
  1122. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1123. // Ensure that indirect stubs dep is not included
  1124. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1125. // Ensure that dependency of stubs is not included
  1126. ensureNotContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1127. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1128. // Ensure that mylib is linking with version 10 of libfoo
  1129. ensureContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared_10/libfoo.so")
  1130. // ... and not linking to the non-stub (impl) variant of libfoo
  1131. ensureNotContains(t, mylibLdFlags, "libfoo/android_arm64_armv8-a_shared/libfoo.so")
  1132. libFooStubsLdFlags := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_10").Rule("ld").Args["libFlags"]
  1133. // Ensure that libfoo stubs is not linking to libbar (since it is a stubs)
  1134. ensureNotContains(t, libFooStubsLdFlags, "libbar.so")
  1135. fullDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/fulllist.txt").Args["content"], "\\n")
  1136. ensureListContains(t, fullDepsInfo, " libfoo(minSdkVersion:(no version)) (external) <- mylib")
  1137. flatDepsInfo := strings.Split(ctx.ModuleForTests("myapex2", "android_common_myapex2_image").Output("depsinfo/flatlist.txt").Args["content"], "\\n")
  1138. ensureListContains(t, flatDepsInfo, "libfoo(minSdkVersion:(no version)) (external)")
  1139. }
  1140. func TestApexWithRuntimeLibsDependency(t *testing.T) {
  1141. /*
  1142. myapex
  1143. |
  1144. v (runtime_libs)
  1145. mylib ------+------> libfoo [provides stub]
  1146. |
  1147. `------> libbar
  1148. */
  1149. ctx := testApex(t, `
  1150. apex {
  1151. name: "myapex",
  1152. key: "myapex.key",
  1153. native_shared_libs: ["mylib"],
  1154. updatable: false,
  1155. }
  1156. apex_key {
  1157. name: "myapex.key",
  1158. public_key: "testkey.avbpubkey",
  1159. private_key: "testkey.pem",
  1160. }
  1161. cc_library {
  1162. name: "mylib",
  1163. srcs: ["mylib.cpp"],
  1164. runtime_libs: ["libfoo", "libbar"],
  1165. system_shared_libs: [],
  1166. stl: "none",
  1167. apex_available: [ "myapex" ],
  1168. }
  1169. cc_library {
  1170. name: "libfoo",
  1171. srcs: ["mylib.cpp"],
  1172. system_shared_libs: [],
  1173. stl: "none",
  1174. stubs: {
  1175. versions: ["10", "20", "30"],
  1176. },
  1177. }
  1178. cc_library {
  1179. name: "libbar",
  1180. srcs: ["mylib.cpp"],
  1181. system_shared_libs: [],
  1182. stl: "none",
  1183. apex_available: [ "myapex" ],
  1184. }
  1185. `)
  1186. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1187. copyCmds := apexRule.Args["copy_commands"]
  1188. // Ensure that direct non-stubs dep is always included
  1189. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1190. // Ensure that indirect stubs dep is not included
  1191. ensureNotContains(t, copyCmds, "image.apex/lib64/libfoo.so")
  1192. // Ensure that runtime_libs dep in included
  1193. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  1194. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1195. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1196. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libfoo.so")
  1197. }
  1198. var prepareForTestOfRuntimeApexWithHwasan = android.GroupFixturePreparers(
  1199. cc.PrepareForTestWithCcBuildComponents,
  1200. PrepareForTestWithApexBuildComponents,
  1201. android.FixtureAddTextFile("bionic/apex/Android.bp", `
  1202. apex {
  1203. name: "com.android.runtime",
  1204. key: "com.android.runtime.key",
  1205. native_shared_libs: ["libc"],
  1206. updatable: false,
  1207. }
  1208. apex_key {
  1209. name: "com.android.runtime.key",
  1210. public_key: "testkey.avbpubkey",
  1211. private_key: "testkey.pem",
  1212. }
  1213. `),
  1214. android.FixtureAddFile("system/sepolicy/apex/com.android.runtime-file_contexts", nil),
  1215. )
  1216. func TestRuntimeApexShouldInstallHwasanIfLibcDependsOnIt(t *testing.T) {
  1217. result := android.GroupFixturePreparers(prepareForTestOfRuntimeApexWithHwasan).RunTestWithBp(t, `
  1218. cc_library {
  1219. name: "libc",
  1220. no_libcrt: true,
  1221. nocrt: true,
  1222. stl: "none",
  1223. system_shared_libs: [],
  1224. stubs: { versions: ["1"] },
  1225. apex_available: ["com.android.runtime"],
  1226. sanitize: {
  1227. hwaddress: true,
  1228. }
  1229. }
  1230. cc_prebuilt_library_shared {
  1231. name: "libclang_rt.hwasan",
  1232. no_libcrt: true,
  1233. nocrt: true,
  1234. stl: "none",
  1235. system_shared_libs: [],
  1236. srcs: [""],
  1237. stubs: { versions: ["1"] },
  1238. stem: "libclang_rt.hwasan-aarch64-android",
  1239. sanitize: {
  1240. never: true,
  1241. },
  1242. } `)
  1243. ctx := result.TestContext
  1244. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1245. "lib64/bionic/libc.so",
  1246. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1247. })
  1248. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1249. installed := hwasan.Description("install libclang_rt.hwasan")
  1250. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1251. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1252. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1253. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1254. }
  1255. func TestRuntimeApexShouldInstallHwasanIfHwaddressSanitized(t *testing.T) {
  1256. result := android.GroupFixturePreparers(
  1257. prepareForTestOfRuntimeApexWithHwasan,
  1258. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1259. variables.SanitizeDevice = []string{"hwaddress"}
  1260. }),
  1261. ).RunTestWithBp(t, `
  1262. cc_library {
  1263. name: "libc",
  1264. no_libcrt: true,
  1265. nocrt: true,
  1266. stl: "none",
  1267. system_shared_libs: [],
  1268. stubs: { versions: ["1"] },
  1269. apex_available: ["com.android.runtime"],
  1270. }
  1271. cc_prebuilt_library_shared {
  1272. name: "libclang_rt.hwasan",
  1273. no_libcrt: true,
  1274. nocrt: true,
  1275. stl: "none",
  1276. system_shared_libs: [],
  1277. srcs: [""],
  1278. stubs: { versions: ["1"] },
  1279. stem: "libclang_rt.hwasan-aarch64-android",
  1280. sanitize: {
  1281. never: true,
  1282. },
  1283. }
  1284. `)
  1285. ctx := result.TestContext
  1286. ensureExactContents(t, ctx, "com.android.runtime", "android_common_hwasan_com.android.runtime_image", []string{
  1287. "lib64/bionic/libc.so",
  1288. "lib64/bionic/libclang_rt.hwasan-aarch64-android.so",
  1289. })
  1290. hwasan := ctx.ModuleForTests("libclang_rt.hwasan", "android_arm64_armv8-a_shared")
  1291. installed := hwasan.Description("install libclang_rt.hwasan")
  1292. ensureContains(t, installed.Output.String(), "/system/lib64/bootstrap/libclang_rt.hwasan-aarch64-android.so")
  1293. symlink := hwasan.Description("install symlink libclang_rt.hwasan")
  1294. ensureEquals(t, symlink.Args["fromPath"], "/apex/com.android.runtime/lib64/bionic/libclang_rt.hwasan-aarch64-android.so")
  1295. ensureContains(t, symlink.Output.String(), "/system/lib64/libclang_rt.hwasan-aarch64-android.so")
  1296. }
  1297. func TestApexDependsOnLLNDKTransitively(t *testing.T) {
  1298. testcases := []struct {
  1299. name string
  1300. minSdkVersion string
  1301. apexVariant string
  1302. shouldLink string
  1303. shouldNotLink []string
  1304. }{
  1305. {
  1306. name: "unspecified version links to the latest",
  1307. minSdkVersion: "",
  1308. apexVariant: "apex10000",
  1309. shouldLink: "current",
  1310. shouldNotLink: []string{"29", "30"},
  1311. },
  1312. {
  1313. name: "always use the latest",
  1314. minSdkVersion: "min_sdk_version: \"29\",",
  1315. apexVariant: "apex29",
  1316. shouldLink: "current",
  1317. shouldNotLink: []string{"29", "30"},
  1318. },
  1319. }
  1320. for _, tc := range testcases {
  1321. t.Run(tc.name, func(t *testing.T) {
  1322. ctx := testApex(t, `
  1323. apex {
  1324. name: "myapex",
  1325. key: "myapex.key",
  1326. native_shared_libs: ["mylib"],
  1327. updatable: false,
  1328. `+tc.minSdkVersion+`
  1329. }
  1330. apex_key {
  1331. name: "myapex.key",
  1332. public_key: "testkey.avbpubkey",
  1333. private_key: "testkey.pem",
  1334. }
  1335. cc_library {
  1336. name: "mylib",
  1337. srcs: ["mylib.cpp"],
  1338. vendor_available: true,
  1339. shared_libs: ["libbar"],
  1340. system_shared_libs: [],
  1341. stl: "none",
  1342. apex_available: [ "myapex" ],
  1343. min_sdk_version: "29",
  1344. }
  1345. cc_library {
  1346. name: "libbar",
  1347. srcs: ["mylib.cpp"],
  1348. system_shared_libs: [],
  1349. stl: "none",
  1350. stubs: { versions: ["29","30"] },
  1351. llndk: {
  1352. symbol_file: "libbar.map.txt",
  1353. }
  1354. }
  1355. `,
  1356. withUnbundledBuild,
  1357. )
  1358. // Ensure that LLNDK dep is not included
  1359. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  1360. "lib64/mylib.so",
  1361. })
  1362. // Ensure that LLNDK dep is required
  1363. apexManifestRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  1364. ensureListEmpty(t, names(apexManifestRule.Args["provideNativeLibs"]))
  1365. ensureListContains(t, names(apexManifestRule.Args["requireNativeLibs"]), "libbar.so")
  1366. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_"+tc.apexVariant).Rule("ld").Args["libFlags"]
  1367. ensureContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+tc.shouldLink+"/libbar.so")
  1368. for _, ver := range tc.shouldNotLink {
  1369. ensureNotContains(t, mylibLdFlags, "libbar/android_arm64_armv8-a_shared_"+ver+"/libbar.so")
  1370. }
  1371. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_"+tc.apexVariant).Rule("cc").Args["cFlags"]
  1372. ver := tc.shouldLink
  1373. if tc.shouldLink == "current" {
  1374. ver = strconv.Itoa(android.FutureApiLevelInt)
  1375. }
  1376. ensureContains(t, mylibCFlags, "__LIBBAR_API__="+ver)
  1377. })
  1378. }
  1379. }
  1380. func TestApexWithSystemLibsStubs(t *testing.T) {
  1381. ctx := testApex(t, `
  1382. apex {
  1383. name: "myapex",
  1384. key: "myapex.key",
  1385. native_shared_libs: ["mylib", "mylib_shared", "libdl", "libm"],
  1386. updatable: false,
  1387. }
  1388. apex_key {
  1389. name: "myapex.key",
  1390. public_key: "testkey.avbpubkey",
  1391. private_key: "testkey.pem",
  1392. }
  1393. cc_library {
  1394. name: "mylib",
  1395. srcs: ["mylib.cpp"],
  1396. system_shared_libs: ["libc", "libm"],
  1397. shared_libs: ["libdl#27"],
  1398. stl: "none",
  1399. apex_available: [ "myapex" ],
  1400. }
  1401. cc_library_shared {
  1402. name: "mylib_shared",
  1403. srcs: ["mylib.cpp"],
  1404. shared_libs: ["libdl#27"],
  1405. stl: "none",
  1406. apex_available: [ "myapex" ],
  1407. }
  1408. cc_library {
  1409. name: "libBootstrap",
  1410. srcs: ["mylib.cpp"],
  1411. stl: "none",
  1412. bootstrap: true,
  1413. }
  1414. `)
  1415. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  1416. copyCmds := apexRule.Args["copy_commands"]
  1417. // Ensure that mylib, libm, libdl are included.
  1418. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  1419. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libm.so")
  1420. ensureContains(t, copyCmds, "image.apex/lib64/bionic/libdl.so")
  1421. // Ensure that libc is not included (since it has stubs and not listed in native_shared_libs)
  1422. ensureNotContains(t, copyCmds, "image.apex/lib64/bionic/libc.so")
  1423. mylibLdFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  1424. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  1425. mylibSharedCFlags := ctx.ModuleForTests("mylib_shared", "android_arm64_armv8-a_shared_apex10000").Rule("cc").Args["cFlags"]
  1426. // For dependency to libc
  1427. // Ensure that mylib is linking with the latest version of stubs
  1428. ensureContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared_current/libc.so")
  1429. // ... and not linking to the non-stub (impl) variant
  1430. ensureNotContains(t, mylibLdFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1431. // ... Cflags from stub is correctly exported to mylib
  1432. ensureContains(t, mylibCFlags, "__LIBC_API__=10000")
  1433. ensureContains(t, mylibSharedCFlags, "__LIBC_API__=10000")
  1434. // For dependency to libm
  1435. // Ensure that mylib is linking with the non-stub (impl) variant
  1436. ensureContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_apex10000/libm.so")
  1437. // ... and not linking to the stub variant
  1438. ensureNotContains(t, mylibLdFlags, "libm/android_arm64_armv8-a_shared_29/libm.so")
  1439. // ... and is not compiling with the stub
  1440. ensureNotContains(t, mylibCFlags, "__LIBM_API__=29")
  1441. ensureNotContains(t, mylibSharedCFlags, "__LIBM_API__=29")
  1442. // For dependency to libdl
  1443. // Ensure that mylib is linking with the specified version of stubs
  1444. ensureContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_27/libdl.so")
  1445. // ... and not linking to the other versions of stubs
  1446. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_28/libdl.so")
  1447. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_29/libdl.so")
  1448. // ... and not linking to the non-stub (impl) variant
  1449. ensureNotContains(t, mylibLdFlags, "libdl/android_arm64_armv8-a_shared_apex10000/libdl.so")
  1450. // ... Cflags from stub is correctly exported to mylib
  1451. ensureContains(t, mylibCFlags, "__LIBDL_API__=27")
  1452. ensureContains(t, mylibSharedCFlags, "__LIBDL_API__=27")
  1453. // Ensure that libBootstrap is depending on the platform variant of bionic libs
  1454. libFlags := ctx.ModuleForTests("libBootstrap", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  1455. ensureContains(t, libFlags, "libc/android_arm64_armv8-a_shared/libc.so")
  1456. ensureContains(t, libFlags, "libm/android_arm64_armv8-a_shared/libm.so")
  1457. ensureContains(t, libFlags, "libdl/android_arm64_armv8-a_shared/libdl.so")
  1458. }
  1459. func TestApexMinSdkVersion_NativeModulesShouldBeBuiltAgainstStubs(t *testing.T) {
  1460. // there are three links between liba --> libz.
  1461. // 1) myapex -> libx -> liba -> libz : this should be #30 link
  1462. // 2) otherapex -> liby -> liba -> libz : this should be #30 link
  1463. // 3) (platform) -> liba -> libz : this should be non-stub link
  1464. ctx := testApex(t, `
  1465. apex {
  1466. name: "myapex",
  1467. key: "myapex.key",
  1468. native_shared_libs: ["libx"],
  1469. min_sdk_version: "29",
  1470. }
  1471. apex {
  1472. name: "otherapex",
  1473. key: "myapex.key",
  1474. native_shared_libs: ["liby"],
  1475. min_sdk_version: "30",
  1476. }
  1477. apex_key {
  1478. name: "myapex.key",
  1479. public_key: "testkey.avbpubkey",
  1480. private_key: "testkey.pem",
  1481. }
  1482. cc_library {
  1483. name: "libx",
  1484. shared_libs: ["liba"],
  1485. system_shared_libs: [],
  1486. stl: "none",
  1487. apex_available: [ "myapex" ],
  1488. min_sdk_version: "29",
  1489. }
  1490. cc_library {
  1491. name: "liby",
  1492. shared_libs: ["liba"],
  1493. system_shared_libs: [],
  1494. stl: "none",
  1495. apex_available: [ "otherapex" ],
  1496. min_sdk_version: "29",
  1497. }
  1498. cc_library {
  1499. name: "liba",
  1500. shared_libs: ["libz"],
  1501. system_shared_libs: [],
  1502. stl: "none",
  1503. apex_available: [
  1504. "//apex_available:anyapex",
  1505. "//apex_available:platform",
  1506. ],
  1507. min_sdk_version: "29",
  1508. }
  1509. cc_library {
  1510. name: "libz",
  1511. system_shared_libs: [],
  1512. stl: "none",
  1513. stubs: {
  1514. versions: ["28", "30"],
  1515. },
  1516. }
  1517. `)
  1518. expectLink := func(from, from_variant, to, to_variant string) {
  1519. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1520. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1521. }
  1522. expectNoLink := func(from, from_variant, to, to_variant string) {
  1523. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1524. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1525. }
  1526. // platform liba is linked to non-stub version
  1527. expectLink("liba", "shared", "libz", "shared")
  1528. // liba in myapex is linked to current
  1529. expectLink("liba", "shared_apex29", "libz", "shared_current")
  1530. expectNoLink("liba", "shared_apex29", "libz", "shared_30")
  1531. expectNoLink("liba", "shared_apex29", "libz", "shared_28")
  1532. expectNoLink("liba", "shared_apex29", "libz", "shared")
  1533. // liba in otherapex is linked to current
  1534. expectLink("liba", "shared_apex30", "libz", "shared_current")
  1535. expectNoLink("liba", "shared_apex30", "libz", "shared_30")
  1536. expectNoLink("liba", "shared_apex30", "libz", "shared_28")
  1537. expectNoLink("liba", "shared_apex30", "libz", "shared")
  1538. }
  1539. func TestApexMinSdkVersion_SupportsCodeNames(t *testing.T) {
  1540. ctx := testApex(t, `
  1541. apex {
  1542. name: "myapex",
  1543. key: "myapex.key",
  1544. native_shared_libs: ["libx"],
  1545. min_sdk_version: "R",
  1546. }
  1547. apex_key {
  1548. name: "myapex.key",
  1549. public_key: "testkey.avbpubkey",
  1550. private_key: "testkey.pem",
  1551. }
  1552. cc_library {
  1553. name: "libx",
  1554. shared_libs: ["libz"],
  1555. system_shared_libs: [],
  1556. stl: "none",
  1557. apex_available: [ "myapex" ],
  1558. min_sdk_version: "R",
  1559. }
  1560. cc_library {
  1561. name: "libz",
  1562. system_shared_libs: [],
  1563. stl: "none",
  1564. stubs: {
  1565. versions: ["29", "R"],
  1566. },
  1567. }
  1568. `,
  1569. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1570. variables.Platform_version_active_codenames = []string{"R"}
  1571. }),
  1572. )
  1573. expectLink := func(from, from_variant, to, to_variant string) {
  1574. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1575. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1576. }
  1577. expectNoLink := func(from, from_variant, to, to_variant string) {
  1578. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1579. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1580. }
  1581. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1582. expectNoLink("libx", "shared_apex10000", "libz", "shared_R")
  1583. expectNoLink("libx", "shared_apex10000", "libz", "shared_29")
  1584. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1585. }
  1586. func TestApexMinSdkVersion_SupportsCodeNames_JavaLibs(t *testing.T) {
  1587. testApex(t, `
  1588. apex {
  1589. name: "myapex",
  1590. key: "myapex.key",
  1591. java_libs: ["libx"],
  1592. min_sdk_version: "S",
  1593. }
  1594. apex_key {
  1595. name: "myapex.key",
  1596. public_key: "testkey.avbpubkey",
  1597. private_key: "testkey.pem",
  1598. }
  1599. java_library {
  1600. name: "libx",
  1601. srcs: ["a.java"],
  1602. apex_available: [ "myapex" ],
  1603. sdk_version: "current",
  1604. min_sdk_version: "S", // should be okay
  1605. }
  1606. `,
  1607. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  1608. variables.Platform_version_active_codenames = []string{"S"}
  1609. variables.Platform_sdk_codename = proptools.StringPtr("S")
  1610. }),
  1611. )
  1612. }
  1613. func TestApexMinSdkVersion_DefaultsToLatest(t *testing.T) {
  1614. ctx := testApex(t, `
  1615. apex {
  1616. name: "myapex",
  1617. key: "myapex.key",
  1618. native_shared_libs: ["libx"],
  1619. updatable: false,
  1620. }
  1621. apex_key {
  1622. name: "myapex.key",
  1623. public_key: "testkey.avbpubkey",
  1624. private_key: "testkey.pem",
  1625. }
  1626. cc_library {
  1627. name: "libx",
  1628. shared_libs: ["libz"],
  1629. system_shared_libs: [],
  1630. stl: "none",
  1631. apex_available: [ "myapex" ],
  1632. }
  1633. cc_library {
  1634. name: "libz",
  1635. system_shared_libs: [],
  1636. stl: "none",
  1637. stubs: {
  1638. versions: ["1", "2"],
  1639. },
  1640. }
  1641. `)
  1642. expectLink := func(from, from_variant, to, to_variant string) {
  1643. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1644. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1645. }
  1646. expectNoLink := func(from, from_variant, to, to_variant string) {
  1647. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1648. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1649. }
  1650. expectLink("libx", "shared_apex10000", "libz", "shared_current")
  1651. expectNoLink("libx", "shared_apex10000", "libz", "shared_1")
  1652. expectNoLink("libx", "shared_apex10000", "libz", "shared_2")
  1653. expectNoLink("libx", "shared_apex10000", "libz", "shared")
  1654. }
  1655. func TestApexMinSdkVersion_crtobjectInVendorApex(t *testing.T) {
  1656. ctx := testApex(t, `
  1657. apex {
  1658. name: "myapex",
  1659. key: "myapex.key",
  1660. native_shared_libs: ["mylib"],
  1661. updatable: false,
  1662. vendor: true,
  1663. min_sdk_version: "29",
  1664. }
  1665. apex_key {
  1666. name: "myapex.key",
  1667. public_key: "testkey.avbpubkey",
  1668. private_key: "testkey.pem",
  1669. }
  1670. cc_library {
  1671. name: "mylib",
  1672. vendor_available: true,
  1673. system_shared_libs: [],
  1674. stl: "none",
  1675. apex_available: [ "myapex" ],
  1676. min_sdk_version: "29",
  1677. }
  1678. `)
  1679. vendorVariant := "android_vendor.29_arm64_armv8-a"
  1680. // First check that the correct variant of crtbegin_so is used.
  1681. ldRule := ctx.ModuleForTests("mylib", vendorVariant+"_shared_apex29").Rule("ld")
  1682. crtBegin := names(ldRule.Args["crtBegin"])
  1683. ensureListContains(t, crtBegin, "out/soong/.intermediates/"+cc.DefaultCcCommonTestModulesDir+"crtbegin_so/"+vendorVariant+"_apex29/crtbegin_so.o")
  1684. // Ensure that the crtbegin_so used by the APEX is targeting 29
  1685. cflags := ctx.ModuleForTests("crtbegin_so", vendorVariant+"_apex29").Rule("cc").Args["cFlags"]
  1686. android.AssertStringDoesContain(t, "cflags", cflags, "-target aarch64-linux-android29")
  1687. }
  1688. func TestPlatformUsesLatestStubsFromApexes(t *testing.T) {
  1689. ctx := testApex(t, `
  1690. apex {
  1691. name: "myapex",
  1692. key: "myapex.key",
  1693. native_shared_libs: ["libx"],
  1694. updatable: false,
  1695. }
  1696. apex_key {
  1697. name: "myapex.key",
  1698. public_key: "testkey.avbpubkey",
  1699. private_key: "testkey.pem",
  1700. }
  1701. cc_library {
  1702. name: "libx",
  1703. system_shared_libs: [],
  1704. stl: "none",
  1705. apex_available: [ "myapex" ],
  1706. stubs: {
  1707. versions: ["1", "2"],
  1708. },
  1709. }
  1710. cc_library {
  1711. name: "libz",
  1712. shared_libs: ["libx"],
  1713. system_shared_libs: [],
  1714. stl: "none",
  1715. }
  1716. `)
  1717. expectLink := func(from, from_variant, to, to_variant string) {
  1718. t.Helper()
  1719. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1720. ensureContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1721. }
  1722. expectNoLink := func(from, from_variant, to, to_variant string) {
  1723. t.Helper()
  1724. ldArgs := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld").Args["libFlags"]
  1725. ensureNotContains(t, ldArgs, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1726. }
  1727. expectLink("libz", "shared", "libx", "shared_current")
  1728. expectNoLink("libz", "shared", "libx", "shared_2")
  1729. expectNoLink("libz", "shared", "libz", "shared_1")
  1730. expectNoLink("libz", "shared", "libz", "shared")
  1731. }
  1732. var prepareForTestWithSantitizeHwaddress = android.FixtureModifyProductVariables(
  1733. func(variables android.FixtureProductVariables) {
  1734. variables.SanitizeDevice = []string{"hwaddress"}
  1735. },
  1736. )
  1737. func TestQApexesUseLatestStubsInBundledBuildsAndHWASAN(t *testing.T) {
  1738. ctx := testApex(t, `
  1739. apex {
  1740. name: "myapex",
  1741. key: "myapex.key",
  1742. native_shared_libs: ["libx"],
  1743. min_sdk_version: "29",
  1744. }
  1745. apex_key {
  1746. name: "myapex.key",
  1747. public_key: "testkey.avbpubkey",
  1748. private_key: "testkey.pem",
  1749. }
  1750. cc_library {
  1751. name: "libx",
  1752. shared_libs: ["libbar"],
  1753. apex_available: [ "myapex" ],
  1754. min_sdk_version: "29",
  1755. }
  1756. cc_library {
  1757. name: "libbar",
  1758. stubs: {
  1759. versions: ["29", "30"],
  1760. },
  1761. }
  1762. `,
  1763. prepareForTestWithSantitizeHwaddress,
  1764. )
  1765. expectLink := func(from, from_variant, to, to_variant string) {
  1766. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  1767. libFlags := ld.Args["libFlags"]
  1768. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  1769. }
  1770. expectLink("libx", "shared_hwasan_apex29", "libbar", "shared_current")
  1771. }
  1772. func TestQTargetApexUsesStaticUnwinder(t *testing.T) {
  1773. ctx := testApex(t, `
  1774. apex {
  1775. name: "myapex",
  1776. key: "myapex.key",
  1777. native_shared_libs: ["libx"],
  1778. min_sdk_version: "29",
  1779. }
  1780. apex_key {
  1781. name: "myapex.key",
  1782. public_key: "testkey.avbpubkey",
  1783. private_key: "testkey.pem",
  1784. }
  1785. cc_library {
  1786. name: "libx",
  1787. apex_available: [ "myapex" ],
  1788. min_sdk_version: "29",
  1789. }
  1790. `)
  1791. // ensure apex variant of c++ is linked with static unwinder
  1792. cm := ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared_apex29").Module().(*cc.Module)
  1793. ensureListContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1794. // note that platform variant is not.
  1795. cm = ctx.ModuleForTests("libc++", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  1796. ensureListNotContains(t, cm.Properties.AndroidMkStaticLibs, "libunwind")
  1797. }
  1798. func TestApexMinSdkVersion_ErrorIfIncompatibleVersion(t *testing.T) {
  1799. testApexError(t, `module "mylib".*: should support min_sdk_version\(29\)`, `
  1800. apex {
  1801. name: "myapex",
  1802. key: "myapex.key",
  1803. native_shared_libs: ["mylib"],
  1804. min_sdk_version: "29",
  1805. }
  1806. apex_key {
  1807. name: "myapex.key",
  1808. public_key: "testkey.avbpubkey",
  1809. private_key: "testkey.pem",
  1810. }
  1811. cc_library {
  1812. name: "mylib",
  1813. srcs: ["mylib.cpp"],
  1814. system_shared_libs: [],
  1815. stl: "none",
  1816. apex_available: [
  1817. "myapex",
  1818. ],
  1819. min_sdk_version: "30",
  1820. }
  1821. `)
  1822. testApexError(t, `module "libfoo.ffi".*: should support min_sdk_version\(29\)`, `
  1823. apex {
  1824. name: "myapex",
  1825. key: "myapex.key",
  1826. native_shared_libs: ["libfoo.ffi"],
  1827. min_sdk_version: "29",
  1828. }
  1829. apex_key {
  1830. name: "myapex.key",
  1831. public_key: "testkey.avbpubkey",
  1832. private_key: "testkey.pem",
  1833. }
  1834. rust_ffi_shared {
  1835. name: "libfoo.ffi",
  1836. srcs: ["foo.rs"],
  1837. crate_name: "foo",
  1838. apex_available: [
  1839. "myapex",
  1840. ],
  1841. min_sdk_version: "30",
  1842. }
  1843. `)
  1844. testApexError(t, `module "libfoo".*: should support min_sdk_version\(29\)`, `
  1845. apex {
  1846. name: "myapex",
  1847. key: "myapex.key",
  1848. java_libs: ["libfoo"],
  1849. min_sdk_version: "29",
  1850. }
  1851. apex_key {
  1852. name: "myapex.key",
  1853. public_key: "testkey.avbpubkey",
  1854. private_key: "testkey.pem",
  1855. }
  1856. java_import {
  1857. name: "libfoo",
  1858. jars: ["libfoo.jar"],
  1859. apex_available: [
  1860. "myapex",
  1861. ],
  1862. min_sdk_version: "30",
  1863. }
  1864. `)
  1865. }
  1866. func TestApexMinSdkVersion_Okay(t *testing.T) {
  1867. testApex(t, `
  1868. apex {
  1869. name: "myapex",
  1870. key: "myapex.key",
  1871. native_shared_libs: ["libfoo"],
  1872. java_libs: ["libbar"],
  1873. min_sdk_version: "29",
  1874. }
  1875. apex_key {
  1876. name: "myapex.key",
  1877. public_key: "testkey.avbpubkey",
  1878. private_key: "testkey.pem",
  1879. }
  1880. cc_library {
  1881. name: "libfoo",
  1882. srcs: ["mylib.cpp"],
  1883. shared_libs: ["libfoo_dep"],
  1884. apex_available: ["myapex"],
  1885. min_sdk_version: "29",
  1886. }
  1887. cc_library {
  1888. name: "libfoo_dep",
  1889. srcs: ["mylib.cpp"],
  1890. apex_available: ["myapex"],
  1891. min_sdk_version: "29",
  1892. }
  1893. java_library {
  1894. name: "libbar",
  1895. sdk_version: "current",
  1896. srcs: ["a.java"],
  1897. static_libs: [
  1898. "libbar_dep",
  1899. "libbar_import_dep",
  1900. ],
  1901. apex_available: ["myapex"],
  1902. min_sdk_version: "29",
  1903. }
  1904. java_library {
  1905. name: "libbar_dep",
  1906. sdk_version: "current",
  1907. srcs: ["a.java"],
  1908. apex_available: ["myapex"],
  1909. min_sdk_version: "29",
  1910. }
  1911. java_import {
  1912. name: "libbar_import_dep",
  1913. jars: ["libbar.jar"],
  1914. apex_available: ["myapex"],
  1915. min_sdk_version: "29",
  1916. }
  1917. `)
  1918. }
  1919. func TestJavaStableSdkVersion(t *testing.T) {
  1920. testCases := []struct {
  1921. name string
  1922. expectedError string
  1923. bp string
  1924. preparer android.FixturePreparer
  1925. }{
  1926. {
  1927. name: "Non-updatable apex with non-stable dep",
  1928. bp: `
  1929. apex {
  1930. name: "myapex",
  1931. java_libs: ["myjar"],
  1932. key: "myapex.key",
  1933. updatable: false,
  1934. }
  1935. apex_key {
  1936. name: "myapex.key",
  1937. public_key: "testkey.avbpubkey",
  1938. private_key: "testkey.pem",
  1939. }
  1940. java_library {
  1941. name: "myjar",
  1942. srcs: ["foo/bar/MyClass.java"],
  1943. sdk_version: "test_current",
  1944. apex_available: ["myapex"],
  1945. }
  1946. `,
  1947. },
  1948. {
  1949. name: "Updatable apex with stable dep",
  1950. bp: `
  1951. apex {
  1952. name: "myapex",
  1953. java_libs: ["myjar"],
  1954. key: "myapex.key",
  1955. updatable: true,
  1956. min_sdk_version: "29",
  1957. }
  1958. apex_key {
  1959. name: "myapex.key",
  1960. public_key: "testkey.avbpubkey",
  1961. private_key: "testkey.pem",
  1962. }
  1963. java_library {
  1964. name: "myjar",
  1965. srcs: ["foo/bar/MyClass.java"],
  1966. sdk_version: "current",
  1967. apex_available: ["myapex"],
  1968. min_sdk_version: "29",
  1969. }
  1970. `,
  1971. },
  1972. {
  1973. name: "Updatable apex with non-stable dep",
  1974. expectedError: "cannot depend on \"myjar\"",
  1975. bp: `
  1976. apex {
  1977. name: "myapex",
  1978. java_libs: ["myjar"],
  1979. key: "myapex.key",
  1980. updatable: true,
  1981. }
  1982. apex_key {
  1983. name: "myapex.key",
  1984. public_key: "testkey.avbpubkey",
  1985. private_key: "testkey.pem",
  1986. }
  1987. java_library {
  1988. name: "myjar",
  1989. srcs: ["foo/bar/MyClass.java"],
  1990. sdk_version: "test_current",
  1991. apex_available: ["myapex"],
  1992. }
  1993. `,
  1994. },
  1995. {
  1996. name: "Updatable apex with non-stable legacy core platform dep",
  1997. expectedError: `\Qcannot depend on "myjar-uses-legacy": non stable SDK core_platform_current - uses legacy core platform\E`,
  1998. bp: `
  1999. apex {
  2000. name: "myapex",
  2001. java_libs: ["myjar-uses-legacy"],
  2002. key: "myapex.key",
  2003. updatable: true,
  2004. }
  2005. apex_key {
  2006. name: "myapex.key",
  2007. public_key: "testkey.avbpubkey",
  2008. private_key: "testkey.pem",
  2009. }
  2010. java_library {
  2011. name: "myjar-uses-legacy",
  2012. srcs: ["foo/bar/MyClass.java"],
  2013. sdk_version: "core_platform",
  2014. apex_available: ["myapex"],
  2015. }
  2016. `,
  2017. preparer: java.FixtureUseLegacyCorePlatformApi("myjar-uses-legacy"),
  2018. },
  2019. {
  2020. name: "Updatable apex with non-stable transitive dep",
  2021. // This is not actually detecting that the transitive dependency is unstable, rather it is
  2022. // detecting that the transitive dependency is building against a wider API surface than the
  2023. // module that depends on it is using.
  2024. expectedError: "compiles against Android API, but dependency \"transitive-jar\" is compiling against private API.",
  2025. bp: `
  2026. apex {
  2027. name: "myapex",
  2028. java_libs: ["myjar"],
  2029. key: "myapex.key",
  2030. updatable: true,
  2031. }
  2032. apex_key {
  2033. name: "myapex.key",
  2034. public_key: "testkey.avbpubkey",
  2035. private_key: "testkey.pem",
  2036. }
  2037. java_library {
  2038. name: "myjar",
  2039. srcs: ["foo/bar/MyClass.java"],
  2040. sdk_version: "current",
  2041. apex_available: ["myapex"],
  2042. static_libs: ["transitive-jar"],
  2043. }
  2044. java_library {
  2045. name: "transitive-jar",
  2046. srcs: ["foo/bar/MyClass.java"],
  2047. sdk_version: "core_platform",
  2048. apex_available: ["myapex"],
  2049. }
  2050. `,
  2051. },
  2052. }
  2053. for _, test := range testCases {
  2054. if test.name != "Updatable apex with non-stable legacy core platform dep" {
  2055. continue
  2056. }
  2057. t.Run(test.name, func(t *testing.T) {
  2058. errorHandler := android.FixtureExpectsNoErrors
  2059. if test.expectedError != "" {
  2060. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(test.expectedError)
  2061. }
  2062. android.GroupFixturePreparers(
  2063. java.PrepareForTestWithJavaDefaultModules,
  2064. PrepareForTestWithApexBuildComponents,
  2065. prepareForTestWithMyapex,
  2066. android.OptionalFixturePreparer(test.preparer),
  2067. ).
  2068. ExtendWithErrorHandler(errorHandler).
  2069. RunTestWithBp(t, test.bp)
  2070. })
  2071. }
  2072. }
  2073. func TestApexMinSdkVersion_ErrorIfDepIsNewer(t *testing.T) {
  2074. testApexError(t, `module "mylib2".*: should support min_sdk_version\(29\) for "myapex"`, `
  2075. apex {
  2076. name: "myapex",
  2077. key: "myapex.key",
  2078. native_shared_libs: ["mylib"],
  2079. min_sdk_version: "29",
  2080. }
  2081. apex_key {
  2082. name: "myapex.key",
  2083. public_key: "testkey.avbpubkey",
  2084. private_key: "testkey.pem",
  2085. }
  2086. cc_library {
  2087. name: "mylib",
  2088. srcs: ["mylib.cpp"],
  2089. shared_libs: ["mylib2"],
  2090. system_shared_libs: [],
  2091. stl: "none",
  2092. apex_available: [
  2093. "myapex",
  2094. ],
  2095. min_sdk_version: "29",
  2096. }
  2097. // indirect part of the apex
  2098. cc_library {
  2099. name: "mylib2",
  2100. srcs: ["mylib.cpp"],
  2101. system_shared_libs: [],
  2102. stl: "none",
  2103. apex_available: [
  2104. "myapex",
  2105. ],
  2106. min_sdk_version: "30",
  2107. }
  2108. `)
  2109. }
  2110. func TestApexMinSdkVersion_ErrorIfDepIsNewer_Java(t *testing.T) {
  2111. testApexError(t, `module "bar".*: should support min_sdk_version\(29\) for "myapex"`, `
  2112. apex {
  2113. name: "myapex",
  2114. key: "myapex.key",
  2115. apps: ["AppFoo"],
  2116. min_sdk_version: "29",
  2117. updatable: false,
  2118. }
  2119. apex_key {
  2120. name: "myapex.key",
  2121. public_key: "testkey.avbpubkey",
  2122. private_key: "testkey.pem",
  2123. }
  2124. android_app {
  2125. name: "AppFoo",
  2126. srcs: ["foo/bar/MyClass.java"],
  2127. sdk_version: "current",
  2128. min_sdk_version: "29",
  2129. system_modules: "none",
  2130. stl: "none",
  2131. static_libs: ["bar"],
  2132. apex_available: [ "myapex" ],
  2133. }
  2134. java_library {
  2135. name: "bar",
  2136. sdk_version: "current",
  2137. srcs: ["a.java"],
  2138. apex_available: [ "myapex" ],
  2139. }
  2140. `)
  2141. }
  2142. func TestApexMinSdkVersion_OkayEvenWhenDepIsNewer_IfItSatisfiesApexMinSdkVersion(t *testing.T) {
  2143. ctx := testApex(t, `
  2144. apex {
  2145. name: "myapex",
  2146. key: "myapex.key",
  2147. native_shared_libs: ["mylib"],
  2148. min_sdk_version: "29",
  2149. }
  2150. apex_key {
  2151. name: "myapex.key",
  2152. public_key: "testkey.avbpubkey",
  2153. private_key: "testkey.pem",
  2154. }
  2155. // mylib in myapex will link to mylib2#current
  2156. // mylib in otherapex will link to mylib2(non-stub) in otherapex as well
  2157. cc_library {
  2158. name: "mylib",
  2159. srcs: ["mylib.cpp"],
  2160. shared_libs: ["mylib2"],
  2161. system_shared_libs: [],
  2162. stl: "none",
  2163. apex_available: ["myapex", "otherapex"],
  2164. min_sdk_version: "29",
  2165. }
  2166. cc_library {
  2167. name: "mylib2",
  2168. srcs: ["mylib.cpp"],
  2169. system_shared_libs: [],
  2170. stl: "none",
  2171. apex_available: ["otherapex"],
  2172. stubs: { versions: ["29", "30"] },
  2173. min_sdk_version: "30",
  2174. }
  2175. apex {
  2176. name: "otherapex",
  2177. key: "myapex.key",
  2178. native_shared_libs: ["mylib", "mylib2"],
  2179. min_sdk_version: "30",
  2180. }
  2181. `)
  2182. expectLink := func(from, from_variant, to, to_variant string) {
  2183. ld := ctx.ModuleForTests(from, "android_arm64_armv8-a_"+from_variant).Rule("ld")
  2184. libFlags := ld.Args["libFlags"]
  2185. ensureContains(t, libFlags, "android_arm64_armv8-a_"+to_variant+"/"+to+".so")
  2186. }
  2187. expectLink("mylib", "shared_apex29", "mylib2", "shared_current")
  2188. expectLink("mylib", "shared_apex30", "mylib2", "shared_apex30")
  2189. }
  2190. func TestApexMinSdkVersion_WorksWithSdkCodename(t *testing.T) {
  2191. withSAsActiveCodeNames := android.FixtureModifyProductVariables(
  2192. func(variables android.FixtureProductVariables) {
  2193. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2194. variables.Platform_version_active_codenames = []string{"S"}
  2195. },
  2196. )
  2197. testApexError(t, `libbar.*: should support min_sdk_version\(S\)`, `
  2198. apex {
  2199. name: "myapex",
  2200. key: "myapex.key",
  2201. native_shared_libs: ["libfoo"],
  2202. min_sdk_version: "S",
  2203. }
  2204. apex_key {
  2205. name: "myapex.key",
  2206. public_key: "testkey.avbpubkey",
  2207. private_key: "testkey.pem",
  2208. }
  2209. cc_library {
  2210. name: "libfoo",
  2211. shared_libs: ["libbar"],
  2212. apex_available: ["myapex"],
  2213. min_sdk_version: "29",
  2214. }
  2215. cc_library {
  2216. name: "libbar",
  2217. apex_available: ["myapex"],
  2218. }
  2219. `, withSAsActiveCodeNames)
  2220. }
  2221. func TestApexMinSdkVersion_WorksWithActiveCodenames(t *testing.T) {
  2222. withSAsActiveCodeNames := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2223. variables.Platform_sdk_codename = proptools.StringPtr("S")
  2224. variables.Platform_version_active_codenames = []string{"S", "T"}
  2225. })
  2226. ctx := testApex(t, `
  2227. apex {
  2228. name: "myapex",
  2229. key: "myapex.key",
  2230. native_shared_libs: ["libfoo"],
  2231. min_sdk_version: "S",
  2232. }
  2233. apex_key {
  2234. name: "myapex.key",
  2235. public_key: "testkey.avbpubkey",
  2236. private_key: "testkey.pem",
  2237. }
  2238. cc_library {
  2239. name: "libfoo",
  2240. shared_libs: ["libbar"],
  2241. apex_available: ["myapex"],
  2242. min_sdk_version: "S",
  2243. }
  2244. cc_library {
  2245. name: "libbar",
  2246. stubs: {
  2247. symbol_file: "libbar.map.txt",
  2248. versions: ["30", "S", "T"],
  2249. },
  2250. }
  2251. `, withSAsActiveCodeNames)
  2252. // ensure libfoo is linked with current version of libbar stub
  2253. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared_apex10000")
  2254. libFlags := libfoo.Rule("ld").Args["libFlags"]
  2255. ensureContains(t, libFlags, "android_arm64_armv8-a_shared_current/libbar.so")
  2256. }
  2257. func TestFilesInSubDir(t *testing.T) {
  2258. ctx := testApex(t, `
  2259. apex {
  2260. name: "myapex",
  2261. key: "myapex.key",
  2262. native_shared_libs: ["mylib"],
  2263. binaries: ["mybin"],
  2264. prebuilts: ["myetc"],
  2265. compile_multilib: "both",
  2266. updatable: false,
  2267. }
  2268. apex_key {
  2269. name: "myapex.key",
  2270. public_key: "testkey.avbpubkey",
  2271. private_key: "testkey.pem",
  2272. }
  2273. prebuilt_etc {
  2274. name: "myetc",
  2275. src: "myprebuilt",
  2276. sub_dir: "foo/bar",
  2277. }
  2278. cc_library {
  2279. name: "mylib",
  2280. srcs: ["mylib.cpp"],
  2281. relative_install_path: "foo/bar",
  2282. system_shared_libs: [],
  2283. stl: "none",
  2284. apex_available: [ "myapex" ],
  2285. }
  2286. cc_binary {
  2287. name: "mybin",
  2288. srcs: ["mylib.cpp"],
  2289. relative_install_path: "foo/bar",
  2290. system_shared_libs: [],
  2291. stl: "none",
  2292. apex_available: [ "myapex" ],
  2293. }
  2294. `)
  2295. generateFsRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("generateFsConfig")
  2296. cmd := generateFsRule.RuleParams.Command
  2297. // Ensure that the subdirectories are all listed
  2298. ensureContains(t, cmd, "/etc ")
  2299. ensureContains(t, cmd, "/etc/foo ")
  2300. ensureContains(t, cmd, "/etc/foo/bar ")
  2301. ensureContains(t, cmd, "/lib64 ")
  2302. ensureContains(t, cmd, "/lib64/foo ")
  2303. ensureContains(t, cmd, "/lib64/foo/bar ")
  2304. ensureContains(t, cmd, "/lib ")
  2305. ensureContains(t, cmd, "/lib/foo ")
  2306. ensureContains(t, cmd, "/lib/foo/bar ")
  2307. ensureContains(t, cmd, "/bin ")
  2308. ensureContains(t, cmd, "/bin/foo ")
  2309. ensureContains(t, cmd, "/bin/foo/bar ")
  2310. }
  2311. func TestFilesInSubDirWhenNativeBridgeEnabled(t *testing.T) {
  2312. ctx := testApex(t, `
  2313. apex {
  2314. name: "myapex",
  2315. key: "myapex.key",
  2316. multilib: {
  2317. both: {
  2318. native_shared_libs: ["mylib"],
  2319. binaries: ["mybin"],
  2320. },
  2321. },
  2322. compile_multilib: "both",
  2323. native_bridge_supported: true,
  2324. updatable: false,
  2325. }
  2326. apex_key {
  2327. name: "myapex.key",
  2328. public_key: "testkey.avbpubkey",
  2329. private_key: "testkey.pem",
  2330. }
  2331. cc_library {
  2332. name: "mylib",
  2333. relative_install_path: "foo/bar",
  2334. system_shared_libs: [],
  2335. stl: "none",
  2336. apex_available: [ "myapex" ],
  2337. native_bridge_supported: true,
  2338. }
  2339. cc_binary {
  2340. name: "mybin",
  2341. relative_install_path: "foo/bar",
  2342. system_shared_libs: [],
  2343. stl: "none",
  2344. apex_available: [ "myapex" ],
  2345. native_bridge_supported: true,
  2346. compile_multilib: "both", // default is "first" for binary
  2347. multilib: {
  2348. lib64: {
  2349. suffix: "64",
  2350. },
  2351. },
  2352. }
  2353. `, withNativeBridgeEnabled)
  2354. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2355. "bin/foo/bar/mybin",
  2356. "bin/foo/bar/mybin64",
  2357. "bin/arm/foo/bar/mybin",
  2358. "bin/arm64/foo/bar/mybin64",
  2359. "lib/foo/bar/mylib.so",
  2360. "lib/arm/foo/bar/mylib.so",
  2361. "lib64/foo/bar/mylib.so",
  2362. "lib64/arm64/foo/bar/mylib.so",
  2363. })
  2364. }
  2365. func TestVendorApex(t *testing.T) {
  2366. result := android.GroupFixturePreparers(
  2367. prepareForApexTest,
  2368. android.FixtureModifyConfig(android.SetKatiEnabledForTests),
  2369. ).RunTestWithBp(t, `
  2370. apex {
  2371. name: "myapex",
  2372. key: "myapex.key",
  2373. binaries: ["mybin"],
  2374. vendor: true,
  2375. updatable: false,
  2376. }
  2377. apex_key {
  2378. name: "myapex.key",
  2379. public_key: "testkey.avbpubkey",
  2380. private_key: "testkey.pem",
  2381. }
  2382. cc_binary {
  2383. name: "mybin",
  2384. vendor: true,
  2385. shared_libs: ["libfoo"],
  2386. }
  2387. cc_library {
  2388. name: "libfoo",
  2389. proprietary: true,
  2390. }
  2391. `)
  2392. ensureExactContents(t, result.TestContext, "myapex", "android_common_myapex_image", []string{
  2393. "bin/mybin",
  2394. "lib64/libfoo.so",
  2395. // TODO(b/159195575): Add an option to use VNDK libs from VNDK APEX
  2396. "lib64/libc++.so",
  2397. })
  2398. apexBundle := result.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2399. data := android.AndroidMkDataForTest(t, result.TestContext, apexBundle)
  2400. name := apexBundle.BaseModuleName()
  2401. prefix := "TARGET_"
  2402. var builder strings.Builder
  2403. data.Custom(&builder, name, prefix, "", data)
  2404. androidMk := android.StringRelativeToTop(result.Config, builder.String())
  2405. installPath := "out/target/product/test_device/vendor/apex"
  2406. ensureContains(t, androidMk, "LOCAL_MODULE_PATH := "+installPath)
  2407. apexManifestRule := result.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  2408. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2409. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2410. }
  2411. func TestVendorApex_use_vndk_as_stable_TryingToIncludeVNDKLib(t *testing.T) {
  2412. testApexError(t, `Trying to include a VNDK library`, `
  2413. apex {
  2414. name: "myapex",
  2415. key: "myapex.key",
  2416. native_shared_libs: ["libc++"], // libc++ is a VNDK lib
  2417. vendor: true,
  2418. use_vndk_as_stable: true,
  2419. updatable: false,
  2420. }
  2421. apex_key {
  2422. name: "myapex.key",
  2423. public_key: "testkey.avbpubkey",
  2424. private_key: "testkey.pem",
  2425. }`)
  2426. }
  2427. func TestVendorApex_use_vndk_as_stable(t *testing.T) {
  2428. // myapex myapex2
  2429. // | |
  2430. // mybin ------. mybin2
  2431. // \ \ / |
  2432. // (stable) .---\--------` |
  2433. // \ / \ |
  2434. // \ / \ /
  2435. // libvndk libvendor
  2436. // (vndk)
  2437. ctx := testApex(t, `
  2438. apex {
  2439. name: "myapex",
  2440. key: "myapex.key",
  2441. binaries: ["mybin"],
  2442. vendor: true,
  2443. use_vndk_as_stable: true,
  2444. updatable: false,
  2445. }
  2446. apex_key {
  2447. name: "myapex.key",
  2448. public_key: "testkey.avbpubkey",
  2449. private_key: "testkey.pem",
  2450. }
  2451. cc_binary {
  2452. name: "mybin",
  2453. vendor: true,
  2454. shared_libs: ["libvndk", "libvendor"],
  2455. }
  2456. cc_library {
  2457. name: "libvndk",
  2458. vndk: {
  2459. enabled: true,
  2460. },
  2461. vendor_available: true,
  2462. product_available: true,
  2463. }
  2464. cc_library {
  2465. name: "libvendor",
  2466. vendor: true,
  2467. stl: "none",
  2468. }
  2469. apex {
  2470. name: "myapex2",
  2471. key: "myapex.key",
  2472. binaries: ["mybin2"],
  2473. vendor: true,
  2474. use_vndk_as_stable: false,
  2475. updatable: false,
  2476. }
  2477. cc_binary {
  2478. name: "mybin2",
  2479. vendor: true,
  2480. shared_libs: ["libvndk", "libvendor"],
  2481. }
  2482. `)
  2483. vendorVariant := "android_vendor.29_arm64_armv8-a"
  2484. for _, tc := range []struct {
  2485. name string
  2486. apexName string
  2487. moduleName string
  2488. moduleVariant string
  2489. libs []string
  2490. contents []string
  2491. requireVndkNamespace bool
  2492. }{
  2493. {
  2494. name: "use_vndk_as_stable",
  2495. apexName: "myapex",
  2496. moduleName: "mybin",
  2497. moduleVariant: vendorVariant + "_apex10000",
  2498. libs: []string{
  2499. // should link with vendor variants of VNDK libs(libvndk/libc++)
  2500. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared/libvndk.so",
  2501. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared/libc++.so",
  2502. // unstable Vendor libs as APEX variant
  2503. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2504. },
  2505. contents: []string{
  2506. "bin/mybin",
  2507. "lib64/libvendor.so",
  2508. // VNDK libs (libvndk/libc++) are not included
  2509. },
  2510. requireVndkNamespace: true,
  2511. },
  2512. {
  2513. name: "!use_vndk_as_stable",
  2514. apexName: "myapex2",
  2515. moduleName: "mybin2",
  2516. moduleVariant: vendorVariant + "_myapex2",
  2517. libs: []string{
  2518. // should link with "unique" APEX(myapex2) variant of VNDK libs(libvndk/libc++)
  2519. "out/soong/.intermediates/libvndk/" + vendorVariant + "_shared_myapex2/libvndk.so",
  2520. "out/soong/.intermediates/" + cc.DefaultCcCommonTestModulesDir + "libc++/" + vendorVariant + "_shared_myapex2/libc++.so",
  2521. // unstable vendor libs have "merged" APEX variants
  2522. "out/soong/.intermediates/libvendor/" + vendorVariant + "_shared_apex10000/libvendor.so",
  2523. },
  2524. contents: []string{
  2525. "bin/mybin2",
  2526. "lib64/libvendor.so",
  2527. // VNDK libs are included as well
  2528. "lib64/libvndk.so",
  2529. "lib64/libc++.so",
  2530. },
  2531. requireVndkNamespace: false,
  2532. },
  2533. } {
  2534. t.Run(tc.name, func(t *testing.T) {
  2535. // Check linked libs
  2536. ldRule := ctx.ModuleForTests(tc.moduleName, tc.moduleVariant).Rule("ld")
  2537. libs := names(ldRule.Args["libFlags"])
  2538. for _, lib := range tc.libs {
  2539. ensureListContains(t, libs, lib)
  2540. }
  2541. // Check apex contents
  2542. ensureExactContents(t, ctx, tc.apexName, "android_common_"+tc.apexName+"_image", tc.contents)
  2543. // Check "requireNativeLibs"
  2544. apexManifestRule := ctx.ModuleForTests(tc.apexName, "android_common_"+tc.apexName+"_image").Rule("apexManifestRule")
  2545. requireNativeLibs := names(apexManifestRule.Args["requireNativeLibs"])
  2546. if tc.requireVndkNamespace {
  2547. ensureListContains(t, requireNativeLibs, ":vndk")
  2548. } else {
  2549. ensureListNotContains(t, requireNativeLibs, ":vndk")
  2550. }
  2551. })
  2552. }
  2553. }
  2554. func TestProductVariant(t *testing.T) {
  2555. ctx := testApex(t, `
  2556. apex {
  2557. name: "myapex",
  2558. key: "myapex.key",
  2559. updatable: false,
  2560. product_specific: true,
  2561. binaries: ["foo"],
  2562. }
  2563. apex_key {
  2564. name: "myapex.key",
  2565. public_key: "testkey.avbpubkey",
  2566. private_key: "testkey.pem",
  2567. }
  2568. cc_binary {
  2569. name: "foo",
  2570. product_available: true,
  2571. apex_available: ["myapex"],
  2572. srcs: ["foo.cpp"],
  2573. }
  2574. `, android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  2575. variables.ProductVndkVersion = proptools.StringPtr("current")
  2576. }),
  2577. )
  2578. cflags := strings.Fields(
  2579. ctx.ModuleForTests("foo", "android_product.29_arm64_armv8-a_myapex").Rule("cc").Args["cFlags"])
  2580. ensureListContains(t, cflags, "-D__ANDROID_VNDK__")
  2581. ensureListContains(t, cflags, "-D__ANDROID_APEX__")
  2582. ensureListContains(t, cflags, "-D__ANDROID_PRODUCT__")
  2583. ensureListNotContains(t, cflags, "-D__ANDROID_VENDOR__")
  2584. }
  2585. func TestApex_withPrebuiltFirmware(t *testing.T) {
  2586. testCases := []struct {
  2587. name string
  2588. additionalProp string
  2589. }{
  2590. {"system apex with prebuilt_firmware", ""},
  2591. {"vendor apex with prebuilt_firmware", "vendor: true,"},
  2592. }
  2593. for _, tc := range testCases {
  2594. t.Run(tc.name, func(t *testing.T) {
  2595. ctx := testApex(t, `
  2596. apex {
  2597. name: "myapex",
  2598. key: "myapex.key",
  2599. prebuilts: ["myfirmware"],
  2600. updatable: false,
  2601. `+tc.additionalProp+`
  2602. }
  2603. apex_key {
  2604. name: "myapex.key",
  2605. public_key: "testkey.avbpubkey",
  2606. private_key: "testkey.pem",
  2607. }
  2608. prebuilt_firmware {
  2609. name: "myfirmware",
  2610. src: "myfirmware.bin",
  2611. filename_from_src: true,
  2612. `+tc.additionalProp+`
  2613. }
  2614. `)
  2615. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  2616. "etc/firmware/myfirmware.bin",
  2617. })
  2618. })
  2619. }
  2620. }
  2621. func TestAndroidMk_VendorApexRequired(t *testing.T) {
  2622. ctx := testApex(t, `
  2623. apex {
  2624. name: "myapex",
  2625. key: "myapex.key",
  2626. vendor: true,
  2627. native_shared_libs: ["mylib"],
  2628. updatable: false,
  2629. }
  2630. apex_key {
  2631. name: "myapex.key",
  2632. public_key: "testkey.avbpubkey",
  2633. private_key: "testkey.pem",
  2634. }
  2635. cc_library {
  2636. name: "mylib",
  2637. vendor_available: true,
  2638. }
  2639. `)
  2640. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2641. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2642. name := apexBundle.BaseModuleName()
  2643. prefix := "TARGET_"
  2644. var builder strings.Builder
  2645. data.Custom(&builder, name, prefix, "", data)
  2646. androidMk := builder.String()
  2647. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += libc.vendor libm.vendor libdl.vendor\n")
  2648. }
  2649. func TestAndroidMkWritesCommonProperties(t *testing.T) {
  2650. ctx := testApex(t, `
  2651. apex {
  2652. name: "myapex",
  2653. key: "myapex.key",
  2654. vintf_fragments: ["fragment.xml"],
  2655. init_rc: ["init.rc"],
  2656. updatable: false,
  2657. }
  2658. apex_key {
  2659. name: "myapex.key",
  2660. public_key: "testkey.avbpubkey",
  2661. private_key: "testkey.pem",
  2662. }
  2663. cc_binary {
  2664. name: "mybin",
  2665. }
  2666. `)
  2667. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  2668. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  2669. name := apexBundle.BaseModuleName()
  2670. prefix := "TARGET_"
  2671. var builder strings.Builder
  2672. data.Custom(&builder, name, prefix, "", data)
  2673. androidMk := builder.String()
  2674. ensureContains(t, androidMk, "LOCAL_FULL_VINTF_FRAGMENTS := fragment.xml\n")
  2675. ensureContains(t, androidMk, "LOCAL_FULL_INIT_RC := init.rc\n")
  2676. }
  2677. func TestStaticLinking(t *testing.T) {
  2678. ctx := testApex(t, `
  2679. apex {
  2680. name: "myapex",
  2681. key: "myapex.key",
  2682. native_shared_libs: ["mylib"],
  2683. updatable: false,
  2684. }
  2685. apex_key {
  2686. name: "myapex.key",
  2687. public_key: "testkey.avbpubkey",
  2688. private_key: "testkey.pem",
  2689. }
  2690. cc_library {
  2691. name: "mylib",
  2692. srcs: ["mylib.cpp"],
  2693. system_shared_libs: [],
  2694. stl: "none",
  2695. stubs: {
  2696. versions: ["1", "2", "3"],
  2697. },
  2698. apex_available: [
  2699. "//apex_available:platform",
  2700. "myapex",
  2701. ],
  2702. }
  2703. cc_binary {
  2704. name: "not_in_apex",
  2705. srcs: ["mylib.cpp"],
  2706. static_libs: ["mylib"],
  2707. static_executable: true,
  2708. system_shared_libs: [],
  2709. stl: "none",
  2710. }
  2711. `)
  2712. ldFlags := ctx.ModuleForTests("not_in_apex", "android_arm64_armv8-a").Rule("ld").Args["libFlags"]
  2713. // Ensure that not_in_apex is linking with the static variant of mylib
  2714. ensureContains(t, ldFlags, "mylib/android_arm64_armv8-a_static/mylib.a")
  2715. }
  2716. func TestKeys(t *testing.T) {
  2717. ctx := testApex(t, `
  2718. apex {
  2719. name: "myapex_keytest",
  2720. key: "myapex.key",
  2721. certificate: ":myapex.certificate",
  2722. native_shared_libs: ["mylib"],
  2723. file_contexts: ":myapex-file_contexts",
  2724. updatable: false,
  2725. }
  2726. cc_library {
  2727. name: "mylib",
  2728. srcs: ["mylib.cpp"],
  2729. system_shared_libs: [],
  2730. stl: "none",
  2731. apex_available: [ "myapex_keytest" ],
  2732. }
  2733. apex_key {
  2734. name: "myapex.key",
  2735. public_key: "testkey.avbpubkey",
  2736. private_key: "testkey.pem",
  2737. }
  2738. android_app_certificate {
  2739. name: "myapex.certificate",
  2740. certificate: "testkey",
  2741. }
  2742. android_app_certificate {
  2743. name: "myapex.certificate.override",
  2744. certificate: "testkey.override",
  2745. }
  2746. `)
  2747. // check the APEX keys
  2748. keys := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  2749. if keys.publicKeyFile.String() != "vendor/foo/devkeys/testkey.avbpubkey" {
  2750. t.Errorf("public key %q is not %q", keys.publicKeyFile.String(),
  2751. "vendor/foo/devkeys/testkey.avbpubkey")
  2752. }
  2753. if keys.privateKeyFile.String() != "vendor/foo/devkeys/testkey.pem" {
  2754. t.Errorf("private key %q is not %q", keys.privateKeyFile.String(),
  2755. "vendor/foo/devkeys/testkey.pem")
  2756. }
  2757. // check the APK certs. It should be overridden to myapex.certificate.override
  2758. certs := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk").Args["certificates"]
  2759. if certs != "testkey.override.x509.pem testkey.override.pk8" {
  2760. t.Errorf("cert and private key %q are not %q", certs,
  2761. "testkey.override.509.pem testkey.override.pk8")
  2762. }
  2763. }
  2764. func TestCertificate(t *testing.T) {
  2765. t.Run("if unspecified, it defaults to DefaultAppCertificate", func(t *testing.T) {
  2766. ctx := testApex(t, `
  2767. apex {
  2768. name: "myapex",
  2769. key: "myapex.key",
  2770. updatable: false,
  2771. }
  2772. apex_key {
  2773. name: "myapex.key",
  2774. public_key: "testkey.avbpubkey",
  2775. private_key: "testkey.pem",
  2776. }`)
  2777. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2778. expected := "vendor/foo/devkeys/test.x509.pem vendor/foo/devkeys/test.pk8"
  2779. if actual := rule.Args["certificates"]; actual != expected {
  2780. t.Errorf("certificates should be %q, not %q", expected, actual)
  2781. }
  2782. })
  2783. t.Run("override when unspecified", func(t *testing.T) {
  2784. ctx := testApex(t, `
  2785. apex {
  2786. name: "myapex_keytest",
  2787. key: "myapex.key",
  2788. file_contexts: ":myapex-file_contexts",
  2789. updatable: false,
  2790. }
  2791. apex_key {
  2792. name: "myapex.key",
  2793. public_key: "testkey.avbpubkey",
  2794. private_key: "testkey.pem",
  2795. }
  2796. android_app_certificate {
  2797. name: "myapex.certificate.override",
  2798. certificate: "testkey.override",
  2799. }`)
  2800. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2801. expected := "testkey.override.x509.pem testkey.override.pk8"
  2802. if actual := rule.Args["certificates"]; actual != expected {
  2803. t.Errorf("certificates should be %q, not %q", expected, actual)
  2804. }
  2805. })
  2806. t.Run("if specified as :module, it respects the prop", func(t *testing.T) {
  2807. ctx := testApex(t, `
  2808. apex {
  2809. name: "myapex",
  2810. key: "myapex.key",
  2811. certificate: ":myapex.certificate",
  2812. updatable: false,
  2813. }
  2814. apex_key {
  2815. name: "myapex.key",
  2816. public_key: "testkey.avbpubkey",
  2817. private_key: "testkey.pem",
  2818. }
  2819. android_app_certificate {
  2820. name: "myapex.certificate",
  2821. certificate: "testkey",
  2822. }`)
  2823. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2824. expected := "testkey.x509.pem testkey.pk8"
  2825. if actual := rule.Args["certificates"]; actual != expected {
  2826. t.Errorf("certificates should be %q, not %q", expected, actual)
  2827. }
  2828. })
  2829. t.Run("override when specifiec as <:module>", func(t *testing.T) {
  2830. ctx := testApex(t, `
  2831. apex {
  2832. name: "myapex_keytest",
  2833. key: "myapex.key",
  2834. file_contexts: ":myapex-file_contexts",
  2835. certificate: ":myapex.certificate",
  2836. updatable: false,
  2837. }
  2838. apex_key {
  2839. name: "myapex.key",
  2840. public_key: "testkey.avbpubkey",
  2841. private_key: "testkey.pem",
  2842. }
  2843. android_app_certificate {
  2844. name: "myapex.certificate.override",
  2845. certificate: "testkey.override",
  2846. }`)
  2847. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2848. expected := "testkey.override.x509.pem testkey.override.pk8"
  2849. if actual := rule.Args["certificates"]; actual != expected {
  2850. t.Errorf("certificates should be %q, not %q", expected, actual)
  2851. }
  2852. })
  2853. t.Run("if specified as name, finds it from DefaultDevKeyDir", func(t *testing.T) {
  2854. ctx := testApex(t, `
  2855. apex {
  2856. name: "myapex",
  2857. key: "myapex.key",
  2858. certificate: "testkey",
  2859. updatable: false,
  2860. }
  2861. apex_key {
  2862. name: "myapex.key",
  2863. public_key: "testkey.avbpubkey",
  2864. private_key: "testkey.pem",
  2865. }`)
  2866. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("signapk")
  2867. expected := "vendor/foo/devkeys/testkey.x509.pem vendor/foo/devkeys/testkey.pk8"
  2868. if actual := rule.Args["certificates"]; actual != expected {
  2869. t.Errorf("certificates should be %q, not %q", expected, actual)
  2870. }
  2871. })
  2872. t.Run("override when specified as <name>", func(t *testing.T) {
  2873. ctx := testApex(t, `
  2874. apex {
  2875. name: "myapex_keytest",
  2876. key: "myapex.key",
  2877. file_contexts: ":myapex-file_contexts",
  2878. certificate: "testkey",
  2879. updatable: false,
  2880. }
  2881. apex_key {
  2882. name: "myapex.key",
  2883. public_key: "testkey.avbpubkey",
  2884. private_key: "testkey.pem",
  2885. }
  2886. android_app_certificate {
  2887. name: "myapex.certificate.override",
  2888. certificate: "testkey.override",
  2889. }`)
  2890. rule := ctx.ModuleForTests("myapex_keytest", "android_common_myapex_keytest_image").Rule("signapk")
  2891. expected := "testkey.override.x509.pem testkey.override.pk8"
  2892. if actual := rule.Args["certificates"]; actual != expected {
  2893. t.Errorf("certificates should be %q, not %q", expected, actual)
  2894. }
  2895. })
  2896. }
  2897. func TestMacro(t *testing.T) {
  2898. ctx := testApex(t, `
  2899. apex {
  2900. name: "myapex",
  2901. key: "myapex.key",
  2902. native_shared_libs: ["mylib", "mylib2"],
  2903. updatable: false,
  2904. }
  2905. apex {
  2906. name: "otherapex",
  2907. key: "myapex.key",
  2908. native_shared_libs: ["mylib", "mylib2"],
  2909. min_sdk_version: "29",
  2910. }
  2911. apex_key {
  2912. name: "myapex.key",
  2913. public_key: "testkey.avbpubkey",
  2914. private_key: "testkey.pem",
  2915. }
  2916. cc_library {
  2917. name: "mylib",
  2918. srcs: ["mylib.cpp"],
  2919. system_shared_libs: [],
  2920. stl: "none",
  2921. apex_available: [
  2922. "myapex",
  2923. "otherapex",
  2924. ],
  2925. recovery_available: true,
  2926. min_sdk_version: "29",
  2927. }
  2928. cc_library {
  2929. name: "mylib2",
  2930. srcs: ["mylib.cpp"],
  2931. system_shared_libs: [],
  2932. stl: "none",
  2933. apex_available: [
  2934. "myapex",
  2935. "otherapex",
  2936. ],
  2937. static_libs: ["mylib3"],
  2938. recovery_available: true,
  2939. min_sdk_version: "29",
  2940. }
  2941. cc_library {
  2942. name: "mylib3",
  2943. srcs: ["mylib.cpp"],
  2944. system_shared_libs: [],
  2945. stl: "none",
  2946. apex_available: [
  2947. "myapex",
  2948. "otherapex",
  2949. ],
  2950. recovery_available: true,
  2951. min_sdk_version: "29",
  2952. }
  2953. `)
  2954. // non-APEX variant does not have __ANDROID_APEX__ defined
  2955. mylibCFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2956. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2957. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2958. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2959. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex10000").Rule("cc").Args["cFlags"]
  2960. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2961. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=10000")
  2962. // APEX variant has __ANDROID_APEX__ and __ANDROID_APEX_SDK__ defined
  2963. mylibCFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_static_apex29").Rule("cc").Args["cFlags"]
  2964. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2965. ensureContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__=29")
  2966. // When a cc_library sets use_apex_name_macro: true each apex gets a unique variant and
  2967. // each variant defines additional macros to distinguish which apex variant it is built for
  2968. // non-APEX variant does not have __ANDROID_APEX__ defined
  2969. mylibCFlags = ctx.ModuleForTests("mylib3", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2970. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2971. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2972. mylibCFlags = ctx.ModuleForTests("mylib3", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2973. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2974. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2975. // non-APEX variant does not have __ANDROID_APEX__ defined
  2976. mylibCFlags = ctx.ModuleForTests("mylib2", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2977. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2978. // recovery variant does not set __ANDROID_APEX_MIN_SDK_VERSION__
  2979. mylibCFlags = ctx.ModuleForTests("mylib2", "android_recovery_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  2980. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX__")
  2981. ensureNotContains(t, mylibCFlags, "-D__ANDROID_APEX_MIN_SDK_VERSION__")
  2982. }
  2983. func TestHeaderLibsDependency(t *testing.T) {
  2984. ctx := testApex(t, `
  2985. apex {
  2986. name: "myapex",
  2987. key: "myapex.key",
  2988. native_shared_libs: ["mylib"],
  2989. updatable: false,
  2990. }
  2991. apex_key {
  2992. name: "myapex.key",
  2993. public_key: "testkey.avbpubkey",
  2994. private_key: "testkey.pem",
  2995. }
  2996. cc_library_headers {
  2997. name: "mylib_headers",
  2998. export_include_dirs: ["my_include"],
  2999. system_shared_libs: [],
  3000. stl: "none",
  3001. apex_available: [ "myapex" ],
  3002. }
  3003. cc_library {
  3004. name: "mylib",
  3005. srcs: ["mylib.cpp"],
  3006. system_shared_libs: [],
  3007. stl: "none",
  3008. header_libs: ["mylib_headers"],
  3009. export_header_lib_headers: ["mylib_headers"],
  3010. stubs: {
  3011. versions: ["1", "2", "3"],
  3012. },
  3013. apex_available: [ "myapex" ],
  3014. }
  3015. cc_library {
  3016. name: "otherlib",
  3017. srcs: ["mylib.cpp"],
  3018. system_shared_libs: [],
  3019. stl: "none",
  3020. shared_libs: ["mylib"],
  3021. }
  3022. `)
  3023. cFlags := ctx.ModuleForTests("otherlib", "android_arm64_armv8-a_static").Rule("cc").Args["cFlags"]
  3024. // Ensure that the include path of the header lib is exported to 'otherlib'
  3025. ensureContains(t, cFlags, "-Imy_include")
  3026. }
  3027. type fileInApex struct {
  3028. path string // path in apex
  3029. src string // src path
  3030. isLink bool
  3031. }
  3032. func getFiles(t *testing.T, ctx *android.TestContext, moduleName, variant string) []fileInApex {
  3033. t.Helper()
  3034. apexRule := ctx.ModuleForTests(moduleName, variant).Rule("apexRule")
  3035. copyCmds := apexRule.Args["copy_commands"]
  3036. imageApexDir := "/image.apex/"
  3037. var ret []fileInApex
  3038. for _, cmd := range strings.Split(copyCmds, "&&") {
  3039. cmd = strings.TrimSpace(cmd)
  3040. if cmd == "" {
  3041. continue
  3042. }
  3043. terms := strings.Split(cmd, " ")
  3044. var dst, src string
  3045. var isLink bool
  3046. switch terms[0] {
  3047. case "mkdir":
  3048. case "cp":
  3049. if len(terms) != 3 && len(terms) != 4 {
  3050. t.Fatal("copyCmds contains invalid cp command", cmd)
  3051. }
  3052. dst = terms[len(terms)-1]
  3053. src = terms[len(terms)-2]
  3054. isLink = false
  3055. case "ln":
  3056. if len(terms) != 3 && len(terms) != 4 {
  3057. // ln LINK TARGET or ln -s LINK TARGET
  3058. t.Fatal("copyCmds contains invalid ln command", cmd)
  3059. }
  3060. dst = terms[len(terms)-1]
  3061. src = terms[len(terms)-2]
  3062. isLink = true
  3063. default:
  3064. t.Fatalf("copyCmds should contain mkdir/cp commands only: %q", cmd)
  3065. }
  3066. if dst != "" {
  3067. index := strings.Index(dst, imageApexDir)
  3068. if index == -1 {
  3069. t.Fatal("copyCmds should copy a file to image.apex/", cmd)
  3070. }
  3071. dstFile := dst[index+len(imageApexDir):]
  3072. ret = append(ret, fileInApex{path: dstFile, src: src, isLink: isLink})
  3073. }
  3074. }
  3075. return ret
  3076. }
  3077. func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, variant string, files []string) {
  3078. t.Helper()
  3079. var failed bool
  3080. var surplus []string
  3081. filesMatched := make(map[string]bool)
  3082. for _, file := range getFiles(t, ctx, moduleName, variant) {
  3083. mactchFound := false
  3084. for _, expected := range files {
  3085. if matched, _ := path.Match(expected, file.path); matched {
  3086. filesMatched[expected] = true
  3087. mactchFound = true
  3088. break
  3089. }
  3090. }
  3091. if !mactchFound {
  3092. surplus = append(surplus, file.path)
  3093. }
  3094. }
  3095. if len(surplus) > 0 {
  3096. sort.Strings(surplus)
  3097. t.Log("surplus files", surplus)
  3098. failed = true
  3099. }
  3100. if len(files) > len(filesMatched) {
  3101. var missing []string
  3102. for _, expected := range files {
  3103. if !filesMatched[expected] {
  3104. missing = append(missing, expected)
  3105. }
  3106. }
  3107. sort.Strings(missing)
  3108. t.Log("missing files", missing)
  3109. failed = true
  3110. }
  3111. if failed {
  3112. t.Fail()
  3113. }
  3114. }
  3115. func TestVndkApexCurrent(t *testing.T) {
  3116. commonFiles := []string{
  3117. "lib/libc++.so",
  3118. "lib64/libc++.so",
  3119. "etc/llndk.libraries.29.txt",
  3120. "etc/vndkcore.libraries.29.txt",
  3121. "etc/vndksp.libraries.29.txt",
  3122. "etc/vndkprivate.libraries.29.txt",
  3123. "etc/vndkproduct.libraries.29.txt",
  3124. }
  3125. testCases := []struct {
  3126. vndkVersion string
  3127. expectedFiles []string
  3128. }{
  3129. {
  3130. vndkVersion: "current",
  3131. expectedFiles: append(commonFiles,
  3132. "lib/libvndk.so",
  3133. "lib/libvndksp.so",
  3134. "lib64/libvndk.so",
  3135. "lib64/libvndksp.so"),
  3136. },
  3137. {
  3138. vndkVersion: "",
  3139. expectedFiles: append(commonFiles,
  3140. // Legacy VNDK APEX contains only VNDK-SP files (of core variant)
  3141. "lib/libvndksp.so",
  3142. "lib64/libvndksp.so"),
  3143. },
  3144. }
  3145. for _, tc := range testCases {
  3146. t.Run("VNDK.current with DeviceVndkVersion="+tc.vndkVersion, func(t *testing.T) {
  3147. ctx := testApex(t, `
  3148. apex_vndk {
  3149. name: "com.android.vndk.current",
  3150. key: "com.android.vndk.current.key",
  3151. updatable: false,
  3152. }
  3153. apex_key {
  3154. name: "com.android.vndk.current.key",
  3155. public_key: "testkey.avbpubkey",
  3156. private_key: "testkey.pem",
  3157. }
  3158. cc_library {
  3159. name: "libvndk",
  3160. srcs: ["mylib.cpp"],
  3161. vendor_available: true,
  3162. product_available: true,
  3163. vndk: {
  3164. enabled: true,
  3165. },
  3166. system_shared_libs: [],
  3167. stl: "none",
  3168. apex_available: [ "com.android.vndk.current" ],
  3169. }
  3170. cc_library {
  3171. name: "libvndksp",
  3172. srcs: ["mylib.cpp"],
  3173. vendor_available: true,
  3174. product_available: true,
  3175. vndk: {
  3176. enabled: true,
  3177. support_system_process: true,
  3178. },
  3179. system_shared_libs: [],
  3180. stl: "none",
  3181. apex_available: [ "com.android.vndk.current" ],
  3182. }
  3183. // VNDK-Ext should not cause any problems
  3184. cc_library {
  3185. name: "libvndk.ext",
  3186. srcs: ["mylib2.cpp"],
  3187. vendor: true,
  3188. vndk: {
  3189. enabled: true,
  3190. extends: "libvndk",
  3191. },
  3192. system_shared_libs: [],
  3193. stl: "none",
  3194. }
  3195. cc_library {
  3196. name: "libvndksp.ext",
  3197. srcs: ["mylib2.cpp"],
  3198. vendor: true,
  3199. vndk: {
  3200. enabled: true,
  3201. support_system_process: true,
  3202. extends: "libvndksp",
  3203. },
  3204. system_shared_libs: [],
  3205. stl: "none",
  3206. }
  3207. `+vndkLibrariesTxtFiles("current"), android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  3208. variables.DeviceVndkVersion = proptools.StringPtr(tc.vndkVersion)
  3209. }))
  3210. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", tc.expectedFiles)
  3211. })
  3212. }
  3213. }
  3214. func TestVndkApexWithPrebuilt(t *testing.T) {
  3215. ctx := testApex(t, `
  3216. apex_vndk {
  3217. name: "com.android.vndk.current",
  3218. key: "com.android.vndk.current.key",
  3219. updatable: false,
  3220. }
  3221. apex_key {
  3222. name: "com.android.vndk.current.key",
  3223. public_key: "testkey.avbpubkey",
  3224. private_key: "testkey.pem",
  3225. }
  3226. cc_prebuilt_library_shared {
  3227. name: "libvndk",
  3228. srcs: ["libvndk.so"],
  3229. vendor_available: true,
  3230. product_available: true,
  3231. vndk: {
  3232. enabled: true,
  3233. },
  3234. system_shared_libs: [],
  3235. stl: "none",
  3236. apex_available: [ "com.android.vndk.current" ],
  3237. }
  3238. cc_prebuilt_library_shared {
  3239. name: "libvndk.arm",
  3240. srcs: ["libvndk.arm.so"],
  3241. vendor_available: true,
  3242. product_available: true,
  3243. vndk: {
  3244. enabled: true,
  3245. },
  3246. enabled: false,
  3247. arch: {
  3248. arm: {
  3249. enabled: true,
  3250. },
  3251. },
  3252. system_shared_libs: [],
  3253. stl: "none",
  3254. apex_available: [ "com.android.vndk.current" ],
  3255. }
  3256. `+vndkLibrariesTxtFiles("current"),
  3257. withFiles(map[string][]byte{
  3258. "libvndk.so": nil,
  3259. "libvndk.arm.so": nil,
  3260. }))
  3261. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3262. "lib/libvndk.so",
  3263. "lib/libvndk.arm.so",
  3264. "lib64/libvndk.so",
  3265. "lib/libc++.so",
  3266. "lib64/libc++.so",
  3267. "etc/*",
  3268. })
  3269. }
  3270. func vndkLibrariesTxtFiles(vers ...string) (result string) {
  3271. for _, v := range vers {
  3272. if v == "current" {
  3273. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3274. result += `
  3275. ` + txt + `_libraries_txt {
  3276. name: "` + txt + `.libraries.txt",
  3277. }
  3278. `
  3279. }
  3280. } else {
  3281. for _, txt := range []string{"llndk", "vndkcore", "vndksp", "vndkprivate", "vndkproduct"} {
  3282. result += `
  3283. prebuilt_etc {
  3284. name: "` + txt + `.libraries.` + v + `.txt",
  3285. src: "dummy.txt",
  3286. }
  3287. `
  3288. }
  3289. }
  3290. }
  3291. return
  3292. }
  3293. func TestVndkApexVersion(t *testing.T) {
  3294. ctx := testApex(t, `
  3295. apex_vndk {
  3296. name: "com.android.vndk.v27",
  3297. key: "myapex.key",
  3298. file_contexts: ":myapex-file_contexts",
  3299. vndk_version: "27",
  3300. updatable: false,
  3301. }
  3302. apex_key {
  3303. name: "myapex.key",
  3304. public_key: "testkey.avbpubkey",
  3305. private_key: "testkey.pem",
  3306. }
  3307. vndk_prebuilt_shared {
  3308. name: "libvndk27",
  3309. version: "27",
  3310. vendor_available: true,
  3311. product_available: true,
  3312. vndk: {
  3313. enabled: true,
  3314. },
  3315. target_arch: "arm64",
  3316. arch: {
  3317. arm: {
  3318. srcs: ["libvndk27_arm.so"],
  3319. },
  3320. arm64: {
  3321. srcs: ["libvndk27_arm64.so"],
  3322. },
  3323. },
  3324. apex_available: [ "com.android.vndk.v27" ],
  3325. }
  3326. vndk_prebuilt_shared {
  3327. name: "libvndk27",
  3328. version: "27",
  3329. vendor_available: true,
  3330. product_available: true,
  3331. vndk: {
  3332. enabled: true,
  3333. },
  3334. target_arch: "x86_64",
  3335. arch: {
  3336. x86: {
  3337. srcs: ["libvndk27_x86.so"],
  3338. },
  3339. x86_64: {
  3340. srcs: ["libvndk27_x86_64.so"],
  3341. },
  3342. },
  3343. }
  3344. `+vndkLibrariesTxtFiles("27"),
  3345. withFiles(map[string][]byte{
  3346. "libvndk27_arm.so": nil,
  3347. "libvndk27_arm64.so": nil,
  3348. "libvndk27_x86.so": nil,
  3349. "libvndk27_x86_64.so": nil,
  3350. }))
  3351. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3352. "lib/libvndk27_arm.so",
  3353. "lib64/libvndk27_arm64.so",
  3354. "etc/*",
  3355. })
  3356. }
  3357. func TestVndkApexNameRule(t *testing.T) {
  3358. ctx := testApex(t, `
  3359. apex_vndk {
  3360. name: "com.android.vndk.current",
  3361. key: "myapex.key",
  3362. file_contexts: ":myapex-file_contexts",
  3363. updatable: false,
  3364. }
  3365. apex_vndk {
  3366. name: "com.android.vndk.v28",
  3367. key: "myapex.key",
  3368. file_contexts: ":myapex-file_contexts",
  3369. vndk_version: "28",
  3370. updatable: false,
  3371. }
  3372. apex_key {
  3373. name: "myapex.key",
  3374. public_key: "testkey.avbpubkey",
  3375. private_key: "testkey.pem",
  3376. }`+vndkLibrariesTxtFiles("28", "current"))
  3377. assertApexName := func(expected, moduleName string) {
  3378. bundle := ctx.ModuleForTests(moduleName, "android_common_image").Module().(*apexBundle)
  3379. actual := proptools.String(bundle.properties.Apex_name)
  3380. if !reflect.DeepEqual(actual, expected) {
  3381. t.Errorf("Got '%v', expected '%v'", actual, expected)
  3382. }
  3383. }
  3384. assertApexName("com.android.vndk.v29", "com.android.vndk.current")
  3385. assertApexName("com.android.vndk.v28", "com.android.vndk.v28")
  3386. }
  3387. func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
  3388. ctx := testApex(t, `
  3389. apex_vndk {
  3390. name: "com.android.vndk.current",
  3391. key: "com.android.vndk.current.key",
  3392. file_contexts: ":myapex-file_contexts",
  3393. updatable: false,
  3394. }
  3395. apex_key {
  3396. name: "com.android.vndk.current.key",
  3397. public_key: "testkey.avbpubkey",
  3398. private_key: "testkey.pem",
  3399. }
  3400. cc_library {
  3401. name: "libvndk",
  3402. srcs: ["mylib.cpp"],
  3403. vendor_available: true,
  3404. product_available: true,
  3405. native_bridge_supported: true,
  3406. host_supported: true,
  3407. vndk: {
  3408. enabled: true,
  3409. },
  3410. system_shared_libs: [],
  3411. stl: "none",
  3412. apex_available: [ "com.android.vndk.current" ],
  3413. }
  3414. `+vndkLibrariesTxtFiles("current"),
  3415. withNativeBridgeEnabled)
  3416. ensureExactContents(t, ctx, "com.android.vndk.current", "android_common_image", []string{
  3417. "lib/libvndk.so",
  3418. "lib64/libvndk.so",
  3419. "lib/libc++.so",
  3420. "lib64/libc++.so",
  3421. "etc/*",
  3422. })
  3423. }
  3424. func TestVndkApexDoesntSupportNativeBridgeSupported(t *testing.T) {
  3425. testApexError(t, `module "com.android.vndk.current" .*: native_bridge_supported: .* doesn't support native bridge binary`, `
  3426. apex_vndk {
  3427. name: "com.android.vndk.current",
  3428. key: "com.android.vndk.current.key",
  3429. file_contexts: ":myapex-file_contexts",
  3430. native_bridge_supported: true,
  3431. }
  3432. apex_key {
  3433. name: "com.android.vndk.current.key",
  3434. public_key: "testkey.avbpubkey",
  3435. private_key: "testkey.pem",
  3436. }
  3437. cc_library {
  3438. name: "libvndk",
  3439. srcs: ["mylib.cpp"],
  3440. vendor_available: true,
  3441. product_available: true,
  3442. native_bridge_supported: true,
  3443. host_supported: true,
  3444. vndk: {
  3445. enabled: true,
  3446. },
  3447. system_shared_libs: [],
  3448. stl: "none",
  3449. }
  3450. `)
  3451. }
  3452. func TestVndkApexWithBinder32(t *testing.T) {
  3453. ctx := testApex(t, `
  3454. apex_vndk {
  3455. name: "com.android.vndk.v27",
  3456. key: "myapex.key",
  3457. file_contexts: ":myapex-file_contexts",
  3458. vndk_version: "27",
  3459. updatable: false,
  3460. }
  3461. apex_key {
  3462. name: "myapex.key",
  3463. public_key: "testkey.avbpubkey",
  3464. private_key: "testkey.pem",
  3465. }
  3466. vndk_prebuilt_shared {
  3467. name: "libvndk27",
  3468. version: "27",
  3469. target_arch: "arm",
  3470. vendor_available: true,
  3471. product_available: true,
  3472. vndk: {
  3473. enabled: true,
  3474. },
  3475. arch: {
  3476. arm: {
  3477. srcs: ["libvndk27.so"],
  3478. }
  3479. },
  3480. }
  3481. vndk_prebuilt_shared {
  3482. name: "libvndk27",
  3483. version: "27",
  3484. target_arch: "arm",
  3485. binder32bit: true,
  3486. vendor_available: true,
  3487. product_available: true,
  3488. vndk: {
  3489. enabled: true,
  3490. },
  3491. arch: {
  3492. arm: {
  3493. srcs: ["libvndk27binder32.so"],
  3494. }
  3495. },
  3496. apex_available: [ "com.android.vndk.v27" ],
  3497. }
  3498. `+vndkLibrariesTxtFiles("27"),
  3499. withFiles(map[string][]byte{
  3500. "libvndk27.so": nil,
  3501. "libvndk27binder32.so": nil,
  3502. }),
  3503. withBinder32bit,
  3504. withTargets(map[android.OsType][]android.Target{
  3505. android.Android: {
  3506. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}},
  3507. NativeBridge: android.NativeBridgeDisabled, NativeBridgeHostArchName: "", NativeBridgeRelativePath: ""},
  3508. },
  3509. }),
  3510. )
  3511. ensureExactContents(t, ctx, "com.android.vndk.v27", "android_common_image", []string{
  3512. "lib/libvndk27binder32.so",
  3513. "etc/*",
  3514. })
  3515. }
  3516. func TestVndkApexShouldNotProvideNativeLibs(t *testing.T) {
  3517. ctx := testApex(t, `
  3518. apex_vndk {
  3519. name: "com.android.vndk.current",
  3520. key: "com.android.vndk.current.key",
  3521. file_contexts: ":myapex-file_contexts",
  3522. updatable: false,
  3523. }
  3524. apex_key {
  3525. name: "com.android.vndk.current.key",
  3526. public_key: "testkey.avbpubkey",
  3527. private_key: "testkey.pem",
  3528. }
  3529. cc_library {
  3530. name: "libz",
  3531. vendor_available: true,
  3532. product_available: true,
  3533. vndk: {
  3534. enabled: true,
  3535. },
  3536. stubs: {
  3537. symbol_file: "libz.map.txt",
  3538. versions: ["30"],
  3539. }
  3540. }
  3541. `+vndkLibrariesTxtFiles("current"), withFiles(map[string][]byte{
  3542. "libz.map.txt": nil,
  3543. }))
  3544. apexManifestRule := ctx.ModuleForTests("com.android.vndk.current", "android_common_image").Rule("apexManifestRule")
  3545. provideNativeLibs := names(apexManifestRule.Args["provideNativeLibs"])
  3546. ensureListEmpty(t, provideNativeLibs)
  3547. }
  3548. func TestDependenciesInApexManifest(t *testing.T) {
  3549. ctx := testApex(t, `
  3550. apex {
  3551. name: "myapex_nodep",
  3552. key: "myapex.key",
  3553. native_shared_libs: ["lib_nodep"],
  3554. compile_multilib: "both",
  3555. file_contexts: ":myapex-file_contexts",
  3556. updatable: false,
  3557. }
  3558. apex {
  3559. name: "myapex_dep",
  3560. key: "myapex.key",
  3561. native_shared_libs: ["lib_dep"],
  3562. compile_multilib: "both",
  3563. file_contexts: ":myapex-file_contexts",
  3564. updatable: false,
  3565. }
  3566. apex {
  3567. name: "myapex_provider",
  3568. key: "myapex.key",
  3569. native_shared_libs: ["libfoo"],
  3570. compile_multilib: "both",
  3571. file_contexts: ":myapex-file_contexts",
  3572. updatable: false,
  3573. }
  3574. apex {
  3575. name: "myapex_selfcontained",
  3576. key: "myapex.key",
  3577. native_shared_libs: ["lib_dep", "libfoo"],
  3578. compile_multilib: "both",
  3579. file_contexts: ":myapex-file_contexts",
  3580. updatable: false,
  3581. }
  3582. apex_key {
  3583. name: "myapex.key",
  3584. public_key: "testkey.avbpubkey",
  3585. private_key: "testkey.pem",
  3586. }
  3587. cc_library {
  3588. name: "lib_nodep",
  3589. srcs: ["mylib.cpp"],
  3590. system_shared_libs: [],
  3591. stl: "none",
  3592. apex_available: [ "myapex_nodep" ],
  3593. }
  3594. cc_library {
  3595. name: "lib_dep",
  3596. srcs: ["mylib.cpp"],
  3597. shared_libs: ["libfoo"],
  3598. system_shared_libs: [],
  3599. stl: "none",
  3600. apex_available: [
  3601. "myapex_dep",
  3602. "myapex_provider",
  3603. "myapex_selfcontained",
  3604. ],
  3605. }
  3606. cc_library {
  3607. name: "libfoo",
  3608. srcs: ["mytest.cpp"],
  3609. stubs: {
  3610. versions: ["1"],
  3611. },
  3612. system_shared_libs: [],
  3613. stl: "none",
  3614. apex_available: [
  3615. "myapex_provider",
  3616. "myapex_selfcontained",
  3617. ],
  3618. }
  3619. `)
  3620. var apexManifestRule android.TestingBuildParams
  3621. var provideNativeLibs, requireNativeLibs []string
  3622. apexManifestRule = ctx.ModuleForTests("myapex_nodep", "android_common_myapex_nodep_image").Rule("apexManifestRule")
  3623. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3624. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3625. ensureListEmpty(t, provideNativeLibs)
  3626. ensureListEmpty(t, requireNativeLibs)
  3627. apexManifestRule = ctx.ModuleForTests("myapex_dep", "android_common_myapex_dep_image").Rule("apexManifestRule")
  3628. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3629. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3630. ensureListEmpty(t, provideNativeLibs)
  3631. ensureListContains(t, requireNativeLibs, "libfoo.so")
  3632. apexManifestRule = ctx.ModuleForTests("myapex_provider", "android_common_myapex_provider_image").Rule("apexManifestRule")
  3633. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3634. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3635. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3636. ensureListEmpty(t, requireNativeLibs)
  3637. apexManifestRule = ctx.ModuleForTests("myapex_selfcontained", "android_common_myapex_selfcontained_image").Rule("apexManifestRule")
  3638. provideNativeLibs = names(apexManifestRule.Args["provideNativeLibs"])
  3639. requireNativeLibs = names(apexManifestRule.Args["requireNativeLibs"])
  3640. ensureListContains(t, provideNativeLibs, "libfoo.so")
  3641. ensureListEmpty(t, requireNativeLibs)
  3642. }
  3643. func TestApexName(t *testing.T) {
  3644. ctx := testApex(t, `
  3645. apex {
  3646. name: "myapex",
  3647. key: "myapex.key",
  3648. apex_name: "com.android.myapex",
  3649. native_shared_libs: ["mylib"],
  3650. updatable: false,
  3651. }
  3652. apex_key {
  3653. name: "myapex.key",
  3654. public_key: "testkey.avbpubkey",
  3655. private_key: "testkey.pem",
  3656. }
  3657. cc_library {
  3658. name: "mylib",
  3659. srcs: ["mylib.cpp"],
  3660. system_shared_libs: [],
  3661. stl: "none",
  3662. apex_available: [
  3663. "//apex_available:platform",
  3664. "myapex",
  3665. ],
  3666. }
  3667. `)
  3668. module := ctx.ModuleForTests("myapex", "android_common_com.android.myapex_image")
  3669. apexManifestRule := module.Rule("apexManifestRule")
  3670. ensureContains(t, apexManifestRule.Args["opt"], "-v name com.android.myapex")
  3671. apexRule := module.Rule("apexRule")
  3672. ensureContains(t, apexRule.Args["opt_flags"], "--do_not_check_keyname")
  3673. apexBundle := module.Module().(*apexBundle)
  3674. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  3675. name := apexBundle.BaseModuleName()
  3676. prefix := "TARGET_"
  3677. var builder strings.Builder
  3678. data.Custom(&builder, name, prefix, "", data)
  3679. androidMk := builder.String()
  3680. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  3681. ensureNotContains(t, androidMk, "LOCAL_MODULE := mylib.com.android.myapex\n")
  3682. }
  3683. func TestNonTestApex(t *testing.T) {
  3684. ctx := testApex(t, `
  3685. apex {
  3686. name: "myapex",
  3687. key: "myapex.key",
  3688. native_shared_libs: ["mylib_common"],
  3689. updatable: false,
  3690. }
  3691. apex_key {
  3692. name: "myapex.key",
  3693. public_key: "testkey.avbpubkey",
  3694. private_key: "testkey.pem",
  3695. }
  3696. cc_library {
  3697. name: "mylib_common",
  3698. srcs: ["mylib.cpp"],
  3699. system_shared_libs: [],
  3700. stl: "none",
  3701. apex_available: [
  3702. "//apex_available:platform",
  3703. "myapex",
  3704. ],
  3705. }
  3706. `)
  3707. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3708. apexRule := module.Rule("apexRule")
  3709. copyCmds := apexRule.Args["copy_commands"]
  3710. if apex, ok := module.Module().(*apexBundle); !ok || apex.testApex {
  3711. t.Log("Apex was a test apex!")
  3712. t.Fail()
  3713. }
  3714. // Ensure that main rule creates an output
  3715. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3716. // Ensure that apex variant is created for the direct dep
  3717. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3718. // Ensure that both direct and indirect deps are copied into apex
  3719. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3720. // Ensure that the platform variant ends with _shared
  3721. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3722. if !ctx.ModuleForTests("mylib_common", "android_arm64_armv8-a_shared_apex10000").Module().(*cc.Module).InAnyApex() {
  3723. t.Log("Found mylib_common not in any apex!")
  3724. t.Fail()
  3725. }
  3726. }
  3727. func TestTestApex(t *testing.T) {
  3728. ctx := testApex(t, `
  3729. apex_test {
  3730. name: "myapex",
  3731. key: "myapex.key",
  3732. native_shared_libs: ["mylib_common_test"],
  3733. updatable: false,
  3734. }
  3735. apex_key {
  3736. name: "myapex.key",
  3737. public_key: "testkey.avbpubkey",
  3738. private_key: "testkey.pem",
  3739. }
  3740. cc_library {
  3741. name: "mylib_common_test",
  3742. srcs: ["mylib.cpp"],
  3743. system_shared_libs: [],
  3744. stl: "none",
  3745. // TODO: remove //apex_available:platform
  3746. apex_available: [
  3747. "//apex_available:platform",
  3748. "myapex",
  3749. ],
  3750. }
  3751. `)
  3752. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3753. apexRule := module.Rule("apexRule")
  3754. copyCmds := apexRule.Args["copy_commands"]
  3755. if apex, ok := module.Module().(*apexBundle); !ok || !apex.testApex {
  3756. t.Log("Apex was not a test apex!")
  3757. t.Fail()
  3758. }
  3759. // Ensure that main rule creates an output
  3760. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3761. // Ensure that apex variant is created for the direct dep
  3762. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared_apex10000")
  3763. // Ensure that both direct and indirect deps are copied into apex
  3764. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common_test.so")
  3765. // Ensure that the platform variant ends with _shared
  3766. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common_test"), "android_arm64_armv8-a_shared")
  3767. }
  3768. func TestApexWithTarget(t *testing.T) {
  3769. ctx := testApex(t, `
  3770. apex {
  3771. name: "myapex",
  3772. key: "myapex.key",
  3773. updatable: false,
  3774. multilib: {
  3775. first: {
  3776. native_shared_libs: ["mylib_common"],
  3777. }
  3778. },
  3779. target: {
  3780. android: {
  3781. multilib: {
  3782. first: {
  3783. native_shared_libs: ["mylib"],
  3784. }
  3785. }
  3786. },
  3787. host: {
  3788. multilib: {
  3789. first: {
  3790. native_shared_libs: ["mylib2"],
  3791. }
  3792. }
  3793. }
  3794. }
  3795. }
  3796. apex_key {
  3797. name: "myapex.key",
  3798. public_key: "testkey.avbpubkey",
  3799. private_key: "testkey.pem",
  3800. }
  3801. cc_library {
  3802. name: "mylib",
  3803. srcs: ["mylib.cpp"],
  3804. system_shared_libs: [],
  3805. stl: "none",
  3806. // TODO: remove //apex_available:platform
  3807. apex_available: [
  3808. "//apex_available:platform",
  3809. "myapex",
  3810. ],
  3811. }
  3812. cc_library {
  3813. name: "mylib_common",
  3814. srcs: ["mylib.cpp"],
  3815. system_shared_libs: [],
  3816. stl: "none",
  3817. compile_multilib: "first",
  3818. // TODO: remove //apex_available:platform
  3819. apex_available: [
  3820. "//apex_available:platform",
  3821. "myapex",
  3822. ],
  3823. }
  3824. cc_library {
  3825. name: "mylib2",
  3826. srcs: ["mylib.cpp"],
  3827. system_shared_libs: [],
  3828. stl: "none",
  3829. compile_multilib: "first",
  3830. }
  3831. `)
  3832. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3833. copyCmds := apexRule.Args["copy_commands"]
  3834. // Ensure that main rule creates an output
  3835. ensureContains(t, apexRule.Output.String(), "myapex.apex.unsigned")
  3836. // Ensure that apex variant is created for the direct dep
  3837. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared_apex10000")
  3838. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared_apex10000")
  3839. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared_apex10000")
  3840. // Ensure that both direct and indirect deps are copied into apex
  3841. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  3842. ensureContains(t, copyCmds, "image.apex/lib64/mylib_common.so")
  3843. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  3844. // Ensure that the platform variant ends with _shared
  3845. ensureListContains(t, ctx.ModuleVariantsForTests("mylib"), "android_arm64_armv8-a_shared")
  3846. ensureListContains(t, ctx.ModuleVariantsForTests("mylib_common"), "android_arm64_armv8-a_shared")
  3847. ensureListContains(t, ctx.ModuleVariantsForTests("mylib2"), "android_arm64_armv8-a_shared")
  3848. }
  3849. func TestApexWithArch(t *testing.T) {
  3850. ctx := testApex(t, `
  3851. apex {
  3852. name: "myapex",
  3853. key: "myapex.key",
  3854. updatable: false,
  3855. arch: {
  3856. arm64: {
  3857. native_shared_libs: ["mylib.arm64"],
  3858. },
  3859. x86_64: {
  3860. native_shared_libs: ["mylib.x64"],
  3861. },
  3862. }
  3863. }
  3864. apex_key {
  3865. name: "myapex.key",
  3866. public_key: "testkey.avbpubkey",
  3867. private_key: "testkey.pem",
  3868. }
  3869. cc_library {
  3870. name: "mylib.arm64",
  3871. srcs: ["mylib.cpp"],
  3872. system_shared_libs: [],
  3873. stl: "none",
  3874. // TODO: remove //apex_available:platform
  3875. apex_available: [
  3876. "//apex_available:platform",
  3877. "myapex",
  3878. ],
  3879. }
  3880. cc_library {
  3881. name: "mylib.x64",
  3882. srcs: ["mylib.cpp"],
  3883. system_shared_libs: [],
  3884. stl: "none",
  3885. // TODO: remove //apex_available:platform
  3886. apex_available: [
  3887. "//apex_available:platform",
  3888. "myapex",
  3889. ],
  3890. }
  3891. `)
  3892. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3893. copyCmds := apexRule.Args["copy_commands"]
  3894. // Ensure that apex variant is created for the direct dep
  3895. ensureListContains(t, ctx.ModuleVariantsForTests("mylib.arm64"), "android_arm64_armv8-a_shared_apex10000")
  3896. ensureListNotContains(t, ctx.ModuleVariantsForTests("mylib.x64"), "android_arm64_armv8-a_shared_apex10000")
  3897. // Ensure that both direct and indirect deps are copied into apex
  3898. ensureContains(t, copyCmds, "image.apex/lib64/mylib.arm64.so")
  3899. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib.x64.so")
  3900. }
  3901. func TestApexWithShBinary(t *testing.T) {
  3902. ctx := testApex(t, `
  3903. apex {
  3904. name: "myapex",
  3905. key: "myapex.key",
  3906. sh_binaries: ["myscript"],
  3907. updatable: false,
  3908. }
  3909. apex_key {
  3910. name: "myapex.key",
  3911. public_key: "testkey.avbpubkey",
  3912. private_key: "testkey.pem",
  3913. }
  3914. sh_binary {
  3915. name: "myscript",
  3916. src: "mylib.cpp",
  3917. filename: "myscript.sh",
  3918. sub_dir: "script",
  3919. }
  3920. `)
  3921. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  3922. copyCmds := apexRule.Args["copy_commands"]
  3923. ensureContains(t, copyCmds, "image.apex/bin/script/myscript.sh")
  3924. }
  3925. func TestApexInVariousPartition(t *testing.T) {
  3926. testcases := []struct {
  3927. propName, parition, flattenedPartition string
  3928. }{
  3929. {"", "system", "system_ext"},
  3930. {"product_specific: true", "product", "product"},
  3931. {"soc_specific: true", "vendor", "vendor"},
  3932. {"proprietary: true", "vendor", "vendor"},
  3933. {"vendor: true", "vendor", "vendor"},
  3934. {"system_ext_specific: true", "system_ext", "system_ext"},
  3935. }
  3936. for _, tc := range testcases {
  3937. t.Run(tc.propName+":"+tc.parition, func(t *testing.T) {
  3938. ctx := testApex(t, `
  3939. apex {
  3940. name: "myapex",
  3941. key: "myapex.key",
  3942. updatable: false,
  3943. `+tc.propName+`
  3944. }
  3945. apex_key {
  3946. name: "myapex.key",
  3947. public_key: "testkey.avbpubkey",
  3948. private_key: "testkey.pem",
  3949. }
  3950. `)
  3951. apex := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  3952. expected := "out/soong/target/product/test_device/" + tc.parition + "/apex"
  3953. actual := apex.installDir.RelativeToTop().String()
  3954. if actual != expected {
  3955. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3956. }
  3957. flattened := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  3958. expected = "out/soong/target/product/test_device/" + tc.flattenedPartition + "/apex"
  3959. actual = flattened.installDir.RelativeToTop().String()
  3960. if actual != expected {
  3961. t.Errorf("wrong install path. expected %q. actual %q", expected, actual)
  3962. }
  3963. })
  3964. }
  3965. }
  3966. func TestFileContexts_FindInDefaultLocationIfNotSet(t *testing.T) {
  3967. ctx := testApex(t, `
  3968. apex {
  3969. name: "myapex",
  3970. key: "myapex.key",
  3971. updatable: false,
  3972. }
  3973. apex_key {
  3974. name: "myapex.key",
  3975. public_key: "testkey.avbpubkey",
  3976. private_key: "testkey.pem",
  3977. }
  3978. `)
  3979. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  3980. rule := module.Output("file_contexts")
  3981. ensureContains(t, rule.RuleParams.Command, "cat system/sepolicy/apex/myapex-file_contexts")
  3982. }
  3983. func TestFileContexts_ShouldBeUnderSystemSepolicyForSystemApexes(t *testing.T) {
  3984. testApexError(t, `"myapex" .*: file_contexts: should be under system/sepolicy`, `
  3985. apex {
  3986. name: "myapex",
  3987. key: "myapex.key",
  3988. file_contexts: "my_own_file_contexts",
  3989. updatable: false,
  3990. }
  3991. apex_key {
  3992. name: "myapex.key",
  3993. public_key: "testkey.avbpubkey",
  3994. private_key: "testkey.pem",
  3995. }
  3996. `, withFiles(map[string][]byte{
  3997. "my_own_file_contexts": nil,
  3998. }))
  3999. }
  4000. func TestFileContexts_ProductSpecificApexes(t *testing.T) {
  4001. testApexError(t, `"myapex" .*: file_contexts: cannot find`, `
  4002. apex {
  4003. name: "myapex",
  4004. key: "myapex.key",
  4005. product_specific: true,
  4006. file_contexts: "product_specific_file_contexts",
  4007. updatable: false,
  4008. }
  4009. apex_key {
  4010. name: "myapex.key",
  4011. public_key: "testkey.avbpubkey",
  4012. private_key: "testkey.pem",
  4013. }
  4014. `)
  4015. ctx := testApex(t, `
  4016. apex {
  4017. name: "myapex",
  4018. key: "myapex.key",
  4019. product_specific: true,
  4020. file_contexts: "product_specific_file_contexts",
  4021. updatable: false,
  4022. }
  4023. apex_key {
  4024. name: "myapex.key",
  4025. public_key: "testkey.avbpubkey",
  4026. private_key: "testkey.pem",
  4027. }
  4028. `, withFiles(map[string][]byte{
  4029. "product_specific_file_contexts": nil,
  4030. }))
  4031. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4032. rule := module.Output("file_contexts")
  4033. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4034. }
  4035. func TestFileContexts_SetViaFileGroup(t *testing.T) {
  4036. ctx := testApex(t, `
  4037. apex {
  4038. name: "myapex",
  4039. key: "myapex.key",
  4040. product_specific: true,
  4041. file_contexts: ":my-file-contexts",
  4042. updatable: false,
  4043. }
  4044. apex_key {
  4045. name: "myapex.key",
  4046. public_key: "testkey.avbpubkey",
  4047. private_key: "testkey.pem",
  4048. }
  4049. filegroup {
  4050. name: "my-file-contexts",
  4051. srcs: ["product_specific_file_contexts"],
  4052. }
  4053. `, withFiles(map[string][]byte{
  4054. "product_specific_file_contexts": nil,
  4055. }))
  4056. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  4057. rule := module.Output("file_contexts")
  4058. ensureContains(t, rule.RuleParams.Command, "cat product_specific_file_contexts")
  4059. }
  4060. func TestApexKeyFromOtherModule(t *testing.T) {
  4061. ctx := testApex(t, `
  4062. apex_key {
  4063. name: "myapex.key",
  4064. public_key: ":my.avbpubkey",
  4065. private_key: ":my.pem",
  4066. product_specific: true,
  4067. }
  4068. filegroup {
  4069. name: "my.avbpubkey",
  4070. srcs: ["testkey2.avbpubkey"],
  4071. }
  4072. filegroup {
  4073. name: "my.pem",
  4074. srcs: ["testkey2.pem"],
  4075. }
  4076. `)
  4077. apex_key := ctx.ModuleForTests("myapex.key", "android_common").Module().(*apexKey)
  4078. expected_pubkey := "testkey2.avbpubkey"
  4079. actual_pubkey := apex_key.publicKeyFile.String()
  4080. if actual_pubkey != expected_pubkey {
  4081. t.Errorf("wrong public key path. expected %q. actual %q", expected_pubkey, actual_pubkey)
  4082. }
  4083. expected_privkey := "testkey2.pem"
  4084. actual_privkey := apex_key.privateKeyFile.String()
  4085. if actual_privkey != expected_privkey {
  4086. t.Errorf("wrong private key path. expected %q. actual %q", expected_privkey, actual_privkey)
  4087. }
  4088. }
  4089. func TestPrebuilt(t *testing.T) {
  4090. ctx := testApex(t, `
  4091. prebuilt_apex {
  4092. name: "myapex",
  4093. arch: {
  4094. arm64: {
  4095. src: "myapex-arm64.apex",
  4096. },
  4097. arm: {
  4098. src: "myapex-arm.apex",
  4099. },
  4100. },
  4101. }
  4102. `)
  4103. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4104. prebuilt := testingModule.Module().(*Prebuilt)
  4105. expectedInput := "myapex-arm64.apex"
  4106. if prebuilt.inputApex.String() != expectedInput {
  4107. t.Errorf("inputApex invalid. expected: %q, actual: %q", expectedInput, prebuilt.inputApex.String())
  4108. }
  4109. android.AssertStringDoesContain(t, "Invalid provenance metadata file",
  4110. prebuilt.ProvenanceMetaDataFile().String(), "soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto")
  4111. rule := testingModule.Rule("genProvenanceMetaData")
  4112. android.AssertStringEquals(t, "Invalid input", "myapex-arm64.apex", rule.Inputs[0].String())
  4113. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4114. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4115. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.apex", rule.Args["install_path"])
  4116. }
  4117. func TestPrebuiltMissingSrc(t *testing.T) {
  4118. testApexError(t, `module "myapex" variant "android_common_myapex".*: prebuilt_apex does not support "arm64_armv8-a"`, `
  4119. prebuilt_apex {
  4120. name: "myapex",
  4121. }
  4122. `)
  4123. }
  4124. func TestPrebuiltFilenameOverride(t *testing.T) {
  4125. ctx := testApex(t, `
  4126. prebuilt_apex {
  4127. name: "myapex",
  4128. src: "myapex-arm.apex",
  4129. filename: "notmyapex.apex",
  4130. }
  4131. `)
  4132. testingModule := ctx.ModuleForTests("myapex", "android_common_myapex")
  4133. p := testingModule.Module().(*Prebuilt)
  4134. expected := "notmyapex.apex"
  4135. if p.installFilename != expected {
  4136. t.Errorf("installFilename invalid. expected: %q, actual: %q", expected, p.installFilename)
  4137. }
  4138. rule := testingModule.Rule("genProvenanceMetaData")
  4139. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4140. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex/provenance_metadata.textproto", rule.Output.String())
  4141. android.AssertStringEquals(t, "Invalid args", "myapex", rule.Args["module_name"])
  4142. android.AssertStringEquals(t, "Invalid args", "/system/apex/notmyapex.apex", rule.Args["install_path"])
  4143. }
  4144. func TestApexSetFilenameOverride(t *testing.T) {
  4145. testApex(t, `
  4146. apex_set {
  4147. name: "com.company.android.myapex",
  4148. apex_name: "com.android.myapex",
  4149. set: "company-myapex.apks",
  4150. filename: "com.company.android.myapex.apex"
  4151. }
  4152. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4153. testApex(t, `
  4154. apex_set {
  4155. name: "com.company.android.myapex",
  4156. apex_name: "com.android.myapex",
  4157. set: "company-myapex.apks",
  4158. filename: "com.company.android.myapex.capex"
  4159. }
  4160. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4161. testApexError(t, `filename should end in .apex or .capex for apex_set`, `
  4162. apex_set {
  4163. name: "com.company.android.myapex",
  4164. apex_name: "com.android.myapex",
  4165. set: "company-myapex.apks",
  4166. filename: "some-random-suffix"
  4167. }
  4168. `)
  4169. }
  4170. func TestPrebuiltOverrides(t *testing.T) {
  4171. ctx := testApex(t, `
  4172. prebuilt_apex {
  4173. name: "myapex.prebuilt",
  4174. src: "myapex-arm.apex",
  4175. overrides: [
  4176. "myapex",
  4177. ],
  4178. }
  4179. `)
  4180. testingModule := ctx.ModuleForTests("myapex.prebuilt", "android_common_myapex.prebuilt")
  4181. p := testingModule.Module().(*Prebuilt)
  4182. expected := []string{"myapex"}
  4183. actual := android.AndroidMkEntriesForTest(t, ctx, p)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  4184. if !reflect.DeepEqual(actual, expected) {
  4185. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES value '%s', expected '%s'", actual, expected)
  4186. }
  4187. rule := testingModule.Rule("genProvenanceMetaData")
  4188. android.AssertStringEquals(t, "Invalid input", "myapex-arm.apex", rule.Inputs[0].String())
  4189. android.AssertStringEquals(t, "Invalid output", "out/soong/.intermediates/provenance_metadata/myapex.prebuilt/provenance_metadata.textproto", rule.Output.String())
  4190. android.AssertStringEquals(t, "Invalid args", "myapex.prebuilt", rule.Args["module_name"])
  4191. android.AssertStringEquals(t, "Invalid args", "/system/apex/myapex.prebuilt.apex", rule.Args["install_path"])
  4192. }
  4193. func TestPrebuiltApexName(t *testing.T) {
  4194. testApex(t, `
  4195. prebuilt_apex {
  4196. name: "com.company.android.myapex",
  4197. apex_name: "com.android.myapex",
  4198. src: "company-myapex-arm.apex",
  4199. }
  4200. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4201. testApex(t, `
  4202. apex_set {
  4203. name: "com.company.android.myapex",
  4204. apex_name: "com.android.myapex",
  4205. set: "company-myapex.apks",
  4206. }
  4207. `).ModuleForTests("com.company.android.myapex", "android_common_com.android.myapex")
  4208. }
  4209. func TestPrebuiltApexNameWithPlatformBootclasspath(t *testing.T) {
  4210. _ = android.GroupFixturePreparers(
  4211. java.PrepareForTestWithJavaDefaultModules,
  4212. PrepareForTestWithApexBuildComponents,
  4213. android.FixtureWithRootAndroidBp(`
  4214. platform_bootclasspath {
  4215. name: "platform-bootclasspath",
  4216. fragments: [
  4217. {
  4218. apex: "com.android.art",
  4219. module: "art-bootclasspath-fragment",
  4220. },
  4221. ],
  4222. }
  4223. prebuilt_apex {
  4224. name: "com.company.android.art",
  4225. apex_name: "com.android.art",
  4226. src: "com.company.android.art-arm.apex",
  4227. exported_bootclasspath_fragments: ["art-bootclasspath-fragment"],
  4228. }
  4229. prebuilt_bootclasspath_fragment {
  4230. name: "art-bootclasspath-fragment",
  4231. image_name: "art",
  4232. contents: ["core-oj"],
  4233. hidden_api: {
  4234. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4235. metadata: "my-bootclasspath-fragment/metadata.csv",
  4236. index: "my-bootclasspath-fragment/index.csv",
  4237. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4238. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4239. },
  4240. }
  4241. java_import {
  4242. name: "core-oj",
  4243. jars: ["prebuilt.jar"],
  4244. }
  4245. `),
  4246. ).RunTest(t)
  4247. }
  4248. // These tests verify that the prebuilt_apex/deapexer to java_import wiring allows for the
  4249. // propagation of paths to dex implementation jars from the former to the latter.
  4250. func TestPrebuiltExportDexImplementationJars(t *testing.T) {
  4251. transform := android.NullFixturePreparer
  4252. checkDexJarBuildPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4253. t.Helper()
  4254. // Make sure the import has been given the correct path to the dex jar.
  4255. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4256. dexJarBuildPath := p.DexJarBuildPath().PathOrNil()
  4257. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4258. android.AssertStringEquals(t, "DexJarBuildPath should be apex-related path.",
  4259. ".intermediates/myapex.deapexer/android_common/deapexer/javalib/"+stem+".jar",
  4260. android.NormalizePathForTesting(dexJarBuildPath))
  4261. }
  4262. checkDexJarInstallPath := func(t *testing.T, ctx *android.TestContext, name string) {
  4263. t.Helper()
  4264. // Make sure the import has been given the correct path to the dex jar.
  4265. p := ctx.ModuleForTests(name, "android_common_myapex").Module().(java.UsesLibraryDependency)
  4266. dexJarBuildPath := p.DexJarInstallPath()
  4267. stem := android.RemoveOptionalPrebuiltPrefix(name)
  4268. android.AssertStringEquals(t, "DexJarInstallPath should be apex-related path.",
  4269. "target/product/test_device/apex/myapex/javalib/"+stem+".jar",
  4270. android.NormalizePathForTesting(dexJarBuildPath))
  4271. }
  4272. ensureNoSourceVariant := func(t *testing.T, ctx *android.TestContext, name string) {
  4273. t.Helper()
  4274. // Make sure that an apex variant is not created for the source module.
  4275. android.AssertArrayString(t, "Check if there is no source variant",
  4276. []string{"android_common"},
  4277. ctx.ModuleVariantsForTests(name))
  4278. }
  4279. t.Run("prebuilt only", func(t *testing.T) {
  4280. bp := `
  4281. prebuilt_apex {
  4282. name: "myapex",
  4283. arch: {
  4284. arm64: {
  4285. src: "myapex-arm64.apex",
  4286. },
  4287. arm: {
  4288. src: "myapex-arm.apex",
  4289. },
  4290. },
  4291. exported_java_libs: ["libfoo", "libbar"],
  4292. }
  4293. java_import {
  4294. name: "libfoo",
  4295. jars: ["libfoo.jar"],
  4296. }
  4297. java_sdk_library_import {
  4298. name: "libbar",
  4299. public: {
  4300. jars: ["libbar.jar"],
  4301. },
  4302. }
  4303. `
  4304. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4305. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4306. deapexerName := deapexerModuleName("myapex")
  4307. android.AssertStringEquals(t, "APEX module name from deapexer name", "myapex", apexModuleName(deapexerName))
  4308. // Make sure that the deapexer has the correct input APEX.
  4309. deapexer := ctx.ModuleForTests(deapexerName, "android_common")
  4310. rule := deapexer.Rule("deapexer")
  4311. if expected, actual := []string{"myapex-arm64.apex"}, android.NormalizePathsForTesting(rule.Implicits); !reflect.DeepEqual(expected, actual) {
  4312. t.Errorf("expected: %q, found: %q", expected, actual)
  4313. }
  4314. // Make sure that the prebuilt_apex has the correct input APEX.
  4315. prebuiltApex := ctx.ModuleForTests("myapex", "android_common_myapex")
  4316. rule = prebuiltApex.Rule("android/soong/android.Cp")
  4317. if expected, actual := "myapex-arm64.apex", android.NormalizePathForTesting(rule.Input); !reflect.DeepEqual(expected, actual) {
  4318. t.Errorf("expected: %q, found: %q", expected, actual)
  4319. }
  4320. checkDexJarBuildPath(t, ctx, "libfoo")
  4321. checkDexJarInstallPath(t, ctx, "libfoo")
  4322. checkDexJarBuildPath(t, ctx, "libbar")
  4323. checkDexJarInstallPath(t, ctx, "libbar")
  4324. })
  4325. t.Run("prebuilt with source preferred", func(t *testing.T) {
  4326. bp := `
  4327. prebuilt_apex {
  4328. name: "myapex",
  4329. arch: {
  4330. arm64: {
  4331. src: "myapex-arm64.apex",
  4332. },
  4333. arm: {
  4334. src: "myapex-arm.apex",
  4335. },
  4336. },
  4337. exported_java_libs: ["libfoo", "libbar"],
  4338. }
  4339. java_import {
  4340. name: "libfoo",
  4341. jars: ["libfoo.jar"],
  4342. }
  4343. java_library {
  4344. name: "libfoo",
  4345. }
  4346. java_sdk_library_import {
  4347. name: "libbar",
  4348. public: {
  4349. jars: ["libbar.jar"],
  4350. },
  4351. }
  4352. java_sdk_library {
  4353. name: "libbar",
  4354. srcs: ["foo/bar/MyClass.java"],
  4355. unsafe_ignore_missing_latest_api: true,
  4356. }
  4357. `
  4358. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4359. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4360. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4361. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4362. ensureNoSourceVariant(t, ctx, "libfoo")
  4363. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4364. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4365. ensureNoSourceVariant(t, ctx, "libbar")
  4366. })
  4367. t.Run("prebuilt preferred with source", func(t *testing.T) {
  4368. bp := `
  4369. prebuilt_apex {
  4370. name: "myapex",
  4371. arch: {
  4372. arm64: {
  4373. src: "myapex-arm64.apex",
  4374. },
  4375. arm: {
  4376. src: "myapex-arm.apex",
  4377. },
  4378. },
  4379. exported_java_libs: ["libfoo", "libbar"],
  4380. }
  4381. java_import {
  4382. name: "libfoo",
  4383. prefer: true,
  4384. jars: ["libfoo.jar"],
  4385. }
  4386. java_library {
  4387. name: "libfoo",
  4388. }
  4389. java_sdk_library_import {
  4390. name: "libbar",
  4391. prefer: true,
  4392. public: {
  4393. jars: ["libbar.jar"],
  4394. },
  4395. }
  4396. java_sdk_library {
  4397. name: "libbar",
  4398. srcs: ["foo/bar/MyClass.java"],
  4399. unsafe_ignore_missing_latest_api: true,
  4400. }
  4401. `
  4402. // Make sure that dexpreopt can access dex implementation files from the prebuilt.
  4403. ctx := testDexpreoptWithApexes(t, bp, "", transform)
  4404. checkDexJarBuildPath(t, ctx, "prebuilt_libfoo")
  4405. checkDexJarInstallPath(t, ctx, "prebuilt_libfoo")
  4406. ensureNoSourceVariant(t, ctx, "libfoo")
  4407. checkDexJarBuildPath(t, ctx, "prebuilt_libbar")
  4408. checkDexJarInstallPath(t, ctx, "prebuilt_libbar")
  4409. ensureNoSourceVariant(t, ctx, "libbar")
  4410. })
  4411. }
  4412. func TestBootDexJarsFromSourcesAndPrebuilts(t *testing.T) {
  4413. preparer := android.GroupFixturePreparers(
  4414. java.FixtureConfigureApexBootJars("myapex:libfoo", "myapex:libbar"),
  4415. // Make sure that the frameworks/base/Android.bp file exists as otherwise hidden API encoding
  4416. // is disabled.
  4417. android.FixtureAddTextFile("frameworks/base/Android.bp", ""),
  4418. )
  4419. checkBootDexJarPath := func(t *testing.T, ctx *android.TestContext, stem string, bootDexJarPath string) {
  4420. t.Helper()
  4421. s := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4422. foundLibfooJar := false
  4423. base := stem + ".jar"
  4424. for _, output := range s.AllOutputs() {
  4425. if filepath.Base(output) == base {
  4426. foundLibfooJar = true
  4427. buildRule := s.Output(output)
  4428. android.AssertStringEquals(t, "boot dex jar path", bootDexJarPath, buildRule.Input.String())
  4429. }
  4430. }
  4431. if !foundLibfooJar {
  4432. t.Errorf("Rule for libfoo.jar missing in dex_bootjars singleton outputs %q", android.StringPathsRelativeToTop(ctx.Config().SoongOutDir(), s.AllOutputs()))
  4433. }
  4434. }
  4435. checkHiddenAPIIndexFromClassesInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4436. t.Helper()
  4437. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4438. var rule android.TestingBuildParams
  4439. rule = platformBootclasspath.Output("hiddenapi-monolithic/index-from-classes.csv")
  4440. java.CheckHiddenAPIRuleInputs(t, "intermediate index", expectedIntermediateInputs, rule)
  4441. }
  4442. checkHiddenAPIIndexFromFlagsInputs := func(t *testing.T, ctx *android.TestContext, expectedIntermediateInputs string) {
  4443. t.Helper()
  4444. platformBootclasspath := ctx.ModuleForTests("platform-bootclasspath", "android_common")
  4445. var rule android.TestingBuildParams
  4446. rule = platformBootclasspath.Output("hiddenapi-index.csv")
  4447. java.CheckHiddenAPIRuleInputs(t, "monolithic index", expectedIntermediateInputs, rule)
  4448. }
  4449. fragment := java.ApexVariantReference{
  4450. Apex: proptools.StringPtr("myapex"),
  4451. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  4452. }
  4453. t.Run("prebuilt only", func(t *testing.T) {
  4454. bp := `
  4455. prebuilt_apex {
  4456. name: "myapex",
  4457. arch: {
  4458. arm64: {
  4459. src: "myapex-arm64.apex",
  4460. },
  4461. arm: {
  4462. src: "myapex-arm.apex",
  4463. },
  4464. },
  4465. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4466. }
  4467. prebuilt_bootclasspath_fragment {
  4468. name: "my-bootclasspath-fragment",
  4469. contents: ["libfoo", "libbar"],
  4470. apex_available: ["myapex"],
  4471. hidden_api: {
  4472. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4473. metadata: "my-bootclasspath-fragment/metadata.csv",
  4474. index: "my-bootclasspath-fragment/index.csv",
  4475. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4476. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4477. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4478. },
  4479. }
  4480. java_import {
  4481. name: "libfoo",
  4482. jars: ["libfoo.jar"],
  4483. apex_available: ["myapex"],
  4484. permitted_packages: ["foo"],
  4485. }
  4486. java_sdk_library_import {
  4487. name: "libbar",
  4488. public: {
  4489. jars: ["libbar.jar"],
  4490. },
  4491. apex_available: ["myapex"],
  4492. shared_library: false,
  4493. permitted_packages: ["bar"],
  4494. }
  4495. `
  4496. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4497. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4498. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4499. // Verify the correct module jars contribute to the hiddenapi index file.
  4500. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4501. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4502. my-bootclasspath-fragment/index.csv
  4503. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4504. `)
  4505. })
  4506. t.Run("apex_set only", func(t *testing.T) {
  4507. bp := `
  4508. apex_set {
  4509. name: "myapex",
  4510. set: "myapex.apks",
  4511. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4512. }
  4513. prebuilt_bootclasspath_fragment {
  4514. name: "my-bootclasspath-fragment",
  4515. contents: ["libfoo", "libbar"],
  4516. apex_available: ["myapex"],
  4517. hidden_api: {
  4518. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4519. metadata: "my-bootclasspath-fragment/metadata.csv",
  4520. index: "my-bootclasspath-fragment/index.csv",
  4521. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4522. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4523. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4524. },
  4525. }
  4526. java_import {
  4527. name: "libfoo",
  4528. jars: ["libfoo.jar"],
  4529. apex_available: ["myapex"],
  4530. permitted_packages: ["foo"],
  4531. }
  4532. java_sdk_library_import {
  4533. name: "libbar",
  4534. public: {
  4535. jars: ["libbar.jar"],
  4536. },
  4537. apex_available: ["myapex"],
  4538. shared_library: false,
  4539. permitted_packages: ["bar"],
  4540. }
  4541. `
  4542. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4543. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4544. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4545. // Verify the correct module jars contribute to the hiddenapi index file.
  4546. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4547. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4548. my-bootclasspath-fragment/index.csv
  4549. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4550. `)
  4551. })
  4552. t.Run("prebuilt with source library preferred", func(t *testing.T) {
  4553. bp := `
  4554. prebuilt_apex {
  4555. name: "myapex",
  4556. arch: {
  4557. arm64: {
  4558. src: "myapex-arm64.apex",
  4559. },
  4560. arm: {
  4561. src: "myapex-arm.apex",
  4562. },
  4563. },
  4564. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4565. }
  4566. prebuilt_bootclasspath_fragment {
  4567. name: "my-bootclasspath-fragment",
  4568. contents: ["libfoo", "libbar"],
  4569. apex_available: ["myapex"],
  4570. hidden_api: {
  4571. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4572. metadata: "my-bootclasspath-fragment/metadata.csv",
  4573. index: "my-bootclasspath-fragment/index.csv",
  4574. stub_flags: "my-bootclasspath-fragment/stub-flags.csv",
  4575. all_flags: "my-bootclasspath-fragment/all-flags.csv",
  4576. },
  4577. }
  4578. java_import {
  4579. name: "libfoo",
  4580. jars: ["libfoo.jar"],
  4581. apex_available: ["myapex"],
  4582. }
  4583. java_library {
  4584. name: "libfoo",
  4585. srcs: ["foo/bar/MyClass.java"],
  4586. apex_available: ["myapex"],
  4587. }
  4588. java_sdk_library_import {
  4589. name: "libbar",
  4590. public: {
  4591. jars: ["libbar.jar"],
  4592. },
  4593. apex_available: ["myapex"],
  4594. shared_library: false,
  4595. }
  4596. java_sdk_library {
  4597. name: "libbar",
  4598. srcs: ["foo/bar/MyClass.java"],
  4599. unsafe_ignore_missing_latest_api: true,
  4600. apex_available: ["myapex"],
  4601. }
  4602. `
  4603. // In this test the source (java_library) libfoo is active since the
  4604. // prebuilt (java_import) defaults to prefer:false. However the
  4605. // prebuilt_apex module always depends on the prebuilt, and so it doesn't
  4606. // find the dex boot jar in it. We either need to disable the source libfoo
  4607. // or make the prebuilt libfoo preferred.
  4608. testDexpreoptWithApexes(t, bp, "module libfoo does not provide a dex boot jar", preparer, fragment)
  4609. // dexbootjar check is skipped if AllowMissingDependencies is true
  4610. preparerAllowMissingDeps := android.GroupFixturePreparers(
  4611. preparer,
  4612. android.PrepareForTestWithAllowMissingDependencies,
  4613. )
  4614. testDexpreoptWithApexes(t, bp, "", preparerAllowMissingDeps, fragment)
  4615. })
  4616. t.Run("prebuilt library preferred with source", func(t *testing.T) {
  4617. bp := `
  4618. prebuilt_apex {
  4619. name: "myapex",
  4620. arch: {
  4621. arm64: {
  4622. src: "myapex-arm64.apex",
  4623. },
  4624. arm: {
  4625. src: "myapex-arm.apex",
  4626. },
  4627. },
  4628. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4629. }
  4630. prebuilt_bootclasspath_fragment {
  4631. name: "my-bootclasspath-fragment",
  4632. contents: ["libfoo", "libbar"],
  4633. apex_available: ["myapex"],
  4634. hidden_api: {
  4635. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4636. metadata: "my-bootclasspath-fragment/metadata.csv",
  4637. index: "my-bootclasspath-fragment/index.csv",
  4638. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4639. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4640. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4641. },
  4642. }
  4643. java_import {
  4644. name: "libfoo",
  4645. prefer: true,
  4646. jars: ["libfoo.jar"],
  4647. apex_available: ["myapex"],
  4648. permitted_packages: ["foo"],
  4649. }
  4650. java_library {
  4651. name: "libfoo",
  4652. srcs: ["foo/bar/MyClass.java"],
  4653. apex_available: ["myapex"],
  4654. }
  4655. java_sdk_library_import {
  4656. name: "libbar",
  4657. prefer: true,
  4658. public: {
  4659. jars: ["libbar.jar"],
  4660. },
  4661. apex_available: ["myapex"],
  4662. shared_library: false,
  4663. permitted_packages: ["bar"],
  4664. }
  4665. java_sdk_library {
  4666. name: "libbar",
  4667. srcs: ["foo/bar/MyClass.java"],
  4668. unsafe_ignore_missing_latest_api: true,
  4669. apex_available: ["myapex"],
  4670. }
  4671. `
  4672. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4673. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4674. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4675. // Verify the correct module jars contribute to the hiddenapi index file.
  4676. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4677. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4678. my-bootclasspath-fragment/index.csv
  4679. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4680. `)
  4681. })
  4682. t.Run("prebuilt with source apex preferred", func(t *testing.T) {
  4683. bp := `
  4684. apex {
  4685. name: "myapex",
  4686. key: "myapex.key",
  4687. java_libs: ["libfoo", "libbar"],
  4688. updatable: false,
  4689. }
  4690. apex_key {
  4691. name: "myapex.key",
  4692. public_key: "testkey.avbpubkey",
  4693. private_key: "testkey.pem",
  4694. }
  4695. prebuilt_apex {
  4696. name: "myapex",
  4697. arch: {
  4698. arm64: {
  4699. src: "myapex-arm64.apex",
  4700. },
  4701. arm: {
  4702. src: "myapex-arm.apex",
  4703. },
  4704. },
  4705. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4706. }
  4707. prebuilt_bootclasspath_fragment {
  4708. name: "my-bootclasspath-fragment",
  4709. contents: ["libfoo", "libbar"],
  4710. apex_available: ["myapex"],
  4711. hidden_api: {
  4712. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4713. metadata: "my-bootclasspath-fragment/metadata.csv",
  4714. index: "my-bootclasspath-fragment/index.csv",
  4715. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4716. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4717. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4718. },
  4719. }
  4720. java_import {
  4721. name: "libfoo",
  4722. jars: ["libfoo.jar"],
  4723. apex_available: ["myapex"],
  4724. }
  4725. java_library {
  4726. name: "libfoo",
  4727. srcs: ["foo/bar/MyClass.java"],
  4728. apex_available: ["myapex"],
  4729. permitted_packages: ["foo"],
  4730. }
  4731. java_sdk_library_import {
  4732. name: "libbar",
  4733. public: {
  4734. jars: ["libbar.jar"],
  4735. },
  4736. apex_available: ["myapex"],
  4737. shared_library: false,
  4738. }
  4739. java_sdk_library {
  4740. name: "libbar",
  4741. srcs: ["foo/bar/MyClass.java"],
  4742. unsafe_ignore_missing_latest_api: true,
  4743. apex_available: ["myapex"],
  4744. permitted_packages: ["bar"],
  4745. }
  4746. `
  4747. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4748. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/libfoo/android_common_apex10000/hiddenapi/libfoo.jar")
  4749. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/libbar/android_common_myapex/hiddenapi/libbar.jar")
  4750. // Verify the correct module jars contribute to the hiddenapi index file.
  4751. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4752. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4753. my-bootclasspath-fragment/index.csv
  4754. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4755. `)
  4756. })
  4757. t.Run("prebuilt preferred with source apex disabled", func(t *testing.T) {
  4758. bp := `
  4759. apex {
  4760. name: "myapex",
  4761. enabled: false,
  4762. key: "myapex.key",
  4763. java_libs: ["libfoo", "libbar"],
  4764. }
  4765. apex_key {
  4766. name: "myapex.key",
  4767. public_key: "testkey.avbpubkey",
  4768. private_key: "testkey.pem",
  4769. }
  4770. prebuilt_apex {
  4771. name: "myapex",
  4772. arch: {
  4773. arm64: {
  4774. src: "myapex-arm64.apex",
  4775. },
  4776. arm: {
  4777. src: "myapex-arm.apex",
  4778. },
  4779. },
  4780. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  4781. }
  4782. prebuilt_bootclasspath_fragment {
  4783. name: "my-bootclasspath-fragment",
  4784. contents: ["libfoo", "libbar"],
  4785. apex_available: ["myapex"],
  4786. hidden_api: {
  4787. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  4788. metadata: "my-bootclasspath-fragment/metadata.csv",
  4789. index: "my-bootclasspath-fragment/index.csv",
  4790. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  4791. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  4792. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  4793. },
  4794. }
  4795. java_import {
  4796. name: "libfoo",
  4797. prefer: true,
  4798. jars: ["libfoo.jar"],
  4799. apex_available: ["myapex"],
  4800. permitted_packages: ["foo"],
  4801. }
  4802. java_library {
  4803. name: "libfoo",
  4804. srcs: ["foo/bar/MyClass.java"],
  4805. apex_available: ["myapex"],
  4806. }
  4807. java_sdk_library_import {
  4808. name: "libbar",
  4809. prefer: true,
  4810. public: {
  4811. jars: ["libbar.jar"],
  4812. },
  4813. apex_available: ["myapex"],
  4814. shared_library: false,
  4815. permitted_packages: ["bar"],
  4816. }
  4817. java_sdk_library {
  4818. name: "libbar",
  4819. srcs: ["foo/bar/MyClass.java"],
  4820. unsafe_ignore_missing_latest_api: true,
  4821. apex_available: ["myapex"],
  4822. }
  4823. `
  4824. ctx := testDexpreoptWithApexes(t, bp, "", preparer, fragment)
  4825. checkBootDexJarPath(t, ctx, "libfoo", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libfoo.jar")
  4826. checkBootDexJarPath(t, ctx, "libbar", "out/soong/.intermediates/myapex.deapexer/android_common/deapexer/javalib/libbar.jar")
  4827. // Verify the correct module jars contribute to the hiddenapi index file.
  4828. checkHiddenAPIIndexFromClassesInputs(t, ctx, ``)
  4829. checkHiddenAPIIndexFromFlagsInputs(t, ctx, `
  4830. my-bootclasspath-fragment/index.csv
  4831. out/soong/.intermediates/frameworks/base/boot/platform-bootclasspath/android_common/hiddenapi-monolithic/index-from-classes.csv
  4832. `)
  4833. })
  4834. }
  4835. func TestApexWithTests(t *testing.T) {
  4836. ctx := testApex(t, `
  4837. apex_test {
  4838. name: "myapex",
  4839. key: "myapex.key",
  4840. updatable: false,
  4841. tests: [
  4842. "mytest",
  4843. "mytests",
  4844. ],
  4845. }
  4846. apex_key {
  4847. name: "myapex.key",
  4848. public_key: "testkey.avbpubkey",
  4849. private_key: "testkey.pem",
  4850. }
  4851. filegroup {
  4852. name: "fg",
  4853. srcs: [
  4854. "baz",
  4855. "bar/baz"
  4856. ],
  4857. }
  4858. cc_test {
  4859. name: "mytest",
  4860. gtest: false,
  4861. srcs: ["mytest.cpp"],
  4862. relative_install_path: "test",
  4863. shared_libs: ["mylib"],
  4864. system_shared_libs: [],
  4865. static_executable: true,
  4866. stl: "none",
  4867. data: [":fg"],
  4868. }
  4869. cc_library {
  4870. name: "mylib",
  4871. srcs: ["mylib.cpp"],
  4872. system_shared_libs: [],
  4873. stl: "none",
  4874. }
  4875. filegroup {
  4876. name: "fg2",
  4877. srcs: [
  4878. "testdata/baz"
  4879. ],
  4880. }
  4881. cc_test {
  4882. name: "mytests",
  4883. gtest: false,
  4884. srcs: [
  4885. "mytest1.cpp",
  4886. "mytest2.cpp",
  4887. "mytest3.cpp",
  4888. ],
  4889. test_per_src: true,
  4890. relative_install_path: "test",
  4891. system_shared_libs: [],
  4892. static_executable: true,
  4893. stl: "none",
  4894. data: [
  4895. ":fg",
  4896. ":fg2",
  4897. ],
  4898. }
  4899. `)
  4900. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  4901. copyCmds := apexRule.Args["copy_commands"]
  4902. // Ensure that test dep (and their transitive dependencies) are copied into apex.
  4903. ensureContains(t, copyCmds, "image.apex/bin/test/mytest")
  4904. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  4905. //Ensure that test data are copied into apex.
  4906. ensureContains(t, copyCmds, "image.apex/bin/test/baz")
  4907. ensureContains(t, copyCmds, "image.apex/bin/test/bar/baz")
  4908. // Ensure that test deps built with `test_per_src` are copied into apex.
  4909. ensureContains(t, copyCmds, "image.apex/bin/test/mytest1")
  4910. ensureContains(t, copyCmds, "image.apex/bin/test/mytest2")
  4911. ensureContains(t, copyCmds, "image.apex/bin/test/mytest3")
  4912. // Ensure the module is correctly translated.
  4913. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4914. data := android.AndroidMkDataForTest(t, ctx, bundle)
  4915. name := bundle.BaseModuleName()
  4916. prefix := "TARGET_"
  4917. var builder strings.Builder
  4918. data.Custom(&builder, name, prefix, "", data)
  4919. androidMk := builder.String()
  4920. ensureContains(t, androidMk, "LOCAL_MODULE := mytest.myapex\n")
  4921. ensureContains(t, androidMk, "LOCAL_MODULE := mytest1.myapex\n")
  4922. ensureContains(t, androidMk, "LOCAL_MODULE := mytest2.myapex\n")
  4923. ensureContains(t, androidMk, "LOCAL_MODULE := mytest3.myapex\n")
  4924. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex\n")
  4925. ensureContains(t, androidMk, "LOCAL_MODULE := apex_pubkey.myapex\n")
  4926. ensureContains(t, androidMk, "LOCAL_MODULE := myapex\n")
  4927. flatBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  4928. data = android.AndroidMkDataForTest(t, ctx, flatBundle)
  4929. data.Custom(&builder, name, prefix, "", data)
  4930. flatAndroidMk := builder.String()
  4931. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :baz :bar/baz\n")
  4932. ensureContainsOnce(t, flatAndroidMk, "LOCAL_TEST_DATA := :testdata/baz\n")
  4933. }
  4934. func TestInstallExtraFlattenedApexes(t *testing.T) {
  4935. ctx := testApex(t, `
  4936. apex {
  4937. name: "myapex",
  4938. key: "myapex.key",
  4939. updatable: false,
  4940. }
  4941. apex_key {
  4942. name: "myapex.key",
  4943. public_key: "testkey.avbpubkey",
  4944. private_key: "testkey.pem",
  4945. }
  4946. `,
  4947. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  4948. variables.InstallExtraFlattenedApexes = proptools.BoolPtr(true)
  4949. }),
  4950. )
  4951. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  4952. ensureListContains(t, ab.requiredDeps, "myapex.flattened")
  4953. mk := android.AndroidMkDataForTest(t, ctx, ab)
  4954. var builder strings.Builder
  4955. mk.Custom(&builder, ab.Name(), "TARGET_", "", mk)
  4956. androidMk := builder.String()
  4957. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += myapex.flattened")
  4958. }
  4959. func TestErrorsIfDepsAreNotEnabled(t *testing.T) {
  4960. testApexError(t, `module "myapex" .* depends on disabled module "libfoo"`, `
  4961. apex {
  4962. name: "myapex",
  4963. key: "myapex.key",
  4964. native_shared_libs: ["libfoo"],
  4965. }
  4966. apex_key {
  4967. name: "myapex.key",
  4968. public_key: "testkey.avbpubkey",
  4969. private_key: "testkey.pem",
  4970. }
  4971. cc_library {
  4972. name: "libfoo",
  4973. stl: "none",
  4974. system_shared_libs: [],
  4975. enabled: false,
  4976. apex_available: ["myapex"],
  4977. }
  4978. `)
  4979. testApexError(t, `module "myapex" .* depends on disabled module "myjar"`, `
  4980. apex {
  4981. name: "myapex",
  4982. key: "myapex.key",
  4983. java_libs: ["myjar"],
  4984. }
  4985. apex_key {
  4986. name: "myapex.key",
  4987. public_key: "testkey.avbpubkey",
  4988. private_key: "testkey.pem",
  4989. }
  4990. java_library {
  4991. name: "myjar",
  4992. srcs: ["foo/bar/MyClass.java"],
  4993. sdk_version: "none",
  4994. system_modules: "none",
  4995. enabled: false,
  4996. apex_available: ["myapex"],
  4997. }
  4998. `)
  4999. }
  5000. func TestApexWithJavaImport(t *testing.T) {
  5001. ctx := testApex(t, `
  5002. apex {
  5003. name: "myapex",
  5004. key: "myapex.key",
  5005. java_libs: ["myjavaimport"],
  5006. updatable: false,
  5007. }
  5008. apex_key {
  5009. name: "myapex.key",
  5010. public_key: "testkey.avbpubkey",
  5011. private_key: "testkey.pem",
  5012. }
  5013. java_import {
  5014. name: "myjavaimport",
  5015. apex_available: ["myapex"],
  5016. jars: ["my.jar"],
  5017. compile_dex: true,
  5018. }
  5019. `)
  5020. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5021. apexRule := module.Rule("apexRule")
  5022. copyCmds := apexRule.Args["copy_commands"]
  5023. ensureContains(t, copyCmds, "image.apex/javalib/myjavaimport.jar")
  5024. }
  5025. func TestApexWithApps(t *testing.T) {
  5026. ctx := testApex(t, `
  5027. apex {
  5028. name: "myapex",
  5029. key: "myapex.key",
  5030. apps: [
  5031. "AppFoo",
  5032. "AppFooPriv",
  5033. ],
  5034. updatable: false,
  5035. }
  5036. apex_key {
  5037. name: "myapex.key",
  5038. public_key: "testkey.avbpubkey",
  5039. private_key: "testkey.pem",
  5040. }
  5041. android_app {
  5042. name: "AppFoo",
  5043. srcs: ["foo/bar/MyClass.java"],
  5044. sdk_version: "current",
  5045. system_modules: "none",
  5046. jni_libs: ["libjni"],
  5047. stl: "none",
  5048. apex_available: [ "myapex" ],
  5049. }
  5050. android_app {
  5051. name: "AppFooPriv",
  5052. srcs: ["foo/bar/MyClass.java"],
  5053. sdk_version: "current",
  5054. system_modules: "none",
  5055. privileged: true,
  5056. stl: "none",
  5057. apex_available: [ "myapex" ],
  5058. }
  5059. cc_library_shared {
  5060. name: "libjni",
  5061. srcs: ["mylib.cpp"],
  5062. shared_libs: ["libfoo"],
  5063. stl: "none",
  5064. system_shared_libs: [],
  5065. apex_available: [ "myapex" ],
  5066. sdk_version: "current",
  5067. }
  5068. cc_library_shared {
  5069. name: "libfoo",
  5070. stl: "none",
  5071. system_shared_libs: [],
  5072. apex_available: [ "myapex" ],
  5073. sdk_version: "current",
  5074. }
  5075. `)
  5076. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5077. apexRule := module.Rule("apexRule")
  5078. copyCmds := apexRule.Args["copy_commands"]
  5079. ensureContains(t, copyCmds, "image.apex/app/AppFoo@TEST.BUILD_ID/AppFoo.apk")
  5080. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPriv@TEST.BUILD_ID/AppFooPriv.apk")
  5081. appZipRule := ctx.ModuleForTests("AppFoo", "android_common_apex10000").Description("zip jni libs")
  5082. // JNI libraries are uncompressed
  5083. if args := appZipRule.Args["jarArgs"]; !strings.Contains(args, "-L 0") {
  5084. t.Errorf("jni libs are not uncompressed for AppFoo")
  5085. }
  5086. // JNI libraries including transitive deps are
  5087. for _, jni := range []string{"libjni", "libfoo"} {
  5088. jniOutput := ctx.ModuleForTests(jni, "android_arm64_armv8-a_sdk_shared_apex10000").Module().(*cc.Module).OutputFile().RelativeToTop()
  5089. // ... embedded inside APK (jnilibs.zip)
  5090. ensureListContains(t, appZipRule.Implicits.Strings(), jniOutput.String())
  5091. // ... and not directly inside the APEX
  5092. ensureNotContains(t, copyCmds, "image.apex/lib64/"+jni+".so")
  5093. }
  5094. }
  5095. func TestApexWithAppImportBuildId(t *testing.T) {
  5096. invalidBuildIds := []string{"../", "a b", "a/b", "a/b/../c", "/a"}
  5097. for _, id := range invalidBuildIds {
  5098. message := fmt.Sprintf("Unable to use build id %s as filename suffix", id)
  5099. fixture := android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  5100. variables.BuildId = proptools.StringPtr(id)
  5101. })
  5102. testApexError(t, message, `apex {
  5103. name: "myapex",
  5104. key: "myapex.key",
  5105. apps: ["AppFooPrebuilt"],
  5106. updatable: false,
  5107. }
  5108. apex_key {
  5109. name: "myapex.key",
  5110. public_key: "testkey.avbpubkey",
  5111. private_key: "testkey.pem",
  5112. }
  5113. android_app_import {
  5114. name: "AppFooPrebuilt",
  5115. apk: "PrebuiltAppFoo.apk",
  5116. presigned: true,
  5117. apex_available: ["myapex"],
  5118. }
  5119. `, fixture)
  5120. }
  5121. }
  5122. func TestApexWithAppImports(t *testing.T) {
  5123. ctx := testApex(t, `
  5124. apex {
  5125. name: "myapex",
  5126. key: "myapex.key",
  5127. apps: [
  5128. "AppFooPrebuilt",
  5129. "AppFooPrivPrebuilt",
  5130. ],
  5131. updatable: false,
  5132. }
  5133. apex_key {
  5134. name: "myapex.key",
  5135. public_key: "testkey.avbpubkey",
  5136. private_key: "testkey.pem",
  5137. }
  5138. android_app_import {
  5139. name: "AppFooPrebuilt",
  5140. apk: "PrebuiltAppFoo.apk",
  5141. presigned: true,
  5142. dex_preopt: {
  5143. enabled: false,
  5144. },
  5145. apex_available: ["myapex"],
  5146. }
  5147. android_app_import {
  5148. name: "AppFooPrivPrebuilt",
  5149. apk: "PrebuiltAppFooPriv.apk",
  5150. privileged: true,
  5151. presigned: true,
  5152. dex_preopt: {
  5153. enabled: false,
  5154. },
  5155. filename: "AwesomePrebuiltAppFooPriv.apk",
  5156. apex_available: ["myapex"],
  5157. }
  5158. `)
  5159. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5160. apexRule := module.Rule("apexRule")
  5161. copyCmds := apexRule.Args["copy_commands"]
  5162. ensureContains(t, copyCmds, "image.apex/app/AppFooPrebuilt@TEST.BUILD_ID/AppFooPrebuilt.apk")
  5163. ensureContains(t, copyCmds, "image.apex/priv-app/AppFooPrivPrebuilt@TEST.BUILD_ID/AwesomePrebuiltAppFooPriv.apk")
  5164. }
  5165. func TestApexWithAppImportsPrefer(t *testing.T) {
  5166. ctx := testApex(t, `
  5167. apex {
  5168. name: "myapex",
  5169. key: "myapex.key",
  5170. apps: [
  5171. "AppFoo",
  5172. ],
  5173. updatable: false,
  5174. }
  5175. apex_key {
  5176. name: "myapex.key",
  5177. public_key: "testkey.avbpubkey",
  5178. private_key: "testkey.pem",
  5179. }
  5180. android_app {
  5181. name: "AppFoo",
  5182. srcs: ["foo/bar/MyClass.java"],
  5183. sdk_version: "none",
  5184. system_modules: "none",
  5185. apex_available: [ "myapex" ],
  5186. }
  5187. android_app_import {
  5188. name: "AppFoo",
  5189. apk: "AppFooPrebuilt.apk",
  5190. filename: "AppFooPrebuilt.apk",
  5191. presigned: true,
  5192. prefer: true,
  5193. apex_available: ["myapex"],
  5194. }
  5195. `, withFiles(map[string][]byte{
  5196. "AppFooPrebuilt.apk": nil,
  5197. }))
  5198. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5199. "app/AppFoo@TEST.BUILD_ID/AppFooPrebuilt.apk",
  5200. })
  5201. }
  5202. func TestApexWithTestHelperApp(t *testing.T) {
  5203. ctx := testApex(t, `
  5204. apex {
  5205. name: "myapex",
  5206. key: "myapex.key",
  5207. apps: [
  5208. "TesterHelpAppFoo",
  5209. ],
  5210. updatable: false,
  5211. }
  5212. apex_key {
  5213. name: "myapex.key",
  5214. public_key: "testkey.avbpubkey",
  5215. private_key: "testkey.pem",
  5216. }
  5217. android_test_helper_app {
  5218. name: "TesterHelpAppFoo",
  5219. srcs: ["foo/bar/MyClass.java"],
  5220. apex_available: [ "myapex" ],
  5221. }
  5222. `)
  5223. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5224. apexRule := module.Rule("apexRule")
  5225. copyCmds := apexRule.Args["copy_commands"]
  5226. ensureContains(t, copyCmds, "image.apex/app/TesterHelpAppFoo@TEST.BUILD_ID/TesterHelpAppFoo.apk")
  5227. }
  5228. func TestApexPropertiesShouldBeDefaultable(t *testing.T) {
  5229. // libfoo's apex_available comes from cc_defaults
  5230. testApexError(t, `requires "libfoo" that doesn't list the APEX under 'apex_available'.`, `
  5231. apex {
  5232. name: "myapex",
  5233. key: "myapex.key",
  5234. native_shared_libs: ["libfoo"],
  5235. updatable: false,
  5236. }
  5237. apex_key {
  5238. name: "myapex.key",
  5239. public_key: "testkey.avbpubkey",
  5240. private_key: "testkey.pem",
  5241. }
  5242. apex {
  5243. name: "otherapex",
  5244. key: "myapex.key",
  5245. native_shared_libs: ["libfoo"],
  5246. updatable: false,
  5247. }
  5248. cc_defaults {
  5249. name: "libfoo-defaults",
  5250. apex_available: ["otherapex"],
  5251. }
  5252. cc_library {
  5253. name: "libfoo",
  5254. defaults: ["libfoo-defaults"],
  5255. stl: "none",
  5256. system_shared_libs: [],
  5257. }`)
  5258. }
  5259. func TestApexAvailable_DirectDep(t *testing.T) {
  5260. // libfoo is not available to myapex, but only to otherapex
  5261. testApexError(t, "requires \"libfoo\" that doesn't list the APEX under 'apex_available'.", `
  5262. apex {
  5263. name: "myapex",
  5264. key: "myapex.key",
  5265. native_shared_libs: ["libfoo"],
  5266. updatable: false,
  5267. }
  5268. apex_key {
  5269. name: "myapex.key",
  5270. public_key: "testkey.avbpubkey",
  5271. private_key: "testkey.pem",
  5272. }
  5273. apex {
  5274. name: "otherapex",
  5275. key: "otherapex.key",
  5276. native_shared_libs: ["libfoo"],
  5277. updatable: false,
  5278. }
  5279. apex_key {
  5280. name: "otherapex.key",
  5281. public_key: "testkey.avbpubkey",
  5282. private_key: "testkey.pem",
  5283. }
  5284. cc_library {
  5285. name: "libfoo",
  5286. stl: "none",
  5287. system_shared_libs: [],
  5288. apex_available: ["otherapex"],
  5289. }`)
  5290. }
  5291. func TestApexAvailable_IndirectDep(t *testing.T) {
  5292. // libbbaz is an indirect dep
  5293. testApexError(t, `requires "libbaz" that doesn't list the APEX under 'apex_available'.\n\nDependency path:
  5294. .*via tag apex\.dependencyTag\{"sharedLib"\}
  5295. .*-> libfoo.*link:shared.*
  5296. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5297. .*-> libbar.*link:shared.*
  5298. .*via tag cc\.libraryDependencyTag.*Kind:sharedLibraryDependency.*
  5299. .*-> libbaz.*link:shared.*`, `
  5300. apex {
  5301. name: "myapex",
  5302. key: "myapex.key",
  5303. native_shared_libs: ["libfoo"],
  5304. updatable: false,
  5305. }
  5306. apex_key {
  5307. name: "myapex.key",
  5308. public_key: "testkey.avbpubkey",
  5309. private_key: "testkey.pem",
  5310. }
  5311. cc_library {
  5312. name: "libfoo",
  5313. stl: "none",
  5314. shared_libs: ["libbar"],
  5315. system_shared_libs: [],
  5316. apex_available: ["myapex"],
  5317. }
  5318. cc_library {
  5319. name: "libbar",
  5320. stl: "none",
  5321. shared_libs: ["libbaz"],
  5322. system_shared_libs: [],
  5323. apex_available: ["myapex"],
  5324. }
  5325. cc_library {
  5326. name: "libbaz",
  5327. stl: "none",
  5328. system_shared_libs: [],
  5329. }`)
  5330. }
  5331. func TestApexAvailable_InvalidApexName(t *testing.T) {
  5332. testApexError(t, "\"otherapex\" is not a valid module name", `
  5333. apex {
  5334. name: "myapex",
  5335. key: "myapex.key",
  5336. native_shared_libs: ["libfoo"],
  5337. updatable: false,
  5338. }
  5339. apex_key {
  5340. name: "myapex.key",
  5341. public_key: "testkey.avbpubkey",
  5342. private_key: "testkey.pem",
  5343. }
  5344. cc_library {
  5345. name: "libfoo",
  5346. stl: "none",
  5347. system_shared_libs: [],
  5348. apex_available: ["otherapex"],
  5349. }`)
  5350. testApex(t, `
  5351. apex {
  5352. name: "myapex",
  5353. key: "myapex.key",
  5354. native_shared_libs: ["libfoo", "libbar"],
  5355. updatable: false,
  5356. }
  5357. apex_key {
  5358. name: "myapex.key",
  5359. public_key: "testkey.avbpubkey",
  5360. private_key: "testkey.pem",
  5361. }
  5362. cc_library {
  5363. name: "libfoo",
  5364. stl: "none",
  5365. system_shared_libs: [],
  5366. runtime_libs: ["libbaz"],
  5367. apex_available: ["myapex"],
  5368. }
  5369. cc_library {
  5370. name: "libbar",
  5371. stl: "none",
  5372. system_shared_libs: [],
  5373. apex_available: ["//apex_available:anyapex"],
  5374. }
  5375. cc_library {
  5376. name: "libbaz",
  5377. stl: "none",
  5378. system_shared_libs: [],
  5379. stubs: {
  5380. versions: ["10", "20", "30"],
  5381. },
  5382. }`)
  5383. }
  5384. func TestApexAvailable_CheckForPlatform(t *testing.T) {
  5385. ctx := testApex(t, `
  5386. apex {
  5387. name: "myapex",
  5388. key: "myapex.key",
  5389. native_shared_libs: ["libbar", "libbaz"],
  5390. updatable: false,
  5391. }
  5392. apex_key {
  5393. name: "myapex.key",
  5394. public_key: "testkey.avbpubkey",
  5395. private_key: "testkey.pem",
  5396. }
  5397. cc_library {
  5398. name: "libfoo",
  5399. stl: "none",
  5400. system_shared_libs: [],
  5401. shared_libs: ["libbar"],
  5402. apex_available: ["//apex_available:platform"],
  5403. }
  5404. cc_library {
  5405. name: "libfoo2",
  5406. stl: "none",
  5407. system_shared_libs: [],
  5408. shared_libs: ["libbaz"],
  5409. apex_available: ["//apex_available:platform"],
  5410. }
  5411. cc_library {
  5412. name: "libbar",
  5413. stl: "none",
  5414. system_shared_libs: [],
  5415. apex_available: ["myapex"],
  5416. }
  5417. cc_library {
  5418. name: "libbaz",
  5419. stl: "none",
  5420. system_shared_libs: [],
  5421. apex_available: ["myapex"],
  5422. stubs: {
  5423. versions: ["1"],
  5424. },
  5425. }`)
  5426. // libfoo shouldn't be available to platform even though it has "//apex_available:platform",
  5427. // because it depends on libbar which isn't available to platform
  5428. libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5429. if libfoo.NotAvailableForPlatform() != true {
  5430. t.Errorf("%q shouldn't be available to platform", libfoo.String())
  5431. }
  5432. // libfoo2 however can be available to platform because it depends on libbaz which provides
  5433. // stubs
  5434. libfoo2 := ctx.ModuleForTests("libfoo2", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5435. if libfoo2.NotAvailableForPlatform() == true {
  5436. t.Errorf("%q should be available to platform", libfoo2.String())
  5437. }
  5438. }
  5439. func TestApexAvailable_CreatedForApex(t *testing.T) {
  5440. ctx := testApex(t, `
  5441. apex {
  5442. name: "myapex",
  5443. key: "myapex.key",
  5444. native_shared_libs: ["libfoo"],
  5445. updatable: false,
  5446. }
  5447. apex_key {
  5448. name: "myapex.key",
  5449. public_key: "testkey.avbpubkey",
  5450. private_key: "testkey.pem",
  5451. }
  5452. cc_library {
  5453. name: "libfoo",
  5454. stl: "none",
  5455. system_shared_libs: [],
  5456. apex_available: ["myapex"],
  5457. static: {
  5458. apex_available: ["//apex_available:platform"],
  5459. },
  5460. }`)
  5461. libfooShared := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_shared").Module().(*cc.Module)
  5462. if libfooShared.NotAvailableForPlatform() != true {
  5463. t.Errorf("%q shouldn't be available to platform", libfooShared.String())
  5464. }
  5465. libfooStatic := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_static").Module().(*cc.Module)
  5466. if libfooStatic.NotAvailableForPlatform() != false {
  5467. t.Errorf("%q should be available to platform", libfooStatic.String())
  5468. }
  5469. }
  5470. func TestOverrideApex(t *testing.T) {
  5471. ctx := testApex(t, `
  5472. apex {
  5473. name: "myapex",
  5474. key: "myapex.key",
  5475. apps: ["app"],
  5476. bpfs: ["bpf"],
  5477. prebuilts: ["myetc"],
  5478. bootclasspath_fragments: ["mybootclasspath_fragment"],
  5479. systemserverclasspath_fragments: ["mysystemserverclasspath_fragment"],
  5480. java_libs: ["myjava_library"],
  5481. overrides: ["oldapex"],
  5482. updatable: false,
  5483. }
  5484. override_apex {
  5485. name: "override_myapex",
  5486. base: "myapex",
  5487. apps: ["override_app"],
  5488. bpfs: ["overrideBpf"],
  5489. prebuilts: ["override_myetc"],
  5490. bootclasspath_fragments: ["override_bootclasspath_fragment"],
  5491. systemserverclasspath_fragments: ["override_systemserverclasspath_fragment"],
  5492. java_libs: ["override_java_library"],
  5493. overrides: ["unknownapex"],
  5494. logging_parent: "com.foo.bar",
  5495. package_name: "test.overridden.package",
  5496. key: "mynewapex.key",
  5497. certificate: ":myapex.certificate",
  5498. }
  5499. apex_key {
  5500. name: "myapex.key",
  5501. public_key: "testkey.avbpubkey",
  5502. private_key: "testkey.pem",
  5503. }
  5504. apex_key {
  5505. name: "mynewapex.key",
  5506. public_key: "testkey2.avbpubkey",
  5507. private_key: "testkey2.pem",
  5508. }
  5509. android_app_certificate {
  5510. name: "myapex.certificate",
  5511. certificate: "testkey",
  5512. }
  5513. android_app {
  5514. name: "app",
  5515. srcs: ["foo/bar/MyClass.java"],
  5516. package_name: "foo",
  5517. sdk_version: "none",
  5518. system_modules: "none",
  5519. apex_available: [ "myapex" ],
  5520. }
  5521. override_android_app {
  5522. name: "override_app",
  5523. base: "app",
  5524. package_name: "bar",
  5525. }
  5526. bpf {
  5527. name: "bpf",
  5528. srcs: ["bpf.c"],
  5529. }
  5530. bpf {
  5531. name: "overrideBpf",
  5532. srcs: ["overrideBpf.c"],
  5533. }
  5534. prebuilt_etc {
  5535. name: "myetc",
  5536. src: "myprebuilt",
  5537. }
  5538. prebuilt_etc {
  5539. name: "override_myetc",
  5540. src: "override_myprebuilt",
  5541. }
  5542. java_library {
  5543. name: "bcplib",
  5544. srcs: ["a.java"],
  5545. compile_dex: true,
  5546. apex_available: ["myapex"],
  5547. permitted_packages: ["bcp.lib"],
  5548. }
  5549. bootclasspath_fragment {
  5550. name: "mybootclasspath_fragment",
  5551. contents: ["bcplib"],
  5552. apex_available: ["myapex"],
  5553. hidden_api: {
  5554. split_packages: ["*"],
  5555. },
  5556. }
  5557. java_library {
  5558. name: "override_bcplib",
  5559. srcs: ["a.java"],
  5560. compile_dex: true,
  5561. apex_available: ["myapex"],
  5562. permitted_packages: ["override.bcp.lib"],
  5563. }
  5564. bootclasspath_fragment {
  5565. name: "override_bootclasspath_fragment",
  5566. contents: ["override_bcplib"],
  5567. apex_available: ["myapex"],
  5568. hidden_api: {
  5569. split_packages: ["*"],
  5570. },
  5571. }
  5572. java_library {
  5573. name: "systemserverlib",
  5574. srcs: ["a.java"],
  5575. apex_available: ["myapex"],
  5576. }
  5577. systemserverclasspath_fragment {
  5578. name: "mysystemserverclasspath_fragment",
  5579. standalone_contents: ["systemserverlib"],
  5580. apex_available: ["myapex"],
  5581. }
  5582. java_library {
  5583. name: "override_systemserverlib",
  5584. srcs: ["a.java"],
  5585. apex_available: ["myapex"],
  5586. }
  5587. systemserverclasspath_fragment {
  5588. name: "override_systemserverclasspath_fragment",
  5589. standalone_contents: ["override_systemserverlib"],
  5590. apex_available: ["myapex"],
  5591. }
  5592. java_library {
  5593. name: "myjava_library",
  5594. srcs: ["a.java"],
  5595. compile_dex: true,
  5596. apex_available: ["myapex"],
  5597. }
  5598. java_library {
  5599. name: "override_java_library",
  5600. srcs: ["a.java"],
  5601. compile_dex: true,
  5602. apex_available: ["myapex"],
  5603. }
  5604. `, withManifestPackageNameOverrides([]string{"myapex:com.android.myapex"}))
  5605. originalVariant := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(android.OverridableModule)
  5606. overriddenVariant := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Module().(android.OverridableModule)
  5607. if originalVariant.GetOverriddenBy() != "" {
  5608. t.Errorf("GetOverriddenBy should be empty, but was %q", originalVariant.GetOverriddenBy())
  5609. }
  5610. if overriddenVariant.GetOverriddenBy() != "override_myapex" {
  5611. t.Errorf("GetOverriddenBy should be \"override_myapex\", but was %q", overriddenVariant.GetOverriddenBy())
  5612. }
  5613. module := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image")
  5614. apexRule := module.Rule("apexRule")
  5615. copyCmds := apexRule.Args["copy_commands"]
  5616. ensureNotContains(t, copyCmds, "image.apex/app/app@TEST.BUILD_ID/app.apk")
  5617. ensureContains(t, copyCmds, "image.apex/app/override_app@TEST.BUILD_ID/override_app.apk")
  5618. ensureNotContains(t, copyCmds, "image.apex/etc/bpf/bpf.o")
  5619. ensureContains(t, copyCmds, "image.apex/etc/bpf/overrideBpf.o")
  5620. ensureNotContains(t, copyCmds, "image.apex/etc/myetc")
  5621. ensureContains(t, copyCmds, "image.apex/etc/override_myetc")
  5622. apexBundle := module.Module().(*apexBundle)
  5623. name := apexBundle.Name()
  5624. if name != "override_myapex" {
  5625. t.Errorf("name should be \"override_myapex\", but was %q", name)
  5626. }
  5627. if apexBundle.overridableProperties.Logging_parent != "com.foo.bar" {
  5628. t.Errorf("override_myapex should have logging parent (com.foo.bar), but was %q.", apexBundle.overridableProperties.Logging_parent)
  5629. }
  5630. android.AssertArrayString(t, "Bootclasspath_fragments does not match",
  5631. []string{"override_bootclasspath_fragment"}, apexBundle.overridableProperties.Bootclasspath_fragments)
  5632. android.AssertArrayString(t, "Systemserverclasspath_fragments does not match",
  5633. []string{"override_systemserverclasspath_fragment"}, apexBundle.overridableProperties.Systemserverclasspath_fragments)
  5634. android.AssertArrayString(t, "Java_libs does not match",
  5635. []string{"override_java_library"}, apexBundle.overridableProperties.Java_libs)
  5636. optFlags := apexRule.Args["opt_flags"]
  5637. ensureContains(t, optFlags, "--override_apk_package_name test.overridden.package")
  5638. ensureContains(t, optFlags, "--pubkey testkey2.avbpubkey")
  5639. signApkRule := module.Rule("signapk")
  5640. ensureEquals(t, signApkRule.Args["certificates"], "testkey.x509.pem testkey.pk8")
  5641. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  5642. var builder strings.Builder
  5643. data.Custom(&builder, name, "TARGET_", "", data)
  5644. androidMk := builder.String()
  5645. ensureContains(t, androidMk, "LOCAL_MODULE := override_app.override_myapex")
  5646. ensureContains(t, androidMk, "LOCAL_MODULE := overrideBpf.o.override_myapex")
  5647. ensureContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.override_myapex")
  5648. ensureContains(t, androidMk, "LOCAL_MODULE := override_bcplib.override_myapex")
  5649. ensureContains(t, androidMk, "LOCAL_MODULE := override_systemserverlib.override_myapex")
  5650. ensureContains(t, androidMk, "LOCAL_MODULE := override_java_library.override_myapex")
  5651. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := override_myapex.apex")
  5652. ensureContains(t, androidMk, "LOCAL_OVERRIDES_MODULES := unknownapex myapex")
  5653. ensureNotContains(t, androidMk, "LOCAL_MODULE := app.myapex")
  5654. ensureNotContains(t, androidMk, "LOCAL_MODULE := bpf.myapex")
  5655. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_app.myapex")
  5656. ensureNotContains(t, androidMk, "LOCAL_MODULE := apex_manifest.pb.myapex")
  5657. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_bcplib.myapex")
  5658. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_systemserverlib.myapex")
  5659. ensureNotContains(t, androidMk, "LOCAL_MODULE := override_java_library.pb.myapex")
  5660. ensureNotContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.apex")
  5661. }
  5662. func TestMinSdkVersionOverride(t *testing.T) {
  5663. // Override from 29 to 31
  5664. minSdkOverride31 := "31"
  5665. ctx := testApex(t, `
  5666. apex {
  5667. name: "myapex",
  5668. key: "myapex.key",
  5669. native_shared_libs: ["mylib"],
  5670. updatable: true,
  5671. min_sdk_version: "29"
  5672. }
  5673. override_apex {
  5674. name: "override_myapex",
  5675. base: "myapex",
  5676. logging_parent: "com.foo.bar",
  5677. package_name: "test.overridden.package"
  5678. }
  5679. apex_key {
  5680. name: "myapex.key",
  5681. public_key: "testkey.avbpubkey",
  5682. private_key: "testkey.pem",
  5683. }
  5684. cc_library {
  5685. name: "mylib",
  5686. srcs: ["mylib.cpp"],
  5687. runtime_libs: ["libbar"],
  5688. system_shared_libs: [],
  5689. stl: "none",
  5690. apex_available: [ "myapex" ],
  5691. min_sdk_version: "apex_inherit"
  5692. }
  5693. cc_library {
  5694. name: "libbar",
  5695. srcs: ["mylib.cpp"],
  5696. system_shared_libs: [],
  5697. stl: "none",
  5698. apex_available: [ "myapex" ],
  5699. min_sdk_version: "apex_inherit"
  5700. }
  5701. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride31))
  5702. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5703. copyCmds := apexRule.Args["copy_commands"]
  5704. // Ensure that direct non-stubs dep is always included
  5705. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5706. // Ensure that runtime_libs dep in included
  5707. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  5708. // Ensure libraries target overridden min_sdk_version value
  5709. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  5710. }
  5711. func TestMinSdkVersionOverrideToLowerVersionNoOp(t *testing.T) {
  5712. // Attempt to override from 31 to 29, should be a NOOP
  5713. minSdkOverride29 := "29"
  5714. ctx := testApex(t, `
  5715. apex {
  5716. name: "myapex",
  5717. key: "myapex.key",
  5718. native_shared_libs: ["mylib"],
  5719. updatable: true,
  5720. min_sdk_version: "31"
  5721. }
  5722. override_apex {
  5723. name: "override_myapex",
  5724. base: "myapex",
  5725. logging_parent: "com.foo.bar",
  5726. package_name: "test.overridden.package"
  5727. }
  5728. apex_key {
  5729. name: "myapex.key",
  5730. public_key: "testkey.avbpubkey",
  5731. private_key: "testkey.pem",
  5732. }
  5733. cc_library {
  5734. name: "mylib",
  5735. srcs: ["mylib.cpp"],
  5736. runtime_libs: ["libbar"],
  5737. system_shared_libs: [],
  5738. stl: "none",
  5739. apex_available: [ "myapex" ],
  5740. min_sdk_version: "apex_inherit"
  5741. }
  5742. cc_library {
  5743. name: "libbar",
  5744. srcs: ["mylib.cpp"],
  5745. system_shared_libs: [],
  5746. stl: "none",
  5747. apex_available: [ "myapex" ],
  5748. min_sdk_version: "apex_inherit"
  5749. }
  5750. `, withApexGlobalMinSdkVersionOverride(&minSdkOverride29))
  5751. apexRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule")
  5752. copyCmds := apexRule.Args["copy_commands"]
  5753. // Ensure that direct non-stubs dep is always included
  5754. ensureContains(t, copyCmds, "image.apex/lib64/mylib.so")
  5755. // Ensure that runtime_libs dep in included
  5756. ensureContains(t, copyCmds, "image.apex/lib64/libbar.so")
  5757. // Ensure libraries target the original min_sdk_version value rather than the overridden
  5758. ensureListContains(t, ctx.ModuleVariantsForTests("libbar"), "android_arm64_armv8-a_shared_apex31")
  5759. }
  5760. func TestLegacyAndroid10Support(t *testing.T) {
  5761. ctx := testApex(t, `
  5762. apex {
  5763. name: "myapex",
  5764. key: "myapex.key",
  5765. native_shared_libs: ["mylib"],
  5766. min_sdk_version: "29",
  5767. }
  5768. apex_key {
  5769. name: "myapex.key",
  5770. public_key: "testkey.avbpubkey",
  5771. private_key: "testkey.pem",
  5772. }
  5773. cc_library {
  5774. name: "mylib",
  5775. srcs: ["mylib.cpp"],
  5776. stl: "libc++",
  5777. system_shared_libs: [],
  5778. apex_available: [ "myapex" ],
  5779. min_sdk_version: "29",
  5780. }
  5781. `, withUnbundledBuild)
  5782. module := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  5783. args := module.Rule("apexRule").Args
  5784. ensureContains(t, args["opt_flags"], "--manifest_json "+module.Output("apex_manifest.json").Output.String())
  5785. ensureNotContains(t, args["opt_flags"], "--no_hashtree")
  5786. // The copies of the libraries in the apex should have one more dependency than
  5787. // the ones outside the apex, namely the unwinder. Ideally we should check
  5788. // the dependency names directly here but for some reason the names are blank in
  5789. // this test.
  5790. for _, lib := range []string{"libc++", "mylib"} {
  5791. apexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared_apex29").Rule("ld").Implicits
  5792. nonApexImplicits := ctx.ModuleForTests(lib, "android_arm64_armv8-a_shared").Rule("ld").Implicits
  5793. if len(apexImplicits) != len(nonApexImplicits)+1 {
  5794. t.Errorf("%q missing unwinder dep", lib)
  5795. }
  5796. }
  5797. }
  5798. var filesForSdkLibrary = android.MockFS{
  5799. "api/current.txt": nil,
  5800. "api/removed.txt": nil,
  5801. "api/system-current.txt": nil,
  5802. "api/system-removed.txt": nil,
  5803. "api/test-current.txt": nil,
  5804. "api/test-removed.txt": nil,
  5805. "100/public/api/foo.txt": nil,
  5806. "100/public/api/foo-removed.txt": nil,
  5807. "100/system/api/foo.txt": nil,
  5808. "100/system/api/foo-removed.txt": nil,
  5809. // For java_sdk_library_import
  5810. "a.jar": nil,
  5811. }
  5812. func TestJavaSDKLibrary(t *testing.T) {
  5813. ctx := testApex(t, `
  5814. apex {
  5815. name: "myapex",
  5816. key: "myapex.key",
  5817. java_libs: ["foo"],
  5818. updatable: false,
  5819. }
  5820. apex_key {
  5821. name: "myapex.key",
  5822. public_key: "testkey.avbpubkey",
  5823. private_key: "testkey.pem",
  5824. }
  5825. java_sdk_library {
  5826. name: "foo",
  5827. srcs: ["a.java"],
  5828. api_packages: ["foo"],
  5829. apex_available: [ "myapex" ],
  5830. }
  5831. prebuilt_apis {
  5832. name: "sdk",
  5833. api_dirs: ["100"],
  5834. }
  5835. `, withFiles(filesForSdkLibrary))
  5836. // java_sdk_library installs both impl jar and permission XML
  5837. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5838. "javalib/foo.jar",
  5839. "etc/permissions/foo.xml",
  5840. })
  5841. // Permission XML should point to the activated path of impl jar of java_sdk_library
  5842. sdkLibrary := ctx.ModuleForTests("foo.xml", "android_common_myapex").Rule("java_sdk_xml")
  5843. ensureMatches(t, sdkLibrary.RuleParams.Command, `<library\\n\s+name=\\\"foo\\\"\\n\s+file=\\\"/apex/myapex/javalib/foo.jar\\\"`)
  5844. }
  5845. func TestJavaSDKLibrary_WithinApex(t *testing.T) {
  5846. ctx := testApex(t, `
  5847. apex {
  5848. name: "myapex",
  5849. key: "myapex.key",
  5850. java_libs: ["foo", "bar"],
  5851. updatable: false,
  5852. }
  5853. apex_key {
  5854. name: "myapex.key",
  5855. public_key: "testkey.avbpubkey",
  5856. private_key: "testkey.pem",
  5857. }
  5858. java_sdk_library {
  5859. name: "foo",
  5860. srcs: ["a.java"],
  5861. api_packages: ["foo"],
  5862. apex_available: ["myapex"],
  5863. sdk_version: "none",
  5864. system_modules: "none",
  5865. }
  5866. java_library {
  5867. name: "bar",
  5868. srcs: ["a.java"],
  5869. libs: ["foo"],
  5870. apex_available: ["myapex"],
  5871. sdk_version: "none",
  5872. system_modules: "none",
  5873. }
  5874. prebuilt_apis {
  5875. name: "sdk",
  5876. api_dirs: ["100"],
  5877. }
  5878. `, withFiles(filesForSdkLibrary))
  5879. // java_sdk_library installs both impl jar and permission XML
  5880. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5881. "javalib/bar.jar",
  5882. "javalib/foo.jar",
  5883. "etc/permissions/foo.xml",
  5884. })
  5885. // The bar library should depend on the implementation jar.
  5886. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  5887. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5888. t.Errorf("expected %q, found %#q", expected, actual)
  5889. }
  5890. }
  5891. func TestJavaSDKLibrary_CrossBoundary(t *testing.T) {
  5892. ctx := testApex(t, `
  5893. apex {
  5894. name: "myapex",
  5895. key: "myapex.key",
  5896. java_libs: ["foo"],
  5897. updatable: false,
  5898. }
  5899. apex_key {
  5900. name: "myapex.key",
  5901. public_key: "testkey.avbpubkey",
  5902. private_key: "testkey.pem",
  5903. }
  5904. java_sdk_library {
  5905. name: "foo",
  5906. srcs: ["a.java"],
  5907. api_packages: ["foo"],
  5908. apex_available: ["myapex"],
  5909. sdk_version: "none",
  5910. system_modules: "none",
  5911. }
  5912. java_library {
  5913. name: "bar",
  5914. srcs: ["a.java"],
  5915. libs: ["foo"],
  5916. sdk_version: "none",
  5917. system_modules: "none",
  5918. }
  5919. prebuilt_apis {
  5920. name: "sdk",
  5921. api_dirs: ["100"],
  5922. }
  5923. `, withFiles(filesForSdkLibrary))
  5924. // java_sdk_library installs both impl jar and permission XML
  5925. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  5926. "javalib/foo.jar",
  5927. "etc/permissions/foo.xml",
  5928. })
  5929. // The bar library should depend on the stubs jar.
  5930. barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
  5931. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  5932. t.Errorf("expected %q, found %#q", expected, actual)
  5933. }
  5934. }
  5935. func TestJavaSDKLibrary_ImportPreferred(t *testing.T) {
  5936. ctx := testApex(t, `
  5937. prebuilt_apis {
  5938. name: "sdk",
  5939. api_dirs: ["100"],
  5940. }`,
  5941. withFiles(map[string][]byte{
  5942. "apex/a.java": nil,
  5943. "apex/apex_manifest.json": nil,
  5944. "apex/Android.bp": []byte(`
  5945. package {
  5946. default_visibility: ["//visibility:private"],
  5947. }
  5948. apex {
  5949. name: "myapex",
  5950. key: "myapex.key",
  5951. java_libs: ["foo", "bar"],
  5952. updatable: false,
  5953. }
  5954. apex_key {
  5955. name: "myapex.key",
  5956. public_key: "testkey.avbpubkey",
  5957. private_key: "testkey.pem",
  5958. }
  5959. java_library {
  5960. name: "bar",
  5961. srcs: ["a.java"],
  5962. libs: ["foo"],
  5963. apex_available: ["myapex"],
  5964. sdk_version: "none",
  5965. system_modules: "none",
  5966. }
  5967. `),
  5968. "source/a.java": nil,
  5969. "source/api/current.txt": nil,
  5970. "source/api/removed.txt": nil,
  5971. "source/Android.bp": []byte(`
  5972. package {
  5973. default_visibility: ["//visibility:private"],
  5974. }
  5975. java_sdk_library {
  5976. name: "foo",
  5977. visibility: ["//apex"],
  5978. srcs: ["a.java"],
  5979. api_packages: ["foo"],
  5980. apex_available: ["myapex"],
  5981. sdk_version: "none",
  5982. system_modules: "none",
  5983. public: {
  5984. enabled: true,
  5985. },
  5986. }
  5987. `),
  5988. "prebuilt/a.jar": nil,
  5989. "prebuilt/Android.bp": []byte(`
  5990. package {
  5991. default_visibility: ["//visibility:private"],
  5992. }
  5993. java_sdk_library_import {
  5994. name: "foo",
  5995. visibility: ["//apex", "//source"],
  5996. apex_available: ["myapex"],
  5997. prefer: true,
  5998. public: {
  5999. jars: ["a.jar"],
  6000. },
  6001. }
  6002. `),
  6003. }), withFiles(filesForSdkLibrary),
  6004. )
  6005. // java_sdk_library installs both impl jar and permission XML
  6006. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6007. "javalib/bar.jar",
  6008. "javalib/foo.jar",
  6009. "etc/permissions/foo.xml",
  6010. })
  6011. // The bar library should depend on the implementation jar.
  6012. barLibrary := ctx.ModuleForTests("bar", "android_common_myapex").Rule("javac")
  6013. if expected, actual := `^-classpath [^:]*/turbine-combined/foo\.impl\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
  6014. t.Errorf("expected %q, found %#q", expected, actual)
  6015. }
  6016. }
  6017. func TestJavaSDKLibrary_ImportOnly(t *testing.T) {
  6018. testApexError(t, `java_libs: "foo" is not configured to be compiled into dex`, `
  6019. apex {
  6020. name: "myapex",
  6021. key: "myapex.key",
  6022. java_libs: ["foo"],
  6023. updatable: false,
  6024. }
  6025. apex_key {
  6026. name: "myapex.key",
  6027. public_key: "testkey.avbpubkey",
  6028. private_key: "testkey.pem",
  6029. }
  6030. java_sdk_library_import {
  6031. name: "foo",
  6032. apex_available: ["myapex"],
  6033. prefer: true,
  6034. public: {
  6035. jars: ["a.jar"],
  6036. },
  6037. }
  6038. `, withFiles(filesForSdkLibrary))
  6039. }
  6040. func TestCompatConfig(t *testing.T) {
  6041. result := android.GroupFixturePreparers(
  6042. prepareForApexTest,
  6043. java.PrepareForTestWithPlatformCompatConfig,
  6044. ).RunTestWithBp(t, `
  6045. apex {
  6046. name: "myapex",
  6047. key: "myapex.key",
  6048. compat_configs: ["myjar-platform-compat-config"],
  6049. java_libs: ["myjar"],
  6050. updatable: false,
  6051. }
  6052. apex_key {
  6053. name: "myapex.key",
  6054. public_key: "testkey.avbpubkey",
  6055. private_key: "testkey.pem",
  6056. }
  6057. platform_compat_config {
  6058. name: "myjar-platform-compat-config",
  6059. src: ":myjar",
  6060. }
  6061. java_library {
  6062. name: "myjar",
  6063. srcs: ["foo/bar/MyClass.java"],
  6064. sdk_version: "none",
  6065. system_modules: "none",
  6066. apex_available: [ "myapex" ],
  6067. }
  6068. // Make sure that a preferred prebuilt does not affect the apex contents.
  6069. prebuilt_platform_compat_config {
  6070. name: "myjar-platform-compat-config",
  6071. metadata: "compat-config/metadata.xml",
  6072. prefer: true,
  6073. }
  6074. `)
  6075. ctx := result.TestContext
  6076. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6077. "etc/compatconfig/myjar-platform-compat-config.xml",
  6078. "javalib/myjar.jar",
  6079. })
  6080. }
  6081. func TestRejectNonInstallableJavaLibrary(t *testing.T) {
  6082. testApexError(t, `"myjar" is not configured to be compiled into dex`, `
  6083. apex {
  6084. name: "myapex",
  6085. key: "myapex.key",
  6086. java_libs: ["myjar"],
  6087. updatable: false,
  6088. }
  6089. apex_key {
  6090. name: "myapex.key",
  6091. public_key: "testkey.avbpubkey",
  6092. private_key: "testkey.pem",
  6093. }
  6094. java_library {
  6095. name: "myjar",
  6096. srcs: ["foo/bar/MyClass.java"],
  6097. sdk_version: "none",
  6098. system_modules: "none",
  6099. compile_dex: false,
  6100. apex_available: ["myapex"],
  6101. }
  6102. `)
  6103. }
  6104. func TestCarryRequiredModuleNames(t *testing.T) {
  6105. ctx := testApex(t, `
  6106. apex {
  6107. name: "myapex",
  6108. key: "myapex.key",
  6109. native_shared_libs: ["mylib"],
  6110. updatable: false,
  6111. }
  6112. apex_key {
  6113. name: "myapex.key",
  6114. public_key: "testkey.avbpubkey",
  6115. private_key: "testkey.pem",
  6116. }
  6117. cc_library {
  6118. name: "mylib",
  6119. srcs: ["mylib.cpp"],
  6120. system_shared_libs: [],
  6121. stl: "none",
  6122. required: ["a", "b"],
  6123. host_required: ["c", "d"],
  6124. target_required: ["e", "f"],
  6125. apex_available: [ "myapex" ],
  6126. }
  6127. `)
  6128. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6129. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6130. name := apexBundle.BaseModuleName()
  6131. prefix := "TARGET_"
  6132. var builder strings.Builder
  6133. data.Custom(&builder, name, prefix, "", data)
  6134. androidMk := builder.String()
  6135. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += a b\n")
  6136. ensureContains(t, androidMk, "LOCAL_HOST_REQUIRED_MODULES += c d\n")
  6137. ensureContains(t, androidMk, "LOCAL_TARGET_REQUIRED_MODULES += e f\n")
  6138. }
  6139. func TestSymlinksFromApexToSystem(t *testing.T) {
  6140. bp := `
  6141. apex {
  6142. name: "myapex",
  6143. key: "myapex.key",
  6144. native_shared_libs: ["mylib"],
  6145. java_libs: ["myjar"],
  6146. updatable: false,
  6147. }
  6148. apex {
  6149. name: "myapex.updatable",
  6150. key: "myapex.key",
  6151. native_shared_libs: ["mylib"],
  6152. java_libs: ["myjar"],
  6153. updatable: true,
  6154. min_sdk_version: "current",
  6155. }
  6156. apex_key {
  6157. name: "myapex.key",
  6158. public_key: "testkey.avbpubkey",
  6159. private_key: "testkey.pem",
  6160. }
  6161. cc_library {
  6162. name: "mylib",
  6163. srcs: ["mylib.cpp"],
  6164. shared_libs: ["myotherlib"],
  6165. system_shared_libs: [],
  6166. stl: "none",
  6167. apex_available: [
  6168. "myapex",
  6169. "myapex.updatable",
  6170. "//apex_available:platform",
  6171. ],
  6172. min_sdk_version: "current",
  6173. }
  6174. cc_library {
  6175. name: "myotherlib",
  6176. srcs: ["mylib.cpp"],
  6177. system_shared_libs: [],
  6178. stl: "none",
  6179. apex_available: [
  6180. "myapex",
  6181. "myapex.updatable",
  6182. "//apex_available:platform",
  6183. ],
  6184. min_sdk_version: "current",
  6185. }
  6186. java_library {
  6187. name: "myjar",
  6188. srcs: ["foo/bar/MyClass.java"],
  6189. sdk_version: "none",
  6190. system_modules: "none",
  6191. libs: ["myotherjar"],
  6192. apex_available: [
  6193. "myapex",
  6194. "myapex.updatable",
  6195. "//apex_available:platform",
  6196. ],
  6197. min_sdk_version: "current",
  6198. }
  6199. java_library {
  6200. name: "myotherjar",
  6201. srcs: ["foo/bar/MyClass.java"],
  6202. sdk_version: "none",
  6203. system_modules: "none",
  6204. apex_available: [
  6205. "myapex",
  6206. "myapex.updatable",
  6207. "//apex_available:platform",
  6208. ],
  6209. min_sdk_version: "current",
  6210. }
  6211. `
  6212. ensureRealfileExists := func(t *testing.T, files []fileInApex, file string) {
  6213. for _, f := range files {
  6214. if f.path == file {
  6215. if f.isLink {
  6216. t.Errorf("%q is not a real file", file)
  6217. }
  6218. return
  6219. }
  6220. }
  6221. t.Errorf("%q is not found", file)
  6222. }
  6223. ensureSymlinkExists := func(t *testing.T, files []fileInApex, file string) {
  6224. for _, f := range files {
  6225. if f.path == file {
  6226. if !f.isLink {
  6227. t.Errorf("%q is not a symlink", file)
  6228. }
  6229. return
  6230. }
  6231. }
  6232. t.Errorf("%q is not found", file)
  6233. }
  6234. // For unbundled build, symlink shouldn't exist regardless of whether an APEX
  6235. // is updatable or not
  6236. ctx := testApex(t, bp, withUnbundledBuild)
  6237. files := getFiles(t, ctx, "myapex", "android_common_myapex_image")
  6238. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6239. ensureRealfileExists(t, files, "lib64/mylib.so")
  6240. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  6241. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  6242. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6243. ensureRealfileExists(t, files, "lib64/mylib.so")
  6244. ensureRealfileExists(t, files, "lib64/myotherlib.so")
  6245. // For bundled build, symlink to the system for the non-updatable APEXes only
  6246. ctx = testApex(t, bp)
  6247. files = getFiles(t, ctx, "myapex", "android_common_myapex_image")
  6248. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6249. ensureRealfileExists(t, files, "lib64/mylib.so")
  6250. ensureSymlinkExists(t, files, "lib64/myotherlib.so") // this is symlink
  6251. files = getFiles(t, ctx, "myapex.updatable", "android_common_myapex.updatable_image")
  6252. ensureRealfileExists(t, files, "javalib/myjar.jar")
  6253. ensureRealfileExists(t, files, "lib64/mylib.so")
  6254. ensureRealfileExists(t, files, "lib64/myotherlib.so") // this is a real file
  6255. }
  6256. func TestSymlinksFromApexToSystemRequiredModuleNames(t *testing.T) {
  6257. ctx := testApex(t, `
  6258. apex {
  6259. name: "myapex",
  6260. key: "myapex.key",
  6261. native_shared_libs: ["mylib"],
  6262. updatable: false,
  6263. }
  6264. apex_key {
  6265. name: "myapex.key",
  6266. public_key: "testkey.avbpubkey",
  6267. private_key: "testkey.pem",
  6268. }
  6269. cc_library_shared {
  6270. name: "mylib",
  6271. srcs: ["mylib.cpp"],
  6272. shared_libs: ["myotherlib"],
  6273. system_shared_libs: [],
  6274. stl: "none",
  6275. apex_available: [
  6276. "myapex",
  6277. "//apex_available:platform",
  6278. ],
  6279. }
  6280. cc_prebuilt_library_shared {
  6281. name: "myotherlib",
  6282. srcs: ["prebuilt.so"],
  6283. system_shared_libs: [],
  6284. stl: "none",
  6285. apex_available: [
  6286. "myapex",
  6287. "//apex_available:platform",
  6288. ],
  6289. }
  6290. `)
  6291. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  6292. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  6293. var builder strings.Builder
  6294. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  6295. androidMk := builder.String()
  6296. // `myotherlib` is added to `myapex` as symlink
  6297. ensureContains(t, androidMk, "LOCAL_MODULE := mylib.myapex\n")
  6298. ensureNotContains(t, androidMk, "LOCAL_MODULE := prebuilt_myotherlib.myapex\n")
  6299. ensureNotContains(t, androidMk, "LOCAL_MODULE := myotherlib.myapex\n")
  6300. // `myapex` should have `myotherlib` in its required line, not `prebuilt_myotherlib`
  6301. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += mylib.myapex:64 myotherlib:64 apex_manifest.pb.myapex apex_pubkey.myapex\n")
  6302. }
  6303. func TestApexWithJniLibs(t *testing.T) {
  6304. ctx := testApex(t, `
  6305. apex {
  6306. name: "myapex",
  6307. key: "myapex.key",
  6308. jni_libs: ["mylib", "libfoo.rust"],
  6309. updatable: false,
  6310. }
  6311. apex_key {
  6312. name: "myapex.key",
  6313. public_key: "testkey.avbpubkey",
  6314. private_key: "testkey.pem",
  6315. }
  6316. cc_library {
  6317. name: "mylib",
  6318. srcs: ["mylib.cpp"],
  6319. shared_libs: ["mylib2"],
  6320. system_shared_libs: [],
  6321. stl: "none",
  6322. apex_available: [ "myapex" ],
  6323. }
  6324. cc_library {
  6325. name: "mylib2",
  6326. srcs: ["mylib.cpp"],
  6327. system_shared_libs: [],
  6328. stl: "none",
  6329. apex_available: [ "myapex" ],
  6330. }
  6331. rust_ffi_shared {
  6332. name: "libfoo.rust",
  6333. crate_name: "foo",
  6334. srcs: ["foo.rs"],
  6335. shared_libs: ["libfoo.shared_from_rust"],
  6336. prefer_rlib: true,
  6337. apex_available: ["myapex"],
  6338. }
  6339. cc_library_shared {
  6340. name: "libfoo.shared_from_rust",
  6341. srcs: ["mylib.cpp"],
  6342. system_shared_libs: [],
  6343. stl: "none",
  6344. stubs: {
  6345. versions: ["10", "11", "12"],
  6346. },
  6347. }
  6348. `)
  6349. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexManifestRule")
  6350. // Notice mylib2.so (transitive dep) is not added as a jni_lib
  6351. ensureEquals(t, rule.Args["opt"], "-a jniLibs libfoo.rust.so mylib.so")
  6352. ensureExactContents(t, ctx, "myapex", "android_common_myapex_image", []string{
  6353. "lib64/mylib.so",
  6354. "lib64/mylib2.so",
  6355. "lib64/libfoo.rust.so",
  6356. "lib64/libc++.so", // auto-added to libfoo.rust by Soong
  6357. "lib64/liblog.so", // auto-added to libfoo.rust by Soong
  6358. })
  6359. // b/220397949
  6360. ensureListContains(t, names(rule.Args["requireNativeLibs"]), "libfoo.shared_from_rust.so")
  6361. }
  6362. func TestApexMutatorsDontRunIfDisabled(t *testing.T) {
  6363. ctx := testApex(t, `
  6364. apex {
  6365. name: "myapex",
  6366. key: "myapex.key",
  6367. updatable: false,
  6368. }
  6369. apex_key {
  6370. name: "myapex.key",
  6371. public_key: "testkey.avbpubkey",
  6372. private_key: "testkey.pem",
  6373. }
  6374. `,
  6375. android.FixtureModifyConfig(func(config android.Config) {
  6376. delete(config.Targets, android.Android)
  6377. config.AndroidCommonTarget = android.Target{}
  6378. }),
  6379. )
  6380. if expected, got := []string{""}, ctx.ModuleVariantsForTests("myapex"); !reflect.DeepEqual(expected, got) {
  6381. t.Errorf("Expected variants: %v, but got: %v", expected, got)
  6382. }
  6383. }
  6384. func TestAppBundle(t *testing.T) {
  6385. ctx := testApex(t, `
  6386. apex {
  6387. name: "myapex",
  6388. key: "myapex.key",
  6389. apps: ["AppFoo"],
  6390. updatable: false,
  6391. }
  6392. apex_key {
  6393. name: "myapex.key",
  6394. public_key: "testkey.avbpubkey",
  6395. private_key: "testkey.pem",
  6396. }
  6397. android_app {
  6398. name: "AppFoo",
  6399. srcs: ["foo/bar/MyClass.java"],
  6400. sdk_version: "none",
  6401. system_modules: "none",
  6402. apex_available: [ "myapex" ],
  6403. }
  6404. `, withManifestPackageNameOverrides([]string{"AppFoo:com.android.foo"}))
  6405. bundleConfigRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Output("bundle_config.json")
  6406. content := bundleConfigRule.Args["content"]
  6407. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6408. ensureContains(t, content, `"apex_config":{"apex_embedded_apk_config":[{"package_name":"com.android.foo","path":"app/AppFoo@TEST.BUILD_ID/AppFoo.apk"}]}`)
  6409. }
  6410. func TestAppSetBundle(t *testing.T) {
  6411. ctx := testApex(t, `
  6412. apex {
  6413. name: "myapex",
  6414. key: "myapex.key",
  6415. apps: ["AppSet"],
  6416. updatable: false,
  6417. }
  6418. apex_key {
  6419. name: "myapex.key",
  6420. public_key: "testkey.avbpubkey",
  6421. private_key: "testkey.pem",
  6422. }
  6423. android_app_set {
  6424. name: "AppSet",
  6425. set: "AppSet.apks",
  6426. }`)
  6427. mod := ctx.ModuleForTests("myapex", "android_common_myapex_image")
  6428. bundleConfigRule := mod.Output("bundle_config.json")
  6429. content := bundleConfigRule.Args["content"]
  6430. ensureContains(t, content, `"compression":{"uncompressed_glob":["apex_payload.img","apex_manifest.*"]}`)
  6431. s := mod.Rule("apexRule").Args["copy_commands"]
  6432. copyCmds := regexp.MustCompile(" *&& *").Split(s, -1)
  6433. if len(copyCmds) != 3 {
  6434. t.Fatalf("Expected 3 commands, got %d in:\n%s", len(copyCmds), s)
  6435. }
  6436. ensureMatches(t, copyCmds[0], "^rm -rf .*/app/AppSet@TEST.BUILD_ID$")
  6437. ensureMatches(t, copyCmds[1], "^mkdir -p .*/app/AppSet@TEST.BUILD_ID$")
  6438. ensureMatches(t, copyCmds[2], "^unzip .*-d .*/app/AppSet@TEST.BUILD_ID .*/AppSet.zip$")
  6439. }
  6440. func TestAppSetBundlePrebuilt(t *testing.T) {
  6441. bp := `
  6442. apex_set {
  6443. name: "myapex",
  6444. filename: "foo_v2.apex",
  6445. sanitized: {
  6446. none: { set: "myapex.apks", },
  6447. hwaddress: { set: "myapex.hwasan.apks", },
  6448. },
  6449. }
  6450. `
  6451. ctx := testApex(t, bp, prepareForTestWithSantitizeHwaddress)
  6452. // Check that the extractor produces the correct output file from the correct input file.
  6453. extractorOutput := "out/soong/.intermediates/myapex.apex.extractor/android_common/extracted/myapex.hwasan.apks"
  6454. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  6455. extractedApex := m.Output(extractorOutput)
  6456. android.AssertArrayString(t, "extractor input", []string{"myapex.hwasan.apks"}, extractedApex.Inputs.Strings())
  6457. // Ditto for the apex.
  6458. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  6459. copiedApex := m.Output("out/soong/.intermediates/myapex/android_common_myapex/foo_v2.apex")
  6460. android.AssertStringEquals(t, "myapex input", extractorOutput, copiedApex.Input.String())
  6461. }
  6462. func testNoUpdatableJarsInBootImage(t *testing.T, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) {
  6463. t.Helper()
  6464. bp := `
  6465. java_library {
  6466. name: "some-updatable-apex-lib",
  6467. srcs: ["a.java"],
  6468. sdk_version: "current",
  6469. apex_available: [
  6470. "some-updatable-apex",
  6471. ],
  6472. permitted_packages: ["some.updatable.apex.lib"],
  6473. }
  6474. java_library {
  6475. name: "some-non-updatable-apex-lib",
  6476. srcs: ["a.java"],
  6477. apex_available: [
  6478. "some-non-updatable-apex",
  6479. ],
  6480. compile_dex: true,
  6481. permitted_packages: ["some.non.updatable.apex.lib"],
  6482. }
  6483. bootclasspath_fragment {
  6484. name: "some-non-updatable-fragment",
  6485. contents: ["some-non-updatable-apex-lib"],
  6486. apex_available: [
  6487. "some-non-updatable-apex",
  6488. ],
  6489. hidden_api: {
  6490. split_packages: ["*"],
  6491. },
  6492. }
  6493. java_library {
  6494. name: "some-platform-lib",
  6495. srcs: ["a.java"],
  6496. sdk_version: "current",
  6497. installable: true,
  6498. }
  6499. java_library {
  6500. name: "some-art-lib",
  6501. srcs: ["a.java"],
  6502. sdk_version: "current",
  6503. apex_available: [
  6504. "com.android.art.debug",
  6505. ],
  6506. hostdex: true,
  6507. compile_dex: true,
  6508. }
  6509. apex {
  6510. name: "some-updatable-apex",
  6511. key: "some-updatable-apex.key",
  6512. java_libs: ["some-updatable-apex-lib"],
  6513. updatable: true,
  6514. min_sdk_version: "current",
  6515. }
  6516. apex {
  6517. name: "some-non-updatable-apex",
  6518. key: "some-non-updatable-apex.key",
  6519. bootclasspath_fragments: ["some-non-updatable-fragment"],
  6520. updatable: false,
  6521. }
  6522. apex_key {
  6523. name: "some-updatable-apex.key",
  6524. }
  6525. apex_key {
  6526. name: "some-non-updatable-apex.key",
  6527. }
  6528. apex {
  6529. name: "com.android.art.debug",
  6530. key: "com.android.art.debug.key",
  6531. bootclasspath_fragments: ["art-bootclasspath-fragment"],
  6532. updatable: true,
  6533. min_sdk_version: "current",
  6534. }
  6535. bootclasspath_fragment {
  6536. name: "art-bootclasspath-fragment",
  6537. image_name: "art",
  6538. contents: ["some-art-lib"],
  6539. apex_available: [
  6540. "com.android.art.debug",
  6541. ],
  6542. hidden_api: {
  6543. split_packages: ["*"],
  6544. },
  6545. }
  6546. apex_key {
  6547. name: "com.android.art.debug.key",
  6548. }
  6549. filegroup {
  6550. name: "some-updatable-apex-file_contexts",
  6551. srcs: [
  6552. "system/sepolicy/apex/some-updatable-apex-file_contexts",
  6553. ],
  6554. }
  6555. filegroup {
  6556. name: "some-non-updatable-apex-file_contexts",
  6557. srcs: [
  6558. "system/sepolicy/apex/some-non-updatable-apex-file_contexts",
  6559. ],
  6560. }
  6561. `
  6562. testDexpreoptWithApexes(t, bp, errmsg, preparer, fragments...)
  6563. }
  6564. func testDexpreoptWithApexes(t *testing.T, bp, errmsg string, preparer android.FixturePreparer, fragments ...java.ApexVariantReference) *android.TestContext {
  6565. t.Helper()
  6566. fs := android.MockFS{
  6567. "a.java": nil,
  6568. "a.jar": nil,
  6569. "apex_manifest.json": nil,
  6570. "AndroidManifest.xml": nil,
  6571. "system/sepolicy/apex/myapex-file_contexts": nil,
  6572. "system/sepolicy/apex/some-updatable-apex-file_contexts": nil,
  6573. "system/sepolicy/apex/some-non-updatable-apex-file_contexts": nil,
  6574. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  6575. "framework/aidl/a.aidl": nil,
  6576. }
  6577. errorHandler := android.FixtureExpectsNoErrors
  6578. if errmsg != "" {
  6579. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  6580. }
  6581. result := android.GroupFixturePreparers(
  6582. cc.PrepareForTestWithCcDefaultModules,
  6583. java.PrepareForTestWithHiddenApiBuildComponents,
  6584. java.PrepareForTestWithJavaDefaultModules,
  6585. java.PrepareForTestWithJavaSdkLibraryFiles,
  6586. PrepareForTestWithApexBuildComponents,
  6587. preparer,
  6588. fs.AddToFixture(),
  6589. android.FixtureModifyMockFS(func(fs android.MockFS) {
  6590. if _, ok := fs["frameworks/base/boot/Android.bp"]; !ok {
  6591. insert := ""
  6592. for _, fragment := range fragments {
  6593. insert += fmt.Sprintf("{apex: %q, module: %q},\n", *fragment.Apex, *fragment.Module)
  6594. }
  6595. fs["frameworks/base/boot/Android.bp"] = []byte(fmt.Sprintf(`
  6596. platform_bootclasspath {
  6597. name: "platform-bootclasspath",
  6598. fragments: [
  6599. %s
  6600. ],
  6601. }
  6602. `, insert))
  6603. }
  6604. }),
  6605. dexpreopt.FixtureSetBootImageProfiles("art/build/boot/boot-image-profile.txt"),
  6606. ).
  6607. ExtendWithErrorHandler(errorHandler).
  6608. RunTestWithBp(t, bp)
  6609. return result.TestContext
  6610. }
  6611. func TestDuplicateDeapexersFromPrebuiltApexes(t *testing.T) {
  6612. preparers := android.GroupFixturePreparers(
  6613. java.PrepareForTestWithJavaDefaultModules,
  6614. PrepareForTestWithApexBuildComponents,
  6615. ).
  6616. ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(
  6617. "Multiple installable prebuilt APEXes provide ambiguous deapexers: com.android.myapex and com.mycompany.android.myapex"))
  6618. bpBase := `
  6619. apex_set {
  6620. name: "com.android.myapex",
  6621. installable: true,
  6622. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6623. set: "myapex.apks",
  6624. }
  6625. apex_set {
  6626. name: "com.mycompany.android.myapex",
  6627. apex_name: "com.android.myapex",
  6628. installable: true,
  6629. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6630. set: "company-myapex.apks",
  6631. }
  6632. prebuilt_bootclasspath_fragment {
  6633. name: "my-bootclasspath-fragment",
  6634. apex_available: ["com.android.myapex"],
  6635. %s
  6636. }
  6637. `
  6638. t.Run("java_import", func(t *testing.T) {
  6639. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6640. java_import {
  6641. name: "libfoo",
  6642. jars: ["libfoo.jar"],
  6643. apex_available: ["com.android.myapex"],
  6644. }
  6645. `)
  6646. })
  6647. t.Run("java_sdk_library_import", func(t *testing.T) {
  6648. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6649. java_sdk_library_import {
  6650. name: "libfoo",
  6651. public: {
  6652. jars: ["libbar.jar"],
  6653. },
  6654. apex_available: ["com.android.myapex"],
  6655. }
  6656. `)
  6657. })
  6658. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  6659. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  6660. image_name: "art",
  6661. contents: ["libfoo"],
  6662. `)+`
  6663. java_sdk_library_import {
  6664. name: "libfoo",
  6665. public: {
  6666. jars: ["libbar.jar"],
  6667. },
  6668. apex_available: ["com.android.myapex"],
  6669. }
  6670. `)
  6671. })
  6672. }
  6673. func TestDuplicateButEquivalentDeapexersFromPrebuiltApexes(t *testing.T) {
  6674. preparers := android.GroupFixturePreparers(
  6675. java.PrepareForTestWithJavaDefaultModules,
  6676. PrepareForTestWithApexBuildComponents,
  6677. )
  6678. bpBase := `
  6679. apex_set {
  6680. name: "com.android.myapex",
  6681. installable: true,
  6682. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6683. set: "myapex.apks",
  6684. }
  6685. apex_set {
  6686. name: "com.android.myapex_compressed",
  6687. apex_name: "com.android.myapex",
  6688. installable: true,
  6689. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6690. set: "myapex_compressed.apks",
  6691. }
  6692. prebuilt_bootclasspath_fragment {
  6693. name: "my-bootclasspath-fragment",
  6694. apex_available: [
  6695. "com.android.myapex",
  6696. "com.android.myapex_compressed",
  6697. ],
  6698. hidden_api: {
  6699. annotation_flags: "annotation-flags.csv",
  6700. metadata: "metadata.csv",
  6701. index: "index.csv",
  6702. signature_patterns: "signature_patterns.csv",
  6703. },
  6704. %s
  6705. }
  6706. `
  6707. t.Run("java_import", func(t *testing.T) {
  6708. result := preparers.RunTestWithBp(t,
  6709. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6710. java_import {
  6711. name: "libfoo",
  6712. jars: ["libfoo.jar"],
  6713. apex_available: [
  6714. "com.android.myapex",
  6715. "com.android.myapex_compressed",
  6716. ],
  6717. }
  6718. `)
  6719. module := result.Module("libfoo", "android_common_com.android.myapex")
  6720. usesLibraryDep := module.(java.UsesLibraryDependency)
  6721. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  6722. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  6723. usesLibraryDep.DexJarBuildPath().Path())
  6724. })
  6725. t.Run("java_sdk_library_import", func(t *testing.T) {
  6726. result := preparers.RunTestWithBp(t,
  6727. fmt.Sprintf(bpBase, `contents: ["libfoo"]`)+`
  6728. java_sdk_library_import {
  6729. name: "libfoo",
  6730. public: {
  6731. jars: ["libbar.jar"],
  6732. },
  6733. apex_available: [
  6734. "com.android.myapex",
  6735. "com.android.myapex_compressed",
  6736. ],
  6737. compile_dex: true,
  6738. }
  6739. `)
  6740. module := result.Module("libfoo", "android_common_com.android.myapex")
  6741. usesLibraryDep := module.(java.UsesLibraryDependency)
  6742. android.AssertPathRelativeToTopEquals(t, "dex jar path",
  6743. "out/soong/.intermediates/com.android.myapex.deapexer/android_common/deapexer/javalib/libfoo.jar",
  6744. usesLibraryDep.DexJarBuildPath().Path())
  6745. })
  6746. t.Run("prebuilt_bootclasspath_fragment", func(t *testing.T) {
  6747. _ = preparers.RunTestWithBp(t, fmt.Sprintf(bpBase, `
  6748. image_name: "art",
  6749. contents: ["libfoo"],
  6750. `)+`
  6751. java_sdk_library_import {
  6752. name: "libfoo",
  6753. public: {
  6754. jars: ["libbar.jar"],
  6755. },
  6756. apex_available: [
  6757. "com.android.myapex",
  6758. "com.android.myapex_compressed",
  6759. ],
  6760. compile_dex: true,
  6761. }
  6762. `)
  6763. })
  6764. }
  6765. func TestUpdatable_should_set_min_sdk_version(t *testing.T) {
  6766. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6767. apex {
  6768. name: "myapex",
  6769. key: "myapex.key",
  6770. updatable: true,
  6771. }
  6772. apex_key {
  6773. name: "myapex.key",
  6774. public_key: "testkey.avbpubkey",
  6775. private_key: "testkey.pem",
  6776. }
  6777. `)
  6778. }
  6779. func TestUpdatableDefault_should_set_min_sdk_version(t *testing.T) {
  6780. testApexError(t, `"myapex" .*: updatable: updatable APEXes should set min_sdk_version`, `
  6781. apex {
  6782. name: "myapex",
  6783. key: "myapex.key",
  6784. }
  6785. apex_key {
  6786. name: "myapex.key",
  6787. public_key: "testkey.avbpubkey",
  6788. private_key: "testkey.pem",
  6789. }
  6790. `)
  6791. }
  6792. func TestUpdatable_cannot_be_vendor_apex(t *testing.T) {
  6793. testApexError(t, `"myapex" .*: updatable: vendor APEXes are not updatable`, `
  6794. apex {
  6795. name: "myapex",
  6796. key: "myapex.key",
  6797. updatable: true,
  6798. soc_specific: true,
  6799. }
  6800. apex_key {
  6801. name: "myapex.key",
  6802. public_key: "testkey.avbpubkey",
  6803. private_key: "testkey.pem",
  6804. }
  6805. `)
  6806. }
  6807. func TestUpdatable_should_not_set_generate_classpaths_proto(t *testing.T) {
  6808. testApexError(t, `"mysystemserverclasspathfragment" .* it must not set generate_classpaths_proto to false`, `
  6809. apex {
  6810. name: "myapex",
  6811. key: "myapex.key",
  6812. systemserverclasspath_fragments: [
  6813. "mysystemserverclasspathfragment",
  6814. ],
  6815. min_sdk_version: "29",
  6816. updatable: true,
  6817. }
  6818. apex_key {
  6819. name: "myapex.key",
  6820. public_key: "testkey.avbpubkey",
  6821. private_key: "testkey.pem",
  6822. }
  6823. java_library {
  6824. name: "foo",
  6825. srcs: ["b.java"],
  6826. min_sdk_version: "29",
  6827. installable: true,
  6828. apex_available: [
  6829. "myapex",
  6830. ],
  6831. }
  6832. systemserverclasspath_fragment {
  6833. name: "mysystemserverclasspathfragment",
  6834. generate_classpaths_proto: false,
  6835. contents: [
  6836. "foo",
  6837. ],
  6838. apex_available: [
  6839. "myapex",
  6840. ],
  6841. }
  6842. `,
  6843. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  6844. )
  6845. }
  6846. func TestNoUpdatableJarsInBootImage(t *testing.T) {
  6847. // Set the BootJars in dexpreopt.GlobalConfig and productVariables to the same value. This can
  6848. // result in an invalid configuration as it does not set the ArtApexJars and allows art apex
  6849. // modules to be included in the BootJars.
  6850. prepareSetBootJars := func(bootJars ...string) android.FixturePreparer {
  6851. return android.GroupFixturePreparers(
  6852. dexpreopt.FixtureSetBootJars(bootJars...),
  6853. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6854. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  6855. }),
  6856. )
  6857. }
  6858. // Set the ArtApexJars and BootJars in dexpreopt.GlobalConfig and productVariables all to the
  6859. // same value. This can result in an invalid configuration as it allows non art apex jars to be
  6860. // specified in the ArtApexJars configuration.
  6861. prepareSetArtJars := func(bootJars ...string) android.FixturePreparer {
  6862. return android.GroupFixturePreparers(
  6863. dexpreopt.FixtureSetArtBootJars(bootJars...),
  6864. dexpreopt.FixtureSetBootJars(bootJars...),
  6865. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  6866. variables.BootJars = android.CreateTestConfiguredJarList(bootJars)
  6867. }),
  6868. )
  6869. }
  6870. t.Run("updatable jar from ART apex in the ART boot image => ok", func(t *testing.T) {
  6871. preparer := android.GroupFixturePreparers(
  6872. java.FixtureConfigureBootJars("com.android.art.debug:some-art-lib"),
  6873. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6874. )
  6875. fragments := []java.ApexVariantReference{
  6876. {
  6877. Apex: proptools.StringPtr("com.android.art.debug"),
  6878. Module: proptools.StringPtr("art-bootclasspath-fragment"),
  6879. },
  6880. {
  6881. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6882. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6883. },
  6884. }
  6885. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  6886. })
  6887. t.Run("updatable jar from ART apex in the framework boot image => error", func(t *testing.T) {
  6888. err := `module "some-art-lib" from updatable apexes \["com.android.art.debug"\] is not allowed in the framework boot image`
  6889. // Update the dexpreopt BootJars directly.
  6890. preparer := android.GroupFixturePreparers(
  6891. prepareSetBootJars("com.android.art.debug:some-art-lib"),
  6892. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6893. )
  6894. testNoUpdatableJarsInBootImage(t, err, preparer)
  6895. })
  6896. t.Run("updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  6897. err := `ArtApexJars expects this to be in apex "some-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  6898. // Update the dexpreopt ArtApexJars directly.
  6899. preparer := prepareSetArtJars("some-updatable-apex:some-updatable-apex-lib")
  6900. testNoUpdatableJarsInBootImage(t, err, preparer)
  6901. })
  6902. t.Run("non-updatable jar from some other apex in the ART boot image => error", func(t *testing.T) {
  6903. err := `ArtApexJars expects this to be in apex "some-non-updatable-apex" but this is only in apexes.*"com.android.art.debug"`
  6904. // Update the dexpreopt ArtApexJars directly.
  6905. preparer := prepareSetArtJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  6906. testNoUpdatableJarsInBootImage(t, err, preparer)
  6907. })
  6908. t.Run("updatable jar from some other apex in the framework boot image => error", func(t *testing.T) {
  6909. err := `module "some-updatable-apex-lib" from updatable apexes \["some-updatable-apex"\] is not allowed in the framework boot image`
  6910. preparer := android.GroupFixturePreparers(
  6911. java.FixtureConfigureBootJars("some-updatable-apex:some-updatable-apex-lib"),
  6912. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6913. )
  6914. testNoUpdatableJarsInBootImage(t, err, preparer)
  6915. })
  6916. t.Run("non-updatable jar from some other apex in the framework boot image => ok", func(t *testing.T) {
  6917. preparer := java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib")
  6918. fragment := java.ApexVariantReference{
  6919. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6920. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6921. }
  6922. testNoUpdatableJarsInBootImage(t, "", preparer, fragment)
  6923. })
  6924. t.Run("nonexistent jar in the ART boot image => error", func(t *testing.T) {
  6925. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  6926. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  6927. testNoUpdatableJarsInBootImage(t, err, preparer)
  6928. })
  6929. t.Run("nonexistent jar in the framework boot image => error", func(t *testing.T) {
  6930. err := `"platform-bootclasspath" depends on undefined module "nonexistent"`
  6931. preparer := java.FixtureConfigureBootJars("platform:nonexistent")
  6932. testNoUpdatableJarsInBootImage(t, err, preparer)
  6933. })
  6934. t.Run("platform jar in the ART boot image => error", func(t *testing.T) {
  6935. err := `ArtApexJars is invalid as it requests a platform variant of "some-platform-lib"`
  6936. // Update the dexpreopt ArtApexJars directly.
  6937. preparer := prepareSetArtJars("platform:some-platform-lib")
  6938. testNoUpdatableJarsInBootImage(t, err, preparer)
  6939. })
  6940. t.Run("platform jar in the framework boot image => ok", func(t *testing.T) {
  6941. preparer := android.GroupFixturePreparers(
  6942. java.FixtureConfigureBootJars("platform:some-platform-lib"),
  6943. java.FixtureConfigureApexBootJars("some-non-updatable-apex:some-non-updatable-apex-lib"),
  6944. )
  6945. fragments := []java.ApexVariantReference{
  6946. {
  6947. Apex: proptools.StringPtr("some-non-updatable-apex"),
  6948. Module: proptools.StringPtr("some-non-updatable-fragment"),
  6949. },
  6950. }
  6951. testNoUpdatableJarsInBootImage(t, "", preparer, fragments...)
  6952. })
  6953. }
  6954. func TestDexpreoptAccessDexFilesFromPrebuiltApex(t *testing.T) {
  6955. preparer := java.FixtureConfigureApexBootJars("myapex:libfoo")
  6956. t.Run("prebuilt no source", func(t *testing.T) {
  6957. fragment := java.ApexVariantReference{
  6958. Apex: proptools.StringPtr("myapex"),
  6959. Module: proptools.StringPtr("my-bootclasspath-fragment"),
  6960. }
  6961. testDexpreoptWithApexes(t, `
  6962. prebuilt_apex {
  6963. name: "myapex" ,
  6964. arch: {
  6965. arm64: {
  6966. src: "myapex-arm64.apex",
  6967. },
  6968. arm: {
  6969. src: "myapex-arm.apex",
  6970. },
  6971. },
  6972. exported_bootclasspath_fragments: ["my-bootclasspath-fragment"],
  6973. }
  6974. prebuilt_bootclasspath_fragment {
  6975. name: "my-bootclasspath-fragment",
  6976. contents: ["libfoo"],
  6977. apex_available: ["myapex"],
  6978. hidden_api: {
  6979. annotation_flags: "my-bootclasspath-fragment/annotation-flags.csv",
  6980. metadata: "my-bootclasspath-fragment/metadata.csv",
  6981. index: "my-bootclasspath-fragment/index.csv",
  6982. signature_patterns: "my-bootclasspath-fragment/signature-patterns.csv",
  6983. filtered_stub_flags: "my-bootclasspath-fragment/filtered-stub-flags.csv",
  6984. filtered_flags: "my-bootclasspath-fragment/filtered-flags.csv",
  6985. },
  6986. }
  6987. java_import {
  6988. name: "libfoo",
  6989. jars: ["libfoo.jar"],
  6990. apex_available: ["myapex"],
  6991. permitted_packages: ["libfoo"],
  6992. }
  6993. `, "", preparer, fragment)
  6994. })
  6995. }
  6996. func testBootJarPermittedPackagesRules(t *testing.T, errmsg, bp string, bootJars []string, rules []android.Rule) {
  6997. t.Helper()
  6998. bp += `
  6999. apex_key {
  7000. name: "myapex.key",
  7001. public_key: "testkey.avbpubkey",
  7002. private_key: "testkey.pem",
  7003. }`
  7004. fs := android.MockFS{
  7005. "lib1/src/A.java": nil,
  7006. "lib2/src/B.java": nil,
  7007. "system/sepolicy/apex/myapex-file_contexts": nil,
  7008. }
  7009. errorHandler := android.FixtureExpectsNoErrors
  7010. if errmsg != "" {
  7011. errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(errmsg)
  7012. }
  7013. android.GroupFixturePreparers(
  7014. android.PrepareForTestWithAndroidBuildComponents,
  7015. java.PrepareForTestWithJavaBuildComponents,
  7016. PrepareForTestWithApexBuildComponents,
  7017. android.PrepareForTestWithNeverallowRules(rules),
  7018. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7019. apexBootJars := make([]string, 0, len(bootJars))
  7020. for _, apexBootJar := range bootJars {
  7021. apexBootJars = append(apexBootJars, "myapex:"+apexBootJar)
  7022. }
  7023. variables.ApexBootJars = android.CreateTestConfiguredJarList(apexBootJars)
  7024. }),
  7025. fs.AddToFixture(),
  7026. ).
  7027. ExtendWithErrorHandler(errorHandler).
  7028. RunTestWithBp(t, bp)
  7029. }
  7030. func TestApexPermittedPackagesRules(t *testing.T) {
  7031. testcases := []struct {
  7032. name string
  7033. expectedError string
  7034. bp string
  7035. bootJars []string
  7036. bcpPermittedPackages map[string][]string
  7037. }{
  7038. {
  7039. name: "Non-Bootclasspath apex jar not satisfying allowed module packages.",
  7040. expectedError: "",
  7041. bp: `
  7042. java_library {
  7043. name: "bcp_lib1",
  7044. srcs: ["lib1/src/*.java"],
  7045. permitted_packages: ["foo.bar"],
  7046. apex_available: ["myapex"],
  7047. sdk_version: "none",
  7048. system_modules: "none",
  7049. }
  7050. java_library {
  7051. name: "nonbcp_lib2",
  7052. srcs: ["lib2/src/*.java"],
  7053. apex_available: ["myapex"],
  7054. permitted_packages: ["a.b"],
  7055. sdk_version: "none",
  7056. system_modules: "none",
  7057. }
  7058. apex {
  7059. name: "myapex",
  7060. key: "myapex.key",
  7061. java_libs: ["bcp_lib1", "nonbcp_lib2"],
  7062. updatable: false,
  7063. }`,
  7064. bootJars: []string{"bcp_lib1"},
  7065. bcpPermittedPackages: map[string][]string{
  7066. "bcp_lib1": []string{
  7067. "foo.bar",
  7068. },
  7069. },
  7070. },
  7071. {
  7072. name: "Bootclasspath apex jar not satisfying allowed module packages.",
  7073. expectedError: `(?s)module "bcp_lib2" .* which is restricted because bcp_lib2 bootjar may only use these package prefixes: foo.bar. Please consider the following alternatives:\n 1. If the offending code is from a statically linked library, consider removing that dependency and using an alternative already in the bootclasspath, or perhaps a shared library. 2. Move the offending code into an allowed package.\n 3. Jarjar the offending code. Please be mindful of the potential system health implications of bundling that code, particularly if the offending jar is part of the bootclasspath.`,
  7074. bp: `
  7075. java_library {
  7076. name: "bcp_lib1",
  7077. srcs: ["lib1/src/*.java"],
  7078. apex_available: ["myapex"],
  7079. permitted_packages: ["foo.bar"],
  7080. sdk_version: "none",
  7081. system_modules: "none",
  7082. }
  7083. java_library {
  7084. name: "bcp_lib2",
  7085. srcs: ["lib2/src/*.java"],
  7086. apex_available: ["myapex"],
  7087. permitted_packages: ["foo.bar", "bar.baz"],
  7088. sdk_version: "none",
  7089. system_modules: "none",
  7090. }
  7091. apex {
  7092. name: "myapex",
  7093. key: "myapex.key",
  7094. java_libs: ["bcp_lib1", "bcp_lib2"],
  7095. updatable: false,
  7096. }
  7097. `,
  7098. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7099. bcpPermittedPackages: map[string][]string{
  7100. "bcp_lib1": []string{
  7101. "foo.bar",
  7102. },
  7103. "bcp_lib2": []string{
  7104. "foo.bar",
  7105. },
  7106. },
  7107. },
  7108. {
  7109. name: "Updateable Bootclasspath apex jar not satisfying allowed module packages.",
  7110. expectedError: "",
  7111. bp: `
  7112. java_library {
  7113. name: "bcp_lib_restricted",
  7114. srcs: ["lib1/src/*.java"],
  7115. apex_available: ["myapex"],
  7116. permitted_packages: ["foo.bar"],
  7117. sdk_version: "none",
  7118. min_sdk_version: "29",
  7119. system_modules: "none",
  7120. }
  7121. java_library {
  7122. name: "bcp_lib_unrestricted",
  7123. srcs: ["lib2/src/*.java"],
  7124. apex_available: ["myapex"],
  7125. permitted_packages: ["foo.bar", "bar.baz"],
  7126. sdk_version: "none",
  7127. min_sdk_version: "29",
  7128. system_modules: "none",
  7129. }
  7130. apex {
  7131. name: "myapex",
  7132. key: "myapex.key",
  7133. java_libs: ["bcp_lib_restricted", "bcp_lib_unrestricted"],
  7134. updatable: true,
  7135. min_sdk_version: "29",
  7136. }
  7137. `,
  7138. bootJars: []string{"bcp_lib1", "bcp_lib2"},
  7139. bcpPermittedPackages: map[string][]string{
  7140. "bcp_lib1_non_updateable": []string{
  7141. "foo.bar",
  7142. },
  7143. // bcp_lib2_updateable has no entry here since updateable bcp can contain new packages - tracking via an allowlist is not necessary
  7144. },
  7145. },
  7146. }
  7147. for _, tc := range testcases {
  7148. t.Run(tc.name, func(t *testing.T) {
  7149. rules := createBcpPermittedPackagesRules(tc.bcpPermittedPackages)
  7150. testBootJarPermittedPackagesRules(t, tc.expectedError, tc.bp, tc.bootJars, rules)
  7151. })
  7152. }
  7153. }
  7154. func TestTestFor(t *testing.T) {
  7155. ctx := testApex(t, `
  7156. apex {
  7157. name: "myapex",
  7158. key: "myapex.key",
  7159. native_shared_libs: ["mylib", "myprivlib"],
  7160. updatable: false,
  7161. }
  7162. apex_key {
  7163. name: "myapex.key",
  7164. public_key: "testkey.avbpubkey",
  7165. private_key: "testkey.pem",
  7166. }
  7167. cc_library {
  7168. name: "mylib",
  7169. srcs: ["mylib.cpp"],
  7170. system_shared_libs: [],
  7171. stl: "none",
  7172. stubs: {
  7173. versions: ["1"],
  7174. },
  7175. apex_available: ["myapex"],
  7176. }
  7177. cc_library {
  7178. name: "myprivlib",
  7179. srcs: ["mylib.cpp"],
  7180. system_shared_libs: [],
  7181. stl: "none",
  7182. apex_available: ["myapex"],
  7183. }
  7184. cc_test {
  7185. name: "mytest",
  7186. gtest: false,
  7187. srcs: ["mylib.cpp"],
  7188. system_shared_libs: [],
  7189. stl: "none",
  7190. shared_libs: ["mylib", "myprivlib", "mytestlib"],
  7191. test_for: ["myapex"]
  7192. }
  7193. cc_library {
  7194. name: "mytestlib",
  7195. srcs: ["mylib.cpp"],
  7196. system_shared_libs: [],
  7197. shared_libs: ["mylib", "myprivlib"],
  7198. stl: "none",
  7199. test_for: ["myapex"],
  7200. }
  7201. cc_benchmark {
  7202. name: "mybench",
  7203. srcs: ["mylib.cpp"],
  7204. system_shared_libs: [],
  7205. shared_libs: ["mylib", "myprivlib"],
  7206. stl: "none",
  7207. test_for: ["myapex"],
  7208. }
  7209. `)
  7210. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  7211. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  7212. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  7213. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  7214. }
  7215. // These modules are tests for the apex, therefore are linked to the
  7216. // actual implementation of mylib instead of its stub.
  7217. ensureLinkedLibIs("mytest", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7218. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7219. ensureLinkedLibIs("mybench", "android_arm64_armv8-a", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7220. }
  7221. func TestIndirectTestFor(t *testing.T) {
  7222. ctx := testApex(t, `
  7223. apex {
  7224. name: "myapex",
  7225. key: "myapex.key",
  7226. native_shared_libs: ["mylib", "myprivlib"],
  7227. updatable: false,
  7228. }
  7229. apex_key {
  7230. name: "myapex.key",
  7231. public_key: "testkey.avbpubkey",
  7232. private_key: "testkey.pem",
  7233. }
  7234. cc_library {
  7235. name: "mylib",
  7236. srcs: ["mylib.cpp"],
  7237. system_shared_libs: [],
  7238. stl: "none",
  7239. stubs: {
  7240. versions: ["1"],
  7241. },
  7242. apex_available: ["myapex"],
  7243. }
  7244. cc_library {
  7245. name: "myprivlib",
  7246. srcs: ["mylib.cpp"],
  7247. system_shared_libs: [],
  7248. stl: "none",
  7249. shared_libs: ["mylib"],
  7250. apex_available: ["myapex"],
  7251. }
  7252. cc_library {
  7253. name: "mytestlib",
  7254. srcs: ["mylib.cpp"],
  7255. system_shared_libs: [],
  7256. shared_libs: ["myprivlib"],
  7257. stl: "none",
  7258. test_for: ["myapex"],
  7259. }
  7260. `)
  7261. ensureLinkedLibIs := func(mod, variant, linkedLib, expectedVariant string) {
  7262. ldFlags := strings.Split(ctx.ModuleForTests(mod, variant).Rule("ld").Args["libFlags"], " ")
  7263. mylibLdFlags := android.FilterListPred(ldFlags, func(s string) bool { return strings.HasPrefix(s, linkedLib) })
  7264. android.AssertArrayString(t, "unexpected "+linkedLib+" link library for "+mod, []string{linkedLib + expectedVariant}, mylibLdFlags)
  7265. }
  7266. // The platform variant of mytestlib links to the platform variant of the
  7267. // internal myprivlib.
  7268. ensureLinkedLibIs("mytestlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/myprivlib/", "android_arm64_armv8-a_shared/myprivlib.so")
  7269. // The platform variant of myprivlib links to the platform variant of mylib
  7270. // and bypasses its stubs.
  7271. ensureLinkedLibIs("myprivlib", "android_arm64_armv8-a_shared", "out/soong/.intermediates/mylib/", "android_arm64_armv8-a_shared/mylib.so")
  7272. }
  7273. func TestTestForForLibInOtherApex(t *testing.T) {
  7274. // This case is only allowed for known overlapping APEXes, i.e. the ART APEXes.
  7275. _ = testApex(t, `
  7276. apex {
  7277. name: "com.android.art",
  7278. key: "myapex.key",
  7279. native_shared_libs: ["mylib"],
  7280. updatable: false,
  7281. }
  7282. apex {
  7283. name: "com.android.art.debug",
  7284. key: "myapex.key",
  7285. native_shared_libs: ["mylib", "mytestlib"],
  7286. updatable: false,
  7287. }
  7288. apex_key {
  7289. name: "myapex.key",
  7290. public_key: "testkey.avbpubkey",
  7291. private_key: "testkey.pem",
  7292. }
  7293. cc_library {
  7294. name: "mylib",
  7295. srcs: ["mylib.cpp"],
  7296. system_shared_libs: [],
  7297. stl: "none",
  7298. stubs: {
  7299. versions: ["1"],
  7300. },
  7301. apex_available: ["com.android.art", "com.android.art.debug"],
  7302. }
  7303. cc_library {
  7304. name: "mytestlib",
  7305. srcs: ["mylib.cpp"],
  7306. system_shared_libs: [],
  7307. shared_libs: ["mylib"],
  7308. stl: "none",
  7309. apex_available: ["com.android.art.debug"],
  7310. test_for: ["com.android.art"],
  7311. }
  7312. `,
  7313. android.MockFS{
  7314. "system/sepolicy/apex/com.android.art-file_contexts": nil,
  7315. "system/sepolicy/apex/com.android.art.debug-file_contexts": nil,
  7316. }.AddToFixture())
  7317. }
  7318. // TODO(jungjw): Move this to proptools
  7319. func intPtr(i int) *int {
  7320. return &i
  7321. }
  7322. func TestApexSet(t *testing.T) {
  7323. ctx := testApex(t, `
  7324. apex_set {
  7325. name: "myapex",
  7326. set: "myapex.apks",
  7327. filename: "foo_v2.apex",
  7328. overrides: ["foo"],
  7329. }
  7330. `,
  7331. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7332. variables.Platform_sdk_version = intPtr(30)
  7333. }),
  7334. android.FixtureModifyConfig(func(config android.Config) {
  7335. config.Targets[android.Android] = []android.Target{
  7336. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm, ArchVariant: "armv7-a-neon", Abi: []string{"armeabi-v7a"}}},
  7337. {Os: android.Android, Arch: android.Arch{ArchType: android.Arm64, ArchVariant: "armv8-a", Abi: []string{"arm64-v8a"}}},
  7338. }
  7339. }),
  7340. )
  7341. m := ctx.ModuleForTests("myapex.apex.extractor", "android_common")
  7342. // Check extract_apks tool parameters.
  7343. extractedApex := m.Output("extracted/myapex.apks")
  7344. actual := extractedApex.Args["abis"]
  7345. expected := "ARMEABI_V7A,ARM64_V8A"
  7346. if actual != expected {
  7347. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  7348. }
  7349. actual = extractedApex.Args["sdk-version"]
  7350. expected = "30"
  7351. if actual != expected {
  7352. t.Errorf("Unexpected abis parameter - expected %q vs actual %q", expected, actual)
  7353. }
  7354. m = ctx.ModuleForTests("myapex", "android_common_myapex")
  7355. a := m.Module().(*ApexSet)
  7356. expectedOverrides := []string{"foo"}
  7357. actualOverrides := android.AndroidMkEntriesForTest(t, ctx, a)[0].EntryMap["LOCAL_OVERRIDES_MODULES"]
  7358. if !reflect.DeepEqual(actualOverrides, expectedOverrides) {
  7359. t.Errorf("Incorrect LOCAL_OVERRIDES_MODULES - expected %q vs actual %q", expectedOverrides, actualOverrides)
  7360. }
  7361. }
  7362. func TestNoStaticLinkingToStubsLib(t *testing.T) {
  7363. testApexError(t, `.*required by "mylib" is a native library providing stub.*`, `
  7364. apex {
  7365. name: "myapex",
  7366. key: "myapex.key",
  7367. native_shared_libs: ["mylib"],
  7368. updatable: false,
  7369. }
  7370. apex_key {
  7371. name: "myapex.key",
  7372. public_key: "testkey.avbpubkey",
  7373. private_key: "testkey.pem",
  7374. }
  7375. cc_library {
  7376. name: "mylib",
  7377. srcs: ["mylib.cpp"],
  7378. static_libs: ["otherlib"],
  7379. system_shared_libs: [],
  7380. stl: "none",
  7381. apex_available: [ "myapex" ],
  7382. }
  7383. cc_library {
  7384. name: "otherlib",
  7385. srcs: ["mylib.cpp"],
  7386. system_shared_libs: [],
  7387. stl: "none",
  7388. stubs: {
  7389. versions: ["1", "2", "3"],
  7390. },
  7391. apex_available: [ "myapex" ],
  7392. }
  7393. `)
  7394. }
  7395. func TestApexKeysTxt(t *testing.T) {
  7396. ctx := testApex(t, `
  7397. apex {
  7398. name: "myapex",
  7399. key: "myapex.key",
  7400. updatable: false,
  7401. custom_sign_tool: "sign_myapex",
  7402. }
  7403. apex_key {
  7404. name: "myapex.key",
  7405. public_key: "testkey.avbpubkey",
  7406. private_key: "testkey.pem",
  7407. }
  7408. `)
  7409. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7410. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7411. ensureContains(t, content, `name="myapex.apex" public_key="vendor/foo/devkeys/testkey.avbpubkey" private_key="vendor/foo/devkeys/testkey.pem" container_certificate="vendor/foo/devkeys/test.x509.pem" container_private_key="vendor/foo/devkeys/test.pk8" partition="system_ext" sign_tool="sign_myapex"`)
  7412. }
  7413. func TestApexKeysTxtOverrides(t *testing.T) {
  7414. ctx := testApex(t, `
  7415. apex {
  7416. name: "myapex",
  7417. key: "myapex.key",
  7418. updatable: false,
  7419. custom_sign_tool: "sign_myapex",
  7420. }
  7421. apex_key {
  7422. name: "myapex.key",
  7423. public_key: "testkey.avbpubkey",
  7424. private_key: "testkey.pem",
  7425. }
  7426. prebuilt_apex {
  7427. name: "myapex",
  7428. prefer: true,
  7429. arch: {
  7430. arm64: {
  7431. src: "myapex-arm64.apex",
  7432. },
  7433. arm: {
  7434. src: "myapex-arm.apex",
  7435. },
  7436. },
  7437. }
  7438. apex_set {
  7439. name: "myapex_set",
  7440. set: "myapex.apks",
  7441. filename: "myapex_set.apex",
  7442. overrides: ["myapex"],
  7443. }
  7444. `)
  7445. apexKeysText := ctx.SingletonForTests("apex_keys_text")
  7446. content := apexKeysText.MaybeDescription("apexkeys.txt").BuildParams.Args["content"]
  7447. ensureContains(t, content, `name="myapex_set.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7448. ensureContains(t, content, `name="myapex.apex" public_key="PRESIGNED" private_key="PRESIGNED" container_certificate="PRESIGNED" container_private_key="PRESIGNED" partition="system"`)
  7449. }
  7450. func TestAllowedFiles(t *testing.T) {
  7451. ctx := testApex(t, `
  7452. apex {
  7453. name: "myapex",
  7454. key: "myapex.key",
  7455. apps: ["app"],
  7456. allowed_files: "allowed.txt",
  7457. updatable: false,
  7458. }
  7459. apex_key {
  7460. name: "myapex.key",
  7461. public_key: "testkey.avbpubkey",
  7462. private_key: "testkey.pem",
  7463. }
  7464. android_app {
  7465. name: "app",
  7466. srcs: ["foo/bar/MyClass.java"],
  7467. package_name: "foo",
  7468. sdk_version: "none",
  7469. system_modules: "none",
  7470. apex_available: [ "myapex" ],
  7471. }
  7472. `, withFiles(map[string][]byte{
  7473. "sub/Android.bp": []byte(`
  7474. override_apex {
  7475. name: "override_myapex",
  7476. base: "myapex",
  7477. apps: ["override_app"],
  7478. allowed_files: ":allowed",
  7479. }
  7480. // Overridable "path" property should be referenced indirectly
  7481. filegroup {
  7482. name: "allowed",
  7483. srcs: ["allowed.txt"],
  7484. }
  7485. override_android_app {
  7486. name: "override_app",
  7487. base: "app",
  7488. package_name: "bar",
  7489. }
  7490. `),
  7491. }))
  7492. rule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("diffApexContentRule")
  7493. if expected, actual := "allowed.txt", rule.Args["allowed_files_file"]; expected != actual {
  7494. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7495. }
  7496. rule2 := ctx.ModuleForTests("myapex", "android_common_override_myapex_myapex_image").Rule("diffApexContentRule")
  7497. if expected, actual := "sub/allowed.txt", rule2.Args["allowed_files_file"]; expected != actual {
  7498. t.Errorf("allowed_files_file: expected %q but got %q", expected, actual)
  7499. }
  7500. }
  7501. func TestNonPreferredPrebuiltDependency(t *testing.T) {
  7502. testApex(t, `
  7503. apex {
  7504. name: "myapex",
  7505. key: "myapex.key",
  7506. native_shared_libs: ["mylib"],
  7507. updatable: false,
  7508. }
  7509. apex_key {
  7510. name: "myapex.key",
  7511. public_key: "testkey.avbpubkey",
  7512. private_key: "testkey.pem",
  7513. }
  7514. cc_library {
  7515. name: "mylib",
  7516. srcs: ["mylib.cpp"],
  7517. stubs: {
  7518. versions: ["current"],
  7519. },
  7520. apex_available: ["myapex"],
  7521. }
  7522. cc_prebuilt_library_shared {
  7523. name: "mylib",
  7524. prefer: false,
  7525. srcs: ["prebuilt.so"],
  7526. stubs: {
  7527. versions: ["current"],
  7528. },
  7529. apex_available: ["myapex"],
  7530. }
  7531. `)
  7532. }
  7533. func TestCompressedApex(t *testing.T) {
  7534. ctx := testApex(t, `
  7535. apex {
  7536. name: "myapex",
  7537. key: "myapex.key",
  7538. compressible: true,
  7539. updatable: false,
  7540. }
  7541. apex_key {
  7542. name: "myapex.key",
  7543. public_key: "testkey.avbpubkey",
  7544. private_key: "testkey.pem",
  7545. }
  7546. `,
  7547. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  7548. variables.CompressedApex = proptools.BoolPtr(true)
  7549. }),
  7550. )
  7551. compressRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("compressRule")
  7552. ensureContains(t, compressRule.Output.String(), "myapex.capex.unsigned")
  7553. signApkRule := ctx.ModuleForTests("myapex", "android_common_myapex_image").Description("sign compressedApex")
  7554. ensureEquals(t, signApkRule.Input.String(), compressRule.Output.String())
  7555. // Make sure output of bundle is .capex
  7556. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7557. ensureContains(t, ab.outputFile.String(), "myapex.capex")
  7558. // Verify android.mk rules
  7559. data := android.AndroidMkDataForTest(t, ctx, ab)
  7560. var builder strings.Builder
  7561. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7562. androidMk := builder.String()
  7563. ensureContains(t, androidMk, "LOCAL_MODULE_STEM := myapex.capex\n")
  7564. }
  7565. func TestPreferredPrebuiltSharedLibDep(t *testing.T) {
  7566. ctx := testApex(t, `
  7567. apex {
  7568. name: "myapex",
  7569. key: "myapex.key",
  7570. native_shared_libs: ["mylib"],
  7571. updatable: false,
  7572. }
  7573. apex_key {
  7574. name: "myapex.key",
  7575. public_key: "testkey.avbpubkey",
  7576. private_key: "testkey.pem",
  7577. }
  7578. cc_library {
  7579. name: "mylib",
  7580. srcs: ["mylib.cpp"],
  7581. apex_available: ["myapex"],
  7582. shared_libs: ["otherlib"],
  7583. system_shared_libs: [],
  7584. }
  7585. cc_library {
  7586. name: "otherlib",
  7587. srcs: ["mylib.cpp"],
  7588. stubs: {
  7589. versions: ["current"],
  7590. },
  7591. }
  7592. cc_prebuilt_library_shared {
  7593. name: "otherlib",
  7594. prefer: true,
  7595. srcs: ["prebuilt.so"],
  7596. stubs: {
  7597. versions: ["current"],
  7598. },
  7599. }
  7600. `)
  7601. ab := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7602. data := android.AndroidMkDataForTest(t, ctx, ab)
  7603. var builder strings.Builder
  7604. data.Custom(&builder, ab.BaseModuleName(), "TARGET_", "", data)
  7605. androidMk := builder.String()
  7606. // The make level dependency needs to be on otherlib - prebuilt_otherlib isn't
  7607. // a thing there.
  7608. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherlib\n")
  7609. }
  7610. func TestExcludeDependency(t *testing.T) {
  7611. ctx := testApex(t, `
  7612. apex {
  7613. name: "myapex",
  7614. key: "myapex.key",
  7615. native_shared_libs: ["mylib"],
  7616. updatable: false,
  7617. }
  7618. apex_key {
  7619. name: "myapex.key",
  7620. public_key: "testkey.avbpubkey",
  7621. private_key: "testkey.pem",
  7622. }
  7623. cc_library {
  7624. name: "mylib",
  7625. srcs: ["mylib.cpp"],
  7626. system_shared_libs: [],
  7627. stl: "none",
  7628. apex_available: ["myapex"],
  7629. shared_libs: ["mylib2"],
  7630. target: {
  7631. apex: {
  7632. exclude_shared_libs: ["mylib2"],
  7633. },
  7634. },
  7635. }
  7636. cc_library {
  7637. name: "mylib2",
  7638. srcs: ["mylib.cpp"],
  7639. system_shared_libs: [],
  7640. stl: "none",
  7641. }
  7642. `)
  7643. // Check if mylib is linked to mylib2 for the non-apex target
  7644. ldFlags := ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared").Rule("ld").Args["libFlags"]
  7645. ensureContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared/mylib2.so")
  7646. // Make sure that the link doesn't occur for the apex target
  7647. ldFlags = ctx.ModuleForTests("mylib", "android_arm64_armv8-a_shared_apex10000").Rule("ld").Args["libFlags"]
  7648. ensureNotContains(t, ldFlags, "mylib2/android_arm64_armv8-a_shared_apex10000/mylib2.so")
  7649. // It shouldn't appear in the copy cmd as well.
  7650. copyCmds := ctx.ModuleForTests("myapex", "android_common_myapex_image").Rule("apexRule").Args["copy_commands"]
  7651. ensureNotContains(t, copyCmds, "image.apex/lib64/mylib2.so")
  7652. }
  7653. func TestPrebuiltStubLibDep(t *testing.T) {
  7654. bpBase := `
  7655. apex {
  7656. name: "myapex",
  7657. key: "myapex.key",
  7658. native_shared_libs: ["mylib"],
  7659. updatable: false,
  7660. }
  7661. apex_key {
  7662. name: "myapex.key",
  7663. public_key: "testkey.avbpubkey",
  7664. private_key: "testkey.pem",
  7665. }
  7666. cc_library {
  7667. name: "mylib",
  7668. srcs: ["mylib.cpp"],
  7669. apex_available: ["myapex"],
  7670. shared_libs: ["stublib"],
  7671. system_shared_libs: [],
  7672. }
  7673. apex {
  7674. name: "otherapex",
  7675. enabled: %s,
  7676. key: "myapex.key",
  7677. native_shared_libs: ["stublib"],
  7678. updatable: false,
  7679. }
  7680. `
  7681. stublibSourceBp := `
  7682. cc_library {
  7683. name: "stublib",
  7684. srcs: ["mylib.cpp"],
  7685. apex_available: ["otherapex"],
  7686. system_shared_libs: [],
  7687. stl: "none",
  7688. stubs: {
  7689. versions: ["1"],
  7690. },
  7691. }
  7692. `
  7693. stublibPrebuiltBp := `
  7694. cc_prebuilt_library_shared {
  7695. name: "stublib",
  7696. srcs: ["prebuilt.so"],
  7697. apex_available: ["otherapex"],
  7698. stubs: {
  7699. versions: ["1"],
  7700. },
  7701. %s
  7702. }
  7703. `
  7704. tests := []struct {
  7705. name string
  7706. stublibBp string
  7707. usePrebuilt bool
  7708. modNames []string // Modules to collect AndroidMkEntries for
  7709. otherApexEnabled []string
  7710. }{
  7711. {
  7712. name: "only_source",
  7713. stublibBp: stublibSourceBp,
  7714. usePrebuilt: false,
  7715. modNames: []string{"stublib"},
  7716. otherApexEnabled: []string{"true", "false"},
  7717. },
  7718. {
  7719. name: "source_preferred",
  7720. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, ""),
  7721. usePrebuilt: false,
  7722. modNames: []string{"stublib", "prebuilt_stublib"},
  7723. otherApexEnabled: []string{"true", "false"},
  7724. },
  7725. {
  7726. name: "prebuilt_preferred",
  7727. stublibBp: stublibSourceBp + fmt.Sprintf(stublibPrebuiltBp, "prefer: true,"),
  7728. usePrebuilt: true,
  7729. modNames: []string{"stublib", "prebuilt_stublib"},
  7730. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7731. },
  7732. {
  7733. name: "only_prebuilt",
  7734. stublibBp: fmt.Sprintf(stublibPrebuiltBp, ""),
  7735. usePrebuilt: true,
  7736. modNames: []string{"stublib"},
  7737. otherApexEnabled: []string{"false"}, // No "true" since APEX cannot depend on prebuilt.
  7738. },
  7739. }
  7740. for _, test := range tests {
  7741. t.Run(test.name, func(t *testing.T) {
  7742. for _, otherApexEnabled := range test.otherApexEnabled {
  7743. t.Run("otherapex_enabled_"+otherApexEnabled, func(t *testing.T) {
  7744. ctx := testApex(t, fmt.Sprintf(bpBase, otherApexEnabled)+test.stublibBp)
  7745. type modAndMkEntries struct {
  7746. mod *cc.Module
  7747. mkEntries android.AndroidMkEntries
  7748. }
  7749. entries := []*modAndMkEntries{}
  7750. // Gather shared lib modules that are installable
  7751. for _, modName := range test.modNames {
  7752. for _, variant := range ctx.ModuleVariantsForTests(modName) {
  7753. if !strings.HasPrefix(variant, "android_arm64_armv8-a_shared") {
  7754. continue
  7755. }
  7756. mod := ctx.ModuleForTests(modName, variant).Module().(*cc.Module)
  7757. if !mod.Enabled() || mod.IsHideFromMake() {
  7758. continue
  7759. }
  7760. for _, ent := range android.AndroidMkEntriesForTest(t, ctx, mod) {
  7761. if ent.Disabled {
  7762. continue
  7763. }
  7764. entries = append(entries, &modAndMkEntries{
  7765. mod: mod,
  7766. mkEntries: ent,
  7767. })
  7768. }
  7769. }
  7770. }
  7771. var entry *modAndMkEntries = nil
  7772. for _, ent := range entries {
  7773. if strings.Join(ent.mkEntries.EntryMap["LOCAL_MODULE"], ",") == "stublib" {
  7774. if entry != nil {
  7775. t.Errorf("More than one AndroidMk entry for \"stublib\": %s and %s", entry.mod, ent.mod)
  7776. } else {
  7777. entry = ent
  7778. }
  7779. }
  7780. }
  7781. if entry == nil {
  7782. t.Errorf("AndroidMk entry for \"stublib\" missing")
  7783. } else {
  7784. isPrebuilt := entry.mod.Prebuilt() != nil
  7785. if isPrebuilt != test.usePrebuilt {
  7786. t.Errorf("Wrong module for \"stublib\" AndroidMk entry: got prebuilt %t, want prebuilt %t", isPrebuilt, test.usePrebuilt)
  7787. }
  7788. if !entry.mod.IsStubs() {
  7789. t.Errorf("Module for \"stublib\" AndroidMk entry isn't a stub: %s", entry.mod)
  7790. }
  7791. if entry.mkEntries.EntryMap["LOCAL_NOT_AVAILABLE_FOR_PLATFORM"] != nil {
  7792. t.Errorf("AndroidMk entry for \"stublib\" has LOCAL_NOT_AVAILABLE_FOR_PLATFORM set: %+v", entry.mkEntries)
  7793. }
  7794. cflags := entry.mkEntries.EntryMap["LOCAL_EXPORT_CFLAGS"]
  7795. expected := "-D__STUBLIB_API__=10000"
  7796. if !android.InList(expected, cflags) {
  7797. t.Errorf("LOCAL_EXPORT_CFLAGS expected to have %q, but got %q", expected, cflags)
  7798. }
  7799. }
  7800. })
  7801. }
  7802. })
  7803. }
  7804. }
  7805. func TestHostApexInHostOnlyBuild(t *testing.T) {
  7806. testApex(t, `
  7807. apex {
  7808. name: "myapex",
  7809. host_supported: true,
  7810. key: "myapex.key",
  7811. updatable: false,
  7812. payload_type: "zip",
  7813. }
  7814. apex_key {
  7815. name: "myapex.key",
  7816. public_key: "testkey.avbpubkey",
  7817. private_key: "testkey.pem",
  7818. }
  7819. `,
  7820. android.FixtureModifyConfig(func(config android.Config) {
  7821. // We may not have device targets in all builds, e.g. in
  7822. // prebuilts/build-tools/build-prebuilts.sh
  7823. config.Targets[android.Android] = []android.Target{}
  7824. }))
  7825. }
  7826. func TestApexJavaCoverage(t *testing.T) {
  7827. bp := `
  7828. apex {
  7829. name: "myapex",
  7830. key: "myapex.key",
  7831. java_libs: ["mylib"],
  7832. bootclasspath_fragments: ["mybootclasspathfragment"],
  7833. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  7834. updatable: false,
  7835. }
  7836. apex_key {
  7837. name: "myapex.key",
  7838. public_key: "testkey.avbpubkey",
  7839. private_key: "testkey.pem",
  7840. }
  7841. java_library {
  7842. name: "mylib",
  7843. srcs: ["mylib.java"],
  7844. apex_available: ["myapex"],
  7845. compile_dex: true,
  7846. }
  7847. bootclasspath_fragment {
  7848. name: "mybootclasspathfragment",
  7849. contents: ["mybootclasspathlib"],
  7850. apex_available: ["myapex"],
  7851. hidden_api: {
  7852. split_packages: ["*"],
  7853. },
  7854. }
  7855. java_library {
  7856. name: "mybootclasspathlib",
  7857. srcs: ["mybootclasspathlib.java"],
  7858. apex_available: ["myapex"],
  7859. compile_dex: true,
  7860. }
  7861. systemserverclasspath_fragment {
  7862. name: "mysystemserverclasspathfragment",
  7863. contents: ["mysystemserverclasspathlib"],
  7864. apex_available: ["myapex"],
  7865. }
  7866. java_library {
  7867. name: "mysystemserverclasspathlib",
  7868. srcs: ["mysystemserverclasspathlib.java"],
  7869. apex_available: ["myapex"],
  7870. compile_dex: true,
  7871. }
  7872. `
  7873. result := android.GroupFixturePreparers(
  7874. PrepareForTestWithApexBuildComponents,
  7875. prepareForTestWithMyapex,
  7876. java.PrepareForTestWithJavaDefaultModules,
  7877. android.PrepareForTestWithAndroidBuildComponents,
  7878. android.FixtureWithRootAndroidBp(bp),
  7879. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  7880. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  7881. android.FixtureMergeEnv(map[string]string{
  7882. "EMMA_INSTRUMENT": "true",
  7883. }),
  7884. ).RunTest(t)
  7885. // Make sure jacoco ran on both mylib and mybootclasspathlib
  7886. if result.ModuleForTests("mylib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7887. t.Errorf("Failed to find jacoco rule for mylib")
  7888. }
  7889. if result.ModuleForTests("mybootclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7890. t.Errorf("Failed to find jacoco rule for mybootclasspathlib")
  7891. }
  7892. if result.ModuleForTests("mysystemserverclasspathlib", "android_common_apex10000").MaybeRule("jacoco").Rule == nil {
  7893. t.Errorf("Failed to find jacoco rule for mysystemserverclasspathlib")
  7894. }
  7895. }
  7896. func TestProhibitStaticExecutable(t *testing.T) {
  7897. testApexError(t, `executable mybin is static`, `
  7898. apex {
  7899. name: "myapex",
  7900. key: "myapex.key",
  7901. binaries: ["mybin"],
  7902. min_sdk_version: "29",
  7903. }
  7904. apex_key {
  7905. name: "myapex.key",
  7906. public_key: "testkey.avbpubkey",
  7907. private_key: "testkey.pem",
  7908. }
  7909. cc_binary {
  7910. name: "mybin",
  7911. srcs: ["mylib.cpp"],
  7912. relative_install_path: "foo/bar",
  7913. static_executable: true,
  7914. system_shared_libs: [],
  7915. stl: "none",
  7916. apex_available: [ "myapex" ],
  7917. min_sdk_version: "29",
  7918. }
  7919. `)
  7920. testApexError(t, `executable mybin.rust is static`, `
  7921. apex {
  7922. name: "myapex",
  7923. key: "myapex.key",
  7924. binaries: ["mybin.rust"],
  7925. min_sdk_version: "29",
  7926. }
  7927. apex_key {
  7928. name: "myapex.key",
  7929. public_key: "testkey.avbpubkey",
  7930. private_key: "testkey.pem",
  7931. }
  7932. rust_binary {
  7933. name: "mybin.rust",
  7934. srcs: ["foo.rs"],
  7935. static_executable: true,
  7936. apex_available: ["myapex"],
  7937. min_sdk_version: "29",
  7938. }
  7939. `)
  7940. }
  7941. func TestAndroidMk_DexpreoptBuiltInstalledForApex(t *testing.T) {
  7942. ctx := testApex(t, `
  7943. apex {
  7944. name: "myapex",
  7945. key: "myapex.key",
  7946. updatable: false,
  7947. java_libs: ["foo"],
  7948. }
  7949. apex_key {
  7950. name: "myapex.key",
  7951. public_key: "testkey.avbpubkey",
  7952. private_key: "testkey.pem",
  7953. }
  7954. java_library {
  7955. name: "foo",
  7956. srcs: ["foo.java"],
  7957. apex_available: ["myapex"],
  7958. installable: true,
  7959. }
  7960. `,
  7961. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7962. )
  7963. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  7964. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  7965. var builder strings.Builder
  7966. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  7967. androidMk := builder.String()
  7968. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex")
  7969. }
  7970. func TestAndroidMk_DexpreoptBuiltInstalledForApex_Prebuilt(t *testing.T) {
  7971. ctx := testApex(t, `
  7972. prebuilt_apex {
  7973. name: "myapex",
  7974. arch: {
  7975. arm64: {
  7976. src: "myapex-arm64.apex",
  7977. },
  7978. arm: {
  7979. src: "myapex-arm.apex",
  7980. },
  7981. },
  7982. exported_java_libs: ["foo"],
  7983. }
  7984. java_import {
  7985. name: "foo",
  7986. jars: ["foo.jar"],
  7987. apex_available: ["myapex"],
  7988. }
  7989. `,
  7990. dexpreopt.FixtureSetApexSystemServerJars("myapex:foo"),
  7991. )
  7992. prebuilt := ctx.ModuleForTests("myapex", "android_common_myapex").Module().(*Prebuilt)
  7993. entriesList := android.AndroidMkEntriesForTest(t, ctx, prebuilt)
  7994. mainModuleEntries := entriesList[0]
  7995. android.AssertArrayString(t,
  7996. "LOCAL_REQUIRED_MODULES",
  7997. mainModuleEntries.EntryMap["LOCAL_REQUIRED_MODULES"],
  7998. []string{
  7999. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.odex",
  8000. "foo-dexpreopt-arm64-apex@myapex@javalib@foo.jar@classes.vdex",
  8001. })
  8002. }
  8003. func TestAndroidMk_RequiredModules(t *testing.T) {
  8004. ctx := testApex(t, `
  8005. apex {
  8006. name: "myapex",
  8007. key: "myapex.key",
  8008. updatable: false,
  8009. java_libs: ["foo"],
  8010. required: ["otherapex"],
  8011. }
  8012. apex {
  8013. name: "otherapex",
  8014. key: "myapex.key",
  8015. updatable: false,
  8016. java_libs: ["foo"],
  8017. required: ["otherapex"],
  8018. }
  8019. apex_key {
  8020. name: "myapex.key",
  8021. public_key: "testkey.avbpubkey",
  8022. private_key: "testkey.pem",
  8023. }
  8024. java_library {
  8025. name: "foo",
  8026. srcs: ["foo.java"],
  8027. apex_available: ["myapex", "otherapex"],
  8028. installable: true,
  8029. }
  8030. `)
  8031. apexBundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8032. data := android.AndroidMkDataForTest(t, ctx, apexBundle)
  8033. var builder strings.Builder
  8034. data.Custom(&builder, apexBundle.BaseModuleName(), "TARGET_", "", data)
  8035. androidMk := builder.String()
  8036. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += otherapex")
  8037. }
  8038. func TestAndroidMk_RequiredDeps(t *testing.T) {
  8039. ctx := testApex(t, `
  8040. apex {
  8041. name: "myapex",
  8042. key: "myapex.key",
  8043. updatable: false,
  8044. }
  8045. apex_key {
  8046. name: "myapex.key",
  8047. public_key: "testkey.avbpubkey",
  8048. private_key: "testkey.pem",
  8049. }
  8050. `)
  8051. bundle := ctx.ModuleForTests("myapex", "android_common_myapex_image").Module().(*apexBundle)
  8052. bundle.requiredDeps = append(bundle.requiredDeps, "foo")
  8053. data := android.AndroidMkDataForTest(t, ctx, bundle)
  8054. var builder strings.Builder
  8055. data.Custom(&builder, bundle.BaseModuleName(), "TARGET_", "", data)
  8056. androidMk := builder.String()
  8057. ensureContains(t, androidMk, "LOCAL_REQUIRED_MODULES += foo")
  8058. flattenedBundle := ctx.ModuleForTests("myapex", "android_common_myapex_flattened").Module().(*apexBundle)
  8059. flattenedBundle.requiredDeps = append(flattenedBundle.requiredDeps, "foo")
  8060. flattenedData := android.AndroidMkDataForTest(t, ctx, flattenedBundle)
  8061. var flattenedBuilder strings.Builder
  8062. flattenedData.Custom(&flattenedBuilder, flattenedBundle.BaseModuleName(), "TARGET_", "", flattenedData)
  8063. flattenedAndroidMk := flattenedBuilder.String()
  8064. ensureContains(t, flattenedAndroidMk, "LOCAL_REQUIRED_MODULES += foo")
  8065. }
  8066. func TestApexOutputFileProducer(t *testing.T) {
  8067. for _, tc := range []struct {
  8068. name string
  8069. ref string
  8070. expected_data []string
  8071. }{
  8072. {
  8073. name: "test_using_output",
  8074. ref: ":myapex",
  8075. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.capex:myapex.capex"},
  8076. },
  8077. {
  8078. name: "test_using_apex",
  8079. ref: ":myapex{.apex}",
  8080. expected_data: []string{"out/soong/.intermediates/myapex/android_common_myapex_image/myapex.apex:myapex.apex"},
  8081. },
  8082. } {
  8083. t.Run(tc.name, func(t *testing.T) {
  8084. ctx := testApex(t, `
  8085. apex {
  8086. name: "myapex",
  8087. key: "myapex.key",
  8088. compressible: true,
  8089. updatable: false,
  8090. }
  8091. apex_key {
  8092. name: "myapex.key",
  8093. public_key: "testkey.avbpubkey",
  8094. private_key: "testkey.pem",
  8095. }
  8096. java_test {
  8097. name: "`+tc.name+`",
  8098. srcs: ["a.java"],
  8099. data: ["`+tc.ref+`"],
  8100. }
  8101. `,
  8102. android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
  8103. variables.CompressedApex = proptools.BoolPtr(true)
  8104. }))
  8105. javaTest := ctx.ModuleForTests(tc.name, "android_common").Module().(*java.Test)
  8106. data := android.AndroidMkEntriesForTest(t, ctx, javaTest)[0].EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
  8107. android.AssertStringPathsRelativeToTopEquals(t, "data", ctx.Config(), tc.expected_data, data)
  8108. })
  8109. }
  8110. }
  8111. func TestSdkLibraryCanHaveHigherMinSdkVersion(t *testing.T) {
  8112. preparer := android.GroupFixturePreparers(
  8113. PrepareForTestWithApexBuildComponents,
  8114. prepareForTestWithMyapex,
  8115. java.PrepareForTestWithJavaSdkLibraryFiles,
  8116. java.PrepareForTestWithJavaDefaultModules,
  8117. android.PrepareForTestWithAndroidBuildComponents,
  8118. dexpreopt.FixtureSetApexBootJars("myapex:mybootclasspathlib"),
  8119. dexpreopt.FixtureSetApexSystemServerJars("myapex:mysystemserverclasspathlib"),
  8120. )
  8121. // Test java_sdk_library in bootclasspath_fragment may define higher min_sdk_version than the apex
  8122. t.Run("bootclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  8123. preparer.RunTestWithBp(t, `
  8124. apex {
  8125. name: "myapex",
  8126. key: "myapex.key",
  8127. bootclasspath_fragments: ["mybootclasspathfragment"],
  8128. min_sdk_version: "30",
  8129. updatable: false,
  8130. }
  8131. apex_key {
  8132. name: "myapex.key",
  8133. public_key: "testkey.avbpubkey",
  8134. private_key: "testkey.pem",
  8135. }
  8136. bootclasspath_fragment {
  8137. name: "mybootclasspathfragment",
  8138. contents: ["mybootclasspathlib"],
  8139. apex_available: ["myapex"],
  8140. hidden_api: {
  8141. split_packages: ["*"],
  8142. },
  8143. }
  8144. java_sdk_library {
  8145. name: "mybootclasspathlib",
  8146. srcs: ["mybootclasspathlib.java"],
  8147. apex_available: ["myapex"],
  8148. compile_dex: true,
  8149. unsafe_ignore_missing_latest_api: true,
  8150. min_sdk_version: "31",
  8151. static_libs: ["util"],
  8152. }
  8153. java_library {
  8154. name: "util",
  8155. srcs: ["a.java"],
  8156. apex_available: ["myapex"],
  8157. min_sdk_version: "31",
  8158. static_libs: ["another_util"],
  8159. }
  8160. java_library {
  8161. name: "another_util",
  8162. srcs: ["a.java"],
  8163. min_sdk_version: "31",
  8164. apex_available: ["myapex"],
  8165. }
  8166. `)
  8167. })
  8168. // Test java_sdk_library in systemserverclasspath_fragment may define higher min_sdk_version than the apex
  8169. t.Run("systemserverclasspath_fragment jar has higher min_sdk_version than apex", func(t *testing.T) {
  8170. preparer.RunTestWithBp(t, `
  8171. apex {
  8172. name: "myapex",
  8173. key: "myapex.key",
  8174. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8175. min_sdk_version: "30",
  8176. updatable: false,
  8177. }
  8178. apex_key {
  8179. name: "myapex.key",
  8180. public_key: "testkey.avbpubkey",
  8181. private_key: "testkey.pem",
  8182. }
  8183. systemserverclasspath_fragment {
  8184. name: "mysystemserverclasspathfragment",
  8185. contents: ["mysystemserverclasspathlib"],
  8186. apex_available: ["myapex"],
  8187. }
  8188. java_sdk_library {
  8189. name: "mysystemserverclasspathlib",
  8190. srcs: ["mysystemserverclasspathlib.java"],
  8191. apex_available: ["myapex"],
  8192. compile_dex: true,
  8193. min_sdk_version: "32",
  8194. unsafe_ignore_missing_latest_api: true,
  8195. static_libs: ["util"],
  8196. }
  8197. java_library {
  8198. name: "util",
  8199. srcs: ["a.java"],
  8200. apex_available: ["myapex"],
  8201. min_sdk_version: "31",
  8202. static_libs: ["another_util"],
  8203. }
  8204. java_library {
  8205. name: "another_util",
  8206. srcs: ["a.java"],
  8207. min_sdk_version: "31",
  8208. apex_available: ["myapex"],
  8209. }
  8210. `)
  8211. })
  8212. t.Run("bootclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  8213. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mybootclasspathlib".*must set min_sdk_version`)).
  8214. RunTestWithBp(t, `
  8215. apex {
  8216. name: "myapex",
  8217. key: "myapex.key",
  8218. bootclasspath_fragments: ["mybootclasspathfragment"],
  8219. min_sdk_version: "30",
  8220. updatable: false,
  8221. }
  8222. apex_key {
  8223. name: "myapex.key",
  8224. public_key: "testkey.avbpubkey",
  8225. private_key: "testkey.pem",
  8226. }
  8227. bootclasspath_fragment {
  8228. name: "mybootclasspathfragment",
  8229. contents: ["mybootclasspathlib"],
  8230. apex_available: ["myapex"],
  8231. hidden_api: {
  8232. split_packages: ["*"],
  8233. },
  8234. }
  8235. java_sdk_library {
  8236. name: "mybootclasspathlib",
  8237. srcs: ["mybootclasspathlib.java"],
  8238. apex_available: ["myapex"],
  8239. compile_dex: true,
  8240. unsafe_ignore_missing_latest_api: true,
  8241. }
  8242. `)
  8243. })
  8244. t.Run("systemserverclasspath_fragment jar must set min_sdk_version", func(t *testing.T) {
  8245. preparer.ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(`module "mysystemserverclasspathlib".*must set min_sdk_version`)).
  8246. RunTestWithBp(t, `
  8247. apex {
  8248. name: "myapex",
  8249. key: "myapex.key",
  8250. systemserverclasspath_fragments: ["mysystemserverclasspathfragment"],
  8251. min_sdk_version: "30",
  8252. updatable: false,
  8253. }
  8254. apex_key {
  8255. name: "myapex.key",
  8256. public_key: "testkey.avbpubkey",
  8257. private_key: "testkey.pem",
  8258. }
  8259. systemserverclasspath_fragment {
  8260. name: "mysystemserverclasspathfragment",
  8261. contents: ["mysystemserverclasspathlib"],
  8262. apex_available: ["myapex"],
  8263. }
  8264. java_sdk_library {
  8265. name: "mysystemserverclasspathlib",
  8266. srcs: ["mysystemserverclasspathlib.java"],
  8267. apex_available: ["myapex"],
  8268. compile_dex: true,
  8269. unsafe_ignore_missing_latest_api: true,
  8270. }
  8271. `)
  8272. })
  8273. }
  8274. // Verifies that the APEX depends on all the Make modules in the list.
  8275. func ensureContainsRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  8276. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  8277. for _, dep := range deps {
  8278. android.AssertStringListContains(t, "", a.requiredDeps, dep)
  8279. }
  8280. }
  8281. // Verifies that the APEX does not depend on any of the Make modules in the list.
  8282. func ensureDoesNotContainRequiredDeps(t *testing.T, ctx *android.TestContext, moduleName, variant string, deps []string) {
  8283. a := ctx.ModuleForTests(moduleName, variant).Module().(*apexBundle)
  8284. for _, dep := range deps {
  8285. android.AssertStringListDoesNotContain(t, "", a.requiredDeps, dep)
  8286. }
  8287. }
  8288. func TestApexStrictUpdtabilityLint(t *testing.T) {
  8289. bpTemplate := `
  8290. apex {
  8291. name: "myapex",
  8292. key: "myapex.key",
  8293. java_libs: ["myjavalib"],
  8294. updatable: %v,
  8295. min_sdk_version: "29",
  8296. }
  8297. apex_key {
  8298. name: "myapex.key",
  8299. }
  8300. java_library {
  8301. name: "myjavalib",
  8302. srcs: ["MyClass.java"],
  8303. apex_available: [ "myapex" ],
  8304. lint: {
  8305. strict_updatability_linting: %v,
  8306. },
  8307. sdk_version: "current",
  8308. min_sdk_version: "29",
  8309. }
  8310. `
  8311. fs := android.MockFS{
  8312. "lint-baseline.xml": nil,
  8313. }
  8314. testCases := []struct {
  8315. testCaseName string
  8316. apexUpdatable bool
  8317. javaStrictUpdtabilityLint bool
  8318. lintFileExists bool
  8319. disallowedFlagExpected bool
  8320. }{
  8321. {
  8322. testCaseName: "lint-baseline.xml does not exist, no disallowed flag necessary in lint cmd",
  8323. apexUpdatable: true,
  8324. javaStrictUpdtabilityLint: true,
  8325. lintFileExists: false,
  8326. disallowedFlagExpected: false,
  8327. },
  8328. {
  8329. testCaseName: "non-updatable apex respects strict_updatability of javalib",
  8330. apexUpdatable: false,
  8331. javaStrictUpdtabilityLint: false,
  8332. lintFileExists: true,
  8333. disallowedFlagExpected: false,
  8334. },
  8335. {
  8336. testCaseName: "non-updatable apex respects strict updatability of javalib",
  8337. apexUpdatable: false,
  8338. javaStrictUpdtabilityLint: true,
  8339. lintFileExists: true,
  8340. disallowedFlagExpected: true,
  8341. },
  8342. {
  8343. testCaseName: "updatable apex sets strict updatability of javalib to true",
  8344. apexUpdatable: true,
  8345. javaStrictUpdtabilityLint: false, // will be set to true by mutator
  8346. lintFileExists: true,
  8347. disallowedFlagExpected: true,
  8348. },
  8349. }
  8350. for _, testCase := range testCases {
  8351. bp := fmt.Sprintf(bpTemplate, testCase.apexUpdatable, testCase.javaStrictUpdtabilityLint)
  8352. fixtures := []android.FixturePreparer{}
  8353. if testCase.lintFileExists {
  8354. fixtures = append(fixtures, fs.AddToFixture())
  8355. }
  8356. result := testApex(t, bp, fixtures...)
  8357. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8358. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8359. disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi")
  8360. if disallowedFlagActual != testCase.disallowedFlagExpected {
  8361. t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  8362. }
  8363. }
  8364. }
  8365. func TestUpdatabilityLintSkipLibcore(t *testing.T) {
  8366. bp := `
  8367. apex {
  8368. name: "myapex",
  8369. key: "myapex.key",
  8370. java_libs: ["myjavalib"],
  8371. updatable: true,
  8372. min_sdk_version: "29",
  8373. }
  8374. apex_key {
  8375. name: "myapex.key",
  8376. }
  8377. java_library {
  8378. name: "myjavalib",
  8379. srcs: ["MyClass.java"],
  8380. apex_available: [ "myapex" ],
  8381. sdk_version: "current",
  8382. min_sdk_version: "29",
  8383. }
  8384. `
  8385. testCases := []struct {
  8386. testCaseName string
  8387. moduleDirectory string
  8388. disallowedFlagExpected bool
  8389. }{
  8390. {
  8391. testCaseName: "lintable module defined outside libcore",
  8392. moduleDirectory: "",
  8393. disallowedFlagExpected: true,
  8394. },
  8395. {
  8396. testCaseName: "lintable module defined in libcore root directory",
  8397. moduleDirectory: "libcore/",
  8398. disallowedFlagExpected: false,
  8399. },
  8400. {
  8401. testCaseName: "lintable module defined in libcore child directory",
  8402. moduleDirectory: "libcore/childdir/",
  8403. disallowedFlagExpected: true,
  8404. },
  8405. }
  8406. for _, testCase := range testCases {
  8407. lintFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"lint-baseline.xml", "")
  8408. bpFileCreator := android.FixtureAddTextFile(testCase.moduleDirectory+"Android.bp", bp)
  8409. result := testApex(t, "", lintFileCreator, bpFileCreator)
  8410. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8411. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8412. cmdFlags := fmt.Sprintf("--baseline %vlint-baseline.xml --disallowed_issues NewApi", testCase.moduleDirectory)
  8413. disallowedFlagActual := strings.Contains(*sboxProto.Commands[0].Command, cmdFlags)
  8414. if disallowedFlagActual != testCase.disallowedFlagExpected {
  8415. t.Errorf("Failed testcase: %v \nActual lint cmd: %v", testCase.testCaseName, *sboxProto.Commands[0].Command)
  8416. }
  8417. }
  8418. }
  8419. // checks transtive deps of an apex coming from bootclasspath_fragment
  8420. func TestApexStrictUpdtabilityLintBcpFragmentDeps(t *testing.T) {
  8421. bp := `
  8422. apex {
  8423. name: "myapex",
  8424. key: "myapex.key",
  8425. bootclasspath_fragments: ["mybootclasspathfragment"],
  8426. updatable: true,
  8427. min_sdk_version: "29",
  8428. }
  8429. apex_key {
  8430. name: "myapex.key",
  8431. }
  8432. bootclasspath_fragment {
  8433. name: "mybootclasspathfragment",
  8434. contents: ["myjavalib"],
  8435. apex_available: ["myapex"],
  8436. hidden_api: {
  8437. split_packages: ["*"],
  8438. },
  8439. }
  8440. java_library {
  8441. name: "myjavalib",
  8442. srcs: ["MyClass.java"],
  8443. apex_available: [ "myapex" ],
  8444. sdk_version: "current",
  8445. min_sdk_version: "29",
  8446. compile_dex: true,
  8447. }
  8448. `
  8449. fs := android.MockFS{
  8450. "lint-baseline.xml": nil,
  8451. }
  8452. result := testApex(t, bp, dexpreopt.FixtureSetApexBootJars("myapex:myjavalib"), fs.AddToFixture())
  8453. myjavalib := result.ModuleForTests("myjavalib", "android_common_apex29")
  8454. sboxProto := android.RuleBuilderSboxProtoForTests(t, myjavalib.Output("lint.sbox.textproto"))
  8455. if !strings.Contains(*sboxProto.Commands[0].Command, "--baseline lint-baseline.xml --disallowed_issues NewApi") {
  8456. t.Errorf("Strict updabality lint missing in myjavalib coming from bootclasspath_fragment mybootclasspath-fragment\nActual lint cmd: %v", *sboxProto.Commands[0].Command)
  8457. }
  8458. }
  8459. // updatable apexes should propagate updatable=true to its apps
  8460. func TestUpdatableApexEnforcesAppUpdatability(t *testing.T) {
  8461. bp := `
  8462. apex {
  8463. name: "myapex",
  8464. key: "myapex.key",
  8465. updatable: %v,
  8466. apps: [
  8467. "myapp",
  8468. ],
  8469. min_sdk_version: "30",
  8470. }
  8471. apex_key {
  8472. name: "myapex.key",
  8473. }
  8474. android_app {
  8475. name: "myapp",
  8476. updatable: %v,
  8477. apex_available: [
  8478. "myapex",
  8479. ],
  8480. sdk_version: "current",
  8481. min_sdk_version: "30",
  8482. }
  8483. `
  8484. testCases := []struct {
  8485. name string
  8486. apex_is_updatable_bp bool
  8487. app_is_updatable_bp bool
  8488. app_is_updatable_expected bool
  8489. }{
  8490. {
  8491. name: "Non-updatable apex respects updatable property of non-updatable app",
  8492. apex_is_updatable_bp: false,
  8493. app_is_updatable_bp: false,
  8494. app_is_updatable_expected: false,
  8495. },
  8496. {
  8497. name: "Non-updatable apex respects updatable property of updatable app",
  8498. apex_is_updatable_bp: false,
  8499. app_is_updatable_bp: true,
  8500. app_is_updatable_expected: true,
  8501. },
  8502. {
  8503. name: "Updatable apex respects updatable property of updatable app",
  8504. apex_is_updatable_bp: true,
  8505. app_is_updatable_bp: true,
  8506. app_is_updatable_expected: true,
  8507. },
  8508. {
  8509. name: "Updatable apex sets updatable=true on non-updatable app",
  8510. apex_is_updatable_bp: true,
  8511. app_is_updatable_bp: false,
  8512. app_is_updatable_expected: true,
  8513. },
  8514. }
  8515. for _, testCase := range testCases {
  8516. result := testApex(t, fmt.Sprintf(bp, testCase.apex_is_updatable_bp, testCase.app_is_updatable_bp))
  8517. myapp := result.ModuleForTests("myapp", "android_common").Module().(*java.AndroidApp)
  8518. android.AssertBoolEquals(t, testCase.name, testCase.app_is_updatable_expected, myapp.Updatable())
  8519. }
  8520. }
  8521. func TestMain(m *testing.M) {
  8522. os.Exit(m.Run())
  8523. }