Преглед на файлове

Don't type variables as booleans in mk2rbc

Our boolean support is not fully fleshed out enough to make variables
real booleans. Keep them strings for now to resolve CI failures.

Bug: 275865081
Test: ./build/bazel/ci/rbc_dashboard.py --quick with aosp/2526609
Change-Id: I636bd9f39b50a47ecf92aecd2bf8ea41eac4d604
Cole Faust преди 1 година
родител
ревизия
c7335de0dd
променени са 1 файла, в които са добавени 5 реда и са изтрити 1 реда
  1. 5 1
      mk2rbc/soong_variables.go

+ 5 - 1
mk2rbc/soong_variables.go

@@ -67,7 +67,11 @@ func (ctx context) NewSoongVariable(name, typeString string) {
 	var valueType starlarkType
 	switch typeString {
 	case "bool":
-		valueType = starlarkTypeBool
+		// TODO: We run into several issues later on if we type this as a bool:
+		//    - We still assign bool-typed variables to strings
+		//    - When emitting the final results as make code, some bool's false values have to
+		//      be an empty string, and some have to be false in order to match the make variables.
+		valueType = starlarkTypeString
 	case "csv":
 		// Only PLATFORM_VERSION_ALL_CODENAMES, and it's a list
 		valueType = starlarkTypeList