Browse Source

Make a pass over our codebase cleaning up non-precise / non-inclusive language.

Test: treehugger
Bug: 204369779
Change-Id: I6e63cae824d323535cdb14b493edd868df47738d
Joe Onorato 2 years ago
parent
commit
b4638c1ac3
6 changed files with 6 additions and 6 deletions
  1. 1 1
      android/neverallow.go
  2. 1 1
      apex/builder.go
  3. 1 1
      cc/ndk_sysroot.go
  4. 1 1
      mk2rbc/cmd/mk2rbc.go
  5. 1 1
      mk2rbc/types.go
  6. 1 1
      third_party/zip/reader_test.go

+ 1 - 1
android/neverallow.go

@@ -27,7 +27,7 @@ import (
 // "neverallow" rules for the build system.
 //
 // This allows things which aren't related to the build system and are enforced
-// for sanity, in progress code refactors, or policy to be expressed in a
+// against assumptions, in progress code refactors, or policy to be expressed in a
 // straightforward away disjoint from implementations and tests which should
 // work regardless of these restrictions.
 //

+ 1 - 1
apex/builder.go

@@ -105,7 +105,7 @@ var (
 		Description: "convert ${in}=>${out}",
 	})
 
-	// TODO(b/113233103): make sure that file_contexts is sane, i.e., validate
+	// TODO(b/113233103): make sure that file_contexts is as expected, i.e., validate
 	// against the binary policy using sefcontext_compiler -p <policy>.
 
 	// TODO(b/114327326): automate the generation of file_contexts

+ 1 - 1
cc/ndk_sysroot.go

@@ -33,7 +33,7 @@ package cc
 // Component 3: Stub Libraries
 // The shared libraries in the NDK are not the actual shared libraries they
 // refer to (to prevent people from accidentally loading them), but stub
-// libraries with dummy implementations of everything for use at build time
+// libraries with placeholder implementations of everything for use at build time
 // only.
 //
 // Since we don't actually need to know anything about the stub libraries aside

+ 1 - 1
mk2rbc/cmd/mk2rbc.go

@@ -60,7 +60,7 @@ var (
 )
 
 func init() {
-	// Poor man's flag aliasing: works, but the usage string is ugly and
+	// Simplistic flag aliasing: works, but the usage string is ugly and
 	// both flag and its alias can be present on the command line
 	flagAlias := func(target string, alias string) {
 		if f := flag.Lookup(target); f != nil {

+ 1 - 1
mk2rbc/types.go

@@ -53,7 +53,7 @@ type variableRegistrar interface {
 	NewVariable(name string, varClass varClass, valueType starlarkType)
 }
 
-// ScopeBase is a dummy implementation of the mkparser.Scope.
+// ScopeBase is a placeholder implementation of the mkparser.Scope.
 // All our scopes are read-only and resolve only simple variables.
 type ScopeBase struct{}
 

+ 1 - 1
third_party/zip/reader_test.go

@@ -786,7 +786,7 @@ func TestIssue10957(t *testing.T) {
 	}
 }
 
-// Verify the number of files is sane.
+// Verify the number of files is within expected bounds
 func TestIssue10956(t *testing.T) {
 	data := []byte("PK\x06\x06PK\x06\a0000\x00\x00\x00\x00\x00\x00\x00\x00" +
 		"0000PK\x05\x06000000000000" +