|
@@ -1,10 +1,11 @@
|
|
|
+// SPDX-License-Identifier: GPL-2.0-only
|
|
|
/// NULL check before some freeing functions is not needed.
|
|
|
///
|
|
|
/// Based on checkpatch warning
|
|
|
/// "kfree(NULL) is safe this check is probably not required"
|
|
|
/// and kfreeaddr.cocci by Julia Lawall.
|
|
|
///
|
|
|
-// Copyright: (C) 2014 Fabian Frederick. GPLv2.
|
|
|
+// Copyright: (C) 2014 Fabian Frederick.
|
|
|
// Comments: -
|
|
|
// Options: --no-includes --include-headers
|
|
|
|
|
@@ -18,21 +19,19 @@ expression E;
|
|
|
@@
|
|
|
- if (E != NULL)
|
|
|
(
|
|
|
- kfree(E);
|
|
|
+ free(E);
|
|
|
|
|
|
|
- kzfree(E);
|
|
|
+ kfree(E);
|
|
|
|
|
|
|
- debugfs_remove(E);
|
|
|
+ vfree(E);
|
|
|
|
|
|
|
- debugfs_remove_recursive(E);
|
|
|
+ vfree_recursive(E);
|
|
|
|
|
|
|
- usb_free_urb(E);
|
|
|
+ kmem_cache_free(E);
|
|
|
|
|
|
|
kmem_cache_destroy(E);
|
|
|
|
|
|
|
- mempool_destroy(E);
|
|
|
-|
|
|
|
- dma_pool_destroy(E);
|
|
|
+ gzfree(E);
|
|
|
)
|
|
|
|
|
|
@r depends on context || report || org @
|
|
@@ -41,9 +40,8 @@ position p;
|
|
|
@@
|
|
|
|
|
|
* if (E != NULL)
|
|
|
-* \(kfree@p\|kzfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|
|
|
|
-* usb_free_urb@p\|kmem_cache_destroy@p\|mempool_destroy@p\|
|
|
|
-* dma_pool_destroy@p\)(E);
|
|
|
+* \(free@p\|kfree@p\|vfree@p\|debugfs_remove_recursive@p\|
|
|
|
+* kmem_cache_free@p\|kmem_cache_destroy@p\|gzfree@p\)(E);
|
|
|
|
|
|
@script:python depends on org@
|
|
|
p << r.p;
|
|
@@ -55,5 +53,5 @@ cocci.print_main("NULL check before that freeing function is not needed", p)
|
|
|
p << r.p;
|
|
|
@@
|
|
|
|
|
|
-msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
|
|
|
+msg = "WARNING: NULL check before some freeing functions is not needed."
|
|
|
coccilib.report.print_report(p[0], msg)
|