Browse Source

powerpc/mpc85xx: Display a warning for unsupported DDR data rates

If DDR initialziation uses a speed table and the speed is not matched,
print a warning message instead of silently ignoring.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
York Sun 13 years ago
parent
commit
939e5bf9b3

+ 6 - 0
board/freescale/corenet_ds/ddr.c

@@ -192,10 +192,16 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 			popts->clk_adjust = pbsp->clk_adjust;
 			popts->wrlvl_start = pbsp->wrlvl_start;
 			popts->twoT_en = pbsp->force_2T;
+			break;
 		}
 		pbsp++;
 	}
 
+	if (i == num_params) {
+		printf("Warning: board specific timing not found "
+			"for data rate %lu MT/s!\n", ddr_freq);
+	}
+
 	/*
 	 * Factors to consider for half-strength driver enable:
 	 *	- number of DIMMs installed

+ 4 - 4
board/freescale/mpc8572ds/ddr.c

@@ -104,7 +104,6 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 	u32 num_params;
 	u32 i;
 	ulong ddr_freq;
-	int matched = 0;
 
 	if (!pdimm->n_ranks)
 		return;
@@ -151,14 +150,15 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 			popts->cpo_override = pbsp->cpo;
 			popts->write_data_delay = pbsp->write_data_delay;
 			popts->twoT_en = pbsp->force_2T;
-			matched = 1;
 			break;
 		}
 		pbsp++;
 	}
 
-	if (!matched)
-		printf("Warning: board specific timing not found!\n");
+	if (i == num_params) {
+		printf("Warning: board specific timing not found "
+			"for data rate %lu MT/s!\n", ddr_freq);
+	}
 
 	/*
 	 * Factors to consider for half-strength driver enable:

+ 5 - 0
board/freescale/mpc8641hpcn/ddr.c

@@ -127,6 +127,11 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 		}
 	}
 
+	if (i == num_params) {
+		printf("Warning: board specific timing not found "
+			"for data rate %lu MT/s!\n", ddr_freq);
+	}
+
 	/* 2T timing enable */
 	popts->twoT_en = 1;
 }

+ 6 - 0
board/freescale/p2020ds/ddr.c

@@ -83,10 +83,16 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 			popts->cpo_override = pbsp->cpo;
 			popts->write_data_delay = pbsp->write_data_delay;
 			popts->twoT_en = pbsp->force_2T;
+			break;
 		}
 		pbsp++;
 	}
 
+	if (i == num_params) {
+		printf("Warning: board specific timing not found "
+			"for data rate %lu MT/s!\n", ddr_freq);
+	}
+
 	/*
 	 * Factors to consider for half-strength driver enable:
 	 *	- number of DIMMs installed

+ 6 - 0
board/xes/xpedite550x/ddr.c

@@ -125,10 +125,16 @@ void fsl_ddr_board_options(memctl_options_t *popts,
 			popts->clk_adjust = pbsp->clk_adjust;
 			popts->cpo_override = pbsp->cpo;
 			popts->twoT_en = 0;
+			break;
 		}
 		pbsp++;
 	}
 
+	if (i == num_params) {
+		printf("Warning: board specific timing not found "
+		"for data rate %lu MT/s!\n", ddr_freq);
+	}
+
 	/*
 	 * Factors to consider for half-strength driver enable:
 	 *	- number of DIMMs installed