Browse Source

scripts: ensure the cocci script for miiphy_register does not leak the MDIO bus

When mdio_register fails, mdio_free should be called on the mdiodev that
was previously allocated with mdio_alloc.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Vladimir Oltean 2 years ago
parent
commit
4df9f5e39f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      scripts/coccinelle/net/mdio_register.cocci

+ 1 - 1
scripts/coccinelle/net/mdio_register.cocci

@@ -21,7 +21,7 @@ identifier readfunc, writefunc;
 + mdiodev->write = writefunc;
 + 
 + retval = mdio_register(mdiodev);
-+ if (retval < 0) return retval;
++ if (retval < 0) { mdio_free(mdiodev); return retval; }
 
 @ update_read_sig @
 identifier mii_reg.readfunc;