Browse Source

enable breakpad: breakpad build issue has been resolved

Signed-off-by: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
Rebecca Chang Swee Fun 1 year ago
parent
commit
20f51eca59

+ 0 - 115
0043-BUILD.gn-remove-dependency-to-breakpad.patch

@@ -1,115 +0,0 @@
-From 277ffdbdb215c9af6757ffa9ce3466762b95fa41 Mon Sep 17 00:00:00 2001
-From: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
-Date: Fri, 15 Jul 2022 07:12:43 +0000
-Subject: [PATCH 43/51] BUILD.gn: remove dependency to breakpad
-
-Signed-off-by: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
----
- BUILD.gn | 36 ------------------------------------
- 1 file changed, 36 deletions(-)
-
-diff --git a/BUILD.gn b/BUILD.gn
-index 9971e594a5be..72c25f93bbc3 100644
---- a/BUILD.gn
-+++ b/BUILD.gn
-@@ -440,10 +440,6 @@ group("gn_all") {
- 
-   if (is_linux || is_chromeos || is_android) {
-     deps += [
--      "//third_party/breakpad:breakpad_unittests",
--      "//third_party/breakpad:core-2-minidump",
--      "//third_party/breakpad:generate_test_dump",
--      "//third_party/breakpad:minidump-2-core",
-       "//tools/dump_process_memory:dump_process",
-       "//tools/memory/partition_allocator:all",
-     ]
-@@ -601,10 +597,6 @@ group("gn_all") {
-       "//mojo:mojo_perftests",
-       "//services/service_manager/public/cpp",
-       "//testing/gmock:gmock_main",
--      "//third_party/breakpad:dump_syms($host_toolchain)",
--      "//third_party/breakpad:microdump_stackwalk($host_toolchain)",
--      "//third_party/breakpad:minidump_dump($host_toolchain)",
--      "//third_party/breakpad:minidump_stackwalk($host_toolchain)",
-     ]
- 
-     if (!is_android) {
-@@ -630,9 +622,6 @@ group("gn_all") {
- 
-   if (is_mac) {
-     deps += [
--      "//third_party/breakpad:crash_inspector",
--      "//third_party/breakpad:dump_syms",
--
-       # The following are accessibility API tools.
-       "//tools/accessibility/inspect:ax_dump_events",
-       "//tools/accessibility/inspect:ax_dump_tree",
-@@ -677,8 +666,6 @@ group("gn_all") {
-         host_os == "win") {
-       deps += [ "//chrome/test/mini_installer:mini_installer_tests" ]
-     }
--  } else if (!is_android && !is_ios && !is_fuchsia) {
--    deps += [ "//third_party/breakpad:symupload($host_toolchain)" ]
-   }
- 
-   if (is_chromecast) {
-@@ -960,7 +947,6 @@ if (is_win) {
-       "//net:net_unittests",
-       "//printing:printing_unittests",
-       "//sql:sql_unittests",
--      "//third_party/breakpad:symupload($host_toolchain)",
-       "//ui/base:ui_base_unittests",
-       "//ui/gfx:gfx_unittests",
-       "//ui/touch_selection:ui_touch_selection_unittests",
-@@ -987,7 +973,6 @@ if (is_chromeos_ash) {
-       "//ppapi/examples/video_decode",
-       "//sandbox/linux:chrome_sandbox",
-       "//sandbox/linux:sandbox_linux_unittests",
--      "//third_party/breakpad:minidump_stackwalk($host_toolchain)",
-       "//third_party/dawn/src/dawn/tests:dawn_end2end_tests",
-       "//third_party/dawn/src/dawn/tests:dawn_unittests",
- 
-@@ -1134,30 +1119,12 @@ if (!is_ios) {
- 
-     if (is_android) {
-       data_deps += [
--        "//third_party/breakpad:breakpad_unittests",
--        "//third_party/breakpad:dump_syms",
--        "//third_party/breakpad:microdump_stackwalk",
--        "//third_party/breakpad:minidump_dump",
--        "//third_party/breakpad:minidump_stackwalk",
--        "//third_party/breakpad:symupload",
-         "//tools/android/forwarder2",
-       ]
-     } else {
-       data_deps += [ "//content/web_test:web_test_common_mojom_js_data_deps" ]
-     }
- 
--    if (!is_win && !is_android) {
--      data_deps +=
--          [ "//third_party/breakpad:minidump_stackwalk($host_toolchain)" ]
--    }
--
--    if (is_mac) {
--      data_deps += [ "//third_party/breakpad:dump_syms($host_toolchain)" ]
--    }
--
--    if (is_linux || is_chromeos) {
--      data_deps += [ "//third_party/breakpad:dump_syms($host_toolchain)" ]
--    }
- 
-     if (is_fuchsia) {
-       data_deps += [
-@@ -1545,9 +1512,6 @@ group("chromium_builder_perf") {
- 
-     if (is_win) {
-       data_deps += [ "//chrome/installer/mini_installer:mini_installer" ]
--    } else {
--      data_deps +=
--          [ "//third_party/breakpad:minidump_stackwalk($host_toolchain)" ]
-     }
-     if (is_win || is_android) {
-       data_deps += [
--- 
-2.25.1
-

+ 0 - 64
0044-tools-perf-chrome_telemetry_build-remove-dependency-.patch

@@ -1,64 +0,0 @@
-From 7c2376f86c6778cc7b4b9acb09caefeb5a0096a5 Mon Sep 17 00:00:00 2001
-From: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
-Date: Mon, 18 Jul 2022 01:08:21 +0000
-Subject: [PATCH 44/51] tools: perf: chrome_telemetry_build: remove dependency
- to breakpad
-
-Signed-off-by: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
----
- tools/perf/chrome_telemetry_build/BUILD.gn | 18 ------------------
- 1 file changed, 18 deletions(-)
-
-diff --git a/tools/perf/chrome_telemetry_build/BUILD.gn b/tools/perf/chrome_telemetry_build/BUILD.gn
-index 2d6c25ea2d0b..d782d15bc70e 100644
---- a/tools/perf/chrome_telemetry_build/BUILD.gn
-+++ b/tools/perf/chrome_telemetry_build/BUILD.gn
-@@ -46,8 +46,6 @@ group("telemetry_chrome_test") {
-   }
- 
-   if (is_linux || is_chromeos) {
--    data_deps += [ "//third_party/breakpad:dump_syms($host_toolchain)" ]
--
-     # CrOS currently has issues with the locally compiled version of
-     # crashpad_database_util, so only include it on traditional Linux
-     # platforms.
-@@ -61,7 +59,6 @@ group("telemetry_chrome_test") {
-     data_deps += [
-       "//chrome:chrome_framework",
-       "//chrome:chrome_helper_app_default",
--      "//third_party/breakpad:dump_syms",
-       "//third_party/crashpad/crashpad/tools:crashpad_database_util",
-     ]
-   }
-@@ -201,7 +198,6 @@ group("telemetry_chrome_test_without_chrome") {
- 
-   data = [
-     "//build/android/pylib/",  # chromium_config.py uses pylib to look for Java
--    "//components/crash/content/tools/generate_breakpad_symbols.py",
-     "//tools/perf/chrome_telemetry_build/",
-     "//tools/perf/core/",  # chrome_telemetry_build/ depends on core/
-   ]
-@@ -211,20 +207,6 @@ group("telemetry_chrome_test_without_chrome") {
-     "//tools/metrics:metrics_python_tests",
-   ]
- 
--  # Cr-Fuchsia doesn't support breakpad.
--  if (!is_win && !is_fuchsia) {
--    data_deps += [
--      # This is defined for Windows, but is unused by Telemetry on
--      # Windows, and including it can have issues when cross-compiling
--      # for Arm-based Windows.
--      "//third_party/breakpad:dump_syms",
--
--      # These explicitly not defined for Windows builds in Breakpad.
--      "//third_party/breakpad:minidump_dump",
--      "//third_party/breakpad:minidump_stackwalk",
--    ]
--  }
--
-   if (is_mac) {
-     data += [
-       # Required for the hermetic otool binary, which is required for
--- 
-2.25.1
-

+ 0 - 35
0045-chrome-test-remove-dependency-to-breakpad.patch

@@ -1,35 +0,0 @@
-From ea9f17b755a42112c4ce9091c0fdc12d4635d904 Mon Sep 17 00:00:00 2001
-From: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
-Date: Mon, 18 Jul 2022 01:15:47 +0000
-Subject: [PATCH 45/51] chrome: test: remove dependency to breakpad
-
-Signed-off-by: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
----
- chrome/test/BUILD.gn | 4 ----
- 1 file changed, 4 deletions(-)
-
-diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
-index a55d15860d58..dfa043daf2bc 100644
---- a/chrome/test/BUILD.gn
-+++ b/chrome/test/BUILD.gn
-@@ -401,7 +401,6 @@ static_library("test_support") {
-     ]
-     public_deps += [
-       "//components/crash/core/app",
--      "//third_party/breakpad",
-     ]
-   }
- 
-@@ -9298,9 +9297,6 @@ test("chrome_app_unittests") {
-     "//components/heap_profiling/in_process",
-     "//components/safe_browsing:buildflags",
-   ]
--  if (!is_fuchsia) {
--    deps += [ "//third_party/breakpad:client" ]
--  }
-   if (enable_gwp_asan) {
-     deps += [ "//components/gwp_asan/client" ]
-   }
--- 
-2.25.1
-

+ 0 - 68
0046-content-shell-remove-dependency-to-breakpad.patch

@@ -1,68 +0,0 @@
-From 20b697d625110386013e5e76b315aa0e70a503e5 Mon Sep 17 00:00:00 2001
-From: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
-Date: Mon, 18 Jul 2022 01:19:03 +0000
-Subject: [PATCH 46/51] content: shell: remove dependency to breakpad
-
-Signed-off-by: Rebecca Chang Swee Fun <rebecca.chang@starfivetech.com>
----
- content/shell/BUILD.gn | 13 -------------
- 1 file changed, 13 deletions(-)
-
-diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
-index 2f83c8802711..abcf4c69b1ba 100644
---- a/content/shell/BUILD.gn
-+++ b/content/shell/BUILD.gn
-@@ -649,7 +649,6 @@ if (is_mac) {
-     testonly = true
-     info_plist = "app/framework-Info.plist"
-     args = [
--      "--breakpad=0",
-       "--keystone=0",
-       "--scm=1",
-       "--version",
-@@ -723,7 +722,6 @@ if (is_mac) {
-     testonly = true
-     info_plist = "app/helper-Info.plist"
-     args = [
--      "--breakpad=0",
-       "--keystone=0",
-       "--scm=0",
-       "--version",
-@@ -859,7 +857,6 @@ group("content_shell_crash_test") {
-     "//third_party/mesa_headers",
-   ]
-   data = [
--    "//content/shell/tools/breakpad_integration_test.py",
-     "//testing/scripts/content_shell_crash_test.py",
-   ]
-   if (is_mac && !use_system_xcode) {
-@@ -875,26 +872,16 @@ group("content_shell_crash_test") {
-   }
-   if (is_posix) {
-     data += [
--      "//components/crash/content/tools/generate_breakpad_symbols.py",
-       "//components/crash/content/tools/dmp2minidump.py",
-     ]
-   }
-   if (is_win) {
-     data_deps += [ "//build/win:copy_cdb_to_output" ]
-   }
--  if (is_posix) {
--    data_deps += [
--      "//third_party/breakpad:dump_syms",
--      "//third_party/breakpad:minidump_stackwalk",
--    ]
--  }
-   if (is_android) {
-     data_deps += [
-       "//build/android:devil_chromium_py",
-       "//build/android:test_runner_py",
--      "//third_party/breakpad:microdump_stackwalk",
--      "//third_party/breakpad:minidump_dump",
--      "//third_party/breakpad:symupload",
-       "//tools/android/forwarder2",
-     ]
-   }
--- 
-2.25.1
-