0001-liftoff-Correct-function-signatures.patch 4.1 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485
  1. From dc3652c0abcdf8573fd044907b19d8eda7ca1124 Mon Sep 17 00:00:00 2001
  2. From: Khem Raj <raj.khem@gmail.com>
  3. Date: Wed, 20 Oct 2021 12:49:58 -0700
  4. Subject: [PATCH] [liftoff] Correct function signatures
  5. Fixes builds on mips where clang reports an error
  6. ../deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h:661:5: error: no matching member function for call to 'Move'
  7. Move(tmp, src, type.value_type());
  8. ^~~~
  9. Upstream-Status: Submitted [https://chromium-review.googlesource.com/c/v8/v8/+/3235674]
  10. Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com>
  11. ---
  12. deps/v8/src/wasm/baseline/liftoff-assembler.h | 6 +++---
  13. deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h | 2 +-
  14. deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h | 2 +-
  15. .../src/wasm/baseline/riscv64/liftoff-assembler-riscv64.h | 2 +-
  16. 4 files changed, 6 insertions(+), 6 deletions(-)
  17. diff --git a/deps/v8/src/wasm/baseline/liftoff-assembler.h b/deps/v8/src/wasm/baseline/liftoff-assembler.h
  18. index 22c7f73a..db4cb168 100644
  19. --- a/deps/v8/src/wasm/baseline/liftoff-assembler.h
  20. +++ b/deps/v8/src/wasm/baseline/liftoff-assembler.h
  21. @@ -646,7 +646,7 @@ class LiftoffAssembler : public TurboAssembler {
  22. void FinishCall(const ValueKindSig*, compiler::CallDescriptor*);
  23. // Move {src} into {dst}. {src} and {dst} must be different.
  24. - void Move(LiftoffRegister dst, LiftoffRegister src, ValueKind);
  25. + void Move(LiftoffRegister dst, LiftoffRegister src, ValueKind kind);
  26. // Parallel register move: For a list of tuples <dst, src, kind>, move the
  27. // {src} register of kind {kind} into {dst}. If {src} equals {dst}, ignore
  28. @@ -795,8 +795,8 @@ class LiftoffAssembler : public TurboAssembler {
  29. inline void MoveStackValue(uint32_t dst_offset, uint32_t src_offset,
  30. ValueKind);
  31. - inline void Move(Register dst, Register src, ValueKind);
  32. - inline void Move(DoubleRegister dst, DoubleRegister src, ValueKind);
  33. + inline void Move(Register dst, Register src, ValueKind kind);
  34. + inline void Move(DoubleRegister dst, DoubleRegister src, ValueKind kind);
  35. inline void Spill(int offset, LiftoffRegister, ValueKind);
  36. inline void Spill(int offset, WasmValue);
  37. diff --git a/deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h b/deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h
  38. index c76fd2f4..0fffe231 100644
  39. --- a/deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h
  40. +++ b/deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h
  41. @@ -661,7 +661,7 @@ void LiftoffAssembler::Store(Register dst_addr, Register offset_reg,
  42. pinned = pinned | LiftoffRegList{dst_op.rm(), src};
  43. LiftoffRegister tmp = GetUnusedRegister(src.reg_class(), pinned);
  44. // Save original value.
  45. - Move(tmp, src, type.value_type());
  46. + Move(tmp, src, type.value_type().kind());
  47. src = tmp;
  48. pinned.set(tmp);
  49. diff --git a/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h b/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
  50. index 36413545..48207337 100644
  51. --- a/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
  52. +++ b/deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
  53. @@ -593,7 +593,7 @@ void LiftoffAssembler::Store(Register dst_addr, Register offset_reg,
  54. pinned.set(dst_op.rm());
  55. LiftoffRegister tmp = GetUnusedRegister(src.reg_class(), pinned);
  56. // Save original value.
  57. - Move(tmp, src, type.value_type());
  58. + Move(tmp, src, type.value_type().kind());
  59. src = tmp;
  60. pinned.set(tmp);
  61. diff --git a/deps/v8/src/wasm/baseline/riscv64/liftoff-assembler-riscv64.h b/deps/v8/src/wasm/baseline/riscv64/liftoff-assembler-riscv64.h
  62. index 642a7d2a..56ffcc2a 100644
  63. --- a/deps/v8/src/wasm/baseline/riscv64/liftoff-assembler-riscv64.h
  64. +++ b/deps/v8/src/wasm/baseline/riscv64/liftoff-assembler-riscv64.h
  65. @@ -589,7 +589,7 @@ void LiftoffAssembler::Store(Register dst_addr, Register offset_reg,
  66. pinned.set(dst_op.rm());
  67. LiftoffRegister tmp = GetUnusedRegister(src.reg_class(), pinned);
  68. // Save original value.
  69. - Move(tmp, src, type.value_type());
  70. + Move(tmp, src, type.value_type().kind());
  71. src = tmp;
  72. pinned.set(tmp);
  73. --
  74. 2.34.1