VIRTUAL_OWNERS 1.4 KB

123456789101112131415161718192021222324252627282930
  1. # These owners approve changes to VirtualTestSuites.
  2. #
  3. # The following things should be checked whether they are justified in the
  4. # CL description:
  5. # - The prefix of the virtual test suites should not be too long. There is
  6. # a 260 characters limit for the length of the path on Windows. The prefix
  7. # will be part of the path should a baseline is needed, and will cause
  8. # trouble at that time.
  9. # - If the CL adds virtual tests (by adding new virtual suites or new
  10. # directories to existing virtual suties), how many tests the CL adds.
  11. # - If the number of new tests is big (e.g. >=500)
  12. # - Whether the new tests can be skipped on some platforms / OS versions.
  13. # - Whether the new directories are essential for test coverage.
  14. # - Whether other alternatives [1] are more suitable than virtual suites.
  15. # - The percentage of time the virtual suite will take. The author can
  16. # find this data in "layout_test_results" page ("Timing stats" in the
  17. # top-right corner) linked from "archive results for blink_web_tests"
  18. # step on try bots like linux-rel, mac-rel and win10_chromium_x64_rel_ng.
  19. # Normally the percentage should be less than 5%.
  20. #
  21. # [1] https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_tests.md#testing-runtime-flags
  22. dom@chromium.org
  23. ikilpatrick@chromium.org
  24. kojii@chromium.org
  25. masonf@chromium.org
  26. pdr@chromium.org
  27. schenney@chromium.org
  28. tkent@chromium.org
  29. wangxianzhu@chromium.org