123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169 |
- // Copyright 2020 The Chromium Authors. All rights reserved.
- // Use of this source code is governed by a BSD-style license that can be
- // found in the LICENSE file.
- #include "net/dns/dns_response_result_extractor.h"
- #include <string>
- #include <utility>
- #include <vector>
- #include "base/strings/string_piece.h"
- #include "base/time/time.h"
- #include "net/base/connection_endpoint_metadata_test_util.h"
- #include "net/base/host_port_pair.h"
- #include "net/base/ip_address.h"
- #include "net/base/ip_endpoint.h"
- #include "net/base/net_errors.h"
- #include "net/dns/dns_query.h"
- #include "net/dns/dns_response.h"
- #include "net/dns/dns_test_util.h"
- #include "net/dns/host_cache.h"
- #include "net/dns/host_resolver_results_test_util.h"
- #include "net/dns/public/dns_protocol.h"
- #include "net/dns/public/dns_query_type.h"
- #include "net/test/gtest_util.h"
- #include "testing/gmock/include/gmock/gmock.h"
- #include "testing/gtest/include/gtest/gtest.h"
- #include "third_party/abseil-cpp/absl/types/optional.h"
- namespace net {
- namespace {
- TEST(DnsResponseResultExtractorTest, ExtractsSingleARecord) {
- constexpr char kName[] = "address.test";
- const IPAddress kExpected(192, 168, 0, 1);
- DnsResponse response = BuildTestDnsAddressResponse(kName, kExpected);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::ElementsAre(kName)));
- EXPECT_TRUE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, ExtractsSingleAAAARecord) {
- constexpr char kName[] = "address.test";
- IPAddress expected;
- CHECK(expected.AssignFromIPLiteral("2001:4860:4860::8888"));
- DnsResponse response = BuildTestDnsAddressResponse(kName, expected);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::AAAA,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- IPEndPoint expected_endpoint(expected, 0 /* port */);
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::ElementsAre(kName)));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsSingleARecordWithCname) {
- const IPAddress kExpected(192, 168, 0, 1);
- constexpr char kName[] = "address.test";
- constexpr char kCanonicalName[] = "alias.test";
- DnsResponse response =
- BuildTestDnsAddressResponseWithCname(kName, kExpected, kCanonicalName);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::UnorderedElementsAre(
- kName, kCanonicalName)));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsARecordsWithCname) {
- constexpr char kName[] = "addresses.test";
- DnsResponse response = BuildTestDnsResponse(
- "addresses.test", dns_protocol::kTypeA,
- {
- BuildTestAddressRecord("alias.test", IPAddress(74, 125, 226, 179)),
- BuildTestAddressRecord("alias.test", IPAddress(74, 125, 226, 180)),
- BuildTestCnameRecord(kName, "alias.test"),
- BuildTestAddressRecord("alias.test", IPAddress(74, 125, 226, 176)),
- BuildTestAddressRecord("alias.test", IPAddress(74, 125, 226, 177)),
- BuildTestAddressRecord("alias.test", IPAddress(74, 125, 226, 178)),
- });
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(
- ExpectEndpointResult(testing::UnorderedElementsAre(
- IPEndPoint(IPAddress(74, 125, 226, 179), 0 /* port */),
- IPEndPoint(IPAddress(74, 125, 226, 178), 0 /* port */),
- IPEndPoint(IPAddress(74, 125, 226, 180), 0 /* port */),
- IPEndPoint(IPAddress(74, 125, 226, 176), 0 /* port */),
- IPEndPoint(IPAddress(74, 125, 226, 177), 0 /* port */))))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::UnorderedElementsAre(
- "alias.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNxdomainAResponses) {
- constexpr char kName[] = "address.test";
- constexpr auto kTtl = base::Hours(2);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetEndpoints(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::ElementsAre(kName)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataAResponses) {
- constexpr char kName[] = "address.test";
- constexpr auto kTtl = base::Minutes(15);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetEndpoints(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::ElementsAre(kName)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedARecord) {
- constexpr char kName[] = "address.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeA,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNameARecord) {
- constexpr char kName[] = "address.test";
- DnsResponse response = BuildTestDnsAddressResponse(
- kName, IPAddress(1, 2, 3, 4), "different.test");
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypeRecordsInAResponse) {
- constexpr char kName[] = "address.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA,
- {BuildTestTextRecord("address.test", {"foo"} /* text_strings */)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetEndpoints(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::ElementsAre("address.test")));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypeRecordsMixedWithARecords) {
- constexpr char kName[] = "address.test";
- const IPAddress kExpected(8, 8, 8, 8);
- constexpr auto kTtl = base::Days(3);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA,
- {BuildTestTextRecord(kName, /*text_strings=*/{"foo"}, base::Hours(2)),
- BuildTestAddressRecord(kName, kExpected, kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::ElementsAre(kName)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsMinATtl) {
- constexpr char kName[] = "name.test";
- constexpr base::TimeDelta kMinTtl = base::Minutes(4);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeA,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4), base::Hours(3)),
- BuildTestAddressRecord(kName, IPAddress(2, 3, 4, 5), kMinTtl),
- BuildTestAddressRecord(kName, IPAddress(3, 4, 5, 6),
- base::Minutes(15))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kMinTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsTxtResponses) {
- constexpr char kName[] = "name.test";
- // Simulate two separate DNS records, each with multiple strings.
- std::vector<std::string> foo_records = {"foo1", "foo2", "foo3"};
- std::vector<std::string> bar_records = {"bar1", "bar2"};
- std::vector<std::vector<std::string>> text_records = {foo_records,
- bar_records};
- DnsResponse response =
- BuildTestDnsTextResponse(kName, std::move(text_records));
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- // Order between separate DNS records is undefined, but each record should
- // stay in order as that order may be meaningful.
- ASSERT_THAT(results.text_records(),
- testing::Optional(testing::UnorderedElementsAre(
- "foo1", "foo2", "foo3", "bar1", "bar2")));
- std::vector<std::string> results_vector = results.text_records().value();
- EXPECT_NE(results_vector.end(),
- std::search(results_vector.begin(), results_vector.end(),
- foo_records.begin(), foo_records.end()));
- EXPECT_NE(results_vector.end(),
- std::search(results_vector.begin(), results_vector.end(),
- bar_records.begin(), bar_records.end()));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNxdomainTxtResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Days(4);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.text_records(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataTxtResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Minutes(42);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- /*answers=*/{}, /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.text_records(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedTxtRecord) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeTXT,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNameTxtRecord) {
- constexpr char kName[] = "name.test";
- DnsResponse response =
- BuildTestDnsTextResponse(kName, {{"foo"}}, "different.test");
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypeTxtResponses) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.text_records(), testing::Optional(testing::IsEmpty()));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, ExtractsMinTxtTtl) {
- constexpr char kName[] = "name.test";
- constexpr base::TimeDelta kMinTtl = base::Minutes(4);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestTextRecord(kName, {"foo"}, base::Hours(3)),
- BuildTestTextRecord(kName, {"bar"}, kMinTtl),
- BuildTestTextRecord(kName, {"baz"}, base::Minutes(15))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kMinTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsPtrResponses) {
- constexpr char kName[] = "name.test";
- DnsResponse response =
- BuildTestDnsPointerResponse(kName, {"foo.com", "bar.com"});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- // Order between separate records is undefined.
- EXPECT_THAT(results.hostnames(),
- testing::Optional(testing::UnorderedElementsAre(
- HostPortPair("foo.com", 0), HostPortPair("bar.com", 0))));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNxdomainPtrResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Hours(5);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypePTR, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataPtrResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Minutes(50);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypePTR, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedPtrRecord) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypePTR,
- {BuildTestDnsRecord(kName, dns_protocol::kTypePTR,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNamePtrRecord) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsPointerResponse(
- kName, {"foo.com", "bar.com"}, "different.test");
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypePtrResponses) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypePTR,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::PTR,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, ExtractsSrvResponses) {
- constexpr char kName[] = "name.test";
- const TestServiceRecord kRecord1 = {2, 3, 1223, "foo.com"};
- const TestServiceRecord kRecord2 = {5, 10, 80, "bar.com"};
- const TestServiceRecord kRecord3 = {5, 1, 5, "google.com"};
- const TestServiceRecord kRecord4 = {2, 100, 12345, "chromium.org"};
- DnsResponse response = BuildTestDnsServiceResponse(
- kName, {kRecord1, kRecord2, kRecord3, kRecord4});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- // Expect ordered by priority, and random within a priority.
- absl::optional<std::vector<HostPortPair>> result_hosts = results.hostnames();
- ASSERT_THAT(
- result_hosts,
- testing::Optional(testing::UnorderedElementsAre(
- HostPortPair("foo.com", 1223), HostPortPair("bar.com", 80),
- HostPortPair("google.com", 5), HostPortPair("chromium.org", 12345))));
- auto priority2 = std::vector<HostPortPair>(result_hosts.value().begin(),
- result_hosts.value().begin() + 2);
- EXPECT_THAT(priority2, testing::UnorderedElementsAre(
- HostPortPair("foo.com", 1223),
- HostPortPair("chromium.org", 12345)));
- auto priority5 = std::vector<HostPortPair>(result_hosts.value().begin() + 2,
- result_hosts.value().end());
- EXPECT_THAT(priority5,
- testing::UnorderedElementsAre(HostPortPair("bar.com", 80),
- HostPortPair("google.com", 5)));
- }
- // 0-weight services are allowed. Ensure that we can handle such records,
- // especially the case where all entries have weight 0.
- TEST(DnsResponseResultExtractorTest, ExtractsZeroWeightSrvResponses) {
- constexpr char kName[] = "name.test";
- const TestServiceRecord kRecord1 = {5, 0, 80, "bar.com"};
- const TestServiceRecord kRecord2 = {5, 0, 5, "google.com"};
- DnsResponse response =
- BuildTestDnsServiceResponse(kName, {kRecord1, kRecord2});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- // Expect ordered by priority, and random within a priority.
- EXPECT_THAT(results.hostnames(),
- testing::Optional(testing::UnorderedElementsAre(
- HostPortPair("bar.com", 80), HostPortPair("google.com", 5))));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNxdomainSrvResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Days(7);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeSRV, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataSrvResponses) {
- constexpr char kName[] = "name.test";
- constexpr auto kTtl = base::Hours(12);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeSRV, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedSrvRecord) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeSRV,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSRV,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNameSrvRecord) {
- constexpr char kName[] = "name.test";
- const TestServiceRecord kRecord = {2, 3, 1223, "foo.com"};
- DnsResponse response =
- BuildTestDnsServiceResponse(kName, {kRecord}, "different.test");
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypeSrvResponses) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeSRV,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::SRV,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.hostnames(), testing::Optional(testing::IsEmpty()));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, ExtractsExperimentalHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Minutes(31);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsAliasRecord(kName, "alias.test", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsNxdomainExperimentalHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Hours(8);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataExperimentalHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Days(3);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedExperimentalHttpsRecord) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeHttps,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNameExperimentalHttpsRecord) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsAliasRecord("different.test", "alias.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest,
- IgnoresWrongTypeExperimentalHttpsResponses) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest,
- IgnoresAdditionalExperimentalHttpsRecords) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Days(3);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- /*answers=*/{BuildTestHttpsAliasRecord(kName, "alias.test", kTtl)},
- /*authority=*/{},
- /*additional=*/
- {BuildTestHttpsServiceRecord(kName, 3u, "service1.test", {},
- base::Minutes(44)),
- BuildTestHttpsServiceRecord(kName, 2u, "service2.test", {},
- base::Minutes(30))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS_EXPERIMENTAL,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsBasicHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Hours(12);
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/{}, kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre(dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsComprehensiveHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr char kAlpn[] = "foo";
- constexpr uint8_t kEchConfig[] = "EEEEEEEEECH!";
- constexpr auto kTtl = base::Hours(12);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({kAlpn}),
- BuildTestHttpsServiceEchConfigParam(kEchConfig)},
- kTtl),
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/3,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({kAlpn}),
- {dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}},
- /*ttl=*/base::Days(3))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(
- ExpectConnectionEndpointMetadata(testing::ElementsAre(kAlpn),
- testing::IsEmpty(), kName),
- ExpectConnectionEndpointMetadata(
- testing::ElementsAre(
- kAlpn, dns_protocol::kHttpsServiceDefaultAlpn),
- testing::ElementsAreArray(kEchConfig), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, IgnoresHttpsResponseWithAlias) {
- constexpr char kName[] = "https.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/{}),
- BuildTestHttpsAliasRecord(kName, "alias.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- // Expected to still output record compatibility for otherwise-ignored records
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- }
- // Expect the entire response to be ignored if all HTTPS records have the
- // "no-default-alpn" param.
- TEST(DnsResponseResultExtractorTest, IgnoresHttpsResponseWithNoDefaultAlpn) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo1"}),
- {dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}}),
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/5,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo2"}),
- {dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- // Expected to still output record compatibility for otherwise-ignored records
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- }
- // Unsupported/unknown HTTPS params are simply ignored if not marked mandatory.
- TEST(DnsResponseResultExtractorTest, IgnoresUnsupportedParamsInHttpsRecord) {
- constexpr char kName[] = "https.test";
- constexpr uint16_t kMadeUpParamKey = 65500; // From the private-use block.
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {{kMadeUpParamKey, "foo"}})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre(dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- // Entire record is dropped if an unsupported/unknown HTTPS param is marked
- // mandatory.
- TEST(DnsResponseResultExtractorTest,
- IgnoresHttpsRecordWithUnsupportedMandatoryParam) {
- constexpr char kName[] = "https.test";
- constexpr uint16_t kMadeUpParamKey = 65500; // From the private-use block.
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"ignored_alpn"}),
- BuildTestHttpsServiceMandatoryParam({kMadeUpParamKey}),
- {kMadeUpParamKey, "foo"}}),
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/5,
- /*service_name=*/".",
- /*params=*/{BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(false, true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithMatchingServiceName) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/kName,
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithMatchingDefaultServiceName) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithPrefixedNameAndMatchingServiceName) {
- constexpr char kName[] = "https.test";
- constexpr char kPrefixedName[] = "_444._https.https.test";
- DnsResponse response = BuildTestDnsResponse(
- kPrefixedName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kPrefixedName, /*priority=*/4,
- /*service_name=*/kName,
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithAliasingAndMatchingServiceName) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestCnameRecord(kName, "alias.test"),
- BuildTestHttpsServiceRecord("alias.test", /*priority=*/4,
- /*service_name=*/kName,
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest,
- IgnoreHttpsRecordWithNonMatchingServiceName) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/"other.service.test",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"ignored"})}),
- BuildTestHttpsServiceRecord("https.test", /*priority=*/5,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithPrefixedNameAndDefaultServiceName) {
- constexpr char kPrefixedName[] = "_445._https.https.test";
- DnsResponse response = BuildTestDnsResponse(
- kPrefixedName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kPrefixedName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/"https.test",
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kPrefixedName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest,
- ExtractsHttpsRecordWithAliasingAndDefaultServiceName) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestCnameRecord(kName, "alias.test"),
- BuildTestHttpsServiceRecord("alias.test", /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), "alias.test"))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsHttpsRecordWithMatchingPort) {
- constexpr char kName[] = "https.test";
- constexpr uint16_t kPort = 4567;
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"}),
- BuildTestHttpsServicePortParam(kPort)})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/kPort, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- }
- TEST(DnsResponseResultExtractorTest, IgnoresHttpsRecordWithMismatchingPort) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"ignored"}),
- BuildTestHttpsServicePortParam(1003)}),
- BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/55, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- }
- // HTTPS records with "no-default-alpn" but also no "alpn" are not
- // "self-consistent" and should be ignored.
- TEST(DnsResponseResultExtractorTest, IgnoresHttpsRecordWithNoAlpn) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {{dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}}),
- BuildTestHttpsServiceRecord(kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo"})})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/55, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true)));
- }
- // Expect the entire response to be ignored if all HTTPS records have the
- // "no-default-alpn" param.
- TEST(DnsResponseResultExtractorTest,
- IgnoresHttpsResponseWithNoCompatibleDefaultAlpn) {
- constexpr char kName[] = "https.test";
- constexpr uint16_t kMadeUpParamKey = 65500; // From the private-use block.
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsServiceRecord(
- kName, /*priority=*/4,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo1"}),
- {dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}}),
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/5,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo2"}),
- {dns_protocol::kHttpsServiceParamKeyNoDefaultAlpn, ""}}),
- // Allows default ALPN, but ignored due to non-matching service name.
- BuildTestHttpsServiceRecord(kName, /*priority=*/3,
- /*service_name=*/"other.test",
- /*params=*/{}),
- // Allows default ALPN, but ignored due to incompatible param.
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/6,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceMandatoryParam({kMadeUpParamKey}),
- {kMadeUpParamKey, "foo"}}),
- // Allows default ALPN, but ignored due to mismatching port.
- BuildTestHttpsServiceRecord(
- kName, /*priority=*/10,
- /*service_name=*/".",
- /*params=*/{BuildTestHttpsServicePortParam(1005)})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- // Expected to still output record compatibility for otherwise-ignored records
- EXPECT_THAT(
- results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true, true, true, false, true)));
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNxdomainHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Minutes(45);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)},
- /*additional=*/{}, dns_protocol::kRcodeNXDOMAIN);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsNodataHttpsResponses) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Hours(36);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps, /*answers=*/{},
- /*authority=*/
- {BuildTestDnsRecord(kName, dns_protocol::kTypeSOA, "fake rdata", kTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, RejectsMalformedHttpsRecord) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeHttps,
- "malformed rdata")} /* answers */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMalformedRecord);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, RejectsWrongNameHttpsRecord) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestHttpsAliasRecord("different.test", "alias.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- EXPECT_FALSE(results.has_ttl());
- }
- TEST(DnsResponseResultExtractorTest, IgnoresWrongTypeHttpsResponses) {
- constexpr char kName[] = "https.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- {BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetMetadatas(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::IsEmpty()));
- }
- TEST(DnsResponseResultExtractorTest, IgnoresAdditionalHttpsRecords) {
- constexpr char kName[] = "https.test";
- constexpr auto kTtl = base::Days(5);
- // Give all records an "alpn" value to help validate that only the correct
- // record is used.
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeHttps,
- /*answers=*/
- {BuildTestHttpsServiceRecord(kName, /*priority=*/5u,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo1"})},
- kTtl)},
- /*authority=*/{},
- /*additional=*/
- {BuildTestHttpsServiceRecord(kName, /*priority=*/3u, /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo2"})},
- base::Minutes(44)),
- BuildTestHttpsServiceRecord(kName, /*priority=*/2u, /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo3"})},
- base::Minutes(30))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::HTTPS,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(
- results.GetMetadatas(),
- testing::Optional(testing::ElementsAre(ExpectConnectionEndpointMetadata(
- testing::ElementsAre("foo1", dns_protocol::kHttpsServiceDefaultAlpn),
- testing::IsEmpty(), kName))));
- EXPECT_THAT(results.https_record_compatibility(),
- testing::Pointee(testing::ElementsAre(true)));
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kTtl);
- }
- TEST(DnsResponseResultExtractorTest, IgnoresUnsolicitedHttpsRecords) {
- constexpr char kName[] = "name.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestDnsRecord(kName, dns_protocol::kTypeTXT,
- "\003foo")} /* answers */,
- {} /* authority */,
- {BuildTestHttpsServiceRecord(
- "https.test", /*priority=*/3u, /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo2"})}, base::Minutes(44)),
- BuildTestHttpsServiceRecord("https.test", /*priority=*/2u,
- /*service_name=*/".",
- /*params=*/
- {BuildTestHttpsServiceAlpnParam({"foo3"})},
- base::Minutes(30))} /* additional */);
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.text_records(),
- testing::Optional(testing::ElementsAre("foo")));
- EXPECT_FALSE(results.GetMetadatas());
- EXPECT_FALSE(results.https_record_compatibility());
- }
- TEST(DnsResponseResultExtractorTest, HandlesInOrderCnameChain) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord(kName, "second.test"),
- BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestTextRecord("fourth.test", {"bar"})});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.text_records(),
- testing::Optional(testing::UnorderedElementsAre("foo", "bar")));
- }
- TEST(DnsResponseResultExtractorTest, HandlesInOrderCnameChainTypeA) {
- constexpr char kName[] = "first.test";
- const IPAddress kExpected(192, 168, 0, 1);
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestCnameRecord(kName, "second.test"),
- BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestAddressRecord("fourth.test", kExpected)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::UnorderedElementsAre(
- "fourth.test", "third.test", "second.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, HandlesReverseOrderCnameChain) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.text_records(),
- testing::Optional(testing::ElementsAre("foo")));
- }
- TEST(DnsResponseResultExtractorTest, HandlesReverseOrderCnameChainTypeA) {
- constexpr char kName[] = "first.test";
- const IPAddress kExpected(192, 168, 0, 1);
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestAddressRecord("fourth.test", kExpected),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::UnorderedElementsAre(
- "fourth.test", "third.test", "second.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, HandlesArbitraryOrderCnameChain) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.text_records(),
- testing::Optional(testing::ElementsAre("foo")));
- }
- TEST(DnsResponseResultExtractorTest, HandlesArbitraryOrderCnameChainTypeA) {
- constexpr char kName[] = "first.test";
- const IPAddress kExpected(192, 168, 0, 1);
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- // Alias names are chosen so that the chain order is not in alphabetical
- // order.
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestCnameRecord("qsecond.test", "athird.test"),
- BuildTestAddressRecord("zfourth.test", kExpected),
- BuildTestCnameRecord("athird.test", "zfourth.test"),
- BuildTestCnameRecord(kName, "qsecond.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::UnorderedElementsAre(
- "zfourth.test", "athird.test", "qsecond.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, IgnoresNonResultTypesMixedWithCnameChain) {
- constexpr char kName[] = "first.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestAddressRecord("third.test", IPAddress(1, 2, 3, 4)),
- BuildTestCnameRecord(kName, "second.test"),
- BuildTestAddressRecord("fourth.test", IPAddress(2, 3, 4, 5))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.text_records(),
- testing::Optional(testing::ElementsAre("foo")));
- EXPECT_FALSE(results.GetEndpoints());
- EXPECT_FALSE(results.aliases());
- }
- TEST(DnsResponseResultExtractorTest,
- IgnoresNonResultTypesMixedWithCnameChainTypeA) {
- constexpr char kName[] = "first.test";
- const IPAddress kExpected(192, 168, 0, 1);
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test"),
- BuildTestAddressRecord("fourth.test", kExpected)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_FALSE(results.text_records());
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::UnorderedElementsAre(
- "fourth.test", "third.test", "second.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, HandlesCnameChainWithoutResult) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.text_records(), testing::Optional(testing::IsEmpty()));
- }
- TEST(DnsResponseResultExtractorTest, HandlesCnameChainWithoutResultTypeA) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsError(ERR_NAME_NOT_RESOLVED));
- EXPECT_THAT(results.GetEndpoints(), testing::Optional(testing::IsEmpty()));
- EXPECT_THAT(results.aliases(),
- testing::Pointee(testing::UnorderedElementsAre(
- "fourth.test", "third.test", "second.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, RejectsCnameChainWithLoop) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("third.test", {"foo"}),
- BuildTestCnameRecord("third.test", "second.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kBadAliasChain);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsCnameChainWithLoopToBeginning) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("third.test", {"foo"}),
- BuildTestCnameRecord("third.test", "first.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kBadAliasChain);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest,
- RejectsCnameChainWithLoopToBeginningWithoutResult) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestCnameRecord("third.test", "first.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kBadAliasChain);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsCnameChainWithWrongStart) {
- constexpr char kName[] = "test.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord("first.test", "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kBadAliasChain);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsCnameChainWithWrongResultName) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("third.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsCnameSharedWithResult) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord(kName, {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kNameMismatch);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsDisjointCnameChain) {
- constexpr char kName[] = "first.test";
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord("other1.test", "other2.test"),
- BuildTestCnameRecord(kName, "second.test"),
- BuildTestCnameRecord("other2.test", "other3.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kBadAliasChain);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, RejectsDoubledCnames) {
- constexpr char kName[] = "first.test";
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeTXT,
- {BuildTestCnameRecord("second.test", "third.test"),
- BuildTestTextRecord("fourth.test", {"foo"}),
- BuildTestCnameRecord("third.test", "fourth.test"),
- BuildTestCnameRecord("third.test", "fifth.test"),
- BuildTestCnameRecord(kName, "second.test")});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kMultipleCnames);
- EXPECT_THAT(results.error(), test::IsError(ERR_DNS_MALFORMED_RESPONSE));
- }
- TEST(DnsResponseResultExtractorTest, IgnoresTtlFromNonResultType) {
- constexpr char kName[] = "name.test";
- constexpr base::TimeDelta kMinTtl = base::Minutes(4);
- DnsResponse response = BuildTestDnsResponse(
- kName, dns_protocol::kTypeTXT,
- {BuildTestTextRecord(kName, {"foo"}, base::Hours(3)),
- BuildTestTextRecord(kName, {"bar"}, kMinTtl),
- BuildTestAddressRecord(kName, IPAddress(1, 2, 3, 4), base::Seconds(2)),
- BuildTestTextRecord(kName, {"baz"}, base::Minutes(15))});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kMinTtl);
- }
- TEST(DnsResponseResultExtractorTest, ExtractsTtlFromCname) {
- constexpr char kName[] = "name.test";
- constexpr char kAlias[] = "alias.test";
- constexpr base::TimeDelta kMinTtl = base::Minutes(4);
- DnsResponse response = BuildTestDnsResponse(
- "name.test", dns_protocol::kTypeTXT,
- {BuildTestTextRecord(kAlias, {"foo"}, base::Hours(3)),
- BuildTestTextRecord(kAlias, {"bar"}, base::Hours(2)),
- BuildTestTextRecord(kAlias, {"baz"}, base::Minutes(15)),
- BuildTestCnameRecord(kName, kAlias, kMinTtl)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::TXT,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- ASSERT_TRUE(results.has_ttl());
- EXPECT_EQ(results.ttl(), kMinTtl);
- }
- TEST(DnsResponseResultExtractorTest, ValidatesAliasNames) {
- constexpr char kName[] = "first.test";
- const IPAddress kExpected(192, 168, 0, 1);
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- DnsResponse response =
- BuildTestDnsResponse(kName, dns_protocol::kTypeA,
- {BuildTestCnameRecord(kName, "second.test"),
- BuildTestCnameRecord("second.test", "localhost"),
- BuildTestCnameRecord("localhost", "fourth.test"),
- BuildTestAddressRecord("fourth.test", kExpected)});
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- // Expect "localhost" to be validated out of the alias list.
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::UnorderedElementsAre(
- "fourth.test", "second.test", kName)));
- }
- TEST(DnsResponseResultExtractorTest, CanonicalizesAliasNames) {
- const IPAddress kExpected(192, 168, 0, 1);
- constexpr char kName[] = "address.test";
- DnsResponse response =
- BuildTestDnsAddressResponseWithCname(kName, kExpected, "ALIAS.test.");
- DnsResponseResultExtractor extractor(&response);
- HostCache::Entry results(ERR_FAILED, HostCache::Entry::SOURCE_UNKNOWN);
- EXPECT_EQ(extractor.ExtractDnsResults(DnsQueryType::A,
- /*original_domain_name=*/kName,
- /*request_port=*/0, &results),
- DnsResponseResultExtractor::ExtractionError::kOk);
- EXPECT_THAT(results.error(), test::IsOk());
- IPEndPoint expected_endpoint(kExpected, 0 /* port */);
- EXPECT_THAT(results.GetEndpoints(),
- testing::Optional(testing::ElementsAre(ExpectEndpointResult(
- testing::ElementsAre(expected_endpoint)))));
- EXPECT_THAT(results.aliases(), testing::Pointee(testing::UnorderedElementsAre(
- kName, "alias.test")));
- }
- } // namespace
- } // namespace net
|