12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342 |
- // Copyright (c) 2012 The Chromium Authors. All rights reserved.
- // Use of this source code is governed by a BSD-style license that can be
- // found in the LICENSE file.
- #include "net/cookies/canonical_cookie.h"
- #include <memory>
- #include <string>
- #include <vector>
- #include "base/test/metrics/histogram_tester.h"
- #include "base/test/scoped_feature_list.h"
- #include "base/time/time.h"
- #include "build/build_config.h"
- #include "net/base/features.h"
- #include "net/cookies/canonical_cookie_test_helpers.h"
- #include "net/cookies/cookie_constants.h"
- #include "net/cookies/cookie_inclusion_status.h"
- #include "net/cookies/cookie_options.h"
- #include "net/cookies/parsed_cookie.h"
- #include "testing/gmock/include/gmock/gmock-matchers.h"
- #include "testing/gmock/include/gmock/gmock.h"
- #include "testing/gtest/include/gtest/gtest.h"
- #include "third_party/abseil-cpp/absl/types/optional.h"
- #include "url/gurl.h"
- #include "url/third_party/mozilla/url_parse.h"
- namespace net {
- namespace {
- const std::vector<std::string> kCookieableSchemes = {"http", "https", "ws",
- "wss"};
- // Helper for testing BuildCookieLine
- void MatchCookieLineToVector(
- const std::string& line,
- const std::vector<std::unique_ptr<CanonicalCookie>>& cookies) {
- std::vector<CanonicalCookie> list;
- for (const auto& cookie : cookies)
- list.push_back(*cookie);
- EXPECT_EQ(line, CanonicalCookie::BuildCookieLine(list));
- }
- } // namespace
- using testing::_;
- using testing::AllOf;
- using testing::Eq;
- using testing::Not;
- using testing::Property;
- // Tests which use this class verify the expiry date clamping behavior when
- // kClampCookieExpiryTo400Days is enabled. This caps expiry dates on new/updated
- // cookies to max of 400 days, but does not affect previously stored cookies.
- class CanonicalCookieWithClampingTest
- : public testing::Test,
- public testing::WithParamInterface<bool> {
- public:
- CanonicalCookieWithClampingTest() {
- scoped_feature_list_.InitWithFeatureState(
- features::kClampCookieExpiryTo400Days,
- IsClampCookieExpiryTo400DaysEnabled());
- }
- bool IsClampCookieExpiryTo400DaysEnabled() { return GetParam(); }
- private:
- base::test::ScopedFeatureList scoped_feature_list_;
- };
- INSTANTIATE_TEST_SUITE_P(/* no label */,
- CanonicalCookieWithClampingTest,
- testing::Bool());
- TEST(CanonicalCookieTest, Constructor) {
- base::Time current_time = base::Time::Now();
- // CreateUnsafeCookieForTesting just forwards to the constructor.
- auto cookie1 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false, absl::nullopt,
- CookieSourceScheme::kSecure, 443);
- EXPECT_EQ("A", cookie1->Name());
- EXPECT_EQ("2", cookie1->Value());
- EXPECT_EQ("www.example.com", cookie1->Domain());
- EXPECT_EQ("/test", cookie1->Path());
- EXPECT_FALSE(cookie1->IsSecure());
- EXPECT_FALSE(cookie1->IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie1->SameSite());
- EXPECT_EQ(CookiePriority::COOKIE_PRIORITY_DEFAULT, cookie1->Priority());
- EXPECT_FALSE(cookie1->IsSameParty());
- EXPECT_FALSE(cookie1->IsPartitioned());
- EXPECT_EQ(cookie1->SourceScheme(), CookieSourceScheme::kSecure);
- EXPECT_EQ(cookie1->SourcePort(), 443);
- auto cookie2 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", ".www.example.com", "/", current_time, base::Time(),
- base::Time(), base::Time(), false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, true,
- CookiePartitionKey::FromURLForTesting(GURL("https://foo.com")),
- CookieSourceScheme::kNonSecure, 65536);
- EXPECT_EQ("A", cookie2->Name());
- EXPECT_EQ("2", cookie2->Value());
- EXPECT_EQ(".www.example.com", cookie2->Domain());
- EXPECT_EQ("/", cookie2->Path());
- EXPECT_FALSE(cookie2->IsSecure());
- EXPECT_FALSE(cookie2->IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie2->SameSite());
- EXPECT_EQ(CookiePriority::COOKIE_PRIORITY_DEFAULT, cookie2->Priority());
- EXPECT_TRUE(cookie2->IsSameParty());
- EXPECT_TRUE(cookie2->IsPartitioned());
- EXPECT_EQ(cookie2->SourceScheme(), CookieSourceScheme::kNonSecure);
- // Because the port can be set explicitly in the constructor its value can be
- // independent of the other parameters. In this case, test that an out of
- // range port is kept out of range.
- EXPECT_EQ(cookie2->SourcePort(), 65536);
- // Set Secure to true but don't specify source_scheme or port.
- auto cookie3 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", ".www.example.com", "/", current_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_TRUE(cookie3->IsSecure());
- EXPECT_EQ(cookie3->SourceScheme(), CookieSourceScheme::kUnset);
- EXPECT_EQ(cookie3->SourcePort(), url::PORT_UNSPECIFIED);
- auto cookie4 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", ".www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_EQ("A", cookie4->Name());
- EXPECT_EQ("2", cookie4->Value());
- EXPECT_EQ(".www.example.com", cookie4->Domain());
- EXPECT_EQ("/test", cookie4->Path());
- EXPECT_FALSE(cookie4->IsSecure());
- EXPECT_FALSE(cookie4->IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie4->SameSite());
- EXPECT_FALSE(cookie4->IsSameParty());
- EXPECT_FALSE(cookie4->IsPartitioned());
- EXPECT_EQ(cookie4->SourceScheme(), CookieSourceScheme::kUnset);
- EXPECT_EQ(cookie4->SourcePort(), url::PORT_UNSPECIFIED);
- // Test some port edge cases: unspecified.
- auto cookie5 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", ".www.example.com", "/", current_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false,
- absl::nullopt, CookieSourceScheme::kUnset, url::PORT_UNSPECIFIED);
- EXPECT_EQ(cookie5->SourcePort(), url::PORT_UNSPECIFIED);
- // Test some port edge cases: invalid.
- auto cookie6 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", ".www.example.com", "/", current_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false,
- absl::nullopt, CookieSourceScheme::kUnset, url::PORT_INVALID);
- EXPECT_EQ(cookie6->SourcePort(), url::PORT_INVALID);
- }
- TEST(CanonicalCookieTest, CreationCornerCases) {
- base::Time creation_time = base::Time::Now();
- std::unique_ptr<CanonicalCookie> cookie;
- absl::optional<base::Time> server_time = absl::nullopt;
- // Space in name.
- cookie = CanonicalCookie::Create(GURL("http://www.example.com/test/foo.html"),
- "A C=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_EQ("A C", cookie->Name());
- // Semicolon in path.
- cookie = CanonicalCookie::Create(GURL("http://fool/;/"), "*", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- // Control characters in name or value.
- CookieInclusionStatus status;
- cookie = CanonicalCookie::Create(
- GURL("http://www.example.com/test/foo.html"), "\b=foo", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(status.HasExclusionReason(
- CookieInclusionStatus::ExclusionReason::EXCLUDE_FAILURE_TO_STORE));
- cookie = CanonicalCookie::Create(
- GURL("http://www.example.com/test/foo.html"), "bar=\b", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(status.HasExclusionReason(
- CookieInclusionStatus::ExclusionReason::EXCLUDE_FAILURE_TO_STORE));
- // The ParsedCookie constructor unit tests cover many edge cases related to
- // invalid sizes when parsing a cookie line, and since CanonicalCookie::Create
- // creates a ParsedCookie immediately, there's no point in replicating all
- // of those tests here. We should test that the corresponding ExclusionReason
- // gets passed back correctly, though.
- std::string too_long_value(ParsedCookie::kMaxCookieNamePlusValueSize + 1,
- 'a');
- cookie = CanonicalCookie::Create(GURL("http://www.example.com/test/foo.html"),
- too_long_value, creation_time, server_time,
- absl::nullopt /* cookie_partition_key */,
- &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(
- status.HasExclusionReason(CookieInclusionStatus::ExclusionReason::
- EXCLUDE_NAME_VALUE_PAIR_EXCEEDS_MAX_SIZE));
- }
- TEST(CanonicalCookieTest, Create) {
- // Test creating cookies from a cookie string.
- GURL url("http://www.example.com/test/foo.html");
- GURL https_url("https://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(
- CanonicalCookie::Create(url, "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_EQ("A", cookie->Name());
- EXPECT_EQ("2", cookie->Value());
- EXPECT_EQ("www.example.com", cookie->Domain());
- EXPECT_EQ("/test", cookie->Path());
- EXPECT_FALSE(cookie->IsSecure());
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kNonSecure);
- EXPECT_EQ(cookie->SourcePort(), 80);
- GURL url2("http://www.foo.com");
- cookie = CanonicalCookie::Create(url2, "B=1", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ("B", cookie->Name());
- EXPECT_EQ("1", cookie->Value());
- EXPECT_EQ("www.foo.com", cookie->Domain());
- EXPECT_EQ("/", cookie->Path());
- EXPECT_FALSE(cookie->IsSecure());
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kNonSecure);
- EXPECT_EQ(cookie->SourcePort(), 80);
- // Test creating secure cookies. Secure scheme is not checked upon creation,
- // so a URL of any scheme can create a Secure cookie.
- cookie =
- CanonicalCookie::Create(url, "A=2; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsSecure());
- cookie = CanonicalCookie::Create(https_url, "A=2; Secure", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsSecure());
- GURL url3("https://www.foo.com");
- cookie =
- CanonicalCookie::Create(url3, "A=2; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kSecure);
- cookie = CanonicalCookie::Create(url3, "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_FALSE(cookie->IsSecure());
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kSecure);
- // Test creating cookie from localhost URL.
- cookie = CanonicalCookie::Create(GURL("http://localhost/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kNonSecure);
- cookie = CanonicalCookie::Create(GURL("http://127.0.0.1/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kNonSecure);
- cookie = CanonicalCookie::Create(GURL("http://[::1]/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kNonSecure);
- cookie = CanonicalCookie::Create(GURL("https://localhost/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kSecure);
- cookie = CanonicalCookie::Create(GURL("https://127.0.0.1/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kSecure);
- cookie = CanonicalCookie::Create(GURL("https://[::1]/path"), "A=2",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourceScheme(), CookieSourceScheme::kSecure);
- // Test creating http only cookies. HttpOnly is not checked upon creation.
- cookie =
- CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsHttpOnly());
- cookie =
- CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsHttpOnly());
- // Test creating SameSite cookies. SameSite is not checked upon creation.
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=Strict", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=Lax", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::LAX_MODE, cookie->SameSite());
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=Extended", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=None", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie->SameSite());
- cookie = CanonicalCookie::Create(url, "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- // Test creating cookies with different ports.
- cookie = CanonicalCookie::Create(GURL("http://www.foo.com"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), 80);
- cookie = CanonicalCookie::Create(GURL("http://www.foo.com:81"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), 81);
- cookie = CanonicalCookie::Create(GURL("https://www.foo.com"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), 443);
- cookie = CanonicalCookie::Create(GURL("https://www.foo.com:1234"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), 1234);
- cookie = CanonicalCookie::Create(GURL("http://www.foo.com:443"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), 443);
- // GURL's port parsing will handle any invalid ports, but let's still make
- // sure we get the expected result anyway.
- cookie = CanonicalCookie::Create(GURL("http://www.foo.com:70000"), "B=1",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(cookie->SourcePort(), url::PORT_INVALID);
- }
- // Test that a cookie string with an empty domain attribute generates a
- // canonical host cookie.
- TEST(CanonicalCookieTest, CreateHostCookieFromString) {
- // Create a new canonical host cookie via empty string domain in the
- // cookie_line.
- GURL url("http://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(CanonicalCookie::Create(
- url, "A=2; domain=; Secure", creation_time, server_time,
- absl::nullopt /*cookie_partition_key*/));
- EXPECT_EQ("www.example.com", cookie->Domain());
- EXPECT_TRUE(cookie->IsHostCookie());
- }
- TEST(CanonicalCookieTest, CreateNonStandardSameSite) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time now = base::Time::Now();
- std::unique_ptr<CanonicalCookie> cookie;
- absl::optional<base::Time> server_time = absl::nullopt;
- // Non-standard value for the SameSite attribute.
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=NonStandard", now,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- // Omit value for the SameSite attribute.
- cookie = CanonicalCookie::Create(url, "A=2; SameSite", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- }
- TEST(CanonicalCookieTest, CreateSameSiteInCrossSiteContexts) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time now = base::Time::Now();
- std::unique_ptr<CanonicalCookie> cookie;
- absl::optional<base::Time> server_time = absl::nullopt;
- // A cookie can be created from any SameSiteContext regardless of SameSite
- // value (it is upon setting the cookie that the SameSiteContext comes into
- // effect).
- cookie =
- CanonicalCookie::Create(url, "A=2; SameSite=Strict", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=Lax", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- cookie = CanonicalCookie::Create(url, "A=2; SameSite=None", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- cookie = CanonicalCookie::Create(url, "A=2;", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- }
- TEST(CanonicalCookieTest, CreateHttpOnly) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieInclusionStatus status;
- // An HttpOnly cookie can be created.
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=2; HttpOnly", now, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_TRUE(cookie->IsHttpOnly());
- EXPECT_TRUE(status.IsInclude());
- }
- TEST(CanonicalCookieTest, CreateWithInvalidDomain) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieInclusionStatus status;
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=2; Domain=wrongdomain.com", now, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_EQ(nullptr, cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- }
- TEST(CanonicalCookieTest, CreateWithNonASCIIDomain) {
- GURL url("http://www.xn--xample-9ua.com/test/foo.html");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- // Test with feature flag enabled.
- {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kCookieDomainRejectNonASCII);
- CookieInclusionStatus status;
- // Test that non-ascii characters are rejected.
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=1; Domain=\xC3\xA9xample.com", now, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_EQ(nullptr, cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN,
- CookieInclusionStatus::EXCLUDE_DOMAIN_NON_ASCII}));
- EXPECT_FALSE(
- status.HasWarningReason(CookieInclusionStatus::WARN_DOMAIN_NON_ASCII));
- }
- // Test with feature flag disabled.
- {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndDisableFeature(features::kCookieDomainRejectNonASCII);
- CookieInclusionStatus status2;
- std::unique_ptr<CanonicalCookie> cookie2 = CanonicalCookie::Create(
- url, "A=2; Domain=\xC3\xA9xample.com", now, server_time,
- absl::nullopt /* cookie_partition_key */, &status2);
- EXPECT_TRUE(cookie2.get());
- EXPECT_TRUE(status2.IsInclude());
- EXPECT_TRUE(
- status2.HasWarningReason(CookieInclusionStatus::WARN_DOMAIN_NON_ASCII));
- }
- // Test that regular ascii punycode still works.
- CookieInclusionStatus status3;
- std::unique_ptr<CanonicalCookie> cookie3 = CanonicalCookie::Create(
- url, "A=3; Domain=xn--xample-9ua.com", now, server_time,
- absl::nullopt /* cookie_partition_key */, &status3);
- EXPECT_TRUE(cookie3.get());
- EXPECT_TRUE(status3.IsInclude());
- EXPECT_FALSE(
- status3.HasWarningReason(CookieInclusionStatus::WARN_DOMAIN_NON_ASCII));
- }
- TEST(CanonicalCookieTest, CreateWithDomainAsIP) {
- GURL url("http://1.1.1.1");
- GURL url6("http://[2606:2800:220:1:248:1893:25c8:1946]");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieInclusionStatus status;
- const struct {
- const GURL url;
- const std::string cookie_line;
- const bool expectedResult;
- } kTests[] = {
- {url, "d=1;Domain=1.1.1.1;", true},
- {url, "dd=1;Domain=.1.1.1.1;", true},
- {url, "ds=1;Domain=1.1.1;", false},
- {url, "dsd=1;Domain=.1.1.1;", false},
- {url, "dx=1;Domain=0x01.0x1.0x1.0x1;", false},
- {url, "dxd=1;Domain=.0x01.0x1.0x1.0x1;", false},
- {url, "do=1;Domain=0001.0001.0001.0001;", false},
- {url, "d10=1;Domain=16843009;", false},
- {url, "d16=value;Domain=0x1010101;", false},
- {url, "d8=1;Domain=0100200401;", false},
- {url, "dm=1;Domain=00001.0x01.1.001;", false},
- {url6, "d1ipv6=1;Domain=[2606:2800:220:1:248:1893:25c8:1946];", true},
- {url6, "dd1ipv6=1;Domain=.[2606:2800:220:1:248:1893:25c8:1946];", true},
- {url6, "dc1ipv6=1;Domain=[2606:2800:220:1:248:1893:25C8:1946];", true},
- {url6, "d2ipv6=1;Domain=2606:2800:220:1:248:1893:25c8:1946;", false},
- {url6, "dd2ipv6=1;Domain=.2606:2800:220:1:248:1893:25c8:1946;", false},
- {url6, "dc2ipv6=1;Domain=2606:2800:220:1:248:1893:25C8:1946;", false},
- };
- for (const auto& test : kTests) {
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- test.url, test.cookie_line, now, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- if (test.expectedResult) {
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(test.url.host(), cookie->Domain());
- } else {
- EXPECT_EQ(nullptr, cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- }
- }
- }
- TEST(CanonicalCookieTest, CreateSameParty) {
- GURL url("http://www.example.com/test/foo.html");
- GURL https_url("https://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieInclusionStatus status;
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=2; SameParty; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_TRUE(cookie->IsSameParty());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- cookie = CanonicalCookie::Create(
- url, "A=2; SameParty; SameSite=None; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_TRUE(cookie->IsSameParty());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie->SameSite());
- cookie = CanonicalCookie::Create(
- url, "A=2; SameParty; SameSite=Lax; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_TRUE(cookie->IsSameParty());
- EXPECT_EQ(CookieSameSite::LAX_MODE, cookie->SameSite());
- // SameParty cookie with SameSite=Strict is invalid.
- cookie = CanonicalCookie::Create(
- url, "A=2; SameParty; SameSite=Strict; Secure", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- // SameParty cookie without Secure is invalid.
- cookie = CanonicalCookie::Create(
- url, "A=2; SameParty; SameSite=Lax", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- }
- TEST(CanonicalCookieTest, CreateWithPartitioned) {
- GURL url("https://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- auto partition_key = absl::make_optional(
- CookiePartitionKey::FromURLForTesting(GURL("https://toplevelsite.com")));
- CookieInclusionStatus status;
- // Valid Partitioned attribute
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "__Host-A=2; Partitioned; Path=/; Secure", creation_time,
- server_time, partition_key, &status);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key, cookie->PartitionKey());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED, cookie->SameSite());
- // Create() without Partitioned in the cookie line should not result in a
- // partitioned cookie.
- status = CookieInclusionStatus();
- cookie =
- CanonicalCookie::Create(url, "__Host-A=2; Path=/; Secure", creation_time,
- server_time, partition_key, &status);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(cookie->IsPartitioned());
- EXPECT_FALSE(cookie->PartitionKey());
- // Partitioned cookies with no __Host- prefix are still valid if they still
- // have Secure, Path=/, and no Domain.
- status = CookieInclusionStatus();
- cookie = CanonicalCookie::Create(url, "A=2; Partitioned; Path=/; Secure",
- creation_time, server_time, partition_key,
- &status);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key, cookie->PartitionKey());
- // Invalid Partitioned attribute: No Secure attribute.
- status = CookieInclusionStatus();
- cookie =
- CanonicalCookie::Create(url, "A=2; Partitioned; Path=/", creation_time,
- server_time, partition_key, &status);
- EXPECT_FALSE(cookie.get());
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PARTITIONED}));
- // Partitioned attribute: No Path attribute.
- status = CookieInclusionStatus();
- cookie =
- CanonicalCookie::Create(url, "A=2; Partitioned; Secure", creation_time,
- server_time, partition_key, &status);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key, cookie->PartitionKey());
- // Partitioned attribute: Path attribute not equal to "/".
- status = CookieInclusionStatus();
- cookie = CanonicalCookie::Create(
- url, "A=2; Partitioned; Path=/foobar; Secure", creation_time, server_time,
- partition_key, &status);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key, cookie->PartitionKey());
- // Partitioned attribute: Domain cookie.
- status = CookieInclusionStatus();
- cookie = CanonicalCookie::Create(
- url, "A=2; Partitioned; Path=/; Secure; Domain=example.com",
- creation_time, server_time, partition_key, &status);
- EXPECT_TRUE(cookie.get());
- LOG(ERROR) << status;
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key, cookie->PartitionKey());
- // No Partitioned attribute but with a nonce.
- status = CookieInclusionStatus();
- auto partition_key_with_nonce =
- absl::make_optional(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"), base::UnguessableToken::Create()));
- cookie =
- CanonicalCookie::Create(url, "__Host-A=2; Path=/; Secure", creation_time,
- server_time, partition_key_with_nonce, &status);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(cookie->IsPartitioned());
- EXPECT_EQ(partition_key_with_nonce, cookie->PartitionKey());
- }
- TEST_P(CanonicalCookieWithClampingTest, CreateWithMaxAge) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- // Max-age with positive integer.
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=1; max-age=60", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Seconds(60) + creation_time, cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- // Max-age with expires (max-age should take precedence).
- cookie = CanonicalCookie::Create(
- url, "A=1; expires=01-Jan-1970, 00:00:00 GMT; max-age=60", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Seconds(60) + creation_time, cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- // Max-age=0 should create an expired cookie with expiry equal to the earliest
- // representable time.
- cookie =
- CanonicalCookie::Create(url, "A=1; max-age=0", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_TRUE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time::Min(), cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- // Negative max-age should create an expired cookie with expiry equal to the
- // earliest representable time.
- cookie = CanonicalCookie::Create(url, "A=1; max-age=-1", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_TRUE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time::Min(), cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- // Max-age with whitespace (should be trimmed out).
- cookie = CanonicalCookie::Create(url, "A=1; max-age = 60 ; Secure",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Seconds(60) + creation_time, cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- // Max-age with non-integer should be ignored.
- cookie = CanonicalCookie::Create(url, "A=1; max-age=abcd", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_FALSE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_TRUE(cookie->IsCanonical());
- // Overflow max-age should be clipped.
- cookie = CanonicalCookie::Create(url,
- "A=1; "
- "max-age="
- "9999999999999999999999999999999999999999999"
- "999999999999999999999999999999999999999999",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- if (IsClampCookieExpiryTo400DaysEnabled()) {
- EXPECT_EQ(creation_time + base::Days(400), cookie->ExpiryDate());
- } else {
- EXPECT_EQ(base::Time::Max(), cookie->ExpiryDate());
- }
- EXPECT_TRUE(cookie->IsCanonical());
- // Underflow max-age should be clipped.
- cookie = CanonicalCookie::Create(url,
- "A=1; "
- "max-age=-"
- "9999999999999999999999999999999999999999999"
- "999999999999999999999999999999999999999999",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_TRUE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time::Min(), cookie->ExpiryDate());
- EXPECT_TRUE(cookie->IsCanonical());
- }
- TEST_P(CanonicalCookieWithClampingTest, CreateWithExpires) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- // Expires in the past
- base::Time past_date = base::Time::Now() - base::Days(10);
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=1; expires=" + base::TimeFormatHTTP(past_date), creation_time,
- server_time, absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_TRUE(cookie->IsExpired(creation_time));
- EXPECT_TRUE((past_date - cookie->ExpiryDate()).magnitude() <
- base::Seconds(1));
- EXPECT_TRUE(cookie->IsCanonical());
- // Expires in the future
- base::Time future_date = base::Time::Now() + base::Days(10);
- cookie = CanonicalCookie::Create(
- url, "A=1; expires=" + base::TimeFormatHTTP(future_date), creation_time,
- server_time, absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_TRUE((future_date - cookie->ExpiryDate()).magnitude() <
- base::Seconds(1));
- EXPECT_TRUE(cookie->IsCanonical());
- // Expires in the far future
- future_date = base::Time::Now() + base::Days(800);
- cookie = CanonicalCookie::Create(
- url, "A=1; expires=" + base::TimeFormatHTTP(future_date), creation_time,
- server_time, absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- if (IsClampCookieExpiryTo400DaysEnabled()) {
- EXPECT_TRUE(
- (cookie->ExpiryDate() - creation_time - base::Days(400)).magnitude() <
- base::Seconds(1));
- } else {
- EXPECT_TRUE((future_date - cookie->ExpiryDate()).magnitude() <
- base::Seconds(1));
- }
- EXPECT_TRUE(cookie->IsCanonical());
- // Expires in the far future using CreateUnsafeCookieForTesting.
- cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", url.host(), url.path(), creation_time, base::Time::Max(),
- base::Time(), base::Time(), true, false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_HIGH, false, absl::nullopt /* cookie_partition_key */,
- CookieSourceScheme::kSecure, 443);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time::Max(), cookie->ExpiryDate());
- EXPECT_EQ(base::Time(), cookie->LastUpdateDate());
- if (IsClampCookieExpiryTo400DaysEnabled()) {
- EXPECT_FALSE(cookie->IsCanonical());
- } else {
- EXPECT_TRUE(cookie->IsCanonical());
- }
- // Expires in the far future using FromStorage.
- cookie = CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", creation_time, base::Time::Max(),
- base::Time(), base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 443);
- EXPECT_TRUE(cookie.get());
- EXPECT_TRUE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time::Max(), cookie->ExpiryDate());
- EXPECT_EQ(base::Time(), cookie->LastUpdateDate());
- if (IsClampCookieExpiryTo400DaysEnabled()) {
- EXPECT_FALSE(cookie->IsCanonical());
- } else {
- EXPECT_TRUE(cookie->IsCanonical());
- }
- }
- TEST(CanonicalCookieTest, EmptyExpiry) {
- GURL url("http://www7.ipdl.inpit.go.jp/Tokujitu/tjkta.ipdl?N0000=108");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::string cookie_line =
- "ACSTM=20130308043820420042; path=/; domain=ipdl.inpit.go.jp; Expires=";
- std::unique_ptr<CanonicalCookie> cookie(
- CanonicalCookie::Create(url, cookie_line, creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(cookie.get());
- EXPECT_FALSE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time(), cookie->ExpiryDate());
- // With a stale server time
- server_time = creation_time - base::Hours(1);
- cookie = CanonicalCookie::Create(url, cookie_line, creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_FALSE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time(), cookie->ExpiryDate());
- // With a future server time
- server_time = creation_time + base::Hours(1);
- cookie = CanonicalCookie::Create(url, cookie_line, creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie.get());
- EXPECT_FALSE(cookie->IsPersistent());
- EXPECT_FALSE(cookie->IsExpired(creation_time));
- EXPECT_EQ(base::Time(), cookie->ExpiryDate());
- }
- TEST_P(CanonicalCookieWithClampingTest, CreateWithLastUpdate) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now() - base::Days(1);
- base::Time last_update_time = base::Time::Now() - base::Hours(1);
- absl::optional<base::Time> server_time = absl::nullopt;
- // Creating a cookie sets the last update date as now.
- std::unique_ptr<CanonicalCookie> cookie =
- CanonicalCookie::Create(url, "A=1", creation_time, server_time,
- /*cookie_partition_key=*/absl::nullopt);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE((base::Time::Now() - cookie->LastUpdateDate()).magnitude() <
- base::Seconds(1));
- // Creating a sanitized cookie sets the last update date as now.
- cookie = CanonicalCookie::CreateSanitizedCookie(
- url, "A", "1", url.host(), url.path(), creation_time, base::Time(),
- creation_time, /*secure=*/true,
- /*http_only=*/false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, /*same_party=*/false,
- /*partition_key=*/absl::nullopt);
- ASSERT_TRUE(cookie.get());
- EXPECT_TRUE((base::Time::Now() - cookie->LastUpdateDate()).magnitude() <
- base::Seconds(1));
- // Creating an unsafe cookie allows us to set the last update date.
- cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", url.host(), url.path(), creation_time, base::Time(),
- base::Time(), last_update_time, /*secure=*/true,
- /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, /*same_party=*/false,
- /*partition_key=*/absl::nullopt, CookieSourceScheme::kSecure,
- /*source_port=*/443);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(last_update_time, cookie->LastUpdateDate());
- // Loading a cookie from storage allows us to set the last update date.
- cookie = CanonicalCookie::FromStorage(
- "A", "1", url.host(), url.path(), creation_time, base::Time(),
- base::Time(), last_update_time, /*secure=*/true,
- /*httponly=*/false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, /*same_party=*/false,
- /*partition_key=*/absl::nullopt, CookieSourceScheme::kSecure,
- /*source_port=*/443);
- ASSERT_TRUE(cookie.get());
- EXPECT_EQ(last_update_time, cookie->LastUpdateDate());
- }
- TEST(CanonicalCookieTest, IsEquivalent) {
- GURL url("https://www.example.com/");
- std::string cookie_name = "A";
- std::string cookie_value = "2EDA-EF";
- std::string cookie_domain = ".www.example.com";
- std::string cookie_path = "/path";
- base::Time creation_time = base::Time::Now();
- base::Time expiration_time = creation_time + base::Days(2);
- base::Time update_time = creation_time + base::Days(1);
- bool secure = false;
- bool httponly = false;
- CookieSameSite same_site = CookieSameSite::NO_RESTRICTION;
- bool same_party = false;
- // Test that a cookie is equivalent to itself.
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Test that two identical cookies are equivalent.
- auto other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Tests that use different variations of attribute values that
- // DON'T affect cookie equivalence.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, "2", cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_HIGH, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- base::Time other_creation_time = creation_time + base::Minutes(2);
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, "2", cookie_domain, cookie_path, other_creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_name, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, true, httponly, same_site,
- COOKIE_PRIORITY_LOW, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_name, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, true, same_site,
- COOKIE_PRIORITY_LOW, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_name, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly,
- CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_LOW, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Test the effect of a differing last_update_time on equivalency.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_name, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), base::Time(), secure, httponly, same_site,
- COOKIE_PRIORITY_LOW, same_party);
- EXPECT_TRUE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- EXPECT_FALSE(cookie->HasEquivalentDataMembers(*other_cookie));
- // Cookies whose names mismatch are not equivalent.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "B", cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_FALSE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_FALSE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // A domain cookie at 'www.example.com' is not equivalent to a host cookie
- // at the same domain. These are, however, equivalent according to the laxer
- // rules of 'IsEquivalentForSecureCookieMatching'.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, "www.example.com", cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_TRUE(cookie->IsDomainCookie());
- EXPECT_FALSE(other_cookie->IsDomainCookie());
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Likewise, a cookie on 'example.com' is not equivalent to a cookie on
- // 'www.example.com', but they are equivalent for secure cookie matching.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, ".example.com", cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Paths are a bit more complicated. 'IsEquivalent' requires an exact path
- // match, while secure cookie matching uses a more relaxed 'IsOnPath' check.
- // That is, |cookie| set on '/path' is not equivalent in either way to
- // |other_cookie| set on '/test' or '/path/subpath'. It is, however,
- // equivalent for secure cookie matching to |other_cookie| set on '/'.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, "/test", creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_FALSE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_FALSE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path + "/subpath",
- creation_time, expiration_time, base::Time(), update_time, secure,
- httponly, same_site, COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- // The path comparison is asymmetric
- EXPECT_FALSE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_TRUE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, "/", creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party);
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- EXPECT_FALSE(other_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- // Partitioned cookies are not equivalent to unpartitioned cookies.
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party,
- CookiePartitionKey::FromURLForTesting(GURL("https://foo.com")));
- EXPECT_FALSE(cookie->IsEquivalent(*other_cookie));
- EXPECT_FALSE(cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- // Partitioned cookies are equal if they have the same partition key.
- auto paritioned_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party,
- CookiePartitionKey::FromURLForTesting(GURL("https://foo.com")));
- EXPECT_TRUE(paritioned_cookie->IsEquivalent(*other_cookie));
- EXPECT_TRUE(
- paritioned_cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- // Partitioned cookies with different partition keys are not equal
- other_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- cookie_name, cookie_value, cookie_domain, cookie_path, creation_time,
- expiration_time, base::Time(), update_time, secure, httponly, same_site,
- COOKIE_PRIORITY_MEDIUM, same_party,
- CookiePartitionKey::FromURLForTesting(GURL("https://bar.com")));
- EXPECT_FALSE(paritioned_cookie->IsEquivalent(*other_cookie));
- EXPECT_FALSE(
- paritioned_cookie->IsEquivalentForSecureCookieMatching(*other_cookie));
- }
- TEST(CanonicalCookieTest, IsEquivalentForSecureCookieMatching) {
- struct {
- struct {
- const char* name;
- const char* domain;
- const char* path;
- absl::optional<CookiePartitionKey> cookie_partition_key = absl::nullopt;
- } cookie, secure_cookie;
- bool equivalent;
- bool is_symmetric; // Whether the reverse comparison has the same result.
- } kTests[] = {
- // Equivalent to itself
- {{"A", "a.foo.com", "/"}, {"A", "a.foo.com", "/"}, true, true},
- {{"A", ".a.foo.com", "/"}, {"A", ".a.foo.com", "/"}, true, true},
- // Names are different
- {{"A", "a.foo.com", "/"}, {"B", "a.foo.com", "/"}, false, true},
- // Host cookie and domain cookie with same hostname match
- {{"A", "a.foo.com", "/"}, {"A", ".a.foo.com", "/"}, true, true},
- // Subdomains and superdomains match
- {{"A", "a.foo.com", "/"}, {"A", ".foo.com", "/"}, true, true},
- {{"A", ".a.foo.com", "/"}, {"A", ".foo.com", "/"}, true, true},
- {{"A", "a.foo.com", "/"}, {"A", "foo.com", "/"}, true, true},
- {{"A", ".a.foo.com", "/"}, {"A", "foo.com", "/"}, true, true},
- // Different domains don't match
- {{"A", "a.foo.com", "/"}, {"A", "b.foo.com", "/"}, false, true},
- {{"A", "a.foo.com", "/"}, {"A", "ba.foo.com", "/"}, false, true},
- // Path attribute matches if it is a subdomain, but not vice versa.
- {{"A", "a.foo.com", "/sub"}, {"A", "a.foo.com", "/"}, true, false},
- // Different paths don't match
- {{"A", "a.foo.com", "/sub"}, {"A", "a.foo.com", "/other"}, false, true},
- {{"A", "a.foo.com", "/a/b"}, {"A", "a.foo.com", "/a/c"}, false, true},
- // Partitioned cookies are not equivalent to unpartitioned cookies.
- {{"A", ".a.foo.com", "/"},
- {"A", ".a.foo.com", "/",
- CookiePartitionKey::FromURLForTesting(GURL("https://bar.com"))},
- false,
- true},
- // Partitioned cookies are equivalent if they have the same partition key.
- {{"A", "a.foo.com", "/",
- CookiePartitionKey::FromURLForTesting(GURL("https://bar.com"))},
- {"A", "a.foo.com", "/",
- CookiePartitionKey::FromURLForTesting(GURL("https://bar.com"))},
- true,
- true},
- // Partitioned cookies are *not* equivalent if they have the different
- // partition keys.
- {{"A", "a.foo.com", "/",
- CookiePartitionKey::FromURLForTesting(GURL("https://bar.com"))},
- {"A", "a.foo.com", "/",
- CookiePartitionKey::FromURLForTesting(GURL("https://baz.com"))},
- false,
- true},
- };
- for (auto test : kTests) {
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- test.cookie.name, "value1", test.cookie.domain, test.cookie.path,
- base::Time(), base::Time(), base::Time(), base::Time(),
- false /* secure */, false /* httponly */, CookieSameSite::LAX_MODE,
- COOKIE_PRIORITY_MEDIUM, false /* sameparty */,
- test.cookie.cookie_partition_key);
- auto secure_cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- test.secure_cookie.name, "value2", test.secure_cookie.domain,
- test.secure_cookie.path, base::Time(), base::Time(), base::Time(),
- base::Time(), true /* secure */, false /* httponly */,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_MEDIUM, false /* sameparty */,
- test.secure_cookie.cookie_partition_key);
- EXPECT_EQ(test.equivalent,
- cookie->IsEquivalentForSecureCookieMatching(*secure_cookie));
- EXPECT_EQ(test.equivalent == test.is_symmetric,
- secure_cookie->IsEquivalentForSecureCookieMatching(*cookie));
- }
- }
- TEST(CanonicalCookieTest, IsDomainMatch) {
- GURL url("http://www.example.com/test/foo.html");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(
- CanonicalCookie::Create(url, "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(cookie->IsHostCookie());
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
- cookie = CanonicalCookie::Create(url, "A=2; Domain=www.example.com",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsDomainCookie());
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
- cookie = CanonicalCookie::Create(url, "A=2; Domain=.www.example.com",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("www.example.com"));
- EXPECT_TRUE(cookie->IsDomainMatch("foo.www.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("www0.example.com"));
- EXPECT_FALSE(cookie->IsDomainMatch("example.com"));
- }
- TEST(CanonicalCookieTest, IsOnPath) {
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(CanonicalCookie::Create(
- GURL("http://www.example.com"), "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(cookie->IsOnPath("/"));
- EXPECT_TRUE(cookie->IsOnPath("/test"));
- EXPECT_TRUE(cookie->IsOnPath("/test/bar.html"));
- // Test the empty string edge case.
- EXPECT_FALSE(cookie->IsOnPath(std::string()));
- cookie = CanonicalCookie::Create(GURL("http://www.example.com/test/foo.html"),
- "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_FALSE(cookie->IsOnPath("/"));
- EXPECT_TRUE(cookie->IsOnPath("/test"));
- EXPECT_TRUE(cookie->IsOnPath("/test/bar.html"));
- EXPECT_TRUE(cookie->IsOnPath("/test/sample/bar.html"));
- }
- TEST(CanonicalCookieTest, GetEffectiveSameSite) {
- struct {
- CookieSameSite same_site;
- CookieEffectiveSameSite expected_effective_same_site;
- // nullopt for following members indicates same effective SameSite result
- // for all possible values.
- absl::optional<CookieAccessSemantics> access_semantics = absl::nullopt;
- absl::optional<bool> is_cookie_recent = absl::nullopt;
- } kTestCases[] = {
- // Explicitly specified SameSite always has the same effective SameSite
- // regardless of the access semantics.
- {CookieSameSite::NO_RESTRICTION, CookieEffectiveSameSite::NO_RESTRICTION},
- {CookieSameSite::LAX_MODE, CookieEffectiveSameSite::LAX_MODE},
- {CookieSameSite::STRICT_MODE, CookieEffectiveSameSite::STRICT_MODE},
- {CookieSameSite::NO_RESTRICTION, CookieEffectiveSameSite::NO_RESTRICTION},
- // UNSPECIFIED always maps to NO_RESTRICTION if LEGACY access semantics.
- {CookieSameSite::UNSPECIFIED, CookieEffectiveSameSite::NO_RESTRICTION,
- CookieAccessSemantics::LEGACY},
- // UNSPECIFIED with non-LEGACY access semantics depends on whether cookie
- // is recently created.
- {CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- CookieAccessSemantics::NONLEGACY, true},
- {CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- CookieAccessSemantics::UNKNOWN, true},
- {CookieSameSite::UNSPECIFIED, CookieEffectiveSameSite::LAX_MODE,
- CookieAccessSemantics::NONLEGACY, false},
- {CookieSameSite::UNSPECIFIED, CookieEffectiveSameSite::LAX_MODE,
- CookieAccessSemantics::UNKNOWN, false},
- };
- for (const auto& test : kTestCases) {
- std::vector<std::unique_ptr<CanonicalCookie>> cookies;
- base::Time now = base::Time::Now();
- base::Time recent_creation_time = now - (kLaxAllowUnsafeMaxAge / 4);
- base::Time not_recent_creation_time = now - (kLaxAllowUnsafeMaxAge * 4);
- base::Time expiry_time = now + (kLaxAllowUnsafeMaxAge / 4);
- if (!test.is_cookie_recent.has_value() || *test.is_cookie_recent) {
- // Recent session cookie.
- cookies.push_back(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "example.test", "/", recent_creation_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false /* httponly */,
- test.same_site, COOKIE_PRIORITY_DEFAULT, false));
- // Recent persistent cookie.
- cookies.push_back(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "example.test", "/", recent_creation_time, expiry_time,
- base::Time(), base::Time(), true /* secure */, false /* httponly */,
- test.same_site, COOKIE_PRIORITY_DEFAULT, false));
- }
- if (!test.is_cookie_recent.has_value() || !(*test.is_cookie_recent)) {
- // Not-recent session cookie.
- cookies.push_back(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "example.test", "/", not_recent_creation_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false /* httponly */,
- test.same_site, COOKIE_PRIORITY_DEFAULT, false));
- // Not-recent persistent cookie.
- cookies.push_back(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "example.test", "/", not_recent_creation_time, expiry_time,
- base::Time(), base::Time(), true /* secure */, false /* httponly */,
- test.same_site, COOKIE_PRIORITY_DEFAULT, false));
- }
- std::vector<CookieAccessSemantics> access_semantics = {
- CookieAccessSemantics::UNKNOWN, CookieAccessSemantics::LEGACY,
- CookieAccessSemantics::NONLEGACY};
- if (test.access_semantics.has_value())
- access_semantics = {*test.access_semantics};
- for (const auto& cookie : cookies) {
- for (const auto semantics : access_semantics) {
- EXPECT_EQ(test.expected_effective_same_site,
- cookie->GetEffectiveSameSiteForTesting(semantics));
- }
- }
- }
- }
- TEST(CanonicalCookieTest, IncludeForRequestURL) {
- GURL url("http://www.example.com");
- base::Time creation_time = base::Time::Now();
- CookieOptions options = CookieOptions::MakeAllInclusive();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(
- CanonicalCookie::Create(url, "A=2", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- GURL("http://www.example.com/foo/bar"), options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- GURL("https://www.example.com/foo/bar"), options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- GURL("https://sub.example.com"), options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_DOMAIN_MISMATCH}));
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- GURL("https://sub.www.example.com"), options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_DOMAIN_MISMATCH}));
- // Test that cookie with a cookie path that does not match the url path are
- // not included.
- cookie = CanonicalCookie::Create(url, "A=2; Path=/foo/bar", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_NOT_ON_PATH}));
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- GURL("http://www.example.com/foo/bar/index.html"),
- options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- // Test that a secure cookie is not included for a non secure URL.
- GURL secure_url("https://www.example.com");
- cookie = CanonicalCookie::Create(secure_url, "A=2; Secure", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsSecure());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- secure_url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SECURE_ONLY}));
- // Test that a delegate can make an exception, however, and ask for a
- // non-secure URL to be treated as trustworthy... with a warning.
- cookie =
- CanonicalCookie::Create(url, "A=2; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie);
- EXPECT_TRUE(cookie->IsSecure());
- CookieAccessResult result = cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams{net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/true,
- CookieSamePartyStatus::kNoSamePartyEnforcement});
- EXPECT_TRUE(result.status.IsInclude());
- EXPECT_TRUE(result.status.HasWarningReason(
- CookieInclusionStatus::WARN_SECURE_ACCESS_GRANTED_NON_CRYPTOGRAPHIC));
- // The same happens for localhost even w/o delegate intervention.
- GURL localhost_url("http://localhost/");
- cookie = CanonicalCookie::Create(localhost_url, "A=2; Secure", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie);
- EXPECT_TRUE(cookie->IsSecure());
- result = cookie->IncludeForRequestURL(
- localhost_url, options,
- CookieAccessParams{net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement});
- EXPECT_TRUE(result.status.IsInclude());
- EXPECT_TRUE(result.status.HasWarningReason(
- CookieInclusionStatus::WARN_SECURE_ACCESS_GRANTED_NON_CRYPTOGRAPHIC));
- // An unneeded exception doesn't add a warning, however.
- cookie = CanonicalCookie::Create(secure_url, "A=2; Secure", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie);
- EXPECT_TRUE(cookie->IsSecure());
- result = cookie->IncludeForRequestURL(
- secure_url, options,
- CookieAccessParams{net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/true,
- CookieSamePartyStatus::kNoSamePartyEnforcement});
- EXPECT_TRUE(result.status.IsInclude());
- EXPECT_FALSE(result.status.ShouldWarn());
- //
- // Test that http only cookies are only included if the include httponly flag
- // is set on the cookie options.
- options.set_include_httponly();
- cookie =
- CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_TRUE(cookie->IsHttpOnly());
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- options.set_exclude_httponly();
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- net::CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_HTTP_ONLY}));
- }
- struct IncludeForRequestURLTestCase {
- std::string cookie_line;
- CookieSameSite expected_samesite;
- CookieEffectiveSameSite expected_effective_samesite;
- CookieOptions::SameSiteCookieContext request_options_samesite_context;
- CookieInclusionStatus expected_inclusion_status;
- base::TimeDelta creation_time_delta = base::TimeDelta();
- };
- void VerifyIncludeForRequestURLTestCases(
- CookieAccessSemantics access_semantics,
- std::vector<IncludeForRequestURLTestCase> test_cases) {
- GURL url("https://example.test");
- for (const auto& test : test_cases) {
- base::Time creation_time = base::Time::Now() - test.creation_time_delta;
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, test.cookie_line, creation_time, absl::nullopt /* server_time */,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ(test.expected_samesite, cookie->SameSite());
- CookieOptions request_options;
- request_options.set_same_site_cookie_context(
- test.request_options_samesite_context);
- EXPECT_THAT(
- cookie->IncludeForRequestURL(
- url, request_options,
- CookieAccessParams{access_semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement}),
- MatchesCookieAccessResult(test.expected_inclusion_status,
- test.expected_effective_samesite,
- access_semantics, true))
- << cookie->Name() << "=" << cookie->Value();
- }
- }
- TEST(CanonicalCookieTest, IncludeForRequestURLSameSite) {
- const base::TimeDelta kLongAge = kLaxAllowUnsafeMaxAge * 4;
- const base::TimeDelta kShortAge = kLaxAllowUnsafeMaxAge / 4;
- using SameSiteCookieContext = CookieOptions::SameSiteCookieContext;
- // Test cases that are the same regardless of feature status or access
- // semantics. For Schemeful Same-Site this means that the context downgrade is
- // a no-op (such as for NO_RESTRICTION cookies) or that there is no downgrade:
- std::vector<IncludeForRequestURLTestCase> common_test_cases = {
- // Strict cookies:
- {"Common=1;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus(CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT)},
- {"Common=2;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus(CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT)},
- {"Common=3;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus(CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT)},
- {"Common=4;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus()},
- // Lax cookies:
- {"Common=5;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus(CookieInclusionStatus::EXCLUDE_SAMESITE_LAX)},
- {"Common=6;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus(CookieInclusionStatus::EXCLUDE_SAMESITE_LAX)},
- {"Common=7;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus()},
- {"Common=8;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus()},
- // Lax cookies with downgrade:
- {"Common=9;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus()},
- // None and Secure cookies:
- {"Common=10;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus()},
- {"Common=11;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus()},
- {"Common=12;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus()},
- {"Common=13;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus()},
- // Because NO_RESTRICTION cookies are always sent, the schemeful context
- // downgrades shouldn't matter.
- {"Common=14;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus()},
- {"Common=15;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus()},
- {"Common=16;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus()},
- {"Common=17;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus()},
- {"Common=18;SameSite=None;Secure", CookieSameSite::NO_RESTRICTION,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus()},
- };
- // Test cases where the unspecified-SameSite cookie defaults to SameSite=None
- // due to LEGACY access semantics):
- std::vector<IncludeForRequestURLTestCase> default_none_test_cases = {
- {"DefaultNone=1", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::
- WARN_SAMESITE_UNSPECIFIED_CROSS_SITE_CONTEXT})},
- {"DefaultNone=2", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::
- WARN_SAMESITE_UNSPECIFIED_CROSS_SITE_CONTEXT})},
- {"DefaultNone=3", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus()},
- {"DefaultNone=4", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::NO_RESTRICTION,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus()}};
- // Test cases where the unspecified-SameSite cookie defaults to SameSite=Lax:
- std::vector<IncludeForRequestURLTestCase> default_lax_test_cases = {
- // Unspecified recently-created cookies (with SameSite-by-default):
- {"DefaultLax=1", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus(
- CookieInclusionStatus::EXCLUDE_SAMESITE_UNSPECIFIED_TREATED_AS_LAX,
- CookieInclusionStatus::WARN_SAMESITE_UNSPECIFIED_CROSS_SITE_CONTEXT),
- kShortAge},
- {"DefaultLax=2", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::WARN_SAMESITE_UNSPECIFIED_LAX_ALLOW_UNSAFE}),
- kShortAge},
- {"DefaultLax=3", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus(), kShortAge},
- {"DefaultLax=4", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus(), kShortAge},
- // Unspecified not-recently-created cookies (with SameSite-by-default):
- {"DefaultLax=5", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus(
- CookieInclusionStatus::EXCLUDE_SAMESITE_UNSPECIFIED_TREATED_AS_LAX,
- CookieInclusionStatus::WARN_SAMESITE_UNSPECIFIED_CROSS_SITE_CONTEXT),
- kLongAge},
- {"DefaultLax=6", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus(
- CookieInclusionStatus::EXCLUDE_SAMESITE_UNSPECIFIED_TREATED_AS_LAX,
- CookieInclusionStatus::WARN_SAMESITE_UNSPECIFIED_CROSS_SITE_CONTEXT),
- kLongAge},
- {"DefaultLax=7", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus(), kLongAge},
- {"DefaultLax=8", CookieSameSite::UNSPECIFIED,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT),
- CookieInclusionStatus(), kLongAge},
- };
- // Test cases that require LEGACY semantics or Schemeful Same-Site to be
- // disabled.
- std::vector<IncludeForRequestURLTestCase> schemeful_disabled_test_cases = {
- {"LEGACY_Schemeful=1;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::WARN_STRICT_LAX_DOWNGRADE_STRICT_SAMESITE})},
- {"LEGACY_Schemeful=2;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE})},
- {"LEGACY_Schemeful=3;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE})},
- {"LEGACY_Schemeful=4;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE})},
- {"LEGACY_Schemeful=5;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE})},
- {"LEGACY_Schemeful=6;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(),
- {CookieInclusionStatus::WARN_LAX_CROSS_DOWNGRADE_LAX_SAMESITE})},
- };
- // Test cases that require NONLEGACY or UNKNOWN semantics with Schemeful
- // Same-Site enabled
- std::vector<IncludeForRequestURLTestCase> schemeful_enabled_test_cases = {
- {"NONLEGACY_Schemeful=1;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT},
- {CookieInclusionStatus::WARN_STRICT_LAX_DOWNGRADE_STRICT_SAMESITE})},
- {"NONLEGACY_Schemeful=2;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT},
- {CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE})},
- {"NONLEGACY_Schemeful=3;SameSite=Strict", CookieSameSite::STRICT_MODE,
- CookieEffectiveSameSite::STRICT_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT},
- {CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE})},
- {"NONLEGACY_Schemeful=4;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::SAME_SITE_LAX_METHOD_UNSAFE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_LAX},
- {CookieInclusionStatus::WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE})},
- {"NONLEGACY_Schemeful=5;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(
- SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_LAX},
- {CookieInclusionStatus::WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE})},
- {"NONLEGACY_Schemeful=6;SameSite=Lax", CookieSameSite::LAX_MODE,
- CookieEffectiveSameSite::LAX_MODE,
- SameSiteCookieContext(SameSiteCookieContext::ContextType::SAME_SITE_LAX,
- SameSiteCookieContext::ContextType::CROSS_SITE),
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_LAX},
- {CookieInclusionStatus::WARN_LAX_CROSS_DOWNGRADE_LAX_SAMESITE})},
- };
- auto SchemefulIndependentCases = [&]() {
- // Run the test cases that are independent of Schemeful Same-Site.
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::UNKNOWN,
- common_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::UNKNOWN,
- default_lax_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::LEGACY,
- common_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::LEGACY,
- default_none_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::NONLEGACY,
- common_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::NONLEGACY,
- default_lax_test_cases);
- };
- {
- // Schemeful Same-Site disabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndDisableFeature(features::kSchemefulSameSite);
- SchemefulIndependentCases();
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::LEGACY,
- schemeful_disabled_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::NONLEGACY,
- schemeful_disabled_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::UNKNOWN,
- schemeful_disabled_test_cases);
- }
- {
- // Schemeful Same-Site enabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kSchemefulSameSite);
- SchemefulIndependentCases();
- // With LEGACY access the cases should act as if schemeful is disabled, even
- // when it's not.
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::LEGACY,
- schemeful_disabled_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::NONLEGACY,
- schemeful_enabled_test_cases);
- VerifyIncludeForRequestURLTestCases(CookieAccessSemantics::UNKNOWN,
- schemeful_enabled_test_cases);
- }
- }
- // Test that SameSite=None requires Secure.
- TEST(CanonicalCookieTest, IncludeCookiesWithoutSameSiteMustBeSecure) {
- GURL url("https://www.example.com");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieOptions options;
- // Make a SameSite=None, *not* Secure cookie.
- std::unique_ptr<CanonicalCookie> cookie = CanonicalCookie::Create(
- url, "A=2; SameSite=None", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie.get());
- EXPECT_FALSE(cookie->IsSecure());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie->SameSite());
- EXPECT_EQ(CookieEffectiveSameSite::NO_RESTRICTION,
- cookie->GetEffectiveSameSiteForTesting());
- // UKNOWN semantics results in modern behavior (requiring Secure).
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_NONE_INSECURE}));
- // LEGACY semantics does not require Secure for SameSite=None cookies.
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- CookieAccessSemantics::LEGACY,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.IsInclude());
- // NONLEGACY semantics results in modern behavior (requiring Secure).
- EXPECT_TRUE(cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- CookieAccessSemantics::NONLEGACY,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement})
- .status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_NONE_INSECURE}));
- }
- TEST(CanonicalCookieTest, IncludeForRequestURLSameParty) {
- GURL url("https://www.example.com");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieOptions options;
- // SameSite is not specified.
- std::unique_ptr<CanonicalCookie> cookie_samesite_unspecified =
- CanonicalCookie::Create(url, "A=2; SameParty; Secure", creation_time,
- server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie_samesite_unspecified.get());
- EXPECT_TRUE(cookie_samesite_unspecified->IsSecure());
- EXPECT_EQ(CookieSameSite::UNSPECIFIED,
- cookie_samesite_unspecified->SameSite());
- EXPECT_EQ(CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE,
- cookie_samesite_unspecified->GetEffectiveSameSiteForTesting());
- EXPECT_TRUE(cookie_samesite_unspecified->IsSameParty());
- // SameSite=None.
- std::unique_ptr<CanonicalCookie> cookie_samesite_none =
- CanonicalCookie::Create(url, "A=2; SameSite=None; SameParty; Secure",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie_samesite_none.get());
- EXPECT_TRUE(cookie_samesite_none->IsSecure());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cookie_samesite_none->SameSite());
- EXPECT_EQ(CookieEffectiveSameSite::NO_RESTRICTION,
- cookie_samesite_none->GetEffectiveSameSiteForTesting());
- EXPECT_TRUE(cookie_samesite_none->IsSameParty());
- // SameSite=Lax.
- std::unique_ptr<CanonicalCookie> cookie_samesite_lax =
- CanonicalCookie::Create(url, "A=2; SameSite=Lax; SameParty; Secure",
- creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie_samesite_lax.get());
- EXPECT_TRUE(cookie_samesite_lax->IsSecure());
- EXPECT_EQ(CookieSameSite::LAX_MODE, cookie_samesite_lax->SameSite());
- EXPECT_EQ(CookieEffectiveSameSite::LAX_MODE,
- cookie_samesite_lax->GetEffectiveSameSiteForTesting());
- EXPECT_TRUE(cookie_samesite_lax->IsSameParty());
- for (const CanonicalCookie* cookie : {
- cookie_samesite_unspecified.get(),
- cookie_samesite_none.get(),
- cookie_samesite_lax.get(),
- }) {
- // SameParty cookies that should be excluded result in the appropriate
- // exclusion reason, and removes SAMESITE exclusion reasons.
- for (CookieAccessSemantics access_semantics : {
- CookieAccessSemantics::UNKNOWN,
- CookieAccessSemantics::LEGACY,
- CookieAccessSemantics::NONLEGACY,
- }) {
- EXPECT_THAT(cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams{
- access_semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kEnforceSamePartyExclude}),
- MatchesCookieAccessResult(
- HasExactlyExclusionReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(
- {CookieInclusionStatus::
- EXCLUDE_SAMEPARTY_CROSS_PARTY_CONTEXT})),
- _, _, true))
- << "SameSite = " << static_cast<int>(cookie->SameSite())
- << ", access_semantics = " << static_cast<int>(access_semantics);
- }
- }
- }
- TEST(CanonicalCookieTest, IncludeForRequestURL_SameSiteNone_Metrics) {
- using SamePartyContextType = SamePartyContext::Type;
- constexpr bool delegate_treats_url_as_trustworthy = false;
- const base::Time now = base::Time::Now();
- const auto make_cookie = [now](CookieSameSite same_site, bool same_party) {
- return CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.com", "/test", now, base::Time(), base::Time(),
- base::Time(), true /* secure */, false /*httponly*/, same_site,
- COOKIE_PRIORITY_DEFAULT, same_party);
- };
- GURL url("https://www.example.com/test");
- const std::unique_ptr<CanonicalCookie> same_site_none_cookie =
- make_cookie(CookieSameSite::NO_RESTRICTION, false /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_party_cookie =
- make_cookie(CookieSameSite::NO_RESTRICTION, true /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_site_lax_cookie =
- make_cookie(CookieSameSite::LAX_MODE, false /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_site_strict_cookie =
- make_cookie(CookieSameSite::STRICT_MODE, false /* same_party */);
- CookieOptions options;
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- // Same as default, but just to be explicit:
- options.set_same_party_context(
- SamePartyContext(SamePartyContext::Type::kCrossParty));
- // Check that the most restrictive context is recognized and enforced.
- EXPECT_THAT(
- same_site_none_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyExclude)),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Now tweak the context to allow a SameParty cookie (using the top&resource
- // definition) and make sure we get the right warning. (Note: we make the
- // "real" same-partyness value match the value computed for the metric, even
- // though they would differ unless we changed the real definition.) Then
- // check that if we modify the cookie as indicated, the set would be allowed,
- // but the next-most-restrictive variation would still be blocked.
- options.set_same_party_context(
- SamePartyContext(SamePartyContextType::kSameParty));
- EXPECT_THAT(
- same_site_none_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyInclude)),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Next: allow a SameParty cookie (using both definitions).
- options.set_same_party_context(SamePartyContext::MakeInclusive());
- EXPECT_THAT(
- same_site_none_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Next: allow a SameSite=Lax cookie.
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_LAX));
- EXPECT_THAT(
- same_site_none_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_strict_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Next: allow a SameSite=Strict cookie.
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_STRICT));
- EXPECT_THAT(
- same_site_none_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_site_strict_cookie->IncludeForRequestURL(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement)),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- }
- // Test that the CookieInclusionStatus warning for inclusion changed by
- // cross-site redirect context downgrade is applied correctly.
- TEST(CanonicalCookieTest, IncludeForRequestURL_RedirectDowngradeWarning) {
- using Context = CookieOptions::SameSiteCookieContext;
- using ContextType = Context::ContextType;
- Context::ContextMetadata strict_lax_downgrade_metadata,
- strict_cross_downgrade_metadata;
- strict_lax_downgrade_metadata.cross_site_redirect_downgrade =
- Context::ContextMetadata::ContextDowngradeType::kStrictToLax;
- strict_cross_downgrade_metadata.cross_site_redirect_downgrade =
- Context::ContextMetadata::ContextDowngradeType::kStrictToCross;
- GURL url("https://www.example.test/test");
- GURL insecure_url("http://www.example.test/test");
- const struct {
- ContextType context_type;
- Context::ContextMetadata metadata;
- CookieSameSite samesite;
- bool expect_cross_site_redirect_warning;
- } kTestCases[] = {
- // Strict-to-lax downgrade.
- {ContextType::SAME_SITE_STRICT, strict_lax_downgrade_metadata,
- CookieSameSite::STRICT_MODE, true},
- {ContextType::SAME_SITE_LAX, strict_lax_downgrade_metadata,
- CookieSameSite::STRICT_MODE, true},
- {ContextType::SAME_SITE_STRICT, strict_lax_downgrade_metadata,
- CookieSameSite::LAX_MODE, false},
- {ContextType::SAME_SITE_LAX, strict_lax_downgrade_metadata,
- CookieSameSite::LAX_MODE, false},
- {ContextType::SAME_SITE_STRICT, strict_lax_downgrade_metadata,
- CookieSameSite::NO_RESTRICTION, false},
- {ContextType::SAME_SITE_LAX, strict_lax_downgrade_metadata,
- CookieSameSite::NO_RESTRICTION, false},
- // Strict-to-cross downgrade.
- {ContextType::SAME_SITE_STRICT, strict_cross_downgrade_metadata,
- CookieSameSite::STRICT_MODE, true},
- {ContextType::CROSS_SITE, strict_cross_downgrade_metadata,
- CookieSameSite::STRICT_MODE, true},
- {ContextType::SAME_SITE_STRICT, strict_cross_downgrade_metadata,
- CookieSameSite::LAX_MODE, true},
- {ContextType::CROSS_SITE, strict_cross_downgrade_metadata,
- CookieSameSite::LAX_MODE, true},
- {ContextType::SAME_SITE_STRICT, strict_cross_downgrade_metadata,
- CookieSameSite::NO_RESTRICTION, false},
- {ContextType::CROSS_SITE, strict_cross_downgrade_metadata,
- CookieSameSite::NO_RESTRICTION, false},
- };
- for (bool consider_redirects : {true, false}) {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitWithFeatureState(
- features::kCookieSameSiteConsidersRedirectChain, consider_redirects);
- for (CookieAccessSemantics semantics :
- {CookieAccessSemantics::LEGACY, CookieAccessSemantics::NONLEGACY}) {
- // There are no downgrade warnings for undowngraded contexts.
- for (ContextType context_type :
- {ContextType::SAME_SITE_STRICT, ContextType::SAME_SITE_LAX,
- ContextType::SAME_SITE_LAX_METHOD_UNSAFE,
- ContextType::CROSS_SITE}) {
- for (CookieSameSite samesite :
- {CookieSameSite::UNSPECIFIED, CookieSameSite::NO_RESTRICTION,
- CookieSameSite::LAX_MODE, CookieSameSite::STRICT_MODE}) {
- std::unique_ptr<CanonicalCookie> cookie =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.test", "/test", base::Time::Now(),
- base::Time(), base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, samesite, COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false);
- CookieOptions options;
- options.set_same_site_cookie_context(Context(context_type));
- EXPECT_FALSE(
- cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement))
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION));
- }
- }
- for (const auto& test : kTestCases) {
- std::unique_ptr<CanonicalCookie> cookie =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.test", "/test", base::Time::Now(),
- base::Time(), base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, test.samesite, COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false);
- CookieOptions options;
- options.set_same_site_cookie_context(
- Context(test.context_type, test.context_type, test.metadata,
- test.metadata));
- EXPECT_EQ(
- cookie
- ->IncludeForRequestURL(
- url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement))
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION),
- test.expect_cross_site_redirect_warning);
- // SameSite warnings not applied if other exclusion reasons apply (e.g.
- // non-https with Secure attribute).
- EXPECT_FALSE(
- cookie
- ->IncludeForRequestURL(
- insecure_url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement))
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION));
- }
- }
- }
- }
- TEST(CanonicalCookieTest, MultipleExclusionReasons) {
- GURL url("http://www.not-secure.com/foo");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieOptions options;
- options.set_exclude_httponly();
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- // Test IncludeForRequestURL()
- // Note: This is a cookie that should never exist normally, because Create()
- // would weed it out.
- auto cookie1 = CanonicalCookie::CreateUnsafeCookieForTesting(
- "name", "value", "other-domain.com", "/bar", creation_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, true /* httponly */,
- CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie1->IncludeForRequestURL(
- url, options,
- CookieAccessParams{CookieAccessSemantics::UNKNOWN,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement}),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting({
- CookieInclusionStatus::EXCLUDE_HTTP_ONLY,
- CookieInclusionStatus::EXCLUDE_SECURE_ONLY,
- CookieInclusionStatus::EXCLUDE_DOMAIN_MISMATCH,
- CookieInclusionStatus::EXCLUDE_NOT_ON_PATH,
- CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT,
- }),
- _, _, false));
- // Test Create()
- CookieInclusionStatus create_status;
- auto cookie2 = CanonicalCookie::Create(
- url, "__Secure-notactuallysecure=value;Domain=some-other-domain.com",
- creation_time, server_time, absl::nullopt /* cookie_partition_key */,
- &create_status);
- ASSERT_FALSE(cookie2);
- EXPECT_TRUE(create_status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX,
- CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- // Test IsSetPermittedInContext()
- auto cookie3 = CanonicalCookie::Create(
- url, "name=value;HttpOnly;SameSite=Lax", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */);
- ASSERT_TRUE(cookie3);
- EXPECT_THAT(
- cookie3->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_HTTP_ONLY,
- CookieInclusionStatus::EXCLUDE_SAMESITE_LAX}),
- _, _, false));
- }
- TEST(CanonicalCookieTest, PartialCompare) {
- GURL url("http://www.example.com");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> cookie(
- CanonicalCookie::Create(url, "a=b", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- std::unique_ptr<CanonicalCookie> cookie_different_path(
- CanonicalCookie::Create(url, "a=b; path=/foo", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- std::unique_ptr<CanonicalCookie> cookie_different_value(
- CanonicalCookie::Create(url, "a=c", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- // Cookie is equivalent to itself.
- EXPECT_FALSE(cookie->PartialCompare(*cookie));
- // Changing the path affects the ordering.
- EXPECT_TRUE(cookie->PartialCompare(*cookie_different_path));
- EXPECT_FALSE(cookie_different_path->PartialCompare(*cookie));
- // Changing the value does not affect the ordering.
- EXPECT_FALSE(cookie->PartialCompare(*cookie_different_value));
- EXPECT_FALSE(cookie_different_value->PartialCompare(*cookie));
- // Cookies identical for PartialCompare() are equivalent.
- EXPECT_TRUE(cookie->IsEquivalent(*cookie_different_value));
- EXPECT_TRUE(cookie->IsEquivalent(*cookie));
- }
- TEST(CanonicalCookieTest, SecureCookiePrefix) {
- GURL https_url("https://www.example.test");
- GURL http_url("http://www.example.test");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- CookieInclusionStatus status;
- // A __Secure- cookie must be Secure.
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Secure-A=B", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Secure-A=B; httponly", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- // (EXCLUDE_HTTP_ONLY would be fine, too)
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // A typoed prefix does not have to be Secure.
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__secure-A=B; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__secure-A=C;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__SecureA=B; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__SecureA=C;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- // A __Secure- cookie can't be set on a non-secure origin.
- EXPECT_FALSE(CanonicalCookie::Create(
- http_url, "__Secure-A=B; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // Hidden __Secure- prefixes should be rejected.
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "=__Secure-A=B; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // While tricky, this isn't considered hidden and is fine.
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "A=__Secure-A=B; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- }
- TEST(CanonicalCookieTest, HostCookiePrefix) {
- GURL https_url("https://www.example.test");
- GURL http_url("http://www.example.test");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::string domain = https_url.host();
- CookieInclusionStatus status;
- // A __Host- cookie must be Secure.
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Domain=" + domain + "; Path=/;", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Path=/; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- // A __Host- cookie must be set from a secure scheme.
- EXPECT_FALSE(CanonicalCookie::Create(
- http_url, "__Host-A=B; Domain=" + domain + "; Path=/; Secure;",
- creation_time, server_time, absl::nullopt /* cookie_partition_key */,
- &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Path=/; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- // A __Host- cookie can't have a Domain.
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Domain=" + domain + "; Path=/; Secure;",
- creation_time, server_time, absl::nullopt /* cookie_partition_key */,
- &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Domain=" + domain + "; Secure;", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // A __Host- cookie may have a domain if it's an IP address that matches the
- // URL.
- EXPECT_TRUE(CanonicalCookie::Create(
- GURL("https://127.0.0.1"),
- "__Host-A=B; Domain=127.0.0.1; Path=/; Secure;", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */, &status));
- // A __Host- cookie with an IP address domain does not need the domain
- // attribute specified explicitly (just like a normal domain).
- EXPECT_TRUE(CanonicalCookie::Create(
- GURL("https://127.0.0.1"), "__Host-A=B; Domain=; Path=/; Secure;",
- creation_time, server_time, absl::nullopt /* cookie_partition_key */,
- &status));
- // A __Host- cookie must have a Path of "/".
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Path=/foo; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Secure; Path=/;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- // Rules don't apply for a typoed prefix.
- EXPECT_TRUE(CanonicalCookie::Create(
- http_url, "__host-A=B; Domain=" + domain + "; Path=/;", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__HostA=B; Domain=" + domain + "; Secure;", creation_time,
- server_time, absl::nullopt /* cookie_partition_key */));
- // Hidden __Host- prefixes should be rejected.
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "=__Host-A=B; Path=/; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // While tricky, this isn't considered hidden and is fine.
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "A=__Host-A=B; Path=/; Secure;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- }
- TEST(CanonicalCookieTest, CanCreateSecureCookiesFromAnyScheme) {
- GURL http_url("http://www.example.com");
- GURL https_url("https://www.example.com");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- std::unique_ptr<CanonicalCookie> http_cookie_no_secure(
- CanonicalCookie::Create(http_url, "a=b", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- std::unique_ptr<CanonicalCookie> http_cookie_secure(CanonicalCookie::Create(
- http_url, "a=b; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- std::unique_ptr<CanonicalCookie> https_cookie_no_secure(
- CanonicalCookie::Create(https_url, "a=b", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- std::unique_ptr<CanonicalCookie> https_cookie_secure(CanonicalCookie::Create(
- https_url, "a=b; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- EXPECT_TRUE(http_cookie_no_secure.get());
- EXPECT_TRUE(http_cookie_secure.get());
- EXPECT_TRUE(https_cookie_no_secure.get());
- EXPECT_TRUE(https_cookie_secure.get());
- }
- TEST(CanonicalCookieTest, IsCanonical) {
- // Base correct template.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Newline in name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A\n", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Carriage return in name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A\r", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Null character in name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- std::string("A\0Z", 3), "B", "x.y", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Name begins with whitespace.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- " A", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Name ends with whitespace.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A ", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Empty name. (Note this is against the spec but compatible with other
- // browsers.)
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Space in name
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A C", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Extra space suffixing name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A ", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // '=' character in name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A=", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Separator in name.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A;", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // '=' character in value.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B=", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Separator in value.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B;", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Separator in domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", ";x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Garbage in domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "@:&", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Space in domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y ", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Empty domain. (This is against cookie spec, but needed for Chrome's
- // out-of-spec use of cookies for extensions; see http://crbug.com/730633.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Path does not start with a "/".
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Empty path.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // "localhost" as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "localhost", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // non-ASCII domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "\xC3\xA9xample.com", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // punycode domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "xn--xample-9ua.com", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Localhost IPv4 address as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "127.0.0.1", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Simple IPv4 address as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "1.2.3.4", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // period-prefixed IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", ".1.3.2.4", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // period-prefixed truncated IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", ".3.2.4", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // truncated IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "3.2.4", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Non-canonical IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "01.2.03.4", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Non-canonical IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "16843009", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Non-canonical IPv4 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "0x1010101", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Null IPv6 address as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[::]", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Localhost IPv6 address as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[::1]", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Fully speced IPv6 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[2001:0DB8:AC10:FE01:0000:0000:0000:0000]",
- "/path", base::Time(), base::Time(), base::Time(),
- base::Time(), false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Zero abbreviated IPv6 address as domain. Not canonical because of leading
- // zeros & uppercase hex letters.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[2001:0DB8:AC10:FE01::]", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Zero prefixes removed IPv6 address as domain. Not canoncial because of
- // uppercase hex letters.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[2001:DB8:AC10:FE01::]", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Lowercased hex IPv6 address as domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[2001:db8:ac10:fe01::]", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Lowercased hex IPv6 address as domain for domain cookie.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", ".[2001:db8:ac10:fe01::]", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Incomplete lowercased hex IPv6 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "[2001:db8:ac10:fe01:]", "/path", base::Time(),
- base::Time(), base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Missing square brackets in IPv6 address as domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "2606:2800:220:1:248:1893:25c8:1946", "/path",
- base::Time(), base::Time(), base::Time(), base::Time(),
- false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Properly formatted host cookie.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Insecure host cookie.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Host cookie with non-null path.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", "x.y", "/path", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Host cookie with empty domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", "", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Host cookie with period prefixed domain.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", ".x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Properly formatted secure cookie.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Secure-A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // Insecure secure cookie.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Secure-A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- // SameParty attribute used correctly (with Secure and non-Strict SameSite).
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, true)
- ->IsCanonical());
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::UNSPECIFIED, COOKIE_PRIORITY_LOW, true)
- ->IsCanonical());
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_LOW, true)
- ->IsCanonical());
- // SameParty without Secure is not canonical.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), false, false,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_LOW, true)
- ->IsCanonical());
- // SameParty with SameSite=Strict is not canonical.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_LOW, true)
- ->IsCanonical());
- // Partitioned attribute used correctly (__Host- prefix, no SameParty).
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "__Host-A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_LOW,
- /*same_party=*/false,
- CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com")))
- ->IsCanonical());
- // Partitioned attribute with no __Host- prefix is still valid if it has
- // Secure, Path=/, and no Domain.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_LOW,
- /*same_party=*/false,
- CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com")))
- ->IsCanonical());
- // Partitioned attribute invalid, not Secure.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), /*secure=*/false,
- /*httponly=*/false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_LOW,
- /*same_party=*/false,
- CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com")))
- ->IsCanonical());
- // Partitioned attribute is valid when Path != "/".
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/foo/bar", base::Time(), base::Time(),
- base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_LOW,
- /*same_party=*/false,
- CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com")))
- ->IsCanonical());
- // Partitioned attribute is valid when Domain attribute also included.
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", ".x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, CookieSameSite::UNSPECIFIED,
- COOKIE_PRIORITY_LOW,
- /*same_party=*/false,
- CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com")))
- ->IsCanonical());
- // Hidden cookie prefixes.
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "", "__Secure-a=b", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- EXPECT_FALSE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "", "__Host-a=b", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "a", "__Secure-a=b", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- EXPECT_TRUE(CanonicalCookie::CreateUnsafeCookieForTesting(
- "a", "__Host-a=b", "x.y", "/", base::Time(), base::Time(),
- base::Time(), base::Time(), true, false,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW, false)
- ->IsCanonical());
- }
- TEST(CanonicalCookieTest, TestSetCreationDate) {
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "B", "x.y", "/path", base::Time(), base::Time(), base::Time(),
- base::Time(), false, false, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_LOW, false);
- EXPECT_TRUE(cookie->CreationDate().is_null());
- base::Time now(base::Time::Now());
- cookie->SetCreationDate(now);
- EXPECT_EQ(now, cookie->CreationDate());
- }
- TEST(CanonicalCookieTest, TestPrefixHistograms) {
- base::HistogramTester histograms;
- const char kCookiePrefixHistogram[] = "Cookie.CookiePrefix";
- GURL https_url("https://www.example.test");
- base::Time creation_time = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Host-A=B;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_HOST, 1);
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__Host-A=B; Path=/; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_HOST, 2);
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__HostA=B; Path=/; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_HOST, 2);
- EXPECT_FALSE(CanonicalCookie::Create(
- https_url, "__Secure-A=B;", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_SECURE, 1);
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__Secure-A=B; Path=/; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_SECURE, 2);
- EXPECT_TRUE(CanonicalCookie::Create(
- https_url, "__SecureA=B; Path=/; Secure", creation_time, server_time,
- absl::nullopt /* cookie_partition_key */));
- histograms.ExpectBucketCount(kCookiePrefixHistogram,
- CanonicalCookie::COOKIE_PREFIX_SECURE, 2);
- }
- TEST(CanonicalCookieTest, BuildCookieLine) {
- std::vector<std::unique_ptr<CanonicalCookie>> cookies;
- GURL url("https://example.com/");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- MatchCookieLineToVector("", cookies);
- cookies.push_back(CanonicalCookie::Create(
- url, "A=B", now, server_time, absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B", cookies);
- // Nameless cookies are sent back without a prefixed '='.
- cookies.push_back(CanonicalCookie::Create(
- url, "C", now, server_time, absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B; C", cookies);
- // Cookies separated by ';'.
- cookies.push_back(CanonicalCookie::Create(
- url, "D=E", now, server_time, absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B; C; D=E", cookies);
- // BuildCookieLine doesn't reorder the list, it relies on the caller to do so.
- cookies.push_back(
- CanonicalCookie::Create(url, "F=G", now - base::Seconds(1), server_time,
- absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B; C; D=E; F=G", cookies);
- // BuildCookieLine doesn't deduplicate.
- cookies.push_back(
- CanonicalCookie::Create(url, "D=E", now - base::Seconds(2), server_time,
- absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B; C; D=E; F=G; D=E", cookies);
- // BuildCookieLine should match the spec in the case of an empty name with a
- // value containing an equal sign (even if it currently produces "invalid"
- // cookie lines).
- cookies.push_back(CanonicalCookie::Create(
- url, "=H=I", now, server_time, absl::nullopt /* cookie_partition_key */));
- MatchCookieLineToVector("A=B; C; D=E; F=G; D=E; H=I", cookies);
- }
- TEST(CanonicalCookieTest, BuildCookieAttributesLine) {
- std::unique_ptr<CanonicalCookie> cookie;
- GURL url("https://example.com/");
- base::Time now = base::Time::Now();
- absl::optional<base::Time> server_time = absl::nullopt;
- cookie = CanonicalCookie::Create(url, "A=B", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ("A=B; domain=example.com; path=/",
- CanonicalCookie::BuildCookieAttributesLine(*cookie));
- // Nameless cookies are sent back without a prefixed '='.
- cookie = CanonicalCookie::Create(url, "C", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ("C; domain=example.com; path=/",
- CanonicalCookie::BuildCookieAttributesLine(*cookie));
- // BuildCookieAttributesLine should match the spec in the case of an empty
- // name with a value containing an equal sign (even if it currently produces
- // "invalid" cookie lines).
- cookie = CanonicalCookie::Create(url, "=H=I", now, server_time,
- absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ("H=I; domain=example.com; path=/",
- CanonicalCookie::BuildCookieAttributesLine(*cookie));
- // BuildCookieAttributesLine should include all attributes.
- cookie = CanonicalCookie::Create(
- url, "A=B; domain=.example.com; path=/; secure; httponly; samesite=lax",
- now, server_time, absl::nullopt /* cookie_partition_key */);
- EXPECT_EQ("A=B; domain=.example.com; path=/; secure; httponly; samesite=lax",
- CanonicalCookie::BuildCookieAttributesLine(*cookie));
- }
- // Confirm that input arguments are reflected in the output cookie.
- TEST(CanonicalCookieTest, CreateSanitizedCookie_Inputs) {
- base::Time two_hours_ago = base::Time::Now() - base::Hours(2);
- base::Time one_hour_ago = base::Time::Now() - base::Hours(1);
- base::Time one_hour_from_now = base::Time::Now() + base::Hours(1);
- CookieInclusionStatus status;
- std::unique_ptr<CanonicalCookie> cc;
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ("A", cc->Name());
- EXPECT_EQ("B", cc->Value());
- EXPECT_EQ("www.foo.com", cc->Domain());
- EXPECT_EQ("/foo", cc->Path());
- EXPECT_EQ(base::Time(), cc->CreationDate());
- EXPECT_EQ(base::Time(), cc->LastAccessDate());
- EXPECT_EQ(base::Time(), cc->ExpiryDate());
- EXPECT_FALSE(cc->IsSecure());
- EXPECT_FALSE(cc->IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cc->SameSite());
- EXPECT_EQ(COOKIE_PRIORITY_MEDIUM, cc->Priority());
- EXPECT_FALSE(cc->IsSameParty());
- EXPECT_FALSE(cc->IsPartitioned());
- EXPECT_FALSE(cc->IsDomainCookie());
- EXPECT_TRUE(status.IsInclude());
- // Creation date
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- two_hours_ago, base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(two_hours_ago, cc->CreationDate());
- EXPECT_TRUE(status.IsInclude());
- // Last access date
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- two_hours_ago, base::Time(), one_hour_ago, false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(one_hour_ago, cc->LastAccessDate());
- EXPECT_TRUE(status.IsInclude());
- // Expiry
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(one_hour_from_now, cc->ExpiryDate());
- EXPECT_TRUE(status.IsInclude());
- // Secure
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), true /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_TRUE(cc->IsSecure());
- EXPECT_TRUE(status.IsInclude());
- // Httponly
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- true /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_TRUE(cc->IsHttpOnly());
- EXPECT_TRUE(status.IsInclude());
- // Same site
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(CookieSameSite::LAX_MODE, cc->SameSite());
- EXPECT_TRUE(status.IsInclude());
- // Priority
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(COOKIE_PRIORITY_LOW, cc->Priority());
- EXPECT_TRUE(status.IsInclude());
- // Domain cookie
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", "www.foo.com", "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_TRUE(cc->IsDomainCookie());
- EXPECT_TRUE(status.IsInclude());
- // SameParty
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), true /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW,
- true /*same_party*/, absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_TRUE(cc->IsSameParty());
- EXPECT_TRUE(status.IsInclude());
- // Partitioned
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- base::Time(), base::Time(), base::Time(), true /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW,
- false /*same_party*/,
- CookiePartitionKey::FromURLForTesting(GURL("https://toplevelsite.com")),
- &status);
- EXPECT_TRUE(cc);
- EXPECT_TRUE(cc->IsPartitioned());
- EXPECT_TRUE(status.IsInclude());
- }
- // Make sure sanitization and blocking of cookies works correctly.
- TEST(CanonicalCookieTest, CreateSanitizedCookie_Logic) {
- base::Time two_hours_ago = base::Time::Now() - base::Hours(2);
- base::Time one_hour_ago = base::Time::Now() - base::Hours(1);
- base::Time one_hour_from_now = base::Time::Now() + base::Hours(1);
- CookieInclusionStatus status;
- // Simple path and domain variations.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/bar"), "C", "D", "www.foo.com", "/",
- two_hours_ago, base::Time(), one_hour_ago, false /*secure*/,
- true /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "E", "F", std::string(), std::string(),
- base::Time(), base::Time(), base::Time(), true /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // Test the file:// protocol.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("file:///"), "A", "B", std::string(), "/foo", one_hour_ago,
- one_hour_from_now, base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("file:///home/user/foo.txt"), "A", "B", std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("file:///home/user/foo.txt"), "A", "B", "home", "/foo", one_hour_ago,
- one_hour_from_now, base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- // Test that malformed attributes fail to set the cookie.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), " A", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A;", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A=", "B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A\x07", "B", std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", " B", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "\x0fZ", std::string(), "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", "www.foo.com ", "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", "foo.ozzzzzzle", "/foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", std::string(), "foo",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", std::string(), "/foo ",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", "%2Efoo.com", "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://domaintest.%E3%81%BF%E3%82%93%E3%81%AA"), "A", "B",
- "domaintest.%E3%81%BF%E3%82%93%E3%81%AA", "/foo", base::Time(),
- base::Time(), base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- std::unique_ptr<CanonicalCookie> cc;
- // Confirm that setting domain cookies with or without leading periods,
- // or on domains different from the URL's, functions correctly.
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", "www.foo.com", "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- ASSERT_TRUE(cc);
- EXPECT_TRUE(cc->IsDomainCookie());
- EXPECT_EQ(".www.foo.com", cc->Domain());
- EXPECT_TRUE(status.IsInclude());
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", ".www.foo.com", "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- ASSERT_TRUE(cc);
- EXPECT_TRUE(cc->IsDomainCookie());
- EXPECT_EQ(".www.foo.com", cc->Domain());
- EXPECT_TRUE(status.IsInclude());
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", ".foo.com", "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- ASSERT_TRUE(cc);
- EXPECT_TRUE(cc->IsDomainCookie());
- EXPECT_EQ(".foo.com", cc->Domain());
- EXPECT_TRUE(status.IsInclude());
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "A", "B", ".www2.www.foo.com", "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- // Secure/URL Scheme mismatch.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", std::string(), "/foo ",
- base::Time(), base::Time(), base::Time(), true /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- // Null creation date/non-null last access date conflict.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", std::string(), "/foo", base::Time(),
- base::Time(), base::Time::Now(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- // Domain doesn't match URL
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", "www.bar.com", "/", base::Time(),
- base::Time(), base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- // Path with unusual characters escaped.
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", std::string(), "/foo\x7F",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- ASSERT_TRUE(cc);
- EXPECT_EQ("/foo%7F", cc->Path());
- EXPECT_TRUE(status.IsInclude());
- // Ensure that all characters get escaped the same on all platforms. This is
- // also useful for visualizing which characters will actually be escaped.
- std::stringstream ss;
- ss << "/";
- for (uint8_t character = 0; character < 0xFF; character++) {
- // Skip any "terminating characters" that CreateSanitizedCookie does not
- // allow to be in `path`.
- if (character == '\0' || character == '\n' || character == '\r' ||
- character == ';') {
- continue;
- }
- ss << character;
- }
- ss << "\xFF";
- std::string initial(ss.str());
- std::string expected =
- "/%01%02%03%04%05%06%07%08%09%0B%0C%0E%0F%10%11%12%13%14%15%16%17%18%19%"
- "1A%1B%1C%1D%1E%1F%20!%22%23$%&'()*+,-./"
- "0123456789:%3C=%3E%3F@ABCDEFGHIJKLMNOPQRSTUVWXYZ[/"
- "]%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~%7F%80%81%82%83%84%85%86%87%"
- "88%89%8A%8B%8C%8D%8E%8F%90%91%92%93%94%95%96%97%98%99%9A%9B%9C%9D%9E%9F%"
- "A0%A1%A2%A3%A4%A5%A6%A7%A8%A9%AA%AB%AC%AD%AE%AF%B0%B1%B2%B3%B4%B5%B6%B7%"
- "B8%B9%BA%BB%BC%BD%BE%BF%C0%C1%C2%C3%C4%C5%C6%C7%C8%C9%CA%CB%CC%CD%CE%CF%"
- "D0%D1%D2%D3%D4%D5%D6%D7%D8%D9%DA%DB%DC%DD%DE%DF%E0%E1%E2%E3%E4%E5%E6%E7%"
- "E8%E9%EA%EB%EC%ED%EE%EF%F0%F1%F2%F3%F4%F5%F6%F7%F8%F9%FA%FB%FC%FD%FE%FF";
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "A", "B", std::string(), initial,
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- ASSERT_TRUE(cc);
- EXPECT_EQ(expected, cc->Path());
- EXPECT_TRUE(status.IsInclude());
- // Empty name and value.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "", "", std::string(), "/", base::Time(),
- base::Time(), base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- // Check that value can contain an equal sign, even when no name is present.
- // Note that in newer drafts of RFC6265bis, it is specified that a cookie with
- // an empty name and a value containing an equal sign should result in a
- // corresponding cookie line that omits the preceding equal sign. This means
- // that the cookie line won't be deserialized into the original cookie in this
- // case. For now, we'll test for compliance with the spec here, but we aim to
- // collect metrics and hopefully fix this in the spec (and then in
- // CanonicalCookie) at some point.
- // For reference, see: https://github.com/httpwg/http-extensions/pull/1592
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "", "ambiguous=value", std::string(),
- std::string(), base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- std::vector<std::unique_ptr<CanonicalCookie>> cookies;
- cookies.push_back(std::move(cc));
- MatchCookieLineToVector("ambiguous=value", cookies);
- // Check that name can't contain an equal sign ("ambiguous=name=value" should
- // correctly be parsed as name: "ambiguous" and value "name=value", so
- // allowing this case would result in cookies that can't serialize correctly).
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com"), "ambiguous=name", "value", std::string(),
- std::string(), base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE}));
- // A __Secure- cookie must be Secure.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Secure-A", "B", ".www.foo.com", "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Secure-A", "B", ".www.foo.com", "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, false, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // A __Host- cookie must be Secure.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, false, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // A __Host- cookie must have path "/".
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/foo",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // A __Host- cookie must not specify a domain.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", ".www.foo.com", "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // Without __Host- prefix, this is a valid host cookie because it does not
- // specify a domain.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // Without __Host- prefix, this is a valid domain (not host) cookie.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".www.foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // The __Host- prefix should not prevent otherwise-valid host cookies from
- // being accepted.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://127.0.0.1"), "A", "B", std::string(), "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://127.0.0.1"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // Host cookies should not specify domain unless it is an IP address that
- // matches the URL.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://127.0.0.1"), "A", "B", "127.0.0.1", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://127.0.0.1"), "__Host-A", "B", "127.0.0.1", "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // Cookies with hidden prefixes should be rejected.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "", "__Host-A=B", "", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "", "__Secure-A=B", "", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PREFIX}));
- // While tricky, this aren't considered hidden prefixes and should succeed.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "__Host-A=B", "", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "__Secure-A=B", "", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // SameParty attribute requires Secure and forbids SameSite=Strict.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".www.foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true /*secure*/, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- true /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".www.foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, false /*secure*/, false,
- CookieSameSite::LAX_MODE, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- true /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".www.foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true /*secure*/, false,
- CookieSameSite::STRICT_MODE, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- true /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".www.foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, false /*secure*/, false,
- CookieSameSite::STRICT_MODE, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- true /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- // Partitioned attribute requires __Host- and forbids SameParty.
- status = CookieInclusionStatus();
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "__Host-A", "B", std::string(), "/",
- two_hours_ago, one_hour_from_now, one_hour_ago, true /*secure*/, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/,
- absl::optional<CookiePartitionKey>(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"))),
- &status));
- EXPECT_TRUE(status.IsInclude());
- // No __Host- prefix is still valid if the cookie still has Secure, Path=/,
- // and no Domain.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, true /*secure*/, false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/,
- absl::optional<CookiePartitionKey>(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"))),
- &status));
- EXPECT_TRUE(status.IsInclude());
- status = CookieInclusionStatus();
- // Invalid: Not Secure.
- status = CookieInclusionStatus();
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, /*secure=*/false, /*http_only=*/false,
- CookieSameSite::LAX_MODE, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false,
- absl::optional<CookiePartitionKey>(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"))),
- &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_PARTITIONED}));
- // Invalid: invalid Path.
- status = CookieInclusionStatus();
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", std::string(), "/foobar",
- two_hours_ago, one_hour_from_now, one_hour_ago, /*secure=*/true,
- /*http_only=*/false, CookieSameSite::NO_RESTRICTION,
- CookiePriority::COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false,
- absl::optional<CookiePartitionKey>(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"))),
- &status));
- EXPECT_TRUE(status.IsInclude());
- // Domain attribute present is still valid.
- status = CookieInclusionStatus();
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("https://www.foo.com"), "A", "B", ".foo.com", "/", two_hours_ago,
- one_hour_from_now, one_hour_ago, /*secure=*/true, /*http_only=*/false,
- CookieSameSite::NO_RESTRICTION, CookiePriority::COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false,
- absl::optional<CookiePartitionKey>(CookiePartitionKey::FromURLForTesting(
- GURL("https://toplevelsite.com"))),
- &status));
- EXPECT_TRUE(status.IsInclude());
- status = CookieInclusionStatus();
- // Check that CreateSanitizedCookie can gracefully fail on inputs that would
- // crash cookie_util::GetCookieDomainWithString due to failing
- // DCHECKs. Specifically, GetCookieDomainWithString requires that if the
- // domain is empty or the URL's host matches the domain, then the URL's host
- // must pass DomainIsHostOnly; it must not begin with a period.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://..."), "A", "B", "...", "/", base::Time(), base::Time(),
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://."), "A", "B", std::string(), "/", base::Time(),
- base::Time(), base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://.chromium.org"), "A", "B", ".chromium.org", "/",
- base::Time(), base::Time(), base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- // Check that a file URL with an IPv6 host, and matching IPv6 domain, are
- // valid.
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("file://[A::]"), "A", "B", "[A::]", "", base::Time(), base::Time(),
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- // On Windows, URLs beginning with two backslashes are considered file
- // URLs. On other platforms, they are invalid.
- auto double_backslash_ipv6_cookie = CanonicalCookie::CreateSanitizedCookie(
- GURL("\\\\[A::]"), "A", "B", "[A::]", "", base::Time(), base::Time(),
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- #if BUILDFLAG(IS_WIN)
- EXPECT_TRUE(double_backslash_ipv6_cookie);
- EXPECT_TRUE(double_backslash_ipv6_cookie->IsCanonical());
- EXPECT_TRUE(status.IsInclude());
- #else
- EXPECT_FALSE(double_backslash_ipv6_cookie);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN}));
- #endif
- // Confirm multiple error types can be set.
- EXPECT_FALSE(CanonicalCookie::CreateSanitizedCookie(
- GURL(""), "", "", "", "", base::Time(), base::Time(), base::Time::Now(),
- true /*secure*/, true /*httponly*/, CookieSameSite::STRICT_MODE,
- COOKIE_PRIORITY_DEFAULT, true /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_FAILURE_TO_STORE,
- CookieInclusionStatus::EXCLUDE_INVALID_DOMAIN,
- CookieInclusionStatus::EXCLUDE_INVALID_SAMEPARTY}));
- // Check that RFC6265bis name + value string length limits are enforced.
- std::string max_name(ParsedCookie::kMaxCookieNamePlusValueSize, 'a');
- std::string max_value(ParsedCookie::kMaxCookieNamePlusValueSize, 'b');
- std::string almost_max_name = max_name.substr(1, std::string::npos);
- std::string almost_max_value = max_value.substr(1, std::string::npos);
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), max_name, "", std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "", max_value, std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), almost_max_name, "b", std::string(),
- "/foo", one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- EXPECT_TRUE(CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "a", almost_max_value, std::string(),
- "/foo", one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status));
- EXPECT_TRUE(status.IsInclude());
- for (const bool toggle : {false, true}) {
- base::test::ScopedFeatureList scope_feature_list;
- scope_feature_list.InitWithFeatureState(
- features::kExtraCookieValidityChecks, toggle);
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), max_name, "X", std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- if (base::FeatureList::IsEnabled(features::kExtraCookieValidityChecks)) {
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_NAME_VALUE_PAIR_EXCEEDS_MAX_SIZE}));
- } else {
- EXPECT_TRUE(cc);
- EXPECT_TRUE(status.IsInclude());
- }
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/foo"), "X", max_value, std::string(), "/foo",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- if (base::FeatureList::IsEnabled(features::kExtraCookieValidityChecks)) {
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_NAME_VALUE_PAIR_EXCEEDS_MAX_SIZE}));
- } else {
- EXPECT_TRUE(cc);
- EXPECT_TRUE(status.IsInclude());
- }
- }
- // Check that the RFC6265bis attribute value size limits apply to the Path
- // attribute value.
- std::string almost_max_path(ParsedCookie::kMaxCookieAttributeValueSize - 1,
- 'c');
- std::string max_path = "/" + almost_max_path;
- std::string too_long_path = "/X" + almost_max_path;
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com" + max_path), "name", "value", std::string(),
- max_path, one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(max_path, cc->Path());
- EXPECT_TRUE(status.IsInclude());
- for (const bool toggle : {false, true}) {
- base::test::ScopedFeatureList scope_feature_list;
- scope_feature_list.InitWithFeatureState(
- features::kExtraCookieValidityChecks, toggle);
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/path-attr-from-url/"), "name", "value",
- std::string(), too_long_path, one_hour_ago, one_hour_from_now,
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- if (base::FeatureList::IsEnabled(features::kExtraCookieValidityChecks)) {
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_ATTRIBUTE_VALUE_EXCEEDS_MAX_SIZE}));
- } else {
- EXPECT_TRUE(cc);
- EXPECT_EQ(too_long_path, cc->Path());
- EXPECT_TRUE(status.IsInclude());
- }
- }
- // Check that length limits on the Path attribute value are not enforced in
- // the case where no Path attribute is specified and the path value is
- // implicitly set from the URL.
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com" + too_long_path + "/"), "name", "value",
- std::string(), std::string(), one_hour_ago, one_hour_from_now,
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(too_long_path, cc->Path());
- EXPECT_TRUE(status.IsInclude());
- // The Path attribute value gets URL-encoded, so ensure that the size limit is
- // enforced after this (to avoid setting cookies where the Path attribute
- // value would otherwise exceed the lengths specified in the RFC).
- for (const bool toggle : {false, true}) {
- base::test::ScopedFeatureList scope_feature_list;
- scope_feature_list.InitWithFeatureState(
- features::kExtraCookieValidityChecks, toggle);
- std::string expanding_path(ParsedCookie::kMaxCookieAttributeValueSize / 2,
- '#');
- expanding_path = "/" + expanding_path;
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.foo.com/path-attr-from-url/"), "name", "value",
- std::string(), expanding_path, one_hour_ago, one_hour_from_now,
- base::Time(), false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/, &status);
- if (base::FeatureList::IsEnabled(features::kExtraCookieValidityChecks)) {
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_ATTRIBUTE_VALUE_EXCEEDS_MAX_SIZE}));
- } else {
- EXPECT_TRUE(cc);
- // "#" expands into "%23"; -2 because '/' doesn't expand
- EXPECT_EQ((expanding_path.size() * 3) - 2, cc->Path().size());
- EXPECT_TRUE(status.IsInclude());
- }
- }
- // Check that the RFC6265bis attribute value size limits apply to the Domain
- // attribute value.
- std::string max_domain(ParsedCookie::kMaxCookieAttributeValueSize, 'd');
- max_domain.replace(ParsedCookie::kMaxCookieAttributeValueSize - 4, 4, ".com");
- std::string too_long_domain = "x" + max_domain;
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://" + max_domain + "/"), "name", "value", max_domain, "/",
- one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(max_domain, cc->DomainWithoutDot());
- EXPECT_TRUE(status.IsInclude());
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://www.domain-from-url.com/"), "name", "value", too_long_domain,
- "/", one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_FALSE(cc);
- EXPECT_TRUE(status.HasExactlyExclusionReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_ATTRIBUTE_VALUE_EXCEEDS_MAX_SIZE}));
- // Check that length limits on the Domain attribute value are not enforced in
- // the case where no Domain attribute is specified and the domain value is
- // implicitly set from the URL.
- cc = CanonicalCookie::CreateSanitizedCookie(
- GURL("http://" + too_long_domain + "/"), "name", "value", std::string(),
- "/", one_hour_ago, one_hour_from_now, base::Time(), false /*secure*/,
- false /*httponly*/, CookieSameSite::NO_RESTRICTION,
- COOKIE_PRIORITY_DEFAULT, false /*same_party*/,
- absl::nullopt /*partition_key*/, &status);
- EXPECT_TRUE(cc);
- EXPECT_EQ(too_long_domain, cc->DomainWithoutDot());
- EXPECT_TRUE(status.IsInclude());
- }
- TEST(CanonicalCookieTest, FromStorage) {
- base::Time two_hours_ago = base::Time::Now() - base::Hours(2);
- base::Time one_hour_ago = base::Time::Now() - base::Hours(1);
- base::Time one_hour_from_now = base::Time::Now() + base::Hours(1);
- std::unique_ptr<CanonicalCookie> cc = CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 87);
- EXPECT_TRUE(cc);
- EXPECT_EQ("A", cc->Name());
- EXPECT_EQ("B", cc->Value());
- EXPECT_EQ("www.foo.com", cc->Domain());
- EXPECT_EQ("/bar", cc->Path());
- EXPECT_EQ(two_hours_ago, cc->CreationDate());
- EXPECT_EQ(one_hour_ago, cc->LastAccessDate());
- EXPECT_EQ(one_hour_from_now, cc->ExpiryDate());
- EXPECT_EQ(one_hour_ago, cc->LastUpdateDate());
- EXPECT_FALSE(cc->IsSecure());
- EXPECT_FALSE(cc->IsHttpOnly());
- EXPECT_EQ(CookieSameSite::NO_RESTRICTION, cc->SameSite());
- EXPECT_EQ(COOKIE_PRIORITY_MEDIUM, cc->Priority());
- EXPECT_EQ(CookieSourceScheme::kSecure, cc->SourceScheme());
- EXPECT_FALSE(cc->IsDomainCookie());
- EXPECT_EQ(cc->SourcePort(), 87);
- // Should return nullptr when the cookie is not canonical.
- // In this case the cookie is not canonical because its name attribute
- // contains a newline character.
- EXPECT_FALSE(CanonicalCookie::FromStorage(
- "A\n", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 80));
- // If the port information gets corrupted out of the valid range
- // FromStorage() should result in a PORT_INVALID.
- std::unique_ptr<CanonicalCookie> cc2 = CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 80000);
- EXPECT_EQ(cc2->SourcePort(), url::PORT_INVALID);
- // Test port edge cases: unspecified.
- std::unique_ptr<CanonicalCookie> cc3 = CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, url::PORT_UNSPECIFIED);
- EXPECT_EQ(cc3->SourcePort(), url::PORT_UNSPECIFIED);
- // Test port edge cases: invalid.
- std::unique_ptr<CanonicalCookie> cc4 = CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, url::PORT_INVALID);
- EXPECT_EQ(cc4->SourcePort(), url::PORT_INVALID);
- }
- TEST(CanonicalCookieTest, IsSetPermittedInContext) {
- GURL url("https://www.example.com/test");
- GURL insecure_url("http://www.example.com/test");
- base::Time current_time = base::Time::Now();
- auto cookie_scriptable = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
- auto cookie_httponly = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, true /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
- CookieOptions context_script;
- CookieOptions context_network;
- context_network.set_include_httponly();
- EXPECT_THAT(
- cookie_scriptable->IsSetPermittedInContext(
- GURL("file://foo/bar.txt"), context_network,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting({
- CookieInclusionStatus::EXCLUDE_NONCOOKIEABLE_SCHEME,
- CookieInclusionStatus::EXCLUDE_SECURE_ONLY,
- }),
- _, _, false));
- EXPECT_THAT(
- cookie_scriptable->IsSetPermittedInContext(
- insecure_url, context_network,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SECURE_ONLY}),
- _, _, false));
- EXPECT_THAT(
- cookie_scriptable->IsSetPermittedInContext(
- url, context_network,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_scriptable->IsSetPermittedInContext(
- url, context_script,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_httponly->IsSetPermittedInContext(
- url, context_network,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_httponly->IsSetPermittedInContext(
- url, context_script,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_HTTP_ONLY}),
- _, _, true));
- CookieOptions context_cross_site;
- CookieOptions context_same_site_lax;
- context_same_site_lax.set_same_site_cookie_context(
- CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_LAX));
- CookieOptions context_same_site_strict;
- context_same_site_strict.set_same_site_cookie_context(
- CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_STRICT));
- CookieOptions context_same_site_strict_to_lax;
- context_same_site_strict_to_lax.set_same_site_cookie_context(
- CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_LAX));
- CookieOptions context_same_site_strict_to_cross;
- context_same_site_strict_to_cross.set_same_site_cookie_context(
- CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_STRICT,
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- CookieOptions context_same_site_lax_to_cross;
- context_same_site_lax_to_cross.set_same_site_cookie_context(
- CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_LAX,
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- {
- auto cookie_same_site_unrestricted =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- {
- // Schemeful Same-Site disabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndDisableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- }
- {
- // Schemeful Same-Site enabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unrestricted->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- }
- }
- {
- auto cookie_same_site_lax = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_LAX}),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- {
- // Schemeful Same-Site disabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndDisableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE)),
- _, _, true));
- EXPECT_THAT(cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_LAX_CROSS_DOWNGRADE_LAX_SAMESITE)),
- _, _, true));
- }
- {
- // Schemeful Same-Site enabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(Not(IsInclude()),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_LAX_SAMESITE),
- HasExclusionReason(
- CookieInclusionStatus::EXCLUDE_SAMESITE_LAX)),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_lax->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(Not(IsInclude()),
- HasWarningReason(CookieInclusionStatus::
- WARN_LAX_CROSS_DOWNGRADE_LAX_SAMESITE),
- HasExclusionReason(
- CookieInclusionStatus::EXCLUDE_SAMESITE_LAX)),
- _, _, true));
- }
- }
- {
- auto cookie_same_site_strict =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_DEFAULT, false);
- // TODO(morlovich): Do compatibility testing on whether set of strict in lax
- // context really should be accepted.
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT}),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- {
- // Schemeful Same-Site disabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndDisableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE)),
- _, _, true));
- EXPECT_THAT(cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_LAX_CROSS_DOWNGRADE_STRICT_SAMESITE)),
- _, _, true));
- }
- {
- // Schemeful Same-Site enabled.
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_lax,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(IsInclude(), Not(HasDowngradeWarning())), _, _, true));
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(Not(IsInclude()),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_STRICT_CROSS_DOWNGRADE_STRICT_SAMESITE),
- HasExclusionReason(
- CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT)),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_lax_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- AllOf(Not(IsInclude()),
- HasWarningReason(
- CookieInclusionStatus::
- WARN_LAX_CROSS_DOWNGRADE_STRICT_SAMESITE),
- HasExclusionReason(
- CookieInclusionStatus::EXCLUDE_SAMESITE_STRICT)),
- _, _, true));
- }
- // Even with Schemeful Same-Site enabled, cookies semantics could change the
- // inclusion.
- {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitAndEnableFeature(features::kSchemefulSameSite);
- EXPECT_THAT(cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(Not(IsInclude()), _, _, true));
- EXPECT_THAT(cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::NONLEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(Not(IsInclude()), _, _, true));
- // LEGACY semantics should allow cookies which Schemeful Same-Site would
- // normally block.
- EXPECT_THAT(cookie_same_site_strict->IsSetPermittedInContext(
- url, context_same_site_strict_to_cross,
- CookieAccessParams(
- CookieAccessSemantics::LEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- }
- }
- // Behavior of UNSPECIFIED depends on CookieAccessSemantics.
- auto cookie_same_site_unspecified =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::UNSPECIFIED, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- HasExactlyExclusionReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(
- {CookieInclusionStatus::
- EXCLUDE_SAMESITE_UNSPECIFIED_TREATED_AS_LAX})),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_cross_site,
- CookieAccessParams(CookieAccessSemantics::NONLEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- HasExactlyExclusionReasonsForTesting(
- std::vector<CookieInclusionStatus::ExclusionReason>(
- {CookieInclusionStatus::
- EXCLUDE_SAMESITE_UNSPECIFIED_TREATED_AS_LAX})),
- _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_lax,
- CookieAccessParams(CookieAccessSemantics::NONLEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- EXPECT_THAT(
- cookie_same_site_unspecified->IsSetPermittedInContext(
- url, context_same_site_strict,
- CookieAccessParams(CookieAccessSemantics::NONLEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- // Test IsSetPermittedInContext successfully chains warnings by passing
- // in a CookieAccessResult and expecting the result to have a
- // WARN_ATTRIBUTE_VALUE_EXCEEDS_MAX_SIZE
- CookieInclusionStatus status;
- std::string long_path(ParsedCookie::kMaxCookieAttributeValueSize, 'a');
- std::unique_ptr<CanonicalCookie> cookie_with_long_path =
- CanonicalCookie::Create(url, "A=B; Path=/" + long_path, current_time,
- absl::nullopt, absl::nullopt, &status);
- CookieAccessResult cookie_access_result(status);
- CookieOptions cookie_with_long_path_options;
- EXPECT_THAT(
- cookie_with_long_path->IsSetPermittedInContext(
- url, cookie_with_long_path_options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes, cookie_access_result),
- MatchesCookieAccessResult(
- HasWarningReason(
- CookieInclusionStatus::WARN_ATTRIBUTE_VALUE_EXCEEDS_MAX_SIZE),
- _, _, _));
- }
- TEST(CanonicalCookieTest, IsSetPermittedEffectiveSameSite) {
- GURL url("http://www.example.com/test");
- base::Time current_time = base::Time::Now();
- CookieOptions options;
- // Test IsSetPermitted CookieEffectiveSameSite for
- // CanonicalCookie with CookieSameSite::NO_RESTRICTION.
- auto cookie_no_restriction = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_no_restriction->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, CookieEffectiveSameSite::NO_RESTRICTION, _,
- false));
- // Test IsSetPermitted CookieEffectiveSameSite for
- // CanonicalCookie with CookieSameSite::LAX_MODE.
- auto cookie_lax = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_lax->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, CookieEffectiveSameSite::LAX_MODE, _,
- false));
- // Test IsSetPermitted CookieEffectiveSameSite for
- // CanonicalCookie with CookieSameSite::STRICT_MODE.
- auto cookie_strict = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::STRICT_MODE, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_strict->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, CookieEffectiveSameSite::STRICT_MODE, _,
- false));
- // Test IsSetPermitted CookieEffectiveSameSite for
- // CanonicalCookie with CookieSameSite::UNSPECIFIED.
- base::Time creation_time = base::Time::Now() - (kLaxAllowUnsafeMaxAge * 4);
- auto cookie_old_unspecified = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", creation_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::UNSPECIFIED, COOKIE_PRIORITY_DEFAULT, false);
- auto cookie_unspecified = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /*secure*/, false /*httponly*/,
- CookieSameSite::UNSPECIFIED, COOKIE_PRIORITY_DEFAULT, false);
- EXPECT_THAT(
- cookie_old_unspecified->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, CookieEffectiveSameSite::LAX_MODE, _,
- false));
- EXPECT_THAT(
- cookie_unspecified->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::UNKNOWN,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- _, CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE, _, false));
- EXPECT_THAT(
- cookie_unspecified->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::NONLEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- _, CookieEffectiveSameSite::LAX_MODE_ALLOW_UNSAFE, _, false));
- EXPECT_THAT(
- cookie_unspecified->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- false /* delegate_treats_url_as_trustworthy */,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, CookieEffectiveSameSite::NO_RESTRICTION, _,
- false));
- }
- TEST(CanonicalCookieTest, IsSetPermitted_AllowedToAccessSecureCookies) {
- GURL url("https://www.example.com/test");
- GURL insecure_url("http://www.example.com/test");
- GURL localhost_url("http://localhost/test");
- base::Time current_time = base::Time::Now();
- CookieOptions options;
- for (bool secure : {false, true}) {
- for (CookieSameSite same_site : {
- CookieSameSite::UNSPECIFIED,
- CookieSameSite::NO_RESTRICTION,
- CookieSameSite::LAX_MODE,
- CookieSameSite::STRICT_MODE,
- }) {
- for (bool same_party : {false, true}) {
- // Skip setting SameParty and SameSite=Strict, since that is invalid.
- if (same_party && same_site == CookieSameSite::STRICT_MODE)
- continue;
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), secure, false /*httponly*/, same_site,
- COOKIE_PRIORITY_DEFAULT, same_party);
- for (bool delegate_treats_url_as_trustworthy : {false, true}) {
- for (CookieAccessSemantics access_semantics : {
- CookieAccessSemantics::UNKNOWN,
- CookieAccessSemantics::LEGACY,
- CookieAccessSemantics::NONLEGACY,
- }) {
- for (CookieSamePartyStatus same_party_status : {
- CookieSamePartyStatus::kNoSamePartyEnforcement,
- CookieSamePartyStatus::kEnforceSamePartyInclude,
- CookieSamePartyStatus::kEnforceSamePartyExclude,
- }) {
- // Skip invalid combinations of `same_party` and
- // `same_party_status`.
- bool has_same_party_enforcement =
- same_party_status !=
- CookieSamePartyStatus::kNoSamePartyEnforcement;
- if (has_same_party_enforcement != same_party) {
- continue;
- }
- EXPECT_THAT(
- cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(access_semantics,
- delegate_treats_url_as_trustworthy,
- same_party_status),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, _, _, true));
- EXPECT_THAT(
- cookie->IsSetPermittedInContext(
- insecure_url, options,
- CookieAccessParams(access_semantics,
- delegate_treats_url_as_trustworthy,
- same_party_status),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- _, _, _, delegate_treats_url_as_trustworthy));
- EXPECT_THAT(
- cookie->IsSetPermittedInContext(
- localhost_url, options,
- CookieAccessParams(access_semantics,
- delegate_treats_url_as_trustworthy,
- same_party_status),
- kCookieableSchemes),
- MatchesCookieAccessResult(_, _, _, true));
- }
- }
- }
- }
- }
- }
- }
- TEST(CanonicalCookieTest, IsSetPermitted_SameSiteNone_Metrics) {
- using SamePartyContextType = SamePartyContext::Type;
- constexpr bool delegate_treats_url_as_trustworthy = false;
- const base::Time now = base::Time::Now();
- const auto make_cookie = [now](CookieSameSite same_site, bool same_party) {
- return CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.com", "/test", now, base::Time(), base::Time(),
- base::Time(), true /* secure */, false /*httponly*/, same_site,
- COOKIE_PRIORITY_DEFAULT, same_party);
- };
- GURL url("https://www.example.com/test");
- const std::unique_ptr<CanonicalCookie> same_site_none_cookie =
- make_cookie(CookieSameSite::NO_RESTRICTION, false /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_party_cookie =
- make_cookie(CookieSameSite::NO_RESTRICTION, true /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_site_lax_cookie =
- make_cookie(CookieSameSite::LAX_MODE, false /* same_party */);
- const std::unique_ptr<CanonicalCookie> same_site_strict_cookie =
- make_cookie(CookieSameSite::STRICT_MODE, false /* same_party */);
- CookieOptions options;
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- // Same as default, but just to be explicit:
- options.set_same_party_context(
- SamePartyContext(SamePartyContext::Type::kCrossParty));
- EXPECT_THAT(
- same_site_none_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyExclude),
- kCookieableSchemes),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Now tweak the context to allow a SameParty cookie (using the top&resource
- // definition) and make sure we get the right warning. (Note: we make the
- // "real" same-partyness value match the value computed for the metric, even
- // though they would differ unless we changed the real definition.) Then
- // check that if we modify the cookie as indicated, the set would be allowed.
- options.set_same_party_context(
- SamePartyContext(SamePartyContextType::kSameParty));
- EXPECT_THAT(
- same_site_none_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyInclude),
- kCookieableSchemes),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Next: allow a SameParty cookie (using both definitions).
- options.set_same_party_context(SamePartyContext::MakeInclusive());
- EXPECT_THAT(
- same_site_none_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_party_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(Not(net::IsInclude()), _, _, true));
- // Next: allow a SameSite=Lax or SameSite=Strict cookie.
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::SAME_SITE_LAX));
- EXPECT_THAT(
- same_site_none_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(CookieInclusionStatus(), _, _, true));
- EXPECT_THAT(
- same_site_lax_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- EXPECT_THAT(
- same_site_strict_cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes),
- MatchesCookieAccessResult(net::IsInclude(), _, _, true));
- }
- TEST(CanonicalCookieTest, IsSetPermitted_SameParty) {
- GURL url("https://www.example.com/test");
- base::Time current_time = base::Time::Now();
- CookieOptions options;
- options.set_same_site_cookie_context(CookieOptions::SameSiteCookieContext(
- CookieOptions::SameSiteCookieContext::ContextType::CROSS_SITE));
- options.set_same_party_context(
- SamePartyContext(SamePartyContext::Type::kSameParty));
- {
- bool delegate_treats_url_as_trustworthy = false;
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false /*httponly*/,
- CookieSameSite::LAX_MODE, COOKIE_PRIORITY_DEFAULT,
- true /* same_party */);
- // The following access would normally be excluded due to SameSite=Lax, but
- // SameParty overrides SameSite.
- EXPECT_THAT(
- cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(CookieAccessSemantics::LEGACY,
- delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyExclude),
- kCookieableSchemes),
- MatchesCookieAccessResult(
- CookieInclusionStatus::MakeFromReasonsForTesting(
- {CookieInclusionStatus::EXCLUDE_SAMEPARTY_CROSS_PARTY_CONTEXT},
- {CookieInclusionStatus::WARN_TREATED_AS_SAMEPARTY}),
- _, _, true));
- }
- for (CookieSameSite same_site : {
- CookieSameSite::UNSPECIFIED,
- CookieSameSite::NO_RESTRICTION,
- CookieSameSite::LAX_MODE,
- }) {
- auto cookie = CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "2", "www.example.com", "/test", current_time, base::Time(),
- base::Time(), base::Time(), true /* secure */, false /*httponly*/,
- same_site, COOKIE_PRIORITY_DEFAULT, true /* same_party */);
- for (bool delegate_treats_url_as_trustworthy : {false, true}) {
- for (CookieAccessSemantics access_semantics : {
- CookieAccessSemantics::UNKNOWN,
- CookieAccessSemantics::LEGACY,
- CookieAccessSemantics::NONLEGACY,
- }) {
- EXPECT_THAT(
- cookie->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(
- access_semantics, delegate_treats_url_as_trustworthy,
- CookieSamePartyStatus::kEnforceSamePartyInclude),
- kCookieableSchemes),
- MatchesCookieAccessResult(IsInclude(), _, _, true));
- }
- }
- }
- }
- // Test that the CookieInclusionStatus warning for inclusion changed by
- // cross-site redirect context downgrade is applied correctly.
- TEST(CanonicalCookieTest, IsSetPermittedInContext_RedirectDowngradeWarning) {
- using Context = CookieOptions::SameSiteCookieContext;
- using ContextType = Context::ContextType;
- GURL url("https://www.example.test/test");
- GURL insecure_url("http://www.example.test/test");
- // Test cases to be used with a lax-to-cross context downgrade.
- const struct {
- ContextType context_type;
- CookieSameSite samesite;
- bool expect_cross_site_redirect_warning;
- } kTestCases[] = {
- {ContextType::SAME_SITE_LAX, CookieSameSite::STRICT_MODE, true},
- {ContextType::CROSS_SITE, CookieSameSite::STRICT_MODE, true},
- {ContextType::SAME_SITE_LAX, CookieSameSite::LAX_MODE, true},
- {ContextType::CROSS_SITE, CookieSameSite::LAX_MODE, true},
- {ContextType::SAME_SITE_LAX, CookieSameSite::NO_RESTRICTION, false},
- {ContextType::CROSS_SITE, CookieSameSite::NO_RESTRICTION, false},
- };
- for (bool consider_redirects : {true, false}) {
- base::test::ScopedFeatureList feature_list;
- feature_list.InitWithFeatureState(
- features::kCookieSameSiteConsidersRedirectChain, consider_redirects);
- for (CookieAccessSemantics semantics :
- {CookieAccessSemantics::LEGACY, CookieAccessSemantics::NONLEGACY}) {
- // There are no downgrade warnings for undowngraded contexts.
- for (ContextType context_type : {ContextType::SAME_SITE_LAX,
- ContextType::SAME_SITE_LAX_METHOD_UNSAFE,
- ContextType::CROSS_SITE}) {
- for (CookieSameSite samesite :
- {CookieSameSite::UNSPECIFIED, CookieSameSite::NO_RESTRICTION,
- CookieSameSite::LAX_MODE, CookieSameSite::STRICT_MODE}) {
- std::unique_ptr<CanonicalCookie> cookie =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.test", "/test", base::Time::Now(),
- base::Time(), base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, samesite, COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false);
- CookieOptions options;
- options.set_same_site_cookie_context(Context(context_type));
- EXPECT_FALSE(
- cookie
- ->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes)
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION));
- }
- }
- for (const auto& test : kTestCases) {
- std::unique_ptr<CanonicalCookie> cookie =
- CanonicalCookie::CreateUnsafeCookieForTesting(
- "A", "1", "www.example.test", "/test", base::Time::Now(),
- base::Time(), base::Time(), base::Time(), /*secure=*/true,
- /*httponly=*/false, test.samesite, COOKIE_PRIORITY_DEFAULT,
- /*same_party=*/false);
- Context::ContextMetadata lax_cross_downgrade_metadata;
- lax_cross_downgrade_metadata.cross_site_redirect_downgrade =
- Context::ContextMetadata::ContextDowngradeType::kLaxToCross;
- CookieOptions options;
- options.set_same_site_cookie_context(Context(
- test.context_type, test.context_type, lax_cross_downgrade_metadata,
- lax_cross_downgrade_metadata));
- EXPECT_EQ(
- cookie
- ->IsSetPermittedInContext(
- url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes)
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION),
- test.expect_cross_site_redirect_warning);
- // SameSite warnings not applied if other exclusion reasons apply (e.g.
- // non-https with Secure attribute).
- EXPECT_FALSE(
- cookie
- ->IsSetPermittedInContext(
- insecure_url, options,
- CookieAccessParams(
- semantics,
- /*delegate_treats_url_as_trustworthy=*/false,
- CookieSamePartyStatus::kNoSamePartyEnforcement),
- kCookieableSchemes)
- .status.HasWarningReason(
- CookieInclusionStatus::
- WARN_CROSS_SITE_REDIRECT_DOWNGRADE_CHANGES_INCLUSION));
- }
- }
- }
- }
- TEST(CanonicalCookieTest, TestIsCanonicalWithInvalidSizeHistograms) {
- base::HistogramTester histograms;
- const char kFromStorageWithValidLengthHistogram[] =
- "Cookie.FromStorageWithValidLength";
- const base::HistogramBase::Sample kInValid = 0;
- const base::HistogramBase::Sample kValid = 1;
- base::Time two_hours_ago = base::Time::Now() - base::Hours(2);
- base::Time one_hour_ago = base::Time::Now() - base::Hours(1);
- base::Time one_hour_from_now = base::Time::Now() + base::Hours(1);
- // Test a cookie that is canonical and valid size
- EXPECT_TRUE(CanonicalCookie::FromStorage(
- "A", "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 87));
- histograms.ExpectBucketCount(kFromStorageWithValidLengthHistogram, kInValid,
- 0);
- histograms.ExpectBucketCount(kFromStorageWithValidLengthHistogram, kValid, 1);
- // Test loading a couple of cookies which are canonical but with an invalid
- // size
- const std::string kCookieBig(4096, 'a');
- EXPECT_TRUE(CanonicalCookie::FromStorage(
- kCookieBig, "B", "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 87));
- EXPECT_TRUE(CanonicalCookie::FromStorage(
- "A", kCookieBig, "www.foo.com", "/bar", two_hours_ago, one_hour_from_now,
- one_hour_ago, one_hour_ago, false /*secure*/, false /*httponly*/,
- CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_DEFAULT,
- false /*same_party*/, absl::nullopt /*partition_key*/,
- CookieSourceScheme::kSecure, 87));
- histograms.ExpectBucketCount(kFromStorageWithValidLengthHistogram, kInValid,
- 2);
- histograms.ExpectBucketCount(kFromStorageWithValidLengthHistogram, kValid, 1);
- }
- TEST(CanonicalCookieTest, TestHasHiddenPrefixName) {
- const struct {
- const char* value;
- bool result;
- } kTestCases[] = {
- {"", false},
- {" ", false},
- {"foobar=", false},
- {"foo=bar", false},
- {" \t ", false},
- {"\t", false},
- {"__Secure-abc", false},
- {"__Secure=-", false},
- {"__Secure=-abc", false},
- {"__Secur=e-abc", false},
- {"__Secureabc", false},
- {"__Host=-", false},
- {"__Host=-abc", false},
- {"__Host-abc", false},
- {"__Hos=t-abc", false},
- {"_Host", false},
- {" __Secure-abc", false},
- {"\t__Host-", false},
- {"a__Host-abc=123", false},
- {"a__Secure-abc=123", false},
- {"__Host-=", true},
- {"__Host-=123", true},
- {"__Host-abc=", true},
- {"__Host-abc=123", true},
- {" __Host-abc=123", true},
- {" __Host-abc=", true},
- {"\t\t\t\t\t__Host-abc=123", true},
- {"\t __Host-abc=", true},
- {"__Secure-=", true},
- {"__Secure-=123", true},
- {"__Secure-abc=", true},
- {"__Secure-abc=123", true},
- {" __Secure-abc=123", true},
- {" __Secure-abc=", true},
- {"\t\t\t\t\t__Secure-abc=123", true},
- {"\t __Secure-abc=", true},
- {"__Secure-abc=123=d=4=fg=", true},
- };
- for (auto test_case : kTestCases) {
- EXPECT_EQ(CanonicalCookie::HasHiddenPrefixName(test_case.value),
- test_case.result)
- << test_case.value << " failed check";
- }
- }
- } // namespace net
|