123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808 |
- // Copyright 2022 The Chromium Authors. All rights reserved.
- // Use of this source code is governed by a BSD-style license that can be
- // found in the LICENSE file.
- #include "components/url_param_filter/core/url_param_filterer.h"
- #include <string>
- #include "base/test/metrics/histogram_tester.h"
- #include "base/test/scoped_feature_list.h"
- #include "components/url_param_filter/core/features.h"
- #include "components/url_param_filter/core/url_param_classifications_loader.h"
- #include "components/url_param_filter/core/url_param_filter_classification.pb.h"
- #include "components/url_param_filter/core/url_param_filter_test_helper.h"
- #include "testing/gtest/include/gtest/gtest.h"
- #include "third_party/abseil-cpp/absl/types/optional.h"
- namespace url_param_filter {
- class UrlParamFiltererTest : public ::testing::Test {};
- TEST_F(UrlParamFiltererTest, FilterUrlEmptyClassifications) {
- GURL source = GURL{"http://source.xyz"};
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- // If no classifications are passed in, don't modify the destination URL.
- FilterResult result = FilterUrl(source, expected, ClassificationMap(),
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlNoChanges) {
- GURL source = GURL{"http://source.xyz"};
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}}});
- // If classifications are passed in, but the destination URL doesn't contain
- // any blocked params, don't modify it.
- FilterResult result = FilterUrl(source, expected, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}}});
- // Navigations from source.xyz with a param called plzblock should have that
- // param removed, regardless of destination.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceBlockedNoValue) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{"https://destination.xyz?plzblock&nochange"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}}});
- // Navigations from source.xyz with a param called plzblock should have that
- // param removed, regardless of missing a value.
- GURL expected = GURL{"https://destination.xyz?nochange"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlMultipleSourceBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock", "plzblock1"}}});
- // Navigations from source.xyz with a param called plzblock or plzblock1
- // should have those params removed, regardless of destination.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlDestinationBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{DestinationKey("destination.xyz"), {"plzblock"}}});
- // Navigations to destination.xyz with a param called plzblock should have
- // that param removed, regardless of source.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlMultipleDestinationBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{DestinationKey("destination.xyz"), {"plzblock", "plzblock1"}}});
- // Navigations to destination.xyz with a param called plzblock and/or
- // plzblock1 should have those param removed, regardless of source.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceWildcardBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("source"), {"plzblock"}}});
- // Navigations from source.* with a param called plzblock should have
- // that param removed, regardless of destination.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceWildcardeTLDHasTrailingDotBlock) {
- // eTLD has a trailing dot, which is weird but legal.
- GURL source = GURL{"https://source.xyz."};
- GURL destination = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("source"), {"plzblock"}}});
- // Navigations from source.* with a param called plzblock should have
- // that param removed, regardless of destination.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceWildcardeTLDUnparsableNotBlocked) {
- // eTLD has two trailing dots, which means we cannot parse it.
- GURL source = GURL{"https://source.xyz.."};
- GURL destination = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("source"), {"plzblock"}}});
- // Since the eTLD is unparsable, we should leave the URL intact.
- GURL expected = GURL{"https://destination.xyz?plzblock=123&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlMultipleSourceWildcardBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("source"), {"plzblock", "plzblock1"}}});
- // Navigations to destination.xyz with a param called plzblock and/or
- // plzblock1 should have those param removed, regardless of source.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest,
- FilterUrlSourceAndSourceWildcardAndDestinationBlocked) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "destination.xyz?plzblock=123&plzblock1=321&plzblockwildcard=456&"
- "nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblockwildcard"}}});
- // Both source and destination have associated URL param filtering rules. Only
- // nochange should remain.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceAndDestinationAsIPBlocked) {
- GURL source = GURL{"https://127.0.0.1"};
- GURL destination =
- GURL{"https://123.0.0.1?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting({
- {SourceKey("127.0.0.1"), {"plzblock"}},
- {DestinationKey("123.0.0.1"), {"plzblock1"}},
- });
- // Both source and destination have associated URL param filtering rules. Only
- // nochange should remain.
- GURL expected = GURL{"https://123.0.0.1?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceAndDestinationAsIPv6Blocked) {
- GURL source = GURL{"https://[::1]"};
- GURL destination = GURL{
- "https://"
- "[2001:db8:ac10:fe01::]?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("[::1]"), {"plzblock"}},
- {DestinationKey("[2001:db8:ac10:fe01::]"), {"plzblock1"}}});
- // Both source and destination have associated URL param filtering rules. Only
- // nochange should remain.
- GURL expected = GURL{"https://[2001:db8:ac10:fe01::]?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest,
- FilterUrlSourceAndDestinationMixedIPv6AndIPv4Blocked) {
- GURL source = GURL{"https://127.0.0.1"};
- GURL destination = GURL{
- "https://"
- "[2001:db8:ac10:fe01::]?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("127.0.0.1"), {"plzblock"}},
- {DestinationKey("[2001:db8:ac10:fe01::]"), {"plzblock1"}}});
- // Both source and destination have associated URL param filtering rules. Only
- // nochange should remain.
- GURL expected = GURL{"https://[2001:db8:ac10:fe01::]?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceWildcardIgnoredForIPv4Source) {
- GURL source = GURL{"https://127.0.0.1"};
- GURL destination =
- GURL{"https://123.0.0.1?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("127.0.0.1"), {"plzblock", "plzblock1"}}});
- // Even if we somehow have a classification map with an IP address wildcard
- // rule, we should not filter based on that because it is not possible to get
- // the eTLD + 1 of an IP address.
- GURL expected =
- GURL{"https://123.0.0.1?plzblock=123&plzblock1=321&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSourceWildcardIgnoredForIPv6Source) {
- GURL source = GURL{"https://[::1]"};
- GURL destination =
- GURL{"https://123.0.0.1?plzblock=123&plzblock1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceWildcardKey("[::1]"), {"plzblock", "plzblock1"}}});
- // Even if we somehow have a classification map with an IP address wildcard
- // rule, we should not filter based on that because it is not possible to get
- // the eTLD + 1 of an IP address.
- GURL expected =
- GURL{"https://123.0.0.1?plzblock=123&plzblock1=321&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(
- UrlParamFiltererTest,
- FilterUrlSourceAndSourceWildcardAndDestinationBlockedCheckOrderingPreserved) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "destination.xyz?plzblock=123&plzblock1=321&nochange=asdf&"
- "plzblockwildcard=456&laternochange="
- "fdsa"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblockwildcard"}}});
- // Both source and destination have associated URL param filtering rules. Only
- // nochange should remain.
- GURL expected =
- GURL{"https://destination.xyz?nochange=asdf&laternochange=fdsa"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlSubdomainsApplied) {
- GURL source = GURL{"https://subdomain.source.xyz"};
- GURL destination = GURL{
- "https://"
- "subdomain.destination.xyz?plzblock=123&plzblock1=321&plzblockwildcard="
- "678&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblockwildcard"}}});
- GURL expected = GURL{"https://subdomain.destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlCaseIgnored) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "destination.xyz?PlZbLoCk=123&PLZBLOCK1=321&plzBlockWildcard=876&"
- "nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblockwildcard"}}});
- // The disallowed params PlZbLoCk and PLZBLOCK1 should be removed.
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlWithNestedUrl) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fplzblock1%"
- "3D123%26nochange%3Dasdf&PLZBLOCK1=321&plzblockWildcard=789&nochange="
- "asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {DestinationKey("source.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblockwildcard"}}});
- // The nested URL pattern is commonly observed; we do not want the parameter
- // to leak.
- GURL expected = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fnochange%"
- "3Dasdf&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlWithNestedUrlNotNeedingFiltering) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fnochange%"
- "3Dasdf&PLZBLOCK1=321&nochange=asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {DestinationKey("source.xyz"), {"plzblock1"}},
- {SourceWildcardKey("source"), {"plzblock1"}}});
- // The nested URL does not have filtered parameters and should be left alone.
- GURL expected = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fnochange%"
- "3Dasdf&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- }
- TEST_F(UrlParamFiltererTest, FilterUrlWithNestedUrlAndDuplicates) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fplzblock1%"
- "3D123%26nochange%3Dasdf%26plzblock1%3D123&PLZBLOCK1=321&nochange=asdf&"
- "PLZBLOCK1=321"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {DestinationKey("source.xyz"), {"plzblock1"}}});
- // The nested URL pattern is commonly observed; we do not want the parameter
- // to leak.
- GURL expected = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fnochange%"
- "3Dasdf&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 4);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FeatureDeactivated) {
- GURL source = GURL{"http://source.xyz"};
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- // When the feature is not explicitly activated, the 2-parameter version of
- // the function should be inert.
- GURL result = FilterUrl(source, expected).filtered_url;
- ASSERT_EQ(result, expected);
- }
- TEST_F(UrlParamFiltererTest, FeatureDeactivatedUseCaseVariant) {
- GURL source = GURL{"http://source.xyz"};
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- // When the feature is not explicitly activated, the 3-parameter version of
- // the function should be inert.
- FilterResult result =
- FilterUrl(source, expected, FilterClassification::CROSS_OTR);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FeatureActivatedNoQueryString) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination = GURL{"https://destination.xyz"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz", {"plzblock"}}}, {{"destination.xyz", {"plzblock1"}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL should be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{"https://destination.xyz"};
- FilterResult result = FilterUrl(source, destination);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FeatureActivatedAllRemoved) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=adf&plzblock1=asdffdsa"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz", {"plzblock"}}}, {{"destination.xyz", {"plzblock1"}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL should be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{"https://destination.xyz"};
- FilterResult result = FilterUrl(source, destination);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, FeatureActivatedSourceAndDestinationRemoval) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=1&plzblock1=2&nochange=asdf"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz", {"plzblock"}}}, {{"destination.xyz", {"plzblock1"}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL should be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result = FilterUrl(source, destination);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, CrossOtrUseCase) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=1&plzblock1=2&nochange=asdf"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz", {{FilterClassification::CROSS_OTR, {"plzblock"}}}}},
- {{"destination.xyz",
- {{FilterClassification::CROSS_OTR, {"plzblock1"}}}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL should be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{"https://destination.xyz?nochange=asdf"};
- FilterResult result =
- FilterUrl(source, destination, FilterClassification::CROSS_OTR);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, MismatchedUseCases) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=1&plzblock1=2&nochange=asdf"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz", {{FilterClassification::CROSS_OTR, {"plzblock"}}}}},
- {{"destination.xyz",
- {{FilterClassification::CROSS_OTR, {"plzblock1"}}}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL could be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- FilterResult result =
- FilterUrl(source, destination, FilterClassification::CROSS_SITE_NO_3PC);
- // There are no rules for CROSS_SITE_NO_3PC, so the URL should not change.
- ASSERT_EQ(result.filtered_url, destination);
- ASSERT_EQ(result.filtered_param_count, 0);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, MixedUseCases) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination =
- GURL{"https://destination.xyz?plzblock=1&plzblock1=2&nochange=asdf"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz",
- {{FilterClassification::CROSS_SITE_NO_3PC, {"plzblock"}}}}},
- {{"destination.xyz",
- {{FilterClassification::CROSS_OTR, {"plzblock1"}}}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL could be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{"https://destination.xyz?plzblock1=2&nochange=asdf"};
- FilterResult result =
- FilterUrl(source, destination, FilterClassification::CROSS_SITE_NO_3PC);
- // The only rule for CROSS_SITE_NO_3PC is to remove `plzblock` from
- // source.xyz.
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 1);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, MultipleUseCases) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination = GURL{
- "https://"
- "destination.xyz?blockotrsource=1&blockno3pcdest=1&plzblock=1&plzblock1="
- "2&nochange=asdf"};
- std::string encoded_classification =
- CreateBase64EncodedFilterParamClassificationForTesting(
- {{"source.xyz",
- {{FilterClassification::CROSS_OTR, {"blockotrsource"}},
- {FilterClassification::CROSS_SITE_NO_3PC, {"plzblock"}}}}},
- {{"destination.xyz",
- {{FilterClassification::CROSS_SITE_NO_3PC, {"blockno3pcdest"}},
- {FilterClassification::CROSS_OTR, {"plzblock1"}}}}});
- base::test::ScopedFeatureList scoped_feature_list;
- // With the flag set, the URL could be filtered.
- scoped_feature_list.InitAndEnableFeatureWithParameters(
- features::kIncognitoParamFilterEnabled,
- {{"classifications", encoded_classification}});
- GURL expected = GURL{
- "https://destination.xyz?blockotrsource=1&plzblock1=2&nochange=asdf"};
- FilterResult result =
- FilterUrl(source, destination, FilterClassification::CROSS_SITE_NO_3PC);
- // `blockotrsource` should be left alone, but `blockno3pcdest` should not.
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 2);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::NON_EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, ExperimentalClassifications) {
- GURL source = GURL{"http://source.xyz"};
- GURL destination = GURL{
- "https://"
- "destination.xyz?srcexperimental=1&destexperimental=2&noblock=1&plzblock="
- "1&plzblockdest=1"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblockdest"}}});
- // In addition to the default `plzblock`, also set `srcexperimental` as an
- // experiment-driven parameter.
- auto key = SourceKey("source.xyz");
- classification_map[key][FilterClassification::USE_CASE_UNKNOWN]
- ["srcexperimental"] =
- ClassificationExperimentStatus::EXPERIMENTAL;
- // In addition to the default `plzblockdest`, also set `destexperimental` as
- // an experiment-driven parameter.
- classification_map[DestinationKey("destination.xyz")]
- [FilterClassification::USE_CASE_UNKNOWN]
- ["destexperimental"] =
- ClassificationExperimentStatus::EXPERIMENTAL;
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- // `blockotrsource` should be left alone, but `blockno3pcdest` should not.
- GURL expected = GURL{"https://destination.xyz?noblock=1"};
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 4);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::EXPERIMENTAL);
- }
- TEST_F(UrlParamFiltererTest, ExperimentalClassificationsWithNestedUrl) {
- GURL source = GURL{"https://source.xyz"};
- GURL destination = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fplzblock1%"
- "3D123%26destexperimental%3D1%26nochange%3Dasdf&PLZBLOCK1=321&nochange="
- "asdf"};
- ClassificationMap classification_map = CreateClassificationMapForTesting(
- {{SourceKey("source.xyz"), {"plzblock"}},
- {DestinationKey("destination.xyz"), {"plzblock1"}},
- {DestinationKey("source.xyz"), {"plzblock1"}}});
- // In addition to the default params, also set `destexperimental` as
- // an experiment-driven parameter and verify the nested URL correctly results
- // in `ClassificationExperimentStatus::EXPERIMENTAL`.
- auto key = DestinationKey("destination.xyz");
- classification_map[key][FilterClassification::USE_CASE_UNKNOWN]
- ["destexperimental"] =
- ClassificationExperimentStatus::EXPERIMENTAL;
- GURL expected = GURL{
- "https://"
- "subdomain.source.xyz?destination=https%3A%2F%2Fdestination.xyz%2F%"
- "3Fnochange%"
- "3Dasdf&nochange=asdf"};
- FilterResult result = FilterUrl(source, destination, classification_map,
- FilterClassification::USE_CASE_UNKNOWN);
- ASSERT_EQ(result.filtered_url, expected);
- ASSERT_EQ(result.filtered_param_count, 3);
- ASSERT_EQ(result.experimental_status,
- ClassificationExperimentStatus::EXPERIMENTAL);
- }
- namespace internal {
- class UrlParamFiltererInternalTest : public ::testing::Test {};
- TEST_F(UrlParamFiltererInternalTest, GetLabelFromHostname) {
- struct {
- std::string url;
- absl::optional<std::string> expected;
- } kTestCases[]{
- // Normal cases.
- {.url = "https://site.xyz?param=123¶m2=456", .expected = "site"},
- {.url = "http://a.com?param=123¶m2=456", .expected = "a"},
- {.url = "https://b.co.uk?param=123¶m2=456", .expected = "b"},
- {.url = "https://subdomain.c.xyz?param=123¶m2=456", .expected = "c"},
- // Trailing dots.
- {.url = "https://a.com./", .expected = "a"},
- {.url = "https://b.gov.uk./", .expected = "b"},
- {.url = "https://c.co.", .expected = "c"},
- // Unparsable.
- {.url = "https://a.com../", .expected = absl::nullopt},
- {.url = "https://b.gov.uk..", .expected = absl::nullopt},
- {.url = "http://192.168.0.1", .expected = absl::nullopt},
- {.url = "http://[2001:0db8:85a3:0000:0000:8a2e:0370:7334]/",
- .expected = absl::nullopt},
- {.url = "http://localhost", .expected = absl::nullopt},
- {.url = "", .expected = absl::nullopt},
- {.url = "http://localhost.", .expected = absl::nullopt},
- {.url = "http://", .expected = absl::nullopt},
- {.url = "file:///C:/file.html", .expected = absl::nullopt},
- {.url = "http://...", .expected = absl::nullopt},
- {.url = "http:////Comment", .expected = absl::nullopt},
- {.url = "http://.com", .expected = absl::nullopt},
- };
- for (const auto& test_case : kTestCases) {
- ASSERT_EQ(GetLabelFromHostname(GURL{test_case.url}), test_case.expected);
- }
- }
- } // namespace internal
- } // namespace url_param_filter
|