PRESUBMIT.py 4.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137
  1. # Copyright (c) 2013 The Chromium Authors. All rights reserved.
  2. # Use of this source code is governed by a BSD-style license that can be
  3. # found in the LICENSE file.
  4. """Presubmit script for android buildbot.
  5. See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
  6. details on the presubmit API built into depot_tools.
  7. """
  8. USE_PYTHON3 = True
  9. def CommonChecks(input_api, output_api):
  10. # These tools don't run on Windows so these tests don't work and give many
  11. # verbose and cryptic failure messages. Linting the code is also skipped on
  12. # Windows because it will fail due to os differences.
  13. if input_api.sys.platform == 'win32':
  14. return []
  15. build_android_dir = input_api.PresubmitLocalPath()
  16. def J(*dirs):
  17. """Returns a path relative to presubmit directory."""
  18. return input_api.os_path.join(build_android_dir, *dirs)
  19. build_pys = [
  20. r'gn/.*\.py$',
  21. r'gyp/.*\.py$',
  22. ]
  23. tests = []
  24. # yapf likes formatting the extra_paths_list to be less readable.
  25. # yapf: disable
  26. tests.extend(
  27. input_api.canned_checks.GetPylint(
  28. input_api,
  29. output_api,
  30. pylintrc='pylintrc',
  31. files_to_skip=[
  32. r'.*_pb2\.py'
  33. ] + build_pys,
  34. extra_paths_list=[
  35. J(),
  36. J('gyp'),
  37. J('buildbot'),
  38. J('..', 'util', 'lib', 'common'),
  39. J('..', '..', 'third_party', 'catapult', 'common',
  40. 'py_trace_event'),
  41. J('..', '..', 'third_party', 'catapult', 'common', 'py_utils'),
  42. J('..', '..', 'third_party', 'catapult', 'devil'),
  43. J('..', '..', 'third_party', 'catapult', 'tracing'),
  44. J('..', '..', 'third_party', 'depot_tools'),
  45. J('..', '..', 'third_party', 'colorama', 'src'),
  46. J('..', '..', 'build'),
  47. ],
  48. version='2.7'))
  49. tests.extend(
  50. input_api.canned_checks.GetPylint(
  51. input_api,
  52. output_api,
  53. files_to_check=build_pys,
  54. files_to_skip=[
  55. r'.*_pb2\.py',
  56. r'.*_pb2\.py',
  57. r'.*create_unwind_table\.py',
  58. r'.*create_unwind_table_tests\.py',
  59. ],
  60. extra_paths_list=[J('gyp'), J('gn')],
  61. version='2.7'))
  62. tests.extend(
  63. input_api.canned_checks.GetPylint(
  64. input_api,
  65. output_api,
  66. files_to_check=[
  67. r'.*create_unwind_table\.py',
  68. r'.*create_unwind_table_tests\.py',
  69. ],
  70. extra_paths_list=[J('gyp'), J('gn')],
  71. version='2.7'))
  72. # yapf: enable
  73. # Disabled due to http://crbug.com/410936
  74. #output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
  75. #input_api, output_api, J('buildbot', 'tests', skip_shebang_check=True)))
  76. pylib_test_env = dict(input_api.environ)
  77. pylib_test_env.update({
  78. 'PYTHONPATH': build_android_dir,
  79. 'PYTHONDONTWRITEBYTECODE': '1',
  80. })
  81. tests.extend(
  82. input_api.canned_checks.GetUnitTests(
  83. input_api,
  84. output_api,
  85. unit_tests=[
  86. J('.', 'emma_coverage_stats_test.py'),
  87. J('.', 'list_class_verification_failures_test.py'),
  88. J('pylib', 'constants', 'host_paths_unittest.py'),
  89. J('pylib', 'gtest', 'gtest_test_instance_test.py'),
  90. J('pylib', 'instrumentation',
  91. 'instrumentation_test_instance_test.py'),
  92. J('pylib', 'local', 'device', 'local_device_gtest_run_test.py'),
  93. J('pylib', 'local', 'device',
  94. 'local_device_instrumentation_test_run_test.py'),
  95. J('pylib', 'local', 'device', 'local_device_test_run_test.py'),
  96. J('pylib', 'local', 'machine',
  97. 'local_machine_junit_test_run_test.py'),
  98. J('pylib', 'output', 'local_output_manager_test.py'),
  99. J('pylib', 'output', 'noop_output_manager_test.py'),
  100. J('pylib', 'output', 'remote_output_manager_test.py'),
  101. J('pylib', 'results', 'json_results_test.py'),
  102. J('pylib', 'utils', 'chrome_proxy_utils_test.py'),
  103. J('pylib', 'utils', 'decorators_test.py'),
  104. J('pylib', 'utils', 'device_dependencies_test.py'),
  105. J('pylib', 'utils', 'dexdump_test.py'),
  106. J('pylib', 'utils', 'gold_utils_test.py'),
  107. J('pylib', 'utils', 'test_filter_test.py'),
  108. J('gyp', 'util', 'build_utils_test.py'),
  109. J('gyp', 'util', 'manifest_utils_test.py'),
  110. J('gyp', 'util', 'md5_check_test.py'),
  111. J('gyp', 'util', 'resource_utils_test.py'),
  112. ],
  113. env=pylib_test_env,
  114. run_on_python2=False,
  115. run_on_python3=True,
  116. skip_shebang_check=True))
  117. return input_api.RunTests(tests)
  118. def CheckChangeOnUpload(input_api, output_api):
  119. return CommonChecks(input_api, output_api)
  120. def CheckChangeOnCommit(input_api, output_api):
  121. return CommonChecks(input_api, output_api)