1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471 |
- // Copyright 2019 The Chromium Authors. All rights reserved.
- // Use of this source code is governed by a BSD-style license that can be
- // found in the LICENSE file.
- #include "ash/app_list/views/result_selection_controller.h"
- #include <gtest/gtest.h>
- #include <cctype>
- #include <map>
- #include <memory>
- #include <string>
- #include <utility>
- #include <vector>
- #include "ash/app_list/app_list_test_view_delegate.h"
- #include "ash/app_list/model/search/test_search_result.h"
- #include "ash/app_list/views/search_result_actions_view.h"
- #include "ash/app_list/views/search_result_actions_view_delegate.h"
- #include "ash/app_list/views/search_result_container_view.h"
- #include "base/bind.h"
- #include "base/i18n/rtl.h"
- #include "base/strings/stringprintf.h"
- #include "ui/events/event.h"
- namespace ash {
- namespace {
- int g_last_created_result_index = -1;
- class TestResultViewWithActions;
- class TestResultView : public SearchResultBaseView {
- public:
- TestResultView() = default;
- TestResultView(const TestResultView&) = delete;
- TestResultView& operator=(const TestResultView&) = delete;
- ~TestResultView() override = default;
- virtual TestResultViewWithActions* AsResultViewWithActions() {
- return nullptr;
- }
- };
- class TestResultViewWithActions : public TestResultView,
- public SearchResultActionsViewDelegate {
- public:
- TestResultViewWithActions()
- : actions_view_owned_(std::make_unique<SearchResultActionsView>(this)) {
- set_actions_view(actions_view_owned_.get());
- }
- TestResultViewWithActions(const TestResultViewWithActions&) = delete;
- TestResultViewWithActions& operator=(const TestResultViewWithActions&) =
- delete;
- // TestResultView:
- TestResultViewWithActions* AsResultViewWithActions() override { return this; }
- // SearchResultActionsViewDelegate:
- void OnSearchResultActionActivated(size_t index) override {}
- bool IsSearchResultHoveredOrSelected() override { return selected(); }
- SearchResultActionsView* GetActionsView() {
- return actions_view_owned_.get();
- }
- private:
- std::unique_ptr<SearchResultActionsView> actions_view_owned_;
- };
- struct TestContainerParams {
- TestContainerParams() = default;
- TestContainerParams(bool horizontal, int result_count)
- : horizontal(horizontal), result_count(result_count) {}
- TestContainerParams(bool horizontal, int result_count, int actions_per_result)
- : horizontal(horizontal),
- result_count(result_count),
- actions_per_result(actions_per_result) {}
- // Whether the contairne is horizontal.
- bool horizontal = false;
- // Number of results in the container.
- int result_count = 0;
- // If set, the container will contain TestResultViewWithActions that
- // have |actions_per_result| actions each.
- absl::optional<int> actions_per_result;
- };
- class TestContainer : public SearchResultContainerView {
- public:
- TestContainer(const TestContainerParams& params,
- test::AppListTestViewDelegate* view_delegate)
- : SearchResultContainerView(view_delegate) {
- set_horizontally_traversable(params.horizontal);
- for (int i = 0; i < params.result_count; ++i) {
- std::string result_id =
- base::StringPrintf("result %d", ++g_last_created_result_index);
- auto result = std::make_unique<TestSearchResult>();
- result->set_result_id(result_id);
- if (params.actions_per_result.has_value()) {
- auto result_view = std::make_unique<TestResultViewWithActions>();
- result_view->SetResult(result.get());
- result_view->GetActionsView()->SetActions(
- std::vector<SearchResult::Action>(
- params.actions_per_result.value(),
- SearchResult::Action(SearchResultActionType::kRemove,
- std::u16string(), false)));
- search_result_views_.emplace_back(std::move(result_view));
- } else {
- auto result_view = std::make_unique<TestResultView>();
- result_view->SetResult(result.get());
- search_result_views_.emplace_back(std::move(result_view));
- }
- search_result_views_.back()->set_index_in_container(i);
- results_.emplace(result_id, std::move(result));
- }
- Update();
- }
- TestContainer(const TestContainer&) = delete;
- TestContainer& operator=(const TestContainer&) = delete;
- ~TestContainer() override = default;
- // SearchResultContainerView:
- SearchResultBaseView* GetResultViewAt(size_t index) override {
- DCHECK_LT(index, search_result_views_.size());
- return search_result_views_[index].get();
- }
- private:
- int DoUpdate() override { return search_result_views_.size(); }
- std::map<std::string, std::unique_ptr<TestSearchResult>> results_;
- std::vector<std::unique_ptr<TestResultView>> search_result_views_;
- };
- class ResultSelectionTest : public testing::Test,
- public testing::WithParamInterface<bool> {
- public:
- ResultSelectionTest() = default;
- ResultSelectionTest(const ResultSelectionTest&) = delete;
- ResultSelectionTest& operator=(const ResultSelectionTest&) = delete;
- ~ResultSelectionTest() override = default;
- void SetUp() override {
- if (testing::UnitTest::GetInstance()->current_test_info()->value_param()) {
- // Setup right to left environment if necessary.
- is_rtl_ = GetParam();
- if (is_rtl_)
- base::i18n::SetICUDefaultLocale("he");
- }
- if (!is_rtl_) {
- // Reset RTL if not needed.
- base::i18n::SetICUDefaultLocale("en");
- }
- app_list_test_delegate_ = std::make_unique<test::AppListTestViewDelegate>();
- result_selection_controller_ = std::make_unique<ResultSelectionController>(
- &containers_,
- base::BindRepeating(&ResultSelectionTest::OnSelectionChanged,
- base::Unretained(this)));
- testing::Test::SetUp();
- }
- void TearDown() override { g_last_created_result_index = -1; }
- protected:
- std::unique_ptr<TestContainer> CreateTestContainer(bool horizontal,
- int results) {
- return std::make_unique<TestContainer>(
- TestContainerParams(horizontal, results),
- app_list_test_delegate_.get());
- }
- std::vector<std::unique_ptr<SearchResultContainerView>> CreateContainerVector(
- int container_count,
- const TestContainerParams& container_params) {
- std::vector<std::unique_ptr<SearchResultContainerView>> containers;
- for (int i = 0; i < container_count; i++) {
- containers.emplace_back(std::make_unique<TestContainer>(
- container_params, app_list_test_delegate_.get()));
- }
- return containers;
- }
- std::vector<ResultLocationDetails> CreateLocationVector(
- int results,
- bool horizontal,
- int container_count = 1,
- int container_index = 0) {
- std::vector<ResultLocationDetails> locations;
- for (int i = 0; i < results; i++) {
- locations.emplace_back(ResultLocationDetails(
- container_index /*container_index*/,
- container_count /*container_count*/, i /*result_index*/,
- results /*result_count*/, horizontal /*container_is_horizontal*/));
- }
- return locations;
- }
- ResultLocationDetails GetCurrentLocation() const {
- return *result_selection_controller_->selected_location_details();
- }
- TestResultView* GetCurrentSelection() {
- ResultLocationDetails location = GetCurrentLocation();
- SearchResultBaseView* view =
- containers_[location.container_index]->GetResultViewAt(
- location.result_index);
- return static_cast<TestResultView*>(view);
- }
- // Asserts that currently selected result has a result action selected.
- // |action_index| - the index of the selected result action.
- testing::AssertionResult CurrentResultActionSelected(int action_index) {
- TestResultViewWithActions* view =
- GetCurrentSelection()->AsResultViewWithActions();
- if (!view) {
- return testing::AssertionFailure()
- << "Selected view with no action support";
- }
- if (!view->selected())
- return testing::AssertionFailure() << "View not selected";
- if (!view->GetActionsView()->HasSelectedAction())
- return testing::AssertionFailure() << "No selected action";
- int selected_action = view->GetActionsView()->GetSelectedAction();
- if (selected_action != action_index) {
- return testing::AssertionFailure()
- << "Wrong selected action " << selected_action;
- }
- return testing::AssertionSuccess();
- }
- // Asserts that the currently selected result has no selected result actions.
- testing::AssertionResult CurrentResultActionNotSelected() {
- TestResultViewWithActions* view =
- GetCurrentSelection()->AsResultViewWithActions();
- if (!view) {
- return testing::AssertionFailure()
- << "Selected view with no action support";
- }
- if (!view->selected())
- return testing::AssertionFailure() << "View not selected";
- int selected_action = view->GetActionsView()->GetSelectedAction();
- if (view->GetActionsView()->HasSelectedAction()) {
- return testing::AssertionFailure()
- << "Selected action found " << selected_action;
- }
- if (selected_action != -1) {
- return testing::AssertionFailure()
- << "Expected selected action index -1; found " << selected_action;
- }
- return testing::AssertionSuccess();
- }
- void SetContainers(
- const std::vector<std::unique_ptr<SearchResultContainerView>>&
- containers) {
- containers_.clear();
- for (auto& container : containers) {
- containers_.emplace_back(container.get());
- }
- }
- void TestSingleAxisTraversal(ui::KeyEvent* forward, ui::KeyEvent* backward) {
- const bool horizontal =
- result_selection_controller_->selected_location_details()
- ->container_is_horizontal;
- std::vector<ResultLocationDetails> locations =
- CreateLocationVector(4, horizontal);
- // These are divided to give as much detail as possible for a test failure.
- TestSingleAxisForward(forward, locations);
- if (horizontal) {
- TestSingleAxisLoop(forward, locations);
- TestSingleAxisLoopBack(backward, locations);
- } else {
- TestSingleAxisLoopRejected(forward, locations);
- }
- TestSingleAxisBackward(backward, locations);
- if (!horizontal) {
- TestSingleAxisLoopBackRejected(backward, locations);
- }
- }
- void TestSingleAxisForward(
- ui::KeyEvent* forward,
- const std::vector<ResultLocationDetails>& locations) {
- // Starts at the beginning
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[0]);
- for (size_t i = 1; i < locations.size(); i++) {
- ASSERT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*forward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[i]);
- }
- // Expect steady traversal to the end
- }
- void TestSingleAxisLoop(ui::KeyEvent* forward,
- const std::vector<ResultLocationDetails>& locations) {
- // Starts at the end
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[3]);
- // Expect loop back to first result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*forward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[0]);
- }
- void TestSingleAxisLoopBack(
- ui::KeyEvent* backward,
- const std::vector<ResultLocationDetails>& locations) {
- // Starts at the first
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[0]);
- // Expect loop back to last result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*backward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[3]);
- }
- void TestSingleAxisLoopRejected(
- ui::KeyEvent* forward,
- const std::vector<ResultLocationDetails>& locations) {
- // Starts at the end
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[3]);
- // Expect no change in location.
- ASSERT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(*forward));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[3]);
- }
- void TestSingleAxisLoopBackRejected(
- ui::KeyEvent* backward,
- const std::vector<ResultLocationDetails>& locations) {
- // Starts at the first
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[0]);
- // Expect no change in location.
- ASSERT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(*backward));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[0]);
- }
- void TestSingleAxisBackward(
- ui::KeyEvent* backward,
- const std::vector<ResultLocationDetails>& locations) {
- ASSERT_FALSE(locations.empty());
- const size_t last_index = locations.size() - 1;
- // Test reverse direction from last result
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[last_index]);
- for (size_t i = last_index; i > 0; i--) {
- ASSERT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*backward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(*result_selection_controller_->selected_location_details(),
- locations[i - 1]);
- }
- }
- void TestMultiAxisTraversal(bool tab) {
- ui::KeyEvent* forward;
- ui::KeyEvent* backward;
- ui::KeyEvent* vertical_forward;
- ui::KeyEvent* vertical_backward;
- if (tab) {
- // Set up for tab traversal
- forward = vertical_forward = &tab_key_;
- backward = vertical_backward = &shift_tab_key_;
- } else {
- // Set up for arrow key traversal
- forward = is_rtl_ ? &left_arrow_ : &right_arrow_;
- backward = is_rtl_ ? &right_arrow_ : &left_arrow_;
- vertical_forward = &down_arrow_;
- vertical_backward = &up_arrow_;
- }
- int num_containers = containers_.size();
- for (int i = 0; i < num_containers; i++) {
- const bool horizontal =
- result_selection_controller_->selected_location_details()
- ->container_is_horizontal;
- std::vector<ResultLocationDetails> locations =
- CreateLocationVector(4, horizontal, num_containers, i);
- if (horizontal && !tab) {
- TestSingleAxisForward(forward, locations);
- TestSingleAxisLoop(forward, locations);
- TestSingleAxisLoopBack(backward, locations);
- TestSingleAxisBackward(backward, locations);
- TestSingleAxisLoopBack(backward, locations);
- // End on the last result.
- } else {
- // Tab and Vertical traversal are identical
- TestSingleAxisForward(vertical_forward, locations);
- TestSingleAxisBackward(vertical_backward, locations);
- TestSingleAxisForward(vertical_forward, locations);
- // End on the last result.
- }
- // Change Containers, if not the last container.
- ASSERT_EQ(
- i == num_containers - 1
- ? ResultSelectionController::MoveResult::kSelectionCycleRejected
- : ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*vertical_forward));
- EXPECT_EQ(i == num_containers - 1 ? 0 : 1,
- GetAndResetSelectionChangeCount());
- }
- }
- // Runs test for TAB traversal over containers that contain results with extra
- // result actions.
- void TestTabTraversalWithResultActions(bool horizontal_containers) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(horizontal_containers, kResultsPerContainer,
- kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [horizontal_containers](int container_index,
- int result_index) {
- return ResultLocationDetails(container_index, kContainerCount,
- result_index, kResultsPerContainer,
- horizontal_containers);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB - the result should remain the same, but the selected action is
- // expected to change.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // TAB - the result should remain the same, but the selected action is
- // expected to change.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(1));
- // TAB - move to the next result.
- TestResultView* previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // Shift-TAB - move back to the previous result, and expect the last action
- // to be selected.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(1));
- // TAB - move back to next result.
- previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // TAB - stay at the same result, but select next action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // Shift-TAB - same result, but deselects actions.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB - reselect the first action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // TAB - select the next action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(1));
- // TAB - select a result in the next container.
- previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(1, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // Shift-TAB - move to previous result/action.
- previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(1));
- EXPECT_FALSE(previous_result->selected());
- // Shift-TAB - move to previous action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- }
- // Tests calling MoveSelection when none of the results are selected. The
- // effect should be the same as resetting selection.
- void TestMoveNullSelection(const ui::KeyEvent& key_event,
- bool expect_reverse,
- bool expect_action_selected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 1;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer,
- kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount,
- result_index, kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(key_event));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- if (expect_reverse) {
- ASSERT_EQ(create_test_location(1, 1), GetCurrentLocation());
- } else {
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- }
- if (expect_action_selected) {
- EXPECT_TRUE(CurrentResultActionSelected(0));
- } else {
- EXPECT_TRUE(CurrentResultActionNotSelected());
- }
- }
- std::unique_ptr<test::AppListTestViewDelegate> app_list_test_delegate_;
- std::unique_ptr<ResultSelectionController> result_selection_controller_;
- std::vector<SearchResultContainerView*> containers_;
- // Set up key events for test. These will never be marked as 'handled'.
- ui::KeyEvent down_arrow_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_DOWN, ui::EF_NONE);
- ui::KeyEvent up_arrow_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_UP, ui::EF_NONE);
- ui::KeyEvent left_arrow_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_LEFT, ui::EF_NONE);
- ui::KeyEvent right_arrow_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_RIGHT, ui::EF_NONE);
- ui::KeyEvent tab_key_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_TAB, ui::EF_NONE);
- ui::KeyEvent shift_tab_key_ =
- ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_TAB, ui::EF_SHIFT_DOWN);
- int GetAndResetSelectionChangeCount() {
- const int result = selection_change_count_;
- selection_change_count_ = 0;
- return result;
- }
- void OnSelectionChanged() { selection_change_count_++; }
- bool is_rtl_ = false;
- int selection_change_count_ = 0;
- };
- INSTANTIATE_TEST_SUITE_P(RTL, ResultSelectionTest, testing::Bool());
- } // namespace
- TEST_F(ResultSelectionTest, VerticalTraversalOneContainerArrowKeys) {
- std::unique_ptr<TestContainer> vertical_container =
- CreateTestContainer(false, 4);
- // The vertical container is not horizontally traversable
- ASSERT_FALSE(vertical_container->horizontally_traversable());
- containers_.clear();
- containers_.emplace_back(vertical_container.get());
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestSingleAxisTraversal(&down_arrow_, &up_arrow_);
- }
- TEST_F(ResultSelectionTest, VerticalTraversalOneContainerTabKey) {
- std::unique_ptr<TestContainer> vertical_container =
- CreateTestContainer(false, 4);
- // The vertical container is not horizontally traversable
- ASSERT_FALSE(vertical_container->horizontally_traversable());
- containers_.clear();
- containers_.emplace_back(vertical_container.get());
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestSingleAxisTraversal(&tab_key_, &shift_tab_key_);
- }
- TEST_P(ResultSelectionTest, HorizontalTraversalOneContainerArrowKeys) {
- ui::KeyEvent* forward = is_rtl_ ? &left_arrow_ : &right_arrow_;
- ui::KeyEvent* backward = is_rtl_ ? &right_arrow_ : &left_arrow_;
- std::unique_ptr<TestContainer> horizontal_container =
- CreateTestContainer(true, 4);
- // The horizontal container is horizontally traversable
- ASSERT_TRUE(horizontal_container->horizontally_traversable());
- containers_.clear();
- containers_.emplace_back(horizontal_container.get());
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestSingleAxisTraversal(forward, backward);
- }
- TEST_P(ResultSelectionTest, HorizontalVerticalArrowKeys) {
- std::unique_ptr<TestContainer> horizontal_container =
- CreateTestContainer(true, 4);
- std::unique_ptr<TestContainer> vertical_container =
- CreateTestContainer(false, 4);
- containers_.clear();
- containers_.emplace_back(horizontal_container.get());
- containers_.emplace_back(vertical_container.get());
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, HorizontalVerticalTab) {
- std::unique_ptr<TestContainer> horizontal_container =
- CreateTestContainer(true, 4);
- std::unique_ptr<TestContainer> vertical_container =
- CreateTestContainer(false, 4);
- containers_.clear();
- containers_.emplace_back(horizontal_container.get());
- containers_.emplace_back(vertical_container.get());
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(true);
- }
- TEST_F(ResultSelectionTest, TestVerticalStackArrows) {
- std::vector<std::unique_ptr<SearchResultContainerView>> vertical_containers =
- CreateContainerVector(4, TestContainerParams(false, 4));
- SetContainers(vertical_containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestVerticalStackTab) {
- std::vector<std::unique_ptr<SearchResultContainerView>> vertical_containers =
- CreateContainerVector(4, TestContainerParams(false, 4));
- SetContainers(vertical_containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(true);
- }
- TEST_P(ResultSelectionTest, TestHorizontalStackArrows) {
- std::vector<std::unique_ptr<SearchResultContainerView>>
- horizontal_containers =
- CreateContainerVector(4, TestContainerParams(true, 4));
- SetContainers(horizontal_containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestHorizontalStackTab) {
- std::vector<std::unique_ptr<SearchResultContainerView>>
- horizontal_containers =
- CreateContainerVector(4, TestContainerParams(true, 4));
- SetContainers(horizontal_containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(true);
- }
- TEST_P(ResultSelectionTest, TestHorizontalStackWithResultActionsArrows) {
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(4, TestContainerParams(true, 4, 2));
- SetContainers(containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestVerticalStackWithResultActionsArrows) {
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(4, TestContainerParams(false, 4, 2));
- SetContainers(containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestVerticalStackWithEmptyResultActionsTab) {
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(4, TestContainerParams(false, 4, 0));
- SetContainers(containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestHorizontalStackWithEmptyResultActionsTab) {
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(4, TestContainerParams(false, 4, 0));
- SetContainers(containers);
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- TestMultiAxisTraversal(false);
- }
- TEST_F(ResultSelectionTest, TestHorizontalStackWithResultActionsTab) {
- TestTabTraversalWithResultActions(true /*horizontal_container*/);
- }
- TEST_F(ResultSelectionTest, TestVerticalStackWithResultActionsTab) {
- TestTabTraversalWithResultActions(false /*horizontal_container*/);
- }
- TEST_F(ResultSelectionTest, TabCycleInContainerWithResultActions) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 1;
- const int kActionsPerResult = 1;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer, false);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // Shift TAB - reject.
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB - the result should remain the same, but the selected action is
- // expected to change.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // TAB - move to the next result, which is in the next container.
- TestResultView* previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(1, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // TAB - next action selected.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(1, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // TAB - rejected, as selection would cycle to the beginning.
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(1, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- }
- TEST_F(ResultSelectionTest, TabCycleInContainerSingleResult) {
- const int kContainerCount = 1;
- const int kResultsPerContainer = 1;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer, false);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- // Shift TAB - reject going to the last result (even though it's the same as
- // the first result).
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- // TAB - reject goting to the first result (event though it's the same as the
- // last result).
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- }
- TEST_F(ResultSelectionTest, TabCycleInContainerSingleResultWithActionUsingTab) {
- const int kContainerCount = 1;
- const int kResultsPerContainer = 1;
- const int kActionsPerResult = 1;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer, false);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // Shift TAB - reject going to the last result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB - the result should remain the same, but the selected action is
- // expected to change.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // TAB - rejected, as selection would cycle to the beginning.
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- }
- TEST_F(ResultSelectionTest,
- TabCycleInContainerSingleResultWithActionUsingUpDown) {
- const int kContainerCount = 1;
- const int kResultsPerContainer = 1;
- const int kActionsPerResult = 1;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer, false);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // UP - reject going to the last result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(up_arrow_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // DOWN - rejected, as selection would cycle to the beginning (even though the
- // first element is the same as the last).
- EXPECT_EQ(ResultSelectionController::MoveResult::kSelectionCycleRejected,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- }
- TEST_P(ResultSelectionTest,
- TestHorizontalStackWithResultActions_ForwardBackWithActionSelected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(true, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- true /*container_is_horizontal*/);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ui::KeyEvent* forward = is_rtl_ ? &left_arrow_ : &right_arrow_;
- ui::KeyEvent* backward = is_rtl_ ? &right_arrow_ : &left_arrow_;
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // Forward selects the next result.
- TestResultView* previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*forward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // Backward selects the previous result.
- previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(*backward));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- }
- TEST_F(ResultSelectionTest,
- TestVerticalStackWithResultActions_UpDownWithActionSelected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // DOWN selects the next result.
- TestResultView* previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // UP selects the previous result.
- previous_result = GetCurrentSelection();
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(up_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- EXPECT_FALSE(previous_result->selected());
- }
- TEST_F(ResultSelectionTest, ResetWhileFirstResultActionSelected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // Reset selection - reset selects the new first result, i.e. the same result
- // as before reset. The selected action should remain the same.
- TestResultView* pre_reset_selection = GetCurrentSelection();
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(pre_reset_selection, GetCurrentSelection());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- }
- TEST_F(ResultSelectionTest, ResetWhileResultActionSelected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // DOWN to select another result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB to select an action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- // Reset selection.
- TestResultView* pre_reset_selection = GetCurrentSelection();
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(0));
- EXPECT_TRUE(pre_reset_selection->selected());
- }
- TEST_F(ResultSelectionTest, ActionRemovedWhileSelected) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- const int kActionsPerResult = 3;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(
- kContainerCount,
- TestContainerParams(false, kResultsPerContainer, kActionsPerResult));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Initialize the RSC for test.
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // DOWN to select another result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // TAB to select the last action.
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(tab_key_));
- EXPECT_EQ(3, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(2));
- TestResultView* selected_view = GetCurrentSelection();
- ASSERT_TRUE(selected_view);
- ASSERT_TRUE(selected_view->AsResultViewWithActions());
- // Remove two trailing actions - the result action is de-selected.
- selected_view->AsResultViewWithActions()->GetActionsView()->SetActions(
- std::vector<SearchResult::Action>(
- 1, SearchResult::Action(ash::SearchResultActionType::kRemove,
- std::u16string(), false)));
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionNotSelected());
- // Shift-TAB move selection to the previous result.
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(shift_tab_key_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(CurrentResultActionSelected(2));
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionTab) {
- TestMoveNullSelection(tab_key_, false /*reverse*/,
- false /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionShiftTab) {
- TestMoveNullSelection(shift_tab_key_, true /*reverse*/,
- true /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionDown) {
- TestMoveNullSelection(down_arrow_, false /*reverse*/,
- false /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionUp) {
- TestMoveNullSelection(up_arrow_, true /*reverse*/,
- false /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionForward) {
- TestMoveNullSelection(right_arrow_, false /*reverse*/,
- false /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionBack) {
- TestMoveNullSelection(left_arrow_, false /*reverse*/,
- false /*expect_action_selected*/);
- }
- TEST_F(ResultSelectionTest, ResetSelectionWithSelectionChangesBlocked) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Set up non default selection,
- result_selection_controller_->ResetSelection(nullptr, false);
- result_selection_controller_->MoveSelection(down_arrow_);
- EXPECT_EQ(2, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- // Test that calling reset selection while selection changes are blocked does
- // not change the selected result.
- result_selection_controller_->set_block_selection_changes(true);
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- // Reset should be enabled once selection changes are unblocked.
- result_selection_controller_->set_block_selection_changes(false);
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- }
- TEST_F(ResultSelectionTest, InitialResetSelectionWithSelectionChangesBlocked) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer));
- SetContainers(containers);
- // Test that calling reset selection while selection changes are blocked does
- // not set the selected result.
- result_selection_controller_->set_block_selection_changes(true);
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- EXPECT_FALSE(result_selection_controller_->selected_result());
- EXPECT_FALSE(result_selection_controller_->selected_location_details());
- // Reset should be enabled once selection changes are unblocked.
- result_selection_controller_->set_block_selection_changes(false);
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- EXPECT_TRUE(result_selection_controller_->selected_location_details());
- }
- TEST_F(ResultSelectionTest, MoveSelectionWithSelectionChangesBlocked) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- result_selection_controller_->ResetSelection(nullptr, false);
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- // Test that calling move selection while selection chages are blocked does
- // not change the selected result.
- result_selection_controller_->set_block_selection_changes(true);
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- // Move should succeed once selection changes are unblocked.
- result_selection_controller_->set_block_selection_changes(false);
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 1), GetCurrentLocation());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- }
- TEST_F(ResultSelectionTest, MoveNullSelectionWithSelectionChangesBlocked) {
- const int kContainerCount = 2;
- const int kResultsPerContainer = 2;
- std::vector<std::unique_ptr<SearchResultContainerView>> containers =
- CreateContainerVector(kContainerCount,
- TestContainerParams(false, kResultsPerContainer));
- SetContainers(containers);
- auto create_test_location = [](int container_index, int result_index) {
- return ResultLocationDetails(container_index, kContainerCount, result_index,
- kResultsPerContainer,
- false /*container_is_horizontal*/);
- };
- // Test that calling move selection while selection chages are blocked does
- // not change the selected result.
- result_selection_controller_->set_block_selection_changes(true);
- EXPECT_EQ(ResultSelectionController::MoveResult::kNone,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(0, GetAndResetSelectionChangeCount());
- EXPECT_FALSE(result_selection_controller_->selected_result());
- EXPECT_FALSE(result_selection_controller_->selected_location_details());
- // Move should succeed once selection changes are unblocked.
- result_selection_controller_->set_block_selection_changes(false);
- EXPECT_EQ(ResultSelectionController::MoveResult::kResultChanged,
- result_selection_controller_->MoveSelection(down_arrow_));
- EXPECT_EQ(1, GetAndResetSelectionChangeCount());
- ASSERT_EQ(create_test_location(0, 0), GetCurrentLocation());
- EXPECT_TRUE(result_selection_controller_->selected_result());
- }
- } // namespace ash
|