0089-util-grub-install-Fix-NULL-pointer-dereferences.patch 1.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142
  1. From 8b3a95655b4391122e7b0315d8cc6f876caf8183 Mon Sep 17 00:00:00 2001
  2. From: Daniel Kiper <daniel.kiper@oracle.com>
  3. Date: Thu, 25 Feb 2021 18:35:01 +0100
  4. Subject: [PATCH] util/grub-install: Fix NULL pointer dereferences
  5. Two grub_device_open() calls does not have associated NULL checks
  6. for returned values. Fix that and appease the Coverity.
  7. Fixes: CID 314583
  8. Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
  9. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
  10. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
  11. ---
  12. util/grub-install.c | 4 ++++
  13. 1 file changed, 4 insertions(+)
  14. diff --git a/util/grub-install.c b/util/grub-install.c
  15. index a82725f..367350f 100644
  16. --- a/util/grub-install.c
  17. +++ b/util/grub-install.c
  18. @@ -1775,6 +1775,8 @@ main (int argc, char *argv[])
  19. fill_core_services (core_services);
  20. ins_dev = grub_device_open (install_drive);
  21. + if (ins_dev == NULL)
  22. + grub_util_error ("%s", grub_errmsg);
  23. bless (ins_dev, core_services, 0);
  24. @@ -1875,6 +1877,8 @@ main (int argc, char *argv[])
  25. fill_core_services(core_services);
  26. ins_dev = grub_device_open (install_drive);
  27. + if (ins_dev == NULL)
  28. + grub_util_error ("%s", grub_errmsg);
  29. bless (ins_dev, boot_efi, 1);
  30. if (!removable && update_nvram)
  31. --
  32. 2.14.2