0050-net-net-Fix-possible-dereference-to-of-a-NULL-pointe.patch 1.4 KB

12345678910111213141516171819202122232425262728293031323334353637383940
  1. From 03f2515ae0c503406f1a99a2178405049c6555db Mon Sep 17 00:00:00 2001
  2. From: Darren Kenny <darren.kenny@oracle.com>
  3. Date: Fri, 27 Nov 2020 15:10:26 +0000
  4. Subject: [PATCH] net/net: Fix possible dereference to of a NULL pointer
  5. It is always possible that grub_zalloc() could fail, so we should check for
  6. a NULL return. Otherwise we run the risk of dereferencing a NULL pointer.
  7. Fixes: CID 296221
  8. Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
  9. Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
  10. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
  11. ---
  12. grub-core/net/net.c | 9 +++++++--
  13. 1 file changed, 7 insertions(+), 2 deletions(-)
  14. diff --git a/grub-core/net/net.c b/grub-core/net/net.c
  15. index 38f19df..7c2cdf2 100644
  16. --- a/grub-core/net/net.c
  17. +++ b/grub-core/net/net.c
  18. @@ -86,8 +86,13 @@ grub_net_link_layer_add_address (struct grub_net_card *card,
  19. /* Add sender to cache table. */
  20. if (card->link_layer_table == NULL)
  21. - card->link_layer_table = grub_zalloc (LINK_LAYER_CACHE_SIZE
  22. - * sizeof (card->link_layer_table[0]));
  23. + {
  24. + card->link_layer_table = grub_zalloc (LINK_LAYER_CACHE_SIZE
  25. + * sizeof (card->link_layer_table[0]));
  26. + if (card->link_layer_table == NULL)
  27. + return;
  28. + }
  29. +
  30. entry = &(card->link_layer_table[card->new_ll_entry]);
  31. entry->avail = 1;
  32. grub_memcpy (&entry->ll_address, ll, sizeof (entry->ll_address));
  33. --
  34. 2.14.2