Browse Source

Improve GitHub templates

Marcel Stör 7 years ago
parent
commit
eddda24a6f
2 changed files with 4 additions and 5 deletions
  1. 1 1
      .github/ISSUE_TEMPLATE.md
  2. 3 4
      .github/PULL_REQUEST_TEMPLATE.md

+ 1 - 1
.github/ISSUE_TEMPLATE.md

@@ -7,7 +7,7 @@ Use one of the two templates below and delete the rest.
 ### Actual behavior
 
 ### Test code
-Provide a minimal and isolated test which will reproduce the problem.
+Provide a [Minimal, Complete, and Verifiable example](http://stackoverflow.com/help/mcve) which will reproduce the problem.
 ```Lua
 -- add code here
 ```

+ 3 - 4
.github/PULL_REQUEST_TEMPLATE.md

@@ -2,10 +2,9 @@ Fixes #\<GitHub-issue-number\>.
 
 Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.
 
-- [ ] This PR is compliant with the [contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) (if not, please describe why).
+- [ ] This PR is for the `dev` branch rather than for `master`.
+- [ ] This PR is compliant with the [other contributing guidelines](https://github.com/nodemcu/nodemcu-firmware/blob/dev/CONTRIBUTING.md) as well (if not, please describe why).
 - [ ] I have thoroughly tested my contribution.
 - [ ] The code changes are reflected in the documentation at `docs/en/*`.
 
-\<Description of and rational behind this PR\>
-
-Committers supporting this PR: leave blank
+\<Description of and rational behind this PR\>