Ticket #44 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Make the examples actually compile...

Reported by: debrouxl Owned by:
Priority: blocker Milestone: Version 1.00
Component: project Version: 0.96
Keywords: Cc: kevin.kofler@…

Description

Besides ticket #43, which is not a failure per se, another problem shows up when building the examples: the "Dialog Struct" example has been failing to compile since

Author: kevinkofler
Date:   Wed Jul 27 19:15:50 2005 +0000

    Fix size allocated for strings in SIZED_DIALOG (thanks to Sébastien Leurent for the fix).

What's more, I find it weird that tprbuilder silently swallows any nonzero exit code returned by system() or win32_system(): it just does exit(0); in that case. In other words, tprbuilder may exit with 0 exit code even if the build failed, which makes it unusable for automated regression testing.
In a way, this ticket is also related to ticket #29.

Two patches will follow, I'd already have committed them if I remembered my password...

Attachments

0001-tprbuilder-return-a-nonzero-exit-code-if-a-command-r.patch Download (1.5 KB) - added by debrouxl 3 years ago.
Patch to make tprbuilder exit with failure if an external command it launched returned failure
0002-Fix-an-example-whose-build-has-failed-since-Kevin-mo.patch Download (11.0 KB) - added by debrouxl 3 years ago.
Patch that fixes the "Dialog Struct" example and adds a script for regression tests

Change History

Changed 3 years ago by debrouxl

Patch to make tprbuilder exit with failure if an external command it launched returned failure

Changed 3 years ago by debrouxl

Patch that fixes the "Dialog Struct" example and adds a script for regression tests

comment:1 Changed 3 years ago by debrouxl

  • Status changed from new to closed
  • Resolution set to fixed

Patches committed as r1323 and r1324.

Note: See TracTickets for help on using tickets.